activemerchant 1.79.2 → 1.80.0

data/lib/active_merchant/billing/gateways/merchant_ware.rb

@@ -11,25 +11,25 @@ module ActiveMerchant #:nodoc:
       self.homepage_url = 'http://merchantwarehouse.com/merchantware'
       self.display_name = 'MerchantWARE'
 
-      ENV_NAMESPACES = { "xmlns:xsi"  => "http://www.w3.org/2001/XMLSchema-instance",
-                         "xmlns:xsd"  => "http://www.w3.org/2001/XMLSchema",
-                         "xmlns:env" => "http://schemas.xmlsoap.org/soap/envelope/"
+      ENV_NAMESPACES = { 'xmlns:xsi'  => 'http://www.w3.org/2001/XMLSchema-instance',
+                         'xmlns:xsd'  => 'http://www.w3.org/2001/XMLSchema',
+                         'xmlns:env' => 'http://schemas.xmlsoap.org/soap/envelope/'
                        }
-      ENV_NAMESPACES_V4 = { "xmlns:xsi"  => "http://www.w3.org/2001/XMLSchema-instance",
-                            "xmlns:xsd"  => "http://www.w3.org/2001/XMLSchema",
-                            "xmlns:soap" => "http://schemas.xmlsoap.org/soap/envelope/"
+      ENV_NAMESPACES_V4 = { 'xmlns:xsi'  => 'http://www.w3.org/2001/XMLSchema-instance',
+                            'xmlns:xsd'  => 'http://www.w3.org/2001/XMLSchema',
+                            'xmlns:soap' => 'http://schemas.xmlsoap.org/soap/envelope/'
                           }
 
-      TX_NAMESPACE = "http://merchantwarehouse.com/MerchantWARE/Client/TransactionRetail"
-      TX_NAMESPACE_V4 = "http://schemas.merchantwarehouse.com/merchantware/40/Credit/"
+      TX_NAMESPACE = 'http://merchantwarehouse.com/MerchantWARE/Client/TransactionRetail'
+      TX_NAMESPACE_V4 = 'http://schemas.merchantwarehouse.com/merchantware/40/Credit/'
 
       ACTIONS = {
-        :purchase  => "IssueKeyedSale",
-        :authorize => "IssueKeyedPreAuth",
-        :capture   => "IssuePostAuth",
-        :void      => "VoidPreAuthorization",
-        :credit    => "IssueKeyedRefund",
-        :reference_credit => "IssueRefundByReference"
+        :purchase  => 'IssueKeyedSale',
+        :authorize => 'IssueKeyedPreAuth',
+        :capture   => 'IssuePostAuth',
+        :void      => 'VoidPreAuthorization',
+        :credit    => 'IssueKeyedRefund',
+        :reference_credit => 'IssueRefundByReference'
       }
 
       # Creates a new MerchantWareGateway
@@ -121,9 +121,9 @@ module ActiveMerchant #:nodoc:
       def soap_request(action)
         xml = Builder::XmlMarkup.new :indent => 2
         xml.instruct!
-        xml.tag! "env:Envelope", ENV_NAMESPACES do
-          xml.tag! "env:Body" do
-            xml.tag! ACTIONS[action], "xmlns" => TX_NAMESPACE do
+        xml.tag! 'env:Envelope', ENV_NAMESPACES do
+          xml.tag! 'env:Body' do
+            xml.tag! ACTIONS[action], 'xmlns' => TX_NAMESPACE do
               add_credentials(xml)
               yield xml
             end
@@ -135,12 +135,12 @@ module ActiveMerchant #:nodoc:
       def v4_soap_request(action)
         xml = Builder::XmlMarkup.new :indent => 2
         xml.instruct!
-        xml.tag! "soap:Envelope", ENV_NAMESPACES_V4 do
-          xml.tag! "soap:Body" do
-            xml.tag! ACTIONS[:void], "xmlns" => TX_NAMESPACE_V4 do
-              xml.tag! "merchantName", @options[:name]
-              xml.tag! "merchantSiteId", @options[:login]
-              xml.tag! "merchantKey", @options[:password]
+        xml.tag! 'soap:Envelope', ENV_NAMESPACES_V4 do
+          xml.tag! 'soap:Body' do
+            xml.tag! ACTIONS[:void], 'xmlns' => TX_NAMESPACE_V4 do
+              xml.tag! 'merchantName', @options[:name]
+              xml.tag! 'merchantSiteId', @options[:login]
+              xml.tag! 'merchantKey', @options[:password]
               yield xml
             end
           end
@@ -175,7 +175,7 @@ module ActiveMerchant #:nodoc:
         request = soap_request(:reference_credit) do |xml|
           add_reference(xml, reference)
           add_invoice(xml, options)
-          add_amount(xml, money, "strOverrideAmount")
+          add_amount(xml, money, 'strOverrideAmount')
         end
 
         commit(:reference_credit, request)
@@ -194,47 +194,47 @@ module ActiveMerchant #:nodoc:
       end
 
       def add_credentials(xml)
-        xml.tag! "strSiteId", @options[:login]
-        xml.tag! "strKey", @options[:password]
-        xml.tag! "strName", @options[:name]
+        xml.tag! 'strSiteId', @options[:login]
+        xml.tag! 'strKey', @options[:password]
+        xml.tag! 'strName', @options[:name]
       end
 
       def add_invoice(xml, options)
-        xml.tag! "strOrderNumber", options[:order_id].to_s.gsub(/[^\w]/, '').slice(0, 25)
+        xml.tag! 'strOrderNumber', options[:order_id].to_s.gsub(/[^\w]/, '').slice(0, 25)
       end
 
-      def add_amount(xml, money, tag = "strAmount")
+      def add_amount(xml, money, tag = 'strAmount')
         xml.tag! tag, amount(money)
       end
 
       def add_reference(xml, reference)
-        xml.tag! "strReferenceCode", reference
+        xml.tag! 'strReferenceCode', reference
       end
 
       def add_reference_token(xml, reference)
-        xml.tag! "token", reference
+        xml.tag! 'token', reference
       end
 
       def add_address(xml, options)
         if address = options[:billing_address] || options[:address]
-          xml.tag! "strAVSStreetAddress", address[:address1]
-          xml.tag! "strAVSZipCode", address[:zip]
+          xml.tag! 'strAVSStreetAddress', address[:address1]
+          xml.tag! 'strAVSZipCode', address[:zip]
         end
       end
 
       def add_credit_card(xml, credit_card)
         if credit_card.respond_to?(:track_data) && credit_card.track_data.present?
-          xml.tag! "trackData", credit_card.track_data
+          xml.tag! 'trackData', credit_card.track_data
         else
-         xml.tag! "strPAN", credit_card.number
-         xml.tag! "strExpDate", expdate(credit_card)
-         xml.tag! "strCardHolder", credit_card.name
-         xml.tag! "strCVCode", credit_card.verification_value if credit_card.verification_value?
+         xml.tag! 'strPAN', credit_card.number
+         xml.tag! 'strExpDate', expdate(credit_card)
+         xml.tag! 'strCardHolder', credit_card.name
+         xml.tag! 'strCVCode', credit_card.verification_value if credit_card.verification_value?
         end
       end
 
       def split_reference(reference)
-        reference.to_s.split(";")
+        reference.to_s.split(';')
       end
 
       def parse(action, data)
@@ -247,10 +247,10 @@ module ActiveMerchant #:nodoc:
           response[element.name] = element.text
         end
 
-        status, code, message = response["ApprovalStatus"].split(";")
+        status, code, message = response['ApprovalStatus'].split(';')
         response[:status] = status
 
-        if response[:success] = status == "APPROVED"
+        if response[:success] = status == 'APPROVED'
           response[:message] = status
         else
           response[:message] = message
@@ -268,17 +268,17 @@ module ActiveMerchant #:nodoc:
 
         document = REXML::Document.new(http_response.body)
 
-        node     = REXML::XPath.first(document, "//soap:Fault")
+        node     = REXML::XPath.first(document, '//soap:Fault')
 
         node.elements.each do |element|
           response[element.name] = element.text
         end
 
-        response[:message] = response["faultstring"].to_s.gsub("\n", " ")
+        response[:message] = response['faultstring'].to_s.gsub("\n", ' ')
         response
       rescue REXML::ParseException
         response[:http_body]        = http_response.body
-        response[:message]          = "Failed to parse the failed response"
+        response[:message]          = 'Failed to parse the failed response'
         response
       end
 
@@ -293,8 +293,8 @@ module ActiveMerchant #:nodoc:
       def commit(action, request, v4 = false)
         begin
           data = ssl_post(url(v4), request,
-                   "Content-Type" => 'text/xml; charset=utf-8',
-                   "SOAPAction"   => soap_action(action, v4)
+                   'Content-Type' => 'text/xml; charset=utf-8',
+                   'SOAPAction'   => soap_action(action, v4)
                  )
           response = parse(action, data)
         rescue ActiveMerchant::ResponseError => e
@@ -304,14 +304,14 @@ module ActiveMerchant #:nodoc:
         Response.new(response[:success], response[:message], response,
           :test => test?,
           :authorization => authorization_from(response),
-          :avs_result => { :code => response["AVSResponse"] },
-          :cvv_result => response["CVResponse"]
+          :avs_result => { :code => response['AVSResponse'] },
+          :cvv_result => response['CVResponse']
         )
       end
 
       def authorization_from(response)
         if response[:success]
-          [ response["ReferenceID"], response["OrderNumber"] ].join(";")
+          [ response['ReferenceID'], response['OrderNumber'] ].join(';')
         end
       end
     end

data/lib/active_merchant/billing/gateways/merchant_ware_version_four.rb

@@ -9,19 +9,19 @@ module ActiveMerchant #:nodoc:
       self.homepage_url = 'http://merchantwarehouse.com/merchantware'
       self.display_name = 'MerchantWARE'
 
-      ENV_NAMESPACES = { "xmlns:xsi"  => "http://www.w3.org/2001/XMLSchema-instance",
-                         "xmlns:xsd"  => "http://www.w3.org/2001/XMLSchema",
-                         "xmlns:soap" => "http://schemas.xmlsoap.org/soap/envelope/" }
+      ENV_NAMESPACES = { 'xmlns:xsi'  => 'http://www.w3.org/2001/XMLSchema-instance',
+                         'xmlns:xsd'  => 'http://www.w3.org/2001/XMLSchema',
+                         'xmlns:soap' => 'http://schemas.xmlsoap.org/soap/envelope/' }
 
-      TX_NAMESPACE = "http://schemas.merchantwarehouse.com/merchantware/40/Credit/"
+      TX_NAMESPACE = 'http://schemas.merchantwarehouse.com/merchantware/40/Credit/'
 
       ACTIONS = {
-        :purchase  => "SaleKeyed",
+        :purchase  => 'SaleKeyed',
         :reference_purchase => 'RepeatSale',
-        :authorize => "PreAuthorizationKeyed",
-        :capture   => "PostAuthorization",
-        :void      => "Void",
-        :refund    => "Refund"
+        :authorize => 'PreAuthorizationKeyed',
+        :capture   => 'PostAuthorization',
+        :void      => 'Void',
+        :refund    => 'Refund'
       }
 
       # Creates a new MerchantWareVersionFourGateway
@@ -102,7 +102,7 @@ module ActiveMerchant #:nodoc:
         request = soap_request(:refund) do |xml|
           add_reference_token(xml, reference)
           add_invoice(xml, options)
-          add_amount(xml, money, "overrideAmount")
+          add_amount(xml, money, 'overrideAmount')
         end
 
         commit(:refund, request)
@@ -131,12 +131,12 @@ module ActiveMerchant #:nodoc:
       def soap_request(action)
         xml = Builder::XmlMarkup.new :indent => 2
         xml.instruct!
-        xml.tag! "soap:Envelope", ENV_NAMESPACES do
-          xml.tag! "soap:Body" do
-            xml.tag! ACTIONS[action], "xmlns" => TX_NAMESPACE do
-              xml.tag! "merchantName", @options[:name]
-              xml.tag! "merchantSiteId", @options[:login]
-              xml.tag! "merchantKey", @options[:password]
+        xml.tag! 'soap:Envelope', ENV_NAMESPACES do
+          xml.tag! 'soap:Body' do
+            xml.tag! ACTIONS[action], 'xmlns' => TX_NAMESPACE do
+              xml.tag! 'merchantName', @options[:name]
+              xml.tag! 'merchantSiteId', @options[:login]
+              xml.tag! 'merchantKey', @options[:password]
               yield xml
             end
           end
@@ -166,21 +166,21 @@ module ActiveMerchant #:nodoc:
       end
 
       def add_invoice(xml, options)
-        xml.tag! "invoiceNumber", truncate(options[:order_id].to_s.gsub(/[^\w]/, ''), 8)
+        xml.tag! 'invoiceNumber', truncate(options[:order_id].to_s.gsub(/[^\w]/, ''), 8)
       end
 
-      def add_amount(xml, money, tag = "amount")
+      def add_amount(xml, money, tag = 'amount')
         xml.tag! tag, amount(money)
       end
 
       def add_reference_token(xml, reference)
-        xml.tag! "token", reference
+        xml.tag! 'token', reference
       end
 
       def add_address(xml, options)
         address = options[:billing_address] || options[:address] || {}
-        xml.tag! "avsStreetAddress", address[:address1]
-        xml.tag! "avsStreetZipCode", address[:zip]
+        xml.tag! 'avsStreetAddress', address[:address1]
+        xml.tag! 'avsStreetZipCode', address[:zip]
       end
 
       def add_payment_source(xml, source)
@@ -192,14 +192,14 @@ module ActiveMerchant #:nodoc:
       end
 
       def add_credit_card(xml, credit_card)
-        xml.tag! "cardNumber", credit_card.number
-        xml.tag! "expirationDate", expdate(credit_card)
-        xml.tag! "cardholder", credit_card.name
-        xml.tag! "cardSecurityCode", credit_card.verification_value if credit_card.verification_value?
+        xml.tag! 'cardNumber', credit_card.number
+        xml.tag! 'expirationDate', expdate(credit_card)
+        xml.tag! 'cardholder', credit_card.name
+        xml.tag! 'cardSecurityCode', credit_card.verification_value if credit_card.verification_value?
       end
 
       def split_reference(reference)
-        reference.to_s.split(";")
+        reference.to_s.split(';')
       end
 
       def parse(action, data)
@@ -212,14 +212,14 @@ module ActiveMerchant #:nodoc:
           response[element.name] = element.text
         end
 
-        if response["ErrorMessage"].present?
-          response[:message] = response["ErrorMessage"]
+        if response['ErrorMessage'].present?
+          response[:message] = response['ErrorMessage']
           response[:success] = false
         else
-          status, code, message = response["ApprovalStatus"].split(";")
+          status, code, message = response['ApprovalStatus'].split(';')
           response[:status] = status
 
-          if response[:success] = status == "APPROVED"
+          if response[:success] = status == 'APPROVED'
             response[:message] = status
           else
             response[:message] = message
@@ -243,11 +243,11 @@ module ActiveMerchant #:nodoc:
           response[element.name] = element.text
         end
 
-        response[:message] = response["ErrorMessage"].to_s.gsub("\n", " ")
+        response[:message] = response['ErrorMessage'].to_s.gsub("\n", ' ')
         response
       rescue REXML::ParseException
         response[:http_body]        = http_response.body
-        response[:message]          = "Failed to parse the failed response"
+        response[:message]          = 'Failed to parse the failed response'
         response
       end
 
@@ -262,8 +262,8 @@ module ActiveMerchant #:nodoc:
       def commit(action, request)
         begin
           data = ssl_post(url, request,
-                   "Content-Type" => 'text/xml; charset=utf-8',
-                   "SOAPAction"   => soap_action(action)
+                   'Content-Type' => 'text/xml; charset=utf-8',
+                   'SOAPAction'   => soap_action(action)
                  )
           response = parse(action, data)
         rescue ActiveMerchant::ResponseError => e
@@ -273,8 +273,8 @@ module ActiveMerchant #:nodoc:
         Response.new(response[:success], response[:message], response,
           :test => test?,
           :authorization => authorization_from(response),
-          :avs_result => { :code => response["AvsResponse"] },
-          :cvv_result => response["CvResponse"]
+          :avs_result => { :code => response['AvsResponse'] },
+          :cvv_result => response['CvResponse']
         )
       end
 

data/lib/active_merchant/billing/gateways/merchant_warrior.rb

@@ -119,7 +119,7 @@ module ActiveMerchant #:nodoc:
       def add_creditcard(post, creditcard)
         post['paymentCardNumber'] = creditcard.number
         post['paymentCardName'] = scrub_name(creditcard.name)
-        post['paymentCardExpiry'] = creditcard.expiry_date.expiration.strftime("%m%y")
+        post['paymentCardExpiry'] = creditcard.expiry_date.expiration.strftime('%m%y')
         post['paymentCardCSC'] = creditcard.verification_value if creditcard.verification_value?
       end
 
@@ -188,14 +188,14 @@ module ActiveMerchant #:nodoc:
 
       def url_for(action, post)
         if token?(post)
-          [(test? ? TOKEN_TEST_URL : TOKEN_LIVE_URL), action].join("/")
+          [(test? ? TOKEN_TEST_URL : TOKEN_LIVE_URL), action].join('/')
         else
           (test? ? POST_TEST_URL : POST_LIVE_URL)
         end
       end
 
       def token?(post)
-        (post["cardID"] || post["cardName"])
+        (post['cardID'] || post['cardName'])
       end
 
       def success?(response)
@@ -203,7 +203,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def post_data(post)
-        post.collect{|k,v| "#{k}=#{CGI.escape(v.to_s)}" }.join("&")
+        post.collect{|k,v| "#{k}=#{CGI.escape(v.to_s)}" }.join('&')
       end
     end
   end

data/lib/active_merchant/billing/gateways/mercury.rb

@@ -87,8 +87,8 @@ module ActiveMerchant #:nodoc:
 
       def scrub(transcript)
         transcript.
-          gsub(%r(&lt;), "<").
-          gsub(%r(&gt;), ">").
+          gsub(%r(&lt;), '<').
+          gsub(%r(&gt;), '>').
           gsub(%r((<pw>).*(</pw>))i, '\1[FILTERED]\2').
           gsub(%r((<AcctNo>)(\d|x)*(</AcctNo>))i, '\1[FILTERED]\3').
           gsub(%r((<CVVData>)\d*(</CVVData>))i, '\1[FILTERED]\2')
@@ -99,15 +99,15 @@ module ActiveMerchant #:nodoc:
       def build_non_authorized_request(action, money, credit_card, options)
         xml = Builder::XmlMarkup.new
 
-        xml.tag! "TStream" do
-          xml.tag! "Transaction" do
+        xml.tag! 'TStream' do
+          xml.tag! 'Transaction' do
             xml.tag! 'TranType', 'Credit'
             xml.tag! 'TranCode', action
             if options[:allow_partial_auth] && (action == 'PreAuth' || action == 'Sale')
-              xml.tag! "PartialAuth", "Allow"
+              xml.tag! 'PartialAuth', 'Allow'
             end
             add_invoice(xml, options[:order_id], nil, options)
-            add_reference(xml, "RecordNumberRequested")
+            add_reference(xml, 'RecordNumberRequested')
             add_customer_data(xml, options)
             add_amount(xml, money, options)
             add_credit_card(xml, credit_card, action)
@@ -121,15 +121,15 @@ module ActiveMerchant #:nodoc:
         xml = Builder::XmlMarkup.new
 
         invoice_no, ref_no, auth_code, acq_ref_data, process_data, record_no, amount = split_authorization(authorization)
-        ref_no = "1" if ref_no.blank?
+        ref_no = '1' if ref_no.blank?
 
-        xml.tag! "TStream" do
-          xml.tag! "Transaction" do
+        xml.tag! 'TStream' do
+          xml.tag! 'Transaction' do
             xml.tag! 'TranType', 'Credit'
             if options[:allow_partial_auth] && (action == 'PreAuthCapture')
-              xml.tag! "PartialAuth", "Allow"
+              xml.tag! 'PartialAuth', 'Allow'
             end
-            xml.tag! 'TranCode', (@use_tokenization ? (action + "ByRecordNo") : action)
+            xml.tag! 'TranCode', (@use_tokenization ? (action + 'ByRecordNo') : action)
             add_invoice(xml, invoice_no, ref_no, options)
             add_reference(xml, record_no)
             add_customer_data(xml, options)
@@ -137,9 +137,9 @@ module ActiveMerchant #:nodoc:
             add_credit_card(xml, credit_card, action) if credit_card
             add_address(xml, options)
             xml.tag! 'TranInfo' do
-              xml.tag! "AuthCode", auth_code
-              xml.tag! "AcqRefData", acq_ref_data
-              xml.tag! "ProcessData", process_data
+              xml.tag! 'AuthCode', auth_code
+              xml.tag! 'AcqRefData', acq_ref_data
+              xml.tag! 'ProcessData', process_data
             end
           end
         end
@@ -149,8 +149,8 @@ module ActiveMerchant #:nodoc:
       def build_card_lookup_request(credit_card, options)
         xml = Builder::XmlMarkup.new
 
-        xml.tag! "TStream" do
-          xml.tag! "Transaction" do
+        xml.tag! 'TStream' do
+          xml.tag! 'Transaction' do
             xml.tag! 'TranType', 'CardLookup'
             xml.tag! 'RecordNo', 'RecordNumberRequested'
             xml.tag! 'Frequency', 'OneTime'
@@ -172,15 +172,15 @@ module ActiveMerchant #:nodoc:
 
       def add_reference(xml, record_no)
         if @use_tokenization
-          xml.tag! "Frequency", "OneTime"
-          xml.tag! "RecordNo", record_no
+          xml.tag! 'Frequency', 'OneTime'
+          xml.tag! 'RecordNo', record_no
         end
       end
 
       def add_customer_data(xml, options)
         xml.tag! 'IpAddress', options[:ip] if options[:ip]
         if options[:customer]
-          xml.tag! "TranInfo" do
+          xml.tag! 'TranInfo' do
             xml.tag! 'CustomerCode', options[:customer]
           end
         end
@@ -255,12 +255,12 @@ module ActiveMerchant #:nodoc:
       def hashify_xml!(xml, response)
         xml = REXML::Document.new(xml)
 
-        xml.elements.each("//CmdResponse/*") do |node|
+        xml.elements.each('//CmdResponse/*') do |node|
           response[node.name.underscore.to_sym] = node.text
         end
 
-        xml.elements.each("//TranResponse/*") do |node|
-          if node.name.to_s == "Amount"
+        xml.elements.each('//TranResponse/*') do |node|
+          if node.name.to_s == 'Amount'
             node.elements.each do |amt|
               response[amt.name.underscore.to_sym] = amt.text
             end
@@ -293,8 +293,8 @@ module ActiveMerchant #:nodoc:
 
       def build_header
         {
-          "SOAPAction" => "http://www.mercurypay.com/CreditTransaction",
-          "Content-Type" => "text/xml; charset=utf-8"
+          'SOAPAction' => 'http://www.mercurypay.com/CreditTransaction',
+          'Content-Type' => 'text/xml; charset=utf-8'
         }
       end
 
@@ -319,7 +319,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def authorization_from(response)
-        dollars, cents = (response[:purchase] || "").split(".").collect{|e| e.to_i}
+        dollars, cents = (response[:purchase] || '').split('.').collect{|e| e.to_i}
         dollars ||= 0
         cents ||= 0
         [
@@ -330,17 +330,17 @@ module ActiveMerchant #:nodoc:
           response[:process_data],
           response[:record_no],
           ((dollars * 100) + cents).to_s
-        ].join(";")
+        ].join(';')
       end
 
       def split_authorization(authorization)
-        invoice_no, ref_no, auth_code, acq_ref_data, process_data, record_no, amount = authorization.split(";")
+        invoice_no, ref_no, auth_code, acq_ref_data, process_data, record_no, amount = authorization.split(';')
         [invoice_no, ref_no, auth_code, acq_ref_data, process_data, record_no, amount]
       end
 
       ENVELOPE_NAMESPACES = {
         'xmlns:xsd' => 'http://www.w3.org/2001/XMLSchema',
-        'xmlns:soap' => "http://schemas.xmlsoap.org/soap/envelope/",
+        'xmlns:soap' => 'http://schemas.xmlsoap.org/soap/envelope/',
         'xmlns:xsi' => 'http://www.w3.org/2001/XMLSchema-instance'
       }