activemerchant 1.79.2 → 1.80.0

data/lib/active_merchant/billing/gateways/linkpoint.rb

@@ -173,11 +173,11 @@ module ActiveMerchant #:nodoc:
         requires!(options, [:periodicity, :bimonthly, :monthly, :biweekly, :weekly, :yearly, :daily], :installments, :order_id )
 
         options.update(
-          :ordertype => "SALE",
-          :action => options[:action] || "SUBMIT",
+          :ordertype => 'SALE',
+          :action => options[:action] || 'SUBMIT',
           :installments => options[:installments] || 12,
-          :startdate => options[:startdate] || "immediate",
-          :periodicity => options[:periodicity].to_s || "monthly",
+          :startdate => options[:startdate] || 'immediate',
+          :periodicity => options[:periodicity].to_s || 'monthly',
           :comments => options[:comments] || nil,
           :threshold => options[:threshold] || 3
         )
@@ -188,7 +188,7 @@ module ActiveMerchant #:nodoc:
       def purchase(money, creditcard, options={})
         requires!(options, :order_id)
         options.update(
-          :ordertype => "SALE"
+          :ordertype => 'SALE'
         )
         commit(money, creditcard, options)
       end
@@ -201,7 +201,7 @@ module ActiveMerchant #:nodoc:
       def authorize(money, creditcard, options = {})
         requires!(options, :order_id)
         options.update(
-          :ordertype => "PREAUTH"
+          :ordertype => 'PREAUTH'
         )
         commit(money, creditcard, options)
       end
@@ -215,7 +215,7 @@ module ActiveMerchant #:nodoc:
       def capture(money, authorization, options = {})
         options.update(
           :order_id => authorization,
-          :ordertype => "POSTAUTH"
+          :ordertype => 'POSTAUTH'
         )
         commit(money, nil, options)
       end
@@ -224,7 +224,7 @@ module ActiveMerchant #:nodoc:
       def void(identification, options = {})
         options.update(
           :order_id => identification,
-          :ordertype => "VOID"
+          :ordertype => 'VOID'
         )
         commit(nil, nil, options)
       end
@@ -236,7 +236,7 @@ module ActiveMerchant #:nodoc:
       #
       def refund(money, identification, options = {})
         options.update(
-          :ordertype => "CREDIT",
+          :ordertype => 'CREDIT',
           :order_id => identification
         )
         commit(money, nil, options)
@@ -272,7 +272,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def successful?(response)
-        response[:approved] == "APPROVED"
+        response[:approved] == 'APPROVED'
       end
 
       # Build the XML file
@@ -280,11 +280,11 @@ module ActiveMerchant #:nodoc:
         params = parameters(money, creditcard, options)
 
         xml = REXML::Document.new
-        order = xml.add_element("order")
+        order = xml.add_element('order')
 
         # Merchant Info
-        merchantinfo = order.add_element("merchantinfo")
-        merchantinfo.add_element("configfile").text = @options[:login]
+        merchantinfo = order.add_element('merchantinfo')
+        merchantinfo.add_element('configfile').text = @options[:login]
 
         # Loop over the params hash to construct the XML string
         for key, value in params
@@ -305,14 +305,14 @@ module ActiveMerchant #:nodoc:
       # adds LinkPoint's Items entity to the XML.  Called from post_data
       def build_items(element, items)
         for item in items
-          item_element = element.add_element("item")
+          item_element = element.add_element('item')
           for key, value in item
             if key == :options
-              options_element = item_element.add_element("options")
+              options_element = item_element.add_element('options')
               for option in value
-                opt_element = options_element.add_element("option")
-                opt_element.add_element("name").text =  option[:name]   unless option[:name].blank?
-                opt_element.add_element("value").text =  option[:value]   unless option[:value].blank?
+                opt_element = options_element.add_element('option')
+                opt_element.add_element('name').text =  option[:name]   unless option[:name].blank?
+                opt_element.add_element('value').text =  option[:value]   unless option[:value].blank?
               end
             else
               item_element.add_element(key.to_s).text =  item[key].to_s unless item[key].blank?
@@ -334,14 +334,14 @@ module ActiveMerchant #:nodoc:
             :chargetotal => amount(money)
           },
           :transactiondetails => {
-            :transactionorigin => options[:transactionorigin] || "ECI",
+            :transactionorigin => options[:transactionorigin] || 'ECI',
             :oid => options[:order_id],
             :ponumber => options[:ponumber],
             :taxexempt => options[:taxexempt],
             :terminaltype => options[:terminaltype],
             :ip => options[:ip],
             :reference_number => options[:reference_number],
-            :recurring => options[:recurring] || "NO",  #DO NOT USE if you are using the periodic billing option.
+            :recurring => options[:recurring] || 'NO',  #DO NOT USE if you are using the periodic billing option.
             :tdate => options[:tdate]
           },
           :orderoptions => {
@@ -433,7 +433,7 @@ module ActiveMerchant #:nodoc:
         # <r_approved>APPROVED</r_approved>
         # <r_avs></r_avs>
 
-        response = {:message => "Global Error Receipt", :complete => false}
+        response = {:message => 'Global Error Receipt', :complete => false}
 
         xml = REXML::Document.new("<response>#{xml}</response>")
         xml.root.elements.each do |node|
@@ -444,7 +444,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def format_creditcard_expiry_year(year)
-        sprintf("%.4i", year)[-2..-1]
+        sprintf('%.4i', year)[-2..-1]
       end
     end
   end

data/lib/active_merchant/billing/gateways/litle.rb

@@ -78,7 +78,7 @@ module ActiveMerchant #:nodoc:
           add_descriptor(doc, options)
           doc.send(refund_type(payment), transaction_attributes(options)) do
             if payment.is_a?(String)
-              transaction_id, kind, _ = split_authorization(payment)
+              transaction_id, _, _ = split_authorization(payment)
               doc.litleTxnId(transaction_id)
               doc.amount(money) if money
             elsif check?(payment)
@@ -192,7 +192,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def refund_type(payment)
-        transaction_id, kind, _ = split_authorization(payment)
+        _, kind, _ = split_authorization(payment)
         if check?(payment) || kind  == 'echeckSales'
           :echeckCredit
         else
@@ -376,7 +376,7 @@ module ActiveMerchant #:nodoc:
 
         if parsed.empty?
           %w(response message).each do |attribute|
-            parsed[attribute.to_sym] = doc.xpath("//litleOnlineResponse").attribute(attribute).value
+            parsed[attribute.to_sym] = doc.xpath('//litleOnlineResponse').attribute(attribute).value
           end
         end
 
@@ -423,7 +423,7 @@ module ActiveMerchant #:nodoc:
         {
           merchantId: @options[:merchant_id],
           version: SCHEMA_VERSION,
-          xmlns: "http://www.litle.com/schema"
+          xmlns: 'http://www.litle.com/schema'
         }
       end
 

data/lib/active_merchant/billing/gateways/mastercard.rb

@@ -59,7 +59,7 @@ module ActiveMerchant
       end
 
       def verify_credentials
-        url = build_url(SecureRandom.uuid, "nonexistent")
+        url = build_url(SecureRandom.uuid, 'nonexistent')
         begin
           ssl_get(url, headers)
         rescue ResponseError => e
@@ -164,7 +164,7 @@ module ActiveMerchant
 
       def add_3dsecure_id(post, options)
         return unless options[:threed_secure_id]
-        post.merge!({"3DSecureId" => options[:threed_secure_id]})
+        post.merge!({'3DSecureId' => options[:threed_secure_id]})
       end
 
       def country_code(country)
@@ -221,7 +221,7 @@ module ActiveMerchant
       end
 
       def success_from(response)
-        response['result'] == "SUCCESS"
+        response['result'] == 'SUCCESS'
       end
 
       def message_from(succeeded, response)

data/lib/active_merchant/billing/gateways/maxipago.rb

@@ -98,7 +98,7 @@ module ActiveMerchant #:nodoc:
 
       def build_xml_request(action)
         builder = Nokogiri::XML::Builder.new(encoding: 'UTF-8')
-        builder.send("transaction-request") do |xml|
+        builder.send('transaction-request') do |xml|
           xml.version '3.1.1.15'
           xml.verification do
             xml.merchantId @options[:login]
@@ -127,7 +127,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def split_authorization(authorization)
-        authorization.split("|")
+        authorization.split('|')
       end
 
       def parse(body)

data/lib/active_merchant/billing/gateways/mercado_pago.rb

@@ -11,8 +11,8 @@ module ActiveMerchant #:nodoc:
       self.money_format = :dollars
 
       CARD_BRAND = {
-        "american_express" => "amex",
-        "diners_club" => "diners"
+        'american_express' => 'amex',
+        'diners_club' => 'diners'
       }
 
       def initialize(options={})
@@ -22,41 +22,41 @@ module ActiveMerchant #:nodoc:
 
       def purchase(money, payment, options={})
         MultiResponse.run do |r|
-          r.process { commit("tokenize", "card_tokens", card_token_request(money, payment, options)) }
+          r.process { commit('tokenize', 'card_tokens', card_token_request(money, payment, options)) }
           options.merge!(card_brand: (CARD_BRAND[payment.brand] || payment.brand))
-          options.merge!(card_token: r.authorization.split("|").first)
-          r.process { commit("purchase", "payments", purchase_request(money, payment, options) ) }
+          options.merge!(card_token: r.authorization.split('|').first)
+          r.process { commit('purchase', 'payments', purchase_request(money, payment, options) ) }
         end
       end
 
       def authorize(money, payment, options={})
         MultiResponse.run do |r|
-          r.process { commit("tokenize", "card_tokens", card_token_request(money, payment, options)) }
+          r.process { commit('tokenize', 'card_tokens', card_token_request(money, payment, options)) }
           options.merge!(card_brand: (CARD_BRAND[payment.brand] || payment.brand))
-          options.merge!(card_token: r.authorization.split("|").first)
-          r.process { commit("authorize", "payments", authorize_request(money, payment, options) ) }
+          options.merge!(card_token: r.authorization.split('|').first)
+          r.process { commit('authorize', 'payments', authorize_request(money, payment, options) ) }
         end
       end
 
       def capture(money, authorization, options={})
         post = {}
-        authorization, _ = authorization.split("|")
+        authorization, _ = authorization.split('|')
         post[:capture] = true
         post[:transaction_amount] = amount(money).to_f
-        commit("capture", "payments/#{authorization}", post)
+        commit('capture', "payments/#{authorization}", post)
       end
 
       def refund(money, authorization, options={})
         post = {}
-        authorization, original_amount = authorization.split("|")
+        authorization, original_amount = authorization.split('|')
         post[:amount] = amount(money).to_f if original_amount && original_amount.to_f > amount(money).to_f
-        commit("refund", "payments/#{authorization}/refunds", post)
+        commit('refund', "payments/#{authorization}/refunds", post)
       end
 
       def void(authorization, options={})
-        authorization, _ = authorization.split("|")
-        post = { status: "cancelled" }
-        commit("void", "payments/#{authorization}", post)
+        authorization, _ = authorization.split('|')
+        post = { status: 'cancelled' }
+        commit('void', "payments/#{authorization}", post)
       end
 
       def verify(credit_card, options={})
@@ -161,10 +161,10 @@ module ActiveMerchant #:nodoc:
       end
 
       def split_street_address(address1)
-        street_number = address1.split(" ").first
+        street_number = address1.split(' ').first
 
-        if street_name = address1.split(" ")[1..-1]
-          street_name = street_name.join(" ")
+        if street_name = address1.split(' ')[1..-1]
+          street_name = street_name.join(' ')
         else
           nil
         end
@@ -190,7 +190,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def commit(action, path, parameters)
-        if ["capture", "void"].include?(action)
+        if ['capture', 'void'].include?(action)
           response = parse(ssl_request(:put, url(path), post_data(parameters), headers))
         else
           response = parse(ssl_post(url(path), post_data(parameters), headers(parameters)))
@@ -207,19 +207,19 @@ module ActiveMerchant #:nodoc:
       end
 
       def success_from(action, response)
-        if action == "refund"
-          response["error"].nil?
+        if action == 'refund'
+          response['error'].nil?
         else
-          ["active", "approved", "authorized", "cancelled", "in_process"].include?(response["status"])
+          ['active', 'approved', 'authorized', 'cancelled', 'in_process'].include?(response['status'])
         end
       end
 
       def message_from(response)
-        (response["status_detail"]) || (response["message"])
+        (response['status_detail']) || (response['message'])
       end
 
       def authorization_from(response, params)
-        [response["id"], params[:transaction_amount]].join("|")
+        [response['id'], params[:transaction_amount]].join('|')
       end
 
       def post_data(parameters = {})
@@ -228,10 +228,10 @@ module ActiveMerchant #:nodoc:
 
       def error_code_from(action, response)
         unless success_from(action, response)
-          if cause = response["cause"]
-            cause.empty? ? nil : cause.first["code"]
+          if cause = response['cause']
+            cause.empty? ? nil : cause.first['code']
           else
-            response["status"]
+            response['status']
           end
         end
       end
@@ -243,7 +243,7 @@ module ActiveMerchant #:nodoc:
 
       def headers(options = {})
         headers = {
-          "Content-Type" => "application/json"
+          'Content-Type' => 'application/json'
         }
         headers['X-Device-Session-ID'] = options[:device_id] if options[:device_id]
         headers

data/lib/active_merchant/billing/gateways/merchant_e_solutions.rb

@@ -162,22 +162,22 @@ module ActiveMerchant #:nodoc:
         response = begin
           parse( ssl_post(url, post_data(action,parameters)) )
         rescue ActiveMerchant::ResponseError => e
-          { "error_code" => "404",  "auth_response_text" => e.to_s }
+          { 'error_code' => '404',  'auth_response_text' => e.to_s }
         end
 
-        Response.new(response["error_code"] == "000", message_from(response), response,
-          :authorization => response["transaction_id"],
+        Response.new(response['error_code'] == '000', message_from(response), response,
+          :authorization => response['transaction_id'],
           :test => test?,
-          :cvv_result => response["cvv2_result"],
-          :avs_result => { :code => response["avs_result"] }
+          :cvv_result => response['cvv2_result'],
+          :avs_result => { :code => response['avs_result'] }
         )
       end
 
       def message_from(response)
-        if response["error_code"] == "000"
-          "This transaction has been approved"
+        if response['error_code'] == '000'
+          'This transaction has been approved'
         else
-          response["auth_response_text"]
+          response['auth_response_text']
         end
       end
 
@@ -187,7 +187,7 @@ module ActiveMerchant #:nodoc:
         post[:profile_key] = @options[:password]
         post[:transaction_type] = action if action
 
-        request = post.merge(parameters).map {|key,value| "#{key}=#{CGI.escape(value.to_s)}"}.join("&")
+        request = post.merge(parameters).map {|key,value| "#{key}=#{CGI.escape(value.to_s)}"}.join('&')
         request
       end
     end

data/lib/active_merchant/billing/gateways/merchant_one.rb

@@ -1,4 +1,4 @@
-require "cgi"
+require 'cgi'
 
 module ActiveMerchant #:nodoc:
   module Billing #:nodoc:
@@ -88,11 +88,11 @@ module ActiveMerchant #:nodoc:
 
       def post_data(action, parameters = {})
         parameters.merge!({:type => action})
-        ret = ""
+        ret = ''
         for key in parameters.keys
           ret += "#{key}=#{CGI.escape(parameters[key].to_s)}"
           if key != parameters.keys.last
-            ret += "&"
+            ret += '&'
           end
         end
         ret.to_s
@@ -101,11 +101,11 @@ module ActiveMerchant #:nodoc:
       def parse(data)
         responses =  CGI.parse(data).inject({}){|h,(k, v)| h[k] = v.first; h}
         Response.new(
-          (responses["response"].to_i == 1),
-          responses["responsetext"],
+          (responses['response'].to_i == 1),
+          responses['responsetext'],
           responses,
           :test => test?,
-          :authorization => responses["transactionid"]
+          :authorization => responses['transactionid']
         )
       end
     end

data/lib/active_merchant/billing/gateways/merchant_partners.rb

@@ -3,13 +3,13 @@ require 'nokogiri'
 module ActiveMerchant #:nodoc:
   module Billing #:nodoc:
     class MerchantPartnersGateway < Gateway
-      self.display_name = "Merchant Partners"
-      self.homepage_url = "http://www.merchantpartners.com/"
+      self.display_name = 'Merchant Partners'
+      self.homepage_url = 'http://www.merchantpartners.com/'
 
-      self.live_url = "https://trans.merchantpartners.com/cgi-bin/ProcessXML.cgi"
+      self.live_url = 'https://trans.merchantpartners.com/cgi-bin/ProcessXML.cgi'
 
-      self.supported_countries = ["US"]
-      self.default_currency = "USD"
+      self.supported_countries = ['US']
+      self.default_currency = 'USD'
       self.money_format = :dollars
       self.supported_cardtypes = [:visa, :master, :american_express, :discover, :diners_club, :jcb]
 
@@ -143,19 +143,19 @@ module ActiveMerchant #:nodoc:
       end
 
       ACTIONS = {
-        purchase: "2",
-        authorize: "1",
-        capture: "3",
-        void: "5",
-        refund: "4",
-        credit: "6",
-        store: "7",
-        stored_purchase: "8",
-        stored_credit: "13"
+        purchase: '2',
+        authorize: '1',
+        capture: '3',
+        void: '5',
+        refund: '4',
+        credit: '6',
+        store: '7',
+        stored_purchase: '8',
+        stored_credit: '13'
       }
 
       STORE_TX_TYPES = {
-        store_only: "3"
+        store_only: '3'
       }
 
       def commit(action, post)
@@ -172,15 +172,15 @@ module ActiveMerchant #:nodoc:
           message_from(succeeded, response_data),
           response_data,
           authorization: authorization_from(post, response_data),
-          :avs_result => AVSResult.new(code: response_data["avs_response"]),
-          :cvv_result => CVVResult.new(response_data["cvv2_response"]),
+          :avs_result => AVSResult.new(code: response_data['avs_response']),
+          :cvv_result => CVVResult.new(response_data['cvv2_response']),
           test: test?
         )
       end
 
       def headers
         {
-          "Content-Type"  => "application/xml"
+          'Content-Type'  => 'application/xml'
         }
       end
 
@@ -188,7 +188,7 @@ module ActiveMerchant #:nodoc:
         Nokogiri::XML::Builder.new(:encoding => 'utf-8') do |xml|
           xml.interface_driver {
             xml.trans_catalog {
-              xml.transaction(name: "creditcard") {
+              xml.transaction(name: 'creditcard') {
                 xml.inputs {
                   post.each do |field, value|
                     xml.send(field, value)
@@ -202,7 +202,7 @@ module ActiveMerchant #:nodoc:
 
       def parse(body)
         response = {}
-        Nokogiri::XML(CGI.unescapeHTML(body)).xpath("//trans_catalog/transaction/outputs").children.each do |node|
+        Nokogiri::XML(CGI.unescapeHTML(body)).xpath('//trans_catalog/transaction/outputs').children.each do |node|
           parse_element(response, node)
         end
         response
@@ -217,11 +217,11 @@ module ActiveMerchant #:nodoc:
       end
 
       def success_from(response)
-        response[:status] == "Approved"
+        response[:status] == 'Approved'
       end
 
       def message_from(succeeded, response)
-        succeeded ? "Succeeded" : error_message_from(response)
+        succeeded ? 'Succeeded' : error_message_from(response)
       end
 
       def authorization_from(request, response)
@@ -231,11 +231,11 @@ module ActiveMerchant #:nodoc:
       end
 
       def split_authorization(authorization)
-        authorization.split("|")
+        authorization.split('|')
       end
 
       def error_message_from(response)
-        if(response[:status] == "Declined")
+        if(response[:status] == 'Declined')
           match = response[:result].match(/DECLINED:\d{10}:(.+):/)
           match[1] if match
         end