activemerchant 1.79.2 → 1.80.0

data/lib/active_merchant/billing/gateways/instapay.rb

@@ -16,8 +16,8 @@ module ActiveMerchant #:nodoc:
       # The name of the gateway
       self.display_name = 'InstaPay'
 
-      SUCCESS         = "Accepted"
-      SUCCESS_MESSAGE = "The transaction has been approved"
+      SUCCESS         = 'Accepted'
+      SUCCESS_MESSAGE = 'The transaction has been approved'
 
       def initialize(options = {})
         requires!(options, :login)
@@ -66,7 +66,7 @@ module ActiveMerchant #:nodoc:
 
       def add_customer_data(post, options)
         post[:ci_email]       = options[:email]
-        post["ci_IP Address"] = options[:ip]
+        post['ci_IP Address'] = options[:ip]
       end
 
       def add_address(post, options)
@@ -154,7 +154,7 @@ module ActiveMerchant #:nodoc:
           post[:merchantpin] = @options[:password]
         end
         post[:action] = action
-        request = post.merge(parameters).collect { |key, value| "#{key}=#{CGI.escape(value.to_s)}" }.join("&")
+        request = post.merge(parameters).collect { |key, value| "#{key}=#{CGI.escape(value.to_s)}" }.join('&')
         request
       end
     end

data/lib/active_merchant/billing/gateways/ipp.rb

@@ -1,4 +1,4 @@
-require "nokogiri"
+require 'nokogiri'
 
 module ActiveMerchant #:nodoc:
   module Billing #:nodoc:
@@ -15,10 +15,10 @@ module ActiveMerchant #:nodoc:
       self.money_format = :cents
 
       STANDARD_ERROR_CODE_MAPPING = {
-        "05" => STANDARD_ERROR_CODE[:card_declined],
-        "06" => STANDARD_ERROR_CODE[:processing_error],
-        "14" => STANDARD_ERROR_CODE[:invalid_number],
-        "54" => STANDARD_ERROR_CODE[:expired_card],
+        '05' => STANDARD_ERROR_CODE[:card_declined],
+        '06' => STANDARD_ERROR_CODE[:processing_error],
+        '14' => STANDARD_ERROR_CODE[:invalid_number],
+        '54' => STANDARD_ERROR_CODE[:expired_card],
       }
 
       def initialize(options={})
@@ -27,11 +27,11 @@ module ActiveMerchant #:nodoc:
       end
 
       def purchase(money, payment, options={})
-        commit("SubmitSinglePayment") do |xml|
+        commit('SubmitSinglePayment') do |xml|
           xml.Transaction do
             xml.CustRef options[:order_id]
             add_amount(xml, money)
-            xml.TrnType "1"
+            xml.TrnType '1'
             add_credit_card(xml, payment)
             add_credentials(xml)
             xml.TrnSource options[:ip]
@@ -40,11 +40,11 @@ module ActiveMerchant #:nodoc:
       end
 
       def authorize(money, payment, options={})
-        commit("SubmitSinglePayment") do |xml|
+        commit('SubmitSinglePayment') do |xml|
           xml.Transaction do
             xml.CustRef options[:order_id]
             add_amount(xml, money)
-            xml.TrnType "2"
+            xml.TrnType '2'
             add_credit_card(xml, payment)
             add_credentials(xml)
             xml.TrnSource options[:ip]
@@ -53,7 +53,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def capture(money, authorization, options={})
-        commit("SubmitSingleCapture") do |xml|
+        commit('SubmitSingleCapture') do |xml|
           xml.Capture do
             xml.Receipt authorization
             add_amount(xml, money)
@@ -63,7 +63,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def refund(money, authorization, options={})
-        commit("SubmitSingleRefund") do |xml|
+        commit('SubmitSingleRefund') do |xml|
           xml.Refund do
             xml.Receipt authorization
             add_amount(xml, money)
@@ -97,7 +97,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def add_credit_card(xml, payment)
-        xml.CreditCard :Registered => "False" do
+        xml.CreditCard :Registered => 'False' do
           xml.CardNumber payment.number
           xml.ExpM format(payment.month, :two_digits)
           xml.ExpY format(payment.year, :four_digits)
@@ -119,8 +119,8 @@ module ActiveMerchant #:nodoc:
 
       def commit(action, &block)
         headers = {
-          "Content-Type" => "text/xml; charset=utf-8",
-          "SOAPAction" => "http://www.ippayments.com.au/interface/api/dts/#{action}",
+          'Content-Type' => 'text/xml; charset=utf-8',
+          'SOAPAction' => "http://www.ippayments.com.au/interface/api/dts/#{action}",
         }
         response = parse(ssl_post(commit_url, new_submit_xml(action, &block), headers))
 
@@ -137,9 +137,9 @@ module ActiveMerchant #:nodoc:
       def new_submit_xml(action)
         xml = Builder::XmlMarkup.new(indent: 2)
         xml.instruct!
-        xml.soap :Envelope, "xmlns:xsi" => "http://www.w3.org/2001/XMLSchema-instance", "xmlns:xsd" => "http://www.w3.org/2001/XMLSchema", "xmlns:soap" => "http://schemas.xmlsoap.org/soap/envelope/" do
+        xml.soap :Envelope, 'xmlns:xsi' => 'http://www.w3.org/2001/XMLSchema-instance', 'xmlns:xsd' => 'http://www.w3.org/2001/XMLSchema', 'xmlns:soap' => 'http://schemas.xmlsoap.org/soap/envelope/' do
           xml.soap :Body do
-            xml.__send__(action, "xmlns" => "http://www.ippayments.com.au/interface/api/dts") do
+            xml.__send__(action, 'xmlns' => 'http://www.ippayments.com.au/interface/api/dts') do
               xml.trnXML do
                 inner_xml = Builder::XmlMarkup.new(indent: 2)
                 yield(inner_xml)
@@ -156,7 +156,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def success_from(response)
-        (response[:response_code] == "0")
+        (response[:response_code] == '0')
       end
 
       def error_code_from(response)

data/lib/active_merchant/billing/gateways/iridium.rb

@@ -24,202 +24,202 @@ module ActiveMerchant #:nodoc:
       self.display_name = 'Iridium'
 
       CURRENCY_CODES = {
-        "AED" => '784',
-        "AFN" => '971',
-        "ALL" => '008',
-        "AMD" => '051',
-        "ANG" => '532',
-        "AOA" => '973',
-        "ARS" => '032',
-        "AUD" => '036',
-        "AWG" => '533',
-        "AZN" => '944',
-        "BAM" => '977',
-        "BBD" => '052',
-        "BDT" => '050',
-        "BGN" => '975',
-        "BHD" => '048',
-        "BIF" => '108',
-        "BMD" => '060',
-        "BND" => '096',
-        "BOB" => '068',
-        "BOV" => '984',
-        "BRL" => '986',
-        "BSD" => '044',
-        "BTN" => '064',
-        "BWP" => '072',
-        "BYR" => '974',
-        "BZD" => '084',
-        "CAD" => '124',
-        "CDF" => '976',
-        "CHE" => '947',
-        "CHF" => '756',
-        "CHW" => '948',
-        "CLF" => '990',
-        "CLP" => '152',
-        "CNY" => '156',
-        "COP" => '170',
-        "COU" => '970',
-        "CRC" => '188',
-        "CUP" => '192',
-        "CVE" => '132',
-        "CYP" => '196',
-        "CZK" => '203',
-        "DJF" => '262',
-        "DKK" => '208',
-        "DOP" => '214',
-        "DZD" => '012',
-        "EEK" => '233',
-        "EGP" => '818',
-        "ERN" => '232',
-        "ETB" => '230',
-        "EUR" => '978',
-        "FJD" => '242',
-        "FKP" => '238',
-        "GBP" => '826',
-        "GEL" => '981',
-        "GHS" => '288',
-        "GIP" => '292',
-        "GMD" => '270',
-        "GNF" => '324',
-        "GTQ" => '320',
-        "GYD" => '328',
-        "HKD" => '344',
-        "HNL" => '340',
-        "HRK" => '191',
-        "HTG" => '332',
-        "HUF" => '348',
-        "IDR" => '360',
-        "ILS" => '376',
-        "INR" => '356',
-        "IQD" => '368',
-        "IRR" => '364',
-        "ISK" => '352',
-        "JMD" => '388',
-        "JOD" => '400',
-        "JPY" => '392',
-        "KES" => '404',
-        "KGS" => '417',
-        "KHR" => '116',
-        "KMF" => '174',
-        "KPW" => '408',
-        "KRW" => '410',
-        "KWD" => '414',
-        "KYD" => '136',
-        "KZT" => '398',
-        "LAK" => '418',
-        "LBP" => '422',
-        "LKR" => '144',
-        "LRD" => '430',
-        "LSL" => '426',
-        "LTL" => '440',
-        "LVL" => '428',
-        "LYD" => '434',
-        "MAD" => '504',
-        "MDL" => '498',
-        "MGA" => '969',
-        "MKD" => '807',
-        "MMK" => '104',
-        "MNT" => '496',
-        "MOP" => '446',
-        "MRO" => '478',
-        "MTL" => '470',
-        "MUR" => '480',
-        "MVR" => '462',
-        "MWK" => '454',
-        "MXN" => '484',
-        "MXV" => '979',
-        "MYR" => '458',
-        "MZN" => '943',
-        "NAD" => '516',
-        "NGN" => '566',
-        "NIO" => '558',
-        "NOK" => '578',
-        "NPR" => '524',
-        "NZD" => '554',
-        "OMR" => '512',
-        "PAB" => '590',
-        "PEN" => '604',
-        "PGK" => '598',
-        "PHP" => '608',
-        "PKR" => '586',
-        "PLN" => '985',
-        "PYG" => '600',
-        "QAR" => '634',
-        "ROL" => '642',
-        "RON" => '946',
-        "RSD" => '941',
-        "RUB" => '643',
-        "RWF" => '646',
-        "SAR" => '682',
-        "SBD" => '090',
-        "SCR" => '690',
-        "SDG" => '938',
-        "SEK" => '752',
-        "SGD" => '702',
-        "SHP" => '654',
-        "SKK" => '703',
-        "SLL" => '694',
-        "SOS" => '706',
-        "SRD" => '968',
-        "STD" => '678',
-        "SYP" => '760',
-        "SZL" => '748',
-        "THB" => '764',
-        "TJS" => '972',
-        "TMM" => '795',
-        "TND" => '788',
-        "TOP" => '776',
-        "TRY" => '949',
-        "TTD" => '780',
-        "TWD" => '901',
-        "TZS" => '834',
-        "UAH" => '980',
-        "UGX" => '800',
-        "USD" => '840',
-        "USN" => '997',
-        "USS" => '998',
-        "UYU" => '858',
-        "UZS" => '860',
-        "VEB" => '862',
-        "VND" => '704',
-        "VUV" => '548',
-        "WST" => '882',
-        "XAF" => '950',
-        "XAG" => '961',
-        "XAU" => '959',
-        "XBA" => '955',
-        "XBB" => '956',
-        "XBC" => '957',
-        "XBD" => '958',
-        "XCD" => '951',
-        "XDR" => '960',
-        "XOF" => '952',
-        "XPD" => '964',
-        "XPF" => '953',
-        "XPT" => '962',
-        "XTS" => '963',
-        "XXX" => '999',
-        "YER" => '886',
-        "ZAR" => '710',
-        "ZMK" => '894',
-        "ZWD" => '716',
+        'AED' => '784',
+        'AFN' => '971',
+        'ALL' => '008',
+        'AMD' => '051',
+        'ANG' => '532',
+        'AOA' => '973',
+        'ARS' => '032',
+        'AUD' => '036',
+        'AWG' => '533',
+        'AZN' => '944',
+        'BAM' => '977',
+        'BBD' => '052',
+        'BDT' => '050',
+        'BGN' => '975',
+        'BHD' => '048',
+        'BIF' => '108',
+        'BMD' => '060',
+        'BND' => '096',
+        'BOB' => '068',
+        'BOV' => '984',
+        'BRL' => '986',
+        'BSD' => '044',
+        'BTN' => '064',
+        'BWP' => '072',
+        'BYR' => '974',
+        'BZD' => '084',
+        'CAD' => '124',
+        'CDF' => '976',
+        'CHE' => '947',
+        'CHF' => '756',
+        'CHW' => '948',
+        'CLF' => '990',
+        'CLP' => '152',
+        'CNY' => '156',
+        'COP' => '170',
+        'COU' => '970',
+        'CRC' => '188',
+        'CUP' => '192',
+        'CVE' => '132',
+        'CYP' => '196',
+        'CZK' => '203',
+        'DJF' => '262',
+        'DKK' => '208',
+        'DOP' => '214',
+        'DZD' => '012',
+        'EEK' => '233',
+        'EGP' => '818',
+        'ERN' => '232',
+        'ETB' => '230',
+        'EUR' => '978',
+        'FJD' => '242',
+        'FKP' => '238',
+        'GBP' => '826',
+        'GEL' => '981',
+        'GHS' => '288',
+        'GIP' => '292',
+        'GMD' => '270',
+        'GNF' => '324',
+        'GTQ' => '320',
+        'GYD' => '328',
+        'HKD' => '344',
+        'HNL' => '340',
+        'HRK' => '191',
+        'HTG' => '332',
+        'HUF' => '348',
+        'IDR' => '360',
+        'ILS' => '376',
+        'INR' => '356',
+        'IQD' => '368',
+        'IRR' => '364',
+        'ISK' => '352',
+        'JMD' => '388',
+        'JOD' => '400',
+        'JPY' => '392',
+        'KES' => '404',
+        'KGS' => '417',
+        'KHR' => '116',
+        'KMF' => '174',
+        'KPW' => '408',
+        'KRW' => '410',
+        'KWD' => '414',
+        'KYD' => '136',
+        'KZT' => '398',
+        'LAK' => '418',
+        'LBP' => '422',
+        'LKR' => '144',
+        'LRD' => '430',
+        'LSL' => '426',
+        'LTL' => '440',
+        'LVL' => '428',
+        'LYD' => '434',
+        'MAD' => '504',
+        'MDL' => '498',
+        'MGA' => '969',
+        'MKD' => '807',
+        'MMK' => '104',
+        'MNT' => '496',
+        'MOP' => '446',
+        'MRO' => '478',
+        'MTL' => '470',
+        'MUR' => '480',
+        'MVR' => '462',
+        'MWK' => '454',
+        'MXN' => '484',
+        'MXV' => '979',
+        'MYR' => '458',
+        'MZN' => '943',
+        'NAD' => '516',
+        'NGN' => '566',
+        'NIO' => '558',
+        'NOK' => '578',
+        'NPR' => '524',
+        'NZD' => '554',
+        'OMR' => '512',
+        'PAB' => '590',
+        'PEN' => '604',
+        'PGK' => '598',
+        'PHP' => '608',
+        'PKR' => '586',
+        'PLN' => '985',
+        'PYG' => '600',
+        'QAR' => '634',
+        'ROL' => '642',
+        'RON' => '946',
+        'RSD' => '941',
+        'RUB' => '643',
+        'RWF' => '646',
+        'SAR' => '682',
+        'SBD' => '090',
+        'SCR' => '690',
+        'SDG' => '938',
+        'SEK' => '752',
+        'SGD' => '702',
+        'SHP' => '654',
+        'SKK' => '703',
+        'SLL' => '694',
+        'SOS' => '706',
+        'SRD' => '968',
+        'STD' => '678',
+        'SYP' => '760',
+        'SZL' => '748',
+        'THB' => '764',
+        'TJS' => '972',
+        'TMM' => '795',
+        'TND' => '788',
+        'TOP' => '776',
+        'TRY' => '949',
+        'TTD' => '780',
+        'TWD' => '901',
+        'TZS' => '834',
+        'UAH' => '980',
+        'UGX' => '800',
+        'USD' => '840',
+        'USN' => '997',
+        'USS' => '998',
+        'UYU' => '858',
+        'UZS' => '860',
+        'VEB' => '862',
+        'VND' => '704',
+        'VUV' => '548',
+        'WST' => '882',
+        'XAF' => '950',
+        'XAG' => '961',
+        'XAU' => '959',
+        'XBA' => '955',
+        'XBB' => '956',
+        'XBC' => '957',
+        'XBD' => '958',
+        'XCD' => '951',
+        'XDR' => '960',
+        'XOF' => '952',
+        'XPD' => '964',
+        'XPF' => '953',
+        'XPT' => '962',
+        'XTS' => '963',
+        'XXX' => '999',
+        'YER' => '886',
+        'ZAR' => '710',
+        'ZMK' => '894',
+        'ZWD' => '716',
       }
 
       AVS_CODE = {
-        "PASSED" => "Y",
-        "FAILED" => "N",
-        "PARTIAL" => "X",
-        "NOT_CHECKED" => "X",
-        "UNKNOWN" => "X"
+        'PASSED' => 'Y',
+        'FAILED' => 'N',
+        'PARTIAL' => 'X',
+        'NOT_CHECKED' => 'X',
+        'UNKNOWN' => 'X'
       }
 
       CVV_CODE = {
-        "PASSED" => "M",
-        "FAILED" => "N",
-        "PARTIAL" => "I",
-        "NOT_CHECKED" => "P",
-        "UNKNOWN" => "U"
+        'PASSED' => 'M',
+        'FAILED' => 'N',
+        'PARTIAL' => 'I',
+        'NOT_CHECKED' => 'P',
+        'UNKNOWN' => 'U'
       }
 
       def initialize(options = {})
@@ -288,7 +288,7 @@ module ActiveMerchant #:nodoc:
 
       def build_reference_request(type, money, authorization, options)
         options.merge!(:action => 'CrossReferenceTransaction')
-        order_id, cross_reference, _ = authorization.split(";")
+        order_id, cross_reference, _ = authorization.split(';')
         build_request(options) do |xml|
           if money
             details = {'CurrencyCode' => currency_code(options[:currency] || default_currency), 'Amount' => amount(money)}
@@ -310,7 +310,7 @@ module ActiveMerchant #:nodoc:
                                     'xmlns:xsi' => 'http://www.w3.org/2001/XMLSchema-instance',
                                     'xmlns:xsd' => 'http://www.w3.org/2001/XMLSchema'} do
           xml.tag! 'soap:Body' do
-            xml.tag! options[:action], {'xmlns' => "https://www.thepaymentgateway.net/"} do
+            xml.tag! options[:action], {'xmlns' => 'https://www.thepaymentgateway.net/'} do
               xml.tag! 'PaymentMessage' do
                 add_merchant_data(xml, options)
                 yield(xml)
@@ -357,7 +357,7 @@ module ActiveMerchant #:nodoc:
           end
 
           xml.tag! 'EmailAddress', options[:email]
-          xml.tag! 'CustomerIPAddress', options[:ip] || "127.0.0.1"
+          xml.tag! 'CustomerIPAddress', options[:ip] || '127.0.0.1'
         end
       end
 
@@ -366,23 +366,23 @@ module ActiveMerchant #:nodoc:
           xml.tag! 'CardName', creditcard.name
           xml.tag! 'CV2', creditcard.verification_value if creditcard.verification_value
           xml.tag! 'CardNumber', creditcard.number
-          xml.tag! 'ExpiryDate', { 'Month' => creditcard.month.to_s.rjust(2, "0"), 'Year' => creditcard.year.to_s[/\d\d$/] }
+          xml.tag! 'ExpiryDate', { 'Month' => creditcard.month.to_s.rjust(2, '0'), 'Year' => creditcard.year.to_s[/\d\d$/] }
         end
       end
 
       def add_merchant_data(xml, options)
-        xml.tag! 'MerchantAuthentication', {"MerchantID" => @options[:login], "Password" => @options[:password]}
+        xml.tag! 'MerchantAuthentication', {'MerchantID' => @options[:login], 'Password' => @options[:password]}
       end
 
       def commit(request, options)
         requires!(options, :action)
         response = parse(ssl_post(test? ? self.test_url : self.live_url, request,
-                              {"SOAPAction" => "https://www.thepaymentgateway.net/" + options[:action],
-                               "Content-Type" => "text/xml; charset=utf-8" }))
+                              {'SOAPAction' => 'https://www.thepaymentgateway.net/' + options[:action],
+                               'Content-Type' => 'text/xml; charset=utf-8' }))
 
-        success = response[:transaction_result][:status_code] == "0"
+        success = response[:transaction_result][:status_code] == '0'
         message = response[:transaction_result][:message]
-        authorization = success ? [ options[:order_id], response[:transaction_output_data][:cross_reference], response[:transaction_output_data][:auth_code] ].compact.join(";") : nil
+        authorization = success ? [ options[:order_id], response[:transaction_output_data][:cross_reference], response[:transaction_output_data][:auth_code] ].compact.join(';') : nil
 
         Response.new(success, message, response,
           :test => test?,
@@ -398,8 +398,8 @@ module ActiveMerchant #:nodoc:
       def parse(xml)
         reply = {}
         xml = REXML::Document.new(xml)
-        if (root = REXML::XPath.first(xml, "//CardDetailsTransactionResponse")) or
-              (root = REXML::XPath.first(xml, "//CrossReferenceTransactionResponse"))
+        if (root = REXML::XPath.first(xml, '//CardDetailsTransactionResponse')) or
+              (root = REXML::XPath.first(xml, '//CrossReferenceTransactionResponse'))
           root.elements.to_a.each do |node|
             case node.name
             when 'Message'
@@ -408,7 +408,7 @@ module ActiveMerchant #:nodoc:
               parse_element(reply, node)
             end
           end
-        elsif root = REXML::XPath.first(xml, "//soap:Fault")
+        elsif root = REXML::XPath.first(xml, '//soap:Fault')
           parse_element(reply, root)
           reply[:message] = "#{reply[:faultcode]}: #{reply[:faultstring]}"
         end
@@ -417,29 +417,29 @@ module ActiveMerchant #:nodoc:
 
       def parse_element(reply, node)
         case node.name
-        when "CrossReferenceTransactionResult"
+        when 'CrossReferenceTransactionResult'
           reply[:transaction_result] = {}
           node.attributes.each do |a,b|
             reply[:transaction_result][a.underscore.to_sym] = b
           end
           node.elements.each{|e| parse_element(reply[:transaction_result], e) } if node.has_elements?
 
-        when "CardDetailsTransactionResult"
+        when 'CardDetailsTransactionResult'
           reply[:transaction_result] = {}
           node.attributes.each do |a,b|
             reply[:transaction_result][a.underscore.to_sym] = b
           end
           node.elements.each{|e| parse_element(reply[:transaction_result], e) } if node.has_elements?
 
-        when "TransactionOutputData"
+        when 'TransactionOutputData'
           reply[:transaction_output_data] = {}
           node.attributes.each{|a,b| reply[:transaction_output_data][a.underscore.to_sym] = b }
           node.elements.each{|e| parse_element(reply[:transaction_output_data], e) } if node.has_elements?
-        when "CustomVariables"
+        when 'CustomVariables'
           reply[:custom_variables] = {}
           node.attributes.each{|a,b| reply[:custom_variables][a.underscore.to_sym] = b }
           node.elements.each{|e| parse_element(reply[:custom_variables], e) } if node.has_elements?
-        when "GatewayEntryPoints"
+        when 'GatewayEntryPoints'
           reply[:gateway_entry_points] = {}
           node.attributes.each{|a,b| reply[:gateway_entry_points][a.underscore.to_sym] = b }
           node.elements.each{|e| parse_element(reply[:gateway_entry_points], e) } if node.has_elements?