activemerchant 1.79.2 → 1.80.0

data/lib/active_merchant/billing/gateways/paypal.rb

@@ -50,7 +50,7 @@ module ActiveMerchant #:nodoc:
 
       def build_sale_or_authorization_request(action, money, credit_card_or_referenced_id, options)
         transaction_type = define_transaction_type(credit_card_or_referenced_id)
-        reference_id = credit_card_or_referenced_id if transaction_type == "DoReferenceTransaction"
+        reference_id = credit_card_or_referenced_id if transaction_type == 'DoReferenceTransaction'
 
         billing_address = options[:billing_address] || options[:address]
         currency_code = options[:currency] || currency(money)

data/lib/active_merchant/billing/gateways/paypal_digital_goods.rb

@@ -30,7 +30,7 @@ module ActiveMerchant #:nodoc:
       #                            :category => "Digital" } ] )
       def build_setup_request(action, money, options)
         requires!(options, :items)
-        raise ArgumentError, "Must include at least 1 Item" unless options[:items].length > 0
+        raise ArgumentError, 'Must include at least 1 Item' unless options[:items].length > 0
         options[:items].each do |item|
           requires!(item, :name, :number, :quantity, :amount, :description, :category)
           raise ArgumentError, "Each of the items must have the category 'Digital'" unless item[:category] == 'Digital'

data/lib/active_merchant/billing/gateways/payscout.rb

@@ -153,7 +153,7 @@ module ActiveMerchant #:nodoc:
         post[:password]       = @options[:password]
         post[:type]           = action
 
-        request = post.merge(parameters).collect { |key, value| "#{key}=#{CGI.escape(value.to_s)}" }.join("&")
+        request = post.merge(parameters).collect { |key, value| "#{key}=#{CGI.escape(value.to_s)}" }.join('&')
         request
       end
     end

data/lib/active_merchant/billing/gateways/paystation.rb

@@ -2,7 +2,7 @@ module ActiveMerchant #:nodoc:
   module Billing #:nodoc:
     class PaystationGateway < Gateway
 
-      self.live_url = self.test_url = "https://www.paystation.co.nz/direct/paystation.dll"
+      self.live_url = self.test_url = 'https://www.paystation.co.nz/direct/paystation.dll'
 
       # an "error code" of "0" means "No error - transaction successful"
       SUCCESSFUL_RESPONSE_CODE = '0'
@@ -104,9 +104,9 @@ module ActiveMerchant #:nodoc:
           {
             :pi    => @options[:paystation_id], # paystation account id
             :gi    => @options[:gateway_id],    # paystation gateway id
-            "2p"   => "t",                      # two-party transaction type
-            :nr    => "t",                      # -- redirect??
-            :df    => "yymm"                    # date format: optional sometimes, required others
+            '2p'   => 't',                      # two-party transaction type
+            :nr    => 't',                      # -- redirect??
+            :df    => 'yymm'                    # date format: optional sometimes, required others
           }
         end
 
@@ -128,27 +128,27 @@ module ActiveMerchant #:nodoc:
         end
 
         def add_token(post, token)
-          post[:fp] = "t"    # turn on "future payments" - what paystation calls Token Billing
+          post[:fp] = 't'    # turn on "future payments" - what paystation calls Token Billing
           post[:ft] = token
         end
 
         def store_credit_card(post, options)
-          post[:fp] = "t"                                # turn on "future payments" - what paystation calls Token Billing
-          post[:fs] = "t"                                # tells paystation to store right now, not bill
+          post[:fp] = 't'                                # turn on "future payments" - what paystation calls Token Billing
+          post[:fs] = 't'                                # tells paystation to store right now, not bill
           post[:ft] = options[:token] if options[:token] # specify a token to use that, or let Paystation generate one
         end
 
         def add_authorize_flag(post, options)
-          post[:pa] = "t" # tells Paystation that this is a pre-auth authorisation payment (account must be in pre-auth mode)
+          post[:pa] = 't' # tells Paystation that this is a pre-auth authorisation payment (account must be in pre-auth mode)
         end
 
         def add_refund_specific_fields(post, authorization)
-          post[:rc] = "t"
+          post[:rc] = 't'
           post[:rt] = authorization
         end
 
         def add_authorization_token(post, auth_token, verification_value = nil)
-          post[:cp] = "t" # Capture Payment flag – tells Paystation this transaction should be treated as a capture payment
+          post[:cp] = 't' # Capture Payment flag – tells Paystation this transaction should be treated as a capture payment
           post[:cx] = auth_token
           post[:cc] = verification_value
         end
@@ -171,15 +171,15 @@ module ActiveMerchant #:nodoc:
         end
 
         def commit(post)
-          post[:tm] = "T" if test?
-          pstn_prefix_params = post.collect { |key, value| "pstn_#{key}=#{CGI.escape(value.to_s)}" }.join("&")
+          post[:tm] = 'T' if test?
+          pstn_prefix_params = post.collect { |key, value| "pstn_#{key}=#{CGI.escape(value.to_s)}" }.join('&')
 
           data     = ssl_post(self.live_url, "#{pstn_prefix_params}&paystation=_empty")
           response = parse(data)
           message  = message_from(response)
 
           PaystationResponse.new(success?(response), message, response,
-              :test          => (response[:tm] && response[:tm].downcase == "t"),
+              :test          => (response[:tm] && response[:tm].downcase == 't'),
               :authorization => response[:paystation_transaction_id]
           )
         end
@@ -200,7 +200,7 @@ module ActiveMerchant #:nodoc:
 
     class PaystationResponse < Response
       def token
-        @params["future_payment_token"]
+        @params['future_payment_token']
       end
     end
   end

data/lib/active_merchant/billing/gateways/payu_in.rb

@@ -3,11 +3,11 @@
 module ActiveMerchant #:nodoc:
   module Billing #:nodoc:
     class PayuInGateway < Gateway
-      self.test_url = "https://test.payu.in/_payment"
-      self.live_url = "https://secure.payu.in/_payment"
+      self.test_url = 'https://test.payu.in/_payment'
+      self.live_url = 'https://secure.payu.in/_payment'
 
-      TEST_INFO_URL = "https://test.payu.in/merchant/postservice.php?form=2"
-      LIVE_INFO_URL = "https://info.payu.in/merchant/postservice.php?form=2"
+      TEST_INFO_URL = 'https://test.payu.in/merchant/postservice.php?form=2'
+      LIVE_INFO_URL = 'https://info.payu.in/merchant/postservice.php?form=2'
 
       self.supported_countries = ['IN']
       self.default_currency = 'INR'
@@ -32,9 +32,9 @@ module ActiveMerchant #:nodoc:
         add_auth(post)
 
         MultiResponse.run do |r|
-          r.process{commit(url("purchase"), post)}
-          if(r.params["enrolled"].to_s == "0")
-            r.process{commit(r.params["post_uri"], r.params["form_post_vars"])}
+          r.process{commit(url('purchase'), post)}
+          if(r.params['enrolled'].to_s == '0')
+            r.process{commit(r.params['post_uri'], r.params['form_post_vars'])}
           else
             r.process{handle_3dsecure(r)}
           end
@@ -42,18 +42,18 @@ module ActiveMerchant #:nodoc:
       end
 
       def refund(money, authorization, options={})
-        raise ArgumentError, "Amount is required" unless money
+        raise ArgumentError, 'Amount is required' unless money
 
         post = {}
 
-        post[:command] = "cancel_refund_transaction"
+        post[:command] = 'cancel_refund_transaction'
         post[:var1] = authorization
         post[:var2] = generate_unique_id
         post[:var3] = amount(money)
 
         add_auth(post, :command, :var1)
 
-        commit(url("refund"), post)
+        commit(url('refund'), post)
       end
 
       def supports_scrubbing?
@@ -82,17 +82,17 @@ module ActiveMerchant #:nodoc:
 
         digest_keys = PAYMENT_DIGEST_KEYS if digest_keys.empty?
         digest = Digest::SHA2.new(512)
-        digest << @options[:key] << "|"
+        digest << @options[:key] << '|'
         digest_keys.each do |key|
-          digest << (post[key.to_sym] || "") << "|"
+          digest << (post[key.to_sym] || '') << '|'
         end
         digest << @options[:salt]
         post[:hash] = digest.hexdigest
       end
 
       def add_customer_data(post, options)
-        post[:email] = clean(options[:email] || "unknown@example.com", nil, 50)
-        post[:phone] = clean((options[:billing_address] && options[:billing_address][:phone]) || "11111111111", :numeric, 50)
+        post[:email] = clean(options[:email] || 'unknown@example.com', nil, 50)
+        post[:phone] = clean((options[:billing_address] && options[:billing_address][:phone]) || '11111111111', :numeric, 50)
       end
 
       def add_addresses(post, options)
@@ -109,7 +109,7 @@ module ActiveMerchant #:nodoc:
           if options[:shipping_address][:name]
             first, *rest = options[:shipping_address][:name].split(/\s+/)
             post[:shipping_firstname] = clean(first, :name, 60)
-            post[:shipping_lastname] = clean(rest.join(" "), :name, 20)
+            post[:shipping_lastname] = clean(rest.join(' '), :name, 20)
           end
           post[:shipping_address1] = clean(options[:shipping_address][:address1], :text, 100)
           post[:shipping_address2] = clean(options[:shipping_address][:address2], :text, 100)
@@ -125,22 +125,22 @@ module ActiveMerchant #:nodoc:
         post[:amount] = amount(money)
 
         post[:txnid] = clean(options[:order_id], :alphanumeric, 30)
-        post[:productinfo] = clean(options[:description] || "Purchase", nil, 100)
+        post[:productinfo] = clean(options[:description] || 'Purchase', nil, 100)
 
-        post[:surl] = "http://example.com"
-        post[:furl] = "http://example.com"
+        post[:surl] = 'http://example.com'
+        post[:furl] = 'http://example.com'
       end
 
       BRAND_MAP = {
-        visa: "VISA",
-        master: "MAST",
-        american_express: "AMEX",
-        diners_club: "DINR",
-        maestro: "MAES"
+        visa: 'VISA',
+        master: 'MAST',
+        american_express: 'AMEX',
+        diners_club: 'DINR',
+        maestro: 'MAES'
       }
 
       def add_payment(post, payment)
-        post[:pg] = "CC"
+        post[:pg] = 'CC'
         post[:firstname] = clean(payment.first_name, :name, 60)
         post[:lastname] = clean(payment.last_name, :name, 20)
 
@@ -153,16 +153,16 @@ module ActiveMerchant #:nodoc:
       end
 
       def clean(value, format, maxlength)
-        value ||= ""
+        value ||= ''
         value = case format
         when :alphanumeric
-          value.gsub(/[^A-Za-z0-9]/, "")
+          value.gsub(/[^A-Za-z0-9]/, '')
         when :name
-          value.gsub(/[^A-Za-z ]/, "")
+          value.gsub(/[^A-Za-z ]/, '')
         when :numeric
-          value.gsub(/[^0-9]/, "")
+          value.gsub(/[^0-9]/, '')
         when :text
-          value.gsub(/[^A-Za-z0-9@\-_\/\. ]/, "")
+          value.gsub(/[^A-Za-z0-9@\-_\/\. ]/, '')
         when nil
           value
         else
@@ -174,10 +174,10 @@ module ActiveMerchant #:nodoc:
       def parse(body)
         top = JSON.parse(body)
 
-        if result = top.delete("result")
-          result.split("&").inject({}) do |hash, string|
-            key, value = string.split("=")
-            hash[CGI.unescape(key).downcase] = CGI.unescape(value || "")
+        if result = top.delete('result')
+          result.split('&').inject({}) do |hash, string|
+            key, value = string.split('=')
+            hash[CGI.unescape(key).downcase] = CGI.unescape(value || '')
             hash
           end.each do |key, value|
             if top[key]
@@ -188,19 +188,19 @@ module ActiveMerchant #:nodoc:
           end
         end
 
-        if response = top.delete("response")
+        if response = top.delete('response')
           top.merge!(response)
         end
 
         top
       rescue JSON::ParserError
         {
-          "error" => "Invalid response received from the PayU API. (The raw response was `#{body}`)."
+          'error' => "Invalid response received from the PayU API. (The raw response was `#{body}`)."
         }
       end
 
       def commit(url, parameters)
-        response = parse(ssl_post(url, post_data(parameters), "Accept-Encoding" => "identity"))
+        response = parse(ssl_post(url, post_data(parameters), 'Accept-Encoding' => 'identity'))
 
         Response.new(
           success_from(response),
@@ -213,7 +213,7 @@ module ActiveMerchant #:nodoc:
 
       def url(action)
         case action
-        when "purchase"
+        when 'purchase'
           (test? ? test_url : live_url)
         else
           (test? ? TEST_INFO_URL : LIVE_INFO_URL)
@@ -221,19 +221,19 @@ module ActiveMerchant #:nodoc:
       end
 
       def success_from(response)
-        if response["result_status"]
-          (response["status"] == "success" && response["result_status"] == "success")
+        if response['result_status']
+          (response['status'] == 'success' && response['result_status'] == 'success')
         else
-          (response["status"] == "success" || response["status"].to_s == "1")
+          (response['status'] == 'success' || response['status'].to_s == '1')
         end
       end
 
       def message_from(response)
-        (response["error_message"] || response["error"] || response["msg"])
+        (response['error_message'] || response['error'] || response['msg'])
       end
 
       def authorization_from(response)
-        response["mihpayid"]
+        response['mihpayid']
       end
 
       def post_data(parameters = {})
@@ -241,7 +241,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def handle_3dsecure(response)
-        Response.new(false, "3D-secure enrolled cards are not supported.")
+        Response.new(false, '3D-secure enrolled cards are not supported.')
       end
     end
   end

data/lib/active_merchant/billing/gateways/payu_latam.rb

@@ -3,29 +3,29 @@ require 'digest/md5'
 module ActiveMerchant #:nodoc:
   module Billing #:nodoc:
     class PayuLatamGateway < Gateway
-      self.display_name = "PayU Latam"
-      self.homepage_url = "http://www.payulatam.com"
+      self.display_name = 'PayU Latam'
+      self.homepage_url = 'http://www.payulatam.com'
 
-      self.test_url = "https://sandbox.api.payulatam.com/payments-api/4.0/service.cgi"
-      self.live_url = "https://api.payulatam.com/payments-api/4.0/service.cgi"
+      self.test_url = 'https://sandbox.api.payulatam.com/payments-api/4.0/service.cgi'
+      self.live_url = 'https://api.payulatam.com/payments-api/4.0/service.cgi'
 
-      self.supported_countries = ["AR", "BR", "CL", "CO", "MX", "PA", "PE"]
-      self.default_currency = "USD"
+      self.supported_countries = ['AR', 'BR', 'CL', 'CO', 'MX', 'PA', 'PE']
+      self.default_currency = 'USD'
       self.money_format = :dollars
       self.supported_cardtypes = [:visa, :master, :american_express, :diners_club]
 
       BRAND_MAP = {
-        "visa" => "VISA",
-        "master" => "MASTERCARD",
-        "american_express" => "AMEX",
-        "diners_club" => "DINERS"
+        'visa' => 'VISA',
+        'master' => 'MASTERCARD',
+        'american_express' => 'AMEX',
+        'diners_club' => 'DINERS'
       }
 
       MINIMUMS = {
-        "ARS" => 1700,
-        "BRL" => 600,
-        "MXN" => 3900,
-        "PEN" => 500
+        'ARS' => 1700,
+        'BRL' => 600,
+        'MXN' => 3900,
+        'PEN' => 500
       }
 
       def initialize(options={})
@@ -251,7 +251,7 @@ module ActiveMerchant #:nodoc:
           post[:transaction][:order][:referenceCode],
           post[:transaction][:order][:additionalValues][:TX_VALUE][:value],
           post[:transaction][:order][:additionalValues][:TX_VALUE][:currency]
-        ].compact.join("~")
+        ].compact.join('~')
 
         Digest::MD5.hexdigest(signature_string)
       end
@@ -333,8 +333,8 @@ module ActiveMerchant #:nodoc:
 
       def headers
         {
-          "Content-Type"  => "application/json",
-          "Accept"  => "application/json"
+          'Content-Type'  => 'application/json',
+          'Accept'  => 'application/json'
         }
       end
 
@@ -354,32 +354,32 @@ module ActiveMerchant #:nodoc:
       def success_from(action, response)
         case action
         when 'store'
-          response["code"] == "SUCCESS" && response["creditCardToken"] && response["creditCardToken"]["creditCardTokenId"].present?
+          response['code'] == 'SUCCESS' && response['creditCardToken'] && response['creditCardToken']['creditCardTokenId'].present?
         when 'verify_credentials'
-          response["code"] == "SUCCESS"
+          response['code'] == 'SUCCESS'
         when 'refund', 'void'
-        response["code"] == "SUCCESS" && response["transactionResponse"] && (response["transactionResponse"]["state"] == "PENDING" || response["transactionResponse"]["state"] == "APPROVED")
+        response['code'] == 'SUCCESS' && response['transactionResponse'] && (response['transactionResponse']['state'] == 'PENDING' || response['transactionResponse']['state'] == 'APPROVED')
         else
-          response["code"] == "SUCCESS" && response["transactionResponse"] && (response["transactionResponse"]["state"] == "APPROVED")
+          response['code'] == 'SUCCESS' && response['transactionResponse'] && (response['transactionResponse']['state'] == 'APPROVED')
         end
       end
 
       def message_from(action, success, response)
         case action
         when 'store'
-          return response["code"] if success
-          error_description = response["creditCardToken"]["errorDescription"] if response["creditCardToken"]
-          response["error"] || error_description || "FAILED"
+          return response['code'] if success
+          error_description = response['creditCardToken']['errorDescription'] if response['creditCardToken']
+          response['error'] || error_description || 'FAILED'
         when 'verify_credentials'
-          return "VERIFIED" if success
-          "FAILED"
+          return 'VERIFIED' if success
+          'FAILED'
         else
-          if response["transactionResponse"]
-            response_message = response["transactionResponse"]["responseMessage"]
-            response_code = response["transactionResponse"]["responseCode"] || response["transactionResponse"]["pendingReason"]
+          if response['transactionResponse']
+            response_message = response['transactionResponse']['responseMessage']
+            response_code = response['transactionResponse']['responseCode'] || response['transactionResponse']['pendingReason']
           end
           return response_code if success
-          response["error"] || response_message || response_code || "FAILED"
+          response['error'] || response_message || response_code || 'FAILED'
         end
       end
 
@@ -387,31 +387,31 @@ module ActiveMerchant #:nodoc:
         case action
         when 'store'
           [
-            response["creditCardToken"]["paymentMethod"],
-            response["creditCardToken"]["creditCardTokenId"]
-          ].compact.join("|")
+            response['creditCardToken']['paymentMethod'],
+            response['creditCardToken']['creditCardTokenId']
+          ].compact.join('|')
         when 'verify_credentials'
           nil
         else
           [
-            response["transactionResponse"]["orderId"],
-            response["transactionResponse"]["transactionId"]
-          ].compact.join("|")
+            response['transactionResponse']['orderId'],
+            response['transactionResponse']['transactionId']
+          ].compact.join('|')
         end
       end
 
       def split_authorization(authorization)
-        authorization.split("|")
+        authorization.split('|')
       end
 
       def error_from(action, response)
         case action
         when 'store'
-          response["creditCardToken"]["errorDescription"] if response["creditCardToken"]
+          response['creditCardToken']['errorDescription'] if response['creditCardToken']
         when 'verify_credentials'
-          response["error"] || "FAILED"
+          response['error'] || 'FAILED'
         else
-          response["transactionResponse"]["errorCode"] || response["transactionResponse"]["responseCode"] if response["transactionResponse"]
+          response['transactionResponse']['errorCode'] || response['transactionResponse']['responseCode'] if response['transactionResponse']
         end
       end
 
@@ -431,7 +431,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def unparsable_response(raw_response)
-        message = "Invalid JSON response received from PayuLatamGateway. Please contact PayuLatamGateway if you continue to receive this message."
+        message = 'Invalid JSON response received from PayuLatamGateway. Please contact PayuLatamGateway if you continue to receive this message.'
         message += " (The raw response returned by the API was #{raw_response.inspect})"
         return Response.new(false, message)
       end