activemerchant 1.79.2 → 1.80.0

data/lib/active_merchant/billing/gateways/culqi.rb

@@ -9,14 +9,14 @@ module ActiveMerchant #:nodoc:
     # largely depends on the transaction acquiring bank. Be sure to understand how
     # your account was configured prior to using this gateway.
     class CulqiGateway < Gateway
-      self.display_name = "Culqi"
-      self.homepage_url = "https://www.culqi.com"
+      self.display_name = 'Culqi'
+      self.homepage_url = 'https://www.culqi.com'
 
-      self.test_url = "https://staging.paymentz.com/transaction/"
-      self.live_url = "https://secure.culqi.com/transaction/"
+      self.test_url = 'https://staging.paymentz.com/transaction/'
+      self.live_url = 'https://secure.culqi.com/transaction/'
 
-      self.supported_countries = ["PE"]
-      self.default_currency = "PEN"
+      self.supported_countries = ['PE']
+      self.default_currency = 'PEN'
       self.money_format = :dollars
       self.supported_cardtypes = [:visa, :master, :diners_club, :american_express]
 
@@ -86,8 +86,8 @@ module ActiveMerchant #:nodoc:
       end
 
       def verify_credentials
-        response = void("0", order_id: "0")
-        response.message.include? "Transaction not found"
+        response = void('0', order_id: '0')
+        response.message.include? 'Transaction not found'
       end
 
       def store(credit_card, options={})
@@ -181,11 +181,11 @@ module ActiveMerchant #:nodoc:
 
       def add_checksum(action, post)
         checksum_elements = case action
-        when :capture;  [post[:toid], post[:trackingid], post[:captureamount], @options[:secret_key]]
-        when :void;     [post[:toid], post[:description], post[:trackingid], @options[:secret_key]]
-        when :refund;   [post[:toid], post[:trackingid], post[:refundamount], @options[:secret_key]]
-        when :tokenize; [post[:partnerid], post[:cardnumber], post[:cvv], @options[:secret_key]]
-        when :invalidate; [post[:partnerid], post[:token], @options[:secret_key]]
+        when :capture    then  [post[:toid], post[:trackingid], post[:captureamount], @options[:secret_key]]
+        when :void       then  [post[:toid], post[:description], post[:trackingid], @options[:secret_key]]
+        when :refund     then  [post[:toid], post[:trackingid], post[:refundamount], @options[:secret_key]]
+        when :tokenize   then [post[:partnerid], post[:cardnumber], post[:cvv], @options[:secret_key]]
+        when :invalidate then [post[:partnerid], post[:token], @options[:secret_key]]
         else [post[:toid], post[:totype], post[:amount], post[:description], post[:redirecturl],
               post[:cardnumber] || post[:token], @options[:secret_key]]
         end
@@ -198,13 +198,13 @@ module ActiveMerchant #:nodoc:
       end
 
       ACTIONS = {
-        authorize: "SingleCallGenericServlet",
-        capture: "SingleCallGenericCaptureServlet",
-        void: "SingleCallGenericVoid",
-        refund: "SingleCallGenericReverse",
-        tokenize: "SingleCallTokenServlet",
-        invalidate: "SingleCallInvalidateToken",
-        tokenpay: "SingleCallTokenTransaction",
+        authorize: 'SingleCallGenericServlet',
+        capture: 'SingleCallGenericCaptureServlet',
+        void: 'SingleCallGenericVoid',
+        refund: 'SingleCallGenericReverse',
+        tokenize: 'SingleCallTokenServlet',
+        invalidate: 'SingleCallInvalidateToken',
+        tokenpay: 'SingleCallTokenTransaction',
       }
 
       def commit(action, params)
@@ -229,8 +229,8 @@ module ActiveMerchant #:nodoc:
 
       def headers
         {
-          "Accept"  => "application/json",
-          "Content-Type"  => "application/x-www-form-urlencoded;charset=UTF-8"
+          'Accept'  => 'application/json',
+          'Content-Type'  => 'application/x-www-form-urlencoded;charset=UTF-8'
         }
       end
 
@@ -246,11 +246,11 @@ module ActiveMerchant #:nodoc:
         begin
           JSON.parse(body)
         rescue JSON::ParserError
-          message = "Invalid JSON response received from CulqiGateway. Please contact CulqiGateway if you continue to receive this message."
+          message = 'Invalid JSON response received from CulqiGateway. Please contact CulqiGateway if you continue to receive this message.'
           message += "(The raw response returned by the API was #{body.inspect})"
           {
-            "status" => "N",
-            "statusdescription" => message
+            'status' => 'N',
+            'statusdescription' => message
           }
         end
       end

data/lib/active_merchant/billing/gateways/cyber_source.rb

@@ -24,7 +24,7 @@ module ActiveMerchant #:nodoc:
       self.test_url = 'https://ics2wstesta.ic3.com/commerce/1.x/transactionProcessor'
       self.live_url = 'https://ics2wsa.ic3.com/commerce/1.x/transactionProcessor'
 
-      XSD_VERSION = "1.121"
+      XSD_VERSION = '1.121'
 
       self.supported_cardtypes = [:visa, :master, :american_express, :discover, :diners_club, :jcb, :switch, :dankort, :maestro]
       self.supported_countries = %w(US BR CA CN DK FI FR DE JP MX NO SE GB SG LB)
@@ -48,44 +48,44 @@ module ActiveMerchant #:nodoc:
       }
 
       @@response_codes = {
-        :r100 => "Successful transaction",
-        :r101 => "Request is missing one or more required fields" ,
-        :r102 => "One or more fields contains invalid data",
-        :r150 => "General failure",
-        :r151 => "The request was received but a server time-out occurred",
-        :r152 => "The request was received, but a service timed out",
-        :r200 => "The authorization request was approved by the issuing bank but declined by CyberSource because it did not pass the AVS check",
-        :r201 => "The issuing bank has questions about the request",
-        :r202 => "Expired card",
-        :r203 => "General decline of the card",
-        :r204 => "Insufficient funds in the account",
-        :r205 => "Stolen or lost card",
-        :r207 => "Issuing bank unavailable",
-        :r208 => "Inactive card or card not authorized for card-not-present transactions",
-        :r209 => "American Express Card Identifiction Digits (CID) did not match",
-        :r210 => "The card has reached the credit limit",
-        :r211 => "Invalid card verification number",
+        :r100 => 'Successful transaction',
+        :r101 => 'Request is missing one or more required fields' ,
+        :r102 => 'One or more fields contains invalid data',
+        :r150 => 'General failure',
+        :r151 => 'The request was received but a server time-out occurred',
+        :r152 => 'The request was received, but a service timed out',
+        :r200 => 'The authorization request was approved by the issuing bank but declined by CyberSource because it did not pass the AVS check',
+        :r201 => 'The issuing bank has questions about the request',
+        :r202 => 'Expired card',
+        :r203 => 'General decline of the card',
+        :r204 => 'Insufficient funds in the account',
+        :r205 => 'Stolen or lost card',
+        :r207 => 'Issuing bank unavailable',
+        :r208 => 'Inactive card or card not authorized for card-not-present transactions',
+        :r209 => 'American Express Card Identifiction Digits (CID) did not match',
+        :r210 => 'The card has reached the credit limit',
+        :r211 => 'Invalid card verification number',
         :r221 => "The customer matched an entry on the processor's negative file",
-        :r230 => "The authorization request was approved by the issuing bank but declined by CyberSource because it did not pass the card verification check",
-        :r231 => "Invalid account number",
-        :r232 => "The card type is not accepted by the payment processor",
-        :r233 => "General decline by the processor",
-        :r234 => "A problem exists with your CyberSource merchant configuration",
-        :r235 => "The requested amount exceeds the originally authorized amount",
-        :r236 => "Processor failure",
-        :r237 => "The authorization has already been reversed",
-        :r238 => "The authorization has already been captured",
-        :r239 => "The requested transaction amount must match the previous transaction amount",
-        :r240 => "The card type sent is invalid or does not correlate with the credit card number",
-        :r241 => "The request ID is invalid",
-        :r242 => "You requested a capture, but there is no corresponding, unused authorization record.",
-        :r243 => "The transaction has already been settled or reversed",
-        :r244 => "The bank account number failed the validation check",
-        :r246 => "The capture or credit is not voidable because the capture or credit information has already been submitted to your processor",
-        :r247 => "You requested a credit for a capture that was previously voided",
-        :r250 => "The request was received, but a time-out occurred with the payment processor",
-        :r254 => "Your CyberSource account is prohibited from processing stand-alone refunds",
-        :r255 => "Your CyberSource account is not configured to process the service in the country you specified"
+        :r230 => 'The authorization request was approved by the issuing bank but declined by CyberSource because it did not pass the card verification check',
+        :r231 => 'Invalid account number',
+        :r232 => 'The card type is not accepted by the payment processor',
+        :r233 => 'General decline by the processor',
+        :r234 => 'A problem exists with your CyberSource merchant configuration',
+        :r235 => 'The requested amount exceeds the originally authorized amount',
+        :r236 => 'Processor failure',
+        :r237 => 'The authorization has already been reversed',
+        :r238 => 'The authorization has already been captured',
+        :r239 => 'The requested transaction amount must match the previous transaction amount',
+        :r240 => 'The card type sent is invalid or does not correlate with the credit card number',
+        :r241 => 'The request ID is invalid',
+        :r242 => 'You requested a capture, but there is no corresponding, unused authorization record.',
+        :r243 => 'The transaction has already been settled or reversed',
+        :r244 => 'The bank account number failed the validation check',
+        :r246 => 'The capture or credit is not voidable because the capture or credit information has already been submitted to your processor',
+        :r247 => 'You requested a credit for a capture that was previously voided',
+        :r250 => 'The request was received, but a time-out occurred with the payment processor',
+        :r254 => 'Your CyberSource account is prohibited from processing stand-alone refunds',
+        :r255 => 'Your CyberSource account is not configured to process the service in the country you specified'
       }
 
       # These are the options that can be used when creating a new CyberSource
@@ -232,8 +232,8 @@ module ActiveMerchant #:nodoc:
       end
 
       def verify_credentials
-        response = void("0")
-        response.params["reasonCode"] == "102"
+        response = void('0')
+        response.params['reasonCode'] == '102'
       end
 
       private
@@ -276,7 +276,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def build_capture_request(money, authorization, options)
-        order_id, request_id, request_token = authorization.split(";")
+        order_id, request_id, request_token = authorization.split(';')
         options[:order_id] = order_id
 
         xml = Builder::XmlMarkup.new :indent => 2
@@ -303,11 +303,11 @@ module ActiveMerchant #:nodoc:
       end
 
       def build_void_request(identification, options)
-        order_id, request_id, request_token, action, money, currency  = identification.split(";")
+        order_id, request_id, request_token, action, money, currency  = identification.split(';')
         options[:order_id] = order_id
 
         xml = Builder::XmlMarkup.new :indent => 2
-        if action == "capture"
+        if action == 'capture'
           add_void_service(xml, request_id, request_token)
         else
           add_purchase_data(xml, money, true, options.merge(:currency => currency || default_currency))
@@ -317,7 +317,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def build_refund_request(money, identification, options)
-        order_id, request_id, request_token = identification.split(";")
+        order_id, request_id, request_token = identification.split(';')
         options[:order_id] = order_id
 
         xml = Builder::XmlMarkup.new :indent => 2
@@ -338,7 +338,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def build_create_subscription_request(payment_method, options)
-        default_subscription_params = {:frequency => "on-demand", :amount => 0, :automatic_renew => false}
+        default_subscription_params = {:frequency => 'on-demand', :amount => 0, :automatic_renew => false}
         options[:subscription] = default_subscription_params.update(
           options[:subscription] || {}
         )
@@ -485,7 +485,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def add_mdd_fields(xml, options)
-        return unless options.keys.any? { |key| key.to_s.start_with?("mdd_field") }
+        return unless options.keys.any? { |key| key.to_s.start_with?('mdd_field') }
 
         xml.tag! 'merchantDefinedData' do
           (1..100).each do |each|
@@ -528,24 +528,24 @@ module ActiveMerchant #:nodoc:
         case card_brand(payment_method).to_sym
         when :visa
           xml.tag! 'ccAuthService', {'run' => 'true'} do
-            xml.tag!("cavv", payment_method.payment_cryptogram)
-            xml.tag!("commerceIndicator", "vbv")
-            xml.tag!("xid", payment_method.payment_cryptogram)
+            xml.tag!('cavv', payment_method.payment_cryptogram)
+            xml.tag!('commerceIndicator', 'vbv')
+            xml.tag!('xid', payment_method.payment_cryptogram)
           end
         when :mastercard
           xml.tag! 'ucaf' do
-            xml.tag!("authenticationData", payment_method.payment_cryptogram)
-            xml.tag!("collectionIndicator", "2")
+            xml.tag!('authenticationData', payment_method.payment_cryptogram)
+            xml.tag!('collectionIndicator', '2')
           end
           xml.tag! 'ccAuthService', {'run' => 'true'} do
-            xml.tag!("commerceIndicator", "spa")
+            xml.tag!('commerceIndicator', 'spa')
           end
         when :american_express
           cryptogram = Base64.decode64(payment_method.payment_cryptogram)
           xml.tag! 'ccAuthService', {'run' => 'true'} do
-            xml.tag!("cavv", Base64.encode64(cryptogram[0...20]))
-            xml.tag!("commerceIndicator", "aesk")
-            xml.tag!("xid", Base64.encode64(cryptogram[20...40]))
+            xml.tag!('cavv', Base64.encode64(cryptogram[0...20]))
+            xml.tag!('commerceIndicator', 'aesk')
+            xml.tag!('xid', Base64.encode64(cryptogram[20...40]))
           end
         end
       end
@@ -618,7 +618,7 @@ module ActiveMerchant #:nodoc:
 
         xml.tag! 'recurringSubscriptionInfo' do
           if reference
-            subscription_id = reference.split(";")[6]
+            subscription_id = reference.split(';')[6]
             xml.tag! 'subscriptionID',  subscription_id
           end
 
@@ -627,8 +627,8 @@ module ActiveMerchant #:nodoc:
           xml.tag! 'numberOfPayments',  options[:subscription][:occurrences]                    if options[:subscription][:occurrences]
           xml.tag! 'automaticRenew',    options[:subscription][:automatic_renew]                if options[:subscription][:automatic_renew]
           xml.tag! 'frequency',         options[:subscription][:frequency]                      if options[:subscription][:frequency]
-          xml.tag! 'startDate',         options[:subscription][:start_date].strftime("%Y%m%d")  if options[:subscription][:start_date]
-          xml.tag! 'endDate',           options[:subscription][:end_date].strftime("%Y%m%d")    if options[:subscription][:end_date]
+          xml.tag! 'startDate',         options[:subscription][:start_date].strftime('%Y%m%d')  if options[:subscription][:start_date]
+          xml.tag! 'endDate',           options[:subscription][:end_date].strftime('%Y%m%d')    if options[:subscription][:end_date]
           xml.tag! 'approvalRequired',  options[:subscription][:approval_required] || false
           xml.tag! 'event',             options[:subscription][:event]                          if options[:subscription][:event]
           xml.tag! 'billPayment',       options[:subscription][:bill_payment]                   if options[:subscription][:bill_payment]
@@ -637,13 +637,13 @@ module ActiveMerchant #:nodoc:
 
       def add_creditcard_payment_method(xml)
         xml.tag! 'subscription' do
-          xml.tag! 'paymentMethod', "credit card"
+          xml.tag! 'paymentMethod', 'credit card'
         end
       end
 
       def add_check_payment_method(xml)
         xml.tag! 'subscription' do
-          xml.tag! 'paymentMethod', "check"
+          xml.tag! 'paymentMethod', 'check'
         end
       end
 
@@ -715,7 +715,7 @@ module ActiveMerchant #:nodoc:
           response = { message: e.to_s }
         end
 
-        success = response[:decision] == "ACCEPT"
+        success = response[:decision] == 'ACCEPT'
         message = response[:message]
 
         authorization = success ? authorization_from(response, action, amount, options) : nil
@@ -733,7 +733,7 @@ module ActiveMerchant #:nodoc:
       def parse(xml)
         reply = {}
         xml = REXML::Document.new(xml)
-        if root = REXML::XPath.first(xml, "//c:replyMessage")
+        if root = REXML::XPath.first(xml, '//c:replyMessage')
           root.elements.to_a.each do |node|
             case node.expanded_name
             when 'c:reasonCode'
@@ -743,7 +743,7 @@ module ActiveMerchant #:nodoc:
               parse_element(reply, node)
             end
           end
-        elsif root = REXML::XPath.first(xml, "//soap:Fault")
+        elsif root = REXML::XPath.first(xml, '//soap:Fault')
           parse_element(reply, root)
           reply[:message] = "#{reply[:faultcode]}: #{reply[:faultstring]}"
         end
@@ -756,7 +756,7 @@ module ActiveMerchant #:nodoc:
         else
           if node.parent.name =~ /item/
             parent = node.parent.name
-            parent += '_' + node.parent.attributes["id"] if node.parent.attributes["id"]
+            parent += '_' + node.parent.attributes['id'] if node.parent.attributes['id']
             parent += '_'
           end
           reply["#{parent}#{node.name}".to_sym] ||= node.text
@@ -771,7 +771,7 @@ module ActiveMerchant #:nodoc:
 
       def authorization_from(response, action, amount, options)
         [options[:order_id], response[:requestID], response[:requestToken], action, amount,
-         options[:currency], response[:subscriptionID]].join(";")
+         options[:currency], response[:subscriptionID]].join(';')
       end
     end
   end

data/lib/active_merchant/billing/gateways/data_cash.rb

@@ -1,4 +1,4 @@
-require "active_support/core_ext/string/access"
+require 'active_support/core_ext/string/access'
 
 module ActiveMerchant
   module Billing
@@ -142,7 +142,7 @@ module ActiveMerchant
 
       def build_purchase_or_authorization_request_with_continuous_authority_reference_request(type, money, authorization, options)
         parsed_authorization = parse_authorization_string(authorization)
-        raise ArgumentError, "The continuous authority reference is required for continuous authority transactions" if parsed_authorization[:ca_reference].blank?
+        raise ArgumentError, 'The continuous authority reference is required for continuous authority transactions' if parsed_authorization[:ca_reference].blank?
 
         xml = Builder::XmlMarkup.new :indent => 2
         xml.instruct!
@@ -288,7 +288,7 @@ module ActiveMerchant
 
         response = {}
         xml = REXML::Document.new(body)
-        root = REXML::XPath.first(xml, "//Response")
+        root = REXML::XPath.first(xml, '//Response')
 
         root.elements.to_a.each do |node|
           parse_element(response, node)
@@ -306,7 +306,7 @@ module ActiveMerchant
       end
 
       def format_reference_number(number)
-        number.to_s.gsub(/[^A-Za-z0-9]/, '').rjust(6, "0").first(30)
+        number.to_s.gsub(/[^A-Za-z0-9]/, '').rjust(6, '0').first(30)
       end
 
       def parse_authorization_string(authorization)

data/lib/active_merchant/billing/gateways/dibs.rb

@@ -1,13 +1,13 @@
 module ActiveMerchant #:nodoc:
   module Billing #:nodoc:
     class DibsGateway < Gateway
-      self.display_name = "DIBS"
-      self.homepage_url = "http://www.dibspayment.com/"
+      self.display_name = 'DIBS'
+      self.homepage_url = 'http://www.dibspayment.com/'
 
-      self.live_url = "https://api.dibspayment.com/merchant/v1/JSON/Transaction/"
+      self.live_url = 'https://api.dibspayment.com/merchant/v1/JSON/Transaction/'
 
-      self.supported_countries = ["US", "FI", "NO", "SE", "GB"]
-      self.default_currency = "USD"
+      self.supported_countries = ['US', 'FI', 'NO', 'SE', 'GB']
+      self.default_currency = 'USD'
       self.money_format = :cents
       self.supported_cardtypes = [:visa, :master, :american_express, :discover]
 
@@ -89,12 +89,12 @@ module ActiveMerchant #:nodoc:
       private
 
       CURRENCY_CODES = Hash.new{|h,k| raise ArgumentError.new("Unsupported currency: #{k}")}
-      CURRENCY_CODES["USD"] = "840"
-      CURRENCY_CODES["DKK"] = "208"
-      CURRENCY_CODES["NOK"] = "578"
-      CURRENCY_CODES["SEK"] = "752"
-      CURRENCY_CODES["GBP"] = "826"
-      CURRENCY_CODES["EUR"] = "978"
+      CURRENCY_CODES['USD'] = '840'
+      CURRENCY_CODES['DKK'] = '208'
+      CURRENCY_CODES['NOK'] = '578'
+      CURRENCY_CODES['SEK'] = '752'
+      CURRENCY_CODES['GBP'] = '826'
+      CURRENCY_CODES['EUR'] = '978'
 
       def add_invoice(post, money, options)
         post[:orderId] = options[:order_id] || generate_unique_id
@@ -114,7 +114,7 @@ module ActiveMerchant #:nodoc:
         post[:startMonth] = payment_method.start_month if payment_method.start_month
         post[:startYear] = payment_method.start_year if payment_method.start_year
         post[:issueNumber] = payment_method.issue_number if payment_method.issue_number
-        post[:clientIp] = options[:ip] || "127.0.0.1"
+        post[:clientIp] = options[:ip] || '127.0.0.1'
         post[:test] = true if test?
       end
 
@@ -128,12 +128,12 @@ module ActiveMerchant #:nodoc:
       end
 
       ACTIONS = {
-        authorize: "AuthorizeCard",
-        authorize_ticket: "AuthorizeTicket",
-        capture: "CaptureTransaction",
-        void: "CancelTransaction",
-        refund: "RefundTransaction",
-        store: "CreateTicket"
+        authorize: 'AuthorizeCard',
+        authorize_ticket: 'AuthorizeTicket',
+        capture: 'CaptureTransaction',
+        void: 'CancelTransaction',
+        refund: 'RefundTransaction',
+        store: 'CreateTicket'
       }
 
       def commit(action, post)
@@ -155,7 +155,7 @@ module ActiveMerchant #:nodoc:
 
       def headers
         {
-          "Content-Type" => "application/x-www-form-urlencoded"
+          'Content-Type' => 'application/x-www-form-urlencoded'
         }
       end
 
@@ -165,7 +165,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def add_hmac(post)
-        data = post.sort.collect { |key, value| "#{key}=#{value.to_s}" }.join("&")
+        data = post.sort.collect { |key, value| "#{key}=#{value.to_s}" }.join('&')
         digest = OpenSSL::Digest.new('sha256')
         key = [@options[:secret_key]].pack('H*')
         post[:MAC] = OpenSSL::HMAC.hexdigest(digest, key, data)
@@ -180,14 +180,14 @@ module ActiveMerchant #:nodoc:
       end
 
       def success_from(raw_response)
-        raw_response["status"] == "ACCEPT"
+        raw_response['status'] == 'ACCEPT'
       end
 
       def message_from(succeeded, response)
         if succeeded
-          "Succeeded"
+          'Succeeded'
         else
-          response["status"] + ": " + response["declineReason"] || "Unable to read error message"
+          response['status'] + ': ' + response['declineReason'] || 'Unable to read error message'
         end
       end
 
@@ -196,7 +196,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def unparsable_response(raw_response)
-        message = "Invalid JSON response received from Dibs. Please contact Dibs if you continue to receive this message."
+        message = 'Invalid JSON response received from Dibs. Please contact Dibs if you continue to receive this message.'
         message += " (The raw response returned by the API was #{raw_response.inspect})"
         return Response.new(false, message)
       end