activemerchant 1.79.2 → 1.80.0

data/lib/active_merchant/billing/gateways/s5.rb

@@ -80,7 +80,7 @@ module ActiveMerchant #:nodoc:
 
       def store(payment, options = {})
         request = build_xml_request do |xml|
-          xml.Payment(code: SUPPORTED_TRANSACTIONS["store"])
+          xml.Payment(code: SUPPORTED_TRANSACTIONS['store'])
           add_account(xml, payment)
           add_customer(xml, payment, options)
           add_recurrence_mode(xml, options)
@@ -174,20 +174,20 @@ module ActiveMerchant #:nodoc:
 
       def add_recurrence_mode(xml, options)
         if options[:recurring] == true
-          xml.Recurrence(mode: "REPEATED")
+          xml.Recurrence(mode: 'REPEATED')
         else
-          xml.Recurrence(mode: "INITIAL")
+          xml.Recurrence(mode: 'INITIAL')
         end
       end
 
       def parse(body)
         results  = {}
         xml = Nokogiri::XML(body)
-        resp = xml.xpath("//Response/Transaction/Identification")
+        resp = xml.xpath('//Response/Transaction/Identification')
         resp.children.each do |element|
           results[element.name.downcase.to_sym] = element.text
         end
-        resp = xml.xpath("//Response/Transaction/Processing")
+        resp = xml.xpath('//Response/Transaction/Processing')
         resp.children.each do |element|
           results[element.name.downcase.to_sym] = element.text
         end

data/lib/active_merchant/billing/gateways/safe_charge.rb

@@ -23,7 +23,7 @@ module ActiveMerchant #:nodoc:
       def purchase(money, payment, options={})
         post = {}
         post[:sg_APIType] = 1 if options[:three_d_secure]
-        trans_type = options[:three_d_secure] ? "Sale3D" : "Sale"
+        trans_type = options[:three_d_secure] ? 'Sale3D' : 'Sale'
         add_transaction_data(trans_type, post, money, options)
         add_payment(post, payment, options)
         add_customer_details(post, payment, options)
@@ -33,7 +33,7 @@ module ActiveMerchant #:nodoc:
 
       def authorize(money, payment, options={})
         post = {}
-        add_transaction_data("Auth", post, money, options)
+        add_transaction_data('Auth', post, money, options)
         add_payment(post, payment, options)
         add_customer_details(post, payment, options)
 
@@ -42,8 +42,8 @@ module ActiveMerchant #:nodoc:
 
       def capture(money, authorization, options={})
         post = {}
-        auth, transaction_id, token, exp_month, exp_year, _, original_currency = authorization.split("|")
-        add_transaction_data("Settle", post, money, (options.merge!({currency: original_currency})))
+        auth, transaction_id, token, exp_month, exp_year, _, original_currency = authorization.split('|')
+        add_transaction_data('Settle', post, money, (options.merge!({currency: original_currency})))
         post[:sg_AuthCode] = auth
         post[:sg_TransactionID] = transaction_id
         post[:sg_CCToken] = token
@@ -55,8 +55,8 @@ module ActiveMerchant #:nodoc:
 
       def refund(money, authorization, options={})
         post = {}
-        auth, transaction_id, token, exp_month, exp_year, _, original_currency = authorization.split("|")
-        add_transaction_data("Credit", post, money, (options.merge!({currency: original_currency})))
+        auth, transaction_id, token, exp_month, exp_year, _, original_currency = authorization.split('|')
+        add_transaction_data('Credit', post, money, (options.merge!({currency: original_currency})))
         post[:sg_CreditType] = 2
         post[:sg_AuthCode] = auth
         post[:sg_TransactionID] = transaction_id
@@ -70,7 +70,7 @@ module ActiveMerchant #:nodoc:
       def credit(money, payment, options={})
         post = {}
         add_payment(post, payment, options)
-        add_transaction_data("Credit", post, money, options)
+        add_transaction_data('Credit', post, money, options)
         post[:sg_CreditType] = 1
 
         commit(post)
@@ -78,8 +78,8 @@ module ActiveMerchant #:nodoc:
 
       def void(authorization, options={})
         post = {}
-        auth, transaction_id, token, exp_month, exp_year, original_amount, original_currency = authorization.split("|")
-        add_transaction_data("Void", post, (original_amount.to_f * 100), (options.merge!({currency: original_currency})))
+        auth, transaction_id, token, exp_month, exp_year, original_amount, original_currency = authorization.split('|')
+        add_transaction_data('Void', post, (original_amount.to_f * 100), (options.merge!({currency: original_currency})))
         post[:sg_CreditType] = 2
         post[:sg_AuthCode] = auth
         post[:sg_TransactionID] = transaction_id
@@ -116,7 +116,7 @@ module ActiveMerchant #:nodoc:
         post[:sg_Amount] = amount(money)
         post[:sg_ClientLoginID] = @options[:client_login_id]
         post[:sg_ClientPassword] = @options[:client_password]
-        post[:sg_ResponseFormat] = "4"
+        post[:sg_ResponseFormat] = '4'
         post[:sg_Version] = VERSION
         post[:sg_ClientUniqueID] = options[:order_id] if options[:order_id]
         post[:sg_UserID] = options[:user_id] if options[:user_id]
@@ -202,11 +202,11 @@ module ActiveMerchant #:nodoc:
       end
 
       def success_from(response)
-        response[:status] == "APPROVED"
+        response[:status] == 'APPROVED'
       end
 
       def message_from(response)
-        return "Success" if success_from(response)
+        return 'Success' if success_from(response)
         response[:reason_codes] || response[:reason]
       end
 
@@ -219,11 +219,11 @@ module ActiveMerchant #:nodoc:
           parameters[:sg_ExpYear],
           parameters[:sg_Amount],
           parameters[:sg_Currency]
-        ].join("|")
+        ].join('|')
       end
 
       def split_authorization(authorization)
-        auth_code, transaction_id, token, month, year, original_amount = authorization.split("|")
+        auth_code, transaction_id, token, month, year, original_amount = authorization.split('|')
 
         {
           auth_code: auth_code,
@@ -241,7 +241,7 @@ module ActiveMerchant #:nodoc:
         params.map do |key, value|
           next if value != false && value.blank?
           "#{key}=#{CGI.escape(value.to_s)}"
-        end.compact.join("&")
+        end.compact.join('&')
       end
 
       def error_code_from(response)
@@ -254,7 +254,7 @@ module ActiveMerchant #:nodoc:
         camel_cased_word.to_s.gsub(/::/, '/').
           gsub(/([A-Z]+)([A-Z][a-z])/,'\1_\2').
           gsub(/([a-z\d])([A-Z])/,'\1_\2').
-          tr("-", "_").
+          tr('-', '_').
           downcase
       end
     end

data/lib/active_merchant/billing/gateways/sage.rb

@@ -19,8 +19,8 @@ module ActiveMerchant #:nodoc:
         :refund             => '10'
       }
 
-      SOURCE_CARD   = "bankcard"
-      SOURCE_ECHECK =  "virtual_check"
+      SOURCE_CARD   = 'bankcard'
+      SOURCE_ECHECK =  'virtual_check'
 
       def initialize(options = {})
         requires!(options, :login, :password)
@@ -36,7 +36,7 @@ module ActiveMerchant #:nodoc:
 
       def purchase(money, payment_method, options = {})
         post = {}
-        if card_brand(payment_method) == "check"
+        if card_brand(payment_method) == 'check'
           source = SOURCE_ECHECK
           add_check(post, payment_method)
           add_check_customer_data(post, options)
@@ -59,13 +59,13 @@ module ActiveMerchant #:nodoc:
       def void(reference, options = {})
         post = {}
         add_reference(post, reference)
-        source = reference.split(";").last
+        source = reference.split(';').last
         commit(:void, post, source)
       end
 
       def credit(money, payment_method, options = {})
         post = {}
-        if card_brand(payment_method) == "check"
+        if card_brand(payment_method) == 'check'
           source = SOURCE_ECHECK
           add_check(post, payment_method)
           add_check_customer_data(post, options)
@@ -115,8 +115,8 @@ module ActiveMerchant #:nodoc:
       # use the same method as in pay_conex
       def force_utf8(string)
         return nil unless string
-        binary = string.encode("BINARY", invalid: :replace, undef: :replace, replace: "?")   # Needed for Ruby 2.0 since #encode is a no-op if the string is already UTF-8. It's not needed for Ruby 2.1 and up since it's not a no-op there.
-        binary.encode("UTF-8", invalid: :replace, undef: :replace, replace: "?")
+        binary = string.encode('BINARY', invalid: :replace, undef: :replace, replace: '?')   # Needed for Ruby 2.0 since #encode is a no-op if the string is already UTF-8. It's not needed for Ruby 2.1 and up since it's not a no-op there.
+        binary.encode('UTF-8', invalid: :replace, undef: :replace, replace: '?')
       end
 
       def add_credit_card(post, credit_card)
@@ -143,7 +143,7 @@ module ActiveMerchant #:nodoc:
         # RCK for Returned Checks
         # ARC for Account Receivable Entry
         # TEL for TelephoneInitiated
-        post[:C_customer_type] = "WEB"
+        post[:C_customer_type] = 'WEB'
 
         # Optional  10  Digit Originator  ID – Assigned  By for  each transaction  class  or  business  purpose. If  not provided, the default Originator ID for the specific  Customer Type will be applied. 
         post[:C_originator_id] = options[:originator_id]
@@ -160,7 +160,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def format_birth_date(date)
-        date.respond_to?(:strftime) ? date.strftime("%m/%d/%Y") : date
+        date.respond_to?(:strftime) ? date.strftime('%m/%d/%Y') : date
       end
 
       # DDA for Checking
@@ -214,7 +214,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def add_reference(post, reference)
-        ref, _ = reference.to_s.split(";")
+        ref, _ = reference.to_s.split(';')
         post[:T_reference] = ref
       end
 
@@ -231,7 +231,7 @@ module ActiveMerchant #:nodoc:
 
         post[:C_address]    = billing_address[:address1]
         post[:C_city]       = billing_address[:city]
-        post[:C_state]      = empty?(billing_address[:state]) ? "Outside of US" : billing_address[:state]
+        post[:C_state]      = empty?(billing_address[:state]) ? 'Outside of US' : billing_address[:state]
         post[:C_zip]        = billing_address[:zip]
         post[:C_country]    = billing_address[:country]
         post[:C_telephone]  = billing_address[:phone]
@@ -288,7 +288,7 @@ module ActiveMerchant #:nodoc:
         params[:M_key] = @options[:password]
         params[:T_code] = TRANSACTIONS[action]
 
-        params.collect { |key, value| "#{key}=#{CGI.escape(value.to_s)}" }.join("&")
+        params.collect { |key, value| "#{key}=#{CGI.escape(value.to_s)}" }.join('&')
       end
 
       def vault
@@ -357,8 +357,8 @@ module ActiveMerchant #:nodoc:
         end
 
         def exp_date(credit_card)
-          year  = sprintf("%.4i", credit_card.year)
-          month = sprintf("%.2i", credit_card.month)
+          year  = sprintf('%.4i', credit_card.year)
+          month = sprintf('%.2i', credit_card.month)
 
           "#{month}#{year[-2..-1]}"
         end
@@ -384,8 +384,8 @@ module ActiveMerchant #:nodoc:
         end
 
         ENVELOPE_NAMESPACES = {
-          'xmlns:SOAP-ENV' => "http://schemas.xmlsoap.org/soap/envelope/",
-          'xmlns:ns1' => "https://www.sagepayments.net/web_services/wsVault/wsVault"
+          'xmlns:SOAP-ENV' => 'http://schemas.xmlsoap.org/soap/envelope/',
+          'xmlns:ns1' => 'https://www.sagepayments.net/web_services/wsVault/wsVault'
         }
 
         ACTION_ELEMENTS = {
@@ -415,8 +415,8 @@ module ActiveMerchant #:nodoc:
 
         def build_headers(action)
           {
-            "SOAPAction" => SOAP_ACTIONS[action],
-            "Content-Type" => "text/xml; charset=utf-8"
+            'SOAPAction' => SOAP_ACTIONS[action],
+            'Content-Type' => 'text/xml; charset=utf-8'
           }
         end
 
@@ -430,12 +430,12 @@ module ActiveMerchant #:nodoc:
           xml = REXML::Document.new(xml)
 
           # Store
-          xml.elements.each("//Table1/*") do |node|
+          xml.elements.each('//Table1/*') do |node|
             response[node.name.underscore.to_sym] = node.text
           end
 
           # Unstore
-          xml.elements.each("//DELETE_DATAResponse/*") do |node|
+          xml.elements.each('//DELETE_DATAResponse/*') do |node|
             response[node.name.underscore.to_sym] = node.text
           end
         end

data/lib/active_merchant/billing/gateways/sage_pay.rb

@@ -25,30 +25,30 @@ module ActiveMerchant #:nodoc:
       }
 
       CREDIT_CARDS = {
-        :visa => "VISA",
-        :master => "MC",
-        :delta => "DELTA",
-        :solo => "SOLO",
-        :switch => "MAESTRO",
-        :maestro => "MAESTRO",
-        :american_express => "AMEX",
-        :electron => "UKE",
-        :diners_club => "DC",
-        :jcb => "JCB"
+        :visa => 'VISA',
+        :master => 'MC',
+        :delta => 'DELTA',
+        :solo => 'SOLO',
+        :switch => 'MAESTRO',
+        :maestro => 'MAESTRO',
+        :american_express => 'AMEX',
+        :electron => 'UKE',
+        :diners_club => 'DC',
+        :jcb => 'JCB'
       }
 
       AVS_CODE = {
-        "NOTPROVIDED" => nil,
-        "NOTCHECKED" => 'X',
-        "MATCHED" => 'Y',
-        "NOTMATCHED" => 'N'
+        'NOTPROVIDED' => nil,
+        'NOTCHECKED' => 'X',
+        'MATCHED' => 'Y',
+        'NOTMATCHED' => 'N'
       }
 
       CVV_CODE = {
-        "NOTPROVIDED" => 'S',
-        "NOTCHECKED" => 'X',
-        "MATCHED" => 'M',
-        "NOTMATCHED" => 'N'
+        'NOTPROVIDED' => 'S',
+        'NOTCHECKED' => 'X',
+        'MATCHED' => 'M',
+        'NOTMATCHED' => 'N'
       }
 
       OPTIONAL_REQUEST_FIELDS = {
@@ -327,7 +327,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def map_card_type(credit_card)
-        raise ArgumentError, "The credit card type must be provided" if card_brand(credit_card).blank?
+        raise ArgumentError, 'The credit card type must be provided' if card_brand(credit_card).blank?
 
         card_type = card_brand(credit_card).to_sym
 
@@ -342,8 +342,8 @@ module ActiveMerchant #:nodoc:
       def format_date(month, year)
         return nil if year.blank? || month.blank?
 
-        year  = sprintf("%.4i", year)
-        month = sprintf("%.2i", month)
+        year  = sprintf('%.4i', year)
+        month = sprintf('%.2i', month)
 
         "#{month}#{year[-2..-1]}"
       end
@@ -351,14 +351,14 @@ module ActiveMerchant #:nodoc:
       def commit(action, parameters)
         response = parse( ssl_post(url_for(action), post_data(action, parameters)) )
 
-        Response.new(response["Status"] == APPROVED, message_from(response), response,
+        Response.new(response['Status'] == APPROVED, message_from(response), response,
           :test => test?,
           :authorization => authorization_from(response, parameters, action),
           :avs_result => {
-            :street_match => AVS_CODE[ response["AddressResult"] ],
-            :postal_match => AVS_CODE[ response["PostCodeResult"] ],
+            :street_match => AVS_CODE[ response['AddressResult'] ],
+            :postal_match => AVS_CODE[ response['PostCodeResult'] ],
           },
-          :cvv_result => CVV_CODE[ response["CV2Result"] ]
+          :cvv_result => CVV_CODE[ response['CV2Result'] ]
         )
       end
 
@@ -368,10 +368,10 @@ module ActiveMerchant #:nodoc:
           response['Token']
         else
          [ params[:VendorTxCode],
-           response["VPSTxId"] || params[:VPSTxId],
-           response["TxAuthNo"],
-           response["SecurityKey"] || params[:SecurityKey],
-           action ].join(";")
+           response['VPSTxId'] || params[:VPSTxId],
+           response['TxAuthNo'],
+           response['SecurityKey'] || params[:SecurityKey],
+           action ].join(';')
         end
       end
 
@@ -386,7 +386,7 @@ module ActiveMerchant #:nodoc:
 
       def build_url(action)
         endpoint = case action
-          when :purchase, :authorization then "vspdirect-register"
+          when :purchase, :authorization then 'vspdirect-register'
           when :store then 'directtoken'
           else TRANSACTIONS[action].downcase
         end
@@ -394,7 +394,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def build_simulator_url(action)
-        endpoint = [ :purchase, :authorization ].include?(action) ? "VSPDirectGateway.asp" : "VSPServerGateway.asp?Service=Vendor#{TRANSACTIONS[action].capitalize}Tx"
+        endpoint = [ :purchase, :authorization ].include?(action) ? 'VSPDirectGateway.asp' : "VSPServerGateway.asp?Service=Vendor#{TRANSACTIONS[action].capitalize}Tx"
         "#{self.simulator_url}/#{endpoint}"
       end
 
@@ -413,7 +413,7 @@ module ActiveMerchant #:nodoc:
           parameters.update(:ReferrerID => application_id)
         end
 
-        parameters.collect { |key, value| "#{key}=#{CGI.escape(value.to_s)}" }.join("&")
+        parameters.collect { |key, value| "#{key}=#{CGI.escape(value.to_s)}" }.join('&')
       end
 
       # SagePay returns data in the following format

data/lib/active_merchant/billing/gateways/sallie_mae.rb

@@ -21,7 +21,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def test?
-        @options[:login] == "TEST0"
+        @options[:login] == 'TEST0'
       end
 
       def authorize(money, creditcard, options = {})
@@ -94,11 +94,11 @@ module ActiveMerchant #:nodoc:
 
       def parse(body)
         h = {}
-        body.gsub!("<html><body><plaintext>", "")
+        body.gsub!('<html><body><plaintext>', '')
         body.
           split("\r\n").
           map do |i|
-            a = i.split("=")
+            a = i.split('=')
             h[a.first] = a.last unless a.first.nil?
           end
         h
@@ -111,30 +111,30 @@ module ActiveMerchant #:nodoc:
 
         case action
         when :sale
-          parameters[:action] = "ns_quicksale_cc"
+          parameters[:action] = 'ns_quicksale_cc'
         when :authonly
-          parameters[:action] = "ns_quicksale_cc"
+          parameters[:action] = 'ns_quicksale_cc'
           parameters[:authonly] = 1
         when :capture
-          parameters[:action] = "ns_quicksale_cc"
+          parameters[:action] = 'ns_quicksale_cc'
         end
 
-        response = parse(ssl_post(self.live_url, parameters.to_post_data) || "")
+        response = parse(ssl_post(self.live_url, parameters.to_post_data) || '')
         Response.new(successful?(response), message_from(response), response,
           :test => test?,
-          :authorization => response["refcode"]
+          :authorization => response['refcode']
         )
       end
 
       def successful?(response)
-        response["Status"] == "Accepted"
+        response['Status'] == 'Accepted'
       end
 
       def message_from(response)
         if successful?(response)
-          "Accepted"
+          'Accepted'
         else
-          response["Reason"].split(":")[2].capitalize unless response["Reason"].nil?
+          response['Reason'].split(':')[2].capitalize unless response['Reason'].nil?
         end
       end
     end