chrome-devtools-frontend 1.0.1726686 → 1.0.1730971

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (490) hide show
  1. package/.agents/rules/tests/test-strict-assertions-and-literal-expectations.md +1 -1
  2. package/.agents/rules/tests/test-view-and-presenter-isolation.md +1 -1
  3. package/.agents/rules/ui-and-widgets/ui-accessibility-and-semantic-html.md +1 -1
  4. package/.agents/rules/ui-and-widgets/ui-css-scoping-and-flex-layout.md +2 -2
  5. package/.agents/rules/ui-and-widgets/ui-declarative-child-widget-composition.md +5 -5
  6. package/.agents/rules/ui-and-widgets/ui-lit-declarative-templates-and-directives.md +2 -2
  7. package/.agents/rules/ui-and-widgets/ui-localization-and-uistrings-hygiene.md +2 -2
  8. package/.agents/rules/ui-and-widgets/ui-modern-component-and-encapsulation-standards.md +3 -3
  9. package/.agents/rules/ui-and-widgets/ui-pure-view-and-presenter-separation.md +2 -2
  10. package/.agents/rules/ui-and-widgets/ui-reactive-widget-update-lifecycle.md +2 -2
  11. package/.agents/rules/ui-and-widgets/ui-view-output-and-callback-contracts.md +2 -2
  12. package/.agents/rules/ui-and-widgets/ui-widget-dom-and-listener-lifecycle.md +2 -2
  13. package/.agents/skills/code-review/SKILL.md +63 -12
  14. package/.agents/skills/ui-eng-vision-local-lit-renderer/SKILL.md +38 -10
  15. package/.agents/skills/ui-eng-vision-widget-promoter/SKILL.md +1 -0
  16. package/.agents/skills/ui-widgets/SKILL.md +8 -2
  17. package/.agents/skills/write-ai-eval-test/SKILL.md +106 -0
  18. package/AUTHORS +2 -0
  19. package/DIR_METADATA +1 -2
  20. package/README.md +48 -26
  21. package/config/typescript/tsconfig.base.json +1 -0
  22. package/config/typescript/tsconfig.eslint.json +1 -0
  23. package/docs/contributing/changes.md +25 -0
  24. package/docs/ui_engineering.md +13 -4
  25. package/eslint.config.mjs +323 -41
  26. package/front_end/core/common/Color.ts +7 -7
  27. package/front_end/core/common/ParsedURL.ts +3 -3
  28. package/front_end/core/common/ResolverBase.ts +3 -3
  29. package/front_end/core/common/SegmentedRange.ts +3 -3
  30. package/front_end/core/common/SimpleHistoryManager.ts +14 -14
  31. package/front_end/core/common/Trie.ts +3 -3
  32. package/front_end/core/common/VersionController.ts +7 -7
  33. package/front_end/core/host/InspectorFrontendHost.ts +2 -2
  34. package/front_end/core/host/InspectorFrontendHostAPI.ts +9 -1
  35. package/front_end/core/host/InspectorFrontendHostStub.ts +1 -1
  36. package/front_end/core/host/UserMetrics.ts +4 -0
  37. package/front_end/core/host/UserMetricsEnums.ts +2 -1
  38. package/front_end/core/platform/StringUtilities.ts +54 -13
  39. package/front_end/core/platform/node/HostRuntime.ts +13 -7
  40. package/front_end/core/protocol_client/DevToolsCDPConnection.ts +4 -5
  41. package/front_end/core/root/Runtime.ts +5 -0
  42. package/front_end/core/sdk/AccessibilityModel.ts +5 -5
  43. package/front_end/core/sdk/AnimationModel.ts +17 -19
  44. package/front_end/core/sdk/CPUProfilerModel.ts +3 -3
  45. package/front_end/core/sdk/CPUThrottlingManager.ts +7 -0
  46. package/front_end/core/sdk/CSSMatchedStyles.ts +73 -13
  47. package/front_end/core/sdk/CSSMetadata.ts +7 -7
  48. package/front_end/core/sdk/CSSModel.ts +33 -33
  49. package/front_end/core/sdk/CSSProperty.ts +5 -5
  50. package/front_end/core/sdk/CSSRule.ts +6 -6
  51. package/front_end/core/sdk/CSSStyleSheetHeader.ts +4 -4
  52. package/front_end/core/sdk/Connections.ts +16 -16
  53. package/front_end/core/sdk/ConsoleModel.ts +44 -47
  54. package/front_end/core/sdk/CookieParser.ts +11 -11
  55. package/front_end/core/sdk/EmulationModel.ts +35 -36
  56. package/front_end/core/sdk/EventBreakpointsModel.ts +11 -11
  57. package/front_end/core/sdk/FrameManager.ts +16 -16
  58. package/front_end/core/sdk/IsolateManager.ts +2 -2
  59. package/front_end/core/sdk/IssuesModel.ts +2 -2
  60. package/front_end/core/sdk/OverlayModel.ts +19 -19
  61. package/front_end/core/sdk/PageResourceLoader.ts +14 -16
  62. package/front_end/core/sdk/RemoteObject.ts +9 -9
  63. package/front_end/core/sdk/Resource.ts +2 -2
  64. package/front_end/core/sdk/RuntimeModel.ts +7 -7
  65. package/front_end/core/sdk/Script.ts +6 -6
  66. package/front_end/core/sdk/ServiceWorkerManager.ts +36 -10
  67. package/front_end/core/sdk/SourceMap.ts +18 -20
  68. package/front_end/core/sdk/SourceMapManager.ts +2 -2
  69. package/front_end/core/sdk/TargetManager.ts +2 -2
  70. package/front_end/devtools_compatibility.js +7 -3
  71. package/front_end/entrypoints/inspector_main/InspectorMain.ts +2 -2
  72. package/front_end/entrypoints/node_app/app/NodeConnectionsPanel.ts +203 -115
  73. package/front_end/generated/InspectorBackendCommands.ts +1 -1
  74. package/front_end/generated/SupportedCSSProperties.ts +1 -3
  75. package/front_end/generated/protocol.ts +1 -0
  76. package/front_end/models/ai_assistance/AiAgent2.ts +36 -12
  77. package/front_end/models/ai_assistance/AiConversation.ts +8 -2
  78. package/front_end/models/ai_assistance/agents/AiAgent.ts +137 -62
  79. package/front_end/models/ai_assistance/agents/ExecuteJavascript.ts +2 -2
  80. package/front_end/models/ai_assistance/agents/StylingAgent.snapshot.txt +2 -2
  81. package/front_end/models/ai_assistance/data_formatters/LighthouseFormatter.snapshot.txt +149 -2
  82. package/front_end/models/ai_assistance/data_formatters/LighthouseFormatter.ts +269 -42
  83. package/front_end/models/ai_assistance/tools/ExecuteJavaScript.ts +3 -0
  84. package/front_end/models/ai_assistance/tools/GetLighthouseAudits.ts +9 -0
  85. package/front_end/models/ai_assistance/tools/ResolveDevtoolsNodePath.ts +13 -2
  86. package/front_end/models/ai_assistance/tools/RunLighthouse.ts +23 -7
  87. package/front_end/models/ai_assistance/tools/Tool.ts +7 -5
  88. package/front_end/models/bindings/CSSWorkspaceBinding.ts +22 -24
  89. package/front_end/models/bindings/DebuggerLanguagePlugins.ts +60 -60
  90. package/front_end/models/bindings/DebuggerWorkspaceBinding.ts +24 -24
  91. package/front_end/models/bindings/DefaultScriptMapping.ts +8 -8
  92. package/front_end/models/bindings/FileUtils.ts +13 -13
  93. package/front_end/models/bindings/PresentationConsoleMessageHelper.ts +3 -3
  94. package/front_end/models/bindings/ResourceScriptMapping.ts +23 -23
  95. package/front_end/models/comment_manager/CommentManager.ts +3 -3
  96. package/front_end/models/comment_manager/CommentThread.ts +50 -5
  97. package/front_end/models/cpu_profile/CPUProfileDataModel.ts +14 -14
  98. package/front_end/models/cpu_profile/ProfileTreeModel.ts +4 -4
  99. package/front_end/models/elements/StyleChanges.ts +38 -0
  100. package/front_end/models/emulation/EmulatedDevices.ts +12 -12
  101. package/front_end/models/har/HARFormat.ts +4 -4
  102. package/front_end/models/javascript_metadata/NativeFunctions.ts +5 -1
  103. package/front_end/models/lighthouse/LighthouseReporterTypes.ts +57 -3
  104. package/front_end/models/lighthouse/RunTypes.ts +9 -1
  105. package/front_end/models/logs/LogManager.ts +2 -2
  106. package/front_end/models/persistence/AutomaticFileSystemManager.ts +3 -0
  107. package/front_end/models/persistence/FileSystemWorkspaceBinding.ts +24 -24
  108. package/front_end/models/persistence/IsolatedFileSystemManager.ts +6 -0
  109. package/front_end/models/persistence/NetworkPersistenceManager.ts +8 -3
  110. package/front_end/models/trace/LanternComputationData.ts +37 -11
  111. package/front_end/models/trace/Processor.ts +2 -1
  112. package/front_end/models/trace/extras/TraceTree.ts +36 -10
  113. package/front_end/models/trace/handlers/InitiatorsHandler.ts +27 -34
  114. package/front_end/models/trace/handlers/LayoutShiftsHandler.ts +2 -6
  115. package/front_end/models/trace/handlers/SamplesHandler.ts +9 -6
  116. package/front_end/models/workspace/FileManager.ts +6 -0
  117. package/front_end/panels/accessibility/ARIAAttributesView.ts +4 -4
  118. package/front_end/panels/accessibility/AccessibilityAnnouncementRecordingView.ts +8 -1
  119. package/front_end/panels/accessibility/AccessibilityNodeView.ts +15 -17
  120. package/front_end/panels/accessibility/AccessibilitySubPane.ts +1 -1
  121. package/front_end/panels/ai_assistance/AiAssistancePanel.ts +5 -5
  122. package/front_end/panels/ai_assistance/ExternalHandler.ts +10 -1
  123. package/front_end/panels/ai_assistance/components/ChatMessage.ts +27 -22
  124. package/front_end/panels/ai_assistance/components/DisabledWidget.ts +19 -23
  125. package/front_end/panels/ai_assistance/components/ExploreWidget.ts +2 -2
  126. package/front_end/panels/ai_assistance/components/PermissionPrompt.ts +23 -9
  127. package/front_end/panels/ai_assistance/components/chatInput.css +1 -1
  128. package/front_end/panels/animation/AnimationTimeline.ts +37 -17
  129. package/front_end/panels/animation/animationTimeline.css +19 -3
  130. package/front_end/panels/application/AppManifestView.ts +1 -2
  131. package/front_end/panels/application/ApplicationPanelSidebar.ts +143 -128
  132. package/front_end/panels/application/DOMStorageItemsView.ts +14 -14
  133. package/front_end/panels/application/DeviceBoundSessionsView.ts +10 -13
  134. package/front_end/panels/application/ExtensionStorageItemsView.ts +3 -4
  135. package/front_end/panels/application/IndexedDBViews.ts +8 -4
  136. package/front_end/panels/application/KeyValueStorageItemsView.ts +4 -5
  137. package/front_end/panels/application/PrivateVerificationTokensView.ts +53 -0
  138. package/front_end/panels/application/ServiceWorkerCacheViews.ts +12 -8
  139. package/front_end/panels/application/ServiceWorkersView.ts +1 -2
  140. package/front_end/panels/application/StorageItemsToolbar.ts +3 -3
  141. package/front_end/panels/application/StorageView.ts +2 -2
  142. package/front_end/panels/application/WebMCPView.ts +91 -109
  143. package/front_end/panels/application/application.ts +2 -0
  144. package/front_end/panels/application/components/StorageMetadataView.ts +6 -6
  145. package/front_end/panels/application/preloading/PreloadingView.ts +70 -37
  146. package/front_end/panels/application/preloading/components/MismatchedPreloadingGrid.ts +2 -2
  147. package/front_end/panels/application/preloading/components/PreloadingDisabledInfobar.ts +3 -3
  148. package/front_end/panels/application/preloading/components/PreloadingGrid.ts +12 -0
  149. package/front_end/panels/application/preloading/components/RuleSetDetailsView.ts +10 -11
  150. package/front_end/panels/application/privateVerificationTokensView.css +20 -0
  151. package/front_end/panels/application/serviceWorkersView.css +2 -2
  152. package/front_end/panels/browser_debugger/DOMBreakpointsSidebarPane.ts +24 -24
  153. package/front_end/panels/changes/ChangesSidebar.ts +5 -5
  154. package/front_end/panels/changes/ChangesView.ts +10 -11
  155. package/front_end/panels/comments/CommentsPane.ts +292 -102
  156. package/front_end/panels/comments/commentsPane.css +93 -12
  157. package/front_end/panels/common/CommentThreadWidget.ts +69 -0
  158. package/front_end/panels/common/CommentsOverlayWidget.ts +108 -29
  159. package/front_end/panels/common/CommentsStatusBarPill.ts +17 -6
  160. package/front_end/panels/common/DOMLinkifier.ts +37 -12
  161. package/front_end/panels/common/ExtensionPanel.ts +13 -4
  162. package/front_end/panels/common/ExtensionServer.ts +27 -3
  163. package/front_end/panels/common/PersistenceUtils.ts +3 -3
  164. package/front_end/panels/common/commentThreadWidget.css +25 -1
  165. package/front_end/panels/common/common-meta.ts +10 -0
  166. package/front_end/panels/console/ConsolePinPane.ts +13 -15
  167. package/front_end/panels/console/ConsolePrompt.ts +173 -95
  168. package/front_end/panels/console/ConsoleSidebar.ts +2 -2
  169. package/front_end/panels/console/ConsoleView.ts +75 -79
  170. package/front_end/panels/console/ConsoleViewMessage.ts +52 -4
  171. package/front_end/panels/console/SymbolizedErrorWidget.ts +8 -4
  172. package/front_end/panels/console/consolePrompt.css +1 -1
  173. package/front_end/panels/console/consoleView.css +1 -1
  174. package/front_end/panels/console_counters/WarningErrorCounter.ts +3 -4
  175. package/front_end/panels/coverage/CoverageListView.ts +2 -2
  176. package/front_end/panels/coverage/CoverageView.ts +20 -5
  177. package/front_end/panels/css_overview/CSSOverviewCompletedView.ts +4 -3
  178. package/front_end/panels/css_overview/CSSOverviewPanel.ts +2 -2
  179. package/front_end/panels/css_overview/CSSOverviewProcessingView.ts +2 -2
  180. package/front_end/panels/css_overview/CSSOverviewSidebarPanel.ts +2 -2
  181. package/front_end/panels/css_overview/CSSOverviewStartView.ts +2 -2
  182. package/front_end/panels/css_overview/CSSOverviewUnusedDeclarations.ts +8 -8
  183. package/front_end/panels/developer_resources/DeveloperResourcesListView.ts +2 -3
  184. package/front_end/panels/developer_resources/DeveloperResourcesView.ts +4 -5
  185. package/front_end/panels/elements/AccessibilityTreeUtils.ts +6 -7
  186. package/front_end/panels/elements/CSSValueTraceView.ts +3 -3
  187. package/front_end/panels/elements/ClassesPaneWidget.ts +1 -2
  188. package/front_end/panels/elements/ComputedStyleWidget.ts +15 -14
  189. package/front_end/panels/elements/DOMTreeElementWidget.ts +5 -4
  190. package/front_end/panels/elements/DOMTreeWidget.ts +2 -1
  191. package/front_end/panels/elements/ElementStatePaneWidget.ts +2 -2
  192. package/front_end/panels/elements/ElementsPanel.ts +1 -0
  193. package/front_end/panels/elements/EventListenersWidget.ts +2 -2
  194. package/front_end/panels/elements/LayoutPane.ts +2 -2
  195. package/front_end/panels/elements/PlatformFontsWidget.ts +3 -3
  196. package/front_end/panels/elements/PropertiesWidget.ts +9 -10
  197. package/front_end/panels/elements/PropertyRenderer.ts +72 -11
  198. package/front_end/panels/elements/StandaloneStylesContainer.ts +5 -10
  199. package/front_end/panels/elements/StyleEditorWidget.ts +30 -16
  200. package/front_end/panels/elements/StylePropertiesSection.ts +93 -44
  201. package/front_end/panels/elements/StylePropertyTreeElement.ts +230 -302
  202. package/front_end/panels/elements/StylesContainer.ts +2 -3
  203. package/front_end/panels/elements/StylesSidebarPane.ts +4 -13
  204. package/front_end/panels/elements/components/AccessibilityTreeNode.ts +66 -37
  205. package/front_end/panels/elements/components/CSSHintDetailsView.ts +51 -41
  206. package/front_end/panels/elements/components/CSSPropertyDocsView.ts +75 -65
  207. package/front_end/panels/elements/components/CSSQuery.ts +112 -74
  208. package/front_end/panels/elements/components/CSSVariableValueView.ts +109 -68
  209. package/front_end/panels/elements/components/ComputedStyleProperty.ts +64 -45
  210. package/front_end/panels/elements/components/ElementsTreeExpandButton.ts +35 -28
  211. package/front_end/panels/elements/components/QueryContainer.ts +104 -74
  212. package/front_end/panels/elements/components/accessibilityTreeNode.css +22 -20
  213. package/front_end/panels/elements/components/computedStyleProperty.css +2 -0
  214. package/front_end/panels/elements/components/cssHintDetailsView.css +23 -21
  215. package/front_end/panels/elements/components/cssPropertyDocsView.css +38 -36
  216. package/front_end/panels/elements/components/cssVariableValueView.css +42 -40
  217. package/front_end/panels/elements/components/elementsTreeExpandButton.css +5 -2
  218. package/front_end/panels/elements/components/queryContainer.css +23 -21
  219. package/front_end/panels/elements/stylesSidebarPane.css +3 -3
  220. package/front_end/panels/emulation/DeviceModeToolbar.ts +2 -2
  221. package/front_end/panels/emulation/InspectedPagePlaceholder.ts +2 -2
  222. package/front_end/panels/emulation/MediaQueryInspector.ts +9 -10
  223. package/front_end/panels/emulation/mediaQueryInspector.css +1 -1
  224. package/front_end/panels/event_listeners/EventListenersView.ts +2 -2
  225. package/front_end/panels/issues/AffectedCookiesView.ts +144 -101
  226. package/front_end/panels/issues/AffectedDescendantsWithinSelectElementView.ts +83 -31
  227. package/front_end/panels/issues/AffectedDirectivesView.ts +218 -135
  228. package/front_end/panels/issues/AffectedDocumentsInQuirksModeView.ts +84 -34
  229. package/front_end/panels/issues/AffectedElementsView.ts +86 -23
  230. package/front_end/panels/issues/AffectedLazyLoadImagesView.ts +2 -2
  231. package/front_end/panels/issues/AffectedMetadataAllowedSitesView.ts +2 -2
  232. package/front_end/panels/issues/AffectedPartitioningBlobURLView.ts +36 -11
  233. package/front_end/panels/issues/AffectedSharedArrayBufferIssueDetailsView.ts +135 -58
  234. package/front_end/panels/issues/AffectedSourcesView.ts +49 -28
  235. package/front_end/panels/issues/AffectedTrackingSitesView.ts +3 -4
  236. package/front_end/panels/issues/CorsIssueDetailsView.ts +490 -269
  237. package/front_end/panels/issues/GenericIssueDetailsView.ts +2 -2
  238. package/front_end/panels/issues/IssueKindView.ts +63 -48
  239. package/front_end/panels/issues/IssueView.ts +14 -18
  240. package/front_end/panels/issues/components/ElementsPanelLink.ts +70 -34
  241. package/front_end/panels/issues/components/HideIssuesMenu.ts +56 -32
  242. package/front_end/panels/issues/components/elementsPanelLink.css +10 -6
  243. package/front_end/panels/issues/components/hideIssuesMenu.css +16 -14
  244. package/front_end/panels/issues/issues.ts +2 -0
  245. package/front_end/panels/issues/issuesTree.css +4 -4
  246. package/front_end/panels/lighthouse/LighthouseController.ts +6 -6
  247. package/front_end/panels/lighthouse/LighthouseStatusView.ts +12 -13
  248. package/front_end/panels/lighthouse/lighthouseStartView.css +1 -1
  249. package/front_end/panels/linear_memory_inspector/LinearMemoryInspectorPane.ts +159 -161
  250. package/front_end/panels/linear_memory_inspector/LinearMemoryInspectorView.ts +228 -0
  251. package/front_end/panels/linear_memory_inspector/components/LinearMemoryInspector.ts +32 -41
  252. package/front_end/panels/linear_memory_inspector/components/linearMemoryHighlightChipList.css +2 -2
  253. package/front_end/panels/linear_memory_inspector/linear_memory_inspector.ts +2 -0
  254. package/front_end/panels/media/EventDisplayTable.ts +2 -2
  255. package/front_end/panels/media/MainView.ts +132 -66
  256. package/front_end/panels/media/PlayerDetailView.ts +32 -14
  257. package/front_end/panels/media/PlayerListView.ts +83 -23
  258. package/front_end/panels/media/PlayerPropertiesView.ts +2 -2
  259. package/front_end/panels/media/TickingFlameChart.ts +153 -63
  260. package/front_end/panels/mobile_throttling/NetworkThrottlingSelector.ts +2 -2
  261. package/front_end/panels/mobile_throttling/ThrottlingSettingsTab.ts +615 -464
  262. package/front_end/panels/mobile_throttling/throttlingSettingsTab.css +43 -0
  263. package/front_end/panels/network/EventSourceMessagesView.ts +3 -3
  264. package/front_end/panels/network/NetworkConfigView.ts +6 -2
  265. package/front_end/panels/network/NetworkDataGridNode.ts +2 -1
  266. package/front_end/panels/network/NetworkItemView.ts +27 -26
  267. package/front_end/panels/network/NetworkManageCustomHeadersView.ts +236 -97
  268. package/front_end/panels/network/NetworkOverview.ts +8 -10
  269. package/front_end/panels/network/RequestConditionsDrawer.ts +8 -4
  270. package/front_end/panels/network/RequestDeviceBoundSessionsView.ts +2 -4
  271. package/front_end/panels/network/RequestHTMLView.ts +26 -7
  272. package/front_end/panels/network/RequestHeadersView.ts +2 -2
  273. package/front_end/panels/network/RequestInitiatorView.ts +21 -22
  274. package/front_end/panels/network/RequestPayloadView.ts +2 -16
  275. package/front_end/panels/network/RequestPreviewView.ts +5 -5
  276. package/front_end/panels/network/RequestTimingView.ts +6 -6
  277. package/front_end/panels/network/ResourceDirectSocketChunkView.ts +5 -6
  278. package/front_end/panels/network/ResourceWebSocketFrameView.ts +4 -3
  279. package/front_end/panels/network/ShowMoreDetailsWidget.ts +11 -12
  280. package/front_end/panels/network/SignedExchangeInfoView.ts +2 -2
  281. package/front_end/panels/network/networkLogView.css +2 -2
  282. package/front_end/panels/network/networkManageCustomHeadersView.css +27 -6
  283. package/front_end/panels/network/requestConditionsDrawer.css +1 -1
  284. package/front_end/panels/network/requestInitiatorView.css +5 -3
  285. package/front_end/panels/performance_monitor/PerformanceMonitor.ts +2 -2
  286. package/front_end/panels/profiler/HeapDetachedElementsView.ts +1 -2
  287. package/front_end/panels/profiler/HeapTimelineOverview.ts +77 -15
  288. package/front_end/panels/profiler/IsolateSelector.ts +258 -187
  289. package/front_end/panels/profiler/ProfileLauncherView.ts +7 -29
  290. package/front_end/panels/profiler/profileLauncherView.css +6 -1
  291. package/front_end/panels/protocol_monitor/JSONEditor.ts +4 -5
  292. package/front_end/panels/recorder/ControlButton.ts +1 -1
  293. package/front_end/panels/recorder/RecordingListView.ts +2 -4
  294. package/front_end/panels/recorder/RecordingView.ts +1 -2
  295. package/front_end/panels/recorder/SelectorPicker.ts +2 -4
  296. package/front_end/panels/recorder/StepView.ts +24 -10
  297. package/front_end/panels/recorder/TimelineSection.ts +1 -1
  298. package/front_end/panels/recorder/recordingView.css +1 -1
  299. package/front_end/panels/screencast/ScreencastApp.ts +1 -1
  300. package/front_end/panels/search/SearchResultsPane.ts +11 -12
  301. package/front_end/panels/search/SearchView.ts +8 -10
  302. package/front_end/panels/security/SecurityPanel.ts +1 -8
  303. package/front_end/panels/security/SecurityPanelSidebar.ts +2 -2
  304. package/front_end/panels/security/mainView.css +1 -1
  305. package/front_end/panels/sensors/LocationsSettingsTab.ts +1 -2
  306. package/front_end/panels/settings/AISettingsTab.ts +1 -1
  307. package/front_end/panels/settings/BackendLinkingSettingsTab.ts +34 -20
  308. package/front_end/panels/settings/EditFileSystemView.ts +2 -2
  309. package/front_end/panels/settings/FrameworkIgnoreListSettingsTab.ts +375 -197
  310. package/front_end/panels/settings/KeybindsSettingsTab.ts +570 -414
  311. package/front_end/panels/settings/SettingsScreen.ts +312 -114
  312. package/front_end/panels/settings/WorkspaceSettingsTab.ts +2 -2
  313. package/front_end/panels/settings/aiSettingsTab.css +1 -4
  314. package/front_end/panels/settings/emulation/DevicesSettingsTab.ts +924 -578
  315. package/front_end/panels/settings/emulation/components/UserAgentClientHintsForm.ts +9 -2
  316. package/front_end/panels/settings/emulation/devicesSettingsTab.css +39 -0
  317. package/front_end/panels/settings/frameworkIgnoreListSettingsTab.css +37 -8
  318. package/front_end/panels/settings/settingsScreen.css +0 -24
  319. package/front_end/panels/sources/BreakpointEditDialog.ts +9 -6
  320. package/front_end/panels/sources/BreakpointsView.ts +25 -4
  321. package/front_end/panels/sources/CallStackSidebarPane.ts +7 -1
  322. package/front_end/panels/sources/DebuggerPlugin.ts +1 -0
  323. package/front_end/panels/sources/GoToLineQuickOpen.ts +8 -8
  324. package/front_end/panels/sources/NavigatorView.ts +521 -439
  325. package/front_end/panels/sources/PersistenceActions.ts +11 -12
  326. package/front_end/panels/sources/ProfilePlugin.ts +28 -17
  327. package/front_end/panels/sources/ScopeChainSidebarPane.ts +3 -4
  328. package/front_end/panels/sources/SourcesNavigator.ts +9 -9
  329. package/front_end/panels/sources/SourcesPanel.ts +2 -2
  330. package/front_end/panels/sources/SourcesView.ts +3 -3
  331. package/front_end/panels/sources/ThreadsSidebarPane.ts +2 -2
  332. package/front_end/panels/sources/WatchExpressionsSidebarPane.ts +2 -2
  333. package/front_end/panels/sources/components/HeadersView.ts +1 -2
  334. package/front_end/panels/timeline/CompatibilityTracksAppender.ts +5 -6
  335. package/front_end/panels/timeline/EventsTimelineTreeView.ts +73 -34
  336. package/front_end/panels/timeline/IsolateSelector.ts +25 -37
  337. package/front_end/panels/timeline/StatusDialog.ts +5 -7
  338. package/front_end/panels/timeline/ThirdPartyTreeView.ts +10 -13
  339. package/front_end/panels/timeline/TimelineDetailsView.ts +40 -21
  340. package/front_end/panels/timeline/TimelineEventOverview.ts +130 -34
  341. package/front_end/panels/timeline/TimelineFlameChartNetworkDataProvider.ts +1 -1
  342. package/front_end/panels/timeline/TimelineMiniMap.ts +255 -103
  343. package/front_end/panels/timeline/TimelinePaintProfilerView.ts +19 -11
  344. package/front_end/panels/timeline/TimelinePanel.ts +1 -0
  345. package/front_end/panels/timeline/TimelineSelectorStatsView.ts +11 -12
  346. package/front_end/panels/timeline/TimelineTreeView.ts +240 -122
  347. package/front_end/panels/timeline/TimelineUIUtils.ts +12 -0
  348. package/front_end/panels/timeline/components/BreadcrumbsUI.ts +5 -4
  349. package/front_end/panels/timeline/components/DetailsView.ts +97 -65
  350. package/front_end/panels/timeline/components/LayoutShiftDetails.ts +2 -2
  351. package/front_end/panels/timeline/components/MetricCard.ts +2 -2
  352. package/front_end/panels/timeline/components/NetworkRequestDetails.ts +11 -12
  353. package/front_end/panels/timeline/components/NetworkTrackWidget.ts +57 -50
  354. package/front_end/panels/timeline/components/RelatedInsightChips.ts +2 -2
  355. package/front_end/panels/timeline/components/Sidebar.ts +161 -109
  356. package/front_end/panels/timeline/components/SidebarAnnotationsTab.ts +33 -12
  357. package/front_end/panels/timeline/components/SidebarInsightsTab.ts +3 -0
  358. package/front_end/panels/timeline/components/insights/LCPDiscovery.ts +11 -11
  359. package/front_end/panels/timeline/components/insights/SlowCSSSelector.ts +6 -7
  360. package/front_end/panels/timeline/components/networkTrackWidget.css +24 -22
  361. package/front_end/panels/timeline/components/sidebarInsightsTab.css +1 -1
  362. package/front_end/panels/timeline/overlays/components/TimespanBreakdownOverlay.ts +15 -10
  363. package/front_end/panels/timeline/overlays/components/entryLabelOverlay.css +1 -1
  364. package/front_end/panels/timeline/timelinePanel.css +5 -0
  365. package/front_end/panels/timeline/timelineStatusDialog.css +1 -1
  366. package/front_end/panels/web_audio/WebAudioView.ts +2 -2
  367. package/front_end/third_party/chromium/README.chromium +1 -1
  368. package/front_end/third_party/legacy-javascript/README.chromium +2 -2
  369. package/front_end/third_party/legacy-javascript/lib/legacy-javascript.js +2 -2
  370. package/front_end/third_party/legacy-javascript/package.json +1 -1
  371. package/front_end/third_party/lighthouse/README.chromium +2 -2
  372. package/front_end/third_party/lighthouse/lighthouse-dt-bundle.js +1983 -2022
  373. package/front_end/third_party/lighthouse/locales/ar-XB.json +157 -142
  374. package/front_end/third_party/lighthouse/locales/ar.json +157 -142
  375. package/front_end/third_party/lighthouse/locales/bg.json +154 -139
  376. package/front_end/third_party/lighthouse/locales/ca.json +157 -142
  377. package/front_end/third_party/lighthouse/locales/cs.json +148 -133
  378. package/front_end/third_party/lighthouse/locales/da.json +153 -138
  379. package/front_end/third_party/lighthouse/locales/de.json +152 -137
  380. package/front_end/third_party/lighthouse/locales/el.json +153 -138
  381. package/front_end/third_party/lighthouse/locales/en-GB.json +160 -145
  382. package/front_end/third_party/lighthouse/locales/en-US.json +239 -218
  383. package/front_end/third_party/lighthouse/locales/en-XL.json +239 -218
  384. package/front_end/third_party/lighthouse/locales/es-419.json +150 -135
  385. package/front_end/third_party/lighthouse/locales/es.json +149 -134
  386. package/front_end/third_party/lighthouse/locales/fi.json +151 -136
  387. package/front_end/third_party/lighthouse/locales/fil.json +154 -139
  388. package/front_end/third_party/lighthouse/locales/fr.json +150 -135
  389. package/front_end/third_party/lighthouse/locales/he.json +160 -145
  390. package/front_end/third_party/lighthouse/locales/hi.json +156 -141
  391. package/front_end/third_party/lighthouse/locales/hr.json +154 -139
  392. package/front_end/third_party/lighthouse/locales/hu.json +111 -96
  393. package/front_end/third_party/lighthouse/locales/id.json +153 -138
  394. package/front_end/third_party/lighthouse/locales/it.json +153 -138
  395. package/front_end/third_party/lighthouse/locales/ja.json +150 -135
  396. package/front_end/third_party/lighthouse/locales/ko.json +42 -27
  397. package/front_end/third_party/lighthouse/locales/lt.json +152 -137
  398. package/front_end/third_party/lighthouse/locales/lv.json +93 -78
  399. package/front_end/third_party/lighthouse/locales/nl.json +149 -134
  400. package/front_end/third_party/lighthouse/locales/no.json +152 -137
  401. package/front_end/third_party/lighthouse/locales/pl.json +153 -138
  402. package/front_end/third_party/lighthouse/locales/pt-PT.json +152 -137
  403. package/front_end/third_party/lighthouse/locales/pt.json +157 -142
  404. package/front_end/third_party/lighthouse/locales/ro.json +149 -134
  405. package/front_end/third_party/lighthouse/locales/ru.json +76 -61
  406. package/front_end/third_party/lighthouse/locales/sk.json +153 -138
  407. package/front_end/third_party/lighthouse/locales/sl.json +149 -134
  408. package/front_end/third_party/lighthouse/locales/sr-Latn.json +151 -136
  409. package/front_end/third_party/lighthouse/locales/sr.json +151 -136
  410. package/front_end/third_party/lighthouse/locales/sv.json +152 -137
  411. package/front_end/third_party/lighthouse/locales/ta.json +156 -141
  412. package/front_end/third_party/lighthouse/locales/te.json +157 -142
  413. package/front_end/third_party/lighthouse/locales/th.json +111 -96
  414. package/front_end/third_party/lighthouse/locales/tr.json +153 -138
  415. package/front_end/third_party/lighthouse/locales/uk.json +149 -134
  416. package/front_end/third_party/lighthouse/locales/vi.json +162 -147
  417. package/front_end/third_party/lighthouse/locales/zh-HK.json +150 -135
  418. package/front_end/third_party/lighthouse/locales/zh-TW.json +154 -139
  419. package/front_end/third_party/lighthouse/locales/zh.json +152 -137
  420. package/front_end/third_party/lighthouse/report/bundle.d.ts +9 -8
  421. package/front_end/third_party/lighthouse/report/bundle.js +10 -10
  422. package/front_end/third_party/lighthouse/report-assets/report-generator.mjs +2 -7
  423. package/front_end/tsconfig.compatibility.json +1 -0
  424. package/front_end/tsconfig.json +3 -2
  425. package/front_end/ui/components/dialogs/TypeToAllowDialog.ts +0 -2
  426. package/front_end/ui/components/dialogs/typeToAllowDialog.css +0 -4
  427. package/front_end/ui/components/icon_button/fileSourceIcon.css +1 -1
  428. package/front_end/ui/components/input/textInput.css +1 -1
  429. package/front_end/ui/components/lists/List.ts +26 -14
  430. package/front_end/ui/components/menus/menus.ts +0 -2
  431. package/front_end/ui/components/suggestion_input/SuggestionInput.ts +351 -138
  432. package/front_end/ui/components/survey_link/surveyLink.css +3 -3
  433. package/front_end/ui/components/switch/switch.css +6 -6
  434. package/front_end/ui/components/text_editor/AiCodeCompletionTeaser.ts +2 -3
  435. package/front_end/ui/components/text_editor/TextEditor.ts +1 -1
  436. package/front_end/ui/components/tooltips/Tooltip.ts +53 -4
  437. package/front_end/ui/components/tree_outline/treeOutline.css +7 -7
  438. package/front_end/ui/helpers/OpenInNewTab.ts +8 -3
  439. package/front_end/ui/legacy/EmptyWidget.ts +4 -4
  440. package/front_end/ui/legacy/ForwardedInputEventHandler.ts +2 -2
  441. package/front_end/ui/legacy/GlassPane.ts +1 -1
  442. package/front_end/ui/legacy/KeyboardShortcut.ts +7 -7
  443. package/front_end/ui/legacy/RemoteDebuggingTerminatedScreen.ts +2 -2
  444. package/front_end/ui/legacy/TabbedPane.ts +198 -66
  445. package/front_end/ui/legacy/TargetCrashedScreen.ts +2 -2
  446. package/front_end/ui/legacy/UIUtils.ts +71 -68
  447. package/front_end/ui/legacy/View.ts +7 -4
  448. package/front_end/ui/legacy/ViewManager.ts +49 -37
  449. package/front_end/ui/legacy/Widget.ts +32 -12
  450. package/front_end/ui/legacy/components/cookie_table/CookiesTable.ts +2 -3
  451. package/front_end/ui/legacy/components/inline_editor/AnimationTimingUI.ts +8 -8
  452. package/front_end/ui/legacy/components/inline_editor/BezierUI.ts +8 -9
  453. package/front_end/ui/legacy/components/inline_editor/LinkSwatch.ts +2 -2
  454. package/front_end/ui/legacy/components/inline_editor/cssAngleEditor.css +1 -1
  455. package/front_end/ui/legacy/components/inline_editor/cssAngleSwatch.css +1 -1
  456. package/front_end/ui/legacy/components/object_ui/ObjectPropertiesSection.ts +45 -11
  457. package/front_end/ui/legacy/components/object_ui/RemoteObjectPreviewFormatter.ts +10 -12
  458. package/front_end/ui/legacy/components/perf_ui/ChartViewport.ts +102 -29
  459. package/front_end/ui/legacy/components/perf_ui/FlameChart.ts +148 -122
  460. package/front_end/ui/legacy/components/perf_ui/TimelineOverviewPane.ts +20 -14
  461. package/front_end/ui/legacy/components/quick_open/filteredListWidget.css +1 -1
  462. package/front_end/ui/legacy/components/source_frame/FontView.ts +29 -5
  463. package/front_end/ui/legacy/components/source_frame/ImageView.ts +79 -12
  464. package/front_end/ui/legacy/components/source_frame/JSONView.ts +20 -2
  465. package/front_end/ui/legacy/components/source_frame/PreviewFactory.ts +2 -2
  466. package/front_end/ui/legacy/components/source_frame/StreamingContentHexView.ts +6 -10
  467. package/front_end/ui/legacy/components/source_frame/XMLView.ts +11 -11
  468. package/front_end/ui/legacy/components/source_frame/fontView.css +7 -0
  469. package/front_end/ui/legacy/components/source_frame/imageView.css +7 -0
  470. package/front_end/ui/legacy/components/utils/JSPresentationUtils.ts +14 -3
  471. package/front_end/ui/legacy/components/utils/Linkifier.ts +126 -2
  472. package/front_end/ui/legacy/emptyWidget.css +2 -1
  473. package/front_end/ui/legacy/inspectorCommon.css +3 -3
  474. package/front_end/ui/legacy/smallBubble.css +1 -1
  475. package/front_end/ui/legacy/tabbedPane.css +6 -0
  476. package/front_end/ui/lit/Directives.ts +35 -18
  477. package/front_end/ui/lit/lit.ts +0 -2
  478. package/front_end/ui/lit/render.ts +0 -7
  479. package/front_end/ui/visual_logging/KnownContextValues.ts +5 -0
  480. package/package.json +1 -1
  481. package/vpython.toml +8 -0
  482. package/vpython.toml.uv.lock +3 -0
  483. package/.agents/skills/review-models-core/SKILL.md +0 -73
  484. package/.agents/skills/review-tests/SKILL.md +0 -67
  485. package/.agents/skills/review-ui-widgets/SKILL.md +0 -115
  486. package/front_end/generated/ARIAProperties.ts +0 -2686
  487. package/front_end/ui/components/menus/README.md +0 -119
  488. package/front_end/ui/components/menus/SelectMenu.ts +0 -473
  489. package/front_end/ui/components/menus/selectMenu.css +0 -54
  490. package/front_end/ui/components/menus/selectMenuButton.css +0 -108
@@ -67,7 +67,7 @@ export class SourceMapManager<T extends FrameAssociated> extends Common.ObjectWr
67
67
  }
68
68
  }
69
69
 
70
- private static getBaseUrl(target: Target|null): Platform.DevToolsPath.UrlString {
70
+ static #getBaseUrl(target: Target|null): Platform.DevToolsPath.UrlString {
71
71
  while (target && target.type() !== Type.FRAME) {
72
72
  target = target.parentTarget();
73
73
  }
@@ -76,7 +76,7 @@ export class SourceMapManager<T extends FrameAssociated> extends Common.ObjectWr
76
76
 
77
77
  static resolveRelativeSourceURL(target: Target|null, url: Platform.DevToolsPath.UrlString):
78
78
  Platform.DevToolsPath.UrlString {
79
- url = Common.ParsedURL.ParsedURL.completeURL(SourceMapManager.getBaseUrl(target), url) ?? url;
79
+ url = Common.ParsedURL.ParsedURL.completeURL(SourceMapManager.#getBaseUrl(target), url) ?? url;
80
80
  return url;
81
81
  }
82
82
 
@@ -236,7 +236,7 @@ export class TargetManager extends Common.ObjectWrapper.ObjectWrapper<EventTypes
236
236
  }
237
237
  }
238
238
 
239
- private modelRemoved(modelClass: SDKModelConstructor, model: SDKModel, inScope: boolean): void {
239
+ #modelRemoved(modelClass: SDKModelConstructor, model: SDKModel, inScope: boolean): void {
240
240
  for (const observer of this.#modelObservers.get(modelClass).values()) {
241
241
  if (!this.#scopedObservers.has(observer) || inScope) {
242
242
  observer.modelRemoved(model);
@@ -370,7 +370,7 @@ export class TargetManager extends Common.ObjectWrapper.ObjectWrapper<EventTypes
370
370
  for (const modelClass of target.models().keys()) {
371
371
  const model = target.models().get(modelClass);
372
372
  assertNotNullOrUndefined(model);
373
- this.modelRemoved(modelClass, model, inScope);
373
+ this.#modelRemoved(modelClass, model, inScope);
374
374
  }
375
375
 
376
376
  // Iterate over a copy. #observers might be modified during iteration.
@@ -694,7 +694,8 @@
694
694
  'autofill-view': 67,
695
695
  freestyler: 68,
696
696
  ads: 69,
697
- MAX_VALUE: 70,
697
+ 'private-verification-tokens': 70,
698
+ MAX_VALUE: 71,
698
699
  },
699
700
  MediaTypes: {
700
701
  Unknown: 0,
@@ -1564,9 +1565,12 @@
1564
1565
 
1565
1566
  /**
1566
1567
  * @param url
1568
+ * @param initiatorId the DevTools frame id or target id of the frame or worker that `url` came from, if any
1567
1569
  */
1568
- openInNewTab(url) {
1569
- DevToolsAPI.sendMessageToEmbedder('openInNewTab', [url], null);
1570
+ openInNewTab(url, initiatorId) {
1571
+ // Only pass `initiatorId` along when there is one: hosts from before it existed accept a single argument.
1572
+ const args = initiatorId === undefined ? [url] : [url, initiatorId];
1573
+ DevToolsAPI.sendMessageToEmbedder('openInNewTab', args, null);
1570
1574
  }
1571
1575
 
1572
1576
  /**
@@ -142,7 +142,7 @@ interface ViewInput {
142
142
  nodeProcessRunning: Boolean;
143
143
  }
144
144
 
145
- type View = (input: ViewInput, _output: object, target: HTMLElement) => void;
145
+ type View = (input: ViewInput, _output: undefined, target: HTMLElement) => void;
146
146
 
147
147
  const isNodeProcessRunning = (targetInfos: Protocol.Target.TargetInfo[]): Boolean => {
148
148
  return Boolean(targetInfos.find(target => target.type === 'node' && !target.attached));
@@ -202,7 +202,7 @@ export class NodeIndicator extends UI.Widget.Widget {
202
202
  const input: ViewInput = {
203
203
  nodeProcessRunning,
204
204
  };
205
- this.#view(input, {}, this.contentElement);
205
+ this.#view(input, undefined, this.contentElement);
206
206
  }
207
207
  }
208
208
 
@@ -1,18 +1,22 @@
1
1
  // Copyright 2015 The Chromium Authors
2
2
  // Use of this source code is governed by a BSD-style license that can be
3
3
  // found in the LICENSE file.
4
- /* eslint-disable @devtools/no-imperative-dom-api */
4
+
5
+ import '../../../ui/components/lists/lists.js';
6
+ import '../../../ui/kit/kit.js';
5
7
 
6
8
  import type * as Common from '../../../core/common/common.js';
7
9
  import * as Host from '../../../core/host/host.js';
8
10
  import * as i18n from '../../../core/i18n/i18n.js';
9
11
  import * as Buttons from '../../../ui/components/buttons/buttons.js';
10
- import * as uiI18n from '../../../ui/i18n/i18n.js';
11
- import {Link} from '../../../ui/kit/kit.js';
12
+ import type * as Lists from '../../../ui/components/lists/lists.js';
12
13
  import * as UI from '../../../ui/legacy/legacy.js';
14
+ import {html, i18nTemplate, render} from '../../../ui/lit/lit.js';
13
15
 
14
16
  import nodeConnectionsPanelStyles from './nodeConnectionsPanel.css.js';
15
17
 
18
+ const {widget} = UI.Widget;
19
+
16
20
  const UIStrings = {
17
21
  /**
18
22
  * @description Text in Node connections panel of the Sources panel when debugging a Node.js app.
@@ -42,156 +46,240 @@ const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
42
46
 
43
47
  const nodejsIconUrl = new URL('../../../Images/node-stack-icon.svg', import.meta.url).toString();
44
48
 
45
- export class NodeConnectionsPanel extends UI.Panel.Panel {
46
- #config!: Adb.Config;
47
- readonly #networkDiscoveryView: NodeConnectionsView;
48
- constructor() {
49
- super('node-connection');
49
+ interface PanelViewInput {
50
+ discoveryConfig: Adb.NetworkDiscoveryConfig;
51
+ onDiscoveryConfigChanged: (config: Adb.NetworkDiscoveryConfig) => void;
52
+ }
50
53
 
51
- this.contentElement.classList.add('node-panel');
54
+ type PanelView = (input: PanelViewInput, output: undefined, target: HTMLElement) => void;
52
55
 
53
- const container = this.contentElement.createChild('div', 'node-panel-center');
56
+ const PANEL_DEFAULT_VIEW: PanelView = (input, _output, target) => {
57
+ // clang-format off
58
+ render(html`
59
+ <style>${nodeConnectionsPanelStyles}</style>
60
+ <div class="node-panel vbox flex-auto" tabindex="0" autofocus>
61
+ <div class="node-panel-center">
62
+ <img class="node-panel-logo" src=${nodejsIconUrl} alt="">
63
+ ${widget(NodeConnectionsView, {
64
+ discoveryConfig: input.discoveryConfig,
65
+ callback: input.onDiscoveryConfigChanged,
66
+ })}
67
+ </div>
68
+ </div>
69
+ `, target);
70
+ // clang-format on
71
+ };
54
72
 
55
- const image = container.createChild('img', 'node-panel-logo');
56
- image.src = nodejsIconUrl;
73
+ export class NodeConnectionsPanel extends UI.Panel.Panel {
74
+ #config?: Adb.Config;
75
+ readonly #view: PanelView;
76
+
77
+ constructor(view: PanelView = PANEL_DEFAULT_VIEW) {
78
+ super('node-connection');
79
+ this.#view = view;
57
80
 
58
81
  Host.InspectorFrontendHost.InspectorFrontendHostInstance.events.addEventListener(
59
82
  Host.InspectorFrontendHostAPI.Events.DevicesDiscoveryConfigChanged, this.#devicesDiscoveryConfigChanged, this);
60
83
 
61
- this.contentElement.tabIndex = 0;
62
- this.setDefaultFocusedElement(this.contentElement);
63
-
64
84
  // Trigger notification once.
65
85
  Host.InspectorFrontendHost.InspectorFrontendHostInstance.setDevicesUpdatesEnabled(false);
66
86
  Host.InspectorFrontendHost.InspectorFrontendHostInstance.setDevicesUpdatesEnabled(true);
87
+ this.performUpdate();
88
+ }
67
89
 
68
- this.#networkDiscoveryView = new NodeConnectionsView(config => {
69
- this.#config.networkDiscoveryConfig = config;
70
- Host.InspectorFrontendHost.InspectorFrontendHostInstance.setDevicesDiscoveryConfig(this.#config);
71
- });
72
- this.#networkDiscoveryView.show(container);
90
+ override performUpdate(): void {
91
+ this.#view({
92
+ discoveryConfig: this.#config?.networkDiscoveryConfig ?? [],
93
+ onDiscoveryConfigChanged: this.#onDiscoveryConfigChanged,
94
+ },
95
+ undefined, this.contentElement);
73
96
  }
74
97
 
98
+ #onDiscoveryConfigChanged = (config: Adb.NetworkDiscoveryConfig): void => {
99
+ if (!this.#config) {
100
+ return;
101
+ }
102
+ this.#config.networkDiscoveryConfig = config;
103
+ Host.InspectorFrontendHost.InspectorFrontendHostInstance.setDevicesDiscoveryConfig(this.#config);
104
+ };
105
+
75
106
  #devicesDiscoveryConfigChanged({data: config}: Common.EventTarget.EventTargetEvent<Adb.Config>): void {
76
107
  this.#config = config;
77
- this.#networkDiscoveryView.discoveryConfigChanged(this.#config.networkDiscoveryConfig);
78
- }
79
- override wasShown(): void {
80
- super.wasShown();
81
- this.registerRequiredCSS(nodeConnectionsPanelStyles);
108
+ this.requestUpdate();
82
109
  }
83
110
  }
84
111
 
85
- export class NodeConnectionsView extends UI.Widget.VBox implements UI.ListWidget.Delegate<Adb.PortForwardingRule> {
86
- readonly #callback: (arg0: Adb.NetworkDiscoveryConfig) => void;
87
- readonly #list: UI.ListWidget.ListWidget<Adb.PortForwardingRule>;
88
- #editor: UI.ListWidget.Editor<Adb.PortForwardingRule>|null;
89
- #networkDiscoveryConfig: Array<{
90
- address: string,
91
- }>;
92
- constructor(callback: (arg0: Adb.NetworkDiscoveryConfig) => void) {
93
- super();
112
+ export interface ViewInput {
113
+ connections: string[];
114
+ editingIndex: number|null;
115
+ onAddClick: () => void;
116
+ onBeginEdit: (index: number) => void;
117
+ onCommitEdit: (index: number, value: string) => void;
118
+ onCancelEdit: () => void;
119
+ onDelete: (index: number) => void;
120
+ validator: (value: string) => Common.UIString.LocalizedString | null;
121
+ }
122
+
123
+ export type View = (input: ViewInput, output: undefined, target: HTMLElement) => void;
124
+
125
+ export const DEFAULT_VIEW: View = (input, _output, target) => {
126
+ // clang-format off
127
+ const documentationLink = html`
128
+ <devtools-link href="https://nodejs.org/learn/getting-started/debugging"
129
+ jslogcontext="node-js-debugging">
130
+ ${i18nString(UIStrings.nodejsDebuggingGuide)}
131
+ </devtools-link>`;
132
+ const items = input.editingIndex === input.connections.length
133
+ ? [...input.connections, '']
134
+ : input.connections;
135
+ render(html`
136
+ <style>${nodeConnectionsPanelStyles}</style>
137
+ <div class="vbox network-discovery-view node-frontend">
138
+ <div class="network-discovery-footer">
139
+ ${i18nTemplate(str_, UIStrings.specifyNetworkEndpointAnd, {PH1: documentationLink})}
140
+ </div>
141
+ ${items.length === 0 ? html`
142
+ <div class="network-discovery-list-empty">${i18nString(UIStrings.noConnectionsSpecified)}</div>
143
+ ` : html`
144
+ <devtools-list
145
+ class="network-discovery-list"
146
+ .editable=${true}
147
+ .deletable=${true}
148
+ @edit=${(e: Lists.List.ItemEditEvent) => input.onBeginEdit(e.detail.index)}
149
+ @delete=${(e: Lists.List.ItemRemoveEvent) => input.onDelete(e.detail.index)}>
150
+ ${items.map((address, index) => {
151
+ const editing = input.editingIndex === index;
152
+ return html`
153
+ <div slot="slot-${index}" class="network-discovery-list-item">
154
+ <devtools-prompt
155
+ class="network-discovery-value network-discovery-address"
156
+ placeholder=${i18nString(UIStrings.networkAddressEgLocalhost)}
157
+ value=${address}
158
+ ?editing=${editing}
159
+ .validator=${input.validator}
160
+ @click=${(e: Event) => {
161
+ if (!editing) {
162
+ input.onBeginEdit(index);
163
+ e.consume(true);
164
+ }
165
+ }}
166
+ @keydown=${(e: KeyboardEvent) => {
167
+ if (!editing && e.key === 'Enter') {
168
+ input.onBeginEdit(index);
169
+ e.consume(true);
170
+ }
171
+ }}
172
+ @commit=${(e: UI.TextPrompt.TextPromptElement.CommitEvent) => input.onCommitEdit(index, e.detail)}
173
+ @cancel=${input.onCancelEdit}>
174
+ ${address}
175
+ </devtools-prompt>
176
+ </div>
177
+ `;
178
+ })}
179
+ </devtools-list>
180
+ `}
181
+ <devtools-button
182
+ class="add-network-target-button"
183
+ .variant=${Buttons.Button.Variant.PRIMARY}
184
+ .jslogContext=${'add-network-target'}
185
+ @click=${input.onAddClick}>
186
+ ${i18nString(UIStrings.addConnection)}
187
+ </devtools-button>
188
+ </div>
189
+ `, target);
190
+ // clang-format on
191
+ };
192
+
193
+ export class NodeConnectionsView extends UI.Widget.VBox {
194
+ #callback?: (arg0: Adb.NetworkDiscoveryConfig) => void;
195
+ #networkDiscoveryConfig: string[] = [];
196
+ #editingIndex: number|null = null;
197
+ readonly #view: View;
198
+
199
+ constructor(element?: HTMLElement, view: View = DEFAULT_VIEW) {
200
+ super(element);
201
+ this.#view = view;
202
+ this.performUpdate();
203
+ }
204
+
205
+ static validateAddress(value: string): Common.UIString.LocalizedString|null {
206
+ const match = value.trim().match(/^([a-zA-Z0-9\.\-_]+):(\d+)$/);
207
+ if (!match) {
208
+ return i18nString(UIStrings.networkAddressEgLocalhost);
209
+ }
210
+ const port = parseInt(match[2], 10);
211
+ return port <= 65535 ? null : i18nString(UIStrings.networkAddressEgLocalhost);
212
+ }
213
+
214
+ set callback(callback: (arg0: Adb.NetworkDiscoveryConfig) => void) {
94
215
  this.#callback = callback;
95
- this.element.classList.add('network-discovery-view');
96
-
97
- const networkDiscoveryFooter = this.element.createChild('div', 'network-discovery-footer');
98
- const documentationLink = Link.create('https://nodejs.org/learn/getting-started/debugging',
99
- i18nString(UIStrings.nodejsDebuggingGuide), undefined, 'node-js-debugging');
100
- networkDiscoveryFooter.appendChild(
101
- uiI18n.getFormatLocalizedString(str_, UIStrings.specifyNetworkEndpointAnd, {PH1: documentationLink}));
102
-
103
- this.#list = new UI.ListWidget.ListWidget(this);
104
- this.#list.registerRequiredCSS(nodeConnectionsPanelStyles);
105
- this.#list.element.classList.add('network-discovery-list');
106
- const placeholder = document.createElement('div');
107
- placeholder.classList.add('network-discovery-list-empty');
108
- placeholder.textContent = i18nString(UIStrings.noConnectionsSpecified);
109
- this.#list.setEmptyPlaceholder(placeholder);
110
- this.#list.show(this.element);
111
- this.#editor = null;
112
-
113
- const addButton = UI.UIUtils.createTextButton(
114
- i18nString(UIStrings.addConnection), this.#addNetworkTargetButtonClicked.bind(this),
115
- {className: 'add-network-target-button', variant: Buttons.Button.Variant.PRIMARY});
116
- this.element.appendChild(addButton);
117
-
118
- this.#networkDiscoveryConfig = [];
119
-
120
- this.element.classList.add('node-frontend');
121
216
  }
122
217
 
123
- #update(): void {
124
- const config = this.#networkDiscoveryConfig.map(item => item.address);
125
- this.#callback.call(null, config);
218
+ set discoveryConfig(networkDiscoveryConfig: Adb.NetworkDiscoveryConfig) {
219
+ this.discoveryConfigChanged(networkDiscoveryConfig);
126
220
  }
127
221
 
128
- #addNetworkTargetButtonClicked(): void {
129
- this.#list.addNewItem(this.#networkDiscoveryConfig.length, {address: '', port: ''});
222
+ override performUpdate(): void {
223
+ this.#view({
224
+ connections: this.#networkDiscoveryConfig,
225
+ editingIndex: this.#editingIndex,
226
+ onAddClick: this.#addNetworkTargetButtonClicked.bind(this),
227
+ onBeginEdit: this.#beginEdit.bind(this),
228
+ onCommitEdit: this.#commitEdit.bind(this),
229
+ onCancelEdit: this.#cancelEdit.bind(this),
230
+ onDelete: this.#deleteItem.bind(this),
231
+ validator: NodeConnectionsView.validateAddress,
232
+ },
233
+ undefined, this.element);
130
234
  }
131
235
 
132
- discoveryConfigChanged(networkDiscoveryConfig: Adb.NetworkDiscoveryConfig): void {
133
- this.#networkDiscoveryConfig = [];
134
- this.#list.clear();
135
- for (const address of networkDiscoveryConfig) {
136
- const item = {address, port: ''};
137
- this.#networkDiscoveryConfig.push(item);
138
- this.#list.appendItem(item, true);
139
- }
236
+ #update(): void {
237
+ this.#callback?.call(null, [...this.#networkDiscoveryConfig]);
140
238
  }
141
239
 
142
- renderItem(rule: Adb.PortForwardingRule, _editable: boolean): Element {
143
- const element = document.createElement('div');
144
- element.classList.add('network-discovery-list-item');
145
- element.createChild('div', 'network-discovery-value network-discovery-address').textContent = rule.address;
146
- return element;
240
+ #addNetworkTargetButtonClicked(): void {
241
+ this.#editingIndex = this.#networkDiscoveryConfig.length;
242
+ this.requestUpdate();
147
243
  }
148
244
 
149
- removeItemRequested(_rule: Adb.PortForwardingRule, index: number): void {
150
- this.#networkDiscoveryConfig.splice(index, 1);
151
- this.#list.removeItem(index);
152
- this.#update();
245
+ #beginEdit(index: number): void {
246
+ this.#editingIndex = index;
247
+ this.requestUpdate();
153
248
  }
154
249
 
155
- commitEdit(rule: Adb.PortForwardingRule, editor: UI.ListWidget.Editor<Adb.PortForwardingRule>, isNew: boolean): void {
156
- rule.address = editor.control('address').value.trim();
157
- if (isNew) {
158
- this.#networkDiscoveryConfig.push(rule);
250
+ #commitEdit(index: number, value: string): void {
251
+ const trimmed = value.trim();
252
+ if (index === this.#networkDiscoveryConfig.length) {
253
+ this.#networkDiscoveryConfig.push(trimmed);
254
+ } else if (index >= 0 && index < this.#networkDiscoveryConfig.length) {
255
+ this.#networkDiscoveryConfig[index] = trimmed;
159
256
  }
257
+ this.#editingIndex = null;
258
+ this.requestUpdate();
160
259
  this.#update();
161
260
  }
162
261
 
163
- beginEdit(rule: Adb.PortForwardingRule): UI.ListWidget.Editor<Adb.PortForwardingRule> {
164
- const editor = this.#createEditor();
165
- editor.control('address').value = rule.address;
166
- return editor;
262
+ #cancelEdit(): void {
263
+ this.#editingIndex = null;
264
+ this.requestUpdate();
167
265
  }
168
266
 
169
- #createEditor(): UI.ListWidget.Editor<Adb.PortForwardingRule> {
170
- if (this.#editor) {
171
- return this.#editor;
172
- }
173
-
174
- const editor = new UI.ListWidget.Editor<Adb.PortForwardingRule>();
175
- this.#editor = editor;
176
- const content = editor.contentElement();
177
- const fields = content.createChild('div', 'network-discovery-edit-row');
178
- const input =
179
- editor.createInput('address', 'text', i18nString(UIStrings.networkAddressEgLocalhost), addressValidator);
180
- fields.createChild('div', 'network-discovery-value network-discovery-address').appendChild(input);
181
- return editor;
182
-
183
- function addressValidator(_rule: Adb.PortForwardingRule, _index: number, input: UI.ListWidget.EditorControl):
184
- UI.ListWidget.ValidatorResult {
185
- const match = input.value.trim().match(/^([a-zA-Z0-9\.\-_]+):(\d+)$/);
186
- if (!match) {
187
- return {
188
- valid: false,
189
- };
267
+ #deleteItem(index: number): void {
268
+ this.#networkDiscoveryConfig.splice(index, 1);
269
+ if (this.#editingIndex !== null) {
270
+ if (this.#editingIndex === index) {
271
+ this.#editingIndex = null;
272
+ } else if (this.#editingIndex > index) {
273
+ this.#editingIndex--;
190
274
  }
191
- const port = parseInt(match[2], 10);
192
- return {
193
- valid: port <= 65535,
194
- };
195
275
  }
276
+ this.requestUpdate();
277
+ this.#update();
278
+ }
279
+
280
+ discoveryConfigChanged(networkDiscoveryConfig: Adb.NetworkDiscoveryConfig): void {
281
+ this.#networkDiscoveryConfig = [...networkDiscoveryConfig];
282
+ this.#editingIndex = null;
283
+ this.requestUpdate();
196
284
  }
197
285
  }
@@ -1243,7 +1243,7 @@ inspectorBackend.registerType("PerformanceTimeline.TimelineEvent", [{"name": "fr
1243
1243
  inspectorBackend.registerEnum("Preload.RuleSetErrorType", {SourceIsNotJsonObject: "SourceIsNotJsonObject", InvalidRulesSkipped: "InvalidRulesSkipped", InvalidRulesetLevelTag: "InvalidRulesetLevelTag"});
1244
1244
  inspectorBackend.registerEnum("Preload.SpeculationAction", {Prefetch: "Prefetch", Prerender: "Prerender", PrerenderUntilScript: "PrerenderUntilScript"});
1245
1245
  inspectorBackend.registerEnum("Preload.SpeculationTargetHint", {Blank: "Blank", Self: "Self"});
1246
- inspectorBackend.registerEnum("Preload.PrerenderFinalStatus", {Activated: "Activated", Destroyed: "Destroyed", LowEndDevice: "LowEndDevice", InvalidSchemeRedirect: "InvalidSchemeRedirect", InvalidSchemeNavigation: "InvalidSchemeNavigation", NavigationRequestBlockedByCsp: "NavigationRequestBlockedByCsp", MojoBinderPolicy: "MojoBinderPolicy", RendererProcessCrashed: "RendererProcessCrashed", RendererProcessKilled: "RendererProcessKilled", Download: "Download", TriggerDestroyed: "TriggerDestroyed", NavigationNotCommitted: "NavigationNotCommitted", NavigationBadHttpStatus: "NavigationBadHttpStatus", ClientCertRequested: "ClientCertRequested", NavigationRequestNetworkError: "NavigationRequestNetworkError", CancelAllHostsForTesting: "CancelAllHostsForTesting", DidFailLoad: "DidFailLoad", Stop: "Stop", SslCertificateError: "SslCertificateError", LoginAuthRequested: "LoginAuthRequested", UaChangeRequiresReload: "UaChangeRequiresReload", BlockedByClient: "BlockedByClient", AudioOutputDeviceRequested: "AudioOutputDeviceRequested", MixedContent: "MixedContent", TriggerBackgrounded: "TriggerBackgrounded", MemoryLimitExceeded: "MemoryLimitExceeded", DataSaverEnabled: "DataSaverEnabled", TriggerUrlHasEffectiveUrl: "TriggerUrlHasEffectiveUrl", ActivatedBeforeStarted: "ActivatedBeforeStarted", InactivePageRestriction: "InactivePageRestriction", StartFailed: "StartFailed", TimeoutBackgrounded: "TimeoutBackgrounded", CrossSiteRedirectInInitialNavigation: "CrossSiteRedirectInInitialNavigation", CrossSiteNavigationInInitialNavigation: "CrossSiteNavigationInInitialNavigation", SameSiteCrossOriginRedirectNotOptInInInitialNavigation: "SameSiteCrossOriginRedirectNotOptInInInitialNavigation", SameSiteCrossOriginNavigationNotOptInInInitialNavigation: "SameSiteCrossOriginNavigationNotOptInInInitialNavigation", ActivationNavigationParameterMismatch: "ActivationNavigationParameterMismatch", ActivatedInBackground: "ActivatedInBackground", EmbedderHostDisallowed: "EmbedderHostDisallowed", ActivationNavigationDestroyedBeforeSuccess: "ActivationNavigationDestroyedBeforeSuccess", TabClosedByUserGesture: "TabClosedByUserGesture", TabClosedWithoutUserGesture: "TabClosedWithoutUserGesture", PrimaryMainFrameRendererProcessCrashed: "PrimaryMainFrameRendererProcessCrashed", PrimaryMainFrameRendererProcessKilled: "PrimaryMainFrameRendererProcessKilled", ActivationFramePolicyNotCompatible: "ActivationFramePolicyNotCompatible", PreloadingDisabled: "PreloadingDisabled", BatterySaverEnabled: "BatterySaverEnabled", ActivatedDuringMainFrameNavigation: "ActivatedDuringMainFrameNavigation", PreloadingUnsupportedByWebContents: "PreloadingUnsupportedByWebContents", CrossSiteRedirectInMainFrameNavigation: "CrossSiteRedirectInMainFrameNavigation", CrossSiteNavigationInMainFrameNavigation: "CrossSiteNavigationInMainFrameNavigation", SameSiteCrossOriginRedirectNotOptInInMainFrameNavigation: "SameSiteCrossOriginRedirectNotOptInInMainFrameNavigation", SameSiteCrossOriginNavigationNotOptInInMainFrameNavigation: "SameSiteCrossOriginNavigationNotOptInInMainFrameNavigation", MemoryPressureOnTrigger: "MemoryPressureOnTrigger", MemoryPressureAfterTriggered: "MemoryPressureAfterTriggered", PrerenderingDisabledByDevTools: "PrerenderingDisabledByDevTools", SpeculationRuleRemoved: "SpeculationRuleRemoved", ActivatedWithAuxiliaryBrowsingContexts: "ActivatedWithAuxiliaryBrowsingContexts", MaxNumOfRunningEagerPrerendersExceeded: "MaxNumOfRunningEagerPrerendersExceeded", MaxNumOfRunningNonEagerPrerendersExceeded: "MaxNumOfRunningNonEagerPrerendersExceeded", MaxNumOfRunningEmbedderPrerendersExceeded: "MaxNumOfRunningEmbedderPrerendersExceeded", PrerenderingUrlHasEffectiveUrl: "PrerenderingUrlHasEffectiveUrl", RedirectedPrerenderingUrlHasEffectiveUrl: "RedirectedPrerenderingUrlHasEffectiveUrl", ActivationUrlHasEffectiveUrl: "ActivationUrlHasEffectiveUrl", JavaScriptInterfaceAdded: "JavaScriptInterfaceAdded", JavaScriptInterfaceRemoved: "JavaScriptInterfaceRemoved", AllPrerenderingCanceled: "AllPrerenderingCanceled", WindowClosed: "WindowClosed", SlowNetwork: "SlowNetwork", OtherPrerenderedPageActivated: "OtherPrerenderedPageActivated", V8OptimizerDisabled: "V8OptimizerDisabled", PrerenderFailedDuringPrefetch: "PrerenderFailedDuringPrefetch", BrowsingDataRemoved: "BrowsingDataRemoved", PrerenderHostReused: "PrerenderHostReused", FormSubmitWhenPrerendering: "FormSubmitWhenPrerendering", CrossDocumentRestart: "CrossDocumentRestart"});
1246
+ inspectorBackend.registerEnum("Preload.PrerenderFinalStatus", {Activated: "Activated", Destroyed: "Destroyed", LowEndDevice: "LowEndDevice", InvalidSchemeRedirect: "InvalidSchemeRedirect", InvalidSchemeNavigation: "InvalidSchemeNavigation", NavigationRequestBlockedByCsp: "NavigationRequestBlockedByCsp", MojoBinderPolicy: "MojoBinderPolicy", RendererProcessCrashed: "RendererProcessCrashed", RendererProcessKilled: "RendererProcessKilled", Download: "Download", TriggerDestroyed: "TriggerDestroyed", NavigationNotCommitted: "NavigationNotCommitted", NavigationBadHttpStatus: "NavigationBadHttpStatus", ClientCertRequested: "ClientCertRequested", NavigationRequestNetworkError: "NavigationRequestNetworkError", CancelAllHostsForTesting: "CancelAllHostsForTesting", DidFailLoad: "DidFailLoad", Stop: "Stop", SslCertificateError: "SslCertificateError", LoginAuthRequested: "LoginAuthRequested", UaChangeRequiresReload: "UaChangeRequiresReload", BlockedByClient: "BlockedByClient", AudioOutputDeviceRequested: "AudioOutputDeviceRequested", MixedContent: "MixedContent", TriggerBackgrounded: "TriggerBackgrounded", MemoryLimitExceeded: "MemoryLimitExceeded", DataSaverEnabled: "DataSaverEnabled", TriggerUrlHasEffectiveUrl: "TriggerUrlHasEffectiveUrl", ActivatedBeforeStarted: "ActivatedBeforeStarted", InactivePageRestriction: "InactivePageRestriction", StartFailed: "StartFailed", TimeoutBackgrounded: "TimeoutBackgrounded", CrossSiteRedirectInInitialNavigation: "CrossSiteRedirectInInitialNavigation", CrossSiteNavigationInInitialNavigation: "CrossSiteNavigationInInitialNavigation", SameSiteCrossOriginRedirectNotOptInInInitialNavigation: "SameSiteCrossOriginRedirectNotOptInInInitialNavigation", SameSiteCrossOriginNavigationNotOptInInInitialNavigation: "SameSiteCrossOriginNavigationNotOptInInInitialNavigation", ActivationNavigationParameterMismatch: "ActivationNavigationParameterMismatch", ActivatedInBackground: "ActivatedInBackground", EmbedderHostDisallowed: "EmbedderHostDisallowed", ActivationNavigationDestroyedBeforeSuccess: "ActivationNavigationDestroyedBeforeSuccess", TabClosedByUserGesture: "TabClosedByUserGesture", TabClosedWithoutUserGesture: "TabClosedWithoutUserGesture", PrimaryMainFrameRendererProcessCrashed: "PrimaryMainFrameRendererProcessCrashed", PrimaryMainFrameRendererProcessKilled: "PrimaryMainFrameRendererProcessKilled", ActivationFramePolicyNotCompatible: "ActivationFramePolicyNotCompatible", PreloadingDisabled: "PreloadingDisabled", BatterySaverEnabled: "BatterySaverEnabled", ActivatedDuringMainFrameNavigation: "ActivatedDuringMainFrameNavigation", PreloadingUnsupportedByWebContents: "PreloadingUnsupportedByWebContents", CrossSiteRedirectInMainFrameNavigation: "CrossSiteRedirectInMainFrameNavigation", CrossSiteNavigationInMainFrameNavigation: "CrossSiteNavigationInMainFrameNavigation", SameSiteCrossOriginRedirectNotOptInInMainFrameNavigation: "SameSiteCrossOriginRedirectNotOptInInMainFrameNavigation", SameSiteCrossOriginNavigationNotOptInInMainFrameNavigation: "SameSiteCrossOriginNavigationNotOptInInMainFrameNavigation", MemoryPressureOnTrigger: "MemoryPressureOnTrigger", MemoryPressureAfterTriggered: "MemoryPressureAfterTriggered", PrerenderingDisabledByDevTools: "PrerenderingDisabledByDevTools", SpeculationRuleRemoved: "SpeculationRuleRemoved", ActivatedWithAuxiliaryBrowsingContexts: "ActivatedWithAuxiliaryBrowsingContexts", MaxNumOfRunningEagerPrerendersExceeded: "MaxNumOfRunningEagerPrerendersExceeded", MaxNumOfRunningNonEagerPrerendersExceeded: "MaxNumOfRunningNonEagerPrerendersExceeded", MaxNumOfRunningEmbedderPrerendersExceeded: "MaxNumOfRunningEmbedderPrerendersExceeded", PrerenderingUrlHasEffectiveUrl: "PrerenderingUrlHasEffectiveUrl", RedirectedPrerenderingUrlHasEffectiveUrl: "RedirectedPrerenderingUrlHasEffectiveUrl", ActivationUrlHasEffectiveUrl: "ActivationUrlHasEffectiveUrl", JavaScriptInterfaceAdded: "JavaScriptInterfaceAdded", JavaScriptInterfaceRemoved: "JavaScriptInterfaceRemoved", AllPrerenderingCanceled: "AllPrerenderingCanceled", WindowClosed: "WindowClosed", SlowNetwork: "SlowNetwork", OtherPrerenderedPageActivated: "OtherPrerenderedPageActivated", V8OptimizerDisabled: "V8OptimizerDisabled", PrerenderFailedDuringPrefetch: "PrerenderFailedDuringPrefetch", BrowsingDataRemoved: "BrowsingDataRemoved", PrerenderHostReused: "PrerenderHostReused", FormSubmitWhenPrerendering: "FormSubmitWhenPrerendering", CrossDocumentRestart: "CrossDocumentRestart", PrefetchFailedCrossOriginSubframe: "PrefetchFailedCrossOriginSubframe"});
1247
1247
  inspectorBackend.registerEnum("Preload.PreloadingStatus", {Pending: "Pending", Running: "Running", Ready: "Ready", Success: "Success", Failure: "Failure", NotSupported: "NotSupported"});
1248
1248
  inspectorBackend.registerEnum("Preload.PrefetchStatus", {PrefetchAllowed: "PrefetchAllowed", PrefetchFailedIneligibleRedirect: "PrefetchFailedIneligibleRedirect", PrefetchFailedInvalidRedirect: "PrefetchFailedInvalidRedirect", PrefetchFailedMIMENotSupported: "PrefetchFailedMIMENotSupported", PrefetchFailedNetError: "PrefetchFailedNetError", PrefetchFailedNon2XX: "PrefetchFailedNon2XX", PrefetchEvictedAfterBrowsingDataRemoved: "PrefetchEvictedAfterBrowsingDataRemoved", PrefetchEvictedAfterCandidateRemoved: "PrefetchEvictedAfterCandidateRemoved", PrefetchEvictedForNewerPrefetch: "PrefetchEvictedForNewerPrefetch", PrefetchHeldback: "PrefetchHeldback", PrefetchIneligibleRetryAfter: "PrefetchIneligibleRetryAfter", PrefetchIsPrivacyDecoy: "PrefetchIsPrivacyDecoy", PrefetchIsStale: "PrefetchIsStale", PrefetchNotEligibleBlockedByConnectionAllowlist: "PrefetchNotEligibleBlockedByConnectionAllowlist", PrefetchNotEligibleBrowserContextOffTheRecord: "PrefetchNotEligibleBrowserContextOffTheRecord", PrefetchNotEligibleCrossOrigin: "PrefetchNotEligibleCrossOrigin", PrefetchNotEligibleDataSaverEnabled: "PrefetchNotEligibleDataSaverEnabled", PrefetchNotEligibleExistingProxy: "PrefetchNotEligibleExistingProxy", PrefetchNotEligibleHostIsNonUnique: "PrefetchNotEligibleHostIsNonUnique", PrefetchNotEligibleNonDefaultStoragePartition: "PrefetchNotEligibleNonDefaultStoragePartition", PrefetchNotEligibleSameSiteCrossOriginPrefetchRequiredProxy: "PrefetchNotEligibleSameSiteCrossOriginPrefetchRequiredProxy", PrefetchNotEligibleSchemeIsNotHttps: "PrefetchNotEligibleSchemeIsNotHttps", PrefetchNotEligibleUserHasCookies: "PrefetchNotEligibleUserHasCookies", PrefetchNotEligibleUserHasServiceWorker: "PrefetchNotEligibleUserHasServiceWorker", PrefetchNotEligibleUserHasServiceWorkerNoFetchHandler: "PrefetchNotEligibleUserHasServiceWorkerNoFetchHandler", PrefetchNotEligibleRedirectFromServiceWorker: "PrefetchNotEligibleRedirectFromServiceWorker", PrefetchNotEligibleRedirectToServiceWorker: "PrefetchNotEligibleRedirectToServiceWorker", PrefetchNotEligibleBatterySaverEnabled: "PrefetchNotEligibleBatterySaverEnabled", PrefetchNotEligiblePreloadingDisabled: "PrefetchNotEligiblePreloadingDisabled", PrefetchNotFinishedInTime: "PrefetchNotFinishedInTime", PrefetchNotStarted: "PrefetchNotStarted", PrefetchNotUsedCookiesChanged: "PrefetchNotUsedCookiesChanged", PrefetchProxyNotAvailable: "PrefetchProxyNotAvailable", PrefetchResponseUsed: "PrefetchResponseUsed", PrefetchSuccessfulButNotUsed: "PrefetchSuccessfulButNotUsed", PrefetchNotUsedProbeFailed: "PrefetchNotUsedProbeFailed", PrefetchCancelledOnUserNavigation: "PrefetchCancelledOnUserNavigation"});
1249
1249
  inspectorBackend.registerEvent("Preload.ruleSetUpdated", ["ruleSet"]);
@@ -3303,9 +3303,7 @@ export const generatedProperties: CSSProperty[] = [
3303
3303
  "content-block-size",
3304
3304
  "content-inline-size"
3305
3305
  ],
3306
- "name": "frame-sizing",
3307
- "runtime_flag": "ResponsiveIframes",
3308
- "runtime_flag_status": "stable"
3306
+ "name": "frame-sizing"
3309
3307
  },
3310
3308
  {
3311
3309
  "longhands": [
@@ -17516,6 +17516,7 @@ export namespace Preload {
17516
17516
  PrerenderHostReused = 'PrerenderHostReused',
17517
17517
  FormSubmitWhenPrerendering = 'FormSubmitWhenPrerendering',
17518
17518
  CrossDocumentRestart = 'CrossDocumentRestart',
17519
+ PrefetchFailedCrossOriginSubframe = 'PrefetchFailedCrossOriginSubframe',
17519
17520
  }
17520
17521
 
17521
17522
  /**
@@ -17,7 +17,8 @@ import {
17
17
  type ParsedResponse,
18
18
  type RequestOptions,
19
19
  ResponseType,
20
- sanitizeSuggestions,
20
+ sanitizeSuggestionsList,
21
+ SUGGEST_FOLLOW_UPS_FUNCTION_NAME,
21
22
  } from './agents/AiAgent.js';
22
23
  import {type ExecuteJsAgentOptions, executeJsCode} from './agents/ExecuteJavascript.js';
23
24
  import {ChangeManager} from './ChangeManager.js';
@@ -59,20 +60,22 @@ Your role is to help web developers debug, analyze, and optimize web application
59
60
  # Workflow
60
61
  1. **Analyze**: Understand the user's intent, the context provided, and what they are trying to achieve.
61
62
  2. **Investigate**: Proactively use your learned skills and tools to gather live data. Do not make assumptions or guess without sufficient evidence.
62
- 3. **Diagnose**: Explore multiple potential explanations and solutions. Distinguish between the primary root cause and contributing factors.
63
- 4. **Respond**: Provide a structured, clear, and actionable response.
63
+ 3. **Evaluate**: Synthesize the live data. If the user is debugging an issue, explore multiple potential explanations and distinguish between the primary root cause and contributing factors.
64
+ 4. **Respond**: Match your response format and depth to the user's question.
64
65
 
65
66
  # Response Structure
66
- If the user asks a question that requires an investigation or debugging, use this structure:
67
- * **Root Cause(s)**: Point out the root cause(s) of the problem.
68
- - Example: "**Root Cause**: [reason]" or "**Root Causes**:" followed by a bulleted list.
69
- * **Suggestion(s)**: List actionable solution suggestion(s) in order of impact.
70
- - Example: "**Suggestion**: [Suggestion]" or "**Suggestions**:" followed by a bulleted list.
67
+ * **Informational or exploratory questions** (e.g., asking what a network request, script, element, or storage entry is or does):
68
+ - Answer directly and concisely in 1–2 short paragraphs or a compact list of key facts.
69
+ - Do NOT include "**Root Cause**" or "**Suggestions**" sections, and do not add unrequested optimization advice when nothing is broken.
70
+ * **Debugging or optimization questions** (e.g., asking why something fails, renders incorrectly, or is slow, or how to improve/fix it):
71
+ - **Root Cause(s)**: Point out the root cause(s) of the problem.
72
+ - Example: "**Root Cause**: [reason]" or "**Root Causes**:" followed by a bulleted list.
73
+ - **Suggestion(s)**: List actionable solution suggestion(s) in order of impact.
74
+ - Example: "**Suggestion**: [Suggestion]" or "**Suggestions**:" followed by a bulleted list.
71
75
 
72
76
  # Follow-up Suggestions
73
- * Output a list of suggested follow-up queries or actions for the user at the very end of your response.
74
- * The format MUST be SUGGESTIONS: ["suggestion 1", "suggestion 2"] on its own single line.
75
- * Ensure suggestions are relevant, concise, and helpful next steps for the user.
77
+ * At the end of your response, call the \`suggestFollowUps\` function to provide 1 to 3 relevant, concise follow-up queries or actions for the user.
78
+ * Do not write follow-up suggestions as text in your response.
76
79
 
77
80
  # Constraints
78
81
  * **CRITICAL**: You are a web development assistant. NEVER provide answers to questions of unrelated topics (such as legal advice, financial advice, personal opinions, medical advice, religion, race, politics, sexuality, gender, or any other non-web-development topics). If asked about these, respond with: "Sorry, I can't answer that. I'm best at questions about web development and debugging."
@@ -143,7 +146,7 @@ function removeDirectiveFromLastLine(lines: string[], textBeforeDirective: strin
143
146
  */
144
147
  function parseSuggestionsArray(array: string): {suggestions: [string, ...string[]]|undefined}|null {
145
148
  try {
146
- return {suggestions: sanitizeSuggestions(array)};
149
+ return {suggestions: sanitizeSuggestionsList(JSON.parse(array))};
147
150
  } catch {
148
151
  // Invalid JSON: the caller decides whether the line is still a directive.
149
152
  return null;
@@ -309,6 +312,27 @@ export class AiAgent2 extends AiAgent<unknown> {
309
312
  };
310
313
  },
311
314
  });
315
+ this.#declaredTools.add(SUGGEST_FOLLOW_UPS_FUNCTION_NAME);
316
+ this.declareFunction<{suggestions: string[]}>(SUGGEST_FOLLOW_UPS_FUNCTION_NAME, {
317
+ description: 'Provides suggested follow-up queries or actions for the user at the end of the response.',
318
+ parameters: {
319
+ type: Host.AidaClient.ParametersTypes.OBJECT,
320
+ description: 'Parameters for follow-up suggestions',
321
+ properties: {
322
+ suggestions: {
323
+ type: Host.AidaClient.ParametersTypes.ARRAY,
324
+ items: {
325
+ type: Host.AidaClient.ParametersTypes.STRING,
326
+ description: 'A concise follow-up query or action (under 60 characters).',
327
+ },
328
+ description: '1 to 3 concise follow-up queries or actions relevant to the response.',
329
+ },
330
+ },
331
+ required: ['suggestions'],
332
+ },
333
+ // Never called: AiAgent#run() and AiAgent#runFunctionCalls() intercept suggestFollowUps directly.
334
+ handler: async () => ({result: 'Suggestions recorded.'}),
335
+ });
312
336
  }
313
337
 
314
338
  override async enhanceQuery(
@@ -13,6 +13,7 @@ import type * as NetworkTimeCalculator from '../network_time_calculator/network_
13
13
 
14
14
  import {AccessibilityAgent} from './agents/AccessibilityAgent.js';
15
15
  import {
16
+ type ActionResponse,
16
17
  type AgentOptions,
17
18
  type AiAgent,
18
19
  type AllowedOriginResult,
@@ -91,6 +92,11 @@ export class AiConversation {
91
92
  if (entry.type === ResponseType.SIDE_EFFECT) {
92
93
  return {...entry, confirm: () => {}};
93
94
  }
95
+ if (entry.type === ResponseType.ACTION && 'code' in entry) {
96
+ // Entries saved before `ActionResponse.code` was renamed to `action`.
97
+ const {code, ...rest} = entry as ActionResponse & {code?: string};
98
+ return {...rest, action: rest.action ?? code};
99
+ }
94
100
  return entry;
95
101
  });
96
102
  return new AiConversation({
@@ -285,8 +291,8 @@ export class AiConversation {
285
291
  if (!item.output) {
286
292
  break;
287
293
  }
288
- if (item.code) {
289
- contentParts.push(`**Code executed:**\n\`\`\`\n${item.code.trim()}\n\`\`\``);
294
+ if (item.action) {
295
+ contentParts.push(`**Code executed:**\n\`\`\`\n${item.action.trim()}\n\`\`\``);
290
296
  }
291
297
  contentParts.push(`**Data returned:**\n\`\`\`\n${item.output}\n\`\`\``);
292
298
  break;