chrome-devtools-frontend 1.0.1726686 → 1.0.1730971

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (490) hide show
  1. package/.agents/rules/tests/test-strict-assertions-and-literal-expectations.md +1 -1
  2. package/.agents/rules/tests/test-view-and-presenter-isolation.md +1 -1
  3. package/.agents/rules/ui-and-widgets/ui-accessibility-and-semantic-html.md +1 -1
  4. package/.agents/rules/ui-and-widgets/ui-css-scoping-and-flex-layout.md +2 -2
  5. package/.agents/rules/ui-and-widgets/ui-declarative-child-widget-composition.md +5 -5
  6. package/.agents/rules/ui-and-widgets/ui-lit-declarative-templates-and-directives.md +2 -2
  7. package/.agents/rules/ui-and-widgets/ui-localization-and-uistrings-hygiene.md +2 -2
  8. package/.agents/rules/ui-and-widgets/ui-modern-component-and-encapsulation-standards.md +3 -3
  9. package/.agents/rules/ui-and-widgets/ui-pure-view-and-presenter-separation.md +2 -2
  10. package/.agents/rules/ui-and-widgets/ui-reactive-widget-update-lifecycle.md +2 -2
  11. package/.agents/rules/ui-and-widgets/ui-view-output-and-callback-contracts.md +2 -2
  12. package/.agents/rules/ui-and-widgets/ui-widget-dom-and-listener-lifecycle.md +2 -2
  13. package/.agents/skills/code-review/SKILL.md +63 -12
  14. package/.agents/skills/ui-eng-vision-local-lit-renderer/SKILL.md +38 -10
  15. package/.agents/skills/ui-eng-vision-widget-promoter/SKILL.md +1 -0
  16. package/.agents/skills/ui-widgets/SKILL.md +8 -2
  17. package/.agents/skills/write-ai-eval-test/SKILL.md +106 -0
  18. package/AUTHORS +2 -0
  19. package/DIR_METADATA +1 -2
  20. package/README.md +48 -26
  21. package/config/typescript/tsconfig.base.json +1 -0
  22. package/config/typescript/tsconfig.eslint.json +1 -0
  23. package/docs/contributing/changes.md +25 -0
  24. package/docs/ui_engineering.md +13 -4
  25. package/eslint.config.mjs +323 -41
  26. package/front_end/core/common/Color.ts +7 -7
  27. package/front_end/core/common/ParsedURL.ts +3 -3
  28. package/front_end/core/common/ResolverBase.ts +3 -3
  29. package/front_end/core/common/SegmentedRange.ts +3 -3
  30. package/front_end/core/common/SimpleHistoryManager.ts +14 -14
  31. package/front_end/core/common/Trie.ts +3 -3
  32. package/front_end/core/common/VersionController.ts +7 -7
  33. package/front_end/core/host/InspectorFrontendHost.ts +2 -2
  34. package/front_end/core/host/InspectorFrontendHostAPI.ts +9 -1
  35. package/front_end/core/host/InspectorFrontendHostStub.ts +1 -1
  36. package/front_end/core/host/UserMetrics.ts +4 -0
  37. package/front_end/core/host/UserMetricsEnums.ts +2 -1
  38. package/front_end/core/platform/StringUtilities.ts +54 -13
  39. package/front_end/core/platform/node/HostRuntime.ts +13 -7
  40. package/front_end/core/protocol_client/DevToolsCDPConnection.ts +4 -5
  41. package/front_end/core/root/Runtime.ts +5 -0
  42. package/front_end/core/sdk/AccessibilityModel.ts +5 -5
  43. package/front_end/core/sdk/AnimationModel.ts +17 -19
  44. package/front_end/core/sdk/CPUProfilerModel.ts +3 -3
  45. package/front_end/core/sdk/CPUThrottlingManager.ts +7 -0
  46. package/front_end/core/sdk/CSSMatchedStyles.ts +73 -13
  47. package/front_end/core/sdk/CSSMetadata.ts +7 -7
  48. package/front_end/core/sdk/CSSModel.ts +33 -33
  49. package/front_end/core/sdk/CSSProperty.ts +5 -5
  50. package/front_end/core/sdk/CSSRule.ts +6 -6
  51. package/front_end/core/sdk/CSSStyleSheetHeader.ts +4 -4
  52. package/front_end/core/sdk/Connections.ts +16 -16
  53. package/front_end/core/sdk/ConsoleModel.ts +44 -47
  54. package/front_end/core/sdk/CookieParser.ts +11 -11
  55. package/front_end/core/sdk/EmulationModel.ts +35 -36
  56. package/front_end/core/sdk/EventBreakpointsModel.ts +11 -11
  57. package/front_end/core/sdk/FrameManager.ts +16 -16
  58. package/front_end/core/sdk/IsolateManager.ts +2 -2
  59. package/front_end/core/sdk/IssuesModel.ts +2 -2
  60. package/front_end/core/sdk/OverlayModel.ts +19 -19
  61. package/front_end/core/sdk/PageResourceLoader.ts +14 -16
  62. package/front_end/core/sdk/RemoteObject.ts +9 -9
  63. package/front_end/core/sdk/Resource.ts +2 -2
  64. package/front_end/core/sdk/RuntimeModel.ts +7 -7
  65. package/front_end/core/sdk/Script.ts +6 -6
  66. package/front_end/core/sdk/ServiceWorkerManager.ts +36 -10
  67. package/front_end/core/sdk/SourceMap.ts +18 -20
  68. package/front_end/core/sdk/SourceMapManager.ts +2 -2
  69. package/front_end/core/sdk/TargetManager.ts +2 -2
  70. package/front_end/devtools_compatibility.js +7 -3
  71. package/front_end/entrypoints/inspector_main/InspectorMain.ts +2 -2
  72. package/front_end/entrypoints/node_app/app/NodeConnectionsPanel.ts +203 -115
  73. package/front_end/generated/InspectorBackendCommands.ts +1 -1
  74. package/front_end/generated/SupportedCSSProperties.ts +1 -3
  75. package/front_end/generated/protocol.ts +1 -0
  76. package/front_end/models/ai_assistance/AiAgent2.ts +36 -12
  77. package/front_end/models/ai_assistance/AiConversation.ts +8 -2
  78. package/front_end/models/ai_assistance/agents/AiAgent.ts +137 -62
  79. package/front_end/models/ai_assistance/agents/ExecuteJavascript.ts +2 -2
  80. package/front_end/models/ai_assistance/agents/StylingAgent.snapshot.txt +2 -2
  81. package/front_end/models/ai_assistance/data_formatters/LighthouseFormatter.snapshot.txt +149 -2
  82. package/front_end/models/ai_assistance/data_formatters/LighthouseFormatter.ts +269 -42
  83. package/front_end/models/ai_assistance/tools/ExecuteJavaScript.ts +3 -0
  84. package/front_end/models/ai_assistance/tools/GetLighthouseAudits.ts +9 -0
  85. package/front_end/models/ai_assistance/tools/ResolveDevtoolsNodePath.ts +13 -2
  86. package/front_end/models/ai_assistance/tools/RunLighthouse.ts +23 -7
  87. package/front_end/models/ai_assistance/tools/Tool.ts +7 -5
  88. package/front_end/models/bindings/CSSWorkspaceBinding.ts +22 -24
  89. package/front_end/models/bindings/DebuggerLanguagePlugins.ts +60 -60
  90. package/front_end/models/bindings/DebuggerWorkspaceBinding.ts +24 -24
  91. package/front_end/models/bindings/DefaultScriptMapping.ts +8 -8
  92. package/front_end/models/bindings/FileUtils.ts +13 -13
  93. package/front_end/models/bindings/PresentationConsoleMessageHelper.ts +3 -3
  94. package/front_end/models/bindings/ResourceScriptMapping.ts +23 -23
  95. package/front_end/models/comment_manager/CommentManager.ts +3 -3
  96. package/front_end/models/comment_manager/CommentThread.ts +50 -5
  97. package/front_end/models/cpu_profile/CPUProfileDataModel.ts +14 -14
  98. package/front_end/models/cpu_profile/ProfileTreeModel.ts +4 -4
  99. package/front_end/models/elements/StyleChanges.ts +38 -0
  100. package/front_end/models/emulation/EmulatedDevices.ts +12 -12
  101. package/front_end/models/har/HARFormat.ts +4 -4
  102. package/front_end/models/javascript_metadata/NativeFunctions.ts +5 -1
  103. package/front_end/models/lighthouse/LighthouseReporterTypes.ts +57 -3
  104. package/front_end/models/lighthouse/RunTypes.ts +9 -1
  105. package/front_end/models/logs/LogManager.ts +2 -2
  106. package/front_end/models/persistence/AutomaticFileSystemManager.ts +3 -0
  107. package/front_end/models/persistence/FileSystemWorkspaceBinding.ts +24 -24
  108. package/front_end/models/persistence/IsolatedFileSystemManager.ts +6 -0
  109. package/front_end/models/persistence/NetworkPersistenceManager.ts +8 -3
  110. package/front_end/models/trace/LanternComputationData.ts +37 -11
  111. package/front_end/models/trace/Processor.ts +2 -1
  112. package/front_end/models/trace/extras/TraceTree.ts +36 -10
  113. package/front_end/models/trace/handlers/InitiatorsHandler.ts +27 -34
  114. package/front_end/models/trace/handlers/LayoutShiftsHandler.ts +2 -6
  115. package/front_end/models/trace/handlers/SamplesHandler.ts +9 -6
  116. package/front_end/models/workspace/FileManager.ts +6 -0
  117. package/front_end/panels/accessibility/ARIAAttributesView.ts +4 -4
  118. package/front_end/panels/accessibility/AccessibilityAnnouncementRecordingView.ts +8 -1
  119. package/front_end/panels/accessibility/AccessibilityNodeView.ts +15 -17
  120. package/front_end/panels/accessibility/AccessibilitySubPane.ts +1 -1
  121. package/front_end/panels/ai_assistance/AiAssistancePanel.ts +5 -5
  122. package/front_end/panels/ai_assistance/ExternalHandler.ts +10 -1
  123. package/front_end/panels/ai_assistance/components/ChatMessage.ts +27 -22
  124. package/front_end/panels/ai_assistance/components/DisabledWidget.ts +19 -23
  125. package/front_end/panels/ai_assistance/components/ExploreWidget.ts +2 -2
  126. package/front_end/panels/ai_assistance/components/PermissionPrompt.ts +23 -9
  127. package/front_end/panels/ai_assistance/components/chatInput.css +1 -1
  128. package/front_end/panels/animation/AnimationTimeline.ts +37 -17
  129. package/front_end/panels/animation/animationTimeline.css +19 -3
  130. package/front_end/panels/application/AppManifestView.ts +1 -2
  131. package/front_end/panels/application/ApplicationPanelSidebar.ts +143 -128
  132. package/front_end/panels/application/DOMStorageItemsView.ts +14 -14
  133. package/front_end/panels/application/DeviceBoundSessionsView.ts +10 -13
  134. package/front_end/panels/application/ExtensionStorageItemsView.ts +3 -4
  135. package/front_end/panels/application/IndexedDBViews.ts +8 -4
  136. package/front_end/panels/application/KeyValueStorageItemsView.ts +4 -5
  137. package/front_end/panels/application/PrivateVerificationTokensView.ts +53 -0
  138. package/front_end/panels/application/ServiceWorkerCacheViews.ts +12 -8
  139. package/front_end/panels/application/ServiceWorkersView.ts +1 -2
  140. package/front_end/panels/application/StorageItemsToolbar.ts +3 -3
  141. package/front_end/panels/application/StorageView.ts +2 -2
  142. package/front_end/panels/application/WebMCPView.ts +91 -109
  143. package/front_end/panels/application/application.ts +2 -0
  144. package/front_end/panels/application/components/StorageMetadataView.ts +6 -6
  145. package/front_end/panels/application/preloading/PreloadingView.ts +70 -37
  146. package/front_end/panels/application/preloading/components/MismatchedPreloadingGrid.ts +2 -2
  147. package/front_end/panels/application/preloading/components/PreloadingDisabledInfobar.ts +3 -3
  148. package/front_end/panels/application/preloading/components/PreloadingGrid.ts +12 -0
  149. package/front_end/panels/application/preloading/components/RuleSetDetailsView.ts +10 -11
  150. package/front_end/panels/application/privateVerificationTokensView.css +20 -0
  151. package/front_end/panels/application/serviceWorkersView.css +2 -2
  152. package/front_end/panels/browser_debugger/DOMBreakpointsSidebarPane.ts +24 -24
  153. package/front_end/panels/changes/ChangesSidebar.ts +5 -5
  154. package/front_end/panels/changes/ChangesView.ts +10 -11
  155. package/front_end/panels/comments/CommentsPane.ts +292 -102
  156. package/front_end/panels/comments/commentsPane.css +93 -12
  157. package/front_end/panels/common/CommentThreadWidget.ts +69 -0
  158. package/front_end/panels/common/CommentsOverlayWidget.ts +108 -29
  159. package/front_end/panels/common/CommentsStatusBarPill.ts +17 -6
  160. package/front_end/panels/common/DOMLinkifier.ts +37 -12
  161. package/front_end/panels/common/ExtensionPanel.ts +13 -4
  162. package/front_end/panels/common/ExtensionServer.ts +27 -3
  163. package/front_end/panels/common/PersistenceUtils.ts +3 -3
  164. package/front_end/panels/common/commentThreadWidget.css +25 -1
  165. package/front_end/panels/common/common-meta.ts +10 -0
  166. package/front_end/panels/console/ConsolePinPane.ts +13 -15
  167. package/front_end/panels/console/ConsolePrompt.ts +173 -95
  168. package/front_end/panels/console/ConsoleSidebar.ts +2 -2
  169. package/front_end/panels/console/ConsoleView.ts +75 -79
  170. package/front_end/panels/console/ConsoleViewMessage.ts +52 -4
  171. package/front_end/panels/console/SymbolizedErrorWidget.ts +8 -4
  172. package/front_end/panels/console/consolePrompt.css +1 -1
  173. package/front_end/panels/console/consoleView.css +1 -1
  174. package/front_end/panels/console_counters/WarningErrorCounter.ts +3 -4
  175. package/front_end/panels/coverage/CoverageListView.ts +2 -2
  176. package/front_end/panels/coverage/CoverageView.ts +20 -5
  177. package/front_end/panels/css_overview/CSSOverviewCompletedView.ts +4 -3
  178. package/front_end/panels/css_overview/CSSOverviewPanel.ts +2 -2
  179. package/front_end/panels/css_overview/CSSOverviewProcessingView.ts +2 -2
  180. package/front_end/panels/css_overview/CSSOverviewSidebarPanel.ts +2 -2
  181. package/front_end/panels/css_overview/CSSOverviewStartView.ts +2 -2
  182. package/front_end/panels/css_overview/CSSOverviewUnusedDeclarations.ts +8 -8
  183. package/front_end/panels/developer_resources/DeveloperResourcesListView.ts +2 -3
  184. package/front_end/panels/developer_resources/DeveloperResourcesView.ts +4 -5
  185. package/front_end/panels/elements/AccessibilityTreeUtils.ts +6 -7
  186. package/front_end/panels/elements/CSSValueTraceView.ts +3 -3
  187. package/front_end/panels/elements/ClassesPaneWidget.ts +1 -2
  188. package/front_end/panels/elements/ComputedStyleWidget.ts +15 -14
  189. package/front_end/panels/elements/DOMTreeElementWidget.ts +5 -4
  190. package/front_end/panels/elements/DOMTreeWidget.ts +2 -1
  191. package/front_end/panels/elements/ElementStatePaneWidget.ts +2 -2
  192. package/front_end/panels/elements/ElementsPanel.ts +1 -0
  193. package/front_end/panels/elements/EventListenersWidget.ts +2 -2
  194. package/front_end/panels/elements/LayoutPane.ts +2 -2
  195. package/front_end/panels/elements/PlatformFontsWidget.ts +3 -3
  196. package/front_end/panels/elements/PropertiesWidget.ts +9 -10
  197. package/front_end/panels/elements/PropertyRenderer.ts +72 -11
  198. package/front_end/panels/elements/StandaloneStylesContainer.ts +5 -10
  199. package/front_end/panels/elements/StyleEditorWidget.ts +30 -16
  200. package/front_end/panels/elements/StylePropertiesSection.ts +93 -44
  201. package/front_end/panels/elements/StylePropertyTreeElement.ts +230 -302
  202. package/front_end/panels/elements/StylesContainer.ts +2 -3
  203. package/front_end/panels/elements/StylesSidebarPane.ts +4 -13
  204. package/front_end/panels/elements/components/AccessibilityTreeNode.ts +66 -37
  205. package/front_end/panels/elements/components/CSSHintDetailsView.ts +51 -41
  206. package/front_end/panels/elements/components/CSSPropertyDocsView.ts +75 -65
  207. package/front_end/panels/elements/components/CSSQuery.ts +112 -74
  208. package/front_end/panels/elements/components/CSSVariableValueView.ts +109 -68
  209. package/front_end/panels/elements/components/ComputedStyleProperty.ts +64 -45
  210. package/front_end/panels/elements/components/ElementsTreeExpandButton.ts +35 -28
  211. package/front_end/panels/elements/components/QueryContainer.ts +104 -74
  212. package/front_end/panels/elements/components/accessibilityTreeNode.css +22 -20
  213. package/front_end/panels/elements/components/computedStyleProperty.css +2 -0
  214. package/front_end/panels/elements/components/cssHintDetailsView.css +23 -21
  215. package/front_end/panels/elements/components/cssPropertyDocsView.css +38 -36
  216. package/front_end/panels/elements/components/cssVariableValueView.css +42 -40
  217. package/front_end/panels/elements/components/elementsTreeExpandButton.css +5 -2
  218. package/front_end/panels/elements/components/queryContainer.css +23 -21
  219. package/front_end/panels/elements/stylesSidebarPane.css +3 -3
  220. package/front_end/panels/emulation/DeviceModeToolbar.ts +2 -2
  221. package/front_end/panels/emulation/InspectedPagePlaceholder.ts +2 -2
  222. package/front_end/panels/emulation/MediaQueryInspector.ts +9 -10
  223. package/front_end/panels/emulation/mediaQueryInspector.css +1 -1
  224. package/front_end/panels/event_listeners/EventListenersView.ts +2 -2
  225. package/front_end/panels/issues/AffectedCookiesView.ts +144 -101
  226. package/front_end/panels/issues/AffectedDescendantsWithinSelectElementView.ts +83 -31
  227. package/front_end/panels/issues/AffectedDirectivesView.ts +218 -135
  228. package/front_end/panels/issues/AffectedDocumentsInQuirksModeView.ts +84 -34
  229. package/front_end/panels/issues/AffectedElementsView.ts +86 -23
  230. package/front_end/panels/issues/AffectedLazyLoadImagesView.ts +2 -2
  231. package/front_end/panels/issues/AffectedMetadataAllowedSitesView.ts +2 -2
  232. package/front_end/panels/issues/AffectedPartitioningBlobURLView.ts +36 -11
  233. package/front_end/panels/issues/AffectedSharedArrayBufferIssueDetailsView.ts +135 -58
  234. package/front_end/panels/issues/AffectedSourcesView.ts +49 -28
  235. package/front_end/panels/issues/AffectedTrackingSitesView.ts +3 -4
  236. package/front_end/panels/issues/CorsIssueDetailsView.ts +490 -269
  237. package/front_end/panels/issues/GenericIssueDetailsView.ts +2 -2
  238. package/front_end/panels/issues/IssueKindView.ts +63 -48
  239. package/front_end/panels/issues/IssueView.ts +14 -18
  240. package/front_end/panels/issues/components/ElementsPanelLink.ts +70 -34
  241. package/front_end/panels/issues/components/HideIssuesMenu.ts +56 -32
  242. package/front_end/panels/issues/components/elementsPanelLink.css +10 -6
  243. package/front_end/panels/issues/components/hideIssuesMenu.css +16 -14
  244. package/front_end/panels/issues/issues.ts +2 -0
  245. package/front_end/panels/issues/issuesTree.css +4 -4
  246. package/front_end/panels/lighthouse/LighthouseController.ts +6 -6
  247. package/front_end/panels/lighthouse/LighthouseStatusView.ts +12 -13
  248. package/front_end/panels/lighthouse/lighthouseStartView.css +1 -1
  249. package/front_end/panels/linear_memory_inspector/LinearMemoryInspectorPane.ts +159 -161
  250. package/front_end/panels/linear_memory_inspector/LinearMemoryInspectorView.ts +228 -0
  251. package/front_end/panels/linear_memory_inspector/components/LinearMemoryInspector.ts +32 -41
  252. package/front_end/panels/linear_memory_inspector/components/linearMemoryHighlightChipList.css +2 -2
  253. package/front_end/panels/linear_memory_inspector/linear_memory_inspector.ts +2 -0
  254. package/front_end/panels/media/EventDisplayTable.ts +2 -2
  255. package/front_end/panels/media/MainView.ts +132 -66
  256. package/front_end/panels/media/PlayerDetailView.ts +32 -14
  257. package/front_end/panels/media/PlayerListView.ts +83 -23
  258. package/front_end/panels/media/PlayerPropertiesView.ts +2 -2
  259. package/front_end/panels/media/TickingFlameChart.ts +153 -63
  260. package/front_end/panels/mobile_throttling/NetworkThrottlingSelector.ts +2 -2
  261. package/front_end/panels/mobile_throttling/ThrottlingSettingsTab.ts +615 -464
  262. package/front_end/panels/mobile_throttling/throttlingSettingsTab.css +43 -0
  263. package/front_end/panels/network/EventSourceMessagesView.ts +3 -3
  264. package/front_end/panels/network/NetworkConfigView.ts +6 -2
  265. package/front_end/panels/network/NetworkDataGridNode.ts +2 -1
  266. package/front_end/panels/network/NetworkItemView.ts +27 -26
  267. package/front_end/panels/network/NetworkManageCustomHeadersView.ts +236 -97
  268. package/front_end/panels/network/NetworkOverview.ts +8 -10
  269. package/front_end/panels/network/RequestConditionsDrawer.ts +8 -4
  270. package/front_end/panels/network/RequestDeviceBoundSessionsView.ts +2 -4
  271. package/front_end/panels/network/RequestHTMLView.ts +26 -7
  272. package/front_end/panels/network/RequestHeadersView.ts +2 -2
  273. package/front_end/panels/network/RequestInitiatorView.ts +21 -22
  274. package/front_end/panels/network/RequestPayloadView.ts +2 -16
  275. package/front_end/panels/network/RequestPreviewView.ts +5 -5
  276. package/front_end/panels/network/RequestTimingView.ts +6 -6
  277. package/front_end/panels/network/ResourceDirectSocketChunkView.ts +5 -6
  278. package/front_end/panels/network/ResourceWebSocketFrameView.ts +4 -3
  279. package/front_end/panels/network/ShowMoreDetailsWidget.ts +11 -12
  280. package/front_end/panels/network/SignedExchangeInfoView.ts +2 -2
  281. package/front_end/panels/network/networkLogView.css +2 -2
  282. package/front_end/panels/network/networkManageCustomHeadersView.css +27 -6
  283. package/front_end/panels/network/requestConditionsDrawer.css +1 -1
  284. package/front_end/panels/network/requestInitiatorView.css +5 -3
  285. package/front_end/panels/performance_monitor/PerformanceMonitor.ts +2 -2
  286. package/front_end/panels/profiler/HeapDetachedElementsView.ts +1 -2
  287. package/front_end/panels/profiler/HeapTimelineOverview.ts +77 -15
  288. package/front_end/panels/profiler/IsolateSelector.ts +258 -187
  289. package/front_end/panels/profiler/ProfileLauncherView.ts +7 -29
  290. package/front_end/panels/profiler/profileLauncherView.css +6 -1
  291. package/front_end/panels/protocol_monitor/JSONEditor.ts +4 -5
  292. package/front_end/panels/recorder/ControlButton.ts +1 -1
  293. package/front_end/panels/recorder/RecordingListView.ts +2 -4
  294. package/front_end/panels/recorder/RecordingView.ts +1 -2
  295. package/front_end/panels/recorder/SelectorPicker.ts +2 -4
  296. package/front_end/panels/recorder/StepView.ts +24 -10
  297. package/front_end/panels/recorder/TimelineSection.ts +1 -1
  298. package/front_end/panels/recorder/recordingView.css +1 -1
  299. package/front_end/panels/screencast/ScreencastApp.ts +1 -1
  300. package/front_end/panels/search/SearchResultsPane.ts +11 -12
  301. package/front_end/panels/search/SearchView.ts +8 -10
  302. package/front_end/panels/security/SecurityPanel.ts +1 -8
  303. package/front_end/panels/security/SecurityPanelSidebar.ts +2 -2
  304. package/front_end/panels/security/mainView.css +1 -1
  305. package/front_end/panels/sensors/LocationsSettingsTab.ts +1 -2
  306. package/front_end/panels/settings/AISettingsTab.ts +1 -1
  307. package/front_end/panels/settings/BackendLinkingSettingsTab.ts +34 -20
  308. package/front_end/panels/settings/EditFileSystemView.ts +2 -2
  309. package/front_end/panels/settings/FrameworkIgnoreListSettingsTab.ts +375 -197
  310. package/front_end/panels/settings/KeybindsSettingsTab.ts +570 -414
  311. package/front_end/panels/settings/SettingsScreen.ts +312 -114
  312. package/front_end/panels/settings/WorkspaceSettingsTab.ts +2 -2
  313. package/front_end/panels/settings/aiSettingsTab.css +1 -4
  314. package/front_end/panels/settings/emulation/DevicesSettingsTab.ts +924 -578
  315. package/front_end/panels/settings/emulation/components/UserAgentClientHintsForm.ts +9 -2
  316. package/front_end/panels/settings/emulation/devicesSettingsTab.css +39 -0
  317. package/front_end/panels/settings/frameworkIgnoreListSettingsTab.css +37 -8
  318. package/front_end/panels/settings/settingsScreen.css +0 -24
  319. package/front_end/panels/sources/BreakpointEditDialog.ts +9 -6
  320. package/front_end/panels/sources/BreakpointsView.ts +25 -4
  321. package/front_end/panels/sources/CallStackSidebarPane.ts +7 -1
  322. package/front_end/panels/sources/DebuggerPlugin.ts +1 -0
  323. package/front_end/panels/sources/GoToLineQuickOpen.ts +8 -8
  324. package/front_end/panels/sources/NavigatorView.ts +521 -439
  325. package/front_end/panels/sources/PersistenceActions.ts +11 -12
  326. package/front_end/panels/sources/ProfilePlugin.ts +28 -17
  327. package/front_end/panels/sources/ScopeChainSidebarPane.ts +3 -4
  328. package/front_end/panels/sources/SourcesNavigator.ts +9 -9
  329. package/front_end/panels/sources/SourcesPanel.ts +2 -2
  330. package/front_end/panels/sources/SourcesView.ts +3 -3
  331. package/front_end/panels/sources/ThreadsSidebarPane.ts +2 -2
  332. package/front_end/panels/sources/WatchExpressionsSidebarPane.ts +2 -2
  333. package/front_end/panels/sources/components/HeadersView.ts +1 -2
  334. package/front_end/panels/timeline/CompatibilityTracksAppender.ts +5 -6
  335. package/front_end/panels/timeline/EventsTimelineTreeView.ts +73 -34
  336. package/front_end/panels/timeline/IsolateSelector.ts +25 -37
  337. package/front_end/panels/timeline/StatusDialog.ts +5 -7
  338. package/front_end/panels/timeline/ThirdPartyTreeView.ts +10 -13
  339. package/front_end/panels/timeline/TimelineDetailsView.ts +40 -21
  340. package/front_end/panels/timeline/TimelineEventOverview.ts +130 -34
  341. package/front_end/panels/timeline/TimelineFlameChartNetworkDataProvider.ts +1 -1
  342. package/front_end/panels/timeline/TimelineMiniMap.ts +255 -103
  343. package/front_end/panels/timeline/TimelinePaintProfilerView.ts +19 -11
  344. package/front_end/panels/timeline/TimelinePanel.ts +1 -0
  345. package/front_end/panels/timeline/TimelineSelectorStatsView.ts +11 -12
  346. package/front_end/panels/timeline/TimelineTreeView.ts +240 -122
  347. package/front_end/panels/timeline/TimelineUIUtils.ts +12 -0
  348. package/front_end/panels/timeline/components/BreadcrumbsUI.ts +5 -4
  349. package/front_end/panels/timeline/components/DetailsView.ts +97 -65
  350. package/front_end/panels/timeline/components/LayoutShiftDetails.ts +2 -2
  351. package/front_end/panels/timeline/components/MetricCard.ts +2 -2
  352. package/front_end/panels/timeline/components/NetworkRequestDetails.ts +11 -12
  353. package/front_end/panels/timeline/components/NetworkTrackWidget.ts +57 -50
  354. package/front_end/panels/timeline/components/RelatedInsightChips.ts +2 -2
  355. package/front_end/panels/timeline/components/Sidebar.ts +161 -109
  356. package/front_end/panels/timeline/components/SidebarAnnotationsTab.ts +33 -12
  357. package/front_end/panels/timeline/components/SidebarInsightsTab.ts +3 -0
  358. package/front_end/panels/timeline/components/insights/LCPDiscovery.ts +11 -11
  359. package/front_end/panels/timeline/components/insights/SlowCSSSelector.ts +6 -7
  360. package/front_end/panels/timeline/components/networkTrackWidget.css +24 -22
  361. package/front_end/panels/timeline/components/sidebarInsightsTab.css +1 -1
  362. package/front_end/panels/timeline/overlays/components/TimespanBreakdownOverlay.ts +15 -10
  363. package/front_end/panels/timeline/overlays/components/entryLabelOverlay.css +1 -1
  364. package/front_end/panels/timeline/timelinePanel.css +5 -0
  365. package/front_end/panels/timeline/timelineStatusDialog.css +1 -1
  366. package/front_end/panels/web_audio/WebAudioView.ts +2 -2
  367. package/front_end/third_party/chromium/README.chromium +1 -1
  368. package/front_end/third_party/legacy-javascript/README.chromium +2 -2
  369. package/front_end/third_party/legacy-javascript/lib/legacy-javascript.js +2 -2
  370. package/front_end/third_party/legacy-javascript/package.json +1 -1
  371. package/front_end/third_party/lighthouse/README.chromium +2 -2
  372. package/front_end/third_party/lighthouse/lighthouse-dt-bundle.js +1983 -2022
  373. package/front_end/third_party/lighthouse/locales/ar-XB.json +157 -142
  374. package/front_end/third_party/lighthouse/locales/ar.json +157 -142
  375. package/front_end/third_party/lighthouse/locales/bg.json +154 -139
  376. package/front_end/third_party/lighthouse/locales/ca.json +157 -142
  377. package/front_end/third_party/lighthouse/locales/cs.json +148 -133
  378. package/front_end/third_party/lighthouse/locales/da.json +153 -138
  379. package/front_end/third_party/lighthouse/locales/de.json +152 -137
  380. package/front_end/third_party/lighthouse/locales/el.json +153 -138
  381. package/front_end/third_party/lighthouse/locales/en-GB.json +160 -145
  382. package/front_end/third_party/lighthouse/locales/en-US.json +239 -218
  383. package/front_end/third_party/lighthouse/locales/en-XL.json +239 -218
  384. package/front_end/third_party/lighthouse/locales/es-419.json +150 -135
  385. package/front_end/third_party/lighthouse/locales/es.json +149 -134
  386. package/front_end/third_party/lighthouse/locales/fi.json +151 -136
  387. package/front_end/third_party/lighthouse/locales/fil.json +154 -139
  388. package/front_end/third_party/lighthouse/locales/fr.json +150 -135
  389. package/front_end/third_party/lighthouse/locales/he.json +160 -145
  390. package/front_end/third_party/lighthouse/locales/hi.json +156 -141
  391. package/front_end/third_party/lighthouse/locales/hr.json +154 -139
  392. package/front_end/third_party/lighthouse/locales/hu.json +111 -96
  393. package/front_end/third_party/lighthouse/locales/id.json +153 -138
  394. package/front_end/third_party/lighthouse/locales/it.json +153 -138
  395. package/front_end/third_party/lighthouse/locales/ja.json +150 -135
  396. package/front_end/third_party/lighthouse/locales/ko.json +42 -27
  397. package/front_end/third_party/lighthouse/locales/lt.json +152 -137
  398. package/front_end/third_party/lighthouse/locales/lv.json +93 -78
  399. package/front_end/third_party/lighthouse/locales/nl.json +149 -134
  400. package/front_end/third_party/lighthouse/locales/no.json +152 -137
  401. package/front_end/third_party/lighthouse/locales/pl.json +153 -138
  402. package/front_end/third_party/lighthouse/locales/pt-PT.json +152 -137
  403. package/front_end/third_party/lighthouse/locales/pt.json +157 -142
  404. package/front_end/third_party/lighthouse/locales/ro.json +149 -134
  405. package/front_end/third_party/lighthouse/locales/ru.json +76 -61
  406. package/front_end/third_party/lighthouse/locales/sk.json +153 -138
  407. package/front_end/third_party/lighthouse/locales/sl.json +149 -134
  408. package/front_end/third_party/lighthouse/locales/sr-Latn.json +151 -136
  409. package/front_end/third_party/lighthouse/locales/sr.json +151 -136
  410. package/front_end/third_party/lighthouse/locales/sv.json +152 -137
  411. package/front_end/third_party/lighthouse/locales/ta.json +156 -141
  412. package/front_end/third_party/lighthouse/locales/te.json +157 -142
  413. package/front_end/third_party/lighthouse/locales/th.json +111 -96
  414. package/front_end/third_party/lighthouse/locales/tr.json +153 -138
  415. package/front_end/third_party/lighthouse/locales/uk.json +149 -134
  416. package/front_end/third_party/lighthouse/locales/vi.json +162 -147
  417. package/front_end/third_party/lighthouse/locales/zh-HK.json +150 -135
  418. package/front_end/third_party/lighthouse/locales/zh-TW.json +154 -139
  419. package/front_end/third_party/lighthouse/locales/zh.json +152 -137
  420. package/front_end/third_party/lighthouse/report/bundle.d.ts +9 -8
  421. package/front_end/third_party/lighthouse/report/bundle.js +10 -10
  422. package/front_end/third_party/lighthouse/report-assets/report-generator.mjs +2 -7
  423. package/front_end/tsconfig.compatibility.json +1 -0
  424. package/front_end/tsconfig.json +3 -2
  425. package/front_end/ui/components/dialogs/TypeToAllowDialog.ts +0 -2
  426. package/front_end/ui/components/dialogs/typeToAllowDialog.css +0 -4
  427. package/front_end/ui/components/icon_button/fileSourceIcon.css +1 -1
  428. package/front_end/ui/components/input/textInput.css +1 -1
  429. package/front_end/ui/components/lists/List.ts +26 -14
  430. package/front_end/ui/components/menus/menus.ts +0 -2
  431. package/front_end/ui/components/suggestion_input/SuggestionInput.ts +351 -138
  432. package/front_end/ui/components/survey_link/surveyLink.css +3 -3
  433. package/front_end/ui/components/switch/switch.css +6 -6
  434. package/front_end/ui/components/text_editor/AiCodeCompletionTeaser.ts +2 -3
  435. package/front_end/ui/components/text_editor/TextEditor.ts +1 -1
  436. package/front_end/ui/components/tooltips/Tooltip.ts +53 -4
  437. package/front_end/ui/components/tree_outline/treeOutline.css +7 -7
  438. package/front_end/ui/helpers/OpenInNewTab.ts +8 -3
  439. package/front_end/ui/legacy/EmptyWidget.ts +4 -4
  440. package/front_end/ui/legacy/ForwardedInputEventHandler.ts +2 -2
  441. package/front_end/ui/legacy/GlassPane.ts +1 -1
  442. package/front_end/ui/legacy/KeyboardShortcut.ts +7 -7
  443. package/front_end/ui/legacy/RemoteDebuggingTerminatedScreen.ts +2 -2
  444. package/front_end/ui/legacy/TabbedPane.ts +198 -66
  445. package/front_end/ui/legacy/TargetCrashedScreen.ts +2 -2
  446. package/front_end/ui/legacy/UIUtils.ts +71 -68
  447. package/front_end/ui/legacy/View.ts +7 -4
  448. package/front_end/ui/legacy/ViewManager.ts +49 -37
  449. package/front_end/ui/legacy/Widget.ts +32 -12
  450. package/front_end/ui/legacy/components/cookie_table/CookiesTable.ts +2 -3
  451. package/front_end/ui/legacy/components/inline_editor/AnimationTimingUI.ts +8 -8
  452. package/front_end/ui/legacy/components/inline_editor/BezierUI.ts +8 -9
  453. package/front_end/ui/legacy/components/inline_editor/LinkSwatch.ts +2 -2
  454. package/front_end/ui/legacy/components/inline_editor/cssAngleEditor.css +1 -1
  455. package/front_end/ui/legacy/components/inline_editor/cssAngleSwatch.css +1 -1
  456. package/front_end/ui/legacy/components/object_ui/ObjectPropertiesSection.ts +45 -11
  457. package/front_end/ui/legacy/components/object_ui/RemoteObjectPreviewFormatter.ts +10 -12
  458. package/front_end/ui/legacy/components/perf_ui/ChartViewport.ts +102 -29
  459. package/front_end/ui/legacy/components/perf_ui/FlameChart.ts +148 -122
  460. package/front_end/ui/legacy/components/perf_ui/TimelineOverviewPane.ts +20 -14
  461. package/front_end/ui/legacy/components/quick_open/filteredListWidget.css +1 -1
  462. package/front_end/ui/legacy/components/source_frame/FontView.ts +29 -5
  463. package/front_end/ui/legacy/components/source_frame/ImageView.ts +79 -12
  464. package/front_end/ui/legacy/components/source_frame/JSONView.ts +20 -2
  465. package/front_end/ui/legacy/components/source_frame/PreviewFactory.ts +2 -2
  466. package/front_end/ui/legacy/components/source_frame/StreamingContentHexView.ts +6 -10
  467. package/front_end/ui/legacy/components/source_frame/XMLView.ts +11 -11
  468. package/front_end/ui/legacy/components/source_frame/fontView.css +7 -0
  469. package/front_end/ui/legacy/components/source_frame/imageView.css +7 -0
  470. package/front_end/ui/legacy/components/utils/JSPresentationUtils.ts +14 -3
  471. package/front_end/ui/legacy/components/utils/Linkifier.ts +126 -2
  472. package/front_end/ui/legacy/emptyWidget.css +2 -1
  473. package/front_end/ui/legacy/inspectorCommon.css +3 -3
  474. package/front_end/ui/legacy/smallBubble.css +1 -1
  475. package/front_end/ui/legacy/tabbedPane.css +6 -0
  476. package/front_end/ui/lit/Directives.ts +35 -18
  477. package/front_end/ui/lit/lit.ts +0 -2
  478. package/front_end/ui/lit/render.ts +0 -7
  479. package/front_end/ui/visual_logging/KnownContextValues.ts +5 -0
  480. package/package.json +1 -1
  481. package/vpython.toml +8 -0
  482. package/vpython.toml.uv.lock +3 -0
  483. package/.agents/skills/review-models-core/SKILL.md +0 -73
  484. package/.agents/skills/review-tests/SKILL.md +0 -67
  485. package/.agents/skills/review-ui-widgets/SKILL.md +0 -115
  486. package/front_end/generated/ARIAProperties.ts +0 -2686
  487. package/front_end/ui/components/menus/README.md +0 -119
  488. package/front_end/ui/components/menus/SelectMenu.ts +0 -473
  489. package/front_end/ui/components/menus/selectMenu.css +0 -54
  490. package/front_end/ui/components/menus/selectMenuButton.css +0 -108
@@ -43,7 +43,7 @@ const UIStrings = {
43
43
  } as const;
44
44
  const str_ = i18n.i18n.registerUIStrings('panels/profiler/ProfileLauncherView.ts', UIStrings);
45
45
  const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
46
- const {widget, widgetRef} = UI.Widget;
46
+ const {widget} = UI.Widget;
47
47
 
48
48
  interface ProfileTypeEntry {
49
49
  profileType: ProfileType;
@@ -58,20 +58,15 @@ export interface ViewInput {
58
58
  controlButtonDisabled: boolean;
59
59
  controlButtonTooltip: string;
60
60
  isProfiling: boolean;
61
- isolateSelector: IsolateSelector|null;
62
61
  onControlClick: () => void;
63
62
  onLoadClick: () => void;
64
63
  onProfileTypeChange: (profileType: ProfileType) => void;
65
64
  }
66
65
 
67
- export interface ViewOutput {
68
- isolateSelector: IsolateSelector;
69
- }
70
-
71
- export type View = (input: ViewInput, output: ViewOutput, target: HTMLElement) => void;
66
+ export type View = (input: ViewInput, _output: undefined, target: HTMLElement) => void;
72
67
 
73
68
  // clang-format off
74
- export const DEFAULT_VIEW: View = (input, output, target) => {
69
+ export const DEFAULT_VIEW: View = (input, _output, target) => {
75
70
  render(html`
76
71
  <style>${profileLauncherViewStyles}</style>
77
72
  <div class="profile-launcher-view-content vbox" jslog=${VisualLogging.section('profiler.launcher')}>
@@ -105,13 +100,7 @@ export const DEFAULT_VIEW: View = (input, output, target) => {
105
100
  </div>
106
101
  <div class="vbox profile-isolate-selector-block">
107
102
  <h1>${i18nString(UIStrings.selectJavascriptVmInstance)}</h1>
108
- <div class="vbox profile-launcher-target-list profile-launcher-target-list-container">
109
- <devtools-widget
110
- ${widget(IsolateSelector)}
111
- ${widgetRef(IsolateSelector, e => {output.isolateSelector = e;})}
112
- ></devtools-widget>
113
- </div>
114
- ${input.isolateSelector?.totalMemoryElement() ?? nothing}
103
+ ${widget(IsolateSelector)}
115
104
  </div>
116
105
  <div class="hbox profile-launcher-buttons">
117
106
  <devtools-button
@@ -129,7 +118,7 @@ export const DEFAULT_VIEW: View = (input, output, target) => {
129
118
  >${input.controlButtonText}</devtools-button>
130
119
  </div>
131
120
  </div>
132
- `, target);
121
+ `, target, {container: {classes: ['profile-launcher-view']}});
133
122
  };
134
123
  // clang-format on
135
124
 
@@ -142,7 +131,6 @@ export class ProfileLauncherView extends ProfileLauncherViewBase {
142
131
  readonly panel: ProfilesPanel;
143
132
  readonly selectedProfileTypeSetting: Common.Settings.Setting<string>;
144
133
  readonly #view: View;
145
- #isolateSelector: IsolateSelector|null = null;
146
134
  #profileTypes = new Map<string, ProfileType>();
147
135
  #isProfiling = false;
148
136
  #isInstantProfile = false;
@@ -151,7 +139,7 @@ export class ProfileLauncherView extends ProfileLauncherViewBase {
151
139
  #selectedTypeId = '';
152
140
 
153
141
  constructor(profilesPanel: ProfilesPanel, view: View = DEFAULT_VIEW) {
154
- super({classes: ['profile-launcher-view']});
142
+ super();
155
143
 
156
144
  this.#view = view;
157
145
  this.panel = profilesPanel;
@@ -243,7 +231,6 @@ export class ProfileLauncherView extends ProfileLauncherViewBase {
243
231
  (this.#isProfiling ? i18nString(UIStrings.stop) : i18nString(UIStrings.start));
244
232
  const controlButtonDisabled = !(this.#isEnabled && this.#recordButtonEnabled);
245
233
  const controlButtonTooltip = this.#recordButtonEnabled ? '' : UI.UIUtils.anotherProfilerActiveLabel();
246
- const that = this;
247
234
 
248
235
  this.#view(
249
236
  {
@@ -253,7 +240,6 @@ export class ProfileLauncherView extends ProfileLauncherViewBase {
253
240
  controlButtonDisabled,
254
241
  controlButtonTooltip,
255
242
  isProfiling: this.#isProfiling,
256
- isolateSelector: this.#isolateSelector,
257
243
  onControlClick: () => {
258
244
  this.panel.toggleRecord();
259
245
  },
@@ -265,15 +251,7 @@ export class ProfileLauncherView extends ProfileLauncherViewBase {
265
251
  this.#profileTypeChanged(profileType);
266
252
  },
267
253
  },
268
- {
269
- set isolateSelector(isolateSelector: IsolateSelector) {
270
- if (that.#isolateSelector === isolateSelector) {
271
- return;
272
- }
273
- that.#isolateSelector = isolateSelector;
274
- that.requestUpdate();
275
- },
276
- },
254
+ undefined,
277
255
  this.contentElement,
278
256
  );
279
257
  }
@@ -43,6 +43,11 @@
43
43
  & > .profile-isolate-selector-block {
44
44
  flex: auto 1 0;
45
45
  overflow: hidden;
46
+
47
+ & > devtools-widget {
48
+ flex: auto 1 0;
49
+ overflow: hidden;
50
+ }
46
51
  }
47
52
  }
48
53
 
@@ -63,7 +68,7 @@
63
68
  line-height: var(--sys-size-8);
64
69
  }
65
70
 
66
- .profile-isolate-selector-block > .profile-memory-usage-item {
71
+ .profile-isolate-selector-block > devtools-widget > .profile-memory-usage-item {
67
72
  margin-left: var(--sys-size-1);
68
73
  margin-bottom: var(--sys-size-3);
69
74
  font-weight: bolder;
@@ -139,7 +139,7 @@ interface ViewInput {
139
139
  displayToolbar?: boolean;
140
140
  }
141
141
 
142
- export type View = (input: ViewInput, output: object, target: HTMLElement) => void;
142
+ export type View = (input: ViewInput, output: undefined, target: HTMLElement) => void;
143
143
 
144
144
  const splitDescription = (description: string): [string, string] => {
145
145
  // If the description is too long we make the UI a bit better by highlighting the first sentence
@@ -527,13 +527,13 @@ export class JSONEditor extends JSONEditorBase {
527
527
  return {
528
528
  box: hintElement.boxInWindow(),
529
529
  show: async (popover: UI.GlassPane.GlassPane) => {
530
- const popupElement = new ElementsComponents.CSSHintDetailsView.CSSHintDetailsView({
530
+ const popupWidget = new ElementsComponents.CSSHintDetailsView.CSSHintDetailsView({
531
531
  getMessage: () => html`<span>${head}</span>`,
532
532
  getPossibleFixMessage: () => popupContent,
533
533
  getLearnMoreLink: () =>
534
534
  `https://chromedevtools.github.io/devtools-protocol/tot/${this.command.split('.')[0]}/`,
535
535
  });
536
- popover.contentElement.appendChild(popupElement);
536
+ popupWidget.show(popover.contentElement);
537
537
  return true;
538
538
  },
539
539
  };
@@ -1007,8 +1007,7 @@ export class JSONEditor extends JSONEditorBase {
1007
1007
  displayCommandInput: this.displayCommandInput,
1008
1008
  displayToolbar: this.displayToolbar,
1009
1009
  };
1010
- const viewOutput = {};
1011
- this.#view(viewInput, viewOutput, this.contentElement);
1010
+ this.#view(viewInput, undefined, this.contentElement);
1012
1011
  }
1013
1012
  }
1014
1013
 
@@ -80,6 +80,6 @@ export class ControlButton extends UI.Widget.Widget<ShadowRoot> {
80
80
  disabled: this.#disabled,
81
81
  onClick: this.#onClick,
82
82
  },
83
- {}, this.contentElement);
83
+ undefined, this.contentElement);
84
84
  }
85
85
  }
@@ -59,9 +59,7 @@ interface ViewInput {
59
59
  onKeyDown: (storageName: string, event: Event) => void;
60
60
  }
61
61
 
62
- export type ViewOutput = object;
63
-
64
- export const DEFAULT_VIEW = (input: ViewInput, _output: ViewOutput, target: HTMLElement): void => {
62
+ export const DEFAULT_VIEW = (input: ViewInput, _output: undefined, target: HTMLElement): void => {
65
63
  const {
66
64
  recordings,
67
65
  replayAllowed,
@@ -212,7 +210,7 @@ export class RecordingListView extends UI.Widget.Widget {
212
210
  onPlayRecordingClick: this.#onPlayRecordingClick.bind(this),
213
211
  onKeyDown: this.#onKeyDown.bind(this),
214
212
  },
215
- {}, this.contentElement);
213
+ undefined, this.contentElement);
216
214
  }
217
215
 
218
216
  override wasShown(): void {
@@ -532,8 +532,6 @@ function renderSections(input: ViewInput): Lit.LitTemplate {
532
532
  <devtools-button
533
533
  @click=${input.showCodeToggle}
534
534
  class="show-code"
535
- aria-controls="recording-code-pane"
536
- aria-expanded=${input.showCodeView}
537
535
  .data=${
538
536
  {
539
537
  variant: Buttons.Button.Variant.OUTLINED,
@@ -541,6 +539,7 @@ function renderSections(input: ViewInput): Lit.LitTemplate {
541
539
  codeToggleTitle,
542
540
  Actions.RecorderActions.TOGGLE_CODE_VIEW,
543
541
  ),
542
+ accessibleExpanded: Boolean(input.showCodeView),
544
543
  } as Buttons.Button.ButtonData
545
544
  }
546
545
  jslog=${VisualLogging.toggleSubpane(Actions.RecorderActions.TOGGLE_CODE_VIEW).track({click: true})}
@@ -35,9 +35,7 @@ export interface ViewInput {
35
35
  onClick: (event: MouseEvent) => void;
36
36
  }
37
37
 
38
- export type ViewOutput = object;
39
-
40
- export const DEFAULT_VIEW = (input: ViewInput, _output: ViewOutput, target: HTMLElement): void => {
38
+ export const DEFAULT_VIEW = (input: ViewInput, _output: undefined, target: HTMLElement): void => {
41
39
  const {active, disabled, onClick} = input;
42
40
  Lit.render(
43
41
  html`
@@ -94,7 +92,7 @@ export class SelectorPicker extends UI.Widget.Widget implements SDK.TargetManage
94
92
  disabled: this.#disabled,
95
93
  onClick: this.#handleClickEvent.bind(this),
96
94
  },
97
- {},
95
+ undefined,
98
96
  this.contentElement,
99
97
  );
100
98
  }
@@ -90,6 +90,10 @@ const UIStrings = {
90
90
  * @description Default title for elements without a specific role.
91
91
  */
92
92
  elementRoleFallback: 'Element',
93
+ /**
94
+ * @description Placeholder title for a recording section without a title.
95
+ */
96
+ noTitle: '(No title)',
93
97
  /**
94
98
  * @description The title of the button in the step's context menu that adds a new step before the current one.
95
99
  */
@@ -104,16 +108,19 @@ const UIStrings = {
104
108
  removeStep: 'Remove step',
105
109
  /**
106
110
  * @description The title of the button that opens the step's context menu.
111
+ * @example {Click} title
107
112
  */
108
- openStepActions: 'Open step actions',
113
+ openStepActions: 'Open step actions for {title}',
109
114
  /**
110
115
  * @description The title of the button in the step's context menu that adds a breakpoint.
116
+ * @example {Click} title
111
117
  */
112
- addBreakpoint: 'Add breakpoint',
118
+ addBreakpoint: 'Add breakpoint for {title}',
113
119
  /**
114
120
  * @description The title of the button in the step's context menu that removes a breakpoint.
121
+ * @example {Click} title
115
122
  */
116
- removeBreakpoint: 'Remove breakpoint',
123
+ removeBreakpoint: 'Remove breakpoint for {title}',
117
124
  /**
118
125
  * @description A menu item in the context menu that expands another menu which lists all
119
126
  * the formats the user can copy the recording as.
@@ -196,9 +203,9 @@ export type ViewOutput = unknown;
196
203
  function getStepTypeTitle(input: {
197
204
  step?: Models.Schema.Step,
198
205
  section?: Models.Section.Section,
199
- }): string|Lit.TemplateResult {
206
+ }): string {
200
207
  if (input.section) {
201
- return input.section.title ? input.section.title : html`<span class="fallback">(No Title)</span>`;
208
+ return input.section.title || i18nString(UIStrings.noTitle);
202
209
  }
203
210
  if (!input.step) {
204
211
  throw new Error('Missing both step and section');
@@ -272,12 +279,20 @@ function getSectionPreview(section?: Models.Section.Section): string {
272
279
  return section.url;
273
280
  }
274
281
 
282
+ function getBreakpointTitle(input: ViewInput): Platform.UIString.LocalizedString {
283
+ const title = getStepTypeTitle(input);
284
+ return input.hasBreakpoint ? i18nString(UIStrings.removeBreakpoint, {title}) :
285
+ i18nString(UIStrings.addBreakpoint, {title});
286
+ }
287
+
275
288
  function renderStepActions(input: ViewInput): Lit.TemplateResult|null {
289
+ const title = getStepTypeTitle(input);
290
+ const accessibleLabel = i18nString(UIStrings.openStepActions, {title});
276
291
  // clang-format off
277
292
  return html`
278
293
  <devtools-menu-button
279
294
  class="step-actions"
280
- .accessibleLabel=${i18nString(UIStrings.openStepActions)}
295
+ .accessibleLabel=${accessibleLabel}
281
296
  .populateMenuCall=${input.populateStepContextMenu}
282
297
  @keydown=${(event: Event) => {
283
298
  event.stopPropagation();
@@ -314,8 +329,7 @@ export const DEFAULT_VIEW = (input: ViewInput, _output: ViewOutput, target: HTML
314
329
  section: input.section,
315
330
  });
316
331
  const subtitle = input.step ? getSelectorPreview(input.step) : getSectionPreview(input.section);
317
- const breakpointTitle =
318
- input.hasBreakpoint ? i18nString(UIStrings.removeBreakpoint) : i18nString(UIStrings.addBreakpoint);
332
+ const breakpointTitle = getBreakpointTitle(input);
319
333
 
320
334
  // clang-format off
321
335
  Lit.render(
@@ -734,14 +748,14 @@ export class StepView extends UI.Widget.Widget<ShadowRoot> {
734
748
  if (this.#viewInput.hasBreakpoint) {
735
749
  actions.push({
736
750
  id: 'remove-breakpoint',
737
- label: i18nString(UIStrings.removeBreakpoint),
751
+ label: getBreakpointTitle(this.#viewInput),
738
752
  group: 'breakPointManagement',
739
753
  groupTitle: i18nString(UIStrings.breakpoints),
740
754
  });
741
755
  } else {
742
756
  actions.push({
743
757
  id: 'add-breakpoint',
744
- label: i18nString(UIStrings.addBreakpoint),
758
+ label: getBreakpointTitle(this.#viewInput),
745
759
  group: 'breakPointManagement',
746
760
  groupTitle: i18nString(UIStrings.breakpoints),
747
761
  });
@@ -96,7 +96,7 @@ export class TimelineSection extends UI.Widget.Widget {
96
96
  isLastSection: this.#isLastSection,
97
97
  isSelected: this.#isSelected,
98
98
  },
99
- {},
99
+ undefined,
100
100
  this.contentElement,
101
101
  );
102
102
  }
@@ -159,7 +159,7 @@
159
159
  height: var(--sys-size-6);
160
160
  display: inline-block;
161
161
  background: var(--sys-color-primary);
162
- border-radius: 50%;
162
+ border-radius: var(--sys-shape-corner-full);
163
163
  margin-right: 7px;
164
164
  }
165
165
 
@@ -135,7 +135,7 @@ export class ScreencastApp implements UI.App.App,
135
135
  screencastEnabled,
136
136
  screenCaptureModel: this.#screenCaptureModel,
137
137
  },
138
- {}, this.#rootView.contentElement);
138
+ undefined, this.#rootView.contentElement);
139
139
  }
140
140
  }
141
141
  }
@@ -265,18 +265,17 @@ export class SearchResultsPane extends UI.Widget.VBox {
265
265
  }
266
266
  this.#resultsUpdated = false;
267
267
  }
268
- this.#view(
269
- {
270
- results: this.#searchResults,
271
- matches: this.#searchMatches,
272
- expandedResults: this.#expandedResults,
273
- onSelectMatch: (searchResult, matchIndex) => {
274
- void Common.Revealer.reveal(searchResult.matchRevealable(matchIndex));
275
- },
276
- onExpandSearchResult: this.#onExpandSearchResult.bind(this),
277
- onShowMoreMatches: this.#onShowMoreMatches.bind(this),
278
- },
279
- {}, this.contentElement);
268
+ this.#view({
269
+ results: this.#searchResults,
270
+ matches: this.#searchMatches,
271
+ expandedResults: this.#expandedResults,
272
+ onSelectMatch: (searchResult, matchIndex) => {
273
+ void Common.Revealer.reveal(searchResult.matchRevealable(matchIndex));
274
+ },
275
+ onExpandSearchResult: this.#onExpandSearchResult.bind(this),
276
+ onShowMoreMatches: this.#onShowMoreMatches.bind(this),
277
+ },
278
+ undefined, this.contentElement);
280
279
  }
281
280
 
282
281
  #regexMatchRanges(lineContent: string, regex: RegExp): TextUtils.TextRange.SourceRange[] {
@@ -158,9 +158,8 @@ export const DEFAULT_VIEW: View = (input, output, target) => {
158
158
  let header = '', text = '';
159
159
  if (!query) {
160
160
  header = i18nString(UIStrings.noSearchResult);
161
- text = i18nString(
162
- UIStrings.typeAndPressSToSearch,
163
- {PH1: UI.KeyboardShortcut.KeyboardShortcut.shortcutToString(UI.KeyboardShortcut.Keys.Enter)});
161
+ text = i18nString(UIStrings.typeAndPressSToSearch,
162
+ {PH1: UI.KeyboardShortcut.KeyboardShortcut.shortcutToString(UI.KeyboardShortcut.Keys.Enter)});
164
163
  } else if (progress) {
165
164
  header = i18nString(UIStrings.searching);
166
165
  } else if (!searchResults.length) {
@@ -276,7 +275,7 @@ export class SearchView extends UI.Widget.VBox<ShadowRoot> {
276
275
  #searchMatchesCount: number;
277
276
  #searchResultsCount: number;
278
277
  #nonEmptySearchResultsCount: number;
279
- #searchingView: UI.Widget.Widget|null;
278
+ #searchingView: UI.EmptyWidget.EmptyWidget|null;
280
279
  #searchConfig: Workspace.SearchConfig.SearchConfig|null;
281
280
  #pendingSearchConfig: Workspace.SearchConfig.SearchConfig|null;
282
281
  #progress: Common.Progress.Progress|null;
@@ -465,9 +464,9 @@ export class SearchView extends UI.Widget.VBox<ShadowRoot> {
465
464
  new Common.Progress.ProgressProxy(new Common.Progress.Progress(), undefined, this.requestUpdate.bind(this));
466
465
  this.#searchStarted();
467
466
  if (this.#searchScope) {
468
- void this.#searchScope.performSearch(
469
- searchConfig, this.#progress, this.#onSearchResult.bind(this, this.#searchId),
470
- this.#onSearchFinished.bind(this, this.#searchId));
467
+ void this.#searchScope.performSearch(searchConfig, this.#progress,
468
+ this.#onSearchResult.bind(this, this.#searchId),
469
+ this.#onSearchFinished.bind(this, this.#searchId));
471
470
  }
472
471
  }
473
472
 
@@ -508,9 +507,8 @@ export class SearchView extends UI.Widget.VBox<ShadowRoot> {
508
507
  } else if (this.#searchMatchesCount > 1 && this.#nonEmptySearchResultsCount === 1) {
509
508
  this.#searchResultsMessage = i18nString(UIStrings.foundDMatchingLinesInFile, {PH1: this.#searchMatchesCount});
510
509
  } else {
511
- this.#searchResultsMessage = i18nString(
512
- UIStrings.foundDMatchingLinesInDFiles,
513
- {PH1: this.#searchMatchesCount, PH2: this.#nonEmptySearchResultsCount});
510
+ this.#searchResultsMessage = i18nString(UIStrings.foundDMatchingLinesInDFiles,
511
+ {PH1: this.#searchMatchesCount, PH2: this.#nonEmptySearchResultsCount});
514
512
  }
515
513
  } else {
516
514
  this.#searchResultsMessage = '';
@@ -505,7 +505,7 @@ export function getSecurityStateIconForOverview(
505
505
  return createIcon(iconName, className);
506
506
  }
507
507
 
508
- function renderHighlightedUrl(url: Platform.DevToolsPath.UrlString, securityState: string): TemplateResult {
508
+ export function renderHighlightedUrl(url: Platform.DevToolsPath.UrlString, securityState: string): TemplateResult {
509
509
  const schemeSeparator = '://';
510
510
  const index = url.indexOf(schemeSeparator);
511
511
 
@@ -525,13 +525,6 @@ function renderHighlightedUrl(url: Platform.DevToolsPath.UrlString, securityStat
525
525
  </span>`;
526
526
  }
527
527
 
528
- export function createHighlightedUrl(url: Platform.DevToolsPath.UrlString, securityState: string): Element {
529
- const fragment = document.createDocumentFragment();
530
- // eslint-disable-next-line @devtools/no-lit-render-outside-of-view
531
- render(renderHighlightedUrl(url, securityState), fragment);
532
- return fragment.firstElementChild as Element;
533
- }
534
-
535
528
  export interface ViewInput {
536
529
  panel: SecurityPanel;
537
530
  }
@@ -11,10 +11,10 @@ import {Directives, html, nothing, render, type TemplateResult} from '../../ui/l
11
11
 
12
12
  import lockIconStyles from './lockIcon.css.js';
13
13
  import {
14
- createHighlightedUrl,
15
14
  getSecurityStateIconForDetailedView,
16
15
  getSecurityStateIconForOverview,
17
16
  OriginGroup,
17
+ renderHighlightedUrl,
18
18
  } from './SecurityPanel.js';
19
19
  import sidebarStyles from './sidebar.css.js';
20
20
 
@@ -86,7 +86,7 @@ export const DEFAULT_VIEW: View = (input, output, target) => {
86
86
  output.onShowOrigin(origin);
87
87
  }}>
88
88
  ${renderIcon(icon)}
89
- ${createHighlightedUrl(origin, state)}
89
+ ${renderHighlightedUrl(origin, state)}
90
90
  </li>
91
91
  `;
92
92
  // clang-format on
@@ -134,7 +134,7 @@
134
134
  }
135
135
 
136
136
  .security-explanations-main {
137
- margin-top: -5px;
137
+ margin-top: calc(-1 * var(--sys-size-3));
138
138
  background-color: var(--sys-color-cdt-base-container);
139
139
  border-bottom: var(--sys-size-1) solid var(--sys-color-divider);
140
140
  }
@@ -426,7 +426,7 @@ export const DEFAULT_VIEW = (input: LocationsViewInput, _output: ViewOutput, tar
426
426
  </div>
427
427
  </div>
428
428
  ${input.activeDialog ? renderLocationDialog(input.activeDialog) : nothing}
429
- `, target);
429
+ `, target, {container: {attributes: {jslog: `${VisualLogging.pane('emulation-locations')}`}}});
430
430
  // clang-format on
431
431
  };
432
432
 
@@ -443,7 +443,6 @@ export class LocationsSettingsTab extends UI.Widget.VBox {
443
443
 
444
444
  constructor(element?: HTMLElement, view: View = DEFAULT_VIEW) {
445
445
  super(element, {
446
- jslog: `${VisualLogging.pane('emulation-locations')}`,
447
446
  useShadowDom: true,
448
447
  });
449
448
  this.#view = view;
@@ -426,7 +426,7 @@ export const AI_SETTINGS_TAB_DEFAULT_VIEW: View = (input, output, target): void
426
426
  size: Buttons.Button.Size.SMALL,
427
427
  iconName: 'bin',
428
428
  title: lockedString(UIStringsNotTranslate.removeAllowedTool),
429
- accessibleLabel: `${lockedString(UIStringsNotTranslate.removeAllowedTool)}: ${tool.displayName}`,
429
+ accessibleLabel: lockedString(`Remove ${tool.displayName} from allowed tools`),
430
430
  jslogContext: 'ai-remove-allowed-tool',
431
431
  } as Buttons.Button.ButtonData}
432
432
  @click=${() => input.removeAllowedTool(tool.toolName)}
@@ -125,7 +125,7 @@ export interface ViewInput {
125
125
  newRule: NetworkForward.BackendLinking.BackendLinkingRule) => void;
126
126
  onDeleteRule: (rule: NetworkForward.BackendLinking.BackendLinkingRule) => void;
127
127
  }
128
- export type View = (input: ViewInput, output: object, target: HTMLElement) => void;
128
+ export type View = (input: ViewInput, output: undefined, target: HTMLElement) => void;
129
129
  export const DEFAULT_VIEW: View = (input, output, target) => {
130
130
  const onCreate = (event: CustomEvent<{urlPattern?: string, targetUrlTemplate?: string, label?: string}>): void => {
131
131
  const data = event.detail;
@@ -252,6 +252,8 @@ export const DEFAULT_VIEW: View = (input, output, target) => {
252
252
  export class BackendLinkingSettingsTab extends UI.Widget.VBox {
253
253
  readonly #view: View;
254
254
  readonly #rulesSetting: Common.Settings.Setting<NetworkForward.BackendLinking.BackendLinkingRule[]>;
255
+ #rules: NetworkForward.BackendLinking.BackendLinkingRule[] = [];
256
+ #isSaving = false;
255
257
 
256
258
  constructor(target?: HTMLElement, view: View = DEFAULT_VIEW) {
257
259
  super(target);
@@ -266,44 +268,56 @@ export class BackendLinkingSettingsTab extends UI.Widget.VBox {
266
268
 
267
269
  override wasShown(): void {
268
270
  super.wasShown();
269
- this.#rulesSetting.addChangeListener(this.requestUpdate, this);
271
+ this.#rules = [...this.#rulesSetting.get()];
272
+ this.#rulesSetting.addChangeListener(this.#onRulesSettingChanged, this);
270
273
  this.requestUpdate();
271
274
  }
272
275
 
273
276
  override willHide(): void {
274
277
  super.willHide();
275
- this.#rulesSetting.removeChangeListener(this.requestUpdate, this);
278
+ this.#rulesSetting.removeChangeListener(this.#onRulesSettingChanged, this);
279
+ }
280
+
281
+ #onRulesSettingChanged(): void {
282
+ if (this.#isSaving) {
283
+ return;
284
+ }
285
+ this.#rules = [...this.#rulesSetting.get()];
286
+ this.requestUpdate();
287
+ }
288
+
289
+ #saveRules(): void {
290
+ this.#isSaving = true;
291
+ try {
292
+ this.#rulesSetting.set(this.#rules.filter(isRuleValid));
293
+ } finally {
294
+ this.#isSaving = false;
295
+ }
296
+ this.requestUpdate();
276
297
  }
277
298
 
278
299
  override performUpdate(): void {
279
300
  const input: ViewInput = {
280
- rules: this.#rulesSetting.get(),
301
+ rules: [...this.#rules],
281
302
  onAddRule: rule => {
282
- if (!isRuleValid(rule)) {
283
- return;
284
- }
285
- this.#rulesSetting.set([...this.#rulesSetting.get(), rule]);
303
+ this.#rules.push(rule);
304
+ this.#saveRules();
286
305
  },
287
306
  onUpdateRule: (oldRule, newRule) => {
288
- if (!isRuleValid(newRule)) {
289
- return;
290
- }
291
- const rules = [...this.#rulesSetting.get()];
292
- const index = rules.indexOf(oldRule);
307
+ const index = this.#rules.indexOf(oldRule);
293
308
  if (index !== -1) {
294
- rules[index] = newRule;
295
- this.#rulesSetting.set(rules);
309
+ this.#rules[index] = newRule;
310
+ this.#saveRules();
296
311
  }
297
312
  },
298
313
  onDeleteRule: rule => {
299
- const rules = [...this.#rulesSetting.get()];
300
- const index = rules.indexOf(rule);
314
+ const index = this.#rules.indexOf(rule);
301
315
  if (index !== -1) {
302
- rules.splice(index, 1);
303
- this.#rulesSetting.set(rules);
316
+ this.#rules.splice(index, 1);
317
+ this.#saveRules();
304
318
  }
305
319
  },
306
320
  };
307
- this.#view(input, {}, this.contentElement);
321
+ this.#view(input, undefined, this.contentElement);
308
322
  }
309
323
  }
@@ -65,7 +65,7 @@ export interface EditFileSystemViewInput {
65
65
  onDelete: (event: CustomEvent) => void;
66
66
  }
67
67
 
68
- export type View = (input: EditFileSystemViewInput, output: object, target: HTMLElement) => void;
68
+ export type View = (input: EditFileSystemViewInput, output: undefined, target: HTMLElement) => void;
69
69
 
70
70
  export const DEFAULT_VIEW: View = (input, _output, target) => {
71
71
  // clang-format off
@@ -143,7 +143,7 @@ export class EditFileSystemView extends UI.Widget.VBox {
143
143
  (e.currentTarget as HTMLElement).dataset.index ?? '-1', e.detail.valueBeforeEditing, e.detail.newText),
144
144
  onDelete: e => this.#onDelete((e.currentTarget as HTMLElement).dataset.index ?? '-1'),
145
145
  };
146
- this.#view(input, {}, this.contentElement);
146
+ this.#view(input, undefined, this.contentElement);
147
147
  }
148
148
 
149
149
  #onCreate(url?: string): void {