chrome-devtools-frontend 1.0.1726686 → 1.0.1730971

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (490) hide show
  1. package/.agents/rules/tests/test-strict-assertions-and-literal-expectations.md +1 -1
  2. package/.agents/rules/tests/test-view-and-presenter-isolation.md +1 -1
  3. package/.agents/rules/ui-and-widgets/ui-accessibility-and-semantic-html.md +1 -1
  4. package/.agents/rules/ui-and-widgets/ui-css-scoping-and-flex-layout.md +2 -2
  5. package/.agents/rules/ui-and-widgets/ui-declarative-child-widget-composition.md +5 -5
  6. package/.agents/rules/ui-and-widgets/ui-lit-declarative-templates-and-directives.md +2 -2
  7. package/.agents/rules/ui-and-widgets/ui-localization-and-uistrings-hygiene.md +2 -2
  8. package/.agents/rules/ui-and-widgets/ui-modern-component-and-encapsulation-standards.md +3 -3
  9. package/.agents/rules/ui-and-widgets/ui-pure-view-and-presenter-separation.md +2 -2
  10. package/.agents/rules/ui-and-widgets/ui-reactive-widget-update-lifecycle.md +2 -2
  11. package/.agents/rules/ui-and-widgets/ui-view-output-and-callback-contracts.md +2 -2
  12. package/.agents/rules/ui-and-widgets/ui-widget-dom-and-listener-lifecycle.md +2 -2
  13. package/.agents/skills/code-review/SKILL.md +63 -12
  14. package/.agents/skills/ui-eng-vision-local-lit-renderer/SKILL.md +38 -10
  15. package/.agents/skills/ui-eng-vision-widget-promoter/SKILL.md +1 -0
  16. package/.agents/skills/ui-widgets/SKILL.md +8 -2
  17. package/.agents/skills/write-ai-eval-test/SKILL.md +106 -0
  18. package/AUTHORS +2 -0
  19. package/DIR_METADATA +1 -2
  20. package/README.md +48 -26
  21. package/config/typescript/tsconfig.base.json +1 -0
  22. package/config/typescript/tsconfig.eslint.json +1 -0
  23. package/docs/contributing/changes.md +25 -0
  24. package/docs/ui_engineering.md +13 -4
  25. package/eslint.config.mjs +323 -41
  26. package/front_end/core/common/Color.ts +7 -7
  27. package/front_end/core/common/ParsedURL.ts +3 -3
  28. package/front_end/core/common/ResolverBase.ts +3 -3
  29. package/front_end/core/common/SegmentedRange.ts +3 -3
  30. package/front_end/core/common/SimpleHistoryManager.ts +14 -14
  31. package/front_end/core/common/Trie.ts +3 -3
  32. package/front_end/core/common/VersionController.ts +7 -7
  33. package/front_end/core/host/InspectorFrontendHost.ts +2 -2
  34. package/front_end/core/host/InspectorFrontendHostAPI.ts +9 -1
  35. package/front_end/core/host/InspectorFrontendHostStub.ts +1 -1
  36. package/front_end/core/host/UserMetrics.ts +4 -0
  37. package/front_end/core/host/UserMetricsEnums.ts +2 -1
  38. package/front_end/core/platform/StringUtilities.ts +54 -13
  39. package/front_end/core/platform/node/HostRuntime.ts +13 -7
  40. package/front_end/core/protocol_client/DevToolsCDPConnection.ts +4 -5
  41. package/front_end/core/root/Runtime.ts +5 -0
  42. package/front_end/core/sdk/AccessibilityModel.ts +5 -5
  43. package/front_end/core/sdk/AnimationModel.ts +17 -19
  44. package/front_end/core/sdk/CPUProfilerModel.ts +3 -3
  45. package/front_end/core/sdk/CPUThrottlingManager.ts +7 -0
  46. package/front_end/core/sdk/CSSMatchedStyles.ts +73 -13
  47. package/front_end/core/sdk/CSSMetadata.ts +7 -7
  48. package/front_end/core/sdk/CSSModel.ts +33 -33
  49. package/front_end/core/sdk/CSSProperty.ts +5 -5
  50. package/front_end/core/sdk/CSSRule.ts +6 -6
  51. package/front_end/core/sdk/CSSStyleSheetHeader.ts +4 -4
  52. package/front_end/core/sdk/Connections.ts +16 -16
  53. package/front_end/core/sdk/ConsoleModel.ts +44 -47
  54. package/front_end/core/sdk/CookieParser.ts +11 -11
  55. package/front_end/core/sdk/EmulationModel.ts +35 -36
  56. package/front_end/core/sdk/EventBreakpointsModel.ts +11 -11
  57. package/front_end/core/sdk/FrameManager.ts +16 -16
  58. package/front_end/core/sdk/IsolateManager.ts +2 -2
  59. package/front_end/core/sdk/IssuesModel.ts +2 -2
  60. package/front_end/core/sdk/OverlayModel.ts +19 -19
  61. package/front_end/core/sdk/PageResourceLoader.ts +14 -16
  62. package/front_end/core/sdk/RemoteObject.ts +9 -9
  63. package/front_end/core/sdk/Resource.ts +2 -2
  64. package/front_end/core/sdk/RuntimeModel.ts +7 -7
  65. package/front_end/core/sdk/Script.ts +6 -6
  66. package/front_end/core/sdk/ServiceWorkerManager.ts +36 -10
  67. package/front_end/core/sdk/SourceMap.ts +18 -20
  68. package/front_end/core/sdk/SourceMapManager.ts +2 -2
  69. package/front_end/core/sdk/TargetManager.ts +2 -2
  70. package/front_end/devtools_compatibility.js +7 -3
  71. package/front_end/entrypoints/inspector_main/InspectorMain.ts +2 -2
  72. package/front_end/entrypoints/node_app/app/NodeConnectionsPanel.ts +203 -115
  73. package/front_end/generated/InspectorBackendCommands.ts +1 -1
  74. package/front_end/generated/SupportedCSSProperties.ts +1 -3
  75. package/front_end/generated/protocol.ts +1 -0
  76. package/front_end/models/ai_assistance/AiAgent2.ts +36 -12
  77. package/front_end/models/ai_assistance/AiConversation.ts +8 -2
  78. package/front_end/models/ai_assistance/agents/AiAgent.ts +137 -62
  79. package/front_end/models/ai_assistance/agents/ExecuteJavascript.ts +2 -2
  80. package/front_end/models/ai_assistance/agents/StylingAgent.snapshot.txt +2 -2
  81. package/front_end/models/ai_assistance/data_formatters/LighthouseFormatter.snapshot.txt +149 -2
  82. package/front_end/models/ai_assistance/data_formatters/LighthouseFormatter.ts +269 -42
  83. package/front_end/models/ai_assistance/tools/ExecuteJavaScript.ts +3 -0
  84. package/front_end/models/ai_assistance/tools/GetLighthouseAudits.ts +9 -0
  85. package/front_end/models/ai_assistance/tools/ResolveDevtoolsNodePath.ts +13 -2
  86. package/front_end/models/ai_assistance/tools/RunLighthouse.ts +23 -7
  87. package/front_end/models/ai_assistance/tools/Tool.ts +7 -5
  88. package/front_end/models/bindings/CSSWorkspaceBinding.ts +22 -24
  89. package/front_end/models/bindings/DebuggerLanguagePlugins.ts +60 -60
  90. package/front_end/models/bindings/DebuggerWorkspaceBinding.ts +24 -24
  91. package/front_end/models/bindings/DefaultScriptMapping.ts +8 -8
  92. package/front_end/models/bindings/FileUtils.ts +13 -13
  93. package/front_end/models/bindings/PresentationConsoleMessageHelper.ts +3 -3
  94. package/front_end/models/bindings/ResourceScriptMapping.ts +23 -23
  95. package/front_end/models/comment_manager/CommentManager.ts +3 -3
  96. package/front_end/models/comment_manager/CommentThread.ts +50 -5
  97. package/front_end/models/cpu_profile/CPUProfileDataModel.ts +14 -14
  98. package/front_end/models/cpu_profile/ProfileTreeModel.ts +4 -4
  99. package/front_end/models/elements/StyleChanges.ts +38 -0
  100. package/front_end/models/emulation/EmulatedDevices.ts +12 -12
  101. package/front_end/models/har/HARFormat.ts +4 -4
  102. package/front_end/models/javascript_metadata/NativeFunctions.ts +5 -1
  103. package/front_end/models/lighthouse/LighthouseReporterTypes.ts +57 -3
  104. package/front_end/models/lighthouse/RunTypes.ts +9 -1
  105. package/front_end/models/logs/LogManager.ts +2 -2
  106. package/front_end/models/persistence/AutomaticFileSystemManager.ts +3 -0
  107. package/front_end/models/persistence/FileSystemWorkspaceBinding.ts +24 -24
  108. package/front_end/models/persistence/IsolatedFileSystemManager.ts +6 -0
  109. package/front_end/models/persistence/NetworkPersistenceManager.ts +8 -3
  110. package/front_end/models/trace/LanternComputationData.ts +37 -11
  111. package/front_end/models/trace/Processor.ts +2 -1
  112. package/front_end/models/trace/extras/TraceTree.ts +36 -10
  113. package/front_end/models/trace/handlers/InitiatorsHandler.ts +27 -34
  114. package/front_end/models/trace/handlers/LayoutShiftsHandler.ts +2 -6
  115. package/front_end/models/trace/handlers/SamplesHandler.ts +9 -6
  116. package/front_end/models/workspace/FileManager.ts +6 -0
  117. package/front_end/panels/accessibility/ARIAAttributesView.ts +4 -4
  118. package/front_end/panels/accessibility/AccessibilityAnnouncementRecordingView.ts +8 -1
  119. package/front_end/panels/accessibility/AccessibilityNodeView.ts +15 -17
  120. package/front_end/panels/accessibility/AccessibilitySubPane.ts +1 -1
  121. package/front_end/panels/ai_assistance/AiAssistancePanel.ts +5 -5
  122. package/front_end/panels/ai_assistance/ExternalHandler.ts +10 -1
  123. package/front_end/panels/ai_assistance/components/ChatMessage.ts +27 -22
  124. package/front_end/panels/ai_assistance/components/DisabledWidget.ts +19 -23
  125. package/front_end/panels/ai_assistance/components/ExploreWidget.ts +2 -2
  126. package/front_end/panels/ai_assistance/components/PermissionPrompt.ts +23 -9
  127. package/front_end/panels/ai_assistance/components/chatInput.css +1 -1
  128. package/front_end/panels/animation/AnimationTimeline.ts +37 -17
  129. package/front_end/panels/animation/animationTimeline.css +19 -3
  130. package/front_end/panels/application/AppManifestView.ts +1 -2
  131. package/front_end/panels/application/ApplicationPanelSidebar.ts +143 -128
  132. package/front_end/panels/application/DOMStorageItemsView.ts +14 -14
  133. package/front_end/panels/application/DeviceBoundSessionsView.ts +10 -13
  134. package/front_end/panels/application/ExtensionStorageItemsView.ts +3 -4
  135. package/front_end/panels/application/IndexedDBViews.ts +8 -4
  136. package/front_end/panels/application/KeyValueStorageItemsView.ts +4 -5
  137. package/front_end/panels/application/PrivateVerificationTokensView.ts +53 -0
  138. package/front_end/panels/application/ServiceWorkerCacheViews.ts +12 -8
  139. package/front_end/panels/application/ServiceWorkersView.ts +1 -2
  140. package/front_end/panels/application/StorageItemsToolbar.ts +3 -3
  141. package/front_end/panels/application/StorageView.ts +2 -2
  142. package/front_end/panels/application/WebMCPView.ts +91 -109
  143. package/front_end/panels/application/application.ts +2 -0
  144. package/front_end/panels/application/components/StorageMetadataView.ts +6 -6
  145. package/front_end/panels/application/preloading/PreloadingView.ts +70 -37
  146. package/front_end/panels/application/preloading/components/MismatchedPreloadingGrid.ts +2 -2
  147. package/front_end/panels/application/preloading/components/PreloadingDisabledInfobar.ts +3 -3
  148. package/front_end/panels/application/preloading/components/PreloadingGrid.ts +12 -0
  149. package/front_end/panels/application/preloading/components/RuleSetDetailsView.ts +10 -11
  150. package/front_end/panels/application/privateVerificationTokensView.css +20 -0
  151. package/front_end/panels/application/serviceWorkersView.css +2 -2
  152. package/front_end/panels/browser_debugger/DOMBreakpointsSidebarPane.ts +24 -24
  153. package/front_end/panels/changes/ChangesSidebar.ts +5 -5
  154. package/front_end/panels/changes/ChangesView.ts +10 -11
  155. package/front_end/panels/comments/CommentsPane.ts +292 -102
  156. package/front_end/panels/comments/commentsPane.css +93 -12
  157. package/front_end/panels/common/CommentThreadWidget.ts +69 -0
  158. package/front_end/panels/common/CommentsOverlayWidget.ts +108 -29
  159. package/front_end/panels/common/CommentsStatusBarPill.ts +17 -6
  160. package/front_end/panels/common/DOMLinkifier.ts +37 -12
  161. package/front_end/panels/common/ExtensionPanel.ts +13 -4
  162. package/front_end/panels/common/ExtensionServer.ts +27 -3
  163. package/front_end/panels/common/PersistenceUtils.ts +3 -3
  164. package/front_end/panels/common/commentThreadWidget.css +25 -1
  165. package/front_end/panels/common/common-meta.ts +10 -0
  166. package/front_end/panels/console/ConsolePinPane.ts +13 -15
  167. package/front_end/panels/console/ConsolePrompt.ts +173 -95
  168. package/front_end/panels/console/ConsoleSidebar.ts +2 -2
  169. package/front_end/panels/console/ConsoleView.ts +75 -79
  170. package/front_end/panels/console/ConsoleViewMessage.ts +52 -4
  171. package/front_end/panels/console/SymbolizedErrorWidget.ts +8 -4
  172. package/front_end/panels/console/consolePrompt.css +1 -1
  173. package/front_end/panels/console/consoleView.css +1 -1
  174. package/front_end/panels/console_counters/WarningErrorCounter.ts +3 -4
  175. package/front_end/panels/coverage/CoverageListView.ts +2 -2
  176. package/front_end/panels/coverage/CoverageView.ts +20 -5
  177. package/front_end/panels/css_overview/CSSOverviewCompletedView.ts +4 -3
  178. package/front_end/panels/css_overview/CSSOverviewPanel.ts +2 -2
  179. package/front_end/panels/css_overview/CSSOverviewProcessingView.ts +2 -2
  180. package/front_end/panels/css_overview/CSSOverviewSidebarPanel.ts +2 -2
  181. package/front_end/panels/css_overview/CSSOverviewStartView.ts +2 -2
  182. package/front_end/panels/css_overview/CSSOverviewUnusedDeclarations.ts +8 -8
  183. package/front_end/panels/developer_resources/DeveloperResourcesListView.ts +2 -3
  184. package/front_end/panels/developer_resources/DeveloperResourcesView.ts +4 -5
  185. package/front_end/panels/elements/AccessibilityTreeUtils.ts +6 -7
  186. package/front_end/panels/elements/CSSValueTraceView.ts +3 -3
  187. package/front_end/panels/elements/ClassesPaneWidget.ts +1 -2
  188. package/front_end/panels/elements/ComputedStyleWidget.ts +15 -14
  189. package/front_end/panels/elements/DOMTreeElementWidget.ts +5 -4
  190. package/front_end/panels/elements/DOMTreeWidget.ts +2 -1
  191. package/front_end/panels/elements/ElementStatePaneWidget.ts +2 -2
  192. package/front_end/panels/elements/ElementsPanel.ts +1 -0
  193. package/front_end/panels/elements/EventListenersWidget.ts +2 -2
  194. package/front_end/panels/elements/LayoutPane.ts +2 -2
  195. package/front_end/panels/elements/PlatformFontsWidget.ts +3 -3
  196. package/front_end/panels/elements/PropertiesWidget.ts +9 -10
  197. package/front_end/panels/elements/PropertyRenderer.ts +72 -11
  198. package/front_end/panels/elements/StandaloneStylesContainer.ts +5 -10
  199. package/front_end/panels/elements/StyleEditorWidget.ts +30 -16
  200. package/front_end/panels/elements/StylePropertiesSection.ts +93 -44
  201. package/front_end/panels/elements/StylePropertyTreeElement.ts +230 -302
  202. package/front_end/panels/elements/StylesContainer.ts +2 -3
  203. package/front_end/panels/elements/StylesSidebarPane.ts +4 -13
  204. package/front_end/panels/elements/components/AccessibilityTreeNode.ts +66 -37
  205. package/front_end/panels/elements/components/CSSHintDetailsView.ts +51 -41
  206. package/front_end/panels/elements/components/CSSPropertyDocsView.ts +75 -65
  207. package/front_end/panels/elements/components/CSSQuery.ts +112 -74
  208. package/front_end/panels/elements/components/CSSVariableValueView.ts +109 -68
  209. package/front_end/panels/elements/components/ComputedStyleProperty.ts +64 -45
  210. package/front_end/panels/elements/components/ElementsTreeExpandButton.ts +35 -28
  211. package/front_end/panels/elements/components/QueryContainer.ts +104 -74
  212. package/front_end/panels/elements/components/accessibilityTreeNode.css +22 -20
  213. package/front_end/panels/elements/components/computedStyleProperty.css +2 -0
  214. package/front_end/panels/elements/components/cssHintDetailsView.css +23 -21
  215. package/front_end/panels/elements/components/cssPropertyDocsView.css +38 -36
  216. package/front_end/panels/elements/components/cssVariableValueView.css +42 -40
  217. package/front_end/panels/elements/components/elementsTreeExpandButton.css +5 -2
  218. package/front_end/panels/elements/components/queryContainer.css +23 -21
  219. package/front_end/panels/elements/stylesSidebarPane.css +3 -3
  220. package/front_end/panels/emulation/DeviceModeToolbar.ts +2 -2
  221. package/front_end/panels/emulation/InspectedPagePlaceholder.ts +2 -2
  222. package/front_end/panels/emulation/MediaQueryInspector.ts +9 -10
  223. package/front_end/panels/emulation/mediaQueryInspector.css +1 -1
  224. package/front_end/panels/event_listeners/EventListenersView.ts +2 -2
  225. package/front_end/panels/issues/AffectedCookiesView.ts +144 -101
  226. package/front_end/panels/issues/AffectedDescendantsWithinSelectElementView.ts +83 -31
  227. package/front_end/panels/issues/AffectedDirectivesView.ts +218 -135
  228. package/front_end/panels/issues/AffectedDocumentsInQuirksModeView.ts +84 -34
  229. package/front_end/panels/issues/AffectedElementsView.ts +86 -23
  230. package/front_end/panels/issues/AffectedLazyLoadImagesView.ts +2 -2
  231. package/front_end/panels/issues/AffectedMetadataAllowedSitesView.ts +2 -2
  232. package/front_end/panels/issues/AffectedPartitioningBlobURLView.ts +36 -11
  233. package/front_end/panels/issues/AffectedSharedArrayBufferIssueDetailsView.ts +135 -58
  234. package/front_end/panels/issues/AffectedSourcesView.ts +49 -28
  235. package/front_end/panels/issues/AffectedTrackingSitesView.ts +3 -4
  236. package/front_end/panels/issues/CorsIssueDetailsView.ts +490 -269
  237. package/front_end/panels/issues/GenericIssueDetailsView.ts +2 -2
  238. package/front_end/panels/issues/IssueKindView.ts +63 -48
  239. package/front_end/panels/issues/IssueView.ts +14 -18
  240. package/front_end/panels/issues/components/ElementsPanelLink.ts +70 -34
  241. package/front_end/panels/issues/components/HideIssuesMenu.ts +56 -32
  242. package/front_end/panels/issues/components/elementsPanelLink.css +10 -6
  243. package/front_end/panels/issues/components/hideIssuesMenu.css +16 -14
  244. package/front_end/panels/issues/issues.ts +2 -0
  245. package/front_end/panels/issues/issuesTree.css +4 -4
  246. package/front_end/panels/lighthouse/LighthouseController.ts +6 -6
  247. package/front_end/panels/lighthouse/LighthouseStatusView.ts +12 -13
  248. package/front_end/panels/lighthouse/lighthouseStartView.css +1 -1
  249. package/front_end/panels/linear_memory_inspector/LinearMemoryInspectorPane.ts +159 -161
  250. package/front_end/panels/linear_memory_inspector/LinearMemoryInspectorView.ts +228 -0
  251. package/front_end/panels/linear_memory_inspector/components/LinearMemoryInspector.ts +32 -41
  252. package/front_end/panels/linear_memory_inspector/components/linearMemoryHighlightChipList.css +2 -2
  253. package/front_end/panels/linear_memory_inspector/linear_memory_inspector.ts +2 -0
  254. package/front_end/panels/media/EventDisplayTable.ts +2 -2
  255. package/front_end/panels/media/MainView.ts +132 -66
  256. package/front_end/panels/media/PlayerDetailView.ts +32 -14
  257. package/front_end/panels/media/PlayerListView.ts +83 -23
  258. package/front_end/panels/media/PlayerPropertiesView.ts +2 -2
  259. package/front_end/panels/media/TickingFlameChart.ts +153 -63
  260. package/front_end/panels/mobile_throttling/NetworkThrottlingSelector.ts +2 -2
  261. package/front_end/panels/mobile_throttling/ThrottlingSettingsTab.ts +615 -464
  262. package/front_end/panels/mobile_throttling/throttlingSettingsTab.css +43 -0
  263. package/front_end/panels/network/EventSourceMessagesView.ts +3 -3
  264. package/front_end/panels/network/NetworkConfigView.ts +6 -2
  265. package/front_end/panels/network/NetworkDataGridNode.ts +2 -1
  266. package/front_end/panels/network/NetworkItemView.ts +27 -26
  267. package/front_end/panels/network/NetworkManageCustomHeadersView.ts +236 -97
  268. package/front_end/panels/network/NetworkOverview.ts +8 -10
  269. package/front_end/panels/network/RequestConditionsDrawer.ts +8 -4
  270. package/front_end/panels/network/RequestDeviceBoundSessionsView.ts +2 -4
  271. package/front_end/panels/network/RequestHTMLView.ts +26 -7
  272. package/front_end/panels/network/RequestHeadersView.ts +2 -2
  273. package/front_end/panels/network/RequestInitiatorView.ts +21 -22
  274. package/front_end/panels/network/RequestPayloadView.ts +2 -16
  275. package/front_end/panels/network/RequestPreviewView.ts +5 -5
  276. package/front_end/panels/network/RequestTimingView.ts +6 -6
  277. package/front_end/panels/network/ResourceDirectSocketChunkView.ts +5 -6
  278. package/front_end/panels/network/ResourceWebSocketFrameView.ts +4 -3
  279. package/front_end/panels/network/ShowMoreDetailsWidget.ts +11 -12
  280. package/front_end/panels/network/SignedExchangeInfoView.ts +2 -2
  281. package/front_end/panels/network/networkLogView.css +2 -2
  282. package/front_end/panels/network/networkManageCustomHeadersView.css +27 -6
  283. package/front_end/panels/network/requestConditionsDrawer.css +1 -1
  284. package/front_end/panels/network/requestInitiatorView.css +5 -3
  285. package/front_end/panels/performance_monitor/PerformanceMonitor.ts +2 -2
  286. package/front_end/panels/profiler/HeapDetachedElementsView.ts +1 -2
  287. package/front_end/panels/profiler/HeapTimelineOverview.ts +77 -15
  288. package/front_end/panels/profiler/IsolateSelector.ts +258 -187
  289. package/front_end/panels/profiler/ProfileLauncherView.ts +7 -29
  290. package/front_end/panels/profiler/profileLauncherView.css +6 -1
  291. package/front_end/panels/protocol_monitor/JSONEditor.ts +4 -5
  292. package/front_end/panels/recorder/ControlButton.ts +1 -1
  293. package/front_end/panels/recorder/RecordingListView.ts +2 -4
  294. package/front_end/panels/recorder/RecordingView.ts +1 -2
  295. package/front_end/panels/recorder/SelectorPicker.ts +2 -4
  296. package/front_end/panels/recorder/StepView.ts +24 -10
  297. package/front_end/panels/recorder/TimelineSection.ts +1 -1
  298. package/front_end/panels/recorder/recordingView.css +1 -1
  299. package/front_end/panels/screencast/ScreencastApp.ts +1 -1
  300. package/front_end/panels/search/SearchResultsPane.ts +11 -12
  301. package/front_end/panels/search/SearchView.ts +8 -10
  302. package/front_end/panels/security/SecurityPanel.ts +1 -8
  303. package/front_end/panels/security/SecurityPanelSidebar.ts +2 -2
  304. package/front_end/panels/security/mainView.css +1 -1
  305. package/front_end/panels/sensors/LocationsSettingsTab.ts +1 -2
  306. package/front_end/panels/settings/AISettingsTab.ts +1 -1
  307. package/front_end/panels/settings/BackendLinkingSettingsTab.ts +34 -20
  308. package/front_end/panels/settings/EditFileSystemView.ts +2 -2
  309. package/front_end/panels/settings/FrameworkIgnoreListSettingsTab.ts +375 -197
  310. package/front_end/panels/settings/KeybindsSettingsTab.ts +570 -414
  311. package/front_end/panels/settings/SettingsScreen.ts +312 -114
  312. package/front_end/panels/settings/WorkspaceSettingsTab.ts +2 -2
  313. package/front_end/panels/settings/aiSettingsTab.css +1 -4
  314. package/front_end/panels/settings/emulation/DevicesSettingsTab.ts +924 -578
  315. package/front_end/panels/settings/emulation/components/UserAgentClientHintsForm.ts +9 -2
  316. package/front_end/panels/settings/emulation/devicesSettingsTab.css +39 -0
  317. package/front_end/panels/settings/frameworkIgnoreListSettingsTab.css +37 -8
  318. package/front_end/panels/settings/settingsScreen.css +0 -24
  319. package/front_end/panels/sources/BreakpointEditDialog.ts +9 -6
  320. package/front_end/panels/sources/BreakpointsView.ts +25 -4
  321. package/front_end/panels/sources/CallStackSidebarPane.ts +7 -1
  322. package/front_end/panels/sources/DebuggerPlugin.ts +1 -0
  323. package/front_end/panels/sources/GoToLineQuickOpen.ts +8 -8
  324. package/front_end/panels/sources/NavigatorView.ts +521 -439
  325. package/front_end/panels/sources/PersistenceActions.ts +11 -12
  326. package/front_end/panels/sources/ProfilePlugin.ts +28 -17
  327. package/front_end/panels/sources/ScopeChainSidebarPane.ts +3 -4
  328. package/front_end/panels/sources/SourcesNavigator.ts +9 -9
  329. package/front_end/panels/sources/SourcesPanel.ts +2 -2
  330. package/front_end/panels/sources/SourcesView.ts +3 -3
  331. package/front_end/panels/sources/ThreadsSidebarPane.ts +2 -2
  332. package/front_end/panels/sources/WatchExpressionsSidebarPane.ts +2 -2
  333. package/front_end/panels/sources/components/HeadersView.ts +1 -2
  334. package/front_end/panels/timeline/CompatibilityTracksAppender.ts +5 -6
  335. package/front_end/panels/timeline/EventsTimelineTreeView.ts +73 -34
  336. package/front_end/panels/timeline/IsolateSelector.ts +25 -37
  337. package/front_end/panels/timeline/StatusDialog.ts +5 -7
  338. package/front_end/panels/timeline/ThirdPartyTreeView.ts +10 -13
  339. package/front_end/panels/timeline/TimelineDetailsView.ts +40 -21
  340. package/front_end/panels/timeline/TimelineEventOverview.ts +130 -34
  341. package/front_end/panels/timeline/TimelineFlameChartNetworkDataProvider.ts +1 -1
  342. package/front_end/panels/timeline/TimelineMiniMap.ts +255 -103
  343. package/front_end/panels/timeline/TimelinePaintProfilerView.ts +19 -11
  344. package/front_end/panels/timeline/TimelinePanel.ts +1 -0
  345. package/front_end/panels/timeline/TimelineSelectorStatsView.ts +11 -12
  346. package/front_end/panels/timeline/TimelineTreeView.ts +240 -122
  347. package/front_end/panels/timeline/TimelineUIUtils.ts +12 -0
  348. package/front_end/panels/timeline/components/BreadcrumbsUI.ts +5 -4
  349. package/front_end/panels/timeline/components/DetailsView.ts +97 -65
  350. package/front_end/panels/timeline/components/LayoutShiftDetails.ts +2 -2
  351. package/front_end/panels/timeline/components/MetricCard.ts +2 -2
  352. package/front_end/panels/timeline/components/NetworkRequestDetails.ts +11 -12
  353. package/front_end/panels/timeline/components/NetworkTrackWidget.ts +57 -50
  354. package/front_end/panels/timeline/components/RelatedInsightChips.ts +2 -2
  355. package/front_end/panels/timeline/components/Sidebar.ts +161 -109
  356. package/front_end/panels/timeline/components/SidebarAnnotationsTab.ts +33 -12
  357. package/front_end/panels/timeline/components/SidebarInsightsTab.ts +3 -0
  358. package/front_end/panels/timeline/components/insights/LCPDiscovery.ts +11 -11
  359. package/front_end/panels/timeline/components/insights/SlowCSSSelector.ts +6 -7
  360. package/front_end/panels/timeline/components/networkTrackWidget.css +24 -22
  361. package/front_end/panels/timeline/components/sidebarInsightsTab.css +1 -1
  362. package/front_end/panels/timeline/overlays/components/TimespanBreakdownOverlay.ts +15 -10
  363. package/front_end/panels/timeline/overlays/components/entryLabelOverlay.css +1 -1
  364. package/front_end/panels/timeline/timelinePanel.css +5 -0
  365. package/front_end/panels/timeline/timelineStatusDialog.css +1 -1
  366. package/front_end/panels/web_audio/WebAudioView.ts +2 -2
  367. package/front_end/third_party/chromium/README.chromium +1 -1
  368. package/front_end/third_party/legacy-javascript/README.chromium +2 -2
  369. package/front_end/third_party/legacy-javascript/lib/legacy-javascript.js +2 -2
  370. package/front_end/third_party/legacy-javascript/package.json +1 -1
  371. package/front_end/third_party/lighthouse/README.chromium +2 -2
  372. package/front_end/third_party/lighthouse/lighthouse-dt-bundle.js +1983 -2022
  373. package/front_end/third_party/lighthouse/locales/ar-XB.json +157 -142
  374. package/front_end/third_party/lighthouse/locales/ar.json +157 -142
  375. package/front_end/third_party/lighthouse/locales/bg.json +154 -139
  376. package/front_end/third_party/lighthouse/locales/ca.json +157 -142
  377. package/front_end/third_party/lighthouse/locales/cs.json +148 -133
  378. package/front_end/third_party/lighthouse/locales/da.json +153 -138
  379. package/front_end/third_party/lighthouse/locales/de.json +152 -137
  380. package/front_end/third_party/lighthouse/locales/el.json +153 -138
  381. package/front_end/third_party/lighthouse/locales/en-GB.json +160 -145
  382. package/front_end/third_party/lighthouse/locales/en-US.json +239 -218
  383. package/front_end/third_party/lighthouse/locales/en-XL.json +239 -218
  384. package/front_end/third_party/lighthouse/locales/es-419.json +150 -135
  385. package/front_end/third_party/lighthouse/locales/es.json +149 -134
  386. package/front_end/third_party/lighthouse/locales/fi.json +151 -136
  387. package/front_end/third_party/lighthouse/locales/fil.json +154 -139
  388. package/front_end/third_party/lighthouse/locales/fr.json +150 -135
  389. package/front_end/third_party/lighthouse/locales/he.json +160 -145
  390. package/front_end/third_party/lighthouse/locales/hi.json +156 -141
  391. package/front_end/third_party/lighthouse/locales/hr.json +154 -139
  392. package/front_end/third_party/lighthouse/locales/hu.json +111 -96
  393. package/front_end/third_party/lighthouse/locales/id.json +153 -138
  394. package/front_end/third_party/lighthouse/locales/it.json +153 -138
  395. package/front_end/third_party/lighthouse/locales/ja.json +150 -135
  396. package/front_end/third_party/lighthouse/locales/ko.json +42 -27
  397. package/front_end/third_party/lighthouse/locales/lt.json +152 -137
  398. package/front_end/third_party/lighthouse/locales/lv.json +93 -78
  399. package/front_end/third_party/lighthouse/locales/nl.json +149 -134
  400. package/front_end/third_party/lighthouse/locales/no.json +152 -137
  401. package/front_end/third_party/lighthouse/locales/pl.json +153 -138
  402. package/front_end/third_party/lighthouse/locales/pt-PT.json +152 -137
  403. package/front_end/third_party/lighthouse/locales/pt.json +157 -142
  404. package/front_end/third_party/lighthouse/locales/ro.json +149 -134
  405. package/front_end/third_party/lighthouse/locales/ru.json +76 -61
  406. package/front_end/third_party/lighthouse/locales/sk.json +153 -138
  407. package/front_end/third_party/lighthouse/locales/sl.json +149 -134
  408. package/front_end/third_party/lighthouse/locales/sr-Latn.json +151 -136
  409. package/front_end/third_party/lighthouse/locales/sr.json +151 -136
  410. package/front_end/third_party/lighthouse/locales/sv.json +152 -137
  411. package/front_end/third_party/lighthouse/locales/ta.json +156 -141
  412. package/front_end/third_party/lighthouse/locales/te.json +157 -142
  413. package/front_end/third_party/lighthouse/locales/th.json +111 -96
  414. package/front_end/third_party/lighthouse/locales/tr.json +153 -138
  415. package/front_end/third_party/lighthouse/locales/uk.json +149 -134
  416. package/front_end/third_party/lighthouse/locales/vi.json +162 -147
  417. package/front_end/third_party/lighthouse/locales/zh-HK.json +150 -135
  418. package/front_end/third_party/lighthouse/locales/zh-TW.json +154 -139
  419. package/front_end/third_party/lighthouse/locales/zh.json +152 -137
  420. package/front_end/third_party/lighthouse/report/bundle.d.ts +9 -8
  421. package/front_end/third_party/lighthouse/report/bundle.js +10 -10
  422. package/front_end/third_party/lighthouse/report-assets/report-generator.mjs +2 -7
  423. package/front_end/tsconfig.compatibility.json +1 -0
  424. package/front_end/tsconfig.json +3 -2
  425. package/front_end/ui/components/dialogs/TypeToAllowDialog.ts +0 -2
  426. package/front_end/ui/components/dialogs/typeToAllowDialog.css +0 -4
  427. package/front_end/ui/components/icon_button/fileSourceIcon.css +1 -1
  428. package/front_end/ui/components/input/textInput.css +1 -1
  429. package/front_end/ui/components/lists/List.ts +26 -14
  430. package/front_end/ui/components/menus/menus.ts +0 -2
  431. package/front_end/ui/components/suggestion_input/SuggestionInput.ts +351 -138
  432. package/front_end/ui/components/survey_link/surveyLink.css +3 -3
  433. package/front_end/ui/components/switch/switch.css +6 -6
  434. package/front_end/ui/components/text_editor/AiCodeCompletionTeaser.ts +2 -3
  435. package/front_end/ui/components/text_editor/TextEditor.ts +1 -1
  436. package/front_end/ui/components/tooltips/Tooltip.ts +53 -4
  437. package/front_end/ui/components/tree_outline/treeOutline.css +7 -7
  438. package/front_end/ui/helpers/OpenInNewTab.ts +8 -3
  439. package/front_end/ui/legacy/EmptyWidget.ts +4 -4
  440. package/front_end/ui/legacy/ForwardedInputEventHandler.ts +2 -2
  441. package/front_end/ui/legacy/GlassPane.ts +1 -1
  442. package/front_end/ui/legacy/KeyboardShortcut.ts +7 -7
  443. package/front_end/ui/legacy/RemoteDebuggingTerminatedScreen.ts +2 -2
  444. package/front_end/ui/legacy/TabbedPane.ts +198 -66
  445. package/front_end/ui/legacy/TargetCrashedScreen.ts +2 -2
  446. package/front_end/ui/legacy/UIUtils.ts +71 -68
  447. package/front_end/ui/legacy/View.ts +7 -4
  448. package/front_end/ui/legacy/ViewManager.ts +49 -37
  449. package/front_end/ui/legacy/Widget.ts +32 -12
  450. package/front_end/ui/legacy/components/cookie_table/CookiesTable.ts +2 -3
  451. package/front_end/ui/legacy/components/inline_editor/AnimationTimingUI.ts +8 -8
  452. package/front_end/ui/legacy/components/inline_editor/BezierUI.ts +8 -9
  453. package/front_end/ui/legacy/components/inline_editor/LinkSwatch.ts +2 -2
  454. package/front_end/ui/legacy/components/inline_editor/cssAngleEditor.css +1 -1
  455. package/front_end/ui/legacy/components/inline_editor/cssAngleSwatch.css +1 -1
  456. package/front_end/ui/legacy/components/object_ui/ObjectPropertiesSection.ts +45 -11
  457. package/front_end/ui/legacy/components/object_ui/RemoteObjectPreviewFormatter.ts +10 -12
  458. package/front_end/ui/legacy/components/perf_ui/ChartViewport.ts +102 -29
  459. package/front_end/ui/legacy/components/perf_ui/FlameChart.ts +148 -122
  460. package/front_end/ui/legacy/components/perf_ui/TimelineOverviewPane.ts +20 -14
  461. package/front_end/ui/legacy/components/quick_open/filteredListWidget.css +1 -1
  462. package/front_end/ui/legacy/components/source_frame/FontView.ts +29 -5
  463. package/front_end/ui/legacy/components/source_frame/ImageView.ts +79 -12
  464. package/front_end/ui/legacy/components/source_frame/JSONView.ts +20 -2
  465. package/front_end/ui/legacy/components/source_frame/PreviewFactory.ts +2 -2
  466. package/front_end/ui/legacy/components/source_frame/StreamingContentHexView.ts +6 -10
  467. package/front_end/ui/legacy/components/source_frame/XMLView.ts +11 -11
  468. package/front_end/ui/legacy/components/source_frame/fontView.css +7 -0
  469. package/front_end/ui/legacy/components/source_frame/imageView.css +7 -0
  470. package/front_end/ui/legacy/components/utils/JSPresentationUtils.ts +14 -3
  471. package/front_end/ui/legacy/components/utils/Linkifier.ts +126 -2
  472. package/front_end/ui/legacy/emptyWidget.css +2 -1
  473. package/front_end/ui/legacy/inspectorCommon.css +3 -3
  474. package/front_end/ui/legacy/smallBubble.css +1 -1
  475. package/front_end/ui/legacy/tabbedPane.css +6 -0
  476. package/front_end/ui/lit/Directives.ts +35 -18
  477. package/front_end/ui/lit/lit.ts +0 -2
  478. package/front_end/ui/lit/render.ts +0 -7
  479. package/front_end/ui/visual_logging/KnownContextValues.ts +5 -0
  480. package/package.json +1 -1
  481. package/vpython.toml +8 -0
  482. package/vpython.toml.uv.lock +3 -0
  483. package/.agents/skills/review-models-core/SKILL.md +0 -73
  484. package/.agents/skills/review-tests/SKILL.md +0 -67
  485. package/.agents/skills/review-ui-widgets/SKILL.md +0 -115
  486. package/front_end/generated/ARIAProperties.ts +0 -2686
  487. package/front_end/ui/components/menus/README.md +0 -119
  488. package/front_end/ui/components/menus/SelectMenu.ts +0 -473
  489. package/front_end/ui/components/menus/selectMenu.css +0 -54
  490. package/front_end/ui/components/menus/selectMenuButton.css +0 -108
@@ -1,22 +1,26 @@
1
1
  // Copyright 2014 The Chromium Authors
2
2
  // Use of this source code is governed by a BSD-style license that can be
3
3
  // found in the LICENSE file.
4
- /* eslint-disable @devtools/no-imperative-dom-api */
5
4
 
5
+ import '../../ui/components/lists/lists.js';
6
6
  import '../../ui/kit/kit.js';
7
7
 
8
8
  import * as Common from '../../core/common/common.js';
9
9
  import * as i18n from '../../core/i18n/i18n.js';
10
+ import * as Platform from '../../core/platform/platform.js';
10
11
  import * as Workspace from '../../models/workspace/workspace.js';
11
12
  import * as Buttons from '../../ui/components/buttons/buttons.js';
13
+ import type * as Lists from '../../ui/components/lists/lists.js';
12
14
  import * as UIHelpers from '../../ui/helpers/helpers.js';
13
- import * as SettingsUI from '../../ui/legacy/components/settings_ui/settings_ui.js';
14
15
  import * as UI from '../../ui/legacy/legacy.js';
16
+ import {Directives, html, type LitTemplate, nothing, render} from '../../ui/lit/lit.js';
15
17
  import * as VisualLogging from '../../ui/visual_logging/visual_logging.js';
16
18
 
17
19
  import frameworkIgnoreListSettingsTabStyles from './frameworkIgnoreListSettingsTab.css.js';
18
20
  import settingsScreenStyles from './settingsScreen.css.js';
19
21
 
22
+ const {bindToSetting} = UI.UIUtils;
23
+
20
24
  const UIStrings = {
21
25
  /**
22
26
  * @description Header text content in Framework Ignore List settings tab of the Settings for enabling or disabling ignore listing.
@@ -89,240 +93,414 @@ const UIStrings = {
89
93
  * @description Text that is usually a hyperlink to more documentation.
90
94
  */
91
95
  learnMore: 'Learn more',
96
+ /**
97
+ * @description Button text to save changes when editing an item in Framework Ignore List settings tab.
98
+ */
99
+ save: 'Save',
100
+ /**
101
+ * @description Button text to add a new item in Framework Ignore List settings tab.
102
+ */
103
+ add: 'Add',
104
+ /**
105
+ * @description Button text to cancel editing an item in Framework Ignore List settings tab.
106
+ */
107
+ cancel: 'Cancel',
92
108
  } as const;
93
109
  const str_ = i18n.i18n.registerUIStrings('panels/settings/FrameworkIgnoreListSettingsTab.ts', UIStrings);
94
110
  const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
95
111
 
96
- export class FrameworkIgnoreListSettingsTab extends UI.Widget.VBox implements
97
- UI.ListWidget.Delegate<Common.Settings.RegExpSettingItem> {
98
- private readonly list: UI.ListWidget.ListWidget<Common.Settings.RegExpSettingItem>;
99
- private readonly setting: Common.Settings.RegExpSetting;
100
- private editor?: UI.ListWidget.Editor<Common.Settings.RegExpSettingItem>;
112
+ export interface ViewInput {
113
+ enabledSetting: Common.Settings.Setting<boolean>;
114
+ skipContentScriptsSetting: Common.Settings.Setting<boolean>;
115
+ automaticallyIgnoreListSetting: Common.Settings.Setting<boolean>;
116
+ skipAnonymousScriptsSetting: Common.Settings.Setting<boolean>;
117
+ enabled: boolean;
118
+ patterns: Common.Settings.RegExpSettingItem[];
119
+ editingIndex: number|null;
120
+ editingValue: string;
121
+ validationError: Common.UIString.LocalizedString|null;
122
+ showValidationError: boolean;
123
+ onLearnMoreClick: () => void;
124
+ onAddPatternClick: () => void;
125
+ onTogglePattern: (index: number, checked: boolean) => void;
126
+ onBeginEdit: (index: number) => void;
127
+ onRemovePattern: (index: number) => void;
128
+ onEditorInput: (value: string) => void;
129
+ onCommitEdit: () => void;
130
+ onCancelEdit: () => void;
131
+ }
132
+
133
+ export type View = (input: ViewInput, output: undefined, target: HTMLElement) => void;
134
+
135
+ function renderRuleItem(item: Common.Settings.RegExpSettingItem, index: number, enabled: boolean,
136
+ onTogglePattern: (index: number, checked: boolean) => void): LitTemplate {
137
+ const helpText = i18nString(UIStrings.ignoreScriptsWhoseNamesMatchS, {PH1: item.pattern});
138
+ // clang-format off
139
+ return html`
140
+ <div class="ignore-list-item">
141
+ <devtools-checkbox
142
+ .checked=${!item.disabled}
143
+ .disabled=${!enabled}
144
+ title=${helpText}
145
+ aria-label=${helpText}
146
+ jslogcontext="settings.ignore-list-pattern"
147
+ @change=${(e: Event) => onTogglePattern(index, (e.target as UI.UIUtils.CheckboxLabel).checked)}>
148
+ ${item.pattern}
149
+ </devtools-checkbox>
150
+ </div>
151
+ `;
152
+ // clang-format on
153
+ }
154
+
155
+ function renderEditor(input: ViewInput): LitTemplate {
156
+ const isNew = input.editingIndex === input.patterns.length;
157
+ const isInvalid = input.showValidationError && input.validationError !== null;
158
+ // clang-format off
159
+ return html`
160
+ <div
161
+ class="editor-container"
162
+ jslog=${VisualLogging.pane('editor').track({resize: true})}
163
+ @keydown=${(e: KeyboardEvent) => {
164
+ if (Platform.KeyboardUtilities.isEscKey(e)) {
165
+ e.consume(true);
166
+ input.onCancelEdit();
167
+ }
168
+ }}>
169
+ <div
170
+ class="editor-content"
171
+ @keydown=${(e: KeyboardEvent) => {
172
+ if (e.key === 'Enter' && !e.isComposing) {
173
+ e.consume(true);
174
+ input.onCommitEdit();
175
+ }
176
+ }}>
177
+ <div class="ignore-list-edit-row">
178
+ <div class="ignore-list-pattern">${i18nString(UIStrings.pattern)}</div>
179
+ </div>
180
+ <div class="ignore-list-edit-row">
181
+ <div class="ignore-list-pattern">
182
+ <input
183
+ class=${Directives.classMap({
184
+ 'harmony-input': true,
185
+ 'error-input': isInvalid,
186
+ })}
187
+ type="text"
188
+ autofocus
189
+ placeholder="/framework\\.js$"
190
+ aria-label=${i18nString(UIStrings.pattern)}
191
+ aria-invalid=${isInvalid ? 'true' : 'false'}
192
+ .value=${Directives.live(input.editingValue)}
193
+ jslog=${VisualLogging.textField().track({change: true, keydown: 'Enter'}).context('pattern')}
194
+ @input=${(e: Event) => input.onEditorInput((e.target as HTMLInputElement).value)}>
195
+ </div>
196
+ </div>
197
+ </div>
198
+ <div class="editor-buttons">
199
+ <devtools-button
200
+ .variant=${Buttons.Button.Variant.OUTLINED}
201
+ .jslogContext=${'cancel'}
202
+ jslog=${VisualLogging.action('cancel').track({click: true})}
203
+ @click=${input.onCancelEdit}>
204
+ ${i18nString(UIStrings.cancel)}
205
+ </devtools-button>
206
+ <devtools-button
207
+ .variant=${Buttons.Button.Variant.PRIMARY}
208
+ .jslogContext=${'commit'}
209
+ .disabled=${input.validationError !== null}
210
+ @click=${input.onCommitEdit}>
211
+ ${isNew ? i18nString(UIStrings.add) : i18nString(UIStrings.save)}
212
+ </devtools-button>
213
+ </div>
214
+ <div class="list-widget-input-validation-error" role="alert" aria-live="polite">
215
+ ${isInvalid && input.validationError ? input.validationError : nothing}
216
+ </div>
217
+ </div>
218
+ `;
219
+ // clang-format on
220
+ }
101
221
 
102
- constructor() {
222
+ export const DEFAULT_VIEW: View = (input, _output, target) => {
223
+ const editingIndex = input.editingIndex;
224
+ const patternsBefore = editingIndex !== null ? input.patterns.slice(0, editingIndex) : input.patterns;
225
+ const patternsAfter = editingIndex !== null ? input.patterns.slice(editingIndex + 1) : [];
226
+
227
+ // clang-format off
228
+ render(html`
229
+ <div class="settings-card-container-wrapper">
230
+ <div class="settings-card-container ignore-list-settings">
231
+ <devtools-card .heading=${i18nString(UIStrings.frameworkIgnoreList)}>
232
+ <span>${i18nString(UIStrings.ignoreListingDescription)}</span>
233
+ <div class="enable-ignore-listing" title=${i18nString(UIStrings.enableIgnoreListingTooltip)}>
234
+ <devtools-checkbox
235
+ name=${i18nString(UIStrings.ignoreListing)}
236
+ title=${i18nString(UIStrings.ignoreListing)}
237
+ ${bindToSetting(input.enabledSetting)}>
238
+ ${i18nString(UIStrings.ignoreListing)}
239
+ </devtools-checkbox>
240
+ </div>
241
+ </devtools-card>
242
+ <devtools-card class="ignore-list-options" .heading=${i18nString(UIStrings.generalExclusionRules)}>
243
+ <div class="ignore-list-option-group general-exclusion-group" role="group">
244
+ <div class="ignore-list-option">
245
+ <devtools-checkbox
246
+ name=${i18nString(UIStrings.ignoreListContentScripts)}
247
+ title=${i18nString(UIStrings.ignoreListContentScripts)}
248
+ ?disabled=${!input.enabled}
249
+ ${bindToSetting(input.skipContentScriptsSetting)}>
250
+ ${i18nString(UIStrings.ignoreListContentScripts)}
251
+ </devtools-checkbox>
252
+ </div>
253
+ <div class="ignore-list-option">
254
+ <devtools-checkbox
255
+ name=${i18nString(UIStrings.automaticallyIgnoreListKnownThirdPartyScripts)}
256
+ title=${i18nString(UIStrings.automaticallyIgnoreListKnownThirdPartyScripts)}
257
+ ?disabled=${!input.enabled}
258
+ ${bindToSetting(input.automaticallyIgnoreListSetting)}>
259
+ ${i18nString(UIStrings.automaticallyIgnoreListKnownThirdPartyScripts)}
260
+ </devtools-checkbox>
261
+ <devtools-button
262
+ .iconName=${'help'}
263
+ .variant=${Buttons.Button.Variant.ICON}
264
+ .size=${Buttons.Button.Size.SMALL}
265
+ .jslogContext=${'learn-more'}
266
+ .title=${i18nString(UIStrings.learnMore)}
267
+ .disabled=${!input.enabled}
268
+ @click=${input.onLearnMoreClick}>
269
+ </devtools-button>
270
+ </div>
271
+ <div class="ignore-list-option">
272
+ <devtools-checkbox
273
+ name=${i18nString(UIStrings.ignoreListAnonymousScripts)}
274
+ title=${i18nString(UIStrings.ignoreListAnonymousScripts)}
275
+ ?disabled=${!input.enabled}
276
+ ${bindToSetting(input.skipAnonymousScriptsSetting)}>
277
+ ${i18nString(UIStrings.ignoreListAnonymousScripts)}
278
+ </devtools-checkbox>
279
+ </div>
280
+ </div>
281
+ </devtools-card>
282
+ <devtools-card class="ignore-list-options" .heading=${i18nString(UIStrings.customExclusionRules)}>
283
+ <div class="ignore-list-option-group custom-exclusion-group" role="group">
284
+ ${patternsBefore.length > 0 ? html`
285
+ <devtools-list
286
+ class="ignore-list"
287
+ .editable=${input.enabled}
288
+ .deletable=${input.enabled}
289
+ @edit=${(e: Lists.List.ItemEditEvent) => input.onBeginEdit(e.detail.index)}
290
+ @delete=${(e: Lists.List.ItemRemoveEvent) => input.onRemovePattern(e.detail.index)}>
291
+ ${Directives.repeat(
292
+ patternsBefore,
293
+ item => item.pattern,
294
+ (item, index) => renderRuleItem(item, index, input.enabled, input.onTogglePattern))}
295
+ </devtools-list>
296
+ ` : nothing}
297
+ ${editingIndex !== null ? renderEditor(input) : nothing}
298
+ ${editingIndex !== null && patternsAfter.length > 0 ? html`
299
+ <devtools-list
300
+ class="ignore-list"
301
+ .editable=${input.enabled}
302
+ .deletable=${input.enabled}
303
+ @edit=${(e: Lists.List.ItemEditEvent) => input.onBeginEdit(editingIndex + 1 + e.detail.index)}
304
+ @delete=${(e: Lists.List.ItemRemoveEvent) => input.onRemovePattern(editingIndex + 1 + e.detail.index)}>
305
+ ${Directives.repeat(
306
+ patternsAfter,
307
+ item => item.pattern,
308
+ (item, index) => renderRuleItem(item, editingIndex + 1 + index, input.enabled, input.onTogglePattern))}
309
+ </devtools-list>
310
+ ` : nothing}
311
+ <devtools-button
312
+ class="add-button"
313
+ .variant=${Buttons.Button.Variant.OUTLINED}
314
+ .jslogContext=${'settings.add-ignore-list-pattern'}
315
+ aria-label=${i18nString(UIStrings.addFilenamePattern)}
316
+ .disabled=${!input.enabled}
317
+ @click=${input.onAddPatternClick}>
318
+ ${i18nString(UIStrings.addPattern)}
319
+ </devtools-button>
320
+ </div>
321
+ </devtools-card>
322
+ </div>
323
+ </div>
324
+ `, target, {container: {attributes: {jslog: `${VisualLogging.pane('blackbox')}`}}});
325
+ // clang-format on
326
+ };
327
+
328
+ export class FrameworkIgnoreListSettingsTab extends UI.Widget.VBox {
329
+ private readonly setting: Common.Settings.RegExpSetting;
330
+ private readonly enabledSetting: Common.Settings.Setting<boolean>;
331
+ private readonly skipContentScriptsSetting: Common.Settings.Setting<boolean>;
332
+ private readonly automaticallyIgnoreListSetting: Common.Settings.Setting<boolean>;
333
+ private readonly skipAnonymousScriptsSetting: Common.Settings.Setting<boolean>;
334
+ readonly #view: View;
335
+ #editingIndex: number|null = null;
336
+ #editingValue = '';
337
+ #showValidationError = false;
338
+
339
+ constructor(view: View = DEFAULT_VIEW) {
103
340
  super({
104
- jslog: `${VisualLogging.pane('blackbox')}`,
105
341
  useShadowDom: true,
106
342
  });
343
+ this.#view = view;
107
344
  this.registerRequiredCSS(frameworkIgnoreListSettingsTabStyles, settingsScreenStyles);
108
345
 
109
- const settingsContent =
110
- this.contentElement.createChild('div', 'settings-card-container-wrapper').createChild('div');
111
- settingsContent.classList.add('settings-card-container', 'ignore-list-settings');
112
-
113
- const ignoreListingDescription = document.createElement('span');
114
- ignoreListingDescription.textContent = i18nString(UIStrings.ignoreListingDescription);
115
- const enabledSetting =
116
- Common.Settings.Settings.instance().resolve(Workspace.IgnoreListManager.enableIgnoreListingSettingDescriptor);
117
- const enableIgnoreListing = this.contentElement.createChild('div', 'enable-ignore-listing');
118
- enableIgnoreListing.appendChild(
119
- SettingsUI.SettingsUI.createSettingCheckbox(i18nString(UIStrings.ignoreListing), enabledSetting));
120
- UI.Tooltip.Tooltip.install(enableIgnoreListing, i18nString(UIStrings.enableIgnoreListingTooltip));
121
-
122
- const enableIgnoreListingCard = settingsContent.createChild('devtools-card');
123
- enableIgnoreListingCard.heading = i18nString(UIStrings.frameworkIgnoreList);
124
- enableIgnoreListingCard.append(ignoreListingDescription, enableIgnoreListing);
125
-
126
- const generalExclusionGroup = this.createSettingGroup();
127
- generalExclusionGroup.classList.add('general-exclusion-group');
128
- const ignoreListContentScripts = generalExclusionGroup.createChild('div', 'ignore-list-option')
129
- .appendChild(SettingsUI.SettingsUI.createSettingCheckbox(
130
- i18nString(UIStrings.ignoreListContentScripts),
131
- Common.Settings.Settings.instance().resolve(
132
- Workspace.IgnoreListManager.skipContentScriptsSettingDescriptor)));
133
-
134
- const automaticallyIgnoreListContainer = generalExclusionGroup.createChild('div', 'ignore-list-option');
135
- const automaticallyIgnoreList =
136
- automaticallyIgnoreListContainer.appendChild(SettingsUI.SettingsUI.createSettingCheckbox(
137
- i18nString(UIStrings.automaticallyIgnoreListKnownThirdPartyScripts),
138
- Common.Settings.Settings.instance().resolve(
139
- Workspace.IgnoreListManager.automaticallyIgnoreListKnownThirdPartyScriptsSettingDescriptor)));
140
-
141
- const automaticallyIgnoreLinkButton = new Buttons.Button.Button();
142
- automaticallyIgnoreLinkButton.data = {
143
- iconName: 'help',
144
- variant: Buttons.Button.Variant.ICON,
145
- size: Buttons.Button.Size.SMALL,
146
- jslogContext: 'learn-more',
147
- title: i18nString(UIStrings.learnMore),
148
- };
149
- automaticallyIgnoreLinkButton.addEventListener(
150
- 'click',
151
- () => UIHelpers.openInNewTab(
152
- 'https://developer.chrome.com/docs/devtools/settings/ignore-list/#skip-third-party'));
153
- automaticallyIgnoreListContainer.appendChild(automaticallyIgnoreLinkButton);
154
-
155
- const ignoreListAnonymousScripts = generalExclusionGroup.createChild('div', 'ignore-list-option')
156
- .appendChild(SettingsUI.SettingsUI.createSettingCheckbox(
157
- i18nString(UIStrings.ignoreListAnonymousScripts),
158
- Common.Settings.Settings.instance().resolve(
159
- Workspace.IgnoreListManager.skipAnonymousScriptsSettingDescriptor)));
160
-
161
- const generalExclusionGroupCard = settingsContent.createChild('devtools-card', 'ignore-list-options');
162
- generalExclusionGroupCard.heading = i18nString(UIStrings.generalExclusionRules);
163
- generalExclusionGroupCard.append(generalExclusionGroup);
164
-
165
- const customExclusionGroup = this.createSettingGroup();
166
- customExclusionGroup.classList.add('custom-exclusion-group');
167
- const customExclusionGroupCard = settingsContent.createChild('devtools-card', 'ignore-list-options');
168
- customExclusionGroupCard.heading = i18nString(UIStrings.customExclusionRules);
169
- customExclusionGroupCard.append(customExclusionGroup);
170
-
171
- this.list = new UI.ListWidget.ListWidget(this);
172
- this.list.element.classList.add('ignore-list');
173
- this.list.registerRequiredCSS(frameworkIgnoreListSettingsTabStyles);
174
-
175
- const placeholder = document.createElement('div');
176
- placeholder.classList.add('ignore-list-empty');
177
- this.list.setEmptyPlaceholder(placeholder);
178
- this.list.show(customExclusionGroup);
179
- const addPatternButton = UI.UIUtils.createTextButton(
180
- i18nString(UIStrings.addPattern), this.addButtonClicked.bind(this),
181
- {className: 'add-button', jslogContext: 'settings.add-ignore-list-pattern'});
182
- UI.ARIAUtils.setLabel(addPatternButton, i18nString(UIStrings.addFilenamePattern));
183
- customExclusionGroup.appendChild(addPatternButton);
184
- this.setting =
185
- Common.Settings.Settings.instance().resolve(
186
- Workspace.IgnoreListManager.skipStackFramesPatternSettingDescriptor) as Common.Settings.RegExpSetting;
187
- this.setting.addChangeListener(this.settingUpdated, this);
188
-
189
- const enabledChanged = (): void => {
190
- const enabled = enabledSetting.get();
191
- ignoreListContentScripts.disabled = !enabled;
192
- automaticallyIgnoreList.disabled = !enabled;
193
- automaticallyIgnoreLinkButton.disabled = !enabled;
194
- ignoreListAnonymousScripts.disabled = !enabled;
195
- addPatternButton.disabled = !enabled;
196
- this.settingUpdated();
197
- };
198
-
199
- enabledSetting.addChangeListener(enabledChanged);
200
- enabledChanged();
346
+ const settings = Common.Settings.Settings.instance();
347
+ this.enabledSetting = settings.resolve(Workspace.IgnoreListManager.enableIgnoreListingSettingDescriptor);
348
+ this.skipContentScriptsSetting = settings.resolve(Workspace.IgnoreListManager.skipContentScriptsSettingDescriptor);
349
+ this.automaticallyIgnoreListSetting =
350
+ settings.resolve(Workspace.IgnoreListManager.automaticallyIgnoreListKnownThirdPartyScriptsSettingDescriptor);
351
+ this.skipAnonymousScriptsSetting =
352
+ settings.resolve(Workspace.IgnoreListManager.skipAnonymousScriptsSettingDescriptor);
353
+
354
+ this.setting = settings.resolve(Workspace.IgnoreListManager.skipStackFramesPatternSettingDescriptor) as
355
+ Common.Settings.RegExpSetting;
356
+ this.setting.addChangeListener(this.#settingUpdated, this);
357
+
358
+ this.enabledSetting.addChangeListener(this.#settingUpdated, this);
359
+ this.performUpdate();
360
+ }
361
+
362
+ override performUpdate(): void {
363
+ const patterns = this.setting.getAsArray();
364
+ const validationError =
365
+ this.#editingIndex !== null ? this.#validatePattern(this.#editingValue, this.#editingIndex) : null;
366
+
367
+ this.#view(
368
+ {
369
+ enabledSetting: this.enabledSetting,
370
+ skipContentScriptsSetting: this.skipContentScriptsSetting,
371
+ automaticallyIgnoreListSetting: this.automaticallyIgnoreListSetting,
372
+ skipAnonymousScriptsSetting: this.skipAnonymousScriptsSetting,
373
+ enabled: this.enabledSetting.get(),
374
+ patterns,
375
+ editingIndex: this.#editingIndex,
376
+ editingValue: this.#editingValue,
377
+ validationError,
378
+ showValidationError: this.#showValidationError,
379
+ onLearnMoreClick: () => {
380
+ UIHelpers.openInNewTab('https://developer.chrome.com/docs/devtools/settings/ignore-list/#skip-third-party');
381
+ },
382
+ onAddPatternClick: this.#addButtonClicked.bind(this),
383
+ onTogglePattern: this.#togglePattern.bind(this),
384
+ onBeginEdit: this.#beginEdit.bind(this),
385
+ onRemovePattern: this.#removePattern.bind(this),
386
+ onEditorInput: this.#onEditorInput.bind(this),
387
+ onCommitEdit: this.#commitEdit.bind(this),
388
+ onCancelEdit: this.#cancelEdit.bind(this),
389
+ },
390
+ undefined,
391
+ this.contentElement,
392
+ );
201
393
  }
202
394
 
203
395
  override wasShown(): void {
204
396
  super.wasShown();
205
- this.settingUpdated();
397
+ this.#cancelEdit();
206
398
  }
207
399
 
208
- private settingUpdated(): void {
209
- const editable = Common.Settings.Settings.instance()
210
- .resolve(Workspace.IgnoreListManager.enableIgnoreListingSettingDescriptor)
211
- .get();
212
- this.list.clear();
213
- const patterns = this.setting.getAsArray();
214
- for (let i = 0; i < patterns.length; ++i) {
215
- this.list.appendItem(patterns[i], editable);
216
- }
400
+ #settingUpdated(): void {
401
+ this.#editingIndex = null;
402
+ this.#editingValue = '';
403
+ this.#showValidationError = false;
404
+ this.performUpdate();
217
405
  }
218
406
 
219
- private addButtonClicked(): void {
220
- this.list.addNewItem(this.setting.getAsArray().length, {pattern: '', disabled: false});
407
+ #addButtonClicked(): void {
408
+ this.#editingIndex = this.setting.getAsArray().length;
409
+ this.#editingValue = '';
410
+ this.#showValidationError = false;
411
+ this.performUpdate();
221
412
  }
222
413
 
223
- private createSettingGroup(): HTMLElement {
224
- const group = document.createElement('div');
225
- group.classList.add('ignore-list-option-group');
226
- UI.ARIAUtils.markAsGroup(group);
227
- return group;
414
+ #beginEdit(index: number): void {
415
+ const patterns = this.setting.getAsArray();
416
+ if (index < 0 || index >= patterns.length) {
417
+ return;
418
+ }
419
+ this.#editingIndex = index;
420
+ this.#editingValue = patterns[index].pattern;
421
+ this.#showValidationError = false;
422
+ this.performUpdate();
228
423
  }
229
424
 
230
- renderItem(item: Common.Settings.RegExpSettingItem, editable: boolean): Element {
231
- const element = document.createElement('div');
232
-
233
- const listSetting = this.setting;
234
-
235
- const checkbox =
236
- UI.UIUtils.CheckboxLabel.createWithStringLiteral(item.pattern, !item.disabled, 'settings.ignore-list-pattern');
237
- const helpText = i18nString(UIStrings.ignoreScriptsWhoseNamesMatchS, {PH1: item.pattern});
238
- UI.Tooltip.Tooltip.install(checkbox, helpText);
239
- checkbox.ariaLabel = helpText;
240
- checkbox.addEventListener('change', inputChanged, false);
241
- checkbox.disabled = !editable;
242
- element.appendChild(checkbox);
243
- element.classList.add('ignore-list-item');
244
-
245
- return element;
246
-
247
- function inputChanged(): void {
248
- const disabled = !checkbox.checked;
249
- if (item.disabled !== disabled) {
250
- item.disabled = disabled;
251
- item.disabledForUrl = undefined;
252
- // Send changed event
253
- listSetting.setAsArray(listSetting.getAsArray());
254
- }
255
- }
425
+ #onEditorInput(value: string): void {
426
+ this.#editingValue = value;
427
+ this.#showValidationError = true;
428
+ this.performUpdate();
256
429
  }
257
430
 
258
- removeItemRequested(_item: Common.Settings.RegExpSettingItem, index: number): void {
259
- const patterns = this.setting.getAsArray();
260
- patterns.splice(index, 1);
261
- this.setting.setAsArray(patterns);
431
+ #cancelEdit(): void {
432
+ this.#editingIndex = null;
433
+ this.#editingValue = '';
434
+ this.#showValidationError = false;
435
+ this.performUpdate();
262
436
  }
263
437
 
264
- commitEdit(
265
- item: Common.Settings.RegExpSettingItem, editor: UI.ListWidget.Editor<Common.Settings.RegExpSettingItem>,
266
- isNew: boolean): void {
267
- item.pattern = editor.control('pattern').value.trim();
438
+ #commitEdit(): void {
439
+ if (this.#editingIndex === null) {
440
+ return;
441
+ }
442
+ const validationError = this.#validatePattern(this.#editingValue, this.#editingIndex);
443
+ if (validationError !== null) {
444
+ this.#showValidationError = true;
445
+ this.performUpdate();
446
+ return;
447
+ }
268
448
 
449
+ const pattern = this.#editingValue.trim();
269
450
  const list = this.setting.getAsArray();
270
- if (isNew) {
271
- list.push(item);
451
+ if (this.#editingIndex === list.length) {
452
+ list.push({pattern, disabled: false});
453
+ } else if (list[this.#editingIndex]) {
454
+ list[this.#editingIndex].pattern = pattern;
272
455
  }
456
+ this.#editingIndex = null;
457
+ this.#editingValue = '';
458
+ this.#showValidationError = false;
273
459
  this.setting.setAsArray(list);
274
460
  }
275
461
 
276
- beginEdit(item: Common.Settings.RegExpSettingItem): UI.ListWidget.Editor<Common.Settings.RegExpSettingItem> {
277
- const editor = this.createEditor();
278
- editor.control('pattern').value = item.pattern;
279
- return editor;
280
- }
281
-
282
- private createEditor(): UI.ListWidget.Editor<Common.Settings.RegExpSettingItem> {
283
- if (this.editor) {
284
- return this.editor;
462
+ #togglePattern(index: number, checked: boolean): void {
463
+ const patterns = this.setting.getAsArray();
464
+ const item = patterns[index];
465
+ if (!item) {
466
+ return;
285
467
  }
468
+ const disabled = !checked;
469
+ if (item.disabled !== disabled) {
470
+ item.disabled = disabled;
471
+ item.disabledForUrl = undefined;
472
+ this.setting.setAsArray(patterns);
473
+ }
474
+ }
286
475
 
287
- const editor = new UI.ListWidget.Editor<Common.Settings.RegExpSettingItem>();
288
- this.editor = editor;
289
- const content = editor.contentElement();
290
-
291
- const titles = content.createChild('div', 'ignore-list-edit-row');
292
- titles.createChild('div', 'ignore-list-pattern').textContent = i18nString(UIStrings.pattern);
293
-
294
- const fields = content.createChild('div', 'ignore-list-edit-row');
295
- const pattern = editor.createInput('pattern', 'text', '/framework\\.js$', patternValidator.bind(this));
296
- UI.ARIAUtils.setLabel(pattern, i18nString(UIStrings.pattern));
297
- fields.createChild('div', 'ignore-list-pattern').appendChild(pattern);
298
-
299
- return editor;
476
+ #removePattern(index: number): void {
477
+ const patterns = this.setting.getAsArray();
478
+ patterns.splice(index, 1);
479
+ this.setting.setAsArray(patterns);
480
+ }
300
481
 
301
- function patternValidator(
302
- this: FrameworkIgnoreListSettingsTab, _item: Common.Settings.RegExpSettingItem, index: number,
303
- input: UI.ListWidget.EditorControl): UI.ListWidget.ValidatorResult {
304
- const pattern = input.value.trim();
305
- const patterns = this.setting.getAsArray();
482
+ #validatePattern(value: string, index: number): Common.UIString.LocalizedString|null {
483
+ const pattern = value.trim();
484
+ const patterns = this.setting.getAsArray();
306
485
 
307
- if (!pattern.length) {
308
- return {valid: false, errorMessage: i18nString(UIStrings.patternCannotBeEmpty)};
309
- }
486
+ if (!pattern.length) {
487
+ return i18nString(UIStrings.patternCannotBeEmpty);
488
+ }
310
489
 
311
- for (let i = 0; i < patterns.length; ++i) {
312
- if (i !== index && patterns[i].pattern === pattern) {
313
- return {valid: false, errorMessage: i18nString(UIStrings.patternAlreadyExists)};
314
- }
490
+ for (let i = 0; i < patterns.length; ++i) {
491
+ if (i !== index && patterns[i].pattern === pattern) {
492
+ return i18nString(UIStrings.patternAlreadyExists);
315
493
  }
494
+ }
316
495
 
317
- let regex;
318
- try {
319
- regex = new RegExp(pattern);
320
- } catch {
321
- }
322
- if (!regex) {
323
- return {valid: false, errorMessage: i18nString(UIStrings.patternMustBeAValidRegular)};
324
- }
325
- return {valid: true};
496
+ let regex;
497
+ try {
498
+ regex = new RegExp(pattern);
499
+ } catch {
500
+ }
501
+ if (!regex) {
502
+ return i18nString(UIStrings.patternMustBeAValidRegular);
326
503
  }
504
+ return null;
327
505
  }
328
506
  }