chrome-devtools-frontend 1.0.1726686 → 1.0.1730971
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/.agents/rules/tests/test-strict-assertions-and-literal-expectations.md +1 -1
- package/.agents/rules/tests/test-view-and-presenter-isolation.md +1 -1
- package/.agents/rules/ui-and-widgets/ui-accessibility-and-semantic-html.md +1 -1
- package/.agents/rules/ui-and-widgets/ui-css-scoping-and-flex-layout.md +2 -2
- package/.agents/rules/ui-and-widgets/ui-declarative-child-widget-composition.md +5 -5
- package/.agents/rules/ui-and-widgets/ui-lit-declarative-templates-and-directives.md +2 -2
- package/.agents/rules/ui-and-widgets/ui-localization-and-uistrings-hygiene.md +2 -2
- package/.agents/rules/ui-and-widgets/ui-modern-component-and-encapsulation-standards.md +3 -3
- package/.agents/rules/ui-and-widgets/ui-pure-view-and-presenter-separation.md +2 -2
- package/.agents/rules/ui-and-widgets/ui-reactive-widget-update-lifecycle.md +2 -2
- package/.agents/rules/ui-and-widgets/ui-view-output-and-callback-contracts.md +2 -2
- package/.agents/rules/ui-and-widgets/ui-widget-dom-and-listener-lifecycle.md +2 -2
- package/.agents/skills/code-review/SKILL.md +63 -12
- package/.agents/skills/ui-eng-vision-local-lit-renderer/SKILL.md +38 -10
- package/.agents/skills/ui-eng-vision-widget-promoter/SKILL.md +1 -0
- package/.agents/skills/ui-widgets/SKILL.md +8 -2
- package/.agents/skills/write-ai-eval-test/SKILL.md +106 -0
- package/AUTHORS +2 -0
- package/DIR_METADATA +1 -2
- package/README.md +48 -26
- package/config/typescript/tsconfig.base.json +1 -0
- package/config/typescript/tsconfig.eslint.json +1 -0
- package/docs/contributing/changes.md +25 -0
- package/docs/ui_engineering.md +13 -4
- package/eslint.config.mjs +323 -41
- package/front_end/core/common/Color.ts +7 -7
- package/front_end/core/common/ParsedURL.ts +3 -3
- package/front_end/core/common/ResolverBase.ts +3 -3
- package/front_end/core/common/SegmentedRange.ts +3 -3
- package/front_end/core/common/SimpleHistoryManager.ts +14 -14
- package/front_end/core/common/Trie.ts +3 -3
- package/front_end/core/common/VersionController.ts +7 -7
- package/front_end/core/host/InspectorFrontendHost.ts +2 -2
- package/front_end/core/host/InspectorFrontendHostAPI.ts +9 -1
- package/front_end/core/host/InspectorFrontendHostStub.ts +1 -1
- package/front_end/core/host/UserMetrics.ts +4 -0
- package/front_end/core/host/UserMetricsEnums.ts +2 -1
- package/front_end/core/platform/StringUtilities.ts +54 -13
- package/front_end/core/platform/node/HostRuntime.ts +13 -7
- package/front_end/core/protocol_client/DevToolsCDPConnection.ts +4 -5
- package/front_end/core/root/Runtime.ts +5 -0
- package/front_end/core/sdk/AccessibilityModel.ts +5 -5
- package/front_end/core/sdk/AnimationModel.ts +17 -19
- package/front_end/core/sdk/CPUProfilerModel.ts +3 -3
- package/front_end/core/sdk/CPUThrottlingManager.ts +7 -0
- package/front_end/core/sdk/CSSMatchedStyles.ts +73 -13
- package/front_end/core/sdk/CSSMetadata.ts +7 -7
- package/front_end/core/sdk/CSSModel.ts +33 -33
- package/front_end/core/sdk/CSSProperty.ts +5 -5
- package/front_end/core/sdk/CSSRule.ts +6 -6
- package/front_end/core/sdk/CSSStyleSheetHeader.ts +4 -4
- package/front_end/core/sdk/Connections.ts +16 -16
- package/front_end/core/sdk/ConsoleModel.ts +44 -47
- package/front_end/core/sdk/CookieParser.ts +11 -11
- package/front_end/core/sdk/EmulationModel.ts +35 -36
- package/front_end/core/sdk/EventBreakpointsModel.ts +11 -11
- package/front_end/core/sdk/FrameManager.ts +16 -16
- package/front_end/core/sdk/IsolateManager.ts +2 -2
- package/front_end/core/sdk/IssuesModel.ts +2 -2
- package/front_end/core/sdk/OverlayModel.ts +19 -19
- package/front_end/core/sdk/PageResourceLoader.ts +14 -16
- package/front_end/core/sdk/RemoteObject.ts +9 -9
- package/front_end/core/sdk/Resource.ts +2 -2
- package/front_end/core/sdk/RuntimeModel.ts +7 -7
- package/front_end/core/sdk/Script.ts +6 -6
- package/front_end/core/sdk/ServiceWorkerManager.ts +36 -10
- package/front_end/core/sdk/SourceMap.ts +18 -20
- package/front_end/core/sdk/SourceMapManager.ts +2 -2
- package/front_end/core/sdk/TargetManager.ts +2 -2
- package/front_end/devtools_compatibility.js +7 -3
- package/front_end/entrypoints/inspector_main/InspectorMain.ts +2 -2
- package/front_end/entrypoints/node_app/app/NodeConnectionsPanel.ts +203 -115
- package/front_end/generated/InspectorBackendCommands.ts +1 -1
- package/front_end/generated/SupportedCSSProperties.ts +1 -3
- package/front_end/generated/protocol.ts +1 -0
- package/front_end/models/ai_assistance/AiAgent2.ts +36 -12
- package/front_end/models/ai_assistance/AiConversation.ts +8 -2
- package/front_end/models/ai_assistance/agents/AiAgent.ts +137 -62
- package/front_end/models/ai_assistance/agents/ExecuteJavascript.ts +2 -2
- package/front_end/models/ai_assistance/agents/StylingAgent.snapshot.txt +2 -2
- package/front_end/models/ai_assistance/data_formatters/LighthouseFormatter.snapshot.txt +149 -2
- package/front_end/models/ai_assistance/data_formatters/LighthouseFormatter.ts +269 -42
- package/front_end/models/ai_assistance/tools/ExecuteJavaScript.ts +3 -0
- package/front_end/models/ai_assistance/tools/GetLighthouseAudits.ts +9 -0
- package/front_end/models/ai_assistance/tools/ResolveDevtoolsNodePath.ts +13 -2
- package/front_end/models/ai_assistance/tools/RunLighthouse.ts +23 -7
- package/front_end/models/ai_assistance/tools/Tool.ts +7 -5
- package/front_end/models/bindings/CSSWorkspaceBinding.ts +22 -24
- package/front_end/models/bindings/DebuggerLanguagePlugins.ts +60 -60
- package/front_end/models/bindings/DebuggerWorkspaceBinding.ts +24 -24
- package/front_end/models/bindings/DefaultScriptMapping.ts +8 -8
- package/front_end/models/bindings/FileUtils.ts +13 -13
- package/front_end/models/bindings/PresentationConsoleMessageHelper.ts +3 -3
- package/front_end/models/bindings/ResourceScriptMapping.ts +23 -23
- package/front_end/models/comment_manager/CommentManager.ts +3 -3
- package/front_end/models/comment_manager/CommentThread.ts +50 -5
- package/front_end/models/cpu_profile/CPUProfileDataModel.ts +14 -14
- package/front_end/models/cpu_profile/ProfileTreeModel.ts +4 -4
- package/front_end/models/elements/StyleChanges.ts +38 -0
- package/front_end/models/emulation/EmulatedDevices.ts +12 -12
- package/front_end/models/har/HARFormat.ts +4 -4
- package/front_end/models/javascript_metadata/NativeFunctions.ts +5 -1
- package/front_end/models/lighthouse/LighthouseReporterTypes.ts +57 -3
- package/front_end/models/lighthouse/RunTypes.ts +9 -1
- package/front_end/models/logs/LogManager.ts +2 -2
- package/front_end/models/persistence/AutomaticFileSystemManager.ts +3 -0
- package/front_end/models/persistence/FileSystemWorkspaceBinding.ts +24 -24
- package/front_end/models/persistence/IsolatedFileSystemManager.ts +6 -0
- package/front_end/models/persistence/NetworkPersistenceManager.ts +8 -3
- package/front_end/models/trace/LanternComputationData.ts +37 -11
- package/front_end/models/trace/Processor.ts +2 -1
- package/front_end/models/trace/extras/TraceTree.ts +36 -10
- package/front_end/models/trace/handlers/InitiatorsHandler.ts +27 -34
- package/front_end/models/trace/handlers/LayoutShiftsHandler.ts +2 -6
- package/front_end/models/trace/handlers/SamplesHandler.ts +9 -6
- package/front_end/models/workspace/FileManager.ts +6 -0
- package/front_end/panels/accessibility/ARIAAttributesView.ts +4 -4
- package/front_end/panels/accessibility/AccessibilityAnnouncementRecordingView.ts +8 -1
- package/front_end/panels/accessibility/AccessibilityNodeView.ts +15 -17
- package/front_end/panels/accessibility/AccessibilitySubPane.ts +1 -1
- package/front_end/panels/ai_assistance/AiAssistancePanel.ts +5 -5
- package/front_end/panels/ai_assistance/ExternalHandler.ts +10 -1
- package/front_end/panels/ai_assistance/components/ChatMessage.ts +27 -22
- package/front_end/panels/ai_assistance/components/DisabledWidget.ts +19 -23
- package/front_end/panels/ai_assistance/components/ExploreWidget.ts +2 -2
- package/front_end/panels/ai_assistance/components/PermissionPrompt.ts +23 -9
- package/front_end/panels/ai_assistance/components/chatInput.css +1 -1
- package/front_end/panels/animation/AnimationTimeline.ts +37 -17
- package/front_end/panels/animation/animationTimeline.css +19 -3
- package/front_end/panels/application/AppManifestView.ts +1 -2
- package/front_end/panels/application/ApplicationPanelSidebar.ts +143 -128
- package/front_end/panels/application/DOMStorageItemsView.ts +14 -14
- package/front_end/panels/application/DeviceBoundSessionsView.ts +10 -13
- package/front_end/panels/application/ExtensionStorageItemsView.ts +3 -4
- package/front_end/panels/application/IndexedDBViews.ts +8 -4
- package/front_end/panels/application/KeyValueStorageItemsView.ts +4 -5
- package/front_end/panels/application/PrivateVerificationTokensView.ts +53 -0
- package/front_end/panels/application/ServiceWorkerCacheViews.ts +12 -8
- package/front_end/panels/application/ServiceWorkersView.ts +1 -2
- package/front_end/panels/application/StorageItemsToolbar.ts +3 -3
- package/front_end/panels/application/StorageView.ts +2 -2
- package/front_end/panels/application/WebMCPView.ts +91 -109
- package/front_end/panels/application/application.ts +2 -0
- package/front_end/panels/application/components/StorageMetadataView.ts +6 -6
- package/front_end/panels/application/preloading/PreloadingView.ts +70 -37
- package/front_end/panels/application/preloading/components/MismatchedPreloadingGrid.ts +2 -2
- package/front_end/panels/application/preloading/components/PreloadingDisabledInfobar.ts +3 -3
- package/front_end/panels/application/preloading/components/PreloadingGrid.ts +12 -0
- package/front_end/panels/application/preloading/components/RuleSetDetailsView.ts +10 -11
- package/front_end/panels/application/privateVerificationTokensView.css +20 -0
- package/front_end/panels/application/serviceWorkersView.css +2 -2
- package/front_end/panels/browser_debugger/DOMBreakpointsSidebarPane.ts +24 -24
- package/front_end/panels/changes/ChangesSidebar.ts +5 -5
- package/front_end/panels/changes/ChangesView.ts +10 -11
- package/front_end/panels/comments/CommentsPane.ts +292 -102
- package/front_end/panels/comments/commentsPane.css +93 -12
- package/front_end/panels/common/CommentThreadWidget.ts +69 -0
- package/front_end/panels/common/CommentsOverlayWidget.ts +108 -29
- package/front_end/panels/common/CommentsStatusBarPill.ts +17 -6
- package/front_end/panels/common/DOMLinkifier.ts +37 -12
- package/front_end/panels/common/ExtensionPanel.ts +13 -4
- package/front_end/panels/common/ExtensionServer.ts +27 -3
- package/front_end/panels/common/PersistenceUtils.ts +3 -3
- package/front_end/panels/common/commentThreadWidget.css +25 -1
- package/front_end/panels/common/common-meta.ts +10 -0
- package/front_end/panels/console/ConsolePinPane.ts +13 -15
- package/front_end/panels/console/ConsolePrompt.ts +173 -95
- package/front_end/panels/console/ConsoleSidebar.ts +2 -2
- package/front_end/panels/console/ConsoleView.ts +75 -79
- package/front_end/panels/console/ConsoleViewMessage.ts +52 -4
- package/front_end/panels/console/SymbolizedErrorWidget.ts +8 -4
- package/front_end/panels/console/consolePrompt.css +1 -1
- package/front_end/panels/console/consoleView.css +1 -1
- package/front_end/panels/console_counters/WarningErrorCounter.ts +3 -4
- package/front_end/panels/coverage/CoverageListView.ts +2 -2
- package/front_end/panels/coverage/CoverageView.ts +20 -5
- package/front_end/panels/css_overview/CSSOverviewCompletedView.ts +4 -3
- package/front_end/panels/css_overview/CSSOverviewPanel.ts +2 -2
- package/front_end/panels/css_overview/CSSOverviewProcessingView.ts +2 -2
- package/front_end/panels/css_overview/CSSOverviewSidebarPanel.ts +2 -2
- package/front_end/panels/css_overview/CSSOverviewStartView.ts +2 -2
- package/front_end/panels/css_overview/CSSOverviewUnusedDeclarations.ts +8 -8
- package/front_end/panels/developer_resources/DeveloperResourcesListView.ts +2 -3
- package/front_end/panels/developer_resources/DeveloperResourcesView.ts +4 -5
- package/front_end/panels/elements/AccessibilityTreeUtils.ts +6 -7
- package/front_end/panels/elements/CSSValueTraceView.ts +3 -3
- package/front_end/panels/elements/ClassesPaneWidget.ts +1 -2
- package/front_end/panels/elements/ComputedStyleWidget.ts +15 -14
- package/front_end/panels/elements/DOMTreeElementWidget.ts +5 -4
- package/front_end/panels/elements/DOMTreeWidget.ts +2 -1
- package/front_end/panels/elements/ElementStatePaneWidget.ts +2 -2
- package/front_end/panels/elements/ElementsPanel.ts +1 -0
- package/front_end/panels/elements/EventListenersWidget.ts +2 -2
- package/front_end/panels/elements/LayoutPane.ts +2 -2
- package/front_end/panels/elements/PlatformFontsWidget.ts +3 -3
- package/front_end/panels/elements/PropertiesWidget.ts +9 -10
- package/front_end/panels/elements/PropertyRenderer.ts +72 -11
- package/front_end/panels/elements/StandaloneStylesContainer.ts +5 -10
- package/front_end/panels/elements/StyleEditorWidget.ts +30 -16
- package/front_end/panels/elements/StylePropertiesSection.ts +93 -44
- package/front_end/panels/elements/StylePropertyTreeElement.ts +230 -302
- package/front_end/panels/elements/StylesContainer.ts +2 -3
- package/front_end/panels/elements/StylesSidebarPane.ts +4 -13
- package/front_end/panels/elements/components/AccessibilityTreeNode.ts +66 -37
- package/front_end/panels/elements/components/CSSHintDetailsView.ts +51 -41
- package/front_end/panels/elements/components/CSSPropertyDocsView.ts +75 -65
- package/front_end/panels/elements/components/CSSQuery.ts +112 -74
- package/front_end/panels/elements/components/CSSVariableValueView.ts +109 -68
- package/front_end/panels/elements/components/ComputedStyleProperty.ts +64 -45
- package/front_end/panels/elements/components/ElementsTreeExpandButton.ts +35 -28
- package/front_end/panels/elements/components/QueryContainer.ts +104 -74
- package/front_end/panels/elements/components/accessibilityTreeNode.css +22 -20
- package/front_end/panels/elements/components/computedStyleProperty.css +2 -0
- package/front_end/panels/elements/components/cssHintDetailsView.css +23 -21
- package/front_end/panels/elements/components/cssPropertyDocsView.css +38 -36
- package/front_end/panels/elements/components/cssVariableValueView.css +42 -40
- package/front_end/panels/elements/components/elementsTreeExpandButton.css +5 -2
- package/front_end/panels/elements/components/queryContainer.css +23 -21
- package/front_end/panels/elements/stylesSidebarPane.css +3 -3
- package/front_end/panels/emulation/DeviceModeToolbar.ts +2 -2
- package/front_end/panels/emulation/InspectedPagePlaceholder.ts +2 -2
- package/front_end/panels/emulation/MediaQueryInspector.ts +9 -10
- package/front_end/panels/emulation/mediaQueryInspector.css +1 -1
- package/front_end/panels/event_listeners/EventListenersView.ts +2 -2
- package/front_end/panels/issues/AffectedCookiesView.ts +144 -101
- package/front_end/panels/issues/AffectedDescendantsWithinSelectElementView.ts +83 -31
- package/front_end/panels/issues/AffectedDirectivesView.ts +218 -135
- package/front_end/panels/issues/AffectedDocumentsInQuirksModeView.ts +84 -34
- package/front_end/panels/issues/AffectedElementsView.ts +86 -23
- package/front_end/panels/issues/AffectedLazyLoadImagesView.ts +2 -2
- package/front_end/panels/issues/AffectedMetadataAllowedSitesView.ts +2 -2
- package/front_end/panels/issues/AffectedPartitioningBlobURLView.ts +36 -11
- package/front_end/panels/issues/AffectedSharedArrayBufferIssueDetailsView.ts +135 -58
- package/front_end/panels/issues/AffectedSourcesView.ts +49 -28
- package/front_end/panels/issues/AffectedTrackingSitesView.ts +3 -4
- package/front_end/panels/issues/CorsIssueDetailsView.ts +490 -269
- package/front_end/panels/issues/GenericIssueDetailsView.ts +2 -2
- package/front_end/panels/issues/IssueKindView.ts +63 -48
- package/front_end/panels/issues/IssueView.ts +14 -18
- package/front_end/panels/issues/components/ElementsPanelLink.ts +70 -34
- package/front_end/panels/issues/components/HideIssuesMenu.ts +56 -32
- package/front_end/panels/issues/components/elementsPanelLink.css +10 -6
- package/front_end/panels/issues/components/hideIssuesMenu.css +16 -14
- package/front_end/panels/issues/issues.ts +2 -0
- package/front_end/panels/issues/issuesTree.css +4 -4
- package/front_end/panels/lighthouse/LighthouseController.ts +6 -6
- package/front_end/panels/lighthouse/LighthouseStatusView.ts +12 -13
- package/front_end/panels/lighthouse/lighthouseStartView.css +1 -1
- package/front_end/panels/linear_memory_inspector/LinearMemoryInspectorPane.ts +159 -161
- package/front_end/panels/linear_memory_inspector/LinearMemoryInspectorView.ts +228 -0
- package/front_end/panels/linear_memory_inspector/components/LinearMemoryInspector.ts +32 -41
- package/front_end/panels/linear_memory_inspector/components/linearMemoryHighlightChipList.css +2 -2
- package/front_end/panels/linear_memory_inspector/linear_memory_inspector.ts +2 -0
- package/front_end/panels/media/EventDisplayTable.ts +2 -2
- package/front_end/panels/media/MainView.ts +132 -66
- package/front_end/panels/media/PlayerDetailView.ts +32 -14
- package/front_end/panels/media/PlayerListView.ts +83 -23
- package/front_end/panels/media/PlayerPropertiesView.ts +2 -2
- package/front_end/panels/media/TickingFlameChart.ts +153 -63
- package/front_end/panels/mobile_throttling/NetworkThrottlingSelector.ts +2 -2
- package/front_end/panels/mobile_throttling/ThrottlingSettingsTab.ts +615 -464
- package/front_end/panels/mobile_throttling/throttlingSettingsTab.css +43 -0
- package/front_end/panels/network/EventSourceMessagesView.ts +3 -3
- package/front_end/panels/network/NetworkConfigView.ts +6 -2
- package/front_end/panels/network/NetworkDataGridNode.ts +2 -1
- package/front_end/panels/network/NetworkItemView.ts +27 -26
- package/front_end/panels/network/NetworkManageCustomHeadersView.ts +236 -97
- package/front_end/panels/network/NetworkOverview.ts +8 -10
- package/front_end/panels/network/RequestConditionsDrawer.ts +8 -4
- package/front_end/panels/network/RequestDeviceBoundSessionsView.ts +2 -4
- package/front_end/panels/network/RequestHTMLView.ts +26 -7
- package/front_end/panels/network/RequestHeadersView.ts +2 -2
- package/front_end/panels/network/RequestInitiatorView.ts +21 -22
- package/front_end/panels/network/RequestPayloadView.ts +2 -16
- package/front_end/panels/network/RequestPreviewView.ts +5 -5
- package/front_end/panels/network/RequestTimingView.ts +6 -6
- package/front_end/panels/network/ResourceDirectSocketChunkView.ts +5 -6
- package/front_end/panels/network/ResourceWebSocketFrameView.ts +4 -3
- package/front_end/panels/network/ShowMoreDetailsWidget.ts +11 -12
- package/front_end/panels/network/SignedExchangeInfoView.ts +2 -2
- package/front_end/panels/network/networkLogView.css +2 -2
- package/front_end/panels/network/networkManageCustomHeadersView.css +27 -6
- package/front_end/panels/network/requestConditionsDrawer.css +1 -1
- package/front_end/panels/network/requestInitiatorView.css +5 -3
- package/front_end/panels/performance_monitor/PerformanceMonitor.ts +2 -2
- package/front_end/panels/profiler/HeapDetachedElementsView.ts +1 -2
- package/front_end/panels/profiler/HeapTimelineOverview.ts +77 -15
- package/front_end/panels/profiler/IsolateSelector.ts +258 -187
- package/front_end/panels/profiler/ProfileLauncherView.ts +7 -29
- package/front_end/panels/profiler/profileLauncherView.css +6 -1
- package/front_end/panels/protocol_monitor/JSONEditor.ts +4 -5
- package/front_end/panels/recorder/ControlButton.ts +1 -1
- package/front_end/panels/recorder/RecordingListView.ts +2 -4
- package/front_end/panels/recorder/RecordingView.ts +1 -2
- package/front_end/panels/recorder/SelectorPicker.ts +2 -4
- package/front_end/panels/recorder/StepView.ts +24 -10
- package/front_end/panels/recorder/TimelineSection.ts +1 -1
- package/front_end/panels/recorder/recordingView.css +1 -1
- package/front_end/panels/screencast/ScreencastApp.ts +1 -1
- package/front_end/panels/search/SearchResultsPane.ts +11 -12
- package/front_end/panels/search/SearchView.ts +8 -10
- package/front_end/panels/security/SecurityPanel.ts +1 -8
- package/front_end/panels/security/SecurityPanelSidebar.ts +2 -2
- package/front_end/panels/security/mainView.css +1 -1
- package/front_end/panels/sensors/LocationsSettingsTab.ts +1 -2
- package/front_end/panels/settings/AISettingsTab.ts +1 -1
- package/front_end/panels/settings/BackendLinkingSettingsTab.ts +34 -20
- package/front_end/panels/settings/EditFileSystemView.ts +2 -2
- package/front_end/panels/settings/FrameworkIgnoreListSettingsTab.ts +375 -197
- package/front_end/panels/settings/KeybindsSettingsTab.ts +570 -414
- package/front_end/panels/settings/SettingsScreen.ts +312 -114
- package/front_end/panels/settings/WorkspaceSettingsTab.ts +2 -2
- package/front_end/panels/settings/aiSettingsTab.css +1 -4
- package/front_end/panels/settings/emulation/DevicesSettingsTab.ts +924 -578
- package/front_end/panels/settings/emulation/components/UserAgentClientHintsForm.ts +9 -2
- package/front_end/panels/settings/emulation/devicesSettingsTab.css +39 -0
- package/front_end/panels/settings/frameworkIgnoreListSettingsTab.css +37 -8
- package/front_end/panels/settings/settingsScreen.css +0 -24
- package/front_end/panels/sources/BreakpointEditDialog.ts +9 -6
- package/front_end/panels/sources/BreakpointsView.ts +25 -4
- package/front_end/panels/sources/CallStackSidebarPane.ts +7 -1
- package/front_end/panels/sources/DebuggerPlugin.ts +1 -0
- package/front_end/panels/sources/GoToLineQuickOpen.ts +8 -8
- package/front_end/panels/sources/NavigatorView.ts +521 -439
- package/front_end/panels/sources/PersistenceActions.ts +11 -12
- package/front_end/panels/sources/ProfilePlugin.ts +28 -17
- package/front_end/panels/sources/ScopeChainSidebarPane.ts +3 -4
- package/front_end/panels/sources/SourcesNavigator.ts +9 -9
- package/front_end/panels/sources/SourcesPanel.ts +2 -2
- package/front_end/panels/sources/SourcesView.ts +3 -3
- package/front_end/panels/sources/ThreadsSidebarPane.ts +2 -2
- package/front_end/panels/sources/WatchExpressionsSidebarPane.ts +2 -2
- package/front_end/panels/sources/components/HeadersView.ts +1 -2
- package/front_end/panels/timeline/CompatibilityTracksAppender.ts +5 -6
- package/front_end/panels/timeline/EventsTimelineTreeView.ts +73 -34
- package/front_end/panels/timeline/IsolateSelector.ts +25 -37
- package/front_end/panels/timeline/StatusDialog.ts +5 -7
- package/front_end/panels/timeline/ThirdPartyTreeView.ts +10 -13
- package/front_end/panels/timeline/TimelineDetailsView.ts +40 -21
- package/front_end/panels/timeline/TimelineEventOverview.ts +130 -34
- package/front_end/panels/timeline/TimelineFlameChartNetworkDataProvider.ts +1 -1
- package/front_end/panels/timeline/TimelineMiniMap.ts +255 -103
- package/front_end/panels/timeline/TimelinePaintProfilerView.ts +19 -11
- package/front_end/panels/timeline/TimelinePanel.ts +1 -0
- package/front_end/panels/timeline/TimelineSelectorStatsView.ts +11 -12
- package/front_end/panels/timeline/TimelineTreeView.ts +240 -122
- package/front_end/panels/timeline/TimelineUIUtils.ts +12 -0
- package/front_end/panels/timeline/components/BreadcrumbsUI.ts +5 -4
- package/front_end/panels/timeline/components/DetailsView.ts +97 -65
- package/front_end/panels/timeline/components/LayoutShiftDetails.ts +2 -2
- package/front_end/panels/timeline/components/MetricCard.ts +2 -2
- package/front_end/panels/timeline/components/NetworkRequestDetails.ts +11 -12
- package/front_end/panels/timeline/components/NetworkTrackWidget.ts +57 -50
- package/front_end/panels/timeline/components/RelatedInsightChips.ts +2 -2
- package/front_end/panels/timeline/components/Sidebar.ts +161 -109
- package/front_end/panels/timeline/components/SidebarAnnotationsTab.ts +33 -12
- package/front_end/panels/timeline/components/SidebarInsightsTab.ts +3 -0
- package/front_end/panels/timeline/components/insights/LCPDiscovery.ts +11 -11
- package/front_end/panels/timeline/components/insights/SlowCSSSelector.ts +6 -7
- package/front_end/panels/timeline/components/networkTrackWidget.css +24 -22
- package/front_end/panels/timeline/components/sidebarInsightsTab.css +1 -1
- package/front_end/panels/timeline/overlays/components/TimespanBreakdownOverlay.ts +15 -10
- package/front_end/panels/timeline/overlays/components/entryLabelOverlay.css +1 -1
- package/front_end/panels/timeline/timelinePanel.css +5 -0
- package/front_end/panels/timeline/timelineStatusDialog.css +1 -1
- package/front_end/panels/web_audio/WebAudioView.ts +2 -2
- package/front_end/third_party/chromium/README.chromium +1 -1
- package/front_end/third_party/legacy-javascript/README.chromium +2 -2
- package/front_end/third_party/legacy-javascript/lib/legacy-javascript.js +2 -2
- package/front_end/third_party/legacy-javascript/package.json +1 -1
- package/front_end/third_party/lighthouse/README.chromium +2 -2
- package/front_end/third_party/lighthouse/lighthouse-dt-bundle.js +1983 -2022
- package/front_end/third_party/lighthouse/locales/ar-XB.json +157 -142
- package/front_end/third_party/lighthouse/locales/ar.json +157 -142
- package/front_end/third_party/lighthouse/locales/bg.json +154 -139
- package/front_end/third_party/lighthouse/locales/ca.json +157 -142
- package/front_end/third_party/lighthouse/locales/cs.json +148 -133
- package/front_end/third_party/lighthouse/locales/da.json +153 -138
- package/front_end/third_party/lighthouse/locales/de.json +152 -137
- package/front_end/third_party/lighthouse/locales/el.json +153 -138
- package/front_end/third_party/lighthouse/locales/en-GB.json +160 -145
- package/front_end/third_party/lighthouse/locales/en-US.json +239 -218
- package/front_end/third_party/lighthouse/locales/en-XL.json +239 -218
- package/front_end/third_party/lighthouse/locales/es-419.json +150 -135
- package/front_end/third_party/lighthouse/locales/es.json +149 -134
- package/front_end/third_party/lighthouse/locales/fi.json +151 -136
- package/front_end/third_party/lighthouse/locales/fil.json +154 -139
- package/front_end/third_party/lighthouse/locales/fr.json +150 -135
- package/front_end/third_party/lighthouse/locales/he.json +160 -145
- package/front_end/third_party/lighthouse/locales/hi.json +156 -141
- package/front_end/third_party/lighthouse/locales/hr.json +154 -139
- package/front_end/third_party/lighthouse/locales/hu.json +111 -96
- package/front_end/third_party/lighthouse/locales/id.json +153 -138
- package/front_end/third_party/lighthouse/locales/it.json +153 -138
- package/front_end/third_party/lighthouse/locales/ja.json +150 -135
- package/front_end/third_party/lighthouse/locales/ko.json +42 -27
- package/front_end/third_party/lighthouse/locales/lt.json +152 -137
- package/front_end/third_party/lighthouse/locales/lv.json +93 -78
- package/front_end/third_party/lighthouse/locales/nl.json +149 -134
- package/front_end/third_party/lighthouse/locales/no.json +152 -137
- package/front_end/third_party/lighthouse/locales/pl.json +153 -138
- package/front_end/third_party/lighthouse/locales/pt-PT.json +152 -137
- package/front_end/third_party/lighthouse/locales/pt.json +157 -142
- package/front_end/third_party/lighthouse/locales/ro.json +149 -134
- package/front_end/third_party/lighthouse/locales/ru.json +76 -61
- package/front_end/third_party/lighthouse/locales/sk.json +153 -138
- package/front_end/third_party/lighthouse/locales/sl.json +149 -134
- package/front_end/third_party/lighthouse/locales/sr-Latn.json +151 -136
- package/front_end/third_party/lighthouse/locales/sr.json +151 -136
- package/front_end/third_party/lighthouse/locales/sv.json +152 -137
- package/front_end/third_party/lighthouse/locales/ta.json +156 -141
- package/front_end/third_party/lighthouse/locales/te.json +157 -142
- package/front_end/third_party/lighthouse/locales/th.json +111 -96
- package/front_end/third_party/lighthouse/locales/tr.json +153 -138
- package/front_end/third_party/lighthouse/locales/uk.json +149 -134
- package/front_end/third_party/lighthouse/locales/vi.json +162 -147
- package/front_end/third_party/lighthouse/locales/zh-HK.json +150 -135
- package/front_end/third_party/lighthouse/locales/zh-TW.json +154 -139
- package/front_end/third_party/lighthouse/locales/zh.json +152 -137
- package/front_end/third_party/lighthouse/report/bundle.d.ts +9 -8
- package/front_end/third_party/lighthouse/report/bundle.js +10 -10
- package/front_end/third_party/lighthouse/report-assets/report-generator.mjs +2 -7
- package/front_end/tsconfig.compatibility.json +1 -0
- package/front_end/tsconfig.json +3 -2
- package/front_end/ui/components/dialogs/TypeToAllowDialog.ts +0 -2
- package/front_end/ui/components/dialogs/typeToAllowDialog.css +0 -4
- package/front_end/ui/components/icon_button/fileSourceIcon.css +1 -1
- package/front_end/ui/components/input/textInput.css +1 -1
- package/front_end/ui/components/lists/List.ts +26 -14
- package/front_end/ui/components/menus/menus.ts +0 -2
- package/front_end/ui/components/suggestion_input/SuggestionInput.ts +351 -138
- package/front_end/ui/components/survey_link/surveyLink.css +3 -3
- package/front_end/ui/components/switch/switch.css +6 -6
- package/front_end/ui/components/text_editor/AiCodeCompletionTeaser.ts +2 -3
- package/front_end/ui/components/text_editor/TextEditor.ts +1 -1
- package/front_end/ui/components/tooltips/Tooltip.ts +53 -4
- package/front_end/ui/components/tree_outline/treeOutline.css +7 -7
- package/front_end/ui/helpers/OpenInNewTab.ts +8 -3
- package/front_end/ui/legacy/EmptyWidget.ts +4 -4
- package/front_end/ui/legacy/ForwardedInputEventHandler.ts +2 -2
- package/front_end/ui/legacy/GlassPane.ts +1 -1
- package/front_end/ui/legacy/KeyboardShortcut.ts +7 -7
- package/front_end/ui/legacy/RemoteDebuggingTerminatedScreen.ts +2 -2
- package/front_end/ui/legacy/TabbedPane.ts +198 -66
- package/front_end/ui/legacy/TargetCrashedScreen.ts +2 -2
- package/front_end/ui/legacy/UIUtils.ts +71 -68
- package/front_end/ui/legacy/View.ts +7 -4
- package/front_end/ui/legacy/ViewManager.ts +49 -37
- package/front_end/ui/legacy/Widget.ts +32 -12
- package/front_end/ui/legacy/components/cookie_table/CookiesTable.ts +2 -3
- package/front_end/ui/legacy/components/inline_editor/AnimationTimingUI.ts +8 -8
- package/front_end/ui/legacy/components/inline_editor/BezierUI.ts +8 -9
- package/front_end/ui/legacy/components/inline_editor/LinkSwatch.ts +2 -2
- package/front_end/ui/legacy/components/inline_editor/cssAngleEditor.css +1 -1
- package/front_end/ui/legacy/components/inline_editor/cssAngleSwatch.css +1 -1
- package/front_end/ui/legacy/components/object_ui/ObjectPropertiesSection.ts +45 -11
- package/front_end/ui/legacy/components/object_ui/RemoteObjectPreviewFormatter.ts +10 -12
- package/front_end/ui/legacy/components/perf_ui/ChartViewport.ts +102 -29
- package/front_end/ui/legacy/components/perf_ui/FlameChart.ts +148 -122
- package/front_end/ui/legacy/components/perf_ui/TimelineOverviewPane.ts +20 -14
- package/front_end/ui/legacy/components/quick_open/filteredListWidget.css +1 -1
- package/front_end/ui/legacy/components/source_frame/FontView.ts +29 -5
- package/front_end/ui/legacy/components/source_frame/ImageView.ts +79 -12
- package/front_end/ui/legacy/components/source_frame/JSONView.ts +20 -2
- package/front_end/ui/legacy/components/source_frame/PreviewFactory.ts +2 -2
- package/front_end/ui/legacy/components/source_frame/StreamingContentHexView.ts +6 -10
- package/front_end/ui/legacy/components/source_frame/XMLView.ts +11 -11
- package/front_end/ui/legacy/components/source_frame/fontView.css +7 -0
- package/front_end/ui/legacy/components/source_frame/imageView.css +7 -0
- package/front_end/ui/legacy/components/utils/JSPresentationUtils.ts +14 -3
- package/front_end/ui/legacy/components/utils/Linkifier.ts +126 -2
- package/front_end/ui/legacy/emptyWidget.css +2 -1
- package/front_end/ui/legacy/inspectorCommon.css +3 -3
- package/front_end/ui/legacy/smallBubble.css +1 -1
- package/front_end/ui/legacy/tabbedPane.css +6 -0
- package/front_end/ui/lit/Directives.ts +35 -18
- package/front_end/ui/lit/lit.ts +0 -2
- package/front_end/ui/lit/render.ts +0 -7
- package/front_end/ui/visual_logging/KnownContextValues.ts +5 -0
- package/package.json +1 -1
- package/vpython.toml +8 -0
- package/vpython.toml.uv.lock +3 -0
- package/.agents/skills/review-models-core/SKILL.md +0 -73
- package/.agents/skills/review-tests/SKILL.md +0 -67
- package/.agents/skills/review-ui-widgets/SKILL.md +0 -115
- package/front_end/generated/ARIAProperties.ts +0 -2686
- package/front_end/ui/components/menus/README.md +0 -119
- package/front_end/ui/components/menus/SelectMenu.ts +0 -473
- package/front_end/ui/components/menus/selectMenu.css +0 -54
- package/front_end/ui/components/menus/selectMenuButton.css +0 -108
|
@@ -16,7 +16,7 @@ import * as CommonPanels from '../common/common.js';
|
|
|
16
16
|
|
|
17
17
|
import commentsPaneStyles from './commentsPane.css.js';
|
|
18
18
|
|
|
19
|
-
const {html, render, Directives: {repeat}} = Lit;
|
|
19
|
+
const {html, render, i18nTemplate, Directives: {ref, repeat}} = Lit;
|
|
20
20
|
const {widget} = UI.Widget;
|
|
21
21
|
const {computeCommentTitle} = CommonPanels.CommentThreadWidget;
|
|
22
22
|
type Title = CommonPanels.CommentThreadWidget.Title;
|
|
@@ -27,13 +27,27 @@ const UIStrings = {
|
|
|
27
27
|
*/
|
|
28
28
|
clearComments: 'Clear all comments',
|
|
29
29
|
/**
|
|
30
|
-
* @description
|
|
30
|
+
* @description Title of the empty state shown in the Comments panel when there are no queued comments.
|
|
31
31
|
*/
|
|
32
|
-
noQueuedComments: 'No queued comments
|
|
32
|
+
noQueuedComments: 'No queued comments',
|
|
33
33
|
/**
|
|
34
|
-
* @description
|
|
34
|
+
* @description Title of the empty state shown in the Comments panel when there are no comments at all.
|
|
35
35
|
*/
|
|
36
|
-
|
|
36
|
+
noComments: 'No comments',
|
|
37
|
+
/**
|
|
38
|
+
* @description Description in the empty state of the Comments panel. PH1 is the comment mode icon, the same icon as
|
|
39
|
+
* the button that turns on comment mode.
|
|
40
|
+
* @example {(comment icon)} PH1
|
|
41
|
+
*/
|
|
42
|
+
emptyStateDescription: 'Use {PH1} to select an element and send tasks, questions, and context to your coding agent',
|
|
43
|
+
/**
|
|
44
|
+
* @description Accessible name of the comment mode icon shown inside the empty state description of the Comments panel.
|
|
45
|
+
*/
|
|
46
|
+
commentModeIcon: 'Comment mode',
|
|
47
|
+
/**
|
|
48
|
+
* @description Link in the empty state of the Comments panel that turns on comment mode so the user can add a comment.
|
|
49
|
+
*/
|
|
50
|
+
addComment: 'Add a comment',
|
|
37
51
|
/**
|
|
38
52
|
* @description Tooltip and aria-label for deleting a comment thread.
|
|
39
53
|
*/
|
|
@@ -46,6 +60,16 @@ const UIStrings = {
|
|
|
46
60
|
* @description Status text shown next to a spinner when a comment thread is being processed by the agent.
|
|
47
61
|
*/
|
|
48
62
|
working: 'Working',
|
|
63
|
+
/**
|
|
64
|
+
* @description Status text shown next to a checkmark when a comment thread has been sent but not yet picked up by
|
|
65
|
+
* the agent.
|
|
66
|
+
*/
|
|
67
|
+
sentStatus: 'Sent',
|
|
68
|
+
/**
|
|
69
|
+
* @description Alt text for the checkmark icon shown on a comment thread that has been sent but not yet picked up
|
|
70
|
+
* by the agent.
|
|
71
|
+
*/
|
|
72
|
+
sentCheckmark: 'Sent checkmark',
|
|
49
73
|
/**
|
|
50
74
|
* @description Button text shown on resolved comment threads to view the agent response.
|
|
51
75
|
*/
|
|
@@ -62,6 +86,10 @@ const UIStrings = {
|
|
|
62
86
|
* @description Label shown next to an element anchor in the comments drawer when the target DOM node has been removed or can no longer be found.
|
|
63
87
|
*/
|
|
64
88
|
removed: 'removed',
|
|
89
|
+
/**
|
|
90
|
+
* @description Text in the bar that visually separates the queued comments from the comments already sent to the agent in the comments drawer.
|
|
91
|
+
*/
|
|
92
|
+
sentComments: 'Sent comments',
|
|
65
93
|
} as const;
|
|
66
94
|
|
|
67
95
|
const UIStringsNotTranslate = {
|
|
@@ -78,6 +106,8 @@ const lockedString = i18n.i18n.lockedString;
|
|
|
78
106
|
|
|
79
107
|
export type Tab = 'queued'|'sent';
|
|
80
108
|
|
|
109
|
+
const TOGGLE_COMMENT_MODE_ACTION_ID = 'comments.toggle-comment-mode';
|
|
110
|
+
|
|
81
111
|
export interface ThreadViewData {
|
|
82
112
|
thread: CommentManager.CommentManager.CommentThread;
|
|
83
113
|
title: Title;
|
|
@@ -86,8 +116,11 @@ export interface ThreadViewData {
|
|
|
86
116
|
|
|
87
117
|
export interface ViewInput {
|
|
88
118
|
activeTab: Tab;
|
|
89
|
-
|
|
90
|
-
|
|
119
|
+
queuedThreads: ThreadViewData[];
|
|
120
|
+
sentThreads: ThreadViewData[];
|
|
121
|
+
onTabClick: (tab: Tab) => void;
|
|
122
|
+
onScroll: () => void;
|
|
123
|
+
onScrollEnd: () => void;
|
|
91
124
|
onClearAll: () => void;
|
|
92
125
|
onThreadClick: (
|
|
93
126
|
thread: CommentManager.CommentManager.CommentThread,
|
|
@@ -95,9 +128,22 @@ export interface ViewInput {
|
|
|
95
128
|
) => void;
|
|
96
129
|
onDeleteThread: (threadId: string) => void;
|
|
97
130
|
onSendToAgent: () => void;
|
|
131
|
+
onAddComment: () => void;
|
|
132
|
+
}
|
|
133
|
+
|
|
134
|
+
export interface ViewOutput {
|
|
135
|
+
/** The element that scrolls the comments. Only used to restore its scroll position. */
|
|
136
|
+
scrollContainer?: HTMLElement;
|
|
137
|
+
/**
|
|
138
|
+
* Scrolls "Queued" to the very top and "Sent" to the sent section, if there is one.
|
|
139
|
+
* Returns whether a smooth scroll started, which ends with a `scrollend` event.
|
|
140
|
+
*/
|
|
141
|
+
scrollToSection?: (tab: Tab, options: {animate: boolean}) => boolean;
|
|
142
|
+
/** The section that has reached the top of the list. */
|
|
143
|
+
sectionAtTop?: () => Tab;
|
|
98
144
|
}
|
|
99
145
|
|
|
100
|
-
export type View = (input: ViewInput, output:
|
|
146
|
+
export type View = (input: ViewInput, output: ViewOutput, target: HTMLElement) => void;
|
|
101
147
|
|
|
102
148
|
function renderThreadStatus(
|
|
103
149
|
thread: CommentManager.CommentManager.CommentThread,
|
|
@@ -106,6 +152,18 @@ function renderThreadStatus(
|
|
|
106
152
|
// clang-format off
|
|
107
153
|
switch (thread.status) {
|
|
108
154
|
case 'SENT_TO_AGENT':
|
|
155
|
+
if (!thread.transmitted) {
|
|
156
|
+
return html`
|
|
157
|
+
<div class="thread-status-sent">
|
|
158
|
+
<devtools-icon
|
|
159
|
+
class="check-icon"
|
|
160
|
+
name="checkmark"
|
|
161
|
+
aria-label=${i18nString(UIStrings.sentCheckmark)}>
|
|
162
|
+
</devtools-icon>
|
|
163
|
+
<span>${i18nString(UIStrings.sentStatus)}</span>
|
|
164
|
+
</div>
|
|
165
|
+
`;
|
|
166
|
+
}
|
|
109
167
|
return html`
|
|
110
168
|
<div class="thread-status-working">
|
|
111
169
|
<devtools-spinner></devtools-spinner>
|
|
@@ -152,34 +210,138 @@ function renderThreadStatus(
|
|
|
152
210
|
// clang-format on
|
|
153
211
|
}
|
|
154
212
|
|
|
155
|
-
export const DEFAULT_VIEW: View = (input: ViewInput,
|
|
213
|
+
export const DEFAULT_VIEW: View = (input: ViewInput, output: ViewOutput, target: HTMLElement): void => {
|
|
156
214
|
const isQueued = input.activeTab === 'queued';
|
|
157
215
|
const isSent = input.activeTab === 'sent';
|
|
216
|
+
const hasThreads = input.queuedThreads.length > 0 || input.sentThreads.length > 0;
|
|
217
|
+
let sentSection: HTMLElement|undefined;
|
|
218
|
+
|
|
219
|
+
output.scrollToSection = (tab, {animate}) => {
|
|
220
|
+
const {scrollContainer} = output;
|
|
221
|
+
const top = tab === 'queued' ? 0 : sentSection?.offsetTop;
|
|
222
|
+
if (!scrollContainer || top === undefined || Math.abs(top - scrollContainer.scrollTop) < 1) {
|
|
223
|
+
return false;
|
|
224
|
+
}
|
|
225
|
+
scrollContainer.scrollTo({top, behavior: animate ? 'smooth' : 'instant'});
|
|
226
|
+
return animate;
|
|
227
|
+
};
|
|
228
|
+
// "Sent" once the sent section has scrolled up to the top edge of the list.
|
|
229
|
+
output.sectionAtTop = () => {
|
|
230
|
+
const {scrollContainer} = output;
|
|
231
|
+
return scrollContainer && sentSection && sentSection.offsetTop - scrollContainer.scrollTop <= 1 ? 'sent' : 'queued';
|
|
232
|
+
};
|
|
158
233
|
const onThreadClick = (e: Event, thread: CommentManager.CommentManager.CommentThread): void => {
|
|
159
234
|
const rowEl = e.currentTarget as HTMLElement;
|
|
160
235
|
const rowRect = rowEl.getBoundingClientRect();
|
|
161
236
|
const badgeRect = rowEl.querySelector('.comment-pin-badge')?.getBoundingClientRect();
|
|
162
237
|
input.onThreadClick(thread, {left: badgeRect?.left ?? rowRect.left, top: rowRect.top});
|
|
163
238
|
};
|
|
239
|
+
|
|
164
240
|
// clang-format off
|
|
241
|
+
const renderThreadList = (threads: ThreadViewData[], className: string): Lit.LitTemplate => html`
|
|
242
|
+
<ul class="comments-list ${className}" role="list">
|
|
243
|
+
${repeat(
|
|
244
|
+
threads,
|
|
245
|
+
item => item.thread.id,
|
|
246
|
+
item => html`
|
|
247
|
+
<li
|
|
248
|
+
class="comment-thread-item ${item.thread.isOrphaned ? 'orphaned' : ''}"
|
|
249
|
+
role="listitem"
|
|
250
|
+
tabindex="0"
|
|
251
|
+
@click=${(e: Event) => onThreadClick(e, item.thread)}
|
|
252
|
+
@keydown=${(e: KeyboardEvent) => {
|
|
253
|
+
if (e.key === 'Enter' || e.key === ' ') {
|
|
254
|
+
e.preventDefault();
|
|
255
|
+
onThreadClick(e, item.thread);
|
|
256
|
+
}
|
|
257
|
+
}}
|
|
258
|
+
jslog=${VisualLogging.item('comment-thread').track({click: true})}>
|
|
259
|
+
<div class="comment-pin-badge" aria-hidden="true"></div>
|
|
260
|
+
<span class="anchor-chip ${item.thread.isOrphaned ? 'orphaned' : ''}">
|
|
261
|
+
${'node' in item.title ?
|
|
262
|
+
widget(CommonPanels.DOMLinkifier.DOMNodeLink, {
|
|
263
|
+
node: item.title.node,
|
|
264
|
+
options: {preventKeyboardFocus: true, disabled: item.thread.isOrphaned},
|
|
265
|
+
}) :
|
|
266
|
+
html`<span class="anchor-chip-text">${item.title.text}</span>`}
|
|
267
|
+
${item.thread.isOrphaned ?
|
|
268
|
+
html`<span class="orphaned-label">(${i18nString(UIStrings.removed)})</span>` :
|
|
269
|
+
Lit.nothing}
|
|
270
|
+
</span>
|
|
271
|
+
<div class="comment-text">${item.commentText}</div>
|
|
272
|
+
${renderThreadStatus(item.thread, input.onDeleteThread)}
|
|
273
|
+
</li>
|
|
274
|
+
`,
|
|
275
|
+
)}
|
|
276
|
+
</ul>
|
|
277
|
+
`;
|
|
278
|
+
|
|
279
|
+
const renderFooter = (): Lit.LitTemplate => html`
|
|
280
|
+
<div class="comments-footer">
|
|
281
|
+
<devtools-icon
|
|
282
|
+
class="info-icon"
|
|
283
|
+
name="info"
|
|
284
|
+
aria-label="Info"
|
|
285
|
+
aria-details="comments-pane-info-tooltip"
|
|
286
|
+
tabindex="0"
|
|
287
|
+
></devtools-icon>
|
|
288
|
+
<devtools-tooltip
|
|
289
|
+
id="comments-pane-info-tooltip"
|
|
290
|
+
variant="rich"
|
|
291
|
+
>
|
|
292
|
+
<div class="info-tooltip-container">
|
|
293
|
+
${lockedString(UIStringsNotTranslate.inputDisclaimer)}
|
|
294
|
+
</div>
|
|
295
|
+
</devtools-tooltip>
|
|
296
|
+
<button
|
|
297
|
+
class="send-agent-button"
|
|
298
|
+
@click=${input.onSendToAgent}
|
|
299
|
+
jslog=${VisualLogging.action('comments-send-to-agent').track({click: true})}>
|
|
300
|
+
${i18nString(UIStrings.sendToAgent)}
|
|
301
|
+
</button>
|
|
302
|
+
</div>
|
|
303
|
+
`;
|
|
304
|
+
|
|
305
|
+
const renderEmptyState = (title: string): Lit.LitTemplate => html`
|
|
306
|
+
<div class="comments-empty-state">
|
|
307
|
+
<div class="comments-empty-state-title">${title}</div>
|
|
308
|
+
<div class="comments-empty-state-description">
|
|
309
|
+
${i18nTemplate(str_, UIStrings.emptyStateDescription, {
|
|
310
|
+
PH1: html`<devtools-icon
|
|
311
|
+
class="comments-empty-state-icon"
|
|
312
|
+
name="comment-mode"
|
|
313
|
+
role="img"
|
|
314
|
+
aria-label=${i18nString(UIStrings.commentModeIcon)}
|
|
315
|
+
></devtools-icon>`,
|
|
316
|
+
})}
|
|
317
|
+
</div>
|
|
318
|
+
<devtools-button
|
|
319
|
+
class="comments-empty-state-link"
|
|
320
|
+
.data=${{
|
|
321
|
+
variant: Buttons.Button.Variant.TEXT,
|
|
322
|
+
jslogContext: 'comments-add-comment',
|
|
323
|
+
} as Buttons.Button.ButtonData}
|
|
324
|
+
@click=${input.onAddComment}
|
|
325
|
+
>${i18nString(UIStrings.addComment)}</devtools-button>
|
|
326
|
+
</div>
|
|
327
|
+
`;
|
|
328
|
+
|
|
165
329
|
render(html`
|
|
166
330
|
<style>${commentsPaneStyles}</style>
|
|
167
331
|
<div class="comments-container" role="region" aria-label="Comments" jslog=${VisualLogging.panel('comments').track({resize: true})}>
|
|
168
332
|
<div class="comments-toolbar" role="toolbar" jslog=${VisualLogging.toolbar('comments-drawer')}>
|
|
169
|
-
<div class="toolbar-left"
|
|
333
|
+
<div class="toolbar-left">
|
|
170
334
|
<button
|
|
171
335
|
class="tab-button ${isQueued ? 'active' : ''}"
|
|
172
|
-
|
|
173
|
-
|
|
174
|
-
@click=${() => input.onTabSelect('queued')}
|
|
336
|
+
aria-current=${isQueued ? 'location' : 'false'}
|
|
337
|
+
@click=${() => input.onTabClick('queued')}
|
|
175
338
|
jslog=${VisualLogging.sectionHeader('queued').track({ click: true })}>
|
|
176
339
|
${i18nString(UIStrings.queued)}
|
|
177
340
|
</button>
|
|
178
341
|
<button
|
|
179
342
|
class="tab-button ${isSent ? 'active' : ''}"
|
|
180
|
-
|
|
181
|
-
|
|
182
|
-
@click=${() => input.onTabSelect('sent')}
|
|
343
|
+
aria-current=${isSent ? 'location' : 'false'}
|
|
344
|
+
@click=${() => input.onTabClick('sent')}
|
|
183
345
|
jslog=${VisualLogging.sectionHeader('sent').track({ click: true })}>
|
|
184
346
|
${i18nString(UIStrings.sent)}
|
|
185
347
|
</button>
|
|
@@ -194,69 +356,32 @@ export const DEFAULT_VIEW: View = (input: ViewInput, _output: undefined, target:
|
|
|
194
356
|
</button>
|
|
195
357
|
</div>
|
|
196
358
|
|
|
197
|
-
${
|
|
198
|
-
<div
|
|
199
|
-
|
|
200
|
-
|
|
201
|
-
|
|
202
|
-
|
|
203
|
-
|
|
204
|
-
|
|
205
|
-
|
|
206
|
-
|
|
207
|
-
|
|
208
|
-
|
|
209
|
-
|
|
210
|
-
|
|
211
|
-
|
|
212
|
-
|
|
213
|
-
|
|
214
|
-
|
|
215
|
-
|
|
216
|
-
|
|
217
|
-
|
|
218
|
-
|
|
219
|
-
<div class="comment-pin-badge" aria-hidden="true"></div>
|
|
220
|
-
<span class="anchor-chip ${item.thread.isOrphaned ? 'orphaned' : ''}">
|
|
221
|
-
${'node' in item.title ?
|
|
222
|
-
widget(CommonPanels.DOMLinkifier.DOMNodeLink, { node: item.title.node, options: { preventKeyboardFocus: true, disabled: item.thread.isOrphaned } }) :
|
|
223
|
-
html`<span class="anchor-chip-text">${item.title.text}</span>`}
|
|
224
|
-
${item.thread.isOrphaned ? html`<span class="orphaned-label">(${i18nString(UIStrings.removed)})</span>` : Lit.nothing}
|
|
225
|
-
</span>
|
|
226
|
-
<div class="comment-text">${item.commentText}</div>
|
|
227
|
-
${renderThreadStatus(item.thread, input.onDeleteThread)}
|
|
228
|
-
</li>
|
|
229
|
-
`,
|
|
230
|
-
)}
|
|
231
|
-
</ul>
|
|
232
|
-
`}
|
|
233
|
-
|
|
234
|
-
${isQueued ? html`
|
|
235
|
-
<div class="comments-footer">
|
|
236
|
-
<devtools-icon
|
|
237
|
-
class="info-icon"
|
|
238
|
-
name="info"
|
|
239
|
-
aria-label="Info"
|
|
240
|
-
aria-details="comments-pane-info-tooltip"
|
|
241
|
-
tabindex="0"
|
|
242
|
-
></devtools-icon>
|
|
243
|
-
<devtools-tooltip
|
|
244
|
-
id="comments-pane-info-tooltip"
|
|
245
|
-
variant="rich"
|
|
246
|
-
>
|
|
247
|
-
<div class="info-tooltip-container">
|
|
248
|
-
${lockedString(UIStringsNotTranslate.inputDisclaimer)}
|
|
359
|
+
${hasThreads ? html`
|
|
360
|
+
<div
|
|
361
|
+
class="comments-scroll-container"
|
|
362
|
+
${ref(element => {
|
|
363
|
+
output.scrollContainer = element as HTMLElement | undefined;
|
|
364
|
+
})}
|
|
365
|
+
@scroll=${input.onScroll}
|
|
366
|
+
@scrollend=${input.onScrollEnd}>
|
|
367
|
+
<div class="comments-queued-section">
|
|
368
|
+
${input.queuedThreads.length > 0 ? html`
|
|
369
|
+
${renderThreadList(input.queuedThreads, 'comments-queued-list')}
|
|
370
|
+
${renderFooter()}
|
|
371
|
+
` : renderEmptyState(i18nString(UIStrings.noQueuedComments))}
|
|
372
|
+
</div>
|
|
373
|
+
${input.sentThreads.length > 0 ? html`
|
|
374
|
+
<div class="comments-sent-section" ${ref(element => {
|
|
375
|
+
sentSection = element as HTMLElement | undefined;
|
|
376
|
+
})}>
|
|
377
|
+
<div class="comments-sent-separator" role="separator" aria-label=${i18nString(UIStrings.sentComments)}>
|
|
378
|
+
${i18nString(UIStrings.sentComments)}
|
|
379
|
+
</div>
|
|
380
|
+
${renderThreadList(input.sentThreads, 'comments-sent-list')}
|
|
249
381
|
</div>
|
|
250
|
-
|
|
251
|
-
<button
|
|
252
|
-
class="send-agent-button"
|
|
253
|
-
?disabled=${input.threads.length === 0}
|
|
254
|
-
@click=${input.onSendToAgent}
|
|
255
|
-
jslog=${VisualLogging.action('comments-send-to-agent').track({ click: true })}>
|
|
256
|
-
${i18nString(UIStrings.sendToAgent)}
|
|
257
|
-
</button>
|
|
382
|
+
` : Lit.nothing}
|
|
258
383
|
</div>
|
|
259
|
-
` :
|
|
384
|
+
` : renderEmptyState(i18nString(UIStrings.noComments))}
|
|
260
385
|
</div>
|
|
261
386
|
`, target);
|
|
262
387
|
// clang-format on
|
|
@@ -273,7 +398,16 @@ export class CommentsPane extends UI.Widget.Widget {
|
|
|
273
398
|
readonly #commentManager: CommentManager.CommentManager.CommentManager;
|
|
274
399
|
|
|
275
400
|
readonly #cachedTitles = new Map<string, Title>();
|
|
401
|
+
readonly #viewOutput: ViewOutput = {};
|
|
276
402
|
#activeTab: Tab = 'queued';
|
|
403
|
+
// Set while a tab click smoothly scrolls the list. Scroll events then don't
|
|
404
|
+
// change the highlighted tab, so it doesn't flicker on the way.
|
|
405
|
+
#scrollingToTab = false;
|
|
406
|
+
// Whether the previous render had sent comments and nothing queued. We jump
|
|
407
|
+
// to Sent only when this changes from false to true. Without it, every update
|
|
408
|
+
// (e.g. the agent resolving a thread) would jump back to Sent even after the
|
|
409
|
+
// user clicked Queued or scrolled up.
|
|
410
|
+
#onlySentComments = false;
|
|
277
411
|
|
|
278
412
|
constructor(
|
|
279
413
|
element?: HTMLElement,
|
|
@@ -299,10 +433,23 @@ export class CommentsPane extends UI.Widget.Widget {
|
|
|
299
433
|
this.#onThreadsChanged,
|
|
300
434
|
this,
|
|
301
435
|
);
|
|
436
|
+
// Re-evaluated on the next render, so that opening the drawer with only
|
|
437
|
+
// sent comments shows them at the top.
|
|
438
|
+
this.#onlySentComments = false;
|
|
302
439
|
this.requestUpdate();
|
|
303
440
|
}
|
|
304
441
|
|
|
442
|
+
/**
|
|
443
|
+
* Lets `UI.Widget` store the list's scroll position when the drawer is hidden
|
|
444
|
+
* and restore it when it is shown again.
|
|
445
|
+
*/
|
|
446
|
+
override elementsToRestoreScrollPositionsFor(): Element[] {
|
|
447
|
+
const {scrollContainer} = this.#viewOutput;
|
|
448
|
+
return scrollContainer ? [this.element, scrollContainer] : [this.element];
|
|
449
|
+
}
|
|
450
|
+
|
|
305
451
|
override willHide(): void {
|
|
452
|
+
this.#scrollingToTab = false;
|
|
306
453
|
this.#commentManager.removeEventListener(
|
|
307
454
|
CommentManager.CommentManager.Events.COMMENT_THREADS_CHANGED,
|
|
308
455
|
this.#onThreadsChanged,
|
|
@@ -311,12 +458,29 @@ export class CommentsPane extends UI.Widget.Widget {
|
|
|
311
458
|
super.willHide();
|
|
312
459
|
}
|
|
313
460
|
|
|
314
|
-
#
|
|
461
|
+
#setActiveTab(tab: Tab): void {
|
|
315
462
|
if (this.#activeTab === tab) {
|
|
316
463
|
return;
|
|
317
464
|
}
|
|
318
465
|
this.#activeTab = tab;
|
|
319
466
|
this.requestUpdate();
|
|
467
|
+
}
|
|
468
|
+
|
|
469
|
+
#handleTabClick = (tab: Tab): void => {
|
|
470
|
+
this.#scrollingToTab = this.#viewOutput.scrollToSection?.(tab, {animate: true}) ?? false;
|
|
471
|
+
this.#setActiveTab(tab);
|
|
472
|
+
};
|
|
473
|
+
|
|
474
|
+
#handleScroll = (): void => {
|
|
475
|
+
if (!this.#scrollingToTab && this.#viewOutput.sectionAtTop) {
|
|
476
|
+
this.#setActiveTab(this.#viewOutput.sectionAtTop());
|
|
477
|
+
}
|
|
478
|
+
};
|
|
479
|
+
|
|
480
|
+
// Fires when a tab-click scroll finishes or the user interrupts it.
|
|
481
|
+
#handleScrollEnd = (): void => {
|
|
482
|
+
this.#scrollingToTab = false;
|
|
483
|
+
this.#handleScroll();
|
|
320
484
|
};
|
|
321
485
|
|
|
322
486
|
#handleClearAll = (): void => {
|
|
@@ -342,44 +506,70 @@ export class CommentsPane extends UI.Widget.Widget {
|
|
|
342
506
|
this.#commentManager.sendQueuedThreads();
|
|
343
507
|
};
|
|
344
508
|
|
|
345
|
-
|
|
346
|
-
|
|
347
|
-
if (this.#
|
|
348
|
-
|
|
349
|
-
} else {
|
|
350
|
-
rawThreads = this.#commentManager.getCommentThreads().filter(thread => thread.status === 'SENT_TO_AGENT' ||
|
|
351
|
-
thread.status === 'RESOLVED');
|
|
509
|
+
#handleAddComment = (): void => {
|
|
510
|
+
const actionRegistry = UI.ActionRegistry.ActionRegistry.instance();
|
|
511
|
+
if (this.#commentManager.isCommentMode() || !actionRegistry.hasAction(TOGGLE_COMMENT_MODE_ACTION_ID)) {
|
|
512
|
+
return;
|
|
352
513
|
}
|
|
514
|
+
void actionRegistry.getAction(TOGGLE_COMMENT_MODE_ACTION_ID).execute();
|
|
515
|
+
};
|
|
353
516
|
|
|
354
|
-
|
|
355
|
-
|
|
356
|
-
|
|
357
|
-
|
|
358
|
-
|
|
359
|
-
|
|
360
|
-
|
|
361
|
-
|
|
362
|
-
|
|
363
|
-
|
|
364
|
-
|
|
365
|
-
|
|
366
|
-
|
|
367
|
-
|
|
517
|
+
async #toViewData(thread: CommentManager.CommentManager.CommentThread): Promise<ThreadViewData> {
|
|
518
|
+
let title = this.#cachedTitles.get(thread.id);
|
|
519
|
+
if (!title) {
|
|
520
|
+
title = await computeCommentTitle(thread.anchor);
|
|
521
|
+
this.#cachedTitles.set(thread.id, title);
|
|
522
|
+
}
|
|
523
|
+
return {
|
|
524
|
+
thread,
|
|
525
|
+
title,
|
|
526
|
+
commentText: thread.comments[0]?.text ?? '',
|
|
527
|
+
};
|
|
528
|
+
}
|
|
529
|
+
|
|
530
|
+
override async performUpdate(signal?: AbortSignal): Promise<void> {
|
|
531
|
+
const allThreads = this.#commentManager.getCommentThreads();
|
|
532
|
+
const queued = allThreads.filter(thread => thread.status === 'ACTIVE');
|
|
533
|
+
const sent = allThreads.filter(thread => thread.status === 'SENT_TO_AGENT' || thread.status === 'RESOLVED');
|
|
534
|
+
|
|
535
|
+
const [queuedThreads, sentThreads] = await Promise.all([
|
|
536
|
+
Promise.all(queued.map(thread => this.#toViewData(thread))),
|
|
537
|
+
Promise.all(sent.map(thread => this.#toViewData(thread))),
|
|
538
|
+
]);
|
|
368
539
|
|
|
369
540
|
if (signal?.aborted) {
|
|
370
541
|
return;
|
|
371
542
|
}
|
|
372
543
|
|
|
544
|
+
// When the list switches to only sent comments (on open, or e.g. after
|
|
545
|
+
// sending the last queued comment), show the sent comments at the top.
|
|
546
|
+
const onlySentComments = queuedThreads.length === 0 && sentThreads.length > 0;
|
|
547
|
+
const showSentComments = onlySentComments && !this.#onlySentComments;
|
|
548
|
+
this.#onlySentComments = onlySentComments;
|
|
549
|
+
if (showSentComments) {
|
|
550
|
+
this.#activeTab = 'sent';
|
|
551
|
+
} else if (sentThreads.length === 0) {
|
|
552
|
+
this.#activeTab = 'queued';
|
|
553
|
+
}
|
|
554
|
+
|
|
373
555
|
const viewInput: ViewInput = {
|
|
374
556
|
activeTab: this.#activeTab,
|
|
375
|
-
|
|
376
|
-
|
|
557
|
+
queuedThreads,
|
|
558
|
+
sentThreads,
|
|
559
|
+
onTabClick: this.#handleTabClick,
|
|
560
|
+
onScroll: this.#handleScroll,
|
|
561
|
+
onScrollEnd: this.#handleScrollEnd,
|
|
377
562
|
onClearAll: this.#handleClearAll,
|
|
378
563
|
onThreadClick: this.#handleThreadClick,
|
|
379
564
|
onDeleteThread: this.#handleDeleteThread,
|
|
380
565
|
onSendToAgent: this.#handleSendToAgent,
|
|
566
|
+
onAddComment: this.#handleAddComment,
|
|
381
567
|
};
|
|
382
568
|
|
|
383
|
-
this.#view(viewInput,
|
|
569
|
+
this.#view(viewInput, this.#viewOutput, this.contentElement);
|
|
570
|
+
|
|
571
|
+
if (showSentComments) {
|
|
572
|
+
this.#viewOutput.scrollToSection?.('sent', {animate: false});
|
|
573
|
+
}
|
|
384
574
|
}
|
|
385
575
|
}
|