chrome-devtools-frontend 1.0.1726686 → 1.0.1730971

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (490) hide show
  1. package/.agents/rules/tests/test-strict-assertions-and-literal-expectations.md +1 -1
  2. package/.agents/rules/tests/test-view-and-presenter-isolation.md +1 -1
  3. package/.agents/rules/ui-and-widgets/ui-accessibility-and-semantic-html.md +1 -1
  4. package/.agents/rules/ui-and-widgets/ui-css-scoping-and-flex-layout.md +2 -2
  5. package/.agents/rules/ui-and-widgets/ui-declarative-child-widget-composition.md +5 -5
  6. package/.agents/rules/ui-and-widgets/ui-lit-declarative-templates-and-directives.md +2 -2
  7. package/.agents/rules/ui-and-widgets/ui-localization-and-uistrings-hygiene.md +2 -2
  8. package/.agents/rules/ui-and-widgets/ui-modern-component-and-encapsulation-standards.md +3 -3
  9. package/.agents/rules/ui-and-widgets/ui-pure-view-and-presenter-separation.md +2 -2
  10. package/.agents/rules/ui-and-widgets/ui-reactive-widget-update-lifecycle.md +2 -2
  11. package/.agents/rules/ui-and-widgets/ui-view-output-and-callback-contracts.md +2 -2
  12. package/.agents/rules/ui-and-widgets/ui-widget-dom-and-listener-lifecycle.md +2 -2
  13. package/.agents/skills/code-review/SKILL.md +63 -12
  14. package/.agents/skills/ui-eng-vision-local-lit-renderer/SKILL.md +38 -10
  15. package/.agents/skills/ui-eng-vision-widget-promoter/SKILL.md +1 -0
  16. package/.agents/skills/ui-widgets/SKILL.md +8 -2
  17. package/.agents/skills/write-ai-eval-test/SKILL.md +106 -0
  18. package/AUTHORS +2 -0
  19. package/DIR_METADATA +1 -2
  20. package/README.md +48 -26
  21. package/config/typescript/tsconfig.base.json +1 -0
  22. package/config/typescript/tsconfig.eslint.json +1 -0
  23. package/docs/contributing/changes.md +25 -0
  24. package/docs/ui_engineering.md +13 -4
  25. package/eslint.config.mjs +323 -41
  26. package/front_end/core/common/Color.ts +7 -7
  27. package/front_end/core/common/ParsedURL.ts +3 -3
  28. package/front_end/core/common/ResolverBase.ts +3 -3
  29. package/front_end/core/common/SegmentedRange.ts +3 -3
  30. package/front_end/core/common/SimpleHistoryManager.ts +14 -14
  31. package/front_end/core/common/Trie.ts +3 -3
  32. package/front_end/core/common/VersionController.ts +7 -7
  33. package/front_end/core/host/InspectorFrontendHost.ts +2 -2
  34. package/front_end/core/host/InspectorFrontendHostAPI.ts +9 -1
  35. package/front_end/core/host/InspectorFrontendHostStub.ts +1 -1
  36. package/front_end/core/host/UserMetrics.ts +4 -0
  37. package/front_end/core/host/UserMetricsEnums.ts +2 -1
  38. package/front_end/core/platform/StringUtilities.ts +54 -13
  39. package/front_end/core/platform/node/HostRuntime.ts +13 -7
  40. package/front_end/core/protocol_client/DevToolsCDPConnection.ts +4 -5
  41. package/front_end/core/root/Runtime.ts +5 -0
  42. package/front_end/core/sdk/AccessibilityModel.ts +5 -5
  43. package/front_end/core/sdk/AnimationModel.ts +17 -19
  44. package/front_end/core/sdk/CPUProfilerModel.ts +3 -3
  45. package/front_end/core/sdk/CPUThrottlingManager.ts +7 -0
  46. package/front_end/core/sdk/CSSMatchedStyles.ts +73 -13
  47. package/front_end/core/sdk/CSSMetadata.ts +7 -7
  48. package/front_end/core/sdk/CSSModel.ts +33 -33
  49. package/front_end/core/sdk/CSSProperty.ts +5 -5
  50. package/front_end/core/sdk/CSSRule.ts +6 -6
  51. package/front_end/core/sdk/CSSStyleSheetHeader.ts +4 -4
  52. package/front_end/core/sdk/Connections.ts +16 -16
  53. package/front_end/core/sdk/ConsoleModel.ts +44 -47
  54. package/front_end/core/sdk/CookieParser.ts +11 -11
  55. package/front_end/core/sdk/EmulationModel.ts +35 -36
  56. package/front_end/core/sdk/EventBreakpointsModel.ts +11 -11
  57. package/front_end/core/sdk/FrameManager.ts +16 -16
  58. package/front_end/core/sdk/IsolateManager.ts +2 -2
  59. package/front_end/core/sdk/IssuesModel.ts +2 -2
  60. package/front_end/core/sdk/OverlayModel.ts +19 -19
  61. package/front_end/core/sdk/PageResourceLoader.ts +14 -16
  62. package/front_end/core/sdk/RemoteObject.ts +9 -9
  63. package/front_end/core/sdk/Resource.ts +2 -2
  64. package/front_end/core/sdk/RuntimeModel.ts +7 -7
  65. package/front_end/core/sdk/Script.ts +6 -6
  66. package/front_end/core/sdk/ServiceWorkerManager.ts +36 -10
  67. package/front_end/core/sdk/SourceMap.ts +18 -20
  68. package/front_end/core/sdk/SourceMapManager.ts +2 -2
  69. package/front_end/core/sdk/TargetManager.ts +2 -2
  70. package/front_end/devtools_compatibility.js +7 -3
  71. package/front_end/entrypoints/inspector_main/InspectorMain.ts +2 -2
  72. package/front_end/entrypoints/node_app/app/NodeConnectionsPanel.ts +203 -115
  73. package/front_end/generated/InspectorBackendCommands.ts +1 -1
  74. package/front_end/generated/SupportedCSSProperties.ts +1 -3
  75. package/front_end/generated/protocol.ts +1 -0
  76. package/front_end/models/ai_assistance/AiAgent2.ts +36 -12
  77. package/front_end/models/ai_assistance/AiConversation.ts +8 -2
  78. package/front_end/models/ai_assistance/agents/AiAgent.ts +137 -62
  79. package/front_end/models/ai_assistance/agents/ExecuteJavascript.ts +2 -2
  80. package/front_end/models/ai_assistance/agents/StylingAgent.snapshot.txt +2 -2
  81. package/front_end/models/ai_assistance/data_formatters/LighthouseFormatter.snapshot.txt +149 -2
  82. package/front_end/models/ai_assistance/data_formatters/LighthouseFormatter.ts +269 -42
  83. package/front_end/models/ai_assistance/tools/ExecuteJavaScript.ts +3 -0
  84. package/front_end/models/ai_assistance/tools/GetLighthouseAudits.ts +9 -0
  85. package/front_end/models/ai_assistance/tools/ResolveDevtoolsNodePath.ts +13 -2
  86. package/front_end/models/ai_assistance/tools/RunLighthouse.ts +23 -7
  87. package/front_end/models/ai_assistance/tools/Tool.ts +7 -5
  88. package/front_end/models/bindings/CSSWorkspaceBinding.ts +22 -24
  89. package/front_end/models/bindings/DebuggerLanguagePlugins.ts +60 -60
  90. package/front_end/models/bindings/DebuggerWorkspaceBinding.ts +24 -24
  91. package/front_end/models/bindings/DefaultScriptMapping.ts +8 -8
  92. package/front_end/models/bindings/FileUtils.ts +13 -13
  93. package/front_end/models/bindings/PresentationConsoleMessageHelper.ts +3 -3
  94. package/front_end/models/bindings/ResourceScriptMapping.ts +23 -23
  95. package/front_end/models/comment_manager/CommentManager.ts +3 -3
  96. package/front_end/models/comment_manager/CommentThread.ts +50 -5
  97. package/front_end/models/cpu_profile/CPUProfileDataModel.ts +14 -14
  98. package/front_end/models/cpu_profile/ProfileTreeModel.ts +4 -4
  99. package/front_end/models/elements/StyleChanges.ts +38 -0
  100. package/front_end/models/emulation/EmulatedDevices.ts +12 -12
  101. package/front_end/models/har/HARFormat.ts +4 -4
  102. package/front_end/models/javascript_metadata/NativeFunctions.ts +5 -1
  103. package/front_end/models/lighthouse/LighthouseReporterTypes.ts +57 -3
  104. package/front_end/models/lighthouse/RunTypes.ts +9 -1
  105. package/front_end/models/logs/LogManager.ts +2 -2
  106. package/front_end/models/persistence/AutomaticFileSystemManager.ts +3 -0
  107. package/front_end/models/persistence/FileSystemWorkspaceBinding.ts +24 -24
  108. package/front_end/models/persistence/IsolatedFileSystemManager.ts +6 -0
  109. package/front_end/models/persistence/NetworkPersistenceManager.ts +8 -3
  110. package/front_end/models/trace/LanternComputationData.ts +37 -11
  111. package/front_end/models/trace/Processor.ts +2 -1
  112. package/front_end/models/trace/extras/TraceTree.ts +36 -10
  113. package/front_end/models/trace/handlers/InitiatorsHandler.ts +27 -34
  114. package/front_end/models/trace/handlers/LayoutShiftsHandler.ts +2 -6
  115. package/front_end/models/trace/handlers/SamplesHandler.ts +9 -6
  116. package/front_end/models/workspace/FileManager.ts +6 -0
  117. package/front_end/panels/accessibility/ARIAAttributesView.ts +4 -4
  118. package/front_end/panels/accessibility/AccessibilityAnnouncementRecordingView.ts +8 -1
  119. package/front_end/panels/accessibility/AccessibilityNodeView.ts +15 -17
  120. package/front_end/panels/accessibility/AccessibilitySubPane.ts +1 -1
  121. package/front_end/panels/ai_assistance/AiAssistancePanel.ts +5 -5
  122. package/front_end/panels/ai_assistance/ExternalHandler.ts +10 -1
  123. package/front_end/panels/ai_assistance/components/ChatMessage.ts +27 -22
  124. package/front_end/panels/ai_assistance/components/DisabledWidget.ts +19 -23
  125. package/front_end/panels/ai_assistance/components/ExploreWidget.ts +2 -2
  126. package/front_end/panels/ai_assistance/components/PermissionPrompt.ts +23 -9
  127. package/front_end/panels/ai_assistance/components/chatInput.css +1 -1
  128. package/front_end/panels/animation/AnimationTimeline.ts +37 -17
  129. package/front_end/panels/animation/animationTimeline.css +19 -3
  130. package/front_end/panels/application/AppManifestView.ts +1 -2
  131. package/front_end/panels/application/ApplicationPanelSidebar.ts +143 -128
  132. package/front_end/panels/application/DOMStorageItemsView.ts +14 -14
  133. package/front_end/panels/application/DeviceBoundSessionsView.ts +10 -13
  134. package/front_end/panels/application/ExtensionStorageItemsView.ts +3 -4
  135. package/front_end/panels/application/IndexedDBViews.ts +8 -4
  136. package/front_end/panels/application/KeyValueStorageItemsView.ts +4 -5
  137. package/front_end/panels/application/PrivateVerificationTokensView.ts +53 -0
  138. package/front_end/panels/application/ServiceWorkerCacheViews.ts +12 -8
  139. package/front_end/panels/application/ServiceWorkersView.ts +1 -2
  140. package/front_end/panels/application/StorageItemsToolbar.ts +3 -3
  141. package/front_end/panels/application/StorageView.ts +2 -2
  142. package/front_end/panels/application/WebMCPView.ts +91 -109
  143. package/front_end/panels/application/application.ts +2 -0
  144. package/front_end/panels/application/components/StorageMetadataView.ts +6 -6
  145. package/front_end/panels/application/preloading/PreloadingView.ts +70 -37
  146. package/front_end/panels/application/preloading/components/MismatchedPreloadingGrid.ts +2 -2
  147. package/front_end/panels/application/preloading/components/PreloadingDisabledInfobar.ts +3 -3
  148. package/front_end/panels/application/preloading/components/PreloadingGrid.ts +12 -0
  149. package/front_end/panels/application/preloading/components/RuleSetDetailsView.ts +10 -11
  150. package/front_end/panels/application/privateVerificationTokensView.css +20 -0
  151. package/front_end/panels/application/serviceWorkersView.css +2 -2
  152. package/front_end/panels/browser_debugger/DOMBreakpointsSidebarPane.ts +24 -24
  153. package/front_end/panels/changes/ChangesSidebar.ts +5 -5
  154. package/front_end/panels/changes/ChangesView.ts +10 -11
  155. package/front_end/panels/comments/CommentsPane.ts +292 -102
  156. package/front_end/panels/comments/commentsPane.css +93 -12
  157. package/front_end/panels/common/CommentThreadWidget.ts +69 -0
  158. package/front_end/panels/common/CommentsOverlayWidget.ts +108 -29
  159. package/front_end/panels/common/CommentsStatusBarPill.ts +17 -6
  160. package/front_end/panels/common/DOMLinkifier.ts +37 -12
  161. package/front_end/panels/common/ExtensionPanel.ts +13 -4
  162. package/front_end/panels/common/ExtensionServer.ts +27 -3
  163. package/front_end/panels/common/PersistenceUtils.ts +3 -3
  164. package/front_end/panels/common/commentThreadWidget.css +25 -1
  165. package/front_end/panels/common/common-meta.ts +10 -0
  166. package/front_end/panels/console/ConsolePinPane.ts +13 -15
  167. package/front_end/panels/console/ConsolePrompt.ts +173 -95
  168. package/front_end/panels/console/ConsoleSidebar.ts +2 -2
  169. package/front_end/panels/console/ConsoleView.ts +75 -79
  170. package/front_end/panels/console/ConsoleViewMessage.ts +52 -4
  171. package/front_end/panels/console/SymbolizedErrorWidget.ts +8 -4
  172. package/front_end/panels/console/consolePrompt.css +1 -1
  173. package/front_end/panels/console/consoleView.css +1 -1
  174. package/front_end/panels/console_counters/WarningErrorCounter.ts +3 -4
  175. package/front_end/panels/coverage/CoverageListView.ts +2 -2
  176. package/front_end/panels/coverage/CoverageView.ts +20 -5
  177. package/front_end/panels/css_overview/CSSOverviewCompletedView.ts +4 -3
  178. package/front_end/panels/css_overview/CSSOverviewPanel.ts +2 -2
  179. package/front_end/panels/css_overview/CSSOverviewProcessingView.ts +2 -2
  180. package/front_end/panels/css_overview/CSSOverviewSidebarPanel.ts +2 -2
  181. package/front_end/panels/css_overview/CSSOverviewStartView.ts +2 -2
  182. package/front_end/panels/css_overview/CSSOverviewUnusedDeclarations.ts +8 -8
  183. package/front_end/panels/developer_resources/DeveloperResourcesListView.ts +2 -3
  184. package/front_end/panels/developer_resources/DeveloperResourcesView.ts +4 -5
  185. package/front_end/panels/elements/AccessibilityTreeUtils.ts +6 -7
  186. package/front_end/panels/elements/CSSValueTraceView.ts +3 -3
  187. package/front_end/panels/elements/ClassesPaneWidget.ts +1 -2
  188. package/front_end/panels/elements/ComputedStyleWidget.ts +15 -14
  189. package/front_end/panels/elements/DOMTreeElementWidget.ts +5 -4
  190. package/front_end/panels/elements/DOMTreeWidget.ts +2 -1
  191. package/front_end/panels/elements/ElementStatePaneWidget.ts +2 -2
  192. package/front_end/panels/elements/ElementsPanel.ts +1 -0
  193. package/front_end/panels/elements/EventListenersWidget.ts +2 -2
  194. package/front_end/panels/elements/LayoutPane.ts +2 -2
  195. package/front_end/panels/elements/PlatformFontsWidget.ts +3 -3
  196. package/front_end/panels/elements/PropertiesWidget.ts +9 -10
  197. package/front_end/panels/elements/PropertyRenderer.ts +72 -11
  198. package/front_end/panels/elements/StandaloneStylesContainer.ts +5 -10
  199. package/front_end/panels/elements/StyleEditorWidget.ts +30 -16
  200. package/front_end/panels/elements/StylePropertiesSection.ts +93 -44
  201. package/front_end/panels/elements/StylePropertyTreeElement.ts +230 -302
  202. package/front_end/panels/elements/StylesContainer.ts +2 -3
  203. package/front_end/panels/elements/StylesSidebarPane.ts +4 -13
  204. package/front_end/panels/elements/components/AccessibilityTreeNode.ts +66 -37
  205. package/front_end/panels/elements/components/CSSHintDetailsView.ts +51 -41
  206. package/front_end/panels/elements/components/CSSPropertyDocsView.ts +75 -65
  207. package/front_end/panels/elements/components/CSSQuery.ts +112 -74
  208. package/front_end/panels/elements/components/CSSVariableValueView.ts +109 -68
  209. package/front_end/panels/elements/components/ComputedStyleProperty.ts +64 -45
  210. package/front_end/panels/elements/components/ElementsTreeExpandButton.ts +35 -28
  211. package/front_end/panels/elements/components/QueryContainer.ts +104 -74
  212. package/front_end/panels/elements/components/accessibilityTreeNode.css +22 -20
  213. package/front_end/panels/elements/components/computedStyleProperty.css +2 -0
  214. package/front_end/panels/elements/components/cssHintDetailsView.css +23 -21
  215. package/front_end/panels/elements/components/cssPropertyDocsView.css +38 -36
  216. package/front_end/panels/elements/components/cssVariableValueView.css +42 -40
  217. package/front_end/panels/elements/components/elementsTreeExpandButton.css +5 -2
  218. package/front_end/panels/elements/components/queryContainer.css +23 -21
  219. package/front_end/panels/elements/stylesSidebarPane.css +3 -3
  220. package/front_end/panels/emulation/DeviceModeToolbar.ts +2 -2
  221. package/front_end/panels/emulation/InspectedPagePlaceholder.ts +2 -2
  222. package/front_end/panels/emulation/MediaQueryInspector.ts +9 -10
  223. package/front_end/panels/emulation/mediaQueryInspector.css +1 -1
  224. package/front_end/panels/event_listeners/EventListenersView.ts +2 -2
  225. package/front_end/panels/issues/AffectedCookiesView.ts +144 -101
  226. package/front_end/panels/issues/AffectedDescendantsWithinSelectElementView.ts +83 -31
  227. package/front_end/panels/issues/AffectedDirectivesView.ts +218 -135
  228. package/front_end/panels/issues/AffectedDocumentsInQuirksModeView.ts +84 -34
  229. package/front_end/panels/issues/AffectedElementsView.ts +86 -23
  230. package/front_end/panels/issues/AffectedLazyLoadImagesView.ts +2 -2
  231. package/front_end/panels/issues/AffectedMetadataAllowedSitesView.ts +2 -2
  232. package/front_end/panels/issues/AffectedPartitioningBlobURLView.ts +36 -11
  233. package/front_end/panels/issues/AffectedSharedArrayBufferIssueDetailsView.ts +135 -58
  234. package/front_end/panels/issues/AffectedSourcesView.ts +49 -28
  235. package/front_end/panels/issues/AffectedTrackingSitesView.ts +3 -4
  236. package/front_end/panels/issues/CorsIssueDetailsView.ts +490 -269
  237. package/front_end/panels/issues/GenericIssueDetailsView.ts +2 -2
  238. package/front_end/panels/issues/IssueKindView.ts +63 -48
  239. package/front_end/panels/issues/IssueView.ts +14 -18
  240. package/front_end/panels/issues/components/ElementsPanelLink.ts +70 -34
  241. package/front_end/panels/issues/components/HideIssuesMenu.ts +56 -32
  242. package/front_end/panels/issues/components/elementsPanelLink.css +10 -6
  243. package/front_end/panels/issues/components/hideIssuesMenu.css +16 -14
  244. package/front_end/panels/issues/issues.ts +2 -0
  245. package/front_end/panels/issues/issuesTree.css +4 -4
  246. package/front_end/panels/lighthouse/LighthouseController.ts +6 -6
  247. package/front_end/panels/lighthouse/LighthouseStatusView.ts +12 -13
  248. package/front_end/panels/lighthouse/lighthouseStartView.css +1 -1
  249. package/front_end/panels/linear_memory_inspector/LinearMemoryInspectorPane.ts +159 -161
  250. package/front_end/panels/linear_memory_inspector/LinearMemoryInspectorView.ts +228 -0
  251. package/front_end/panels/linear_memory_inspector/components/LinearMemoryInspector.ts +32 -41
  252. package/front_end/panels/linear_memory_inspector/components/linearMemoryHighlightChipList.css +2 -2
  253. package/front_end/panels/linear_memory_inspector/linear_memory_inspector.ts +2 -0
  254. package/front_end/panels/media/EventDisplayTable.ts +2 -2
  255. package/front_end/panels/media/MainView.ts +132 -66
  256. package/front_end/panels/media/PlayerDetailView.ts +32 -14
  257. package/front_end/panels/media/PlayerListView.ts +83 -23
  258. package/front_end/panels/media/PlayerPropertiesView.ts +2 -2
  259. package/front_end/panels/media/TickingFlameChart.ts +153 -63
  260. package/front_end/panels/mobile_throttling/NetworkThrottlingSelector.ts +2 -2
  261. package/front_end/panels/mobile_throttling/ThrottlingSettingsTab.ts +615 -464
  262. package/front_end/panels/mobile_throttling/throttlingSettingsTab.css +43 -0
  263. package/front_end/panels/network/EventSourceMessagesView.ts +3 -3
  264. package/front_end/panels/network/NetworkConfigView.ts +6 -2
  265. package/front_end/panels/network/NetworkDataGridNode.ts +2 -1
  266. package/front_end/panels/network/NetworkItemView.ts +27 -26
  267. package/front_end/panels/network/NetworkManageCustomHeadersView.ts +236 -97
  268. package/front_end/panels/network/NetworkOverview.ts +8 -10
  269. package/front_end/panels/network/RequestConditionsDrawer.ts +8 -4
  270. package/front_end/panels/network/RequestDeviceBoundSessionsView.ts +2 -4
  271. package/front_end/panels/network/RequestHTMLView.ts +26 -7
  272. package/front_end/panels/network/RequestHeadersView.ts +2 -2
  273. package/front_end/panels/network/RequestInitiatorView.ts +21 -22
  274. package/front_end/panels/network/RequestPayloadView.ts +2 -16
  275. package/front_end/panels/network/RequestPreviewView.ts +5 -5
  276. package/front_end/panels/network/RequestTimingView.ts +6 -6
  277. package/front_end/panels/network/ResourceDirectSocketChunkView.ts +5 -6
  278. package/front_end/panels/network/ResourceWebSocketFrameView.ts +4 -3
  279. package/front_end/panels/network/ShowMoreDetailsWidget.ts +11 -12
  280. package/front_end/panels/network/SignedExchangeInfoView.ts +2 -2
  281. package/front_end/panels/network/networkLogView.css +2 -2
  282. package/front_end/panels/network/networkManageCustomHeadersView.css +27 -6
  283. package/front_end/panels/network/requestConditionsDrawer.css +1 -1
  284. package/front_end/panels/network/requestInitiatorView.css +5 -3
  285. package/front_end/panels/performance_monitor/PerformanceMonitor.ts +2 -2
  286. package/front_end/panels/profiler/HeapDetachedElementsView.ts +1 -2
  287. package/front_end/panels/profiler/HeapTimelineOverview.ts +77 -15
  288. package/front_end/panels/profiler/IsolateSelector.ts +258 -187
  289. package/front_end/panels/profiler/ProfileLauncherView.ts +7 -29
  290. package/front_end/panels/profiler/profileLauncherView.css +6 -1
  291. package/front_end/panels/protocol_monitor/JSONEditor.ts +4 -5
  292. package/front_end/panels/recorder/ControlButton.ts +1 -1
  293. package/front_end/panels/recorder/RecordingListView.ts +2 -4
  294. package/front_end/panels/recorder/RecordingView.ts +1 -2
  295. package/front_end/panels/recorder/SelectorPicker.ts +2 -4
  296. package/front_end/panels/recorder/StepView.ts +24 -10
  297. package/front_end/panels/recorder/TimelineSection.ts +1 -1
  298. package/front_end/panels/recorder/recordingView.css +1 -1
  299. package/front_end/panels/screencast/ScreencastApp.ts +1 -1
  300. package/front_end/panels/search/SearchResultsPane.ts +11 -12
  301. package/front_end/panels/search/SearchView.ts +8 -10
  302. package/front_end/panels/security/SecurityPanel.ts +1 -8
  303. package/front_end/panels/security/SecurityPanelSidebar.ts +2 -2
  304. package/front_end/panels/security/mainView.css +1 -1
  305. package/front_end/panels/sensors/LocationsSettingsTab.ts +1 -2
  306. package/front_end/panels/settings/AISettingsTab.ts +1 -1
  307. package/front_end/panels/settings/BackendLinkingSettingsTab.ts +34 -20
  308. package/front_end/panels/settings/EditFileSystemView.ts +2 -2
  309. package/front_end/panels/settings/FrameworkIgnoreListSettingsTab.ts +375 -197
  310. package/front_end/panels/settings/KeybindsSettingsTab.ts +570 -414
  311. package/front_end/panels/settings/SettingsScreen.ts +312 -114
  312. package/front_end/panels/settings/WorkspaceSettingsTab.ts +2 -2
  313. package/front_end/panels/settings/aiSettingsTab.css +1 -4
  314. package/front_end/panels/settings/emulation/DevicesSettingsTab.ts +924 -578
  315. package/front_end/panels/settings/emulation/components/UserAgentClientHintsForm.ts +9 -2
  316. package/front_end/panels/settings/emulation/devicesSettingsTab.css +39 -0
  317. package/front_end/panels/settings/frameworkIgnoreListSettingsTab.css +37 -8
  318. package/front_end/panels/settings/settingsScreen.css +0 -24
  319. package/front_end/panels/sources/BreakpointEditDialog.ts +9 -6
  320. package/front_end/panels/sources/BreakpointsView.ts +25 -4
  321. package/front_end/panels/sources/CallStackSidebarPane.ts +7 -1
  322. package/front_end/panels/sources/DebuggerPlugin.ts +1 -0
  323. package/front_end/panels/sources/GoToLineQuickOpen.ts +8 -8
  324. package/front_end/panels/sources/NavigatorView.ts +521 -439
  325. package/front_end/panels/sources/PersistenceActions.ts +11 -12
  326. package/front_end/panels/sources/ProfilePlugin.ts +28 -17
  327. package/front_end/panels/sources/ScopeChainSidebarPane.ts +3 -4
  328. package/front_end/panels/sources/SourcesNavigator.ts +9 -9
  329. package/front_end/panels/sources/SourcesPanel.ts +2 -2
  330. package/front_end/panels/sources/SourcesView.ts +3 -3
  331. package/front_end/panels/sources/ThreadsSidebarPane.ts +2 -2
  332. package/front_end/panels/sources/WatchExpressionsSidebarPane.ts +2 -2
  333. package/front_end/panels/sources/components/HeadersView.ts +1 -2
  334. package/front_end/panels/timeline/CompatibilityTracksAppender.ts +5 -6
  335. package/front_end/panels/timeline/EventsTimelineTreeView.ts +73 -34
  336. package/front_end/panels/timeline/IsolateSelector.ts +25 -37
  337. package/front_end/panels/timeline/StatusDialog.ts +5 -7
  338. package/front_end/panels/timeline/ThirdPartyTreeView.ts +10 -13
  339. package/front_end/panels/timeline/TimelineDetailsView.ts +40 -21
  340. package/front_end/panels/timeline/TimelineEventOverview.ts +130 -34
  341. package/front_end/panels/timeline/TimelineFlameChartNetworkDataProvider.ts +1 -1
  342. package/front_end/panels/timeline/TimelineMiniMap.ts +255 -103
  343. package/front_end/panels/timeline/TimelinePaintProfilerView.ts +19 -11
  344. package/front_end/panels/timeline/TimelinePanel.ts +1 -0
  345. package/front_end/panels/timeline/TimelineSelectorStatsView.ts +11 -12
  346. package/front_end/panels/timeline/TimelineTreeView.ts +240 -122
  347. package/front_end/panels/timeline/TimelineUIUtils.ts +12 -0
  348. package/front_end/panels/timeline/components/BreadcrumbsUI.ts +5 -4
  349. package/front_end/panels/timeline/components/DetailsView.ts +97 -65
  350. package/front_end/panels/timeline/components/LayoutShiftDetails.ts +2 -2
  351. package/front_end/panels/timeline/components/MetricCard.ts +2 -2
  352. package/front_end/panels/timeline/components/NetworkRequestDetails.ts +11 -12
  353. package/front_end/panels/timeline/components/NetworkTrackWidget.ts +57 -50
  354. package/front_end/panels/timeline/components/RelatedInsightChips.ts +2 -2
  355. package/front_end/panels/timeline/components/Sidebar.ts +161 -109
  356. package/front_end/panels/timeline/components/SidebarAnnotationsTab.ts +33 -12
  357. package/front_end/panels/timeline/components/SidebarInsightsTab.ts +3 -0
  358. package/front_end/panels/timeline/components/insights/LCPDiscovery.ts +11 -11
  359. package/front_end/panels/timeline/components/insights/SlowCSSSelector.ts +6 -7
  360. package/front_end/panels/timeline/components/networkTrackWidget.css +24 -22
  361. package/front_end/panels/timeline/components/sidebarInsightsTab.css +1 -1
  362. package/front_end/panels/timeline/overlays/components/TimespanBreakdownOverlay.ts +15 -10
  363. package/front_end/panels/timeline/overlays/components/entryLabelOverlay.css +1 -1
  364. package/front_end/panels/timeline/timelinePanel.css +5 -0
  365. package/front_end/panels/timeline/timelineStatusDialog.css +1 -1
  366. package/front_end/panels/web_audio/WebAudioView.ts +2 -2
  367. package/front_end/third_party/chromium/README.chromium +1 -1
  368. package/front_end/third_party/legacy-javascript/README.chromium +2 -2
  369. package/front_end/third_party/legacy-javascript/lib/legacy-javascript.js +2 -2
  370. package/front_end/third_party/legacy-javascript/package.json +1 -1
  371. package/front_end/third_party/lighthouse/README.chromium +2 -2
  372. package/front_end/third_party/lighthouse/lighthouse-dt-bundle.js +1983 -2022
  373. package/front_end/third_party/lighthouse/locales/ar-XB.json +157 -142
  374. package/front_end/third_party/lighthouse/locales/ar.json +157 -142
  375. package/front_end/third_party/lighthouse/locales/bg.json +154 -139
  376. package/front_end/third_party/lighthouse/locales/ca.json +157 -142
  377. package/front_end/third_party/lighthouse/locales/cs.json +148 -133
  378. package/front_end/third_party/lighthouse/locales/da.json +153 -138
  379. package/front_end/third_party/lighthouse/locales/de.json +152 -137
  380. package/front_end/third_party/lighthouse/locales/el.json +153 -138
  381. package/front_end/third_party/lighthouse/locales/en-GB.json +160 -145
  382. package/front_end/third_party/lighthouse/locales/en-US.json +239 -218
  383. package/front_end/third_party/lighthouse/locales/en-XL.json +239 -218
  384. package/front_end/third_party/lighthouse/locales/es-419.json +150 -135
  385. package/front_end/third_party/lighthouse/locales/es.json +149 -134
  386. package/front_end/third_party/lighthouse/locales/fi.json +151 -136
  387. package/front_end/third_party/lighthouse/locales/fil.json +154 -139
  388. package/front_end/third_party/lighthouse/locales/fr.json +150 -135
  389. package/front_end/third_party/lighthouse/locales/he.json +160 -145
  390. package/front_end/third_party/lighthouse/locales/hi.json +156 -141
  391. package/front_end/third_party/lighthouse/locales/hr.json +154 -139
  392. package/front_end/third_party/lighthouse/locales/hu.json +111 -96
  393. package/front_end/third_party/lighthouse/locales/id.json +153 -138
  394. package/front_end/third_party/lighthouse/locales/it.json +153 -138
  395. package/front_end/third_party/lighthouse/locales/ja.json +150 -135
  396. package/front_end/third_party/lighthouse/locales/ko.json +42 -27
  397. package/front_end/third_party/lighthouse/locales/lt.json +152 -137
  398. package/front_end/third_party/lighthouse/locales/lv.json +93 -78
  399. package/front_end/third_party/lighthouse/locales/nl.json +149 -134
  400. package/front_end/third_party/lighthouse/locales/no.json +152 -137
  401. package/front_end/third_party/lighthouse/locales/pl.json +153 -138
  402. package/front_end/third_party/lighthouse/locales/pt-PT.json +152 -137
  403. package/front_end/third_party/lighthouse/locales/pt.json +157 -142
  404. package/front_end/third_party/lighthouse/locales/ro.json +149 -134
  405. package/front_end/third_party/lighthouse/locales/ru.json +76 -61
  406. package/front_end/third_party/lighthouse/locales/sk.json +153 -138
  407. package/front_end/third_party/lighthouse/locales/sl.json +149 -134
  408. package/front_end/third_party/lighthouse/locales/sr-Latn.json +151 -136
  409. package/front_end/third_party/lighthouse/locales/sr.json +151 -136
  410. package/front_end/third_party/lighthouse/locales/sv.json +152 -137
  411. package/front_end/third_party/lighthouse/locales/ta.json +156 -141
  412. package/front_end/third_party/lighthouse/locales/te.json +157 -142
  413. package/front_end/third_party/lighthouse/locales/th.json +111 -96
  414. package/front_end/third_party/lighthouse/locales/tr.json +153 -138
  415. package/front_end/third_party/lighthouse/locales/uk.json +149 -134
  416. package/front_end/third_party/lighthouse/locales/vi.json +162 -147
  417. package/front_end/third_party/lighthouse/locales/zh-HK.json +150 -135
  418. package/front_end/third_party/lighthouse/locales/zh-TW.json +154 -139
  419. package/front_end/third_party/lighthouse/locales/zh.json +152 -137
  420. package/front_end/third_party/lighthouse/report/bundle.d.ts +9 -8
  421. package/front_end/third_party/lighthouse/report/bundle.js +10 -10
  422. package/front_end/third_party/lighthouse/report-assets/report-generator.mjs +2 -7
  423. package/front_end/tsconfig.compatibility.json +1 -0
  424. package/front_end/tsconfig.json +3 -2
  425. package/front_end/ui/components/dialogs/TypeToAllowDialog.ts +0 -2
  426. package/front_end/ui/components/dialogs/typeToAllowDialog.css +0 -4
  427. package/front_end/ui/components/icon_button/fileSourceIcon.css +1 -1
  428. package/front_end/ui/components/input/textInput.css +1 -1
  429. package/front_end/ui/components/lists/List.ts +26 -14
  430. package/front_end/ui/components/menus/menus.ts +0 -2
  431. package/front_end/ui/components/suggestion_input/SuggestionInput.ts +351 -138
  432. package/front_end/ui/components/survey_link/surveyLink.css +3 -3
  433. package/front_end/ui/components/switch/switch.css +6 -6
  434. package/front_end/ui/components/text_editor/AiCodeCompletionTeaser.ts +2 -3
  435. package/front_end/ui/components/text_editor/TextEditor.ts +1 -1
  436. package/front_end/ui/components/tooltips/Tooltip.ts +53 -4
  437. package/front_end/ui/components/tree_outline/treeOutline.css +7 -7
  438. package/front_end/ui/helpers/OpenInNewTab.ts +8 -3
  439. package/front_end/ui/legacy/EmptyWidget.ts +4 -4
  440. package/front_end/ui/legacy/ForwardedInputEventHandler.ts +2 -2
  441. package/front_end/ui/legacy/GlassPane.ts +1 -1
  442. package/front_end/ui/legacy/KeyboardShortcut.ts +7 -7
  443. package/front_end/ui/legacy/RemoteDebuggingTerminatedScreen.ts +2 -2
  444. package/front_end/ui/legacy/TabbedPane.ts +198 -66
  445. package/front_end/ui/legacy/TargetCrashedScreen.ts +2 -2
  446. package/front_end/ui/legacy/UIUtils.ts +71 -68
  447. package/front_end/ui/legacy/View.ts +7 -4
  448. package/front_end/ui/legacy/ViewManager.ts +49 -37
  449. package/front_end/ui/legacy/Widget.ts +32 -12
  450. package/front_end/ui/legacy/components/cookie_table/CookiesTable.ts +2 -3
  451. package/front_end/ui/legacy/components/inline_editor/AnimationTimingUI.ts +8 -8
  452. package/front_end/ui/legacy/components/inline_editor/BezierUI.ts +8 -9
  453. package/front_end/ui/legacy/components/inline_editor/LinkSwatch.ts +2 -2
  454. package/front_end/ui/legacy/components/inline_editor/cssAngleEditor.css +1 -1
  455. package/front_end/ui/legacy/components/inline_editor/cssAngleSwatch.css +1 -1
  456. package/front_end/ui/legacy/components/object_ui/ObjectPropertiesSection.ts +45 -11
  457. package/front_end/ui/legacy/components/object_ui/RemoteObjectPreviewFormatter.ts +10 -12
  458. package/front_end/ui/legacy/components/perf_ui/ChartViewport.ts +102 -29
  459. package/front_end/ui/legacy/components/perf_ui/FlameChart.ts +148 -122
  460. package/front_end/ui/legacy/components/perf_ui/TimelineOverviewPane.ts +20 -14
  461. package/front_end/ui/legacy/components/quick_open/filteredListWidget.css +1 -1
  462. package/front_end/ui/legacy/components/source_frame/FontView.ts +29 -5
  463. package/front_end/ui/legacy/components/source_frame/ImageView.ts +79 -12
  464. package/front_end/ui/legacy/components/source_frame/JSONView.ts +20 -2
  465. package/front_end/ui/legacy/components/source_frame/PreviewFactory.ts +2 -2
  466. package/front_end/ui/legacy/components/source_frame/StreamingContentHexView.ts +6 -10
  467. package/front_end/ui/legacy/components/source_frame/XMLView.ts +11 -11
  468. package/front_end/ui/legacy/components/source_frame/fontView.css +7 -0
  469. package/front_end/ui/legacy/components/source_frame/imageView.css +7 -0
  470. package/front_end/ui/legacy/components/utils/JSPresentationUtils.ts +14 -3
  471. package/front_end/ui/legacy/components/utils/Linkifier.ts +126 -2
  472. package/front_end/ui/legacy/emptyWidget.css +2 -1
  473. package/front_end/ui/legacy/inspectorCommon.css +3 -3
  474. package/front_end/ui/legacy/smallBubble.css +1 -1
  475. package/front_end/ui/legacy/tabbedPane.css +6 -0
  476. package/front_end/ui/lit/Directives.ts +35 -18
  477. package/front_end/ui/lit/lit.ts +0 -2
  478. package/front_end/ui/lit/render.ts +0 -7
  479. package/front_end/ui/visual_logging/KnownContextValues.ts +5 -0
  480. package/package.json +1 -1
  481. package/vpython.toml +8 -0
  482. package/vpython.toml.uv.lock +3 -0
  483. package/.agents/skills/review-models-core/SKILL.md +0 -73
  484. package/.agents/skills/review-tests/SKILL.md +0 -67
  485. package/.agents/skills/review-ui-widgets/SKILL.md +0 -115
  486. package/front_end/generated/ARIAProperties.ts +0 -2686
  487. package/front_end/ui/components/menus/README.md +0 -119
  488. package/front_end/ui/components/menus/SelectMenu.ts +0 -473
  489. package/front_end/ui/components/menus/selectMenu.css +0 -54
  490. package/front_end/ui/components/menus/selectMenuButton.css +0 -108
@@ -11,7 +11,7 @@ import * as UI from '../../ui/legacy/legacy.js';
11
11
  import {Directives, html, render} from '../../ui/lit/lit.js';
12
12
  import * as VisualLogging from '../../ui/visual_logging/visual_logging.js';
13
13
 
14
- import type {MainView, TriggerDispatcher} from './MainView.js';
14
+ import type {MainView, PlayerData, TriggerDispatcher} from './MainView.js';
15
15
  import type {PlayerEvent} from './MediaModel.js';
16
16
  import playerListViewStyles from './playerListView.css.js';
17
17
  import {PlayerPropertyKeys} from './PlayerPropertiesView.js';
@@ -55,7 +55,7 @@ export interface ViewInput {
55
55
  onPlayerClick: (playerID: string) => void;
56
56
  onPlayerContextMenu: (playerID: string, event: Event) => void;
57
57
  }
58
- export type View = (input: ViewInput, output: object, target: HTMLElement) => void;
58
+ export type View = (input: ViewInput, output: undefined, target: HTMLElement) => void;
59
59
 
60
60
  const DEFAULT_VIEW: View = (input, _output, target) => {
61
61
  // clang-format off
@@ -106,31 +106,88 @@ export class PlayerListView extends UI.Widget.VBox implements TriggerDispatcher
106
106
  #view: View;
107
107
  private readonly playerStatuses: Map<string, PlayerStatus>;
108
108
  private readonly playerEntriesWithHostnameFrameTitle: Set<string>;
109
- private readonly mainContainer: MainView;
109
+ private readonly mainContainer?: MainView;
110
110
  private currentlySelectedPlayerID: string|null;
111
-
112
- constructor(mainContainer: MainView, view: View = DEFAULT_VIEW) {
113
- super({useShadowDom: true});
111
+ readonly #processedEventCounts = new Map<string, number>();
112
+ #onSelectPlayer?: (playerID: string) => void;
113
+ #onHidePlayer?: (playerID: string) => void;
114
+ #onHideOtherPlayers?: (playerID: string) => void;
115
+ #onSavePlayerInfo?: (playerID: string) => void;
116
+ readonly #boundSelectPlayer = this.selectPlayer.bind(this);
117
+ readonly #boundRightClickPlayer = this.rightClickPlayer.bind(this);
118
+
119
+ constructor(mainContainerOrElement?: MainView|HTMLElement, view: View = DEFAULT_VIEW) {
120
+ const element = mainContainerOrElement instanceof HTMLElement ? mainContainerOrElement : undefined;
121
+ super(element, {useShadowDom: true});
114
122
  this.#view = view;
123
+ this.setMinimumSize(100, 25);
115
124
 
116
125
  this.playerStatuses = new Map();
117
126
  this.playerEntriesWithHostnameFrameTitle = new Set();
118
127
 
119
128
  // Container where new panels can be added based on clicks.
120
- this.mainContainer = mainContainer;
129
+ if (mainContainerOrElement && !(mainContainerOrElement instanceof HTMLElement)) {
130
+ this.mainContainer = mainContainerOrElement;
131
+ }
121
132
 
122
133
  this.currentlySelectedPlayerID = null;
123
134
  this.requestUpdate();
124
135
  }
125
136
 
137
+ set players(players: Map<string, PlayerData>) {
138
+ for (const playerID of Array.from(this.playerStatuses.keys())) {
139
+ if (!players.has(playerID)) {
140
+ this.deletePlayer(playerID);
141
+ this.#processedEventCounts.delete(playerID);
142
+ }
143
+ }
144
+ for (const [playerID, data] of players) {
145
+ if (!this.playerStatuses.has(playerID)) {
146
+ this.addMediaElementItem(playerID);
147
+ }
148
+ for (const [name, value] of data.properties) {
149
+ this.onProperty(playerID, {name, value});
150
+ }
151
+ const prevCount = this.#processedEventCounts.get(playerID) ?? 0;
152
+ for (let i = prevCount; i < data.events.length; i++) {
153
+ this.onEvent(playerID, data.events[i]);
154
+ }
155
+ this.#processedEventCounts.set(playerID, data.events.length);
156
+ }
157
+ }
158
+
159
+ set selectedPlayerID(playerID: string|null) {
160
+ if (this.currentlySelectedPlayerID === playerID) {
161
+ return;
162
+ }
163
+ this.currentlySelectedPlayerID = playerID;
164
+ this.requestUpdate();
165
+ }
166
+
167
+ set onSelectPlayer(callback: ((playerID: string) => void)|undefined) {
168
+ this.#onSelectPlayer = callback;
169
+ }
170
+
171
+ set onHidePlayer(callback: ((playerID: string) => void)|undefined) {
172
+ this.#onHidePlayer = callback;
173
+ }
174
+
175
+ set onHideOtherPlayers(callback: ((playerID: string) => void)|undefined) {
176
+ this.#onHideOtherPlayers = callback;
177
+ }
178
+
179
+ set onSavePlayerInfo(callback: ((playerID: string) => void)|undefined) {
180
+ this.#onSavePlayerInfo = callback;
181
+ }
182
+
126
183
  override performUpdate(): void {
127
184
  const input: ViewInput = {
128
185
  players: Array.from(this.playerStatuses.values()),
129
186
  selectedPlayerID: this.currentlySelectedPlayerID,
130
- onPlayerClick: this.selectPlayer.bind(this),
131
- onPlayerContextMenu: this.rightClickPlayer.bind(this),
187
+ onPlayerClick: this.#boundSelectPlayer,
188
+ onPlayerContextMenu: this.#boundRightClickPlayer,
132
189
  };
133
- this.#view(input, {}, this.contentElement);
190
+ this.#view(input, undefined, this.contentElement);
134
191
  }
135
192
 
136
193
  selectPlayerById(playerID: string): void {
@@ -140,23 +197,26 @@ export class PlayerListView extends UI.Widget.VBox implements TriggerDispatcher
140
197
  }
141
198
 
142
199
  private selectPlayer(playerID: string): void {
143
- this.mainContainer.renderMainPanel(playerID);
200
+ this.mainContainer?.renderMainPanel(playerID);
201
+ this.#onSelectPlayer?.(playerID);
144
202
  this.currentlySelectedPlayerID = playerID;
145
203
  this.requestUpdate();
146
204
  }
147
205
 
148
206
  private rightClickPlayer(playerID: string, event: Event): void {
149
207
  const contextMenu = new UI.ContextMenu.ContextMenu(event);
150
- contextMenu.headerSection().appendItem(
151
- i18nString(UIStrings.hidePlayer), this.mainContainer.markPlayerForDeletion.bind(this.mainContainer, playerID),
152
- {jslogContext: 'hide-player'});
153
- contextMenu.headerSection().appendItem(
154
- i18nString(UIStrings.hideAllOthers),
155
- this.mainContainer.markOtherPlayersForDeletion.bind(this.mainContainer, playerID),
156
- {jslogContext: 'hide-all-others'});
157
- contextMenu.headerSection().appendItem(
158
- i18nString(UIStrings.savePlayerInfo), this.mainContainer.exportPlayerData.bind(this.mainContainer, playerID),
159
- {jslogContext: 'save-player-info'});
208
+ contextMenu.headerSection().appendItem(i18nString(UIStrings.hidePlayer), () => {
209
+ this.mainContainer?.markPlayerForDeletion(playerID);
210
+ this.#onHidePlayer?.(playerID);
211
+ }, {jslogContext: 'hide-player'});
212
+ contextMenu.headerSection().appendItem(i18nString(UIStrings.hideAllOthers), () => {
213
+ this.mainContainer?.markOtherPlayersForDeletion(playerID);
214
+ this.#onHideOtherPlayers?.(playerID);
215
+ }, {jslogContext: 'hide-all-others'});
216
+ contextMenu.headerSection().appendItem(i18nString(UIStrings.savePlayerInfo), () => {
217
+ this.mainContainer?.exportPlayerData(playerID);
218
+ this.#onSavePlayerInfo?.(playerID);
219
+ }, {jslogContext: 'save-player-info'});
160
220
  void contextMenu.show();
161
221
  }
162
222
 
@@ -204,8 +264,8 @@ export class PlayerListView extends UI.Widget.VBox implements TriggerDispatcher
204
264
  }
205
265
  }
206
266
 
207
- private formatAndEvaluate(
208
- playerID: string, func: (...args: any[]) => unknown, candidate: string, min: number, max: number): void {
267
+ private formatAndEvaluate(playerID: string, func: (...args: any[]) => unknown, candidate: string, min: number,
268
+ max: number): void {
209
269
  if (candidate.length <= min) {
210
270
  return;
211
271
  }
@@ -325,7 +325,7 @@ const {widget} = UI.Widget;
325
325
  interface ViewInput {
326
326
  properties: Record<PlayerPropertyKeys, Property>;
327
327
  }
328
- type View = (input: ViewInput, output: object, target: HTMLElement) => void;
328
+ type View = (input: ViewInput, output: undefined, target: HTMLElement) => void;
329
329
  export const DEFAULT_VIEW: View = (input, output, target) => {
330
330
  function propertyTitle(type: PlayerPropertyKeys): Platform.UIString.LocalizedString {
331
331
  switch (type) {
@@ -540,6 +540,6 @@ export class PlayerPropertiesView extends UI.Widget.VBox {
540
540
  }
541
541
 
542
542
  override performUpdate(): void {
543
- this.#view(this, {}, this.contentElement);
543
+ this.#view(this, undefined, this.contentElement);
544
544
  }
545
545
  }
@@ -1,16 +1,46 @@
1
1
  // Copyright 2020 The Chromium Authors
2
2
  // Use of this source code is governed by a BSD-style license that can be
3
3
  // found in the LICENSE file.
4
- /* eslint-disable @devtools/no-imperative-dom-api */
5
-
6
4
  import * as Common from '../../core/common/common.js';
7
5
  import * as Host from '../../core/host/host.js';
6
+ import * as i18n from '../../core/i18n/i18n.js';
8
7
  import * as PerfUI from '../../ui/legacy/components/perf_ui/perf_ui.js';
9
8
  import * as UI from '../../ui/legacy/legacy.js';
10
9
  import * as ThemeSupport from '../../ui/legacy/theme_support/theme_support.js';
10
+ import {html, render, type TemplateResult} from '../../ui/lit/lit.js';
11
11
 
12
12
  import {Bounds, formatMillisecondsToSeconds} from './TickingFlameChartHelpers.js';
13
13
 
14
+ const UIStrings = {
15
+ /**
16
+ * @description Name of an event shown in the hover popover of the media
17
+ * panel timeline.
18
+ * @example {Play} PH1
19
+ */
20
+ name: 'Name: {PH1}',
21
+ /**
22
+ * @description Duration of an event shown in the hover popover of the media
23
+ * panel timeline, given as a start time and an end time in seconds.
24
+ * @example {1.00s} PH1
25
+ * @example {2.50s} PH2
26
+ */
27
+ duration: 'Duration: {PH1} - {PH2}',
28
+ /**
29
+ * @description Duration of an event that is still ongoing, shown in the
30
+ * hover popover of the media panel timeline.
31
+ * @example {1.00s} PH1
32
+ */
33
+ durationLive: 'Duration: {PH1} - LIVE!',
34
+ /**
35
+ * @description Time of an instantaneous event shown in the hover popover of
36
+ * the media panel timeline.
37
+ * @example {1.00s} PH1
38
+ */
39
+ time: 'Time: {PH1}',
40
+ } as const;
41
+ const str_ = i18n.i18n.registerUIStrings('panels/media/TickingFlameChart.ts', UIStrings);
42
+ const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
43
+
14
44
  const defaultFont = '11px ' + Host.Platform.fontFamily();
15
45
  function getGroupDefaultTextColor(): string {
16
46
  return ThemeSupport.ThemeSupport.instance().getComputedValue('--sys-color-on-surface');
@@ -57,6 +87,30 @@ export interface EventProperties {
57
87
  color?: string;
58
88
  }
59
89
 
90
+ export interface EventPopoverInput {
91
+ title: string;
92
+ startTimeReadable: string;
93
+ live: boolean;
94
+ durationReadable?: string;
95
+ }
96
+
97
+ /**
98
+ * Renders the hover popover contents for an event on the timeline.
99
+ */
100
+ export function renderEventPopover(input: EventPopoverInput): TemplateResult {
101
+ // clang-format off
102
+ return html`
103
+ <span>${i18nString(UIStrings.name, {PH1: input.title})}</span>
104
+ <br>
105
+ ${input.live ?
106
+ html`<span>${i18nString(UIStrings.durationLive, {PH1: input.startTimeReadable})}</span>` :
107
+ input.durationReadable !== undefined ?
108
+ html`<span>${i18nString(UIStrings.duration, {PH1: input.startTimeReadable, PH2: input.durationReadable})}</span>` :
109
+ html`<span>${i18nString(UIStrings.time, {PH1: input.startTimeReadable})}</span>`}
110
+ `;
111
+ // clang-format on
112
+ }
113
+
60
114
  /**
61
115
  * Wrapper class for each event displayed on the timeline.
62
116
  */
@@ -71,10 +125,9 @@ export class Event {
71
125
  #color: string;
72
126
  #fontColor: string;
73
127
 
74
- constructor(
75
- timelineData: PerfUI.FlameChart.FlameChartTimelineData, eventHandlers: EventHandlers,
76
- eventProperties: EventProperties|
77
- undefined = {color: undefined, duration: undefined, level: 0, name: '', startTime: 0}) {
128
+ constructor(timelineData: PerfUI.FlameChart.FlameChartTimelineData, eventHandlers: EventHandlers,
129
+ eventProperties: EventProperties|
130
+ undefined = {color: undefined, duration: undefined, level: 0, name: '', startTime: 0}) {
78
131
  // These allow the event to privately change it's own data in the timeline.
79
132
  this.timelineData = timelineData;
80
133
  this.setLive = eventHandlers.setLive;
@@ -103,21 +156,19 @@ export class Event {
103
156
  }
104
157
 
105
158
  /**
106
- * Render hovertext into the |htmlElement|
159
+ * The data shown in the hover popover for this event.
107
160
  */
108
- decorate(htmlElement: HTMLElement): void {
109
- htmlElement.createChild('span').textContent = `Name: ${this.title}`;
110
- htmlElement.createChild('br');
111
-
161
+ popoverInput(): EventPopoverInput {
112
162
  const startTimeReadable = formatMillisecondsToSeconds(this.startTime, 2);
113
- if (this.#live) {
114
- htmlElement.createChild('span').textContent = `Duration: ${startTimeReadable} - LIVE!`;
115
- } else if (!isNaN(this.duration)) {
116
- const durationReadable = formatMillisecondsToSeconds(this.duration + this.startTime, 2);
117
- htmlElement.createChild('span').textContent = `Duration: ${startTimeReadable} - ${durationReadable}`;
118
- } else {
119
- htmlElement.createChild('span').textContent = `Time: ${startTimeReadable}`;
120
- }
163
+ const durationReadable = !this.#live && !isNaN(this.duration) ?
164
+ formatMillisecondsToSeconds(this.duration + this.startTime, 2) :
165
+ undefined;
166
+ return {
167
+ title: this.title,
168
+ startTimeReadable,
169
+ live: this.#live,
170
+ durationReadable,
171
+ };
121
172
  }
122
173
 
123
174
  /**
@@ -174,6 +225,61 @@ export class Event {
174
225
  }
175
226
  }
176
227
 
228
+ class FlameChartWidget extends PerfUI.FlameChart.FlameChart {
229
+ #onScroll?: (scrollTickCount: number, scrollPositionRatio: number) => void;
230
+
231
+ constructor(element?: HTMLElement) {
232
+ super(new TickingFlameChartDataProvider(new Bounds(0, 1000, 30000, 1000), () => {}),
233
+ new TickingFlameChartDelegate(), {}, element);
234
+ this.disableRangeSelection();
235
+ this.bindCanvasEvent('wheel', e => {
236
+ const wheelEvent = e as WheelEvent;
237
+ // TODO: is this a good divisor? does it account for high precision scroll wheels?
238
+ // low precision scroll wheels?
239
+ const scrollTickCount = Math.round(wheelEvent.deltaY / 50);
240
+ const scrollPositionRatio = wheelEvent.offsetX / (wheelEvent.srcElement as HTMLElement).clientWidth;
241
+ this.#onScroll?.(scrollTickCount, scrollPositionRatio);
242
+ });
243
+ }
244
+
245
+ set provider(provider: PerfUI.FlameChart.FlameChartDataProvider) {
246
+ this.setDataProvider(provider);
247
+ }
248
+
249
+ set chartDelegate(delegate: PerfUI.FlameChart.FlameChartDelegate) {
250
+ this.setDelegate(delegate);
251
+ }
252
+
253
+ set onScroll(onScroll: (scrollTickCount: number, scrollPositionRatio: number) => void) {
254
+ this.#onScroll = onScroll;
255
+ }
256
+ }
257
+
258
+ export interface TickingFlameChartViewInput {
259
+ dataProvider: PerfUI.FlameChart.FlameChartDataProvider;
260
+ delegate: PerfUI.FlameChart.FlameChartDelegate;
261
+ windowTimes: {low: number, high: number};
262
+ onScroll: (scrollTickCount: number, scrollPositionRatio: number) => void;
263
+ }
264
+
265
+ export type TickingFlameChartView = (input: TickingFlameChartViewInput, output: undefined, target: HTMLElement) => void;
266
+
267
+ export const DEFAULT_VIEW: TickingFlameChartView = (input, _output, target) => {
268
+ // clang-format off
269
+ render(html`
270
+ <devtools-widget
271
+ class="flex-auto vbox"
272
+ ${UI.Widget.widget(FlameChartWidget, {
273
+ provider: input.dataProvider,
274
+ chartDelegate: input.delegate,
275
+ windowTimes: {min: input.windowTimes.low, max: input.windowTimes.high, animate: true},
276
+ onScroll: input.onScroll,
277
+ })}
278
+ ></devtools-widget>
279
+ `, target);
280
+ // clang-format on
281
+ };
282
+
177
283
  export class TickingFlameChart extends UI.Widget.VBox {
178
284
  private intervalTimer: number;
179
285
  private lastTimestamp: number;
@@ -183,12 +289,13 @@ export class TickingFlameChart extends UI.Widget.VBox {
183
289
  private readonly bounds: Bounds;
184
290
  private readonly dataProvider: TickingFlameChartDataProvider;
185
291
  private readonly delegate: TickingFlameChartDelegate;
186
- private readonly chartGroupExpansionSetting: Common.Settings.Setting<Object>;
187
- private readonly chart: PerfUI.FlameChart.FlameChart;
188
292
  private stoppedPermanently?: boolean;
293
+ readonly #view: TickingFlameChartView;
294
+ readonly #boundOnScroll = this.onScroll.bind(this);
189
295
 
190
- constructor() {
191
- super();
296
+ constructor(element?: HTMLElement, view: TickingFlameChartView = DEFAULT_VIEW) {
297
+ super(element);
298
+ this.#view = view;
192
299
 
193
300
  // set to update once per second _while the tab is active_
194
301
  this.intervalTimer = 0;
@@ -207,26 +314,17 @@ export class TickingFlameChart extends UI.Widget.VBox {
207
314
  // Delegate doesn't do much for now.
208
315
  this.delegate = new TickingFlameChartDelegate();
209
316
 
210
- // Chart settings.
211
- this.chartGroupExpansionSetting =
212
- Common.Settings.Settings.instance().createSetting('media-flame-chart-group-expansion', {});
213
-
214
- // Create the chart.
215
- this.chart =
216
- // TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration
217
- // @ts-expect-error
218
- new PerfUI.FlameChart.FlameChart(this.dataProvider, this.delegate, this.chartGroupExpansionSetting);
219
-
220
- // TODO: needs to have support in the delegate for supporting this.
221
- this.chart.disableRangeSelection();
222
-
223
- // Scrolling should change the current bounds, and repaint the chart.
224
- this.chart.bindCanvasEvent('wheel', e => {
225
- this.onScroll(e as WheelEvent);
226
- });
317
+ this.performUpdate();
318
+ }
227
319
 
228
- // Add the chart.
229
- this.chart.show(this.contentElement);
320
+ override performUpdate(): void {
321
+ this.#view({
322
+ dataProvider: this.dataProvider,
323
+ delegate: this.delegate,
324
+ windowTimes: {low: this.bounds.low, high: this.bounds.high},
325
+ onScroll: this.#boundOnScroll,
326
+ },
327
+ undefined, this.contentElement);
230
328
  }
231
329
 
232
330
  /**
@@ -268,11 +366,7 @@ export class TickingFlameChart extends UI.Widget.VBox {
268
366
  }
269
367
  }
270
368
 
271
- private onScroll(e: WheelEvent): void {
272
- // TODO: is this a good divisor? does it account for high precision scroll wheels?
273
- // low precision scroll wheels?
274
- const scrollTickCount = Math.round(e.deltaY / 50);
275
- const scrollPositionRatio = e.offsetX / (e.srcElement as HTMLElement).clientWidth;
369
+ private onScroll(scrollTickCount: number, scrollPositionRatio: number): void {
276
370
  if (scrollTickCount > 0) {
277
371
  this.bounds.zoomOut(scrollTickCount, scrollPositionRatio);
278
372
  } else {
@@ -336,8 +430,7 @@ export class TickingFlameChart extends UI.Widget.VBox {
336
430
  this.bounds.addMax(duration);
337
431
  }
338
432
  this.dataProvider.updateMaxTime(this.bounds);
339
- this.chart.setWindowTimes(this.bounds.low, this.bounds.high, true);
340
- this.chart.scheduleUpdate();
433
+ this.performUpdate();
341
434
  }
342
435
  }
343
436
 
@@ -418,13 +511,12 @@ class TickingFlameChartDataProvider implements PerfUI.FlameChart.FlameChartDataP
418
511
  throw new Error(`level ${properties['level']} is above the maximum allowed of ${this.maxLevel}`);
419
512
  }
420
513
 
421
- const event = new Event(
422
- this.#timelineData, {
423
- setLive: this.setLive.bind(this),
424
- setComplete: this.setComplete.bind(this),
425
- updateMaxTime: this.updateMaxTimeHandle,
426
- },
427
- properties);
514
+ const event = new Event(this.#timelineData, {
515
+ setLive: this.setLive.bind(this),
516
+ setComplete: this.setComplete.bind(this),
517
+ updateMaxTime: this.updateMaxTimeHandle,
518
+ },
519
+ properties);
428
520
 
429
521
  this.eventMap.set(event.id, event);
430
522
  return event;
@@ -482,9 +574,8 @@ class TickingFlameChartDataProvider implements PerfUI.FlameChart.FlameChartDataP
482
574
  return defaultFont;
483
575
  }
484
576
 
485
- decorateEntry(
486
- _index: number, _context: CanvasRenderingContext2D, _text: string|null, _barX: number, _barY: number,
487
- _barWidth: number, _barHeight: number, _unclippedBarX: number, _timeToPixelRatio: number): boolean {
577
+ decorateEntry(_index: number, _context: CanvasRenderingContext2D, _text: string|null, _barX: number, _barY: number,
578
+ _barWidth: number, _barHeight: number, _unclippedBarX: number, _timeToPixelRatio: number): boolean {
488
579
  return false;
489
580
  }
490
581
 
@@ -492,10 +583,9 @@ class TickingFlameChartDataProvider implements PerfUI.FlameChart.FlameChartDataP
492
583
  return false;
493
584
  }
494
585
 
495
- preparePopoverElement(index: number): Element|null {
496
- const element = document.createElement('div');
497
- (this.eventMap.get(index) as Event).decorate(element);
498
- return element;
586
+ preparePopoverElement(index: number): TemplateResult|null {
587
+ const event = this.eventMap.get(index);
588
+ return event ? renderEventPopover(event.popoverInput()) : null;
499
589
  }
500
590
 
501
591
  formatValue(value: number, _precision?: number): string {
@@ -69,7 +69,7 @@ interface ViewInput {
69
69
  onSelect: (conditions: SDK.NetworkManager.ThrottlingConditions) => void;
70
70
  onAddCustomConditions: () => void;
71
71
  }
72
- export type ViewFunction = (input: ViewInput, output: object, target: HTMLSelectElement) => void;
72
+ export type ViewFunction = (input: ViewInput, output: undefined, target: HTMLSelectElement) => void;
73
73
 
74
74
  const optionsMap = new WeakMap<HTMLOptionElement, SDK.NetworkManager.ThrottlingConditions>();
75
75
 
@@ -399,7 +399,7 @@ export class NetworkThrottlingSelect extends NetworkThrottlingSelectBase {
399
399
  throttlingGroups,
400
400
  customConditionsGroup,
401
401
  };
402
- this.#view(viewInput, {}, this.contentElement as HTMLSelectElement);
402
+ this.#view(viewInput, undefined, this.contentElement as HTMLSelectElement);
403
403
  }
404
404
  }
405
405
  export namespace NetworkThrottlingSelect {