chrome-devtools-frontend 1.0.1726686 → 1.0.1730971

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (490) hide show
  1. package/.agents/rules/tests/test-strict-assertions-and-literal-expectations.md +1 -1
  2. package/.agents/rules/tests/test-view-and-presenter-isolation.md +1 -1
  3. package/.agents/rules/ui-and-widgets/ui-accessibility-and-semantic-html.md +1 -1
  4. package/.agents/rules/ui-and-widgets/ui-css-scoping-and-flex-layout.md +2 -2
  5. package/.agents/rules/ui-and-widgets/ui-declarative-child-widget-composition.md +5 -5
  6. package/.agents/rules/ui-and-widgets/ui-lit-declarative-templates-and-directives.md +2 -2
  7. package/.agents/rules/ui-and-widgets/ui-localization-and-uistrings-hygiene.md +2 -2
  8. package/.agents/rules/ui-and-widgets/ui-modern-component-and-encapsulation-standards.md +3 -3
  9. package/.agents/rules/ui-and-widgets/ui-pure-view-and-presenter-separation.md +2 -2
  10. package/.agents/rules/ui-and-widgets/ui-reactive-widget-update-lifecycle.md +2 -2
  11. package/.agents/rules/ui-and-widgets/ui-view-output-and-callback-contracts.md +2 -2
  12. package/.agents/rules/ui-and-widgets/ui-widget-dom-and-listener-lifecycle.md +2 -2
  13. package/.agents/skills/code-review/SKILL.md +63 -12
  14. package/.agents/skills/ui-eng-vision-local-lit-renderer/SKILL.md +38 -10
  15. package/.agents/skills/ui-eng-vision-widget-promoter/SKILL.md +1 -0
  16. package/.agents/skills/ui-widgets/SKILL.md +8 -2
  17. package/.agents/skills/write-ai-eval-test/SKILL.md +106 -0
  18. package/AUTHORS +2 -0
  19. package/DIR_METADATA +1 -2
  20. package/README.md +48 -26
  21. package/config/typescript/tsconfig.base.json +1 -0
  22. package/config/typescript/tsconfig.eslint.json +1 -0
  23. package/docs/contributing/changes.md +25 -0
  24. package/docs/ui_engineering.md +13 -4
  25. package/eslint.config.mjs +323 -41
  26. package/front_end/core/common/Color.ts +7 -7
  27. package/front_end/core/common/ParsedURL.ts +3 -3
  28. package/front_end/core/common/ResolverBase.ts +3 -3
  29. package/front_end/core/common/SegmentedRange.ts +3 -3
  30. package/front_end/core/common/SimpleHistoryManager.ts +14 -14
  31. package/front_end/core/common/Trie.ts +3 -3
  32. package/front_end/core/common/VersionController.ts +7 -7
  33. package/front_end/core/host/InspectorFrontendHost.ts +2 -2
  34. package/front_end/core/host/InspectorFrontendHostAPI.ts +9 -1
  35. package/front_end/core/host/InspectorFrontendHostStub.ts +1 -1
  36. package/front_end/core/host/UserMetrics.ts +4 -0
  37. package/front_end/core/host/UserMetricsEnums.ts +2 -1
  38. package/front_end/core/platform/StringUtilities.ts +54 -13
  39. package/front_end/core/platform/node/HostRuntime.ts +13 -7
  40. package/front_end/core/protocol_client/DevToolsCDPConnection.ts +4 -5
  41. package/front_end/core/root/Runtime.ts +5 -0
  42. package/front_end/core/sdk/AccessibilityModel.ts +5 -5
  43. package/front_end/core/sdk/AnimationModel.ts +17 -19
  44. package/front_end/core/sdk/CPUProfilerModel.ts +3 -3
  45. package/front_end/core/sdk/CPUThrottlingManager.ts +7 -0
  46. package/front_end/core/sdk/CSSMatchedStyles.ts +73 -13
  47. package/front_end/core/sdk/CSSMetadata.ts +7 -7
  48. package/front_end/core/sdk/CSSModel.ts +33 -33
  49. package/front_end/core/sdk/CSSProperty.ts +5 -5
  50. package/front_end/core/sdk/CSSRule.ts +6 -6
  51. package/front_end/core/sdk/CSSStyleSheetHeader.ts +4 -4
  52. package/front_end/core/sdk/Connections.ts +16 -16
  53. package/front_end/core/sdk/ConsoleModel.ts +44 -47
  54. package/front_end/core/sdk/CookieParser.ts +11 -11
  55. package/front_end/core/sdk/EmulationModel.ts +35 -36
  56. package/front_end/core/sdk/EventBreakpointsModel.ts +11 -11
  57. package/front_end/core/sdk/FrameManager.ts +16 -16
  58. package/front_end/core/sdk/IsolateManager.ts +2 -2
  59. package/front_end/core/sdk/IssuesModel.ts +2 -2
  60. package/front_end/core/sdk/OverlayModel.ts +19 -19
  61. package/front_end/core/sdk/PageResourceLoader.ts +14 -16
  62. package/front_end/core/sdk/RemoteObject.ts +9 -9
  63. package/front_end/core/sdk/Resource.ts +2 -2
  64. package/front_end/core/sdk/RuntimeModel.ts +7 -7
  65. package/front_end/core/sdk/Script.ts +6 -6
  66. package/front_end/core/sdk/ServiceWorkerManager.ts +36 -10
  67. package/front_end/core/sdk/SourceMap.ts +18 -20
  68. package/front_end/core/sdk/SourceMapManager.ts +2 -2
  69. package/front_end/core/sdk/TargetManager.ts +2 -2
  70. package/front_end/devtools_compatibility.js +7 -3
  71. package/front_end/entrypoints/inspector_main/InspectorMain.ts +2 -2
  72. package/front_end/entrypoints/node_app/app/NodeConnectionsPanel.ts +203 -115
  73. package/front_end/generated/InspectorBackendCommands.ts +1 -1
  74. package/front_end/generated/SupportedCSSProperties.ts +1 -3
  75. package/front_end/generated/protocol.ts +1 -0
  76. package/front_end/models/ai_assistance/AiAgent2.ts +36 -12
  77. package/front_end/models/ai_assistance/AiConversation.ts +8 -2
  78. package/front_end/models/ai_assistance/agents/AiAgent.ts +137 -62
  79. package/front_end/models/ai_assistance/agents/ExecuteJavascript.ts +2 -2
  80. package/front_end/models/ai_assistance/agents/StylingAgent.snapshot.txt +2 -2
  81. package/front_end/models/ai_assistance/data_formatters/LighthouseFormatter.snapshot.txt +149 -2
  82. package/front_end/models/ai_assistance/data_formatters/LighthouseFormatter.ts +269 -42
  83. package/front_end/models/ai_assistance/tools/ExecuteJavaScript.ts +3 -0
  84. package/front_end/models/ai_assistance/tools/GetLighthouseAudits.ts +9 -0
  85. package/front_end/models/ai_assistance/tools/ResolveDevtoolsNodePath.ts +13 -2
  86. package/front_end/models/ai_assistance/tools/RunLighthouse.ts +23 -7
  87. package/front_end/models/ai_assistance/tools/Tool.ts +7 -5
  88. package/front_end/models/bindings/CSSWorkspaceBinding.ts +22 -24
  89. package/front_end/models/bindings/DebuggerLanguagePlugins.ts +60 -60
  90. package/front_end/models/bindings/DebuggerWorkspaceBinding.ts +24 -24
  91. package/front_end/models/bindings/DefaultScriptMapping.ts +8 -8
  92. package/front_end/models/bindings/FileUtils.ts +13 -13
  93. package/front_end/models/bindings/PresentationConsoleMessageHelper.ts +3 -3
  94. package/front_end/models/bindings/ResourceScriptMapping.ts +23 -23
  95. package/front_end/models/comment_manager/CommentManager.ts +3 -3
  96. package/front_end/models/comment_manager/CommentThread.ts +50 -5
  97. package/front_end/models/cpu_profile/CPUProfileDataModel.ts +14 -14
  98. package/front_end/models/cpu_profile/ProfileTreeModel.ts +4 -4
  99. package/front_end/models/elements/StyleChanges.ts +38 -0
  100. package/front_end/models/emulation/EmulatedDevices.ts +12 -12
  101. package/front_end/models/har/HARFormat.ts +4 -4
  102. package/front_end/models/javascript_metadata/NativeFunctions.ts +5 -1
  103. package/front_end/models/lighthouse/LighthouseReporterTypes.ts +57 -3
  104. package/front_end/models/lighthouse/RunTypes.ts +9 -1
  105. package/front_end/models/logs/LogManager.ts +2 -2
  106. package/front_end/models/persistence/AutomaticFileSystemManager.ts +3 -0
  107. package/front_end/models/persistence/FileSystemWorkspaceBinding.ts +24 -24
  108. package/front_end/models/persistence/IsolatedFileSystemManager.ts +6 -0
  109. package/front_end/models/persistence/NetworkPersistenceManager.ts +8 -3
  110. package/front_end/models/trace/LanternComputationData.ts +37 -11
  111. package/front_end/models/trace/Processor.ts +2 -1
  112. package/front_end/models/trace/extras/TraceTree.ts +36 -10
  113. package/front_end/models/trace/handlers/InitiatorsHandler.ts +27 -34
  114. package/front_end/models/trace/handlers/LayoutShiftsHandler.ts +2 -6
  115. package/front_end/models/trace/handlers/SamplesHandler.ts +9 -6
  116. package/front_end/models/workspace/FileManager.ts +6 -0
  117. package/front_end/panels/accessibility/ARIAAttributesView.ts +4 -4
  118. package/front_end/panels/accessibility/AccessibilityAnnouncementRecordingView.ts +8 -1
  119. package/front_end/panels/accessibility/AccessibilityNodeView.ts +15 -17
  120. package/front_end/panels/accessibility/AccessibilitySubPane.ts +1 -1
  121. package/front_end/panels/ai_assistance/AiAssistancePanel.ts +5 -5
  122. package/front_end/panels/ai_assistance/ExternalHandler.ts +10 -1
  123. package/front_end/panels/ai_assistance/components/ChatMessage.ts +27 -22
  124. package/front_end/panels/ai_assistance/components/DisabledWidget.ts +19 -23
  125. package/front_end/panels/ai_assistance/components/ExploreWidget.ts +2 -2
  126. package/front_end/panels/ai_assistance/components/PermissionPrompt.ts +23 -9
  127. package/front_end/panels/ai_assistance/components/chatInput.css +1 -1
  128. package/front_end/panels/animation/AnimationTimeline.ts +37 -17
  129. package/front_end/panels/animation/animationTimeline.css +19 -3
  130. package/front_end/panels/application/AppManifestView.ts +1 -2
  131. package/front_end/panels/application/ApplicationPanelSidebar.ts +143 -128
  132. package/front_end/panels/application/DOMStorageItemsView.ts +14 -14
  133. package/front_end/panels/application/DeviceBoundSessionsView.ts +10 -13
  134. package/front_end/panels/application/ExtensionStorageItemsView.ts +3 -4
  135. package/front_end/panels/application/IndexedDBViews.ts +8 -4
  136. package/front_end/panels/application/KeyValueStorageItemsView.ts +4 -5
  137. package/front_end/panels/application/PrivateVerificationTokensView.ts +53 -0
  138. package/front_end/panels/application/ServiceWorkerCacheViews.ts +12 -8
  139. package/front_end/panels/application/ServiceWorkersView.ts +1 -2
  140. package/front_end/panels/application/StorageItemsToolbar.ts +3 -3
  141. package/front_end/panels/application/StorageView.ts +2 -2
  142. package/front_end/panels/application/WebMCPView.ts +91 -109
  143. package/front_end/panels/application/application.ts +2 -0
  144. package/front_end/panels/application/components/StorageMetadataView.ts +6 -6
  145. package/front_end/panels/application/preloading/PreloadingView.ts +70 -37
  146. package/front_end/panels/application/preloading/components/MismatchedPreloadingGrid.ts +2 -2
  147. package/front_end/panels/application/preloading/components/PreloadingDisabledInfobar.ts +3 -3
  148. package/front_end/panels/application/preloading/components/PreloadingGrid.ts +12 -0
  149. package/front_end/panels/application/preloading/components/RuleSetDetailsView.ts +10 -11
  150. package/front_end/panels/application/privateVerificationTokensView.css +20 -0
  151. package/front_end/panels/application/serviceWorkersView.css +2 -2
  152. package/front_end/panels/browser_debugger/DOMBreakpointsSidebarPane.ts +24 -24
  153. package/front_end/panels/changes/ChangesSidebar.ts +5 -5
  154. package/front_end/panels/changes/ChangesView.ts +10 -11
  155. package/front_end/panels/comments/CommentsPane.ts +292 -102
  156. package/front_end/panels/comments/commentsPane.css +93 -12
  157. package/front_end/panels/common/CommentThreadWidget.ts +69 -0
  158. package/front_end/panels/common/CommentsOverlayWidget.ts +108 -29
  159. package/front_end/panels/common/CommentsStatusBarPill.ts +17 -6
  160. package/front_end/panels/common/DOMLinkifier.ts +37 -12
  161. package/front_end/panels/common/ExtensionPanel.ts +13 -4
  162. package/front_end/panels/common/ExtensionServer.ts +27 -3
  163. package/front_end/panels/common/PersistenceUtils.ts +3 -3
  164. package/front_end/panels/common/commentThreadWidget.css +25 -1
  165. package/front_end/panels/common/common-meta.ts +10 -0
  166. package/front_end/panels/console/ConsolePinPane.ts +13 -15
  167. package/front_end/panels/console/ConsolePrompt.ts +173 -95
  168. package/front_end/panels/console/ConsoleSidebar.ts +2 -2
  169. package/front_end/panels/console/ConsoleView.ts +75 -79
  170. package/front_end/panels/console/ConsoleViewMessage.ts +52 -4
  171. package/front_end/panels/console/SymbolizedErrorWidget.ts +8 -4
  172. package/front_end/panels/console/consolePrompt.css +1 -1
  173. package/front_end/panels/console/consoleView.css +1 -1
  174. package/front_end/panels/console_counters/WarningErrorCounter.ts +3 -4
  175. package/front_end/panels/coverage/CoverageListView.ts +2 -2
  176. package/front_end/panels/coverage/CoverageView.ts +20 -5
  177. package/front_end/panels/css_overview/CSSOverviewCompletedView.ts +4 -3
  178. package/front_end/panels/css_overview/CSSOverviewPanel.ts +2 -2
  179. package/front_end/panels/css_overview/CSSOverviewProcessingView.ts +2 -2
  180. package/front_end/panels/css_overview/CSSOverviewSidebarPanel.ts +2 -2
  181. package/front_end/panels/css_overview/CSSOverviewStartView.ts +2 -2
  182. package/front_end/panels/css_overview/CSSOverviewUnusedDeclarations.ts +8 -8
  183. package/front_end/panels/developer_resources/DeveloperResourcesListView.ts +2 -3
  184. package/front_end/panels/developer_resources/DeveloperResourcesView.ts +4 -5
  185. package/front_end/panels/elements/AccessibilityTreeUtils.ts +6 -7
  186. package/front_end/panels/elements/CSSValueTraceView.ts +3 -3
  187. package/front_end/panels/elements/ClassesPaneWidget.ts +1 -2
  188. package/front_end/panels/elements/ComputedStyleWidget.ts +15 -14
  189. package/front_end/panels/elements/DOMTreeElementWidget.ts +5 -4
  190. package/front_end/panels/elements/DOMTreeWidget.ts +2 -1
  191. package/front_end/panels/elements/ElementStatePaneWidget.ts +2 -2
  192. package/front_end/panels/elements/ElementsPanel.ts +1 -0
  193. package/front_end/panels/elements/EventListenersWidget.ts +2 -2
  194. package/front_end/panels/elements/LayoutPane.ts +2 -2
  195. package/front_end/panels/elements/PlatformFontsWidget.ts +3 -3
  196. package/front_end/panels/elements/PropertiesWidget.ts +9 -10
  197. package/front_end/panels/elements/PropertyRenderer.ts +72 -11
  198. package/front_end/panels/elements/StandaloneStylesContainer.ts +5 -10
  199. package/front_end/panels/elements/StyleEditorWidget.ts +30 -16
  200. package/front_end/panels/elements/StylePropertiesSection.ts +93 -44
  201. package/front_end/panels/elements/StylePropertyTreeElement.ts +230 -302
  202. package/front_end/panels/elements/StylesContainer.ts +2 -3
  203. package/front_end/panels/elements/StylesSidebarPane.ts +4 -13
  204. package/front_end/panels/elements/components/AccessibilityTreeNode.ts +66 -37
  205. package/front_end/panels/elements/components/CSSHintDetailsView.ts +51 -41
  206. package/front_end/panels/elements/components/CSSPropertyDocsView.ts +75 -65
  207. package/front_end/panels/elements/components/CSSQuery.ts +112 -74
  208. package/front_end/panels/elements/components/CSSVariableValueView.ts +109 -68
  209. package/front_end/panels/elements/components/ComputedStyleProperty.ts +64 -45
  210. package/front_end/panels/elements/components/ElementsTreeExpandButton.ts +35 -28
  211. package/front_end/panels/elements/components/QueryContainer.ts +104 -74
  212. package/front_end/panels/elements/components/accessibilityTreeNode.css +22 -20
  213. package/front_end/panels/elements/components/computedStyleProperty.css +2 -0
  214. package/front_end/panels/elements/components/cssHintDetailsView.css +23 -21
  215. package/front_end/panels/elements/components/cssPropertyDocsView.css +38 -36
  216. package/front_end/panels/elements/components/cssVariableValueView.css +42 -40
  217. package/front_end/panels/elements/components/elementsTreeExpandButton.css +5 -2
  218. package/front_end/panels/elements/components/queryContainer.css +23 -21
  219. package/front_end/panels/elements/stylesSidebarPane.css +3 -3
  220. package/front_end/panels/emulation/DeviceModeToolbar.ts +2 -2
  221. package/front_end/panels/emulation/InspectedPagePlaceholder.ts +2 -2
  222. package/front_end/panels/emulation/MediaQueryInspector.ts +9 -10
  223. package/front_end/panels/emulation/mediaQueryInspector.css +1 -1
  224. package/front_end/panels/event_listeners/EventListenersView.ts +2 -2
  225. package/front_end/panels/issues/AffectedCookiesView.ts +144 -101
  226. package/front_end/panels/issues/AffectedDescendantsWithinSelectElementView.ts +83 -31
  227. package/front_end/panels/issues/AffectedDirectivesView.ts +218 -135
  228. package/front_end/panels/issues/AffectedDocumentsInQuirksModeView.ts +84 -34
  229. package/front_end/panels/issues/AffectedElementsView.ts +86 -23
  230. package/front_end/panels/issues/AffectedLazyLoadImagesView.ts +2 -2
  231. package/front_end/panels/issues/AffectedMetadataAllowedSitesView.ts +2 -2
  232. package/front_end/panels/issues/AffectedPartitioningBlobURLView.ts +36 -11
  233. package/front_end/panels/issues/AffectedSharedArrayBufferIssueDetailsView.ts +135 -58
  234. package/front_end/panels/issues/AffectedSourcesView.ts +49 -28
  235. package/front_end/panels/issues/AffectedTrackingSitesView.ts +3 -4
  236. package/front_end/panels/issues/CorsIssueDetailsView.ts +490 -269
  237. package/front_end/panels/issues/GenericIssueDetailsView.ts +2 -2
  238. package/front_end/panels/issues/IssueKindView.ts +63 -48
  239. package/front_end/panels/issues/IssueView.ts +14 -18
  240. package/front_end/panels/issues/components/ElementsPanelLink.ts +70 -34
  241. package/front_end/panels/issues/components/HideIssuesMenu.ts +56 -32
  242. package/front_end/panels/issues/components/elementsPanelLink.css +10 -6
  243. package/front_end/panels/issues/components/hideIssuesMenu.css +16 -14
  244. package/front_end/panels/issues/issues.ts +2 -0
  245. package/front_end/panels/issues/issuesTree.css +4 -4
  246. package/front_end/panels/lighthouse/LighthouseController.ts +6 -6
  247. package/front_end/panels/lighthouse/LighthouseStatusView.ts +12 -13
  248. package/front_end/panels/lighthouse/lighthouseStartView.css +1 -1
  249. package/front_end/panels/linear_memory_inspector/LinearMemoryInspectorPane.ts +159 -161
  250. package/front_end/panels/linear_memory_inspector/LinearMemoryInspectorView.ts +228 -0
  251. package/front_end/panels/linear_memory_inspector/components/LinearMemoryInspector.ts +32 -41
  252. package/front_end/panels/linear_memory_inspector/components/linearMemoryHighlightChipList.css +2 -2
  253. package/front_end/panels/linear_memory_inspector/linear_memory_inspector.ts +2 -0
  254. package/front_end/panels/media/EventDisplayTable.ts +2 -2
  255. package/front_end/panels/media/MainView.ts +132 -66
  256. package/front_end/panels/media/PlayerDetailView.ts +32 -14
  257. package/front_end/panels/media/PlayerListView.ts +83 -23
  258. package/front_end/panels/media/PlayerPropertiesView.ts +2 -2
  259. package/front_end/panels/media/TickingFlameChart.ts +153 -63
  260. package/front_end/panels/mobile_throttling/NetworkThrottlingSelector.ts +2 -2
  261. package/front_end/panels/mobile_throttling/ThrottlingSettingsTab.ts +615 -464
  262. package/front_end/panels/mobile_throttling/throttlingSettingsTab.css +43 -0
  263. package/front_end/panels/network/EventSourceMessagesView.ts +3 -3
  264. package/front_end/panels/network/NetworkConfigView.ts +6 -2
  265. package/front_end/panels/network/NetworkDataGridNode.ts +2 -1
  266. package/front_end/panels/network/NetworkItemView.ts +27 -26
  267. package/front_end/panels/network/NetworkManageCustomHeadersView.ts +236 -97
  268. package/front_end/panels/network/NetworkOverview.ts +8 -10
  269. package/front_end/panels/network/RequestConditionsDrawer.ts +8 -4
  270. package/front_end/panels/network/RequestDeviceBoundSessionsView.ts +2 -4
  271. package/front_end/panels/network/RequestHTMLView.ts +26 -7
  272. package/front_end/panels/network/RequestHeadersView.ts +2 -2
  273. package/front_end/panels/network/RequestInitiatorView.ts +21 -22
  274. package/front_end/panels/network/RequestPayloadView.ts +2 -16
  275. package/front_end/panels/network/RequestPreviewView.ts +5 -5
  276. package/front_end/panels/network/RequestTimingView.ts +6 -6
  277. package/front_end/panels/network/ResourceDirectSocketChunkView.ts +5 -6
  278. package/front_end/panels/network/ResourceWebSocketFrameView.ts +4 -3
  279. package/front_end/panels/network/ShowMoreDetailsWidget.ts +11 -12
  280. package/front_end/panels/network/SignedExchangeInfoView.ts +2 -2
  281. package/front_end/panels/network/networkLogView.css +2 -2
  282. package/front_end/panels/network/networkManageCustomHeadersView.css +27 -6
  283. package/front_end/panels/network/requestConditionsDrawer.css +1 -1
  284. package/front_end/panels/network/requestInitiatorView.css +5 -3
  285. package/front_end/panels/performance_monitor/PerformanceMonitor.ts +2 -2
  286. package/front_end/panels/profiler/HeapDetachedElementsView.ts +1 -2
  287. package/front_end/panels/profiler/HeapTimelineOverview.ts +77 -15
  288. package/front_end/panels/profiler/IsolateSelector.ts +258 -187
  289. package/front_end/panels/profiler/ProfileLauncherView.ts +7 -29
  290. package/front_end/panels/profiler/profileLauncherView.css +6 -1
  291. package/front_end/panels/protocol_monitor/JSONEditor.ts +4 -5
  292. package/front_end/panels/recorder/ControlButton.ts +1 -1
  293. package/front_end/panels/recorder/RecordingListView.ts +2 -4
  294. package/front_end/panels/recorder/RecordingView.ts +1 -2
  295. package/front_end/panels/recorder/SelectorPicker.ts +2 -4
  296. package/front_end/panels/recorder/StepView.ts +24 -10
  297. package/front_end/panels/recorder/TimelineSection.ts +1 -1
  298. package/front_end/panels/recorder/recordingView.css +1 -1
  299. package/front_end/panels/screencast/ScreencastApp.ts +1 -1
  300. package/front_end/panels/search/SearchResultsPane.ts +11 -12
  301. package/front_end/panels/search/SearchView.ts +8 -10
  302. package/front_end/panels/security/SecurityPanel.ts +1 -8
  303. package/front_end/panels/security/SecurityPanelSidebar.ts +2 -2
  304. package/front_end/panels/security/mainView.css +1 -1
  305. package/front_end/panels/sensors/LocationsSettingsTab.ts +1 -2
  306. package/front_end/panels/settings/AISettingsTab.ts +1 -1
  307. package/front_end/panels/settings/BackendLinkingSettingsTab.ts +34 -20
  308. package/front_end/panels/settings/EditFileSystemView.ts +2 -2
  309. package/front_end/panels/settings/FrameworkIgnoreListSettingsTab.ts +375 -197
  310. package/front_end/panels/settings/KeybindsSettingsTab.ts +570 -414
  311. package/front_end/panels/settings/SettingsScreen.ts +312 -114
  312. package/front_end/panels/settings/WorkspaceSettingsTab.ts +2 -2
  313. package/front_end/panels/settings/aiSettingsTab.css +1 -4
  314. package/front_end/panels/settings/emulation/DevicesSettingsTab.ts +924 -578
  315. package/front_end/panels/settings/emulation/components/UserAgentClientHintsForm.ts +9 -2
  316. package/front_end/panels/settings/emulation/devicesSettingsTab.css +39 -0
  317. package/front_end/panels/settings/frameworkIgnoreListSettingsTab.css +37 -8
  318. package/front_end/panels/settings/settingsScreen.css +0 -24
  319. package/front_end/panels/sources/BreakpointEditDialog.ts +9 -6
  320. package/front_end/panels/sources/BreakpointsView.ts +25 -4
  321. package/front_end/panels/sources/CallStackSidebarPane.ts +7 -1
  322. package/front_end/panels/sources/DebuggerPlugin.ts +1 -0
  323. package/front_end/panels/sources/GoToLineQuickOpen.ts +8 -8
  324. package/front_end/panels/sources/NavigatorView.ts +521 -439
  325. package/front_end/panels/sources/PersistenceActions.ts +11 -12
  326. package/front_end/panels/sources/ProfilePlugin.ts +28 -17
  327. package/front_end/panels/sources/ScopeChainSidebarPane.ts +3 -4
  328. package/front_end/panels/sources/SourcesNavigator.ts +9 -9
  329. package/front_end/panels/sources/SourcesPanel.ts +2 -2
  330. package/front_end/panels/sources/SourcesView.ts +3 -3
  331. package/front_end/panels/sources/ThreadsSidebarPane.ts +2 -2
  332. package/front_end/panels/sources/WatchExpressionsSidebarPane.ts +2 -2
  333. package/front_end/panels/sources/components/HeadersView.ts +1 -2
  334. package/front_end/panels/timeline/CompatibilityTracksAppender.ts +5 -6
  335. package/front_end/panels/timeline/EventsTimelineTreeView.ts +73 -34
  336. package/front_end/panels/timeline/IsolateSelector.ts +25 -37
  337. package/front_end/panels/timeline/StatusDialog.ts +5 -7
  338. package/front_end/panels/timeline/ThirdPartyTreeView.ts +10 -13
  339. package/front_end/panels/timeline/TimelineDetailsView.ts +40 -21
  340. package/front_end/panels/timeline/TimelineEventOverview.ts +130 -34
  341. package/front_end/panels/timeline/TimelineFlameChartNetworkDataProvider.ts +1 -1
  342. package/front_end/panels/timeline/TimelineMiniMap.ts +255 -103
  343. package/front_end/panels/timeline/TimelinePaintProfilerView.ts +19 -11
  344. package/front_end/panels/timeline/TimelinePanel.ts +1 -0
  345. package/front_end/panels/timeline/TimelineSelectorStatsView.ts +11 -12
  346. package/front_end/panels/timeline/TimelineTreeView.ts +240 -122
  347. package/front_end/panels/timeline/TimelineUIUtils.ts +12 -0
  348. package/front_end/panels/timeline/components/BreadcrumbsUI.ts +5 -4
  349. package/front_end/panels/timeline/components/DetailsView.ts +97 -65
  350. package/front_end/panels/timeline/components/LayoutShiftDetails.ts +2 -2
  351. package/front_end/panels/timeline/components/MetricCard.ts +2 -2
  352. package/front_end/panels/timeline/components/NetworkRequestDetails.ts +11 -12
  353. package/front_end/panels/timeline/components/NetworkTrackWidget.ts +57 -50
  354. package/front_end/panels/timeline/components/RelatedInsightChips.ts +2 -2
  355. package/front_end/panels/timeline/components/Sidebar.ts +161 -109
  356. package/front_end/panels/timeline/components/SidebarAnnotationsTab.ts +33 -12
  357. package/front_end/panels/timeline/components/SidebarInsightsTab.ts +3 -0
  358. package/front_end/panels/timeline/components/insights/LCPDiscovery.ts +11 -11
  359. package/front_end/panels/timeline/components/insights/SlowCSSSelector.ts +6 -7
  360. package/front_end/panels/timeline/components/networkTrackWidget.css +24 -22
  361. package/front_end/panels/timeline/components/sidebarInsightsTab.css +1 -1
  362. package/front_end/panels/timeline/overlays/components/TimespanBreakdownOverlay.ts +15 -10
  363. package/front_end/panels/timeline/overlays/components/entryLabelOverlay.css +1 -1
  364. package/front_end/panels/timeline/timelinePanel.css +5 -0
  365. package/front_end/panels/timeline/timelineStatusDialog.css +1 -1
  366. package/front_end/panels/web_audio/WebAudioView.ts +2 -2
  367. package/front_end/third_party/chromium/README.chromium +1 -1
  368. package/front_end/third_party/legacy-javascript/README.chromium +2 -2
  369. package/front_end/third_party/legacy-javascript/lib/legacy-javascript.js +2 -2
  370. package/front_end/third_party/legacy-javascript/package.json +1 -1
  371. package/front_end/third_party/lighthouse/README.chromium +2 -2
  372. package/front_end/third_party/lighthouse/lighthouse-dt-bundle.js +1983 -2022
  373. package/front_end/third_party/lighthouse/locales/ar-XB.json +157 -142
  374. package/front_end/third_party/lighthouse/locales/ar.json +157 -142
  375. package/front_end/third_party/lighthouse/locales/bg.json +154 -139
  376. package/front_end/third_party/lighthouse/locales/ca.json +157 -142
  377. package/front_end/third_party/lighthouse/locales/cs.json +148 -133
  378. package/front_end/third_party/lighthouse/locales/da.json +153 -138
  379. package/front_end/third_party/lighthouse/locales/de.json +152 -137
  380. package/front_end/third_party/lighthouse/locales/el.json +153 -138
  381. package/front_end/third_party/lighthouse/locales/en-GB.json +160 -145
  382. package/front_end/third_party/lighthouse/locales/en-US.json +239 -218
  383. package/front_end/third_party/lighthouse/locales/en-XL.json +239 -218
  384. package/front_end/third_party/lighthouse/locales/es-419.json +150 -135
  385. package/front_end/third_party/lighthouse/locales/es.json +149 -134
  386. package/front_end/third_party/lighthouse/locales/fi.json +151 -136
  387. package/front_end/third_party/lighthouse/locales/fil.json +154 -139
  388. package/front_end/third_party/lighthouse/locales/fr.json +150 -135
  389. package/front_end/third_party/lighthouse/locales/he.json +160 -145
  390. package/front_end/third_party/lighthouse/locales/hi.json +156 -141
  391. package/front_end/third_party/lighthouse/locales/hr.json +154 -139
  392. package/front_end/third_party/lighthouse/locales/hu.json +111 -96
  393. package/front_end/third_party/lighthouse/locales/id.json +153 -138
  394. package/front_end/third_party/lighthouse/locales/it.json +153 -138
  395. package/front_end/third_party/lighthouse/locales/ja.json +150 -135
  396. package/front_end/third_party/lighthouse/locales/ko.json +42 -27
  397. package/front_end/third_party/lighthouse/locales/lt.json +152 -137
  398. package/front_end/third_party/lighthouse/locales/lv.json +93 -78
  399. package/front_end/third_party/lighthouse/locales/nl.json +149 -134
  400. package/front_end/third_party/lighthouse/locales/no.json +152 -137
  401. package/front_end/third_party/lighthouse/locales/pl.json +153 -138
  402. package/front_end/third_party/lighthouse/locales/pt-PT.json +152 -137
  403. package/front_end/third_party/lighthouse/locales/pt.json +157 -142
  404. package/front_end/third_party/lighthouse/locales/ro.json +149 -134
  405. package/front_end/third_party/lighthouse/locales/ru.json +76 -61
  406. package/front_end/third_party/lighthouse/locales/sk.json +153 -138
  407. package/front_end/third_party/lighthouse/locales/sl.json +149 -134
  408. package/front_end/third_party/lighthouse/locales/sr-Latn.json +151 -136
  409. package/front_end/third_party/lighthouse/locales/sr.json +151 -136
  410. package/front_end/third_party/lighthouse/locales/sv.json +152 -137
  411. package/front_end/third_party/lighthouse/locales/ta.json +156 -141
  412. package/front_end/third_party/lighthouse/locales/te.json +157 -142
  413. package/front_end/third_party/lighthouse/locales/th.json +111 -96
  414. package/front_end/third_party/lighthouse/locales/tr.json +153 -138
  415. package/front_end/third_party/lighthouse/locales/uk.json +149 -134
  416. package/front_end/third_party/lighthouse/locales/vi.json +162 -147
  417. package/front_end/third_party/lighthouse/locales/zh-HK.json +150 -135
  418. package/front_end/third_party/lighthouse/locales/zh-TW.json +154 -139
  419. package/front_end/third_party/lighthouse/locales/zh.json +152 -137
  420. package/front_end/third_party/lighthouse/report/bundle.d.ts +9 -8
  421. package/front_end/third_party/lighthouse/report/bundle.js +10 -10
  422. package/front_end/third_party/lighthouse/report-assets/report-generator.mjs +2 -7
  423. package/front_end/tsconfig.compatibility.json +1 -0
  424. package/front_end/tsconfig.json +3 -2
  425. package/front_end/ui/components/dialogs/TypeToAllowDialog.ts +0 -2
  426. package/front_end/ui/components/dialogs/typeToAllowDialog.css +0 -4
  427. package/front_end/ui/components/icon_button/fileSourceIcon.css +1 -1
  428. package/front_end/ui/components/input/textInput.css +1 -1
  429. package/front_end/ui/components/lists/List.ts +26 -14
  430. package/front_end/ui/components/menus/menus.ts +0 -2
  431. package/front_end/ui/components/suggestion_input/SuggestionInput.ts +351 -138
  432. package/front_end/ui/components/survey_link/surveyLink.css +3 -3
  433. package/front_end/ui/components/switch/switch.css +6 -6
  434. package/front_end/ui/components/text_editor/AiCodeCompletionTeaser.ts +2 -3
  435. package/front_end/ui/components/text_editor/TextEditor.ts +1 -1
  436. package/front_end/ui/components/tooltips/Tooltip.ts +53 -4
  437. package/front_end/ui/components/tree_outline/treeOutline.css +7 -7
  438. package/front_end/ui/helpers/OpenInNewTab.ts +8 -3
  439. package/front_end/ui/legacy/EmptyWidget.ts +4 -4
  440. package/front_end/ui/legacy/ForwardedInputEventHandler.ts +2 -2
  441. package/front_end/ui/legacy/GlassPane.ts +1 -1
  442. package/front_end/ui/legacy/KeyboardShortcut.ts +7 -7
  443. package/front_end/ui/legacy/RemoteDebuggingTerminatedScreen.ts +2 -2
  444. package/front_end/ui/legacy/TabbedPane.ts +198 -66
  445. package/front_end/ui/legacy/TargetCrashedScreen.ts +2 -2
  446. package/front_end/ui/legacy/UIUtils.ts +71 -68
  447. package/front_end/ui/legacy/View.ts +7 -4
  448. package/front_end/ui/legacy/ViewManager.ts +49 -37
  449. package/front_end/ui/legacy/Widget.ts +32 -12
  450. package/front_end/ui/legacy/components/cookie_table/CookiesTable.ts +2 -3
  451. package/front_end/ui/legacy/components/inline_editor/AnimationTimingUI.ts +8 -8
  452. package/front_end/ui/legacy/components/inline_editor/BezierUI.ts +8 -9
  453. package/front_end/ui/legacy/components/inline_editor/LinkSwatch.ts +2 -2
  454. package/front_end/ui/legacy/components/inline_editor/cssAngleEditor.css +1 -1
  455. package/front_end/ui/legacy/components/inline_editor/cssAngleSwatch.css +1 -1
  456. package/front_end/ui/legacy/components/object_ui/ObjectPropertiesSection.ts +45 -11
  457. package/front_end/ui/legacy/components/object_ui/RemoteObjectPreviewFormatter.ts +10 -12
  458. package/front_end/ui/legacy/components/perf_ui/ChartViewport.ts +102 -29
  459. package/front_end/ui/legacy/components/perf_ui/FlameChart.ts +148 -122
  460. package/front_end/ui/legacy/components/perf_ui/TimelineOverviewPane.ts +20 -14
  461. package/front_end/ui/legacy/components/quick_open/filteredListWidget.css +1 -1
  462. package/front_end/ui/legacy/components/source_frame/FontView.ts +29 -5
  463. package/front_end/ui/legacy/components/source_frame/ImageView.ts +79 -12
  464. package/front_end/ui/legacy/components/source_frame/JSONView.ts +20 -2
  465. package/front_end/ui/legacy/components/source_frame/PreviewFactory.ts +2 -2
  466. package/front_end/ui/legacy/components/source_frame/StreamingContentHexView.ts +6 -10
  467. package/front_end/ui/legacy/components/source_frame/XMLView.ts +11 -11
  468. package/front_end/ui/legacy/components/source_frame/fontView.css +7 -0
  469. package/front_end/ui/legacy/components/source_frame/imageView.css +7 -0
  470. package/front_end/ui/legacy/components/utils/JSPresentationUtils.ts +14 -3
  471. package/front_end/ui/legacy/components/utils/Linkifier.ts +126 -2
  472. package/front_end/ui/legacy/emptyWidget.css +2 -1
  473. package/front_end/ui/legacy/inspectorCommon.css +3 -3
  474. package/front_end/ui/legacy/smallBubble.css +1 -1
  475. package/front_end/ui/legacy/tabbedPane.css +6 -0
  476. package/front_end/ui/lit/Directives.ts +35 -18
  477. package/front_end/ui/lit/lit.ts +0 -2
  478. package/front_end/ui/lit/render.ts +0 -7
  479. package/front_end/ui/visual_logging/KnownContextValues.ts +5 -0
  480. package/package.json +1 -1
  481. package/vpython.toml +8 -0
  482. package/vpython.toml.uv.lock +3 -0
  483. package/.agents/skills/review-models-core/SKILL.md +0 -73
  484. package/.agents/skills/review-tests/SKILL.md +0 -67
  485. package/.agents/skills/review-ui-widgets/SKILL.md +0 -115
  486. package/front_end/generated/ARIAProperties.ts +0 -2686
  487. package/front_end/ui/components/menus/README.md +0 -119
  488. package/front_end/ui/components/menus/SelectMenu.ts +0 -473
  489. package/front_end/ui/components/menus/selectMenu.css +0 -54
  490. package/front_end/ui/components/menus/selectMenuButton.css +0 -108
package/README.md CHANGED
@@ -6,54 +6,76 @@
6
6
 
7
7
  <!-- [END badges] -->
8
8
 
9
- The client-side of the Chrome DevTools, including all TypeScript & CSS to run the DevTools webapp.
9
+ This repository contains the client side of Chrome DevTools. It contains all
10
+ the TypeScript and CSS code that runs the DevTools web app.
10
11
 
11
12
  ### Source code and documentation
12
13
 
13
- The frontend is available on [chromium.googlesource.com]. Check out the [Chromium DevTools
14
- documentation] for instructions to [set up], use, and maintain a DevTools front-end checkout,
15
- as well as design guidelines, and architectural documentation.
14
+ The source code is on [chromium.googlesource.com].
15
+
16
+ The [Chromium DevTools documentation] tells you how to do these tasks:
17
+
18
+ - [Set up] a DevTools frontend checkout.
19
+ - Use a DevTools frontend checkout.
20
+ - Maintain a DevTools frontend checkout.
21
+
22
+ The documentation also contains design guidelines and architecture
23
+ documentation.
24
+
25
+ Other documentation:
16
26
 
17
27
  - DevTools user documentation: [devtools.chrome.com](https://devtools.chrome.com)
18
- - Debugger protocol documentation: [chromedevtools.github.io/devtools-protocol](https://chromedevtools.github.io/devtools-protocol)
19
- - Awesome Chrome DevTools: [github.com/paulirish/awesome-chrome-devtools](https://github.com/paulirish/awesome-chrome-devtools)
20
- - Contributing to Chrome DevTools: [goo.gle/devtools-contribution-guide](http://goo.gle/devtools-contribution-guide)
21
- - Contributing To Chrome DevTools Protocol: [goo.gle/devtools-contribution-guide-cdp](https://goo.gle/devtools-contribution-guide-cdp)
28
+ - Chrome DevTools Protocol documentation: [chromedevtools.github.io/devtools-protocol](https://chromedevtools.github.io/devtools-protocol)
29
+ - A list of Chrome DevTools resources: [github.com/paulirish/awesome-chrome-devtools](https://github.com/paulirish/awesome-chrome-devtools)
30
+ - How to contribute to Chrome DevTools: [goo.gle/devtools-contribution-guide](http://goo.gle/devtools-contribution-guide)
31
+ - How to contribute to the Chrome DevTools Protocol: [goo.gle/devtools-contribution-guide-cdp](https://goo.gle/devtools-contribution-guide-cdp)
22
32
 
23
33
  ### Source mirrors
24
34
 
25
- DevTools frontend repository is mirrored on [GitHub](https://github.com/ChromeDevTools/devtools-frontend).
35
+ There is a mirror of the DevTools frontend repository on
36
+ [GitHub](https://github.com/ChromeDevTools/devtools-frontend).
37
+
38
+ The DevTools frontend is also available on npm as the
39
+ [chrome-devtools-frontend](https://www.npmjs.com/package/chrome-devtools-frontend)
40
+ package. The package does not supply CJS modules or ES modules. Thus, it can be
41
+ difficult to use this package in other tools. For an example of how to use it,
42
+ see [this file](https://github.com/paulirish/devtools-timeline-model/blob/master/index.js).
26
43
 
27
- DevTools frontend is also available on NPM as the [chrome-devtools-frontend](https://www.npmjs.com/package/chrome-devtools-frontend) package. It's not currently available via CJS or ES modules, so consuming this package in other tools may require [some effort](https://github.com/paulirish/devtools-timeline-model/blob/master/index.js).
44
+ The version number of the npm package (for example, `1.0.373466`) is the
45
+ Chromium commit position of the latest frontend Git commit. The version number
46
+ increases with each Chromium commit. But we publish the package only
47
+ approximately one time each day.
28
48
 
29
- The version number of the npm package (e.g. `1.0.373466`) refers to the Chromium commit position of latest frontend git commit. It's incremented with every Chromium commit, however the package is updated roughly daily.
49
+ ### Contact us
30
50
 
31
- ### Getting in touch
51
+ - Follow [@ChromeDevTools] on X (previously Twitter).
52
+ - Send a message to the Chrome DevTools mailing list: [g/google-chrome-developer-tools]
53
+ - Report a new DevTools bug: [goo.gle/devtools-bug]
32
54
 
33
- - [@ChromeDevTools] on Twitter
34
- - Chrome DevTools mailing list: [g/google-chrome-developer-tools]
35
- - File a new DevTools ticket: [goo.gle/devtools-bug]
55
+ ### Get the latest news
36
56
 
37
- There are a few options to keep an eye on the latest and greatest of DevTools development:
57
+ To get the latest news about DevTools development, do one or more of these
58
+ steps:
38
59
 
39
- - Follow [What's new in DevTools].
40
- - Follow [Umar's Dev Tips].
41
- - Follow these individual Twitter accounts:
60
+ - Read [What's new in DevTools].
61
+ - Read [Umar's Dev Tips].
62
+ - Follow these accounts on X:
42
63
  [@umaar](https://x.com/umaar),
43
64
  [@malyw](https://x.com/malyw),
44
65
  [@kdzwinel](https://x.com/kdzwinel),
45
66
  [@addyosmani](https://x.com/addyosmani),
46
67
  [@paul_irish](https://x.com/paul_irish),
47
68
  [@samccone](https://x.com/samccone),
48
- [@mathias](https://x.com/ziyunfei),
69
+ [@mathias](https://x.com/mathias),
49
70
  [@mattzeunert](https://x.com/mattzeunert),
50
71
  [@PrashantPalikhe](https://x.com/PrashantPalikhe),
51
72
  [@ziyunfei](https://x.com/ziyunfei), and
52
73
  [@bmeurer](https://x.com/bmeurer).
53
- - Follow to [g/devtools-reviews@chromium.org] mailing list for all reviews of pending code,
54
- and [view the log], or follow [@DevToolsCommits] on Twitter.
55
- - Checkout [all open DevTools tickets] on crbug.com
56
- - Use Chrome Canary and poke around the experiments.
74
+ - Join the [g/devtools-reviews@chromium.org] mailing list. This list shows all
75
+ pending code reviews.
76
+ - Read the [commit log], or follow [@DevToolsCommits] on X.
77
+ - See [all open DevTools bugs] on crbug.com.
78
+ - Use Chrome Canary and try the experiments.
57
79
 
58
80
  [Chromium DevTools documentation]: http://goo.gle/chromium-devtools
59
81
  [set up]: https://chromium.googlesource.com/devtools/devtools-frontend/+/main/docs/get_the_code.md
@@ -61,9 +83,9 @@ There are a few options to keep an eye on the latest and greatest of DevTools de
61
83
  [What's new in DevTools]: https://developer.chrome.com/docs/devtools/news
62
84
  [Umar's Dev Tips]: https://umaar.com/dev-tips
63
85
  [g/devtools-reviews@chromium.org]: https://groups.google.com/a/chromium.org/forum/#!forum/devtools-reviews
64
- [view the log]: https://chromium.googlesource.com/devtools/devtools-frontend/+log/main
86
+ [commit log]: https://chromium.googlesource.com/devtools/devtools-frontend/+log/main
65
87
  [@ChromeDevTools]: http://x.com/ChromeDevTools
66
88
  [@DevToolsCommits]: http://x.com/DevToolsCommits
67
- [all open DevTools tickets]: http://goo.gle/devtools-bugs
89
+ [all open DevTools bugs]: http://goo.gle/devtools-bugs
68
90
  [g/google-chrome-developer-tools]: https://groups.google.com/forum/#!forum/google-chrome-developer-tools
69
91
  [goo.gle/devtools-bug]: http://goo.gle/devtools-bug
@@ -2,6 +2,7 @@
2
2
  "compilerOptions": {
3
3
  "module": "esnext",
4
4
  "target": "esnext",
5
+ "rootDirs": ["../../front_end", "../../out/Default/gen/front_end"],
5
6
  "checkJs": true,
6
7
  "allowJs": true,
7
8
 
@@ -13,6 +13,7 @@
13
13
  "webworker",
14
14
  "webworker.iterable"
15
15
  ],
16
+ "composite": false,
16
17
  "noEmit": true
17
18
  },
18
19
  "include": [
@@ -121,6 +121,31 @@ See the section about [Creating demos for crbugs](https://github.com/ChromeDevTo
121
121
  and check out the [README](https://github.com/ChromeDevTools/devtools-dbg-stories#readme) for more information about non-trivial test
122
122
  cases and the like.
123
123
 
124
+ ## Code review
125
+
126
+ - **AI pre-review (`ChromiumCodeReviewAgent`)**: Run `Commit-Queue+1`
127
+ (`git cl upload --cq-dry-run`) before adding human reviewers to the attention
128
+ set, and address or reply to `ERROR`/`WARNING` findings in the Gerrit Checks
129
+ tab. (Googlers: link `@chromium.org` and `@google.com` at
130
+ <https://chromium-review.googlesource.com/settings/#Identities>.)
131
+ - **Strict at module boundaries, relaxed inside module interiors**: Human and
132
+ automated reviews strictly enforce module boundaries: entrypoint exports,
133
+ cross-module imports and GN `visibility`, `core -> models -> ui -> panels`
134
+ layering, `SettingDescriptor` placement (lowest-layer rule), public
135
+ widget/component APIs, and CDP contracts. Implementation details behind a
136
+ module entrypoint are governed by tests and lint rules rather than subjective
137
+ style preferences.
138
+ - **Block-and-codify**: If a reviewer blocks a CL on an uncodified pattern,
139
+ that pattern should be codified within a week as an ESLint/Stylelint rule, a
140
+ GN visibility check, a test, or an in-tree review rule under
141
+ `.agents/rules/`.
142
+ - **Large-scale migrations**: Repo-wide migrations require an owner-approved
143
+ goal and mechanical verification (lint/typecheck/tests proving the target
144
+ state). Mechanical or test-only migration CLs that pass presubmit, tryjobs,
145
+ and `ChromiumCodeReviewAgent` with zero `ERROR`/`WARNING` findings may be
146
+ sent to any `COMMON_OWNERS` reviewer for a quick stamp rather than routing
147
+ exclusively to a single domain lead.
148
+
124
149
  ## Merges and cherry-picks
125
150
 
126
151
  _Merge request/approval is handled by Chromium Release Managers. DevTools follows [Chromium's merge criteria](https://chromium.googlesource.com/chromium/src.git/+/refs/heads/main/docs/process/merge_request.md#merge-criteria-phases). In exceptional cases please get in touch with hablich@chromium.org._
@@ -1272,8 +1272,12 @@ export const DEFAULT_VIEW = (input, _output, target) => {
1272
1272
  };
1273
1273
  ```
1274
1274
 
1275
- ### Pre-existing Widget Instances (`WrapperWidget`)
1276
- When embedding pre-existing `UI.Widget` instances that are created elsewhere (such as `UI.ViewManager` locations: `TabbedViewLocation.tabbedPane()`, `StackLocation.widget()`), render them declaratively using `${widget(UI.Widget.WrapperWidget, {widget: myWidgetInstance})}` instead of creating custom wrapper widget classes. `WrapperWidget` automatically forwards constraints and manages child widget attach/detach lifecycles.
1275
+ ### Avoid `WrapperWidget` for Child Widgets, `TabbedPane`, and `StackLocation`
1276
+ **Do NOT instantiate child widgets or layout containers (`new ChildWidget()`, `UI.TabbedPane.TabbedPane` / `tabbedLocation.tabbedPane()`, `StackLocation.widget()`, `UI.ListWidget.ListWidget`, `UI.SplitWidget.SplitWidget`) in the constructor/presenter and pass them via `ViewInput` to `UI.Widget.WrapperWidget`.**
1277
+ - **Child widgets:** Refactor the child widget to accept `element?: HTMLElement` in its constructor and setters for its state, and instantiate it declaratively in the view with `${widget(ChildWidget, {...})}`.
1278
+ - **`TabbedPane` and `StackLocation`:** Create tabbed panes and stack panes declaratively in the view using `<devtools-tabbed-pane>` (or `${widget(UI.TabbedPane.TabbedPane, ...)}`) and `<devtools-stack-pane>` rather than passing a `TabbedPane` or `StackLocation` widget instance through `ViewInput` to `WrapperWidget`.
1279
+
1280
+ `WrapperWidget` is only justified when reparenting a shared stateful singleton across multiple containers (such as `ConsoleView.instance()` or `SourcesView`) or bridging an opaque `UI.Widget` returned by an external factory. When using `WrapperWidget`, note that it sets `display: contents` on its `<devtools-widget>` host element, so never put sizing, border, or background classes on the `<devtools-widget>` hosting `WrapperWidget` (wrap it in a `<div>` instead).
1277
1281
 
1278
1282
  ### Preserving `showMode` Settings
1279
1283
  When migrating a `SplitWidget` that persists sidebar visibility (e.g. via `splitWidget.showModeSetting()`), bind the setting's value to the `<devtools-split-view show=${input.showMode}>` property (`Both`, `OnlyMain`, or `OnlySidebar`) to preserve user settings and layout state across sessions.
@@ -1531,7 +1535,7 @@ export class NodeIndicator extends UI.Widget.Widget {
1531
1535
  readonly #view: View;
1532
1536
 
1533
1537
  constructor(element?: HTMLElement, view = DEFAULT_VIEW) {
1534
- super(element, {useShadowDom: true});
1538
+ super(element, {useShadowDom: 'pure'});
1535
1539
  this.#view = view;
1536
1540
  }
1537
1541
 
@@ -1597,9 +1601,14 @@ ranges `10,2` and the current range `5,3` will also be highlighted.
1597
1601
 
1598
1602
  Replace the legacy imperative `UI.ListWidget.ListWidget` (which rendered inline editing controls and required custom delegates) with the modern `<devtools-list>` component.
1599
1603
 
1604
+ **Anti-pattern — Do NOT pass `list: UI.ListWidget.ListWidget` in `ViewInput` to `WrapperWidget`:**
1605
+ Do not keep `this.list = new UI.ListWidget.ListWidget(this)` and `implements UI.ListWidget.Delegate` on the presenter (imperatively calling `this.list.clear()`, `this.list.appendItem()`, `this.list.addNewItem()`), render `renderItem`/`beginEdit` into `DocumentFragment` adapters, and mount `this.list` via `UI.Widget.WrapperWidget`. That leaks a view widget into the presenter's state and misuses `WrapperWidget`. Instead:
1606
+ - **Recommended (`<devtools-list>`)**: Replace `UI.ListWidget` and `UI.ListWidget.Delegate` with `<devtools-list>`, passing pure data (`items`, `editingIndex`, `validationError`) and callbacks (`onEdit`, `onDelete`, `onCommitEdit`, `onCancelEdit`) in `ViewInput`, and rendering all markup inside `DEFAULT_VIEW`.
1607
+ - **Incremental fallback (if preserving legacy `ListWidget.Editor` DOM/screenshot goldens temporarily)**: Move `ListWidget` and `ListWidget.Delegate` ownership out of the presenter and into the view layer — pass only pure data and callbacks in `ViewInput`, encapsulate `ListWidget` + `ListWidget.Delegate` inside a small view-layer child `Widget` instantiated via `${widget(...)}` in `DEFAULT_VIEW`, and expose a narrow action callback on `ViewOutput` (e.g. `output.addNewItem = () => ...`) if needed.
1608
+
1600
1609
  ### Guidelines
1601
1610
  1. **Dialogue Modals for Complex Editors:** If the editor contains multiple input fields (e.g., location details, headers), show the editor in a modal card dialog powered by `UI.Dialog.Dialog`.
1602
- 2. **Inline Prompts for Trivial Editors:** If the editor is trivial (i.e., a single text input, such as URL pattern blocking rules), handle editing inline using a `<devtools-prompt>` component. In this case, clicking the item focuses the prompt and toggles `editing` mode inline, dispatching `@commit` and `@cancel` events to update the state. See `RequestConditionsDrawer` for a reference implementation.
1611
+ 2. **Inline Prompts or Rows for Trivial Editors:** If the editor is trivial (i.e., a single text input, such as URL pattern or regex ignore-list rules), handle editing inline using a `<devtools-prompt>` component (see `RequestConditionsDrawer.ts`) or an inline editor row in the template (see `EditFileSystemView.ts`). When using `<devtools-prompt>`, clicking the item focuses the prompt and toggles `editing` mode inline, dispatching `@commit` and `@cancel` events to update the state.
1603
1612
  3. **Conditionally render list:** Use `<devtools-list>` and conditionally render it inside the card only if the list has elements (`input.locations.length > 0`). This ensures empty state layout rules are correctly applied and prevents extra spacing/gaps.
1604
1613
  4. **Declarative dialog views:** Define the edit/add modal content in a separate, customizable view function (e.g. `DEFAULT_DIALOG_VIEW`). Instantiating `UI.Dialog.Dialog` in the class is fine, but its content rendering should be driven declaratively by the dialog view function.
1605
1614
  5. **Common styles integration:** Ensure `{includeCommonStyles: true}` is passed when rendering elements into the DOM inside test setups to import proper layout variables and global typography styles (e.g. Roboto).