chrome-devtools-frontend 1.0.1726686 → 1.0.1730971

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (490) hide show
  1. package/.agents/rules/tests/test-strict-assertions-and-literal-expectations.md +1 -1
  2. package/.agents/rules/tests/test-view-and-presenter-isolation.md +1 -1
  3. package/.agents/rules/ui-and-widgets/ui-accessibility-and-semantic-html.md +1 -1
  4. package/.agents/rules/ui-and-widgets/ui-css-scoping-and-flex-layout.md +2 -2
  5. package/.agents/rules/ui-and-widgets/ui-declarative-child-widget-composition.md +5 -5
  6. package/.agents/rules/ui-and-widgets/ui-lit-declarative-templates-and-directives.md +2 -2
  7. package/.agents/rules/ui-and-widgets/ui-localization-and-uistrings-hygiene.md +2 -2
  8. package/.agents/rules/ui-and-widgets/ui-modern-component-and-encapsulation-standards.md +3 -3
  9. package/.agents/rules/ui-and-widgets/ui-pure-view-and-presenter-separation.md +2 -2
  10. package/.agents/rules/ui-and-widgets/ui-reactive-widget-update-lifecycle.md +2 -2
  11. package/.agents/rules/ui-and-widgets/ui-view-output-and-callback-contracts.md +2 -2
  12. package/.agents/rules/ui-and-widgets/ui-widget-dom-and-listener-lifecycle.md +2 -2
  13. package/.agents/skills/code-review/SKILL.md +63 -12
  14. package/.agents/skills/ui-eng-vision-local-lit-renderer/SKILL.md +38 -10
  15. package/.agents/skills/ui-eng-vision-widget-promoter/SKILL.md +1 -0
  16. package/.agents/skills/ui-widgets/SKILL.md +8 -2
  17. package/.agents/skills/write-ai-eval-test/SKILL.md +106 -0
  18. package/AUTHORS +2 -0
  19. package/DIR_METADATA +1 -2
  20. package/README.md +48 -26
  21. package/config/typescript/tsconfig.base.json +1 -0
  22. package/config/typescript/tsconfig.eslint.json +1 -0
  23. package/docs/contributing/changes.md +25 -0
  24. package/docs/ui_engineering.md +13 -4
  25. package/eslint.config.mjs +323 -41
  26. package/front_end/core/common/Color.ts +7 -7
  27. package/front_end/core/common/ParsedURL.ts +3 -3
  28. package/front_end/core/common/ResolverBase.ts +3 -3
  29. package/front_end/core/common/SegmentedRange.ts +3 -3
  30. package/front_end/core/common/SimpleHistoryManager.ts +14 -14
  31. package/front_end/core/common/Trie.ts +3 -3
  32. package/front_end/core/common/VersionController.ts +7 -7
  33. package/front_end/core/host/InspectorFrontendHost.ts +2 -2
  34. package/front_end/core/host/InspectorFrontendHostAPI.ts +9 -1
  35. package/front_end/core/host/InspectorFrontendHostStub.ts +1 -1
  36. package/front_end/core/host/UserMetrics.ts +4 -0
  37. package/front_end/core/host/UserMetricsEnums.ts +2 -1
  38. package/front_end/core/platform/StringUtilities.ts +54 -13
  39. package/front_end/core/platform/node/HostRuntime.ts +13 -7
  40. package/front_end/core/protocol_client/DevToolsCDPConnection.ts +4 -5
  41. package/front_end/core/root/Runtime.ts +5 -0
  42. package/front_end/core/sdk/AccessibilityModel.ts +5 -5
  43. package/front_end/core/sdk/AnimationModel.ts +17 -19
  44. package/front_end/core/sdk/CPUProfilerModel.ts +3 -3
  45. package/front_end/core/sdk/CPUThrottlingManager.ts +7 -0
  46. package/front_end/core/sdk/CSSMatchedStyles.ts +73 -13
  47. package/front_end/core/sdk/CSSMetadata.ts +7 -7
  48. package/front_end/core/sdk/CSSModel.ts +33 -33
  49. package/front_end/core/sdk/CSSProperty.ts +5 -5
  50. package/front_end/core/sdk/CSSRule.ts +6 -6
  51. package/front_end/core/sdk/CSSStyleSheetHeader.ts +4 -4
  52. package/front_end/core/sdk/Connections.ts +16 -16
  53. package/front_end/core/sdk/ConsoleModel.ts +44 -47
  54. package/front_end/core/sdk/CookieParser.ts +11 -11
  55. package/front_end/core/sdk/EmulationModel.ts +35 -36
  56. package/front_end/core/sdk/EventBreakpointsModel.ts +11 -11
  57. package/front_end/core/sdk/FrameManager.ts +16 -16
  58. package/front_end/core/sdk/IsolateManager.ts +2 -2
  59. package/front_end/core/sdk/IssuesModel.ts +2 -2
  60. package/front_end/core/sdk/OverlayModel.ts +19 -19
  61. package/front_end/core/sdk/PageResourceLoader.ts +14 -16
  62. package/front_end/core/sdk/RemoteObject.ts +9 -9
  63. package/front_end/core/sdk/Resource.ts +2 -2
  64. package/front_end/core/sdk/RuntimeModel.ts +7 -7
  65. package/front_end/core/sdk/Script.ts +6 -6
  66. package/front_end/core/sdk/ServiceWorkerManager.ts +36 -10
  67. package/front_end/core/sdk/SourceMap.ts +18 -20
  68. package/front_end/core/sdk/SourceMapManager.ts +2 -2
  69. package/front_end/core/sdk/TargetManager.ts +2 -2
  70. package/front_end/devtools_compatibility.js +7 -3
  71. package/front_end/entrypoints/inspector_main/InspectorMain.ts +2 -2
  72. package/front_end/entrypoints/node_app/app/NodeConnectionsPanel.ts +203 -115
  73. package/front_end/generated/InspectorBackendCommands.ts +1 -1
  74. package/front_end/generated/SupportedCSSProperties.ts +1 -3
  75. package/front_end/generated/protocol.ts +1 -0
  76. package/front_end/models/ai_assistance/AiAgent2.ts +36 -12
  77. package/front_end/models/ai_assistance/AiConversation.ts +8 -2
  78. package/front_end/models/ai_assistance/agents/AiAgent.ts +137 -62
  79. package/front_end/models/ai_assistance/agents/ExecuteJavascript.ts +2 -2
  80. package/front_end/models/ai_assistance/agents/StylingAgent.snapshot.txt +2 -2
  81. package/front_end/models/ai_assistance/data_formatters/LighthouseFormatter.snapshot.txt +149 -2
  82. package/front_end/models/ai_assistance/data_formatters/LighthouseFormatter.ts +269 -42
  83. package/front_end/models/ai_assistance/tools/ExecuteJavaScript.ts +3 -0
  84. package/front_end/models/ai_assistance/tools/GetLighthouseAudits.ts +9 -0
  85. package/front_end/models/ai_assistance/tools/ResolveDevtoolsNodePath.ts +13 -2
  86. package/front_end/models/ai_assistance/tools/RunLighthouse.ts +23 -7
  87. package/front_end/models/ai_assistance/tools/Tool.ts +7 -5
  88. package/front_end/models/bindings/CSSWorkspaceBinding.ts +22 -24
  89. package/front_end/models/bindings/DebuggerLanguagePlugins.ts +60 -60
  90. package/front_end/models/bindings/DebuggerWorkspaceBinding.ts +24 -24
  91. package/front_end/models/bindings/DefaultScriptMapping.ts +8 -8
  92. package/front_end/models/bindings/FileUtils.ts +13 -13
  93. package/front_end/models/bindings/PresentationConsoleMessageHelper.ts +3 -3
  94. package/front_end/models/bindings/ResourceScriptMapping.ts +23 -23
  95. package/front_end/models/comment_manager/CommentManager.ts +3 -3
  96. package/front_end/models/comment_manager/CommentThread.ts +50 -5
  97. package/front_end/models/cpu_profile/CPUProfileDataModel.ts +14 -14
  98. package/front_end/models/cpu_profile/ProfileTreeModel.ts +4 -4
  99. package/front_end/models/elements/StyleChanges.ts +38 -0
  100. package/front_end/models/emulation/EmulatedDevices.ts +12 -12
  101. package/front_end/models/har/HARFormat.ts +4 -4
  102. package/front_end/models/javascript_metadata/NativeFunctions.ts +5 -1
  103. package/front_end/models/lighthouse/LighthouseReporterTypes.ts +57 -3
  104. package/front_end/models/lighthouse/RunTypes.ts +9 -1
  105. package/front_end/models/logs/LogManager.ts +2 -2
  106. package/front_end/models/persistence/AutomaticFileSystemManager.ts +3 -0
  107. package/front_end/models/persistence/FileSystemWorkspaceBinding.ts +24 -24
  108. package/front_end/models/persistence/IsolatedFileSystemManager.ts +6 -0
  109. package/front_end/models/persistence/NetworkPersistenceManager.ts +8 -3
  110. package/front_end/models/trace/LanternComputationData.ts +37 -11
  111. package/front_end/models/trace/Processor.ts +2 -1
  112. package/front_end/models/trace/extras/TraceTree.ts +36 -10
  113. package/front_end/models/trace/handlers/InitiatorsHandler.ts +27 -34
  114. package/front_end/models/trace/handlers/LayoutShiftsHandler.ts +2 -6
  115. package/front_end/models/trace/handlers/SamplesHandler.ts +9 -6
  116. package/front_end/models/workspace/FileManager.ts +6 -0
  117. package/front_end/panels/accessibility/ARIAAttributesView.ts +4 -4
  118. package/front_end/panels/accessibility/AccessibilityAnnouncementRecordingView.ts +8 -1
  119. package/front_end/panels/accessibility/AccessibilityNodeView.ts +15 -17
  120. package/front_end/panels/accessibility/AccessibilitySubPane.ts +1 -1
  121. package/front_end/panels/ai_assistance/AiAssistancePanel.ts +5 -5
  122. package/front_end/panels/ai_assistance/ExternalHandler.ts +10 -1
  123. package/front_end/panels/ai_assistance/components/ChatMessage.ts +27 -22
  124. package/front_end/panels/ai_assistance/components/DisabledWidget.ts +19 -23
  125. package/front_end/panels/ai_assistance/components/ExploreWidget.ts +2 -2
  126. package/front_end/panels/ai_assistance/components/PermissionPrompt.ts +23 -9
  127. package/front_end/panels/ai_assistance/components/chatInput.css +1 -1
  128. package/front_end/panels/animation/AnimationTimeline.ts +37 -17
  129. package/front_end/panels/animation/animationTimeline.css +19 -3
  130. package/front_end/panels/application/AppManifestView.ts +1 -2
  131. package/front_end/panels/application/ApplicationPanelSidebar.ts +143 -128
  132. package/front_end/panels/application/DOMStorageItemsView.ts +14 -14
  133. package/front_end/panels/application/DeviceBoundSessionsView.ts +10 -13
  134. package/front_end/panels/application/ExtensionStorageItemsView.ts +3 -4
  135. package/front_end/panels/application/IndexedDBViews.ts +8 -4
  136. package/front_end/panels/application/KeyValueStorageItemsView.ts +4 -5
  137. package/front_end/panels/application/PrivateVerificationTokensView.ts +53 -0
  138. package/front_end/panels/application/ServiceWorkerCacheViews.ts +12 -8
  139. package/front_end/panels/application/ServiceWorkersView.ts +1 -2
  140. package/front_end/panels/application/StorageItemsToolbar.ts +3 -3
  141. package/front_end/panels/application/StorageView.ts +2 -2
  142. package/front_end/panels/application/WebMCPView.ts +91 -109
  143. package/front_end/panels/application/application.ts +2 -0
  144. package/front_end/panels/application/components/StorageMetadataView.ts +6 -6
  145. package/front_end/panels/application/preloading/PreloadingView.ts +70 -37
  146. package/front_end/panels/application/preloading/components/MismatchedPreloadingGrid.ts +2 -2
  147. package/front_end/panels/application/preloading/components/PreloadingDisabledInfobar.ts +3 -3
  148. package/front_end/panels/application/preloading/components/PreloadingGrid.ts +12 -0
  149. package/front_end/panels/application/preloading/components/RuleSetDetailsView.ts +10 -11
  150. package/front_end/panels/application/privateVerificationTokensView.css +20 -0
  151. package/front_end/panels/application/serviceWorkersView.css +2 -2
  152. package/front_end/panels/browser_debugger/DOMBreakpointsSidebarPane.ts +24 -24
  153. package/front_end/panels/changes/ChangesSidebar.ts +5 -5
  154. package/front_end/panels/changes/ChangesView.ts +10 -11
  155. package/front_end/panels/comments/CommentsPane.ts +292 -102
  156. package/front_end/panels/comments/commentsPane.css +93 -12
  157. package/front_end/panels/common/CommentThreadWidget.ts +69 -0
  158. package/front_end/panels/common/CommentsOverlayWidget.ts +108 -29
  159. package/front_end/panels/common/CommentsStatusBarPill.ts +17 -6
  160. package/front_end/panels/common/DOMLinkifier.ts +37 -12
  161. package/front_end/panels/common/ExtensionPanel.ts +13 -4
  162. package/front_end/panels/common/ExtensionServer.ts +27 -3
  163. package/front_end/panels/common/PersistenceUtils.ts +3 -3
  164. package/front_end/panels/common/commentThreadWidget.css +25 -1
  165. package/front_end/panels/common/common-meta.ts +10 -0
  166. package/front_end/panels/console/ConsolePinPane.ts +13 -15
  167. package/front_end/panels/console/ConsolePrompt.ts +173 -95
  168. package/front_end/panels/console/ConsoleSidebar.ts +2 -2
  169. package/front_end/panels/console/ConsoleView.ts +75 -79
  170. package/front_end/panels/console/ConsoleViewMessage.ts +52 -4
  171. package/front_end/panels/console/SymbolizedErrorWidget.ts +8 -4
  172. package/front_end/panels/console/consolePrompt.css +1 -1
  173. package/front_end/panels/console/consoleView.css +1 -1
  174. package/front_end/panels/console_counters/WarningErrorCounter.ts +3 -4
  175. package/front_end/panels/coverage/CoverageListView.ts +2 -2
  176. package/front_end/panels/coverage/CoverageView.ts +20 -5
  177. package/front_end/panels/css_overview/CSSOverviewCompletedView.ts +4 -3
  178. package/front_end/panels/css_overview/CSSOverviewPanel.ts +2 -2
  179. package/front_end/panels/css_overview/CSSOverviewProcessingView.ts +2 -2
  180. package/front_end/panels/css_overview/CSSOverviewSidebarPanel.ts +2 -2
  181. package/front_end/panels/css_overview/CSSOverviewStartView.ts +2 -2
  182. package/front_end/panels/css_overview/CSSOverviewUnusedDeclarations.ts +8 -8
  183. package/front_end/panels/developer_resources/DeveloperResourcesListView.ts +2 -3
  184. package/front_end/panels/developer_resources/DeveloperResourcesView.ts +4 -5
  185. package/front_end/panels/elements/AccessibilityTreeUtils.ts +6 -7
  186. package/front_end/panels/elements/CSSValueTraceView.ts +3 -3
  187. package/front_end/panels/elements/ClassesPaneWidget.ts +1 -2
  188. package/front_end/panels/elements/ComputedStyleWidget.ts +15 -14
  189. package/front_end/panels/elements/DOMTreeElementWidget.ts +5 -4
  190. package/front_end/panels/elements/DOMTreeWidget.ts +2 -1
  191. package/front_end/panels/elements/ElementStatePaneWidget.ts +2 -2
  192. package/front_end/panels/elements/ElementsPanel.ts +1 -0
  193. package/front_end/panels/elements/EventListenersWidget.ts +2 -2
  194. package/front_end/panels/elements/LayoutPane.ts +2 -2
  195. package/front_end/panels/elements/PlatformFontsWidget.ts +3 -3
  196. package/front_end/panels/elements/PropertiesWidget.ts +9 -10
  197. package/front_end/panels/elements/PropertyRenderer.ts +72 -11
  198. package/front_end/panels/elements/StandaloneStylesContainer.ts +5 -10
  199. package/front_end/panels/elements/StyleEditorWidget.ts +30 -16
  200. package/front_end/panels/elements/StylePropertiesSection.ts +93 -44
  201. package/front_end/panels/elements/StylePropertyTreeElement.ts +230 -302
  202. package/front_end/panels/elements/StylesContainer.ts +2 -3
  203. package/front_end/panels/elements/StylesSidebarPane.ts +4 -13
  204. package/front_end/panels/elements/components/AccessibilityTreeNode.ts +66 -37
  205. package/front_end/panels/elements/components/CSSHintDetailsView.ts +51 -41
  206. package/front_end/panels/elements/components/CSSPropertyDocsView.ts +75 -65
  207. package/front_end/panels/elements/components/CSSQuery.ts +112 -74
  208. package/front_end/panels/elements/components/CSSVariableValueView.ts +109 -68
  209. package/front_end/panels/elements/components/ComputedStyleProperty.ts +64 -45
  210. package/front_end/panels/elements/components/ElementsTreeExpandButton.ts +35 -28
  211. package/front_end/panels/elements/components/QueryContainer.ts +104 -74
  212. package/front_end/panels/elements/components/accessibilityTreeNode.css +22 -20
  213. package/front_end/panels/elements/components/computedStyleProperty.css +2 -0
  214. package/front_end/panels/elements/components/cssHintDetailsView.css +23 -21
  215. package/front_end/panels/elements/components/cssPropertyDocsView.css +38 -36
  216. package/front_end/panels/elements/components/cssVariableValueView.css +42 -40
  217. package/front_end/panels/elements/components/elementsTreeExpandButton.css +5 -2
  218. package/front_end/panels/elements/components/queryContainer.css +23 -21
  219. package/front_end/panels/elements/stylesSidebarPane.css +3 -3
  220. package/front_end/panels/emulation/DeviceModeToolbar.ts +2 -2
  221. package/front_end/panels/emulation/InspectedPagePlaceholder.ts +2 -2
  222. package/front_end/panels/emulation/MediaQueryInspector.ts +9 -10
  223. package/front_end/panels/emulation/mediaQueryInspector.css +1 -1
  224. package/front_end/panels/event_listeners/EventListenersView.ts +2 -2
  225. package/front_end/panels/issues/AffectedCookiesView.ts +144 -101
  226. package/front_end/panels/issues/AffectedDescendantsWithinSelectElementView.ts +83 -31
  227. package/front_end/panels/issues/AffectedDirectivesView.ts +218 -135
  228. package/front_end/panels/issues/AffectedDocumentsInQuirksModeView.ts +84 -34
  229. package/front_end/panels/issues/AffectedElementsView.ts +86 -23
  230. package/front_end/panels/issues/AffectedLazyLoadImagesView.ts +2 -2
  231. package/front_end/panels/issues/AffectedMetadataAllowedSitesView.ts +2 -2
  232. package/front_end/panels/issues/AffectedPartitioningBlobURLView.ts +36 -11
  233. package/front_end/panels/issues/AffectedSharedArrayBufferIssueDetailsView.ts +135 -58
  234. package/front_end/panels/issues/AffectedSourcesView.ts +49 -28
  235. package/front_end/panels/issues/AffectedTrackingSitesView.ts +3 -4
  236. package/front_end/panels/issues/CorsIssueDetailsView.ts +490 -269
  237. package/front_end/panels/issues/GenericIssueDetailsView.ts +2 -2
  238. package/front_end/panels/issues/IssueKindView.ts +63 -48
  239. package/front_end/panels/issues/IssueView.ts +14 -18
  240. package/front_end/panels/issues/components/ElementsPanelLink.ts +70 -34
  241. package/front_end/panels/issues/components/HideIssuesMenu.ts +56 -32
  242. package/front_end/panels/issues/components/elementsPanelLink.css +10 -6
  243. package/front_end/panels/issues/components/hideIssuesMenu.css +16 -14
  244. package/front_end/panels/issues/issues.ts +2 -0
  245. package/front_end/panels/issues/issuesTree.css +4 -4
  246. package/front_end/panels/lighthouse/LighthouseController.ts +6 -6
  247. package/front_end/panels/lighthouse/LighthouseStatusView.ts +12 -13
  248. package/front_end/panels/lighthouse/lighthouseStartView.css +1 -1
  249. package/front_end/panels/linear_memory_inspector/LinearMemoryInspectorPane.ts +159 -161
  250. package/front_end/panels/linear_memory_inspector/LinearMemoryInspectorView.ts +228 -0
  251. package/front_end/panels/linear_memory_inspector/components/LinearMemoryInspector.ts +32 -41
  252. package/front_end/panels/linear_memory_inspector/components/linearMemoryHighlightChipList.css +2 -2
  253. package/front_end/panels/linear_memory_inspector/linear_memory_inspector.ts +2 -0
  254. package/front_end/panels/media/EventDisplayTable.ts +2 -2
  255. package/front_end/panels/media/MainView.ts +132 -66
  256. package/front_end/panels/media/PlayerDetailView.ts +32 -14
  257. package/front_end/panels/media/PlayerListView.ts +83 -23
  258. package/front_end/panels/media/PlayerPropertiesView.ts +2 -2
  259. package/front_end/panels/media/TickingFlameChart.ts +153 -63
  260. package/front_end/panels/mobile_throttling/NetworkThrottlingSelector.ts +2 -2
  261. package/front_end/panels/mobile_throttling/ThrottlingSettingsTab.ts +615 -464
  262. package/front_end/panels/mobile_throttling/throttlingSettingsTab.css +43 -0
  263. package/front_end/panels/network/EventSourceMessagesView.ts +3 -3
  264. package/front_end/panels/network/NetworkConfigView.ts +6 -2
  265. package/front_end/panels/network/NetworkDataGridNode.ts +2 -1
  266. package/front_end/panels/network/NetworkItemView.ts +27 -26
  267. package/front_end/panels/network/NetworkManageCustomHeadersView.ts +236 -97
  268. package/front_end/panels/network/NetworkOverview.ts +8 -10
  269. package/front_end/panels/network/RequestConditionsDrawer.ts +8 -4
  270. package/front_end/panels/network/RequestDeviceBoundSessionsView.ts +2 -4
  271. package/front_end/panels/network/RequestHTMLView.ts +26 -7
  272. package/front_end/panels/network/RequestHeadersView.ts +2 -2
  273. package/front_end/panels/network/RequestInitiatorView.ts +21 -22
  274. package/front_end/panels/network/RequestPayloadView.ts +2 -16
  275. package/front_end/panels/network/RequestPreviewView.ts +5 -5
  276. package/front_end/panels/network/RequestTimingView.ts +6 -6
  277. package/front_end/panels/network/ResourceDirectSocketChunkView.ts +5 -6
  278. package/front_end/panels/network/ResourceWebSocketFrameView.ts +4 -3
  279. package/front_end/panels/network/ShowMoreDetailsWidget.ts +11 -12
  280. package/front_end/panels/network/SignedExchangeInfoView.ts +2 -2
  281. package/front_end/panels/network/networkLogView.css +2 -2
  282. package/front_end/panels/network/networkManageCustomHeadersView.css +27 -6
  283. package/front_end/panels/network/requestConditionsDrawer.css +1 -1
  284. package/front_end/panels/network/requestInitiatorView.css +5 -3
  285. package/front_end/panels/performance_monitor/PerformanceMonitor.ts +2 -2
  286. package/front_end/panels/profiler/HeapDetachedElementsView.ts +1 -2
  287. package/front_end/panels/profiler/HeapTimelineOverview.ts +77 -15
  288. package/front_end/panels/profiler/IsolateSelector.ts +258 -187
  289. package/front_end/panels/profiler/ProfileLauncherView.ts +7 -29
  290. package/front_end/panels/profiler/profileLauncherView.css +6 -1
  291. package/front_end/panels/protocol_monitor/JSONEditor.ts +4 -5
  292. package/front_end/panels/recorder/ControlButton.ts +1 -1
  293. package/front_end/panels/recorder/RecordingListView.ts +2 -4
  294. package/front_end/panels/recorder/RecordingView.ts +1 -2
  295. package/front_end/panels/recorder/SelectorPicker.ts +2 -4
  296. package/front_end/panels/recorder/StepView.ts +24 -10
  297. package/front_end/panels/recorder/TimelineSection.ts +1 -1
  298. package/front_end/panels/recorder/recordingView.css +1 -1
  299. package/front_end/panels/screencast/ScreencastApp.ts +1 -1
  300. package/front_end/panels/search/SearchResultsPane.ts +11 -12
  301. package/front_end/panels/search/SearchView.ts +8 -10
  302. package/front_end/panels/security/SecurityPanel.ts +1 -8
  303. package/front_end/panels/security/SecurityPanelSidebar.ts +2 -2
  304. package/front_end/panels/security/mainView.css +1 -1
  305. package/front_end/panels/sensors/LocationsSettingsTab.ts +1 -2
  306. package/front_end/panels/settings/AISettingsTab.ts +1 -1
  307. package/front_end/panels/settings/BackendLinkingSettingsTab.ts +34 -20
  308. package/front_end/panels/settings/EditFileSystemView.ts +2 -2
  309. package/front_end/panels/settings/FrameworkIgnoreListSettingsTab.ts +375 -197
  310. package/front_end/panels/settings/KeybindsSettingsTab.ts +570 -414
  311. package/front_end/panels/settings/SettingsScreen.ts +312 -114
  312. package/front_end/panels/settings/WorkspaceSettingsTab.ts +2 -2
  313. package/front_end/panels/settings/aiSettingsTab.css +1 -4
  314. package/front_end/panels/settings/emulation/DevicesSettingsTab.ts +924 -578
  315. package/front_end/panels/settings/emulation/components/UserAgentClientHintsForm.ts +9 -2
  316. package/front_end/panels/settings/emulation/devicesSettingsTab.css +39 -0
  317. package/front_end/panels/settings/frameworkIgnoreListSettingsTab.css +37 -8
  318. package/front_end/panels/settings/settingsScreen.css +0 -24
  319. package/front_end/panels/sources/BreakpointEditDialog.ts +9 -6
  320. package/front_end/panels/sources/BreakpointsView.ts +25 -4
  321. package/front_end/panels/sources/CallStackSidebarPane.ts +7 -1
  322. package/front_end/panels/sources/DebuggerPlugin.ts +1 -0
  323. package/front_end/panels/sources/GoToLineQuickOpen.ts +8 -8
  324. package/front_end/panels/sources/NavigatorView.ts +521 -439
  325. package/front_end/panels/sources/PersistenceActions.ts +11 -12
  326. package/front_end/panels/sources/ProfilePlugin.ts +28 -17
  327. package/front_end/panels/sources/ScopeChainSidebarPane.ts +3 -4
  328. package/front_end/panels/sources/SourcesNavigator.ts +9 -9
  329. package/front_end/panels/sources/SourcesPanel.ts +2 -2
  330. package/front_end/panels/sources/SourcesView.ts +3 -3
  331. package/front_end/panels/sources/ThreadsSidebarPane.ts +2 -2
  332. package/front_end/panels/sources/WatchExpressionsSidebarPane.ts +2 -2
  333. package/front_end/panels/sources/components/HeadersView.ts +1 -2
  334. package/front_end/panels/timeline/CompatibilityTracksAppender.ts +5 -6
  335. package/front_end/panels/timeline/EventsTimelineTreeView.ts +73 -34
  336. package/front_end/panels/timeline/IsolateSelector.ts +25 -37
  337. package/front_end/panels/timeline/StatusDialog.ts +5 -7
  338. package/front_end/panels/timeline/ThirdPartyTreeView.ts +10 -13
  339. package/front_end/panels/timeline/TimelineDetailsView.ts +40 -21
  340. package/front_end/panels/timeline/TimelineEventOverview.ts +130 -34
  341. package/front_end/panels/timeline/TimelineFlameChartNetworkDataProvider.ts +1 -1
  342. package/front_end/panels/timeline/TimelineMiniMap.ts +255 -103
  343. package/front_end/panels/timeline/TimelinePaintProfilerView.ts +19 -11
  344. package/front_end/panels/timeline/TimelinePanel.ts +1 -0
  345. package/front_end/panels/timeline/TimelineSelectorStatsView.ts +11 -12
  346. package/front_end/panels/timeline/TimelineTreeView.ts +240 -122
  347. package/front_end/panels/timeline/TimelineUIUtils.ts +12 -0
  348. package/front_end/panels/timeline/components/BreadcrumbsUI.ts +5 -4
  349. package/front_end/panels/timeline/components/DetailsView.ts +97 -65
  350. package/front_end/panels/timeline/components/LayoutShiftDetails.ts +2 -2
  351. package/front_end/panels/timeline/components/MetricCard.ts +2 -2
  352. package/front_end/panels/timeline/components/NetworkRequestDetails.ts +11 -12
  353. package/front_end/panels/timeline/components/NetworkTrackWidget.ts +57 -50
  354. package/front_end/panels/timeline/components/RelatedInsightChips.ts +2 -2
  355. package/front_end/panels/timeline/components/Sidebar.ts +161 -109
  356. package/front_end/panels/timeline/components/SidebarAnnotationsTab.ts +33 -12
  357. package/front_end/panels/timeline/components/SidebarInsightsTab.ts +3 -0
  358. package/front_end/panels/timeline/components/insights/LCPDiscovery.ts +11 -11
  359. package/front_end/panels/timeline/components/insights/SlowCSSSelector.ts +6 -7
  360. package/front_end/panels/timeline/components/networkTrackWidget.css +24 -22
  361. package/front_end/panels/timeline/components/sidebarInsightsTab.css +1 -1
  362. package/front_end/panels/timeline/overlays/components/TimespanBreakdownOverlay.ts +15 -10
  363. package/front_end/panels/timeline/overlays/components/entryLabelOverlay.css +1 -1
  364. package/front_end/panels/timeline/timelinePanel.css +5 -0
  365. package/front_end/panels/timeline/timelineStatusDialog.css +1 -1
  366. package/front_end/panels/web_audio/WebAudioView.ts +2 -2
  367. package/front_end/third_party/chromium/README.chromium +1 -1
  368. package/front_end/third_party/legacy-javascript/README.chromium +2 -2
  369. package/front_end/third_party/legacy-javascript/lib/legacy-javascript.js +2 -2
  370. package/front_end/third_party/legacy-javascript/package.json +1 -1
  371. package/front_end/third_party/lighthouse/README.chromium +2 -2
  372. package/front_end/third_party/lighthouse/lighthouse-dt-bundle.js +1983 -2022
  373. package/front_end/third_party/lighthouse/locales/ar-XB.json +157 -142
  374. package/front_end/third_party/lighthouse/locales/ar.json +157 -142
  375. package/front_end/third_party/lighthouse/locales/bg.json +154 -139
  376. package/front_end/third_party/lighthouse/locales/ca.json +157 -142
  377. package/front_end/third_party/lighthouse/locales/cs.json +148 -133
  378. package/front_end/third_party/lighthouse/locales/da.json +153 -138
  379. package/front_end/third_party/lighthouse/locales/de.json +152 -137
  380. package/front_end/third_party/lighthouse/locales/el.json +153 -138
  381. package/front_end/third_party/lighthouse/locales/en-GB.json +160 -145
  382. package/front_end/third_party/lighthouse/locales/en-US.json +239 -218
  383. package/front_end/third_party/lighthouse/locales/en-XL.json +239 -218
  384. package/front_end/third_party/lighthouse/locales/es-419.json +150 -135
  385. package/front_end/third_party/lighthouse/locales/es.json +149 -134
  386. package/front_end/third_party/lighthouse/locales/fi.json +151 -136
  387. package/front_end/third_party/lighthouse/locales/fil.json +154 -139
  388. package/front_end/third_party/lighthouse/locales/fr.json +150 -135
  389. package/front_end/third_party/lighthouse/locales/he.json +160 -145
  390. package/front_end/third_party/lighthouse/locales/hi.json +156 -141
  391. package/front_end/third_party/lighthouse/locales/hr.json +154 -139
  392. package/front_end/third_party/lighthouse/locales/hu.json +111 -96
  393. package/front_end/third_party/lighthouse/locales/id.json +153 -138
  394. package/front_end/third_party/lighthouse/locales/it.json +153 -138
  395. package/front_end/third_party/lighthouse/locales/ja.json +150 -135
  396. package/front_end/third_party/lighthouse/locales/ko.json +42 -27
  397. package/front_end/third_party/lighthouse/locales/lt.json +152 -137
  398. package/front_end/third_party/lighthouse/locales/lv.json +93 -78
  399. package/front_end/third_party/lighthouse/locales/nl.json +149 -134
  400. package/front_end/third_party/lighthouse/locales/no.json +152 -137
  401. package/front_end/third_party/lighthouse/locales/pl.json +153 -138
  402. package/front_end/third_party/lighthouse/locales/pt-PT.json +152 -137
  403. package/front_end/third_party/lighthouse/locales/pt.json +157 -142
  404. package/front_end/third_party/lighthouse/locales/ro.json +149 -134
  405. package/front_end/third_party/lighthouse/locales/ru.json +76 -61
  406. package/front_end/third_party/lighthouse/locales/sk.json +153 -138
  407. package/front_end/third_party/lighthouse/locales/sl.json +149 -134
  408. package/front_end/third_party/lighthouse/locales/sr-Latn.json +151 -136
  409. package/front_end/third_party/lighthouse/locales/sr.json +151 -136
  410. package/front_end/third_party/lighthouse/locales/sv.json +152 -137
  411. package/front_end/third_party/lighthouse/locales/ta.json +156 -141
  412. package/front_end/third_party/lighthouse/locales/te.json +157 -142
  413. package/front_end/third_party/lighthouse/locales/th.json +111 -96
  414. package/front_end/third_party/lighthouse/locales/tr.json +153 -138
  415. package/front_end/third_party/lighthouse/locales/uk.json +149 -134
  416. package/front_end/third_party/lighthouse/locales/vi.json +162 -147
  417. package/front_end/third_party/lighthouse/locales/zh-HK.json +150 -135
  418. package/front_end/third_party/lighthouse/locales/zh-TW.json +154 -139
  419. package/front_end/third_party/lighthouse/locales/zh.json +152 -137
  420. package/front_end/third_party/lighthouse/report/bundle.d.ts +9 -8
  421. package/front_end/third_party/lighthouse/report/bundle.js +10 -10
  422. package/front_end/third_party/lighthouse/report-assets/report-generator.mjs +2 -7
  423. package/front_end/tsconfig.compatibility.json +1 -0
  424. package/front_end/tsconfig.json +3 -2
  425. package/front_end/ui/components/dialogs/TypeToAllowDialog.ts +0 -2
  426. package/front_end/ui/components/dialogs/typeToAllowDialog.css +0 -4
  427. package/front_end/ui/components/icon_button/fileSourceIcon.css +1 -1
  428. package/front_end/ui/components/input/textInput.css +1 -1
  429. package/front_end/ui/components/lists/List.ts +26 -14
  430. package/front_end/ui/components/menus/menus.ts +0 -2
  431. package/front_end/ui/components/suggestion_input/SuggestionInput.ts +351 -138
  432. package/front_end/ui/components/survey_link/surveyLink.css +3 -3
  433. package/front_end/ui/components/switch/switch.css +6 -6
  434. package/front_end/ui/components/text_editor/AiCodeCompletionTeaser.ts +2 -3
  435. package/front_end/ui/components/text_editor/TextEditor.ts +1 -1
  436. package/front_end/ui/components/tooltips/Tooltip.ts +53 -4
  437. package/front_end/ui/components/tree_outline/treeOutline.css +7 -7
  438. package/front_end/ui/helpers/OpenInNewTab.ts +8 -3
  439. package/front_end/ui/legacy/EmptyWidget.ts +4 -4
  440. package/front_end/ui/legacy/ForwardedInputEventHandler.ts +2 -2
  441. package/front_end/ui/legacy/GlassPane.ts +1 -1
  442. package/front_end/ui/legacy/KeyboardShortcut.ts +7 -7
  443. package/front_end/ui/legacy/RemoteDebuggingTerminatedScreen.ts +2 -2
  444. package/front_end/ui/legacy/TabbedPane.ts +198 -66
  445. package/front_end/ui/legacy/TargetCrashedScreen.ts +2 -2
  446. package/front_end/ui/legacy/UIUtils.ts +71 -68
  447. package/front_end/ui/legacy/View.ts +7 -4
  448. package/front_end/ui/legacy/ViewManager.ts +49 -37
  449. package/front_end/ui/legacy/Widget.ts +32 -12
  450. package/front_end/ui/legacy/components/cookie_table/CookiesTable.ts +2 -3
  451. package/front_end/ui/legacy/components/inline_editor/AnimationTimingUI.ts +8 -8
  452. package/front_end/ui/legacy/components/inline_editor/BezierUI.ts +8 -9
  453. package/front_end/ui/legacy/components/inline_editor/LinkSwatch.ts +2 -2
  454. package/front_end/ui/legacy/components/inline_editor/cssAngleEditor.css +1 -1
  455. package/front_end/ui/legacy/components/inline_editor/cssAngleSwatch.css +1 -1
  456. package/front_end/ui/legacy/components/object_ui/ObjectPropertiesSection.ts +45 -11
  457. package/front_end/ui/legacy/components/object_ui/RemoteObjectPreviewFormatter.ts +10 -12
  458. package/front_end/ui/legacy/components/perf_ui/ChartViewport.ts +102 -29
  459. package/front_end/ui/legacy/components/perf_ui/FlameChart.ts +148 -122
  460. package/front_end/ui/legacy/components/perf_ui/TimelineOverviewPane.ts +20 -14
  461. package/front_end/ui/legacy/components/quick_open/filteredListWidget.css +1 -1
  462. package/front_end/ui/legacy/components/source_frame/FontView.ts +29 -5
  463. package/front_end/ui/legacy/components/source_frame/ImageView.ts +79 -12
  464. package/front_end/ui/legacy/components/source_frame/JSONView.ts +20 -2
  465. package/front_end/ui/legacy/components/source_frame/PreviewFactory.ts +2 -2
  466. package/front_end/ui/legacy/components/source_frame/StreamingContentHexView.ts +6 -10
  467. package/front_end/ui/legacy/components/source_frame/XMLView.ts +11 -11
  468. package/front_end/ui/legacy/components/source_frame/fontView.css +7 -0
  469. package/front_end/ui/legacy/components/source_frame/imageView.css +7 -0
  470. package/front_end/ui/legacy/components/utils/JSPresentationUtils.ts +14 -3
  471. package/front_end/ui/legacy/components/utils/Linkifier.ts +126 -2
  472. package/front_end/ui/legacy/emptyWidget.css +2 -1
  473. package/front_end/ui/legacy/inspectorCommon.css +3 -3
  474. package/front_end/ui/legacy/smallBubble.css +1 -1
  475. package/front_end/ui/legacy/tabbedPane.css +6 -0
  476. package/front_end/ui/lit/Directives.ts +35 -18
  477. package/front_end/ui/lit/lit.ts +0 -2
  478. package/front_end/ui/lit/render.ts +0 -7
  479. package/front_end/ui/visual_logging/KnownContextValues.ts +5 -0
  480. package/package.json +1 -1
  481. package/vpython.toml +8 -0
  482. package/vpython.toml.uv.lock +3 -0
  483. package/.agents/skills/review-models-core/SKILL.md +0 -73
  484. package/.agents/skills/review-tests/SKILL.md +0 -67
  485. package/.agents/skills/review-ui-widgets/SKILL.md +0 -115
  486. package/front_end/generated/ARIAProperties.ts +0 -2686
  487. package/front_end/ui/components/menus/README.md +0 -119
  488. package/front_end/ui/components/menus/SelectMenu.ts +0 -473
  489. package/front_end/ui/components/menus/selectMenu.css +0 -54
  490. package/front_end/ui/components/menus/selectMenuButton.css +0 -108
@@ -68,14 +68,14 @@ export class GenericIssueDetailsView extends AffectedResourcesView {
68
68
  if (details.violatingNodeId) {
69
69
  const target = genericIssue.model()?.target() || null;
70
70
  element.appendChild(await this.createElementCell(
71
- {backendNodeId: details.violatingNodeId, nodeName: this.violatingNodeIdName(details.errorType), target},
71
+ {backendNodeId: details.violatingNodeId, nodeName: this.#violatingNodeIdName(details.errorType), target},
72
72
  genericIssue.getCategory()));
73
73
  }
74
74
 
75
75
  this.affectedResources.appendChild(element);
76
76
  }
77
77
 
78
- private violatingNodeIdName(errorType: Protocol.Audits.GenericIssueErrorType): Platform.UIString.LocalizedString {
78
+ #violatingNodeIdName(errorType: Protocol.Audits.GenericIssueErrorType): Platform.UIString.LocalizedString {
79
79
  switch (errorType) {
80
80
  case Protocol.Audits.GenericIssueErrorType.FormLabelForNameError:
81
81
  // Since the error is referencing the <label> tag, this string doesn't
@@ -1,19 +1,23 @@
1
1
  // Copyright 2021 The Chromium Authors
2
2
  // Use of this source code is governed by a BSD-style license that can be
3
3
  // found in the LICENSE file.
4
- /* eslint-disable @devtools/no-imperative-dom-api */
4
+
5
+ import '../../ui/components/adorners/adorners.js';
6
+ import '../../ui/kit/kit.js';
7
+ import './components/components.js';
5
8
 
6
9
  import * as Common from '../../core/common/common.js';
7
10
  import * as i18n from '../../core/i18n/i18n.js';
8
11
  import * as Platform from '../../core/platform/platform.js';
9
12
  import * as IssuesManager from '../../models/issues_manager/issues_manager.js';
10
- import * as Adorners from '../../ui/components/adorners/adorners.js';
11
13
  import * as IssueCounter from '../../ui/components/issue_counter/issue_counter.js';
12
- import {Icon} from '../../ui/kit/kit.js';
13
14
  import * as UI from '../../ui/legacy/legacy.js';
15
+ import {html, render} from '../../ui/lit/lit.js';
14
16
 
15
17
  import * as Components from './components/components.js';
16
18
 
19
+ const {widget} = UI.Widget;
20
+
17
21
  const UIStrings = {
18
22
  /**
19
23
  * @description Context menu item in the Issues panel to hide all current page errors.
@@ -60,14 +64,43 @@ export function getClassNameFromKind(kind: IssuesManager.Issue.IssueKind): strin
60
64
  }
61
65
  }
62
66
 
67
+ interface ViewInput {
68
+ iconName: string;
69
+ count: number;
70
+ title: Common.UIString.LocalizedString;
71
+ menuItemLabel: Common.UIString.LocalizedString;
72
+ menuItemAction: () => void;
73
+ }
74
+
75
+ type View = (input: ViewInput, output: undefined, target: HTMLElement) => void;
76
+
77
+ const DEFAULT_VIEW: View = (input, _output, target) => {
78
+ // clang-format off
79
+ render(html`
80
+ <div class="header">
81
+ <devtools-icon class="leading-issue-icon extra-large" .name=${input.iconName}></devtools-icon>
82
+ <devtools-adorner class="aggregated-issues-count" .name=${'countWrapper'}>
83
+ <span>${input.count}</span>
84
+ </devtools-adorner>
85
+ <div class="title">${input.title}</div>
86
+ <devtools-widget class="hide-available-issues" ${widget(Components.HideIssuesMenu.HideIssuesMenu, {
87
+ menuItemLabel: input.menuItemLabel,
88
+ menuItemAction: input.menuItemAction,
89
+ })}></devtools-widget>
90
+ </div>
91
+ `, target);
92
+ // clang-format on
93
+ };
94
+
63
95
  export class IssueKindView extends UI.TreeOutline.TreeElement {
64
96
  #kind: IssuesManager.Issue.IssueKind;
65
- #issueCount: HTMLElement;
97
+ #issueCount = 0;
98
+ readonly #view: View;
66
99
 
67
- constructor(kind: IssuesManager.Issue.IssueKind) {
100
+ constructor(kind: IssuesManager.Issue.IssueKind, view: View = DEFAULT_VIEW) {
68
101
  super(undefined, true, Platform.StringUtilities.toKebabCase(kind));
69
102
  this.#kind = kind;
70
- this.#issueCount = document.createElement('span');
103
+ this.#view = view;
71
104
 
72
105
  this.toggleOnClick = true;
73
106
  this.listItemElement.classList.add('issue-kind');
@@ -90,54 +123,36 @@ export class IssueKindView extends UI.TreeOutline.TreeElement {
90
123
  }
91
124
  }
92
125
 
93
- #appendHeader(): void {
94
- const header = document.createElement('div');
95
- header.classList.add('header');
96
-
97
- const issueKindIcon = new Icon();
98
- issueKindIcon.name = IssueCounter.IssueCounter.getIssueKindIconName(this.#kind);
99
- issueKindIcon.classList.add('leading-issue-icon', 'extra-large');
100
-
101
- const countAdorner = new Adorners.Adorner.Adorner();
102
- countAdorner.name = 'countWrapper';
103
- countAdorner.append(this.#issueCount);
104
- countAdorner.classList.add('aggregated-issues-count');
105
- this.#issueCount.textContent = '0';
106
-
107
- const title = document.createElement('div');
108
- title.classList.add('title');
109
- title.textContent = IssuesManager.Issue.getIssueKindName(this.#kind);
110
-
111
- const hideAvailableIssuesBtn = new Components.HideIssuesMenu.HideIssuesMenu();
112
- hideAvailableIssuesBtn.classList.add('hide-available-issues');
113
- hideAvailableIssuesBtn.data = {
114
- menuItemLabel: this.getHideAllCurrentKindString(),
115
- menuItemAction: () => {
116
- const setting = IssuesManager.IssuesManager.getHideIssueByCodeSetting();
117
- const values = setting.get();
118
- for (const issue of IssuesManager.IssuesManager.IssuesManager.instance().issues()) {
119
- if (issue.getKind() === this.#kind) {
120
- values[issue.code()] = IssuesManager.IssuesManager.IssueStatus.HIDDEN;
121
- }
122
- }
123
- setting.set(values);
124
- },
125
- };
126
-
127
- header.appendChild(issueKindIcon);
128
- header.appendChild(countAdorner);
129
- header.appendChild(title);
130
- header.appendChild(hideAvailableIssuesBtn);
131
-
132
- this.listItemElement.appendChild(header);
126
+ #render(): void {
127
+ this.#view(
128
+ {
129
+ iconName: IssueCounter.IssueCounter.getIssueKindIconName(this.#kind),
130
+ count: this.#issueCount,
131
+ title: IssuesManager.Issue.getIssueKindName(this.#kind),
132
+ menuItemLabel: this.getHideAllCurrentKindString(),
133
+ menuItemAction: () => {
134
+ const setting = IssuesManager.IssuesManager.getHideIssueByCodeSetting();
135
+ const values = setting.get();
136
+ for (const issue of IssuesManager.IssuesManager.IssuesManager.instance().issues()) {
137
+ if (issue.getKind() === this.#kind) {
138
+ values[issue.code()] = IssuesManager.IssuesManager.IssueStatus.HIDDEN;
139
+ }
140
+ }
141
+ setting.set(values);
142
+ },
143
+ },
144
+ undefined,
145
+ this.listItemElement,
146
+ );
133
147
  }
134
148
 
135
149
  override onattach(): void {
136
- this.#appendHeader();
150
+ this.#render();
137
151
  this.expand();
138
152
  }
139
153
 
140
154
  update(count: number): void {
141
- this.#issueCount.textContent = `${count}`;
155
+ this.#issueCount = count;
156
+ this.#render();
142
157
  }
143
158
  }
@@ -193,13 +193,12 @@ class AffectedMixedContentView extends AffectedResourcesView {
193
193
  cell.title = mixedContent.insecureURL;
194
194
  }
195
195
 
196
- this.appendIssueDetailCell(
197
- element, AffectedMixedContentView.translateStatus(mixedContent.resolutionStatus),
198
- 'affected-resource-mixed-content-info');
196
+ this.appendIssueDetailCell(element, AffectedMixedContentView.#translateStatus(mixedContent.resolutionStatus),
197
+ 'affected-resource-mixed-content-info');
199
198
  this.affectedResources.appendChild(element);
200
199
  }
201
200
 
202
- private static translateStatus(resolutionStatus: Protocol.Audits.MixedContentResolutionStatus):
201
+ static #translateStatus(resolutionStatus: Protocol.Audits.MixedContentResolutionStatus):
203
202
  Platform.UIString.LocalizedString {
204
203
  switch (resolutionStatus) {
205
204
  case Protocol.Audits.MixedContentResolutionStatus.MixedContentBlocked:
@@ -241,7 +240,7 @@ export class IssueView extends UI.TreeOutline.TreeElement {
241
240
  this.toggleOnClick = true;
242
241
  this.listItemElement.classList.add('issue');
243
242
  this.childrenListElement.classList.add('issue-body');
244
- this.childrenListElement.classList.add(IssueView.getBodyCSSClass(this.#issue.getKind()));
243
+ this.childrenListElement.classList.add(IssueView.#getBodyCSSClass(this.#issue.getKind()));
245
244
 
246
245
  this.affectedResources = this.#createAffectedResources();
247
246
  this.#affectedResourceViews = [
@@ -284,7 +283,7 @@ export class IssueView extends UI.TreeOutline.TreeElement {
284
283
  this.#affectedResourceViews.forEach(view => view.setIssue(issue));
285
284
  }
286
285
 
287
- private static getBodyCSSClass(issueKind: IssuesManager.Issue.IssueKind): string {
286
+ static #getBodyCSSClass(issueKind: IssuesManager.Issue.IssueKind): string {
288
287
  switch (issueKind) {
289
288
  case IssuesManager.Issue.IssueKind.BREAKING_CHANGE:
290
289
  return 'issue-kind-breaking-change';
@@ -356,7 +355,7 @@ export class IssueView extends UI.TreeOutline.TreeElement {
356
355
  title.textContent = this.#description.title;
357
356
  header.appendChild(title);
358
357
  if (this.#hiddenIssuesMenu) {
359
- header.appendChild(this.#hiddenIssuesMenu);
358
+ this.#hiddenIssuesMenu.show(header, undefined, /* suppressOrphanWidgetError= */ true);
360
359
  }
361
360
  this.#updateFromIssue();
362
361
  this.listItemElement.appendChild(header);
@@ -396,18 +395,15 @@ export class IssueView extends UI.TreeOutline.TreeElement {
396
395
  }
397
396
  this.listItemElement.classList.toggle('hidden-issue', this.#issue.isHidden());
398
397
  if (this.#hiddenIssuesMenu) {
399
- const data: Components.HideIssuesMenu.HiddenIssuesMenuData = {
400
- menuItemLabel: this.#issue.isHidden() ? i18nString(UIStrings.unhideIssuesLikeThis) :
401
- i18nString(UIStrings.hideIssuesLikeThis),
402
- menuItemAction: () => {
403
- const setting = IssuesManager.IssuesManager.getHideIssueByCodeSetting();
404
- const values = setting.get();
405
- values[this.#issue.code()] = this.#issue.isHidden() ? IssuesManager.IssuesManager.IssueStatus.UNHIDDEN :
406
- IssuesManager.IssuesManager.IssueStatus.HIDDEN;
407
- setting.set(values);
408
- },
398
+ this.#hiddenIssuesMenu.menuItemLabel = this.#issue.isHidden() ? i18nString(UIStrings.unhideIssuesLikeThis) :
399
+ i18nString(UIStrings.hideIssuesLikeThis);
400
+ this.#hiddenIssuesMenu.menuItemAction = () => {
401
+ const setting = IssuesManager.IssuesManager.getHideIssueByCodeSetting();
402
+ const values = setting.get();
403
+ values[this.#issue.code()] = this.#issue.isHidden() ? IssuesManager.IssuesManager.IssueStatus.UNHIDDEN :
404
+ IssuesManager.IssuesManager.IssueStatus.HIDDEN;
405
+ setting.set(values);
409
406
  };
410
- this.#hiddenIssuesMenu.data = data;
411
407
  }
412
408
  }
413
409
 
@@ -1,55 +1,91 @@
1
1
  // Copyright 2020 The Chromium Authors
2
2
  // Use of this source code is governed by a BSD-style license that can be
3
3
  // found in the LICENSE file.
4
- /* eslint-disable @devtools/no-lit-render-outside-of-view */
5
-
4
+ import * as UI from '../../../ui/legacy/legacy.js';
6
5
  import {html, render} from '../../../ui/lit/lit.js';
7
6
  import * as VisualLogging from '../../../ui/visual_logging/visual_logging.js';
8
7
 
9
8
  import elementsPanelLinkStyles from './elementsPanelLink.css.js';
10
9
 
10
+ export interface ViewInput {
11
+ onElementRevealIconClick: () => void;
12
+ onElementRevealIconMouseEnter: () => void;
13
+ onElementRevealIconMouseLeave: () => void;
14
+ }
15
+
16
+ export type View = (input: ViewInput, output: undefined, target: HTMLElement) => void;
17
+
18
+ export const DEFAULT_VIEW: View = (input, _output, target) => {
19
+ // clang-format off
20
+ render(html`
21
+ <style>${elementsPanelLinkStyles}</style>
22
+ <button
23
+ class="element-reveal-icon"
24
+ jslog=${VisualLogging.link('elements-panel').track({click: true})}
25
+ @click=${input.onElementRevealIconClick}
26
+ @mouseenter=${input.onElementRevealIconMouseEnter}
27
+ @mouseleave=${input.onElementRevealIconMouseLeave}></button>
28
+ `, target);
29
+ // clang-format on
30
+ };
31
+
11
32
  export interface ElementsPanelLinkData {
12
- onElementRevealIconClick: (event?: Event) => void;
13
- onElementRevealIconMouseEnter: (event?: Event) => void;
14
- onElementRevealIconMouseLeave: (event?: Event) => void;
33
+ onElementRevealIconClick: () => void;
34
+ onElementRevealIconMouseEnter: () => void;
35
+ onElementRevealIconMouseLeave: () => void;
15
36
  }
16
- export class ElementsPanelLink extends HTMLElement {
17
- readonly #shadow = this.attachShadow({mode: 'open'});
37
+ export class ElementsPanelLink extends UI.Widget.Widget {
38
+ #onElementRevealIconClick: () => void = () => {};
39
+ #onElementRevealIconMouseEnter: () => void = () => {};
40
+ #onElementRevealIconMouseLeave: () => void = () => {};
41
+ readonly #view: View;
42
+
43
+ constructor(element?: HTMLElement, view: View = DEFAULT_VIEW) {
44
+ super(element);
45
+ this.#view = view;
46
+ }
18
47
 
19
- #onElementRevealIconClick: ((event?: Event) => void) = () => {};
20
- #onElementRevealIconMouseEnter: ((event?: Event) => void) = () => {};
21
- #onElementRevealIconMouseLeave: ((event?: Event) => void) = () => {};
48
+ override wasShown(): void {
49
+ super.wasShown();
50
+ this.requestUpdate();
51
+ }
22
52
 
23
- set data(data: ElementsPanelLinkData) {
24
- this.#onElementRevealIconClick = data.onElementRevealIconClick;
25
- this.#onElementRevealIconMouseEnter = data.onElementRevealIconMouseEnter;
26
- this.#onElementRevealIconMouseLeave = data.onElementRevealIconMouseLeave;
27
- this.#update();
53
+ set onElementRevealIconClick(onElementRevealIconClick: () => void) {
54
+ if (this.#onElementRevealIconClick === onElementRevealIconClick) {
55
+ return;
56
+ }
57
+ this.#onElementRevealIconClick = onElementRevealIconClick;
58
+ this.requestUpdate();
28
59
  }
29
60
 
30
- #update(): void {
31
- this.#render();
61
+ set onElementRevealIconMouseEnter(onElementRevealIconMouseEnter: () => void) {
62
+ if (this.#onElementRevealIconMouseEnter === onElementRevealIconMouseEnter) {
63
+ return;
64
+ }
65
+ this.#onElementRevealIconMouseEnter = onElementRevealIconMouseEnter;
66
+ this.requestUpdate();
32
67
  }
33
68
 
34
- #render(): void {
35
- // clang-format off
36
- render(html`
37
- <style>${elementsPanelLinkStyles}</style>
38
- <span
39
- class="element-reveal-icon"
40
- jslog=${VisualLogging.link('elements-panel').track({click: true})}
41
- @click=${this.#onElementRevealIconClick}
42
- @mouseenter=${this.#onElementRevealIconMouseEnter}
43
- @mouseleave=${this.#onElementRevealIconMouseLeave}></span>
44
- `, this.#shadow, {host: this});
45
- // clang-format on
69
+ set onElementRevealIconMouseLeave(onElementRevealIconMouseLeave: () => void) {
70
+ if (this.#onElementRevealIconMouseLeave === onElementRevealIconMouseLeave) {
71
+ return;
72
+ }
73
+ this.#onElementRevealIconMouseLeave = onElementRevealIconMouseLeave;
74
+ this.requestUpdate();
46
75
  }
47
- }
48
76
 
49
- customElements.define('devtools-elements-panel-link', ElementsPanelLink);
77
+ set data(data: ElementsPanelLinkData) {
78
+ this.onElementRevealIconClick = data.onElementRevealIconClick;
79
+ this.onElementRevealIconMouseEnter = data.onElementRevealIconMouseEnter;
80
+ this.onElementRevealIconMouseLeave = data.onElementRevealIconMouseLeave;
81
+ }
50
82
 
51
- declare global {
52
- interface HTMLElementTagNameMap {
53
- 'devtools-elements-panel-link': ElementsPanelLink;
83
+ override performUpdate(): void {
84
+ this.#view({
85
+ onElementRevealIconClick: this.#onElementRevealIconClick,
86
+ onElementRevealIconMouseEnter: this.#onElementRevealIconMouseEnter,
87
+ onElementRevealIconMouseLeave: this.#onElementRevealIconMouseLeave,
88
+ },
89
+ undefined, this.contentElement);
54
90
  }
55
91
  }
@@ -1,7 +1,6 @@
1
1
  // Copyright 2021 The Chromium Authors
2
2
  // Use of this source code is governed by a BSD-style license that can be
3
3
  // found in the LICENSE file.
4
- /* eslint-disable @devtools/no-lit-render-outside-of-view */
5
4
 
6
5
  import * as Common from '../../../core/common/common.js';
7
6
  import * as i18n from '../../../core/i18n/i18n.js';
@@ -21,62 +20,87 @@ const UIStrings = {
21
20
  const str_ = i18n.i18n.registerUIStrings('panels/issues/components/HideIssuesMenu.ts', UIStrings);
22
21
  const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
23
22
 
24
- export interface HiddenIssuesMenuData {
23
+ export interface ViewInput {
25
24
  menuItemLabel: Common.UIString.LocalizedString;
26
25
  menuItemAction: () => void;
27
26
  }
28
27
 
29
- export class HideIssuesMenu extends HTMLElement {
30
- readonly #shadow: ShadowRoot = this.attachShadow({mode: 'open'});
31
- #menuItemLabel: Common.UIString.LocalizedString = Common.UIString.LocalizedEmptyString;
32
- #menuItemAction: () => void = () => {};
28
+ export type View = (input: ViewInput, output: undefined, target: HTMLElement|DocumentFragment) => void;
33
29
 
34
- set data(data: HiddenIssuesMenuData) {
35
- this.#menuItemLabel = data.menuItemLabel;
36
- this.#menuItemAction = data.menuItemAction;
37
- this.#render();
38
- }
39
-
40
- onMenuOpen(event: Event): void {
30
+ export const DEFAULT_VIEW: View = (input, _output, target) => {
31
+ const onMenuOpen = (event: Event): void => {
41
32
  event.stopPropagation();
42
- const buttonElement = this.#shadow.querySelector('devtools-button');
33
+ const buttonElement = event.currentTarget as HTMLElement | null;
43
34
  const contextMenu = new UI.ContextMenu.ContextMenu(event, {
44
35
  x: buttonElement?.getBoundingClientRect().left,
45
36
  y: buttonElement?.getBoundingClientRect().bottom,
46
37
  });
47
- contextMenu.headerSection().appendItem(
48
- this.#menuItemLabel, () => this.#menuItemAction(), {jslogContext: 'toggle-similar-issues'});
38
+ contextMenu.headerSection().appendItem(input.menuItemLabel, () => input.menuItemAction(),
39
+ {jslogContext: 'toggle-similar-issues'});
49
40
  void contextMenu.show();
50
- }
41
+ };
51
42
 
52
- onKeydown(event: KeyboardEvent): void {
43
+ const onKeydown = (event: KeyboardEvent): void => {
53
44
  if (event.key === 'Enter' || event.key === 'Space') {
54
45
  // Make sure we don't propagate 'Enter' or 'Space' key events to parents,
55
46
  // so that these get turned into 'click' events properly.
56
47
  event.stopImmediatePropagation();
57
48
  }
58
- }
49
+ };
59
50
 
60
- #render(): void {
61
- // Disabled until https://crbug.com/1079231 is fixed.
62
- // clang-format off
63
- render(html`
51
+ // Disabled until https://crbug.com/1079231 is fixed.
52
+ // clang-format off
53
+ render(html`
64
54
  <style>${hideIssuesMenuStyles}</style>
65
55
  <devtools-button
66
- .data=${{variant: Buttons.Button.Variant.ICON,iconName: 'dots-vertical', title: i18nString(UIStrings.tooltipTitle)} as Buttons.Button.ButtonData}
56
+ .data=${{variant: Buttons.Button.Variant.ICON, iconName: 'dots-vertical', title: i18nString(UIStrings.tooltipTitle)} as Buttons.Button.ButtonData}
67
57
  .jslogContext=${'hide-issues'}
68
58
  class="hide-issues-menu-btn"
69
- @click=${this.onMenuOpen}
70
- @keydown=${this.onKeydown}></devtools-button>
71
- `, this.#shadow, {host: this});
59
+ @click=${onMenuOpen}
60
+ @keydown=${onKeydown}></devtools-button>
61
+ `, target, {container: {classes: ['hide-issues-menu']}});
62
+ // clang-format on
63
+ };
64
+
65
+ export class HideIssuesMenu extends UI.Widget.Widget<ShadowRoot> {
66
+ #menuItemLabel: Common.UIString.LocalizedString = Common.UIString.LocalizedEmptyString;
67
+ #menuItemAction: () => void = () => {};
68
+ readonly #view: View;
69
+
70
+ constructor(element?: HTMLElement, view: View = DEFAULT_VIEW) {
71
+ super(element, {useShadowDom: 'pure'});
72
+ this.#view = view;
73
+ }
74
+
75
+ set menuItemLabel(menuItemLabel: Common.UIString.LocalizedString) {
76
+ if (this.#menuItemLabel === menuItemLabel) {
77
+ return;
78
+ }
79
+ this.#menuItemLabel = menuItemLabel;
80
+ this.requestUpdate();
72
81
  }
73
- }
74
82
 
75
- customElements.define('devtools-hide-issues-menu', HideIssuesMenu);
83
+ set menuItemAction(menuItemAction: () => void) {
84
+ if (this.#menuItemAction === menuItemAction) {
85
+ return;
86
+ }
87
+ this.#menuItemAction = menuItemAction;
88
+ this.requestUpdate();
89
+ }
76
90
 
77
- declare global {
91
+ override wasShown(): void {
92
+ super.wasShown();
93
+ this.requestUpdate();
94
+ }
78
95
 
79
- interface HTMLElementTagNameMap {
80
- 'devtools-hide-issues-menu': HideIssuesMenu;
96
+ override performUpdate(): void {
97
+ this.#view(
98
+ {
99
+ menuItemLabel: this.#menuItemLabel,
100
+ menuItemAction: this.#menuItemAction,
101
+ },
102
+ undefined,
103
+ this.contentElement,
104
+ );
81
105
  }
82
106
  }
@@ -4,10 +4,14 @@
4
4
  * found in the LICENSE file.
5
5
  */
6
6
 
7
- .element-reveal-icon {
8
- display: inline-block;
9
- width: var(--sys-size-9);
10
- height: var(--sys-size-9);
11
- mask-image: var(--image-file-select-element);
12
- background-color: var(--icon-default);
7
+ @scope to (devtools-widget > *) {
8
+ .element-reveal-icon {
9
+ display: inline-block;
10
+ width: var(--sys-size-9);
11
+ height: var(--sys-size-9);
12
+ mask-image: var(--image-file-select-element);
13
+ background-color: var(--icon-default);
14
+ border: none;
15
+ padding: 0;
16
+ }
13
17
  }
@@ -4,20 +4,22 @@
4
4
  * found in the LICENSE file.
5
5
  */
6
6
 
7
- .hide-issues-menu-btn {
8
- position: relative;
9
- display: flex;
10
- background-color: transparent;
11
- flex: none;
12
- align-items: center;
13
- justify-content: center;
14
- padding: 0;
15
- margin: 0 calc(-1 * var(--sys-size-2)) 0 var(--sys-size-3);
16
- overflow: hidden;
17
- border-radius: 0;
18
- border: none;
7
+ @scope to (devtools-widget > *) {
8
+ .hide-issues-menu-btn {
9
+ position: relative;
10
+ display: flex;
11
+ background-color: transparent;
12
+ flex: none;
13
+ align-items: center;
14
+ justify-content: center;
15
+ padding: 0;
16
+ margin: 0 calc(-1 * var(--sys-size-2)) 0 var(--sys-size-3);
17
+ overflow: hidden;
18
+ border-radius: 0;
19
+ border: none;
19
20
 
20
- &:hover > devtools-icon {
21
- color: var(--icon-default-hover);
21
+ &:hover > devtools-icon {
22
+ color: var(--icon-default-hover);
23
+ }
22
24
  }
23
25
  }
@@ -2,6 +2,7 @@
2
2
  // Use of this source code is governed by a BSD-style license that can be
3
3
  // found in the LICENSE file.
4
4
 
5
+ import * as AffectedDescendantsWithinSelectElementView from './AffectedDescendantsWithinSelectElementView.js';
5
6
  import * as AffectedElementsView from './AffectedElementsView.js';
6
7
  import * as AffectedLazyLoadImagesView from './AffectedLazyLoadImagesView.js';
7
8
  import * as AffectedMetadataAllowedSitesView from './AffectedMetadataAllowedSitesView.js';
@@ -11,6 +12,7 @@ import * as IssuesPane from './IssuesPane.js';
11
12
  import * as IssueView from './IssueView.js';
12
13
 
13
14
  export {
15
+ AffectedDescendantsWithinSelectElementView,
14
16
  AffectedElementsView,
15
17
  AffectedLazyLoadImagesView,
16
18
  AffectedMetadataAllowedSitesView,
@@ -117,12 +117,13 @@ p {
117
117
  }
118
118
  }
119
119
 
120
- .header devtools-hide-issues-menu {
120
+ .header .hide-issues-menu {
121
121
  visibility: hidden;
122
+ flex: none;
122
123
  }
123
124
 
124
- .header:hover devtools-hide-issues-menu,
125
- .issue.selected devtools-hide-issues-menu {
125
+ .header:hover .hide-issues-menu,
126
+ .issue.selected .hide-issues-menu {
126
127
  visibility: visible;
127
128
  }
128
129
 
@@ -304,7 +305,6 @@ ul > li.plain-enum::before {
304
305
 
305
306
  .affected-resource-element {
306
307
  font-size: var(--sys-typescale-body4-size);
307
- line-height: 18px;
308
308
  color: var(--sys-color-primary);
309
309
  border: 0;
310
310
  border-collapse: collapse;
@@ -9,7 +9,7 @@ import type * as Platform from '../../core/platform/platform.js';
9
9
  import * as SDK from '../../core/sdk/sdk.js';
10
10
  import * as Protocol from '../../generated/protocol.js';
11
11
  import * as EmulationModel from '../../models/emulation/emulation.js';
12
- import type * as LighthouseModel from '../../models/lighthouse/lighthouse.js';
12
+ import * as LighthouseModel from '../../models/lighthouse/lighthouse.js';
13
13
  import * as UI from '../../ui/legacy/legacy.js';
14
14
  import * as Emulation from '../emulation/emulation.js';
15
15
 
@@ -736,7 +736,7 @@ export function getPresets(): LighthouseModel.RunTypes.Preset[] {
736
736
  configID: 'performance',
737
737
  title: i18nLazyString(UIStrings.performance),
738
738
  description: i18nLazyString(UIStrings.howLongDoesThisAppTakeToShow),
739
- supportedModes: ['navigation', 'timespan', 'snapshot'],
739
+ supportedModes: LighthouseModel.RunTypes.CATEGORY_SUPPORTED_MODES.performance,
740
740
  userMetric: Host.UserMetrics.LighthouseCategoryUsed.PERFORMANCE,
741
741
  },
742
742
  {
@@ -744,7 +744,7 @@ export function getPresets(): LighthouseModel.RunTypes.Preset[] {
744
744
  configID: 'accessibility',
745
745
  title: i18nLazyString(UIStrings.accessibility),
746
746
  description: i18nLazyString(UIStrings.isThisPageUsableByPeopleWith),
747
- supportedModes: ['navigation', 'snapshot'],
747
+ supportedModes: LighthouseModel.RunTypes.CATEGORY_SUPPORTED_MODES.accessibility,
748
748
  userMetric: Host.UserMetrics.LighthouseCategoryUsed.ACCESSIBILITY,
749
749
  },
750
750
  {
@@ -752,7 +752,7 @@ export function getPresets(): LighthouseModel.RunTypes.Preset[] {
752
752
  configID: 'best-practices',
753
753
  title: i18nLazyString(UIStrings.bestPractices),
754
754
  description: i18nLazyString(UIStrings.doesThisPageFollowBestPractices),
755
- supportedModes: ['navigation', 'timespan', 'snapshot'],
755
+ supportedModes: LighthouseModel.RunTypes.CATEGORY_SUPPORTED_MODES['best-practices'],
756
756
  userMetric: Host.UserMetrics.LighthouseCategoryUsed.BEST_PRACTICES,
757
757
  },
758
758
  {
@@ -760,7 +760,7 @@ export function getPresets(): LighthouseModel.RunTypes.Preset[] {
760
760
  configID: 'seo',
761
761
  title: i18nLazyString(UIStrings.seo),
762
762
  description: i18nLazyString(UIStrings.isThisPageOptimizedForSearch),
763
- supportedModes: ['navigation', 'snapshot'],
763
+ supportedModes: LighthouseModel.RunTypes.CATEGORY_SUPPORTED_MODES.seo,
764
764
  userMetric: Host.UserMetrics.LighthouseCategoryUsed.SEO,
765
765
  },
766
766
  {
@@ -768,7 +768,7 @@ export function getPresets(): LighthouseModel.RunTypes.Preset[] {
768
768
  configID: 'agentic-browsing',
769
769
  title: i18nLazyString(UIStrings.agenticBrowsing),
770
770
  description: i18nLazyString(UIStrings.agenticBrowsingDescription),
771
- supportedModes: ['navigation', 'snapshot'],
771
+ supportedModes: LighthouseModel.RunTypes.CATEGORY_SUPPORTED_MODES['agentic-browsing'],
772
772
  userMetric: Host.UserMetrics.LighthouseCategoryUsed.AGENTIC_BROWSING,
773
773
  },
774
774
  ];