chrome-devtools-frontend 1.0.1726686 → 1.0.1730971

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (490) hide show
  1. package/.agents/rules/tests/test-strict-assertions-and-literal-expectations.md +1 -1
  2. package/.agents/rules/tests/test-view-and-presenter-isolation.md +1 -1
  3. package/.agents/rules/ui-and-widgets/ui-accessibility-and-semantic-html.md +1 -1
  4. package/.agents/rules/ui-and-widgets/ui-css-scoping-and-flex-layout.md +2 -2
  5. package/.agents/rules/ui-and-widgets/ui-declarative-child-widget-composition.md +5 -5
  6. package/.agents/rules/ui-and-widgets/ui-lit-declarative-templates-and-directives.md +2 -2
  7. package/.agents/rules/ui-and-widgets/ui-localization-and-uistrings-hygiene.md +2 -2
  8. package/.agents/rules/ui-and-widgets/ui-modern-component-and-encapsulation-standards.md +3 -3
  9. package/.agents/rules/ui-and-widgets/ui-pure-view-and-presenter-separation.md +2 -2
  10. package/.agents/rules/ui-and-widgets/ui-reactive-widget-update-lifecycle.md +2 -2
  11. package/.agents/rules/ui-and-widgets/ui-view-output-and-callback-contracts.md +2 -2
  12. package/.agents/rules/ui-and-widgets/ui-widget-dom-and-listener-lifecycle.md +2 -2
  13. package/.agents/skills/code-review/SKILL.md +63 -12
  14. package/.agents/skills/ui-eng-vision-local-lit-renderer/SKILL.md +38 -10
  15. package/.agents/skills/ui-eng-vision-widget-promoter/SKILL.md +1 -0
  16. package/.agents/skills/ui-widgets/SKILL.md +8 -2
  17. package/.agents/skills/write-ai-eval-test/SKILL.md +106 -0
  18. package/AUTHORS +2 -0
  19. package/DIR_METADATA +1 -2
  20. package/README.md +48 -26
  21. package/config/typescript/tsconfig.base.json +1 -0
  22. package/config/typescript/tsconfig.eslint.json +1 -0
  23. package/docs/contributing/changes.md +25 -0
  24. package/docs/ui_engineering.md +13 -4
  25. package/eslint.config.mjs +323 -41
  26. package/front_end/core/common/Color.ts +7 -7
  27. package/front_end/core/common/ParsedURL.ts +3 -3
  28. package/front_end/core/common/ResolverBase.ts +3 -3
  29. package/front_end/core/common/SegmentedRange.ts +3 -3
  30. package/front_end/core/common/SimpleHistoryManager.ts +14 -14
  31. package/front_end/core/common/Trie.ts +3 -3
  32. package/front_end/core/common/VersionController.ts +7 -7
  33. package/front_end/core/host/InspectorFrontendHost.ts +2 -2
  34. package/front_end/core/host/InspectorFrontendHostAPI.ts +9 -1
  35. package/front_end/core/host/InspectorFrontendHostStub.ts +1 -1
  36. package/front_end/core/host/UserMetrics.ts +4 -0
  37. package/front_end/core/host/UserMetricsEnums.ts +2 -1
  38. package/front_end/core/platform/StringUtilities.ts +54 -13
  39. package/front_end/core/platform/node/HostRuntime.ts +13 -7
  40. package/front_end/core/protocol_client/DevToolsCDPConnection.ts +4 -5
  41. package/front_end/core/root/Runtime.ts +5 -0
  42. package/front_end/core/sdk/AccessibilityModel.ts +5 -5
  43. package/front_end/core/sdk/AnimationModel.ts +17 -19
  44. package/front_end/core/sdk/CPUProfilerModel.ts +3 -3
  45. package/front_end/core/sdk/CPUThrottlingManager.ts +7 -0
  46. package/front_end/core/sdk/CSSMatchedStyles.ts +73 -13
  47. package/front_end/core/sdk/CSSMetadata.ts +7 -7
  48. package/front_end/core/sdk/CSSModel.ts +33 -33
  49. package/front_end/core/sdk/CSSProperty.ts +5 -5
  50. package/front_end/core/sdk/CSSRule.ts +6 -6
  51. package/front_end/core/sdk/CSSStyleSheetHeader.ts +4 -4
  52. package/front_end/core/sdk/Connections.ts +16 -16
  53. package/front_end/core/sdk/ConsoleModel.ts +44 -47
  54. package/front_end/core/sdk/CookieParser.ts +11 -11
  55. package/front_end/core/sdk/EmulationModel.ts +35 -36
  56. package/front_end/core/sdk/EventBreakpointsModel.ts +11 -11
  57. package/front_end/core/sdk/FrameManager.ts +16 -16
  58. package/front_end/core/sdk/IsolateManager.ts +2 -2
  59. package/front_end/core/sdk/IssuesModel.ts +2 -2
  60. package/front_end/core/sdk/OverlayModel.ts +19 -19
  61. package/front_end/core/sdk/PageResourceLoader.ts +14 -16
  62. package/front_end/core/sdk/RemoteObject.ts +9 -9
  63. package/front_end/core/sdk/Resource.ts +2 -2
  64. package/front_end/core/sdk/RuntimeModel.ts +7 -7
  65. package/front_end/core/sdk/Script.ts +6 -6
  66. package/front_end/core/sdk/ServiceWorkerManager.ts +36 -10
  67. package/front_end/core/sdk/SourceMap.ts +18 -20
  68. package/front_end/core/sdk/SourceMapManager.ts +2 -2
  69. package/front_end/core/sdk/TargetManager.ts +2 -2
  70. package/front_end/devtools_compatibility.js +7 -3
  71. package/front_end/entrypoints/inspector_main/InspectorMain.ts +2 -2
  72. package/front_end/entrypoints/node_app/app/NodeConnectionsPanel.ts +203 -115
  73. package/front_end/generated/InspectorBackendCommands.ts +1 -1
  74. package/front_end/generated/SupportedCSSProperties.ts +1 -3
  75. package/front_end/generated/protocol.ts +1 -0
  76. package/front_end/models/ai_assistance/AiAgent2.ts +36 -12
  77. package/front_end/models/ai_assistance/AiConversation.ts +8 -2
  78. package/front_end/models/ai_assistance/agents/AiAgent.ts +137 -62
  79. package/front_end/models/ai_assistance/agents/ExecuteJavascript.ts +2 -2
  80. package/front_end/models/ai_assistance/agents/StylingAgent.snapshot.txt +2 -2
  81. package/front_end/models/ai_assistance/data_formatters/LighthouseFormatter.snapshot.txt +149 -2
  82. package/front_end/models/ai_assistance/data_formatters/LighthouseFormatter.ts +269 -42
  83. package/front_end/models/ai_assistance/tools/ExecuteJavaScript.ts +3 -0
  84. package/front_end/models/ai_assistance/tools/GetLighthouseAudits.ts +9 -0
  85. package/front_end/models/ai_assistance/tools/ResolveDevtoolsNodePath.ts +13 -2
  86. package/front_end/models/ai_assistance/tools/RunLighthouse.ts +23 -7
  87. package/front_end/models/ai_assistance/tools/Tool.ts +7 -5
  88. package/front_end/models/bindings/CSSWorkspaceBinding.ts +22 -24
  89. package/front_end/models/bindings/DebuggerLanguagePlugins.ts +60 -60
  90. package/front_end/models/bindings/DebuggerWorkspaceBinding.ts +24 -24
  91. package/front_end/models/bindings/DefaultScriptMapping.ts +8 -8
  92. package/front_end/models/bindings/FileUtils.ts +13 -13
  93. package/front_end/models/bindings/PresentationConsoleMessageHelper.ts +3 -3
  94. package/front_end/models/bindings/ResourceScriptMapping.ts +23 -23
  95. package/front_end/models/comment_manager/CommentManager.ts +3 -3
  96. package/front_end/models/comment_manager/CommentThread.ts +50 -5
  97. package/front_end/models/cpu_profile/CPUProfileDataModel.ts +14 -14
  98. package/front_end/models/cpu_profile/ProfileTreeModel.ts +4 -4
  99. package/front_end/models/elements/StyleChanges.ts +38 -0
  100. package/front_end/models/emulation/EmulatedDevices.ts +12 -12
  101. package/front_end/models/har/HARFormat.ts +4 -4
  102. package/front_end/models/javascript_metadata/NativeFunctions.ts +5 -1
  103. package/front_end/models/lighthouse/LighthouseReporterTypes.ts +57 -3
  104. package/front_end/models/lighthouse/RunTypes.ts +9 -1
  105. package/front_end/models/logs/LogManager.ts +2 -2
  106. package/front_end/models/persistence/AutomaticFileSystemManager.ts +3 -0
  107. package/front_end/models/persistence/FileSystemWorkspaceBinding.ts +24 -24
  108. package/front_end/models/persistence/IsolatedFileSystemManager.ts +6 -0
  109. package/front_end/models/persistence/NetworkPersistenceManager.ts +8 -3
  110. package/front_end/models/trace/LanternComputationData.ts +37 -11
  111. package/front_end/models/trace/Processor.ts +2 -1
  112. package/front_end/models/trace/extras/TraceTree.ts +36 -10
  113. package/front_end/models/trace/handlers/InitiatorsHandler.ts +27 -34
  114. package/front_end/models/trace/handlers/LayoutShiftsHandler.ts +2 -6
  115. package/front_end/models/trace/handlers/SamplesHandler.ts +9 -6
  116. package/front_end/models/workspace/FileManager.ts +6 -0
  117. package/front_end/panels/accessibility/ARIAAttributesView.ts +4 -4
  118. package/front_end/panels/accessibility/AccessibilityAnnouncementRecordingView.ts +8 -1
  119. package/front_end/panels/accessibility/AccessibilityNodeView.ts +15 -17
  120. package/front_end/panels/accessibility/AccessibilitySubPane.ts +1 -1
  121. package/front_end/panels/ai_assistance/AiAssistancePanel.ts +5 -5
  122. package/front_end/panels/ai_assistance/ExternalHandler.ts +10 -1
  123. package/front_end/panels/ai_assistance/components/ChatMessage.ts +27 -22
  124. package/front_end/panels/ai_assistance/components/DisabledWidget.ts +19 -23
  125. package/front_end/panels/ai_assistance/components/ExploreWidget.ts +2 -2
  126. package/front_end/panels/ai_assistance/components/PermissionPrompt.ts +23 -9
  127. package/front_end/panels/ai_assistance/components/chatInput.css +1 -1
  128. package/front_end/panels/animation/AnimationTimeline.ts +37 -17
  129. package/front_end/panels/animation/animationTimeline.css +19 -3
  130. package/front_end/panels/application/AppManifestView.ts +1 -2
  131. package/front_end/panels/application/ApplicationPanelSidebar.ts +143 -128
  132. package/front_end/panels/application/DOMStorageItemsView.ts +14 -14
  133. package/front_end/panels/application/DeviceBoundSessionsView.ts +10 -13
  134. package/front_end/panels/application/ExtensionStorageItemsView.ts +3 -4
  135. package/front_end/panels/application/IndexedDBViews.ts +8 -4
  136. package/front_end/panels/application/KeyValueStorageItemsView.ts +4 -5
  137. package/front_end/panels/application/PrivateVerificationTokensView.ts +53 -0
  138. package/front_end/panels/application/ServiceWorkerCacheViews.ts +12 -8
  139. package/front_end/panels/application/ServiceWorkersView.ts +1 -2
  140. package/front_end/panels/application/StorageItemsToolbar.ts +3 -3
  141. package/front_end/panels/application/StorageView.ts +2 -2
  142. package/front_end/panels/application/WebMCPView.ts +91 -109
  143. package/front_end/panels/application/application.ts +2 -0
  144. package/front_end/panels/application/components/StorageMetadataView.ts +6 -6
  145. package/front_end/panels/application/preloading/PreloadingView.ts +70 -37
  146. package/front_end/panels/application/preloading/components/MismatchedPreloadingGrid.ts +2 -2
  147. package/front_end/panels/application/preloading/components/PreloadingDisabledInfobar.ts +3 -3
  148. package/front_end/panels/application/preloading/components/PreloadingGrid.ts +12 -0
  149. package/front_end/panels/application/preloading/components/RuleSetDetailsView.ts +10 -11
  150. package/front_end/panels/application/privateVerificationTokensView.css +20 -0
  151. package/front_end/panels/application/serviceWorkersView.css +2 -2
  152. package/front_end/panels/browser_debugger/DOMBreakpointsSidebarPane.ts +24 -24
  153. package/front_end/panels/changes/ChangesSidebar.ts +5 -5
  154. package/front_end/panels/changes/ChangesView.ts +10 -11
  155. package/front_end/panels/comments/CommentsPane.ts +292 -102
  156. package/front_end/panels/comments/commentsPane.css +93 -12
  157. package/front_end/panels/common/CommentThreadWidget.ts +69 -0
  158. package/front_end/panels/common/CommentsOverlayWidget.ts +108 -29
  159. package/front_end/panels/common/CommentsStatusBarPill.ts +17 -6
  160. package/front_end/panels/common/DOMLinkifier.ts +37 -12
  161. package/front_end/panels/common/ExtensionPanel.ts +13 -4
  162. package/front_end/panels/common/ExtensionServer.ts +27 -3
  163. package/front_end/panels/common/PersistenceUtils.ts +3 -3
  164. package/front_end/panels/common/commentThreadWidget.css +25 -1
  165. package/front_end/panels/common/common-meta.ts +10 -0
  166. package/front_end/panels/console/ConsolePinPane.ts +13 -15
  167. package/front_end/panels/console/ConsolePrompt.ts +173 -95
  168. package/front_end/panels/console/ConsoleSidebar.ts +2 -2
  169. package/front_end/panels/console/ConsoleView.ts +75 -79
  170. package/front_end/panels/console/ConsoleViewMessage.ts +52 -4
  171. package/front_end/panels/console/SymbolizedErrorWidget.ts +8 -4
  172. package/front_end/panels/console/consolePrompt.css +1 -1
  173. package/front_end/panels/console/consoleView.css +1 -1
  174. package/front_end/panels/console_counters/WarningErrorCounter.ts +3 -4
  175. package/front_end/panels/coverage/CoverageListView.ts +2 -2
  176. package/front_end/panels/coverage/CoverageView.ts +20 -5
  177. package/front_end/panels/css_overview/CSSOverviewCompletedView.ts +4 -3
  178. package/front_end/panels/css_overview/CSSOverviewPanel.ts +2 -2
  179. package/front_end/panels/css_overview/CSSOverviewProcessingView.ts +2 -2
  180. package/front_end/panels/css_overview/CSSOverviewSidebarPanel.ts +2 -2
  181. package/front_end/panels/css_overview/CSSOverviewStartView.ts +2 -2
  182. package/front_end/panels/css_overview/CSSOverviewUnusedDeclarations.ts +8 -8
  183. package/front_end/panels/developer_resources/DeveloperResourcesListView.ts +2 -3
  184. package/front_end/panels/developer_resources/DeveloperResourcesView.ts +4 -5
  185. package/front_end/panels/elements/AccessibilityTreeUtils.ts +6 -7
  186. package/front_end/panels/elements/CSSValueTraceView.ts +3 -3
  187. package/front_end/panels/elements/ClassesPaneWidget.ts +1 -2
  188. package/front_end/panels/elements/ComputedStyleWidget.ts +15 -14
  189. package/front_end/panels/elements/DOMTreeElementWidget.ts +5 -4
  190. package/front_end/panels/elements/DOMTreeWidget.ts +2 -1
  191. package/front_end/panels/elements/ElementStatePaneWidget.ts +2 -2
  192. package/front_end/panels/elements/ElementsPanel.ts +1 -0
  193. package/front_end/panels/elements/EventListenersWidget.ts +2 -2
  194. package/front_end/panels/elements/LayoutPane.ts +2 -2
  195. package/front_end/panels/elements/PlatformFontsWidget.ts +3 -3
  196. package/front_end/panels/elements/PropertiesWidget.ts +9 -10
  197. package/front_end/panels/elements/PropertyRenderer.ts +72 -11
  198. package/front_end/panels/elements/StandaloneStylesContainer.ts +5 -10
  199. package/front_end/panels/elements/StyleEditorWidget.ts +30 -16
  200. package/front_end/panels/elements/StylePropertiesSection.ts +93 -44
  201. package/front_end/panels/elements/StylePropertyTreeElement.ts +230 -302
  202. package/front_end/panels/elements/StylesContainer.ts +2 -3
  203. package/front_end/panels/elements/StylesSidebarPane.ts +4 -13
  204. package/front_end/panels/elements/components/AccessibilityTreeNode.ts +66 -37
  205. package/front_end/panels/elements/components/CSSHintDetailsView.ts +51 -41
  206. package/front_end/panels/elements/components/CSSPropertyDocsView.ts +75 -65
  207. package/front_end/panels/elements/components/CSSQuery.ts +112 -74
  208. package/front_end/panels/elements/components/CSSVariableValueView.ts +109 -68
  209. package/front_end/panels/elements/components/ComputedStyleProperty.ts +64 -45
  210. package/front_end/panels/elements/components/ElementsTreeExpandButton.ts +35 -28
  211. package/front_end/panels/elements/components/QueryContainer.ts +104 -74
  212. package/front_end/panels/elements/components/accessibilityTreeNode.css +22 -20
  213. package/front_end/panels/elements/components/computedStyleProperty.css +2 -0
  214. package/front_end/panels/elements/components/cssHintDetailsView.css +23 -21
  215. package/front_end/panels/elements/components/cssPropertyDocsView.css +38 -36
  216. package/front_end/panels/elements/components/cssVariableValueView.css +42 -40
  217. package/front_end/panels/elements/components/elementsTreeExpandButton.css +5 -2
  218. package/front_end/panels/elements/components/queryContainer.css +23 -21
  219. package/front_end/panels/elements/stylesSidebarPane.css +3 -3
  220. package/front_end/panels/emulation/DeviceModeToolbar.ts +2 -2
  221. package/front_end/panels/emulation/InspectedPagePlaceholder.ts +2 -2
  222. package/front_end/panels/emulation/MediaQueryInspector.ts +9 -10
  223. package/front_end/panels/emulation/mediaQueryInspector.css +1 -1
  224. package/front_end/panels/event_listeners/EventListenersView.ts +2 -2
  225. package/front_end/panels/issues/AffectedCookiesView.ts +144 -101
  226. package/front_end/panels/issues/AffectedDescendantsWithinSelectElementView.ts +83 -31
  227. package/front_end/panels/issues/AffectedDirectivesView.ts +218 -135
  228. package/front_end/panels/issues/AffectedDocumentsInQuirksModeView.ts +84 -34
  229. package/front_end/panels/issues/AffectedElementsView.ts +86 -23
  230. package/front_end/panels/issues/AffectedLazyLoadImagesView.ts +2 -2
  231. package/front_end/panels/issues/AffectedMetadataAllowedSitesView.ts +2 -2
  232. package/front_end/panels/issues/AffectedPartitioningBlobURLView.ts +36 -11
  233. package/front_end/panels/issues/AffectedSharedArrayBufferIssueDetailsView.ts +135 -58
  234. package/front_end/panels/issues/AffectedSourcesView.ts +49 -28
  235. package/front_end/panels/issues/AffectedTrackingSitesView.ts +3 -4
  236. package/front_end/panels/issues/CorsIssueDetailsView.ts +490 -269
  237. package/front_end/panels/issues/GenericIssueDetailsView.ts +2 -2
  238. package/front_end/panels/issues/IssueKindView.ts +63 -48
  239. package/front_end/panels/issues/IssueView.ts +14 -18
  240. package/front_end/panels/issues/components/ElementsPanelLink.ts +70 -34
  241. package/front_end/panels/issues/components/HideIssuesMenu.ts +56 -32
  242. package/front_end/panels/issues/components/elementsPanelLink.css +10 -6
  243. package/front_end/panels/issues/components/hideIssuesMenu.css +16 -14
  244. package/front_end/panels/issues/issues.ts +2 -0
  245. package/front_end/panels/issues/issuesTree.css +4 -4
  246. package/front_end/panels/lighthouse/LighthouseController.ts +6 -6
  247. package/front_end/panels/lighthouse/LighthouseStatusView.ts +12 -13
  248. package/front_end/panels/lighthouse/lighthouseStartView.css +1 -1
  249. package/front_end/panels/linear_memory_inspector/LinearMemoryInspectorPane.ts +159 -161
  250. package/front_end/panels/linear_memory_inspector/LinearMemoryInspectorView.ts +228 -0
  251. package/front_end/panels/linear_memory_inspector/components/LinearMemoryInspector.ts +32 -41
  252. package/front_end/panels/linear_memory_inspector/components/linearMemoryHighlightChipList.css +2 -2
  253. package/front_end/panels/linear_memory_inspector/linear_memory_inspector.ts +2 -0
  254. package/front_end/panels/media/EventDisplayTable.ts +2 -2
  255. package/front_end/panels/media/MainView.ts +132 -66
  256. package/front_end/panels/media/PlayerDetailView.ts +32 -14
  257. package/front_end/panels/media/PlayerListView.ts +83 -23
  258. package/front_end/panels/media/PlayerPropertiesView.ts +2 -2
  259. package/front_end/panels/media/TickingFlameChart.ts +153 -63
  260. package/front_end/panels/mobile_throttling/NetworkThrottlingSelector.ts +2 -2
  261. package/front_end/panels/mobile_throttling/ThrottlingSettingsTab.ts +615 -464
  262. package/front_end/panels/mobile_throttling/throttlingSettingsTab.css +43 -0
  263. package/front_end/panels/network/EventSourceMessagesView.ts +3 -3
  264. package/front_end/panels/network/NetworkConfigView.ts +6 -2
  265. package/front_end/panels/network/NetworkDataGridNode.ts +2 -1
  266. package/front_end/panels/network/NetworkItemView.ts +27 -26
  267. package/front_end/panels/network/NetworkManageCustomHeadersView.ts +236 -97
  268. package/front_end/panels/network/NetworkOverview.ts +8 -10
  269. package/front_end/panels/network/RequestConditionsDrawer.ts +8 -4
  270. package/front_end/panels/network/RequestDeviceBoundSessionsView.ts +2 -4
  271. package/front_end/panels/network/RequestHTMLView.ts +26 -7
  272. package/front_end/panels/network/RequestHeadersView.ts +2 -2
  273. package/front_end/panels/network/RequestInitiatorView.ts +21 -22
  274. package/front_end/panels/network/RequestPayloadView.ts +2 -16
  275. package/front_end/panels/network/RequestPreviewView.ts +5 -5
  276. package/front_end/panels/network/RequestTimingView.ts +6 -6
  277. package/front_end/panels/network/ResourceDirectSocketChunkView.ts +5 -6
  278. package/front_end/panels/network/ResourceWebSocketFrameView.ts +4 -3
  279. package/front_end/panels/network/ShowMoreDetailsWidget.ts +11 -12
  280. package/front_end/panels/network/SignedExchangeInfoView.ts +2 -2
  281. package/front_end/panels/network/networkLogView.css +2 -2
  282. package/front_end/panels/network/networkManageCustomHeadersView.css +27 -6
  283. package/front_end/panels/network/requestConditionsDrawer.css +1 -1
  284. package/front_end/panels/network/requestInitiatorView.css +5 -3
  285. package/front_end/panels/performance_monitor/PerformanceMonitor.ts +2 -2
  286. package/front_end/panels/profiler/HeapDetachedElementsView.ts +1 -2
  287. package/front_end/panels/profiler/HeapTimelineOverview.ts +77 -15
  288. package/front_end/panels/profiler/IsolateSelector.ts +258 -187
  289. package/front_end/panels/profiler/ProfileLauncherView.ts +7 -29
  290. package/front_end/panels/profiler/profileLauncherView.css +6 -1
  291. package/front_end/panels/protocol_monitor/JSONEditor.ts +4 -5
  292. package/front_end/panels/recorder/ControlButton.ts +1 -1
  293. package/front_end/panels/recorder/RecordingListView.ts +2 -4
  294. package/front_end/panels/recorder/RecordingView.ts +1 -2
  295. package/front_end/panels/recorder/SelectorPicker.ts +2 -4
  296. package/front_end/panels/recorder/StepView.ts +24 -10
  297. package/front_end/panels/recorder/TimelineSection.ts +1 -1
  298. package/front_end/panels/recorder/recordingView.css +1 -1
  299. package/front_end/panels/screencast/ScreencastApp.ts +1 -1
  300. package/front_end/panels/search/SearchResultsPane.ts +11 -12
  301. package/front_end/panels/search/SearchView.ts +8 -10
  302. package/front_end/panels/security/SecurityPanel.ts +1 -8
  303. package/front_end/panels/security/SecurityPanelSidebar.ts +2 -2
  304. package/front_end/panels/security/mainView.css +1 -1
  305. package/front_end/panels/sensors/LocationsSettingsTab.ts +1 -2
  306. package/front_end/panels/settings/AISettingsTab.ts +1 -1
  307. package/front_end/panels/settings/BackendLinkingSettingsTab.ts +34 -20
  308. package/front_end/panels/settings/EditFileSystemView.ts +2 -2
  309. package/front_end/panels/settings/FrameworkIgnoreListSettingsTab.ts +375 -197
  310. package/front_end/panels/settings/KeybindsSettingsTab.ts +570 -414
  311. package/front_end/panels/settings/SettingsScreen.ts +312 -114
  312. package/front_end/panels/settings/WorkspaceSettingsTab.ts +2 -2
  313. package/front_end/panels/settings/aiSettingsTab.css +1 -4
  314. package/front_end/panels/settings/emulation/DevicesSettingsTab.ts +924 -578
  315. package/front_end/panels/settings/emulation/components/UserAgentClientHintsForm.ts +9 -2
  316. package/front_end/panels/settings/emulation/devicesSettingsTab.css +39 -0
  317. package/front_end/panels/settings/frameworkIgnoreListSettingsTab.css +37 -8
  318. package/front_end/panels/settings/settingsScreen.css +0 -24
  319. package/front_end/panels/sources/BreakpointEditDialog.ts +9 -6
  320. package/front_end/panels/sources/BreakpointsView.ts +25 -4
  321. package/front_end/panels/sources/CallStackSidebarPane.ts +7 -1
  322. package/front_end/panels/sources/DebuggerPlugin.ts +1 -0
  323. package/front_end/panels/sources/GoToLineQuickOpen.ts +8 -8
  324. package/front_end/panels/sources/NavigatorView.ts +521 -439
  325. package/front_end/panels/sources/PersistenceActions.ts +11 -12
  326. package/front_end/panels/sources/ProfilePlugin.ts +28 -17
  327. package/front_end/panels/sources/ScopeChainSidebarPane.ts +3 -4
  328. package/front_end/panels/sources/SourcesNavigator.ts +9 -9
  329. package/front_end/panels/sources/SourcesPanel.ts +2 -2
  330. package/front_end/panels/sources/SourcesView.ts +3 -3
  331. package/front_end/panels/sources/ThreadsSidebarPane.ts +2 -2
  332. package/front_end/panels/sources/WatchExpressionsSidebarPane.ts +2 -2
  333. package/front_end/panels/sources/components/HeadersView.ts +1 -2
  334. package/front_end/panels/timeline/CompatibilityTracksAppender.ts +5 -6
  335. package/front_end/panels/timeline/EventsTimelineTreeView.ts +73 -34
  336. package/front_end/panels/timeline/IsolateSelector.ts +25 -37
  337. package/front_end/panels/timeline/StatusDialog.ts +5 -7
  338. package/front_end/panels/timeline/ThirdPartyTreeView.ts +10 -13
  339. package/front_end/panels/timeline/TimelineDetailsView.ts +40 -21
  340. package/front_end/panels/timeline/TimelineEventOverview.ts +130 -34
  341. package/front_end/panels/timeline/TimelineFlameChartNetworkDataProvider.ts +1 -1
  342. package/front_end/panels/timeline/TimelineMiniMap.ts +255 -103
  343. package/front_end/panels/timeline/TimelinePaintProfilerView.ts +19 -11
  344. package/front_end/panels/timeline/TimelinePanel.ts +1 -0
  345. package/front_end/panels/timeline/TimelineSelectorStatsView.ts +11 -12
  346. package/front_end/panels/timeline/TimelineTreeView.ts +240 -122
  347. package/front_end/panels/timeline/TimelineUIUtils.ts +12 -0
  348. package/front_end/panels/timeline/components/BreadcrumbsUI.ts +5 -4
  349. package/front_end/panels/timeline/components/DetailsView.ts +97 -65
  350. package/front_end/panels/timeline/components/LayoutShiftDetails.ts +2 -2
  351. package/front_end/panels/timeline/components/MetricCard.ts +2 -2
  352. package/front_end/panels/timeline/components/NetworkRequestDetails.ts +11 -12
  353. package/front_end/panels/timeline/components/NetworkTrackWidget.ts +57 -50
  354. package/front_end/panels/timeline/components/RelatedInsightChips.ts +2 -2
  355. package/front_end/panels/timeline/components/Sidebar.ts +161 -109
  356. package/front_end/panels/timeline/components/SidebarAnnotationsTab.ts +33 -12
  357. package/front_end/panels/timeline/components/SidebarInsightsTab.ts +3 -0
  358. package/front_end/panels/timeline/components/insights/LCPDiscovery.ts +11 -11
  359. package/front_end/panels/timeline/components/insights/SlowCSSSelector.ts +6 -7
  360. package/front_end/panels/timeline/components/networkTrackWidget.css +24 -22
  361. package/front_end/panels/timeline/components/sidebarInsightsTab.css +1 -1
  362. package/front_end/panels/timeline/overlays/components/TimespanBreakdownOverlay.ts +15 -10
  363. package/front_end/panels/timeline/overlays/components/entryLabelOverlay.css +1 -1
  364. package/front_end/panels/timeline/timelinePanel.css +5 -0
  365. package/front_end/panels/timeline/timelineStatusDialog.css +1 -1
  366. package/front_end/panels/web_audio/WebAudioView.ts +2 -2
  367. package/front_end/third_party/chromium/README.chromium +1 -1
  368. package/front_end/third_party/legacy-javascript/README.chromium +2 -2
  369. package/front_end/third_party/legacy-javascript/lib/legacy-javascript.js +2 -2
  370. package/front_end/third_party/legacy-javascript/package.json +1 -1
  371. package/front_end/third_party/lighthouse/README.chromium +2 -2
  372. package/front_end/third_party/lighthouse/lighthouse-dt-bundle.js +1983 -2022
  373. package/front_end/third_party/lighthouse/locales/ar-XB.json +157 -142
  374. package/front_end/third_party/lighthouse/locales/ar.json +157 -142
  375. package/front_end/third_party/lighthouse/locales/bg.json +154 -139
  376. package/front_end/third_party/lighthouse/locales/ca.json +157 -142
  377. package/front_end/third_party/lighthouse/locales/cs.json +148 -133
  378. package/front_end/third_party/lighthouse/locales/da.json +153 -138
  379. package/front_end/third_party/lighthouse/locales/de.json +152 -137
  380. package/front_end/third_party/lighthouse/locales/el.json +153 -138
  381. package/front_end/third_party/lighthouse/locales/en-GB.json +160 -145
  382. package/front_end/third_party/lighthouse/locales/en-US.json +239 -218
  383. package/front_end/third_party/lighthouse/locales/en-XL.json +239 -218
  384. package/front_end/third_party/lighthouse/locales/es-419.json +150 -135
  385. package/front_end/third_party/lighthouse/locales/es.json +149 -134
  386. package/front_end/third_party/lighthouse/locales/fi.json +151 -136
  387. package/front_end/third_party/lighthouse/locales/fil.json +154 -139
  388. package/front_end/third_party/lighthouse/locales/fr.json +150 -135
  389. package/front_end/third_party/lighthouse/locales/he.json +160 -145
  390. package/front_end/third_party/lighthouse/locales/hi.json +156 -141
  391. package/front_end/third_party/lighthouse/locales/hr.json +154 -139
  392. package/front_end/third_party/lighthouse/locales/hu.json +111 -96
  393. package/front_end/third_party/lighthouse/locales/id.json +153 -138
  394. package/front_end/third_party/lighthouse/locales/it.json +153 -138
  395. package/front_end/third_party/lighthouse/locales/ja.json +150 -135
  396. package/front_end/third_party/lighthouse/locales/ko.json +42 -27
  397. package/front_end/third_party/lighthouse/locales/lt.json +152 -137
  398. package/front_end/third_party/lighthouse/locales/lv.json +93 -78
  399. package/front_end/third_party/lighthouse/locales/nl.json +149 -134
  400. package/front_end/third_party/lighthouse/locales/no.json +152 -137
  401. package/front_end/third_party/lighthouse/locales/pl.json +153 -138
  402. package/front_end/third_party/lighthouse/locales/pt-PT.json +152 -137
  403. package/front_end/third_party/lighthouse/locales/pt.json +157 -142
  404. package/front_end/third_party/lighthouse/locales/ro.json +149 -134
  405. package/front_end/third_party/lighthouse/locales/ru.json +76 -61
  406. package/front_end/third_party/lighthouse/locales/sk.json +153 -138
  407. package/front_end/third_party/lighthouse/locales/sl.json +149 -134
  408. package/front_end/third_party/lighthouse/locales/sr-Latn.json +151 -136
  409. package/front_end/third_party/lighthouse/locales/sr.json +151 -136
  410. package/front_end/third_party/lighthouse/locales/sv.json +152 -137
  411. package/front_end/third_party/lighthouse/locales/ta.json +156 -141
  412. package/front_end/third_party/lighthouse/locales/te.json +157 -142
  413. package/front_end/third_party/lighthouse/locales/th.json +111 -96
  414. package/front_end/third_party/lighthouse/locales/tr.json +153 -138
  415. package/front_end/third_party/lighthouse/locales/uk.json +149 -134
  416. package/front_end/third_party/lighthouse/locales/vi.json +162 -147
  417. package/front_end/third_party/lighthouse/locales/zh-HK.json +150 -135
  418. package/front_end/third_party/lighthouse/locales/zh-TW.json +154 -139
  419. package/front_end/third_party/lighthouse/locales/zh.json +152 -137
  420. package/front_end/third_party/lighthouse/report/bundle.d.ts +9 -8
  421. package/front_end/third_party/lighthouse/report/bundle.js +10 -10
  422. package/front_end/third_party/lighthouse/report-assets/report-generator.mjs +2 -7
  423. package/front_end/tsconfig.compatibility.json +1 -0
  424. package/front_end/tsconfig.json +3 -2
  425. package/front_end/ui/components/dialogs/TypeToAllowDialog.ts +0 -2
  426. package/front_end/ui/components/dialogs/typeToAllowDialog.css +0 -4
  427. package/front_end/ui/components/icon_button/fileSourceIcon.css +1 -1
  428. package/front_end/ui/components/input/textInput.css +1 -1
  429. package/front_end/ui/components/lists/List.ts +26 -14
  430. package/front_end/ui/components/menus/menus.ts +0 -2
  431. package/front_end/ui/components/suggestion_input/SuggestionInput.ts +351 -138
  432. package/front_end/ui/components/survey_link/surveyLink.css +3 -3
  433. package/front_end/ui/components/switch/switch.css +6 -6
  434. package/front_end/ui/components/text_editor/AiCodeCompletionTeaser.ts +2 -3
  435. package/front_end/ui/components/text_editor/TextEditor.ts +1 -1
  436. package/front_end/ui/components/tooltips/Tooltip.ts +53 -4
  437. package/front_end/ui/components/tree_outline/treeOutline.css +7 -7
  438. package/front_end/ui/helpers/OpenInNewTab.ts +8 -3
  439. package/front_end/ui/legacy/EmptyWidget.ts +4 -4
  440. package/front_end/ui/legacy/ForwardedInputEventHandler.ts +2 -2
  441. package/front_end/ui/legacy/GlassPane.ts +1 -1
  442. package/front_end/ui/legacy/KeyboardShortcut.ts +7 -7
  443. package/front_end/ui/legacy/RemoteDebuggingTerminatedScreen.ts +2 -2
  444. package/front_end/ui/legacy/TabbedPane.ts +198 -66
  445. package/front_end/ui/legacy/TargetCrashedScreen.ts +2 -2
  446. package/front_end/ui/legacy/UIUtils.ts +71 -68
  447. package/front_end/ui/legacy/View.ts +7 -4
  448. package/front_end/ui/legacy/ViewManager.ts +49 -37
  449. package/front_end/ui/legacy/Widget.ts +32 -12
  450. package/front_end/ui/legacy/components/cookie_table/CookiesTable.ts +2 -3
  451. package/front_end/ui/legacy/components/inline_editor/AnimationTimingUI.ts +8 -8
  452. package/front_end/ui/legacy/components/inline_editor/BezierUI.ts +8 -9
  453. package/front_end/ui/legacy/components/inline_editor/LinkSwatch.ts +2 -2
  454. package/front_end/ui/legacy/components/inline_editor/cssAngleEditor.css +1 -1
  455. package/front_end/ui/legacy/components/inline_editor/cssAngleSwatch.css +1 -1
  456. package/front_end/ui/legacy/components/object_ui/ObjectPropertiesSection.ts +45 -11
  457. package/front_end/ui/legacy/components/object_ui/RemoteObjectPreviewFormatter.ts +10 -12
  458. package/front_end/ui/legacy/components/perf_ui/ChartViewport.ts +102 -29
  459. package/front_end/ui/legacy/components/perf_ui/FlameChart.ts +148 -122
  460. package/front_end/ui/legacy/components/perf_ui/TimelineOverviewPane.ts +20 -14
  461. package/front_end/ui/legacy/components/quick_open/filteredListWidget.css +1 -1
  462. package/front_end/ui/legacy/components/source_frame/FontView.ts +29 -5
  463. package/front_end/ui/legacy/components/source_frame/ImageView.ts +79 -12
  464. package/front_end/ui/legacy/components/source_frame/JSONView.ts +20 -2
  465. package/front_end/ui/legacy/components/source_frame/PreviewFactory.ts +2 -2
  466. package/front_end/ui/legacy/components/source_frame/StreamingContentHexView.ts +6 -10
  467. package/front_end/ui/legacy/components/source_frame/XMLView.ts +11 -11
  468. package/front_end/ui/legacy/components/source_frame/fontView.css +7 -0
  469. package/front_end/ui/legacy/components/source_frame/imageView.css +7 -0
  470. package/front_end/ui/legacy/components/utils/JSPresentationUtils.ts +14 -3
  471. package/front_end/ui/legacy/components/utils/Linkifier.ts +126 -2
  472. package/front_end/ui/legacy/emptyWidget.css +2 -1
  473. package/front_end/ui/legacy/inspectorCommon.css +3 -3
  474. package/front_end/ui/legacy/smallBubble.css +1 -1
  475. package/front_end/ui/legacy/tabbedPane.css +6 -0
  476. package/front_end/ui/lit/Directives.ts +35 -18
  477. package/front_end/ui/lit/lit.ts +0 -2
  478. package/front_end/ui/lit/render.ts +0 -7
  479. package/front_end/ui/visual_logging/KnownContextValues.ts +5 -0
  480. package/package.json +1 -1
  481. package/vpython.toml +8 -0
  482. package/vpython.toml.uv.lock +3 -0
  483. package/.agents/skills/review-models-core/SKILL.md +0 -73
  484. package/.agents/skills/review-tests/SKILL.md +0 -67
  485. package/.agents/skills/review-ui-widgets/SKILL.md +0 -115
  486. package/front_end/generated/ARIAProperties.ts +0 -2686
  487. package/front_end/ui/components/menus/README.md +0 -119
  488. package/front_end/ui/components/menus/SelectMenu.ts +0 -473
  489. package/front_end/ui/components/menus/selectMenu.css +0 -54
  490. package/front_end/ui/components/menus/selectMenuButton.css +0 -108
@@ -1,7 +1,8 @@
1
1
  // Copyright 2016 The Chromium Authors
2
2
  // Use of this source code is governed by a BSD-style license that can be
3
3
  // found in the LICENSE file.
4
- /* eslint-disable @devtools/no-imperative-dom-api */
4
+
5
+ import '../../ui/kit/kit.js';
5
6
 
6
7
  import * as Common from '../../core/common/common.js';
7
8
  import * as Host from '../../core/host/host.js';
@@ -14,15 +15,16 @@ import * as Formatter from '../../models/formatter/formatter.js';
14
15
  import * as SourceMapScopes from '../../models/source_map_scopes/source_map_scopes.js';
15
16
  import * as CodeMirror from '../../third_party/codemirror.next/codemirror.next.js';
16
17
  import * as TextEditor from '../../ui/components/text_editor/text_editor.js';
17
- import {Icon} from '../../ui/kit/kit.js';
18
18
  import * as ObjectUI from '../../ui/legacy/components/object_ui/object_ui.js';
19
19
  import * as UI from '../../ui/legacy/legacy.js';
20
+ import {Directives, html, nothing, render} from '../../ui/lit/lit.js';
20
21
  import * as Settings from '../../ui/settings/settings.js';
21
22
  import * as VisualLogging from '../../ui/visual_logging/visual_logging.js';
22
23
 
23
24
  import {ConsolePanel} from './ConsolePanel.js';
24
25
  import consolePromptStyles from './consolePrompt.css.js';
25
26
 
27
+ const {classMap, ref} = Directives;
26
28
  const {Direction} = TextEditor.TextEditorHistory;
27
29
 
28
30
  const UIStrings = {
@@ -31,13 +33,16 @@ const UIStrings = {
31
33
  */
32
34
  consolePrompt: 'Console prompt',
33
35
  /**
34
- * @description Warning shown to users when pasting text into the DevTools Console. IMPORTANT: keep double quotes around PH1 and do not use single quotes.
36
+ * @description Warning shown to users when pasting text into the DevTools
37
+ * Console. IMPORTANT: keep double quotes around PH1 and do not use single
38
+ * quotes.
35
39
  * @example {allow pasting} PH1
36
40
  */
37
41
  selfXssWarning:
38
42
  'Warning: Don’t paste code into the DevTools Console that you don’t understand or haven’t reviewed yourself. This could allow attackers to steal your identity or take control of your computer. Type "{PH1}" below and press Enter to allow pasting.',
39
43
  /**
40
- * @description Text a user needs to type in order to confirm that they are aware of the danger of pasting code into the DevTools Console.
44
+ * @description Text a user needs to type in order to confirm that they are
45
+ * aware of the danger of pasting code into the DevTools Console.
41
46
  */
42
47
  allowPasting: 'allow pasting',
43
48
  } as const;
@@ -49,27 +54,83 @@ const ConsolePromptBase: Common.ObjectWrapper.EventMixin<EventTypes, typeof UI.W
49
54
  UI.Widget.Widget,
50
55
  );
51
56
 
57
+ export interface ViewInput {
58
+ editorState: CodeMirror.EditorState;
59
+ eagerEvalEnabled: boolean;
60
+ preview: DocumentFragment|null;
61
+ isIncomplete: boolean;
62
+ onBelowEditorClick: () => void;
63
+ }
64
+
65
+ export interface ViewOutput {
66
+ editor?: TextEditor.TextEditor.TextEditor;
67
+ getBelowEditorHeight?: () => number;
68
+ }
69
+
70
+ export type View = (input: ViewInput, output: ViewOutput, target: HTMLElement) => void;
71
+
72
+ export const DEFAULT_VIEW: View = (input, output, target) => {
73
+ // clang-format off
74
+ render(html`
75
+ <style>${consolePromptStyles}</style>
76
+ <div class="console-prompt-editor-container">
77
+ <devtools-text-editor
78
+ .state=${input.editorState}
79
+ @keydown=${(event: Event) => {
80
+ if (event.defaultPrevented) {
81
+ event.stopPropagation();
82
+ }
83
+ }}
84
+ ${ref(e => {
85
+ output.editor = e instanceof TextEditor.TextEditor.TextEditor ? e : undefined;
86
+ })}
87
+ ></devtools-text-editor>
88
+ </div>
89
+ <div
90
+ class=${classMap({'console-eager-preview': true, hidden: !input.eagerEvalEnabled})}
91
+ @click=${input.onBelowEditorClick}
92
+ ${ref(e => {
93
+ output.getBelowEditorHeight = e instanceof HTMLElement ? () => e.offsetHeight : undefined;
94
+ })}
95
+ >
96
+ <div class="console-eager-inner-preview">${input.preview ?? nothing}</div>
97
+ <devtools-icon name="chevron-left-dot" class="preview-result-icon medium"></devtools-icon>
98
+ </div>
99
+ <devtools-icon
100
+ name="chevron-right"
101
+ style="color: var(--icon-action)"
102
+ class=${classMap({'console-prompt-icon': true, medium: true, 'console-prompt-incomplete': input.isIncomplete})}
103
+ ></devtools-icon>
104
+ `, target, {container: {attributes: {jslog: `${VisualLogging.textField('console-prompt').track({
105
+ change: true,
106
+ keydown: 'Enter|ArrowUp|ArrowDown|PageUp',
107
+ })}`}}});
108
+ // clang-format on
109
+ };
110
+
52
111
  export class ConsolePrompt extends ConsolePromptBase {
112
+ readonly #view: View;
113
+ readonly #viewOutput: ViewOutput = {};
53
114
  private addCompletionsFromHistory: boolean;
54
115
  #history: TextEditor.AutocompleteHistory.AutocompleteHistory;
55
116
  private initialText: string;
56
- private editor: TextEditor.TextEditor.TextEditor;
57
- private readonly eagerPreviewElement: HTMLDivElement;
117
+ #editorState: CodeMirror.EditorState;
118
+ private editor?: TextEditor.TextEditor.TextEditor;
58
119
  private textChangeThrottler: Common.Throttler.Throttler;
59
120
  private requestPreviewBound: () => Promise<void>;
60
121
  private requestPreviewCurrent = 0;
61
- private readonly innerPreviewElement: HTMLElement;
62
- private readonly promptIcon: Icon;
122
+ #preview: DocumentFragment|null = null;
123
+ #isIncomplete = false;
63
124
  private readonly iconThrottler: Common.Throttler.Throttler;
64
125
  private readonly eagerEvalSetting: Common.Settings.Setting<boolean>;
65
126
  protected previewRequestForTest: Promise<void>|null;
66
127
  private highlightingNode: boolean;
67
- // The CodeMirror state field that controls whether the argument hints are showing.
68
- // If they are, the escape key will clear them. However, if they aren't, then the
69
- // console drawer should be hidden as a whole.
128
+ // The CodeMirror state field that controls whether the argument hints are
129
+ // showing. If they are, the escape key will clear them. However, if they
130
+ // aren't, then the console drawer should be hidden as a whole.
70
131
  #argumentHintsState: CodeMirror.StateField<CodeMirror.Tooltip|null>;
71
132
 
72
- #editorHistory: TextEditor.TextEditorHistory.TextEditorHistory;
133
+ #editorHistory?: TextEditor.TextEditorHistory.TextEditorHistory;
73
134
  #selfXssWarningShown = false;
74
135
  #javaScriptCompletionCompartment: CodeMirror.Compartment = new CodeMirror.Compartment();
75
136
 
@@ -93,48 +154,26 @@ export class ConsolePrompt extends ConsolePromptBase {
93
154
  #updateJavaScriptCompletionCompartment(): void {
94
155
  const extensions = this.#getJavaScriptCompletionExtensions();
95
156
  const effects = this.#javaScriptCompletionCompartment.reconfigure(extensions);
96
- this.editor.dispatch({effects});
157
+ this.editor?.dispatch({effects});
97
158
  }
98
159
 
99
- constructor(aiCodeCompletionConfig?: TextEditor.AiCodeCompletionProvider.AiCodeCompletionConfig) {
100
- super({
101
- jslog: `${VisualLogging.textField('console-prompt').track({
102
- change: true,
103
- keydown: 'Enter|ArrowUp|ArrowDown|PageUp',
104
- })}`,
105
- });
106
- this.registerRequiredCSS(consolePromptStyles);
160
+ constructor(aiCodeCompletionConfig?: TextEditor.AiCodeCompletionProvider.AiCodeCompletionConfig,
161
+ view: View = DEFAULT_VIEW) {
162
+ super();
163
+ this.#view = view;
107
164
  this.addCompletionsFromHistory = true;
108
165
  this.#history = new TextEditor.AutocompleteHistory.AutocompleteHistory(
109
166
  Common.Settings.Settings.instance().createLocalSetting('console-history', []));
110
167
 
111
168
  this.initialText = '';
112
- this.eagerPreviewElement = document.createElement('div');
113
- this.eagerPreviewElement.classList.add('console-eager-preview');
114
169
  this.textChangeThrottler = new Common.Throttler.Throttler(150);
115
170
  this.requestPreviewBound = this.requestPreview.bind(this);
116
- this.innerPreviewElement = this.eagerPreviewElement.createChild('div', 'console-eager-inner-preview');
117
- const previewIcon = new Icon();
118
- previewIcon.name = 'chevron-left-dot';
119
- previewIcon.classList.add('preview-result-icon', 'medium');
120
- this.eagerPreviewElement.appendChild(previewIcon);
121
-
122
- const editorContainerElement = this.element.createChild('div', 'console-prompt-editor-container');
123
- this.element.appendChild(this.eagerPreviewElement);
124
-
125
- this.promptIcon = new Icon();
126
- this.promptIcon.name = 'chevron-right';
127
- this.promptIcon.style.color = 'var(--icon-action)';
128
- this.promptIcon.classList.add('console-prompt-icon', 'medium');
129
- this.element.appendChild(this.promptIcon);
130
171
  this.iconThrottler = new Common.Throttler.Throttler(0);
131
172
 
132
173
  this.eagerEvalSetting =
133
174
  Common.Settings.Settings.instance().resolve(Settings.ConsoleSettings.consoleEagerEvalSettingDescriptor);
134
175
  this.eagerEvalSetting.addChangeListener(this.eagerSettingChanged.bind(this));
135
- this.eagerPreviewElement.classList.toggle('hidden', !this.eagerEvalSetting.get());
136
176
 
137
- this.element.tabIndex = 0;
138
177
  this.previewRequestForTest = null;
139
178
  this.highlightingNode = false;
140
179
  const argumentHints = TextEditor.JavaScript.argumentHints();
@@ -154,7 +193,7 @@ export class ConsolePrompt extends ConsolePromptBase {
154
193
  TextEditor.Config.autocompletion.instance(),
155
194
  CodeMirror.javascript.javascriptLanguage.data.of({
156
195
  autocomplete: (context: CodeMirror.CompletionContext) =>
157
- this.addCompletionsFromHistory ? this.#editorHistory.historyCompletions(context) : null,
196
+ this.addCompletionsFromHistory ? (this.#editorHistory?.historyCompletions(context) ?? null) : null,
158
197
  }),
159
198
  CodeMirror.EditorView.contentAttributes.of({'aria-label': i18nString(UIStrings.consolePrompt)}),
160
199
  CodeMirror.EditorView.lineWrapping,
@@ -170,53 +209,63 @@ export class ConsolePrompt extends ConsolePromptBase {
170
209
  }
171
210
 
172
211
  const doc = this.initialText;
173
- const editorState = CodeMirror.EditorState.create({doc, extensions});
174
-
175
- this.editor = new TextEditor.TextEditor.TextEditor(editorState);
212
+ this.#editorState = CodeMirror.EditorState.create({doc, extensions});
176
213
 
177
- if (this.aiCodeCompletionProvider) {
178
- this.aiCodeCompletionProvider.editorInitialized(this.editor);
179
- this.editor.editor.dispatch({
180
- effects: TextEditor.AiCodeCompletionProvider.setAiCodeCompletionTeaserMode.of(
181
- TextEditor.AiCodeCompletionProvider.AiCodeCompletionTeaserMode.ONLY_SHOW_ON_EMPTY),
182
- });
183
- }
184
-
185
- this.editor.addEventListener('keydown', event => {
186
- if (event.defaultPrevented) {
187
- event.stopPropagation();
188
- }
189
- });
190
- editorContainerElement.appendChild(this.editor);
191
- this.#editorHistory = new TextEditor.TextEditorHistory.TextEditorHistory(this.editor, this.#history);
214
+ this.performUpdate();
192
215
 
193
216
  if (this.hasFocus()) {
194
217
  this.focus();
195
218
  }
196
- this.element.removeAttribute('tabindex');
197
-
198
- this.editorSetForTest();
199
219
 
200
- // Record the console tool load time after the console prompt constructor is complete.
220
+ // Record the console tool load time after the console prompt constructor is
221
+ // complete.
201
222
  UI.UIUserMetrics.UIUserMetrics.instance().panelLoaded('console', 'DevTools.Launch.Console');
202
223
  }
203
224
 
225
+ override performUpdate(): void {
226
+ this.#view({
227
+ editorState: this.editor?.state ?? this.#editorState,
228
+ eagerEvalEnabled: this.eagerEvalSetting.get(),
229
+ preview: this.#preview,
230
+ isIncomplete: this.#isIncomplete,
231
+ onBelowEditorClick: () => {
232
+ if (!this.element.hasSelection()) {
233
+ this.moveCaretToEndOfPrompt();
234
+ this.focus();
235
+ }
236
+ },
237
+ },
238
+ this.#viewOutput, this.contentElement);
239
+ if (this.#viewOutput.editor && this.editor !== this.#viewOutput.editor) {
240
+ this.editor = this.#viewOutput.editor;
241
+ this.#editorHistory = new TextEditor.TextEditorHistory.TextEditorHistory(this.editor, this.#history);
242
+ if (this.aiCodeCompletionProvider) {
243
+ this.aiCodeCompletionProvider.editorInitialized(this.editor);
244
+ this.editor.editor.dispatch({
245
+ effects: TextEditor.AiCodeCompletionProvider.setAiCodeCompletionTeaserMode.of(
246
+ TextEditor.AiCodeCompletionProvider.AiCodeCompletionTeaserMode.ONLY_SHOW_ON_EMPTY),
247
+ });
248
+ }
249
+ this.editorSetForTest();
250
+ }
251
+ }
252
+
204
253
  private eagerSettingChanged(): void {
205
254
  const enabled = this.eagerEvalSetting.get();
206
- this.eagerPreviewElement.classList.toggle('hidden', !enabled);
255
+ this.requestUpdate();
207
256
  if (enabled) {
208
257
  void this.requestPreview();
209
258
  }
210
259
  }
211
260
 
212
- belowEditorElement(): Element {
213
- return this.eagerPreviewElement;
261
+ belowEditorHeight(): number {
262
+ return this.#viewOutput.getBelowEditorHeight?.() ?? 0;
214
263
  }
215
264
 
216
265
  private onTextChanged(): void {
217
266
  // ConsoleView and prompt both use a throttler, so we clear the preview
218
267
  // ASAP to avoid inconsistency between a fresh viewport and stale preview.
219
- if (this.eagerEvalSetting.get()) {
268
+ if (this.eagerEvalSetting.get() && this.editor) {
220
269
  const asSoonAsPossible = !TextEditor.Config.contentIncludingHint(this.editor.editor);
221
270
  this.previewRequestForTest = this.textChangeThrottler.schedule(
222
271
  this.requestPreviewBound,
@@ -227,18 +276,23 @@ export class ConsolePrompt extends ConsolePromptBase {
227
276
  }
228
277
 
229
278
  private async requestPreview(): Promise<void> {
279
+ if (!this.editor) {
280
+ return;
281
+ }
230
282
  const id = ++this.requestPreviewCurrent;
231
283
  const text = TextEditor.Config.contentIncludingHint(this.editor.editor).trim();
232
284
  const executionContext = UI.Context.Context.instance().flavor(SDK.RuntimeModel.ExecutionContext);
233
285
  const {preview, result} = await ObjectUI.JavaScriptREPL.JavaScriptREPL.evaluateAndBuildPreview(
234
286
  text, true /* throwOnSideEffect */, true /* replMode */, 500 /* timeout */);
235
- if (this.requestPreviewCurrent !== id) {
287
+ if (this.requestPreviewCurrent !== id || !this.editor) {
236
288
  return;
237
289
  }
238
- this.innerPreviewElement.removeChildren();
239
290
  if (preview.deepTextContent() !== TextEditor.Config.contentIncludingHint(this.editor.editor).trim()) {
240
- this.innerPreviewElement.appendChild(preview);
291
+ this.#preview = preview;
292
+ } else {
293
+ this.#preview = null;
241
294
  }
295
+ this.requestUpdate();
242
296
  if (result && 'object' in result && result.object?.subtype === 'node') {
243
297
  this.highlightingNode = true;
244
298
  SDK.OverlayModel.OverlayModel.highlightObjectAsDOMNode(result.object);
@@ -264,7 +318,9 @@ export class ConsolePrompt extends ConsolePromptBase {
264
318
  }
265
319
 
266
320
  clearAutocomplete(): void {
267
- CodeMirror.closeCompletion(this.editor.editor);
321
+ if (this.editor) {
322
+ CodeMirror.closeCompletion(this.editor.editor);
323
+ }
268
324
  }
269
325
 
270
326
  clearAiCodeCompletionCache(): void {
@@ -272,15 +328,19 @@ export class ConsolePrompt extends ConsolePromptBase {
272
328
  }
273
329
 
274
330
  moveCaretToEndOfPrompt(): void {
275
- this.editor.dispatch({
276
- selection: CodeMirror.EditorSelection.cursor(this.editor.state.doc.length),
277
- });
331
+ if (this.editor) {
332
+ this.editor.dispatch({
333
+ selection: CodeMirror.EditorSelection.cursor(this.editor.state.doc.length),
334
+ });
335
+ }
278
336
  }
279
337
 
280
338
  clear(): void {
281
- this.editor.dispatch({
282
- changes: {from: 0, to: this.editor.state.doc.length},
283
- });
339
+ if (this.editor) {
340
+ this.editor.dispatch({
341
+ changes: {from: 0, to: this.editor.state.doc.length},
342
+ });
343
+ }
284
344
  }
285
345
 
286
346
  /**
@@ -288,15 +348,17 @@ export class ConsolePrompt extends ConsolePromptBase {
288
348
  * at the end, and scrolls the editor into view.
289
349
  */
290
350
  insertText(text: string): void {
291
- this.editor.dispatch({
292
- changes: {from: 0, to: this.editor.state.doc.length, insert: text},
293
- selection: {anchor: text.length},
294
- scrollIntoView: true,
295
- });
351
+ if (this.editor) {
352
+ this.editor.dispatch({
353
+ changes: {from: 0, to: this.editor.state.doc.length, insert: text},
354
+ selection: {anchor: text.length},
355
+ scrollIntoView: true,
356
+ });
357
+ }
296
358
  }
297
359
 
298
360
  text(): string {
299
- return this.editor.state.doc.toString();
361
+ return this.editor?.state.doc.toString() ?? '';
300
362
  }
301
363
 
302
364
  setAddCompletionsFromHistory(value: boolean): void {
@@ -308,31 +370,39 @@ export class ConsolePrompt extends ConsolePromptBase {
308
370
  {
309
371
  // Handle the KeyboardEvent manually.
310
372
  any: (_view, event) => {
311
- // Events with `repeat=true` are excluded from altering the history state because
312
- // they are often not intended as such. Example:
373
+ // Events with `repeat=true` are excluded from altering the history
374
+ // state because they are often not intended as such. Example:
313
375
  // Scrolling through long snippets.
314
376
  if (event.repeat) {
315
377
  return false;
316
378
  }
317
379
 
318
380
  if (event.key === 'ArrowUp') {
319
- return this.#editorHistory.moveHistory(Direction.BACKWARD);
381
+ return this.#editorHistory?.moveHistory(Direction.BACKWARD) ?? false;
320
382
  }
321
383
 
322
384
  if (event.key === 'ArrowDown') {
323
- return this.#editorHistory.moveHistory(Direction.FORWARD);
385
+ return this.#editorHistory?.moveHistory(Direction.FORWARD) ?? false;
324
386
  }
325
387
 
326
388
  return false;
327
389
  },
328
390
  },
329
391
 
330
- {mac: 'Ctrl-p', run: () => this.#editorHistory.moveHistory(Direction.BACKWARD, true)},
331
- {mac: 'Ctrl-n', run: () => this.#editorHistory.moveHistory(Direction.FORWARD, true)},
392
+ {
393
+ mac: 'Ctrl-p',
394
+ run: () => this.#editorHistory?.moveHistory(Direction.BACKWARD, true) ?? false,
395
+ },
396
+ {
397
+ mac: 'Ctrl-n',
398
+ run: () => this.#editorHistory?.moveHistory(Direction.FORWARD, true) ?? false,
399
+ },
332
400
  {
333
401
  key: 'Escape',
334
402
  run: () => {
335
- return TextEditor.JavaScript.closeArgumentsHintsTooltip(this.editor.editor, this.#argumentHintsState);
403
+ return this.editor ?
404
+ TextEditor.JavaScript.closeArgumentsHintsTooltip(this.editor.editor, this.#argumentHintsState) :
405
+ false;
336
406
  },
337
407
  },
338
408
  {
@@ -354,6 +424,9 @@ export class ConsolePrompt extends ConsolePromptBase {
354
424
  }
355
425
 
356
426
  private async enterWillEvaluate(forceEvaluate?: boolean): Promise<boolean> {
427
+ if (!this.editor) {
428
+ return false;
429
+ }
357
430
  const {doc, selection} = this.editor.state;
358
431
  if (!doc.length) {
359
432
  return false;
@@ -364,7 +437,8 @@ export class ConsolePrompt extends ConsolePromptBase {
364
437
  const currentExecutionContext = UI.Context.Context.instance().flavor(SDK.RuntimeModel.ExecutionContext);
365
438
  const isExpressionComplete = await TextEditor.JavaScript.isExpressionComplete(doc.toString());
366
439
  if (currentExecutionContext !== UI.Context.Context.instance().flavor(SDK.RuntimeModel.ExecutionContext)) {
367
- // We should not evaluate if the current context has changed since user action
440
+ // We should not evaluate if the current context has changed since user
441
+ // action
368
442
  return false;
369
443
  }
370
444
  return isExpressionComplete;
@@ -380,6 +454,9 @@ export class ConsolePrompt extends ConsolePromptBase {
380
454
  }
381
455
 
382
456
  private async handleEnter(forceEvaluate?: boolean): Promise<void> {
457
+ if (!this.editor) {
458
+ return;
459
+ }
383
460
  if (this.#selfXssWarningShown &&
384
461
  (this.text() === i18nString(UIStrings.allowPasting) ||
385
462
  this.text() === `'${i18nString(UIStrings.allowPasting)}'`)) {
@@ -423,7 +500,8 @@ export class ConsolePrompt extends ConsolePromptBase {
423
500
 
424
501
  private updatePromptIcon(): void {
425
502
  void this.iconThrottler.schedule(async () => {
426
- this.promptIcon.classList.toggle('console-prompt-incomplete', !(await this.enterWillEvaluate()));
503
+ this.#isIncomplete = !(await this.enterWillEvaluate());
504
+ this.requestUpdate();
427
505
  });
428
506
  }
429
507
 
@@ -444,9 +522,9 @@ export class ConsolePrompt extends ConsolePromptBase {
444
522
  }
445
523
  }
446
524
 
447
- private async evaluateCommandInConsole(
448
- executionContext: SDK.RuntimeModel.ExecutionContext, message: SDK.ConsoleModel.ConsoleMessage, expression: string,
449
- useCommandLineAPI: boolean): Promise<void> {
525
+ private async evaluateCommandInConsole(executionContext: SDK.RuntimeModel.ExecutionContext,
526
+ message: SDK.ConsoleModel.ConsoleMessage, expression: string,
527
+ useCommandLineAPI: boolean): Promise<void> {
450
528
  const callFrame = executionContext.debuggerModel.selectedCallFrame();
451
529
  if (callFrame?.script.isJavaScript()) {
452
530
  const nameMap = await SourceMapScopes.NamesResolver.allVariablesInCallFrame(
@@ -478,7 +556,7 @@ export class ConsolePrompt extends ConsolePromptBase {
478
556
  }
479
557
 
480
558
  override focus(): void {
481
- this.editor.focus();
559
+ this.editor?.focus();
482
560
  }
483
561
 
484
562
  private editorSetForTest(): void {
@@ -76,7 +76,7 @@ interface ViewInput {
76
76
  onSelectionChanged: (selectedFilter: ConsoleFilter) => void;
77
77
  }
78
78
 
79
- export type View = (input: ViewInput, output: object, target: HTMLElement|DocumentFragment) => void;
79
+ export type View = (input: ViewInput, output: undefined, target: HTMLElement|DocumentFragment) => void;
80
80
  export const DEFAULT_VIEW: View = (input, output, target) => {
81
81
  render(html`<devtools-tree
82
82
  navigation-variant
@@ -214,7 +214,7 @@ export class ConsoleSidebar extends ConsoleSidebarBase {
214
214
  this.dispatchEventToListeners(Events.FILTER_SELECTED);
215
215
  },
216
216
  };
217
- this.#view(input, {}, this.contentElement);
217
+ this.#view(input, undefined, this.contentElement);
218
218
  }
219
219
 
220
220
  clear(): void {