chrome-devtools-frontend 1.0.1726686 → 1.0.1730971
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/.agents/rules/tests/test-strict-assertions-and-literal-expectations.md +1 -1
- package/.agents/rules/tests/test-view-and-presenter-isolation.md +1 -1
- package/.agents/rules/ui-and-widgets/ui-accessibility-and-semantic-html.md +1 -1
- package/.agents/rules/ui-and-widgets/ui-css-scoping-and-flex-layout.md +2 -2
- package/.agents/rules/ui-and-widgets/ui-declarative-child-widget-composition.md +5 -5
- package/.agents/rules/ui-and-widgets/ui-lit-declarative-templates-and-directives.md +2 -2
- package/.agents/rules/ui-and-widgets/ui-localization-and-uistrings-hygiene.md +2 -2
- package/.agents/rules/ui-and-widgets/ui-modern-component-and-encapsulation-standards.md +3 -3
- package/.agents/rules/ui-and-widgets/ui-pure-view-and-presenter-separation.md +2 -2
- package/.agents/rules/ui-and-widgets/ui-reactive-widget-update-lifecycle.md +2 -2
- package/.agents/rules/ui-and-widgets/ui-view-output-and-callback-contracts.md +2 -2
- package/.agents/rules/ui-and-widgets/ui-widget-dom-and-listener-lifecycle.md +2 -2
- package/.agents/skills/code-review/SKILL.md +63 -12
- package/.agents/skills/ui-eng-vision-local-lit-renderer/SKILL.md +38 -10
- package/.agents/skills/ui-eng-vision-widget-promoter/SKILL.md +1 -0
- package/.agents/skills/ui-widgets/SKILL.md +8 -2
- package/.agents/skills/write-ai-eval-test/SKILL.md +106 -0
- package/AUTHORS +2 -0
- package/DIR_METADATA +1 -2
- package/README.md +48 -26
- package/config/typescript/tsconfig.base.json +1 -0
- package/config/typescript/tsconfig.eslint.json +1 -0
- package/docs/contributing/changes.md +25 -0
- package/docs/ui_engineering.md +13 -4
- package/eslint.config.mjs +323 -41
- package/front_end/core/common/Color.ts +7 -7
- package/front_end/core/common/ParsedURL.ts +3 -3
- package/front_end/core/common/ResolverBase.ts +3 -3
- package/front_end/core/common/SegmentedRange.ts +3 -3
- package/front_end/core/common/SimpleHistoryManager.ts +14 -14
- package/front_end/core/common/Trie.ts +3 -3
- package/front_end/core/common/VersionController.ts +7 -7
- package/front_end/core/host/InspectorFrontendHost.ts +2 -2
- package/front_end/core/host/InspectorFrontendHostAPI.ts +9 -1
- package/front_end/core/host/InspectorFrontendHostStub.ts +1 -1
- package/front_end/core/host/UserMetrics.ts +4 -0
- package/front_end/core/host/UserMetricsEnums.ts +2 -1
- package/front_end/core/platform/StringUtilities.ts +54 -13
- package/front_end/core/platform/node/HostRuntime.ts +13 -7
- package/front_end/core/protocol_client/DevToolsCDPConnection.ts +4 -5
- package/front_end/core/root/Runtime.ts +5 -0
- package/front_end/core/sdk/AccessibilityModel.ts +5 -5
- package/front_end/core/sdk/AnimationModel.ts +17 -19
- package/front_end/core/sdk/CPUProfilerModel.ts +3 -3
- package/front_end/core/sdk/CPUThrottlingManager.ts +7 -0
- package/front_end/core/sdk/CSSMatchedStyles.ts +73 -13
- package/front_end/core/sdk/CSSMetadata.ts +7 -7
- package/front_end/core/sdk/CSSModel.ts +33 -33
- package/front_end/core/sdk/CSSProperty.ts +5 -5
- package/front_end/core/sdk/CSSRule.ts +6 -6
- package/front_end/core/sdk/CSSStyleSheetHeader.ts +4 -4
- package/front_end/core/sdk/Connections.ts +16 -16
- package/front_end/core/sdk/ConsoleModel.ts +44 -47
- package/front_end/core/sdk/CookieParser.ts +11 -11
- package/front_end/core/sdk/EmulationModel.ts +35 -36
- package/front_end/core/sdk/EventBreakpointsModel.ts +11 -11
- package/front_end/core/sdk/FrameManager.ts +16 -16
- package/front_end/core/sdk/IsolateManager.ts +2 -2
- package/front_end/core/sdk/IssuesModel.ts +2 -2
- package/front_end/core/sdk/OverlayModel.ts +19 -19
- package/front_end/core/sdk/PageResourceLoader.ts +14 -16
- package/front_end/core/sdk/RemoteObject.ts +9 -9
- package/front_end/core/sdk/Resource.ts +2 -2
- package/front_end/core/sdk/RuntimeModel.ts +7 -7
- package/front_end/core/sdk/Script.ts +6 -6
- package/front_end/core/sdk/ServiceWorkerManager.ts +36 -10
- package/front_end/core/sdk/SourceMap.ts +18 -20
- package/front_end/core/sdk/SourceMapManager.ts +2 -2
- package/front_end/core/sdk/TargetManager.ts +2 -2
- package/front_end/devtools_compatibility.js +7 -3
- package/front_end/entrypoints/inspector_main/InspectorMain.ts +2 -2
- package/front_end/entrypoints/node_app/app/NodeConnectionsPanel.ts +203 -115
- package/front_end/generated/InspectorBackendCommands.ts +1 -1
- package/front_end/generated/SupportedCSSProperties.ts +1 -3
- package/front_end/generated/protocol.ts +1 -0
- package/front_end/models/ai_assistance/AiAgent2.ts +36 -12
- package/front_end/models/ai_assistance/AiConversation.ts +8 -2
- package/front_end/models/ai_assistance/agents/AiAgent.ts +137 -62
- package/front_end/models/ai_assistance/agents/ExecuteJavascript.ts +2 -2
- package/front_end/models/ai_assistance/agents/StylingAgent.snapshot.txt +2 -2
- package/front_end/models/ai_assistance/data_formatters/LighthouseFormatter.snapshot.txt +149 -2
- package/front_end/models/ai_assistance/data_formatters/LighthouseFormatter.ts +269 -42
- package/front_end/models/ai_assistance/tools/ExecuteJavaScript.ts +3 -0
- package/front_end/models/ai_assistance/tools/GetLighthouseAudits.ts +9 -0
- package/front_end/models/ai_assistance/tools/ResolveDevtoolsNodePath.ts +13 -2
- package/front_end/models/ai_assistance/tools/RunLighthouse.ts +23 -7
- package/front_end/models/ai_assistance/tools/Tool.ts +7 -5
- package/front_end/models/bindings/CSSWorkspaceBinding.ts +22 -24
- package/front_end/models/bindings/DebuggerLanguagePlugins.ts +60 -60
- package/front_end/models/bindings/DebuggerWorkspaceBinding.ts +24 -24
- package/front_end/models/bindings/DefaultScriptMapping.ts +8 -8
- package/front_end/models/bindings/FileUtils.ts +13 -13
- package/front_end/models/bindings/PresentationConsoleMessageHelper.ts +3 -3
- package/front_end/models/bindings/ResourceScriptMapping.ts +23 -23
- package/front_end/models/comment_manager/CommentManager.ts +3 -3
- package/front_end/models/comment_manager/CommentThread.ts +50 -5
- package/front_end/models/cpu_profile/CPUProfileDataModel.ts +14 -14
- package/front_end/models/cpu_profile/ProfileTreeModel.ts +4 -4
- package/front_end/models/elements/StyleChanges.ts +38 -0
- package/front_end/models/emulation/EmulatedDevices.ts +12 -12
- package/front_end/models/har/HARFormat.ts +4 -4
- package/front_end/models/javascript_metadata/NativeFunctions.ts +5 -1
- package/front_end/models/lighthouse/LighthouseReporterTypes.ts +57 -3
- package/front_end/models/lighthouse/RunTypes.ts +9 -1
- package/front_end/models/logs/LogManager.ts +2 -2
- package/front_end/models/persistence/AutomaticFileSystemManager.ts +3 -0
- package/front_end/models/persistence/FileSystemWorkspaceBinding.ts +24 -24
- package/front_end/models/persistence/IsolatedFileSystemManager.ts +6 -0
- package/front_end/models/persistence/NetworkPersistenceManager.ts +8 -3
- package/front_end/models/trace/LanternComputationData.ts +37 -11
- package/front_end/models/trace/Processor.ts +2 -1
- package/front_end/models/trace/extras/TraceTree.ts +36 -10
- package/front_end/models/trace/handlers/InitiatorsHandler.ts +27 -34
- package/front_end/models/trace/handlers/LayoutShiftsHandler.ts +2 -6
- package/front_end/models/trace/handlers/SamplesHandler.ts +9 -6
- package/front_end/models/workspace/FileManager.ts +6 -0
- package/front_end/panels/accessibility/ARIAAttributesView.ts +4 -4
- package/front_end/panels/accessibility/AccessibilityAnnouncementRecordingView.ts +8 -1
- package/front_end/panels/accessibility/AccessibilityNodeView.ts +15 -17
- package/front_end/panels/accessibility/AccessibilitySubPane.ts +1 -1
- package/front_end/panels/ai_assistance/AiAssistancePanel.ts +5 -5
- package/front_end/panels/ai_assistance/ExternalHandler.ts +10 -1
- package/front_end/panels/ai_assistance/components/ChatMessage.ts +27 -22
- package/front_end/panels/ai_assistance/components/DisabledWidget.ts +19 -23
- package/front_end/panels/ai_assistance/components/ExploreWidget.ts +2 -2
- package/front_end/panels/ai_assistance/components/PermissionPrompt.ts +23 -9
- package/front_end/panels/ai_assistance/components/chatInput.css +1 -1
- package/front_end/panels/animation/AnimationTimeline.ts +37 -17
- package/front_end/panels/animation/animationTimeline.css +19 -3
- package/front_end/panels/application/AppManifestView.ts +1 -2
- package/front_end/panels/application/ApplicationPanelSidebar.ts +143 -128
- package/front_end/panels/application/DOMStorageItemsView.ts +14 -14
- package/front_end/panels/application/DeviceBoundSessionsView.ts +10 -13
- package/front_end/panels/application/ExtensionStorageItemsView.ts +3 -4
- package/front_end/panels/application/IndexedDBViews.ts +8 -4
- package/front_end/panels/application/KeyValueStorageItemsView.ts +4 -5
- package/front_end/panels/application/PrivateVerificationTokensView.ts +53 -0
- package/front_end/panels/application/ServiceWorkerCacheViews.ts +12 -8
- package/front_end/panels/application/ServiceWorkersView.ts +1 -2
- package/front_end/panels/application/StorageItemsToolbar.ts +3 -3
- package/front_end/panels/application/StorageView.ts +2 -2
- package/front_end/panels/application/WebMCPView.ts +91 -109
- package/front_end/panels/application/application.ts +2 -0
- package/front_end/panels/application/components/StorageMetadataView.ts +6 -6
- package/front_end/panels/application/preloading/PreloadingView.ts +70 -37
- package/front_end/panels/application/preloading/components/MismatchedPreloadingGrid.ts +2 -2
- package/front_end/panels/application/preloading/components/PreloadingDisabledInfobar.ts +3 -3
- package/front_end/panels/application/preloading/components/PreloadingGrid.ts +12 -0
- package/front_end/panels/application/preloading/components/RuleSetDetailsView.ts +10 -11
- package/front_end/panels/application/privateVerificationTokensView.css +20 -0
- package/front_end/panels/application/serviceWorkersView.css +2 -2
- package/front_end/panels/browser_debugger/DOMBreakpointsSidebarPane.ts +24 -24
- package/front_end/panels/changes/ChangesSidebar.ts +5 -5
- package/front_end/panels/changes/ChangesView.ts +10 -11
- package/front_end/panels/comments/CommentsPane.ts +292 -102
- package/front_end/panels/comments/commentsPane.css +93 -12
- package/front_end/panels/common/CommentThreadWidget.ts +69 -0
- package/front_end/panels/common/CommentsOverlayWidget.ts +108 -29
- package/front_end/panels/common/CommentsStatusBarPill.ts +17 -6
- package/front_end/panels/common/DOMLinkifier.ts +37 -12
- package/front_end/panels/common/ExtensionPanel.ts +13 -4
- package/front_end/panels/common/ExtensionServer.ts +27 -3
- package/front_end/panels/common/PersistenceUtils.ts +3 -3
- package/front_end/panels/common/commentThreadWidget.css +25 -1
- package/front_end/panels/common/common-meta.ts +10 -0
- package/front_end/panels/console/ConsolePinPane.ts +13 -15
- package/front_end/panels/console/ConsolePrompt.ts +173 -95
- package/front_end/panels/console/ConsoleSidebar.ts +2 -2
- package/front_end/panels/console/ConsoleView.ts +75 -79
- package/front_end/panels/console/ConsoleViewMessage.ts +52 -4
- package/front_end/panels/console/SymbolizedErrorWidget.ts +8 -4
- package/front_end/panels/console/consolePrompt.css +1 -1
- package/front_end/panels/console/consoleView.css +1 -1
- package/front_end/panels/console_counters/WarningErrorCounter.ts +3 -4
- package/front_end/panels/coverage/CoverageListView.ts +2 -2
- package/front_end/panels/coverage/CoverageView.ts +20 -5
- package/front_end/panels/css_overview/CSSOverviewCompletedView.ts +4 -3
- package/front_end/panels/css_overview/CSSOverviewPanel.ts +2 -2
- package/front_end/panels/css_overview/CSSOverviewProcessingView.ts +2 -2
- package/front_end/panels/css_overview/CSSOverviewSidebarPanel.ts +2 -2
- package/front_end/panels/css_overview/CSSOverviewStartView.ts +2 -2
- package/front_end/panels/css_overview/CSSOverviewUnusedDeclarations.ts +8 -8
- package/front_end/panels/developer_resources/DeveloperResourcesListView.ts +2 -3
- package/front_end/panels/developer_resources/DeveloperResourcesView.ts +4 -5
- package/front_end/panels/elements/AccessibilityTreeUtils.ts +6 -7
- package/front_end/panels/elements/CSSValueTraceView.ts +3 -3
- package/front_end/panels/elements/ClassesPaneWidget.ts +1 -2
- package/front_end/panels/elements/ComputedStyleWidget.ts +15 -14
- package/front_end/panels/elements/DOMTreeElementWidget.ts +5 -4
- package/front_end/panels/elements/DOMTreeWidget.ts +2 -1
- package/front_end/panels/elements/ElementStatePaneWidget.ts +2 -2
- package/front_end/panels/elements/ElementsPanel.ts +1 -0
- package/front_end/panels/elements/EventListenersWidget.ts +2 -2
- package/front_end/panels/elements/LayoutPane.ts +2 -2
- package/front_end/panels/elements/PlatformFontsWidget.ts +3 -3
- package/front_end/panels/elements/PropertiesWidget.ts +9 -10
- package/front_end/panels/elements/PropertyRenderer.ts +72 -11
- package/front_end/panels/elements/StandaloneStylesContainer.ts +5 -10
- package/front_end/panels/elements/StyleEditorWidget.ts +30 -16
- package/front_end/panels/elements/StylePropertiesSection.ts +93 -44
- package/front_end/panels/elements/StylePropertyTreeElement.ts +230 -302
- package/front_end/panels/elements/StylesContainer.ts +2 -3
- package/front_end/panels/elements/StylesSidebarPane.ts +4 -13
- package/front_end/panels/elements/components/AccessibilityTreeNode.ts +66 -37
- package/front_end/panels/elements/components/CSSHintDetailsView.ts +51 -41
- package/front_end/panels/elements/components/CSSPropertyDocsView.ts +75 -65
- package/front_end/panels/elements/components/CSSQuery.ts +112 -74
- package/front_end/panels/elements/components/CSSVariableValueView.ts +109 -68
- package/front_end/panels/elements/components/ComputedStyleProperty.ts +64 -45
- package/front_end/panels/elements/components/ElementsTreeExpandButton.ts +35 -28
- package/front_end/panels/elements/components/QueryContainer.ts +104 -74
- package/front_end/panels/elements/components/accessibilityTreeNode.css +22 -20
- package/front_end/panels/elements/components/computedStyleProperty.css +2 -0
- package/front_end/panels/elements/components/cssHintDetailsView.css +23 -21
- package/front_end/panels/elements/components/cssPropertyDocsView.css +38 -36
- package/front_end/panels/elements/components/cssVariableValueView.css +42 -40
- package/front_end/panels/elements/components/elementsTreeExpandButton.css +5 -2
- package/front_end/panels/elements/components/queryContainer.css +23 -21
- package/front_end/panels/elements/stylesSidebarPane.css +3 -3
- package/front_end/panels/emulation/DeviceModeToolbar.ts +2 -2
- package/front_end/panels/emulation/InspectedPagePlaceholder.ts +2 -2
- package/front_end/panels/emulation/MediaQueryInspector.ts +9 -10
- package/front_end/panels/emulation/mediaQueryInspector.css +1 -1
- package/front_end/panels/event_listeners/EventListenersView.ts +2 -2
- package/front_end/panels/issues/AffectedCookiesView.ts +144 -101
- package/front_end/panels/issues/AffectedDescendantsWithinSelectElementView.ts +83 -31
- package/front_end/panels/issues/AffectedDirectivesView.ts +218 -135
- package/front_end/panels/issues/AffectedDocumentsInQuirksModeView.ts +84 -34
- package/front_end/panels/issues/AffectedElementsView.ts +86 -23
- package/front_end/panels/issues/AffectedLazyLoadImagesView.ts +2 -2
- package/front_end/panels/issues/AffectedMetadataAllowedSitesView.ts +2 -2
- package/front_end/panels/issues/AffectedPartitioningBlobURLView.ts +36 -11
- package/front_end/panels/issues/AffectedSharedArrayBufferIssueDetailsView.ts +135 -58
- package/front_end/panels/issues/AffectedSourcesView.ts +49 -28
- package/front_end/panels/issues/AffectedTrackingSitesView.ts +3 -4
- package/front_end/panels/issues/CorsIssueDetailsView.ts +490 -269
- package/front_end/panels/issues/GenericIssueDetailsView.ts +2 -2
- package/front_end/panels/issues/IssueKindView.ts +63 -48
- package/front_end/panels/issues/IssueView.ts +14 -18
- package/front_end/panels/issues/components/ElementsPanelLink.ts +70 -34
- package/front_end/panels/issues/components/HideIssuesMenu.ts +56 -32
- package/front_end/panels/issues/components/elementsPanelLink.css +10 -6
- package/front_end/panels/issues/components/hideIssuesMenu.css +16 -14
- package/front_end/panels/issues/issues.ts +2 -0
- package/front_end/panels/issues/issuesTree.css +4 -4
- package/front_end/panels/lighthouse/LighthouseController.ts +6 -6
- package/front_end/panels/lighthouse/LighthouseStatusView.ts +12 -13
- package/front_end/panels/lighthouse/lighthouseStartView.css +1 -1
- package/front_end/panels/linear_memory_inspector/LinearMemoryInspectorPane.ts +159 -161
- package/front_end/panels/linear_memory_inspector/LinearMemoryInspectorView.ts +228 -0
- package/front_end/panels/linear_memory_inspector/components/LinearMemoryInspector.ts +32 -41
- package/front_end/panels/linear_memory_inspector/components/linearMemoryHighlightChipList.css +2 -2
- package/front_end/panels/linear_memory_inspector/linear_memory_inspector.ts +2 -0
- package/front_end/panels/media/EventDisplayTable.ts +2 -2
- package/front_end/panels/media/MainView.ts +132 -66
- package/front_end/panels/media/PlayerDetailView.ts +32 -14
- package/front_end/panels/media/PlayerListView.ts +83 -23
- package/front_end/panels/media/PlayerPropertiesView.ts +2 -2
- package/front_end/panels/media/TickingFlameChart.ts +153 -63
- package/front_end/panels/mobile_throttling/NetworkThrottlingSelector.ts +2 -2
- package/front_end/panels/mobile_throttling/ThrottlingSettingsTab.ts +615 -464
- package/front_end/panels/mobile_throttling/throttlingSettingsTab.css +43 -0
- package/front_end/panels/network/EventSourceMessagesView.ts +3 -3
- package/front_end/panels/network/NetworkConfigView.ts +6 -2
- package/front_end/panels/network/NetworkDataGridNode.ts +2 -1
- package/front_end/panels/network/NetworkItemView.ts +27 -26
- package/front_end/panels/network/NetworkManageCustomHeadersView.ts +236 -97
- package/front_end/panels/network/NetworkOverview.ts +8 -10
- package/front_end/panels/network/RequestConditionsDrawer.ts +8 -4
- package/front_end/panels/network/RequestDeviceBoundSessionsView.ts +2 -4
- package/front_end/panels/network/RequestHTMLView.ts +26 -7
- package/front_end/panels/network/RequestHeadersView.ts +2 -2
- package/front_end/panels/network/RequestInitiatorView.ts +21 -22
- package/front_end/panels/network/RequestPayloadView.ts +2 -16
- package/front_end/panels/network/RequestPreviewView.ts +5 -5
- package/front_end/panels/network/RequestTimingView.ts +6 -6
- package/front_end/panels/network/ResourceDirectSocketChunkView.ts +5 -6
- package/front_end/panels/network/ResourceWebSocketFrameView.ts +4 -3
- package/front_end/panels/network/ShowMoreDetailsWidget.ts +11 -12
- package/front_end/panels/network/SignedExchangeInfoView.ts +2 -2
- package/front_end/panels/network/networkLogView.css +2 -2
- package/front_end/panels/network/networkManageCustomHeadersView.css +27 -6
- package/front_end/panels/network/requestConditionsDrawer.css +1 -1
- package/front_end/panels/network/requestInitiatorView.css +5 -3
- package/front_end/panels/performance_monitor/PerformanceMonitor.ts +2 -2
- package/front_end/panels/profiler/HeapDetachedElementsView.ts +1 -2
- package/front_end/panels/profiler/HeapTimelineOverview.ts +77 -15
- package/front_end/panels/profiler/IsolateSelector.ts +258 -187
- package/front_end/panels/profiler/ProfileLauncherView.ts +7 -29
- package/front_end/panels/profiler/profileLauncherView.css +6 -1
- package/front_end/panels/protocol_monitor/JSONEditor.ts +4 -5
- package/front_end/panels/recorder/ControlButton.ts +1 -1
- package/front_end/panels/recorder/RecordingListView.ts +2 -4
- package/front_end/panels/recorder/RecordingView.ts +1 -2
- package/front_end/panels/recorder/SelectorPicker.ts +2 -4
- package/front_end/panels/recorder/StepView.ts +24 -10
- package/front_end/panels/recorder/TimelineSection.ts +1 -1
- package/front_end/panels/recorder/recordingView.css +1 -1
- package/front_end/panels/screencast/ScreencastApp.ts +1 -1
- package/front_end/panels/search/SearchResultsPane.ts +11 -12
- package/front_end/panels/search/SearchView.ts +8 -10
- package/front_end/panels/security/SecurityPanel.ts +1 -8
- package/front_end/panels/security/SecurityPanelSidebar.ts +2 -2
- package/front_end/panels/security/mainView.css +1 -1
- package/front_end/panels/sensors/LocationsSettingsTab.ts +1 -2
- package/front_end/panels/settings/AISettingsTab.ts +1 -1
- package/front_end/panels/settings/BackendLinkingSettingsTab.ts +34 -20
- package/front_end/panels/settings/EditFileSystemView.ts +2 -2
- package/front_end/panels/settings/FrameworkIgnoreListSettingsTab.ts +375 -197
- package/front_end/panels/settings/KeybindsSettingsTab.ts +570 -414
- package/front_end/panels/settings/SettingsScreen.ts +312 -114
- package/front_end/panels/settings/WorkspaceSettingsTab.ts +2 -2
- package/front_end/panels/settings/aiSettingsTab.css +1 -4
- package/front_end/panels/settings/emulation/DevicesSettingsTab.ts +924 -578
- package/front_end/panels/settings/emulation/components/UserAgentClientHintsForm.ts +9 -2
- package/front_end/panels/settings/emulation/devicesSettingsTab.css +39 -0
- package/front_end/panels/settings/frameworkIgnoreListSettingsTab.css +37 -8
- package/front_end/panels/settings/settingsScreen.css +0 -24
- package/front_end/panels/sources/BreakpointEditDialog.ts +9 -6
- package/front_end/panels/sources/BreakpointsView.ts +25 -4
- package/front_end/panels/sources/CallStackSidebarPane.ts +7 -1
- package/front_end/panels/sources/DebuggerPlugin.ts +1 -0
- package/front_end/panels/sources/GoToLineQuickOpen.ts +8 -8
- package/front_end/panels/sources/NavigatorView.ts +521 -439
- package/front_end/panels/sources/PersistenceActions.ts +11 -12
- package/front_end/panels/sources/ProfilePlugin.ts +28 -17
- package/front_end/panels/sources/ScopeChainSidebarPane.ts +3 -4
- package/front_end/panels/sources/SourcesNavigator.ts +9 -9
- package/front_end/panels/sources/SourcesPanel.ts +2 -2
- package/front_end/panels/sources/SourcesView.ts +3 -3
- package/front_end/panels/sources/ThreadsSidebarPane.ts +2 -2
- package/front_end/panels/sources/WatchExpressionsSidebarPane.ts +2 -2
- package/front_end/panels/sources/components/HeadersView.ts +1 -2
- package/front_end/panels/timeline/CompatibilityTracksAppender.ts +5 -6
- package/front_end/panels/timeline/EventsTimelineTreeView.ts +73 -34
- package/front_end/panels/timeline/IsolateSelector.ts +25 -37
- package/front_end/panels/timeline/StatusDialog.ts +5 -7
- package/front_end/panels/timeline/ThirdPartyTreeView.ts +10 -13
- package/front_end/panels/timeline/TimelineDetailsView.ts +40 -21
- package/front_end/panels/timeline/TimelineEventOverview.ts +130 -34
- package/front_end/panels/timeline/TimelineFlameChartNetworkDataProvider.ts +1 -1
- package/front_end/panels/timeline/TimelineMiniMap.ts +255 -103
- package/front_end/panels/timeline/TimelinePaintProfilerView.ts +19 -11
- package/front_end/panels/timeline/TimelinePanel.ts +1 -0
- package/front_end/panels/timeline/TimelineSelectorStatsView.ts +11 -12
- package/front_end/panels/timeline/TimelineTreeView.ts +240 -122
- package/front_end/panels/timeline/TimelineUIUtils.ts +12 -0
- package/front_end/panels/timeline/components/BreadcrumbsUI.ts +5 -4
- package/front_end/panels/timeline/components/DetailsView.ts +97 -65
- package/front_end/panels/timeline/components/LayoutShiftDetails.ts +2 -2
- package/front_end/panels/timeline/components/MetricCard.ts +2 -2
- package/front_end/panels/timeline/components/NetworkRequestDetails.ts +11 -12
- package/front_end/panels/timeline/components/NetworkTrackWidget.ts +57 -50
- package/front_end/panels/timeline/components/RelatedInsightChips.ts +2 -2
- package/front_end/panels/timeline/components/Sidebar.ts +161 -109
- package/front_end/panels/timeline/components/SidebarAnnotationsTab.ts +33 -12
- package/front_end/panels/timeline/components/SidebarInsightsTab.ts +3 -0
- package/front_end/panels/timeline/components/insights/LCPDiscovery.ts +11 -11
- package/front_end/panels/timeline/components/insights/SlowCSSSelector.ts +6 -7
- package/front_end/panels/timeline/components/networkTrackWidget.css +24 -22
- package/front_end/panels/timeline/components/sidebarInsightsTab.css +1 -1
- package/front_end/panels/timeline/overlays/components/TimespanBreakdownOverlay.ts +15 -10
- package/front_end/panels/timeline/overlays/components/entryLabelOverlay.css +1 -1
- package/front_end/panels/timeline/timelinePanel.css +5 -0
- package/front_end/panels/timeline/timelineStatusDialog.css +1 -1
- package/front_end/panels/web_audio/WebAudioView.ts +2 -2
- package/front_end/third_party/chromium/README.chromium +1 -1
- package/front_end/third_party/legacy-javascript/README.chromium +2 -2
- package/front_end/third_party/legacy-javascript/lib/legacy-javascript.js +2 -2
- package/front_end/third_party/legacy-javascript/package.json +1 -1
- package/front_end/third_party/lighthouse/README.chromium +2 -2
- package/front_end/third_party/lighthouse/lighthouse-dt-bundle.js +1983 -2022
- package/front_end/third_party/lighthouse/locales/ar-XB.json +157 -142
- package/front_end/third_party/lighthouse/locales/ar.json +157 -142
- package/front_end/third_party/lighthouse/locales/bg.json +154 -139
- package/front_end/third_party/lighthouse/locales/ca.json +157 -142
- package/front_end/third_party/lighthouse/locales/cs.json +148 -133
- package/front_end/third_party/lighthouse/locales/da.json +153 -138
- package/front_end/third_party/lighthouse/locales/de.json +152 -137
- package/front_end/third_party/lighthouse/locales/el.json +153 -138
- package/front_end/third_party/lighthouse/locales/en-GB.json +160 -145
- package/front_end/third_party/lighthouse/locales/en-US.json +239 -218
- package/front_end/third_party/lighthouse/locales/en-XL.json +239 -218
- package/front_end/third_party/lighthouse/locales/es-419.json +150 -135
- package/front_end/third_party/lighthouse/locales/es.json +149 -134
- package/front_end/third_party/lighthouse/locales/fi.json +151 -136
- package/front_end/third_party/lighthouse/locales/fil.json +154 -139
- package/front_end/third_party/lighthouse/locales/fr.json +150 -135
- package/front_end/third_party/lighthouse/locales/he.json +160 -145
- package/front_end/third_party/lighthouse/locales/hi.json +156 -141
- package/front_end/third_party/lighthouse/locales/hr.json +154 -139
- package/front_end/third_party/lighthouse/locales/hu.json +111 -96
- package/front_end/third_party/lighthouse/locales/id.json +153 -138
- package/front_end/third_party/lighthouse/locales/it.json +153 -138
- package/front_end/third_party/lighthouse/locales/ja.json +150 -135
- package/front_end/third_party/lighthouse/locales/ko.json +42 -27
- package/front_end/third_party/lighthouse/locales/lt.json +152 -137
- package/front_end/third_party/lighthouse/locales/lv.json +93 -78
- package/front_end/third_party/lighthouse/locales/nl.json +149 -134
- package/front_end/third_party/lighthouse/locales/no.json +152 -137
- package/front_end/third_party/lighthouse/locales/pl.json +153 -138
- package/front_end/third_party/lighthouse/locales/pt-PT.json +152 -137
- package/front_end/third_party/lighthouse/locales/pt.json +157 -142
- package/front_end/third_party/lighthouse/locales/ro.json +149 -134
- package/front_end/third_party/lighthouse/locales/ru.json +76 -61
- package/front_end/third_party/lighthouse/locales/sk.json +153 -138
- package/front_end/third_party/lighthouse/locales/sl.json +149 -134
- package/front_end/third_party/lighthouse/locales/sr-Latn.json +151 -136
- package/front_end/third_party/lighthouse/locales/sr.json +151 -136
- package/front_end/third_party/lighthouse/locales/sv.json +152 -137
- package/front_end/third_party/lighthouse/locales/ta.json +156 -141
- package/front_end/third_party/lighthouse/locales/te.json +157 -142
- package/front_end/third_party/lighthouse/locales/th.json +111 -96
- package/front_end/third_party/lighthouse/locales/tr.json +153 -138
- package/front_end/third_party/lighthouse/locales/uk.json +149 -134
- package/front_end/third_party/lighthouse/locales/vi.json +162 -147
- package/front_end/third_party/lighthouse/locales/zh-HK.json +150 -135
- package/front_end/third_party/lighthouse/locales/zh-TW.json +154 -139
- package/front_end/third_party/lighthouse/locales/zh.json +152 -137
- package/front_end/third_party/lighthouse/report/bundle.d.ts +9 -8
- package/front_end/third_party/lighthouse/report/bundle.js +10 -10
- package/front_end/third_party/lighthouse/report-assets/report-generator.mjs +2 -7
- package/front_end/tsconfig.compatibility.json +1 -0
- package/front_end/tsconfig.json +3 -2
- package/front_end/ui/components/dialogs/TypeToAllowDialog.ts +0 -2
- package/front_end/ui/components/dialogs/typeToAllowDialog.css +0 -4
- package/front_end/ui/components/icon_button/fileSourceIcon.css +1 -1
- package/front_end/ui/components/input/textInput.css +1 -1
- package/front_end/ui/components/lists/List.ts +26 -14
- package/front_end/ui/components/menus/menus.ts +0 -2
- package/front_end/ui/components/suggestion_input/SuggestionInput.ts +351 -138
- package/front_end/ui/components/survey_link/surveyLink.css +3 -3
- package/front_end/ui/components/switch/switch.css +6 -6
- package/front_end/ui/components/text_editor/AiCodeCompletionTeaser.ts +2 -3
- package/front_end/ui/components/text_editor/TextEditor.ts +1 -1
- package/front_end/ui/components/tooltips/Tooltip.ts +53 -4
- package/front_end/ui/components/tree_outline/treeOutline.css +7 -7
- package/front_end/ui/helpers/OpenInNewTab.ts +8 -3
- package/front_end/ui/legacy/EmptyWidget.ts +4 -4
- package/front_end/ui/legacy/ForwardedInputEventHandler.ts +2 -2
- package/front_end/ui/legacy/GlassPane.ts +1 -1
- package/front_end/ui/legacy/KeyboardShortcut.ts +7 -7
- package/front_end/ui/legacy/RemoteDebuggingTerminatedScreen.ts +2 -2
- package/front_end/ui/legacy/TabbedPane.ts +198 -66
- package/front_end/ui/legacy/TargetCrashedScreen.ts +2 -2
- package/front_end/ui/legacy/UIUtils.ts +71 -68
- package/front_end/ui/legacy/View.ts +7 -4
- package/front_end/ui/legacy/ViewManager.ts +49 -37
- package/front_end/ui/legacy/Widget.ts +32 -12
- package/front_end/ui/legacy/components/cookie_table/CookiesTable.ts +2 -3
- package/front_end/ui/legacy/components/inline_editor/AnimationTimingUI.ts +8 -8
- package/front_end/ui/legacy/components/inline_editor/BezierUI.ts +8 -9
- package/front_end/ui/legacy/components/inline_editor/LinkSwatch.ts +2 -2
- package/front_end/ui/legacy/components/inline_editor/cssAngleEditor.css +1 -1
- package/front_end/ui/legacy/components/inline_editor/cssAngleSwatch.css +1 -1
- package/front_end/ui/legacy/components/object_ui/ObjectPropertiesSection.ts +45 -11
- package/front_end/ui/legacy/components/object_ui/RemoteObjectPreviewFormatter.ts +10 -12
- package/front_end/ui/legacy/components/perf_ui/ChartViewport.ts +102 -29
- package/front_end/ui/legacy/components/perf_ui/FlameChart.ts +148 -122
- package/front_end/ui/legacy/components/perf_ui/TimelineOverviewPane.ts +20 -14
- package/front_end/ui/legacy/components/quick_open/filteredListWidget.css +1 -1
- package/front_end/ui/legacy/components/source_frame/FontView.ts +29 -5
- package/front_end/ui/legacy/components/source_frame/ImageView.ts +79 -12
- package/front_end/ui/legacy/components/source_frame/JSONView.ts +20 -2
- package/front_end/ui/legacy/components/source_frame/PreviewFactory.ts +2 -2
- package/front_end/ui/legacy/components/source_frame/StreamingContentHexView.ts +6 -10
- package/front_end/ui/legacy/components/source_frame/XMLView.ts +11 -11
- package/front_end/ui/legacy/components/source_frame/fontView.css +7 -0
- package/front_end/ui/legacy/components/source_frame/imageView.css +7 -0
- package/front_end/ui/legacy/components/utils/JSPresentationUtils.ts +14 -3
- package/front_end/ui/legacy/components/utils/Linkifier.ts +126 -2
- package/front_end/ui/legacy/emptyWidget.css +2 -1
- package/front_end/ui/legacy/inspectorCommon.css +3 -3
- package/front_end/ui/legacy/smallBubble.css +1 -1
- package/front_end/ui/legacy/tabbedPane.css +6 -0
- package/front_end/ui/lit/Directives.ts +35 -18
- package/front_end/ui/lit/lit.ts +0 -2
- package/front_end/ui/lit/render.ts +0 -7
- package/front_end/ui/visual_logging/KnownContextValues.ts +5 -0
- package/package.json +1 -1
- package/vpython.toml +8 -0
- package/vpython.toml.uv.lock +3 -0
- package/.agents/skills/review-models-core/SKILL.md +0 -73
- package/.agents/skills/review-tests/SKILL.md +0 -67
- package/.agents/skills/review-ui-widgets/SKILL.md +0 -115
- package/front_end/generated/ARIAProperties.ts +0 -2686
- package/front_end/ui/components/menus/README.md +0 -119
- package/front_end/ui/components/menus/SelectMenu.ts +0 -473
- package/front_end/ui/components/menus/selectMenu.css +0 -54
- package/front_end/ui/components/menus/selectMenuButton.css +0 -108
|
@@ -1,125 +1,476 @@
|
|
|
1
1
|
// Copyright 2020 The Chromium Authors
|
|
2
2
|
// Use of this source code is governed by a BSD-style license that can be
|
|
3
3
|
// found in the LICENSE file.
|
|
4
|
-
|
|
4
|
+
|
|
5
|
+
import '../../ui/components/request_link_icon/request_link_icon.js';
|
|
5
6
|
|
|
6
7
|
import * as Host from '../../core/host/host.js';
|
|
7
8
|
import * as i18n from '../../core/i18n/i18n.js';
|
|
8
9
|
import * as Platform from '../../core/platform/platform.js';
|
|
10
|
+
import type * as SDK from '../../core/sdk/sdk.js';
|
|
9
11
|
import * as Protocol from '../../generated/protocol.js';
|
|
10
12
|
import * as IssuesManager from '../../models/issues_manager/issues_manager.js';
|
|
13
|
+
import type * as Logs from '../../models/logs/logs.js';
|
|
11
14
|
import * as NetworkForward from '../../panels/network/forward/forward.js';
|
|
15
|
+
import type * as RequestLinkIcon from '../../ui/components/request_link_icon/request_link_icon.js';
|
|
16
|
+
import * as Components from '../../ui/legacy/components/utils/utils.js';
|
|
17
|
+
import * as UI from '../../ui/legacy/legacy.js';
|
|
18
|
+
import {html, type LitTemplate, nothing, render} from '../../ui/lit/lit.js';
|
|
12
19
|
|
|
13
20
|
import {AffectedItem, AffectedResourcesView} from './AffectedResourcesView.js';
|
|
14
21
|
import type {IssueView} from './IssueView.js';
|
|
15
22
|
|
|
23
|
+
const {widget} = UI.Widget;
|
|
24
|
+
|
|
25
|
+
export interface RequestCellData {
|
|
26
|
+
affectedRequest: Protocol.Audits.AffectedRequest;
|
|
27
|
+
linkToPreflight?: boolean;
|
|
28
|
+
highlightHeader?: {section: NetworkForward.UIRequestLocation.UIHeaderSection, name: string};
|
|
29
|
+
additionalOnClickAction?: () => void;
|
|
30
|
+
}
|
|
31
|
+
|
|
32
|
+
export interface SourceLocationData {
|
|
33
|
+
target: SDK.Target.Target|null;
|
|
34
|
+
scriptId: Protocol.Runtime.ScriptId|null;
|
|
35
|
+
url: Platform.DevToolsPath.UrlString;
|
|
36
|
+
lineNumber: number;
|
|
37
|
+
columnNumber?: number;
|
|
38
|
+
}
|
|
39
|
+
|
|
40
|
+
export interface CorsRow {
|
|
41
|
+
request: RequestCellData;
|
|
42
|
+
isWarning: boolean;
|
|
43
|
+
preflight?: RequestCellData;
|
|
44
|
+
header: string;
|
|
45
|
+
problem: string;
|
|
46
|
+
failedParameter: string;
|
|
47
|
+
initiatorOrigin: string;
|
|
48
|
+
resourceIPAddressSpace: string;
|
|
49
|
+
initiatorIPAddressSpace: string;
|
|
50
|
+
initiatorIsSecureContext: boolean|undefined;
|
|
51
|
+
sourceLocation?: SourceLocationData;
|
|
52
|
+
}
|
|
53
|
+
|
|
54
|
+
export interface ViewInput {
|
|
55
|
+
issueCode?: IssuesManager.CorsIssue.IssueCode;
|
|
56
|
+
rows: CorsRow[];
|
|
57
|
+
requestResolver: Logs.RequestResolver.RequestResolver;
|
|
58
|
+
}
|
|
59
|
+
|
|
60
|
+
export type View = (input: ViewInput, _output: undefined, target: HTMLElement) => void;
|
|
61
|
+
|
|
62
|
+
export const DEFAULT_VIEW: View = (input, _output, target) => {
|
|
63
|
+
const renderStatus = (isWarning: boolean): LitTemplate => html`
|
|
64
|
+
<td class=${isWarning ? 'affected-resource-report-only-status' : 'affected-resource-blocked-status'}>
|
|
65
|
+
${isWarning ? i18nString(UIStrings.warning) : i18nString(UIStrings.blocked)}
|
|
66
|
+
</td>
|
|
67
|
+
`;
|
|
68
|
+
|
|
69
|
+
const renderRequestCell = (request: RequestCellData): LitTemplate => {
|
|
70
|
+
// clang-format off
|
|
71
|
+
return html`
|
|
72
|
+
<td class="affected-resource-cell">
|
|
73
|
+
<devtools-request-link-icon .data=${{
|
|
74
|
+
...request,
|
|
75
|
+
requestResolver: input.requestResolver,
|
|
76
|
+
displayURL: true,
|
|
77
|
+
} as RequestLinkIcon.RequestLinkIcon.RequestLinkIconData}></devtools-request-link-icon>
|
|
78
|
+
</td>
|
|
79
|
+
`;
|
|
80
|
+
// clang-format on
|
|
81
|
+
};
|
|
82
|
+
|
|
83
|
+
const renderPreflightCell = (preflight: RequestCellData|undefined): LitTemplate =>
|
|
84
|
+
preflight ? renderRequestCell(preflight) : html`<td></td>`;
|
|
85
|
+
|
|
86
|
+
const renderCodeExampleCell = (text: string): LitTemplate => html`<td class="code-example">${text}</td>`;
|
|
87
|
+
|
|
88
|
+
const renderSourceLocationCell = (location: SourceLocationData|undefined): LitTemplate => {
|
|
89
|
+
if (!location) {
|
|
90
|
+
return html`<td class="affected-source-location"></td>`;
|
|
91
|
+
}
|
|
92
|
+
// clang-format off
|
|
93
|
+
return html`
|
|
94
|
+
<td class="affected-source-location">${
|
|
95
|
+
widget(Components.Linkifier.ScriptLocationLink, {
|
|
96
|
+
target: location.target ?? undefined,
|
|
97
|
+
scriptId: location.scriptId ?? undefined,
|
|
98
|
+
sourceURL: location.url,
|
|
99
|
+
lineNumber: location.lineNumber,
|
|
100
|
+
options: {
|
|
101
|
+
columnNumber: location.columnNumber,
|
|
102
|
+
maxLength: UI.UIUtils.MaxLengthForDisplayedURLsInConsole,
|
|
103
|
+
jslogContext: 'source-location',
|
|
104
|
+
},
|
|
105
|
+
})}</td>
|
|
106
|
+
`;
|
|
107
|
+
// clang-format on
|
|
108
|
+
};
|
|
109
|
+
|
|
110
|
+
const renderSecureContextCell = (isSecureContext: boolean|undefined): LitTemplate => html`
|
|
111
|
+
<td>${
|
|
112
|
+
isSecureContext === undefined ? nothing :
|
|
113
|
+
isSecureContext ? i18nString(UIStrings.secure) :
|
|
114
|
+
i18nString(UIStrings.insecure)}</td>
|
|
115
|
+
`;
|
|
116
|
+
|
|
117
|
+
const renderExtraHeaderColumns = (issueCode: IssuesManager.CorsIssue.IssueCode): LitTemplate => {
|
|
118
|
+
switch (issueCode) {
|
|
119
|
+
case IssuesManager.CorsIssue.IssueCode.INVALID_HEADER_VALUES:
|
|
120
|
+
// clang-format off
|
|
121
|
+
return html`
|
|
122
|
+
<td class="affected-resource-header">${i18nString(UIStrings.preflightRequestIfProblematic)}</td>
|
|
123
|
+
<td class="affected-resource-header">${i18nString(UIStrings.header)}</td>
|
|
124
|
+
<td class="affected-resource-header">${i18nString(UIStrings.problem)}</td>
|
|
125
|
+
<td class="affected-resource-header">${i18nString(UIStrings.invalidValue)}</td>
|
|
126
|
+
`;
|
|
127
|
+
// clang-format on
|
|
128
|
+
case IssuesManager.CorsIssue.IssueCode.WILDCARD_ORIGN_NOT_ALLOWED:
|
|
129
|
+
return html`<td class="affected-resource-header">${i18nString(UIStrings.preflightRequestIfProblematic)}</td>`;
|
|
130
|
+
case IssuesManager.CorsIssue.IssueCode.PREFLIGHT_RESPONSE_INVALID:
|
|
131
|
+
// clang-format off
|
|
132
|
+
return html`
|
|
133
|
+
<td class="affected-resource-header">${i18nString(UIStrings.preflightRequest)}</td>
|
|
134
|
+
<td class="affected-resource-header">${i18nString(UIStrings.problem)}</td>
|
|
135
|
+
`;
|
|
136
|
+
// clang-format on
|
|
137
|
+
case IssuesManager.CorsIssue.IssueCode.ORIGIN_MISMATCH:
|
|
138
|
+
// clang-format off
|
|
139
|
+
return html`
|
|
140
|
+
<td class="affected-resource-header">${i18nString(UIStrings.preflightRequestIfProblematic)}</td>
|
|
141
|
+
<td class="affected-resource-header">${i18nString(UIStrings.initiatorContext)}</td>
|
|
142
|
+
<td class="affected-resource-header">${i18nString(UIStrings.allowedOrigin)}</td>
|
|
143
|
+
`;
|
|
144
|
+
// clang-format on
|
|
145
|
+
case IssuesManager.CorsIssue.IssueCode.ALLOW_CREDENTIALS_REQUIRED:
|
|
146
|
+
// clang-format off
|
|
147
|
+
return html`
|
|
148
|
+
<td class="affected-resource-header">${i18nString(UIStrings.preflightRequestIfProblematic)}</td>
|
|
149
|
+
<td class="affected-resource-header">${i18nString(UIStrings.allowCredentialsValueFromHeader)}</td>
|
|
150
|
+
`;
|
|
151
|
+
// clang-format on
|
|
152
|
+
case IssuesManager.CorsIssue.IssueCode.INSECURE_LOCAL_NETWORK:
|
|
153
|
+
// clang-format off
|
|
154
|
+
return html`
|
|
155
|
+
<td class="affected-resource-header">${i18nString(UIStrings.resourceAddressSpace)}</td>
|
|
156
|
+
<td class="affected-resource-header">${i18nString(UIStrings.initiatorAddressSpace)}</td>
|
|
157
|
+
<td class="affected-resource-header">${i18nString(UIStrings.initiatorContext)}</td>
|
|
158
|
+
`;
|
|
159
|
+
// clang-format on
|
|
160
|
+
case IssuesManager.CorsIssue.IssueCode.METHOD_DISALLOWED_BY_PREFLIGHT_RESPONSE:
|
|
161
|
+
// clang-format off
|
|
162
|
+
return html`
|
|
163
|
+
<td class="affected-resource-header">${i18nString(UIStrings.preflightRequest)}</td>
|
|
164
|
+
<td class="affected-resource-header">${i18nString(UIStrings.disallowedRequestMethod)}</td>
|
|
165
|
+
`;
|
|
166
|
+
// clang-format on
|
|
167
|
+
case IssuesManager.CorsIssue.IssueCode.HEADER_DISALLOWED_BY_PREFLIGHT_RESPONSE:
|
|
168
|
+
// clang-format off
|
|
169
|
+
return html`
|
|
170
|
+
<td class="affected-resource-header">${i18nString(UIStrings.preflightRequest)}</td>
|
|
171
|
+
<td class="affected-resource-header">${i18nString(UIStrings.disallowedRequestHeader)}</td>
|
|
172
|
+
`;
|
|
173
|
+
// clang-format on
|
|
174
|
+
case IssuesManager.CorsIssue.IssueCode.DISALLOWED_BY_MODE:
|
|
175
|
+
// clang-format off
|
|
176
|
+
return html`
|
|
177
|
+
<td class="affected-resource-header">${i18nString(UIStrings.initiatorContext)}</td>
|
|
178
|
+
<td class="affected-resource-header">${i18nString(UIStrings.sourceLocation)}</td>
|
|
179
|
+
`;
|
|
180
|
+
// clang-format on
|
|
181
|
+
case IssuesManager.CorsIssue.IssueCode.CORS_DISABLED_SCHEME:
|
|
182
|
+
// clang-format off
|
|
183
|
+
return html`
|
|
184
|
+
<td class="affected-resource-header">${i18nString(UIStrings.initiatorContext)}</td>
|
|
185
|
+
<td class="affected-resource-header">${i18nString(UIStrings.sourceLocation)}</td>
|
|
186
|
+
<td class="affected-resource-header">${i18nString(UIStrings.unsupportedScheme)}</td>
|
|
187
|
+
`;
|
|
188
|
+
// clang-format on
|
|
189
|
+
case IssuesManager.CorsIssue.IssueCode.NO_CORS_REDIRECT_MODE_NOT_FOLLOW:
|
|
190
|
+
return html`<td class="affected-resource-header">${i18nString(UIStrings.sourceLocation)}</td>`;
|
|
191
|
+
case IssuesManager.CorsIssue.IssueCode.REDIRECT_CONTAINS_CREDENTIALS:
|
|
192
|
+
case IssuesManager.CorsIssue.IssueCode.PREFLIGHT_MISSING_ALLOW_EXTERNAL:
|
|
193
|
+
case IssuesManager.CorsIssue.IssueCode.PREFLIGHT_INVALID_ALLOW_EXTERNAL:
|
|
194
|
+
case IssuesManager.CorsIssue.IssueCode.INVALID_LOCAL_NETWORK_ACCESS:
|
|
195
|
+
case IssuesManager.CorsIssue.IssueCode.LOCAL_NETWORK_ACCESS_PERMISSION_DENIED:
|
|
196
|
+
return nothing;
|
|
197
|
+
default:
|
|
198
|
+
Platform.assertNever(issueCode, 'Unknown issue code: ' + issueCode);
|
|
199
|
+
}
|
|
200
|
+
};
|
|
201
|
+
|
|
202
|
+
const renderRow = (issueCode: IssuesManager.CorsIssue.IssueCode, row: CorsRow): LitTemplate => {
|
|
203
|
+
switch (issueCode) {
|
|
204
|
+
case IssuesManager.CorsIssue.IssueCode.INVALID_HEADER_VALUES:
|
|
205
|
+
// clang-format off
|
|
206
|
+
return html`
|
|
207
|
+
<tr class="affected-resource-directive">
|
|
208
|
+
${renderRequestCell(row.request)}
|
|
209
|
+
${renderStatus(row.isWarning)}
|
|
210
|
+
${renderPreflightCell(row.preflight)}
|
|
211
|
+
${renderCodeExampleCell(row.header)}
|
|
212
|
+
<td>${row.problem}</td>
|
|
213
|
+
${renderCodeExampleCell(row.failedParameter)}
|
|
214
|
+
</tr>
|
|
215
|
+
`;
|
|
216
|
+
// clang-format on
|
|
217
|
+
case IssuesManager.CorsIssue.IssueCode.WILDCARD_ORIGN_NOT_ALLOWED:
|
|
218
|
+
// clang-format off
|
|
219
|
+
return html`
|
|
220
|
+
<tr class="affected-resource-directive">
|
|
221
|
+
${renderRequestCell(row.request)}
|
|
222
|
+
${renderStatus(row.isWarning)}
|
|
223
|
+
${renderPreflightCell(row.preflight)}
|
|
224
|
+
</tr>
|
|
225
|
+
`;
|
|
226
|
+
// clang-format on
|
|
227
|
+
case IssuesManager.CorsIssue.IssueCode.PREFLIGHT_RESPONSE_INVALID:
|
|
228
|
+
// clang-format off
|
|
229
|
+
return html`
|
|
230
|
+
<tr class="affected-resource-directive">
|
|
231
|
+
${renderRequestCell(row.request)}
|
|
232
|
+
${renderStatus(row.isWarning)}
|
|
233
|
+
${renderPreflightCell(row.preflight)}
|
|
234
|
+
<td>${row.problem}</td>
|
|
235
|
+
</tr>
|
|
236
|
+
`;
|
|
237
|
+
// clang-format on
|
|
238
|
+
case IssuesManager.CorsIssue.IssueCode.ORIGIN_MISMATCH:
|
|
239
|
+
// clang-format off
|
|
240
|
+
return html`
|
|
241
|
+
<tr class="affected-resource-directive">
|
|
242
|
+
${renderRequestCell(row.request)}
|
|
243
|
+
${renderStatus(row.isWarning)}
|
|
244
|
+
${renderPreflightCell(row.preflight)}
|
|
245
|
+
${renderCodeExampleCell(row.initiatorOrigin)}
|
|
246
|
+
${renderCodeExampleCell(row.failedParameter)}
|
|
247
|
+
</tr>
|
|
248
|
+
`;
|
|
249
|
+
// clang-format on
|
|
250
|
+
case IssuesManager.CorsIssue.IssueCode.ALLOW_CREDENTIALS_REQUIRED:
|
|
251
|
+
case IssuesManager.CorsIssue.IssueCode.METHOD_DISALLOWED_BY_PREFLIGHT_RESPONSE:
|
|
252
|
+
case IssuesManager.CorsIssue.IssueCode.HEADER_DISALLOWED_BY_PREFLIGHT_RESPONSE:
|
|
253
|
+
// clang-format off
|
|
254
|
+
return html`
|
|
255
|
+
<tr class="affected-resource-directive">
|
|
256
|
+
${renderRequestCell(row.request)}
|
|
257
|
+
${renderStatus(row.isWarning)}
|
|
258
|
+
${renderPreflightCell(row.preflight)}
|
|
259
|
+
${renderCodeExampleCell(row.failedParameter)}
|
|
260
|
+
</tr>
|
|
261
|
+
`;
|
|
262
|
+
// clang-format on
|
|
263
|
+
case IssuesManager.CorsIssue.IssueCode.INSECURE_LOCAL_NETWORK:
|
|
264
|
+
// clang-format off
|
|
265
|
+
return html`
|
|
266
|
+
<tr class="affected-resource-directive">
|
|
267
|
+
${renderRequestCell(row.request)}
|
|
268
|
+
${renderStatus(row.isWarning)}
|
|
269
|
+
<td>${row.resourceIPAddressSpace}</td>
|
|
270
|
+
<td>${row.initiatorIPAddressSpace}</td>
|
|
271
|
+
${renderSecureContextCell(row.initiatorIsSecureContext)}
|
|
272
|
+
</tr>
|
|
273
|
+
`;
|
|
274
|
+
// clang-format on
|
|
275
|
+
case IssuesManager.CorsIssue.IssueCode.DISALLOWED_BY_MODE:
|
|
276
|
+
// clang-format off
|
|
277
|
+
return html`
|
|
278
|
+
<tr class="affected-resource-directive">
|
|
279
|
+
${renderRequestCell(row.request)}
|
|
280
|
+
${renderStatus(row.isWarning)}
|
|
281
|
+
${renderCodeExampleCell(row.initiatorOrigin)}
|
|
282
|
+
${renderSourceLocationCell(row.sourceLocation)}
|
|
283
|
+
</tr>
|
|
284
|
+
`;
|
|
285
|
+
// clang-format on
|
|
286
|
+
case IssuesManager.CorsIssue.IssueCode.CORS_DISABLED_SCHEME:
|
|
287
|
+
// clang-format off
|
|
288
|
+
return html`
|
|
289
|
+
<tr class="affected-resource-directive">
|
|
290
|
+
${renderRequestCell(row.request)}
|
|
291
|
+
${renderStatus(row.isWarning)}
|
|
292
|
+
${renderCodeExampleCell(row.initiatorOrigin)}
|
|
293
|
+
${renderSourceLocationCell(row.sourceLocation)}
|
|
294
|
+
${renderCodeExampleCell(row.failedParameter)}
|
|
295
|
+
</tr>
|
|
296
|
+
`;
|
|
297
|
+
// clang-format on
|
|
298
|
+
case IssuesManager.CorsIssue.IssueCode.NO_CORS_REDIRECT_MODE_NOT_FOLLOW:
|
|
299
|
+
// clang-format off
|
|
300
|
+
return html`
|
|
301
|
+
<tr class="affected-resource-directive">
|
|
302
|
+
${renderRequestCell(row.request)}
|
|
303
|
+
${renderStatus(row.isWarning)}
|
|
304
|
+
${renderSourceLocationCell(row.sourceLocation)}
|
|
305
|
+
</tr>
|
|
306
|
+
`;
|
|
307
|
+
// clang-format on
|
|
308
|
+
case IssuesManager.CorsIssue.IssueCode.REDIRECT_CONTAINS_CREDENTIALS:
|
|
309
|
+
case IssuesManager.CorsIssue.IssueCode.PREFLIGHT_MISSING_ALLOW_EXTERNAL:
|
|
310
|
+
case IssuesManager.CorsIssue.IssueCode.PREFLIGHT_INVALID_ALLOW_EXTERNAL:
|
|
311
|
+
case IssuesManager.CorsIssue.IssueCode.INVALID_LOCAL_NETWORK_ACCESS:
|
|
312
|
+
case IssuesManager.CorsIssue.IssueCode.LOCAL_NETWORK_ACCESS_PERMISSION_DENIED:
|
|
313
|
+
// clang-format off
|
|
314
|
+
return html`
|
|
315
|
+
<tr class="affected-resource-directive">
|
|
316
|
+
${renderRequestCell(row.request)}
|
|
317
|
+
${renderStatus(row.isWarning)}
|
|
318
|
+
</tr>
|
|
319
|
+
`;
|
|
320
|
+
// clang-format on
|
|
321
|
+
default:
|
|
322
|
+
Platform.assertNever(issueCode, 'Unknown issue code: ' + issueCode);
|
|
323
|
+
}
|
|
324
|
+
};
|
|
325
|
+
|
|
326
|
+
const issueCode = input.issueCode;
|
|
327
|
+
// clang-format off
|
|
328
|
+
render(issueCode ? html`
|
|
329
|
+
<tr>
|
|
330
|
+
<td class="affected-resource-header">${i18nString(UIStrings.request)}</td>
|
|
331
|
+
<td class="affected-resource-header">${i18nString(UIStrings.status)}</td>
|
|
332
|
+
${renderExtraHeaderColumns(issueCode)}
|
|
333
|
+
</tr>
|
|
334
|
+
${input.rows.map(row => renderRow(issueCode, row))}
|
|
335
|
+
` : nothing, target);
|
|
336
|
+
// clang-format on
|
|
337
|
+
};
|
|
338
|
+
|
|
16
339
|
const UIStrings = {
|
|
17
340
|
/**
|
|
18
|
-
* @description Label in the Issues panel for the number of affected requests
|
|
341
|
+
* @description Label in the Issues panel for the number of affected requests
|
|
342
|
+
* in the CORS affected resources table.
|
|
19
343
|
*/
|
|
20
344
|
nRequests: '{n, plural, =1 {# request} other {# requests}}',
|
|
21
345
|
/**
|
|
22
|
-
* @description Violation status in the Issues panel indicating that a CORS
|
|
346
|
+
* @description Violation status in the Issues panel indicating that a CORS
|
|
347
|
+
* issue produced a warning.
|
|
23
348
|
*/
|
|
24
349
|
warning: 'Warning',
|
|
25
350
|
/**
|
|
26
|
-
* @description Violation status in the Issues panel indicating that a CORS
|
|
351
|
+
* @description Violation status in the Issues panel indicating that a CORS
|
|
352
|
+
* request was blocked.
|
|
27
353
|
*/
|
|
28
354
|
blocked: 'Blocked',
|
|
29
355
|
/**
|
|
30
|
-
* @description Column header in the Issues panel for request status in the
|
|
356
|
+
* @description Column header in the Issues panel for request status in the
|
|
357
|
+
* CORS affected resources table.
|
|
31
358
|
*/
|
|
32
359
|
status: 'Status',
|
|
33
360
|
/**
|
|
34
|
-
* @description Column header in the Issues panel for network requests in the
|
|
361
|
+
* @description Column header in the Issues panel for network requests in the
|
|
362
|
+
* CORS affected resources table.
|
|
35
363
|
*/
|
|
36
364
|
request: 'Request',
|
|
37
365
|
/**
|
|
38
|
-
* @description Column header in the Issues panel for resource addresses in
|
|
366
|
+
* @description Column header in the Issues panel for resource addresses in
|
|
367
|
+
* the CORS affected resources table.
|
|
39
368
|
*/
|
|
40
369
|
resourceAddressSpace: 'Resource address',
|
|
41
370
|
/**
|
|
42
|
-
* @description Column header in the Issues panel for initiator addresses in
|
|
371
|
+
* @description Column header in the Issues panel for initiator addresses in
|
|
372
|
+
* the CORS affected resources table.
|
|
43
373
|
*/
|
|
44
374
|
initiatorAddressSpace: 'Initiator address',
|
|
45
375
|
/**
|
|
46
|
-
* @description Context status in the Issues panel indicating a secure
|
|
376
|
+
* @description Context status in the Issues panel indicating a secure
|
|
377
|
+
* initiator context.
|
|
47
378
|
*/
|
|
48
379
|
secure: 'Secure',
|
|
49
380
|
/**
|
|
50
|
-
* @description Context status in the Issues panel indicating an insecure
|
|
381
|
+
* @description Context status in the Issues panel indicating an insecure
|
|
382
|
+
* initiator context.
|
|
51
383
|
*/
|
|
52
384
|
insecure: 'Insecure',
|
|
53
385
|
/**
|
|
54
|
-
* @description Column header in the Issues panel for initiator context in the
|
|
386
|
+
* @description Column header in the Issues panel for initiator context in the
|
|
387
|
+
* CORS affected resources table.
|
|
55
388
|
*/
|
|
56
389
|
initiatorContext: 'Initiator context',
|
|
57
390
|
/**
|
|
58
|
-
* @description Column header in the Issues panel for preflight requests when
|
|
391
|
+
* @description Column header in the Issues panel for preflight requests when
|
|
392
|
+
* problematic in the CORS affected resources table.
|
|
59
393
|
*/
|
|
60
394
|
preflightRequestIfProblematic: 'Preflight request (if problematic)',
|
|
61
395
|
/**
|
|
62
|
-
* @description Column header in the Issues panel for preflight requests in
|
|
396
|
+
* @description Column header in the Issues panel for preflight requests in
|
|
397
|
+
* the CORS affected resources table.
|
|
63
398
|
*/
|
|
64
399
|
preflightRequest: 'Preflight request',
|
|
65
400
|
/**
|
|
66
|
-
* @description Column header in the Issues panel for HTTP header names in the
|
|
401
|
+
* @description Column header in the Issues panel for HTTP header names in the
|
|
402
|
+
* CORS affected resources table.
|
|
67
403
|
*/
|
|
68
404
|
header: 'Header',
|
|
69
405
|
/**
|
|
70
|
-
* @description Column header in the Issues panel for problem descriptions in
|
|
406
|
+
* @description Column header in the Issues panel for problem descriptions in
|
|
407
|
+
* the CORS affected resources table.
|
|
71
408
|
*/
|
|
72
409
|
problem: 'Problem',
|
|
73
410
|
/**
|
|
74
|
-
* @description Column header in the Issues panel for invalid header values in
|
|
411
|
+
* @description Column header in the Issues panel for invalid header values in
|
|
412
|
+
* the CORS affected resources table.
|
|
75
413
|
*/
|
|
76
414
|
invalidValue: 'Invalid value (if available)',
|
|
77
415
|
/**
|
|
78
|
-
* @description Problem description in the Issues panel indicating that a
|
|
416
|
+
* @description Problem description in the Issues panel indicating that a
|
|
417
|
+
* required CORS response header was missing.
|
|
79
418
|
*/
|
|
80
419
|
problemMissingHeader: 'Missing header',
|
|
81
420
|
/**
|
|
82
|
-
* @description Problem description in the Issues panel indicating that a CORS
|
|
421
|
+
* @description Problem description in the Issues panel indicating that a CORS
|
|
422
|
+
* response header contained multiple values.
|
|
83
423
|
*/
|
|
84
424
|
problemMultipleValues: 'Multiple values',
|
|
85
425
|
/**
|
|
86
|
-
* @description Problem description in the Issues panel indicating that a CORS
|
|
426
|
+
* @description Problem description in the Issues panel indicating that a CORS
|
|
427
|
+
* response header contained an invalid value.
|
|
87
428
|
*/
|
|
88
429
|
problemInvalidValue: 'Invalid value',
|
|
89
430
|
/**
|
|
90
|
-
* @description Problem description in the Issues panel indicating that the
|
|
431
|
+
* @description Problem description in the Issues panel indicating that the
|
|
432
|
+
* preflight response was a redirect.
|
|
91
433
|
*/
|
|
92
434
|
preflightDisallowedRedirect: 'Response to preflight was a redirect',
|
|
93
435
|
/**
|
|
94
|
-
* @description Problem description in the Issues panel indicating that the
|
|
436
|
+
* @description Problem description in the Issues panel indicating that the
|
|
437
|
+
* preflight request HTTP status was not successful.
|
|
95
438
|
*/
|
|
96
439
|
preflightInvalidStatus: 'HTTP status of preflight request didn’t indicate success',
|
|
97
440
|
/**
|
|
98
|
-
* @description Column header in the Issues panel for allowed origins in the
|
|
441
|
+
* @description Column header in the Issues panel for allowed origins in the
|
|
442
|
+
* CORS affected resources table.
|
|
99
443
|
*/
|
|
100
444
|
allowedOrigin: 'Allowed origin (from header)',
|
|
101
445
|
/**
|
|
102
|
-
* @description Column header in the Issues panel for the
|
|
446
|
+
* @description Column header in the Issues panel for the
|
|
447
|
+
* Access-Control-Allow-Credentials header value in the CORS affected
|
|
448
|
+
* resources table.
|
|
103
449
|
*/
|
|
104
450
|
allowCredentialsValueFromHeader: '`Access-Control-Allow-Credentials` header value',
|
|
105
451
|
/**
|
|
106
|
-
* @description Column header in the Issues panel for disallowed request
|
|
452
|
+
* @description Column header in the Issues panel for disallowed request
|
|
453
|
+
* methods in the CORS affected resources table.
|
|
107
454
|
*/
|
|
108
455
|
disallowedRequestMethod: 'Disallowed request method',
|
|
109
456
|
/**
|
|
110
|
-
* @description Column header in the Issues panel for disallowed request
|
|
457
|
+
* @description Column header in the Issues panel for disallowed request
|
|
458
|
+
* headers in the CORS affected resources table.
|
|
111
459
|
*/
|
|
112
460
|
disallowedRequestHeader: 'Disallowed request header',
|
|
113
461
|
/**
|
|
114
|
-
* @description Column header in the Issues panel for source locations in the
|
|
462
|
+
* @description Column header in the Issues panel for source locations in the
|
|
463
|
+
* CORS affected resources table.
|
|
115
464
|
*/
|
|
116
465
|
sourceLocation: 'Source location',
|
|
117
466
|
/**
|
|
118
|
-
* @description Column header in the Issues panel for unsupported URL schemes
|
|
467
|
+
* @description Column header in the Issues panel for unsupported URL schemes
|
|
468
|
+
* in the CORS affected resources table.
|
|
119
469
|
*/
|
|
120
470
|
unsupportedScheme: 'Unsupported scheme',
|
|
121
471
|
/**
|
|
122
|
-
* @description Problem description in the Issues panel indicating that a
|
|
472
|
+
* @description Problem description in the Issues panel indicating that a
|
|
473
|
+
* network request failed.
|
|
123
474
|
*/
|
|
124
475
|
failedRequest: 'Failed request',
|
|
125
476
|
} as const;
|
|
@@ -127,112 +478,34 @@ const str_ = i18n.i18n.registerUIStrings('panels/issues/CorsIssueDetailsView.ts'
|
|
|
127
478
|
const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
|
|
128
479
|
|
|
129
480
|
export class CorsIssueDetailsView extends AffectedResourcesView {
|
|
130
|
-
|
|
481
|
+
readonly #view: View;
|
|
482
|
+
readonly #onRequestClick = (): void => {
|
|
483
|
+
Host.userMetrics.issuesPanelResourceOpened(IssuesManager.Issue.IssueCategory.CORS, AffectedItem.REQUEST);
|
|
484
|
+
};
|
|
485
|
+
|
|
486
|
+
constructor(parent: IssueView, issue: IssuesManager.IssueAggregator.AggregatedIssue, jslogContext: string,
|
|
487
|
+
view: View = DEFAULT_VIEW) {
|
|
131
488
|
super(parent, issue, jslogContext);
|
|
489
|
+
this.#view = view;
|
|
132
490
|
this.affectedResourcesCountElement.classList.add('cors-issue-affected-resource-label');
|
|
133
491
|
}
|
|
134
492
|
|
|
135
|
-
#appendStatus(element: HTMLElement, isWarning: boolean): void {
|
|
136
|
-
const status = document.createElement('td');
|
|
137
|
-
if (isWarning) {
|
|
138
|
-
status.classList.add('affected-resource-report-only-status');
|
|
139
|
-
status.textContent = i18nString(UIStrings.warning);
|
|
140
|
-
} else {
|
|
141
|
-
status.classList.add('affected-resource-blocked-status');
|
|
142
|
-
status.textContent = i18nString(UIStrings.blocked);
|
|
143
|
-
}
|
|
144
|
-
element.appendChild(status);
|
|
145
|
-
}
|
|
146
|
-
|
|
147
493
|
protected getResourceNameWithCount(count: number): Platform.UIString.LocalizedString {
|
|
148
494
|
return i18nString(UIStrings.nRequests, {n: count});
|
|
149
495
|
}
|
|
150
496
|
|
|
151
|
-
#appendDetails(issueCode: IssuesManager.CorsIssue.IssueCode,
|
|
152
|
-
|
|
153
|
-
const
|
|
154
|
-
this.appendColumnTitle(header, i18nString(UIStrings.request));
|
|
155
|
-
this.appendColumnTitle(header, i18nString(UIStrings.status));
|
|
156
|
-
switch (issueCode) {
|
|
157
|
-
case IssuesManager.CorsIssue.IssueCode.INVALID_HEADER_VALUES:
|
|
158
|
-
this.appendColumnTitle(header, i18nString(UIStrings.preflightRequestIfProblematic));
|
|
159
|
-
this.appendColumnTitle(header, i18nString(UIStrings.header));
|
|
160
|
-
this.appendColumnTitle(header, i18nString(UIStrings.problem));
|
|
161
|
-
this.appendColumnTitle(header, i18nString(UIStrings.invalidValue));
|
|
162
|
-
break;
|
|
163
|
-
case IssuesManager.CorsIssue.IssueCode.WILDCARD_ORIGN_NOT_ALLOWED:
|
|
164
|
-
this.appendColumnTitle(header, i18nString(UIStrings.preflightRequestIfProblematic));
|
|
165
|
-
break;
|
|
166
|
-
case IssuesManager.CorsIssue.IssueCode.PREFLIGHT_RESPONSE_INVALID:
|
|
167
|
-
this.appendColumnTitle(header, i18nString(UIStrings.preflightRequest));
|
|
168
|
-
this.appendColumnTitle(header, i18nString(UIStrings.problem));
|
|
169
|
-
break;
|
|
170
|
-
case IssuesManager.CorsIssue.IssueCode.ORIGIN_MISMATCH:
|
|
171
|
-
this.appendColumnTitle(header, i18nString(UIStrings.preflightRequestIfProblematic));
|
|
172
|
-
this.appendColumnTitle(header, i18nString(UIStrings.initiatorContext));
|
|
173
|
-
this.appendColumnTitle(header, i18nString(UIStrings.allowedOrigin));
|
|
174
|
-
break;
|
|
175
|
-
case IssuesManager.CorsIssue.IssueCode.ALLOW_CREDENTIALS_REQUIRED:
|
|
176
|
-
this.appendColumnTitle(header, i18nString(UIStrings.preflightRequestIfProblematic));
|
|
177
|
-
this.appendColumnTitle(header, i18nString(UIStrings.allowCredentialsValueFromHeader));
|
|
178
|
-
break;
|
|
179
|
-
case IssuesManager.CorsIssue.IssueCode.INSECURE_LOCAL_NETWORK:
|
|
180
|
-
this.appendColumnTitle(header, i18nString(UIStrings.resourceAddressSpace));
|
|
181
|
-
this.appendColumnTitle(header, i18nString(UIStrings.initiatorAddressSpace));
|
|
182
|
-
this.appendColumnTitle(header, i18nString(UIStrings.initiatorContext));
|
|
183
|
-
break;
|
|
184
|
-
case IssuesManager.CorsIssue.IssueCode.METHOD_DISALLOWED_BY_PREFLIGHT_RESPONSE:
|
|
185
|
-
this.appendColumnTitle(header, i18nString(UIStrings.preflightRequest));
|
|
186
|
-
this.appendColumnTitle(header, i18nString(UIStrings.disallowedRequestMethod));
|
|
187
|
-
break;
|
|
188
|
-
case IssuesManager.CorsIssue.IssueCode.HEADER_DISALLOWED_BY_PREFLIGHT_RESPONSE:
|
|
189
|
-
this.appendColumnTitle(header, i18nString(UIStrings.preflightRequest));
|
|
190
|
-
this.appendColumnTitle(header, i18nString(UIStrings.disallowedRequestHeader));
|
|
191
|
-
break;
|
|
192
|
-
case IssuesManager.CorsIssue.IssueCode.REDIRECT_CONTAINS_CREDENTIALS:
|
|
193
|
-
// The default columns suffice.
|
|
194
|
-
break;
|
|
195
|
-
case IssuesManager.CorsIssue.IssueCode.DISALLOWED_BY_MODE:
|
|
196
|
-
this.appendColumnTitle(header, i18nString(UIStrings.initiatorContext));
|
|
197
|
-
this.appendColumnTitle(header, i18nString(UIStrings.sourceLocation));
|
|
198
|
-
break;
|
|
199
|
-
case IssuesManager.CorsIssue.IssueCode.CORS_DISABLED_SCHEME:
|
|
200
|
-
this.appendColumnTitle(header, i18nString(UIStrings.initiatorContext));
|
|
201
|
-
this.appendColumnTitle(header, i18nString(UIStrings.sourceLocation));
|
|
202
|
-
this.appendColumnTitle(header, i18nString(UIStrings.unsupportedScheme));
|
|
203
|
-
break;
|
|
204
|
-
case IssuesManager.CorsIssue.IssueCode.NO_CORS_REDIRECT_MODE_NOT_FOLLOW:
|
|
205
|
-
this.appendColumnTitle(header, i18nString(UIStrings.sourceLocation));
|
|
206
|
-
break;
|
|
207
|
-
case IssuesManager.CorsIssue.IssueCode.PREFLIGHT_MISSING_ALLOW_EXTERNAL:
|
|
208
|
-
case IssuesManager.CorsIssue.IssueCode.PREFLIGHT_INVALID_ALLOW_EXTERNAL:
|
|
209
|
-
case IssuesManager.CorsIssue.IssueCode.INVALID_LOCAL_NETWORK_ACCESS:
|
|
210
|
-
case IssuesManager.CorsIssue.IssueCode.LOCAL_NETWORK_ACCESS_PERMISSION_DENIED:
|
|
211
|
-
// The default columns suffice.
|
|
212
|
-
break;
|
|
213
|
-
default:
|
|
214
|
-
Platform.assertNever(issueCode, 'Unknow issue code ' + issueCode);
|
|
215
|
-
}
|
|
216
|
-
|
|
217
|
-
this.affectedResources.appendChild(header);
|
|
218
|
-
let count = 0;
|
|
497
|
+
#appendDetails(issueCode: IssuesManager.CorsIssue.IssueCode,
|
|
498
|
+
issues: Iterable<IssuesManager.CorsIssue.CorsIssue>): void {
|
|
499
|
+
const rows: CorsRow[] = [];
|
|
219
500
|
for (const issue of issues) {
|
|
220
|
-
|
|
221
|
-
this.#appendDetail(issueCode, issue);
|
|
501
|
+
rows.push(this.#createDetailRow(issueCode, issue));
|
|
222
502
|
}
|
|
223
|
-
this.
|
|
503
|
+
const input: ViewInput = {issueCode, rows, requestResolver: this.requestResolver};
|
|
504
|
+
this.#view(input, undefined, this.affectedResources);
|
|
505
|
+
this.updateAffectedResourceCount(rows.length);
|
|
224
506
|
}
|
|
225
507
|
|
|
226
|
-
#
|
|
227
|
-
if (isSecureContext === undefined) {
|
|
228
|
-
this.appendIssueDetailCell(element, '');
|
|
229
|
-
return;
|
|
230
|
-
}
|
|
231
|
-
this.appendIssueDetailCell(
|
|
232
|
-
element, isSecureContext ? i18nString(UIStrings.secure) : i18nString(UIStrings.insecure));
|
|
233
|
-
}
|
|
234
|
-
|
|
235
|
-
private static getHeaderFromError(corsError: Protocol.Network.CorsError): string {
|
|
508
|
+
static #getHeaderFromError(corsError: Protocol.Network.CorsError): string {
|
|
236
509
|
switch (corsError) {
|
|
237
510
|
case Protocol.Network.CorsError.InvalidAllowHeadersPreflightResponse:
|
|
238
511
|
return 'Access-Control-Allow-Headers';
|
|
@@ -262,7 +535,7 @@ export class CorsIssueDetailsView extends AffectedResourcesView {
|
|
|
262
535
|
return '';
|
|
263
536
|
}
|
|
264
537
|
|
|
265
|
-
|
|
538
|
+
static #getProblemFromError(corsErrorStatus: Protocol.Network.CorsErrorStatus): string {
|
|
266
539
|
switch (corsErrorStatus.corsError) {
|
|
267
540
|
case Protocol.Network.CorsError.InvalidAllowHeadersPreflightResponse:
|
|
268
541
|
case Protocol.Network.CorsError.InvalidAllowMethodsPreflightResponse:
|
|
@@ -285,171 +558,119 @@ export class CorsIssueDetailsView extends AffectedResourcesView {
|
|
|
285
558
|
throw new Error('Invalid Argument');
|
|
286
559
|
}
|
|
287
560
|
|
|
288
|
-
#
|
|
289
|
-
const element = document.createElement('tr');
|
|
290
|
-
element.classList.add('affected-resource-directive');
|
|
291
|
-
|
|
561
|
+
#createDetailRow(issueCode: IssuesManager.CorsIssue.IssueCode, issue: IssuesManager.CorsIssue.CorsIssue): CorsRow {
|
|
292
562
|
const details = issue.details();
|
|
293
563
|
const corsErrorStatus = details.corsErrorStatus;
|
|
294
564
|
const corsError = details.corsErrorStatus.corsError;
|
|
295
565
|
|
|
296
566
|
const highlightHeader = {
|
|
297
567
|
section: NetworkForward.UIRequestLocation.UIHeaderSection.RESPONSE,
|
|
298
|
-
name: CorsIssueDetailsView
|
|
568
|
+
name: CorsIssueDetailsView.#getHeaderFromError(corsError),
|
|
299
569
|
};
|
|
300
570
|
|
|
301
571
|
const opts = {
|
|
302
|
-
additionalOnClickAction
|
|
303
|
-
Host.userMetrics.issuesPanelResourceOpened(IssuesManager.Issue.IssueCategory.CORS, AffectedItem.REQUEST);
|
|
304
|
-
},
|
|
572
|
+
additionalOnClickAction: this.#onRequestClick,
|
|
305
573
|
};
|
|
306
574
|
|
|
307
|
-
|
|
308
|
-
|
|
309
|
-
|
|
310
|
-
|
|
311
|
-
|
|
312
|
-
|
|
313
|
-
|
|
314
|
-
|
|
315
|
-
|
|
316
|
-
|
|
317
|
-
|
|
318
|
-
|
|
319
|
-
|
|
320
|
-
|
|
321
|
-
|
|
322
|
-
|
|
323
|
-
|
|
324
|
-
|
|
325
|
-
|
|
326
|
-
|
|
327
|
-
|
|
328
|
-
|
|
329
|
-
}
|
|
330
|
-
break;
|
|
331
|
-
case IssuesManager.CorsIssue.IssueCode.PREFLIGHT_RESPONSE_INVALID: {
|
|
332
|
-
element.appendChild(this.createRequestCell(details.request, opts));
|
|
333
|
-
this.#appendStatus(element, details.isWarning);
|
|
334
|
-
const specialHighlightHeader = corsError === Protocol.Network.CorsError.PreflightInvalidStatus ?
|
|
335
|
-
{
|
|
336
|
-
section: NetworkForward.UIRequestLocation.UIHeaderSection.GENERAL,
|
|
337
|
-
name: 'Status-Code',
|
|
338
|
-
} :
|
|
339
|
-
highlightHeader;
|
|
340
|
-
element.appendChild(this.createRequestCell(
|
|
341
|
-
details.request, {...opts, linkToPreflight: true, highlightHeader: specialHighlightHeader}));
|
|
342
|
-
this.appendIssueDetailCell(element, CorsIssueDetailsView.getProblemFromError(details.corsErrorStatus));
|
|
343
|
-
break;
|
|
344
|
-
}
|
|
345
|
-
case IssuesManager.CorsIssue.IssueCode.ORIGIN_MISMATCH:
|
|
346
|
-
element.appendChild(this.createRequestCell(details.request, opts));
|
|
347
|
-
this.#appendStatus(element, details.isWarning);
|
|
348
|
-
if (corsError.includes('Preflight')) {
|
|
349
|
-
element.appendChild(
|
|
350
|
-
this.createRequestCell(details.request, {...opts, linkToPreflight: true, highlightHeader}));
|
|
351
|
-
} else {
|
|
352
|
-
this.appendIssueDetailCell(element, '');
|
|
353
|
-
}
|
|
354
|
-
this.appendIssueDetailCell(element, details.initiatorOrigin ?? '', 'code-example');
|
|
355
|
-
this.appendIssueDetailCell(element, details.corsErrorStatus.failedParameter, 'code-example');
|
|
356
|
-
break;
|
|
357
|
-
case IssuesManager.CorsIssue.IssueCode.ALLOW_CREDENTIALS_REQUIRED:
|
|
358
|
-
element.appendChild(this.createRequestCell(details.request, opts));
|
|
359
|
-
this.#appendStatus(element, details.isWarning);
|
|
360
|
-
if (corsError.includes('Preflight')) {
|
|
361
|
-
element.appendChild(
|
|
362
|
-
this.createRequestCell(details.request, {...opts, linkToPreflight: true, highlightHeader}));
|
|
363
|
-
} else {
|
|
364
|
-
this.appendIssueDetailCell(element, '');
|
|
365
|
-
}
|
|
366
|
-
this.appendIssueDetailCell(element, details.corsErrorStatus.failedParameter, 'code-example');
|
|
367
|
-
break;
|
|
368
|
-
case IssuesManager.CorsIssue.IssueCode.INSECURE_LOCAL_NETWORK:
|
|
369
|
-
element.appendChild(this.createRequestCell(details.request, opts));
|
|
370
|
-
this.#appendStatus(element, details.isWarning);
|
|
371
|
-
this.appendIssueDetailCell(element, details.resourceIPAddressSpace ?? '');
|
|
372
|
-
this.appendIssueDetailCell(element, details.clientSecurityState?.initiatorIPAddressSpace ?? '');
|
|
373
|
-
this.#appendSecureContextCell(element, details.clientSecurityState?.initiatorIsSecureContext);
|
|
374
|
-
break;
|
|
375
|
-
case IssuesManager.CorsIssue.IssueCode.METHOD_DISALLOWED_BY_PREFLIGHT_RESPONSE:
|
|
376
|
-
element.appendChild(this.createRequestCell(details.request, opts));
|
|
377
|
-
this.#appendStatus(element, details.isWarning);
|
|
378
|
-
element.appendChild(this.createRequestCell(details.request, {...opts, linkToPreflight: true, highlightHeader}));
|
|
379
|
-
this.appendIssueDetailCell(element, details.corsErrorStatus.failedParameter, 'code-example');
|
|
380
|
-
break;
|
|
381
|
-
case IssuesManager.CorsIssue.IssueCode.HEADER_DISALLOWED_BY_PREFLIGHT_RESPONSE:
|
|
382
|
-
element.appendChild(this.createRequestCell(details.request, {
|
|
383
|
-
...opts,
|
|
384
|
-
highlightHeader: {
|
|
385
|
-
section: NetworkForward.UIRequestLocation.UIHeaderSection.REQUEST,
|
|
386
|
-
name: corsErrorStatus.failedParameter,
|
|
387
|
-
},
|
|
388
|
-
}));
|
|
389
|
-
this.#appendStatus(element, details.isWarning);
|
|
390
|
-
element.appendChild(this.createRequestCell(details.request, {
|
|
391
|
-
...opts,
|
|
392
|
-
linkToPreflight: true,
|
|
393
|
-
highlightHeader: {
|
|
394
|
-
section: NetworkForward.UIRequestLocation.UIHeaderSection.RESPONSE,
|
|
395
|
-
name: 'Access-Control-Allow-Headers',
|
|
396
|
-
},
|
|
397
|
-
}));
|
|
398
|
-
this.appendIssueDetailCell(element, details.corsErrorStatus.failedParameter, 'code-example');
|
|
399
|
-
break;
|
|
400
|
-
case IssuesManager.CorsIssue.IssueCode.REDIRECT_CONTAINS_CREDENTIALS:
|
|
401
|
-
element.appendChild(this.createRequestCell(details.request, {
|
|
402
|
-
...opts,
|
|
403
|
-
highlightHeader: {
|
|
404
|
-
section: NetworkForward.UIRequestLocation.UIHeaderSection.RESPONSE,
|
|
405
|
-
name: CorsIssueDetailsView.getHeaderFromError(corsError),
|
|
406
|
-
},
|
|
407
|
-
}));
|
|
408
|
-
this.#appendStatus(element, details.isWarning);
|
|
409
|
-
break;
|
|
410
|
-
case IssuesManager.CorsIssue.IssueCode.DISALLOWED_BY_MODE:
|
|
411
|
-
element.appendChild(this.createRequestCell(details.request, opts));
|
|
412
|
-
this.#appendStatus(element, details.isWarning);
|
|
413
|
-
this.appendIssueDetailCell(element, details.initiatorOrigin ?? '', 'code-example');
|
|
414
|
-
this.appendSourceLocation(element, details.location, issue.model()?.getTargetIfNotDisposed());
|
|
415
|
-
break;
|
|
416
|
-
case IssuesManager.CorsIssue.IssueCode.CORS_DISABLED_SCHEME:
|
|
417
|
-
element.appendChild(this.createRequestCell(details.request, {
|
|
418
|
-
...opts,
|
|
419
|
-
highlightHeader: {
|
|
420
|
-
section: NetworkForward.UIRequestLocation.UIHeaderSection.RESPONSE,
|
|
421
|
-
name: CorsIssueDetailsView.getHeaderFromError(corsError),
|
|
422
|
-
},
|
|
423
|
-
}));
|
|
424
|
-
this.#appendStatus(element, details.isWarning);
|
|
425
|
-
this.appendIssueDetailCell(element, details.initiatorOrigin ?? '', 'code-example');
|
|
426
|
-
this.appendSourceLocation(element, details.location, issue.model()?.getTargetIfNotDisposed());
|
|
427
|
-
this.appendIssueDetailCell(element, details.corsErrorStatus.failedParameter ?? '', 'code-example');
|
|
428
|
-
break;
|
|
429
|
-
case IssuesManager.CorsIssue.IssueCode.NO_CORS_REDIRECT_MODE_NOT_FOLLOW:
|
|
430
|
-
element.appendChild(this.createRequestCell(details.request, opts));
|
|
431
|
-
this.#appendStatus(element, details.isWarning);
|
|
432
|
-
this.appendSourceLocation(element, details.location, issue.model()?.getTargetIfNotDisposed());
|
|
433
|
-
break;
|
|
434
|
-
case IssuesManager.CorsIssue.IssueCode.PREFLIGHT_MISSING_ALLOW_EXTERNAL:
|
|
435
|
-
case IssuesManager.CorsIssue.IssueCode.PREFLIGHT_INVALID_ALLOW_EXTERNAL:
|
|
436
|
-
case IssuesManager.CorsIssue.IssueCode.INVALID_LOCAL_NETWORK_ACCESS:
|
|
437
|
-
case IssuesManager.CorsIssue.IssueCode.LOCAL_NETWORK_ACCESS_PERMISSION_DENIED:
|
|
438
|
-
element.appendChild(this.createRequestCell(details.request, opts));
|
|
439
|
-
this.#appendStatus(element, details.isWarning);
|
|
440
|
-
break;
|
|
441
|
-
default:
|
|
442
|
-
Platform.assertNever(issueCode, 'Unknown issue code: ' + issueCode);
|
|
575
|
+
let request: RequestCellData;
|
|
576
|
+
if (issueCode === IssuesManager.CorsIssue.IssueCode.HEADER_DISALLOWED_BY_PREFLIGHT_RESPONSE) {
|
|
577
|
+
request = {
|
|
578
|
+
affectedRequest: details.request,
|
|
579
|
+
...opts,
|
|
580
|
+
highlightHeader: {
|
|
581
|
+
section: NetworkForward.UIRequestLocation.UIHeaderSection.REQUEST,
|
|
582
|
+
name: corsErrorStatus.failedParameter,
|
|
583
|
+
},
|
|
584
|
+
};
|
|
585
|
+
} else if (issueCode === IssuesManager.CorsIssue.IssueCode.REDIRECT_CONTAINS_CREDENTIALS ||
|
|
586
|
+
issueCode === IssuesManager.CorsIssue.IssueCode.CORS_DISABLED_SCHEME) {
|
|
587
|
+
request = {
|
|
588
|
+
affectedRequest: details.request,
|
|
589
|
+
...opts,
|
|
590
|
+
highlightHeader,
|
|
591
|
+
};
|
|
592
|
+
} else {
|
|
593
|
+
request = {
|
|
594
|
+
affectedRequest: details.request,
|
|
595
|
+
...opts,
|
|
596
|
+
};
|
|
443
597
|
}
|
|
444
598
|
|
|
445
|
-
|
|
599
|
+
let preflight: RequestCellData|undefined;
|
|
600
|
+
if (issueCode === IssuesManager.CorsIssue.IssueCode.PREFLIGHT_RESPONSE_INVALID) {
|
|
601
|
+
const specialHighlightHeader = corsError === Protocol.Network.CorsError.PreflightInvalidStatus ? {
|
|
602
|
+
section: NetworkForward.UIRequestLocation.UIHeaderSection.GENERAL,
|
|
603
|
+
name: 'Status-Code',
|
|
604
|
+
} :
|
|
605
|
+
highlightHeader;
|
|
606
|
+
preflight = {
|
|
607
|
+
affectedRequest: details.request,
|
|
608
|
+
...opts,
|
|
609
|
+
linkToPreflight: true,
|
|
610
|
+
highlightHeader: specialHighlightHeader,
|
|
611
|
+
};
|
|
612
|
+
} else if (issueCode === IssuesManager.CorsIssue.IssueCode.METHOD_DISALLOWED_BY_PREFLIGHT_RESPONSE) {
|
|
613
|
+
preflight = {affectedRequest: details.request, ...opts, linkToPreflight: true, highlightHeader};
|
|
614
|
+
} else if (issueCode === IssuesManager.CorsIssue.IssueCode.HEADER_DISALLOWED_BY_PREFLIGHT_RESPONSE) {
|
|
615
|
+
preflight = {
|
|
616
|
+
affectedRequest: details.request,
|
|
617
|
+
...opts,
|
|
618
|
+
linkToPreflight: true,
|
|
619
|
+
highlightHeader: {
|
|
620
|
+
section: NetworkForward.UIRequestLocation.UIHeaderSection.RESPONSE,
|
|
621
|
+
name: 'Access-Control-Allow-Headers',
|
|
622
|
+
},
|
|
623
|
+
};
|
|
624
|
+
} else if ((issueCode === IssuesManager.CorsIssue.IssueCode.INVALID_HEADER_VALUES ||
|
|
625
|
+
issueCode === IssuesManager.CorsIssue.IssueCode.WILDCARD_ORIGN_NOT_ALLOWED ||
|
|
626
|
+
issueCode === IssuesManager.CorsIssue.IssueCode.ORIGIN_MISMATCH ||
|
|
627
|
+
issueCode === IssuesManager.CorsIssue.IssueCode.ALLOW_CREDENTIALS_REQUIRED) &&
|
|
628
|
+
corsError.includes('Preflight')) {
|
|
629
|
+
preflight = {affectedRequest: details.request, ...opts, linkToPreflight: true, highlightHeader};
|
|
630
|
+
}
|
|
631
|
+
|
|
632
|
+
let problem = '';
|
|
633
|
+
if (issueCode === IssuesManager.CorsIssue.IssueCode.INVALID_HEADER_VALUES ||
|
|
634
|
+
issueCode === IssuesManager.CorsIssue.IssueCode.PREFLIGHT_RESPONSE_INVALID) {
|
|
635
|
+
problem = CorsIssueDetailsView.#getProblemFromError(details.corsErrorStatus);
|
|
636
|
+
}
|
|
637
|
+
|
|
638
|
+
let sourceLocation: SourceLocationData|undefined;
|
|
639
|
+
if ((issueCode === IssuesManager.CorsIssue.IssueCode.DISALLOWED_BY_MODE ||
|
|
640
|
+
issueCode === IssuesManager.CorsIssue.IssueCode.CORS_DISABLED_SCHEME ||
|
|
641
|
+
issueCode === IssuesManager.CorsIssue.IssueCode.NO_CORS_REDIRECT_MODE_NOT_FOLLOW) &&
|
|
642
|
+
details.location) {
|
|
643
|
+
sourceLocation = {
|
|
644
|
+
target: issue.model()?.getTargetIfNotDisposed() || null,
|
|
645
|
+
scriptId: details.location.scriptId || null,
|
|
646
|
+
url: details.location.url as Platform.DevToolsPath.UrlString,
|
|
647
|
+
lineNumber: details.location.lineNumber,
|
|
648
|
+
columnNumber: details.location.columnNumber,
|
|
649
|
+
};
|
|
650
|
+
}
|
|
651
|
+
|
|
652
|
+
return {
|
|
653
|
+
request,
|
|
654
|
+
isWarning: details.isWarning,
|
|
655
|
+
preflight,
|
|
656
|
+
header: CorsIssueDetailsView.#getHeaderFromError(corsError),
|
|
657
|
+
problem,
|
|
658
|
+
failedParameter: details.corsErrorStatus.failedParameter ?? '',
|
|
659
|
+
initiatorOrigin: details.initiatorOrigin ?? '',
|
|
660
|
+
resourceIPAddressSpace: details.resourceIPAddressSpace ?? '',
|
|
661
|
+
initiatorIPAddressSpace: details.clientSecurityState?.initiatorIPAddressSpace ?? '',
|
|
662
|
+
initiatorIsSecureContext: details.clientSecurityState?.initiatorIsSecureContext,
|
|
663
|
+
sourceLocation,
|
|
664
|
+
};
|
|
446
665
|
}
|
|
447
666
|
|
|
448
667
|
update(): void {
|
|
449
|
-
this.clear();
|
|
668
|
+
this.requestResolver.clear();
|
|
450
669
|
const issues = this.issue.getCorsIssues();
|
|
451
670
|
const issue = issues.values().next();
|
|
452
671
|
if (issue.done) {
|
|
672
|
+
const input: ViewInput = {rows: [], requestResolver: this.requestResolver};
|
|
673
|
+
this.#view(input, undefined, this.affectedResources);
|
|
453
674
|
this.updateAffectedResourceCount(0);
|
|
454
675
|
} else {
|
|
455
676
|
this.#appendDetails(issue.value.code(), issues);
|