chrome-devtools-frontend 1.0.1726686 → 1.0.1730971

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (490) hide show
  1. package/.agents/rules/tests/test-strict-assertions-and-literal-expectations.md +1 -1
  2. package/.agents/rules/tests/test-view-and-presenter-isolation.md +1 -1
  3. package/.agents/rules/ui-and-widgets/ui-accessibility-and-semantic-html.md +1 -1
  4. package/.agents/rules/ui-and-widgets/ui-css-scoping-and-flex-layout.md +2 -2
  5. package/.agents/rules/ui-and-widgets/ui-declarative-child-widget-composition.md +5 -5
  6. package/.agents/rules/ui-and-widgets/ui-lit-declarative-templates-and-directives.md +2 -2
  7. package/.agents/rules/ui-and-widgets/ui-localization-and-uistrings-hygiene.md +2 -2
  8. package/.agents/rules/ui-and-widgets/ui-modern-component-and-encapsulation-standards.md +3 -3
  9. package/.agents/rules/ui-and-widgets/ui-pure-view-and-presenter-separation.md +2 -2
  10. package/.agents/rules/ui-and-widgets/ui-reactive-widget-update-lifecycle.md +2 -2
  11. package/.agents/rules/ui-and-widgets/ui-view-output-and-callback-contracts.md +2 -2
  12. package/.agents/rules/ui-and-widgets/ui-widget-dom-and-listener-lifecycle.md +2 -2
  13. package/.agents/skills/code-review/SKILL.md +63 -12
  14. package/.agents/skills/ui-eng-vision-local-lit-renderer/SKILL.md +38 -10
  15. package/.agents/skills/ui-eng-vision-widget-promoter/SKILL.md +1 -0
  16. package/.agents/skills/ui-widgets/SKILL.md +8 -2
  17. package/.agents/skills/write-ai-eval-test/SKILL.md +106 -0
  18. package/AUTHORS +2 -0
  19. package/DIR_METADATA +1 -2
  20. package/README.md +48 -26
  21. package/config/typescript/tsconfig.base.json +1 -0
  22. package/config/typescript/tsconfig.eslint.json +1 -0
  23. package/docs/contributing/changes.md +25 -0
  24. package/docs/ui_engineering.md +13 -4
  25. package/eslint.config.mjs +323 -41
  26. package/front_end/core/common/Color.ts +7 -7
  27. package/front_end/core/common/ParsedURL.ts +3 -3
  28. package/front_end/core/common/ResolverBase.ts +3 -3
  29. package/front_end/core/common/SegmentedRange.ts +3 -3
  30. package/front_end/core/common/SimpleHistoryManager.ts +14 -14
  31. package/front_end/core/common/Trie.ts +3 -3
  32. package/front_end/core/common/VersionController.ts +7 -7
  33. package/front_end/core/host/InspectorFrontendHost.ts +2 -2
  34. package/front_end/core/host/InspectorFrontendHostAPI.ts +9 -1
  35. package/front_end/core/host/InspectorFrontendHostStub.ts +1 -1
  36. package/front_end/core/host/UserMetrics.ts +4 -0
  37. package/front_end/core/host/UserMetricsEnums.ts +2 -1
  38. package/front_end/core/platform/StringUtilities.ts +54 -13
  39. package/front_end/core/platform/node/HostRuntime.ts +13 -7
  40. package/front_end/core/protocol_client/DevToolsCDPConnection.ts +4 -5
  41. package/front_end/core/root/Runtime.ts +5 -0
  42. package/front_end/core/sdk/AccessibilityModel.ts +5 -5
  43. package/front_end/core/sdk/AnimationModel.ts +17 -19
  44. package/front_end/core/sdk/CPUProfilerModel.ts +3 -3
  45. package/front_end/core/sdk/CPUThrottlingManager.ts +7 -0
  46. package/front_end/core/sdk/CSSMatchedStyles.ts +73 -13
  47. package/front_end/core/sdk/CSSMetadata.ts +7 -7
  48. package/front_end/core/sdk/CSSModel.ts +33 -33
  49. package/front_end/core/sdk/CSSProperty.ts +5 -5
  50. package/front_end/core/sdk/CSSRule.ts +6 -6
  51. package/front_end/core/sdk/CSSStyleSheetHeader.ts +4 -4
  52. package/front_end/core/sdk/Connections.ts +16 -16
  53. package/front_end/core/sdk/ConsoleModel.ts +44 -47
  54. package/front_end/core/sdk/CookieParser.ts +11 -11
  55. package/front_end/core/sdk/EmulationModel.ts +35 -36
  56. package/front_end/core/sdk/EventBreakpointsModel.ts +11 -11
  57. package/front_end/core/sdk/FrameManager.ts +16 -16
  58. package/front_end/core/sdk/IsolateManager.ts +2 -2
  59. package/front_end/core/sdk/IssuesModel.ts +2 -2
  60. package/front_end/core/sdk/OverlayModel.ts +19 -19
  61. package/front_end/core/sdk/PageResourceLoader.ts +14 -16
  62. package/front_end/core/sdk/RemoteObject.ts +9 -9
  63. package/front_end/core/sdk/Resource.ts +2 -2
  64. package/front_end/core/sdk/RuntimeModel.ts +7 -7
  65. package/front_end/core/sdk/Script.ts +6 -6
  66. package/front_end/core/sdk/ServiceWorkerManager.ts +36 -10
  67. package/front_end/core/sdk/SourceMap.ts +18 -20
  68. package/front_end/core/sdk/SourceMapManager.ts +2 -2
  69. package/front_end/core/sdk/TargetManager.ts +2 -2
  70. package/front_end/devtools_compatibility.js +7 -3
  71. package/front_end/entrypoints/inspector_main/InspectorMain.ts +2 -2
  72. package/front_end/entrypoints/node_app/app/NodeConnectionsPanel.ts +203 -115
  73. package/front_end/generated/InspectorBackendCommands.ts +1 -1
  74. package/front_end/generated/SupportedCSSProperties.ts +1 -3
  75. package/front_end/generated/protocol.ts +1 -0
  76. package/front_end/models/ai_assistance/AiAgent2.ts +36 -12
  77. package/front_end/models/ai_assistance/AiConversation.ts +8 -2
  78. package/front_end/models/ai_assistance/agents/AiAgent.ts +137 -62
  79. package/front_end/models/ai_assistance/agents/ExecuteJavascript.ts +2 -2
  80. package/front_end/models/ai_assistance/agents/StylingAgent.snapshot.txt +2 -2
  81. package/front_end/models/ai_assistance/data_formatters/LighthouseFormatter.snapshot.txt +149 -2
  82. package/front_end/models/ai_assistance/data_formatters/LighthouseFormatter.ts +269 -42
  83. package/front_end/models/ai_assistance/tools/ExecuteJavaScript.ts +3 -0
  84. package/front_end/models/ai_assistance/tools/GetLighthouseAudits.ts +9 -0
  85. package/front_end/models/ai_assistance/tools/ResolveDevtoolsNodePath.ts +13 -2
  86. package/front_end/models/ai_assistance/tools/RunLighthouse.ts +23 -7
  87. package/front_end/models/ai_assistance/tools/Tool.ts +7 -5
  88. package/front_end/models/bindings/CSSWorkspaceBinding.ts +22 -24
  89. package/front_end/models/bindings/DebuggerLanguagePlugins.ts +60 -60
  90. package/front_end/models/bindings/DebuggerWorkspaceBinding.ts +24 -24
  91. package/front_end/models/bindings/DefaultScriptMapping.ts +8 -8
  92. package/front_end/models/bindings/FileUtils.ts +13 -13
  93. package/front_end/models/bindings/PresentationConsoleMessageHelper.ts +3 -3
  94. package/front_end/models/bindings/ResourceScriptMapping.ts +23 -23
  95. package/front_end/models/comment_manager/CommentManager.ts +3 -3
  96. package/front_end/models/comment_manager/CommentThread.ts +50 -5
  97. package/front_end/models/cpu_profile/CPUProfileDataModel.ts +14 -14
  98. package/front_end/models/cpu_profile/ProfileTreeModel.ts +4 -4
  99. package/front_end/models/elements/StyleChanges.ts +38 -0
  100. package/front_end/models/emulation/EmulatedDevices.ts +12 -12
  101. package/front_end/models/har/HARFormat.ts +4 -4
  102. package/front_end/models/javascript_metadata/NativeFunctions.ts +5 -1
  103. package/front_end/models/lighthouse/LighthouseReporterTypes.ts +57 -3
  104. package/front_end/models/lighthouse/RunTypes.ts +9 -1
  105. package/front_end/models/logs/LogManager.ts +2 -2
  106. package/front_end/models/persistence/AutomaticFileSystemManager.ts +3 -0
  107. package/front_end/models/persistence/FileSystemWorkspaceBinding.ts +24 -24
  108. package/front_end/models/persistence/IsolatedFileSystemManager.ts +6 -0
  109. package/front_end/models/persistence/NetworkPersistenceManager.ts +8 -3
  110. package/front_end/models/trace/LanternComputationData.ts +37 -11
  111. package/front_end/models/trace/Processor.ts +2 -1
  112. package/front_end/models/trace/extras/TraceTree.ts +36 -10
  113. package/front_end/models/trace/handlers/InitiatorsHandler.ts +27 -34
  114. package/front_end/models/trace/handlers/LayoutShiftsHandler.ts +2 -6
  115. package/front_end/models/trace/handlers/SamplesHandler.ts +9 -6
  116. package/front_end/models/workspace/FileManager.ts +6 -0
  117. package/front_end/panels/accessibility/ARIAAttributesView.ts +4 -4
  118. package/front_end/panels/accessibility/AccessibilityAnnouncementRecordingView.ts +8 -1
  119. package/front_end/panels/accessibility/AccessibilityNodeView.ts +15 -17
  120. package/front_end/panels/accessibility/AccessibilitySubPane.ts +1 -1
  121. package/front_end/panels/ai_assistance/AiAssistancePanel.ts +5 -5
  122. package/front_end/panels/ai_assistance/ExternalHandler.ts +10 -1
  123. package/front_end/panels/ai_assistance/components/ChatMessage.ts +27 -22
  124. package/front_end/panels/ai_assistance/components/DisabledWidget.ts +19 -23
  125. package/front_end/panels/ai_assistance/components/ExploreWidget.ts +2 -2
  126. package/front_end/panels/ai_assistance/components/PermissionPrompt.ts +23 -9
  127. package/front_end/panels/ai_assistance/components/chatInput.css +1 -1
  128. package/front_end/panels/animation/AnimationTimeline.ts +37 -17
  129. package/front_end/panels/animation/animationTimeline.css +19 -3
  130. package/front_end/panels/application/AppManifestView.ts +1 -2
  131. package/front_end/panels/application/ApplicationPanelSidebar.ts +143 -128
  132. package/front_end/panels/application/DOMStorageItemsView.ts +14 -14
  133. package/front_end/panels/application/DeviceBoundSessionsView.ts +10 -13
  134. package/front_end/panels/application/ExtensionStorageItemsView.ts +3 -4
  135. package/front_end/panels/application/IndexedDBViews.ts +8 -4
  136. package/front_end/panels/application/KeyValueStorageItemsView.ts +4 -5
  137. package/front_end/panels/application/PrivateVerificationTokensView.ts +53 -0
  138. package/front_end/panels/application/ServiceWorkerCacheViews.ts +12 -8
  139. package/front_end/panels/application/ServiceWorkersView.ts +1 -2
  140. package/front_end/panels/application/StorageItemsToolbar.ts +3 -3
  141. package/front_end/panels/application/StorageView.ts +2 -2
  142. package/front_end/panels/application/WebMCPView.ts +91 -109
  143. package/front_end/panels/application/application.ts +2 -0
  144. package/front_end/panels/application/components/StorageMetadataView.ts +6 -6
  145. package/front_end/panels/application/preloading/PreloadingView.ts +70 -37
  146. package/front_end/panels/application/preloading/components/MismatchedPreloadingGrid.ts +2 -2
  147. package/front_end/panels/application/preloading/components/PreloadingDisabledInfobar.ts +3 -3
  148. package/front_end/panels/application/preloading/components/PreloadingGrid.ts +12 -0
  149. package/front_end/panels/application/preloading/components/RuleSetDetailsView.ts +10 -11
  150. package/front_end/panels/application/privateVerificationTokensView.css +20 -0
  151. package/front_end/panels/application/serviceWorkersView.css +2 -2
  152. package/front_end/panels/browser_debugger/DOMBreakpointsSidebarPane.ts +24 -24
  153. package/front_end/panels/changes/ChangesSidebar.ts +5 -5
  154. package/front_end/panels/changes/ChangesView.ts +10 -11
  155. package/front_end/panels/comments/CommentsPane.ts +292 -102
  156. package/front_end/panels/comments/commentsPane.css +93 -12
  157. package/front_end/panels/common/CommentThreadWidget.ts +69 -0
  158. package/front_end/panels/common/CommentsOverlayWidget.ts +108 -29
  159. package/front_end/panels/common/CommentsStatusBarPill.ts +17 -6
  160. package/front_end/panels/common/DOMLinkifier.ts +37 -12
  161. package/front_end/panels/common/ExtensionPanel.ts +13 -4
  162. package/front_end/panels/common/ExtensionServer.ts +27 -3
  163. package/front_end/panels/common/PersistenceUtils.ts +3 -3
  164. package/front_end/panels/common/commentThreadWidget.css +25 -1
  165. package/front_end/panels/common/common-meta.ts +10 -0
  166. package/front_end/panels/console/ConsolePinPane.ts +13 -15
  167. package/front_end/panels/console/ConsolePrompt.ts +173 -95
  168. package/front_end/panels/console/ConsoleSidebar.ts +2 -2
  169. package/front_end/panels/console/ConsoleView.ts +75 -79
  170. package/front_end/panels/console/ConsoleViewMessage.ts +52 -4
  171. package/front_end/panels/console/SymbolizedErrorWidget.ts +8 -4
  172. package/front_end/panels/console/consolePrompt.css +1 -1
  173. package/front_end/panels/console/consoleView.css +1 -1
  174. package/front_end/panels/console_counters/WarningErrorCounter.ts +3 -4
  175. package/front_end/panels/coverage/CoverageListView.ts +2 -2
  176. package/front_end/panels/coverage/CoverageView.ts +20 -5
  177. package/front_end/panels/css_overview/CSSOverviewCompletedView.ts +4 -3
  178. package/front_end/panels/css_overview/CSSOverviewPanel.ts +2 -2
  179. package/front_end/panels/css_overview/CSSOverviewProcessingView.ts +2 -2
  180. package/front_end/panels/css_overview/CSSOverviewSidebarPanel.ts +2 -2
  181. package/front_end/panels/css_overview/CSSOverviewStartView.ts +2 -2
  182. package/front_end/panels/css_overview/CSSOverviewUnusedDeclarations.ts +8 -8
  183. package/front_end/panels/developer_resources/DeveloperResourcesListView.ts +2 -3
  184. package/front_end/panels/developer_resources/DeveloperResourcesView.ts +4 -5
  185. package/front_end/panels/elements/AccessibilityTreeUtils.ts +6 -7
  186. package/front_end/panels/elements/CSSValueTraceView.ts +3 -3
  187. package/front_end/panels/elements/ClassesPaneWidget.ts +1 -2
  188. package/front_end/panels/elements/ComputedStyleWidget.ts +15 -14
  189. package/front_end/panels/elements/DOMTreeElementWidget.ts +5 -4
  190. package/front_end/panels/elements/DOMTreeWidget.ts +2 -1
  191. package/front_end/panels/elements/ElementStatePaneWidget.ts +2 -2
  192. package/front_end/panels/elements/ElementsPanel.ts +1 -0
  193. package/front_end/panels/elements/EventListenersWidget.ts +2 -2
  194. package/front_end/panels/elements/LayoutPane.ts +2 -2
  195. package/front_end/panels/elements/PlatformFontsWidget.ts +3 -3
  196. package/front_end/panels/elements/PropertiesWidget.ts +9 -10
  197. package/front_end/panels/elements/PropertyRenderer.ts +72 -11
  198. package/front_end/panels/elements/StandaloneStylesContainer.ts +5 -10
  199. package/front_end/panels/elements/StyleEditorWidget.ts +30 -16
  200. package/front_end/panels/elements/StylePropertiesSection.ts +93 -44
  201. package/front_end/panels/elements/StylePropertyTreeElement.ts +230 -302
  202. package/front_end/panels/elements/StylesContainer.ts +2 -3
  203. package/front_end/panels/elements/StylesSidebarPane.ts +4 -13
  204. package/front_end/panels/elements/components/AccessibilityTreeNode.ts +66 -37
  205. package/front_end/panels/elements/components/CSSHintDetailsView.ts +51 -41
  206. package/front_end/panels/elements/components/CSSPropertyDocsView.ts +75 -65
  207. package/front_end/panels/elements/components/CSSQuery.ts +112 -74
  208. package/front_end/panels/elements/components/CSSVariableValueView.ts +109 -68
  209. package/front_end/panels/elements/components/ComputedStyleProperty.ts +64 -45
  210. package/front_end/panels/elements/components/ElementsTreeExpandButton.ts +35 -28
  211. package/front_end/panels/elements/components/QueryContainer.ts +104 -74
  212. package/front_end/panels/elements/components/accessibilityTreeNode.css +22 -20
  213. package/front_end/panels/elements/components/computedStyleProperty.css +2 -0
  214. package/front_end/panels/elements/components/cssHintDetailsView.css +23 -21
  215. package/front_end/panels/elements/components/cssPropertyDocsView.css +38 -36
  216. package/front_end/panels/elements/components/cssVariableValueView.css +42 -40
  217. package/front_end/panels/elements/components/elementsTreeExpandButton.css +5 -2
  218. package/front_end/panels/elements/components/queryContainer.css +23 -21
  219. package/front_end/panels/elements/stylesSidebarPane.css +3 -3
  220. package/front_end/panels/emulation/DeviceModeToolbar.ts +2 -2
  221. package/front_end/panels/emulation/InspectedPagePlaceholder.ts +2 -2
  222. package/front_end/panels/emulation/MediaQueryInspector.ts +9 -10
  223. package/front_end/panels/emulation/mediaQueryInspector.css +1 -1
  224. package/front_end/panels/event_listeners/EventListenersView.ts +2 -2
  225. package/front_end/panels/issues/AffectedCookiesView.ts +144 -101
  226. package/front_end/panels/issues/AffectedDescendantsWithinSelectElementView.ts +83 -31
  227. package/front_end/panels/issues/AffectedDirectivesView.ts +218 -135
  228. package/front_end/panels/issues/AffectedDocumentsInQuirksModeView.ts +84 -34
  229. package/front_end/panels/issues/AffectedElementsView.ts +86 -23
  230. package/front_end/panels/issues/AffectedLazyLoadImagesView.ts +2 -2
  231. package/front_end/panels/issues/AffectedMetadataAllowedSitesView.ts +2 -2
  232. package/front_end/panels/issues/AffectedPartitioningBlobURLView.ts +36 -11
  233. package/front_end/panels/issues/AffectedSharedArrayBufferIssueDetailsView.ts +135 -58
  234. package/front_end/panels/issues/AffectedSourcesView.ts +49 -28
  235. package/front_end/panels/issues/AffectedTrackingSitesView.ts +3 -4
  236. package/front_end/panels/issues/CorsIssueDetailsView.ts +490 -269
  237. package/front_end/panels/issues/GenericIssueDetailsView.ts +2 -2
  238. package/front_end/panels/issues/IssueKindView.ts +63 -48
  239. package/front_end/panels/issues/IssueView.ts +14 -18
  240. package/front_end/panels/issues/components/ElementsPanelLink.ts +70 -34
  241. package/front_end/panels/issues/components/HideIssuesMenu.ts +56 -32
  242. package/front_end/panels/issues/components/elementsPanelLink.css +10 -6
  243. package/front_end/panels/issues/components/hideIssuesMenu.css +16 -14
  244. package/front_end/panels/issues/issues.ts +2 -0
  245. package/front_end/panels/issues/issuesTree.css +4 -4
  246. package/front_end/panels/lighthouse/LighthouseController.ts +6 -6
  247. package/front_end/panels/lighthouse/LighthouseStatusView.ts +12 -13
  248. package/front_end/panels/lighthouse/lighthouseStartView.css +1 -1
  249. package/front_end/panels/linear_memory_inspector/LinearMemoryInspectorPane.ts +159 -161
  250. package/front_end/panels/linear_memory_inspector/LinearMemoryInspectorView.ts +228 -0
  251. package/front_end/panels/linear_memory_inspector/components/LinearMemoryInspector.ts +32 -41
  252. package/front_end/panels/linear_memory_inspector/components/linearMemoryHighlightChipList.css +2 -2
  253. package/front_end/panels/linear_memory_inspector/linear_memory_inspector.ts +2 -0
  254. package/front_end/panels/media/EventDisplayTable.ts +2 -2
  255. package/front_end/panels/media/MainView.ts +132 -66
  256. package/front_end/panels/media/PlayerDetailView.ts +32 -14
  257. package/front_end/panels/media/PlayerListView.ts +83 -23
  258. package/front_end/panels/media/PlayerPropertiesView.ts +2 -2
  259. package/front_end/panels/media/TickingFlameChart.ts +153 -63
  260. package/front_end/panels/mobile_throttling/NetworkThrottlingSelector.ts +2 -2
  261. package/front_end/panels/mobile_throttling/ThrottlingSettingsTab.ts +615 -464
  262. package/front_end/panels/mobile_throttling/throttlingSettingsTab.css +43 -0
  263. package/front_end/panels/network/EventSourceMessagesView.ts +3 -3
  264. package/front_end/panels/network/NetworkConfigView.ts +6 -2
  265. package/front_end/panels/network/NetworkDataGridNode.ts +2 -1
  266. package/front_end/panels/network/NetworkItemView.ts +27 -26
  267. package/front_end/panels/network/NetworkManageCustomHeadersView.ts +236 -97
  268. package/front_end/panels/network/NetworkOverview.ts +8 -10
  269. package/front_end/panels/network/RequestConditionsDrawer.ts +8 -4
  270. package/front_end/panels/network/RequestDeviceBoundSessionsView.ts +2 -4
  271. package/front_end/panels/network/RequestHTMLView.ts +26 -7
  272. package/front_end/panels/network/RequestHeadersView.ts +2 -2
  273. package/front_end/panels/network/RequestInitiatorView.ts +21 -22
  274. package/front_end/panels/network/RequestPayloadView.ts +2 -16
  275. package/front_end/panels/network/RequestPreviewView.ts +5 -5
  276. package/front_end/panels/network/RequestTimingView.ts +6 -6
  277. package/front_end/panels/network/ResourceDirectSocketChunkView.ts +5 -6
  278. package/front_end/panels/network/ResourceWebSocketFrameView.ts +4 -3
  279. package/front_end/panels/network/ShowMoreDetailsWidget.ts +11 -12
  280. package/front_end/panels/network/SignedExchangeInfoView.ts +2 -2
  281. package/front_end/panels/network/networkLogView.css +2 -2
  282. package/front_end/panels/network/networkManageCustomHeadersView.css +27 -6
  283. package/front_end/panels/network/requestConditionsDrawer.css +1 -1
  284. package/front_end/panels/network/requestInitiatorView.css +5 -3
  285. package/front_end/panels/performance_monitor/PerformanceMonitor.ts +2 -2
  286. package/front_end/panels/profiler/HeapDetachedElementsView.ts +1 -2
  287. package/front_end/panels/profiler/HeapTimelineOverview.ts +77 -15
  288. package/front_end/panels/profiler/IsolateSelector.ts +258 -187
  289. package/front_end/panels/profiler/ProfileLauncherView.ts +7 -29
  290. package/front_end/panels/profiler/profileLauncherView.css +6 -1
  291. package/front_end/panels/protocol_monitor/JSONEditor.ts +4 -5
  292. package/front_end/panels/recorder/ControlButton.ts +1 -1
  293. package/front_end/panels/recorder/RecordingListView.ts +2 -4
  294. package/front_end/panels/recorder/RecordingView.ts +1 -2
  295. package/front_end/panels/recorder/SelectorPicker.ts +2 -4
  296. package/front_end/panels/recorder/StepView.ts +24 -10
  297. package/front_end/panels/recorder/TimelineSection.ts +1 -1
  298. package/front_end/panels/recorder/recordingView.css +1 -1
  299. package/front_end/panels/screencast/ScreencastApp.ts +1 -1
  300. package/front_end/panels/search/SearchResultsPane.ts +11 -12
  301. package/front_end/panels/search/SearchView.ts +8 -10
  302. package/front_end/panels/security/SecurityPanel.ts +1 -8
  303. package/front_end/panels/security/SecurityPanelSidebar.ts +2 -2
  304. package/front_end/panels/security/mainView.css +1 -1
  305. package/front_end/panels/sensors/LocationsSettingsTab.ts +1 -2
  306. package/front_end/panels/settings/AISettingsTab.ts +1 -1
  307. package/front_end/panels/settings/BackendLinkingSettingsTab.ts +34 -20
  308. package/front_end/panels/settings/EditFileSystemView.ts +2 -2
  309. package/front_end/panels/settings/FrameworkIgnoreListSettingsTab.ts +375 -197
  310. package/front_end/panels/settings/KeybindsSettingsTab.ts +570 -414
  311. package/front_end/panels/settings/SettingsScreen.ts +312 -114
  312. package/front_end/panels/settings/WorkspaceSettingsTab.ts +2 -2
  313. package/front_end/panels/settings/aiSettingsTab.css +1 -4
  314. package/front_end/panels/settings/emulation/DevicesSettingsTab.ts +924 -578
  315. package/front_end/panels/settings/emulation/components/UserAgentClientHintsForm.ts +9 -2
  316. package/front_end/panels/settings/emulation/devicesSettingsTab.css +39 -0
  317. package/front_end/panels/settings/frameworkIgnoreListSettingsTab.css +37 -8
  318. package/front_end/panels/settings/settingsScreen.css +0 -24
  319. package/front_end/panels/sources/BreakpointEditDialog.ts +9 -6
  320. package/front_end/panels/sources/BreakpointsView.ts +25 -4
  321. package/front_end/panels/sources/CallStackSidebarPane.ts +7 -1
  322. package/front_end/panels/sources/DebuggerPlugin.ts +1 -0
  323. package/front_end/panels/sources/GoToLineQuickOpen.ts +8 -8
  324. package/front_end/panels/sources/NavigatorView.ts +521 -439
  325. package/front_end/panels/sources/PersistenceActions.ts +11 -12
  326. package/front_end/panels/sources/ProfilePlugin.ts +28 -17
  327. package/front_end/panels/sources/ScopeChainSidebarPane.ts +3 -4
  328. package/front_end/panels/sources/SourcesNavigator.ts +9 -9
  329. package/front_end/panels/sources/SourcesPanel.ts +2 -2
  330. package/front_end/panels/sources/SourcesView.ts +3 -3
  331. package/front_end/panels/sources/ThreadsSidebarPane.ts +2 -2
  332. package/front_end/panels/sources/WatchExpressionsSidebarPane.ts +2 -2
  333. package/front_end/panels/sources/components/HeadersView.ts +1 -2
  334. package/front_end/panels/timeline/CompatibilityTracksAppender.ts +5 -6
  335. package/front_end/panels/timeline/EventsTimelineTreeView.ts +73 -34
  336. package/front_end/panels/timeline/IsolateSelector.ts +25 -37
  337. package/front_end/panels/timeline/StatusDialog.ts +5 -7
  338. package/front_end/panels/timeline/ThirdPartyTreeView.ts +10 -13
  339. package/front_end/panels/timeline/TimelineDetailsView.ts +40 -21
  340. package/front_end/panels/timeline/TimelineEventOverview.ts +130 -34
  341. package/front_end/panels/timeline/TimelineFlameChartNetworkDataProvider.ts +1 -1
  342. package/front_end/panels/timeline/TimelineMiniMap.ts +255 -103
  343. package/front_end/panels/timeline/TimelinePaintProfilerView.ts +19 -11
  344. package/front_end/panels/timeline/TimelinePanel.ts +1 -0
  345. package/front_end/panels/timeline/TimelineSelectorStatsView.ts +11 -12
  346. package/front_end/panels/timeline/TimelineTreeView.ts +240 -122
  347. package/front_end/panels/timeline/TimelineUIUtils.ts +12 -0
  348. package/front_end/panels/timeline/components/BreadcrumbsUI.ts +5 -4
  349. package/front_end/panels/timeline/components/DetailsView.ts +97 -65
  350. package/front_end/panels/timeline/components/LayoutShiftDetails.ts +2 -2
  351. package/front_end/panels/timeline/components/MetricCard.ts +2 -2
  352. package/front_end/panels/timeline/components/NetworkRequestDetails.ts +11 -12
  353. package/front_end/panels/timeline/components/NetworkTrackWidget.ts +57 -50
  354. package/front_end/panels/timeline/components/RelatedInsightChips.ts +2 -2
  355. package/front_end/panels/timeline/components/Sidebar.ts +161 -109
  356. package/front_end/panels/timeline/components/SidebarAnnotationsTab.ts +33 -12
  357. package/front_end/panels/timeline/components/SidebarInsightsTab.ts +3 -0
  358. package/front_end/panels/timeline/components/insights/LCPDiscovery.ts +11 -11
  359. package/front_end/panels/timeline/components/insights/SlowCSSSelector.ts +6 -7
  360. package/front_end/panels/timeline/components/networkTrackWidget.css +24 -22
  361. package/front_end/panels/timeline/components/sidebarInsightsTab.css +1 -1
  362. package/front_end/panels/timeline/overlays/components/TimespanBreakdownOverlay.ts +15 -10
  363. package/front_end/panels/timeline/overlays/components/entryLabelOverlay.css +1 -1
  364. package/front_end/panels/timeline/timelinePanel.css +5 -0
  365. package/front_end/panels/timeline/timelineStatusDialog.css +1 -1
  366. package/front_end/panels/web_audio/WebAudioView.ts +2 -2
  367. package/front_end/third_party/chromium/README.chromium +1 -1
  368. package/front_end/third_party/legacy-javascript/README.chromium +2 -2
  369. package/front_end/third_party/legacy-javascript/lib/legacy-javascript.js +2 -2
  370. package/front_end/third_party/legacy-javascript/package.json +1 -1
  371. package/front_end/third_party/lighthouse/README.chromium +2 -2
  372. package/front_end/third_party/lighthouse/lighthouse-dt-bundle.js +1983 -2022
  373. package/front_end/third_party/lighthouse/locales/ar-XB.json +157 -142
  374. package/front_end/third_party/lighthouse/locales/ar.json +157 -142
  375. package/front_end/third_party/lighthouse/locales/bg.json +154 -139
  376. package/front_end/third_party/lighthouse/locales/ca.json +157 -142
  377. package/front_end/third_party/lighthouse/locales/cs.json +148 -133
  378. package/front_end/third_party/lighthouse/locales/da.json +153 -138
  379. package/front_end/third_party/lighthouse/locales/de.json +152 -137
  380. package/front_end/third_party/lighthouse/locales/el.json +153 -138
  381. package/front_end/third_party/lighthouse/locales/en-GB.json +160 -145
  382. package/front_end/third_party/lighthouse/locales/en-US.json +239 -218
  383. package/front_end/third_party/lighthouse/locales/en-XL.json +239 -218
  384. package/front_end/third_party/lighthouse/locales/es-419.json +150 -135
  385. package/front_end/third_party/lighthouse/locales/es.json +149 -134
  386. package/front_end/third_party/lighthouse/locales/fi.json +151 -136
  387. package/front_end/third_party/lighthouse/locales/fil.json +154 -139
  388. package/front_end/third_party/lighthouse/locales/fr.json +150 -135
  389. package/front_end/third_party/lighthouse/locales/he.json +160 -145
  390. package/front_end/third_party/lighthouse/locales/hi.json +156 -141
  391. package/front_end/third_party/lighthouse/locales/hr.json +154 -139
  392. package/front_end/third_party/lighthouse/locales/hu.json +111 -96
  393. package/front_end/third_party/lighthouse/locales/id.json +153 -138
  394. package/front_end/third_party/lighthouse/locales/it.json +153 -138
  395. package/front_end/third_party/lighthouse/locales/ja.json +150 -135
  396. package/front_end/third_party/lighthouse/locales/ko.json +42 -27
  397. package/front_end/third_party/lighthouse/locales/lt.json +152 -137
  398. package/front_end/third_party/lighthouse/locales/lv.json +93 -78
  399. package/front_end/third_party/lighthouse/locales/nl.json +149 -134
  400. package/front_end/third_party/lighthouse/locales/no.json +152 -137
  401. package/front_end/third_party/lighthouse/locales/pl.json +153 -138
  402. package/front_end/third_party/lighthouse/locales/pt-PT.json +152 -137
  403. package/front_end/third_party/lighthouse/locales/pt.json +157 -142
  404. package/front_end/third_party/lighthouse/locales/ro.json +149 -134
  405. package/front_end/third_party/lighthouse/locales/ru.json +76 -61
  406. package/front_end/third_party/lighthouse/locales/sk.json +153 -138
  407. package/front_end/third_party/lighthouse/locales/sl.json +149 -134
  408. package/front_end/third_party/lighthouse/locales/sr-Latn.json +151 -136
  409. package/front_end/third_party/lighthouse/locales/sr.json +151 -136
  410. package/front_end/third_party/lighthouse/locales/sv.json +152 -137
  411. package/front_end/third_party/lighthouse/locales/ta.json +156 -141
  412. package/front_end/third_party/lighthouse/locales/te.json +157 -142
  413. package/front_end/third_party/lighthouse/locales/th.json +111 -96
  414. package/front_end/third_party/lighthouse/locales/tr.json +153 -138
  415. package/front_end/third_party/lighthouse/locales/uk.json +149 -134
  416. package/front_end/third_party/lighthouse/locales/vi.json +162 -147
  417. package/front_end/third_party/lighthouse/locales/zh-HK.json +150 -135
  418. package/front_end/third_party/lighthouse/locales/zh-TW.json +154 -139
  419. package/front_end/third_party/lighthouse/locales/zh.json +152 -137
  420. package/front_end/third_party/lighthouse/report/bundle.d.ts +9 -8
  421. package/front_end/third_party/lighthouse/report/bundle.js +10 -10
  422. package/front_end/third_party/lighthouse/report-assets/report-generator.mjs +2 -7
  423. package/front_end/tsconfig.compatibility.json +1 -0
  424. package/front_end/tsconfig.json +3 -2
  425. package/front_end/ui/components/dialogs/TypeToAllowDialog.ts +0 -2
  426. package/front_end/ui/components/dialogs/typeToAllowDialog.css +0 -4
  427. package/front_end/ui/components/icon_button/fileSourceIcon.css +1 -1
  428. package/front_end/ui/components/input/textInput.css +1 -1
  429. package/front_end/ui/components/lists/List.ts +26 -14
  430. package/front_end/ui/components/menus/menus.ts +0 -2
  431. package/front_end/ui/components/suggestion_input/SuggestionInput.ts +351 -138
  432. package/front_end/ui/components/survey_link/surveyLink.css +3 -3
  433. package/front_end/ui/components/switch/switch.css +6 -6
  434. package/front_end/ui/components/text_editor/AiCodeCompletionTeaser.ts +2 -3
  435. package/front_end/ui/components/text_editor/TextEditor.ts +1 -1
  436. package/front_end/ui/components/tooltips/Tooltip.ts +53 -4
  437. package/front_end/ui/components/tree_outline/treeOutline.css +7 -7
  438. package/front_end/ui/helpers/OpenInNewTab.ts +8 -3
  439. package/front_end/ui/legacy/EmptyWidget.ts +4 -4
  440. package/front_end/ui/legacy/ForwardedInputEventHandler.ts +2 -2
  441. package/front_end/ui/legacy/GlassPane.ts +1 -1
  442. package/front_end/ui/legacy/KeyboardShortcut.ts +7 -7
  443. package/front_end/ui/legacy/RemoteDebuggingTerminatedScreen.ts +2 -2
  444. package/front_end/ui/legacy/TabbedPane.ts +198 -66
  445. package/front_end/ui/legacy/TargetCrashedScreen.ts +2 -2
  446. package/front_end/ui/legacy/UIUtils.ts +71 -68
  447. package/front_end/ui/legacy/View.ts +7 -4
  448. package/front_end/ui/legacy/ViewManager.ts +49 -37
  449. package/front_end/ui/legacy/Widget.ts +32 -12
  450. package/front_end/ui/legacy/components/cookie_table/CookiesTable.ts +2 -3
  451. package/front_end/ui/legacy/components/inline_editor/AnimationTimingUI.ts +8 -8
  452. package/front_end/ui/legacy/components/inline_editor/BezierUI.ts +8 -9
  453. package/front_end/ui/legacy/components/inline_editor/LinkSwatch.ts +2 -2
  454. package/front_end/ui/legacy/components/inline_editor/cssAngleEditor.css +1 -1
  455. package/front_end/ui/legacy/components/inline_editor/cssAngleSwatch.css +1 -1
  456. package/front_end/ui/legacy/components/object_ui/ObjectPropertiesSection.ts +45 -11
  457. package/front_end/ui/legacy/components/object_ui/RemoteObjectPreviewFormatter.ts +10 -12
  458. package/front_end/ui/legacy/components/perf_ui/ChartViewport.ts +102 -29
  459. package/front_end/ui/legacy/components/perf_ui/FlameChart.ts +148 -122
  460. package/front_end/ui/legacy/components/perf_ui/TimelineOverviewPane.ts +20 -14
  461. package/front_end/ui/legacy/components/quick_open/filteredListWidget.css +1 -1
  462. package/front_end/ui/legacy/components/source_frame/FontView.ts +29 -5
  463. package/front_end/ui/legacy/components/source_frame/ImageView.ts +79 -12
  464. package/front_end/ui/legacy/components/source_frame/JSONView.ts +20 -2
  465. package/front_end/ui/legacy/components/source_frame/PreviewFactory.ts +2 -2
  466. package/front_end/ui/legacy/components/source_frame/StreamingContentHexView.ts +6 -10
  467. package/front_end/ui/legacy/components/source_frame/XMLView.ts +11 -11
  468. package/front_end/ui/legacy/components/source_frame/fontView.css +7 -0
  469. package/front_end/ui/legacy/components/source_frame/imageView.css +7 -0
  470. package/front_end/ui/legacy/components/utils/JSPresentationUtils.ts +14 -3
  471. package/front_end/ui/legacy/components/utils/Linkifier.ts +126 -2
  472. package/front_end/ui/legacy/emptyWidget.css +2 -1
  473. package/front_end/ui/legacy/inspectorCommon.css +3 -3
  474. package/front_end/ui/legacy/smallBubble.css +1 -1
  475. package/front_end/ui/legacy/tabbedPane.css +6 -0
  476. package/front_end/ui/lit/Directives.ts +35 -18
  477. package/front_end/ui/lit/lit.ts +0 -2
  478. package/front_end/ui/lit/render.ts +0 -7
  479. package/front_end/ui/visual_logging/KnownContextValues.ts +5 -0
  480. package/package.json +1 -1
  481. package/vpython.toml +8 -0
  482. package/vpython.toml.uv.lock +3 -0
  483. package/.agents/skills/review-models-core/SKILL.md +0 -73
  484. package/.agents/skills/review-tests/SKILL.md +0 -67
  485. package/.agents/skills/review-ui-widgets/SKILL.md +0 -115
  486. package/front_end/generated/ARIAProperties.ts +0 -2686
  487. package/front_end/ui/components/menus/README.md +0 -119
  488. package/front_end/ui/components/menus/SelectMenu.ts +0 -473
  489. package/front_end/ui/components/menus/selectMenu.css +0 -54
  490. package/front_end/ui/components/menus/selectMenuButton.css +0 -108
@@ -153,3 +153,46 @@
153
153
  font-weight: bold;
154
154
  border-bottom: var(--sys-size-1) solid var(--sys-color-divider);
155
155
  }
156
+
157
+ .editor-container {
158
+ display: flex;
159
+ flex-direction: column;
160
+ align-items: stretch;
161
+ flex: none;
162
+ background: var(--sys-color-surface3);
163
+ overflow: hidden;
164
+ }
165
+
166
+ .editor-content {
167
+ flex: auto;
168
+ display: flex;
169
+ flex-direction: column;
170
+ align-items: stretch;
171
+ }
172
+
173
+ .editor-content input {
174
+ margin-right: 10px;
175
+ }
176
+
177
+ .editor-content input.error-input {
178
+ background-color: var(--sys-color-cdt-base-container);
179
+ }
180
+
181
+ .editor-buttons {
182
+ flex: none;
183
+ display: flex;
184
+ flex-direction: row;
185
+ align-items: center;
186
+ justify-content: flex-start;
187
+ padding: 5px;
188
+ gap: var(--sys-size-6);
189
+ }
190
+
191
+ .list-widget-input-validation-error {
192
+ color: var(--sys-color-error);
193
+ margin: 0 5px;
194
+ }
195
+
196
+ .editor-container ~ .add-conditions-button {
197
+ display: none;
198
+ }
@@ -111,7 +111,7 @@ export const DEFAULT_VIEW: View = (input, _output, target) => {
111
111
  `}>
112
112
  </devtools-data-grid>
113
113
  </div>
114
- `, target);
114
+ `, target, {container: {attributes: {jslog: `${VisualLogging.pane('event-stream').track({resize: true})}`}}});
115
115
  // clang-format on
116
116
  };
117
117
 
@@ -122,7 +122,7 @@ export class EventSourceMessagesView extends UI.Widget.VBox {
122
122
  #view: View;
123
123
 
124
124
  constructor(request: SDK.NetworkRequest.NetworkRequest, view: View = DEFAULT_VIEW) {
125
- super({jslog: `${VisualLogging.pane('event-stream').track({resize: true})}`});
125
+ super();
126
126
  this.#view = view;
127
127
  this.request = request;
128
128
 
@@ -205,7 +205,7 @@ export class EventSourceMessagesView extends UI.Widget.VBox {
205
205
  onRowContextMenu: this.onRowContextMenu.bind(this),
206
206
  };
207
207
 
208
- this.#view(input, {}, this.contentElement);
208
+ this.#view(input, undefined, this.contentElement);
209
209
  }
210
210
  }
211
211
 
@@ -216,7 +216,12 @@ export const DEFAULT_VIEW: View = (input, output, target) => {
216
216
  ${renderNetworkThrottlingSection()}
217
217
  <div class="panel-section-separator"></div>
218
218
  ${renderUserAgentSection(input, output)}
219
- `, target, {container: {classes: ['network-config']}});
219
+ `, target, {
220
+ container: {
221
+ classes: ['network-config'],
222
+ attributes: {jslog: `${VisualLogging.panel('network-conditions').track({resize: true})}`},
223
+ },
224
+ });
220
225
  };
221
226
  // clang-format on
222
227
 
@@ -240,7 +245,6 @@ export class NetworkConfigView extends UI.Widget.VBox {
240
245
 
241
246
  constructor(view: View = DEFAULT_VIEW) {
242
247
  super({
243
- jslog: `${VisualLogging.panel('network-conditions').track({resize: true})}`,
244
248
  useShadowDom: true,
245
249
  });
246
250
  this.registerRequiredCSS(networkConfigViewStyles);
@@ -1372,7 +1372,8 @@ export class NetworkRequestNode extends NetworkNode {
1372
1372
  if (!Common.ParsedURL.hasWebSafeScheme(this.requestInternal.url())) {
1373
1373
  return;
1374
1374
  }
1375
- Host.InspectorFrontendHost.InspectorFrontendHostInstance.openInNewTab(this.requestInternal.url());
1375
+ Host.InspectorFrontendHost.InspectorFrontendHostInstance.openInNewTab(
1376
+ this.requestInternal.url(), Components.Linkifier.openInNewTabInitiatorId(this.requestInternal));
1376
1377
  }
1377
1378
 
1378
1379
  private isFailed(): boolean {
@@ -188,9 +188,9 @@ export class NetworkItemView extends UI.TabbedPane.TabbedPane {
188
188
  this.setSuffixElement(NetworkForward.UIRequestLocation.UIRequestTabs.HEADERS_COMPONENT, statusDot);
189
189
  }
190
190
 
191
- void this.maybeAppendPayloadPanel();
191
+ void this.#maybeAppendPayloadPanel();
192
192
 
193
- this.addEventListener(UI.TabbedPane.Events.TabSelected, this.tabSelected, this);
193
+ this.addEventListener(UI.TabbedPane.Events.TabSelected, this.#tabSelected, this);
194
194
 
195
195
  if (request.resourceType() === Common.ResourceType.resourceTypes.WebSocket) {
196
196
  const frameView = new ResourceWebSocketFrameView(request);
@@ -261,13 +261,14 @@ export class NetworkItemView extends UI.TabbedPane.TabbedPane {
261
261
 
262
262
  override wasShown(): void {
263
263
  super.wasShown();
264
- this.#request.addEventListener(SDK.NetworkRequest.Events.REQUEST_HEADERS_CHANGED, this.requestHeadersChanged, this);
265
- this.#request.addEventListener(
266
- SDK.NetworkRequest.Events.RESPONSE_HEADERS_CHANGED, this.maybeAppendCookieResponsePanels, this);
267
- this.#request.addEventListener(
268
- SDK.NetworkRequest.Events.TRUST_TOKEN_RESULT_ADDED, this.maybeShowErrorIconInTrustTokenTabHeader, this);
269
- this.maybeAppendCookieResponsePanels();
270
- this.maybeShowErrorIconInTrustTokenTabHeader();
264
+ this.#request.addEventListener(SDK.NetworkRequest.Events.REQUEST_HEADERS_CHANGED, this.#requestHeadersChanged,
265
+ this);
266
+ this.#request.addEventListener(SDK.NetworkRequest.Events.RESPONSE_HEADERS_CHANGED,
267
+ this.#maybeAppendCookieResponsePanels, this);
268
+ this.#request.addEventListener(SDK.NetworkRequest.Events.TRUST_TOKEN_RESULT_ADDED,
269
+ this.#maybeShowErrorIconInTrustTokenTabHeader, this);
270
+ this.#maybeAppendCookieResponsePanels();
271
+ this.#maybeShowErrorIconInTrustTokenTabHeader();
271
272
 
272
273
  // Only select the initial tab the first time the view is shown after construction.
273
274
  // When the view is re-shown (without re-constructing) users or revealers might have changed
@@ -282,25 +283,25 @@ export class NetworkItemView extends UI.TabbedPane.TabbedPane {
282
283
 
283
284
  override willHide(): void {
284
285
  super.willHide();
285
- this.#request.removeEventListener(
286
- SDK.NetworkRequest.Events.REQUEST_HEADERS_CHANGED, this.requestHeadersChanged, this);
287
- this.#request.removeEventListener(
288
- SDK.NetworkRequest.Events.RESPONSE_HEADERS_CHANGED, this.maybeAppendCookieResponsePanels, this);
289
- this.#request.removeEventListener(
290
- SDK.NetworkRequest.Events.TRUST_TOKEN_RESULT_ADDED, this.maybeShowErrorIconInTrustTokenTabHeader, this);
286
+ this.#request.removeEventListener(SDK.NetworkRequest.Events.REQUEST_HEADERS_CHANGED, this.#requestHeadersChanged,
287
+ this);
288
+ this.#request.removeEventListener(SDK.NetworkRequest.Events.RESPONSE_HEADERS_CHANGED,
289
+ this.#maybeAppendCookieResponsePanels, this);
290
+ this.#request.removeEventListener(SDK.NetworkRequest.Events.TRUST_TOKEN_RESULT_ADDED,
291
+ this.#maybeShowErrorIconInTrustTokenTabHeader, this);
291
292
  }
292
293
 
293
- private async requestHeadersChanged(): Promise<void> {
294
- this.maybeAppendCookiesPanel();
295
- void this.maybeAppendPayloadPanel();
294
+ async #requestHeadersChanged(): Promise<void> {
295
+ this.#maybeAppendCookiesPanel();
296
+ void this.#maybeAppendPayloadPanel();
296
297
  }
297
298
 
298
- private maybeAppendCookieResponsePanels(): void {
299
- this.maybeAppendCookiesPanel();
300
- this.maybeAppendDeviceBoundSessionsPanel();
299
+ #maybeAppendCookieResponsePanels(): void {
300
+ this.#maybeAppendCookiesPanel();
301
+ this.#maybeAppendDeviceBoundSessionsPanel();
301
302
  }
302
303
 
303
- private maybeAppendCookiesPanel(): void {
304
+ #maybeAppendCookiesPanel(): void {
304
305
  const cookiesPresent = this.#request.hasRequestCookies() || this.#request.responseCookies.length > 0;
305
306
  console.assert(cookiesPresent || !this.#cookiesView, 'Cookies were introduced in headers and then removed!');
306
307
  if (cookiesPresent && !this.#cookiesView) {
@@ -318,7 +319,7 @@ export class NetworkItemView extends UI.TabbedPane.TabbedPane {
318
319
  }
319
320
  }
320
321
 
321
- private maybeAppendDeviceBoundSessionsPanel(): void {
322
+ #maybeAppendDeviceBoundSessionsPanel(): void {
322
323
  const deviceBoundSessionsPresent = this.#request.getDeviceBoundSessionUsages().length > 0;
323
324
  if (deviceBoundSessionsPresent && !this.#deviceBoundSessionsView) {
324
325
  this.#deviceBoundSessionsView = new RequestDeviceBoundSessionsView(this.#request);
@@ -329,7 +330,7 @@ export class NetworkItemView extends UI.TabbedPane.TabbedPane {
329
330
  }
330
331
  }
331
332
 
332
- private async maybeAppendPayloadPanel(): Promise<void> {
333
+ async #maybeAppendPayloadPanel(): Promise<void> {
333
334
  if (this.hasTab('payload')) {
334
335
  return;
335
336
  }
@@ -343,7 +344,7 @@ export class NetworkItemView extends UI.TabbedPane.TabbedPane {
343
344
  }
344
345
  }
345
346
 
346
- private maybeShowErrorIconInTrustTokenTabHeader(): void {
347
+ #maybeShowErrorIconInTrustTokenTabHeader(): void {
347
348
  const trustTokenResult = this.#request.trustTokenOperationDoneEvent();
348
349
  if (trustTokenResult &&
349
350
  !NetworkComponents.RequestTrustTokensView.statusConsideredSuccess(trustTokenResult.status)) {
@@ -366,7 +367,7 @@ export class NetworkItemView extends UI.TabbedPane.TabbedPane {
366
367
  }
367
368
  }
368
369
 
369
- private tabSelected(event: Common.EventTarget.EventTargetEvent<UI.TabbedPane.EventData>): void {
370
+ #tabSelected(event: Common.EventTarget.EventTargetEvent<UI.TabbedPane.EventData>): void {
370
371
  if (!event.data.isUserGesture) {
371
372
  return;
372
373
  }
@@ -1,13 +1,21 @@
1
1
  // Copyright 2016 The Chromium Authors
2
2
  // Use of this source code is governed by a BSD-style license that can be
3
3
  // found in the LICENSE file.
4
- /* eslint-disable @devtools/no-imperative-dom-api */
5
4
 
5
+ import '../../ui/components/lists/lists.js';
6
+ import '../../ui/legacy/legacy.js';
7
+
8
+ import type * as Common from '../../core/common/common.js';
6
9
  import * as i18n from '../../core/i18n/i18n.js';
10
+ import * as Buttons from '../../ui/components/buttons/buttons.js';
11
+ import type * as Lists from '../../ui/components/lists/lists.js';
7
12
  import * as UI from '../../ui/legacy/legacy.js';
13
+ import {Directives, html, type LitTemplate, render} from '../../ui/lit/lit.js';
8
14
 
9
15
  import networkManageCustomHeadersViewStyles from './networkManageCustomHeadersView.css.js';
10
16
 
17
+ const {ifDefined, repeat} = Directives;
18
+
11
19
  const UIStrings = {
12
20
  /**
13
21
  * @description Text in Network Manage Custom Headers View of the Network panel
@@ -22,27 +30,149 @@ const UIStrings = {
22
30
  */
23
31
  addCustomHeader: 'Add custom header…',
24
32
  /**
25
- * @description Text in Network Manage Custom Headers View of the Network panel
33
+ * @description Accessible label for custom header name input in Network Manage Custom Headers View
34
+ * of the Network panel
26
35
  */
27
36
  headerName: 'Header name',
37
+ /**
38
+ * @description Error message shown when custom header name input is empty
39
+ */
40
+ headerCannotBeEmpty: 'Header name can’t be empty',
41
+ /**
42
+ * @description Error message shown when custom header name already exists
43
+ */
44
+ headerAlreadyExists: 'Header already exists',
28
45
  } as const;
29
46
  const str_ = i18n.i18n.registerUIStrings('panels/network/NetworkManageCustomHeadersView.ts', UIStrings);
30
47
  const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
31
48
 
32
- interface CustomHeader {
49
+ const NEW_ITEM_KEY = Symbol('new-header');
50
+
51
+ export interface CustomHeaderItem {
33
52
  header: string;
53
+ editable: boolean;
54
+ isNew?: boolean;
55
+ }
56
+
57
+ export interface ViewInput {
58
+ items: CustomHeaderItem[];
59
+ editingHeader: string|null;
60
+ onAddClick: () => void;
61
+ onBeginEdit: (header: string) => void;
62
+ onRemove: (header: string) => void;
63
+ onCommitEdit: (newHeader: string) => void;
64
+ onCancelEdit: () => void;
65
+ validateHeader: (itemHeader: string, newHeader: string) => Common.UIString.LocalizedString | null;
34
66
  }
35
67
 
36
- export class NetworkManageCustomHeadersView extends UI.Widget.VBox implements UI.ListWidget.Delegate<CustomHeader> {
37
- private readonly list: UI.ListWidget.ListWidget<CustomHeader>;
38
- private readonly columnConfigs: Map<string, {
68
+ export type View = (input: ViewInput, output: undefined, target: HTMLElement) => void;
69
+
70
+ function renderCustomHeaderItem(item: CustomHeaderItem, input: ViewInput): LitTemplate {
71
+ const editing = item.editable &&
72
+ ((Boolean(item.isNew) && input.editingHeader === '') ||
73
+ (!item.isNew && input.editingHeader !== null &&
74
+ input.editingHeader.toLowerCase() === item.header.toLowerCase()));
75
+
76
+ const onPromptActivate = (event: Event): void => {
77
+ if (!item.editable || editing) {
78
+ return;
79
+ }
80
+ input.onBeginEdit(item.header);
81
+ event.consume(true);
82
+ };
83
+
84
+ // clang-format off
85
+ return html`
86
+ <div
87
+ class="custom-headers-list-item"
88
+ ?editable=${item.editable && !editing}
89
+ ?deletable=${item.editable && !editing}>
90
+ ${item.editable ? html`
91
+ <devtools-prompt
92
+ class="custom-header-name"
93
+ render-as-block
94
+ title=${ifDefined(item.header || undefined)}
95
+ aria-label=${ifDefined(editing ? i18nString(UIStrings.headerName) : undefined)}
96
+ value=${item.header}
97
+ ?editing=${editing}
98
+ .validator=${(value: string) => input.validateHeader(item.header, value)}
99
+ @click=${onPromptActivate}
100
+ @commit=${(event: UI.TextPrompt.TextPromptElement.CommitEvent) => input.onCommitEdit(event.detail)}
101
+ @cancel=${input.onCancelEdit}>
102
+ ${item.header}
103
+ </devtools-prompt>
104
+ ` : html`
105
+ <div class="custom-header-name" title=${item.header}>${item.header}</div>
106
+ `}
107
+ </div>
108
+ `;
109
+ // clang-format on
110
+ }
111
+
112
+ export const DEFAULT_VIEW: View = (input, _output, target) => {
113
+ // clang-format off
114
+ render(html`
115
+ <style>${networkManageCustomHeadersViewStyles}</style>
116
+ <div class="header">${i18nString(UIStrings.manageHeaderColumns)}</div>
117
+ ${input.items.length === 0 ? html`
118
+ <div class="custom-headers-list custom-headers-list-list-empty">
119
+ ${i18nString(UIStrings.noCustomHeaders)}
120
+ </div>
121
+ ` : html`
122
+ <devtools-list
123
+ class="custom-headers-list square-corners"
124
+ ?disable-li-focus=${input.editingHeader !== null}
125
+ @edit=${(event: Lists.List.ItemEditEvent) => {
126
+ const item = input.items[event.detail.index];
127
+ if (item) {
128
+ input.onBeginEdit(item.header);
129
+ }
130
+ }}
131
+ @delete=${(event: Lists.List.ItemRemoveEvent) => {
132
+ const item = input.items[event.detail.index];
133
+ if (item) {
134
+ input.onRemove(item.header);
135
+ }
136
+ }}>
137
+ ${repeat(
138
+ input.items,
139
+ item => item.isNew ? NEW_ITEM_KEY : item.header.toLowerCase(),
140
+ item => renderCustomHeaderItem(item, input))}
141
+ </devtools-list>
142
+ `}
143
+ <devtools-button
144
+ class="add-button"
145
+ .variant=${Buttons.Button.Variant.OUTLINED}
146
+ .jslogContext=${'network.add-custom-header'}
147
+ @click=${input.onAddClick}>
148
+ ${i18nString(UIStrings.addCustomHeader)}
149
+ </devtools-button>
150
+ `, target, {
151
+ container: {
152
+ attributes: {
153
+ tabindex: '0',
154
+ },
155
+ },
156
+ });
157
+ // clang-format on
158
+ };
159
+
160
+ export class NetworkManageCustomHeadersView extends UI.Widget.VBox {
161
+ readonly #columnConfigs = new Map<string, {
39
162
  title: string,
40
163
  editable: boolean,
41
- }>;
42
- private addHeaderColumnCallback: (arg0: string) => boolean;
43
- private changeHeaderColumnCallback: (arg0: string, arg1: string) => boolean;
44
- private readonly removeHeaderColumnCallback: (arg0: string) => boolean;
45
- private editor?: UI.ListWidget.Editor<CustomHeader>;
164
+ }>();
165
+ readonly #addHeaderColumnCallback: (header: string) => boolean;
166
+ readonly #changeHeaderColumnCallback: (oldHeader: string, newHeader: string) => boolean;
167
+ readonly #removeHeaderColumnCallback: (header: string) => boolean;
168
+ readonly #view: View;
169
+ #editingHeader: string|null = null;
170
+ readonly #onAddClickBound = this.#addButtonClicked.bind(this);
171
+ readonly #onBeginEditBound = this.#beginEdit.bind(this);
172
+ readonly #onRemoveBound = this.#removeItem.bind(this);
173
+ readonly #onCommitEditBound = this.#commitEdit.bind(this);
174
+ readonly #onCancelEditBound = this.#cancelEdit.bind(this);
175
+ readonly #validateHeaderBound = this.#validateHeader.bind(this);
46
176
 
47
177
  constructor(
48
178
  columnData: Array<{
@@ -51,120 +181,129 @@ export class NetworkManageCustomHeadersView extends UI.Widget.VBox implements UI
51
181
  }>,
52
182
  addHeaderColumnCallback: (arg0: string) => boolean,
53
183
  changeHeaderColumnCallback: (arg0: string, arg1: string) => boolean,
54
- removeHeaderColumnCallback: (arg0: string) => boolean) {
184
+ removeHeaderColumnCallback: (arg0: string) => boolean,
185
+ view: View = DEFAULT_VIEW,
186
+ ) {
55
187
  super({useShadowDom: true});
56
- this.registerRequiredCSS(networkManageCustomHeadersViewStyles);
57
-
58
- this.contentElement.createChild('div', 'header').textContent = i18nString(UIStrings.manageHeaderColumns);
188
+ this.#view = view;
59
189
 
60
- this.list = new UI.ListWidget.ListWidget(this);
61
- this.list.registerRequiredCSS(networkManageCustomHeadersViewStyles);
62
- this.list.element.classList.add('custom-headers-list');
63
-
64
- const placeholder = document.createElement('div');
65
- placeholder.classList.add('custom-headers-list-list-empty');
66
- placeholder.textContent = i18nString(UIStrings.noCustomHeaders);
67
- this.list.setEmptyPlaceholder(placeholder);
68
- this.list.show(this.contentElement);
69
- this.contentElement.appendChild(
70
- UI.UIUtils.createTextButton(i18nString(UIStrings.addCustomHeader), this.addButtonClicked.bind(this), {
71
- className: 'add-button',
72
- jslogContext: 'network.add-custom-header',
73
- }));
190
+ for (const column of columnData) {
191
+ this.#columnConfigs.set(column.title.toLowerCase(), column);
192
+ }
74
193
 
75
- this.columnConfigs = new Map();
76
- columnData.forEach(columnData => this.columnConfigs.set(columnData.title.toLowerCase(), columnData));
194
+ this.#addHeaderColumnCallback = addHeaderColumnCallback;
195
+ this.#changeHeaderColumnCallback = changeHeaderColumnCallback;
196
+ this.#removeHeaderColumnCallback = removeHeaderColumnCallback;
77
197
 
78
- this.addHeaderColumnCallback = addHeaderColumnCallback;
79
- this.changeHeaderColumnCallback = changeHeaderColumnCallback;
80
- this.removeHeaderColumnCallback = removeHeaderColumnCallback;
198
+ this.requestUpdate();
199
+ }
81
200
 
82
- this.contentElement.tabIndex = 0;
201
+ override performUpdate(): void {
202
+ const items: CustomHeaderItem[] = [];
203
+ for (const headerData of this.#columnConfigs.values()) {
204
+ items.push({header: headerData.title, editable: headerData.editable});
205
+ }
206
+ if (this.#editingHeader === '') {
207
+ items.push({header: '', editable: true, isNew: true});
208
+ }
209
+ this.#view(
210
+ {
211
+ items,
212
+ editingHeader: this.#editingHeader,
213
+ onAddClick: this.#onAddClickBound,
214
+ onBeginEdit: this.#onBeginEditBound,
215
+ onRemove: this.#onRemoveBound,
216
+ onCommitEdit: this.#onCommitEditBound,
217
+ onCancelEdit: this.#onCancelEditBound,
218
+ validateHeader: this.#validateHeaderBound,
219
+ },
220
+ undefined,
221
+ this.contentElement,
222
+ );
83
223
  }
84
224
 
85
225
  override wasShown(): void {
86
226
  super.wasShown();
87
- this.headersUpdated();
88
- }
89
-
90
- private headersUpdated(): void {
91
- this.list.clear();
92
- this.columnConfigs.forEach(headerData => this.list.appendItem({header: headerData.title}, headerData.editable));
227
+ this.requestUpdate();
93
228
  }
94
229
 
95
- private addButtonClicked(): void {
96
- this.list.addNewItem(this.columnConfigs.size, {header: ''});
230
+ #addButtonClicked(): void {
231
+ if (this.#editingHeader === '') {
232
+ return;
233
+ }
234
+ this.#editingHeader = '';
235
+ this.requestUpdate();
97
236
  }
98
237
 
99
- renderItem(item: CustomHeader, _editable: boolean): Element {
100
- const element = document.createElement('div');
101
- element.classList.add('custom-headers-list-item');
102
- const header = element.createChild('div', 'custom-header-name');
103
- header.textContent = item.header;
104
- UI.Tooltip.Tooltip.install(header, item.header);
105
- return element;
238
+ #beginEdit(header: string): void {
239
+ const config = this.#columnConfigs.get(header.toLowerCase());
240
+ if (!config?.editable) {
241
+ return;
242
+ }
243
+ this.#editingHeader = config.title;
244
+ this.requestUpdate();
106
245
  }
107
246
 
108
- removeItemRequested(item: CustomHeader, _index: number): void {
109
- this.removeHeaderColumnCallback(item.header);
110
- this.columnConfigs.delete(item.header.toLowerCase());
111
- this.headersUpdated();
247
+ #removeItem(header: string): void {
248
+ const key = header.toLowerCase();
249
+ const config = this.#columnConfigs.get(key);
250
+ if (!config?.editable) {
251
+ return;
252
+ }
253
+ if (this.#removeHeaderColumnCallback(config.title)) {
254
+ this.#columnConfigs.delete(key);
255
+ }
256
+ if (this.#editingHeader?.toLowerCase() === key) {
257
+ this.#editingHeader = null;
258
+ }
259
+ this.requestUpdate();
112
260
  }
113
261
 
114
- commitEdit(item: CustomHeader, editor: UI.ListWidget.Editor<CustomHeader>, isNew: boolean): void {
115
- const headerId = editor.control('header').value.trim();
116
- let success;
117
- if (isNew) {
118
- success = this.addHeaderColumnCallback(headerId);
119
- } else {
120
- success = this.changeHeaderColumnCallback(item.header, headerId);
262
+ #commitEdit(newHeader: string): void {
263
+ if (this.#editingHeader === null) {
264
+ return;
265
+ }
266
+ const oldHeader = this.#editingHeader;
267
+ const isNew = oldHeader === '';
268
+ const trimmedHeader = newHeader.trim();
269
+ if (this.#validateHeader(oldHeader, trimmedHeader) !== null) {
270
+ return;
271
+ }
272
+ if (!isNew && oldHeader === trimmedHeader) {
273
+ this.#editingHeader = null;
274
+ this.requestUpdate();
275
+ return;
121
276
  }
122
277
 
278
+ const success = isNew ? this.#addHeaderColumnCallback(trimmedHeader) :
279
+ this.#changeHeaderColumnCallback(oldHeader, trimmedHeader);
123
280
  if (success && !isNew) {
124
- this.columnConfigs.delete(item.header.toLowerCase());
281
+ this.#columnConfigs.delete(oldHeader.toLowerCase());
125
282
  }
126
283
  if (success) {
127
- this.columnConfigs.set(headerId.toLowerCase(), {title: headerId, editable: true});
284
+ this.#columnConfigs.set(trimmedHeader.toLowerCase(), {title: trimmedHeader, editable: true});
128
285
  }
129
-
130
- this.headersUpdated();
286
+ this.#editingHeader = null;
287
+ this.requestUpdate();
131
288
  }
132
289
 
133
- beginEdit(item: CustomHeader): UI.ListWidget.Editor<CustomHeader> {
134
- const editor = this.createEditor();
135
- editor.control('header').value = item.header;
136
- return editor;
290
+ #cancelEdit(): void {
291
+ if (this.#editingHeader === null) {
292
+ return;
293
+ }
294
+ this.#editingHeader = null;
295
+ this.requestUpdate();
137
296
  }
138
297
 
139
- private createEditor(): UI.ListWidget.Editor<CustomHeader> {
140
- if (this.editor) {
141
- return this.editor;
298
+ #validateHeader(itemHeader: string, newHeader: string): Common.UIString.LocalizedString|null {
299
+ const trimmed = newHeader.trim();
300
+ if (!trimmed) {
301
+ return i18nString(UIStrings.headerCannotBeEmpty);
142
302
  }
143
-
144
- const editor = new UI.ListWidget.Editor<CustomHeader>();
145
- this.editor = editor;
146
- const content = editor.contentElement();
147
-
148
- const titles = content.createChild('div', 'custom-headers-edit-row');
149
- titles.createChild('div', 'custom-headers-header').textContent = i18nString(UIStrings.headerName);
150
-
151
- const fields = content.createChild('div', 'custom-headers-edit-row');
152
- fields.createChild('div', 'custom-headers-header')
153
- .appendChild(editor.createInput('header', 'text', 'x-custom-header', validateHeader.bind(this)));
154
-
155
- return editor;
156
-
157
- function validateHeader(
158
- this: NetworkManageCustomHeadersView, item: CustomHeader, _index: number,
159
- _input: UI.ListWidget.EditorControl): UI.ListWidget.ValidatorResult {
160
- let valid = true;
161
- const headerId = editor.control('header').value.trim().toLowerCase();
162
- if (this.columnConfigs.has(headerId) && item.header !== headerId) {
163
- valid = false;
164
- }
165
- return {
166
- valid,
167
- };
303
+ const headerId = trimmed.toLowerCase();
304
+ if (this.#columnConfigs.has(headerId) && itemHeader.toLowerCase() !== headerId) {
305
+ return i18nString(UIStrings.headerAlreadyExists);
168
306
  }
307
+ return null;
169
308
  }
170
309
  }
@@ -1,7 +1,6 @@
1
1
  // Copyright 2015 The Chromium Authors
2
2
  // Use of this source code is governed by a BSD-style license that can be
3
3
  // found in the LICENSE file.
4
- /* eslint-disable @devtools/no-imperative-dom-api */
5
4
 
6
5
  import type * as Common from '../../core/common/common.js';
7
6
  import * as SDK from '../../core/sdk/sdk.js';
@@ -26,20 +25,19 @@ export class NetworkOverview extends PerfUI.TimelineOverviewPane.TimelineOvervie
26
25
  private span!: number;
27
26
  private lastBoundary?: NetworkTimeCalculator.NetworkTimeBoundary|null;
28
27
 
29
- constructor() {
30
- super();
28
+ constructor(element?: HTMLElement) {
29
+ super(element, {classes: ['network-overview']});
31
30
  this.selectedFilmStripTime = -1;
32
- this.element.classList.add('network-overview');
33
31
 
34
32
  this.numBands = 1;
35
33
  this.highlightedRequest = null;
36
34
 
37
- SDK.TargetManager.TargetManager.instance().addModelListener(
38
- SDK.ResourceTreeModel.ResourceTreeModel, SDK.ResourceTreeModel.Events.Load, this.loadEventFired, this,
39
- {scoped: true});
40
- SDK.TargetManager.TargetManager.instance().addModelListener(
41
- SDK.ResourceTreeModel.ResourceTreeModel, SDK.ResourceTreeModel.Events.DOMContentLoaded,
42
- this.domContentLoadedEventFired, this, {scoped: true});
35
+ SDK.TargetManager.TargetManager.instance().addModelListener(SDK.ResourceTreeModel.ResourceTreeModel,
36
+ SDK.ResourceTreeModel.Events.Load, this.loadEventFired,
37
+ this, {scoped: true});
38
+ SDK.TargetManager.TargetManager.instance().addModelListener(SDK.ResourceTreeModel.ResourceTreeModel,
39
+ SDK.ResourceTreeModel.Events.DOMContentLoaded,
40
+ this.domContentLoadedEventFired, this, {scoped: true});
43
41
 
44
42
  this.reset();
45
43
  }