chrome-devtools-frontend 1.0.1726686 → 1.0.1730971

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (490) hide show
  1. package/.agents/rules/tests/test-strict-assertions-and-literal-expectations.md +1 -1
  2. package/.agents/rules/tests/test-view-and-presenter-isolation.md +1 -1
  3. package/.agents/rules/ui-and-widgets/ui-accessibility-and-semantic-html.md +1 -1
  4. package/.agents/rules/ui-and-widgets/ui-css-scoping-and-flex-layout.md +2 -2
  5. package/.agents/rules/ui-and-widgets/ui-declarative-child-widget-composition.md +5 -5
  6. package/.agents/rules/ui-and-widgets/ui-lit-declarative-templates-and-directives.md +2 -2
  7. package/.agents/rules/ui-and-widgets/ui-localization-and-uistrings-hygiene.md +2 -2
  8. package/.agents/rules/ui-and-widgets/ui-modern-component-and-encapsulation-standards.md +3 -3
  9. package/.agents/rules/ui-and-widgets/ui-pure-view-and-presenter-separation.md +2 -2
  10. package/.agents/rules/ui-and-widgets/ui-reactive-widget-update-lifecycle.md +2 -2
  11. package/.agents/rules/ui-and-widgets/ui-view-output-and-callback-contracts.md +2 -2
  12. package/.agents/rules/ui-and-widgets/ui-widget-dom-and-listener-lifecycle.md +2 -2
  13. package/.agents/skills/code-review/SKILL.md +63 -12
  14. package/.agents/skills/ui-eng-vision-local-lit-renderer/SKILL.md +38 -10
  15. package/.agents/skills/ui-eng-vision-widget-promoter/SKILL.md +1 -0
  16. package/.agents/skills/ui-widgets/SKILL.md +8 -2
  17. package/.agents/skills/write-ai-eval-test/SKILL.md +106 -0
  18. package/AUTHORS +2 -0
  19. package/DIR_METADATA +1 -2
  20. package/README.md +48 -26
  21. package/config/typescript/tsconfig.base.json +1 -0
  22. package/config/typescript/tsconfig.eslint.json +1 -0
  23. package/docs/contributing/changes.md +25 -0
  24. package/docs/ui_engineering.md +13 -4
  25. package/eslint.config.mjs +323 -41
  26. package/front_end/core/common/Color.ts +7 -7
  27. package/front_end/core/common/ParsedURL.ts +3 -3
  28. package/front_end/core/common/ResolverBase.ts +3 -3
  29. package/front_end/core/common/SegmentedRange.ts +3 -3
  30. package/front_end/core/common/SimpleHistoryManager.ts +14 -14
  31. package/front_end/core/common/Trie.ts +3 -3
  32. package/front_end/core/common/VersionController.ts +7 -7
  33. package/front_end/core/host/InspectorFrontendHost.ts +2 -2
  34. package/front_end/core/host/InspectorFrontendHostAPI.ts +9 -1
  35. package/front_end/core/host/InspectorFrontendHostStub.ts +1 -1
  36. package/front_end/core/host/UserMetrics.ts +4 -0
  37. package/front_end/core/host/UserMetricsEnums.ts +2 -1
  38. package/front_end/core/platform/StringUtilities.ts +54 -13
  39. package/front_end/core/platform/node/HostRuntime.ts +13 -7
  40. package/front_end/core/protocol_client/DevToolsCDPConnection.ts +4 -5
  41. package/front_end/core/root/Runtime.ts +5 -0
  42. package/front_end/core/sdk/AccessibilityModel.ts +5 -5
  43. package/front_end/core/sdk/AnimationModel.ts +17 -19
  44. package/front_end/core/sdk/CPUProfilerModel.ts +3 -3
  45. package/front_end/core/sdk/CPUThrottlingManager.ts +7 -0
  46. package/front_end/core/sdk/CSSMatchedStyles.ts +73 -13
  47. package/front_end/core/sdk/CSSMetadata.ts +7 -7
  48. package/front_end/core/sdk/CSSModel.ts +33 -33
  49. package/front_end/core/sdk/CSSProperty.ts +5 -5
  50. package/front_end/core/sdk/CSSRule.ts +6 -6
  51. package/front_end/core/sdk/CSSStyleSheetHeader.ts +4 -4
  52. package/front_end/core/sdk/Connections.ts +16 -16
  53. package/front_end/core/sdk/ConsoleModel.ts +44 -47
  54. package/front_end/core/sdk/CookieParser.ts +11 -11
  55. package/front_end/core/sdk/EmulationModel.ts +35 -36
  56. package/front_end/core/sdk/EventBreakpointsModel.ts +11 -11
  57. package/front_end/core/sdk/FrameManager.ts +16 -16
  58. package/front_end/core/sdk/IsolateManager.ts +2 -2
  59. package/front_end/core/sdk/IssuesModel.ts +2 -2
  60. package/front_end/core/sdk/OverlayModel.ts +19 -19
  61. package/front_end/core/sdk/PageResourceLoader.ts +14 -16
  62. package/front_end/core/sdk/RemoteObject.ts +9 -9
  63. package/front_end/core/sdk/Resource.ts +2 -2
  64. package/front_end/core/sdk/RuntimeModel.ts +7 -7
  65. package/front_end/core/sdk/Script.ts +6 -6
  66. package/front_end/core/sdk/ServiceWorkerManager.ts +36 -10
  67. package/front_end/core/sdk/SourceMap.ts +18 -20
  68. package/front_end/core/sdk/SourceMapManager.ts +2 -2
  69. package/front_end/core/sdk/TargetManager.ts +2 -2
  70. package/front_end/devtools_compatibility.js +7 -3
  71. package/front_end/entrypoints/inspector_main/InspectorMain.ts +2 -2
  72. package/front_end/entrypoints/node_app/app/NodeConnectionsPanel.ts +203 -115
  73. package/front_end/generated/InspectorBackendCommands.ts +1 -1
  74. package/front_end/generated/SupportedCSSProperties.ts +1 -3
  75. package/front_end/generated/protocol.ts +1 -0
  76. package/front_end/models/ai_assistance/AiAgent2.ts +36 -12
  77. package/front_end/models/ai_assistance/AiConversation.ts +8 -2
  78. package/front_end/models/ai_assistance/agents/AiAgent.ts +137 -62
  79. package/front_end/models/ai_assistance/agents/ExecuteJavascript.ts +2 -2
  80. package/front_end/models/ai_assistance/agents/StylingAgent.snapshot.txt +2 -2
  81. package/front_end/models/ai_assistance/data_formatters/LighthouseFormatter.snapshot.txt +149 -2
  82. package/front_end/models/ai_assistance/data_formatters/LighthouseFormatter.ts +269 -42
  83. package/front_end/models/ai_assistance/tools/ExecuteJavaScript.ts +3 -0
  84. package/front_end/models/ai_assistance/tools/GetLighthouseAudits.ts +9 -0
  85. package/front_end/models/ai_assistance/tools/ResolveDevtoolsNodePath.ts +13 -2
  86. package/front_end/models/ai_assistance/tools/RunLighthouse.ts +23 -7
  87. package/front_end/models/ai_assistance/tools/Tool.ts +7 -5
  88. package/front_end/models/bindings/CSSWorkspaceBinding.ts +22 -24
  89. package/front_end/models/bindings/DebuggerLanguagePlugins.ts +60 -60
  90. package/front_end/models/bindings/DebuggerWorkspaceBinding.ts +24 -24
  91. package/front_end/models/bindings/DefaultScriptMapping.ts +8 -8
  92. package/front_end/models/bindings/FileUtils.ts +13 -13
  93. package/front_end/models/bindings/PresentationConsoleMessageHelper.ts +3 -3
  94. package/front_end/models/bindings/ResourceScriptMapping.ts +23 -23
  95. package/front_end/models/comment_manager/CommentManager.ts +3 -3
  96. package/front_end/models/comment_manager/CommentThread.ts +50 -5
  97. package/front_end/models/cpu_profile/CPUProfileDataModel.ts +14 -14
  98. package/front_end/models/cpu_profile/ProfileTreeModel.ts +4 -4
  99. package/front_end/models/elements/StyleChanges.ts +38 -0
  100. package/front_end/models/emulation/EmulatedDevices.ts +12 -12
  101. package/front_end/models/har/HARFormat.ts +4 -4
  102. package/front_end/models/javascript_metadata/NativeFunctions.ts +5 -1
  103. package/front_end/models/lighthouse/LighthouseReporterTypes.ts +57 -3
  104. package/front_end/models/lighthouse/RunTypes.ts +9 -1
  105. package/front_end/models/logs/LogManager.ts +2 -2
  106. package/front_end/models/persistence/AutomaticFileSystemManager.ts +3 -0
  107. package/front_end/models/persistence/FileSystemWorkspaceBinding.ts +24 -24
  108. package/front_end/models/persistence/IsolatedFileSystemManager.ts +6 -0
  109. package/front_end/models/persistence/NetworkPersistenceManager.ts +8 -3
  110. package/front_end/models/trace/LanternComputationData.ts +37 -11
  111. package/front_end/models/trace/Processor.ts +2 -1
  112. package/front_end/models/trace/extras/TraceTree.ts +36 -10
  113. package/front_end/models/trace/handlers/InitiatorsHandler.ts +27 -34
  114. package/front_end/models/trace/handlers/LayoutShiftsHandler.ts +2 -6
  115. package/front_end/models/trace/handlers/SamplesHandler.ts +9 -6
  116. package/front_end/models/workspace/FileManager.ts +6 -0
  117. package/front_end/panels/accessibility/ARIAAttributesView.ts +4 -4
  118. package/front_end/panels/accessibility/AccessibilityAnnouncementRecordingView.ts +8 -1
  119. package/front_end/panels/accessibility/AccessibilityNodeView.ts +15 -17
  120. package/front_end/panels/accessibility/AccessibilitySubPane.ts +1 -1
  121. package/front_end/panels/ai_assistance/AiAssistancePanel.ts +5 -5
  122. package/front_end/panels/ai_assistance/ExternalHandler.ts +10 -1
  123. package/front_end/panels/ai_assistance/components/ChatMessage.ts +27 -22
  124. package/front_end/panels/ai_assistance/components/DisabledWidget.ts +19 -23
  125. package/front_end/panels/ai_assistance/components/ExploreWidget.ts +2 -2
  126. package/front_end/panels/ai_assistance/components/PermissionPrompt.ts +23 -9
  127. package/front_end/panels/ai_assistance/components/chatInput.css +1 -1
  128. package/front_end/panels/animation/AnimationTimeline.ts +37 -17
  129. package/front_end/panels/animation/animationTimeline.css +19 -3
  130. package/front_end/panels/application/AppManifestView.ts +1 -2
  131. package/front_end/panels/application/ApplicationPanelSidebar.ts +143 -128
  132. package/front_end/panels/application/DOMStorageItemsView.ts +14 -14
  133. package/front_end/panels/application/DeviceBoundSessionsView.ts +10 -13
  134. package/front_end/panels/application/ExtensionStorageItemsView.ts +3 -4
  135. package/front_end/panels/application/IndexedDBViews.ts +8 -4
  136. package/front_end/panels/application/KeyValueStorageItemsView.ts +4 -5
  137. package/front_end/panels/application/PrivateVerificationTokensView.ts +53 -0
  138. package/front_end/panels/application/ServiceWorkerCacheViews.ts +12 -8
  139. package/front_end/panels/application/ServiceWorkersView.ts +1 -2
  140. package/front_end/panels/application/StorageItemsToolbar.ts +3 -3
  141. package/front_end/panels/application/StorageView.ts +2 -2
  142. package/front_end/panels/application/WebMCPView.ts +91 -109
  143. package/front_end/panels/application/application.ts +2 -0
  144. package/front_end/panels/application/components/StorageMetadataView.ts +6 -6
  145. package/front_end/panels/application/preloading/PreloadingView.ts +70 -37
  146. package/front_end/panels/application/preloading/components/MismatchedPreloadingGrid.ts +2 -2
  147. package/front_end/panels/application/preloading/components/PreloadingDisabledInfobar.ts +3 -3
  148. package/front_end/panels/application/preloading/components/PreloadingGrid.ts +12 -0
  149. package/front_end/panels/application/preloading/components/RuleSetDetailsView.ts +10 -11
  150. package/front_end/panels/application/privateVerificationTokensView.css +20 -0
  151. package/front_end/panels/application/serviceWorkersView.css +2 -2
  152. package/front_end/panels/browser_debugger/DOMBreakpointsSidebarPane.ts +24 -24
  153. package/front_end/panels/changes/ChangesSidebar.ts +5 -5
  154. package/front_end/panels/changes/ChangesView.ts +10 -11
  155. package/front_end/panels/comments/CommentsPane.ts +292 -102
  156. package/front_end/panels/comments/commentsPane.css +93 -12
  157. package/front_end/panels/common/CommentThreadWidget.ts +69 -0
  158. package/front_end/panels/common/CommentsOverlayWidget.ts +108 -29
  159. package/front_end/panels/common/CommentsStatusBarPill.ts +17 -6
  160. package/front_end/panels/common/DOMLinkifier.ts +37 -12
  161. package/front_end/panels/common/ExtensionPanel.ts +13 -4
  162. package/front_end/panels/common/ExtensionServer.ts +27 -3
  163. package/front_end/panels/common/PersistenceUtils.ts +3 -3
  164. package/front_end/panels/common/commentThreadWidget.css +25 -1
  165. package/front_end/panels/common/common-meta.ts +10 -0
  166. package/front_end/panels/console/ConsolePinPane.ts +13 -15
  167. package/front_end/panels/console/ConsolePrompt.ts +173 -95
  168. package/front_end/panels/console/ConsoleSidebar.ts +2 -2
  169. package/front_end/panels/console/ConsoleView.ts +75 -79
  170. package/front_end/panels/console/ConsoleViewMessage.ts +52 -4
  171. package/front_end/panels/console/SymbolizedErrorWidget.ts +8 -4
  172. package/front_end/panels/console/consolePrompt.css +1 -1
  173. package/front_end/panels/console/consoleView.css +1 -1
  174. package/front_end/panels/console_counters/WarningErrorCounter.ts +3 -4
  175. package/front_end/panels/coverage/CoverageListView.ts +2 -2
  176. package/front_end/panels/coverage/CoverageView.ts +20 -5
  177. package/front_end/panels/css_overview/CSSOverviewCompletedView.ts +4 -3
  178. package/front_end/panels/css_overview/CSSOverviewPanel.ts +2 -2
  179. package/front_end/panels/css_overview/CSSOverviewProcessingView.ts +2 -2
  180. package/front_end/panels/css_overview/CSSOverviewSidebarPanel.ts +2 -2
  181. package/front_end/panels/css_overview/CSSOverviewStartView.ts +2 -2
  182. package/front_end/panels/css_overview/CSSOverviewUnusedDeclarations.ts +8 -8
  183. package/front_end/panels/developer_resources/DeveloperResourcesListView.ts +2 -3
  184. package/front_end/panels/developer_resources/DeveloperResourcesView.ts +4 -5
  185. package/front_end/panels/elements/AccessibilityTreeUtils.ts +6 -7
  186. package/front_end/panels/elements/CSSValueTraceView.ts +3 -3
  187. package/front_end/panels/elements/ClassesPaneWidget.ts +1 -2
  188. package/front_end/panels/elements/ComputedStyleWidget.ts +15 -14
  189. package/front_end/panels/elements/DOMTreeElementWidget.ts +5 -4
  190. package/front_end/panels/elements/DOMTreeWidget.ts +2 -1
  191. package/front_end/panels/elements/ElementStatePaneWidget.ts +2 -2
  192. package/front_end/panels/elements/ElementsPanel.ts +1 -0
  193. package/front_end/panels/elements/EventListenersWidget.ts +2 -2
  194. package/front_end/panels/elements/LayoutPane.ts +2 -2
  195. package/front_end/panels/elements/PlatformFontsWidget.ts +3 -3
  196. package/front_end/panels/elements/PropertiesWidget.ts +9 -10
  197. package/front_end/panels/elements/PropertyRenderer.ts +72 -11
  198. package/front_end/panels/elements/StandaloneStylesContainer.ts +5 -10
  199. package/front_end/panels/elements/StyleEditorWidget.ts +30 -16
  200. package/front_end/panels/elements/StylePropertiesSection.ts +93 -44
  201. package/front_end/panels/elements/StylePropertyTreeElement.ts +230 -302
  202. package/front_end/panels/elements/StylesContainer.ts +2 -3
  203. package/front_end/panels/elements/StylesSidebarPane.ts +4 -13
  204. package/front_end/panels/elements/components/AccessibilityTreeNode.ts +66 -37
  205. package/front_end/panels/elements/components/CSSHintDetailsView.ts +51 -41
  206. package/front_end/panels/elements/components/CSSPropertyDocsView.ts +75 -65
  207. package/front_end/panels/elements/components/CSSQuery.ts +112 -74
  208. package/front_end/panels/elements/components/CSSVariableValueView.ts +109 -68
  209. package/front_end/panels/elements/components/ComputedStyleProperty.ts +64 -45
  210. package/front_end/panels/elements/components/ElementsTreeExpandButton.ts +35 -28
  211. package/front_end/panels/elements/components/QueryContainer.ts +104 -74
  212. package/front_end/panels/elements/components/accessibilityTreeNode.css +22 -20
  213. package/front_end/panels/elements/components/computedStyleProperty.css +2 -0
  214. package/front_end/panels/elements/components/cssHintDetailsView.css +23 -21
  215. package/front_end/panels/elements/components/cssPropertyDocsView.css +38 -36
  216. package/front_end/panels/elements/components/cssVariableValueView.css +42 -40
  217. package/front_end/panels/elements/components/elementsTreeExpandButton.css +5 -2
  218. package/front_end/panels/elements/components/queryContainer.css +23 -21
  219. package/front_end/panels/elements/stylesSidebarPane.css +3 -3
  220. package/front_end/panels/emulation/DeviceModeToolbar.ts +2 -2
  221. package/front_end/panels/emulation/InspectedPagePlaceholder.ts +2 -2
  222. package/front_end/panels/emulation/MediaQueryInspector.ts +9 -10
  223. package/front_end/panels/emulation/mediaQueryInspector.css +1 -1
  224. package/front_end/panels/event_listeners/EventListenersView.ts +2 -2
  225. package/front_end/panels/issues/AffectedCookiesView.ts +144 -101
  226. package/front_end/panels/issues/AffectedDescendantsWithinSelectElementView.ts +83 -31
  227. package/front_end/panels/issues/AffectedDirectivesView.ts +218 -135
  228. package/front_end/panels/issues/AffectedDocumentsInQuirksModeView.ts +84 -34
  229. package/front_end/panels/issues/AffectedElementsView.ts +86 -23
  230. package/front_end/panels/issues/AffectedLazyLoadImagesView.ts +2 -2
  231. package/front_end/panels/issues/AffectedMetadataAllowedSitesView.ts +2 -2
  232. package/front_end/panels/issues/AffectedPartitioningBlobURLView.ts +36 -11
  233. package/front_end/panels/issues/AffectedSharedArrayBufferIssueDetailsView.ts +135 -58
  234. package/front_end/panels/issues/AffectedSourcesView.ts +49 -28
  235. package/front_end/panels/issues/AffectedTrackingSitesView.ts +3 -4
  236. package/front_end/panels/issues/CorsIssueDetailsView.ts +490 -269
  237. package/front_end/panels/issues/GenericIssueDetailsView.ts +2 -2
  238. package/front_end/panels/issues/IssueKindView.ts +63 -48
  239. package/front_end/panels/issues/IssueView.ts +14 -18
  240. package/front_end/panels/issues/components/ElementsPanelLink.ts +70 -34
  241. package/front_end/panels/issues/components/HideIssuesMenu.ts +56 -32
  242. package/front_end/panels/issues/components/elementsPanelLink.css +10 -6
  243. package/front_end/panels/issues/components/hideIssuesMenu.css +16 -14
  244. package/front_end/panels/issues/issues.ts +2 -0
  245. package/front_end/panels/issues/issuesTree.css +4 -4
  246. package/front_end/panels/lighthouse/LighthouseController.ts +6 -6
  247. package/front_end/panels/lighthouse/LighthouseStatusView.ts +12 -13
  248. package/front_end/panels/lighthouse/lighthouseStartView.css +1 -1
  249. package/front_end/panels/linear_memory_inspector/LinearMemoryInspectorPane.ts +159 -161
  250. package/front_end/panels/linear_memory_inspector/LinearMemoryInspectorView.ts +228 -0
  251. package/front_end/panels/linear_memory_inspector/components/LinearMemoryInspector.ts +32 -41
  252. package/front_end/panels/linear_memory_inspector/components/linearMemoryHighlightChipList.css +2 -2
  253. package/front_end/panels/linear_memory_inspector/linear_memory_inspector.ts +2 -0
  254. package/front_end/panels/media/EventDisplayTable.ts +2 -2
  255. package/front_end/panels/media/MainView.ts +132 -66
  256. package/front_end/panels/media/PlayerDetailView.ts +32 -14
  257. package/front_end/panels/media/PlayerListView.ts +83 -23
  258. package/front_end/panels/media/PlayerPropertiesView.ts +2 -2
  259. package/front_end/panels/media/TickingFlameChart.ts +153 -63
  260. package/front_end/panels/mobile_throttling/NetworkThrottlingSelector.ts +2 -2
  261. package/front_end/panels/mobile_throttling/ThrottlingSettingsTab.ts +615 -464
  262. package/front_end/panels/mobile_throttling/throttlingSettingsTab.css +43 -0
  263. package/front_end/panels/network/EventSourceMessagesView.ts +3 -3
  264. package/front_end/panels/network/NetworkConfigView.ts +6 -2
  265. package/front_end/panels/network/NetworkDataGridNode.ts +2 -1
  266. package/front_end/panels/network/NetworkItemView.ts +27 -26
  267. package/front_end/panels/network/NetworkManageCustomHeadersView.ts +236 -97
  268. package/front_end/panels/network/NetworkOverview.ts +8 -10
  269. package/front_end/panels/network/RequestConditionsDrawer.ts +8 -4
  270. package/front_end/panels/network/RequestDeviceBoundSessionsView.ts +2 -4
  271. package/front_end/panels/network/RequestHTMLView.ts +26 -7
  272. package/front_end/panels/network/RequestHeadersView.ts +2 -2
  273. package/front_end/panels/network/RequestInitiatorView.ts +21 -22
  274. package/front_end/panels/network/RequestPayloadView.ts +2 -16
  275. package/front_end/panels/network/RequestPreviewView.ts +5 -5
  276. package/front_end/panels/network/RequestTimingView.ts +6 -6
  277. package/front_end/panels/network/ResourceDirectSocketChunkView.ts +5 -6
  278. package/front_end/panels/network/ResourceWebSocketFrameView.ts +4 -3
  279. package/front_end/panels/network/ShowMoreDetailsWidget.ts +11 -12
  280. package/front_end/panels/network/SignedExchangeInfoView.ts +2 -2
  281. package/front_end/panels/network/networkLogView.css +2 -2
  282. package/front_end/panels/network/networkManageCustomHeadersView.css +27 -6
  283. package/front_end/panels/network/requestConditionsDrawer.css +1 -1
  284. package/front_end/panels/network/requestInitiatorView.css +5 -3
  285. package/front_end/panels/performance_monitor/PerformanceMonitor.ts +2 -2
  286. package/front_end/panels/profiler/HeapDetachedElementsView.ts +1 -2
  287. package/front_end/panels/profiler/HeapTimelineOverview.ts +77 -15
  288. package/front_end/panels/profiler/IsolateSelector.ts +258 -187
  289. package/front_end/panels/profiler/ProfileLauncherView.ts +7 -29
  290. package/front_end/panels/profiler/profileLauncherView.css +6 -1
  291. package/front_end/panels/protocol_monitor/JSONEditor.ts +4 -5
  292. package/front_end/panels/recorder/ControlButton.ts +1 -1
  293. package/front_end/panels/recorder/RecordingListView.ts +2 -4
  294. package/front_end/panels/recorder/RecordingView.ts +1 -2
  295. package/front_end/panels/recorder/SelectorPicker.ts +2 -4
  296. package/front_end/panels/recorder/StepView.ts +24 -10
  297. package/front_end/panels/recorder/TimelineSection.ts +1 -1
  298. package/front_end/panels/recorder/recordingView.css +1 -1
  299. package/front_end/panels/screencast/ScreencastApp.ts +1 -1
  300. package/front_end/panels/search/SearchResultsPane.ts +11 -12
  301. package/front_end/panels/search/SearchView.ts +8 -10
  302. package/front_end/panels/security/SecurityPanel.ts +1 -8
  303. package/front_end/panels/security/SecurityPanelSidebar.ts +2 -2
  304. package/front_end/panels/security/mainView.css +1 -1
  305. package/front_end/panels/sensors/LocationsSettingsTab.ts +1 -2
  306. package/front_end/panels/settings/AISettingsTab.ts +1 -1
  307. package/front_end/panels/settings/BackendLinkingSettingsTab.ts +34 -20
  308. package/front_end/panels/settings/EditFileSystemView.ts +2 -2
  309. package/front_end/panels/settings/FrameworkIgnoreListSettingsTab.ts +375 -197
  310. package/front_end/panels/settings/KeybindsSettingsTab.ts +570 -414
  311. package/front_end/panels/settings/SettingsScreen.ts +312 -114
  312. package/front_end/panels/settings/WorkspaceSettingsTab.ts +2 -2
  313. package/front_end/panels/settings/aiSettingsTab.css +1 -4
  314. package/front_end/panels/settings/emulation/DevicesSettingsTab.ts +924 -578
  315. package/front_end/panels/settings/emulation/components/UserAgentClientHintsForm.ts +9 -2
  316. package/front_end/panels/settings/emulation/devicesSettingsTab.css +39 -0
  317. package/front_end/panels/settings/frameworkIgnoreListSettingsTab.css +37 -8
  318. package/front_end/panels/settings/settingsScreen.css +0 -24
  319. package/front_end/panels/sources/BreakpointEditDialog.ts +9 -6
  320. package/front_end/panels/sources/BreakpointsView.ts +25 -4
  321. package/front_end/panels/sources/CallStackSidebarPane.ts +7 -1
  322. package/front_end/panels/sources/DebuggerPlugin.ts +1 -0
  323. package/front_end/panels/sources/GoToLineQuickOpen.ts +8 -8
  324. package/front_end/panels/sources/NavigatorView.ts +521 -439
  325. package/front_end/panels/sources/PersistenceActions.ts +11 -12
  326. package/front_end/panels/sources/ProfilePlugin.ts +28 -17
  327. package/front_end/panels/sources/ScopeChainSidebarPane.ts +3 -4
  328. package/front_end/panels/sources/SourcesNavigator.ts +9 -9
  329. package/front_end/panels/sources/SourcesPanel.ts +2 -2
  330. package/front_end/panels/sources/SourcesView.ts +3 -3
  331. package/front_end/panels/sources/ThreadsSidebarPane.ts +2 -2
  332. package/front_end/panels/sources/WatchExpressionsSidebarPane.ts +2 -2
  333. package/front_end/panels/sources/components/HeadersView.ts +1 -2
  334. package/front_end/panels/timeline/CompatibilityTracksAppender.ts +5 -6
  335. package/front_end/panels/timeline/EventsTimelineTreeView.ts +73 -34
  336. package/front_end/panels/timeline/IsolateSelector.ts +25 -37
  337. package/front_end/panels/timeline/StatusDialog.ts +5 -7
  338. package/front_end/panels/timeline/ThirdPartyTreeView.ts +10 -13
  339. package/front_end/panels/timeline/TimelineDetailsView.ts +40 -21
  340. package/front_end/panels/timeline/TimelineEventOverview.ts +130 -34
  341. package/front_end/panels/timeline/TimelineFlameChartNetworkDataProvider.ts +1 -1
  342. package/front_end/panels/timeline/TimelineMiniMap.ts +255 -103
  343. package/front_end/panels/timeline/TimelinePaintProfilerView.ts +19 -11
  344. package/front_end/panels/timeline/TimelinePanel.ts +1 -0
  345. package/front_end/panels/timeline/TimelineSelectorStatsView.ts +11 -12
  346. package/front_end/panels/timeline/TimelineTreeView.ts +240 -122
  347. package/front_end/panels/timeline/TimelineUIUtils.ts +12 -0
  348. package/front_end/panels/timeline/components/BreadcrumbsUI.ts +5 -4
  349. package/front_end/panels/timeline/components/DetailsView.ts +97 -65
  350. package/front_end/panels/timeline/components/LayoutShiftDetails.ts +2 -2
  351. package/front_end/panels/timeline/components/MetricCard.ts +2 -2
  352. package/front_end/panels/timeline/components/NetworkRequestDetails.ts +11 -12
  353. package/front_end/panels/timeline/components/NetworkTrackWidget.ts +57 -50
  354. package/front_end/panels/timeline/components/RelatedInsightChips.ts +2 -2
  355. package/front_end/panels/timeline/components/Sidebar.ts +161 -109
  356. package/front_end/panels/timeline/components/SidebarAnnotationsTab.ts +33 -12
  357. package/front_end/panels/timeline/components/SidebarInsightsTab.ts +3 -0
  358. package/front_end/panels/timeline/components/insights/LCPDiscovery.ts +11 -11
  359. package/front_end/panels/timeline/components/insights/SlowCSSSelector.ts +6 -7
  360. package/front_end/panels/timeline/components/networkTrackWidget.css +24 -22
  361. package/front_end/panels/timeline/components/sidebarInsightsTab.css +1 -1
  362. package/front_end/panels/timeline/overlays/components/TimespanBreakdownOverlay.ts +15 -10
  363. package/front_end/panels/timeline/overlays/components/entryLabelOverlay.css +1 -1
  364. package/front_end/panels/timeline/timelinePanel.css +5 -0
  365. package/front_end/panels/timeline/timelineStatusDialog.css +1 -1
  366. package/front_end/panels/web_audio/WebAudioView.ts +2 -2
  367. package/front_end/third_party/chromium/README.chromium +1 -1
  368. package/front_end/third_party/legacy-javascript/README.chromium +2 -2
  369. package/front_end/third_party/legacy-javascript/lib/legacy-javascript.js +2 -2
  370. package/front_end/third_party/legacy-javascript/package.json +1 -1
  371. package/front_end/third_party/lighthouse/README.chromium +2 -2
  372. package/front_end/third_party/lighthouse/lighthouse-dt-bundle.js +1983 -2022
  373. package/front_end/third_party/lighthouse/locales/ar-XB.json +157 -142
  374. package/front_end/third_party/lighthouse/locales/ar.json +157 -142
  375. package/front_end/third_party/lighthouse/locales/bg.json +154 -139
  376. package/front_end/third_party/lighthouse/locales/ca.json +157 -142
  377. package/front_end/third_party/lighthouse/locales/cs.json +148 -133
  378. package/front_end/third_party/lighthouse/locales/da.json +153 -138
  379. package/front_end/third_party/lighthouse/locales/de.json +152 -137
  380. package/front_end/third_party/lighthouse/locales/el.json +153 -138
  381. package/front_end/third_party/lighthouse/locales/en-GB.json +160 -145
  382. package/front_end/third_party/lighthouse/locales/en-US.json +239 -218
  383. package/front_end/third_party/lighthouse/locales/en-XL.json +239 -218
  384. package/front_end/third_party/lighthouse/locales/es-419.json +150 -135
  385. package/front_end/third_party/lighthouse/locales/es.json +149 -134
  386. package/front_end/third_party/lighthouse/locales/fi.json +151 -136
  387. package/front_end/third_party/lighthouse/locales/fil.json +154 -139
  388. package/front_end/third_party/lighthouse/locales/fr.json +150 -135
  389. package/front_end/third_party/lighthouse/locales/he.json +160 -145
  390. package/front_end/third_party/lighthouse/locales/hi.json +156 -141
  391. package/front_end/third_party/lighthouse/locales/hr.json +154 -139
  392. package/front_end/third_party/lighthouse/locales/hu.json +111 -96
  393. package/front_end/third_party/lighthouse/locales/id.json +153 -138
  394. package/front_end/third_party/lighthouse/locales/it.json +153 -138
  395. package/front_end/third_party/lighthouse/locales/ja.json +150 -135
  396. package/front_end/third_party/lighthouse/locales/ko.json +42 -27
  397. package/front_end/third_party/lighthouse/locales/lt.json +152 -137
  398. package/front_end/third_party/lighthouse/locales/lv.json +93 -78
  399. package/front_end/third_party/lighthouse/locales/nl.json +149 -134
  400. package/front_end/third_party/lighthouse/locales/no.json +152 -137
  401. package/front_end/third_party/lighthouse/locales/pl.json +153 -138
  402. package/front_end/third_party/lighthouse/locales/pt-PT.json +152 -137
  403. package/front_end/third_party/lighthouse/locales/pt.json +157 -142
  404. package/front_end/third_party/lighthouse/locales/ro.json +149 -134
  405. package/front_end/third_party/lighthouse/locales/ru.json +76 -61
  406. package/front_end/third_party/lighthouse/locales/sk.json +153 -138
  407. package/front_end/third_party/lighthouse/locales/sl.json +149 -134
  408. package/front_end/third_party/lighthouse/locales/sr-Latn.json +151 -136
  409. package/front_end/third_party/lighthouse/locales/sr.json +151 -136
  410. package/front_end/third_party/lighthouse/locales/sv.json +152 -137
  411. package/front_end/third_party/lighthouse/locales/ta.json +156 -141
  412. package/front_end/third_party/lighthouse/locales/te.json +157 -142
  413. package/front_end/third_party/lighthouse/locales/th.json +111 -96
  414. package/front_end/third_party/lighthouse/locales/tr.json +153 -138
  415. package/front_end/third_party/lighthouse/locales/uk.json +149 -134
  416. package/front_end/third_party/lighthouse/locales/vi.json +162 -147
  417. package/front_end/third_party/lighthouse/locales/zh-HK.json +150 -135
  418. package/front_end/third_party/lighthouse/locales/zh-TW.json +154 -139
  419. package/front_end/third_party/lighthouse/locales/zh.json +152 -137
  420. package/front_end/third_party/lighthouse/report/bundle.d.ts +9 -8
  421. package/front_end/third_party/lighthouse/report/bundle.js +10 -10
  422. package/front_end/third_party/lighthouse/report-assets/report-generator.mjs +2 -7
  423. package/front_end/tsconfig.compatibility.json +1 -0
  424. package/front_end/tsconfig.json +3 -2
  425. package/front_end/ui/components/dialogs/TypeToAllowDialog.ts +0 -2
  426. package/front_end/ui/components/dialogs/typeToAllowDialog.css +0 -4
  427. package/front_end/ui/components/icon_button/fileSourceIcon.css +1 -1
  428. package/front_end/ui/components/input/textInput.css +1 -1
  429. package/front_end/ui/components/lists/List.ts +26 -14
  430. package/front_end/ui/components/menus/menus.ts +0 -2
  431. package/front_end/ui/components/suggestion_input/SuggestionInput.ts +351 -138
  432. package/front_end/ui/components/survey_link/surveyLink.css +3 -3
  433. package/front_end/ui/components/switch/switch.css +6 -6
  434. package/front_end/ui/components/text_editor/AiCodeCompletionTeaser.ts +2 -3
  435. package/front_end/ui/components/text_editor/TextEditor.ts +1 -1
  436. package/front_end/ui/components/tooltips/Tooltip.ts +53 -4
  437. package/front_end/ui/components/tree_outline/treeOutline.css +7 -7
  438. package/front_end/ui/helpers/OpenInNewTab.ts +8 -3
  439. package/front_end/ui/legacy/EmptyWidget.ts +4 -4
  440. package/front_end/ui/legacy/ForwardedInputEventHandler.ts +2 -2
  441. package/front_end/ui/legacy/GlassPane.ts +1 -1
  442. package/front_end/ui/legacy/KeyboardShortcut.ts +7 -7
  443. package/front_end/ui/legacy/RemoteDebuggingTerminatedScreen.ts +2 -2
  444. package/front_end/ui/legacy/TabbedPane.ts +198 -66
  445. package/front_end/ui/legacy/TargetCrashedScreen.ts +2 -2
  446. package/front_end/ui/legacy/UIUtils.ts +71 -68
  447. package/front_end/ui/legacy/View.ts +7 -4
  448. package/front_end/ui/legacy/ViewManager.ts +49 -37
  449. package/front_end/ui/legacy/Widget.ts +32 -12
  450. package/front_end/ui/legacy/components/cookie_table/CookiesTable.ts +2 -3
  451. package/front_end/ui/legacy/components/inline_editor/AnimationTimingUI.ts +8 -8
  452. package/front_end/ui/legacy/components/inline_editor/BezierUI.ts +8 -9
  453. package/front_end/ui/legacy/components/inline_editor/LinkSwatch.ts +2 -2
  454. package/front_end/ui/legacy/components/inline_editor/cssAngleEditor.css +1 -1
  455. package/front_end/ui/legacy/components/inline_editor/cssAngleSwatch.css +1 -1
  456. package/front_end/ui/legacy/components/object_ui/ObjectPropertiesSection.ts +45 -11
  457. package/front_end/ui/legacy/components/object_ui/RemoteObjectPreviewFormatter.ts +10 -12
  458. package/front_end/ui/legacy/components/perf_ui/ChartViewport.ts +102 -29
  459. package/front_end/ui/legacy/components/perf_ui/FlameChart.ts +148 -122
  460. package/front_end/ui/legacy/components/perf_ui/TimelineOverviewPane.ts +20 -14
  461. package/front_end/ui/legacy/components/quick_open/filteredListWidget.css +1 -1
  462. package/front_end/ui/legacy/components/source_frame/FontView.ts +29 -5
  463. package/front_end/ui/legacy/components/source_frame/ImageView.ts +79 -12
  464. package/front_end/ui/legacy/components/source_frame/JSONView.ts +20 -2
  465. package/front_end/ui/legacy/components/source_frame/PreviewFactory.ts +2 -2
  466. package/front_end/ui/legacy/components/source_frame/StreamingContentHexView.ts +6 -10
  467. package/front_end/ui/legacy/components/source_frame/XMLView.ts +11 -11
  468. package/front_end/ui/legacy/components/source_frame/fontView.css +7 -0
  469. package/front_end/ui/legacy/components/source_frame/imageView.css +7 -0
  470. package/front_end/ui/legacy/components/utils/JSPresentationUtils.ts +14 -3
  471. package/front_end/ui/legacy/components/utils/Linkifier.ts +126 -2
  472. package/front_end/ui/legacy/emptyWidget.css +2 -1
  473. package/front_end/ui/legacy/inspectorCommon.css +3 -3
  474. package/front_end/ui/legacy/smallBubble.css +1 -1
  475. package/front_end/ui/legacy/tabbedPane.css +6 -0
  476. package/front_end/ui/lit/Directives.ts +35 -18
  477. package/front_end/ui/lit/lit.ts +0 -2
  478. package/front_end/ui/lit/render.ts +0 -7
  479. package/front_end/ui/visual_logging/KnownContextValues.ts +5 -0
  480. package/package.json +1 -1
  481. package/vpython.toml +8 -0
  482. package/vpython.toml.uv.lock +3 -0
  483. package/.agents/skills/review-models-core/SKILL.md +0 -73
  484. package/.agents/skills/review-tests/SKILL.md +0 -67
  485. package/.agents/skills/review-ui-widgets/SKILL.md +0 -115
  486. package/front_end/generated/ARIAProperties.ts +0 -2686
  487. package/front_end/ui/components/menus/README.md +0 -119
  488. package/front_end/ui/components/menus/SelectMenu.ts +0 -473
  489. package/front_end/ui/components/menus/selectMenu.css +0 -54
  490. package/front_end/ui/components/menus/selectMenuButton.css +0 -108
@@ -80,7 +80,7 @@
80
80
  white-space: normal;
81
81
  }
82
82
 
83
- .ancestor-rule-list devtools-css-query {
83
+ .ancestor-rule-list .css-query {
84
84
  display: block;
85
85
  }
86
86
 
@@ -107,7 +107,7 @@
107
107
  }
108
108
 
109
109
  &.styles-panel-hovered:not(.read-only),
110
- &.styles-panel-hovered:not(.read-only) devtools-css-query {
110
+ &.styles-panel-hovered:not(.read-only) .css-query {
111
111
  --override-styles-section-text-hover-text-decoration: underline;
112
112
  --override-styles-section-text-hover-cursor: default;
113
113
  }
@@ -380,7 +380,7 @@
380
380
  flex: none;
381
381
  width: var(--sys-size-3);
382
382
  height: var(--sys-size-3);
383
- border-radius: 50%;
383
+ border-radius: var(--sys-shape-corner-full);
384
384
  background-color: currentcolor;
385
385
  /* Aligns the bullet's center with the disclosure triangle above. */
386
386
  margin-left: var(--sys-size-2);
@@ -274,7 +274,7 @@ export interface ViewInput {
274
274
  showUserAgentTypeSetting: Common.Settings.Setting<boolean>;
275
275
  }
276
276
 
277
- export type View = (input: ViewInput, output: object, target: HTMLElement|DocumentFragment) => void;
277
+ export type View = (input: ViewInput, output: undefined, target: HTMLElement|DocumentFragment) => void;
278
278
 
279
279
  function createSizeInput(
280
280
  title: string, jslogContext: string, value: string|undefined, disabled: boolean|undefined,
@@ -679,7 +679,7 @@ export class DeviceModeToolbar extends UI.Widget.Widget {
679
679
  showUserAgentTypeSetting: this.showUserAgentTypeSetting,
680
680
  };
681
681
 
682
- this.view(input, {}, this.contentElement);
682
+ this.view(input, undefined, this.contentElement);
683
683
  }
684
684
 
685
685
  private getDevicePostureOptions(): Array<{title: string, value: string, selected: boolean}> {
@@ -40,7 +40,7 @@ export class InspectedPagePlaceholder extends InspectedPagePlaceholderBase {
40
40
  this.setMinimumSize(1, 1);
41
41
  }
42
42
 
43
- private dipPageRect(): {
43
+ #dipPageRect(): {
44
44
  x: number,
45
45
  y: number,
46
46
  width: number,
@@ -65,7 +65,7 @@ export class InspectedPagePlaceholder extends InspectedPagePlaceholderBase {
65
65
  if (!this.element.isConnected) {
66
66
  return;
67
67
  }
68
- const rect = this.dipPageRect();
68
+ const rect = this.#dipPageRect();
69
69
  const bounds = {
70
70
  x: Math.round(rect.x),
71
71
  y: Math.round(rect.y),
@@ -39,7 +39,7 @@ export interface MediaQueryMarker {
39
39
  locations: SDK.CSSModel.CSSLocation[];
40
40
  }
41
41
 
42
- export const DEFAULT_VIEW = (input: ViewInput, _output: object, target: DocumentFragment): void => {
42
+ export const DEFAULT_VIEW = (input: ViewInput, _output: undefined, target: DocumentFragment): void => {
43
43
  const createBarClassMap = (marker: MediaQueryMarker): Record<string, boolean> => ({
44
44
  'media-inspector-bar': true,
45
45
  'media-inspector-marker-inactive': !marker.active,
@@ -168,7 +168,7 @@ export class MediaQueryInspector extends UI.Widget.Widget<ShadowRoot> implements
168
168
  private cachedQueryModels?: MediaQueryUIModel[];
169
169
 
170
170
  constructor(element?: HTMLElement,
171
- view: (input: ViewInput, _output: object, target: DocumentFragment) => void = DEFAULT_VIEW) {
171
+ view: (input: ViewInput, _output: undefined, target: DocumentFragment) => void = DEFAULT_VIEW) {
172
172
  super(element, {useShadowDom: 'pure'});
173
173
  this.view = view;
174
174
  this.#scale = 1;
@@ -399,14 +399,13 @@ export class MediaQueryInspector extends UI.Widget.Widget<ShadowRoot> implements
399
399
  }
400
400
  const markers = Map.groupBy(this.buildMediaQueryMarkers(), marker => marker.model.section());
401
401
 
402
- this.view(
403
- {
404
- zoomFactor: this.zoomFactor(),
405
- markers,
406
- onMediaQueryClicked: this.onMediaQueryClicked.bind(this),
407
- onContextMenu: this.onContextMenu.bind(this),
408
- },
409
- {}, this.contentElement);
402
+ this.view({
403
+ zoomFactor: this.zoomFactor(),
404
+ markers,
405
+ onMediaQueryClicked: this.onMediaQueryClicked.bind(this),
406
+ onContextMenu: this.onContextMenu.bind(this),
407
+ },
408
+ undefined, this.contentElement);
410
409
  }
411
410
  }
412
411
 
@@ -6,7 +6,7 @@
6
6
  /* Media query bars */
7
7
 
8
8
  .media-inspector-view {
9
- height: 50px;
9
+ height: var(--sys-size-16);
10
10
  }
11
11
 
12
12
  .media-inspector-marker-container {
@@ -68,7 +68,7 @@ interface ViewInput {
68
68
  filter?: {showFramework: boolean, showPassive: boolean, showBlocking: boolean};
69
69
  }
70
70
 
71
- type View = (input: ViewInput, output: object, target: HTMLElement) => void;
71
+ type View = (input: ViewInput, output: undefined, target: HTMLElement) => void;
72
72
 
73
73
  export const DEFAULT_VIEW: View = (input, output, target) => {
74
74
  const types = input.listeners.keys().toArray().sort();
@@ -284,7 +284,7 @@ export class EventListenersView extends UI.Widget.VBox {
284
284
  }
285
285
  },
286
286
  };
287
- this.#view(input, {}, this.contentElement);
287
+ this.#view(input, undefined, this.contentElement);
288
288
  this.eventListenersArrivedForTest();
289
289
  }
290
290
 
@@ -1,41 +1,115 @@
1
1
  // Copyright 2021 The Chromium Authors
2
2
  // Use of this source code is governed by a BSD-style license that can be
3
3
  // found in the LICENSE file.
4
- /* eslint-disable @devtools/no-imperative-dom-api */
5
4
 
6
5
  import * as Common from '../../core/common/common.js';
7
6
  import * as Host from '../../core/host/host.js';
8
7
  import * as i18n from '../../core/i18n/i18n.js';
9
8
  import type * as Platform from '../../core/platform/platform.js';
10
9
  import type * as Protocol from '../../generated/protocol.js';
10
+ import type * as IssuesManager from '../../models/issues_manager/issues_manager.js';
11
11
  import * as NetworkForward from '../../panels/network/forward/forward.js';
12
+ import {html, render} from '../../ui/lit/lit.js';
12
13
  import * as VisualLogging from '../../ui/visual_logging/visual_logging.js';
13
14
 
14
15
  import {AffectedItem, AffectedResourcesView} from './AffectedResourcesView.js';
16
+ import type {IssueView} from './IssueView.js';
17
+
18
+ export interface CookieViewItem {
19
+ name: string;
20
+ domainAndPath: string;
21
+ hasRequest: boolean;
22
+ onClick: () => void;
23
+ }
24
+
25
+ export interface CookiesViewInput {
26
+ cookies: CookieViewItem[];
27
+ }
28
+
29
+ export type CookiesView = (input: CookiesViewInput, _output: undefined, target: HTMLElement) => void;
30
+
31
+ export const DEFAULT_VIEW: CookiesView = (input, _output, target) => {
32
+ // clang-format off
33
+ render(html`
34
+ <tr>
35
+ <td class="affected-resource-header">${i18nString(UIStrings.name)}</td>
36
+ <td class="affected-resource-header affected-resource-cookie-info-header">
37
+ ${i18nString(UIStrings.domainAndPath)}
38
+ </td>
39
+ </tr>
40
+ ${input.cookies.map(cookie => html`
41
+ <tr class="affected-resource-cookie" jslog=${VisualLogging.tableRow('affected-cookie')}>
42
+ <td>
43
+ ${cookie.hasRequest ? html`
44
+ <button
45
+ class="link devtools-link"
46
+ tabindex="0"
47
+ jslog=${VisualLogging.link('issues.filter-network-requests-by-cookie').track({click: true})}
48
+ @click=${cookie.onClick}
49
+ >${cookie.name}</button>
50
+ ` : cookie.name}
51
+ </td>
52
+ <td class="affected-resource-cookie-info">${cookie.domainAndPath}</td>
53
+ </tr>
54
+ `)}
55
+ `, target);
56
+ // clang-format on
57
+ };
58
+
59
+ export interface RawCookieLinesViewInput {
60
+ cookieLines: Array<{rawCookieLine: string, hasRequest: boolean}>;
61
+ onRawCookieClick: (rawCookieLine: string) => void;
62
+ }
63
+
64
+ export type RawCookieLinesView = (input: RawCookieLinesViewInput, _output: undefined, target: HTMLElement) => void;
65
+
66
+ export const RAW_COOKIE_LINES_VIEW: RawCookieLinesView = (input, _output, target) => {
67
+ // clang-format off
68
+ render(html`
69
+ ${input.cookieLines.map(cookie => html`
70
+ <tr class="affected-resource-directive" jslog=${VisualLogging.tableRow('affected-raw-cookie')}>
71
+ <td>
72
+ ${cookie.hasRequest ? html`
73
+ <button
74
+ class="link devtools-link"
75
+ title=${i18nString(UIStrings.filterSetCookieTitle)}
76
+ tabindex="0"
77
+ jslog=${VisualLogging.link('issues.filter-network-requests-by-raw-cookie').track({click: true})}
78
+ @click=${() => input.onRawCookieClick(cookie.rawCookieLine)}
79
+ >${cookie.rawCookieLine}</button>
80
+ ` : cookie.rawCookieLine}
81
+ </td>
82
+ </tr>
83
+ `)}
84
+ `, target);
85
+ // clang-format on
86
+ };
15
87
 
16
88
  const UIStrings = {
17
89
  /**
18
- * @description Label in the Issues panel for the number of affected cookies. See https://developer.mozilla.org/en-US/docs/Web/HTTP/Cookies.
90
+ * @description Label in the Issues panel for the number of affected cookies.
91
+ * See https://developer.mozilla.org/en-US/docs/Web/HTTP/Cookies.
19
92
  */
20
93
  nCookies: '{n, plural, =1 {# cookie} other {# cookies}}',
21
94
  /**
22
- * @description Column header in the Issues panel for cookie names in the affected cookies table.
95
+ * @description Column header in the Issues panel for cookie names in the
96
+ * affected cookies table.
23
97
  */
24
98
  name: 'Name',
25
99
  /**
26
- * @description Column header in the Issues panel for cookie domains in the affected cookies table. See https://developer.mozilla.org/en-US/docs/Web/HTTP/Cookies#define_where_cookies_are_sent.
27
- */
28
- domain: 'Domain',
29
- /**
30
- * @description Column header in the Issues panel for cookie paths in the affected cookies table. See https://developer.mozilla.org/en-US/docs/Web/HTTP/Cookies#define_where_cookies_are_sent.
100
+ * @description Column header in the Issues panel for cookie domains and paths
101
+ * in the affected cookies table. See
102
+ * https://developer.mozilla.org/en-US/docs/Web/HTTP/Cookies#define_where_cookies_are_sent.
31
103
  */
32
- path: 'Path',
104
+ domainAndPath: 'Domain & path',
33
105
  /**
34
- * @description Label in the Issues panel for the number of affected raw Set-Cookie headers.
106
+ * @description Label in the Issues panel for the number of affected raw
107
+ * Set-Cookie headers.
35
108
  */
36
109
  nRawCookieLines: '{n, plural, =1 {1 raw `Set-Cookie` header} other {# raw `Set-Cookie` headers}}',
37
110
  /**
38
- * @description Tooltip in the Issues panel for the button to filter network requests by this Set-Cookie header in the Network panel.
111
+ * @description Tooltip in the Issues panel for the button to filter network
112
+ * requests by this Set-Cookie header in the Network panel.
39
113
  */
40
114
  filterSetCookieTitle: 'Show network requests that include this `Set-Cookie` header in the Network panel',
41
115
  } as const;
@@ -43,111 +117,80 @@ const str_ = i18n.i18n.registerUIStrings('panels/issues/AffectedCookiesView.ts',
43
117
  const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
44
118
 
45
119
  export class AffectedCookiesView extends AffectedResourcesView {
46
- protected getResourceNameWithCount(count: number): Platform.UIString.LocalizedString {
47
- return i18nString(UIStrings.nCookies, {n: count});
120
+ readonly #view: CookiesView;
121
+
122
+ constructor(parent: IssueView, issue: IssuesManager.IssueAggregator.AggregatedIssue, jslogContext: string,
123
+ view: CookiesView = DEFAULT_VIEW) {
124
+ super(parent, issue, jslogContext);
125
+ this.#view = view;
48
126
  }
49
127
 
50
- #appendAffectedCookies(cookies: Iterable<{cookie: Protocol.Audits.AffectedCookie, hasRequest: boolean}>): void {
51
- const header = document.createElement('tr');
52
- this.appendColumnTitle(header, i18nString(UIStrings.name));
53
- this.appendColumnTitle(
54
- header, i18nString(UIStrings.domain) + ' & ' + i18nString(UIStrings.path),
55
- 'affected-resource-cookie-info-header');
56
-
57
- this.affectedResources.appendChild(header);
58
-
59
- let count = 0;
60
- for (const cookie of cookies) {
61
- count++;
62
- this.#appendAffectedCookie(cookie.cookie, cookie.hasRequest);
63
- }
64
- this.updateAffectedResourceCount(count);
128
+ protected override getResourceNameWithCount(count: number): Platform.UIString.LocalizedString {
129
+ return i18nString(UIStrings.nCookies, {n: count});
65
130
  }
66
131
 
67
- #appendAffectedCookie(cookie: Protocol.Audits.AffectedCookie, hasAssociatedRequest: boolean): void {
68
- const element = document.createElement('tr');
69
- element.classList.add('affected-resource-cookie');
70
- element.setAttribute('jslog', `${VisualLogging.tableRow('affected-cookie')}`);
71
- const name = document.createElement('td');
72
- if (hasAssociatedRequest) {
73
- const link = document.createElement('button');
74
- link.classList.add('link', 'devtools-link');
75
- link.textContent = cookie.name;
76
- link.tabIndex = 0;
77
- link.setAttribute(
78
- 'jslog', `${VisualLogging.link('issues.filter-network-requests-by-cookie').track({click: true})}`);
79
- link.addEventListener('click', () => {
80
- Host.userMetrics.issuesPanelResourceOpened(this.issue.getCategory(), AffectedItem.COOKIE);
81
- void Common.Revealer.reveal(NetworkForward.UIFilter.UIRequestFilter.filters([
82
- {
83
- filterType: NetworkForward.UIFilter.FilterType.CookieDomain,
84
- filterValue: cookie.domain,
85
- },
86
- {
87
- filterType: NetworkForward.UIFilter.FilterType.CookieName,
88
- filterValue: cookie.name,
89
- },
90
- {
91
- filterType: NetworkForward.UIFilter.FilterType.CookiePath,
92
- filterValue: cookie.path,
93
- },
94
- ]));
95
- });
96
- name.appendChild(link);
97
- } else {
98
- name.textContent = cookie.name;
99
- }
100
- element.appendChild(name);
101
- this.appendIssueDetailCell(element, `${cookie.domain}${cookie.path}`, 'affected-resource-cookie-info');
102
-
103
- this.affectedResources.appendChild(element);
132
+ #appendAffectedCookies(cookies: Iterable<{cookie: Protocol.Audits.AffectedCookie, hasRequest: boolean}>): void {
133
+ const cookieList: CookieViewItem[] = Array.from(
134
+ cookies, ({cookie, hasRequest}) => ({
135
+ name: cookie.name,
136
+ domainAndPath: `${cookie.domain}${cookie.path}`,
137
+ hasRequest,
138
+ onClick: () => {
139
+ Host.userMetrics.issuesPanelResourceOpened(this.issue.getCategory(), AffectedItem.COOKIE);
140
+ void Common.Revealer.reveal(NetworkForward.UIFilter.UIRequestFilter.filters([
141
+ {
142
+ filterType: NetworkForward.UIFilter.FilterType.CookieDomain,
143
+ filterValue: cookie.domain,
144
+ },
145
+ {
146
+ filterType: NetworkForward.UIFilter.FilterType.CookieName,
147
+ filterValue: cookie.name,
148
+ },
149
+ {
150
+ filterType: NetworkForward.UIFilter.FilterType.CookiePath,
151
+ filterValue: cookie.path,
152
+ },
153
+ ]));
154
+ },
155
+ }));
156
+ this.#view({cookies: cookieList}, undefined, this.affectedResources);
157
+ this.updateAffectedResourceCount(cookieList.length);
104
158
  }
105
159
 
106
- update(): void {
107
- this.clear();
160
+ override update(): void {
161
+ this.requestResolver.clear();
108
162
  this.#appendAffectedCookies(this.issue.cookiesWithRequestIndicator());
109
163
  }
110
164
  }
111
165
 
112
166
  export class AffectedRawCookieLinesView extends AffectedResourcesView {
167
+ readonly #view: RawCookieLinesView;
168
+
169
+ constructor(parent: IssueView, issue: IssuesManager.IssueAggregator.AggregatedIssue, jslogContext: string,
170
+ view: RawCookieLinesView = RAW_COOKIE_LINES_VIEW) {
171
+ super(parent, issue, jslogContext);
172
+ this.#view = view;
173
+ }
174
+
113
175
  protected override getResourceNameWithCount(count: number): Platform.UIString.LocalizedString {
114
176
  return i18nString(UIStrings.nRawCookieLines, {n: count});
115
177
  }
116
178
 
117
179
  override update(): void {
118
- this.clear();
119
- const cookieLinesWithRequestIndicator = this.issue.getRawCookieLines();
120
- let count = 0;
121
-
122
- for (const cookie of cookieLinesWithRequestIndicator) {
123
- const row = document.createElement('tr');
124
- row.classList.add('affected-resource-directive');
125
- row.setAttribute('jslog', `${VisualLogging.tableRow('affected-raw-cookie')}`);
126
- if (cookie.hasRequest) {
127
- const cookieLine = document.createElement('td');
128
- const link = document.createElement('button');
129
- link.classList.add('link', 'devtools-link');
130
- link.textContent = cookie.rawCookieLine;
131
- link.title = i18nString(UIStrings.filterSetCookieTitle);
132
- link.tabIndex = 0;
133
- link.setAttribute(
134
- 'jslog', `${VisualLogging.link('issues.filter-network-requests-by-raw-cookie').track({click: true})}`);
135
- link.addEventListener('click', () => {
136
- void Common.Revealer.reveal(NetworkForward.UIFilter.UIRequestFilter.filters([
137
- {
138
- filterType: NetworkForward.UIFilter.FilterType.ResponseHeaderValueSetCookie,
139
- filterValue: cookie.rawCookieLine,
140
- },
141
- ]));
142
- });
143
- cookieLine.appendChild(link);
144
- row.appendChild(cookieLine);
145
- } else {
146
- this.appendIssueDetailCell(row, cookie.rawCookieLine);
147
- }
148
- this.affectedResources.appendChild(row);
149
- count++;
150
- }
151
- this.updateAffectedResourceCount(count);
180
+ this.requestResolver.clear();
181
+ const cookieLines = Array.from(this.issue.getRawCookieLines());
182
+ this.#view({
183
+ cookieLines,
184
+ onRawCookieClick: rawCookieLine => {
185
+ void Common.Revealer.reveal(NetworkForward.UIFilter.UIRequestFilter.filters([
186
+ {
187
+ filterType: NetworkForward.UIFilter.FilterType.ResponseHeaderValueSetCookie,
188
+ filterValue: rawCookieLine,
189
+ },
190
+ ]));
191
+ },
192
+ },
193
+ undefined, this.affectedResources);
194
+ this.updateAffectedResourceCount(cookieLines.length);
152
195
  }
153
196
  }
@@ -1,65 +1,117 @@
1
1
  // Copyright 2025 The Chromium Authors
2
2
  // Use of this source code is governed by a BSD-style license that can be
3
3
  // found in the LICENSE file.
4
- /* eslint-disable @devtools/no-imperative-dom-api */
5
4
 
5
+ import * as Host from '../../core/host/host.js';
6
6
  import * as i18n from '../../core/i18n/i18n.js';
7
7
  import type * as Platform from '../../core/platform/platform.js';
8
+ import * as SDK from '../../core/sdk/sdk.js';
9
+ import type * as Protocol from '../../generated/protocol.js';
8
10
  import type * as IssuesManager from '../../models/issues_manager/issues_manager.js';
11
+ import {html, type LitTemplate, render} from '../../ui/lit/lit.js';
12
+ import * as PanelsCommon from '../common/common.js';
9
13
 
10
14
  import {AffectedElementsView} from './AffectedElementsView.js';
15
+ import {AffectedItem} from './AffectedResourcesView.js';
16
+ import type {IssueView} from './IssueView.js';
17
+
18
+ export interface SelectDescendantRow {
19
+ backendNodeId: Protocol.DOM.BackendNodeId;
20
+ nodeName: string;
21
+ target: SDK.Target.Target|null;
22
+ onElementClick: () => void;
23
+ }
24
+
25
+ export interface ViewInput {
26
+ rows: SelectDescendantRow[];
27
+ }
28
+
29
+ export type View = (input: ViewInput, _output: undefined, target: HTMLElement) => void;
30
+
31
+ export const DEFAULT_VIEW: View = (input, _output, target) => {
32
+ const renderElementCell = (row: SelectDescendantRow): LitTemplate => {
33
+ if (!row.target) {
34
+ return html`<td>${row.nodeName || i18nString(UIStrings.unavailable)}</td>`;
35
+ }
36
+ const deferredDOMNode = new SDK.DOMModel.DeferredDOMNode(row.target, row.backendNodeId);
37
+ // clang-format off
38
+ return html`
39
+ <td class="affected-resource-element devtools-link">
40
+ ${PanelsCommon.DOMLinkifier.Linkifier.instance().linkify(
41
+ deferredDOMNode, {textContent: row.nodeName || undefined, onClick: row.onElementClick})}
42
+ </td>
43
+ `;
44
+ // clang-format on
45
+ };
46
+
47
+ // clang-format off
48
+ render(html`
49
+ ${input.rows.map(row => html`
50
+ <tr class="affected-resource-select-element-descendant">
51
+ ${renderElementCell(row)}
52
+ </tr>
53
+ `)}
54
+ `, target);
55
+ // clang-format on
56
+ };
11
57
 
12
58
  const UIStrings = {
13
59
  /**
14
- * @description Label in the Issues panel for the number of affected descendant nodes.
60
+ * @description Label in the Issues panel for the number of affected
61
+ * descendant nodes.
15
62
  */
16
- nDescendants: '{n, plural, =1 { descendant} other { descendants}}',
63
+ nDescendants: '{n, plural, =1 {# descendant} other {# descendants}}',
17
64
  /**
18
- * @description Link text in the Issues panel for a disallowed descendant node.
65
+ * @description Link text in the Issues panel for a disallowed descendant
66
+ * node.
19
67
  */
20
68
  disallowedNode: 'Disallowed descendant',
69
+ /**
70
+ * @description Fallback text in the Issues panel when an HTML element is
71
+ * unavailable in the affected resources table.
72
+ */
73
+ unavailable: 'Unavailable',
21
74
  } as const;
22
75
  const str_ = i18n.i18n.registerUIStrings('panels/issues/AffectedDescendantsWithinSelectElementView.ts', UIStrings);
23
76
  const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
24
77
 
25
78
  export class AffectedDescendantsWithinSelectElementView extends AffectedElementsView {
26
- #runningUpdatePromise: Promise<void> = Promise.resolve();
79
+ readonly #view: View;
27
80
 
28
- override update(): void {
29
- // Ensure that doUpdate is invoked atomically by serializing the update calls
30
- // because it's not re-entrace safe.
31
- this.#runningUpdatePromise = this.#runningUpdatePromise.then(this.#doUpdate.bind(this));
81
+ constructor(parent: IssueView, issue: IssuesManager.IssueAggregator.AggregatedIssue, jslogContext: string,
82
+ view: View = DEFAULT_VIEW) {
83
+ super(parent, issue, jslogContext);
84
+ this.#view = view;
32
85
  }
33
86
 
34
- protected getResourceName(count: number): Platform.UIString.LocalizedString {
35
- return i18nString(UIStrings.nDescendants, {n: count});
87
+ override update(): void {
88
+ this.requestResolver.clear();
89
+ this.#appendDisallowedSelectDescendants(this.issue.getElementAccessibilityIssues());
36
90
  }
37
91
 
38
- async #doUpdate(): Promise<void> {
39
- this.clear();
40
- await this.#appendDisallowedSelectDescendants(this.issue.getElementAccessibilityIssues());
92
+ protected override getResourceNameWithCount(count: number): Platform.UIString.LocalizedString {
93
+ return i18nString(UIStrings.nDescendants, {n: count});
41
94
  }
42
95
 
43
- async #appendDisallowedSelectDescendant(issue: IssuesManager.ElementAccessibilityIssue.ElementAccessibilityIssue):
44
- Promise<void> {
45
- const row = document.createElement('tr');
46
- row.classList.add('affected-resource-select-element-descendant');
47
-
96
+ #createDisallowedSelectDescendantRow(issue: IssuesManager.ElementAccessibilityIssue.ElementAccessibilityIssue):
97
+ SelectDescendantRow {
48
98
  const details = issue.details();
49
99
  const target = issue.model()?.target() || null;
50
- row.appendChild(await this.createElementCell(
51
- {nodeName: i18nString(UIStrings.disallowedNode), backendNodeId: details.nodeId, target}, issue.getCategory()));
52
-
53
- this.affectedResources.appendChild(row);
100
+ const category = issue.getCategory();
101
+ return {
102
+ nodeName: i18nString(UIStrings.disallowedNode),
103
+ backendNodeId: details.nodeId,
104
+ target,
105
+ onElementClick: () => {
106
+ Host.userMetrics.issuesPanelResourceOpened(category, AffectedItem.ELEMENT);
107
+ },
108
+ };
54
109
  }
55
110
 
56
- async #appendDisallowedSelectDescendants(
57
- issues: Iterable<IssuesManager.ElementAccessibilityIssue.ElementAccessibilityIssue>): Promise<void> {
58
- let count = 0;
59
- for (const issue of issues) {
60
- count++;
61
- await this.#appendDisallowedSelectDescendant(issue);
62
- }
63
- this.updateAffectedResourceCount(count);
111
+ #appendDisallowedSelectDescendants(
112
+ issues: Iterable<IssuesManager.ElementAccessibilityIssue.ElementAccessibilityIssue>): void {
113
+ const rows = Array.from(issues, issue => this.#createDisallowedSelectDescendantRow(issue));
114
+ this.#view({rows}, undefined, this.affectedResources);
115
+ this.updateAffectedResourceCount(rows.length);
64
116
  }
65
117
  }