chrome-devtools-frontend 1.0.1726686 → 1.0.1730971

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (490) hide show
  1. package/.agents/rules/tests/test-strict-assertions-and-literal-expectations.md +1 -1
  2. package/.agents/rules/tests/test-view-and-presenter-isolation.md +1 -1
  3. package/.agents/rules/ui-and-widgets/ui-accessibility-and-semantic-html.md +1 -1
  4. package/.agents/rules/ui-and-widgets/ui-css-scoping-and-flex-layout.md +2 -2
  5. package/.agents/rules/ui-and-widgets/ui-declarative-child-widget-composition.md +5 -5
  6. package/.agents/rules/ui-and-widgets/ui-lit-declarative-templates-and-directives.md +2 -2
  7. package/.agents/rules/ui-and-widgets/ui-localization-and-uistrings-hygiene.md +2 -2
  8. package/.agents/rules/ui-and-widgets/ui-modern-component-and-encapsulation-standards.md +3 -3
  9. package/.agents/rules/ui-and-widgets/ui-pure-view-and-presenter-separation.md +2 -2
  10. package/.agents/rules/ui-and-widgets/ui-reactive-widget-update-lifecycle.md +2 -2
  11. package/.agents/rules/ui-and-widgets/ui-view-output-and-callback-contracts.md +2 -2
  12. package/.agents/rules/ui-and-widgets/ui-widget-dom-and-listener-lifecycle.md +2 -2
  13. package/.agents/skills/code-review/SKILL.md +63 -12
  14. package/.agents/skills/ui-eng-vision-local-lit-renderer/SKILL.md +38 -10
  15. package/.agents/skills/ui-eng-vision-widget-promoter/SKILL.md +1 -0
  16. package/.agents/skills/ui-widgets/SKILL.md +8 -2
  17. package/.agents/skills/write-ai-eval-test/SKILL.md +106 -0
  18. package/AUTHORS +2 -0
  19. package/DIR_METADATA +1 -2
  20. package/README.md +48 -26
  21. package/config/typescript/tsconfig.base.json +1 -0
  22. package/config/typescript/tsconfig.eslint.json +1 -0
  23. package/docs/contributing/changes.md +25 -0
  24. package/docs/ui_engineering.md +13 -4
  25. package/eslint.config.mjs +323 -41
  26. package/front_end/core/common/Color.ts +7 -7
  27. package/front_end/core/common/ParsedURL.ts +3 -3
  28. package/front_end/core/common/ResolverBase.ts +3 -3
  29. package/front_end/core/common/SegmentedRange.ts +3 -3
  30. package/front_end/core/common/SimpleHistoryManager.ts +14 -14
  31. package/front_end/core/common/Trie.ts +3 -3
  32. package/front_end/core/common/VersionController.ts +7 -7
  33. package/front_end/core/host/InspectorFrontendHost.ts +2 -2
  34. package/front_end/core/host/InspectorFrontendHostAPI.ts +9 -1
  35. package/front_end/core/host/InspectorFrontendHostStub.ts +1 -1
  36. package/front_end/core/host/UserMetrics.ts +4 -0
  37. package/front_end/core/host/UserMetricsEnums.ts +2 -1
  38. package/front_end/core/platform/StringUtilities.ts +54 -13
  39. package/front_end/core/platform/node/HostRuntime.ts +13 -7
  40. package/front_end/core/protocol_client/DevToolsCDPConnection.ts +4 -5
  41. package/front_end/core/root/Runtime.ts +5 -0
  42. package/front_end/core/sdk/AccessibilityModel.ts +5 -5
  43. package/front_end/core/sdk/AnimationModel.ts +17 -19
  44. package/front_end/core/sdk/CPUProfilerModel.ts +3 -3
  45. package/front_end/core/sdk/CPUThrottlingManager.ts +7 -0
  46. package/front_end/core/sdk/CSSMatchedStyles.ts +73 -13
  47. package/front_end/core/sdk/CSSMetadata.ts +7 -7
  48. package/front_end/core/sdk/CSSModel.ts +33 -33
  49. package/front_end/core/sdk/CSSProperty.ts +5 -5
  50. package/front_end/core/sdk/CSSRule.ts +6 -6
  51. package/front_end/core/sdk/CSSStyleSheetHeader.ts +4 -4
  52. package/front_end/core/sdk/Connections.ts +16 -16
  53. package/front_end/core/sdk/ConsoleModel.ts +44 -47
  54. package/front_end/core/sdk/CookieParser.ts +11 -11
  55. package/front_end/core/sdk/EmulationModel.ts +35 -36
  56. package/front_end/core/sdk/EventBreakpointsModel.ts +11 -11
  57. package/front_end/core/sdk/FrameManager.ts +16 -16
  58. package/front_end/core/sdk/IsolateManager.ts +2 -2
  59. package/front_end/core/sdk/IssuesModel.ts +2 -2
  60. package/front_end/core/sdk/OverlayModel.ts +19 -19
  61. package/front_end/core/sdk/PageResourceLoader.ts +14 -16
  62. package/front_end/core/sdk/RemoteObject.ts +9 -9
  63. package/front_end/core/sdk/Resource.ts +2 -2
  64. package/front_end/core/sdk/RuntimeModel.ts +7 -7
  65. package/front_end/core/sdk/Script.ts +6 -6
  66. package/front_end/core/sdk/ServiceWorkerManager.ts +36 -10
  67. package/front_end/core/sdk/SourceMap.ts +18 -20
  68. package/front_end/core/sdk/SourceMapManager.ts +2 -2
  69. package/front_end/core/sdk/TargetManager.ts +2 -2
  70. package/front_end/devtools_compatibility.js +7 -3
  71. package/front_end/entrypoints/inspector_main/InspectorMain.ts +2 -2
  72. package/front_end/entrypoints/node_app/app/NodeConnectionsPanel.ts +203 -115
  73. package/front_end/generated/InspectorBackendCommands.ts +1 -1
  74. package/front_end/generated/SupportedCSSProperties.ts +1 -3
  75. package/front_end/generated/protocol.ts +1 -0
  76. package/front_end/models/ai_assistance/AiAgent2.ts +36 -12
  77. package/front_end/models/ai_assistance/AiConversation.ts +8 -2
  78. package/front_end/models/ai_assistance/agents/AiAgent.ts +137 -62
  79. package/front_end/models/ai_assistance/agents/ExecuteJavascript.ts +2 -2
  80. package/front_end/models/ai_assistance/agents/StylingAgent.snapshot.txt +2 -2
  81. package/front_end/models/ai_assistance/data_formatters/LighthouseFormatter.snapshot.txt +149 -2
  82. package/front_end/models/ai_assistance/data_formatters/LighthouseFormatter.ts +269 -42
  83. package/front_end/models/ai_assistance/tools/ExecuteJavaScript.ts +3 -0
  84. package/front_end/models/ai_assistance/tools/GetLighthouseAudits.ts +9 -0
  85. package/front_end/models/ai_assistance/tools/ResolveDevtoolsNodePath.ts +13 -2
  86. package/front_end/models/ai_assistance/tools/RunLighthouse.ts +23 -7
  87. package/front_end/models/ai_assistance/tools/Tool.ts +7 -5
  88. package/front_end/models/bindings/CSSWorkspaceBinding.ts +22 -24
  89. package/front_end/models/bindings/DebuggerLanguagePlugins.ts +60 -60
  90. package/front_end/models/bindings/DebuggerWorkspaceBinding.ts +24 -24
  91. package/front_end/models/bindings/DefaultScriptMapping.ts +8 -8
  92. package/front_end/models/bindings/FileUtils.ts +13 -13
  93. package/front_end/models/bindings/PresentationConsoleMessageHelper.ts +3 -3
  94. package/front_end/models/bindings/ResourceScriptMapping.ts +23 -23
  95. package/front_end/models/comment_manager/CommentManager.ts +3 -3
  96. package/front_end/models/comment_manager/CommentThread.ts +50 -5
  97. package/front_end/models/cpu_profile/CPUProfileDataModel.ts +14 -14
  98. package/front_end/models/cpu_profile/ProfileTreeModel.ts +4 -4
  99. package/front_end/models/elements/StyleChanges.ts +38 -0
  100. package/front_end/models/emulation/EmulatedDevices.ts +12 -12
  101. package/front_end/models/har/HARFormat.ts +4 -4
  102. package/front_end/models/javascript_metadata/NativeFunctions.ts +5 -1
  103. package/front_end/models/lighthouse/LighthouseReporterTypes.ts +57 -3
  104. package/front_end/models/lighthouse/RunTypes.ts +9 -1
  105. package/front_end/models/logs/LogManager.ts +2 -2
  106. package/front_end/models/persistence/AutomaticFileSystemManager.ts +3 -0
  107. package/front_end/models/persistence/FileSystemWorkspaceBinding.ts +24 -24
  108. package/front_end/models/persistence/IsolatedFileSystemManager.ts +6 -0
  109. package/front_end/models/persistence/NetworkPersistenceManager.ts +8 -3
  110. package/front_end/models/trace/LanternComputationData.ts +37 -11
  111. package/front_end/models/trace/Processor.ts +2 -1
  112. package/front_end/models/trace/extras/TraceTree.ts +36 -10
  113. package/front_end/models/trace/handlers/InitiatorsHandler.ts +27 -34
  114. package/front_end/models/trace/handlers/LayoutShiftsHandler.ts +2 -6
  115. package/front_end/models/trace/handlers/SamplesHandler.ts +9 -6
  116. package/front_end/models/workspace/FileManager.ts +6 -0
  117. package/front_end/panels/accessibility/ARIAAttributesView.ts +4 -4
  118. package/front_end/panels/accessibility/AccessibilityAnnouncementRecordingView.ts +8 -1
  119. package/front_end/panels/accessibility/AccessibilityNodeView.ts +15 -17
  120. package/front_end/panels/accessibility/AccessibilitySubPane.ts +1 -1
  121. package/front_end/panels/ai_assistance/AiAssistancePanel.ts +5 -5
  122. package/front_end/panels/ai_assistance/ExternalHandler.ts +10 -1
  123. package/front_end/panels/ai_assistance/components/ChatMessage.ts +27 -22
  124. package/front_end/panels/ai_assistance/components/DisabledWidget.ts +19 -23
  125. package/front_end/panels/ai_assistance/components/ExploreWidget.ts +2 -2
  126. package/front_end/panels/ai_assistance/components/PermissionPrompt.ts +23 -9
  127. package/front_end/panels/ai_assistance/components/chatInput.css +1 -1
  128. package/front_end/panels/animation/AnimationTimeline.ts +37 -17
  129. package/front_end/panels/animation/animationTimeline.css +19 -3
  130. package/front_end/panels/application/AppManifestView.ts +1 -2
  131. package/front_end/panels/application/ApplicationPanelSidebar.ts +143 -128
  132. package/front_end/panels/application/DOMStorageItemsView.ts +14 -14
  133. package/front_end/panels/application/DeviceBoundSessionsView.ts +10 -13
  134. package/front_end/panels/application/ExtensionStorageItemsView.ts +3 -4
  135. package/front_end/panels/application/IndexedDBViews.ts +8 -4
  136. package/front_end/panels/application/KeyValueStorageItemsView.ts +4 -5
  137. package/front_end/panels/application/PrivateVerificationTokensView.ts +53 -0
  138. package/front_end/panels/application/ServiceWorkerCacheViews.ts +12 -8
  139. package/front_end/panels/application/ServiceWorkersView.ts +1 -2
  140. package/front_end/panels/application/StorageItemsToolbar.ts +3 -3
  141. package/front_end/panels/application/StorageView.ts +2 -2
  142. package/front_end/panels/application/WebMCPView.ts +91 -109
  143. package/front_end/panels/application/application.ts +2 -0
  144. package/front_end/panels/application/components/StorageMetadataView.ts +6 -6
  145. package/front_end/panels/application/preloading/PreloadingView.ts +70 -37
  146. package/front_end/panels/application/preloading/components/MismatchedPreloadingGrid.ts +2 -2
  147. package/front_end/panels/application/preloading/components/PreloadingDisabledInfobar.ts +3 -3
  148. package/front_end/panels/application/preloading/components/PreloadingGrid.ts +12 -0
  149. package/front_end/panels/application/preloading/components/RuleSetDetailsView.ts +10 -11
  150. package/front_end/panels/application/privateVerificationTokensView.css +20 -0
  151. package/front_end/panels/application/serviceWorkersView.css +2 -2
  152. package/front_end/panels/browser_debugger/DOMBreakpointsSidebarPane.ts +24 -24
  153. package/front_end/panels/changes/ChangesSidebar.ts +5 -5
  154. package/front_end/panels/changes/ChangesView.ts +10 -11
  155. package/front_end/panels/comments/CommentsPane.ts +292 -102
  156. package/front_end/panels/comments/commentsPane.css +93 -12
  157. package/front_end/panels/common/CommentThreadWidget.ts +69 -0
  158. package/front_end/panels/common/CommentsOverlayWidget.ts +108 -29
  159. package/front_end/panels/common/CommentsStatusBarPill.ts +17 -6
  160. package/front_end/panels/common/DOMLinkifier.ts +37 -12
  161. package/front_end/panels/common/ExtensionPanel.ts +13 -4
  162. package/front_end/panels/common/ExtensionServer.ts +27 -3
  163. package/front_end/panels/common/PersistenceUtils.ts +3 -3
  164. package/front_end/panels/common/commentThreadWidget.css +25 -1
  165. package/front_end/panels/common/common-meta.ts +10 -0
  166. package/front_end/panels/console/ConsolePinPane.ts +13 -15
  167. package/front_end/panels/console/ConsolePrompt.ts +173 -95
  168. package/front_end/panels/console/ConsoleSidebar.ts +2 -2
  169. package/front_end/panels/console/ConsoleView.ts +75 -79
  170. package/front_end/panels/console/ConsoleViewMessage.ts +52 -4
  171. package/front_end/panels/console/SymbolizedErrorWidget.ts +8 -4
  172. package/front_end/panels/console/consolePrompt.css +1 -1
  173. package/front_end/panels/console/consoleView.css +1 -1
  174. package/front_end/panels/console_counters/WarningErrorCounter.ts +3 -4
  175. package/front_end/panels/coverage/CoverageListView.ts +2 -2
  176. package/front_end/panels/coverage/CoverageView.ts +20 -5
  177. package/front_end/panels/css_overview/CSSOverviewCompletedView.ts +4 -3
  178. package/front_end/panels/css_overview/CSSOverviewPanel.ts +2 -2
  179. package/front_end/panels/css_overview/CSSOverviewProcessingView.ts +2 -2
  180. package/front_end/panels/css_overview/CSSOverviewSidebarPanel.ts +2 -2
  181. package/front_end/panels/css_overview/CSSOverviewStartView.ts +2 -2
  182. package/front_end/panels/css_overview/CSSOverviewUnusedDeclarations.ts +8 -8
  183. package/front_end/panels/developer_resources/DeveloperResourcesListView.ts +2 -3
  184. package/front_end/panels/developer_resources/DeveloperResourcesView.ts +4 -5
  185. package/front_end/panels/elements/AccessibilityTreeUtils.ts +6 -7
  186. package/front_end/panels/elements/CSSValueTraceView.ts +3 -3
  187. package/front_end/panels/elements/ClassesPaneWidget.ts +1 -2
  188. package/front_end/panels/elements/ComputedStyleWidget.ts +15 -14
  189. package/front_end/panels/elements/DOMTreeElementWidget.ts +5 -4
  190. package/front_end/panels/elements/DOMTreeWidget.ts +2 -1
  191. package/front_end/panels/elements/ElementStatePaneWidget.ts +2 -2
  192. package/front_end/panels/elements/ElementsPanel.ts +1 -0
  193. package/front_end/panels/elements/EventListenersWidget.ts +2 -2
  194. package/front_end/panels/elements/LayoutPane.ts +2 -2
  195. package/front_end/panels/elements/PlatformFontsWidget.ts +3 -3
  196. package/front_end/panels/elements/PropertiesWidget.ts +9 -10
  197. package/front_end/panels/elements/PropertyRenderer.ts +72 -11
  198. package/front_end/panels/elements/StandaloneStylesContainer.ts +5 -10
  199. package/front_end/panels/elements/StyleEditorWidget.ts +30 -16
  200. package/front_end/panels/elements/StylePropertiesSection.ts +93 -44
  201. package/front_end/panels/elements/StylePropertyTreeElement.ts +230 -302
  202. package/front_end/panels/elements/StylesContainer.ts +2 -3
  203. package/front_end/panels/elements/StylesSidebarPane.ts +4 -13
  204. package/front_end/panels/elements/components/AccessibilityTreeNode.ts +66 -37
  205. package/front_end/panels/elements/components/CSSHintDetailsView.ts +51 -41
  206. package/front_end/panels/elements/components/CSSPropertyDocsView.ts +75 -65
  207. package/front_end/panels/elements/components/CSSQuery.ts +112 -74
  208. package/front_end/panels/elements/components/CSSVariableValueView.ts +109 -68
  209. package/front_end/panels/elements/components/ComputedStyleProperty.ts +64 -45
  210. package/front_end/panels/elements/components/ElementsTreeExpandButton.ts +35 -28
  211. package/front_end/panels/elements/components/QueryContainer.ts +104 -74
  212. package/front_end/panels/elements/components/accessibilityTreeNode.css +22 -20
  213. package/front_end/panels/elements/components/computedStyleProperty.css +2 -0
  214. package/front_end/panels/elements/components/cssHintDetailsView.css +23 -21
  215. package/front_end/panels/elements/components/cssPropertyDocsView.css +38 -36
  216. package/front_end/panels/elements/components/cssVariableValueView.css +42 -40
  217. package/front_end/panels/elements/components/elementsTreeExpandButton.css +5 -2
  218. package/front_end/panels/elements/components/queryContainer.css +23 -21
  219. package/front_end/panels/elements/stylesSidebarPane.css +3 -3
  220. package/front_end/panels/emulation/DeviceModeToolbar.ts +2 -2
  221. package/front_end/panels/emulation/InspectedPagePlaceholder.ts +2 -2
  222. package/front_end/panels/emulation/MediaQueryInspector.ts +9 -10
  223. package/front_end/panels/emulation/mediaQueryInspector.css +1 -1
  224. package/front_end/panels/event_listeners/EventListenersView.ts +2 -2
  225. package/front_end/panels/issues/AffectedCookiesView.ts +144 -101
  226. package/front_end/panels/issues/AffectedDescendantsWithinSelectElementView.ts +83 -31
  227. package/front_end/panels/issues/AffectedDirectivesView.ts +218 -135
  228. package/front_end/panels/issues/AffectedDocumentsInQuirksModeView.ts +84 -34
  229. package/front_end/panels/issues/AffectedElementsView.ts +86 -23
  230. package/front_end/panels/issues/AffectedLazyLoadImagesView.ts +2 -2
  231. package/front_end/panels/issues/AffectedMetadataAllowedSitesView.ts +2 -2
  232. package/front_end/panels/issues/AffectedPartitioningBlobURLView.ts +36 -11
  233. package/front_end/panels/issues/AffectedSharedArrayBufferIssueDetailsView.ts +135 -58
  234. package/front_end/panels/issues/AffectedSourcesView.ts +49 -28
  235. package/front_end/panels/issues/AffectedTrackingSitesView.ts +3 -4
  236. package/front_end/panels/issues/CorsIssueDetailsView.ts +490 -269
  237. package/front_end/panels/issues/GenericIssueDetailsView.ts +2 -2
  238. package/front_end/panels/issues/IssueKindView.ts +63 -48
  239. package/front_end/panels/issues/IssueView.ts +14 -18
  240. package/front_end/panels/issues/components/ElementsPanelLink.ts +70 -34
  241. package/front_end/panels/issues/components/HideIssuesMenu.ts +56 -32
  242. package/front_end/panels/issues/components/elementsPanelLink.css +10 -6
  243. package/front_end/panels/issues/components/hideIssuesMenu.css +16 -14
  244. package/front_end/panels/issues/issues.ts +2 -0
  245. package/front_end/panels/issues/issuesTree.css +4 -4
  246. package/front_end/panels/lighthouse/LighthouseController.ts +6 -6
  247. package/front_end/panels/lighthouse/LighthouseStatusView.ts +12 -13
  248. package/front_end/panels/lighthouse/lighthouseStartView.css +1 -1
  249. package/front_end/panels/linear_memory_inspector/LinearMemoryInspectorPane.ts +159 -161
  250. package/front_end/panels/linear_memory_inspector/LinearMemoryInspectorView.ts +228 -0
  251. package/front_end/panels/linear_memory_inspector/components/LinearMemoryInspector.ts +32 -41
  252. package/front_end/panels/linear_memory_inspector/components/linearMemoryHighlightChipList.css +2 -2
  253. package/front_end/panels/linear_memory_inspector/linear_memory_inspector.ts +2 -0
  254. package/front_end/panels/media/EventDisplayTable.ts +2 -2
  255. package/front_end/panels/media/MainView.ts +132 -66
  256. package/front_end/panels/media/PlayerDetailView.ts +32 -14
  257. package/front_end/panels/media/PlayerListView.ts +83 -23
  258. package/front_end/panels/media/PlayerPropertiesView.ts +2 -2
  259. package/front_end/panels/media/TickingFlameChart.ts +153 -63
  260. package/front_end/panels/mobile_throttling/NetworkThrottlingSelector.ts +2 -2
  261. package/front_end/panels/mobile_throttling/ThrottlingSettingsTab.ts +615 -464
  262. package/front_end/panels/mobile_throttling/throttlingSettingsTab.css +43 -0
  263. package/front_end/panels/network/EventSourceMessagesView.ts +3 -3
  264. package/front_end/panels/network/NetworkConfigView.ts +6 -2
  265. package/front_end/panels/network/NetworkDataGridNode.ts +2 -1
  266. package/front_end/panels/network/NetworkItemView.ts +27 -26
  267. package/front_end/panels/network/NetworkManageCustomHeadersView.ts +236 -97
  268. package/front_end/panels/network/NetworkOverview.ts +8 -10
  269. package/front_end/panels/network/RequestConditionsDrawer.ts +8 -4
  270. package/front_end/panels/network/RequestDeviceBoundSessionsView.ts +2 -4
  271. package/front_end/panels/network/RequestHTMLView.ts +26 -7
  272. package/front_end/panels/network/RequestHeadersView.ts +2 -2
  273. package/front_end/panels/network/RequestInitiatorView.ts +21 -22
  274. package/front_end/panels/network/RequestPayloadView.ts +2 -16
  275. package/front_end/panels/network/RequestPreviewView.ts +5 -5
  276. package/front_end/panels/network/RequestTimingView.ts +6 -6
  277. package/front_end/panels/network/ResourceDirectSocketChunkView.ts +5 -6
  278. package/front_end/panels/network/ResourceWebSocketFrameView.ts +4 -3
  279. package/front_end/panels/network/ShowMoreDetailsWidget.ts +11 -12
  280. package/front_end/panels/network/SignedExchangeInfoView.ts +2 -2
  281. package/front_end/panels/network/networkLogView.css +2 -2
  282. package/front_end/panels/network/networkManageCustomHeadersView.css +27 -6
  283. package/front_end/panels/network/requestConditionsDrawer.css +1 -1
  284. package/front_end/panels/network/requestInitiatorView.css +5 -3
  285. package/front_end/panels/performance_monitor/PerformanceMonitor.ts +2 -2
  286. package/front_end/panels/profiler/HeapDetachedElementsView.ts +1 -2
  287. package/front_end/panels/profiler/HeapTimelineOverview.ts +77 -15
  288. package/front_end/panels/profiler/IsolateSelector.ts +258 -187
  289. package/front_end/panels/profiler/ProfileLauncherView.ts +7 -29
  290. package/front_end/panels/profiler/profileLauncherView.css +6 -1
  291. package/front_end/panels/protocol_monitor/JSONEditor.ts +4 -5
  292. package/front_end/panels/recorder/ControlButton.ts +1 -1
  293. package/front_end/panels/recorder/RecordingListView.ts +2 -4
  294. package/front_end/panels/recorder/RecordingView.ts +1 -2
  295. package/front_end/panels/recorder/SelectorPicker.ts +2 -4
  296. package/front_end/panels/recorder/StepView.ts +24 -10
  297. package/front_end/panels/recorder/TimelineSection.ts +1 -1
  298. package/front_end/panels/recorder/recordingView.css +1 -1
  299. package/front_end/panels/screencast/ScreencastApp.ts +1 -1
  300. package/front_end/panels/search/SearchResultsPane.ts +11 -12
  301. package/front_end/panels/search/SearchView.ts +8 -10
  302. package/front_end/panels/security/SecurityPanel.ts +1 -8
  303. package/front_end/panels/security/SecurityPanelSidebar.ts +2 -2
  304. package/front_end/panels/security/mainView.css +1 -1
  305. package/front_end/panels/sensors/LocationsSettingsTab.ts +1 -2
  306. package/front_end/panels/settings/AISettingsTab.ts +1 -1
  307. package/front_end/panels/settings/BackendLinkingSettingsTab.ts +34 -20
  308. package/front_end/panels/settings/EditFileSystemView.ts +2 -2
  309. package/front_end/panels/settings/FrameworkIgnoreListSettingsTab.ts +375 -197
  310. package/front_end/panels/settings/KeybindsSettingsTab.ts +570 -414
  311. package/front_end/panels/settings/SettingsScreen.ts +312 -114
  312. package/front_end/panels/settings/WorkspaceSettingsTab.ts +2 -2
  313. package/front_end/panels/settings/aiSettingsTab.css +1 -4
  314. package/front_end/panels/settings/emulation/DevicesSettingsTab.ts +924 -578
  315. package/front_end/panels/settings/emulation/components/UserAgentClientHintsForm.ts +9 -2
  316. package/front_end/panels/settings/emulation/devicesSettingsTab.css +39 -0
  317. package/front_end/panels/settings/frameworkIgnoreListSettingsTab.css +37 -8
  318. package/front_end/panels/settings/settingsScreen.css +0 -24
  319. package/front_end/panels/sources/BreakpointEditDialog.ts +9 -6
  320. package/front_end/panels/sources/BreakpointsView.ts +25 -4
  321. package/front_end/panels/sources/CallStackSidebarPane.ts +7 -1
  322. package/front_end/panels/sources/DebuggerPlugin.ts +1 -0
  323. package/front_end/panels/sources/GoToLineQuickOpen.ts +8 -8
  324. package/front_end/panels/sources/NavigatorView.ts +521 -439
  325. package/front_end/panels/sources/PersistenceActions.ts +11 -12
  326. package/front_end/panels/sources/ProfilePlugin.ts +28 -17
  327. package/front_end/panels/sources/ScopeChainSidebarPane.ts +3 -4
  328. package/front_end/panels/sources/SourcesNavigator.ts +9 -9
  329. package/front_end/panels/sources/SourcesPanel.ts +2 -2
  330. package/front_end/panels/sources/SourcesView.ts +3 -3
  331. package/front_end/panels/sources/ThreadsSidebarPane.ts +2 -2
  332. package/front_end/panels/sources/WatchExpressionsSidebarPane.ts +2 -2
  333. package/front_end/panels/sources/components/HeadersView.ts +1 -2
  334. package/front_end/panels/timeline/CompatibilityTracksAppender.ts +5 -6
  335. package/front_end/panels/timeline/EventsTimelineTreeView.ts +73 -34
  336. package/front_end/panels/timeline/IsolateSelector.ts +25 -37
  337. package/front_end/panels/timeline/StatusDialog.ts +5 -7
  338. package/front_end/panels/timeline/ThirdPartyTreeView.ts +10 -13
  339. package/front_end/panels/timeline/TimelineDetailsView.ts +40 -21
  340. package/front_end/panels/timeline/TimelineEventOverview.ts +130 -34
  341. package/front_end/panels/timeline/TimelineFlameChartNetworkDataProvider.ts +1 -1
  342. package/front_end/panels/timeline/TimelineMiniMap.ts +255 -103
  343. package/front_end/panels/timeline/TimelinePaintProfilerView.ts +19 -11
  344. package/front_end/panels/timeline/TimelinePanel.ts +1 -0
  345. package/front_end/panels/timeline/TimelineSelectorStatsView.ts +11 -12
  346. package/front_end/panels/timeline/TimelineTreeView.ts +240 -122
  347. package/front_end/panels/timeline/TimelineUIUtils.ts +12 -0
  348. package/front_end/panels/timeline/components/BreadcrumbsUI.ts +5 -4
  349. package/front_end/panels/timeline/components/DetailsView.ts +97 -65
  350. package/front_end/panels/timeline/components/LayoutShiftDetails.ts +2 -2
  351. package/front_end/panels/timeline/components/MetricCard.ts +2 -2
  352. package/front_end/panels/timeline/components/NetworkRequestDetails.ts +11 -12
  353. package/front_end/panels/timeline/components/NetworkTrackWidget.ts +57 -50
  354. package/front_end/panels/timeline/components/RelatedInsightChips.ts +2 -2
  355. package/front_end/panels/timeline/components/Sidebar.ts +161 -109
  356. package/front_end/panels/timeline/components/SidebarAnnotationsTab.ts +33 -12
  357. package/front_end/panels/timeline/components/SidebarInsightsTab.ts +3 -0
  358. package/front_end/panels/timeline/components/insights/LCPDiscovery.ts +11 -11
  359. package/front_end/panels/timeline/components/insights/SlowCSSSelector.ts +6 -7
  360. package/front_end/panels/timeline/components/networkTrackWidget.css +24 -22
  361. package/front_end/panels/timeline/components/sidebarInsightsTab.css +1 -1
  362. package/front_end/panels/timeline/overlays/components/TimespanBreakdownOverlay.ts +15 -10
  363. package/front_end/panels/timeline/overlays/components/entryLabelOverlay.css +1 -1
  364. package/front_end/panels/timeline/timelinePanel.css +5 -0
  365. package/front_end/panels/timeline/timelineStatusDialog.css +1 -1
  366. package/front_end/panels/web_audio/WebAudioView.ts +2 -2
  367. package/front_end/third_party/chromium/README.chromium +1 -1
  368. package/front_end/third_party/legacy-javascript/README.chromium +2 -2
  369. package/front_end/third_party/legacy-javascript/lib/legacy-javascript.js +2 -2
  370. package/front_end/third_party/legacy-javascript/package.json +1 -1
  371. package/front_end/third_party/lighthouse/README.chromium +2 -2
  372. package/front_end/third_party/lighthouse/lighthouse-dt-bundle.js +1983 -2022
  373. package/front_end/third_party/lighthouse/locales/ar-XB.json +157 -142
  374. package/front_end/third_party/lighthouse/locales/ar.json +157 -142
  375. package/front_end/third_party/lighthouse/locales/bg.json +154 -139
  376. package/front_end/third_party/lighthouse/locales/ca.json +157 -142
  377. package/front_end/third_party/lighthouse/locales/cs.json +148 -133
  378. package/front_end/third_party/lighthouse/locales/da.json +153 -138
  379. package/front_end/third_party/lighthouse/locales/de.json +152 -137
  380. package/front_end/third_party/lighthouse/locales/el.json +153 -138
  381. package/front_end/third_party/lighthouse/locales/en-GB.json +160 -145
  382. package/front_end/third_party/lighthouse/locales/en-US.json +239 -218
  383. package/front_end/third_party/lighthouse/locales/en-XL.json +239 -218
  384. package/front_end/third_party/lighthouse/locales/es-419.json +150 -135
  385. package/front_end/third_party/lighthouse/locales/es.json +149 -134
  386. package/front_end/third_party/lighthouse/locales/fi.json +151 -136
  387. package/front_end/third_party/lighthouse/locales/fil.json +154 -139
  388. package/front_end/third_party/lighthouse/locales/fr.json +150 -135
  389. package/front_end/third_party/lighthouse/locales/he.json +160 -145
  390. package/front_end/third_party/lighthouse/locales/hi.json +156 -141
  391. package/front_end/third_party/lighthouse/locales/hr.json +154 -139
  392. package/front_end/third_party/lighthouse/locales/hu.json +111 -96
  393. package/front_end/third_party/lighthouse/locales/id.json +153 -138
  394. package/front_end/third_party/lighthouse/locales/it.json +153 -138
  395. package/front_end/third_party/lighthouse/locales/ja.json +150 -135
  396. package/front_end/third_party/lighthouse/locales/ko.json +42 -27
  397. package/front_end/third_party/lighthouse/locales/lt.json +152 -137
  398. package/front_end/third_party/lighthouse/locales/lv.json +93 -78
  399. package/front_end/third_party/lighthouse/locales/nl.json +149 -134
  400. package/front_end/third_party/lighthouse/locales/no.json +152 -137
  401. package/front_end/third_party/lighthouse/locales/pl.json +153 -138
  402. package/front_end/third_party/lighthouse/locales/pt-PT.json +152 -137
  403. package/front_end/third_party/lighthouse/locales/pt.json +157 -142
  404. package/front_end/third_party/lighthouse/locales/ro.json +149 -134
  405. package/front_end/third_party/lighthouse/locales/ru.json +76 -61
  406. package/front_end/third_party/lighthouse/locales/sk.json +153 -138
  407. package/front_end/third_party/lighthouse/locales/sl.json +149 -134
  408. package/front_end/third_party/lighthouse/locales/sr-Latn.json +151 -136
  409. package/front_end/third_party/lighthouse/locales/sr.json +151 -136
  410. package/front_end/third_party/lighthouse/locales/sv.json +152 -137
  411. package/front_end/third_party/lighthouse/locales/ta.json +156 -141
  412. package/front_end/third_party/lighthouse/locales/te.json +157 -142
  413. package/front_end/third_party/lighthouse/locales/th.json +111 -96
  414. package/front_end/third_party/lighthouse/locales/tr.json +153 -138
  415. package/front_end/third_party/lighthouse/locales/uk.json +149 -134
  416. package/front_end/third_party/lighthouse/locales/vi.json +162 -147
  417. package/front_end/third_party/lighthouse/locales/zh-HK.json +150 -135
  418. package/front_end/third_party/lighthouse/locales/zh-TW.json +154 -139
  419. package/front_end/third_party/lighthouse/locales/zh.json +152 -137
  420. package/front_end/third_party/lighthouse/report/bundle.d.ts +9 -8
  421. package/front_end/third_party/lighthouse/report/bundle.js +10 -10
  422. package/front_end/third_party/lighthouse/report-assets/report-generator.mjs +2 -7
  423. package/front_end/tsconfig.compatibility.json +1 -0
  424. package/front_end/tsconfig.json +3 -2
  425. package/front_end/ui/components/dialogs/TypeToAllowDialog.ts +0 -2
  426. package/front_end/ui/components/dialogs/typeToAllowDialog.css +0 -4
  427. package/front_end/ui/components/icon_button/fileSourceIcon.css +1 -1
  428. package/front_end/ui/components/input/textInput.css +1 -1
  429. package/front_end/ui/components/lists/List.ts +26 -14
  430. package/front_end/ui/components/menus/menus.ts +0 -2
  431. package/front_end/ui/components/suggestion_input/SuggestionInput.ts +351 -138
  432. package/front_end/ui/components/survey_link/surveyLink.css +3 -3
  433. package/front_end/ui/components/switch/switch.css +6 -6
  434. package/front_end/ui/components/text_editor/AiCodeCompletionTeaser.ts +2 -3
  435. package/front_end/ui/components/text_editor/TextEditor.ts +1 -1
  436. package/front_end/ui/components/tooltips/Tooltip.ts +53 -4
  437. package/front_end/ui/components/tree_outline/treeOutline.css +7 -7
  438. package/front_end/ui/helpers/OpenInNewTab.ts +8 -3
  439. package/front_end/ui/legacy/EmptyWidget.ts +4 -4
  440. package/front_end/ui/legacy/ForwardedInputEventHandler.ts +2 -2
  441. package/front_end/ui/legacy/GlassPane.ts +1 -1
  442. package/front_end/ui/legacy/KeyboardShortcut.ts +7 -7
  443. package/front_end/ui/legacy/RemoteDebuggingTerminatedScreen.ts +2 -2
  444. package/front_end/ui/legacy/TabbedPane.ts +198 -66
  445. package/front_end/ui/legacy/TargetCrashedScreen.ts +2 -2
  446. package/front_end/ui/legacy/UIUtils.ts +71 -68
  447. package/front_end/ui/legacy/View.ts +7 -4
  448. package/front_end/ui/legacy/ViewManager.ts +49 -37
  449. package/front_end/ui/legacy/Widget.ts +32 -12
  450. package/front_end/ui/legacy/components/cookie_table/CookiesTable.ts +2 -3
  451. package/front_end/ui/legacy/components/inline_editor/AnimationTimingUI.ts +8 -8
  452. package/front_end/ui/legacy/components/inline_editor/BezierUI.ts +8 -9
  453. package/front_end/ui/legacy/components/inline_editor/LinkSwatch.ts +2 -2
  454. package/front_end/ui/legacy/components/inline_editor/cssAngleEditor.css +1 -1
  455. package/front_end/ui/legacy/components/inline_editor/cssAngleSwatch.css +1 -1
  456. package/front_end/ui/legacy/components/object_ui/ObjectPropertiesSection.ts +45 -11
  457. package/front_end/ui/legacy/components/object_ui/RemoteObjectPreviewFormatter.ts +10 -12
  458. package/front_end/ui/legacy/components/perf_ui/ChartViewport.ts +102 -29
  459. package/front_end/ui/legacy/components/perf_ui/FlameChart.ts +148 -122
  460. package/front_end/ui/legacy/components/perf_ui/TimelineOverviewPane.ts +20 -14
  461. package/front_end/ui/legacy/components/quick_open/filteredListWidget.css +1 -1
  462. package/front_end/ui/legacy/components/source_frame/FontView.ts +29 -5
  463. package/front_end/ui/legacy/components/source_frame/ImageView.ts +79 -12
  464. package/front_end/ui/legacy/components/source_frame/JSONView.ts +20 -2
  465. package/front_end/ui/legacy/components/source_frame/PreviewFactory.ts +2 -2
  466. package/front_end/ui/legacy/components/source_frame/StreamingContentHexView.ts +6 -10
  467. package/front_end/ui/legacy/components/source_frame/XMLView.ts +11 -11
  468. package/front_end/ui/legacy/components/source_frame/fontView.css +7 -0
  469. package/front_end/ui/legacy/components/source_frame/imageView.css +7 -0
  470. package/front_end/ui/legacy/components/utils/JSPresentationUtils.ts +14 -3
  471. package/front_end/ui/legacy/components/utils/Linkifier.ts +126 -2
  472. package/front_end/ui/legacy/emptyWidget.css +2 -1
  473. package/front_end/ui/legacy/inspectorCommon.css +3 -3
  474. package/front_end/ui/legacy/smallBubble.css +1 -1
  475. package/front_end/ui/legacy/tabbedPane.css +6 -0
  476. package/front_end/ui/lit/Directives.ts +35 -18
  477. package/front_end/ui/lit/lit.ts +0 -2
  478. package/front_end/ui/lit/render.ts +0 -7
  479. package/front_end/ui/visual_logging/KnownContextValues.ts +5 -0
  480. package/package.json +1 -1
  481. package/vpython.toml +8 -0
  482. package/vpython.toml.uv.lock +3 -0
  483. package/.agents/skills/review-models-core/SKILL.md +0 -73
  484. package/.agents/skills/review-tests/SKILL.md +0 -67
  485. package/.agents/skills/review-ui-widgets/SKILL.md +0 -115
  486. package/front_end/generated/ARIAProperties.ts +0 -2686
  487. package/front_end/ui/components/menus/README.md +0 -119
  488. package/front_end/ui/components/menus/SelectMenu.ts +0 -473
  489. package/front_end/ui/components/menus/selectMenu.css +0 -54
  490. package/front_end/ui/components/menus/selectMenuButton.css +0 -108
@@ -36,9 +36,8 @@ export interface StylesContainer {
36
36
  forceUpdate(): void;
37
37
  hideAllPopovers(): void;
38
38
 
39
- getVariablePopoverContents(
40
- matchedStyles: SDK.CSSMatchedStyles.CSSMatchedStyles, variableName: string,
41
- computedValue: string|null): ElementsComponents.CSSVariableValueView.CSSVariableValueView;
39
+ getRegisteredPropertyDetails(matchedStyles: SDK.CSSMatchedStyles.CSSMatchedStyles, variableName: string):
40
+ ElementsComponents.CSSVariableValueView.RegisteredPropertyDetails|undefined;
42
41
  getVariableParserError(matchedStyles: SDK.CSSMatchedStyles.CSSMatchedStyles, variableName: string):
43
42
  ElementsComponents.CSSVariableValueView.CSSVariableParserError|null;
44
43
  jumpToFunctionDefinition(functionName: string, treeScopeDistance: number): void;
@@ -714,7 +714,7 @@ export class StylesSidebarPane extends StylesSidebarPaneBase implements StylesCo
714
714
  });
715
715
  }
716
716
 
717
- #getRegisteredPropertyDetails(matchedStyles: SDK.CSSMatchedStyles.CSSMatchedStyles, variableName: string):
717
+ getRegisteredPropertyDetails(matchedStyles: SDK.CSSMatchedStyles.CSSMatchedStyles, variableName: string):
718
718
  ElementsComponents.CSSVariableValueView.RegisteredPropertyDetails|undefined {
719
719
  const registration = matchedStyles.getRegisteredProperty(variableName);
720
720
  const goToDefinition = (): void => this.jumpToSection(variableName, REGISTERED_PROPERTY_SECTION_NAME);
@@ -723,21 +723,12 @@ export class StylesSidebarPane extends StylesSidebarPaneBase implements StylesCo
723
723
 
724
724
  getVariableParserError(matchedStyles: SDK.CSSMatchedStyles.CSSMatchedStyles,
725
725
  variableName: string): ElementsComponents.CSSVariableValueView.CSSVariableParserError|null {
726
- const registrationDetails = this.#getRegisteredPropertyDetails(matchedStyles, variableName);
726
+ const registrationDetails = this.getRegisteredPropertyDetails(matchedStyles, variableName);
727
727
  return registrationDetails ?
728
728
  new ElementsComponents.CSSVariableValueView.CSSVariableParserError(registrationDetails) :
729
729
  null;
730
730
  }
731
731
 
732
- getVariablePopoverContents(matchedStyles: SDK.CSSMatchedStyles.CSSMatchedStyles, variableName: string,
733
- computedValue: string|null): ElementsComponents.CSSVariableValueView.CSSVariableValueView {
734
- return new ElementsComponents.CSSVariableValueView.CSSVariableValueView({
735
- variableName,
736
- value: computedValue ?? undefined,
737
- details: this.#getRegisteredPropertyDetails(matchedStyles, variableName),
738
- });
739
- }
740
-
741
732
  private async fetchComputedStylesFor(nodeId: Protocol.DOM.NodeId|undefined): Promise<Map<string, string>|null> {
742
733
  const node = this.node();
743
734
  if (node === null || nodeId === undefined) {
@@ -1105,8 +1096,8 @@ export class StylesSidebarPane extends StylesSidebarPaneBase implements StylesCo
1105
1096
  this.hasMatchedStyles = matchedStyles !== null && node !== null;
1106
1097
  if (!this.hasMatchedStyles) {
1107
1098
  this.sectionBlocks = [];
1108
- this.sectionsContainer.contentElement.removeChildren();
1109
1099
  this.sectionsContainer.detachChildWidgets();
1100
+ this.sectionsContainer.contentElement.removeChildren();
1110
1101
  this.noMatchesElement.classList.remove('hidden');
1111
1102
  return;
1112
1103
  }
@@ -1134,8 +1125,8 @@ export class StylesSidebarPane extends StylesSidebarPaneBase implements StylesCo
1134
1125
  }
1135
1126
  }
1136
1127
 
1137
- this.sectionsContainer.contentElement.removeChildren();
1138
1128
  this.sectionsContainer.detachChildWidgets();
1129
+ this.sectionsContainer.contentElement.removeChildren();
1139
1130
  const fragment = document.createDocumentFragment();
1140
1131
 
1141
1132
  let index = 0;
@@ -1,13 +1,11 @@
1
1
  // Copyright 2021 The Chromium Authors
2
2
  // Use of this source code is governed by a BSD-style license that can be
3
3
  // found in the LICENSE file.
4
- /* eslint-disable @devtools/no-lit-render-outside-of-view */
5
4
 
6
5
  import * as i18n from '../../../core/i18n/i18n.js';
7
6
  import * as Platform from '../../../core/platform/platform.js';
8
7
  import * as SDK from '../../../core/sdk/sdk.js';
9
8
  import type * as Protocol from '../../../generated/protocol.js';
10
- import * as RenderCoordinator from '../../../ui/components/render_coordinator/render_coordinator.js';
11
9
  import * as UI from '../../../ui/legacy/legacy.js';
12
10
  import {html, nothing, render} from '../../../ui/lit/lit.js';
13
11
 
@@ -35,57 +33,88 @@ function truncateTextIfNeeded(text: string): string {
35
33
  return text;
36
34
  }
37
35
 
38
- export interface AccessibilityTreeNodeData {
36
+ export interface ViewInput {
39
37
  ignored: boolean;
40
38
  name: string;
41
39
  role: string;
42
40
  properties: Protocol.Accessibility.AXProperty[];
43
- id: string;
44
41
  }
45
42
 
46
- export class AccessibilityTreeNode extends HTMLElement {
47
- readonly #shadow = UI.UIUtils.createShadowRootWithCoreStyles(this, {cssFile: accessibilityTreeNodeStyles});
43
+ export type View = (input: ViewInput, output: undefined, target: HTMLElement) => void;
48
44
 
45
+ export const DEFAULT_VIEW: View = (input, _output, target) => {
46
+ const role = html`<span class='role-value'>${truncateTextIfNeeded(input.role)}</span>`;
47
+ const name = html`"<span class='attribute-value'>${input.name}</span>"`;
48
+ const properties = input.properties.map(
49
+ ({name, value}) => SDK.AccessibilityModel.isPrintableType(value.type) ?
50
+ html` <span class='attribute-name'>${name}</span>:&nbsp;<span class='attribute-value'>${value.value}</span>` :
51
+ nothing);
52
+ const content =
53
+ input.ignored ? html`<span>${i18nString(UIStrings.ignored)}</span>` : html`${role}&nbsp;${name}${properties}`;
54
+ // clang-format off
55
+ render(
56
+ html`
57
+ <style>${accessibilityTreeNodeStyles}</style>
58
+ <div class='container'>${content}</div>
59
+ `,
60
+ target);
61
+ // clang-format on
62
+ };
63
+
64
+ export class AccessibilityTreeNode extends UI.Widget.Widget {
49
65
  #ignored = true;
50
66
  #name = '';
51
67
  #role = '';
52
68
  #properties: Protocol.Accessibility.AXProperty[] = [];
53
- #id = '';
69
+ readonly #view: View;
54
70
 
55
- set data(data: AccessibilityTreeNodeData) {
56
- this.#ignored = data.ignored;
57
- this.#name = data.name;
58
- this.#role = data.role;
59
- this.#properties = data.properties;
60
- this.#id = data.id;
61
- void this.#render();
71
+ constructor(element?: HTMLElement, view: View = DEFAULT_VIEW) {
72
+ super(element);
73
+ this.#view = view;
62
74
  }
63
75
 
64
- async #render(): Promise<void> {
65
- const role = html`<span class='role-value'>${truncateTextIfNeeded(this.#role)}</span>`;
66
- const name = html`"<span class='attribute-value'>${this.#name}</span>"`;
67
- const properties =
68
- this.#properties.map(({name, value}) => SDK.AccessibilityModel.isPrintableType(value.type) ?
69
- html` <span class='attribute-name'>${
70
- name}</span>:&nbsp;<span class='attribute-value'>${value.value}</span>` :
71
- nothing);
72
- const content =
73
- this.#ignored ? html`<span>${i18nString(UIStrings.ignored)}</span>` : html`${role}&nbsp;${name}${properties}`;
74
- await RenderCoordinator.write(`Accessibility node ${this.#id} render`, () => {
75
- // clang-format off
76
- render(
77
- html`<div class='container'>${content}</div>`,
78
- this.#shadow,
79
- {host: this});
80
- // clang-format on
81
- });
76
+ set ignored(ignored: boolean) {
77
+ if (this.#ignored === ignored) {
78
+ return;
79
+ }
80
+ this.#ignored = ignored;
81
+ this.requestUpdate();
82
+ }
83
+
84
+ set name(name: string) {
85
+ if (this.#name === name) {
86
+ return;
87
+ }
88
+ this.#name = name;
89
+ this.requestUpdate();
82
90
  }
83
- }
84
91
 
85
- customElements.define('devtools-accessibility-tree-node', AccessibilityTreeNode);
92
+ set role(role: string) {
93
+ if (this.#role === role) {
94
+ return;
95
+ }
96
+ this.#role = role;
97
+ this.requestUpdate();
98
+ }
99
+
100
+ set properties(properties: Protocol.Accessibility.AXProperty[]) {
101
+ if (this.#properties === properties) {
102
+ return;
103
+ }
104
+ this.#properties = properties;
105
+ this.requestUpdate();
106
+ }
86
107
 
87
- declare global {
88
- interface HTMLElementTagNameMap {
89
- 'devtools-accessibility-tree-node': AccessibilityTreeNode;
108
+ override performUpdate(): void {
109
+ this.#view(
110
+ {
111
+ ignored: this.#ignored,
112
+ name: this.#name,
113
+ role: this.#role,
114
+ properties: this.#properties,
115
+ },
116
+ undefined,
117
+ this.contentElement,
118
+ );
90
119
  }
91
120
  }
@@ -1,12 +1,10 @@
1
1
  // Copyright 2022 The Chromium Authors
2
2
  // Use of this source code is governed by a BSD-style license that can be
3
3
  // found in the LICENSE file.
4
- /* eslint-disable @devtools/no-lit-render-outside-of-view */
5
-
6
4
  import '../../../ui/kit/kit.js';
7
- import '../../../ui/legacy/legacy.js';
8
5
 
9
6
  import * as i18n from '../../../core/i18n/i18n.js';
7
+ import * as UI from '../../../ui/legacy/legacy.js';
10
8
  import {html, type LitTemplate, render} from '../../../ui/lit/lit.js';
11
9
 
12
10
  import cssHintDetailsViewStyles from './cssHintDetailsView.css.js';
@@ -26,49 +24,61 @@ interface Hint {
26
24
  getLearnMoreLink(): string|undefined;
27
25
  }
28
26
 
29
- export class CSSHintDetailsView extends HTMLElement {
30
- readonly #shadow = this.attachShadow({mode: 'open'});
31
- readonly #authoringHint: Hint;
27
+ export interface ViewInput {
28
+ authoringHint?: Hint;
29
+ }
32
30
 
33
- constructor(authoringHint: Hint) {
34
- super();
35
- this.#authoringHint = authoringHint;
36
- this.#render();
37
- }
31
+ export type View = (input: ViewInput, output: undefined, target: HTMLElement) => void;
38
32
 
39
- #render(): void {
40
- const link = this.#authoringHint.getLearnMoreLink();
41
- // clang-format off
42
- render(html`
43
- <style>${cssHintDetailsViewStyles}</style>
44
- <div class="hint-popup-wrapper">
45
- <div class="hint-popup-reason">
46
- ${this.#authoringHint.getMessage()}
33
+ export const DEFAULT_VIEW: View = (input, _output, target) => {
34
+ if (!input.authoringHint) {
35
+ return;
36
+ }
37
+ const link = input.authoringHint.getLearnMoreLink();
38
+ // clang-format off
39
+ render(html`
40
+ <style>${cssHintDetailsViewStyles}</style>
41
+ <div class="hint-popup-wrapper">
42
+ <div class="hint-popup-reason">
43
+ ${input.authoringHint.getMessage()}
44
+ </div>
45
+ ${input.authoringHint.getPossibleFixMessage() ? html`
46
+ <div class="hint-popup-possible-fix">
47
+ ${input.authoringHint.getPossibleFixMessage()}
47
48
  </div>
48
- ${this.#authoringHint.getPossibleFixMessage() ? html`
49
- <div class="hint-popup-possible-fix">
50
- ${this.#authoringHint.getPossibleFixMessage()}
51
- </div>
52
- ` : ''}
53
- ${link ? html`
54
- <div class="footer">
55
- <devtools-link id="learn-more" href=${link} class="clickable underlined unbreakable-text">
56
- ${i18nString(UIStrings.learnMore)}
57
- </devtools-link>
58
- </div>
59
- `: ''}
60
- </div>
61
- `, this.#shadow, {
62
- host: this,
63
- });
64
- // clang-format on
49
+ ` : ''}
50
+ ${link ? html`
51
+ <div class="footer">
52
+ <devtools-link id="learn-more" href=${link} class="clickable underlined unbreakable-text">
53
+ ${i18nString(UIStrings.learnMore)}
54
+ </devtools-link>
55
+ </div>
56
+ `: ''}
57
+ </div>
58
+ `, target, {container: {classes: ['css-hint-details-view']}});
59
+ // clang-format on
60
+ };
61
+
62
+ export class CSSHintDetailsView extends UI.Widget.Widget {
63
+ #authoringHint?: Hint;
64
+ readonly #view: View;
65
+
66
+ constructor(authoringHint?: Hint, element?: HTMLElement, view: View = DEFAULT_VIEW) {
67
+ super(element);
68
+ this.#authoringHint = authoringHint;
69
+ this.#view = view;
70
+ this.performUpdate();
65
71
  }
66
- }
67
72
 
68
- customElements.define('devtools-css-hint-details-view', CSSHintDetailsView);
73
+ set authoringHint(authoringHint: Hint) {
74
+ if (this.#authoringHint === authoringHint) {
75
+ return;
76
+ }
77
+ this.#authoringHint = authoringHint;
78
+ this.requestUpdate();
79
+ }
69
80
 
70
- declare global {
71
- interface HTMLElementTagNameMap {
72
- 'devtools-css-hint-details-view': CSSHintDetailsView;
81
+ override performUpdate(): void {
82
+ this.#view({authoringHint: this.#authoringHint}, undefined, this.contentElement);
73
83
  }
74
84
  }
@@ -1,14 +1,13 @@
1
1
  // Copyright 2023 The Chromium Authors
2
2
  // Use of this source code is governed by a BSD-style license that can be
3
3
  // found in the LICENSE file.
4
- /* eslint-disable @devtools/no-lit-render-outside-of-view */
5
4
 
6
5
  import '../../../ui/kit/kit.js';
7
- import '../../../ui/legacy/legacy.js';
8
6
 
9
7
  import * as Common from '../../../core/common/common.js';
10
8
  import * as i18n from '../../../core/i18n/i18n.js';
11
9
  import type * as Platform from '../../../core/platform/platform.js';
10
+ import * as UI from '../../../ui/legacy/legacy.js';
12
11
  import {html, nothing, render} from '../../../ui/lit/lit.js';
13
12
  import * as SettingsUI from '../../../ui/settings/settings.js';
14
13
  import * as VisualLogging from '../../../ui/visual_logging/visual_logging.js';
@@ -207,77 +206,88 @@ export interface CSSProperty {
207
206
  }>;
208
207
  }
209
208
 
210
- export class CSSPropertyDocsView extends HTMLElement {
211
- readonly #shadow = this.attachShadow({mode: 'open'});
209
+ export interface ViewInput {
210
+ cssProperty: CSSProperty;
211
+ onDontShowChanged: (showDocumentation: boolean) => void;
212
+ }
213
+
214
+ export type View = (input: ViewInput, output: undefined, target: HTMLElement) => void;
215
+
216
+ export const DEFAULT_VIEW: View = (input, _output, target) => {
217
+ const {description, references, baseline, browsers} = input.cssProperty;
218
+ const link = references?.[0].url;
219
+
220
+ // Disabled until https://crbug.com/1079231 is fixed.
221
+ // clang-format off
222
+ render(html`
223
+ <style>${CSSPropertyDocsViewStyles}</style>
224
+ <div class="docs-popup-wrapper">
225
+ ${description ? html`
226
+ <div id="description">
227
+ ${description}
228
+ </div>
229
+ ` : nothing}
230
+ ${baseline ? html`
231
+ <div id="baseline" class="docs-popup-section">
232
+ <img
233
+ id="baseline-icon"
234
+ src=${getBaselineIconPath(baseline)}
235
+ role="presentation"
236
+ >
237
+ <span>
238
+ ${getBaselineText(baseline, browsers)}
239
+ </span>
240
+ </div>
241
+ ` : nothing}
242
+ ${link ? html`
243
+ <div class="docs-popup-section footer">
244
+ <devtools-link
245
+ id="learn-more"
246
+ href=${link}
247
+ class="clickable underlined unbreakable-text"
248
+ >
249
+ ${i18nString(UIStrings.learnMore)}
250
+ </devtools-link>
251
+ <devtools-checkbox
252
+ @change=${(e: Event) => {
253
+ const showDocumentation = !(e.target as HTMLInputElement).checked;
254
+ input.onDontShowChanged(showDocumentation);
255
+ }}
256
+ jslog=${VisualLogging.toggle('css-property-doc').track({ change: true })}>
257
+ ${i18nString(UIStrings.dontShow)}
258
+ </devtools-checkbox>
259
+ </div>
260
+ ` : nothing}
261
+ </div>
262
+ `, target, {container: {classes: ['css-property-docs-view']}});
263
+ // clang-format on
264
+ };
265
+
266
+ export class CSSPropertyDocsView extends UI.Widget.Widget {
212
267
  readonly #cssProperty: CSSProperty;
268
+ readonly #view: View;
213
269
 
214
- constructor(cssProperty: CSSProperty) {
215
- super();
270
+ constructor(cssProperty: CSSProperty, element?: HTMLElement, view: View = DEFAULT_VIEW) {
271
+ super(element);
216
272
  this.#cssProperty = cssProperty;
217
- this.#render();
273
+ this.#view = view;
274
+ this.performUpdate();
218
275
  }
219
276
 
220
- #dontShowChanged(e: Event): void {
221
- const showDocumentation = !(e.target as HTMLInputElement).checked;
277
+ #dontShowChanged = (showDocumentation: boolean): void => {
222
278
  Common.Settings.Settings.instance()
223
279
  .resolve(SettingsUI.ElementsSettings.showCSSPropertyDocumentationOnHoverSettingDescriptor)
224
280
  .set(showDocumentation);
225
- }
226
-
227
- #render(): void {
228
- const {description, references, baseline, browsers} = this.#cssProperty;
229
- const link = references?.[0].url;
230
-
231
- // Disabled until https://crbug.com/1079231 is fixed.
232
- // clang-format off
233
- render(html`
234
- <style>${CSSPropertyDocsViewStyles}</style>
235
- <div class="docs-popup-wrapper">
236
- ${description ? html`
237
- <div id="description">
238
- ${description}
239
- </div>
240
- ` : nothing}
241
- ${baseline ? html`
242
- <div id="baseline" class="docs-popup-section">
243
- <img
244
- id="baseline-icon"
245
- src=${getBaselineIconPath(baseline)}
246
- role="presentation"
247
- >
248
- <span>
249
- ${getBaselineText(baseline, browsers)}
250
- </span>
251
- </div>
252
- ` : nothing}
253
- ${link ? html`
254
- <div class="docs-popup-section footer">
255
- <devtools-link
256
- id="learn-more"
257
- href=${link}
258
- class="clickable underlined unbreakable-text"
259
- >
260
- ${i18nString(UIStrings.learnMore)}
261
- </devtools-link>
262
- <devtools-checkbox
263
- @change=${this.#dontShowChanged}
264
- jslog=${VisualLogging.toggle('css-property-doc').track({ change: true })}>
265
- ${i18nString(UIStrings.dontShow)}
266
- </devtools-checkbox>
267
- </div>
268
- ` : nothing}
269
- </div>
270
- `, this.#shadow, {
271
- host: this,
272
- });
273
- // clang-format on
274
- }
275
- }
276
-
277
- customElements.define('devtools-css-property-docs-view', CSSPropertyDocsView);
281
+ };
278
282
 
279
- declare global {
280
- interface HTMLElementTagNameMap {
281
- 'devtools-css-property-docs-view': CSSPropertyDocsView;
283
+ override performUpdate(): void {
284
+ this.#view(
285
+ {
286
+ cssProperty: this.#cssProperty,
287
+ onDontShowChanged: this.#dontShowChanged,
288
+ },
289
+ undefined,
290
+ this.contentElement,
291
+ );
282
292
  }
283
293
  }