chrome-devtools-frontend 1.0.1726686 → 1.0.1730971

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (490) hide show
  1. package/.agents/rules/tests/test-strict-assertions-and-literal-expectations.md +1 -1
  2. package/.agents/rules/tests/test-view-and-presenter-isolation.md +1 -1
  3. package/.agents/rules/ui-and-widgets/ui-accessibility-and-semantic-html.md +1 -1
  4. package/.agents/rules/ui-and-widgets/ui-css-scoping-and-flex-layout.md +2 -2
  5. package/.agents/rules/ui-and-widgets/ui-declarative-child-widget-composition.md +5 -5
  6. package/.agents/rules/ui-and-widgets/ui-lit-declarative-templates-and-directives.md +2 -2
  7. package/.agents/rules/ui-and-widgets/ui-localization-and-uistrings-hygiene.md +2 -2
  8. package/.agents/rules/ui-and-widgets/ui-modern-component-and-encapsulation-standards.md +3 -3
  9. package/.agents/rules/ui-and-widgets/ui-pure-view-and-presenter-separation.md +2 -2
  10. package/.agents/rules/ui-and-widgets/ui-reactive-widget-update-lifecycle.md +2 -2
  11. package/.agents/rules/ui-and-widgets/ui-view-output-and-callback-contracts.md +2 -2
  12. package/.agents/rules/ui-and-widgets/ui-widget-dom-and-listener-lifecycle.md +2 -2
  13. package/.agents/skills/code-review/SKILL.md +63 -12
  14. package/.agents/skills/ui-eng-vision-local-lit-renderer/SKILL.md +38 -10
  15. package/.agents/skills/ui-eng-vision-widget-promoter/SKILL.md +1 -0
  16. package/.agents/skills/ui-widgets/SKILL.md +8 -2
  17. package/.agents/skills/write-ai-eval-test/SKILL.md +106 -0
  18. package/AUTHORS +2 -0
  19. package/DIR_METADATA +1 -2
  20. package/README.md +48 -26
  21. package/config/typescript/tsconfig.base.json +1 -0
  22. package/config/typescript/tsconfig.eslint.json +1 -0
  23. package/docs/contributing/changes.md +25 -0
  24. package/docs/ui_engineering.md +13 -4
  25. package/eslint.config.mjs +323 -41
  26. package/front_end/core/common/Color.ts +7 -7
  27. package/front_end/core/common/ParsedURL.ts +3 -3
  28. package/front_end/core/common/ResolverBase.ts +3 -3
  29. package/front_end/core/common/SegmentedRange.ts +3 -3
  30. package/front_end/core/common/SimpleHistoryManager.ts +14 -14
  31. package/front_end/core/common/Trie.ts +3 -3
  32. package/front_end/core/common/VersionController.ts +7 -7
  33. package/front_end/core/host/InspectorFrontendHost.ts +2 -2
  34. package/front_end/core/host/InspectorFrontendHostAPI.ts +9 -1
  35. package/front_end/core/host/InspectorFrontendHostStub.ts +1 -1
  36. package/front_end/core/host/UserMetrics.ts +4 -0
  37. package/front_end/core/host/UserMetricsEnums.ts +2 -1
  38. package/front_end/core/platform/StringUtilities.ts +54 -13
  39. package/front_end/core/platform/node/HostRuntime.ts +13 -7
  40. package/front_end/core/protocol_client/DevToolsCDPConnection.ts +4 -5
  41. package/front_end/core/root/Runtime.ts +5 -0
  42. package/front_end/core/sdk/AccessibilityModel.ts +5 -5
  43. package/front_end/core/sdk/AnimationModel.ts +17 -19
  44. package/front_end/core/sdk/CPUProfilerModel.ts +3 -3
  45. package/front_end/core/sdk/CPUThrottlingManager.ts +7 -0
  46. package/front_end/core/sdk/CSSMatchedStyles.ts +73 -13
  47. package/front_end/core/sdk/CSSMetadata.ts +7 -7
  48. package/front_end/core/sdk/CSSModel.ts +33 -33
  49. package/front_end/core/sdk/CSSProperty.ts +5 -5
  50. package/front_end/core/sdk/CSSRule.ts +6 -6
  51. package/front_end/core/sdk/CSSStyleSheetHeader.ts +4 -4
  52. package/front_end/core/sdk/Connections.ts +16 -16
  53. package/front_end/core/sdk/ConsoleModel.ts +44 -47
  54. package/front_end/core/sdk/CookieParser.ts +11 -11
  55. package/front_end/core/sdk/EmulationModel.ts +35 -36
  56. package/front_end/core/sdk/EventBreakpointsModel.ts +11 -11
  57. package/front_end/core/sdk/FrameManager.ts +16 -16
  58. package/front_end/core/sdk/IsolateManager.ts +2 -2
  59. package/front_end/core/sdk/IssuesModel.ts +2 -2
  60. package/front_end/core/sdk/OverlayModel.ts +19 -19
  61. package/front_end/core/sdk/PageResourceLoader.ts +14 -16
  62. package/front_end/core/sdk/RemoteObject.ts +9 -9
  63. package/front_end/core/sdk/Resource.ts +2 -2
  64. package/front_end/core/sdk/RuntimeModel.ts +7 -7
  65. package/front_end/core/sdk/Script.ts +6 -6
  66. package/front_end/core/sdk/ServiceWorkerManager.ts +36 -10
  67. package/front_end/core/sdk/SourceMap.ts +18 -20
  68. package/front_end/core/sdk/SourceMapManager.ts +2 -2
  69. package/front_end/core/sdk/TargetManager.ts +2 -2
  70. package/front_end/devtools_compatibility.js +7 -3
  71. package/front_end/entrypoints/inspector_main/InspectorMain.ts +2 -2
  72. package/front_end/entrypoints/node_app/app/NodeConnectionsPanel.ts +203 -115
  73. package/front_end/generated/InspectorBackendCommands.ts +1 -1
  74. package/front_end/generated/SupportedCSSProperties.ts +1 -3
  75. package/front_end/generated/protocol.ts +1 -0
  76. package/front_end/models/ai_assistance/AiAgent2.ts +36 -12
  77. package/front_end/models/ai_assistance/AiConversation.ts +8 -2
  78. package/front_end/models/ai_assistance/agents/AiAgent.ts +137 -62
  79. package/front_end/models/ai_assistance/agents/ExecuteJavascript.ts +2 -2
  80. package/front_end/models/ai_assistance/agents/StylingAgent.snapshot.txt +2 -2
  81. package/front_end/models/ai_assistance/data_formatters/LighthouseFormatter.snapshot.txt +149 -2
  82. package/front_end/models/ai_assistance/data_formatters/LighthouseFormatter.ts +269 -42
  83. package/front_end/models/ai_assistance/tools/ExecuteJavaScript.ts +3 -0
  84. package/front_end/models/ai_assistance/tools/GetLighthouseAudits.ts +9 -0
  85. package/front_end/models/ai_assistance/tools/ResolveDevtoolsNodePath.ts +13 -2
  86. package/front_end/models/ai_assistance/tools/RunLighthouse.ts +23 -7
  87. package/front_end/models/ai_assistance/tools/Tool.ts +7 -5
  88. package/front_end/models/bindings/CSSWorkspaceBinding.ts +22 -24
  89. package/front_end/models/bindings/DebuggerLanguagePlugins.ts +60 -60
  90. package/front_end/models/bindings/DebuggerWorkspaceBinding.ts +24 -24
  91. package/front_end/models/bindings/DefaultScriptMapping.ts +8 -8
  92. package/front_end/models/bindings/FileUtils.ts +13 -13
  93. package/front_end/models/bindings/PresentationConsoleMessageHelper.ts +3 -3
  94. package/front_end/models/bindings/ResourceScriptMapping.ts +23 -23
  95. package/front_end/models/comment_manager/CommentManager.ts +3 -3
  96. package/front_end/models/comment_manager/CommentThread.ts +50 -5
  97. package/front_end/models/cpu_profile/CPUProfileDataModel.ts +14 -14
  98. package/front_end/models/cpu_profile/ProfileTreeModel.ts +4 -4
  99. package/front_end/models/elements/StyleChanges.ts +38 -0
  100. package/front_end/models/emulation/EmulatedDevices.ts +12 -12
  101. package/front_end/models/har/HARFormat.ts +4 -4
  102. package/front_end/models/javascript_metadata/NativeFunctions.ts +5 -1
  103. package/front_end/models/lighthouse/LighthouseReporterTypes.ts +57 -3
  104. package/front_end/models/lighthouse/RunTypes.ts +9 -1
  105. package/front_end/models/logs/LogManager.ts +2 -2
  106. package/front_end/models/persistence/AutomaticFileSystemManager.ts +3 -0
  107. package/front_end/models/persistence/FileSystemWorkspaceBinding.ts +24 -24
  108. package/front_end/models/persistence/IsolatedFileSystemManager.ts +6 -0
  109. package/front_end/models/persistence/NetworkPersistenceManager.ts +8 -3
  110. package/front_end/models/trace/LanternComputationData.ts +37 -11
  111. package/front_end/models/trace/Processor.ts +2 -1
  112. package/front_end/models/trace/extras/TraceTree.ts +36 -10
  113. package/front_end/models/trace/handlers/InitiatorsHandler.ts +27 -34
  114. package/front_end/models/trace/handlers/LayoutShiftsHandler.ts +2 -6
  115. package/front_end/models/trace/handlers/SamplesHandler.ts +9 -6
  116. package/front_end/models/workspace/FileManager.ts +6 -0
  117. package/front_end/panels/accessibility/ARIAAttributesView.ts +4 -4
  118. package/front_end/panels/accessibility/AccessibilityAnnouncementRecordingView.ts +8 -1
  119. package/front_end/panels/accessibility/AccessibilityNodeView.ts +15 -17
  120. package/front_end/panels/accessibility/AccessibilitySubPane.ts +1 -1
  121. package/front_end/panels/ai_assistance/AiAssistancePanel.ts +5 -5
  122. package/front_end/panels/ai_assistance/ExternalHandler.ts +10 -1
  123. package/front_end/panels/ai_assistance/components/ChatMessage.ts +27 -22
  124. package/front_end/panels/ai_assistance/components/DisabledWidget.ts +19 -23
  125. package/front_end/panels/ai_assistance/components/ExploreWidget.ts +2 -2
  126. package/front_end/panels/ai_assistance/components/PermissionPrompt.ts +23 -9
  127. package/front_end/panels/ai_assistance/components/chatInput.css +1 -1
  128. package/front_end/panels/animation/AnimationTimeline.ts +37 -17
  129. package/front_end/panels/animation/animationTimeline.css +19 -3
  130. package/front_end/panels/application/AppManifestView.ts +1 -2
  131. package/front_end/panels/application/ApplicationPanelSidebar.ts +143 -128
  132. package/front_end/panels/application/DOMStorageItemsView.ts +14 -14
  133. package/front_end/panels/application/DeviceBoundSessionsView.ts +10 -13
  134. package/front_end/panels/application/ExtensionStorageItemsView.ts +3 -4
  135. package/front_end/panels/application/IndexedDBViews.ts +8 -4
  136. package/front_end/panels/application/KeyValueStorageItemsView.ts +4 -5
  137. package/front_end/panels/application/PrivateVerificationTokensView.ts +53 -0
  138. package/front_end/panels/application/ServiceWorkerCacheViews.ts +12 -8
  139. package/front_end/panels/application/ServiceWorkersView.ts +1 -2
  140. package/front_end/panels/application/StorageItemsToolbar.ts +3 -3
  141. package/front_end/panels/application/StorageView.ts +2 -2
  142. package/front_end/panels/application/WebMCPView.ts +91 -109
  143. package/front_end/panels/application/application.ts +2 -0
  144. package/front_end/panels/application/components/StorageMetadataView.ts +6 -6
  145. package/front_end/panels/application/preloading/PreloadingView.ts +70 -37
  146. package/front_end/panels/application/preloading/components/MismatchedPreloadingGrid.ts +2 -2
  147. package/front_end/panels/application/preloading/components/PreloadingDisabledInfobar.ts +3 -3
  148. package/front_end/panels/application/preloading/components/PreloadingGrid.ts +12 -0
  149. package/front_end/panels/application/preloading/components/RuleSetDetailsView.ts +10 -11
  150. package/front_end/panels/application/privateVerificationTokensView.css +20 -0
  151. package/front_end/panels/application/serviceWorkersView.css +2 -2
  152. package/front_end/panels/browser_debugger/DOMBreakpointsSidebarPane.ts +24 -24
  153. package/front_end/panels/changes/ChangesSidebar.ts +5 -5
  154. package/front_end/panels/changes/ChangesView.ts +10 -11
  155. package/front_end/panels/comments/CommentsPane.ts +292 -102
  156. package/front_end/panels/comments/commentsPane.css +93 -12
  157. package/front_end/panels/common/CommentThreadWidget.ts +69 -0
  158. package/front_end/panels/common/CommentsOverlayWidget.ts +108 -29
  159. package/front_end/panels/common/CommentsStatusBarPill.ts +17 -6
  160. package/front_end/panels/common/DOMLinkifier.ts +37 -12
  161. package/front_end/panels/common/ExtensionPanel.ts +13 -4
  162. package/front_end/panels/common/ExtensionServer.ts +27 -3
  163. package/front_end/panels/common/PersistenceUtils.ts +3 -3
  164. package/front_end/panels/common/commentThreadWidget.css +25 -1
  165. package/front_end/panels/common/common-meta.ts +10 -0
  166. package/front_end/panels/console/ConsolePinPane.ts +13 -15
  167. package/front_end/panels/console/ConsolePrompt.ts +173 -95
  168. package/front_end/panels/console/ConsoleSidebar.ts +2 -2
  169. package/front_end/panels/console/ConsoleView.ts +75 -79
  170. package/front_end/panels/console/ConsoleViewMessage.ts +52 -4
  171. package/front_end/panels/console/SymbolizedErrorWidget.ts +8 -4
  172. package/front_end/panels/console/consolePrompt.css +1 -1
  173. package/front_end/panels/console/consoleView.css +1 -1
  174. package/front_end/panels/console_counters/WarningErrorCounter.ts +3 -4
  175. package/front_end/panels/coverage/CoverageListView.ts +2 -2
  176. package/front_end/panels/coverage/CoverageView.ts +20 -5
  177. package/front_end/panels/css_overview/CSSOverviewCompletedView.ts +4 -3
  178. package/front_end/panels/css_overview/CSSOverviewPanel.ts +2 -2
  179. package/front_end/panels/css_overview/CSSOverviewProcessingView.ts +2 -2
  180. package/front_end/panels/css_overview/CSSOverviewSidebarPanel.ts +2 -2
  181. package/front_end/panels/css_overview/CSSOverviewStartView.ts +2 -2
  182. package/front_end/panels/css_overview/CSSOverviewUnusedDeclarations.ts +8 -8
  183. package/front_end/panels/developer_resources/DeveloperResourcesListView.ts +2 -3
  184. package/front_end/panels/developer_resources/DeveloperResourcesView.ts +4 -5
  185. package/front_end/panels/elements/AccessibilityTreeUtils.ts +6 -7
  186. package/front_end/panels/elements/CSSValueTraceView.ts +3 -3
  187. package/front_end/panels/elements/ClassesPaneWidget.ts +1 -2
  188. package/front_end/panels/elements/ComputedStyleWidget.ts +15 -14
  189. package/front_end/panels/elements/DOMTreeElementWidget.ts +5 -4
  190. package/front_end/panels/elements/DOMTreeWidget.ts +2 -1
  191. package/front_end/panels/elements/ElementStatePaneWidget.ts +2 -2
  192. package/front_end/panels/elements/ElementsPanel.ts +1 -0
  193. package/front_end/panels/elements/EventListenersWidget.ts +2 -2
  194. package/front_end/panels/elements/LayoutPane.ts +2 -2
  195. package/front_end/panels/elements/PlatformFontsWidget.ts +3 -3
  196. package/front_end/panels/elements/PropertiesWidget.ts +9 -10
  197. package/front_end/panels/elements/PropertyRenderer.ts +72 -11
  198. package/front_end/panels/elements/StandaloneStylesContainer.ts +5 -10
  199. package/front_end/panels/elements/StyleEditorWidget.ts +30 -16
  200. package/front_end/panels/elements/StylePropertiesSection.ts +93 -44
  201. package/front_end/panels/elements/StylePropertyTreeElement.ts +230 -302
  202. package/front_end/panels/elements/StylesContainer.ts +2 -3
  203. package/front_end/panels/elements/StylesSidebarPane.ts +4 -13
  204. package/front_end/panels/elements/components/AccessibilityTreeNode.ts +66 -37
  205. package/front_end/panels/elements/components/CSSHintDetailsView.ts +51 -41
  206. package/front_end/panels/elements/components/CSSPropertyDocsView.ts +75 -65
  207. package/front_end/panels/elements/components/CSSQuery.ts +112 -74
  208. package/front_end/panels/elements/components/CSSVariableValueView.ts +109 -68
  209. package/front_end/panels/elements/components/ComputedStyleProperty.ts +64 -45
  210. package/front_end/panels/elements/components/ElementsTreeExpandButton.ts +35 -28
  211. package/front_end/panels/elements/components/QueryContainer.ts +104 -74
  212. package/front_end/panels/elements/components/accessibilityTreeNode.css +22 -20
  213. package/front_end/panels/elements/components/computedStyleProperty.css +2 -0
  214. package/front_end/panels/elements/components/cssHintDetailsView.css +23 -21
  215. package/front_end/panels/elements/components/cssPropertyDocsView.css +38 -36
  216. package/front_end/panels/elements/components/cssVariableValueView.css +42 -40
  217. package/front_end/panels/elements/components/elementsTreeExpandButton.css +5 -2
  218. package/front_end/panels/elements/components/queryContainer.css +23 -21
  219. package/front_end/panels/elements/stylesSidebarPane.css +3 -3
  220. package/front_end/panels/emulation/DeviceModeToolbar.ts +2 -2
  221. package/front_end/panels/emulation/InspectedPagePlaceholder.ts +2 -2
  222. package/front_end/panels/emulation/MediaQueryInspector.ts +9 -10
  223. package/front_end/panels/emulation/mediaQueryInspector.css +1 -1
  224. package/front_end/panels/event_listeners/EventListenersView.ts +2 -2
  225. package/front_end/panels/issues/AffectedCookiesView.ts +144 -101
  226. package/front_end/panels/issues/AffectedDescendantsWithinSelectElementView.ts +83 -31
  227. package/front_end/panels/issues/AffectedDirectivesView.ts +218 -135
  228. package/front_end/panels/issues/AffectedDocumentsInQuirksModeView.ts +84 -34
  229. package/front_end/panels/issues/AffectedElementsView.ts +86 -23
  230. package/front_end/panels/issues/AffectedLazyLoadImagesView.ts +2 -2
  231. package/front_end/panels/issues/AffectedMetadataAllowedSitesView.ts +2 -2
  232. package/front_end/panels/issues/AffectedPartitioningBlobURLView.ts +36 -11
  233. package/front_end/panels/issues/AffectedSharedArrayBufferIssueDetailsView.ts +135 -58
  234. package/front_end/panels/issues/AffectedSourcesView.ts +49 -28
  235. package/front_end/panels/issues/AffectedTrackingSitesView.ts +3 -4
  236. package/front_end/panels/issues/CorsIssueDetailsView.ts +490 -269
  237. package/front_end/panels/issues/GenericIssueDetailsView.ts +2 -2
  238. package/front_end/panels/issues/IssueKindView.ts +63 -48
  239. package/front_end/panels/issues/IssueView.ts +14 -18
  240. package/front_end/panels/issues/components/ElementsPanelLink.ts +70 -34
  241. package/front_end/panels/issues/components/HideIssuesMenu.ts +56 -32
  242. package/front_end/panels/issues/components/elementsPanelLink.css +10 -6
  243. package/front_end/panels/issues/components/hideIssuesMenu.css +16 -14
  244. package/front_end/panels/issues/issues.ts +2 -0
  245. package/front_end/panels/issues/issuesTree.css +4 -4
  246. package/front_end/panels/lighthouse/LighthouseController.ts +6 -6
  247. package/front_end/panels/lighthouse/LighthouseStatusView.ts +12 -13
  248. package/front_end/panels/lighthouse/lighthouseStartView.css +1 -1
  249. package/front_end/panels/linear_memory_inspector/LinearMemoryInspectorPane.ts +159 -161
  250. package/front_end/panels/linear_memory_inspector/LinearMemoryInspectorView.ts +228 -0
  251. package/front_end/panels/linear_memory_inspector/components/LinearMemoryInspector.ts +32 -41
  252. package/front_end/panels/linear_memory_inspector/components/linearMemoryHighlightChipList.css +2 -2
  253. package/front_end/panels/linear_memory_inspector/linear_memory_inspector.ts +2 -0
  254. package/front_end/panels/media/EventDisplayTable.ts +2 -2
  255. package/front_end/panels/media/MainView.ts +132 -66
  256. package/front_end/panels/media/PlayerDetailView.ts +32 -14
  257. package/front_end/panels/media/PlayerListView.ts +83 -23
  258. package/front_end/panels/media/PlayerPropertiesView.ts +2 -2
  259. package/front_end/panels/media/TickingFlameChart.ts +153 -63
  260. package/front_end/panels/mobile_throttling/NetworkThrottlingSelector.ts +2 -2
  261. package/front_end/panels/mobile_throttling/ThrottlingSettingsTab.ts +615 -464
  262. package/front_end/panels/mobile_throttling/throttlingSettingsTab.css +43 -0
  263. package/front_end/panels/network/EventSourceMessagesView.ts +3 -3
  264. package/front_end/panels/network/NetworkConfigView.ts +6 -2
  265. package/front_end/panels/network/NetworkDataGridNode.ts +2 -1
  266. package/front_end/panels/network/NetworkItemView.ts +27 -26
  267. package/front_end/panels/network/NetworkManageCustomHeadersView.ts +236 -97
  268. package/front_end/panels/network/NetworkOverview.ts +8 -10
  269. package/front_end/panels/network/RequestConditionsDrawer.ts +8 -4
  270. package/front_end/panels/network/RequestDeviceBoundSessionsView.ts +2 -4
  271. package/front_end/panels/network/RequestHTMLView.ts +26 -7
  272. package/front_end/panels/network/RequestHeadersView.ts +2 -2
  273. package/front_end/panels/network/RequestInitiatorView.ts +21 -22
  274. package/front_end/panels/network/RequestPayloadView.ts +2 -16
  275. package/front_end/panels/network/RequestPreviewView.ts +5 -5
  276. package/front_end/panels/network/RequestTimingView.ts +6 -6
  277. package/front_end/panels/network/ResourceDirectSocketChunkView.ts +5 -6
  278. package/front_end/panels/network/ResourceWebSocketFrameView.ts +4 -3
  279. package/front_end/panels/network/ShowMoreDetailsWidget.ts +11 -12
  280. package/front_end/panels/network/SignedExchangeInfoView.ts +2 -2
  281. package/front_end/panels/network/networkLogView.css +2 -2
  282. package/front_end/panels/network/networkManageCustomHeadersView.css +27 -6
  283. package/front_end/panels/network/requestConditionsDrawer.css +1 -1
  284. package/front_end/panels/network/requestInitiatorView.css +5 -3
  285. package/front_end/panels/performance_monitor/PerformanceMonitor.ts +2 -2
  286. package/front_end/panels/profiler/HeapDetachedElementsView.ts +1 -2
  287. package/front_end/panels/profiler/HeapTimelineOverview.ts +77 -15
  288. package/front_end/panels/profiler/IsolateSelector.ts +258 -187
  289. package/front_end/panels/profiler/ProfileLauncherView.ts +7 -29
  290. package/front_end/panels/profiler/profileLauncherView.css +6 -1
  291. package/front_end/panels/protocol_monitor/JSONEditor.ts +4 -5
  292. package/front_end/panels/recorder/ControlButton.ts +1 -1
  293. package/front_end/panels/recorder/RecordingListView.ts +2 -4
  294. package/front_end/panels/recorder/RecordingView.ts +1 -2
  295. package/front_end/panels/recorder/SelectorPicker.ts +2 -4
  296. package/front_end/panels/recorder/StepView.ts +24 -10
  297. package/front_end/panels/recorder/TimelineSection.ts +1 -1
  298. package/front_end/panels/recorder/recordingView.css +1 -1
  299. package/front_end/panels/screencast/ScreencastApp.ts +1 -1
  300. package/front_end/panels/search/SearchResultsPane.ts +11 -12
  301. package/front_end/panels/search/SearchView.ts +8 -10
  302. package/front_end/panels/security/SecurityPanel.ts +1 -8
  303. package/front_end/panels/security/SecurityPanelSidebar.ts +2 -2
  304. package/front_end/panels/security/mainView.css +1 -1
  305. package/front_end/panels/sensors/LocationsSettingsTab.ts +1 -2
  306. package/front_end/panels/settings/AISettingsTab.ts +1 -1
  307. package/front_end/panels/settings/BackendLinkingSettingsTab.ts +34 -20
  308. package/front_end/panels/settings/EditFileSystemView.ts +2 -2
  309. package/front_end/panels/settings/FrameworkIgnoreListSettingsTab.ts +375 -197
  310. package/front_end/panels/settings/KeybindsSettingsTab.ts +570 -414
  311. package/front_end/panels/settings/SettingsScreen.ts +312 -114
  312. package/front_end/panels/settings/WorkspaceSettingsTab.ts +2 -2
  313. package/front_end/panels/settings/aiSettingsTab.css +1 -4
  314. package/front_end/panels/settings/emulation/DevicesSettingsTab.ts +924 -578
  315. package/front_end/panels/settings/emulation/components/UserAgentClientHintsForm.ts +9 -2
  316. package/front_end/panels/settings/emulation/devicesSettingsTab.css +39 -0
  317. package/front_end/panels/settings/frameworkIgnoreListSettingsTab.css +37 -8
  318. package/front_end/panels/settings/settingsScreen.css +0 -24
  319. package/front_end/panels/sources/BreakpointEditDialog.ts +9 -6
  320. package/front_end/panels/sources/BreakpointsView.ts +25 -4
  321. package/front_end/panels/sources/CallStackSidebarPane.ts +7 -1
  322. package/front_end/panels/sources/DebuggerPlugin.ts +1 -0
  323. package/front_end/panels/sources/GoToLineQuickOpen.ts +8 -8
  324. package/front_end/panels/sources/NavigatorView.ts +521 -439
  325. package/front_end/panels/sources/PersistenceActions.ts +11 -12
  326. package/front_end/panels/sources/ProfilePlugin.ts +28 -17
  327. package/front_end/panels/sources/ScopeChainSidebarPane.ts +3 -4
  328. package/front_end/panels/sources/SourcesNavigator.ts +9 -9
  329. package/front_end/panels/sources/SourcesPanel.ts +2 -2
  330. package/front_end/panels/sources/SourcesView.ts +3 -3
  331. package/front_end/panels/sources/ThreadsSidebarPane.ts +2 -2
  332. package/front_end/panels/sources/WatchExpressionsSidebarPane.ts +2 -2
  333. package/front_end/panels/sources/components/HeadersView.ts +1 -2
  334. package/front_end/panels/timeline/CompatibilityTracksAppender.ts +5 -6
  335. package/front_end/panels/timeline/EventsTimelineTreeView.ts +73 -34
  336. package/front_end/panels/timeline/IsolateSelector.ts +25 -37
  337. package/front_end/panels/timeline/StatusDialog.ts +5 -7
  338. package/front_end/panels/timeline/ThirdPartyTreeView.ts +10 -13
  339. package/front_end/panels/timeline/TimelineDetailsView.ts +40 -21
  340. package/front_end/panels/timeline/TimelineEventOverview.ts +130 -34
  341. package/front_end/panels/timeline/TimelineFlameChartNetworkDataProvider.ts +1 -1
  342. package/front_end/panels/timeline/TimelineMiniMap.ts +255 -103
  343. package/front_end/panels/timeline/TimelinePaintProfilerView.ts +19 -11
  344. package/front_end/panels/timeline/TimelinePanel.ts +1 -0
  345. package/front_end/panels/timeline/TimelineSelectorStatsView.ts +11 -12
  346. package/front_end/panels/timeline/TimelineTreeView.ts +240 -122
  347. package/front_end/panels/timeline/TimelineUIUtils.ts +12 -0
  348. package/front_end/panels/timeline/components/BreadcrumbsUI.ts +5 -4
  349. package/front_end/panels/timeline/components/DetailsView.ts +97 -65
  350. package/front_end/panels/timeline/components/LayoutShiftDetails.ts +2 -2
  351. package/front_end/panels/timeline/components/MetricCard.ts +2 -2
  352. package/front_end/panels/timeline/components/NetworkRequestDetails.ts +11 -12
  353. package/front_end/panels/timeline/components/NetworkTrackWidget.ts +57 -50
  354. package/front_end/panels/timeline/components/RelatedInsightChips.ts +2 -2
  355. package/front_end/panels/timeline/components/Sidebar.ts +161 -109
  356. package/front_end/panels/timeline/components/SidebarAnnotationsTab.ts +33 -12
  357. package/front_end/panels/timeline/components/SidebarInsightsTab.ts +3 -0
  358. package/front_end/panels/timeline/components/insights/LCPDiscovery.ts +11 -11
  359. package/front_end/panels/timeline/components/insights/SlowCSSSelector.ts +6 -7
  360. package/front_end/panels/timeline/components/networkTrackWidget.css +24 -22
  361. package/front_end/panels/timeline/components/sidebarInsightsTab.css +1 -1
  362. package/front_end/panels/timeline/overlays/components/TimespanBreakdownOverlay.ts +15 -10
  363. package/front_end/panels/timeline/overlays/components/entryLabelOverlay.css +1 -1
  364. package/front_end/panels/timeline/timelinePanel.css +5 -0
  365. package/front_end/panels/timeline/timelineStatusDialog.css +1 -1
  366. package/front_end/panels/web_audio/WebAudioView.ts +2 -2
  367. package/front_end/third_party/chromium/README.chromium +1 -1
  368. package/front_end/third_party/legacy-javascript/README.chromium +2 -2
  369. package/front_end/third_party/legacy-javascript/lib/legacy-javascript.js +2 -2
  370. package/front_end/third_party/legacy-javascript/package.json +1 -1
  371. package/front_end/third_party/lighthouse/README.chromium +2 -2
  372. package/front_end/third_party/lighthouse/lighthouse-dt-bundle.js +1983 -2022
  373. package/front_end/third_party/lighthouse/locales/ar-XB.json +157 -142
  374. package/front_end/third_party/lighthouse/locales/ar.json +157 -142
  375. package/front_end/third_party/lighthouse/locales/bg.json +154 -139
  376. package/front_end/third_party/lighthouse/locales/ca.json +157 -142
  377. package/front_end/third_party/lighthouse/locales/cs.json +148 -133
  378. package/front_end/third_party/lighthouse/locales/da.json +153 -138
  379. package/front_end/third_party/lighthouse/locales/de.json +152 -137
  380. package/front_end/third_party/lighthouse/locales/el.json +153 -138
  381. package/front_end/third_party/lighthouse/locales/en-GB.json +160 -145
  382. package/front_end/third_party/lighthouse/locales/en-US.json +239 -218
  383. package/front_end/third_party/lighthouse/locales/en-XL.json +239 -218
  384. package/front_end/third_party/lighthouse/locales/es-419.json +150 -135
  385. package/front_end/third_party/lighthouse/locales/es.json +149 -134
  386. package/front_end/third_party/lighthouse/locales/fi.json +151 -136
  387. package/front_end/third_party/lighthouse/locales/fil.json +154 -139
  388. package/front_end/third_party/lighthouse/locales/fr.json +150 -135
  389. package/front_end/third_party/lighthouse/locales/he.json +160 -145
  390. package/front_end/third_party/lighthouse/locales/hi.json +156 -141
  391. package/front_end/third_party/lighthouse/locales/hr.json +154 -139
  392. package/front_end/third_party/lighthouse/locales/hu.json +111 -96
  393. package/front_end/third_party/lighthouse/locales/id.json +153 -138
  394. package/front_end/third_party/lighthouse/locales/it.json +153 -138
  395. package/front_end/third_party/lighthouse/locales/ja.json +150 -135
  396. package/front_end/third_party/lighthouse/locales/ko.json +42 -27
  397. package/front_end/third_party/lighthouse/locales/lt.json +152 -137
  398. package/front_end/third_party/lighthouse/locales/lv.json +93 -78
  399. package/front_end/third_party/lighthouse/locales/nl.json +149 -134
  400. package/front_end/third_party/lighthouse/locales/no.json +152 -137
  401. package/front_end/third_party/lighthouse/locales/pl.json +153 -138
  402. package/front_end/third_party/lighthouse/locales/pt-PT.json +152 -137
  403. package/front_end/third_party/lighthouse/locales/pt.json +157 -142
  404. package/front_end/third_party/lighthouse/locales/ro.json +149 -134
  405. package/front_end/third_party/lighthouse/locales/ru.json +76 -61
  406. package/front_end/third_party/lighthouse/locales/sk.json +153 -138
  407. package/front_end/third_party/lighthouse/locales/sl.json +149 -134
  408. package/front_end/third_party/lighthouse/locales/sr-Latn.json +151 -136
  409. package/front_end/third_party/lighthouse/locales/sr.json +151 -136
  410. package/front_end/third_party/lighthouse/locales/sv.json +152 -137
  411. package/front_end/third_party/lighthouse/locales/ta.json +156 -141
  412. package/front_end/third_party/lighthouse/locales/te.json +157 -142
  413. package/front_end/third_party/lighthouse/locales/th.json +111 -96
  414. package/front_end/third_party/lighthouse/locales/tr.json +153 -138
  415. package/front_end/third_party/lighthouse/locales/uk.json +149 -134
  416. package/front_end/third_party/lighthouse/locales/vi.json +162 -147
  417. package/front_end/third_party/lighthouse/locales/zh-HK.json +150 -135
  418. package/front_end/third_party/lighthouse/locales/zh-TW.json +154 -139
  419. package/front_end/third_party/lighthouse/locales/zh.json +152 -137
  420. package/front_end/third_party/lighthouse/report/bundle.d.ts +9 -8
  421. package/front_end/third_party/lighthouse/report/bundle.js +10 -10
  422. package/front_end/third_party/lighthouse/report-assets/report-generator.mjs +2 -7
  423. package/front_end/tsconfig.compatibility.json +1 -0
  424. package/front_end/tsconfig.json +3 -2
  425. package/front_end/ui/components/dialogs/TypeToAllowDialog.ts +0 -2
  426. package/front_end/ui/components/dialogs/typeToAllowDialog.css +0 -4
  427. package/front_end/ui/components/icon_button/fileSourceIcon.css +1 -1
  428. package/front_end/ui/components/input/textInput.css +1 -1
  429. package/front_end/ui/components/lists/List.ts +26 -14
  430. package/front_end/ui/components/menus/menus.ts +0 -2
  431. package/front_end/ui/components/suggestion_input/SuggestionInput.ts +351 -138
  432. package/front_end/ui/components/survey_link/surveyLink.css +3 -3
  433. package/front_end/ui/components/switch/switch.css +6 -6
  434. package/front_end/ui/components/text_editor/AiCodeCompletionTeaser.ts +2 -3
  435. package/front_end/ui/components/text_editor/TextEditor.ts +1 -1
  436. package/front_end/ui/components/tooltips/Tooltip.ts +53 -4
  437. package/front_end/ui/components/tree_outline/treeOutline.css +7 -7
  438. package/front_end/ui/helpers/OpenInNewTab.ts +8 -3
  439. package/front_end/ui/legacy/EmptyWidget.ts +4 -4
  440. package/front_end/ui/legacy/ForwardedInputEventHandler.ts +2 -2
  441. package/front_end/ui/legacy/GlassPane.ts +1 -1
  442. package/front_end/ui/legacy/KeyboardShortcut.ts +7 -7
  443. package/front_end/ui/legacy/RemoteDebuggingTerminatedScreen.ts +2 -2
  444. package/front_end/ui/legacy/TabbedPane.ts +198 -66
  445. package/front_end/ui/legacy/TargetCrashedScreen.ts +2 -2
  446. package/front_end/ui/legacy/UIUtils.ts +71 -68
  447. package/front_end/ui/legacy/View.ts +7 -4
  448. package/front_end/ui/legacy/ViewManager.ts +49 -37
  449. package/front_end/ui/legacy/Widget.ts +32 -12
  450. package/front_end/ui/legacy/components/cookie_table/CookiesTable.ts +2 -3
  451. package/front_end/ui/legacy/components/inline_editor/AnimationTimingUI.ts +8 -8
  452. package/front_end/ui/legacy/components/inline_editor/BezierUI.ts +8 -9
  453. package/front_end/ui/legacy/components/inline_editor/LinkSwatch.ts +2 -2
  454. package/front_end/ui/legacy/components/inline_editor/cssAngleEditor.css +1 -1
  455. package/front_end/ui/legacy/components/inline_editor/cssAngleSwatch.css +1 -1
  456. package/front_end/ui/legacy/components/object_ui/ObjectPropertiesSection.ts +45 -11
  457. package/front_end/ui/legacy/components/object_ui/RemoteObjectPreviewFormatter.ts +10 -12
  458. package/front_end/ui/legacy/components/perf_ui/ChartViewport.ts +102 -29
  459. package/front_end/ui/legacy/components/perf_ui/FlameChart.ts +148 -122
  460. package/front_end/ui/legacy/components/perf_ui/TimelineOverviewPane.ts +20 -14
  461. package/front_end/ui/legacy/components/quick_open/filteredListWidget.css +1 -1
  462. package/front_end/ui/legacy/components/source_frame/FontView.ts +29 -5
  463. package/front_end/ui/legacy/components/source_frame/ImageView.ts +79 -12
  464. package/front_end/ui/legacy/components/source_frame/JSONView.ts +20 -2
  465. package/front_end/ui/legacy/components/source_frame/PreviewFactory.ts +2 -2
  466. package/front_end/ui/legacy/components/source_frame/StreamingContentHexView.ts +6 -10
  467. package/front_end/ui/legacy/components/source_frame/XMLView.ts +11 -11
  468. package/front_end/ui/legacy/components/source_frame/fontView.css +7 -0
  469. package/front_end/ui/legacy/components/source_frame/imageView.css +7 -0
  470. package/front_end/ui/legacy/components/utils/JSPresentationUtils.ts +14 -3
  471. package/front_end/ui/legacy/components/utils/Linkifier.ts +126 -2
  472. package/front_end/ui/legacy/emptyWidget.css +2 -1
  473. package/front_end/ui/legacy/inspectorCommon.css +3 -3
  474. package/front_end/ui/legacy/smallBubble.css +1 -1
  475. package/front_end/ui/legacy/tabbedPane.css +6 -0
  476. package/front_end/ui/lit/Directives.ts +35 -18
  477. package/front_end/ui/lit/lit.ts +0 -2
  478. package/front_end/ui/lit/render.ts +0 -7
  479. package/front_end/ui/visual_logging/KnownContextValues.ts +5 -0
  480. package/package.json +1 -1
  481. package/vpython.toml +8 -0
  482. package/vpython.toml.uv.lock +3 -0
  483. package/.agents/skills/review-models-core/SKILL.md +0 -73
  484. package/.agents/skills/review-tests/SKILL.md +0 -67
  485. package/.agents/skills/review-ui-widgets/SKILL.md +0 -115
  486. package/front_end/generated/ARIAProperties.ts +0 -2686
  487. package/front_end/ui/components/menus/README.md +0 -119
  488. package/front_end/ui/components/menus/SelectMenu.ts +0 -473
  489. package/front_end/ui/components/menus/selectMenu.css +0 -54
  490. package/front_end/ui/components/menus/selectMenuButton.css +0 -108
@@ -1,7 +1,6 @@
1
1
  // Copyright 2021 The Chromium Authors
2
2
  // Use of this source code is governed by a BSD-style license that can be
3
3
  // found in the LICENSE file.
4
- /* eslint-disable @devtools/no-imperative-dom-api */
5
4
 
6
5
  import * as Common from '../../core/common/common.js';
7
6
  import * as Host from '../../core/host/host.js';
@@ -10,45 +9,185 @@ import * as Platform from '../../core/platform/platform.js';
10
9
  import * as SDK from '../../core/sdk/sdk.js';
11
10
  import type * as Protocol from '../../generated/protocol.js';
12
11
  import * as IssuesManager from '../../models/issues_manager/issues_manager.js';
12
+ import * as Components from '../../ui/legacy/components/utils/utils.js';
13
+ import * as UI from '../../ui/legacy/legacy.js';
14
+ import {html, type LitTemplate, nothing, render} from '../../ui/lit/lit.js';
15
+ import * as VisualLogging from '../../ui/visual_logging/visual_logging.js';
13
16
 
14
17
  import {AffectedItem, AffectedResourcesView} from './AffectedResourcesView.js';
15
18
  import * as IssuesComponents from './components/components.js';
19
+ import type {IssueView} from './IssueView.js';
20
+
21
+ const {widget} = UI.Widget;
22
+
23
+ export interface SourceLocationData {
24
+ target: SDK.Target.Target|null;
25
+ scriptId: Protocol.Runtime.ScriptId|null;
26
+ url: Platform.DevToolsPath.UrlString;
27
+ lineNumber: number;
28
+ columnNumber?: number;
29
+ }
30
+
31
+ export interface DirectiveRow {
32
+ violatedDirective: string;
33
+ isReportOnly: boolean;
34
+ blockedURL: Platform.DevToolsPath.UrlString;
35
+ sourceLocation?: SourceLocationData;
36
+ hasModel: boolean;
37
+ elementsPanelLinkData?: IssuesComponents.ElementsPanelLink.ElementsPanelLinkData;
38
+ }
39
+
40
+ export interface ViewInput {
41
+ issueCode: string;
42
+ rows: DirectiveRow[];
43
+ linkifier: Components.Linkifier.Linkifier;
44
+ }
45
+
46
+ export type View = (input: ViewInput, _output: undefined, target: HTMLElement) => void;
47
+
48
+ export const DEFAULT_VIEW: View = (input, _output, target) => {
49
+ const renderStatus = (isReportOnly: boolean): LitTemplate => html`
50
+ <td class=${isReportOnly ? 'affected-resource-report-only-status' : 'affected-resource-blocked-status'}>
51
+ ${isReportOnly ? i18nString(UIStrings.reportonly) : i18nString(UIStrings.blocked)}
52
+ </td>
53
+ `;
54
+
55
+ const renderViolatedDirective = (directive: string): LitTemplate => html`<td>${directive}</td>`;
56
+
57
+ const renderSourceLocation = (location: SourceLocationData|undefined): LitTemplate => {
58
+ if (!location) {
59
+ return html`<td class="affected-source-location"></td>`;
60
+ }
61
+ const sourceAnchor = input.linkifier.linkifyScriptLocation(
62
+ location.target, location.scriptId, location.url, location.lineNumber, {columnNumber: location.columnNumber});
63
+ sourceAnchor.setAttribute('jslog', `${VisualLogging.link('source-location').track({click: true})}`);
64
+ return html`<td class="affected-source-location">${sourceAnchor}</td>`;
65
+ };
66
+
67
+ const renderBlockedElement =
68
+ (data: IssuesComponents.ElementsPanelLink.ElementsPanelLinkData|undefined): LitTemplate => {
69
+ if (!data) {
70
+ return html`<td class="affected-resource-csp-info-node"></td>`;
71
+ }
72
+ // clang-format off
73
+ return html`
74
+ <td class="affected-resource-csp-info-node">
75
+ <devtools-widget
76
+ title=${i18nString(UIStrings.clickToRevealTheViolatingDomNode)}
77
+ ${widget(IssuesComponents.ElementsPanelLink.ElementsPanelLink, data)}
78
+ ></devtools-widget>
79
+ </td>
80
+ `;
81
+ // clang-format on
82
+ };
83
+
84
+ // clang-format off
85
+ render(html`
86
+ ${input.issueCode === IssuesManager.ContentSecurityPolicyIssue.inlineViolationCode ? html`
87
+ <tr>
88
+ <td class="affected-resource-header">${i18nString(UIStrings.directiveC)}</td>
89
+ <td class="affected-resource-header">${i18nString(UIStrings.element)}</td>
90
+ <td class="affected-resource-header">${i18nString(UIStrings.sourceLocation)}</td>
91
+ <td class="affected-resource-header">${i18nString(UIStrings.status)}</td>
92
+ </tr>
93
+ ${input.rows.map(row => row.hasModel ? html`
94
+ <tr class="affected-resource-directive">
95
+ ${renderViolatedDirective(row.violatedDirective)}
96
+ ${renderBlockedElement(row.elementsPanelLinkData)}
97
+ ${renderSourceLocation(row.sourceLocation)}
98
+ ${renderStatus(row.isReportOnly)}
99
+ </tr>
100
+ ` : nothing)}
101
+ ` : input.issueCode === IssuesManager.ContentSecurityPolicyIssue.urlViolationCode ? html`
102
+ <tr>
103
+ <td class="affected-resource-header affected-resource-directive-info-header">${i18nString(UIStrings.resourceC)}</td>
104
+ <td class="affected-resource-header">${i18nString(UIStrings.status)}</td>
105
+ <td class="affected-resource-header">${i18nString(UIStrings.directiveC)}</td>
106
+ <td class="affected-resource-header">${i18nString(UIStrings.sourceLocation)}</td>
107
+ </tr>
108
+ ${input.rows.map(row => html`
109
+ <tr class="affected-resource-directive">
110
+ <td class="affected-resource-directive-info">${row.blockedURL}</td>
111
+ ${renderStatus(row.isReportOnly)}
112
+ ${renderViolatedDirective(row.violatedDirective)}
113
+ ${renderSourceLocation(row.sourceLocation)}
114
+ </tr>
115
+ `)}
116
+ ` : (input.issueCode === IssuesManager.ContentSecurityPolicyIssue.evalViolationCode ||
117
+ input.issueCode === IssuesManager.ContentSecurityPolicyIssue.trustedTypesPolicyViolationCode) ? html`
118
+ <tr>
119
+ <td class="affected-resource-header">${i18nString(UIStrings.sourceLocation)}</td>
120
+ <td class="affected-resource-header">${i18nString(UIStrings.directiveC)}</td>
121
+ <td class="affected-resource-header">${i18nString(UIStrings.status)}</td>
122
+ </tr>
123
+ ${input.rows.map(row => html`
124
+ <tr class="affected-resource-directive">
125
+ ${renderSourceLocation(row.sourceLocation)}
126
+ ${renderViolatedDirective(row.violatedDirective)}
127
+ ${renderStatus(row.isReportOnly)}
128
+ </tr>
129
+ `)}
130
+ ` : input.issueCode === IssuesManager.ContentSecurityPolicyIssue.trustedTypesSinkViolationCode ? html`
131
+ <tr>
132
+ <td class="affected-resource-header">${i18nString(UIStrings.sourceLocation)}</td>
133
+ <td class="affected-resource-header">${i18nString(UIStrings.status)}</td>
134
+ </tr>
135
+ ${input.rows.map(row => html`
136
+ <tr class="affected-resource-directive">
137
+ ${renderSourceLocation(row.sourceLocation)}
138
+ ${renderStatus(row.isReportOnly)}
139
+ </tr>
140
+ `)}
141
+ ` : nothing}
142
+ `, target);
143
+ // clang-format on
144
+ };
16
145
 
17
146
  const UIStrings = {
18
147
  /**
19
- * @description Label in the Issues panel for the number of affected Content Security Policy (CSP) directives. See https://developer.mozilla.org/en-US/docs/Web/HTTP/CSP.
148
+ * @description Label in the Issues panel for the number of affected Content
149
+ * Security Policy (CSP) directives. See
150
+ * https://developer.mozilla.org/en-US/docs/Web/HTTP/CSP.
20
151
  */
21
152
  nDirectives: '{n, plural, =1 {# directive} other {# directives}}',
22
153
  /**
23
- * @description Resolution status in the Issues panel indicating that a Content Security Policy violation is report-only.
154
+ * @description Resolution status in the Issues panel indicating that a
155
+ * Content Security Policy violation is report-only.
24
156
  */
25
157
  reportonly: 'Report-only',
26
158
  /**
27
- * @description Resolution status in the Issues panel indicating that a Content Security Policy violation was blocked.
159
+ * @description Resolution status in the Issues panel indicating that a
160
+ * Content Security Policy violation was blocked.
28
161
  */
29
162
  blocked: 'Blocked',
30
163
  /**
31
- * @description Tooltip in the Issues panel for the button to reveal a violating DOM node in the Elements panel.
164
+ * @description Tooltip in the Issues panel for the button to reveal a
165
+ * violating DOM node in the Elements panel.
32
166
  */
33
167
  clickToRevealTheViolatingDomNode: 'Click to reveal the violating DOM node in the Elements panel',
34
168
  /**
35
- * @description Column header in the Issues panel for Content Security Policy directives in the affected directives table.
169
+ * @description Column header in the Issues panel for Content Security Policy
170
+ * directives in the affected directives table.
36
171
  */
37
172
  directiveC: 'Directive',
38
173
  /**
39
- * @description Column header in the Issues panel for DOM elements in the affected directives table.
174
+ * @description Column header in the Issues panel for DOM elements in the
175
+ * affected directives table.
40
176
  */
41
177
  element: 'Element',
42
178
  /**
43
- * @description Column header in the Issues panel for source locations in the affected directives table.
179
+ * @description Column header in the Issues panel for source locations in the
180
+ * affected directives table.
44
181
  */
45
182
  sourceLocation: 'Source location',
46
183
  /**
47
- * @description Column header in the Issues panel for violation status in the affected directives table.
184
+ * @description Column header in the Issues panel for violation status in the
185
+ * affected directives table.
48
186
  */
49
187
  status: 'Status',
50
188
  /**
51
- * @description Column header in the Issues panel for blocked resources in the affected directives table.
189
+ * @description Column header in the Issues panel for blocked resources in the
190
+ * affected directives table.
52
191
  */
53
192
  resourceC: 'Resource',
54
193
  } as const;
@@ -57,153 +196,97 @@ const str_ = i18n.i18n.registerUIStrings('panels/issues/AffectedDirectivesView.t
57
196
  const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
58
197
 
59
198
  export class AffectedDirectivesView extends AffectedResourcesView {
60
- #appendStatus(element: Element, isReportOnly: boolean): void {
61
- const status = document.createElement('td');
62
- if (isReportOnly) {
63
- status.classList.add('affected-resource-report-only-status');
64
- status.textContent = i18nString(UIStrings.reportonly);
65
- } else {
66
- status.classList.add('affected-resource-blocked-status');
67
- status.textContent = i18nString(UIStrings.blocked);
68
- }
69
- element.appendChild(status);
199
+ readonly #view: View;
200
+ readonly #linkifier = new Components.Linkifier.Linkifier(UI.UIUtils.MaxLengthForDisplayedURLsInConsole);
201
+
202
+ constructor(parent: IssueView, issue: IssuesManager.IssueAggregator.AggregatedIssue, jslogContext: string,
203
+ view: View = DEFAULT_VIEW) {
204
+ super(parent, issue, jslogContext);
205
+ this.#view = view;
70
206
  }
71
207
 
72
208
  protected getResourceNameWithCount(count: number): Platform.UIString.LocalizedString {
73
209
  return i18nString(UIStrings.nDirectives, {n: count});
74
210
  }
75
211
 
76
- #appendViolatedDirective(element: Element, directive: string): void {
77
- const violatedDirective = document.createElement('td');
78
- violatedDirective.textContent = directive;
79
- element.appendChild(violatedDirective);
80
- }
81
-
82
- #appendBlockedURL(element: Element, url: Platform.DevToolsPath.UrlString): void {
83
- const info = document.createElement('td');
84
- info.classList.add('affected-resource-directive-info');
85
- info.textContent = url;
86
- element.appendChild(info);
87
- }
88
-
89
- #appendBlockedElement(
90
- element: Element, nodeId: Protocol.DOM.BackendNodeId|undefined, model: SDK.IssuesModel.IssuesModel): void {
91
- const elementsPanelLinkComponent = new IssuesComponents.ElementsPanelLink.ElementsPanelLink();
92
- if (nodeId) {
93
- const violatingNodeId = nodeId;
94
- elementsPanelLinkComponent.title = i18nString(UIStrings.clickToRevealTheViolatingDomNode);
95
-
96
- const onElementRevealIconClick: (arg0?: Event|undefined) => void = () => {
97
- const target = model.getTargetIfNotDisposed();
98
- if (target) {
99
- Host.userMetrics.issuesPanelResourceOpened(this.issue.getCategory(), AffectedItem.ELEMENT);
100
- const deferredDOMNode = new SDK.DOMModel.DeferredDOMNode(target, violatingNodeId);
101
- void Common.Revealer.reveal(deferredDOMNode);
102
- }
103
- };
104
-
105
- const onElementRevealIconMouseEnter: (arg0?: Event|undefined) => void = () => {
106
- const target = model.getTargetIfNotDisposed();
107
- if (target) {
108
- const deferredDOMNode = new SDK.DOMModel.DeferredDOMNode(target, violatingNodeId);
109
- if (deferredDOMNode) {
110
- deferredDOMNode.highlight();
111
- }
112
- }
113
- };
114
-
115
- const onElementRevealIconMouseLeave: (arg0?: Event|undefined) => void = () => {
116
- SDK.OverlayModel.OverlayModel.hideDOMNodeHighlight(SDK.TargetManager.TargetManager.instance());
117
- };
118
-
119
- elementsPanelLinkComponent
120
- .data = {onElementRevealIconClick, onElementRevealIconMouseEnter, onElementRevealIconMouseLeave};
121
- }
122
-
123
- const violatingNode = document.createElement('td');
124
- violatingNode.classList.add('affected-resource-csp-info-node');
125
- violatingNode.appendChild(elementsPanelLinkComponent);
126
- element.appendChild(violatingNode);
127
- }
128
-
129
212
  #appendAffectedContentSecurityPolicyDetails(
130
213
  cspIssues: Iterable<IssuesManager.ContentSecurityPolicyIssue.ContentSecurityPolicyIssue>): void {
131
- const header = document.createElement('tr');
132
- if (this.issue.code() === IssuesManager.ContentSecurityPolicyIssue.inlineViolationCode) {
133
- this.appendColumnTitle(header, i18nString(UIStrings.directiveC));
134
- this.appendColumnTitle(header, i18nString(UIStrings.element));
135
- this.appendColumnTitle(header, i18nString(UIStrings.sourceLocation));
136
- this.appendColumnTitle(header, i18nString(UIStrings.status));
137
- } else if (this.issue.code() === IssuesManager.ContentSecurityPolicyIssue.urlViolationCode) {
138
- this.appendColumnTitle(header, i18nString(UIStrings.resourceC), 'affected-resource-directive-info-header');
139
- this.appendColumnTitle(header, i18nString(UIStrings.status));
140
- this.appendColumnTitle(header, i18nString(UIStrings.directiveC));
141
- this.appendColumnTitle(header, i18nString(UIStrings.sourceLocation));
142
- } else if (this.issue.code() === IssuesManager.ContentSecurityPolicyIssue.evalViolationCode) {
143
- this.appendColumnTitle(header, i18nString(UIStrings.sourceLocation));
144
- this.appendColumnTitle(header, i18nString(UIStrings.directiveC));
145
- this.appendColumnTitle(header, i18nString(UIStrings.status));
146
- } else if (this.issue.code() === IssuesManager.ContentSecurityPolicyIssue.trustedTypesSinkViolationCode) {
147
- this.appendColumnTitle(header, i18nString(UIStrings.sourceLocation));
148
- this.appendColumnTitle(header, i18nString(UIStrings.status));
149
- } else if (this.issue.code() === IssuesManager.ContentSecurityPolicyIssue.trustedTypesPolicyViolationCode) {
150
- this.appendColumnTitle(header, i18nString(UIStrings.sourceLocation));
151
- this.appendColumnTitle(header, i18nString(UIStrings.directiveC));
152
- this.appendColumnTitle(header, i18nString(UIStrings.status));
153
- } else {
214
+ const issueCode = this.issue.code();
215
+ if (issueCode !== IssuesManager.ContentSecurityPolicyIssue.inlineViolationCode &&
216
+ issueCode !== IssuesManager.ContentSecurityPolicyIssue.urlViolationCode &&
217
+ issueCode !== IssuesManager.ContentSecurityPolicyIssue.evalViolationCode &&
218
+ issueCode !== IssuesManager.ContentSecurityPolicyIssue.trustedTypesSinkViolationCode &&
219
+ issueCode !== IssuesManager.ContentSecurityPolicyIssue.trustedTypesPolicyViolationCode) {
220
+ this.#view({issueCode, rows: [], linkifier: this.#linkifier}, undefined, this.affectedResources);
154
221
  this.updateAffectedResourceCount(0);
155
222
  return;
156
223
  }
157
- this.affectedResources.appendChild(header);
158
- let count = 0;
224
+
225
+ const rows: DirectiveRow[] = [];
159
226
  for (const cspIssue of cspIssues) {
160
- count++;
161
- this.#appendAffectedContentSecurityPolicyDetail(cspIssue);
227
+ rows.push(this.#createDirectiveRow(cspIssue));
162
228
  }
163
- this.updateAffectedResourceCount(count);
229
+ this.#view({issueCode, rows, linkifier: this.#linkifier}, undefined, this.affectedResources);
230
+ this.updateAffectedResourceCount(rows.length);
164
231
  }
165
232
 
166
- #appendAffectedContentSecurityPolicyDetail(
167
- cspIssue: IssuesManager.ContentSecurityPolicyIssue.ContentSecurityPolicyIssue): void {
168
- const element = document.createElement('tr');
169
- element.classList.add('affected-resource-directive');
170
-
233
+ #createDirectiveRow(cspIssue: IssuesManager.ContentSecurityPolicyIssue.ContentSecurityPolicyIssue): DirectiveRow {
171
234
  const cspIssueDetails = cspIssue.details();
172
235
  const location = IssuesManager.Issue.toZeroBasedLocation(cspIssueDetails.sourceCodeLocation);
173
236
  const model = cspIssue.model();
174
- const maybeTarget = cspIssue.model()?.getTargetIfNotDisposed();
175
- if (this.issue.code() === IssuesManager.ContentSecurityPolicyIssue.inlineViolationCode && model) {
176
- this.#appendViolatedDirective(element, cspIssueDetails.violatedDirective);
177
- this.#appendBlockedElement(element, cspIssueDetails.violatingNodeId, model);
178
- this.appendSourceLocation(element, location, maybeTarget);
179
- this.#appendStatus(element, cspIssueDetails.isReportOnly);
180
- } else if (this.issue.code() === IssuesManager.ContentSecurityPolicyIssue.urlViolationCode) {
181
- const url = cspIssueDetails.blockedURL ? cspIssueDetails.blockedURL as Platform.DevToolsPath.UrlString :
182
- Platform.DevToolsPath.EmptyUrlString;
183
- this.#appendBlockedURL(element, url);
184
- this.#appendStatus(element, cspIssueDetails.isReportOnly);
185
- this.#appendViolatedDirective(element, cspIssueDetails.violatedDirective);
186
- this.appendSourceLocation(element, location, maybeTarget);
187
- } else if (this.issue.code() === IssuesManager.ContentSecurityPolicyIssue.evalViolationCode) {
188
- this.appendSourceLocation(element, location, maybeTarget);
189
- this.#appendViolatedDirective(element, cspIssueDetails.violatedDirective);
190
- this.#appendStatus(element, cspIssueDetails.isReportOnly);
191
- } else if (this.issue.code() === IssuesManager.ContentSecurityPolicyIssue.trustedTypesSinkViolationCode) {
192
- this.appendSourceLocation(element, location, maybeTarget);
193
- this.#appendStatus(element, cspIssueDetails.isReportOnly);
194
- } else if (this.issue.code() === IssuesManager.ContentSecurityPolicyIssue.trustedTypesPolicyViolationCode) {
195
- this.appendSourceLocation(element, location, maybeTarget);
196
- this.#appendViolatedDirective(element, cspIssueDetails.violatedDirective);
197
- this.#appendStatus(element, cspIssueDetails.isReportOnly);
198
- } else {
199
- return;
237
+ const maybeTarget = model?.getTargetIfNotDisposed();
238
+ let sourceLocation: SourceLocationData|undefined;
239
+ if (location) {
240
+ sourceLocation = {
241
+ target: maybeTarget || null,
242
+ scriptId: location.scriptId || null,
243
+ url: location.url as Platform.DevToolsPath.UrlString,
244
+ lineNumber: location.lineNumber,
245
+ columnNumber: location.columnNumber,
246
+ };
200
247
  }
201
-
202
- this.affectedResources.appendChild(element);
248
+ const blockedURL = cspIssueDetails.blockedURL ? cspIssueDetails.blockedURL as Platform.DevToolsPath.UrlString :
249
+ Platform.DevToolsPath.EmptyUrlString;
250
+ const nodeId = cspIssueDetails.violatingNodeId;
251
+ let elementsPanelLinkData: IssuesComponents.ElementsPanelLink.ElementsPanelLinkData|undefined;
252
+ if (model && nodeId) {
253
+ const category = this.issue.getCategory();
254
+ elementsPanelLinkData = {
255
+ onElementRevealIconClick: () => {
256
+ const sdkTarget = model.getTargetIfNotDisposed();
257
+ if (sdkTarget) {
258
+ Host.userMetrics.issuesPanelResourceOpened(category, AffectedItem.ELEMENT);
259
+ const deferredDOMNode = new SDK.DOMModel.DeferredDOMNode(sdkTarget, nodeId);
260
+ void Common.Revealer.reveal(deferredDOMNode);
261
+ }
262
+ },
263
+ onElementRevealIconMouseEnter: () => {
264
+ const sdkTarget = model.getTargetIfNotDisposed();
265
+ if (sdkTarget) {
266
+ const deferredDOMNode = new SDK.DOMModel.DeferredDOMNode(sdkTarget, nodeId);
267
+ if (deferredDOMNode) {
268
+ deferredDOMNode.highlight();
269
+ }
270
+ }
271
+ },
272
+ onElementRevealIconMouseLeave: () => {
273
+ SDK.OverlayModel.OverlayModel.hideDOMNodeHighlight(SDK.TargetManager.TargetManager.instance());
274
+ },
275
+ };
276
+ }
277
+ return {
278
+ violatedDirective: cspIssueDetails.violatedDirective,
279
+ isReportOnly: cspIssueDetails.isReportOnly,
280
+ blockedURL,
281
+ sourceLocation,
282
+ hasModel: Boolean(model),
283
+ elementsPanelLinkData,
284
+ };
203
285
  }
204
286
 
205
287
  update(): void {
206
- this.clear();
288
+ this.requestResolver.clear();
289
+ this.#linkifier.reset();
207
290
  this.#appendAffectedContentSecurityPolicyDetails(this.issue.getCspIssues());
208
291
  }
209
292
  }
@@ -1,14 +1,19 @@
1
1
  // Copyright 2021 The Chromium Authors
2
2
  // Use of this source code is governed by a BSD-style license that can be
3
3
  // found in the LICENSE file.
4
- /* eslint-disable @devtools/no-imperative-dom-api */
5
4
 
5
+ import * as Host from '../../core/host/host.js';
6
6
  import * as i18n from '../../core/i18n/i18n.js';
7
7
  import type * as Platform from '../../core/platform/platform.js';
8
8
  import * as SDK from '../../core/sdk/sdk.js';
9
+ import type * as Protocol from '../../generated/protocol.js';
9
10
  import type * as IssuesManager from '../../models/issues_manager/issues_manager.js';
11
+ import {html, type LitTemplate, render} from '../../ui/lit/lit.js';
12
+ import * as PanelsCommon from '../common/common.js';
10
13
 
11
14
  import {AffectedElementsView} from './AffectedElementsView.js';
15
+ import {AffectedItem} from './AffectedResourcesView.js';
16
+ import type {IssueView} from './IssueView.js';
12
17
 
13
18
  const UIStrings = {
14
19
  /**
@@ -27,56 +32,101 @@ const UIStrings = {
27
32
  * @description Column header in the Issues panel for document quirks mode in the quirks mode affected documents table.
28
33
  */
29
34
  mode: 'Mode',
35
+ /**
36
+ * @description Fallback text in the Issues panel when an HTML element is unavailable in the affected resources table.
37
+ */
38
+ unavailable: 'Unavailable',
30
39
  } as const;
31
40
  const str_ = i18n.i18n.registerUIStrings('panels/issues/AffectedDocumentsInQuirksModeView.ts', UIStrings);
32
41
  const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
33
42
 
43
+ export interface QuirksModeRow {
44
+ nodeName: string;
45
+ backendNodeId: Protocol.DOM.BackendNodeId;
46
+ target: SDK.Target.Target|null;
47
+ onElementClick: () => void;
48
+ mode: string;
49
+ url: string;
50
+ }
51
+
52
+ export interface ViewInput {
53
+ rows: QuirksModeRow[];
54
+ }
55
+
56
+ export type View = (input: ViewInput, _output: undefined, target: HTMLElement) => void;
57
+
58
+ export const DEFAULT_VIEW: View = (input, _output, target) => {
59
+ const renderElementCell = (row: QuirksModeRow): LitTemplate => {
60
+ if (!row.target) {
61
+ return html`<td>${row.nodeName || i18nString(UIStrings.unavailable)}</td>`;
62
+ }
63
+ const deferredDOMNode = new SDK.DOMModel.DeferredDOMNode(row.target, row.backendNodeId);
64
+ // clang-format off
65
+ return html`
66
+ <td class="affected-resource-element devtools-link">
67
+ ${PanelsCommon.DOMLinkifier.Linkifier.instance().linkify(
68
+ deferredDOMNode, {textContent: row.nodeName || undefined, onClick: row.onElementClick})}
69
+ </td>
70
+ `;
71
+ // clang-format on
72
+ };
73
+
74
+ // clang-format off
75
+ render(html`
76
+ <tr>
77
+ <td class="affected-resource-header">${i18nString(UIStrings.documentInTheDOMTree)}</td>
78
+ <td class="affected-resource-header">${i18nString(UIStrings.mode)}</td>
79
+ <td class="affected-resource-header">${i18nString(UIStrings.url)}</td>
80
+ </tr>
81
+ ${input.rows.map(row => html`
82
+ <tr class="affected-resource-quirks-mode">
83
+ ${renderElementCell(row)}
84
+ <td>${row.mode}</td>
85
+ <td>${row.url}</td>
86
+ </tr>
87
+ `)}
88
+ `, target);
89
+ // clang-format on
90
+ };
91
+
34
92
  export class AffectedDocumentsInQuirksModeView extends AffectedElementsView {
35
- #runningUpdatePromise: Promise<void> = Promise.resolve();
93
+ readonly #view: View;
94
+
95
+ constructor(parent: IssueView, issue: IssuesManager.IssueAggregator.AggregatedIssue, jslogContext: string,
96
+ view: View = DEFAULT_VIEW) {
97
+ super(parent, issue, jslogContext);
98
+ this.#view = view;
99
+ }
36
100
 
37
101
  override update(): void {
38
- // Ensure that doUpdate is invoked atomically by serializing the update calls
39
- // because it's not re-entrace safe.
40
- this.#runningUpdatePromise = this.#runningUpdatePromise.then(this.#doUpdate.bind(this));
102
+ this.requestResolver.clear();
103
+ this.#appendQuirksModeDocuments(this.issue.getQuirksModeIssues());
41
104
  }
42
105
 
43
106
  protected getResourceName(count: number): Platform.UIString.LocalizedString {
44
107
  return i18nString(UIStrings.nDocuments, {n: count});
45
108
  }
46
109
 
47
- async #doUpdate(): Promise<void> {
48
- this.clear();
49
- await this.#appendQuirksModeDocuments(this.issue.getQuirksModeIssues());
50
- }
51
-
52
- async #appendQuirksModeDocument(issue: IssuesManager.QuirksModeIssue.QuirksModeIssue): Promise<void> {
53
- const row = document.createElement('tr');
54
- row.classList.add('affected-resource-quirks-mode');
55
-
110
+ #createQuirksModeDocumentRow(issue: IssuesManager.QuirksModeIssue.QuirksModeIssue): QuirksModeRow {
56
111
  const details = issue.details();
57
-
58
112
  const target =
59
113
  SDK.FrameManager.FrameManager.instance().getFrame(details.frameId)?.resourceTreeModel().target() || null;
60
- row.appendChild(await this.createElementCell(
61
- {nodeName: 'document', backendNodeId: details.documentNodeId, target}, issue.getCategory()));
62
- this.appendIssueDetailCell(row, details.isLimitedQuirksMode ? 'Limited Quirks Mode' : 'Quirks Mode');
63
- this.appendIssueDetailCell(row, details.url);
64
-
65
- this.affectedResources.appendChild(row);
114
+ const category = issue.getCategory();
115
+ return {
116
+ nodeName: 'document',
117
+ backendNodeId: details.documentNodeId,
118
+ target,
119
+ onElementClick: () => {
120
+ Host.userMetrics.issuesPanelResourceOpened(category, AffectedItem.ELEMENT);
121
+ },
122
+ mode: details.isLimitedQuirksMode ? 'Limited Quirks Mode' : 'Quirks Mode',
123
+ url: details.url,
124
+ };
66
125
  }
67
126
 
68
- async #appendQuirksModeDocuments(issues: Iterable<IssuesManager.QuirksModeIssue.QuirksModeIssue>): Promise<void> {
69
- const header = document.createElement('tr');
70
- this.appendColumnTitle(header, i18nString(UIStrings.documentInTheDOMTree));
71
- this.appendColumnTitle(header, i18nString(UIStrings.mode));
72
- this.appendColumnTitle(header, i18nString(UIStrings.url));
73
-
74
- this.affectedResources.appendChild(header);
75
- let count = 0;
76
- for (const issue of issues) {
77
- count++;
78
- await this.#appendQuirksModeDocument(issue);
79
- }
80
- this.updateAffectedResourceCount(count);
127
+ #appendQuirksModeDocuments(issues: Iterable<IssuesManager.QuirksModeIssue.QuirksModeIssue>): void {
128
+ const rows = Array.from(issues, issue => this.#createQuirksModeDocumentRow(issue));
129
+ this.#view({rows}, undefined, this.affectedResources);
130
+ this.updateAffectedResourceCount(rows.length);
81
131
  }
82
132
  }