chrome-devtools-frontend 1.0.1726686 → 1.0.1730971

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (490) hide show
  1. package/.agents/rules/tests/test-strict-assertions-and-literal-expectations.md +1 -1
  2. package/.agents/rules/tests/test-view-and-presenter-isolation.md +1 -1
  3. package/.agents/rules/ui-and-widgets/ui-accessibility-and-semantic-html.md +1 -1
  4. package/.agents/rules/ui-and-widgets/ui-css-scoping-and-flex-layout.md +2 -2
  5. package/.agents/rules/ui-and-widgets/ui-declarative-child-widget-composition.md +5 -5
  6. package/.agents/rules/ui-and-widgets/ui-lit-declarative-templates-and-directives.md +2 -2
  7. package/.agents/rules/ui-and-widgets/ui-localization-and-uistrings-hygiene.md +2 -2
  8. package/.agents/rules/ui-and-widgets/ui-modern-component-and-encapsulation-standards.md +3 -3
  9. package/.agents/rules/ui-and-widgets/ui-pure-view-and-presenter-separation.md +2 -2
  10. package/.agents/rules/ui-and-widgets/ui-reactive-widget-update-lifecycle.md +2 -2
  11. package/.agents/rules/ui-and-widgets/ui-view-output-and-callback-contracts.md +2 -2
  12. package/.agents/rules/ui-and-widgets/ui-widget-dom-and-listener-lifecycle.md +2 -2
  13. package/.agents/skills/code-review/SKILL.md +63 -12
  14. package/.agents/skills/ui-eng-vision-local-lit-renderer/SKILL.md +38 -10
  15. package/.agents/skills/ui-eng-vision-widget-promoter/SKILL.md +1 -0
  16. package/.agents/skills/ui-widgets/SKILL.md +8 -2
  17. package/.agents/skills/write-ai-eval-test/SKILL.md +106 -0
  18. package/AUTHORS +2 -0
  19. package/DIR_METADATA +1 -2
  20. package/README.md +48 -26
  21. package/config/typescript/tsconfig.base.json +1 -0
  22. package/config/typescript/tsconfig.eslint.json +1 -0
  23. package/docs/contributing/changes.md +25 -0
  24. package/docs/ui_engineering.md +13 -4
  25. package/eslint.config.mjs +323 -41
  26. package/front_end/core/common/Color.ts +7 -7
  27. package/front_end/core/common/ParsedURL.ts +3 -3
  28. package/front_end/core/common/ResolverBase.ts +3 -3
  29. package/front_end/core/common/SegmentedRange.ts +3 -3
  30. package/front_end/core/common/SimpleHistoryManager.ts +14 -14
  31. package/front_end/core/common/Trie.ts +3 -3
  32. package/front_end/core/common/VersionController.ts +7 -7
  33. package/front_end/core/host/InspectorFrontendHost.ts +2 -2
  34. package/front_end/core/host/InspectorFrontendHostAPI.ts +9 -1
  35. package/front_end/core/host/InspectorFrontendHostStub.ts +1 -1
  36. package/front_end/core/host/UserMetrics.ts +4 -0
  37. package/front_end/core/host/UserMetricsEnums.ts +2 -1
  38. package/front_end/core/platform/StringUtilities.ts +54 -13
  39. package/front_end/core/platform/node/HostRuntime.ts +13 -7
  40. package/front_end/core/protocol_client/DevToolsCDPConnection.ts +4 -5
  41. package/front_end/core/root/Runtime.ts +5 -0
  42. package/front_end/core/sdk/AccessibilityModel.ts +5 -5
  43. package/front_end/core/sdk/AnimationModel.ts +17 -19
  44. package/front_end/core/sdk/CPUProfilerModel.ts +3 -3
  45. package/front_end/core/sdk/CPUThrottlingManager.ts +7 -0
  46. package/front_end/core/sdk/CSSMatchedStyles.ts +73 -13
  47. package/front_end/core/sdk/CSSMetadata.ts +7 -7
  48. package/front_end/core/sdk/CSSModel.ts +33 -33
  49. package/front_end/core/sdk/CSSProperty.ts +5 -5
  50. package/front_end/core/sdk/CSSRule.ts +6 -6
  51. package/front_end/core/sdk/CSSStyleSheetHeader.ts +4 -4
  52. package/front_end/core/sdk/Connections.ts +16 -16
  53. package/front_end/core/sdk/ConsoleModel.ts +44 -47
  54. package/front_end/core/sdk/CookieParser.ts +11 -11
  55. package/front_end/core/sdk/EmulationModel.ts +35 -36
  56. package/front_end/core/sdk/EventBreakpointsModel.ts +11 -11
  57. package/front_end/core/sdk/FrameManager.ts +16 -16
  58. package/front_end/core/sdk/IsolateManager.ts +2 -2
  59. package/front_end/core/sdk/IssuesModel.ts +2 -2
  60. package/front_end/core/sdk/OverlayModel.ts +19 -19
  61. package/front_end/core/sdk/PageResourceLoader.ts +14 -16
  62. package/front_end/core/sdk/RemoteObject.ts +9 -9
  63. package/front_end/core/sdk/Resource.ts +2 -2
  64. package/front_end/core/sdk/RuntimeModel.ts +7 -7
  65. package/front_end/core/sdk/Script.ts +6 -6
  66. package/front_end/core/sdk/ServiceWorkerManager.ts +36 -10
  67. package/front_end/core/sdk/SourceMap.ts +18 -20
  68. package/front_end/core/sdk/SourceMapManager.ts +2 -2
  69. package/front_end/core/sdk/TargetManager.ts +2 -2
  70. package/front_end/devtools_compatibility.js +7 -3
  71. package/front_end/entrypoints/inspector_main/InspectorMain.ts +2 -2
  72. package/front_end/entrypoints/node_app/app/NodeConnectionsPanel.ts +203 -115
  73. package/front_end/generated/InspectorBackendCommands.ts +1 -1
  74. package/front_end/generated/SupportedCSSProperties.ts +1 -3
  75. package/front_end/generated/protocol.ts +1 -0
  76. package/front_end/models/ai_assistance/AiAgent2.ts +36 -12
  77. package/front_end/models/ai_assistance/AiConversation.ts +8 -2
  78. package/front_end/models/ai_assistance/agents/AiAgent.ts +137 -62
  79. package/front_end/models/ai_assistance/agents/ExecuteJavascript.ts +2 -2
  80. package/front_end/models/ai_assistance/agents/StylingAgent.snapshot.txt +2 -2
  81. package/front_end/models/ai_assistance/data_formatters/LighthouseFormatter.snapshot.txt +149 -2
  82. package/front_end/models/ai_assistance/data_formatters/LighthouseFormatter.ts +269 -42
  83. package/front_end/models/ai_assistance/tools/ExecuteJavaScript.ts +3 -0
  84. package/front_end/models/ai_assistance/tools/GetLighthouseAudits.ts +9 -0
  85. package/front_end/models/ai_assistance/tools/ResolveDevtoolsNodePath.ts +13 -2
  86. package/front_end/models/ai_assistance/tools/RunLighthouse.ts +23 -7
  87. package/front_end/models/ai_assistance/tools/Tool.ts +7 -5
  88. package/front_end/models/bindings/CSSWorkspaceBinding.ts +22 -24
  89. package/front_end/models/bindings/DebuggerLanguagePlugins.ts +60 -60
  90. package/front_end/models/bindings/DebuggerWorkspaceBinding.ts +24 -24
  91. package/front_end/models/bindings/DefaultScriptMapping.ts +8 -8
  92. package/front_end/models/bindings/FileUtils.ts +13 -13
  93. package/front_end/models/bindings/PresentationConsoleMessageHelper.ts +3 -3
  94. package/front_end/models/bindings/ResourceScriptMapping.ts +23 -23
  95. package/front_end/models/comment_manager/CommentManager.ts +3 -3
  96. package/front_end/models/comment_manager/CommentThread.ts +50 -5
  97. package/front_end/models/cpu_profile/CPUProfileDataModel.ts +14 -14
  98. package/front_end/models/cpu_profile/ProfileTreeModel.ts +4 -4
  99. package/front_end/models/elements/StyleChanges.ts +38 -0
  100. package/front_end/models/emulation/EmulatedDevices.ts +12 -12
  101. package/front_end/models/har/HARFormat.ts +4 -4
  102. package/front_end/models/javascript_metadata/NativeFunctions.ts +5 -1
  103. package/front_end/models/lighthouse/LighthouseReporterTypes.ts +57 -3
  104. package/front_end/models/lighthouse/RunTypes.ts +9 -1
  105. package/front_end/models/logs/LogManager.ts +2 -2
  106. package/front_end/models/persistence/AutomaticFileSystemManager.ts +3 -0
  107. package/front_end/models/persistence/FileSystemWorkspaceBinding.ts +24 -24
  108. package/front_end/models/persistence/IsolatedFileSystemManager.ts +6 -0
  109. package/front_end/models/persistence/NetworkPersistenceManager.ts +8 -3
  110. package/front_end/models/trace/LanternComputationData.ts +37 -11
  111. package/front_end/models/trace/Processor.ts +2 -1
  112. package/front_end/models/trace/extras/TraceTree.ts +36 -10
  113. package/front_end/models/trace/handlers/InitiatorsHandler.ts +27 -34
  114. package/front_end/models/trace/handlers/LayoutShiftsHandler.ts +2 -6
  115. package/front_end/models/trace/handlers/SamplesHandler.ts +9 -6
  116. package/front_end/models/workspace/FileManager.ts +6 -0
  117. package/front_end/panels/accessibility/ARIAAttributesView.ts +4 -4
  118. package/front_end/panels/accessibility/AccessibilityAnnouncementRecordingView.ts +8 -1
  119. package/front_end/panels/accessibility/AccessibilityNodeView.ts +15 -17
  120. package/front_end/panels/accessibility/AccessibilitySubPane.ts +1 -1
  121. package/front_end/panels/ai_assistance/AiAssistancePanel.ts +5 -5
  122. package/front_end/panels/ai_assistance/ExternalHandler.ts +10 -1
  123. package/front_end/panels/ai_assistance/components/ChatMessage.ts +27 -22
  124. package/front_end/panels/ai_assistance/components/DisabledWidget.ts +19 -23
  125. package/front_end/panels/ai_assistance/components/ExploreWidget.ts +2 -2
  126. package/front_end/panels/ai_assistance/components/PermissionPrompt.ts +23 -9
  127. package/front_end/panels/ai_assistance/components/chatInput.css +1 -1
  128. package/front_end/panels/animation/AnimationTimeline.ts +37 -17
  129. package/front_end/panels/animation/animationTimeline.css +19 -3
  130. package/front_end/panels/application/AppManifestView.ts +1 -2
  131. package/front_end/panels/application/ApplicationPanelSidebar.ts +143 -128
  132. package/front_end/panels/application/DOMStorageItemsView.ts +14 -14
  133. package/front_end/panels/application/DeviceBoundSessionsView.ts +10 -13
  134. package/front_end/panels/application/ExtensionStorageItemsView.ts +3 -4
  135. package/front_end/panels/application/IndexedDBViews.ts +8 -4
  136. package/front_end/panels/application/KeyValueStorageItemsView.ts +4 -5
  137. package/front_end/panels/application/PrivateVerificationTokensView.ts +53 -0
  138. package/front_end/panels/application/ServiceWorkerCacheViews.ts +12 -8
  139. package/front_end/panels/application/ServiceWorkersView.ts +1 -2
  140. package/front_end/panels/application/StorageItemsToolbar.ts +3 -3
  141. package/front_end/panels/application/StorageView.ts +2 -2
  142. package/front_end/panels/application/WebMCPView.ts +91 -109
  143. package/front_end/panels/application/application.ts +2 -0
  144. package/front_end/panels/application/components/StorageMetadataView.ts +6 -6
  145. package/front_end/panels/application/preloading/PreloadingView.ts +70 -37
  146. package/front_end/panels/application/preloading/components/MismatchedPreloadingGrid.ts +2 -2
  147. package/front_end/panels/application/preloading/components/PreloadingDisabledInfobar.ts +3 -3
  148. package/front_end/panels/application/preloading/components/PreloadingGrid.ts +12 -0
  149. package/front_end/panels/application/preloading/components/RuleSetDetailsView.ts +10 -11
  150. package/front_end/panels/application/privateVerificationTokensView.css +20 -0
  151. package/front_end/panels/application/serviceWorkersView.css +2 -2
  152. package/front_end/panels/browser_debugger/DOMBreakpointsSidebarPane.ts +24 -24
  153. package/front_end/panels/changes/ChangesSidebar.ts +5 -5
  154. package/front_end/panels/changes/ChangesView.ts +10 -11
  155. package/front_end/panels/comments/CommentsPane.ts +292 -102
  156. package/front_end/panels/comments/commentsPane.css +93 -12
  157. package/front_end/panels/common/CommentThreadWidget.ts +69 -0
  158. package/front_end/panels/common/CommentsOverlayWidget.ts +108 -29
  159. package/front_end/panels/common/CommentsStatusBarPill.ts +17 -6
  160. package/front_end/panels/common/DOMLinkifier.ts +37 -12
  161. package/front_end/panels/common/ExtensionPanel.ts +13 -4
  162. package/front_end/panels/common/ExtensionServer.ts +27 -3
  163. package/front_end/panels/common/PersistenceUtils.ts +3 -3
  164. package/front_end/panels/common/commentThreadWidget.css +25 -1
  165. package/front_end/panels/common/common-meta.ts +10 -0
  166. package/front_end/panels/console/ConsolePinPane.ts +13 -15
  167. package/front_end/panels/console/ConsolePrompt.ts +173 -95
  168. package/front_end/panels/console/ConsoleSidebar.ts +2 -2
  169. package/front_end/panels/console/ConsoleView.ts +75 -79
  170. package/front_end/panels/console/ConsoleViewMessage.ts +52 -4
  171. package/front_end/panels/console/SymbolizedErrorWidget.ts +8 -4
  172. package/front_end/panels/console/consolePrompt.css +1 -1
  173. package/front_end/panels/console/consoleView.css +1 -1
  174. package/front_end/panels/console_counters/WarningErrorCounter.ts +3 -4
  175. package/front_end/panels/coverage/CoverageListView.ts +2 -2
  176. package/front_end/panels/coverage/CoverageView.ts +20 -5
  177. package/front_end/panels/css_overview/CSSOverviewCompletedView.ts +4 -3
  178. package/front_end/panels/css_overview/CSSOverviewPanel.ts +2 -2
  179. package/front_end/panels/css_overview/CSSOverviewProcessingView.ts +2 -2
  180. package/front_end/panels/css_overview/CSSOverviewSidebarPanel.ts +2 -2
  181. package/front_end/panels/css_overview/CSSOverviewStartView.ts +2 -2
  182. package/front_end/panels/css_overview/CSSOverviewUnusedDeclarations.ts +8 -8
  183. package/front_end/panels/developer_resources/DeveloperResourcesListView.ts +2 -3
  184. package/front_end/panels/developer_resources/DeveloperResourcesView.ts +4 -5
  185. package/front_end/panels/elements/AccessibilityTreeUtils.ts +6 -7
  186. package/front_end/panels/elements/CSSValueTraceView.ts +3 -3
  187. package/front_end/panels/elements/ClassesPaneWidget.ts +1 -2
  188. package/front_end/panels/elements/ComputedStyleWidget.ts +15 -14
  189. package/front_end/panels/elements/DOMTreeElementWidget.ts +5 -4
  190. package/front_end/panels/elements/DOMTreeWidget.ts +2 -1
  191. package/front_end/panels/elements/ElementStatePaneWidget.ts +2 -2
  192. package/front_end/panels/elements/ElementsPanel.ts +1 -0
  193. package/front_end/panels/elements/EventListenersWidget.ts +2 -2
  194. package/front_end/panels/elements/LayoutPane.ts +2 -2
  195. package/front_end/panels/elements/PlatformFontsWidget.ts +3 -3
  196. package/front_end/panels/elements/PropertiesWidget.ts +9 -10
  197. package/front_end/panels/elements/PropertyRenderer.ts +72 -11
  198. package/front_end/panels/elements/StandaloneStylesContainer.ts +5 -10
  199. package/front_end/panels/elements/StyleEditorWidget.ts +30 -16
  200. package/front_end/panels/elements/StylePropertiesSection.ts +93 -44
  201. package/front_end/panels/elements/StylePropertyTreeElement.ts +230 -302
  202. package/front_end/panels/elements/StylesContainer.ts +2 -3
  203. package/front_end/panels/elements/StylesSidebarPane.ts +4 -13
  204. package/front_end/panels/elements/components/AccessibilityTreeNode.ts +66 -37
  205. package/front_end/panels/elements/components/CSSHintDetailsView.ts +51 -41
  206. package/front_end/panels/elements/components/CSSPropertyDocsView.ts +75 -65
  207. package/front_end/panels/elements/components/CSSQuery.ts +112 -74
  208. package/front_end/panels/elements/components/CSSVariableValueView.ts +109 -68
  209. package/front_end/panels/elements/components/ComputedStyleProperty.ts +64 -45
  210. package/front_end/panels/elements/components/ElementsTreeExpandButton.ts +35 -28
  211. package/front_end/panels/elements/components/QueryContainer.ts +104 -74
  212. package/front_end/panels/elements/components/accessibilityTreeNode.css +22 -20
  213. package/front_end/panels/elements/components/computedStyleProperty.css +2 -0
  214. package/front_end/panels/elements/components/cssHintDetailsView.css +23 -21
  215. package/front_end/panels/elements/components/cssPropertyDocsView.css +38 -36
  216. package/front_end/panels/elements/components/cssVariableValueView.css +42 -40
  217. package/front_end/panels/elements/components/elementsTreeExpandButton.css +5 -2
  218. package/front_end/panels/elements/components/queryContainer.css +23 -21
  219. package/front_end/panels/elements/stylesSidebarPane.css +3 -3
  220. package/front_end/panels/emulation/DeviceModeToolbar.ts +2 -2
  221. package/front_end/panels/emulation/InspectedPagePlaceholder.ts +2 -2
  222. package/front_end/panels/emulation/MediaQueryInspector.ts +9 -10
  223. package/front_end/panels/emulation/mediaQueryInspector.css +1 -1
  224. package/front_end/panels/event_listeners/EventListenersView.ts +2 -2
  225. package/front_end/panels/issues/AffectedCookiesView.ts +144 -101
  226. package/front_end/panels/issues/AffectedDescendantsWithinSelectElementView.ts +83 -31
  227. package/front_end/panels/issues/AffectedDirectivesView.ts +218 -135
  228. package/front_end/panels/issues/AffectedDocumentsInQuirksModeView.ts +84 -34
  229. package/front_end/panels/issues/AffectedElementsView.ts +86 -23
  230. package/front_end/panels/issues/AffectedLazyLoadImagesView.ts +2 -2
  231. package/front_end/panels/issues/AffectedMetadataAllowedSitesView.ts +2 -2
  232. package/front_end/panels/issues/AffectedPartitioningBlobURLView.ts +36 -11
  233. package/front_end/panels/issues/AffectedSharedArrayBufferIssueDetailsView.ts +135 -58
  234. package/front_end/panels/issues/AffectedSourcesView.ts +49 -28
  235. package/front_end/panels/issues/AffectedTrackingSitesView.ts +3 -4
  236. package/front_end/panels/issues/CorsIssueDetailsView.ts +490 -269
  237. package/front_end/panels/issues/GenericIssueDetailsView.ts +2 -2
  238. package/front_end/panels/issues/IssueKindView.ts +63 -48
  239. package/front_end/panels/issues/IssueView.ts +14 -18
  240. package/front_end/panels/issues/components/ElementsPanelLink.ts +70 -34
  241. package/front_end/panels/issues/components/HideIssuesMenu.ts +56 -32
  242. package/front_end/panels/issues/components/elementsPanelLink.css +10 -6
  243. package/front_end/panels/issues/components/hideIssuesMenu.css +16 -14
  244. package/front_end/panels/issues/issues.ts +2 -0
  245. package/front_end/panels/issues/issuesTree.css +4 -4
  246. package/front_end/panels/lighthouse/LighthouseController.ts +6 -6
  247. package/front_end/panels/lighthouse/LighthouseStatusView.ts +12 -13
  248. package/front_end/panels/lighthouse/lighthouseStartView.css +1 -1
  249. package/front_end/panels/linear_memory_inspector/LinearMemoryInspectorPane.ts +159 -161
  250. package/front_end/panels/linear_memory_inspector/LinearMemoryInspectorView.ts +228 -0
  251. package/front_end/panels/linear_memory_inspector/components/LinearMemoryInspector.ts +32 -41
  252. package/front_end/panels/linear_memory_inspector/components/linearMemoryHighlightChipList.css +2 -2
  253. package/front_end/panels/linear_memory_inspector/linear_memory_inspector.ts +2 -0
  254. package/front_end/panels/media/EventDisplayTable.ts +2 -2
  255. package/front_end/panels/media/MainView.ts +132 -66
  256. package/front_end/panels/media/PlayerDetailView.ts +32 -14
  257. package/front_end/panels/media/PlayerListView.ts +83 -23
  258. package/front_end/panels/media/PlayerPropertiesView.ts +2 -2
  259. package/front_end/panels/media/TickingFlameChart.ts +153 -63
  260. package/front_end/panels/mobile_throttling/NetworkThrottlingSelector.ts +2 -2
  261. package/front_end/panels/mobile_throttling/ThrottlingSettingsTab.ts +615 -464
  262. package/front_end/panels/mobile_throttling/throttlingSettingsTab.css +43 -0
  263. package/front_end/panels/network/EventSourceMessagesView.ts +3 -3
  264. package/front_end/panels/network/NetworkConfigView.ts +6 -2
  265. package/front_end/panels/network/NetworkDataGridNode.ts +2 -1
  266. package/front_end/panels/network/NetworkItemView.ts +27 -26
  267. package/front_end/panels/network/NetworkManageCustomHeadersView.ts +236 -97
  268. package/front_end/panels/network/NetworkOverview.ts +8 -10
  269. package/front_end/panels/network/RequestConditionsDrawer.ts +8 -4
  270. package/front_end/panels/network/RequestDeviceBoundSessionsView.ts +2 -4
  271. package/front_end/panels/network/RequestHTMLView.ts +26 -7
  272. package/front_end/panels/network/RequestHeadersView.ts +2 -2
  273. package/front_end/panels/network/RequestInitiatorView.ts +21 -22
  274. package/front_end/panels/network/RequestPayloadView.ts +2 -16
  275. package/front_end/panels/network/RequestPreviewView.ts +5 -5
  276. package/front_end/panels/network/RequestTimingView.ts +6 -6
  277. package/front_end/panels/network/ResourceDirectSocketChunkView.ts +5 -6
  278. package/front_end/panels/network/ResourceWebSocketFrameView.ts +4 -3
  279. package/front_end/panels/network/ShowMoreDetailsWidget.ts +11 -12
  280. package/front_end/panels/network/SignedExchangeInfoView.ts +2 -2
  281. package/front_end/panels/network/networkLogView.css +2 -2
  282. package/front_end/panels/network/networkManageCustomHeadersView.css +27 -6
  283. package/front_end/panels/network/requestConditionsDrawer.css +1 -1
  284. package/front_end/panels/network/requestInitiatorView.css +5 -3
  285. package/front_end/panels/performance_monitor/PerformanceMonitor.ts +2 -2
  286. package/front_end/panels/profiler/HeapDetachedElementsView.ts +1 -2
  287. package/front_end/panels/profiler/HeapTimelineOverview.ts +77 -15
  288. package/front_end/panels/profiler/IsolateSelector.ts +258 -187
  289. package/front_end/panels/profiler/ProfileLauncherView.ts +7 -29
  290. package/front_end/panels/profiler/profileLauncherView.css +6 -1
  291. package/front_end/panels/protocol_monitor/JSONEditor.ts +4 -5
  292. package/front_end/panels/recorder/ControlButton.ts +1 -1
  293. package/front_end/panels/recorder/RecordingListView.ts +2 -4
  294. package/front_end/panels/recorder/RecordingView.ts +1 -2
  295. package/front_end/panels/recorder/SelectorPicker.ts +2 -4
  296. package/front_end/panels/recorder/StepView.ts +24 -10
  297. package/front_end/panels/recorder/TimelineSection.ts +1 -1
  298. package/front_end/panels/recorder/recordingView.css +1 -1
  299. package/front_end/panels/screencast/ScreencastApp.ts +1 -1
  300. package/front_end/panels/search/SearchResultsPane.ts +11 -12
  301. package/front_end/panels/search/SearchView.ts +8 -10
  302. package/front_end/panels/security/SecurityPanel.ts +1 -8
  303. package/front_end/panels/security/SecurityPanelSidebar.ts +2 -2
  304. package/front_end/panels/security/mainView.css +1 -1
  305. package/front_end/panels/sensors/LocationsSettingsTab.ts +1 -2
  306. package/front_end/panels/settings/AISettingsTab.ts +1 -1
  307. package/front_end/panels/settings/BackendLinkingSettingsTab.ts +34 -20
  308. package/front_end/panels/settings/EditFileSystemView.ts +2 -2
  309. package/front_end/panels/settings/FrameworkIgnoreListSettingsTab.ts +375 -197
  310. package/front_end/panels/settings/KeybindsSettingsTab.ts +570 -414
  311. package/front_end/panels/settings/SettingsScreen.ts +312 -114
  312. package/front_end/panels/settings/WorkspaceSettingsTab.ts +2 -2
  313. package/front_end/panels/settings/aiSettingsTab.css +1 -4
  314. package/front_end/panels/settings/emulation/DevicesSettingsTab.ts +924 -578
  315. package/front_end/panels/settings/emulation/components/UserAgentClientHintsForm.ts +9 -2
  316. package/front_end/panels/settings/emulation/devicesSettingsTab.css +39 -0
  317. package/front_end/panels/settings/frameworkIgnoreListSettingsTab.css +37 -8
  318. package/front_end/panels/settings/settingsScreen.css +0 -24
  319. package/front_end/panels/sources/BreakpointEditDialog.ts +9 -6
  320. package/front_end/panels/sources/BreakpointsView.ts +25 -4
  321. package/front_end/panels/sources/CallStackSidebarPane.ts +7 -1
  322. package/front_end/panels/sources/DebuggerPlugin.ts +1 -0
  323. package/front_end/panels/sources/GoToLineQuickOpen.ts +8 -8
  324. package/front_end/panels/sources/NavigatorView.ts +521 -439
  325. package/front_end/panels/sources/PersistenceActions.ts +11 -12
  326. package/front_end/panels/sources/ProfilePlugin.ts +28 -17
  327. package/front_end/panels/sources/ScopeChainSidebarPane.ts +3 -4
  328. package/front_end/panels/sources/SourcesNavigator.ts +9 -9
  329. package/front_end/panels/sources/SourcesPanel.ts +2 -2
  330. package/front_end/panels/sources/SourcesView.ts +3 -3
  331. package/front_end/panels/sources/ThreadsSidebarPane.ts +2 -2
  332. package/front_end/panels/sources/WatchExpressionsSidebarPane.ts +2 -2
  333. package/front_end/panels/sources/components/HeadersView.ts +1 -2
  334. package/front_end/panels/timeline/CompatibilityTracksAppender.ts +5 -6
  335. package/front_end/panels/timeline/EventsTimelineTreeView.ts +73 -34
  336. package/front_end/panels/timeline/IsolateSelector.ts +25 -37
  337. package/front_end/panels/timeline/StatusDialog.ts +5 -7
  338. package/front_end/panels/timeline/ThirdPartyTreeView.ts +10 -13
  339. package/front_end/panels/timeline/TimelineDetailsView.ts +40 -21
  340. package/front_end/panels/timeline/TimelineEventOverview.ts +130 -34
  341. package/front_end/panels/timeline/TimelineFlameChartNetworkDataProvider.ts +1 -1
  342. package/front_end/panels/timeline/TimelineMiniMap.ts +255 -103
  343. package/front_end/panels/timeline/TimelinePaintProfilerView.ts +19 -11
  344. package/front_end/panels/timeline/TimelinePanel.ts +1 -0
  345. package/front_end/panels/timeline/TimelineSelectorStatsView.ts +11 -12
  346. package/front_end/panels/timeline/TimelineTreeView.ts +240 -122
  347. package/front_end/panels/timeline/TimelineUIUtils.ts +12 -0
  348. package/front_end/panels/timeline/components/BreadcrumbsUI.ts +5 -4
  349. package/front_end/panels/timeline/components/DetailsView.ts +97 -65
  350. package/front_end/panels/timeline/components/LayoutShiftDetails.ts +2 -2
  351. package/front_end/panels/timeline/components/MetricCard.ts +2 -2
  352. package/front_end/panels/timeline/components/NetworkRequestDetails.ts +11 -12
  353. package/front_end/panels/timeline/components/NetworkTrackWidget.ts +57 -50
  354. package/front_end/panels/timeline/components/RelatedInsightChips.ts +2 -2
  355. package/front_end/panels/timeline/components/Sidebar.ts +161 -109
  356. package/front_end/panels/timeline/components/SidebarAnnotationsTab.ts +33 -12
  357. package/front_end/panels/timeline/components/SidebarInsightsTab.ts +3 -0
  358. package/front_end/panels/timeline/components/insights/LCPDiscovery.ts +11 -11
  359. package/front_end/panels/timeline/components/insights/SlowCSSSelector.ts +6 -7
  360. package/front_end/panels/timeline/components/networkTrackWidget.css +24 -22
  361. package/front_end/panels/timeline/components/sidebarInsightsTab.css +1 -1
  362. package/front_end/panels/timeline/overlays/components/TimespanBreakdownOverlay.ts +15 -10
  363. package/front_end/panels/timeline/overlays/components/entryLabelOverlay.css +1 -1
  364. package/front_end/panels/timeline/timelinePanel.css +5 -0
  365. package/front_end/panels/timeline/timelineStatusDialog.css +1 -1
  366. package/front_end/panels/web_audio/WebAudioView.ts +2 -2
  367. package/front_end/third_party/chromium/README.chromium +1 -1
  368. package/front_end/third_party/legacy-javascript/README.chromium +2 -2
  369. package/front_end/third_party/legacy-javascript/lib/legacy-javascript.js +2 -2
  370. package/front_end/third_party/legacy-javascript/package.json +1 -1
  371. package/front_end/third_party/lighthouse/README.chromium +2 -2
  372. package/front_end/third_party/lighthouse/lighthouse-dt-bundle.js +1983 -2022
  373. package/front_end/third_party/lighthouse/locales/ar-XB.json +157 -142
  374. package/front_end/third_party/lighthouse/locales/ar.json +157 -142
  375. package/front_end/third_party/lighthouse/locales/bg.json +154 -139
  376. package/front_end/third_party/lighthouse/locales/ca.json +157 -142
  377. package/front_end/third_party/lighthouse/locales/cs.json +148 -133
  378. package/front_end/third_party/lighthouse/locales/da.json +153 -138
  379. package/front_end/third_party/lighthouse/locales/de.json +152 -137
  380. package/front_end/third_party/lighthouse/locales/el.json +153 -138
  381. package/front_end/third_party/lighthouse/locales/en-GB.json +160 -145
  382. package/front_end/third_party/lighthouse/locales/en-US.json +239 -218
  383. package/front_end/third_party/lighthouse/locales/en-XL.json +239 -218
  384. package/front_end/third_party/lighthouse/locales/es-419.json +150 -135
  385. package/front_end/third_party/lighthouse/locales/es.json +149 -134
  386. package/front_end/third_party/lighthouse/locales/fi.json +151 -136
  387. package/front_end/third_party/lighthouse/locales/fil.json +154 -139
  388. package/front_end/third_party/lighthouse/locales/fr.json +150 -135
  389. package/front_end/third_party/lighthouse/locales/he.json +160 -145
  390. package/front_end/third_party/lighthouse/locales/hi.json +156 -141
  391. package/front_end/third_party/lighthouse/locales/hr.json +154 -139
  392. package/front_end/third_party/lighthouse/locales/hu.json +111 -96
  393. package/front_end/third_party/lighthouse/locales/id.json +153 -138
  394. package/front_end/third_party/lighthouse/locales/it.json +153 -138
  395. package/front_end/third_party/lighthouse/locales/ja.json +150 -135
  396. package/front_end/third_party/lighthouse/locales/ko.json +42 -27
  397. package/front_end/third_party/lighthouse/locales/lt.json +152 -137
  398. package/front_end/third_party/lighthouse/locales/lv.json +93 -78
  399. package/front_end/third_party/lighthouse/locales/nl.json +149 -134
  400. package/front_end/third_party/lighthouse/locales/no.json +152 -137
  401. package/front_end/third_party/lighthouse/locales/pl.json +153 -138
  402. package/front_end/third_party/lighthouse/locales/pt-PT.json +152 -137
  403. package/front_end/third_party/lighthouse/locales/pt.json +157 -142
  404. package/front_end/third_party/lighthouse/locales/ro.json +149 -134
  405. package/front_end/third_party/lighthouse/locales/ru.json +76 -61
  406. package/front_end/third_party/lighthouse/locales/sk.json +153 -138
  407. package/front_end/third_party/lighthouse/locales/sl.json +149 -134
  408. package/front_end/third_party/lighthouse/locales/sr-Latn.json +151 -136
  409. package/front_end/third_party/lighthouse/locales/sr.json +151 -136
  410. package/front_end/third_party/lighthouse/locales/sv.json +152 -137
  411. package/front_end/third_party/lighthouse/locales/ta.json +156 -141
  412. package/front_end/third_party/lighthouse/locales/te.json +157 -142
  413. package/front_end/third_party/lighthouse/locales/th.json +111 -96
  414. package/front_end/third_party/lighthouse/locales/tr.json +153 -138
  415. package/front_end/third_party/lighthouse/locales/uk.json +149 -134
  416. package/front_end/third_party/lighthouse/locales/vi.json +162 -147
  417. package/front_end/third_party/lighthouse/locales/zh-HK.json +150 -135
  418. package/front_end/third_party/lighthouse/locales/zh-TW.json +154 -139
  419. package/front_end/third_party/lighthouse/locales/zh.json +152 -137
  420. package/front_end/third_party/lighthouse/report/bundle.d.ts +9 -8
  421. package/front_end/third_party/lighthouse/report/bundle.js +10 -10
  422. package/front_end/third_party/lighthouse/report-assets/report-generator.mjs +2 -7
  423. package/front_end/tsconfig.compatibility.json +1 -0
  424. package/front_end/tsconfig.json +3 -2
  425. package/front_end/ui/components/dialogs/TypeToAllowDialog.ts +0 -2
  426. package/front_end/ui/components/dialogs/typeToAllowDialog.css +0 -4
  427. package/front_end/ui/components/icon_button/fileSourceIcon.css +1 -1
  428. package/front_end/ui/components/input/textInput.css +1 -1
  429. package/front_end/ui/components/lists/List.ts +26 -14
  430. package/front_end/ui/components/menus/menus.ts +0 -2
  431. package/front_end/ui/components/suggestion_input/SuggestionInput.ts +351 -138
  432. package/front_end/ui/components/survey_link/surveyLink.css +3 -3
  433. package/front_end/ui/components/switch/switch.css +6 -6
  434. package/front_end/ui/components/text_editor/AiCodeCompletionTeaser.ts +2 -3
  435. package/front_end/ui/components/text_editor/TextEditor.ts +1 -1
  436. package/front_end/ui/components/tooltips/Tooltip.ts +53 -4
  437. package/front_end/ui/components/tree_outline/treeOutline.css +7 -7
  438. package/front_end/ui/helpers/OpenInNewTab.ts +8 -3
  439. package/front_end/ui/legacy/EmptyWidget.ts +4 -4
  440. package/front_end/ui/legacy/ForwardedInputEventHandler.ts +2 -2
  441. package/front_end/ui/legacy/GlassPane.ts +1 -1
  442. package/front_end/ui/legacy/KeyboardShortcut.ts +7 -7
  443. package/front_end/ui/legacy/RemoteDebuggingTerminatedScreen.ts +2 -2
  444. package/front_end/ui/legacy/TabbedPane.ts +198 -66
  445. package/front_end/ui/legacy/TargetCrashedScreen.ts +2 -2
  446. package/front_end/ui/legacy/UIUtils.ts +71 -68
  447. package/front_end/ui/legacy/View.ts +7 -4
  448. package/front_end/ui/legacy/ViewManager.ts +49 -37
  449. package/front_end/ui/legacy/Widget.ts +32 -12
  450. package/front_end/ui/legacy/components/cookie_table/CookiesTable.ts +2 -3
  451. package/front_end/ui/legacy/components/inline_editor/AnimationTimingUI.ts +8 -8
  452. package/front_end/ui/legacy/components/inline_editor/BezierUI.ts +8 -9
  453. package/front_end/ui/legacy/components/inline_editor/LinkSwatch.ts +2 -2
  454. package/front_end/ui/legacy/components/inline_editor/cssAngleEditor.css +1 -1
  455. package/front_end/ui/legacy/components/inline_editor/cssAngleSwatch.css +1 -1
  456. package/front_end/ui/legacy/components/object_ui/ObjectPropertiesSection.ts +45 -11
  457. package/front_end/ui/legacy/components/object_ui/RemoteObjectPreviewFormatter.ts +10 -12
  458. package/front_end/ui/legacy/components/perf_ui/ChartViewport.ts +102 -29
  459. package/front_end/ui/legacy/components/perf_ui/FlameChart.ts +148 -122
  460. package/front_end/ui/legacy/components/perf_ui/TimelineOverviewPane.ts +20 -14
  461. package/front_end/ui/legacy/components/quick_open/filteredListWidget.css +1 -1
  462. package/front_end/ui/legacy/components/source_frame/FontView.ts +29 -5
  463. package/front_end/ui/legacy/components/source_frame/ImageView.ts +79 -12
  464. package/front_end/ui/legacy/components/source_frame/JSONView.ts +20 -2
  465. package/front_end/ui/legacy/components/source_frame/PreviewFactory.ts +2 -2
  466. package/front_end/ui/legacy/components/source_frame/StreamingContentHexView.ts +6 -10
  467. package/front_end/ui/legacy/components/source_frame/XMLView.ts +11 -11
  468. package/front_end/ui/legacy/components/source_frame/fontView.css +7 -0
  469. package/front_end/ui/legacy/components/source_frame/imageView.css +7 -0
  470. package/front_end/ui/legacy/components/utils/JSPresentationUtils.ts +14 -3
  471. package/front_end/ui/legacy/components/utils/Linkifier.ts +126 -2
  472. package/front_end/ui/legacy/emptyWidget.css +2 -1
  473. package/front_end/ui/legacy/inspectorCommon.css +3 -3
  474. package/front_end/ui/legacy/smallBubble.css +1 -1
  475. package/front_end/ui/legacy/tabbedPane.css +6 -0
  476. package/front_end/ui/lit/Directives.ts +35 -18
  477. package/front_end/ui/lit/lit.ts +0 -2
  478. package/front_end/ui/lit/render.ts +0 -7
  479. package/front_end/ui/visual_logging/KnownContextValues.ts +5 -0
  480. package/package.json +1 -1
  481. package/vpython.toml +8 -0
  482. package/vpython.toml.uv.lock +3 -0
  483. package/.agents/skills/review-models-core/SKILL.md +0 -73
  484. package/.agents/skills/review-tests/SKILL.md +0 -67
  485. package/.agents/skills/review-ui-widgets/SKILL.md +0 -115
  486. package/front_end/generated/ARIAProperties.ts +0 -2686
  487. package/front_end/ui/components/menus/README.md +0 -119
  488. package/front_end/ui/components/menus/SelectMenu.ts +0 -473
  489. package/front_end/ui/components/menus/selectMenu.css +0 -54
  490. package/front_end/ui/components/menus/selectMenuButton.css +0 -108
@@ -2433,7 +2433,19 @@ export class TimelineDetailsContentHelper {
2433
2433
  stackTraceElement.classList.add('timeline-details-view-row', 'timeline-details-stack-values');
2434
2434
  stackTraceElement.setAttribute('jslog', `${VisualLogging.item('detail-row')}`);
2435
2435
  callFrameContents.markAsRoot();
2436
+ callFrameContents.markAsExternallyManaged();
2436
2437
  callFrameContents.show(stackTraceElement);
2438
+ callFrameContents.willHide();
2439
+ const tracker = document.createElement('devtools-widget') as
2440
+ UI.Widget.WidgetElement<LegacyComponents.JSPresentationUtils.StackTracePreviewContent>;
2441
+ tracker.style.display = 'none';
2442
+ tracker.onConnect = () => {
2443
+ callFrameContents.wasShown();
2444
+ };
2445
+ tracker.onDisconnect = () => {
2446
+ callFrameContents.willHide();
2447
+ };
2448
+ stackTraceElement.appendChild(tracker);
2437
2449
  return stackTraceElement;
2438
2450
  }
2439
2451
  }
@@ -70,20 +70,21 @@ export class BreadcrumbsUI extends UI.Widget.Widget {
70
70
  this.requestUpdate();
71
71
  }
72
72
 
73
- #activateBreadcrumb(breadcrumb: Trace.Types.File.Breadcrumb): void {
73
+ #activateBreadcrumb(breadcrumb: Trace.Types.File.Breadcrumb, removeChildBreadcrumbs = false): void {
74
74
  this.#activeBreadcrumb = breadcrumb;
75
- this.onBreadcrumbActivated?.(breadcrumb, false);
75
+ this.onBreadcrumbActivated?.(breadcrumb, removeChildBreadcrumbs);
76
+ this.requestUpdate();
76
77
  }
77
78
 
78
79
  #onContextMenu(event: Event, breadcrumb: Trace.Types.File.Breadcrumb): void {
79
80
  const menu = new UI.ContextMenu.ContextMenu(event);
80
81
 
81
82
  menu.defaultSection().appendItem(i18nString(UIStrings.activateBreadcrumb), () => {
82
- this.onBreadcrumbActivated?.(breadcrumb, false);
83
+ this.#activateBreadcrumb(breadcrumb);
83
84
  });
84
85
 
85
86
  menu.defaultSection().appendItem(i18nString(UIStrings.removeChildBreadcrumbs), () => {
86
- this.onBreadcrumbActivated?.(breadcrumb, true);
87
+ this.#activateBreadcrumb(breadcrumb, true);
87
88
  });
88
89
 
89
90
  void menu.show();
@@ -1,14 +1,19 @@
1
1
  // Copyright 2023 The Chromium Authors
2
2
  // Use of this source code is governed by a BSD-style license that can be
3
3
  // found in the LICENSE file.
4
- /* eslint-disable @devtools/no-imperative-dom-api */
4
+
5
+ import '../../../ui/kit/kit.js';
5
6
 
6
7
  import * as i18n from '../../../core/i18n/i18n.js';
7
8
  import * as Platform from '../../../core/platform/platform.js';
8
9
  import type * as Protocol from '../../../generated/protocol.js';
9
10
  import * as Trace from '../../../models/trace/trace.js';
10
- import * as uiI18n from '../../../ui/i18n/i18n.js';
11
- import {Link} from '../../../ui/kit/kit.js';
11
+ import {
12
+ html,
13
+ i18nTemplate as unboundI18nTemplate,
14
+ nothing,
15
+ render,
16
+ } from '../../../ui/lit/lit.js';
12
17
 
13
18
  // *********************************************************************
14
19
  // At the moment this file consists of helpers to aid in the rendering
@@ -18,107 +23,125 @@ import {Link} from '../../../ui/kit/kit.js';
18
23
 
19
24
  const UIStrings = {
20
25
  /**
21
- * @description Text in the Performance panel for a forced style and layout calculation of elements in a page.
26
+ * @description Text in the Performance panel for a forced style and layout
27
+ * calculation of elements in a page.
22
28
  */
23
29
  forcedReflow: 'Forced reflow',
24
30
  /**
25
- * @description Warning message indicating that an event is likely a performance bottleneck in the Performance panel.
31
+ * @description Warning message indicating that an event is likely a
32
+ * performance bottleneck in the Performance panel.
26
33
  * @example {Forced reflow} PH1
27
34
  */
28
35
  sIsALikelyPerformanceBottleneck: '{PH1} is a likely performance bottleneck',
29
36
  /**
30
- * @description Warning message in the Performance panel for an idle callback function that took longer to execute than its predefined deadline.
37
+ * @description Warning message in the Performance panel for an idle callback
38
+ * function that took longer to execute than its predefined deadline.
31
39
  * @example {10ms} PH1
32
40
  */
33
41
  idleCallbackExecutionExtended: 'Idle callback execution extended beyond deadline by {PH1}',
34
42
  /**
35
- * @description Warning message in the Performance panel describing how long a task took.
43
+ * @description Warning message in the Performance panel describing how long a
44
+ * task took.
36
45
  * @example {Task} PH1
37
46
  * @example {10ms} PH2
38
47
  */
39
48
  sTookS: '{PH1} took {PH2}',
40
49
  /**
41
- * @description Label in the Performance panel for a task that took a long time.
50
+ * @description Label in the Performance panel for a task that took a long
51
+ * time.
42
52
  */
43
53
  longTask: 'Long task',
44
54
  /**
45
- * @description Label in the Performance panel for an interaction that took a long time.
55
+ * @description Label in the Performance panel for an interaction that took a
56
+ * long time.
46
57
  */
47
58
  longInteractionINP: 'Long interaction',
48
59
  /**
49
- * @description Warning message in the Performance panel indicating that an interaction caused poor responsiveness.
60
+ * @description Warning message in the Performance panel indicating that an
61
+ * interaction caused poor responsiveness.
50
62
  * @example {Long interaction} PH1
51
63
  */
52
64
  sIsLikelyPoorPageResponsiveness: '{PH1} indicates poor page responsiveness',
53
65
  /**
54
- * @description Label for the WebSocket sub-protocol in the event details view of the Performance panel.
66
+ * @description Label for the WebSocket sub-protocol in the event details view
67
+ * of the Performance panel.
55
68
  */
56
69
  websocketProtocol: 'WebSocket protocol',
57
70
  /**
58
- * @description Details text indicating how many bytes were transferred in a WebSocket message in the Performance panel.
71
+ * @description Details text indicating how many bytes were transferred in a
72
+ * WebSocket message in the Performance panel.
59
73
  * @example {1024} PH1
60
74
  */
61
75
  webSocketBytes: '{PH1} byte(s)',
62
76
  /**
63
- * @description Details label indicating the data length of a WebSocket message in the Performance panel.
77
+ * @description Details label indicating the data length of a WebSocket
78
+ * message in the Performance panel.
64
79
  */
65
80
  webSocketDataLength: 'Data length',
66
81
  } as const;
67
82
 
68
83
  const str_ = i18n.i18n.registerUIStrings('panels/timeline/components/DetailsView.ts', UIStrings);
69
84
  const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
85
+ const i18nTemplate = unboundI18nTemplate.bind(undefined, str_);
86
+
87
+ interface WarningViewInput {
88
+ event: Trace.Types.Events.Event;
89
+ warnings: Trace.Handlers.ModelHandlers.Warnings.Warning[];
90
+ }
91
+
92
+ function renderWarningElements(input: WarningViewInput, _output: undefined, target: DocumentFragment): void {
93
+ const duration = Trace.Helpers.Timing.microToMilli(Trace.Types.Timing.Micro(input.event.dur || 0));
94
+ render(html`${input.warnings.map(warning => {
95
+ switch (warning) {
96
+ case 'FORCED_REFLOW': {
97
+ const forcedReflowLink = html`<devtools-link
98
+ href="https://developers.google.com/web/fundamentals/performance/rendering/avoid-large-complex-layouts-and-layout-thrashing#avoid-forced-synchronous-layouts"
99
+ jslogcontext="forced-reflow">${i18nString(UIStrings.forcedReflow)}</devtools-link>`;
100
+ return html`<span>${
101
+ i18nTemplate(UIStrings.sIsALikelyPerformanceBottleneck, {PH1: forcedReflowLink})}</span>`;
102
+ }
103
+ case 'IDLE_CALLBACK_OVER_TIME': {
104
+ if (!Trace.Types.Events.isFireIdleCallback(input.event)) {
105
+ return nothing;
106
+ }
107
+ const exceededMs = i18n.TimeUtilities.millisToString(
108
+ (duration || 0) - input.event.args.data['allottedMilliseconds'], true);
109
+ return html`<span>${i18nString(UIStrings.idleCallbackExecutionExtended, {PH1: exceededMs})}</span>`;
110
+ }
111
+ case 'LONG_TASK': {
112
+ const longTaskLink = html`<devtools-link
113
+ href="https://web.dev/optimize-long-tasks/"
114
+ jslogcontext="long-tasks">${i18nString(UIStrings.longTask)}</devtools-link>`;
115
+ return html`<span>${i18nTemplate(UIStrings.sTookS, {
116
+ PH1: longTaskLink,
117
+ PH2: i18n.TimeUtilities.millisToString((duration || 0), true),
118
+ })}</span>`;
119
+ }
120
+ case 'LONG_INTERACTION': {
121
+ const longInteractionINPLink = html`<devtools-link
122
+ href="https://web.dev/inp"
123
+ jslogcontext="long-interaction">${i18nString(UIStrings.longInteractionINP)}</devtools-link>`;
124
+ return html`<span>${i18nTemplate(UIStrings.sIsLikelyPoorPageResponsiveness, {
125
+ PH1: longInteractionINPLink,
126
+ })}</span>`;
127
+ }
128
+ default: {
129
+ Platform.assertNever(warning, `Unhandled warning type ${warning}`);
130
+ }
131
+ }
132
+ })}`,
133
+ target);
134
+ }
70
135
 
71
- export function buildWarningElementsForEvent(
72
- event: Trace.Types.Events.Event, parsedTrace: Trace.TraceModel.ParsedTrace): HTMLSpanElement[] {
136
+ export function buildWarningElementsForEvent(event: Trace.Types.Events.Event,
137
+ parsedTrace: Trace.TraceModel.ParsedTrace): HTMLSpanElement[] {
73
138
  const warnings = parsedTrace.data.Warnings.perEvent.get(event);
74
- const warningElements: HTMLSpanElement[] = [];
75
139
  if (!warnings) {
76
- return warningElements;
77
- }
78
- for (const warning of warnings) {
79
- const duration = Trace.Helpers.Timing.microToMilli(Trace.Types.Timing.Micro(event.dur || 0));
80
- const span = document.createElement('span');
81
- switch (warning) {
82
- case 'FORCED_REFLOW': {
83
- const forcedReflowLink = Link.create(
84
- 'https://developers.google.com/web/fundamentals/performance/rendering/avoid-large-complex-layouts-and-layout-thrashing#avoid-forced-synchronous-layouts',
85
- i18nString(UIStrings.forcedReflow), undefined, 'forced-reflow');
86
- span.appendChild(
87
- uiI18n.getFormatLocalizedString(str_, UIStrings.sIsALikelyPerformanceBottleneck, {PH1: forcedReflowLink}));
88
- break;
89
- }
90
- case 'IDLE_CALLBACK_OVER_TIME': {
91
- if (!Trace.Types.Events.isFireIdleCallback(event)) {
92
- break;
93
- }
94
- const exceededMs =
95
- i18n.TimeUtilities.millisToString((duration || 0) - event.args.data['allottedMilliseconds'], true);
96
- span.textContent = i18nString(UIStrings.idleCallbackExecutionExtended, {PH1: exceededMs});
97
- break;
98
- }
99
-
100
- case 'LONG_TASK': {
101
- const longTaskLink = Link.create(
102
- 'https://web.dev/optimize-long-tasks/', i18nString(UIStrings.longTask), undefined, 'long-tasks');
103
- span.appendChild(uiI18n.getFormatLocalizedString(
104
- str_, UIStrings.sTookS,
105
- {PH1: longTaskLink, PH2: i18n.TimeUtilities.millisToString((duration || 0), true)}));
106
- break;
107
- }
108
- case 'LONG_INTERACTION': {
109
- const longInteractionINPLink =
110
- Link.create('https://web.dev/inp', i18nString(UIStrings.longInteractionINP), undefined, 'long-interaction');
111
- span.appendChild(uiI18n.getFormatLocalizedString(
112
- str_, UIStrings.sIsLikelyPoorPageResponsiveness, {PH1: longInteractionINPLink}));
113
- break;
114
- }
115
- default: {
116
- Platform.assertNever(warning, `Unhandled warning type ${warning}`);
117
- }
118
- }
119
- warningElements.push(span);
140
+ return [];
120
141
  }
121
- return warningElements;
142
+ const fragment = document.createDocumentFragment();
143
+ renderWarningElements({event, warnings}, undefined, fragment);
144
+ return Array.from(fragment.children).filter((child): child is HTMLSpanElement => child instanceof HTMLSpanElement);
122
145
  }
123
146
 
124
147
  export interface DetailRow {
@@ -132,22 +155,31 @@ export function buildRowsForWebSocketEvent(
132
155
 
133
156
  const initiator = parsedTrace.data.Initiators.eventToInitiator.get(event);
134
157
  if (initiator && Trace.Types.Events.isWebSocketCreate(initiator)) {
135
- // The initiator will be a WebSocketCreate, but this check helps TypeScript to understand.
158
+ // The initiator will be a WebSocketCreate, but this check helps TypeScript
159
+ // to understand.
136
160
  rows.push({key: i18n.i18n.lockedString('URL'), value: initiator.args.data.url});
137
161
  if (initiator.args.data.webSocketProtocol) {
138
- rows.push({key: i18nString(UIStrings.websocketProtocol), value: initiator.args.data.webSocketProtocol});
162
+ rows.push({
163
+ key: i18nString(UIStrings.websocketProtocol),
164
+ value: initiator.args.data.webSocketProtocol,
165
+ });
139
166
  }
140
167
  } else if (Trace.Types.Events.isWebSocketCreate(event)) {
141
168
  rows.push({key: i18n.i18n.lockedString('URL'), value: event.args.data.url});
142
169
  if (event.args.data.webSocketProtocol) {
143
- rows.push({key: i18nString(UIStrings.websocketProtocol), value: event.args.data.webSocketProtocol});
170
+ rows.push({
171
+ key: i18nString(UIStrings.websocketProtocol),
172
+ value: event.args.data.webSocketProtocol,
173
+ });
144
174
  }
145
175
  }
146
176
  if (Trace.Types.Events.isWebSocketTransfer(event)) {
147
177
  if (event.args.data.dataLength) {
148
178
  rows.push({
149
179
  key: i18nString(UIStrings.webSocketDataLength),
150
- value: `${i18nString(UIStrings.webSocketBytes, {PH1: event.args.data.dataLength})}`,
180
+ value: `${i18nString(UIStrings.webSocketBytes, {
181
+ PH1: event.args.data.dataLength,
182
+ })}`,
151
183
  });
152
184
  }
153
185
  }
@@ -88,7 +88,7 @@ export interface ViewInput {
88
88
  togglePopover: (e: MouseEvent) => void;
89
89
  onEventClick: (event: Trace.Types.Events.Event) => void;
90
90
  }
91
- export type View = (input: ViewInput, output: object, target: HTMLElement) => void;
91
+ export type View = (input: ViewInput, output: undefined, target: HTMLElement) => void;
92
92
 
93
93
  export class LayoutShiftDetails extends UI.Widget.Widget {
94
94
  #view: View;
@@ -152,7 +152,7 @@ export class LayoutShiftDetails extends UI.Widget.Widget {
152
152
  togglePopover: e => this.#togglePopover(e),
153
153
  onEventClick: e => this.#handleTraceEventClick(e),
154
154
  },
155
- {}, this.contentElement);
155
+ undefined, this.contentElement);
156
156
  }
157
157
  }
158
158
 
@@ -246,7 +246,7 @@ interface ViewInput {
246
246
  warnings?: string[];
247
247
  }
248
248
 
249
- type View = (input: ViewInput, output: object, target: HTMLElement) => void;
249
+ type View = (input: ViewInput, output: undefined, target: HTMLElement) => void;
250
250
  export const DEFAULT_VIEW: View = (input, output, target) => {
251
251
  const {metric, localValue, fieldValue} = input;
252
252
 
@@ -631,6 +631,6 @@ export class MetricCard extends UI.Widget.VBox {
631
631
  subparts: this.#subparts,
632
632
  warnings: this.#warnings,
633
633
  },
634
- {}, this.contentElement);
634
+ undefined, this.contentElement);
635
635
  }
636
636
  }
@@ -126,7 +126,7 @@ export interface ViewInput {
126
126
  linkifier: LegacyComponents.Linkifier.Linkifier|null;
127
127
  parsedTrace: Trace.TraceModel.ParsedTrace|null;
128
128
  }
129
- export type View = (input: ViewInput, output: object, target: HTMLElement) => void;
129
+ export type View = (input: ViewInput, output: undefined, target: HTMLElement) => void;
130
130
 
131
131
  export class NetworkRequestDetails extends UI.Widget.Widget {
132
132
  #view: View;
@@ -183,17 +183,16 @@ export class NetworkRequestDetails extends UI.Widget.Widget {
183
183
  }
184
184
 
185
185
  override performUpdate(): Promise<void>|void {
186
- this.#view(
187
- {
188
- request: this.#request,
189
- previewElementsCache: this.#requestPreviewElements,
190
- target: this.#target,
191
- entityMapper: this.#entityMapper,
192
- serverTimings: this.#serverTimings,
193
- linkifier: this.#linkifier,
194
- parsedTrace: this.#parsedTrace,
195
- },
196
- {}, this.contentElement);
186
+ this.#view({
187
+ request: this.#request,
188
+ previewElementsCache: this.#requestPreviewElements,
189
+ target: this.#target,
190
+ entityMapper: this.#entityMapper,
191
+ serverTimings: this.#serverTimings,
192
+ linkifier: this.#linkifier,
193
+ parsedTrace: this.#parsedTrace,
194
+ },
195
+ undefined, this.contentElement);
197
196
  }
198
197
  }
199
198
 
@@ -4,11 +4,13 @@
4
4
 
5
5
  import * as Trace from '../../../models/trace/trace.js';
6
6
  import * as PerfUI from '../../../ui/legacy/components/perf_ui/perf_ui.js';
7
+ import * as UI from '../../../ui/legacy/legacy.js';
7
8
  import * as Lit from '../../../ui/lit/lit.js';
8
9
 
9
10
  import networkTrackWidgetStyles from './networkTrackWidget.css.js';
10
11
 
11
- const {html} = Lit;
12
+ const {html, render} = Lit;
13
+ const {widget} = UI.Widget;
12
14
 
13
15
  // TODO: Do not redeclare the DataProvider here.
14
16
  // To prevent circular dependencies with the parent timeline module (since timeline.ts
@@ -29,17 +31,41 @@ export interface NetworkTrackWidgetData {
29
31
  dataProvider: NetworkDataProvider;
30
32
  }
31
33
 
32
- export class NetworkTrackWidget extends HTMLElement implements PerfUI.FlameChart.FlameChartDelegate {
33
- readonly #shadow = this.attachShadow({mode: 'open'});
34
+ export interface ViewInput {
35
+ dataProvider: NetworkDataProvider;
36
+ delegate: PerfUI.FlameChart.FlameChartDelegate;
37
+ windowTimes: Trace.Types.Timing.TraceWindowMilli;
38
+ }
34
39
 
35
- #flameChartContainer = document.createElement('div');
36
- #flameChart: PerfUI.FlameChart.FlameChart|null = null;
40
+ export type View = (input: ViewInput, output: undefined, target: HTMLElement) => void;
41
+
42
+ export const DEFAULT_VIEW: View = (input, _output, target) => {
43
+ // clang-format off
44
+ render(
45
+ html`
46
+ <style>${networkTrackWidgetStyles}</style>
47
+ <devtools-widget
48
+ class="container"
49
+ ${widget(
50
+ (element: HTMLElement): PerfUI.FlameChart.FlameChart =>
51
+ new PerfUI.FlameChart.FlameChart(input.dataProvider, input.delegate, undefined, element),
52
+ {windowTimes: input.windowTimes},
53
+ )}
54
+ ></devtools-widget>
55
+ `,
56
+ target);
57
+ // clang-format on
58
+ };
59
+
60
+ export class NetworkTrackWidget extends UI.Widget.Widget implements PerfUI.FlameChart.FlameChartDelegate {
37
61
  #dataProvider: NetworkDataProvider|null = null;
38
62
  #parsedTrace: Trace.TraceModel.ParsedTrace|null = null;
63
+ #bounds: Trace.Types.Timing.TraceWindowMicro|null = null;
64
+ readonly #view: View;
39
65
 
40
- constructor() {
41
- super();
42
- this.#flameChartContainer.classList.add('container');
66
+ constructor(element?: HTMLElement, view: View = DEFAULT_VIEW) {
67
+ super(element);
68
+ this.#view = view;
43
69
  }
44
70
 
45
71
  set data(data: NetworkTrackWidgetData) {
@@ -48,26 +74,26 @@ export class NetworkTrackWidget extends HTMLElement implements PerfUI.FlameChart
48
74
  if (!parsedTrace || !dataProvider) {
49
75
  return;
50
76
  }
77
+ if (this.#dataProvider === dataProvider && this.#parsedTrace === parsedTrace && this.#bounds === data.bounds) {
78
+ return;
79
+ }
51
80
 
52
- const isDataProviderChanged = dataProvider !== this.#dataProvider;
53
81
  this.#dataProvider = dataProvider;
54
82
  this.#parsedTrace = parsedTrace;
83
+ this.#bounds = data.bounds;
84
+ this.requestUpdate();
85
+ }
55
86
 
56
- // 1. Render first to mount the container in the DOM so show() succeeds
57
- this.#render();
58
-
59
- // 2. Instantiate and show the flame chart in the mounted container
60
- if (isDataProviderChanged || !this.#flameChart) {
61
- this.#flameChartContainer.innerHTML = '';
62
- this.#flameChart = new PerfUI.FlameChart.FlameChart(this.#dataProvider, this);
63
- this.#flameChart.show(this.#flameChartContainer, undefined, true);
87
+ override performUpdate(): void {
88
+ if (!this.#parsedTrace || !this.#dataProvider || !this.#bounds) {
89
+ return;
64
90
  }
65
91
 
66
- const entityMapper = Trace.EntityMapper.EntityMapper.getOrCreate(parsedTrace);
92
+ const entityMapper = Trace.EntityMapper.EntityMapper.getOrCreate(this.#parsedTrace);
67
93
  // Override preparePopoverElement to always return null, preventing any hover tooltips
68
94
  // from being generated or rendered when the user hovers over the network request blocks.
69
95
  this.#dataProvider.preparePopoverElement = () => null;
70
- this.#dataProvider.setModel(parsedTrace, entityMapper);
96
+ this.#dataProvider.setModel(this.#parsedTrace, entityMapper);
71
97
  const timelineData = this.#dataProvider.timelineData();
72
98
  // Clearing the groups array hides the collapsible "Network" track header on the left.
73
99
  // When the groups array is empty, the FlameChart component directly renders the track
@@ -75,30 +101,21 @@ export class NetworkTrackWidget extends HTMLElement implements PerfUI.FlameChart
75
101
  timelineData.groups = [];
76
102
 
77
103
  const bounds = Trace.Helpers.Timing.traceWindowMicroSecondsToMilliSeconds({
78
- min: Trace.Types.Timing.Micro(data.bounds.min),
79
- max: Trace.Types.Timing.Micro(data.bounds.max),
80
- range: Trace.Types.Timing.Micro(data.bounds.range),
104
+ min: Trace.Types.Timing.Micro(this.#bounds.min),
105
+ max: Trace.Types.Timing.Micro(this.#bounds.max),
106
+ range: Trace.Types.Timing.Micro(this.#bounds.range),
81
107
  });
82
108
 
83
109
  this.#dataProvider.setWindowTimes(bounds.min, bounds.max);
84
- this.#flameChart.setWindowTimes(bounds.min, bounds.max);
85
- this.#render();
86
- }
87
-
88
- #render(): void {
89
- if (!this.#parsedTrace) {
90
- return;
91
- }
92
- const output = html`
93
- <style>${networkTrackWidgetStyles}</style>
94
- ${this.#flameChartContainer}
95
- `;
96
- // eslint-disable-next-line @devtools/no-lit-render-outside-of-view
97
- Lit.render(output, this.#shadow, {host: this});
98
-
99
- if (this.#flameChart) {
100
- this.#flameChart.update();
101
- }
110
+ this.#view(
111
+ {
112
+ dataProvider: this.#dataProvider,
113
+ delegate: this,
114
+ windowTimes: bounds,
115
+ },
116
+ undefined,
117
+ this.contentElement,
118
+ );
102
119
  }
103
120
 
104
121
  windowChanged(_windowStartTime: number, _windowEndTime: number, _animate: boolean): void {
@@ -110,13 +127,3 @@ export class NetworkTrackWidget extends HTMLElement implements PerfUI.FlameChart
110
127
  updateSelectedGroup(_flameChart: PerfUI.FlameChart.FlameChart, _group: PerfUI.FlameChart.Group|null): void {
111
128
  }
112
129
  }
113
-
114
- if (!customElements.get('devtools-performance-agent-network-track')) {
115
- customElements.define('devtools-performance-agent-network-track', NetworkTrackWidget);
116
- }
117
-
118
- declare global {
119
- interface HTMLElementTagNameMap {
120
- 'devtools-performance-agent-network-track': NetworkTrackWidget;
121
- }
122
- }
@@ -37,7 +37,7 @@ export interface ViewInput {
37
37
  eventToInsightsMap: EventToRelatedInsightsMap;
38
38
  onInsightClick: (insight: RelatedInsight) => void;
39
39
  }
40
- export type View = (input: ViewInput, output: object, target: HTMLElement) => void;
40
+ export type View = (input: ViewInput, output: undefined, target: HTMLElement) => void;
41
41
 
42
42
  export interface Data {
43
43
  eventToRelatedInsightsMap: EventToRelatedInsightsMap|null;
@@ -78,7 +78,7 @@ export class RelatedInsightChips extends UI.Widget.Widget {
78
78
  insight.activateInsight();
79
79
  },
80
80
  };
81
- this.#view(input, {}, this.contentElement);
81
+ this.#view(input, undefined, this.contentElement);
82
82
  }
83
83
  }
84
84