chrome-devtools-frontend 1.0.1726686 → 1.0.1730971

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (490) hide show
  1. package/.agents/rules/tests/test-strict-assertions-and-literal-expectations.md +1 -1
  2. package/.agents/rules/tests/test-view-and-presenter-isolation.md +1 -1
  3. package/.agents/rules/ui-and-widgets/ui-accessibility-and-semantic-html.md +1 -1
  4. package/.agents/rules/ui-and-widgets/ui-css-scoping-and-flex-layout.md +2 -2
  5. package/.agents/rules/ui-and-widgets/ui-declarative-child-widget-composition.md +5 -5
  6. package/.agents/rules/ui-and-widgets/ui-lit-declarative-templates-and-directives.md +2 -2
  7. package/.agents/rules/ui-and-widgets/ui-localization-and-uistrings-hygiene.md +2 -2
  8. package/.agents/rules/ui-and-widgets/ui-modern-component-and-encapsulation-standards.md +3 -3
  9. package/.agents/rules/ui-and-widgets/ui-pure-view-and-presenter-separation.md +2 -2
  10. package/.agents/rules/ui-and-widgets/ui-reactive-widget-update-lifecycle.md +2 -2
  11. package/.agents/rules/ui-and-widgets/ui-view-output-and-callback-contracts.md +2 -2
  12. package/.agents/rules/ui-and-widgets/ui-widget-dom-and-listener-lifecycle.md +2 -2
  13. package/.agents/skills/code-review/SKILL.md +63 -12
  14. package/.agents/skills/ui-eng-vision-local-lit-renderer/SKILL.md +38 -10
  15. package/.agents/skills/ui-eng-vision-widget-promoter/SKILL.md +1 -0
  16. package/.agents/skills/ui-widgets/SKILL.md +8 -2
  17. package/.agents/skills/write-ai-eval-test/SKILL.md +106 -0
  18. package/AUTHORS +2 -0
  19. package/DIR_METADATA +1 -2
  20. package/README.md +48 -26
  21. package/config/typescript/tsconfig.base.json +1 -0
  22. package/config/typescript/tsconfig.eslint.json +1 -0
  23. package/docs/contributing/changes.md +25 -0
  24. package/docs/ui_engineering.md +13 -4
  25. package/eslint.config.mjs +323 -41
  26. package/front_end/core/common/Color.ts +7 -7
  27. package/front_end/core/common/ParsedURL.ts +3 -3
  28. package/front_end/core/common/ResolverBase.ts +3 -3
  29. package/front_end/core/common/SegmentedRange.ts +3 -3
  30. package/front_end/core/common/SimpleHistoryManager.ts +14 -14
  31. package/front_end/core/common/Trie.ts +3 -3
  32. package/front_end/core/common/VersionController.ts +7 -7
  33. package/front_end/core/host/InspectorFrontendHost.ts +2 -2
  34. package/front_end/core/host/InspectorFrontendHostAPI.ts +9 -1
  35. package/front_end/core/host/InspectorFrontendHostStub.ts +1 -1
  36. package/front_end/core/host/UserMetrics.ts +4 -0
  37. package/front_end/core/host/UserMetricsEnums.ts +2 -1
  38. package/front_end/core/platform/StringUtilities.ts +54 -13
  39. package/front_end/core/platform/node/HostRuntime.ts +13 -7
  40. package/front_end/core/protocol_client/DevToolsCDPConnection.ts +4 -5
  41. package/front_end/core/root/Runtime.ts +5 -0
  42. package/front_end/core/sdk/AccessibilityModel.ts +5 -5
  43. package/front_end/core/sdk/AnimationModel.ts +17 -19
  44. package/front_end/core/sdk/CPUProfilerModel.ts +3 -3
  45. package/front_end/core/sdk/CPUThrottlingManager.ts +7 -0
  46. package/front_end/core/sdk/CSSMatchedStyles.ts +73 -13
  47. package/front_end/core/sdk/CSSMetadata.ts +7 -7
  48. package/front_end/core/sdk/CSSModel.ts +33 -33
  49. package/front_end/core/sdk/CSSProperty.ts +5 -5
  50. package/front_end/core/sdk/CSSRule.ts +6 -6
  51. package/front_end/core/sdk/CSSStyleSheetHeader.ts +4 -4
  52. package/front_end/core/sdk/Connections.ts +16 -16
  53. package/front_end/core/sdk/ConsoleModel.ts +44 -47
  54. package/front_end/core/sdk/CookieParser.ts +11 -11
  55. package/front_end/core/sdk/EmulationModel.ts +35 -36
  56. package/front_end/core/sdk/EventBreakpointsModel.ts +11 -11
  57. package/front_end/core/sdk/FrameManager.ts +16 -16
  58. package/front_end/core/sdk/IsolateManager.ts +2 -2
  59. package/front_end/core/sdk/IssuesModel.ts +2 -2
  60. package/front_end/core/sdk/OverlayModel.ts +19 -19
  61. package/front_end/core/sdk/PageResourceLoader.ts +14 -16
  62. package/front_end/core/sdk/RemoteObject.ts +9 -9
  63. package/front_end/core/sdk/Resource.ts +2 -2
  64. package/front_end/core/sdk/RuntimeModel.ts +7 -7
  65. package/front_end/core/sdk/Script.ts +6 -6
  66. package/front_end/core/sdk/ServiceWorkerManager.ts +36 -10
  67. package/front_end/core/sdk/SourceMap.ts +18 -20
  68. package/front_end/core/sdk/SourceMapManager.ts +2 -2
  69. package/front_end/core/sdk/TargetManager.ts +2 -2
  70. package/front_end/devtools_compatibility.js +7 -3
  71. package/front_end/entrypoints/inspector_main/InspectorMain.ts +2 -2
  72. package/front_end/entrypoints/node_app/app/NodeConnectionsPanel.ts +203 -115
  73. package/front_end/generated/InspectorBackendCommands.ts +1 -1
  74. package/front_end/generated/SupportedCSSProperties.ts +1 -3
  75. package/front_end/generated/protocol.ts +1 -0
  76. package/front_end/models/ai_assistance/AiAgent2.ts +36 -12
  77. package/front_end/models/ai_assistance/AiConversation.ts +8 -2
  78. package/front_end/models/ai_assistance/agents/AiAgent.ts +137 -62
  79. package/front_end/models/ai_assistance/agents/ExecuteJavascript.ts +2 -2
  80. package/front_end/models/ai_assistance/agents/StylingAgent.snapshot.txt +2 -2
  81. package/front_end/models/ai_assistance/data_formatters/LighthouseFormatter.snapshot.txt +149 -2
  82. package/front_end/models/ai_assistance/data_formatters/LighthouseFormatter.ts +269 -42
  83. package/front_end/models/ai_assistance/tools/ExecuteJavaScript.ts +3 -0
  84. package/front_end/models/ai_assistance/tools/GetLighthouseAudits.ts +9 -0
  85. package/front_end/models/ai_assistance/tools/ResolveDevtoolsNodePath.ts +13 -2
  86. package/front_end/models/ai_assistance/tools/RunLighthouse.ts +23 -7
  87. package/front_end/models/ai_assistance/tools/Tool.ts +7 -5
  88. package/front_end/models/bindings/CSSWorkspaceBinding.ts +22 -24
  89. package/front_end/models/bindings/DebuggerLanguagePlugins.ts +60 -60
  90. package/front_end/models/bindings/DebuggerWorkspaceBinding.ts +24 -24
  91. package/front_end/models/bindings/DefaultScriptMapping.ts +8 -8
  92. package/front_end/models/bindings/FileUtils.ts +13 -13
  93. package/front_end/models/bindings/PresentationConsoleMessageHelper.ts +3 -3
  94. package/front_end/models/bindings/ResourceScriptMapping.ts +23 -23
  95. package/front_end/models/comment_manager/CommentManager.ts +3 -3
  96. package/front_end/models/comment_manager/CommentThread.ts +50 -5
  97. package/front_end/models/cpu_profile/CPUProfileDataModel.ts +14 -14
  98. package/front_end/models/cpu_profile/ProfileTreeModel.ts +4 -4
  99. package/front_end/models/elements/StyleChanges.ts +38 -0
  100. package/front_end/models/emulation/EmulatedDevices.ts +12 -12
  101. package/front_end/models/har/HARFormat.ts +4 -4
  102. package/front_end/models/javascript_metadata/NativeFunctions.ts +5 -1
  103. package/front_end/models/lighthouse/LighthouseReporterTypes.ts +57 -3
  104. package/front_end/models/lighthouse/RunTypes.ts +9 -1
  105. package/front_end/models/logs/LogManager.ts +2 -2
  106. package/front_end/models/persistence/AutomaticFileSystemManager.ts +3 -0
  107. package/front_end/models/persistence/FileSystemWorkspaceBinding.ts +24 -24
  108. package/front_end/models/persistence/IsolatedFileSystemManager.ts +6 -0
  109. package/front_end/models/persistence/NetworkPersistenceManager.ts +8 -3
  110. package/front_end/models/trace/LanternComputationData.ts +37 -11
  111. package/front_end/models/trace/Processor.ts +2 -1
  112. package/front_end/models/trace/extras/TraceTree.ts +36 -10
  113. package/front_end/models/trace/handlers/InitiatorsHandler.ts +27 -34
  114. package/front_end/models/trace/handlers/LayoutShiftsHandler.ts +2 -6
  115. package/front_end/models/trace/handlers/SamplesHandler.ts +9 -6
  116. package/front_end/models/workspace/FileManager.ts +6 -0
  117. package/front_end/panels/accessibility/ARIAAttributesView.ts +4 -4
  118. package/front_end/panels/accessibility/AccessibilityAnnouncementRecordingView.ts +8 -1
  119. package/front_end/panels/accessibility/AccessibilityNodeView.ts +15 -17
  120. package/front_end/panels/accessibility/AccessibilitySubPane.ts +1 -1
  121. package/front_end/panels/ai_assistance/AiAssistancePanel.ts +5 -5
  122. package/front_end/panels/ai_assistance/ExternalHandler.ts +10 -1
  123. package/front_end/panels/ai_assistance/components/ChatMessage.ts +27 -22
  124. package/front_end/panels/ai_assistance/components/DisabledWidget.ts +19 -23
  125. package/front_end/panels/ai_assistance/components/ExploreWidget.ts +2 -2
  126. package/front_end/panels/ai_assistance/components/PermissionPrompt.ts +23 -9
  127. package/front_end/panels/ai_assistance/components/chatInput.css +1 -1
  128. package/front_end/panels/animation/AnimationTimeline.ts +37 -17
  129. package/front_end/panels/animation/animationTimeline.css +19 -3
  130. package/front_end/panels/application/AppManifestView.ts +1 -2
  131. package/front_end/panels/application/ApplicationPanelSidebar.ts +143 -128
  132. package/front_end/panels/application/DOMStorageItemsView.ts +14 -14
  133. package/front_end/panels/application/DeviceBoundSessionsView.ts +10 -13
  134. package/front_end/panels/application/ExtensionStorageItemsView.ts +3 -4
  135. package/front_end/panels/application/IndexedDBViews.ts +8 -4
  136. package/front_end/panels/application/KeyValueStorageItemsView.ts +4 -5
  137. package/front_end/panels/application/PrivateVerificationTokensView.ts +53 -0
  138. package/front_end/panels/application/ServiceWorkerCacheViews.ts +12 -8
  139. package/front_end/panels/application/ServiceWorkersView.ts +1 -2
  140. package/front_end/panels/application/StorageItemsToolbar.ts +3 -3
  141. package/front_end/panels/application/StorageView.ts +2 -2
  142. package/front_end/panels/application/WebMCPView.ts +91 -109
  143. package/front_end/panels/application/application.ts +2 -0
  144. package/front_end/panels/application/components/StorageMetadataView.ts +6 -6
  145. package/front_end/panels/application/preloading/PreloadingView.ts +70 -37
  146. package/front_end/panels/application/preloading/components/MismatchedPreloadingGrid.ts +2 -2
  147. package/front_end/panels/application/preloading/components/PreloadingDisabledInfobar.ts +3 -3
  148. package/front_end/panels/application/preloading/components/PreloadingGrid.ts +12 -0
  149. package/front_end/panels/application/preloading/components/RuleSetDetailsView.ts +10 -11
  150. package/front_end/panels/application/privateVerificationTokensView.css +20 -0
  151. package/front_end/panels/application/serviceWorkersView.css +2 -2
  152. package/front_end/panels/browser_debugger/DOMBreakpointsSidebarPane.ts +24 -24
  153. package/front_end/panels/changes/ChangesSidebar.ts +5 -5
  154. package/front_end/panels/changes/ChangesView.ts +10 -11
  155. package/front_end/panels/comments/CommentsPane.ts +292 -102
  156. package/front_end/panels/comments/commentsPane.css +93 -12
  157. package/front_end/panels/common/CommentThreadWidget.ts +69 -0
  158. package/front_end/panels/common/CommentsOverlayWidget.ts +108 -29
  159. package/front_end/panels/common/CommentsStatusBarPill.ts +17 -6
  160. package/front_end/panels/common/DOMLinkifier.ts +37 -12
  161. package/front_end/panels/common/ExtensionPanel.ts +13 -4
  162. package/front_end/panels/common/ExtensionServer.ts +27 -3
  163. package/front_end/panels/common/PersistenceUtils.ts +3 -3
  164. package/front_end/panels/common/commentThreadWidget.css +25 -1
  165. package/front_end/panels/common/common-meta.ts +10 -0
  166. package/front_end/panels/console/ConsolePinPane.ts +13 -15
  167. package/front_end/panels/console/ConsolePrompt.ts +173 -95
  168. package/front_end/panels/console/ConsoleSidebar.ts +2 -2
  169. package/front_end/panels/console/ConsoleView.ts +75 -79
  170. package/front_end/panels/console/ConsoleViewMessage.ts +52 -4
  171. package/front_end/panels/console/SymbolizedErrorWidget.ts +8 -4
  172. package/front_end/panels/console/consolePrompt.css +1 -1
  173. package/front_end/panels/console/consoleView.css +1 -1
  174. package/front_end/panels/console_counters/WarningErrorCounter.ts +3 -4
  175. package/front_end/panels/coverage/CoverageListView.ts +2 -2
  176. package/front_end/panels/coverage/CoverageView.ts +20 -5
  177. package/front_end/panels/css_overview/CSSOverviewCompletedView.ts +4 -3
  178. package/front_end/panels/css_overview/CSSOverviewPanel.ts +2 -2
  179. package/front_end/panels/css_overview/CSSOverviewProcessingView.ts +2 -2
  180. package/front_end/panels/css_overview/CSSOverviewSidebarPanel.ts +2 -2
  181. package/front_end/panels/css_overview/CSSOverviewStartView.ts +2 -2
  182. package/front_end/panels/css_overview/CSSOverviewUnusedDeclarations.ts +8 -8
  183. package/front_end/panels/developer_resources/DeveloperResourcesListView.ts +2 -3
  184. package/front_end/panels/developer_resources/DeveloperResourcesView.ts +4 -5
  185. package/front_end/panels/elements/AccessibilityTreeUtils.ts +6 -7
  186. package/front_end/panels/elements/CSSValueTraceView.ts +3 -3
  187. package/front_end/panels/elements/ClassesPaneWidget.ts +1 -2
  188. package/front_end/panels/elements/ComputedStyleWidget.ts +15 -14
  189. package/front_end/panels/elements/DOMTreeElementWidget.ts +5 -4
  190. package/front_end/panels/elements/DOMTreeWidget.ts +2 -1
  191. package/front_end/panels/elements/ElementStatePaneWidget.ts +2 -2
  192. package/front_end/panels/elements/ElementsPanel.ts +1 -0
  193. package/front_end/panels/elements/EventListenersWidget.ts +2 -2
  194. package/front_end/panels/elements/LayoutPane.ts +2 -2
  195. package/front_end/panels/elements/PlatformFontsWidget.ts +3 -3
  196. package/front_end/panels/elements/PropertiesWidget.ts +9 -10
  197. package/front_end/panels/elements/PropertyRenderer.ts +72 -11
  198. package/front_end/panels/elements/StandaloneStylesContainer.ts +5 -10
  199. package/front_end/panels/elements/StyleEditorWidget.ts +30 -16
  200. package/front_end/panels/elements/StylePropertiesSection.ts +93 -44
  201. package/front_end/panels/elements/StylePropertyTreeElement.ts +230 -302
  202. package/front_end/panels/elements/StylesContainer.ts +2 -3
  203. package/front_end/panels/elements/StylesSidebarPane.ts +4 -13
  204. package/front_end/panels/elements/components/AccessibilityTreeNode.ts +66 -37
  205. package/front_end/panels/elements/components/CSSHintDetailsView.ts +51 -41
  206. package/front_end/panels/elements/components/CSSPropertyDocsView.ts +75 -65
  207. package/front_end/panels/elements/components/CSSQuery.ts +112 -74
  208. package/front_end/panels/elements/components/CSSVariableValueView.ts +109 -68
  209. package/front_end/panels/elements/components/ComputedStyleProperty.ts +64 -45
  210. package/front_end/panels/elements/components/ElementsTreeExpandButton.ts +35 -28
  211. package/front_end/panels/elements/components/QueryContainer.ts +104 -74
  212. package/front_end/panels/elements/components/accessibilityTreeNode.css +22 -20
  213. package/front_end/panels/elements/components/computedStyleProperty.css +2 -0
  214. package/front_end/panels/elements/components/cssHintDetailsView.css +23 -21
  215. package/front_end/panels/elements/components/cssPropertyDocsView.css +38 -36
  216. package/front_end/panels/elements/components/cssVariableValueView.css +42 -40
  217. package/front_end/panels/elements/components/elementsTreeExpandButton.css +5 -2
  218. package/front_end/panels/elements/components/queryContainer.css +23 -21
  219. package/front_end/panels/elements/stylesSidebarPane.css +3 -3
  220. package/front_end/panels/emulation/DeviceModeToolbar.ts +2 -2
  221. package/front_end/panels/emulation/InspectedPagePlaceholder.ts +2 -2
  222. package/front_end/panels/emulation/MediaQueryInspector.ts +9 -10
  223. package/front_end/panels/emulation/mediaQueryInspector.css +1 -1
  224. package/front_end/panels/event_listeners/EventListenersView.ts +2 -2
  225. package/front_end/panels/issues/AffectedCookiesView.ts +144 -101
  226. package/front_end/panels/issues/AffectedDescendantsWithinSelectElementView.ts +83 -31
  227. package/front_end/panels/issues/AffectedDirectivesView.ts +218 -135
  228. package/front_end/panels/issues/AffectedDocumentsInQuirksModeView.ts +84 -34
  229. package/front_end/panels/issues/AffectedElementsView.ts +86 -23
  230. package/front_end/panels/issues/AffectedLazyLoadImagesView.ts +2 -2
  231. package/front_end/panels/issues/AffectedMetadataAllowedSitesView.ts +2 -2
  232. package/front_end/panels/issues/AffectedPartitioningBlobURLView.ts +36 -11
  233. package/front_end/panels/issues/AffectedSharedArrayBufferIssueDetailsView.ts +135 -58
  234. package/front_end/panels/issues/AffectedSourcesView.ts +49 -28
  235. package/front_end/panels/issues/AffectedTrackingSitesView.ts +3 -4
  236. package/front_end/panels/issues/CorsIssueDetailsView.ts +490 -269
  237. package/front_end/panels/issues/GenericIssueDetailsView.ts +2 -2
  238. package/front_end/panels/issues/IssueKindView.ts +63 -48
  239. package/front_end/panels/issues/IssueView.ts +14 -18
  240. package/front_end/panels/issues/components/ElementsPanelLink.ts +70 -34
  241. package/front_end/panels/issues/components/HideIssuesMenu.ts +56 -32
  242. package/front_end/panels/issues/components/elementsPanelLink.css +10 -6
  243. package/front_end/panels/issues/components/hideIssuesMenu.css +16 -14
  244. package/front_end/panels/issues/issues.ts +2 -0
  245. package/front_end/panels/issues/issuesTree.css +4 -4
  246. package/front_end/panels/lighthouse/LighthouseController.ts +6 -6
  247. package/front_end/panels/lighthouse/LighthouseStatusView.ts +12 -13
  248. package/front_end/panels/lighthouse/lighthouseStartView.css +1 -1
  249. package/front_end/panels/linear_memory_inspector/LinearMemoryInspectorPane.ts +159 -161
  250. package/front_end/panels/linear_memory_inspector/LinearMemoryInspectorView.ts +228 -0
  251. package/front_end/panels/linear_memory_inspector/components/LinearMemoryInspector.ts +32 -41
  252. package/front_end/panels/linear_memory_inspector/components/linearMemoryHighlightChipList.css +2 -2
  253. package/front_end/panels/linear_memory_inspector/linear_memory_inspector.ts +2 -0
  254. package/front_end/panels/media/EventDisplayTable.ts +2 -2
  255. package/front_end/panels/media/MainView.ts +132 -66
  256. package/front_end/panels/media/PlayerDetailView.ts +32 -14
  257. package/front_end/panels/media/PlayerListView.ts +83 -23
  258. package/front_end/panels/media/PlayerPropertiesView.ts +2 -2
  259. package/front_end/panels/media/TickingFlameChart.ts +153 -63
  260. package/front_end/panels/mobile_throttling/NetworkThrottlingSelector.ts +2 -2
  261. package/front_end/panels/mobile_throttling/ThrottlingSettingsTab.ts +615 -464
  262. package/front_end/panels/mobile_throttling/throttlingSettingsTab.css +43 -0
  263. package/front_end/panels/network/EventSourceMessagesView.ts +3 -3
  264. package/front_end/panels/network/NetworkConfigView.ts +6 -2
  265. package/front_end/panels/network/NetworkDataGridNode.ts +2 -1
  266. package/front_end/panels/network/NetworkItemView.ts +27 -26
  267. package/front_end/panels/network/NetworkManageCustomHeadersView.ts +236 -97
  268. package/front_end/panels/network/NetworkOverview.ts +8 -10
  269. package/front_end/panels/network/RequestConditionsDrawer.ts +8 -4
  270. package/front_end/panels/network/RequestDeviceBoundSessionsView.ts +2 -4
  271. package/front_end/panels/network/RequestHTMLView.ts +26 -7
  272. package/front_end/panels/network/RequestHeadersView.ts +2 -2
  273. package/front_end/panels/network/RequestInitiatorView.ts +21 -22
  274. package/front_end/panels/network/RequestPayloadView.ts +2 -16
  275. package/front_end/panels/network/RequestPreviewView.ts +5 -5
  276. package/front_end/panels/network/RequestTimingView.ts +6 -6
  277. package/front_end/panels/network/ResourceDirectSocketChunkView.ts +5 -6
  278. package/front_end/panels/network/ResourceWebSocketFrameView.ts +4 -3
  279. package/front_end/panels/network/ShowMoreDetailsWidget.ts +11 -12
  280. package/front_end/panels/network/SignedExchangeInfoView.ts +2 -2
  281. package/front_end/panels/network/networkLogView.css +2 -2
  282. package/front_end/panels/network/networkManageCustomHeadersView.css +27 -6
  283. package/front_end/panels/network/requestConditionsDrawer.css +1 -1
  284. package/front_end/panels/network/requestInitiatorView.css +5 -3
  285. package/front_end/panels/performance_monitor/PerformanceMonitor.ts +2 -2
  286. package/front_end/panels/profiler/HeapDetachedElementsView.ts +1 -2
  287. package/front_end/panels/profiler/HeapTimelineOverview.ts +77 -15
  288. package/front_end/panels/profiler/IsolateSelector.ts +258 -187
  289. package/front_end/panels/profiler/ProfileLauncherView.ts +7 -29
  290. package/front_end/panels/profiler/profileLauncherView.css +6 -1
  291. package/front_end/panels/protocol_monitor/JSONEditor.ts +4 -5
  292. package/front_end/panels/recorder/ControlButton.ts +1 -1
  293. package/front_end/panels/recorder/RecordingListView.ts +2 -4
  294. package/front_end/panels/recorder/RecordingView.ts +1 -2
  295. package/front_end/panels/recorder/SelectorPicker.ts +2 -4
  296. package/front_end/panels/recorder/StepView.ts +24 -10
  297. package/front_end/panels/recorder/TimelineSection.ts +1 -1
  298. package/front_end/panels/recorder/recordingView.css +1 -1
  299. package/front_end/panels/screencast/ScreencastApp.ts +1 -1
  300. package/front_end/panels/search/SearchResultsPane.ts +11 -12
  301. package/front_end/panels/search/SearchView.ts +8 -10
  302. package/front_end/panels/security/SecurityPanel.ts +1 -8
  303. package/front_end/panels/security/SecurityPanelSidebar.ts +2 -2
  304. package/front_end/panels/security/mainView.css +1 -1
  305. package/front_end/panels/sensors/LocationsSettingsTab.ts +1 -2
  306. package/front_end/panels/settings/AISettingsTab.ts +1 -1
  307. package/front_end/panels/settings/BackendLinkingSettingsTab.ts +34 -20
  308. package/front_end/panels/settings/EditFileSystemView.ts +2 -2
  309. package/front_end/panels/settings/FrameworkIgnoreListSettingsTab.ts +375 -197
  310. package/front_end/panels/settings/KeybindsSettingsTab.ts +570 -414
  311. package/front_end/panels/settings/SettingsScreen.ts +312 -114
  312. package/front_end/panels/settings/WorkspaceSettingsTab.ts +2 -2
  313. package/front_end/panels/settings/aiSettingsTab.css +1 -4
  314. package/front_end/panels/settings/emulation/DevicesSettingsTab.ts +924 -578
  315. package/front_end/panels/settings/emulation/components/UserAgentClientHintsForm.ts +9 -2
  316. package/front_end/panels/settings/emulation/devicesSettingsTab.css +39 -0
  317. package/front_end/panels/settings/frameworkIgnoreListSettingsTab.css +37 -8
  318. package/front_end/panels/settings/settingsScreen.css +0 -24
  319. package/front_end/panels/sources/BreakpointEditDialog.ts +9 -6
  320. package/front_end/panels/sources/BreakpointsView.ts +25 -4
  321. package/front_end/panels/sources/CallStackSidebarPane.ts +7 -1
  322. package/front_end/panels/sources/DebuggerPlugin.ts +1 -0
  323. package/front_end/panels/sources/GoToLineQuickOpen.ts +8 -8
  324. package/front_end/panels/sources/NavigatorView.ts +521 -439
  325. package/front_end/panels/sources/PersistenceActions.ts +11 -12
  326. package/front_end/panels/sources/ProfilePlugin.ts +28 -17
  327. package/front_end/panels/sources/ScopeChainSidebarPane.ts +3 -4
  328. package/front_end/panels/sources/SourcesNavigator.ts +9 -9
  329. package/front_end/panels/sources/SourcesPanel.ts +2 -2
  330. package/front_end/panels/sources/SourcesView.ts +3 -3
  331. package/front_end/panels/sources/ThreadsSidebarPane.ts +2 -2
  332. package/front_end/panels/sources/WatchExpressionsSidebarPane.ts +2 -2
  333. package/front_end/panels/sources/components/HeadersView.ts +1 -2
  334. package/front_end/panels/timeline/CompatibilityTracksAppender.ts +5 -6
  335. package/front_end/panels/timeline/EventsTimelineTreeView.ts +73 -34
  336. package/front_end/panels/timeline/IsolateSelector.ts +25 -37
  337. package/front_end/panels/timeline/StatusDialog.ts +5 -7
  338. package/front_end/panels/timeline/ThirdPartyTreeView.ts +10 -13
  339. package/front_end/panels/timeline/TimelineDetailsView.ts +40 -21
  340. package/front_end/panels/timeline/TimelineEventOverview.ts +130 -34
  341. package/front_end/panels/timeline/TimelineFlameChartNetworkDataProvider.ts +1 -1
  342. package/front_end/panels/timeline/TimelineMiniMap.ts +255 -103
  343. package/front_end/panels/timeline/TimelinePaintProfilerView.ts +19 -11
  344. package/front_end/panels/timeline/TimelinePanel.ts +1 -0
  345. package/front_end/panels/timeline/TimelineSelectorStatsView.ts +11 -12
  346. package/front_end/panels/timeline/TimelineTreeView.ts +240 -122
  347. package/front_end/panels/timeline/TimelineUIUtils.ts +12 -0
  348. package/front_end/panels/timeline/components/BreadcrumbsUI.ts +5 -4
  349. package/front_end/panels/timeline/components/DetailsView.ts +97 -65
  350. package/front_end/panels/timeline/components/LayoutShiftDetails.ts +2 -2
  351. package/front_end/panels/timeline/components/MetricCard.ts +2 -2
  352. package/front_end/panels/timeline/components/NetworkRequestDetails.ts +11 -12
  353. package/front_end/panels/timeline/components/NetworkTrackWidget.ts +57 -50
  354. package/front_end/panels/timeline/components/RelatedInsightChips.ts +2 -2
  355. package/front_end/panels/timeline/components/Sidebar.ts +161 -109
  356. package/front_end/panels/timeline/components/SidebarAnnotationsTab.ts +33 -12
  357. package/front_end/panels/timeline/components/SidebarInsightsTab.ts +3 -0
  358. package/front_end/panels/timeline/components/insights/LCPDiscovery.ts +11 -11
  359. package/front_end/panels/timeline/components/insights/SlowCSSSelector.ts +6 -7
  360. package/front_end/panels/timeline/components/networkTrackWidget.css +24 -22
  361. package/front_end/panels/timeline/components/sidebarInsightsTab.css +1 -1
  362. package/front_end/panels/timeline/overlays/components/TimespanBreakdownOverlay.ts +15 -10
  363. package/front_end/panels/timeline/overlays/components/entryLabelOverlay.css +1 -1
  364. package/front_end/panels/timeline/timelinePanel.css +5 -0
  365. package/front_end/panels/timeline/timelineStatusDialog.css +1 -1
  366. package/front_end/panels/web_audio/WebAudioView.ts +2 -2
  367. package/front_end/third_party/chromium/README.chromium +1 -1
  368. package/front_end/third_party/legacy-javascript/README.chromium +2 -2
  369. package/front_end/third_party/legacy-javascript/lib/legacy-javascript.js +2 -2
  370. package/front_end/third_party/legacy-javascript/package.json +1 -1
  371. package/front_end/third_party/lighthouse/README.chromium +2 -2
  372. package/front_end/third_party/lighthouse/lighthouse-dt-bundle.js +1983 -2022
  373. package/front_end/third_party/lighthouse/locales/ar-XB.json +157 -142
  374. package/front_end/third_party/lighthouse/locales/ar.json +157 -142
  375. package/front_end/third_party/lighthouse/locales/bg.json +154 -139
  376. package/front_end/third_party/lighthouse/locales/ca.json +157 -142
  377. package/front_end/third_party/lighthouse/locales/cs.json +148 -133
  378. package/front_end/third_party/lighthouse/locales/da.json +153 -138
  379. package/front_end/third_party/lighthouse/locales/de.json +152 -137
  380. package/front_end/third_party/lighthouse/locales/el.json +153 -138
  381. package/front_end/third_party/lighthouse/locales/en-GB.json +160 -145
  382. package/front_end/third_party/lighthouse/locales/en-US.json +239 -218
  383. package/front_end/third_party/lighthouse/locales/en-XL.json +239 -218
  384. package/front_end/third_party/lighthouse/locales/es-419.json +150 -135
  385. package/front_end/third_party/lighthouse/locales/es.json +149 -134
  386. package/front_end/third_party/lighthouse/locales/fi.json +151 -136
  387. package/front_end/third_party/lighthouse/locales/fil.json +154 -139
  388. package/front_end/third_party/lighthouse/locales/fr.json +150 -135
  389. package/front_end/third_party/lighthouse/locales/he.json +160 -145
  390. package/front_end/third_party/lighthouse/locales/hi.json +156 -141
  391. package/front_end/third_party/lighthouse/locales/hr.json +154 -139
  392. package/front_end/third_party/lighthouse/locales/hu.json +111 -96
  393. package/front_end/third_party/lighthouse/locales/id.json +153 -138
  394. package/front_end/third_party/lighthouse/locales/it.json +153 -138
  395. package/front_end/third_party/lighthouse/locales/ja.json +150 -135
  396. package/front_end/third_party/lighthouse/locales/ko.json +42 -27
  397. package/front_end/third_party/lighthouse/locales/lt.json +152 -137
  398. package/front_end/third_party/lighthouse/locales/lv.json +93 -78
  399. package/front_end/third_party/lighthouse/locales/nl.json +149 -134
  400. package/front_end/third_party/lighthouse/locales/no.json +152 -137
  401. package/front_end/third_party/lighthouse/locales/pl.json +153 -138
  402. package/front_end/third_party/lighthouse/locales/pt-PT.json +152 -137
  403. package/front_end/third_party/lighthouse/locales/pt.json +157 -142
  404. package/front_end/third_party/lighthouse/locales/ro.json +149 -134
  405. package/front_end/third_party/lighthouse/locales/ru.json +76 -61
  406. package/front_end/third_party/lighthouse/locales/sk.json +153 -138
  407. package/front_end/third_party/lighthouse/locales/sl.json +149 -134
  408. package/front_end/third_party/lighthouse/locales/sr-Latn.json +151 -136
  409. package/front_end/third_party/lighthouse/locales/sr.json +151 -136
  410. package/front_end/third_party/lighthouse/locales/sv.json +152 -137
  411. package/front_end/third_party/lighthouse/locales/ta.json +156 -141
  412. package/front_end/third_party/lighthouse/locales/te.json +157 -142
  413. package/front_end/third_party/lighthouse/locales/th.json +111 -96
  414. package/front_end/third_party/lighthouse/locales/tr.json +153 -138
  415. package/front_end/third_party/lighthouse/locales/uk.json +149 -134
  416. package/front_end/third_party/lighthouse/locales/vi.json +162 -147
  417. package/front_end/third_party/lighthouse/locales/zh-HK.json +150 -135
  418. package/front_end/third_party/lighthouse/locales/zh-TW.json +154 -139
  419. package/front_end/third_party/lighthouse/locales/zh.json +152 -137
  420. package/front_end/third_party/lighthouse/report/bundle.d.ts +9 -8
  421. package/front_end/third_party/lighthouse/report/bundle.js +10 -10
  422. package/front_end/third_party/lighthouse/report-assets/report-generator.mjs +2 -7
  423. package/front_end/tsconfig.compatibility.json +1 -0
  424. package/front_end/tsconfig.json +3 -2
  425. package/front_end/ui/components/dialogs/TypeToAllowDialog.ts +0 -2
  426. package/front_end/ui/components/dialogs/typeToAllowDialog.css +0 -4
  427. package/front_end/ui/components/icon_button/fileSourceIcon.css +1 -1
  428. package/front_end/ui/components/input/textInput.css +1 -1
  429. package/front_end/ui/components/lists/List.ts +26 -14
  430. package/front_end/ui/components/menus/menus.ts +0 -2
  431. package/front_end/ui/components/suggestion_input/SuggestionInput.ts +351 -138
  432. package/front_end/ui/components/survey_link/surveyLink.css +3 -3
  433. package/front_end/ui/components/switch/switch.css +6 -6
  434. package/front_end/ui/components/text_editor/AiCodeCompletionTeaser.ts +2 -3
  435. package/front_end/ui/components/text_editor/TextEditor.ts +1 -1
  436. package/front_end/ui/components/tooltips/Tooltip.ts +53 -4
  437. package/front_end/ui/components/tree_outline/treeOutline.css +7 -7
  438. package/front_end/ui/helpers/OpenInNewTab.ts +8 -3
  439. package/front_end/ui/legacy/EmptyWidget.ts +4 -4
  440. package/front_end/ui/legacy/ForwardedInputEventHandler.ts +2 -2
  441. package/front_end/ui/legacy/GlassPane.ts +1 -1
  442. package/front_end/ui/legacy/KeyboardShortcut.ts +7 -7
  443. package/front_end/ui/legacy/RemoteDebuggingTerminatedScreen.ts +2 -2
  444. package/front_end/ui/legacy/TabbedPane.ts +198 -66
  445. package/front_end/ui/legacy/TargetCrashedScreen.ts +2 -2
  446. package/front_end/ui/legacy/UIUtils.ts +71 -68
  447. package/front_end/ui/legacy/View.ts +7 -4
  448. package/front_end/ui/legacy/ViewManager.ts +49 -37
  449. package/front_end/ui/legacy/Widget.ts +32 -12
  450. package/front_end/ui/legacy/components/cookie_table/CookiesTable.ts +2 -3
  451. package/front_end/ui/legacy/components/inline_editor/AnimationTimingUI.ts +8 -8
  452. package/front_end/ui/legacy/components/inline_editor/BezierUI.ts +8 -9
  453. package/front_end/ui/legacy/components/inline_editor/LinkSwatch.ts +2 -2
  454. package/front_end/ui/legacy/components/inline_editor/cssAngleEditor.css +1 -1
  455. package/front_end/ui/legacy/components/inline_editor/cssAngleSwatch.css +1 -1
  456. package/front_end/ui/legacy/components/object_ui/ObjectPropertiesSection.ts +45 -11
  457. package/front_end/ui/legacy/components/object_ui/RemoteObjectPreviewFormatter.ts +10 -12
  458. package/front_end/ui/legacy/components/perf_ui/ChartViewport.ts +102 -29
  459. package/front_end/ui/legacy/components/perf_ui/FlameChart.ts +148 -122
  460. package/front_end/ui/legacy/components/perf_ui/TimelineOverviewPane.ts +20 -14
  461. package/front_end/ui/legacy/components/quick_open/filteredListWidget.css +1 -1
  462. package/front_end/ui/legacy/components/source_frame/FontView.ts +29 -5
  463. package/front_end/ui/legacy/components/source_frame/ImageView.ts +79 -12
  464. package/front_end/ui/legacy/components/source_frame/JSONView.ts +20 -2
  465. package/front_end/ui/legacy/components/source_frame/PreviewFactory.ts +2 -2
  466. package/front_end/ui/legacy/components/source_frame/StreamingContentHexView.ts +6 -10
  467. package/front_end/ui/legacy/components/source_frame/XMLView.ts +11 -11
  468. package/front_end/ui/legacy/components/source_frame/fontView.css +7 -0
  469. package/front_end/ui/legacy/components/source_frame/imageView.css +7 -0
  470. package/front_end/ui/legacy/components/utils/JSPresentationUtils.ts +14 -3
  471. package/front_end/ui/legacy/components/utils/Linkifier.ts +126 -2
  472. package/front_end/ui/legacy/emptyWidget.css +2 -1
  473. package/front_end/ui/legacy/inspectorCommon.css +3 -3
  474. package/front_end/ui/legacy/smallBubble.css +1 -1
  475. package/front_end/ui/legacy/tabbedPane.css +6 -0
  476. package/front_end/ui/lit/Directives.ts +35 -18
  477. package/front_end/ui/lit/lit.ts +0 -2
  478. package/front_end/ui/lit/render.ts +0 -7
  479. package/front_end/ui/visual_logging/KnownContextValues.ts +5 -0
  480. package/package.json +1 -1
  481. package/vpython.toml +8 -0
  482. package/vpython.toml.uv.lock +3 -0
  483. package/.agents/skills/review-models-core/SKILL.md +0 -73
  484. package/.agents/skills/review-tests/SKILL.md +0 -67
  485. package/.agents/skills/review-ui-widgets/SKILL.md +0 -115
  486. package/front_end/generated/ARIAProperties.ts +0 -2686
  487. package/front_end/ui/components/menus/README.md +0 -119
  488. package/front_end/ui/components/menus/SelectMenu.ts +0 -473
  489. package/front_end/ui/components/menus/selectMenu.css +0 -54
  490. package/front_end/ui/components/menus/selectMenuButton.css +0 -108
@@ -63,20 +63,6 @@ export interface Settings {
63
63
  endianness: Endianness;
64
64
  }
65
65
 
66
- export const enum Events {
67
- MEMORY_REQUEST = 'MemoryRequest',
68
- ADDRESS_CHANGED = 'AddressChanged',
69
- SETTINGS_CHANGED = 'SettingsChanged',
70
- DELETE_MEMORY_HIGHLIGHT = 'DeleteMemoryHighlight',
71
- }
72
-
73
- export interface EventTypes {
74
- [Events.MEMORY_REQUEST]: {start: number, end: number, address: number};
75
- [Events.ADDRESS_CHANGED]: number;
76
- [Events.SETTINGS_CHANGED]: Settings;
77
- [Events.DELETE_MEMORY_HIGHLIGHT]: HighlightInfo;
78
- }
79
-
80
66
  class AddressHistoryEntry implements Common.SimpleHistoryManager.HistoryEntry {
81
67
  #address = 0;
82
68
  #callback;
@@ -127,7 +113,7 @@ export interface ViewInput {
127
113
  viewerStart: number;
128
114
  }
129
115
 
130
- export const DEFAULT_VIEW = (input: ViewInput, _output: Record<string, unknown>, target: HTMLElement): void => {
116
+ export const DEFAULT_VIEW = (input: ViewInput, _output: undefined, target: HTMLElement): void => {
131
117
  const navigatorAddressToShow =
132
118
  input.currentNavigatorMode === Mode.SUBMITTED ? formatAddress(input.address) : input.currentNavigatorAddressLine;
133
119
  const navigatorAddressIsValid = isValidAddress(navigatorAddressToShow, input.outerMemoryLength);
@@ -160,7 +146,7 @@ export const DEFAULT_VIEW = (input: ViewInput, _output: Record<string, unknown>,
160
146
  ${widget(LinearMemoryHighlightChipList, {
161
147
  highlightInfos: highlightedMemoryAreas,
162
148
  focusedMemoryHighlight,
163
- jumpToAddress: (address: number) => input.onJumpToAddress(address),
149
+ jumpToAddress: input.onJumpToAddress,
164
150
  deleteHighlight: input.onDeleteMemoryHighlight,
165
151
  })}
166
152
  <devtools-widget class="viewer-widget"
@@ -238,12 +224,7 @@ function getSmallestEnclosingMemoryHighlight(highlightedMemoryAreas: HighlightIn
238
224
 
239
225
  export type View = typeof DEFAULT_VIEW;
240
226
 
241
- const LinearMemoryInspectorBase: Common.ObjectWrapper.EventMixin<EventTypes, typeof UI.Widget.Widget> =
242
- Common.ObjectWrapper.eventMixin(
243
- UI.Widget.Widget,
244
- );
245
-
246
- export class LinearMemoryInspector extends LinearMemoryInspectorBase {
227
+ export class LinearMemoryInspector extends UI.Widget.Widget {
247
228
  readonly #history = new Common.SimpleHistoryManager.SimpleHistoryManager(10);
248
229
 
249
230
  #memory = new Uint8Array();
@@ -263,6 +244,10 @@ export class LinearMemoryInspector extends LinearMemoryInspectorBase {
263
244
  #endianness = Endianness.LITTLE;
264
245
 
265
246
  #hideValueInspector = false;
247
+ #onMemoryRequest?: (request: {start: number, end: number, address: number}) => void;
248
+ #onAddressChanged?: (address: number) => void;
249
+ #onSettingsChanged?: (settings: Settings) => void;
250
+ #onDeleteMemoryHighlight?: (highlightInfo: HighlightInfo) => void;
266
251
  #view: View;
267
252
 
268
253
  constructor(element?: HTMLElement, view?: View) {
@@ -314,11 +299,27 @@ export class LinearMemoryInspector extends LinearMemoryInspectorBase {
314
299
  return this.#hideValueInspector;
315
300
  }
316
301
 
302
+ set onMemoryRequest(value: ((request: {start: number, end: number, address: number}) => void)|undefined) {
303
+ this.#onMemoryRequest = value;
304
+ }
305
+
306
+ set onAddressChanged(value: ((address: number) => void)|undefined) {
307
+ this.#onAddressChanged = value;
308
+ }
309
+
310
+ set onSettingsChanged(value: ((settings: Settings) => void)|undefined) {
311
+ this.#onSettingsChanged = value;
312
+ }
313
+
314
+ set onDeleteMemoryHighlight(value: ((highlightInfo: HighlightInfo) => void)|undefined) {
315
+ this.#onDeleteMemoryHighlight = value;
316
+ }
317
+
317
318
  override performUpdate(): void {
318
319
  const {start, end} = getPageRangeForAddress(this.#address, this.#numBytesPerPage, this.#outerMemoryLength);
319
320
 
320
321
  if (start < this.#memoryOffset || end > this.#memoryOffset + this.#memory.length) {
321
- this.dispatchEventToListeners(Events.MEMORY_REQUEST, {start, end, address: this.#address});
322
+ this.#onMemoryRequest?.({start, end, address: this.#address});
322
323
  return;
323
324
  }
324
325
 
@@ -357,8 +358,8 @@ export class LinearMemoryInspector extends LinearMemoryInspectorBase {
357
358
  onNavigatePage: this.#navigatePage.bind(this),
358
359
  onNavigateHistory: this.#navigateHistory.bind(this),
359
360
  onJumpToAddress: this.#onJumpToAddress.bind(this),
360
- onDeleteMemoryHighlight: this.#onDeleteMemoryHighlight.bind(this),
361
- onByteSelected: this.#onByteSelected.bind(this),
361
+ onDeleteMemoryHighlight: highlight => this.#onDeleteMemoryHighlight?.(highlight),
362
+ onByteSelected: this.#onJumpToAddress.bind(this),
362
363
  onResize: this.#resize.bind(this),
363
364
  onValueTypeToggled: this.#onValueTypeToggled.bind(this),
364
365
  onValueTypeModeChanged: this.#onValueTypeModeChanged.bind(this),
@@ -366,7 +367,7 @@ export class LinearMemoryInspector extends LinearMemoryInspectorBase {
366
367
  memorySlice: this.#memory.slice(start - this.#memoryOffset, end - this.#memoryOffset),
367
368
  viewerStart: start,
368
369
  };
369
- this.#view(viewInput, {}, this.contentElement);
370
+ this.#view(viewInput, undefined, this.contentElement);
370
371
  }
371
372
 
372
373
  #onJumpToAddress(address: number): void {
@@ -375,19 +376,9 @@ export class LinearMemoryInspector extends LinearMemoryInspectorBase {
375
376
  this.#jumpToAddress(addressInRange);
376
377
  }
377
378
 
378
- #onDeleteMemoryHighlight(highlight: HighlightInfo): void {
379
- this.dispatchEventToListeners(Events.DELETE_MEMORY_HIGHLIGHT, highlight);
380
- }
381
-
382
379
  #onRefreshRequest(): void {
383
380
  const {start, end} = getPageRangeForAddress(this.#address, this.#numBytesPerPage, this.#outerMemoryLength);
384
- this.dispatchEventToListeners(Events.MEMORY_REQUEST, {start, end, address: this.#address});
385
- }
386
-
387
- #onByteSelected(address: number): void {
388
- this.#currentNavigatorMode = Mode.SUBMITTED;
389
- const addressInRange = Math.max(0, Math.min(address, this.#outerMemoryLength - 1));
390
- this.#jumpToAddress(addressInRange);
381
+ this.#onMemoryRequest?.({start, end, address: this.#address});
391
382
  }
392
383
 
393
384
  #createSettings(): Settings {
@@ -396,7 +387,7 @@ export class LinearMemoryInspector extends LinearMemoryInspectorBase {
396
387
 
397
388
  #onEndiannessChanged(endianness: Endianness): void {
398
389
  this.#endianness = endianness;
399
- this.dispatchEventToListeners(Events.SETTINGS_CHANGED, this.#createSettings());
390
+ this.#onSettingsChanged?.(this.#createSettings());
400
391
  void this.requestUpdate();
401
392
  }
402
393
 
@@ -428,7 +419,7 @@ export class LinearMemoryInspector extends LinearMemoryInspectorBase {
428
419
  valueTypes.delete(type);
429
420
  }
430
421
  this.#valueTypes = valueTypes;
431
- this.dispatchEventToListeners(Events.SETTINGS_CHANGED, this.#createSettings());
422
+ this.#onSettingsChanged?.(this.#createSettings());
432
423
  void this.requestUpdate();
433
424
  }
434
425
 
@@ -436,7 +427,7 @@ export class LinearMemoryInspector extends LinearMemoryInspectorBase {
436
427
  const valueTypeModes = new Map(this.#valueTypeModes);
437
428
  valueTypeModes.set(type, mode);
438
429
  this.#valueTypeModes = valueTypeModes;
439
- this.dispatchEventToListeners(Events.SETTINGS_CHANGED, this.#createSettings());
430
+ this.#onSettingsChanged?.(this.#createSettings());
440
431
  void this.requestUpdate();
441
432
  }
442
433
 
@@ -473,7 +464,7 @@ export class LinearMemoryInspector extends LinearMemoryInspectorBase {
473
464
  const historyEntry = new AddressHistoryEntry(address, () => this.#jumpToAddress(address));
474
465
  this.#history.push(historyEntry);
475
466
  this.#address = address;
476
- this.dispatchEventToListeners(Events.ADDRESS_CHANGED, this.#address);
467
+ this.#onAddressChanged?.(this.#address);
477
468
  void this.requestUpdate();
478
469
  }
479
470
  }
@@ -56,7 +56,7 @@
56
56
 
57
57
  .delete-highlight-button:hover {
58
58
  background-color: var(--sys-color-state-hover-on-subtle);
59
- border-radius: 50%;
59
+ border-radius: var(--sys-shape-corner-full);
60
60
  }
61
61
 
62
62
  .jump-to-highlight-button {
@@ -76,7 +76,7 @@
76
76
  display: flex;
77
77
  align-items: center;
78
78
  justify-content: center;
79
- border-radius: 50%;
79
+ border-radius: var(--sys-shape-corner-full);
80
80
  }
81
81
 
82
82
  .source-code {
@@ -4,8 +4,10 @@
4
4
 
5
5
  import * as LinearMemoryInspectorController from './LinearMemoryInspectorController.js';
6
6
  import * as LinearMemoryInspectorPane from './LinearMemoryInspectorPane.js';
7
+ import * as LinearMemoryInspectorView from './LinearMemoryInspectorView.js';
7
8
 
8
9
  export {
9
10
  LinearMemoryInspectorController,
10
11
  LinearMemoryInspectorPane,
12
+ LinearMemoryInspectorView,
11
13
  };
@@ -80,7 +80,7 @@ export const DEFAULT_VIEW: View = (input, _output, target) => {
80
80
  </devtools-data-grid>
81
81
  `,
82
82
  // clang-format on
83
- target);
83
+ target, {container: {attributes: {jslog: `${VisualLogging.pane('events')}`}}});
84
84
  };
85
85
 
86
86
  export class PlayerEventsView extends UI.Widget.VBox {
@@ -89,7 +89,7 @@ export class PlayerEventsView extends UI.Widget.VBox {
89
89
  #parsedEvents: EventDisplayRow[] = [];
90
90
 
91
91
  constructor(view: View = DEFAULT_VIEW) {
92
- super({jslog: `${VisualLogging.pane('events')}`});
92
+ super();
93
93
  this.#view = view;
94
94
  this.firstEventTime = 0;
95
95
  this.requestUpdate();
@@ -1,7 +1,6 @@
1
1
  // Copyright 2019 The Chromium Authors
2
2
  // Use of this source code is governed by a BSD-style license that can be
3
3
  // found in the LICENSE file.
4
- /* eslint-disable @devtools/no-imperative-dom-api */
5
4
 
6
5
  import type * as Common from '../../core/common/common.js';
7
6
  import * as i18n from '../../core/i18n/i18n.js';
@@ -9,11 +8,75 @@ import type * as Platform from '../../core/platform/platform.js';
9
8
  import * as SDK from '../../core/sdk/sdk.js';
10
9
  import type * as Protocol from '../../generated/protocol.js';
11
10
  import * as UI from '../../ui/legacy/legacy.js';
11
+ import {Directives, html, render} from '../../ui/lit/lit.js';
12
+ import * as VisualLogging from '../../ui/visual_logging/visual_logging.js';
12
13
 
13
14
  import {Events, MediaModel, type PlayerEvent} from './MediaModel.js';
14
15
  import {PlayerDetailView} from './PlayerDetailView.js';
15
16
  import {PlayerListView} from './PlayerListView.js';
16
17
 
18
+ const {repeat} = Directives;
19
+ const {widget} = UI.Widget;
20
+
21
+ export interface PlayerData {
22
+ properties: Map<string, string>;
23
+ messages: Protocol.Media.PlayerMessage[];
24
+ events: PlayerEvent[];
25
+ errors: Protocol.Media.PlayerError[];
26
+ }
27
+
28
+ export interface ViewInput {
29
+ players: Map<string, PlayerData>;
30
+ activePlayerId: string|null;
31
+ onPlayerSelected: (playerID: string) => void;
32
+ onHidePlayer: (playerID: string) => void;
33
+ onHideOtherPlayers: (playerID: string) => void;
34
+ onSavePlayerInfo: (playerID: string) => void;
35
+ }
36
+
37
+ export type View = (input: ViewInput, _output: undefined, target: HTMLElement) => void;
38
+
39
+ export const DEFAULT_VIEW: View = (input, _output, target) => {
40
+ const hasPlayers = input.players.size > 0;
41
+ const activePlayerData = input.activePlayerId ? input.players.get(input.activePlayerId) : undefined;
42
+ const placeholderHeader =
43
+ hasPlayers ? i18nString(UIStrings.noPlayerDetailsSelected) : i18nString(UIStrings.noMediaPlayer);
44
+ const placeholderText =
45
+ hasPlayers ? i18nString(UIStrings.selectToViewDetails) : i18nString(UIStrings.mediaPlayerDescription);
46
+ // clang-format off
47
+ render(html`
48
+ <devtools-split-view direction="column"
49
+ name="media-panel-split-view-state"
50
+ sidebar-initial-size="200"
51
+ show=${hasPlayers ? 'both' : 'main'}>
52
+ <devtools-widget slot="sidebar"
53
+ class="panel-sidebar"
54
+ jslog=${VisualLogging.pane('sidebar').track({resize: true})}
55
+ ${widget(PlayerListView, {
56
+ players: input.players,
57
+ selectedPlayerID: input.activePlayerId,
58
+ onSelectPlayer: input.onPlayerSelected,
59
+ onHidePlayer: input.onHidePlayer,
60
+ onHideOtherPlayers: input.onHideOtherPlayers,
61
+ onSavePlayerInfo: input.onSavePlayerInfo,
62
+ })}>
63
+ </devtools-widget>
64
+ ${activePlayerData && input.activePlayerId ? repeat([input.activePlayerId], id => id, () => html`
65
+ <devtools-widget slot="main" ${widget(PlayerDetailView, {
66
+ playerData: activePlayerData,
67
+ })}></devtools-widget>
68
+ `) : html`
69
+ <devtools-widget slot="main" ${widget(UI.EmptyWidget.EmptyWidget, {
70
+ header: placeholderHeader,
71
+ text: placeholderText,
72
+ link: MEDIA_PLAYER_EXPLANATION_URL,
73
+ })}></devtools-widget>
74
+ `}
75
+ </devtools-split-view>
76
+ `, target);
77
+ // clang-format on
78
+ };
79
+
17
80
  const UIStrings = {
18
81
  /**
19
82
  * @description Text to show if no media player has been selected.
@@ -85,12 +148,7 @@ class PlayerDataCollection implements TriggerHandler {
85
148
  this.events.push(event);
86
149
  }
87
150
 
88
- export(): {
89
- properties: Map<string, string>,
90
- messages: Protocol.Media.PlayerMessage[],
91
- events: PlayerEvent[],
92
- errors: Protocol.Media.PlayerError[],
93
- } {
151
+ export(): PlayerData {
94
152
  return {properties: this.properties, messages: this.messages, events: this.events, errors: this.errors};
95
153
  }
96
154
  }
@@ -141,12 +199,7 @@ export class PlayerDataDownloadManager implements TriggerDispatcher {
141
199
  playerProperty.onEvent(event);
142
200
  }
143
201
 
144
- exportPlayerData(playerID: string): {
145
- properties: Map<string, string>,
146
- messages: Protocol.Media.PlayerMessage[],
147
- events: PlayerEvent[],
148
- errors: Protocol.Media.PlayerError[],
149
- } {
202
+ exportPlayerData(playerID: string): PlayerData {
150
203
  const playerProperty = this.playerDataCollection.get(playerID);
151
204
  if (!playerProperty) {
152
205
  throw new Error('Unable to find player');
@@ -160,20 +213,25 @@ export class PlayerDataDownloadManager implements TriggerDispatcher {
160
213
  }
161
214
  }
162
215
 
163
- export class MainView extends UI.Panel.PanelWithSidebar implements SDK.TargetManager.SDKModelObserver<MediaModel> {
164
- private detailPanels: Map<string, PlayerDetailView>;
216
+ export class MainView extends UI.Panel.Panel implements SDK.TargetManager.SDKModelObserver<MediaModel> {
165
217
  private deletedPlayers: Set<string>;
166
218
  private readonly downloadStore: PlayerDataDownloadManager;
167
- private readonly sidebar: PlayerListView;
219
+ #playerData: Map<string, PlayerData>;
168
220
  #playerIdsToPlayers: Map<string, Protocol.Media.Player>;
169
221
  #domNodeIdsToPlayerIds: Map<Protocol.DOM.BackendNodeId, string>;
170
- #placeholder: UI.EmptyWidget.EmptyWidget;
222
+ #activePlayerId: string|null = null;
223
+ readonly #view: View;
171
224
  readonly #initialPlayersLoadedPromise: Promise<void>;
172
225
  #initialPlayersLoadedPromiseResolve: () => void = () => {};
226
+ readonly #boundRenderMainPanel = this.renderMainPanel.bind(this);
227
+ readonly #boundMarkPlayerForDeletion = this.markPlayerForDeletion.bind(this);
228
+ readonly #boundMarkOtherPlayersForDeletion = this.markOtherPlayersForDeletion.bind(this);
229
+ readonly #boundExportPlayerData = this.exportPlayerData.bind(this);
173
230
 
174
- constructor(downloadStore: PlayerDataDownloadManager = new PlayerDataDownloadManager()) {
231
+ constructor(downloadStore: PlayerDataDownloadManager = new PlayerDataDownloadManager(), view: View = DEFAULT_VIEW) {
175
232
  super('media');
176
- this.detailPanels = new Map();
233
+ this.#view = view;
234
+ this.#playerData = new Map();
177
235
  this.#playerIdsToPlayers = new Map();
178
236
  this.#domNodeIdsToPlayerIds = new Map();
179
237
  this.#initialPlayersLoadedPromise = new Promise(resolve => {
@@ -183,28 +241,29 @@ export class MainView extends UI.Panel.PanelWithSidebar implements SDK.TargetMan
183
241
  this.deletedPlayers = new Set();
184
242
 
185
243
  this.downloadStore = downloadStore;
186
-
187
- this.sidebar = new PlayerListView(this);
188
- this.sidebar.show(this.panelSidebarElement());
189
- this.splitWidget().hideSidebar();
190
-
191
- this.#placeholder =
192
- new UI.EmptyWidget.EmptyWidget(i18nString(UIStrings.noMediaPlayer), UIStrings.mediaPlayerDescription);
193
- this.#placeholder.show(this.mainElement());
194
- this.#placeholder.link = MEDIA_PLAYER_EXPLANATION_URL;
244
+ this.requestUpdate();
195
245
 
196
246
  SDK.TargetManager.TargetManager.instance().observeModels(MediaModel, this, {scoped: true});
197
247
  }
198
248
 
249
+ override performUpdate(): void {
250
+ const input: ViewInput = {
251
+ players: new Map(this.#playerData),
252
+ activePlayerId: this.#activePlayerId,
253
+ onPlayerSelected: this.#boundRenderMainPanel,
254
+ onHidePlayer: this.#boundMarkPlayerForDeletion,
255
+ onHideOtherPlayers: this.#boundMarkOtherPlayersForDeletion,
256
+ onSavePlayerInfo: this.#boundExportPlayerData,
257
+ };
258
+ this.#view(input, undefined, this.contentElement);
259
+ }
260
+
199
261
  renderMainPanel(playerID: string): void {
200
- if (!this.detailPanels.has(playerID)) {
262
+ if (!this.#playerData.has(playerID) || this.#activePlayerId === playerID) {
201
263
  return;
202
264
  }
203
- const mainWidget = this.splitWidget().mainWidget();
204
- if (mainWidget) {
205
- mainWidget.detachChildWidgets();
206
- }
207
- this.detailPanels.get(playerID)?.show(this.mainElement());
265
+ this.#activePlayerId = playerID;
266
+ this.requestUpdate();
208
267
  }
209
268
 
210
269
  override wasShown(): void {
@@ -277,43 +336,59 @@ export class MainView extends UI.Panel.PanelWithSidebar implements SDK.TargetMan
277
336
  }
278
337
 
279
338
  private shouldPropagate(playerID: string): boolean {
280
- return !this.deletedPlayers.has(playerID) && this.detailPanels.has(playerID);
339
+ return !this.deletedPlayers.has(playerID) && this.#playerData.has(playerID);
281
340
  }
282
341
 
283
342
  onProperty(playerID: string, property: Protocol.Media.PlayerProperty): void {
284
343
  if (!this.shouldPropagate(playerID)) {
285
344
  return;
286
345
  }
287
- this.sidebar.onProperty(playerID, property);
288
346
  this.downloadStore.onProperty(playerID, property);
289
- this.detailPanels.get(playerID)?.onProperty(property);
347
+ const data = this.#playerData.get(playerID);
348
+ if (data) {
349
+ data.properties.set(property.name, property.value);
350
+ this.#playerData.set(playerID, {...data});
351
+ this.requestUpdate();
352
+ }
290
353
  }
291
354
 
292
355
  onError(playerID: string, error: Protocol.Media.PlayerError): void {
293
356
  if (!this.shouldPropagate(playerID)) {
294
357
  return;
295
358
  }
296
- this.sidebar.onError(playerID, error);
297
359
  this.downloadStore.onError(playerID, error);
298
- this.detailPanels.get(playerID)?.onError(error);
360
+ const data = this.#playerData.get(playerID);
361
+ if (data) {
362
+ data.errors.push(error);
363
+ this.#playerData.set(playerID, {...data});
364
+ this.requestUpdate();
365
+ }
299
366
  }
300
367
 
301
368
  onMessage(playerID: string, message: Protocol.Media.PlayerMessage): void {
302
369
  if (!this.shouldPropagate(playerID)) {
303
370
  return;
304
371
  }
305
- this.sidebar.onMessage(playerID, message);
306
372
  this.downloadStore.onMessage(playerID, message);
307
- this.detailPanels.get(playerID)?.onMessage(message);
373
+ const data = this.#playerData.get(playerID);
374
+ if (data) {
375
+ data.messages.push(message);
376
+ this.#playerData.set(playerID, {...data});
377
+ this.requestUpdate();
378
+ }
308
379
  }
309
380
 
310
381
  onEvent(playerID: string, event: PlayerEvent): void {
311
382
  if (!this.shouldPropagate(playerID)) {
312
383
  return;
313
384
  }
314
- this.sidebar.onEvent(playerID, event);
315
385
  this.downloadStore.onEvent(playerID, event);
316
- this.detailPanels.get(playerID)?.onEvent(event);
386
+ const data = this.#playerData.get(playerID);
387
+ if (data) {
388
+ data.events.push(event);
389
+ this.#playerData.set(playerID, {...data});
390
+ this.requestUpdate();
391
+ }
317
392
  }
318
393
 
319
394
  selectPlayerByDOMNodeId(domNodeId: Protocol.DOM.BackendNodeId): void {
@@ -323,7 +398,7 @@ export class MainView extends UI.Panel.PanelWithSidebar implements SDK.TargetMan
323
398
  }
324
399
  const player = this.#playerIdsToPlayers.get(playerId);
325
400
  if (player) {
326
- this.sidebar.selectPlayerById(player.playerId);
401
+ this.renderMainPanel(player.playerId);
327
402
  }
328
403
  }
329
404
 
@@ -338,17 +413,14 @@ export class MainView extends UI.Panel.PanelWithSidebar implements SDK.TargetMan
338
413
  this.#domNodeIdsToPlayerIds.set(player.domNodeId, player.playerId);
339
414
  }
340
415
 
341
- if (this.splitWidget().showMode() !== UI.SplitWidget.ShowMode.BOTH) {
342
- this.splitWidget().showBoth();
343
- }
344
- this.sidebar.addMediaElementItem(player.playerId);
345
- this.detailPanels.set(player.playerId, new PlayerDetailView());
416
+ this.#playerData.set(player.playerId, {
417
+ properties: new Map(),
418
+ messages: [],
419
+ events: [],
420
+ errors: [],
421
+ });
346
422
  this.downloadStore.addPlayer(player.playerId);
347
-
348
- if (this.detailPanels.size === 1) {
349
- this.#placeholder.header = i18nString(UIStrings.noPlayerDetailsSelected);
350
- this.#placeholder.text = i18nString(UIStrings.selectToViewDetails);
351
- }
423
+ this.requestUpdate();
352
424
 
353
425
  this.#initialPlayersLoadedPromiseResolve();
354
426
  }
@@ -356,28 +428,21 @@ export class MainView extends UI.Panel.PanelWithSidebar implements SDK.TargetMan
356
428
  markPlayerForDeletion(playerID: string): void {
357
429
  // TODO(tmathmeyer): send this to chromium to save the storage space there too.
358
430
  this.deletedPlayers.add(playerID);
359
- this.detailPanels.delete(playerID);
431
+ this.#playerData.delete(playerID);
360
432
  const player = this.#playerIdsToPlayers.get(playerID);
361
433
  if (player?.domNodeId) {
362
434
  this.#domNodeIdsToPlayerIds.delete(player.domNodeId);
363
435
  }
364
436
  this.#playerIdsToPlayers.delete(playerID);
365
- this.sidebar.deletePlayer(playerID);
366
437
  this.downloadStore.deletePlayer(playerID);
367
- if (this.detailPanels.size === 0) {
368
- this.#placeholder.header = i18nString(UIStrings.noMediaPlayer);
369
- this.#placeholder.text = i18nString(UIStrings.mediaPlayerDescription);
370
- this.splitWidget().hideSidebar();
371
- const mainWidget = this.splitWidget().mainWidget();
372
- if (mainWidget) {
373
- mainWidget.detachChildWidgets();
374
- }
375
- this.#placeholder.show(this.mainElement());
438
+ if (this.#activePlayerId === playerID) {
439
+ this.#activePlayerId = null;
376
440
  }
441
+ this.requestUpdate();
377
442
  }
378
443
 
379
444
  markOtherPlayersForDeletion(playerID: string): void {
380
- for (const keyID of this.detailPanels.keys()) {
445
+ for (const keyID of this.#playerData.keys()) {
381
446
  if (keyID !== playerID) {
382
447
  this.markPlayerForDeletion(keyID);
383
448
  }
@@ -387,6 +452,7 @@ export class MainView extends UI.Panel.PanelWithSidebar implements SDK.TargetMan
387
452
  exportPlayerData(playerID: string): void {
388
453
  const dump = this.downloadStore.exportPlayerData(playerID);
389
454
  const uriContent = 'data:application/octet-stream,' + encodeURIComponent(JSON.stringify(dump, null, 2));
455
+ /* eslint-disable-next-line @devtools/no-imperative-dom-api */
390
456
  const anchor = document.createElement('a');
391
457
  anchor.href = uriContent;
392
458
  anchor.download = playerID + '.json';
@@ -8,7 +8,7 @@ import * as UI from '../../ui/legacy/legacy.js';
8
8
 
9
9
  import {PlayerEventsView} from './EventDisplayTable.js';
10
10
  import {PlayerEventsTimeline} from './EventTimelineView.js';
11
- import type {TriggerHandler} from './MainView.js';
11
+ import type {PlayerData, TriggerHandler} from './MainView.js';
12
12
  import type {PlayerEvent} from './MediaModel.js';
13
13
  import {PlayerMessagesView} from './PlayerMessagesView.js';
14
14
  import {PlayerPropertiesView} from './PlayerPropertiesView.js';
@@ -62,26 +62,44 @@ export class PlayerDetailView extends UI.TabbedPane.TabbedPane implements Trigge
62
62
  private readonly propertyView: PlayerPropertiesView;
63
63
  private readonly messageView: PlayerMessagesView;
64
64
  private readonly timelineView: PlayerEventsTimeline;
65
+ #processedEventsCount = 0;
66
+ #processedMessagesCount = 0;
67
+ #processedErrorsCount = 0;
65
68
 
66
- constructor() {
67
- super();
69
+ constructor(element?: HTMLElement) {
70
+ super(element);
68
71
 
69
72
  this.eventView = new PlayerEventsView();
70
73
  this.propertyView = new PlayerPropertiesView();
71
74
  this.messageView = new PlayerMessagesView();
72
75
  this.timelineView = new PlayerEventsTimeline();
73
76
 
74
- this.appendTab(
75
- PlayerDetailViewTabs.PROPERTIES, i18nString(UIStrings.properties), this.propertyView,
76
- i18nString(UIStrings.playerProperties));
77
- this.appendTab(
78
- PlayerDetailViewTabs.EVENTS, i18nString(UIStrings.events), this.eventView, i18nString(UIStrings.playerEvents));
79
- this.appendTab(
80
- PlayerDetailViewTabs.MESSAGES, i18nString(UIStrings.messages), this.messageView,
81
- i18nString(UIStrings.playerMessages));
82
- this.appendTab(
83
- PlayerDetailViewTabs.TIMELINE, i18nString(UIStrings.timeline), this.timelineView,
84
- i18nString(UIStrings.playerTimeline));
77
+ this.appendTab(PlayerDetailViewTabs.PROPERTIES, i18nString(UIStrings.properties), this.propertyView,
78
+ i18nString(UIStrings.playerProperties));
79
+ this.appendTab(PlayerDetailViewTabs.EVENTS, i18nString(UIStrings.events), this.eventView,
80
+ i18nString(UIStrings.playerEvents));
81
+ this.appendTab(PlayerDetailViewTabs.MESSAGES, i18nString(UIStrings.messages), this.messageView,
82
+ i18nString(UIStrings.playerMessages));
83
+ this.appendTab(PlayerDetailViewTabs.TIMELINE, i18nString(UIStrings.timeline), this.timelineView,
84
+ i18nString(UIStrings.playerTimeline));
85
+ }
86
+
87
+ set playerData(data: PlayerData) {
88
+ for (const [name, value] of data.properties) {
89
+ this.onProperty({name, value});
90
+ }
91
+ for (let i = this.#processedEventsCount; i < data.events.length; i++) {
92
+ this.onEvent(data.events[i]);
93
+ }
94
+ this.#processedEventsCount = data.events.length;
95
+ for (let i = this.#processedMessagesCount; i < data.messages.length; i++) {
96
+ this.onMessage(data.messages[i]);
97
+ }
98
+ this.#processedMessagesCount = data.messages.length;
99
+ for (let i = this.#processedErrorsCount; i < data.errors.length; i++) {
100
+ this.onError(data.errors[i]);
101
+ }
102
+ this.#processedErrorsCount = data.errors.length;
85
103
  }
86
104
 
87
105
  onProperty(property: Protocol.Media.PlayerProperty): void {