chrome-devtools-frontend 1.0.1726686 → 1.0.1730971

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (490) hide show
  1. package/.agents/rules/tests/test-strict-assertions-and-literal-expectations.md +1 -1
  2. package/.agents/rules/tests/test-view-and-presenter-isolation.md +1 -1
  3. package/.agents/rules/ui-and-widgets/ui-accessibility-and-semantic-html.md +1 -1
  4. package/.agents/rules/ui-and-widgets/ui-css-scoping-and-flex-layout.md +2 -2
  5. package/.agents/rules/ui-and-widgets/ui-declarative-child-widget-composition.md +5 -5
  6. package/.agents/rules/ui-and-widgets/ui-lit-declarative-templates-and-directives.md +2 -2
  7. package/.agents/rules/ui-and-widgets/ui-localization-and-uistrings-hygiene.md +2 -2
  8. package/.agents/rules/ui-and-widgets/ui-modern-component-and-encapsulation-standards.md +3 -3
  9. package/.agents/rules/ui-and-widgets/ui-pure-view-and-presenter-separation.md +2 -2
  10. package/.agents/rules/ui-and-widgets/ui-reactive-widget-update-lifecycle.md +2 -2
  11. package/.agents/rules/ui-and-widgets/ui-view-output-and-callback-contracts.md +2 -2
  12. package/.agents/rules/ui-and-widgets/ui-widget-dom-and-listener-lifecycle.md +2 -2
  13. package/.agents/skills/code-review/SKILL.md +63 -12
  14. package/.agents/skills/ui-eng-vision-local-lit-renderer/SKILL.md +38 -10
  15. package/.agents/skills/ui-eng-vision-widget-promoter/SKILL.md +1 -0
  16. package/.agents/skills/ui-widgets/SKILL.md +8 -2
  17. package/.agents/skills/write-ai-eval-test/SKILL.md +106 -0
  18. package/AUTHORS +2 -0
  19. package/DIR_METADATA +1 -2
  20. package/README.md +48 -26
  21. package/config/typescript/tsconfig.base.json +1 -0
  22. package/config/typescript/tsconfig.eslint.json +1 -0
  23. package/docs/contributing/changes.md +25 -0
  24. package/docs/ui_engineering.md +13 -4
  25. package/eslint.config.mjs +323 -41
  26. package/front_end/core/common/Color.ts +7 -7
  27. package/front_end/core/common/ParsedURL.ts +3 -3
  28. package/front_end/core/common/ResolverBase.ts +3 -3
  29. package/front_end/core/common/SegmentedRange.ts +3 -3
  30. package/front_end/core/common/SimpleHistoryManager.ts +14 -14
  31. package/front_end/core/common/Trie.ts +3 -3
  32. package/front_end/core/common/VersionController.ts +7 -7
  33. package/front_end/core/host/InspectorFrontendHost.ts +2 -2
  34. package/front_end/core/host/InspectorFrontendHostAPI.ts +9 -1
  35. package/front_end/core/host/InspectorFrontendHostStub.ts +1 -1
  36. package/front_end/core/host/UserMetrics.ts +4 -0
  37. package/front_end/core/host/UserMetricsEnums.ts +2 -1
  38. package/front_end/core/platform/StringUtilities.ts +54 -13
  39. package/front_end/core/platform/node/HostRuntime.ts +13 -7
  40. package/front_end/core/protocol_client/DevToolsCDPConnection.ts +4 -5
  41. package/front_end/core/root/Runtime.ts +5 -0
  42. package/front_end/core/sdk/AccessibilityModel.ts +5 -5
  43. package/front_end/core/sdk/AnimationModel.ts +17 -19
  44. package/front_end/core/sdk/CPUProfilerModel.ts +3 -3
  45. package/front_end/core/sdk/CPUThrottlingManager.ts +7 -0
  46. package/front_end/core/sdk/CSSMatchedStyles.ts +73 -13
  47. package/front_end/core/sdk/CSSMetadata.ts +7 -7
  48. package/front_end/core/sdk/CSSModel.ts +33 -33
  49. package/front_end/core/sdk/CSSProperty.ts +5 -5
  50. package/front_end/core/sdk/CSSRule.ts +6 -6
  51. package/front_end/core/sdk/CSSStyleSheetHeader.ts +4 -4
  52. package/front_end/core/sdk/Connections.ts +16 -16
  53. package/front_end/core/sdk/ConsoleModel.ts +44 -47
  54. package/front_end/core/sdk/CookieParser.ts +11 -11
  55. package/front_end/core/sdk/EmulationModel.ts +35 -36
  56. package/front_end/core/sdk/EventBreakpointsModel.ts +11 -11
  57. package/front_end/core/sdk/FrameManager.ts +16 -16
  58. package/front_end/core/sdk/IsolateManager.ts +2 -2
  59. package/front_end/core/sdk/IssuesModel.ts +2 -2
  60. package/front_end/core/sdk/OverlayModel.ts +19 -19
  61. package/front_end/core/sdk/PageResourceLoader.ts +14 -16
  62. package/front_end/core/sdk/RemoteObject.ts +9 -9
  63. package/front_end/core/sdk/Resource.ts +2 -2
  64. package/front_end/core/sdk/RuntimeModel.ts +7 -7
  65. package/front_end/core/sdk/Script.ts +6 -6
  66. package/front_end/core/sdk/ServiceWorkerManager.ts +36 -10
  67. package/front_end/core/sdk/SourceMap.ts +18 -20
  68. package/front_end/core/sdk/SourceMapManager.ts +2 -2
  69. package/front_end/core/sdk/TargetManager.ts +2 -2
  70. package/front_end/devtools_compatibility.js +7 -3
  71. package/front_end/entrypoints/inspector_main/InspectorMain.ts +2 -2
  72. package/front_end/entrypoints/node_app/app/NodeConnectionsPanel.ts +203 -115
  73. package/front_end/generated/InspectorBackendCommands.ts +1 -1
  74. package/front_end/generated/SupportedCSSProperties.ts +1 -3
  75. package/front_end/generated/protocol.ts +1 -0
  76. package/front_end/models/ai_assistance/AiAgent2.ts +36 -12
  77. package/front_end/models/ai_assistance/AiConversation.ts +8 -2
  78. package/front_end/models/ai_assistance/agents/AiAgent.ts +137 -62
  79. package/front_end/models/ai_assistance/agents/ExecuteJavascript.ts +2 -2
  80. package/front_end/models/ai_assistance/agents/StylingAgent.snapshot.txt +2 -2
  81. package/front_end/models/ai_assistance/data_formatters/LighthouseFormatter.snapshot.txt +149 -2
  82. package/front_end/models/ai_assistance/data_formatters/LighthouseFormatter.ts +269 -42
  83. package/front_end/models/ai_assistance/tools/ExecuteJavaScript.ts +3 -0
  84. package/front_end/models/ai_assistance/tools/GetLighthouseAudits.ts +9 -0
  85. package/front_end/models/ai_assistance/tools/ResolveDevtoolsNodePath.ts +13 -2
  86. package/front_end/models/ai_assistance/tools/RunLighthouse.ts +23 -7
  87. package/front_end/models/ai_assistance/tools/Tool.ts +7 -5
  88. package/front_end/models/bindings/CSSWorkspaceBinding.ts +22 -24
  89. package/front_end/models/bindings/DebuggerLanguagePlugins.ts +60 -60
  90. package/front_end/models/bindings/DebuggerWorkspaceBinding.ts +24 -24
  91. package/front_end/models/bindings/DefaultScriptMapping.ts +8 -8
  92. package/front_end/models/bindings/FileUtils.ts +13 -13
  93. package/front_end/models/bindings/PresentationConsoleMessageHelper.ts +3 -3
  94. package/front_end/models/bindings/ResourceScriptMapping.ts +23 -23
  95. package/front_end/models/comment_manager/CommentManager.ts +3 -3
  96. package/front_end/models/comment_manager/CommentThread.ts +50 -5
  97. package/front_end/models/cpu_profile/CPUProfileDataModel.ts +14 -14
  98. package/front_end/models/cpu_profile/ProfileTreeModel.ts +4 -4
  99. package/front_end/models/elements/StyleChanges.ts +38 -0
  100. package/front_end/models/emulation/EmulatedDevices.ts +12 -12
  101. package/front_end/models/har/HARFormat.ts +4 -4
  102. package/front_end/models/javascript_metadata/NativeFunctions.ts +5 -1
  103. package/front_end/models/lighthouse/LighthouseReporterTypes.ts +57 -3
  104. package/front_end/models/lighthouse/RunTypes.ts +9 -1
  105. package/front_end/models/logs/LogManager.ts +2 -2
  106. package/front_end/models/persistence/AutomaticFileSystemManager.ts +3 -0
  107. package/front_end/models/persistence/FileSystemWorkspaceBinding.ts +24 -24
  108. package/front_end/models/persistence/IsolatedFileSystemManager.ts +6 -0
  109. package/front_end/models/persistence/NetworkPersistenceManager.ts +8 -3
  110. package/front_end/models/trace/LanternComputationData.ts +37 -11
  111. package/front_end/models/trace/Processor.ts +2 -1
  112. package/front_end/models/trace/extras/TraceTree.ts +36 -10
  113. package/front_end/models/trace/handlers/InitiatorsHandler.ts +27 -34
  114. package/front_end/models/trace/handlers/LayoutShiftsHandler.ts +2 -6
  115. package/front_end/models/trace/handlers/SamplesHandler.ts +9 -6
  116. package/front_end/models/workspace/FileManager.ts +6 -0
  117. package/front_end/panels/accessibility/ARIAAttributesView.ts +4 -4
  118. package/front_end/panels/accessibility/AccessibilityAnnouncementRecordingView.ts +8 -1
  119. package/front_end/panels/accessibility/AccessibilityNodeView.ts +15 -17
  120. package/front_end/panels/accessibility/AccessibilitySubPane.ts +1 -1
  121. package/front_end/panels/ai_assistance/AiAssistancePanel.ts +5 -5
  122. package/front_end/panels/ai_assistance/ExternalHandler.ts +10 -1
  123. package/front_end/panels/ai_assistance/components/ChatMessage.ts +27 -22
  124. package/front_end/panels/ai_assistance/components/DisabledWidget.ts +19 -23
  125. package/front_end/panels/ai_assistance/components/ExploreWidget.ts +2 -2
  126. package/front_end/panels/ai_assistance/components/PermissionPrompt.ts +23 -9
  127. package/front_end/panels/ai_assistance/components/chatInput.css +1 -1
  128. package/front_end/panels/animation/AnimationTimeline.ts +37 -17
  129. package/front_end/panels/animation/animationTimeline.css +19 -3
  130. package/front_end/panels/application/AppManifestView.ts +1 -2
  131. package/front_end/panels/application/ApplicationPanelSidebar.ts +143 -128
  132. package/front_end/panels/application/DOMStorageItemsView.ts +14 -14
  133. package/front_end/panels/application/DeviceBoundSessionsView.ts +10 -13
  134. package/front_end/panels/application/ExtensionStorageItemsView.ts +3 -4
  135. package/front_end/panels/application/IndexedDBViews.ts +8 -4
  136. package/front_end/panels/application/KeyValueStorageItemsView.ts +4 -5
  137. package/front_end/panels/application/PrivateVerificationTokensView.ts +53 -0
  138. package/front_end/panels/application/ServiceWorkerCacheViews.ts +12 -8
  139. package/front_end/panels/application/ServiceWorkersView.ts +1 -2
  140. package/front_end/panels/application/StorageItemsToolbar.ts +3 -3
  141. package/front_end/panels/application/StorageView.ts +2 -2
  142. package/front_end/panels/application/WebMCPView.ts +91 -109
  143. package/front_end/panels/application/application.ts +2 -0
  144. package/front_end/panels/application/components/StorageMetadataView.ts +6 -6
  145. package/front_end/panels/application/preloading/PreloadingView.ts +70 -37
  146. package/front_end/panels/application/preloading/components/MismatchedPreloadingGrid.ts +2 -2
  147. package/front_end/panels/application/preloading/components/PreloadingDisabledInfobar.ts +3 -3
  148. package/front_end/panels/application/preloading/components/PreloadingGrid.ts +12 -0
  149. package/front_end/panels/application/preloading/components/RuleSetDetailsView.ts +10 -11
  150. package/front_end/panels/application/privateVerificationTokensView.css +20 -0
  151. package/front_end/panels/application/serviceWorkersView.css +2 -2
  152. package/front_end/panels/browser_debugger/DOMBreakpointsSidebarPane.ts +24 -24
  153. package/front_end/panels/changes/ChangesSidebar.ts +5 -5
  154. package/front_end/panels/changes/ChangesView.ts +10 -11
  155. package/front_end/panels/comments/CommentsPane.ts +292 -102
  156. package/front_end/panels/comments/commentsPane.css +93 -12
  157. package/front_end/panels/common/CommentThreadWidget.ts +69 -0
  158. package/front_end/panels/common/CommentsOverlayWidget.ts +108 -29
  159. package/front_end/panels/common/CommentsStatusBarPill.ts +17 -6
  160. package/front_end/panels/common/DOMLinkifier.ts +37 -12
  161. package/front_end/panels/common/ExtensionPanel.ts +13 -4
  162. package/front_end/panels/common/ExtensionServer.ts +27 -3
  163. package/front_end/panels/common/PersistenceUtils.ts +3 -3
  164. package/front_end/panels/common/commentThreadWidget.css +25 -1
  165. package/front_end/panels/common/common-meta.ts +10 -0
  166. package/front_end/panels/console/ConsolePinPane.ts +13 -15
  167. package/front_end/panels/console/ConsolePrompt.ts +173 -95
  168. package/front_end/panels/console/ConsoleSidebar.ts +2 -2
  169. package/front_end/panels/console/ConsoleView.ts +75 -79
  170. package/front_end/panels/console/ConsoleViewMessage.ts +52 -4
  171. package/front_end/panels/console/SymbolizedErrorWidget.ts +8 -4
  172. package/front_end/panels/console/consolePrompt.css +1 -1
  173. package/front_end/panels/console/consoleView.css +1 -1
  174. package/front_end/panels/console_counters/WarningErrorCounter.ts +3 -4
  175. package/front_end/panels/coverage/CoverageListView.ts +2 -2
  176. package/front_end/panels/coverage/CoverageView.ts +20 -5
  177. package/front_end/panels/css_overview/CSSOverviewCompletedView.ts +4 -3
  178. package/front_end/panels/css_overview/CSSOverviewPanel.ts +2 -2
  179. package/front_end/panels/css_overview/CSSOverviewProcessingView.ts +2 -2
  180. package/front_end/panels/css_overview/CSSOverviewSidebarPanel.ts +2 -2
  181. package/front_end/panels/css_overview/CSSOverviewStartView.ts +2 -2
  182. package/front_end/panels/css_overview/CSSOverviewUnusedDeclarations.ts +8 -8
  183. package/front_end/panels/developer_resources/DeveloperResourcesListView.ts +2 -3
  184. package/front_end/panels/developer_resources/DeveloperResourcesView.ts +4 -5
  185. package/front_end/panels/elements/AccessibilityTreeUtils.ts +6 -7
  186. package/front_end/panels/elements/CSSValueTraceView.ts +3 -3
  187. package/front_end/panels/elements/ClassesPaneWidget.ts +1 -2
  188. package/front_end/panels/elements/ComputedStyleWidget.ts +15 -14
  189. package/front_end/panels/elements/DOMTreeElementWidget.ts +5 -4
  190. package/front_end/panels/elements/DOMTreeWidget.ts +2 -1
  191. package/front_end/panels/elements/ElementStatePaneWidget.ts +2 -2
  192. package/front_end/panels/elements/ElementsPanel.ts +1 -0
  193. package/front_end/panels/elements/EventListenersWidget.ts +2 -2
  194. package/front_end/panels/elements/LayoutPane.ts +2 -2
  195. package/front_end/panels/elements/PlatformFontsWidget.ts +3 -3
  196. package/front_end/panels/elements/PropertiesWidget.ts +9 -10
  197. package/front_end/panels/elements/PropertyRenderer.ts +72 -11
  198. package/front_end/panels/elements/StandaloneStylesContainer.ts +5 -10
  199. package/front_end/panels/elements/StyleEditorWidget.ts +30 -16
  200. package/front_end/panels/elements/StylePropertiesSection.ts +93 -44
  201. package/front_end/panels/elements/StylePropertyTreeElement.ts +230 -302
  202. package/front_end/panels/elements/StylesContainer.ts +2 -3
  203. package/front_end/panels/elements/StylesSidebarPane.ts +4 -13
  204. package/front_end/panels/elements/components/AccessibilityTreeNode.ts +66 -37
  205. package/front_end/panels/elements/components/CSSHintDetailsView.ts +51 -41
  206. package/front_end/panels/elements/components/CSSPropertyDocsView.ts +75 -65
  207. package/front_end/panels/elements/components/CSSQuery.ts +112 -74
  208. package/front_end/panels/elements/components/CSSVariableValueView.ts +109 -68
  209. package/front_end/panels/elements/components/ComputedStyleProperty.ts +64 -45
  210. package/front_end/panels/elements/components/ElementsTreeExpandButton.ts +35 -28
  211. package/front_end/panels/elements/components/QueryContainer.ts +104 -74
  212. package/front_end/panels/elements/components/accessibilityTreeNode.css +22 -20
  213. package/front_end/panels/elements/components/computedStyleProperty.css +2 -0
  214. package/front_end/panels/elements/components/cssHintDetailsView.css +23 -21
  215. package/front_end/panels/elements/components/cssPropertyDocsView.css +38 -36
  216. package/front_end/panels/elements/components/cssVariableValueView.css +42 -40
  217. package/front_end/panels/elements/components/elementsTreeExpandButton.css +5 -2
  218. package/front_end/panels/elements/components/queryContainer.css +23 -21
  219. package/front_end/panels/elements/stylesSidebarPane.css +3 -3
  220. package/front_end/panels/emulation/DeviceModeToolbar.ts +2 -2
  221. package/front_end/panels/emulation/InspectedPagePlaceholder.ts +2 -2
  222. package/front_end/panels/emulation/MediaQueryInspector.ts +9 -10
  223. package/front_end/panels/emulation/mediaQueryInspector.css +1 -1
  224. package/front_end/panels/event_listeners/EventListenersView.ts +2 -2
  225. package/front_end/panels/issues/AffectedCookiesView.ts +144 -101
  226. package/front_end/panels/issues/AffectedDescendantsWithinSelectElementView.ts +83 -31
  227. package/front_end/panels/issues/AffectedDirectivesView.ts +218 -135
  228. package/front_end/panels/issues/AffectedDocumentsInQuirksModeView.ts +84 -34
  229. package/front_end/panels/issues/AffectedElementsView.ts +86 -23
  230. package/front_end/panels/issues/AffectedLazyLoadImagesView.ts +2 -2
  231. package/front_end/panels/issues/AffectedMetadataAllowedSitesView.ts +2 -2
  232. package/front_end/panels/issues/AffectedPartitioningBlobURLView.ts +36 -11
  233. package/front_end/panels/issues/AffectedSharedArrayBufferIssueDetailsView.ts +135 -58
  234. package/front_end/panels/issues/AffectedSourcesView.ts +49 -28
  235. package/front_end/panels/issues/AffectedTrackingSitesView.ts +3 -4
  236. package/front_end/panels/issues/CorsIssueDetailsView.ts +490 -269
  237. package/front_end/panels/issues/GenericIssueDetailsView.ts +2 -2
  238. package/front_end/panels/issues/IssueKindView.ts +63 -48
  239. package/front_end/panels/issues/IssueView.ts +14 -18
  240. package/front_end/panels/issues/components/ElementsPanelLink.ts +70 -34
  241. package/front_end/panels/issues/components/HideIssuesMenu.ts +56 -32
  242. package/front_end/panels/issues/components/elementsPanelLink.css +10 -6
  243. package/front_end/panels/issues/components/hideIssuesMenu.css +16 -14
  244. package/front_end/panels/issues/issues.ts +2 -0
  245. package/front_end/panels/issues/issuesTree.css +4 -4
  246. package/front_end/panels/lighthouse/LighthouseController.ts +6 -6
  247. package/front_end/panels/lighthouse/LighthouseStatusView.ts +12 -13
  248. package/front_end/panels/lighthouse/lighthouseStartView.css +1 -1
  249. package/front_end/panels/linear_memory_inspector/LinearMemoryInspectorPane.ts +159 -161
  250. package/front_end/panels/linear_memory_inspector/LinearMemoryInspectorView.ts +228 -0
  251. package/front_end/panels/linear_memory_inspector/components/LinearMemoryInspector.ts +32 -41
  252. package/front_end/panels/linear_memory_inspector/components/linearMemoryHighlightChipList.css +2 -2
  253. package/front_end/panels/linear_memory_inspector/linear_memory_inspector.ts +2 -0
  254. package/front_end/panels/media/EventDisplayTable.ts +2 -2
  255. package/front_end/panels/media/MainView.ts +132 -66
  256. package/front_end/panels/media/PlayerDetailView.ts +32 -14
  257. package/front_end/panels/media/PlayerListView.ts +83 -23
  258. package/front_end/panels/media/PlayerPropertiesView.ts +2 -2
  259. package/front_end/panels/media/TickingFlameChart.ts +153 -63
  260. package/front_end/panels/mobile_throttling/NetworkThrottlingSelector.ts +2 -2
  261. package/front_end/panels/mobile_throttling/ThrottlingSettingsTab.ts +615 -464
  262. package/front_end/panels/mobile_throttling/throttlingSettingsTab.css +43 -0
  263. package/front_end/panels/network/EventSourceMessagesView.ts +3 -3
  264. package/front_end/panels/network/NetworkConfigView.ts +6 -2
  265. package/front_end/panels/network/NetworkDataGridNode.ts +2 -1
  266. package/front_end/panels/network/NetworkItemView.ts +27 -26
  267. package/front_end/panels/network/NetworkManageCustomHeadersView.ts +236 -97
  268. package/front_end/panels/network/NetworkOverview.ts +8 -10
  269. package/front_end/panels/network/RequestConditionsDrawer.ts +8 -4
  270. package/front_end/panels/network/RequestDeviceBoundSessionsView.ts +2 -4
  271. package/front_end/panels/network/RequestHTMLView.ts +26 -7
  272. package/front_end/panels/network/RequestHeadersView.ts +2 -2
  273. package/front_end/panels/network/RequestInitiatorView.ts +21 -22
  274. package/front_end/panels/network/RequestPayloadView.ts +2 -16
  275. package/front_end/panels/network/RequestPreviewView.ts +5 -5
  276. package/front_end/panels/network/RequestTimingView.ts +6 -6
  277. package/front_end/panels/network/ResourceDirectSocketChunkView.ts +5 -6
  278. package/front_end/panels/network/ResourceWebSocketFrameView.ts +4 -3
  279. package/front_end/panels/network/ShowMoreDetailsWidget.ts +11 -12
  280. package/front_end/panels/network/SignedExchangeInfoView.ts +2 -2
  281. package/front_end/panels/network/networkLogView.css +2 -2
  282. package/front_end/panels/network/networkManageCustomHeadersView.css +27 -6
  283. package/front_end/panels/network/requestConditionsDrawer.css +1 -1
  284. package/front_end/panels/network/requestInitiatorView.css +5 -3
  285. package/front_end/panels/performance_monitor/PerformanceMonitor.ts +2 -2
  286. package/front_end/panels/profiler/HeapDetachedElementsView.ts +1 -2
  287. package/front_end/panels/profiler/HeapTimelineOverview.ts +77 -15
  288. package/front_end/panels/profiler/IsolateSelector.ts +258 -187
  289. package/front_end/panels/profiler/ProfileLauncherView.ts +7 -29
  290. package/front_end/panels/profiler/profileLauncherView.css +6 -1
  291. package/front_end/panels/protocol_monitor/JSONEditor.ts +4 -5
  292. package/front_end/panels/recorder/ControlButton.ts +1 -1
  293. package/front_end/panels/recorder/RecordingListView.ts +2 -4
  294. package/front_end/panels/recorder/RecordingView.ts +1 -2
  295. package/front_end/panels/recorder/SelectorPicker.ts +2 -4
  296. package/front_end/panels/recorder/StepView.ts +24 -10
  297. package/front_end/panels/recorder/TimelineSection.ts +1 -1
  298. package/front_end/panels/recorder/recordingView.css +1 -1
  299. package/front_end/panels/screencast/ScreencastApp.ts +1 -1
  300. package/front_end/panels/search/SearchResultsPane.ts +11 -12
  301. package/front_end/panels/search/SearchView.ts +8 -10
  302. package/front_end/panels/security/SecurityPanel.ts +1 -8
  303. package/front_end/panels/security/SecurityPanelSidebar.ts +2 -2
  304. package/front_end/panels/security/mainView.css +1 -1
  305. package/front_end/panels/sensors/LocationsSettingsTab.ts +1 -2
  306. package/front_end/panels/settings/AISettingsTab.ts +1 -1
  307. package/front_end/panels/settings/BackendLinkingSettingsTab.ts +34 -20
  308. package/front_end/panels/settings/EditFileSystemView.ts +2 -2
  309. package/front_end/panels/settings/FrameworkIgnoreListSettingsTab.ts +375 -197
  310. package/front_end/panels/settings/KeybindsSettingsTab.ts +570 -414
  311. package/front_end/panels/settings/SettingsScreen.ts +312 -114
  312. package/front_end/panels/settings/WorkspaceSettingsTab.ts +2 -2
  313. package/front_end/panels/settings/aiSettingsTab.css +1 -4
  314. package/front_end/panels/settings/emulation/DevicesSettingsTab.ts +924 -578
  315. package/front_end/panels/settings/emulation/components/UserAgentClientHintsForm.ts +9 -2
  316. package/front_end/panels/settings/emulation/devicesSettingsTab.css +39 -0
  317. package/front_end/panels/settings/frameworkIgnoreListSettingsTab.css +37 -8
  318. package/front_end/panels/settings/settingsScreen.css +0 -24
  319. package/front_end/panels/sources/BreakpointEditDialog.ts +9 -6
  320. package/front_end/panels/sources/BreakpointsView.ts +25 -4
  321. package/front_end/panels/sources/CallStackSidebarPane.ts +7 -1
  322. package/front_end/panels/sources/DebuggerPlugin.ts +1 -0
  323. package/front_end/panels/sources/GoToLineQuickOpen.ts +8 -8
  324. package/front_end/panels/sources/NavigatorView.ts +521 -439
  325. package/front_end/panels/sources/PersistenceActions.ts +11 -12
  326. package/front_end/panels/sources/ProfilePlugin.ts +28 -17
  327. package/front_end/panels/sources/ScopeChainSidebarPane.ts +3 -4
  328. package/front_end/panels/sources/SourcesNavigator.ts +9 -9
  329. package/front_end/panels/sources/SourcesPanel.ts +2 -2
  330. package/front_end/panels/sources/SourcesView.ts +3 -3
  331. package/front_end/panels/sources/ThreadsSidebarPane.ts +2 -2
  332. package/front_end/panels/sources/WatchExpressionsSidebarPane.ts +2 -2
  333. package/front_end/panels/sources/components/HeadersView.ts +1 -2
  334. package/front_end/panels/timeline/CompatibilityTracksAppender.ts +5 -6
  335. package/front_end/panels/timeline/EventsTimelineTreeView.ts +73 -34
  336. package/front_end/panels/timeline/IsolateSelector.ts +25 -37
  337. package/front_end/panels/timeline/StatusDialog.ts +5 -7
  338. package/front_end/panels/timeline/ThirdPartyTreeView.ts +10 -13
  339. package/front_end/panels/timeline/TimelineDetailsView.ts +40 -21
  340. package/front_end/panels/timeline/TimelineEventOverview.ts +130 -34
  341. package/front_end/panels/timeline/TimelineFlameChartNetworkDataProvider.ts +1 -1
  342. package/front_end/panels/timeline/TimelineMiniMap.ts +255 -103
  343. package/front_end/panels/timeline/TimelinePaintProfilerView.ts +19 -11
  344. package/front_end/panels/timeline/TimelinePanel.ts +1 -0
  345. package/front_end/panels/timeline/TimelineSelectorStatsView.ts +11 -12
  346. package/front_end/panels/timeline/TimelineTreeView.ts +240 -122
  347. package/front_end/panels/timeline/TimelineUIUtils.ts +12 -0
  348. package/front_end/panels/timeline/components/BreadcrumbsUI.ts +5 -4
  349. package/front_end/panels/timeline/components/DetailsView.ts +97 -65
  350. package/front_end/panels/timeline/components/LayoutShiftDetails.ts +2 -2
  351. package/front_end/panels/timeline/components/MetricCard.ts +2 -2
  352. package/front_end/panels/timeline/components/NetworkRequestDetails.ts +11 -12
  353. package/front_end/panels/timeline/components/NetworkTrackWidget.ts +57 -50
  354. package/front_end/panels/timeline/components/RelatedInsightChips.ts +2 -2
  355. package/front_end/panels/timeline/components/Sidebar.ts +161 -109
  356. package/front_end/panels/timeline/components/SidebarAnnotationsTab.ts +33 -12
  357. package/front_end/panels/timeline/components/SidebarInsightsTab.ts +3 -0
  358. package/front_end/panels/timeline/components/insights/LCPDiscovery.ts +11 -11
  359. package/front_end/panels/timeline/components/insights/SlowCSSSelector.ts +6 -7
  360. package/front_end/panels/timeline/components/networkTrackWidget.css +24 -22
  361. package/front_end/panels/timeline/components/sidebarInsightsTab.css +1 -1
  362. package/front_end/panels/timeline/overlays/components/TimespanBreakdownOverlay.ts +15 -10
  363. package/front_end/panels/timeline/overlays/components/entryLabelOverlay.css +1 -1
  364. package/front_end/panels/timeline/timelinePanel.css +5 -0
  365. package/front_end/panels/timeline/timelineStatusDialog.css +1 -1
  366. package/front_end/panels/web_audio/WebAudioView.ts +2 -2
  367. package/front_end/third_party/chromium/README.chromium +1 -1
  368. package/front_end/third_party/legacy-javascript/README.chromium +2 -2
  369. package/front_end/third_party/legacy-javascript/lib/legacy-javascript.js +2 -2
  370. package/front_end/third_party/legacy-javascript/package.json +1 -1
  371. package/front_end/third_party/lighthouse/README.chromium +2 -2
  372. package/front_end/third_party/lighthouse/lighthouse-dt-bundle.js +1983 -2022
  373. package/front_end/third_party/lighthouse/locales/ar-XB.json +157 -142
  374. package/front_end/third_party/lighthouse/locales/ar.json +157 -142
  375. package/front_end/third_party/lighthouse/locales/bg.json +154 -139
  376. package/front_end/third_party/lighthouse/locales/ca.json +157 -142
  377. package/front_end/third_party/lighthouse/locales/cs.json +148 -133
  378. package/front_end/third_party/lighthouse/locales/da.json +153 -138
  379. package/front_end/third_party/lighthouse/locales/de.json +152 -137
  380. package/front_end/third_party/lighthouse/locales/el.json +153 -138
  381. package/front_end/third_party/lighthouse/locales/en-GB.json +160 -145
  382. package/front_end/third_party/lighthouse/locales/en-US.json +239 -218
  383. package/front_end/third_party/lighthouse/locales/en-XL.json +239 -218
  384. package/front_end/third_party/lighthouse/locales/es-419.json +150 -135
  385. package/front_end/third_party/lighthouse/locales/es.json +149 -134
  386. package/front_end/third_party/lighthouse/locales/fi.json +151 -136
  387. package/front_end/third_party/lighthouse/locales/fil.json +154 -139
  388. package/front_end/third_party/lighthouse/locales/fr.json +150 -135
  389. package/front_end/third_party/lighthouse/locales/he.json +160 -145
  390. package/front_end/third_party/lighthouse/locales/hi.json +156 -141
  391. package/front_end/third_party/lighthouse/locales/hr.json +154 -139
  392. package/front_end/third_party/lighthouse/locales/hu.json +111 -96
  393. package/front_end/third_party/lighthouse/locales/id.json +153 -138
  394. package/front_end/third_party/lighthouse/locales/it.json +153 -138
  395. package/front_end/third_party/lighthouse/locales/ja.json +150 -135
  396. package/front_end/third_party/lighthouse/locales/ko.json +42 -27
  397. package/front_end/third_party/lighthouse/locales/lt.json +152 -137
  398. package/front_end/third_party/lighthouse/locales/lv.json +93 -78
  399. package/front_end/third_party/lighthouse/locales/nl.json +149 -134
  400. package/front_end/third_party/lighthouse/locales/no.json +152 -137
  401. package/front_end/third_party/lighthouse/locales/pl.json +153 -138
  402. package/front_end/third_party/lighthouse/locales/pt-PT.json +152 -137
  403. package/front_end/third_party/lighthouse/locales/pt.json +157 -142
  404. package/front_end/third_party/lighthouse/locales/ro.json +149 -134
  405. package/front_end/third_party/lighthouse/locales/ru.json +76 -61
  406. package/front_end/third_party/lighthouse/locales/sk.json +153 -138
  407. package/front_end/third_party/lighthouse/locales/sl.json +149 -134
  408. package/front_end/third_party/lighthouse/locales/sr-Latn.json +151 -136
  409. package/front_end/third_party/lighthouse/locales/sr.json +151 -136
  410. package/front_end/third_party/lighthouse/locales/sv.json +152 -137
  411. package/front_end/third_party/lighthouse/locales/ta.json +156 -141
  412. package/front_end/third_party/lighthouse/locales/te.json +157 -142
  413. package/front_end/third_party/lighthouse/locales/th.json +111 -96
  414. package/front_end/third_party/lighthouse/locales/tr.json +153 -138
  415. package/front_end/third_party/lighthouse/locales/uk.json +149 -134
  416. package/front_end/third_party/lighthouse/locales/vi.json +162 -147
  417. package/front_end/third_party/lighthouse/locales/zh-HK.json +150 -135
  418. package/front_end/third_party/lighthouse/locales/zh-TW.json +154 -139
  419. package/front_end/third_party/lighthouse/locales/zh.json +152 -137
  420. package/front_end/third_party/lighthouse/report/bundle.d.ts +9 -8
  421. package/front_end/third_party/lighthouse/report/bundle.js +10 -10
  422. package/front_end/third_party/lighthouse/report-assets/report-generator.mjs +2 -7
  423. package/front_end/tsconfig.compatibility.json +1 -0
  424. package/front_end/tsconfig.json +3 -2
  425. package/front_end/ui/components/dialogs/TypeToAllowDialog.ts +0 -2
  426. package/front_end/ui/components/dialogs/typeToAllowDialog.css +0 -4
  427. package/front_end/ui/components/icon_button/fileSourceIcon.css +1 -1
  428. package/front_end/ui/components/input/textInput.css +1 -1
  429. package/front_end/ui/components/lists/List.ts +26 -14
  430. package/front_end/ui/components/menus/menus.ts +0 -2
  431. package/front_end/ui/components/suggestion_input/SuggestionInput.ts +351 -138
  432. package/front_end/ui/components/survey_link/surveyLink.css +3 -3
  433. package/front_end/ui/components/switch/switch.css +6 -6
  434. package/front_end/ui/components/text_editor/AiCodeCompletionTeaser.ts +2 -3
  435. package/front_end/ui/components/text_editor/TextEditor.ts +1 -1
  436. package/front_end/ui/components/tooltips/Tooltip.ts +53 -4
  437. package/front_end/ui/components/tree_outline/treeOutline.css +7 -7
  438. package/front_end/ui/helpers/OpenInNewTab.ts +8 -3
  439. package/front_end/ui/legacy/EmptyWidget.ts +4 -4
  440. package/front_end/ui/legacy/ForwardedInputEventHandler.ts +2 -2
  441. package/front_end/ui/legacy/GlassPane.ts +1 -1
  442. package/front_end/ui/legacy/KeyboardShortcut.ts +7 -7
  443. package/front_end/ui/legacy/RemoteDebuggingTerminatedScreen.ts +2 -2
  444. package/front_end/ui/legacy/TabbedPane.ts +198 -66
  445. package/front_end/ui/legacy/TargetCrashedScreen.ts +2 -2
  446. package/front_end/ui/legacy/UIUtils.ts +71 -68
  447. package/front_end/ui/legacy/View.ts +7 -4
  448. package/front_end/ui/legacy/ViewManager.ts +49 -37
  449. package/front_end/ui/legacy/Widget.ts +32 -12
  450. package/front_end/ui/legacy/components/cookie_table/CookiesTable.ts +2 -3
  451. package/front_end/ui/legacy/components/inline_editor/AnimationTimingUI.ts +8 -8
  452. package/front_end/ui/legacy/components/inline_editor/BezierUI.ts +8 -9
  453. package/front_end/ui/legacy/components/inline_editor/LinkSwatch.ts +2 -2
  454. package/front_end/ui/legacy/components/inline_editor/cssAngleEditor.css +1 -1
  455. package/front_end/ui/legacy/components/inline_editor/cssAngleSwatch.css +1 -1
  456. package/front_end/ui/legacy/components/object_ui/ObjectPropertiesSection.ts +45 -11
  457. package/front_end/ui/legacy/components/object_ui/RemoteObjectPreviewFormatter.ts +10 -12
  458. package/front_end/ui/legacy/components/perf_ui/ChartViewport.ts +102 -29
  459. package/front_end/ui/legacy/components/perf_ui/FlameChart.ts +148 -122
  460. package/front_end/ui/legacy/components/perf_ui/TimelineOverviewPane.ts +20 -14
  461. package/front_end/ui/legacy/components/quick_open/filteredListWidget.css +1 -1
  462. package/front_end/ui/legacy/components/source_frame/FontView.ts +29 -5
  463. package/front_end/ui/legacy/components/source_frame/ImageView.ts +79 -12
  464. package/front_end/ui/legacy/components/source_frame/JSONView.ts +20 -2
  465. package/front_end/ui/legacy/components/source_frame/PreviewFactory.ts +2 -2
  466. package/front_end/ui/legacy/components/source_frame/StreamingContentHexView.ts +6 -10
  467. package/front_end/ui/legacy/components/source_frame/XMLView.ts +11 -11
  468. package/front_end/ui/legacy/components/source_frame/fontView.css +7 -0
  469. package/front_end/ui/legacy/components/source_frame/imageView.css +7 -0
  470. package/front_end/ui/legacy/components/utils/JSPresentationUtils.ts +14 -3
  471. package/front_end/ui/legacy/components/utils/Linkifier.ts +126 -2
  472. package/front_end/ui/legacy/emptyWidget.css +2 -1
  473. package/front_end/ui/legacy/inspectorCommon.css +3 -3
  474. package/front_end/ui/legacy/smallBubble.css +1 -1
  475. package/front_end/ui/legacy/tabbedPane.css +6 -0
  476. package/front_end/ui/lit/Directives.ts +35 -18
  477. package/front_end/ui/lit/lit.ts +0 -2
  478. package/front_end/ui/lit/render.ts +0 -7
  479. package/front_end/ui/visual_logging/KnownContextValues.ts +5 -0
  480. package/package.json +1 -1
  481. package/vpython.toml +8 -0
  482. package/vpython.toml.uv.lock +3 -0
  483. package/.agents/skills/review-models-core/SKILL.md +0 -73
  484. package/.agents/skills/review-tests/SKILL.md +0 -67
  485. package/.agents/skills/review-ui-widgets/SKILL.md +0 -115
  486. package/front_end/generated/ARIAProperties.ts +0 -2686
  487. package/front_end/ui/components/menus/README.md +0 -119
  488. package/front_end/ui/components/menus/SelectMenu.ts +0 -473
  489. package/front_end/ui/components/menus/selectMenu.css +0 -54
  490. package/front_end/ui/components/menus/selectMenuButton.css +0 -108
@@ -1,7 +1,6 @@
1
1
  // Copyright 2021 The Chromium Authors
2
2
  // Use of this source code is governed by a BSD-style license that can be
3
3
  // found in the LICENSE file.
4
- /* eslint-disable @devtools/no-lit-render-outside-of-view */
5
4
 
6
5
  import '../../../ui/components/tooltips/tooltips.js';
7
6
  import '../../../ui/legacy/components/inline_editor/inline_editor.js';
@@ -13,9 +12,10 @@ import * as Lit from '../../../ui/lit/lit.js';
13
12
  import * as VisualLogging from '../../../ui/visual_logging/visual_logging.js';
14
13
 
15
14
  import cssQueryStyles from './cssQuery.css.js';
16
- import type {CSSVariableValueView} from './CSSVariableValueView.js';
15
+ import {CSSVariableValueView, type RegisteredPropertyDetails} from './CSSVariableValueView.js';
17
16
 
18
17
  const {render, html} = Lit;
18
+ const {widget} = UI.Widget;
19
19
 
20
20
  export interface CSSQueryData {
21
21
  queryPrefix: string;
@@ -23,38 +23,125 @@ export interface CSSQueryData {
23
23
  queryText: string;
24
24
  onQueryTextClick?: (event: Event) => void;
25
25
  onLinkActivate?: (resolvedVariable: string|SDK.CSSMatchedStyles.CSSValueSource) => void;
26
- getPopoverContents?: (variableName: string, variableValue: string|null) => CSSVariableValueView;
26
+ getRegisteredPropertyDetails?: (variableName: string) => RegisteredPropertyDetails | undefined;
27
27
  jslogContext: string;
28
28
  }
29
29
 
30
- interface TextSection {
30
+ export interface TextSection {
31
31
  text: string;
32
32
  isVariable: boolean;
33
33
  }
34
34
 
35
- export class CSSQuery extends HTMLElement {
36
- readonly #shadow = this.attachShadow({mode: 'open'});
35
+ export interface ViewInput {
36
+ queryPrefix: string;
37
+ queryName?: string;
38
+ queryText: TextSection[];
39
+ onQueryTextClick?: (event: Event) => void;
40
+ onLinkActivate?: (resolvedVariable: string|SDK.CSSMatchedStyles.CSSValueSource) => void;
41
+ getRegisteredPropertyDetails?: (variableName: string) => RegisteredPropertyDetails | undefined;
42
+ jslogContext?: string;
43
+ matchedStyles?: SDK.CSSMatchedStyles.CSSMatchedStyles;
44
+ style?: SDK.CSSStyleDeclaration.CSSStyleDeclaration;
45
+ containerNode?: SDK.DOMModel.DOMNode;
46
+ tooltipPrefix: string;
47
+ }
48
+
49
+ export type View = (input: ViewInput, output: undefined, target: HTMLElement|DocumentFragment) => void;
50
+
51
+ export const DEFAULT_VIEW: View = (input, _output, target) => {
52
+ const queryClasses = Lit.Directives.classMap({
53
+ query: true,
54
+ editable: Boolean(input.onQueryTextClick),
55
+ });
56
+
57
+ // clang-format off
58
+ const queryText = html`
59
+ <span class="query-text" @click=${input.onQueryTextClick}>${
60
+ input.queryText.map((section, index) => {
61
+ if (section.isVariable && input.matchedStyles && input.style && input.onLinkActivate) {
62
+ const variableName = section.text;
63
+ const variable = input.matchedStyles.computeCSSVariable(input.style, variableName, input.containerNode);
64
+ const isDefined = variable !== null && variable.value !== undefined;
65
+ const onLinkActivate = (): void => {
66
+ if (input.onLinkActivate) {
67
+ input.onLinkActivate(variable ? variable.declaration : variableName);
68
+ }
69
+ };
70
+ const tooltipId = `${input.tooltipPrefix || 'css-query'}-${index}-${variableName}`;
71
+ const tooltip = {tooltipId};
72
+ return html`
73
+ <devtools-link-swatch class="css-var-link" .data=${{
74
+ tooltip,
75
+ text: variableName,
76
+ isDefined,
77
+ onLinkActivate,
78
+ } as InlineEditor.LinkSwatch.LinkSwatchRenderData}>
79
+ </devtools-link-swatch>
80
+ <devtools-tooltip
81
+ id=${tooltipId}
82
+ variant="rich"
83
+ jslogContext="elements.css-var"
84
+ >
85
+ ${widget(CSSVariableValueView, {
86
+ variableName,
87
+ value: variable?.value,
88
+ details: input.getRegisteredPropertyDetails?.(variableName),
89
+ })}
90
+ </devtools-tooltip>
91
+ `;
92
+ }
93
+ return html`${section.text}`;
94
+ })
95
+ }</span>
96
+ `;
97
+
98
+ render(html`
99
+ <style>${cssQueryStyles}</style>
100
+ <style>${UI.inspectorCommonStyles}</style>
101
+ <div class=${queryClasses} jslog=${
102
+ VisualLogging.cssRuleHeader(input.jslogContext).track({click:true, change: true})}>
103
+ <slot name="indent"></slot>
104
+ ${input.queryPrefix ? html`<span>${input.queryPrefix + ' '}</span>` : Lit.nothing}
105
+ ${input.queryName ? html`<span>${input.queryName + ' '}</span>` : Lit.nothing}
106
+ ${queryText}<slot></slot> <span class="sidebar-pane-open-brace">{</span>
107
+ </div>`,
108
+ target, {container: {classes: ['css-query']}});
109
+ // clang-format on
110
+ };
111
+
112
+ export class CSSQuery extends UI.Widget.Widget<ShadowRoot> {
113
+ #view: View;
37
114
  #queryPrefix = '';
38
115
  #queryName?: string;
39
116
  #queryText: TextSection[] = [];
40
117
  #onQueryTextClick?: (event: Event) => void;
41
118
  #onLinkActivate?: (resolvedVariable: string|SDK.CSSMatchedStyles.CSSValueSource) => void;
42
- #getPopoverContents?: (variableName: string, variableValue: string|null) => CSSVariableValueView;
119
+ #getRegisteredPropertyDetails?: (variableName: string) => RegisteredPropertyDetails | undefined;
43
120
  #jslogContext?: string;
44
121
  #matchedStyles?: SDK.CSSMatchedStyles.CSSMatchedStyles;
45
122
  #style?: SDK.CSSStyleDeclaration.CSSStyleDeclaration;
46
123
  #containerNode?: SDK.DOMModel.DOMNode;
47
124
  #tooltipPrefix = '';
48
125
 
126
+ constructor(element?: HTMLElement, view: View = DEFAULT_VIEW) {
127
+ super(element, {useShadowDom: 'pure'});
128
+ this.#view = view;
129
+ }
130
+
49
131
  set data(data: CSSQueryData) {
50
132
  this.#queryPrefix = data.queryPrefix;
51
133
  this.#queryName = data.queryName;
52
134
  this.#queryText = [{text: data.queryText, isVariable: false}];
53
135
  this.#onQueryTextClick = data.onQueryTextClick;
54
136
  this.#onLinkActivate = data.onLinkActivate;
55
- this.#getPopoverContents = data.getPopoverContents;
137
+ this.#getRegisteredPropertyDetails = data.getRegisteredPropertyDetails;
56
138
  this.#jslogContext = data.jslogContext;
57
- this.#render();
139
+ this.performUpdate();
140
+ }
141
+
142
+ override wasShown(): void {
143
+ super.wasShown();
144
+ this.performUpdate();
58
145
  }
59
146
 
60
147
  parseStyleQueries(
@@ -116,72 +203,23 @@ export class CSSQuery extends HTMLElement {
116
203
  }
117
204
 
118
205
  this.#queryText = sections;
119
- this.#render();
120
- }
121
-
122
- #render(): void {
123
- const queryClasses = Lit.Directives.classMap({
124
- query: true,
125
- editable: Boolean(this.#onQueryTextClick),
126
- });
127
-
128
- // clang-format off
129
- const queryText = html`
130
- <span class="query-text" @click=${this.#onQueryTextClick}>${
131
- this.#queryText.map((section, index) => {
132
- if (section.isVariable && this.#matchedStyles && this.#style && this.#onLinkActivate) {
133
- const variableName = section.text;
134
- const variable = this.#matchedStyles.computeCSSVariable(this.#style, variableName, this.#containerNode);
135
- const isDefined = variable !== null && variable.value !== undefined;
136
- const onLinkActivate = (): void => {
137
- if (this.#onLinkActivate) {
138
- this.#onLinkActivate(variable ? variable.declaration : variableName);
139
- }
140
- };
141
- const tooltipContents = this.#getPopoverContents?.(variableName, variable?.value ?? null) ?? null;
142
- const tooltipId = `${this.#tooltipPrefix}-${index}-${variableName}`;
143
- const tooltip = {tooltipId};
144
- return html`
145
- <devtools-link-swatch class="css-var-link" .data=${{
146
- tooltip,
147
- text: variableName,
148
- isDefined,
149
- onLinkActivate,
150
- } as InlineEditor.LinkSwatch.LinkSwatchRenderData}>
151
- </devtools-link-swatch>
152
- <devtools-tooltip
153
- id=${tooltipId}
154
- variant="rich"
155
- jslogContext="elements.css-var"
156
- >
157
- ${tooltipContents}
158
- </devtools-tooltip>
159
- `;
160
- }
161
- return html`${section.text}`;
162
- })
163
- }</span>
164
- `;
165
-
166
- render(html`
167
- <style>${cssQueryStyles}</style>
168
- <style>${UI.inspectorCommonStyles}</style>
169
- <div class=${queryClasses} jslog=${
170
- VisualLogging.cssRuleHeader(this.#jslogContext).track({click:true, change: true})}>
171
- <slot name="indent"></slot>
172
- ${this.#queryPrefix ? html`<span>${this.#queryPrefix + ' '}</span>` : Lit.nothing}
173
- ${this.#queryName ? html`<span>${this.#queryName + ' '}</span>` : Lit.nothing}
174
- ${queryText}<slot></slot> <span class="sidebar-pane-open-brace">{</span>
175
- </div>`,
176
- this.#shadow, {host: this});
177
- // clang-format on
206
+ this.performUpdate();
178
207
  }
179
- }
180
-
181
- customElements.define('devtools-css-query', CSSQuery);
182
208
 
183
- declare global {
184
- interface HTMLElementTagNameMap {
185
- 'devtools-css-query': CSSQuery;
209
+ override performUpdate(): void {
210
+ this.#view({
211
+ queryPrefix: this.#queryPrefix,
212
+ queryName: this.#queryName,
213
+ queryText: this.#queryText,
214
+ onQueryTextClick: this.#onQueryTextClick,
215
+ onLinkActivate: this.#onLinkActivate,
216
+ getRegisteredPropertyDetails: this.#getRegisteredPropertyDetails,
217
+ jslogContext: this.#jslogContext,
218
+ matchedStyles: this.#matchedStyles,
219
+ style: this.#style,
220
+ containerNode: this.#containerNode,
221
+ tooltipPrefix: this.#tooltipPrefix,
222
+ },
223
+ undefined, this.contentElement);
186
224
  }
187
225
  }
@@ -1,10 +1,10 @@
1
1
  // Copyright 2023 The Chromium Authors
2
2
  // Use of this source code is governed by a BSD-style license that can be
3
3
  // found in the LICENSE file.
4
- /* eslint-disable @devtools/no-lit-render-outside-of-view */
5
4
 
6
5
  import * as i18n from '../../../core/i18n/i18n.js';
7
6
  import type * as SDK from '../../../core/sdk/sdk.js';
7
+ import * as UI from '../../../ui/legacy/legacy.js';
8
8
  import * as Lit from '../../../ui/lit/lit.js';
9
9
 
10
10
  import cssVariableValueViewStyles from './cssVariableValueView.css.js';
@@ -46,48 +46,97 @@ function getLinkSection(details: RegisteredPropertyDetails): Lit.TemplateResult
46
46
  </div>`;
47
47
  }
48
48
 
49
- export class CSSVariableParserError extends HTMLElement {
50
- readonly #shadow = this.attachShadow({mode: 'open'});
49
+ export interface ParserErrorViewInput {
50
+ details: RegisteredPropertyDetails;
51
+ }
52
+
53
+ export type ParserErrorView = (input: ParserErrorViewInput, output: undefined, target: HTMLElement) => void;
54
+
55
+ export const DEFAULT_PARSER_ERROR_VIEW: ParserErrorView = (input, _output, target) => {
56
+ const type = html`<span class="monospace css-property">${input.details.registration.syntax()}</span>`;
57
+ render(html`
58
+ <style>${cssVariableValueViewStyles}</style>
59
+ <div class="variable-value-popup-wrapper">
60
+ ${i18nTemplate(UIStrings.invalidPropertyValue, {type})}
61
+ ${getLinkSection(input.details)}
62
+ </div>`,
63
+ target, {container: {classes: ['css-variable-parser-error']}});
64
+ };
51
65
 
52
- constructor(details: RegisteredPropertyDetails) {
66
+ export class CSSVariableParserError extends UI.Widget.Widget {
67
+ #view: ParserErrorView;
68
+ readonly #details: RegisteredPropertyDetails;
69
+
70
+ constructor(details: RegisteredPropertyDetails, view: ParserErrorView = DEFAULT_PARSER_ERROR_VIEW) {
53
71
  super();
54
- this.#render(details);
72
+ this.#view = view;
73
+ this.#details = details;
74
+ this.performUpdate();
55
75
  }
56
76
 
57
- #render(details: RegisteredPropertyDetails): void {
58
- const type = html`<span class="monospace css-property">${details.registration.syntax()}</span>`;
59
- render(
60
- html`
61
- <style>${cssVariableValueViewStyles}</style>
62
- <div class="variable-value-popup-wrapper">
63
- ${i18nTemplate(UIStrings.invalidPropertyValue, {type})}
64
- ${getLinkSection(details)}
65
- </div>`,
66
- this.#shadow, {
67
- host: this,
68
- });
77
+ override wasShown(): void {
78
+ super.wasShown();
79
+ this.performUpdate();
69
80
  }
81
+
82
+ override performUpdate(): void {
83
+ this.#view({details: this.#details}, undefined, this.contentElement);
84
+ }
85
+ }
86
+
87
+ export interface ViewInput {
88
+ variableName: string;
89
+ value?: string;
90
+ details?: RegisteredPropertyDetails;
70
91
  }
71
92
 
72
- export class CSSVariableValueView extends HTMLElement {
73
- readonly #shadow = this.attachShadow({mode: 'open'});
74
- readonly variableName: string;
93
+ export type View = (input: ViewInput, output: undefined, target: HTMLElement) => void;
94
+
95
+ export const DEFAULT_VIEW: View = (input, _output, target) => {
96
+ const initialValue = input.details?.registration.initialValue();
97
+ const registrationView = input.details ? html`
98
+ <hr class=divider />
99
+ <div class=registered-property-popup-wrapper>
100
+ <div class="monospace">
101
+ <div><span class="css-property">syntax:</span> ${input.details.registration.syntax()}</div>
102
+ <div><span class="css-property">inherits:</span> ${input.details.registration.inherits()}</div>
103
+ ${initialValue ? html`<div><span class="css-property">initial-value:</span> ${initialValue}</div>` : ''}
104
+ </div>
105
+ ${getLinkSection(input.details)}
106
+ </div>` :
107
+ '';
108
+
109
+ const valueText = input.value ?? i18nString(UIStrings.sIsNotDefined, {PH1: input.variableName});
110
+ render(html`<style>${cssVariableValueViewStyles}</style>
111
+ <div class="variable-value-popup-wrapper">
112
+ ${valueText}
113
+ </div>
114
+ ${registrationView}
115
+ `,
116
+ target, {container: {classes: ['css-variable-value-view']}});
117
+ };
118
+
119
+ export class CSSVariableValueView extends UI.Widget.Widget {
120
+ #view: View;
121
+ #variableName = '';
75
122
  #value: string|undefined;
76
- readonly details: RegisteredPropertyDetails|undefined;
77
-
78
- constructor({
79
- variableName,
80
- value,
81
- details,
82
- }: {
83
- variableName: string,
84
- value: string|undefined,
85
- details?: RegisteredPropertyDetails,
86
- }) {
87
- super();
88
- this.variableName = variableName;
89
- this.details = details;
90
- this.value = value;
123
+ #details: RegisteredPropertyDetails|undefined;
124
+
125
+ constructor(element?: HTMLElement, view: View = DEFAULT_VIEW) {
126
+ super(element);
127
+ this.#view = view;
128
+ }
129
+
130
+ get variableName(): string {
131
+ return this.#variableName;
132
+ }
133
+
134
+ set variableName(variableName: string) {
135
+ if (this.#variableName === variableName) {
136
+ return;
137
+ }
138
+ this.#variableName = variableName;
139
+ this.requestUpdate();
91
140
  }
92
141
 
93
142
  get value(): string|undefined {
@@ -95,44 +144,36 @@ export class CSSVariableValueView extends HTMLElement {
95
144
  }
96
145
 
97
146
  set value(value: string|undefined) {
147
+ if (this.#value === value) {
148
+ return;
149
+ }
98
150
  this.#value = value;
99
- this.#render();
151
+ this.requestUpdate();
100
152
  }
101
153
 
102
- #render(): void {
103
- const initialValue = this.details?.registration.initialValue();
104
- const registrationView = this.details ? html`
105
- <hr class=divider />
106
- <div class=registered-property-popup-wrapper>
107
- <div class="monospace">
108
- <div><span class="css-property">syntax:</span> ${this.details.registration.syntax()}</div>
109
- <div><span class="css-property">inherits:</span> ${this.details.registration.inherits()}</div>
110
- ${initialValue ? html`<div><span class="css-property">initial-value:</span> ${initialValue}</div>` : ''}
111
- </div>
112
- ${getLinkSection(this.details)}
113
- </div>` :
114
- '';
115
-
116
- const valueText = this.value ?? i18nString(UIStrings.sIsNotDefined, {PH1: this.variableName});
117
- render(
118
- html`<style>${cssVariableValueViewStyles}</style>
119
- <div class="variable-value-popup-wrapper">
120
- ${valueText}
121
- </div>
122
- ${registrationView}
123
- `,
124
- this.#shadow, {
125
- host: this,
126
- });
154
+ get details(): RegisteredPropertyDetails|undefined {
155
+ return this.#details;
156
+ }
157
+
158
+ set details(details: RegisteredPropertyDetails|undefined) {
159
+ if (this.#details === details) {
160
+ return;
161
+ }
162
+ this.#details = details;
163
+ this.requestUpdate();
127
164
  }
128
- }
129
165
 
130
- customElements.define('devtools-css-variable-value-view', CSSVariableValueView);
131
- customElements.define('devtools-css-variable-parser-error', CSSVariableParserError);
166
+ override wasShown(): void {
167
+ super.wasShown();
168
+ this.performUpdate();
169
+ }
132
170
 
133
- declare global {
134
- interface HTMLElementTagNameMap {
135
- 'devtools-css-variable-value-view': CSSVariableValueView;
136
- 'devtools-css-variable-parser-error': CSSVariableParserError;
171
+ override performUpdate(): void {
172
+ this.#view({
173
+ variableName: this.#variableName,
174
+ value: this.#value,
175
+ details: this.#details,
176
+ },
177
+ undefined, this.contentElement);
137
178
  }
138
179
  }
@@ -1,27 +1,62 @@
1
1
  // Copyright 2020 The Chromium Authors
2
2
  // Use of this source code is governed by a BSD-style license that can be
3
3
  // found in the LICENSE file.
4
- /* eslint-disable @devtools/no-lit-render-outside-of-view */
5
4
 
6
- import {html, render} from '../../../ui/lit/lit.js';
5
+ import * as UI from '../../../ui/legacy/legacy.js';
6
+ import {Directives, html, nothing, render} from '../../../ui/lit/lit.js';
7
7
  import * as VisualLogging from '../../../ui/visual_logging/visual_logging.js';
8
8
 
9
9
  import computedStylePropertyStyles from './computedStyleProperty.css.js';
10
10
 
11
- export class NavigateToSourceEvent extends Event {
12
- static readonly eventName = 'onnavigatetosource';
13
- constructor() {
14
- super(NavigateToSourceEvent.eventName, {bubbles: true, composed: true});
15
- }
11
+ const {classMap} = Directives;
12
+
13
+ export interface ViewInput {
14
+ inherited: boolean;
15
+ traceable: boolean;
16
+ onNavigateToSource: () => void;
16
17
  }
17
18
 
18
- export class ComputedStyleProperty extends HTMLElement {
19
- readonly #shadow = this.attachShadow({mode: 'open'});
19
+ export type View = (input: ViewInput, output: undefined, target: HTMLElement|DocumentFragment) => void;
20
+
21
+ export const DEFAULT_VIEW: View = (input, _output, target) => {
22
+ // Disabled until https://crbug.com/1079231 is fixed.
23
+ // clang-format off
24
+ render(html`
25
+ <style>${computedStylePropertyStyles}</style>
26
+ <div class=${classMap({'computed-style-property': true, inherited: input.inherited})}>
27
+ <div class="property-name">
28
+ <slot name="name"></slot>
29
+ </div>
30
+ <span class="hidden" aria-hidden="false">: </span>
31
+ ${input.traceable ?
32
+ html`<button class="goto" @click=${(event: Event) => {
33
+ event.consume(true);
34
+ input.onNavigateToSource();
35
+ }} jslog=${VisualLogging.action('elements.jump-to-style').track({click:true})}></button>` :
36
+ nothing}
37
+ <div class="property-value">
38
+ <slot name="value"></slot>
39
+ </div>
40
+ <span class="hidden" aria-hidden="false">;</span>
41
+ </div>
42
+ `, target, {container: {classes: ['computed-style-property']}});
43
+ // clang-format on
44
+ };
45
+
46
+ export class ComputedStyleProperty extends UI.Widget.Widget<ShadowRoot> {
20
47
  #inherited = false;
21
48
  #traceable = false;
49
+ #onNavigateToSource: () => void = () => {};
50
+ readonly #view: View;
51
+
52
+ constructor(element?: HTMLElement, view: View = DEFAULT_VIEW) {
53
+ super(element, {useShadowDom: 'pure'});
54
+ this.#view = view;
55
+ }
22
56
 
23
- connectedCallback(): void {
24
- this.#render();
57
+ override wasShown(): void {
58
+ super.wasShown();
59
+ this.requestUpdate();
25
60
  }
26
61
 
27
62
  set inherited(inherited: boolean) {
@@ -29,7 +64,7 @@ export class ComputedStyleProperty extends HTMLElement {
29
64
  return;
30
65
  }
31
66
  this.#inherited = inherited;
32
- this.#render();
67
+ this.requestUpdate();
33
68
  }
34
69
 
35
70
  set traceable(traceable: boolean) {
@@ -37,42 +72,26 @@ export class ComputedStyleProperty extends HTMLElement {
37
72
  return;
38
73
  }
39
74
  this.#traceable = traceable;
40
- this.#render();
75
+ this.requestUpdate();
41
76
  }
42
77
 
43
- #onNavigateToSourceClick(): void {
44
- this.dispatchEvent(new NavigateToSourceEvent());
45
- }
46
-
47
- #render(): void {
48
- // Disabled until https://crbug.com/1079231 is fixed.
49
- // clang-format off
50
- render(html`
51
- <style>${computedStylePropertyStyles}</style>
52
- <div class="computed-style-property ${this.#inherited ? 'inherited' : ''}">
53
- <div class="property-name">
54
- <slot name="name"></slot>
55
- </div>
56
- <span class="hidden" aria-hidden="false">: </span>
57
- ${this.#traceable ?
58
- html`<span class="goto" @click=${this.#onNavigateToSourceClick} jslog=${VisualLogging.action('elements.jump-to-style').track({click:true})}></span>` :
59
- null}
60
- <div class="property-value">
61
- <slot name="value"></slot>
62
- </div>
63
- <span class="hidden" aria-hidden="false">;</span>
64
- </div>
65
- `, this.#shadow, {
66
- host: this,
67
- });
68
- // clang-format on
78
+ set onNavigateToSource(onNavigateToSource: () => void) {
79
+ if (onNavigateToSource === this.#onNavigateToSource) {
80
+ return;
81
+ }
82
+ this.#onNavigateToSource = onNavigateToSource;
83
+ this.requestUpdate();
69
84
  }
70
- }
71
-
72
- customElements.define('devtools-computed-style-property', ComputedStyleProperty);
73
85
 
74
- declare global {
75
- interface HTMLElementTagNameMap {
76
- 'devtools-computed-style-property': ComputedStyleProperty;
86
+ override performUpdate(): void {
87
+ this.#view(
88
+ {
89
+ inherited: this.#inherited,
90
+ traceable: this.#traceable,
91
+ onNavigateToSource: this.#onNavigateToSource,
92
+ },
93
+ undefined,
94
+ this.contentElement,
95
+ );
77
96
  }
78
97
  }