chrome-devtools-frontend 1.0.1726686 → 1.0.1730971
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/.agents/rules/tests/test-strict-assertions-and-literal-expectations.md +1 -1
- package/.agents/rules/tests/test-view-and-presenter-isolation.md +1 -1
- package/.agents/rules/ui-and-widgets/ui-accessibility-and-semantic-html.md +1 -1
- package/.agents/rules/ui-and-widgets/ui-css-scoping-and-flex-layout.md +2 -2
- package/.agents/rules/ui-and-widgets/ui-declarative-child-widget-composition.md +5 -5
- package/.agents/rules/ui-and-widgets/ui-lit-declarative-templates-and-directives.md +2 -2
- package/.agents/rules/ui-and-widgets/ui-localization-and-uistrings-hygiene.md +2 -2
- package/.agents/rules/ui-and-widgets/ui-modern-component-and-encapsulation-standards.md +3 -3
- package/.agents/rules/ui-and-widgets/ui-pure-view-and-presenter-separation.md +2 -2
- package/.agents/rules/ui-and-widgets/ui-reactive-widget-update-lifecycle.md +2 -2
- package/.agents/rules/ui-and-widgets/ui-view-output-and-callback-contracts.md +2 -2
- package/.agents/rules/ui-and-widgets/ui-widget-dom-and-listener-lifecycle.md +2 -2
- package/.agents/skills/code-review/SKILL.md +63 -12
- package/.agents/skills/ui-eng-vision-local-lit-renderer/SKILL.md +38 -10
- package/.agents/skills/ui-eng-vision-widget-promoter/SKILL.md +1 -0
- package/.agents/skills/ui-widgets/SKILL.md +8 -2
- package/.agents/skills/write-ai-eval-test/SKILL.md +106 -0
- package/AUTHORS +2 -0
- package/DIR_METADATA +1 -2
- package/README.md +48 -26
- package/config/typescript/tsconfig.base.json +1 -0
- package/config/typescript/tsconfig.eslint.json +1 -0
- package/docs/contributing/changes.md +25 -0
- package/docs/ui_engineering.md +13 -4
- package/eslint.config.mjs +323 -41
- package/front_end/core/common/Color.ts +7 -7
- package/front_end/core/common/ParsedURL.ts +3 -3
- package/front_end/core/common/ResolverBase.ts +3 -3
- package/front_end/core/common/SegmentedRange.ts +3 -3
- package/front_end/core/common/SimpleHistoryManager.ts +14 -14
- package/front_end/core/common/Trie.ts +3 -3
- package/front_end/core/common/VersionController.ts +7 -7
- package/front_end/core/host/InspectorFrontendHost.ts +2 -2
- package/front_end/core/host/InspectorFrontendHostAPI.ts +9 -1
- package/front_end/core/host/InspectorFrontendHostStub.ts +1 -1
- package/front_end/core/host/UserMetrics.ts +4 -0
- package/front_end/core/host/UserMetricsEnums.ts +2 -1
- package/front_end/core/platform/StringUtilities.ts +54 -13
- package/front_end/core/platform/node/HostRuntime.ts +13 -7
- package/front_end/core/protocol_client/DevToolsCDPConnection.ts +4 -5
- package/front_end/core/root/Runtime.ts +5 -0
- package/front_end/core/sdk/AccessibilityModel.ts +5 -5
- package/front_end/core/sdk/AnimationModel.ts +17 -19
- package/front_end/core/sdk/CPUProfilerModel.ts +3 -3
- package/front_end/core/sdk/CPUThrottlingManager.ts +7 -0
- package/front_end/core/sdk/CSSMatchedStyles.ts +73 -13
- package/front_end/core/sdk/CSSMetadata.ts +7 -7
- package/front_end/core/sdk/CSSModel.ts +33 -33
- package/front_end/core/sdk/CSSProperty.ts +5 -5
- package/front_end/core/sdk/CSSRule.ts +6 -6
- package/front_end/core/sdk/CSSStyleSheetHeader.ts +4 -4
- package/front_end/core/sdk/Connections.ts +16 -16
- package/front_end/core/sdk/ConsoleModel.ts +44 -47
- package/front_end/core/sdk/CookieParser.ts +11 -11
- package/front_end/core/sdk/EmulationModel.ts +35 -36
- package/front_end/core/sdk/EventBreakpointsModel.ts +11 -11
- package/front_end/core/sdk/FrameManager.ts +16 -16
- package/front_end/core/sdk/IsolateManager.ts +2 -2
- package/front_end/core/sdk/IssuesModel.ts +2 -2
- package/front_end/core/sdk/OverlayModel.ts +19 -19
- package/front_end/core/sdk/PageResourceLoader.ts +14 -16
- package/front_end/core/sdk/RemoteObject.ts +9 -9
- package/front_end/core/sdk/Resource.ts +2 -2
- package/front_end/core/sdk/RuntimeModel.ts +7 -7
- package/front_end/core/sdk/Script.ts +6 -6
- package/front_end/core/sdk/ServiceWorkerManager.ts +36 -10
- package/front_end/core/sdk/SourceMap.ts +18 -20
- package/front_end/core/sdk/SourceMapManager.ts +2 -2
- package/front_end/core/sdk/TargetManager.ts +2 -2
- package/front_end/devtools_compatibility.js +7 -3
- package/front_end/entrypoints/inspector_main/InspectorMain.ts +2 -2
- package/front_end/entrypoints/node_app/app/NodeConnectionsPanel.ts +203 -115
- package/front_end/generated/InspectorBackendCommands.ts +1 -1
- package/front_end/generated/SupportedCSSProperties.ts +1 -3
- package/front_end/generated/protocol.ts +1 -0
- package/front_end/models/ai_assistance/AiAgent2.ts +36 -12
- package/front_end/models/ai_assistance/AiConversation.ts +8 -2
- package/front_end/models/ai_assistance/agents/AiAgent.ts +137 -62
- package/front_end/models/ai_assistance/agents/ExecuteJavascript.ts +2 -2
- package/front_end/models/ai_assistance/agents/StylingAgent.snapshot.txt +2 -2
- package/front_end/models/ai_assistance/data_formatters/LighthouseFormatter.snapshot.txt +149 -2
- package/front_end/models/ai_assistance/data_formatters/LighthouseFormatter.ts +269 -42
- package/front_end/models/ai_assistance/tools/ExecuteJavaScript.ts +3 -0
- package/front_end/models/ai_assistance/tools/GetLighthouseAudits.ts +9 -0
- package/front_end/models/ai_assistance/tools/ResolveDevtoolsNodePath.ts +13 -2
- package/front_end/models/ai_assistance/tools/RunLighthouse.ts +23 -7
- package/front_end/models/ai_assistance/tools/Tool.ts +7 -5
- package/front_end/models/bindings/CSSWorkspaceBinding.ts +22 -24
- package/front_end/models/bindings/DebuggerLanguagePlugins.ts +60 -60
- package/front_end/models/bindings/DebuggerWorkspaceBinding.ts +24 -24
- package/front_end/models/bindings/DefaultScriptMapping.ts +8 -8
- package/front_end/models/bindings/FileUtils.ts +13 -13
- package/front_end/models/bindings/PresentationConsoleMessageHelper.ts +3 -3
- package/front_end/models/bindings/ResourceScriptMapping.ts +23 -23
- package/front_end/models/comment_manager/CommentManager.ts +3 -3
- package/front_end/models/comment_manager/CommentThread.ts +50 -5
- package/front_end/models/cpu_profile/CPUProfileDataModel.ts +14 -14
- package/front_end/models/cpu_profile/ProfileTreeModel.ts +4 -4
- package/front_end/models/elements/StyleChanges.ts +38 -0
- package/front_end/models/emulation/EmulatedDevices.ts +12 -12
- package/front_end/models/har/HARFormat.ts +4 -4
- package/front_end/models/javascript_metadata/NativeFunctions.ts +5 -1
- package/front_end/models/lighthouse/LighthouseReporterTypes.ts +57 -3
- package/front_end/models/lighthouse/RunTypes.ts +9 -1
- package/front_end/models/logs/LogManager.ts +2 -2
- package/front_end/models/persistence/AutomaticFileSystemManager.ts +3 -0
- package/front_end/models/persistence/FileSystemWorkspaceBinding.ts +24 -24
- package/front_end/models/persistence/IsolatedFileSystemManager.ts +6 -0
- package/front_end/models/persistence/NetworkPersistenceManager.ts +8 -3
- package/front_end/models/trace/LanternComputationData.ts +37 -11
- package/front_end/models/trace/Processor.ts +2 -1
- package/front_end/models/trace/extras/TraceTree.ts +36 -10
- package/front_end/models/trace/handlers/InitiatorsHandler.ts +27 -34
- package/front_end/models/trace/handlers/LayoutShiftsHandler.ts +2 -6
- package/front_end/models/trace/handlers/SamplesHandler.ts +9 -6
- package/front_end/models/workspace/FileManager.ts +6 -0
- package/front_end/panels/accessibility/ARIAAttributesView.ts +4 -4
- package/front_end/panels/accessibility/AccessibilityAnnouncementRecordingView.ts +8 -1
- package/front_end/panels/accessibility/AccessibilityNodeView.ts +15 -17
- package/front_end/panels/accessibility/AccessibilitySubPane.ts +1 -1
- package/front_end/panels/ai_assistance/AiAssistancePanel.ts +5 -5
- package/front_end/panels/ai_assistance/ExternalHandler.ts +10 -1
- package/front_end/panels/ai_assistance/components/ChatMessage.ts +27 -22
- package/front_end/panels/ai_assistance/components/DisabledWidget.ts +19 -23
- package/front_end/panels/ai_assistance/components/ExploreWidget.ts +2 -2
- package/front_end/panels/ai_assistance/components/PermissionPrompt.ts +23 -9
- package/front_end/panels/ai_assistance/components/chatInput.css +1 -1
- package/front_end/panels/animation/AnimationTimeline.ts +37 -17
- package/front_end/panels/animation/animationTimeline.css +19 -3
- package/front_end/panels/application/AppManifestView.ts +1 -2
- package/front_end/panels/application/ApplicationPanelSidebar.ts +143 -128
- package/front_end/panels/application/DOMStorageItemsView.ts +14 -14
- package/front_end/panels/application/DeviceBoundSessionsView.ts +10 -13
- package/front_end/panels/application/ExtensionStorageItemsView.ts +3 -4
- package/front_end/panels/application/IndexedDBViews.ts +8 -4
- package/front_end/panels/application/KeyValueStorageItemsView.ts +4 -5
- package/front_end/panels/application/PrivateVerificationTokensView.ts +53 -0
- package/front_end/panels/application/ServiceWorkerCacheViews.ts +12 -8
- package/front_end/panels/application/ServiceWorkersView.ts +1 -2
- package/front_end/panels/application/StorageItemsToolbar.ts +3 -3
- package/front_end/panels/application/StorageView.ts +2 -2
- package/front_end/panels/application/WebMCPView.ts +91 -109
- package/front_end/panels/application/application.ts +2 -0
- package/front_end/panels/application/components/StorageMetadataView.ts +6 -6
- package/front_end/panels/application/preloading/PreloadingView.ts +70 -37
- package/front_end/panels/application/preloading/components/MismatchedPreloadingGrid.ts +2 -2
- package/front_end/panels/application/preloading/components/PreloadingDisabledInfobar.ts +3 -3
- package/front_end/panels/application/preloading/components/PreloadingGrid.ts +12 -0
- package/front_end/panels/application/preloading/components/RuleSetDetailsView.ts +10 -11
- package/front_end/panels/application/privateVerificationTokensView.css +20 -0
- package/front_end/panels/application/serviceWorkersView.css +2 -2
- package/front_end/panels/browser_debugger/DOMBreakpointsSidebarPane.ts +24 -24
- package/front_end/panels/changes/ChangesSidebar.ts +5 -5
- package/front_end/panels/changes/ChangesView.ts +10 -11
- package/front_end/panels/comments/CommentsPane.ts +292 -102
- package/front_end/panels/comments/commentsPane.css +93 -12
- package/front_end/panels/common/CommentThreadWidget.ts +69 -0
- package/front_end/panels/common/CommentsOverlayWidget.ts +108 -29
- package/front_end/panels/common/CommentsStatusBarPill.ts +17 -6
- package/front_end/panels/common/DOMLinkifier.ts +37 -12
- package/front_end/panels/common/ExtensionPanel.ts +13 -4
- package/front_end/panels/common/ExtensionServer.ts +27 -3
- package/front_end/panels/common/PersistenceUtils.ts +3 -3
- package/front_end/panels/common/commentThreadWidget.css +25 -1
- package/front_end/panels/common/common-meta.ts +10 -0
- package/front_end/panels/console/ConsolePinPane.ts +13 -15
- package/front_end/panels/console/ConsolePrompt.ts +173 -95
- package/front_end/panels/console/ConsoleSidebar.ts +2 -2
- package/front_end/panels/console/ConsoleView.ts +75 -79
- package/front_end/panels/console/ConsoleViewMessage.ts +52 -4
- package/front_end/panels/console/SymbolizedErrorWidget.ts +8 -4
- package/front_end/panels/console/consolePrompt.css +1 -1
- package/front_end/panels/console/consoleView.css +1 -1
- package/front_end/panels/console_counters/WarningErrorCounter.ts +3 -4
- package/front_end/panels/coverage/CoverageListView.ts +2 -2
- package/front_end/panels/coverage/CoverageView.ts +20 -5
- package/front_end/panels/css_overview/CSSOverviewCompletedView.ts +4 -3
- package/front_end/panels/css_overview/CSSOverviewPanel.ts +2 -2
- package/front_end/panels/css_overview/CSSOverviewProcessingView.ts +2 -2
- package/front_end/panels/css_overview/CSSOverviewSidebarPanel.ts +2 -2
- package/front_end/panels/css_overview/CSSOverviewStartView.ts +2 -2
- package/front_end/panels/css_overview/CSSOverviewUnusedDeclarations.ts +8 -8
- package/front_end/panels/developer_resources/DeveloperResourcesListView.ts +2 -3
- package/front_end/panels/developer_resources/DeveloperResourcesView.ts +4 -5
- package/front_end/panels/elements/AccessibilityTreeUtils.ts +6 -7
- package/front_end/panels/elements/CSSValueTraceView.ts +3 -3
- package/front_end/panels/elements/ClassesPaneWidget.ts +1 -2
- package/front_end/panels/elements/ComputedStyleWidget.ts +15 -14
- package/front_end/panels/elements/DOMTreeElementWidget.ts +5 -4
- package/front_end/panels/elements/DOMTreeWidget.ts +2 -1
- package/front_end/panels/elements/ElementStatePaneWidget.ts +2 -2
- package/front_end/panels/elements/ElementsPanel.ts +1 -0
- package/front_end/panels/elements/EventListenersWidget.ts +2 -2
- package/front_end/panels/elements/LayoutPane.ts +2 -2
- package/front_end/panels/elements/PlatformFontsWidget.ts +3 -3
- package/front_end/panels/elements/PropertiesWidget.ts +9 -10
- package/front_end/panels/elements/PropertyRenderer.ts +72 -11
- package/front_end/panels/elements/StandaloneStylesContainer.ts +5 -10
- package/front_end/panels/elements/StyleEditorWidget.ts +30 -16
- package/front_end/panels/elements/StylePropertiesSection.ts +93 -44
- package/front_end/panels/elements/StylePropertyTreeElement.ts +230 -302
- package/front_end/panels/elements/StylesContainer.ts +2 -3
- package/front_end/panels/elements/StylesSidebarPane.ts +4 -13
- package/front_end/panels/elements/components/AccessibilityTreeNode.ts +66 -37
- package/front_end/panels/elements/components/CSSHintDetailsView.ts +51 -41
- package/front_end/panels/elements/components/CSSPropertyDocsView.ts +75 -65
- package/front_end/panels/elements/components/CSSQuery.ts +112 -74
- package/front_end/panels/elements/components/CSSVariableValueView.ts +109 -68
- package/front_end/panels/elements/components/ComputedStyleProperty.ts +64 -45
- package/front_end/panels/elements/components/ElementsTreeExpandButton.ts +35 -28
- package/front_end/panels/elements/components/QueryContainer.ts +104 -74
- package/front_end/panels/elements/components/accessibilityTreeNode.css +22 -20
- package/front_end/panels/elements/components/computedStyleProperty.css +2 -0
- package/front_end/panels/elements/components/cssHintDetailsView.css +23 -21
- package/front_end/panels/elements/components/cssPropertyDocsView.css +38 -36
- package/front_end/panels/elements/components/cssVariableValueView.css +42 -40
- package/front_end/panels/elements/components/elementsTreeExpandButton.css +5 -2
- package/front_end/panels/elements/components/queryContainer.css +23 -21
- package/front_end/panels/elements/stylesSidebarPane.css +3 -3
- package/front_end/panels/emulation/DeviceModeToolbar.ts +2 -2
- package/front_end/panels/emulation/InspectedPagePlaceholder.ts +2 -2
- package/front_end/panels/emulation/MediaQueryInspector.ts +9 -10
- package/front_end/panels/emulation/mediaQueryInspector.css +1 -1
- package/front_end/panels/event_listeners/EventListenersView.ts +2 -2
- package/front_end/panels/issues/AffectedCookiesView.ts +144 -101
- package/front_end/panels/issues/AffectedDescendantsWithinSelectElementView.ts +83 -31
- package/front_end/panels/issues/AffectedDirectivesView.ts +218 -135
- package/front_end/panels/issues/AffectedDocumentsInQuirksModeView.ts +84 -34
- package/front_end/panels/issues/AffectedElementsView.ts +86 -23
- package/front_end/panels/issues/AffectedLazyLoadImagesView.ts +2 -2
- package/front_end/panels/issues/AffectedMetadataAllowedSitesView.ts +2 -2
- package/front_end/panels/issues/AffectedPartitioningBlobURLView.ts +36 -11
- package/front_end/panels/issues/AffectedSharedArrayBufferIssueDetailsView.ts +135 -58
- package/front_end/panels/issues/AffectedSourcesView.ts +49 -28
- package/front_end/panels/issues/AffectedTrackingSitesView.ts +3 -4
- package/front_end/panels/issues/CorsIssueDetailsView.ts +490 -269
- package/front_end/panels/issues/GenericIssueDetailsView.ts +2 -2
- package/front_end/panels/issues/IssueKindView.ts +63 -48
- package/front_end/panels/issues/IssueView.ts +14 -18
- package/front_end/panels/issues/components/ElementsPanelLink.ts +70 -34
- package/front_end/panels/issues/components/HideIssuesMenu.ts +56 -32
- package/front_end/panels/issues/components/elementsPanelLink.css +10 -6
- package/front_end/panels/issues/components/hideIssuesMenu.css +16 -14
- package/front_end/panels/issues/issues.ts +2 -0
- package/front_end/panels/issues/issuesTree.css +4 -4
- package/front_end/panels/lighthouse/LighthouseController.ts +6 -6
- package/front_end/panels/lighthouse/LighthouseStatusView.ts +12 -13
- package/front_end/panels/lighthouse/lighthouseStartView.css +1 -1
- package/front_end/panels/linear_memory_inspector/LinearMemoryInspectorPane.ts +159 -161
- package/front_end/panels/linear_memory_inspector/LinearMemoryInspectorView.ts +228 -0
- package/front_end/panels/linear_memory_inspector/components/LinearMemoryInspector.ts +32 -41
- package/front_end/panels/linear_memory_inspector/components/linearMemoryHighlightChipList.css +2 -2
- package/front_end/panels/linear_memory_inspector/linear_memory_inspector.ts +2 -0
- package/front_end/panels/media/EventDisplayTable.ts +2 -2
- package/front_end/panels/media/MainView.ts +132 -66
- package/front_end/panels/media/PlayerDetailView.ts +32 -14
- package/front_end/panels/media/PlayerListView.ts +83 -23
- package/front_end/panels/media/PlayerPropertiesView.ts +2 -2
- package/front_end/panels/media/TickingFlameChart.ts +153 -63
- package/front_end/panels/mobile_throttling/NetworkThrottlingSelector.ts +2 -2
- package/front_end/panels/mobile_throttling/ThrottlingSettingsTab.ts +615 -464
- package/front_end/panels/mobile_throttling/throttlingSettingsTab.css +43 -0
- package/front_end/panels/network/EventSourceMessagesView.ts +3 -3
- package/front_end/panels/network/NetworkConfigView.ts +6 -2
- package/front_end/panels/network/NetworkDataGridNode.ts +2 -1
- package/front_end/panels/network/NetworkItemView.ts +27 -26
- package/front_end/panels/network/NetworkManageCustomHeadersView.ts +236 -97
- package/front_end/panels/network/NetworkOverview.ts +8 -10
- package/front_end/panels/network/RequestConditionsDrawer.ts +8 -4
- package/front_end/panels/network/RequestDeviceBoundSessionsView.ts +2 -4
- package/front_end/panels/network/RequestHTMLView.ts +26 -7
- package/front_end/panels/network/RequestHeadersView.ts +2 -2
- package/front_end/panels/network/RequestInitiatorView.ts +21 -22
- package/front_end/panels/network/RequestPayloadView.ts +2 -16
- package/front_end/panels/network/RequestPreviewView.ts +5 -5
- package/front_end/panels/network/RequestTimingView.ts +6 -6
- package/front_end/panels/network/ResourceDirectSocketChunkView.ts +5 -6
- package/front_end/panels/network/ResourceWebSocketFrameView.ts +4 -3
- package/front_end/panels/network/ShowMoreDetailsWidget.ts +11 -12
- package/front_end/panels/network/SignedExchangeInfoView.ts +2 -2
- package/front_end/panels/network/networkLogView.css +2 -2
- package/front_end/panels/network/networkManageCustomHeadersView.css +27 -6
- package/front_end/panels/network/requestConditionsDrawer.css +1 -1
- package/front_end/panels/network/requestInitiatorView.css +5 -3
- package/front_end/panels/performance_monitor/PerformanceMonitor.ts +2 -2
- package/front_end/panels/profiler/HeapDetachedElementsView.ts +1 -2
- package/front_end/panels/profiler/HeapTimelineOverview.ts +77 -15
- package/front_end/panels/profiler/IsolateSelector.ts +258 -187
- package/front_end/panels/profiler/ProfileLauncherView.ts +7 -29
- package/front_end/panels/profiler/profileLauncherView.css +6 -1
- package/front_end/panels/protocol_monitor/JSONEditor.ts +4 -5
- package/front_end/panels/recorder/ControlButton.ts +1 -1
- package/front_end/panels/recorder/RecordingListView.ts +2 -4
- package/front_end/panels/recorder/RecordingView.ts +1 -2
- package/front_end/panels/recorder/SelectorPicker.ts +2 -4
- package/front_end/panels/recorder/StepView.ts +24 -10
- package/front_end/panels/recorder/TimelineSection.ts +1 -1
- package/front_end/panels/recorder/recordingView.css +1 -1
- package/front_end/panels/screencast/ScreencastApp.ts +1 -1
- package/front_end/panels/search/SearchResultsPane.ts +11 -12
- package/front_end/panels/search/SearchView.ts +8 -10
- package/front_end/panels/security/SecurityPanel.ts +1 -8
- package/front_end/panels/security/SecurityPanelSidebar.ts +2 -2
- package/front_end/panels/security/mainView.css +1 -1
- package/front_end/panels/sensors/LocationsSettingsTab.ts +1 -2
- package/front_end/panels/settings/AISettingsTab.ts +1 -1
- package/front_end/panels/settings/BackendLinkingSettingsTab.ts +34 -20
- package/front_end/panels/settings/EditFileSystemView.ts +2 -2
- package/front_end/panels/settings/FrameworkIgnoreListSettingsTab.ts +375 -197
- package/front_end/panels/settings/KeybindsSettingsTab.ts +570 -414
- package/front_end/panels/settings/SettingsScreen.ts +312 -114
- package/front_end/panels/settings/WorkspaceSettingsTab.ts +2 -2
- package/front_end/panels/settings/aiSettingsTab.css +1 -4
- package/front_end/panels/settings/emulation/DevicesSettingsTab.ts +924 -578
- package/front_end/panels/settings/emulation/components/UserAgentClientHintsForm.ts +9 -2
- package/front_end/panels/settings/emulation/devicesSettingsTab.css +39 -0
- package/front_end/panels/settings/frameworkIgnoreListSettingsTab.css +37 -8
- package/front_end/panels/settings/settingsScreen.css +0 -24
- package/front_end/panels/sources/BreakpointEditDialog.ts +9 -6
- package/front_end/panels/sources/BreakpointsView.ts +25 -4
- package/front_end/panels/sources/CallStackSidebarPane.ts +7 -1
- package/front_end/panels/sources/DebuggerPlugin.ts +1 -0
- package/front_end/panels/sources/GoToLineQuickOpen.ts +8 -8
- package/front_end/panels/sources/NavigatorView.ts +521 -439
- package/front_end/panels/sources/PersistenceActions.ts +11 -12
- package/front_end/panels/sources/ProfilePlugin.ts +28 -17
- package/front_end/panels/sources/ScopeChainSidebarPane.ts +3 -4
- package/front_end/panels/sources/SourcesNavigator.ts +9 -9
- package/front_end/panels/sources/SourcesPanel.ts +2 -2
- package/front_end/panels/sources/SourcesView.ts +3 -3
- package/front_end/panels/sources/ThreadsSidebarPane.ts +2 -2
- package/front_end/panels/sources/WatchExpressionsSidebarPane.ts +2 -2
- package/front_end/panels/sources/components/HeadersView.ts +1 -2
- package/front_end/panels/timeline/CompatibilityTracksAppender.ts +5 -6
- package/front_end/panels/timeline/EventsTimelineTreeView.ts +73 -34
- package/front_end/panels/timeline/IsolateSelector.ts +25 -37
- package/front_end/panels/timeline/StatusDialog.ts +5 -7
- package/front_end/panels/timeline/ThirdPartyTreeView.ts +10 -13
- package/front_end/panels/timeline/TimelineDetailsView.ts +40 -21
- package/front_end/panels/timeline/TimelineEventOverview.ts +130 -34
- package/front_end/panels/timeline/TimelineFlameChartNetworkDataProvider.ts +1 -1
- package/front_end/panels/timeline/TimelineMiniMap.ts +255 -103
- package/front_end/panels/timeline/TimelinePaintProfilerView.ts +19 -11
- package/front_end/panels/timeline/TimelinePanel.ts +1 -0
- package/front_end/panels/timeline/TimelineSelectorStatsView.ts +11 -12
- package/front_end/panels/timeline/TimelineTreeView.ts +240 -122
- package/front_end/panels/timeline/TimelineUIUtils.ts +12 -0
- package/front_end/panels/timeline/components/BreadcrumbsUI.ts +5 -4
- package/front_end/panels/timeline/components/DetailsView.ts +97 -65
- package/front_end/panels/timeline/components/LayoutShiftDetails.ts +2 -2
- package/front_end/panels/timeline/components/MetricCard.ts +2 -2
- package/front_end/panels/timeline/components/NetworkRequestDetails.ts +11 -12
- package/front_end/panels/timeline/components/NetworkTrackWidget.ts +57 -50
- package/front_end/panels/timeline/components/RelatedInsightChips.ts +2 -2
- package/front_end/panels/timeline/components/Sidebar.ts +161 -109
- package/front_end/panels/timeline/components/SidebarAnnotationsTab.ts +33 -12
- package/front_end/panels/timeline/components/SidebarInsightsTab.ts +3 -0
- package/front_end/panels/timeline/components/insights/LCPDiscovery.ts +11 -11
- package/front_end/panels/timeline/components/insights/SlowCSSSelector.ts +6 -7
- package/front_end/panels/timeline/components/networkTrackWidget.css +24 -22
- package/front_end/panels/timeline/components/sidebarInsightsTab.css +1 -1
- package/front_end/panels/timeline/overlays/components/TimespanBreakdownOverlay.ts +15 -10
- package/front_end/panels/timeline/overlays/components/entryLabelOverlay.css +1 -1
- package/front_end/panels/timeline/timelinePanel.css +5 -0
- package/front_end/panels/timeline/timelineStatusDialog.css +1 -1
- package/front_end/panels/web_audio/WebAudioView.ts +2 -2
- package/front_end/third_party/chromium/README.chromium +1 -1
- package/front_end/third_party/legacy-javascript/README.chromium +2 -2
- package/front_end/third_party/legacy-javascript/lib/legacy-javascript.js +2 -2
- package/front_end/third_party/legacy-javascript/package.json +1 -1
- package/front_end/third_party/lighthouse/README.chromium +2 -2
- package/front_end/third_party/lighthouse/lighthouse-dt-bundle.js +1983 -2022
- package/front_end/third_party/lighthouse/locales/ar-XB.json +157 -142
- package/front_end/third_party/lighthouse/locales/ar.json +157 -142
- package/front_end/third_party/lighthouse/locales/bg.json +154 -139
- package/front_end/third_party/lighthouse/locales/ca.json +157 -142
- package/front_end/third_party/lighthouse/locales/cs.json +148 -133
- package/front_end/third_party/lighthouse/locales/da.json +153 -138
- package/front_end/third_party/lighthouse/locales/de.json +152 -137
- package/front_end/third_party/lighthouse/locales/el.json +153 -138
- package/front_end/third_party/lighthouse/locales/en-GB.json +160 -145
- package/front_end/third_party/lighthouse/locales/en-US.json +239 -218
- package/front_end/third_party/lighthouse/locales/en-XL.json +239 -218
- package/front_end/third_party/lighthouse/locales/es-419.json +150 -135
- package/front_end/third_party/lighthouse/locales/es.json +149 -134
- package/front_end/third_party/lighthouse/locales/fi.json +151 -136
- package/front_end/third_party/lighthouse/locales/fil.json +154 -139
- package/front_end/third_party/lighthouse/locales/fr.json +150 -135
- package/front_end/third_party/lighthouse/locales/he.json +160 -145
- package/front_end/third_party/lighthouse/locales/hi.json +156 -141
- package/front_end/third_party/lighthouse/locales/hr.json +154 -139
- package/front_end/third_party/lighthouse/locales/hu.json +111 -96
- package/front_end/third_party/lighthouse/locales/id.json +153 -138
- package/front_end/third_party/lighthouse/locales/it.json +153 -138
- package/front_end/third_party/lighthouse/locales/ja.json +150 -135
- package/front_end/third_party/lighthouse/locales/ko.json +42 -27
- package/front_end/third_party/lighthouse/locales/lt.json +152 -137
- package/front_end/third_party/lighthouse/locales/lv.json +93 -78
- package/front_end/third_party/lighthouse/locales/nl.json +149 -134
- package/front_end/third_party/lighthouse/locales/no.json +152 -137
- package/front_end/third_party/lighthouse/locales/pl.json +153 -138
- package/front_end/third_party/lighthouse/locales/pt-PT.json +152 -137
- package/front_end/third_party/lighthouse/locales/pt.json +157 -142
- package/front_end/third_party/lighthouse/locales/ro.json +149 -134
- package/front_end/third_party/lighthouse/locales/ru.json +76 -61
- package/front_end/third_party/lighthouse/locales/sk.json +153 -138
- package/front_end/third_party/lighthouse/locales/sl.json +149 -134
- package/front_end/third_party/lighthouse/locales/sr-Latn.json +151 -136
- package/front_end/third_party/lighthouse/locales/sr.json +151 -136
- package/front_end/third_party/lighthouse/locales/sv.json +152 -137
- package/front_end/third_party/lighthouse/locales/ta.json +156 -141
- package/front_end/third_party/lighthouse/locales/te.json +157 -142
- package/front_end/third_party/lighthouse/locales/th.json +111 -96
- package/front_end/third_party/lighthouse/locales/tr.json +153 -138
- package/front_end/third_party/lighthouse/locales/uk.json +149 -134
- package/front_end/third_party/lighthouse/locales/vi.json +162 -147
- package/front_end/third_party/lighthouse/locales/zh-HK.json +150 -135
- package/front_end/third_party/lighthouse/locales/zh-TW.json +154 -139
- package/front_end/third_party/lighthouse/locales/zh.json +152 -137
- package/front_end/third_party/lighthouse/report/bundle.d.ts +9 -8
- package/front_end/third_party/lighthouse/report/bundle.js +10 -10
- package/front_end/third_party/lighthouse/report-assets/report-generator.mjs +2 -7
- package/front_end/tsconfig.compatibility.json +1 -0
- package/front_end/tsconfig.json +3 -2
- package/front_end/ui/components/dialogs/TypeToAllowDialog.ts +0 -2
- package/front_end/ui/components/dialogs/typeToAllowDialog.css +0 -4
- package/front_end/ui/components/icon_button/fileSourceIcon.css +1 -1
- package/front_end/ui/components/input/textInput.css +1 -1
- package/front_end/ui/components/lists/List.ts +26 -14
- package/front_end/ui/components/menus/menus.ts +0 -2
- package/front_end/ui/components/suggestion_input/SuggestionInput.ts +351 -138
- package/front_end/ui/components/survey_link/surveyLink.css +3 -3
- package/front_end/ui/components/switch/switch.css +6 -6
- package/front_end/ui/components/text_editor/AiCodeCompletionTeaser.ts +2 -3
- package/front_end/ui/components/text_editor/TextEditor.ts +1 -1
- package/front_end/ui/components/tooltips/Tooltip.ts +53 -4
- package/front_end/ui/components/tree_outline/treeOutline.css +7 -7
- package/front_end/ui/helpers/OpenInNewTab.ts +8 -3
- package/front_end/ui/legacy/EmptyWidget.ts +4 -4
- package/front_end/ui/legacy/ForwardedInputEventHandler.ts +2 -2
- package/front_end/ui/legacy/GlassPane.ts +1 -1
- package/front_end/ui/legacy/KeyboardShortcut.ts +7 -7
- package/front_end/ui/legacy/RemoteDebuggingTerminatedScreen.ts +2 -2
- package/front_end/ui/legacy/TabbedPane.ts +198 -66
- package/front_end/ui/legacy/TargetCrashedScreen.ts +2 -2
- package/front_end/ui/legacy/UIUtils.ts +71 -68
- package/front_end/ui/legacy/View.ts +7 -4
- package/front_end/ui/legacy/ViewManager.ts +49 -37
- package/front_end/ui/legacy/Widget.ts +32 -12
- package/front_end/ui/legacy/components/cookie_table/CookiesTable.ts +2 -3
- package/front_end/ui/legacy/components/inline_editor/AnimationTimingUI.ts +8 -8
- package/front_end/ui/legacy/components/inline_editor/BezierUI.ts +8 -9
- package/front_end/ui/legacy/components/inline_editor/LinkSwatch.ts +2 -2
- package/front_end/ui/legacy/components/inline_editor/cssAngleEditor.css +1 -1
- package/front_end/ui/legacy/components/inline_editor/cssAngleSwatch.css +1 -1
- package/front_end/ui/legacy/components/object_ui/ObjectPropertiesSection.ts +45 -11
- package/front_end/ui/legacy/components/object_ui/RemoteObjectPreviewFormatter.ts +10 -12
- package/front_end/ui/legacy/components/perf_ui/ChartViewport.ts +102 -29
- package/front_end/ui/legacy/components/perf_ui/FlameChart.ts +148 -122
- package/front_end/ui/legacy/components/perf_ui/TimelineOverviewPane.ts +20 -14
- package/front_end/ui/legacy/components/quick_open/filteredListWidget.css +1 -1
- package/front_end/ui/legacy/components/source_frame/FontView.ts +29 -5
- package/front_end/ui/legacy/components/source_frame/ImageView.ts +79 -12
- package/front_end/ui/legacy/components/source_frame/JSONView.ts +20 -2
- package/front_end/ui/legacy/components/source_frame/PreviewFactory.ts +2 -2
- package/front_end/ui/legacy/components/source_frame/StreamingContentHexView.ts +6 -10
- package/front_end/ui/legacy/components/source_frame/XMLView.ts +11 -11
- package/front_end/ui/legacy/components/source_frame/fontView.css +7 -0
- package/front_end/ui/legacy/components/source_frame/imageView.css +7 -0
- package/front_end/ui/legacy/components/utils/JSPresentationUtils.ts +14 -3
- package/front_end/ui/legacy/components/utils/Linkifier.ts +126 -2
- package/front_end/ui/legacy/emptyWidget.css +2 -1
- package/front_end/ui/legacy/inspectorCommon.css +3 -3
- package/front_end/ui/legacy/smallBubble.css +1 -1
- package/front_end/ui/legacy/tabbedPane.css +6 -0
- package/front_end/ui/lit/Directives.ts +35 -18
- package/front_end/ui/lit/lit.ts +0 -2
- package/front_end/ui/lit/render.ts +0 -7
- package/front_end/ui/visual_logging/KnownContextValues.ts +5 -0
- package/package.json +1 -1
- package/vpython.toml +8 -0
- package/vpython.toml.uv.lock +3 -0
- package/.agents/skills/review-models-core/SKILL.md +0 -73
- package/.agents/skills/review-tests/SKILL.md +0 -67
- package/.agents/skills/review-ui-widgets/SKILL.md +0 -115
- package/front_end/generated/ARIAProperties.ts +0 -2686
- package/front_end/ui/components/menus/README.md +0 -119
- package/front_end/ui/components/menus/SelectMenu.ts +0 -473
- package/front_end/ui/components/menus/selectMenu.css +0 -54
- package/front_end/ui/components/menus/selectMenuButton.css +0 -108
|
@@ -1,53 +1,116 @@
|
|
|
1
1
|
// Copyright 2021 The Chromium Authors
|
|
2
2
|
// Use of this source code is governed by a BSD-style license that can be
|
|
3
3
|
// found in the LICENSE file.
|
|
4
|
-
/* eslint-disable @devtools/no-imperative-dom-api */
|
|
5
4
|
|
|
5
|
+
import * as Host from '../../core/host/host.js';
|
|
6
6
|
import * as i18n from '../../core/i18n/i18n.js';
|
|
7
7
|
import type * as Platform from '../../core/platform/platform.js';
|
|
8
|
+
import * as SDK from '../../core/sdk/sdk.js';
|
|
9
|
+
import type * as Protocol from '../../generated/protocol.js';
|
|
8
10
|
import type * as IssuesManager from '../../models/issues_manager/issues_manager.js';
|
|
11
|
+
import * as UI from '../../ui/legacy/legacy.js';
|
|
12
|
+
import {Directives, html, type LitTemplate, render} from '../../ui/lit/lit.js';
|
|
9
13
|
import * as VisualLogging from '../../ui/visual_logging/visual_logging.js';
|
|
14
|
+
import * as PanelsCommon from '../common/common.js';
|
|
10
15
|
|
|
11
|
-
import {AffectedResourcesView} from './AffectedResourcesView.js';
|
|
16
|
+
import {AffectedItem, AffectedResourcesView} from './AffectedResourcesView.js';
|
|
17
|
+
import type {IssueView} from './IssueView.js';
|
|
18
|
+
|
|
19
|
+
const {ifDefined} = Directives;
|
|
20
|
+
const {widget} = UI.Widget;
|
|
21
|
+
|
|
22
|
+
export interface ElementRow {
|
|
23
|
+
nodeName: string;
|
|
24
|
+
backendNodeId: Protocol.DOM.BackendNodeId;
|
|
25
|
+
// Resolved in the presenter; `undefined` when the issue has no target.
|
|
26
|
+
deferredNode?: SDK.DOMModel.DeferredDOMNode;
|
|
27
|
+
targetId?: string;
|
|
28
|
+
onElementClick: () => void;
|
|
29
|
+
}
|
|
30
|
+
|
|
31
|
+
export interface ViewInput {
|
|
32
|
+
rows: ElementRow[];
|
|
33
|
+
}
|
|
34
|
+
|
|
35
|
+
export type View = (input: ViewInput, _output: undefined, target: HTMLElement) => void;
|
|
36
|
+
|
|
37
|
+
export const DEFAULT_VIEW: View = (input, _output, target) => {
|
|
38
|
+
const renderElementCell = (row: ElementRow): LitTemplate => {
|
|
39
|
+
const {deferredNode} = row;
|
|
40
|
+
if (!deferredNode) {
|
|
41
|
+
return html`<td>${row.nodeName || i18nString(UIStrings.unavailable)}</td>`;
|
|
42
|
+
}
|
|
43
|
+
// clang-format off
|
|
44
|
+
return html`
|
|
45
|
+
<td class="affected-resource-element devtools-link">${
|
|
46
|
+
widget(PanelsCommon.DOMLinkifier.DeferredDOMNodeLink, {
|
|
47
|
+
deferredNode,
|
|
48
|
+
options: {textContent: row.nodeName || undefined, onClick: row.onElementClick},
|
|
49
|
+
})}</td>
|
|
50
|
+
`;
|
|
51
|
+
// clang-format on
|
|
52
|
+
};
|
|
53
|
+
|
|
54
|
+
// clang-format off
|
|
55
|
+
render(html`
|
|
56
|
+
${input.rows.map(row => html`
|
|
57
|
+
<tr jslog=${VisualLogging.tableRow('affected-element')}
|
|
58
|
+
data-backend-node-id=${ifDefined(row.backendNodeId ? String(row.backendNodeId) : undefined)}
|
|
59
|
+
data-target-id=${ifDefined(row.backendNodeId ? row.targetId : undefined)}>
|
|
60
|
+
${renderElementCell(row)}
|
|
61
|
+
</tr>
|
|
62
|
+
`)}
|
|
63
|
+
`, target);
|
|
64
|
+
// clang-format on
|
|
65
|
+
};
|
|
12
66
|
|
|
13
67
|
const UIStrings = {
|
|
14
68
|
/**
|
|
15
69
|
* @description Label in the Issues panel for the number of affected elements.
|
|
16
70
|
*/
|
|
17
71
|
nElements: '{n, plural, =1 {# element} other {# elements}}',
|
|
72
|
+
/**
|
|
73
|
+
* @description Fallback text in the Issues panel when an HTML element is unavailable in the affected resources table.
|
|
74
|
+
*/
|
|
75
|
+
unavailable: 'Unavailable',
|
|
18
76
|
} as const;
|
|
19
77
|
const str_ = i18n.i18n.registerUIStrings('panels/issues/AffectedElementsView.ts', UIStrings);
|
|
20
78
|
const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
|
|
21
79
|
export class AffectedElementsView extends AffectedResourcesView {
|
|
22
|
-
|
|
23
|
-
|
|
24
|
-
|
|
25
|
-
|
|
26
|
-
|
|
27
|
-
|
|
28
|
-
|
|
80
|
+
readonly #view: View;
|
|
81
|
+
|
|
82
|
+
constructor(parent: IssueView, issue: IssuesManager.IssueAggregator.AggregatedIssue, jslogContext: string,
|
|
83
|
+
view: View = DEFAULT_VIEW) {
|
|
84
|
+
super(parent, issue, jslogContext);
|
|
85
|
+
this.#view = view;
|
|
86
|
+
}
|
|
87
|
+
|
|
88
|
+
#appendAffectedElements(affectedElements: Iterable<IssuesManager.Issue.AffectedElement>): void {
|
|
89
|
+
const rows = Array.from(affectedElements, element => this.#createAffectedElementRow(element));
|
|
90
|
+
this.#view({rows}, undefined, this.affectedResources);
|
|
91
|
+
this.updateAffectedResourceCount(rows.length);
|
|
29
92
|
}
|
|
30
93
|
|
|
31
94
|
protected getResourceNameWithCount(count: number): Platform.UIString.LocalizedString {
|
|
32
95
|
return i18nString(UIStrings.nElements, {n: count});
|
|
33
96
|
}
|
|
34
97
|
|
|
35
|
-
|
|
36
|
-
const
|
|
37
|
-
const
|
|
38
|
-
|
|
39
|
-
|
|
40
|
-
|
|
41
|
-
|
|
42
|
-
|
|
43
|
-
|
|
44
|
-
|
|
45
|
-
|
|
46
|
-
|
|
98
|
+
#createAffectedElementRow(element: IssuesManager.Issue.AffectedElement): ElementRow {
|
|
99
|
+
const issueCategory = this.issue.getCategory();
|
|
100
|
+
const {target, backendNodeId} = element;
|
|
101
|
+
return {
|
|
102
|
+
nodeName: element.nodeName,
|
|
103
|
+
backendNodeId,
|
|
104
|
+
deferredNode: target ? new SDK.DOMModel.DeferredDOMNode(target, backendNodeId) : undefined,
|
|
105
|
+
targetId: target?.id(),
|
|
106
|
+
onElementClick: () => {
|
|
107
|
+
Host.userMetrics.issuesPanelResourceOpened(issueCategory, AffectedItem.ELEMENT);
|
|
108
|
+
},
|
|
109
|
+
};
|
|
47
110
|
}
|
|
48
111
|
|
|
49
112
|
update(): void {
|
|
50
|
-
this.clear();
|
|
51
|
-
|
|
113
|
+
this.requestResolver.clear();
|
|
114
|
+
this.#appendAffectedElements(this.issue.elements());
|
|
52
115
|
}
|
|
53
116
|
}
|
|
@@ -26,7 +26,7 @@ export interface ViewInput {
|
|
|
26
26
|
category: IssuesManager.Issue.IssueCategory) => Promise<Element>;
|
|
27
27
|
}
|
|
28
28
|
|
|
29
|
-
export type View = (input: ViewInput, output:
|
|
29
|
+
export type View = (input: ViewInput, output: undefined, target: HTMLElement) => Promise<void>;
|
|
30
30
|
|
|
31
31
|
export const DEFAULT_VIEW: View = async (input, _output, target) => {
|
|
32
32
|
const templates = [];
|
|
@@ -71,6 +71,6 @@ export class AffectedLazyLoadImagesView extends AffectedResourcesView {
|
|
|
71
71
|
issueCategory: this.issue.getCategory(),
|
|
72
72
|
createElementCell: this.createElementCell.bind(this),
|
|
73
73
|
};
|
|
74
|
-
await this.#view(input,
|
|
74
|
+
await this.#view(input, undefined, this.affectedResources);
|
|
75
75
|
}
|
|
76
76
|
}
|
|
@@ -38,7 +38,7 @@ export interface ViewInput {
|
|
|
38
38
|
issueDetails: readonly Protocol.Audits.CookieDeprecationMetadataIssueDetails[];
|
|
39
39
|
}
|
|
40
40
|
|
|
41
|
-
export type View = (input: ViewInput, output:
|
|
41
|
+
export type View = (input: ViewInput, output: undefined, target: HTMLElement) => void;
|
|
42
42
|
|
|
43
43
|
function renderOptOut(details: Protocol.Audits.CookieDeprecationMetadataIssueDetails): LitTemplate {
|
|
44
44
|
if (details.isOptOutTopLevel || details.optOutPercentage <= 0) {
|
|
@@ -87,7 +87,7 @@ export class AffectedMetadataAllowedSitesView extends AffectedResourcesView {
|
|
|
87
87
|
|
|
88
88
|
override update(): void {
|
|
89
89
|
const issueDetails = Array.from(this.issue.getCookieDeprecationMetadataIssues(), issue => issue.details());
|
|
90
|
-
this.#view({issueDetails},
|
|
90
|
+
this.#view({issueDetails}, undefined, this.affectedResources);
|
|
91
91
|
this.updateAffectedResourceCount(issueDetails.length);
|
|
92
92
|
}
|
|
93
93
|
}
|
|
@@ -1,23 +1,41 @@
|
|
|
1
1
|
// Copyright 2025 The Chromium Authors
|
|
2
2
|
// Use of this source code is governed by a BSD-style license that can be
|
|
3
3
|
// found in the LICENSE file.
|
|
4
|
-
/* eslint-disable @devtools/no-imperative-dom-api */
|
|
5
4
|
|
|
6
5
|
import * as i18n from '../../core/i18n/i18n.js';
|
|
7
6
|
import type * as Platform from '../../core/platform/platform.js';
|
|
8
7
|
import * as Protocol from '../../generated/protocol.js';
|
|
8
|
+
import type * as IssuesManager from '../../models/issues_manager/issues_manager.js';
|
|
9
|
+
import {html, render} from '../../ui/lit/lit.js';
|
|
9
10
|
|
|
10
11
|
import {AffectedResourcesView} from './AffectedResourcesView.js';
|
|
12
|
+
import type {IssueView} from './IssueView.js';
|
|
13
|
+
|
|
14
|
+
export interface ViewInput {
|
|
15
|
+
messages: Platform.UIString.LocalizedString[];
|
|
16
|
+
}
|
|
17
|
+
|
|
18
|
+
export type View = (input: ViewInput, _output: undefined, target: HTMLElement) => void;
|
|
19
|
+
|
|
20
|
+
export const DEFAULT_VIEW: View = (input, _output, target) => {
|
|
21
|
+
// clang-format off
|
|
22
|
+
render(html`
|
|
23
|
+
${input.messages.map(message => html`<div>${message}</div>`)}
|
|
24
|
+
`, target);
|
|
25
|
+
// clang-format on
|
|
26
|
+
};
|
|
11
27
|
|
|
12
28
|
const UIStrings = {
|
|
13
29
|
/**
|
|
14
|
-
* @description Description in the Issues panel for a partitioning blob URL
|
|
30
|
+
* @description Description in the Issues panel for a partitioning blob URL
|
|
31
|
+
* issue when cross-partition fetching is blocked.
|
|
15
32
|
* @example {blob:https://web-platform.test:8444/example} url
|
|
16
33
|
*/
|
|
17
34
|
blockedCrossPartitionFetching:
|
|
18
35
|
'Access to the Blob URL {url} was blocked because it was performed from a cross-partition context',
|
|
19
36
|
/**
|
|
20
|
-
* @description Description in the Issues panel for a partitioning blob URL
|
|
37
|
+
* @description Description in the Issues panel for a partitioning blob URL
|
|
38
|
+
* issue when noopener is enforced for navigation.
|
|
21
39
|
* @example {blob:https://web-platform.test:8444/example} url
|
|
22
40
|
*/
|
|
23
41
|
enforceNoopenerForNavigation:
|
|
@@ -28,7 +46,8 @@ const UIStrings = {
|
|
|
28
46
|
*/
|
|
29
47
|
blobURLCount: 'Blob URL issues count: {count}',
|
|
30
48
|
/**
|
|
31
|
-
* @description Message in the Issues panel shown when no blob URL is
|
|
49
|
+
* @description Message in the Issues panel shown when no blob URL is
|
|
50
|
+
* available for a partitioning blob URL issue.
|
|
32
51
|
*/
|
|
33
52
|
noBlobURLAvailable: 'No Blob URL available for this issue',
|
|
34
53
|
} as const;
|
|
@@ -37,13 +56,22 @@ const str_ = i18n.i18n.registerUIStrings('panels/issues/AffectedPartitioningBlob
|
|
|
37
56
|
const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
|
|
38
57
|
|
|
39
58
|
export class AffectedPartitioningBlobURLView extends AffectedResourcesView {
|
|
59
|
+
readonly #view: View;
|
|
60
|
+
|
|
61
|
+
constructor(parent: IssueView, issue: IssuesManager.IssueAggregator.AggregatedIssue, jslogContext: string,
|
|
62
|
+
view: View = DEFAULT_VIEW) {
|
|
63
|
+
super(parent, issue, jslogContext);
|
|
64
|
+
this.#view = view;
|
|
65
|
+
}
|
|
66
|
+
|
|
40
67
|
protected override getResourceNameWithCount(count: number): string {
|
|
41
68
|
return i18nString(UIStrings.blobURLCount, {count});
|
|
42
69
|
}
|
|
43
70
|
|
|
44
71
|
override update(): void {
|
|
45
|
-
this.clear();
|
|
72
|
+
this.requestResolver.clear();
|
|
46
73
|
let count = 0;
|
|
74
|
+
const messages: Platform.UIString.LocalizedString[] = [];
|
|
47
75
|
const partitioningBlobURLIssues = this.issue.getPartitioningBlobURLIssues();
|
|
48
76
|
for (const issue of partitioningBlobURLIssues) {
|
|
49
77
|
const blobURL = issue.details().url;
|
|
@@ -60,16 +88,13 @@ export class AffectedPartitioningBlobURLView extends AffectedResourcesView {
|
|
|
60
88
|
description = i18nString(UIStrings.enforceNoopenerForNavigation, {url: blobURL});
|
|
61
89
|
break;
|
|
62
90
|
}
|
|
63
|
-
|
|
64
|
-
descriptionElement.textContent = description;
|
|
65
|
-
this.affectedResources.appendChild(descriptionElement);
|
|
91
|
+
messages.push(description);
|
|
66
92
|
count++;
|
|
67
93
|
} else {
|
|
68
|
-
|
|
69
|
-
noURLMessage.textContent = i18nString(UIStrings.noBlobURLAvailable);
|
|
70
|
-
this.affectedResources.appendChild(noURLMessage);
|
|
94
|
+
messages.push(i18nString(UIStrings.noBlobURLAvailable));
|
|
71
95
|
}
|
|
72
96
|
}
|
|
97
|
+
this.#view({messages}, undefined, this.affectedResources);
|
|
73
98
|
this.updateAffectedResourceCount(count);
|
|
74
99
|
}
|
|
75
100
|
}
|
|
@@ -1,121 +1,198 @@
|
|
|
1
1
|
// Copyright 2020 The Chromium Authors
|
|
2
2
|
// Use of this source code is governed by a BSD-style license that can be
|
|
3
3
|
// found in the LICENSE file.
|
|
4
|
-
/* eslint-disable @devtools/no-imperative-dom-api */
|
|
5
4
|
|
|
6
5
|
import * as i18n from '../../core/i18n/i18n.js';
|
|
7
|
-
import
|
|
6
|
+
import * as Platform from '../../core/platform/platform.js';
|
|
7
|
+
import type * as SDK from '../../core/sdk/sdk.js';
|
|
8
8
|
import * as Protocol from '../../generated/protocol.js';
|
|
9
9
|
import * as IssuesManager from '../../models/issues_manager/issues_manager.js';
|
|
10
|
+
import * as Components from '../../ui/legacy/components/utils/utils.js';
|
|
11
|
+
import * as UI from '../../ui/legacy/legacy.js';
|
|
12
|
+
import {html, type LitTemplate, render} from '../../ui/lit/lit.js';
|
|
10
13
|
|
|
11
14
|
import {AffectedResourcesView} from './AffectedResourcesView.js';
|
|
15
|
+
import type {IssueView} from './IssueView.js';
|
|
16
|
+
|
|
17
|
+
const {widget} = UI.Widget;
|
|
18
|
+
|
|
19
|
+
export interface SourceLocationData {
|
|
20
|
+
target: SDK.Target.Target|null;
|
|
21
|
+
scriptId: Protocol.Runtime.ScriptId|null;
|
|
22
|
+
url: Platform.DevToolsPath.UrlString;
|
|
23
|
+
lineNumber: number;
|
|
24
|
+
columnNumber?: number;
|
|
25
|
+
}
|
|
26
|
+
|
|
27
|
+
export interface SharedArrayBufferRow {
|
|
28
|
+
sourceLocation?: SourceLocationData;
|
|
29
|
+
triggerText: Platform.UIString.LocalizedString;
|
|
30
|
+
triggerTitle: Platform.UIString.LocalizedString;
|
|
31
|
+
isWarning: boolean;
|
|
32
|
+
}
|
|
33
|
+
|
|
34
|
+
export interface ViewInput {
|
|
35
|
+
rows: SharedArrayBufferRow[];
|
|
36
|
+
}
|
|
37
|
+
|
|
38
|
+
export type View = (input: ViewInput, _output: undefined, target: HTMLElement) => void;
|
|
39
|
+
|
|
40
|
+
export const DEFAULT_VIEW: View = (input, _output, target) => {
|
|
41
|
+
const renderSourceLocation = (location: SourceLocationData|undefined): LitTemplate => {
|
|
42
|
+
if (!location) {
|
|
43
|
+
return html`<td class="affected-source-location"></td>`;
|
|
44
|
+
}
|
|
45
|
+
// clang-format off
|
|
46
|
+
return html`
|
|
47
|
+
<td class="affected-source-location">${
|
|
48
|
+
widget(Components.Linkifier.ScriptLocationLink, {
|
|
49
|
+
target: location.target ?? undefined,
|
|
50
|
+
scriptId: location.scriptId ?? undefined,
|
|
51
|
+
sourceURL: location.url,
|
|
52
|
+
lineNumber: location.lineNumber,
|
|
53
|
+
options: {
|
|
54
|
+
columnNumber: location.columnNumber,
|
|
55
|
+
maxLength: UI.UIUtils.MaxLengthForDisplayedURLsInConsole,
|
|
56
|
+
jslogContext: 'source-location',
|
|
57
|
+
},
|
|
58
|
+
})}</td>
|
|
59
|
+
`;
|
|
60
|
+
// clang-format on
|
|
61
|
+
};
|
|
62
|
+
|
|
63
|
+
// clang-format off
|
|
64
|
+
render(html`
|
|
65
|
+
<tr>
|
|
66
|
+
<td class="affected-resource-header">${i18nString(UIStrings.sourceLocation)}</td>
|
|
67
|
+
<td class="affected-resource-header">${i18nString(UIStrings.trigger)}</td>
|
|
68
|
+
<td class="affected-resource-header">${i18nString(UIStrings.status)}</td>
|
|
69
|
+
</tr>
|
|
70
|
+
${input.rows.map(row => html`
|
|
71
|
+
<tr class="affected-resource-directive">
|
|
72
|
+
${renderSourceLocation(row.sourceLocation)}
|
|
73
|
+
<td title=${row.triggerTitle}>${row.triggerText}</td>
|
|
74
|
+
<td class=${row.isWarning ? 'affected-resource-report-only-status' : 'affected-resource-blocked-status'}>
|
|
75
|
+
${row.isWarning ? i18nString(UIStrings.warning) : i18nString(UIStrings.blocked)}
|
|
76
|
+
</td>
|
|
77
|
+
</tr>
|
|
78
|
+
`)}
|
|
79
|
+
`, target);
|
|
80
|
+
// clang-format on
|
|
81
|
+
};
|
|
12
82
|
|
|
13
83
|
const UIStrings = {
|
|
14
84
|
/**
|
|
15
|
-
* @description Label in the Issues panel for the number of affected
|
|
85
|
+
* @description Label in the Issues panel for the number of affected
|
|
86
|
+
* violations in the SharedArrayBuffer affected resources table.
|
|
16
87
|
*/
|
|
17
88
|
nViolations: '{n, plural, =1 {# violation} other {# violations}}',
|
|
18
89
|
/**
|
|
19
|
-
* @description Violation status in the Issues panel indicating that a
|
|
90
|
+
* @description Violation status in the Issues panel indicating that a
|
|
91
|
+
* SharedArrayBuffer issue produced a warning.
|
|
20
92
|
*/
|
|
21
93
|
warning: 'Warning',
|
|
22
94
|
/**
|
|
23
|
-
* @description Violation status in the Issues panel indicating that a
|
|
95
|
+
* @description Violation status in the Issues panel indicating that a
|
|
96
|
+
* SharedArrayBuffer operation was blocked.
|
|
24
97
|
*/
|
|
25
98
|
blocked: 'Blocked',
|
|
26
99
|
/**
|
|
27
|
-
* @description Trigger type in the Issues panel indicating that a
|
|
100
|
+
* @description Trigger type in the Issues panel indicating that a
|
|
101
|
+
* SharedArrayBuffer was instantiated.
|
|
28
102
|
*/
|
|
29
103
|
instantiation: 'Instantiation',
|
|
30
104
|
/**
|
|
31
|
-
* @description Tooltip in the Issues panel explaining that a
|
|
105
|
+
* @description Tooltip in the Issues panel explaining that a
|
|
106
|
+
* SharedArrayBuffer was instantiated in a non-cross-origin-isolated context.
|
|
32
107
|
*/
|
|
33
108
|
aSharedarraybufferWas: 'A `SharedArrayBuffer` was instantiated in a context that isn’t cross-origin isolated',
|
|
34
109
|
/**
|
|
35
|
-
* @description Trigger type in the Issues panel indicating that a
|
|
110
|
+
* @description Trigger type in the Issues panel indicating that a
|
|
111
|
+
* SharedArrayBuffer was transferred.
|
|
36
112
|
*/
|
|
37
113
|
transfer: 'Transfer',
|
|
38
114
|
/**
|
|
39
|
-
* @description Tooltip in the Issues panel explaining that a
|
|
115
|
+
* @description Tooltip in the Issues panel explaining that a
|
|
116
|
+
* SharedArrayBuffer was transferred to a non-cross-origin-isolated context.
|
|
40
117
|
*/
|
|
41
118
|
sharedarraybufferWasTransferedTo: '`SharedArrayBuffer` was transferred to a context that isn’t cross-origin isolated',
|
|
42
119
|
/**
|
|
43
|
-
* @description Column header in the Issues panel for source locations in the
|
|
120
|
+
* @description Column header in the Issues panel for source locations in the
|
|
121
|
+
* SharedArrayBuffer affected resources table.
|
|
44
122
|
*/
|
|
45
123
|
sourceLocation: 'Source location',
|
|
46
124
|
/**
|
|
47
|
-
* @description Column header in the Issues panel for trigger types in the
|
|
125
|
+
* @description Column header in the Issues panel for trigger types in the
|
|
126
|
+
* SharedArrayBuffer affected resources table.
|
|
48
127
|
*/
|
|
49
128
|
trigger: 'Trigger',
|
|
50
129
|
/**
|
|
51
|
-
* @description Column header in the Issues panel for violation status in the
|
|
130
|
+
* @description Column header in the Issues panel for violation status in the
|
|
131
|
+
* SharedArrayBuffer affected resources table.
|
|
52
132
|
*/
|
|
53
133
|
status: 'Status',
|
|
54
134
|
} as const;
|
|
55
135
|
const str_ = i18n.i18n.registerUIStrings('panels/issues/AffectedSharedArrayBufferIssueDetailsView.ts', UIStrings);
|
|
56
136
|
const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
|
|
57
137
|
export class AffectedSharedArrayBufferIssueDetailsView extends AffectedResourcesView {
|
|
58
|
-
|
|
59
|
-
return i18nString(UIStrings.nViolations, {n: count});
|
|
60
|
-
}
|
|
138
|
+
readonly #view: View;
|
|
61
139
|
|
|
62
|
-
|
|
63
|
-
|
|
64
|
-
|
|
65
|
-
|
|
66
|
-
status.textContent = i18nString(UIStrings.warning);
|
|
67
|
-
} else {
|
|
68
|
-
status.classList.add('affected-resource-blocked-status');
|
|
69
|
-
status.textContent = i18nString(UIStrings.blocked);
|
|
70
|
-
}
|
|
71
|
-
element.appendChild(status);
|
|
140
|
+
constructor(parent: IssueView, issue: IssuesManager.IssueAggregator.AggregatedIssue, jslogContext: string,
|
|
141
|
+
view: View = DEFAULT_VIEW) {
|
|
142
|
+
super(parent, issue, jslogContext);
|
|
143
|
+
this.#view = view;
|
|
72
144
|
}
|
|
73
145
|
|
|
74
|
-
|
|
75
|
-
|
|
76
|
-
switch (type) {
|
|
77
|
-
case Protocol.Audits.SharedArrayBufferIssueType.CreationIssue:
|
|
78
|
-
status.textContent = i18nString(UIStrings.instantiation);
|
|
79
|
-
status.title = i18nString(UIStrings.aSharedarraybufferWas);
|
|
80
|
-
break;
|
|
81
|
-
case Protocol.Audits.SharedArrayBufferIssueType.TransferIssue:
|
|
82
|
-
status.textContent = i18nString(UIStrings.transfer);
|
|
83
|
-
status.title = i18nString(UIStrings.sharedarraybufferWasTransferedTo);
|
|
84
|
-
break;
|
|
85
|
-
}
|
|
86
|
-
element.appendChild(status);
|
|
146
|
+
protected getResourceNameWithCount(count: number): Platform.UIString.LocalizedString {
|
|
147
|
+
return i18nString(UIStrings.nViolations, {n: count});
|
|
87
148
|
}
|
|
88
149
|
|
|
89
150
|
#appendDetails(sabIssues: Iterable<IssuesManager.SharedArrayBufferIssue.SharedArrayBufferIssue>): void {
|
|
90
|
-
const
|
|
91
|
-
this.appendColumnTitle(header, i18nString(UIStrings.sourceLocation));
|
|
92
|
-
this.appendColumnTitle(header, i18nString(UIStrings.trigger));
|
|
93
|
-
this.appendColumnTitle(header, i18nString(UIStrings.status));
|
|
94
|
-
|
|
95
|
-
this.affectedResources.appendChild(header);
|
|
96
|
-
let count = 0;
|
|
151
|
+
const rows: SharedArrayBufferRow[] = [];
|
|
97
152
|
for (const sabIssue of sabIssues) {
|
|
98
|
-
|
|
99
|
-
this.#appendDetail(sabIssue);
|
|
153
|
+
rows.push(this.#createDetailRow(sabIssue));
|
|
100
154
|
}
|
|
101
|
-
this.
|
|
155
|
+
this.#view({rows}, undefined, this.affectedResources);
|
|
156
|
+
this.updateAffectedResourceCount(rows.length);
|
|
102
157
|
}
|
|
103
158
|
|
|
104
|
-
#
|
|
105
|
-
const element = document.createElement('tr');
|
|
106
|
-
element.classList.add('affected-resource-directive');
|
|
107
|
-
|
|
159
|
+
#createDetailRow(sabIssue: IssuesManager.SharedArrayBufferIssue.SharedArrayBufferIssue): SharedArrayBufferRow {
|
|
108
160
|
const sabIssueDetails = sabIssue.details();
|
|
109
161
|
const location = IssuesManager.Issue.toZeroBasedLocation(sabIssueDetails.sourceCodeLocation);
|
|
110
|
-
|
|
111
|
-
|
|
112
|
-
|
|
113
|
-
|
|
114
|
-
|
|
162
|
+
let sourceLocation: SourceLocationData|undefined;
|
|
163
|
+
if (location) {
|
|
164
|
+
sourceLocation = {
|
|
165
|
+
target: sabIssue.model()?.getTargetIfNotDisposed() || null,
|
|
166
|
+
scriptId: location.scriptId || null,
|
|
167
|
+
url: location.url as Platform.DevToolsPath.UrlString,
|
|
168
|
+
lineNumber: location.lineNumber,
|
|
169
|
+
columnNumber: location.columnNumber,
|
|
170
|
+
};
|
|
171
|
+
}
|
|
172
|
+
let triggerText: Platform.UIString.LocalizedString;
|
|
173
|
+
let triggerTitle: Platform.UIString.LocalizedString;
|
|
174
|
+
switch (sabIssueDetails.type) {
|
|
175
|
+
case Protocol.Audits.SharedArrayBufferIssueType.CreationIssue:
|
|
176
|
+
triggerText = i18nString(UIStrings.instantiation);
|
|
177
|
+
triggerTitle = i18nString(UIStrings.aSharedarraybufferWas);
|
|
178
|
+
break;
|
|
179
|
+
case Protocol.Audits.SharedArrayBufferIssueType.TransferIssue:
|
|
180
|
+
triggerText = i18nString(UIStrings.transfer);
|
|
181
|
+
triggerTitle = i18nString(UIStrings.sharedarraybufferWasTransferedTo);
|
|
182
|
+
break;
|
|
183
|
+
default:
|
|
184
|
+
Platform.assertNever(sabIssueDetails.type, `Unhandled issue type: ${sabIssueDetails.type}`);
|
|
185
|
+
}
|
|
186
|
+
return {
|
|
187
|
+
sourceLocation,
|
|
188
|
+
triggerText,
|
|
189
|
+
triggerTitle,
|
|
190
|
+
isWarning: sabIssueDetails.isWarning,
|
|
191
|
+
};
|
|
115
192
|
}
|
|
116
193
|
|
|
117
194
|
update(): void {
|
|
118
|
-
this.clear();
|
|
195
|
+
this.requestResolver.clear();
|
|
119
196
|
this.#appendDetails(this.issue.getSharedArrayBufferIssues());
|
|
120
197
|
}
|
|
121
198
|
}
|
|
@@ -1,19 +1,49 @@
|
|
|
1
1
|
// Copyright 2021 The Chromium Authors
|
|
2
2
|
// Use of this source code is governed by a BSD-style license that can be
|
|
3
3
|
// found in the LICENSE file.
|
|
4
|
-
/* eslint-disable @devtools/no-imperative-dom-api */
|
|
5
4
|
|
|
6
5
|
import * as i18n from '../../core/i18n/i18n.js';
|
|
7
6
|
import type * as Platform from '../../core/platform/platform.js';
|
|
8
7
|
import type * as Protocol from '../../generated/protocol.js';
|
|
8
|
+
import type * as IssuesManager from '../../models/issues_manager/issues_manager.js';
|
|
9
9
|
import * as Components from '../../ui/legacy/components/utils/utils.js';
|
|
10
|
-
import
|
|
10
|
+
import {html, render} from '../../ui/lit/lit.js';
|
|
11
11
|
|
|
12
12
|
import {AffectedResourcesView} from './AffectedResourcesView.js';
|
|
13
|
+
import type {IssueView} from './IssueView.js';
|
|
14
|
+
|
|
15
|
+
export interface ViewInput {
|
|
16
|
+
sources: Protocol.Audits.SourceCodeLocation[];
|
|
17
|
+
}
|
|
18
|
+
|
|
19
|
+
export type View = (input: ViewInput, _output: undefined, target: HTMLElement) => void;
|
|
20
|
+
|
|
21
|
+
export const DEFAULT_VIEW: View = (input, _output, target) => {
|
|
22
|
+
// clang-format off
|
|
23
|
+
render(html`
|
|
24
|
+
${input.sources.map(source => html`
|
|
25
|
+
<tr class="affected-resource-source">
|
|
26
|
+
<td>
|
|
27
|
+
${Components.Linkifier.Linkifier.renderLinkifiedUrl(
|
|
28
|
+
source.url as Platform.DevToolsPath.UrlString,
|
|
29
|
+
{
|
|
30
|
+
columnNumber: source.columnNumber,
|
|
31
|
+
lineNumber: source.lineNumber,
|
|
32
|
+
tabStop: true,
|
|
33
|
+
showColumnNumber: false,
|
|
34
|
+
jslogContext: 'source-location',
|
|
35
|
+
})}
|
|
36
|
+
</td>
|
|
37
|
+
</tr>
|
|
38
|
+
`)}
|
|
39
|
+
`, target);
|
|
40
|
+
// clang-format on
|
|
41
|
+
};
|
|
13
42
|
|
|
14
43
|
const UIStrings = {
|
|
15
44
|
/**
|
|
16
|
-
* @description Label in the Issues panel for the number of affected source
|
|
45
|
+
* @description Label in the Issues panel for the number of affected source
|
|
46
|
+
* code locations.
|
|
17
47
|
*/
|
|
18
48
|
nSources: '{n, plural, =1 {# source} other {# sources}}',
|
|
19
49
|
} as const;
|
|
@@ -22,40 +52,31 @@ const str_ = i18n.i18n.registerUIStrings('panels/issues/AffectedSourcesView.ts',
|
|
|
22
52
|
const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
|
|
23
53
|
|
|
24
54
|
export class AffectedSourcesView extends AffectedResourcesView {
|
|
55
|
+
readonly #view: View;
|
|
56
|
+
|
|
57
|
+
constructor(parent: IssueView, issue: IssuesManager.IssueAggregator.AggregatedIssue, jslogContext: string,
|
|
58
|
+
view: View = DEFAULT_VIEW) {
|
|
59
|
+
super(parent, issue, jslogContext);
|
|
60
|
+
this.#view = view;
|
|
61
|
+
}
|
|
62
|
+
|
|
25
63
|
#appendAffectedSources(affectedSources: Iterable<Protocol.Audits.SourceCodeLocation>): void {
|
|
26
|
-
|
|
27
|
-
|
|
28
|
-
|
|
29
|
-
count++;
|
|
30
|
-
}
|
|
31
|
-
this.updateAffectedResourceCount(count);
|
|
64
|
+
const sources = Array.from(affectedSources);
|
|
65
|
+
this.#view({sources}, undefined, this.affectedResources);
|
|
66
|
+
this.updateAffectedResourceCount(sources.length);
|
|
32
67
|
}
|
|
33
68
|
|
|
34
69
|
protected getResourceNameWithCount(count: number): Platform.UIString.LocalizedString {
|
|
35
70
|
return i18nString(UIStrings.nSources, {n: count});
|
|
36
71
|
}
|
|
37
72
|
|
|
38
|
-
|
|
39
|
-
|
|
40
|
-
|
|
41
|
-
// to support source maps and formatted scripts.
|
|
42
|
-
const linkifierURLOptions = {columnNumber, lineNumber, tabStop: true, showColumnNumber: false};
|
|
43
|
-
// An element created with linkifyURL can subscribe to the events
|
|
44
|
-
// 'click' neither 'keydown' if that key is the 'Enter' key.
|
|
45
|
-
// Also, this element has a context menu, so we should be able to
|
|
46
|
-
// track when the user use the context menu too.
|
|
47
|
-
const anchorElement =
|
|
48
|
-
Components.Linkifier.Linkifier.linkifyURL(url as Platform.DevToolsPath.UrlString, linkifierURLOptions);
|
|
49
|
-
anchorElement.setAttribute('jslog', `${VisualLogging.link('source-location').track({click: true})}`);
|
|
50
|
-
cellElement.appendChild(anchorElement);
|
|
51
|
-
const rowElement = document.createElement('tr');
|
|
52
|
-
rowElement.classList.add('affected-resource-source');
|
|
53
|
-
rowElement.appendChild(cellElement);
|
|
54
|
-
this.affectedResources.appendChild(rowElement);
|
|
73
|
+
override clear(): void {
|
|
74
|
+
this.requestResolver.clear();
|
|
75
|
+
this.#view({sources: []}, undefined, this.affectedResources);
|
|
55
76
|
}
|
|
56
77
|
|
|
57
|
-
update(): void {
|
|
58
|
-
this.clear();
|
|
78
|
+
override update(): void {
|
|
79
|
+
this.requestResolver.clear();
|
|
59
80
|
this.#appendAffectedSources(this.issue.sources());
|
|
60
81
|
}
|
|
61
82
|
}
|
|
@@ -20,10 +20,9 @@ const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
|
|
|
20
20
|
export interface ViewInput {
|
|
21
21
|
trackingSites: readonly string[];
|
|
22
22
|
}
|
|
23
|
-
export type
|
|
24
|
-
export type View = (input: ViewInput, output: ViewOutput, target: HTMLElement) => void;
|
|
23
|
+
export type View = (input: ViewInput, output: undefined, target: HTMLElement) => void;
|
|
25
24
|
|
|
26
|
-
export function defaultView(input: ViewInput, output:
|
|
25
|
+
export function defaultView(input: ViewInput, output: undefined, target: HTMLElement): void {
|
|
27
26
|
render(html`
|
|
28
27
|
<tbody>
|
|
29
28
|
${input.trackingSites.map(site => html`
|
|
@@ -45,7 +44,7 @@ export class AffectedTrackingSitesView extends AffectedResourcesView {
|
|
|
45
44
|
|
|
46
45
|
override update(): void {
|
|
47
46
|
const trackingSites = Array.from(this.issue.getBounceTrackingSites());
|
|
48
|
-
this.#view({trackingSites},
|
|
47
|
+
this.#view({trackingSites}, undefined, this.affectedResources);
|
|
49
48
|
this.updateAffectedResourceCount(trackingSites.length);
|
|
50
49
|
}
|
|
51
50
|
}
|