chrome-devtools-frontend 1.0.1726686 → 1.0.1730971
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/.agents/rules/tests/test-strict-assertions-and-literal-expectations.md +1 -1
- package/.agents/rules/tests/test-view-and-presenter-isolation.md +1 -1
- package/.agents/rules/ui-and-widgets/ui-accessibility-and-semantic-html.md +1 -1
- package/.agents/rules/ui-and-widgets/ui-css-scoping-and-flex-layout.md +2 -2
- package/.agents/rules/ui-and-widgets/ui-declarative-child-widget-composition.md +5 -5
- package/.agents/rules/ui-and-widgets/ui-lit-declarative-templates-and-directives.md +2 -2
- package/.agents/rules/ui-and-widgets/ui-localization-and-uistrings-hygiene.md +2 -2
- package/.agents/rules/ui-and-widgets/ui-modern-component-and-encapsulation-standards.md +3 -3
- package/.agents/rules/ui-and-widgets/ui-pure-view-and-presenter-separation.md +2 -2
- package/.agents/rules/ui-and-widgets/ui-reactive-widget-update-lifecycle.md +2 -2
- package/.agents/rules/ui-and-widgets/ui-view-output-and-callback-contracts.md +2 -2
- package/.agents/rules/ui-and-widgets/ui-widget-dom-and-listener-lifecycle.md +2 -2
- package/.agents/skills/code-review/SKILL.md +63 -12
- package/.agents/skills/ui-eng-vision-local-lit-renderer/SKILL.md +38 -10
- package/.agents/skills/ui-eng-vision-widget-promoter/SKILL.md +1 -0
- package/.agents/skills/ui-widgets/SKILL.md +8 -2
- package/.agents/skills/write-ai-eval-test/SKILL.md +106 -0
- package/AUTHORS +2 -0
- package/DIR_METADATA +1 -2
- package/README.md +48 -26
- package/config/typescript/tsconfig.base.json +1 -0
- package/config/typescript/tsconfig.eslint.json +1 -0
- package/docs/contributing/changes.md +25 -0
- package/docs/ui_engineering.md +13 -4
- package/eslint.config.mjs +323 -41
- package/front_end/core/common/Color.ts +7 -7
- package/front_end/core/common/ParsedURL.ts +3 -3
- package/front_end/core/common/ResolverBase.ts +3 -3
- package/front_end/core/common/SegmentedRange.ts +3 -3
- package/front_end/core/common/SimpleHistoryManager.ts +14 -14
- package/front_end/core/common/Trie.ts +3 -3
- package/front_end/core/common/VersionController.ts +7 -7
- package/front_end/core/host/InspectorFrontendHost.ts +2 -2
- package/front_end/core/host/InspectorFrontendHostAPI.ts +9 -1
- package/front_end/core/host/InspectorFrontendHostStub.ts +1 -1
- package/front_end/core/host/UserMetrics.ts +4 -0
- package/front_end/core/host/UserMetricsEnums.ts +2 -1
- package/front_end/core/platform/StringUtilities.ts +54 -13
- package/front_end/core/platform/node/HostRuntime.ts +13 -7
- package/front_end/core/protocol_client/DevToolsCDPConnection.ts +4 -5
- package/front_end/core/root/Runtime.ts +5 -0
- package/front_end/core/sdk/AccessibilityModel.ts +5 -5
- package/front_end/core/sdk/AnimationModel.ts +17 -19
- package/front_end/core/sdk/CPUProfilerModel.ts +3 -3
- package/front_end/core/sdk/CPUThrottlingManager.ts +7 -0
- package/front_end/core/sdk/CSSMatchedStyles.ts +73 -13
- package/front_end/core/sdk/CSSMetadata.ts +7 -7
- package/front_end/core/sdk/CSSModel.ts +33 -33
- package/front_end/core/sdk/CSSProperty.ts +5 -5
- package/front_end/core/sdk/CSSRule.ts +6 -6
- package/front_end/core/sdk/CSSStyleSheetHeader.ts +4 -4
- package/front_end/core/sdk/Connections.ts +16 -16
- package/front_end/core/sdk/ConsoleModel.ts +44 -47
- package/front_end/core/sdk/CookieParser.ts +11 -11
- package/front_end/core/sdk/EmulationModel.ts +35 -36
- package/front_end/core/sdk/EventBreakpointsModel.ts +11 -11
- package/front_end/core/sdk/FrameManager.ts +16 -16
- package/front_end/core/sdk/IsolateManager.ts +2 -2
- package/front_end/core/sdk/IssuesModel.ts +2 -2
- package/front_end/core/sdk/OverlayModel.ts +19 -19
- package/front_end/core/sdk/PageResourceLoader.ts +14 -16
- package/front_end/core/sdk/RemoteObject.ts +9 -9
- package/front_end/core/sdk/Resource.ts +2 -2
- package/front_end/core/sdk/RuntimeModel.ts +7 -7
- package/front_end/core/sdk/Script.ts +6 -6
- package/front_end/core/sdk/ServiceWorkerManager.ts +36 -10
- package/front_end/core/sdk/SourceMap.ts +18 -20
- package/front_end/core/sdk/SourceMapManager.ts +2 -2
- package/front_end/core/sdk/TargetManager.ts +2 -2
- package/front_end/devtools_compatibility.js +7 -3
- package/front_end/entrypoints/inspector_main/InspectorMain.ts +2 -2
- package/front_end/entrypoints/node_app/app/NodeConnectionsPanel.ts +203 -115
- package/front_end/generated/InspectorBackendCommands.ts +1 -1
- package/front_end/generated/SupportedCSSProperties.ts +1 -3
- package/front_end/generated/protocol.ts +1 -0
- package/front_end/models/ai_assistance/AiAgent2.ts +36 -12
- package/front_end/models/ai_assistance/AiConversation.ts +8 -2
- package/front_end/models/ai_assistance/agents/AiAgent.ts +137 -62
- package/front_end/models/ai_assistance/agents/ExecuteJavascript.ts +2 -2
- package/front_end/models/ai_assistance/agents/StylingAgent.snapshot.txt +2 -2
- package/front_end/models/ai_assistance/data_formatters/LighthouseFormatter.snapshot.txt +149 -2
- package/front_end/models/ai_assistance/data_formatters/LighthouseFormatter.ts +269 -42
- package/front_end/models/ai_assistance/tools/ExecuteJavaScript.ts +3 -0
- package/front_end/models/ai_assistance/tools/GetLighthouseAudits.ts +9 -0
- package/front_end/models/ai_assistance/tools/ResolveDevtoolsNodePath.ts +13 -2
- package/front_end/models/ai_assistance/tools/RunLighthouse.ts +23 -7
- package/front_end/models/ai_assistance/tools/Tool.ts +7 -5
- package/front_end/models/bindings/CSSWorkspaceBinding.ts +22 -24
- package/front_end/models/bindings/DebuggerLanguagePlugins.ts +60 -60
- package/front_end/models/bindings/DebuggerWorkspaceBinding.ts +24 -24
- package/front_end/models/bindings/DefaultScriptMapping.ts +8 -8
- package/front_end/models/bindings/FileUtils.ts +13 -13
- package/front_end/models/bindings/PresentationConsoleMessageHelper.ts +3 -3
- package/front_end/models/bindings/ResourceScriptMapping.ts +23 -23
- package/front_end/models/comment_manager/CommentManager.ts +3 -3
- package/front_end/models/comment_manager/CommentThread.ts +50 -5
- package/front_end/models/cpu_profile/CPUProfileDataModel.ts +14 -14
- package/front_end/models/cpu_profile/ProfileTreeModel.ts +4 -4
- package/front_end/models/elements/StyleChanges.ts +38 -0
- package/front_end/models/emulation/EmulatedDevices.ts +12 -12
- package/front_end/models/har/HARFormat.ts +4 -4
- package/front_end/models/javascript_metadata/NativeFunctions.ts +5 -1
- package/front_end/models/lighthouse/LighthouseReporterTypes.ts +57 -3
- package/front_end/models/lighthouse/RunTypes.ts +9 -1
- package/front_end/models/logs/LogManager.ts +2 -2
- package/front_end/models/persistence/AutomaticFileSystemManager.ts +3 -0
- package/front_end/models/persistence/FileSystemWorkspaceBinding.ts +24 -24
- package/front_end/models/persistence/IsolatedFileSystemManager.ts +6 -0
- package/front_end/models/persistence/NetworkPersistenceManager.ts +8 -3
- package/front_end/models/trace/LanternComputationData.ts +37 -11
- package/front_end/models/trace/Processor.ts +2 -1
- package/front_end/models/trace/extras/TraceTree.ts +36 -10
- package/front_end/models/trace/handlers/InitiatorsHandler.ts +27 -34
- package/front_end/models/trace/handlers/LayoutShiftsHandler.ts +2 -6
- package/front_end/models/trace/handlers/SamplesHandler.ts +9 -6
- package/front_end/models/workspace/FileManager.ts +6 -0
- package/front_end/panels/accessibility/ARIAAttributesView.ts +4 -4
- package/front_end/panels/accessibility/AccessibilityAnnouncementRecordingView.ts +8 -1
- package/front_end/panels/accessibility/AccessibilityNodeView.ts +15 -17
- package/front_end/panels/accessibility/AccessibilitySubPane.ts +1 -1
- package/front_end/panels/ai_assistance/AiAssistancePanel.ts +5 -5
- package/front_end/panels/ai_assistance/ExternalHandler.ts +10 -1
- package/front_end/panels/ai_assistance/components/ChatMessage.ts +27 -22
- package/front_end/panels/ai_assistance/components/DisabledWidget.ts +19 -23
- package/front_end/panels/ai_assistance/components/ExploreWidget.ts +2 -2
- package/front_end/panels/ai_assistance/components/PermissionPrompt.ts +23 -9
- package/front_end/panels/ai_assistance/components/chatInput.css +1 -1
- package/front_end/panels/animation/AnimationTimeline.ts +37 -17
- package/front_end/panels/animation/animationTimeline.css +19 -3
- package/front_end/panels/application/AppManifestView.ts +1 -2
- package/front_end/panels/application/ApplicationPanelSidebar.ts +143 -128
- package/front_end/panels/application/DOMStorageItemsView.ts +14 -14
- package/front_end/panels/application/DeviceBoundSessionsView.ts +10 -13
- package/front_end/panels/application/ExtensionStorageItemsView.ts +3 -4
- package/front_end/panels/application/IndexedDBViews.ts +8 -4
- package/front_end/panels/application/KeyValueStorageItemsView.ts +4 -5
- package/front_end/panels/application/PrivateVerificationTokensView.ts +53 -0
- package/front_end/panels/application/ServiceWorkerCacheViews.ts +12 -8
- package/front_end/panels/application/ServiceWorkersView.ts +1 -2
- package/front_end/panels/application/StorageItemsToolbar.ts +3 -3
- package/front_end/panels/application/StorageView.ts +2 -2
- package/front_end/panels/application/WebMCPView.ts +91 -109
- package/front_end/panels/application/application.ts +2 -0
- package/front_end/panels/application/components/StorageMetadataView.ts +6 -6
- package/front_end/panels/application/preloading/PreloadingView.ts +70 -37
- package/front_end/panels/application/preloading/components/MismatchedPreloadingGrid.ts +2 -2
- package/front_end/panels/application/preloading/components/PreloadingDisabledInfobar.ts +3 -3
- package/front_end/panels/application/preloading/components/PreloadingGrid.ts +12 -0
- package/front_end/panels/application/preloading/components/RuleSetDetailsView.ts +10 -11
- package/front_end/panels/application/privateVerificationTokensView.css +20 -0
- package/front_end/panels/application/serviceWorkersView.css +2 -2
- package/front_end/panels/browser_debugger/DOMBreakpointsSidebarPane.ts +24 -24
- package/front_end/panels/changes/ChangesSidebar.ts +5 -5
- package/front_end/panels/changes/ChangesView.ts +10 -11
- package/front_end/panels/comments/CommentsPane.ts +292 -102
- package/front_end/panels/comments/commentsPane.css +93 -12
- package/front_end/panels/common/CommentThreadWidget.ts +69 -0
- package/front_end/panels/common/CommentsOverlayWidget.ts +108 -29
- package/front_end/panels/common/CommentsStatusBarPill.ts +17 -6
- package/front_end/panels/common/DOMLinkifier.ts +37 -12
- package/front_end/panels/common/ExtensionPanel.ts +13 -4
- package/front_end/panels/common/ExtensionServer.ts +27 -3
- package/front_end/panels/common/PersistenceUtils.ts +3 -3
- package/front_end/panels/common/commentThreadWidget.css +25 -1
- package/front_end/panels/common/common-meta.ts +10 -0
- package/front_end/panels/console/ConsolePinPane.ts +13 -15
- package/front_end/panels/console/ConsolePrompt.ts +173 -95
- package/front_end/panels/console/ConsoleSidebar.ts +2 -2
- package/front_end/panels/console/ConsoleView.ts +75 -79
- package/front_end/panels/console/ConsoleViewMessage.ts +52 -4
- package/front_end/panels/console/SymbolizedErrorWidget.ts +8 -4
- package/front_end/panels/console/consolePrompt.css +1 -1
- package/front_end/panels/console/consoleView.css +1 -1
- package/front_end/panels/console_counters/WarningErrorCounter.ts +3 -4
- package/front_end/panels/coverage/CoverageListView.ts +2 -2
- package/front_end/panels/coverage/CoverageView.ts +20 -5
- package/front_end/panels/css_overview/CSSOverviewCompletedView.ts +4 -3
- package/front_end/panels/css_overview/CSSOverviewPanel.ts +2 -2
- package/front_end/panels/css_overview/CSSOverviewProcessingView.ts +2 -2
- package/front_end/panels/css_overview/CSSOverviewSidebarPanel.ts +2 -2
- package/front_end/panels/css_overview/CSSOverviewStartView.ts +2 -2
- package/front_end/panels/css_overview/CSSOverviewUnusedDeclarations.ts +8 -8
- package/front_end/panels/developer_resources/DeveloperResourcesListView.ts +2 -3
- package/front_end/panels/developer_resources/DeveloperResourcesView.ts +4 -5
- package/front_end/panels/elements/AccessibilityTreeUtils.ts +6 -7
- package/front_end/panels/elements/CSSValueTraceView.ts +3 -3
- package/front_end/panels/elements/ClassesPaneWidget.ts +1 -2
- package/front_end/panels/elements/ComputedStyleWidget.ts +15 -14
- package/front_end/panels/elements/DOMTreeElementWidget.ts +5 -4
- package/front_end/panels/elements/DOMTreeWidget.ts +2 -1
- package/front_end/panels/elements/ElementStatePaneWidget.ts +2 -2
- package/front_end/panels/elements/ElementsPanel.ts +1 -0
- package/front_end/panels/elements/EventListenersWidget.ts +2 -2
- package/front_end/panels/elements/LayoutPane.ts +2 -2
- package/front_end/panels/elements/PlatformFontsWidget.ts +3 -3
- package/front_end/panels/elements/PropertiesWidget.ts +9 -10
- package/front_end/panels/elements/PropertyRenderer.ts +72 -11
- package/front_end/panels/elements/StandaloneStylesContainer.ts +5 -10
- package/front_end/panels/elements/StyleEditorWidget.ts +30 -16
- package/front_end/panels/elements/StylePropertiesSection.ts +93 -44
- package/front_end/panels/elements/StylePropertyTreeElement.ts +230 -302
- package/front_end/panels/elements/StylesContainer.ts +2 -3
- package/front_end/panels/elements/StylesSidebarPane.ts +4 -13
- package/front_end/panels/elements/components/AccessibilityTreeNode.ts +66 -37
- package/front_end/panels/elements/components/CSSHintDetailsView.ts +51 -41
- package/front_end/panels/elements/components/CSSPropertyDocsView.ts +75 -65
- package/front_end/panels/elements/components/CSSQuery.ts +112 -74
- package/front_end/panels/elements/components/CSSVariableValueView.ts +109 -68
- package/front_end/panels/elements/components/ComputedStyleProperty.ts +64 -45
- package/front_end/panels/elements/components/ElementsTreeExpandButton.ts +35 -28
- package/front_end/panels/elements/components/QueryContainer.ts +104 -74
- package/front_end/panels/elements/components/accessibilityTreeNode.css +22 -20
- package/front_end/panels/elements/components/computedStyleProperty.css +2 -0
- package/front_end/panels/elements/components/cssHintDetailsView.css +23 -21
- package/front_end/panels/elements/components/cssPropertyDocsView.css +38 -36
- package/front_end/panels/elements/components/cssVariableValueView.css +42 -40
- package/front_end/panels/elements/components/elementsTreeExpandButton.css +5 -2
- package/front_end/panels/elements/components/queryContainer.css +23 -21
- package/front_end/panels/elements/stylesSidebarPane.css +3 -3
- package/front_end/panels/emulation/DeviceModeToolbar.ts +2 -2
- package/front_end/panels/emulation/InspectedPagePlaceholder.ts +2 -2
- package/front_end/panels/emulation/MediaQueryInspector.ts +9 -10
- package/front_end/panels/emulation/mediaQueryInspector.css +1 -1
- package/front_end/panels/event_listeners/EventListenersView.ts +2 -2
- package/front_end/panels/issues/AffectedCookiesView.ts +144 -101
- package/front_end/panels/issues/AffectedDescendantsWithinSelectElementView.ts +83 -31
- package/front_end/panels/issues/AffectedDirectivesView.ts +218 -135
- package/front_end/panels/issues/AffectedDocumentsInQuirksModeView.ts +84 -34
- package/front_end/panels/issues/AffectedElementsView.ts +86 -23
- package/front_end/panels/issues/AffectedLazyLoadImagesView.ts +2 -2
- package/front_end/panels/issues/AffectedMetadataAllowedSitesView.ts +2 -2
- package/front_end/panels/issues/AffectedPartitioningBlobURLView.ts +36 -11
- package/front_end/panels/issues/AffectedSharedArrayBufferIssueDetailsView.ts +135 -58
- package/front_end/panels/issues/AffectedSourcesView.ts +49 -28
- package/front_end/panels/issues/AffectedTrackingSitesView.ts +3 -4
- package/front_end/panels/issues/CorsIssueDetailsView.ts +490 -269
- package/front_end/panels/issues/GenericIssueDetailsView.ts +2 -2
- package/front_end/panels/issues/IssueKindView.ts +63 -48
- package/front_end/panels/issues/IssueView.ts +14 -18
- package/front_end/panels/issues/components/ElementsPanelLink.ts +70 -34
- package/front_end/panels/issues/components/HideIssuesMenu.ts +56 -32
- package/front_end/panels/issues/components/elementsPanelLink.css +10 -6
- package/front_end/panels/issues/components/hideIssuesMenu.css +16 -14
- package/front_end/panels/issues/issues.ts +2 -0
- package/front_end/panels/issues/issuesTree.css +4 -4
- package/front_end/panels/lighthouse/LighthouseController.ts +6 -6
- package/front_end/panels/lighthouse/LighthouseStatusView.ts +12 -13
- package/front_end/panels/lighthouse/lighthouseStartView.css +1 -1
- package/front_end/panels/linear_memory_inspector/LinearMemoryInspectorPane.ts +159 -161
- package/front_end/panels/linear_memory_inspector/LinearMemoryInspectorView.ts +228 -0
- package/front_end/panels/linear_memory_inspector/components/LinearMemoryInspector.ts +32 -41
- package/front_end/panels/linear_memory_inspector/components/linearMemoryHighlightChipList.css +2 -2
- package/front_end/panels/linear_memory_inspector/linear_memory_inspector.ts +2 -0
- package/front_end/panels/media/EventDisplayTable.ts +2 -2
- package/front_end/panels/media/MainView.ts +132 -66
- package/front_end/panels/media/PlayerDetailView.ts +32 -14
- package/front_end/panels/media/PlayerListView.ts +83 -23
- package/front_end/panels/media/PlayerPropertiesView.ts +2 -2
- package/front_end/panels/media/TickingFlameChart.ts +153 -63
- package/front_end/panels/mobile_throttling/NetworkThrottlingSelector.ts +2 -2
- package/front_end/panels/mobile_throttling/ThrottlingSettingsTab.ts +615 -464
- package/front_end/panels/mobile_throttling/throttlingSettingsTab.css +43 -0
- package/front_end/panels/network/EventSourceMessagesView.ts +3 -3
- package/front_end/panels/network/NetworkConfigView.ts +6 -2
- package/front_end/panels/network/NetworkDataGridNode.ts +2 -1
- package/front_end/panels/network/NetworkItemView.ts +27 -26
- package/front_end/panels/network/NetworkManageCustomHeadersView.ts +236 -97
- package/front_end/panels/network/NetworkOverview.ts +8 -10
- package/front_end/panels/network/RequestConditionsDrawer.ts +8 -4
- package/front_end/panels/network/RequestDeviceBoundSessionsView.ts +2 -4
- package/front_end/panels/network/RequestHTMLView.ts +26 -7
- package/front_end/panels/network/RequestHeadersView.ts +2 -2
- package/front_end/panels/network/RequestInitiatorView.ts +21 -22
- package/front_end/panels/network/RequestPayloadView.ts +2 -16
- package/front_end/panels/network/RequestPreviewView.ts +5 -5
- package/front_end/panels/network/RequestTimingView.ts +6 -6
- package/front_end/panels/network/ResourceDirectSocketChunkView.ts +5 -6
- package/front_end/panels/network/ResourceWebSocketFrameView.ts +4 -3
- package/front_end/panels/network/ShowMoreDetailsWidget.ts +11 -12
- package/front_end/panels/network/SignedExchangeInfoView.ts +2 -2
- package/front_end/panels/network/networkLogView.css +2 -2
- package/front_end/panels/network/networkManageCustomHeadersView.css +27 -6
- package/front_end/panels/network/requestConditionsDrawer.css +1 -1
- package/front_end/panels/network/requestInitiatorView.css +5 -3
- package/front_end/panels/performance_monitor/PerformanceMonitor.ts +2 -2
- package/front_end/panels/profiler/HeapDetachedElementsView.ts +1 -2
- package/front_end/panels/profiler/HeapTimelineOverview.ts +77 -15
- package/front_end/panels/profiler/IsolateSelector.ts +258 -187
- package/front_end/panels/profiler/ProfileLauncherView.ts +7 -29
- package/front_end/panels/profiler/profileLauncherView.css +6 -1
- package/front_end/panels/protocol_monitor/JSONEditor.ts +4 -5
- package/front_end/panels/recorder/ControlButton.ts +1 -1
- package/front_end/panels/recorder/RecordingListView.ts +2 -4
- package/front_end/panels/recorder/RecordingView.ts +1 -2
- package/front_end/panels/recorder/SelectorPicker.ts +2 -4
- package/front_end/panels/recorder/StepView.ts +24 -10
- package/front_end/panels/recorder/TimelineSection.ts +1 -1
- package/front_end/panels/recorder/recordingView.css +1 -1
- package/front_end/panels/screencast/ScreencastApp.ts +1 -1
- package/front_end/panels/search/SearchResultsPane.ts +11 -12
- package/front_end/panels/search/SearchView.ts +8 -10
- package/front_end/panels/security/SecurityPanel.ts +1 -8
- package/front_end/panels/security/SecurityPanelSidebar.ts +2 -2
- package/front_end/panels/security/mainView.css +1 -1
- package/front_end/panels/sensors/LocationsSettingsTab.ts +1 -2
- package/front_end/panels/settings/AISettingsTab.ts +1 -1
- package/front_end/panels/settings/BackendLinkingSettingsTab.ts +34 -20
- package/front_end/panels/settings/EditFileSystemView.ts +2 -2
- package/front_end/panels/settings/FrameworkIgnoreListSettingsTab.ts +375 -197
- package/front_end/panels/settings/KeybindsSettingsTab.ts +570 -414
- package/front_end/panels/settings/SettingsScreen.ts +312 -114
- package/front_end/panels/settings/WorkspaceSettingsTab.ts +2 -2
- package/front_end/panels/settings/aiSettingsTab.css +1 -4
- package/front_end/panels/settings/emulation/DevicesSettingsTab.ts +924 -578
- package/front_end/panels/settings/emulation/components/UserAgentClientHintsForm.ts +9 -2
- package/front_end/panels/settings/emulation/devicesSettingsTab.css +39 -0
- package/front_end/panels/settings/frameworkIgnoreListSettingsTab.css +37 -8
- package/front_end/panels/settings/settingsScreen.css +0 -24
- package/front_end/panels/sources/BreakpointEditDialog.ts +9 -6
- package/front_end/panels/sources/BreakpointsView.ts +25 -4
- package/front_end/panels/sources/CallStackSidebarPane.ts +7 -1
- package/front_end/panels/sources/DebuggerPlugin.ts +1 -0
- package/front_end/panels/sources/GoToLineQuickOpen.ts +8 -8
- package/front_end/panels/sources/NavigatorView.ts +521 -439
- package/front_end/panels/sources/PersistenceActions.ts +11 -12
- package/front_end/panels/sources/ProfilePlugin.ts +28 -17
- package/front_end/panels/sources/ScopeChainSidebarPane.ts +3 -4
- package/front_end/panels/sources/SourcesNavigator.ts +9 -9
- package/front_end/panels/sources/SourcesPanel.ts +2 -2
- package/front_end/panels/sources/SourcesView.ts +3 -3
- package/front_end/panels/sources/ThreadsSidebarPane.ts +2 -2
- package/front_end/panels/sources/WatchExpressionsSidebarPane.ts +2 -2
- package/front_end/panels/sources/components/HeadersView.ts +1 -2
- package/front_end/panels/timeline/CompatibilityTracksAppender.ts +5 -6
- package/front_end/panels/timeline/EventsTimelineTreeView.ts +73 -34
- package/front_end/panels/timeline/IsolateSelector.ts +25 -37
- package/front_end/panels/timeline/StatusDialog.ts +5 -7
- package/front_end/panels/timeline/ThirdPartyTreeView.ts +10 -13
- package/front_end/panels/timeline/TimelineDetailsView.ts +40 -21
- package/front_end/panels/timeline/TimelineEventOverview.ts +130 -34
- package/front_end/panels/timeline/TimelineFlameChartNetworkDataProvider.ts +1 -1
- package/front_end/panels/timeline/TimelineMiniMap.ts +255 -103
- package/front_end/panels/timeline/TimelinePaintProfilerView.ts +19 -11
- package/front_end/panels/timeline/TimelinePanel.ts +1 -0
- package/front_end/panels/timeline/TimelineSelectorStatsView.ts +11 -12
- package/front_end/panels/timeline/TimelineTreeView.ts +240 -122
- package/front_end/panels/timeline/TimelineUIUtils.ts +12 -0
- package/front_end/panels/timeline/components/BreadcrumbsUI.ts +5 -4
- package/front_end/panels/timeline/components/DetailsView.ts +97 -65
- package/front_end/panels/timeline/components/LayoutShiftDetails.ts +2 -2
- package/front_end/panels/timeline/components/MetricCard.ts +2 -2
- package/front_end/panels/timeline/components/NetworkRequestDetails.ts +11 -12
- package/front_end/panels/timeline/components/NetworkTrackWidget.ts +57 -50
- package/front_end/panels/timeline/components/RelatedInsightChips.ts +2 -2
- package/front_end/panels/timeline/components/Sidebar.ts +161 -109
- package/front_end/panels/timeline/components/SidebarAnnotationsTab.ts +33 -12
- package/front_end/panels/timeline/components/SidebarInsightsTab.ts +3 -0
- package/front_end/panels/timeline/components/insights/LCPDiscovery.ts +11 -11
- package/front_end/panels/timeline/components/insights/SlowCSSSelector.ts +6 -7
- package/front_end/panels/timeline/components/networkTrackWidget.css +24 -22
- package/front_end/panels/timeline/components/sidebarInsightsTab.css +1 -1
- package/front_end/panels/timeline/overlays/components/TimespanBreakdownOverlay.ts +15 -10
- package/front_end/panels/timeline/overlays/components/entryLabelOverlay.css +1 -1
- package/front_end/panels/timeline/timelinePanel.css +5 -0
- package/front_end/panels/timeline/timelineStatusDialog.css +1 -1
- package/front_end/panels/web_audio/WebAudioView.ts +2 -2
- package/front_end/third_party/chromium/README.chromium +1 -1
- package/front_end/third_party/legacy-javascript/README.chromium +2 -2
- package/front_end/third_party/legacy-javascript/lib/legacy-javascript.js +2 -2
- package/front_end/third_party/legacy-javascript/package.json +1 -1
- package/front_end/third_party/lighthouse/README.chromium +2 -2
- package/front_end/third_party/lighthouse/lighthouse-dt-bundle.js +1983 -2022
- package/front_end/third_party/lighthouse/locales/ar-XB.json +157 -142
- package/front_end/third_party/lighthouse/locales/ar.json +157 -142
- package/front_end/third_party/lighthouse/locales/bg.json +154 -139
- package/front_end/third_party/lighthouse/locales/ca.json +157 -142
- package/front_end/third_party/lighthouse/locales/cs.json +148 -133
- package/front_end/third_party/lighthouse/locales/da.json +153 -138
- package/front_end/third_party/lighthouse/locales/de.json +152 -137
- package/front_end/third_party/lighthouse/locales/el.json +153 -138
- package/front_end/third_party/lighthouse/locales/en-GB.json +160 -145
- package/front_end/third_party/lighthouse/locales/en-US.json +239 -218
- package/front_end/third_party/lighthouse/locales/en-XL.json +239 -218
- package/front_end/third_party/lighthouse/locales/es-419.json +150 -135
- package/front_end/third_party/lighthouse/locales/es.json +149 -134
- package/front_end/third_party/lighthouse/locales/fi.json +151 -136
- package/front_end/third_party/lighthouse/locales/fil.json +154 -139
- package/front_end/third_party/lighthouse/locales/fr.json +150 -135
- package/front_end/third_party/lighthouse/locales/he.json +160 -145
- package/front_end/third_party/lighthouse/locales/hi.json +156 -141
- package/front_end/third_party/lighthouse/locales/hr.json +154 -139
- package/front_end/third_party/lighthouse/locales/hu.json +111 -96
- package/front_end/third_party/lighthouse/locales/id.json +153 -138
- package/front_end/third_party/lighthouse/locales/it.json +153 -138
- package/front_end/third_party/lighthouse/locales/ja.json +150 -135
- package/front_end/third_party/lighthouse/locales/ko.json +42 -27
- package/front_end/third_party/lighthouse/locales/lt.json +152 -137
- package/front_end/third_party/lighthouse/locales/lv.json +93 -78
- package/front_end/third_party/lighthouse/locales/nl.json +149 -134
- package/front_end/third_party/lighthouse/locales/no.json +152 -137
- package/front_end/third_party/lighthouse/locales/pl.json +153 -138
- package/front_end/third_party/lighthouse/locales/pt-PT.json +152 -137
- package/front_end/third_party/lighthouse/locales/pt.json +157 -142
- package/front_end/third_party/lighthouse/locales/ro.json +149 -134
- package/front_end/third_party/lighthouse/locales/ru.json +76 -61
- package/front_end/third_party/lighthouse/locales/sk.json +153 -138
- package/front_end/third_party/lighthouse/locales/sl.json +149 -134
- package/front_end/third_party/lighthouse/locales/sr-Latn.json +151 -136
- package/front_end/third_party/lighthouse/locales/sr.json +151 -136
- package/front_end/third_party/lighthouse/locales/sv.json +152 -137
- package/front_end/third_party/lighthouse/locales/ta.json +156 -141
- package/front_end/third_party/lighthouse/locales/te.json +157 -142
- package/front_end/third_party/lighthouse/locales/th.json +111 -96
- package/front_end/third_party/lighthouse/locales/tr.json +153 -138
- package/front_end/third_party/lighthouse/locales/uk.json +149 -134
- package/front_end/third_party/lighthouse/locales/vi.json +162 -147
- package/front_end/third_party/lighthouse/locales/zh-HK.json +150 -135
- package/front_end/third_party/lighthouse/locales/zh-TW.json +154 -139
- package/front_end/third_party/lighthouse/locales/zh.json +152 -137
- package/front_end/third_party/lighthouse/report/bundle.d.ts +9 -8
- package/front_end/third_party/lighthouse/report/bundle.js +10 -10
- package/front_end/third_party/lighthouse/report-assets/report-generator.mjs +2 -7
- package/front_end/tsconfig.compatibility.json +1 -0
- package/front_end/tsconfig.json +3 -2
- package/front_end/ui/components/dialogs/TypeToAllowDialog.ts +0 -2
- package/front_end/ui/components/dialogs/typeToAllowDialog.css +0 -4
- package/front_end/ui/components/icon_button/fileSourceIcon.css +1 -1
- package/front_end/ui/components/input/textInput.css +1 -1
- package/front_end/ui/components/lists/List.ts +26 -14
- package/front_end/ui/components/menus/menus.ts +0 -2
- package/front_end/ui/components/suggestion_input/SuggestionInput.ts +351 -138
- package/front_end/ui/components/survey_link/surveyLink.css +3 -3
- package/front_end/ui/components/switch/switch.css +6 -6
- package/front_end/ui/components/text_editor/AiCodeCompletionTeaser.ts +2 -3
- package/front_end/ui/components/text_editor/TextEditor.ts +1 -1
- package/front_end/ui/components/tooltips/Tooltip.ts +53 -4
- package/front_end/ui/components/tree_outline/treeOutline.css +7 -7
- package/front_end/ui/helpers/OpenInNewTab.ts +8 -3
- package/front_end/ui/legacy/EmptyWidget.ts +4 -4
- package/front_end/ui/legacy/ForwardedInputEventHandler.ts +2 -2
- package/front_end/ui/legacy/GlassPane.ts +1 -1
- package/front_end/ui/legacy/KeyboardShortcut.ts +7 -7
- package/front_end/ui/legacy/RemoteDebuggingTerminatedScreen.ts +2 -2
- package/front_end/ui/legacy/TabbedPane.ts +198 -66
- package/front_end/ui/legacy/TargetCrashedScreen.ts +2 -2
- package/front_end/ui/legacy/UIUtils.ts +71 -68
- package/front_end/ui/legacy/View.ts +7 -4
- package/front_end/ui/legacy/ViewManager.ts +49 -37
- package/front_end/ui/legacy/Widget.ts +32 -12
- package/front_end/ui/legacy/components/cookie_table/CookiesTable.ts +2 -3
- package/front_end/ui/legacy/components/inline_editor/AnimationTimingUI.ts +8 -8
- package/front_end/ui/legacy/components/inline_editor/BezierUI.ts +8 -9
- package/front_end/ui/legacy/components/inline_editor/LinkSwatch.ts +2 -2
- package/front_end/ui/legacy/components/inline_editor/cssAngleEditor.css +1 -1
- package/front_end/ui/legacy/components/inline_editor/cssAngleSwatch.css +1 -1
- package/front_end/ui/legacy/components/object_ui/ObjectPropertiesSection.ts +45 -11
- package/front_end/ui/legacy/components/object_ui/RemoteObjectPreviewFormatter.ts +10 -12
- package/front_end/ui/legacy/components/perf_ui/ChartViewport.ts +102 -29
- package/front_end/ui/legacy/components/perf_ui/FlameChart.ts +148 -122
- package/front_end/ui/legacy/components/perf_ui/TimelineOverviewPane.ts +20 -14
- package/front_end/ui/legacy/components/quick_open/filteredListWidget.css +1 -1
- package/front_end/ui/legacy/components/source_frame/FontView.ts +29 -5
- package/front_end/ui/legacy/components/source_frame/ImageView.ts +79 -12
- package/front_end/ui/legacy/components/source_frame/JSONView.ts +20 -2
- package/front_end/ui/legacy/components/source_frame/PreviewFactory.ts +2 -2
- package/front_end/ui/legacy/components/source_frame/StreamingContentHexView.ts +6 -10
- package/front_end/ui/legacy/components/source_frame/XMLView.ts +11 -11
- package/front_end/ui/legacy/components/source_frame/fontView.css +7 -0
- package/front_end/ui/legacy/components/source_frame/imageView.css +7 -0
- package/front_end/ui/legacy/components/utils/JSPresentationUtils.ts +14 -3
- package/front_end/ui/legacy/components/utils/Linkifier.ts +126 -2
- package/front_end/ui/legacy/emptyWidget.css +2 -1
- package/front_end/ui/legacy/inspectorCommon.css +3 -3
- package/front_end/ui/legacy/smallBubble.css +1 -1
- package/front_end/ui/legacy/tabbedPane.css +6 -0
- package/front_end/ui/lit/Directives.ts +35 -18
- package/front_end/ui/lit/lit.ts +0 -2
- package/front_end/ui/lit/render.ts +0 -7
- package/front_end/ui/visual_logging/KnownContextValues.ts +5 -0
- package/package.json +1 -1
- package/vpython.toml +8 -0
- package/vpython.toml.uv.lock +3 -0
- package/.agents/skills/review-models-core/SKILL.md +0 -73
- package/.agents/skills/review-tests/SKILL.md +0 -67
- package/.agents/skills/review-ui-widgets/SKILL.md +0 -115
- package/front_end/generated/ARIAProperties.ts +0 -2686
- package/front_end/ui/components/menus/README.md +0 -119
- package/front_end/ui/components/menus/SelectMenu.ts +0 -473
- package/front_end/ui/components/menus/selectMenu.css +0 -54
- package/front_end/ui/components/menus/selectMenuButton.css +0 -108
|
@@ -15,19 +15,24 @@ import * as DataGrid from '../../ui/legacy/components/data_grid/data_grid.js';
|
|
|
15
15
|
import * as Components from '../../ui/legacy/components/utils/utils.js';
|
|
16
16
|
import * as UI from '../../ui/legacy/legacy.js';
|
|
17
17
|
import * as ThemeSupport from '../../ui/legacy/theme_support/theme_support.js';
|
|
18
|
+
import {html, nothing, render} from '../../ui/lit/lit.js';
|
|
18
19
|
import * as VisualLogging from '../../ui/visual_logging/visual_logging.js';
|
|
19
20
|
|
|
20
21
|
import {ActiveFilters} from './ActiveFilters.js';
|
|
21
22
|
import * as Extensions from './extensions/extensions.js';
|
|
22
23
|
import {targetForEvent} from './TargetForEvent.js';
|
|
23
24
|
import {TimelineRegExp} from './TimelineFilters.js';
|
|
24
|
-
import {
|
|
25
|
+
import {
|
|
26
|
+
rangeForSelection,
|
|
27
|
+
type TimelineSelection,
|
|
28
|
+
} from './TimelineSelection.js';
|
|
25
29
|
import timelineTreeViewStyles from './timelineTreeView.css.js';
|
|
26
30
|
import {TimelineUIUtils} from './TimelineUIUtils.js';
|
|
27
31
|
|
|
28
32
|
const UIStrings = {
|
|
29
33
|
/**
|
|
30
|
-
* @description Data grid name for timeline tree view tables in the
|
|
34
|
+
* @description Data grid name for timeline tree view tables in the
|
|
35
|
+
* Performance panel.
|
|
31
36
|
*/
|
|
32
37
|
performance: 'Performance',
|
|
33
38
|
/**
|
|
@@ -43,7 +48,8 @@ const UIStrings = {
|
|
|
43
48
|
*/
|
|
44
49
|
activity: 'Activity',
|
|
45
50
|
/**
|
|
46
|
-
* @description Banner message shown when no tree item is selected for details
|
|
51
|
+
* @description Banner message shown when no tree item is selected for details
|
|
52
|
+
* in the Performance panel.
|
|
47
53
|
*/
|
|
48
54
|
selectItemForDetails: 'Select item for details',
|
|
49
55
|
/**
|
|
@@ -52,7 +58,8 @@ const UIStrings = {
|
|
|
52
58
|
*/
|
|
53
59
|
percentPlaceholder: '{PH1} %',
|
|
54
60
|
/**
|
|
55
|
-
* @description Row label for Chrome extensions overhead in timeline tree
|
|
61
|
+
* @description Row label for Chrome extensions overhead in timeline tree
|
|
62
|
+
* views.
|
|
56
63
|
*/
|
|
57
64
|
chromeExtensionsOverhead: '[`Chrome` extensions overhead]',
|
|
58
65
|
/**
|
|
@@ -68,39 +75,48 @@ const UIStrings = {
|
|
|
68
75
|
*/
|
|
69
76
|
page: 'Page',
|
|
70
77
|
/**
|
|
71
|
-
* @description Option in the grouping dropdown for no grouping in timeline
|
|
78
|
+
* @description Option in the grouping dropdown for no grouping in timeline
|
|
79
|
+
* tree views.
|
|
72
80
|
*/
|
|
73
81
|
noGrouping: 'No grouping',
|
|
74
82
|
/**
|
|
75
|
-
* @description Option in the grouping dropdown to group by activity in
|
|
83
|
+
* @description Option in the grouping dropdown to group by activity in
|
|
84
|
+
* timeline tree views.
|
|
76
85
|
*/
|
|
77
86
|
groupByActivity: 'Group by activity',
|
|
78
87
|
/**
|
|
79
|
-
* @description Option in the grouping dropdown to group by category in
|
|
88
|
+
* @description Option in the grouping dropdown to group by category in
|
|
89
|
+
* timeline tree views.
|
|
80
90
|
*/
|
|
81
91
|
groupByCategory: 'Group by category',
|
|
82
92
|
/**
|
|
83
|
-
* @description Option in the grouping dropdown to group by domain in timeline
|
|
93
|
+
* @description Option in the grouping dropdown to group by domain in timeline
|
|
94
|
+
* tree views.
|
|
84
95
|
*/
|
|
85
96
|
groupByDomain: 'Group by domain',
|
|
86
97
|
/**
|
|
87
|
-
* @description Option in the grouping dropdown to group by frame in timeline
|
|
98
|
+
* @description Option in the grouping dropdown to group by frame in timeline
|
|
99
|
+
* tree views.
|
|
88
100
|
*/
|
|
89
101
|
groupByFrame: 'Group by frame',
|
|
90
102
|
/**
|
|
91
|
-
* @description Option in the grouping dropdown to group by subdomain in
|
|
103
|
+
* @description Option in the grouping dropdown to group by subdomain in
|
|
104
|
+
* timeline tree views.
|
|
92
105
|
*/
|
|
93
106
|
groupBySubdomain: 'Group by subdomain',
|
|
94
107
|
/**
|
|
95
|
-
* @description Option in the grouping dropdown to group by URL in timeline
|
|
108
|
+
* @description Option in the grouping dropdown to group by URL in timeline
|
|
109
|
+
* tree views.
|
|
96
110
|
*/
|
|
97
111
|
groupByUrl: 'Group by URL',
|
|
98
112
|
/**
|
|
99
|
-
* @description Option in the grouping dropdown to group by third parties in
|
|
113
|
+
* @description Option in the grouping dropdown to group by third parties in
|
|
114
|
+
* timeline tree views.
|
|
100
115
|
*/
|
|
101
116
|
groupByThirdParties: 'Group by 3rd parties',
|
|
102
117
|
/**
|
|
103
|
-
* @description Accessible label for the grouping dropdown in timeline tree
|
|
118
|
+
* @description Accessible label for the grouping dropdown in timeline tree
|
|
119
|
+
* views.
|
|
104
120
|
*/
|
|
105
121
|
groupBy: 'Group by',
|
|
106
122
|
/**
|
|
@@ -108,43 +124,53 @@ const UIStrings = {
|
|
|
108
124
|
*/
|
|
109
125
|
heaviestStack: 'Heaviest stack',
|
|
110
126
|
/**
|
|
111
|
-
* @description Tooltip for the button to show the heaviest stack sidebar in
|
|
127
|
+
* @description Tooltip for the button to show the heaviest stack sidebar in
|
|
128
|
+
* timeline tree views.
|
|
112
129
|
*/
|
|
113
130
|
showHeaviestStack: 'Show heaviest stack',
|
|
114
131
|
/**
|
|
115
|
-
* @description Tooltip for the button to hide the heaviest stack sidebar in
|
|
132
|
+
* @description Tooltip for the button to hide the heaviest stack sidebar in
|
|
133
|
+
* timeline tree views.
|
|
116
134
|
*/
|
|
117
135
|
hideHeaviestStack: 'Hide heaviest stack',
|
|
118
136
|
/**
|
|
119
|
-
* @description Screen reader announcement when the heaviest stack sidebar is
|
|
137
|
+
* @description Screen reader announcement when the heaviest stack sidebar is
|
|
138
|
+
* shown in the Performance panel.
|
|
120
139
|
*/
|
|
121
140
|
heaviestStackShown: 'Heaviest stack sidebar shown',
|
|
122
141
|
/**
|
|
123
|
-
* @description Screen reader announcement when the heaviest stack sidebar is
|
|
142
|
+
* @description Screen reader announcement when the heaviest stack sidebar is
|
|
143
|
+
* hidden in the Performance panel.
|
|
124
144
|
*/
|
|
125
145
|
heaviestStackHidden: 'Heaviest stack sidebar hidden',
|
|
126
146
|
/**
|
|
127
|
-
* @description Data grid name for heaviest stack tables in the Performance
|
|
147
|
+
* @description Data grid name for heaviest stack tables in the Performance
|
|
148
|
+
* panel.
|
|
128
149
|
*/
|
|
129
150
|
timelineStack: 'Timeline stack',
|
|
130
151
|
/**
|
|
131
|
-
* @description Tooltip for the match case search button in timeline tree
|
|
152
|
+
* @description Tooltip for the match case search button in timeline tree
|
|
153
|
+
* views.
|
|
132
154
|
*/
|
|
133
155
|
matchCase: 'Match case',
|
|
134
156
|
/**
|
|
135
|
-
* @description Tooltip for the regular expression search button in timeline
|
|
157
|
+
* @description Tooltip for the regular expression search button in timeline
|
|
158
|
+
* tree views.
|
|
136
159
|
*/
|
|
137
160
|
useRegularExpression: 'Use regular expression',
|
|
138
161
|
/**
|
|
139
|
-
* @description Tooltip for the match whole word search button in timeline
|
|
162
|
+
* @description Tooltip for the match whole word search button in timeline
|
|
163
|
+
* tree views.
|
|
140
164
|
*/
|
|
141
165
|
matchWholeWord: 'Match whole word',
|
|
142
166
|
/**
|
|
143
|
-
* @description Tooltip for the button to switch to the bottom-up view in
|
|
167
|
+
* @description Tooltip for the button to switch to the bottom-up view in
|
|
168
|
+
* timeline tree views.
|
|
144
169
|
*/
|
|
145
170
|
bottomUp: 'Bottom-up',
|
|
146
171
|
/**
|
|
147
|
-
* @description Accessible label for the button to switch to the bottom-up
|
|
172
|
+
* @description Accessible label for the button to switch to the bottom-up
|
|
173
|
+
* view in timeline tree views.
|
|
148
174
|
*/
|
|
149
175
|
viewBottomUp: 'View bottom-up',
|
|
150
176
|
/**
|
|
@@ -160,13 +186,20 @@ const str_ = i18n.i18n.registerUIStrings('panels/timeline/TimelineTreeView.ts',
|
|
|
160
186
|
const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
|
|
161
187
|
|
|
162
188
|
/**
|
|
163
|
-
* For an overview, read:
|
|
189
|
+
* For an overview, read:
|
|
190
|
+
* https://chromium.googlesource.com/devtools/devtools-frontend/+/refs/heads/main/front_end/panels/timeline/README.md#timeline-tree-views
|
|
164
191
|
*/
|
|
165
192
|
const TimelineTreeViewBase: Common.ObjectWrapper.EventMixin<TimelineTreeView.EventTypes, typeof UI.Widget.VBox> =
|
|
166
193
|
Common.ObjectWrapper.eventMixin(
|
|
167
194
|
UI.Widget.VBox,
|
|
168
195
|
);
|
|
169
196
|
|
|
197
|
+
function renderDetailsPlaceholder(input: {showPlaceholder: boolean}, _output: undefined, target: HTMLElement): void {
|
|
198
|
+
render(input.showPlaceholder ? html`<div class="empty-state">${i18nString(UIStrings.selectItemForDetails)}</div>` :
|
|
199
|
+
nothing,
|
|
200
|
+
target);
|
|
201
|
+
}
|
|
202
|
+
|
|
170
203
|
export class TimelineTreeView extends TimelineTreeViewBase implements UI.SearchableView.Searchable {
|
|
171
204
|
/** This is sorted by ts. */
|
|
172
205
|
#selectedEvents: Trace.Types.Events.Event[]|null;
|
|
@@ -176,8 +209,8 @@ export class TimelineTreeView extends TimelineTreeViewBase implements UI.Searcha
|
|
|
176
209
|
private lastHoveredProfileNode!: Trace.Extras.TraceTree.Node|null;
|
|
177
210
|
private textFilterInternal!: TimelineRegExp;
|
|
178
211
|
private taskFilter!: Trace.Extras.TraceFilter.ExclusiveNameFilter;
|
|
179
|
-
protected startTimeInternal
|
|
180
|
-
protected endTimeInternal
|
|
212
|
+
protected startTimeInternal?: Trace.Types.Timing.Milli;
|
|
213
|
+
protected endTimeInternal?: Trace.Types.Timing.Milli;
|
|
181
214
|
splitWidget!: UI.SplitWidget.SplitWidget;
|
|
182
215
|
detailsView!: UI.Widget.Widget;
|
|
183
216
|
private searchableView!: UI.SearchableView.SearchableView;
|
|
@@ -221,11 +254,23 @@ export class TimelineTreeView extends TimelineTreeViewBase implements UI.Searcha
|
|
|
221
254
|
}
|
|
222
255
|
|
|
223
256
|
set selectedEvents(selectedEvents: Trace.Types.Events.Event[]|null) {
|
|
257
|
+
if (this.#selectedEvents === selectedEvents) {
|
|
258
|
+
return;
|
|
259
|
+
}
|
|
224
260
|
this.#selectedEvents = selectedEvents;
|
|
225
261
|
this.refreshTree();
|
|
226
262
|
}
|
|
227
263
|
|
|
228
264
|
set parsedTrace(parsedTrace: Trace.TraceModel.ParsedTrace|null) {
|
|
265
|
+
if (this.#parsedTrace === parsedTrace) {
|
|
266
|
+
return;
|
|
267
|
+
}
|
|
268
|
+
if (this.#parsedTrace !== null) {
|
|
269
|
+
// Clear bounds from the previous trace so refreshTree() does not rebuild
|
|
270
|
+
// the tree with stale bounds before the new trace's selection is set.
|
|
271
|
+
this.startTimeInternal = undefined;
|
|
272
|
+
this.endTimeInternal = undefined;
|
|
273
|
+
}
|
|
229
274
|
this.#parsedTrace = parsedTrace;
|
|
230
275
|
this.refreshTree();
|
|
231
276
|
}
|
|
@@ -243,7 +288,7 @@ export class TimelineTreeView extends TimelineTreeViewBase implements UI.Searcha
|
|
|
243
288
|
}
|
|
244
289
|
|
|
245
290
|
get startTime(): Trace.Types.Timing.Milli {
|
|
246
|
-
return this.startTimeInternal;
|
|
291
|
+
return this.startTimeInternal ?? Trace.Types.Timing.Milli(0);
|
|
247
292
|
}
|
|
248
293
|
|
|
249
294
|
set endTime(endTime: Trace.Types.Timing.Milli) {
|
|
@@ -255,7 +300,7 @@ export class TimelineTreeView extends TimelineTreeViewBase implements UI.Searcha
|
|
|
255
300
|
}
|
|
256
301
|
|
|
257
302
|
get endTime(): Trace.Types.Timing.Milli {
|
|
258
|
-
return this.endTimeInternal;
|
|
303
|
+
return this.endTimeInternal ?? Trace.Types.Timing.Milli(Infinity);
|
|
259
304
|
}
|
|
260
305
|
|
|
261
306
|
get compactMode(): boolean {
|
|
@@ -318,6 +363,16 @@ export class TimelineTreeView extends TimelineTreeViewBase implements UI.Searcha
|
|
|
318
363
|
parsedTrace: Trace.TraceModel.ParsedTrace|null,
|
|
319
364
|
entityMapper: Trace.EntityMapper.EntityMapper|null,
|
|
320
365
|
}) {
|
|
366
|
+
if (this.#parsedTrace === model.parsedTrace && this.#selectedEvents === model.selectedEvents &&
|
|
367
|
+
this.#entityMapper === model.entityMapper) {
|
|
368
|
+
return;
|
|
369
|
+
}
|
|
370
|
+
if (this.#parsedTrace !== null && this.#parsedTrace !== model.parsedTrace) {
|
|
371
|
+
// Clear bounds from the previous trace so refreshTree() does not rebuild
|
|
372
|
+
// the tree with stale bounds before the new trace's selection is set.
|
|
373
|
+
this.startTimeInternal = undefined;
|
|
374
|
+
this.endTimeInternal = undefined;
|
|
375
|
+
}
|
|
321
376
|
this.#parsedTrace = model.parsedTrace;
|
|
322
377
|
this.#selectedEvents = model.selectedEvents;
|
|
323
378
|
this.#entityMapper = model.entityMapper;
|
|
@@ -390,7 +445,8 @@ export class TimelineTreeView extends TimelineTreeViewBase implements UI.Searcha
|
|
|
390
445
|
override wasShown(): void {
|
|
391
446
|
super.wasShown();
|
|
392
447
|
// Only refresh if data or configuration changed while detached,
|
|
393
|
-
// avoiding rebuilding the DataGrid which resets expanded nodes and
|
|
448
|
+
// avoiding rebuilding the DataGrid which resets expanded nodes and
|
|
449
|
+
// selection.
|
|
394
450
|
if (this.#dirty) {
|
|
395
451
|
this.refreshTree();
|
|
396
452
|
}
|
|
@@ -409,8 +465,13 @@ export class TimelineTreeView extends TimelineTreeViewBase implements UI.Searcha
|
|
|
409
465
|
}
|
|
410
466
|
|
|
411
467
|
setRange(startTime: Trace.Types.Timing.Milli, endTime: Trace.Types.Timing.Milli): void {
|
|
412
|
-
this.startTime
|
|
413
|
-
|
|
468
|
+
if (this.startTimeInternal === startTime && this.endTimeInternal === endTime) {
|
|
469
|
+
return;
|
|
470
|
+
}
|
|
471
|
+
// Update internal fields directly to prevent the startTime and endTime setters from
|
|
472
|
+
// triggering individual refreshTree() calls.
|
|
473
|
+
this.startTimeInternal = startTime;
|
|
474
|
+
this.endTimeInternal = endTime;
|
|
414
475
|
this.refreshTree();
|
|
415
476
|
}
|
|
416
477
|
|
|
@@ -431,7 +492,11 @@ export class TimelineTreeView extends TimelineTreeViewBase implements UI.Searcha
|
|
|
431
492
|
}
|
|
432
493
|
|
|
433
494
|
filters(): Trace.Extras.TraceFilter.TraceFilter[] {
|
|
434
|
-
return [
|
|
495
|
+
return [
|
|
496
|
+
this.taskFilter,
|
|
497
|
+
this.textFilterInternal,
|
|
498
|
+
...(ActiveFilters.instance().activeFilters()),
|
|
499
|
+
];
|
|
435
500
|
}
|
|
436
501
|
|
|
437
502
|
filtersWithoutTextFilter(): Trace.Extras.TraceFilter.TraceFilter[] {
|
|
@@ -454,15 +519,15 @@ export class TimelineTreeView extends TimelineTreeViewBase implements UI.Searcha
|
|
|
454
519
|
}, this);
|
|
455
520
|
toolbar.appendToolbarItem(this.caseSensitiveButton);
|
|
456
521
|
|
|
457
|
-
this.regexButton = new UI.Toolbar.ToolbarToggle(
|
|
458
|
-
|
|
522
|
+
this.regexButton = new UI.Toolbar.ToolbarToggle(i18nString(UIStrings.useRegularExpression), 'regular-expression',
|
|
523
|
+
undefined, 'regular-expression');
|
|
459
524
|
this.regexButton.addEventListener(UI.Toolbar.ToolbarButton.Events.CLICK, () => {
|
|
460
525
|
this.#filterChanged();
|
|
461
526
|
}, this);
|
|
462
527
|
toolbar.appendToolbarItem(this.regexButton);
|
|
463
528
|
|
|
464
|
-
this.matchWholeWord = new UI.Toolbar.ToolbarToggle(
|
|
465
|
-
|
|
529
|
+
this.matchWholeWord = new UI.Toolbar.ToolbarToggle(i18nString(UIStrings.matchWholeWord), 'match-whole-word',
|
|
530
|
+
undefined, 'match-whole-word');
|
|
466
531
|
this.matchWholeWord.addEventListener(UI.Toolbar.ToolbarButton.Events.CLICK, () => {
|
|
467
532
|
this.#filterChanged();
|
|
468
533
|
}, this);
|
|
@@ -499,18 +564,17 @@ export class TimelineTreeView extends TimelineTreeViewBase implements UI.Searcha
|
|
|
499
564
|
|
|
500
565
|
/**
|
|
501
566
|
* Refreshes the tree. By default, it will only do this
|
|
502
|
-
* if the tree is
|
|
567
|
+
* if the tree view is currently showing - as in the UI we
|
|
503
568
|
* have multiple trees and we only want to refresh the
|
|
504
569
|
* active one. Pass `true` into this function to force a
|
|
505
570
|
* refresh regardless.
|
|
506
571
|
*/
|
|
507
572
|
refreshTree(forceRefresh = false): void {
|
|
508
|
-
if (!this.
|
|
573
|
+
if (!this.isShowing() && !forceRefresh) {
|
|
509
574
|
// This function can be called in different views (Bottom-Up and
|
|
510
575
|
// Call Tree) by the same single event whenever the group-by
|
|
511
576
|
// dropdown changes value. Thus, we bail out whenever the view is
|
|
512
|
-
// not visible
|
|
513
|
-
// from the document.
|
|
577
|
+
// not visible to avoid useless work.
|
|
514
578
|
// Mark dirty so that the refresh is deferred until shown.
|
|
515
579
|
this.#dirty = true;
|
|
516
580
|
return;
|
|
@@ -518,7 +582,8 @@ export class TimelineTreeView extends TimelineTreeViewBase implements UI.Searcha
|
|
|
518
582
|
this.#dirty = false;
|
|
519
583
|
this.linkifier.reset();
|
|
520
584
|
this.dataGrid.rootNode().removeChildren();
|
|
521
|
-
|
|
585
|
+
// Do not build the tree until bounds are configured by an active selection.
|
|
586
|
+
if (!this.#parsedTrace || this.startTimeInternal === undefined || this.endTimeInternal === undefined) {
|
|
522
587
|
this.updateDetailsForSelection();
|
|
523
588
|
return;
|
|
524
589
|
}
|
|
@@ -584,23 +649,40 @@ export class TimelineTreeView extends TimelineTreeViewBase implements UI.Searcha
|
|
|
584
649
|
|
|
585
650
|
populateColumns(columns: DataGrid.DataGrid.ColumnDescriptor[]): void {
|
|
586
651
|
if (this.compactMode) {
|
|
587
|
-
columns.push(
|
|
588
|
-
|
|
589
|
-
|
|
590
|
-
|
|
591
|
-
|
|
592
|
-
|
|
652
|
+
columns.push(({
|
|
653
|
+
id: 'self',
|
|
654
|
+
title: i18nString(UIStrings.selfTime),
|
|
655
|
+
width: '15%',
|
|
656
|
+
sortable: true,
|
|
657
|
+
} as DataGrid.DataGrid.ColumnDescriptor));
|
|
658
|
+
columns.push(({
|
|
659
|
+
id: 'total',
|
|
660
|
+
title: i18nString(UIStrings.totalTime),
|
|
661
|
+
width: '15%',
|
|
662
|
+
sortable: true,
|
|
663
|
+
} as DataGrid.DataGrid.ColumnDescriptor));
|
|
593
664
|
} else {
|
|
594
|
-
columns.push(
|
|
595
|
-
|
|
596
|
-
|
|
597
|
-
|
|
598
|
-
|
|
599
|
-
|
|
600
|
-
|
|
601
|
-
|
|
602
|
-
|
|
603
|
-
|
|
665
|
+
columns.push(({
|
|
666
|
+
id: 'self',
|
|
667
|
+
title: i18nString(UIStrings.selfTime),
|
|
668
|
+
width: '120px',
|
|
669
|
+
fixedWidth: true,
|
|
670
|
+
sortable: true,
|
|
671
|
+
} as DataGrid.DataGrid.ColumnDescriptor));
|
|
672
|
+
columns.push(({
|
|
673
|
+
id: 'total',
|
|
674
|
+
title: i18nString(UIStrings.totalTime),
|
|
675
|
+
width: '120px',
|
|
676
|
+
fixedWidth: true,
|
|
677
|
+
sortable: true,
|
|
678
|
+
} as DataGrid.DataGrid.ColumnDescriptor));
|
|
679
|
+
}
|
|
680
|
+
columns.push(({
|
|
681
|
+
id: 'activity',
|
|
682
|
+
title: i18nString(UIStrings.activity),
|
|
683
|
+
disclosure: true,
|
|
684
|
+
sortable: true,
|
|
685
|
+
} as DataGrid.DataGrid.ColumnDescriptor));
|
|
604
686
|
}
|
|
605
687
|
|
|
606
688
|
sortingChanged(): void {
|
|
@@ -615,23 +697,21 @@ export class TimelineTreeView extends TimelineTreeViewBase implements UI.Searcha
|
|
|
615
697
|
}
|
|
616
698
|
|
|
617
699
|
// Gets the sorting function for the tree view nodes.
|
|
618
|
-
getSortingFunction(columnId: string):
|
|
619
|
-
|
|
620
|
-
|
|
621
|
-
|
|
622
|
-
|
|
623
|
-
|
|
624
|
-
|
|
625
|
-
|
|
626
|
-
|
|
627
|
-
|
|
628
|
-
|
|
629
|
-
|
|
630
|
-
|
|
631
|
-
|
|
632
|
-
|
|
633
|
-
return nameA.localeCompare(nameB);
|
|
634
|
-
};
|
|
700
|
+
getSortingFunction(columnId: string): ((a: DataGrid.SortableDataGrid.SortableDataGridNode<GridNode>,
|
|
701
|
+
b: DataGrid.SortableDataGrid.SortableDataGridNode<GridNode>) => number)|null {
|
|
702
|
+
const compareNameSortFn = (a: DataGrid.SortableDataGrid.SortableDataGridNode<GridNode>,
|
|
703
|
+
b: DataGrid.SortableDataGrid.SortableDataGridNode<GridNode>): number => {
|
|
704
|
+
const nodeA = (a as TreeGridNode);
|
|
705
|
+
const nodeB = (b as TreeGridNode);
|
|
706
|
+
const eventA = nodeA.profileNode.event;
|
|
707
|
+
const eventB = nodeB.profileNode.event;
|
|
708
|
+
if (!eventA || !eventB) {
|
|
709
|
+
return 0;
|
|
710
|
+
}
|
|
711
|
+
const nameA = this.#eventNameForSorting(eventA);
|
|
712
|
+
const nameB = this.#eventNameForSorting(eventB);
|
|
713
|
+
return nameA.localeCompare(nameB);
|
|
714
|
+
};
|
|
635
715
|
|
|
636
716
|
switch (columnId) {
|
|
637
717
|
case 'start-time':
|
|
@@ -648,17 +728,15 @@ export class TimelineTreeView extends TimelineTreeViewBase implements UI.Searcha
|
|
|
648
728
|
return null;
|
|
649
729
|
}
|
|
650
730
|
|
|
651
|
-
function compareSelfTime(
|
|
652
|
-
|
|
653
|
-
b: DataGrid.SortableDataGrid.SortableDataGridNode<GridNode>): number {
|
|
731
|
+
function compareSelfTime(a: DataGrid.SortableDataGrid.SortableDataGridNode<GridNode>,
|
|
732
|
+
b: DataGrid.SortableDataGrid.SortableDataGridNode<GridNode>): number {
|
|
654
733
|
const nodeA = a as TreeGridNode;
|
|
655
734
|
const nodeB = b as TreeGridNode;
|
|
656
735
|
return nodeA.profileNode.selfTime - nodeB.profileNode.selfTime;
|
|
657
736
|
}
|
|
658
737
|
|
|
659
|
-
function compareStartTime(
|
|
660
|
-
|
|
661
|
-
b: DataGrid.SortableDataGrid.SortableDataGridNode<GridNode>): number {
|
|
738
|
+
function compareStartTime(a: DataGrid.SortableDataGrid.SortableDataGridNode<GridNode>,
|
|
739
|
+
b: DataGrid.SortableDataGrid.SortableDataGridNode<GridNode>): number {
|
|
662
740
|
const nodeA = (a as TreeGridNode);
|
|
663
741
|
const nodeB = (b as TreeGridNode);
|
|
664
742
|
const eventA = nodeA.profileNode.event;
|
|
@@ -670,9 +748,8 @@ export class TimelineTreeView extends TimelineTreeViewBase implements UI.Searcha
|
|
|
670
748
|
return eventA.ts - eventB.ts;
|
|
671
749
|
}
|
|
672
750
|
|
|
673
|
-
function compareTotalTime(
|
|
674
|
-
|
|
675
|
-
b: DataGrid.SortableDataGrid.SortableDataGridNode<GridNode>): number {
|
|
751
|
+
function compareTotalTime(a: DataGrid.SortableDataGrid.SortableDataGridNode<GridNode>,
|
|
752
|
+
b: DataGrid.SortableDataGrid.SortableDataGridNode<GridNode>): number {
|
|
676
753
|
const nodeA = a as TreeGridNode;
|
|
677
754
|
const nodeB = b as TreeGridNode;
|
|
678
755
|
return nodeA.profileNode.totalTime - nodeB.profileNode.totalTime;
|
|
@@ -714,13 +791,16 @@ export class TimelineTreeView extends TimelineTreeViewBase implements UI.Searcha
|
|
|
714
791
|
return;
|
|
715
792
|
}
|
|
716
793
|
this.detailsView.detachChildWidgets();
|
|
717
|
-
this.detailsView.element.removeChildren();
|
|
718
794
|
this.lastSelectedNodeInternal = selectedNode;
|
|
795
|
+
// Clear placeholder via Lit before calling showDetailsForNode so that
|
|
796
|
+
// subclasses can either render details declaratively into the same
|
|
797
|
+
// container without corrupting Lit's part tree, or synchronously attach
|
|
798
|
+
// child widgets without having them removed.
|
|
799
|
+
renderDetailsPlaceholder({showPlaceholder: false}, undefined, this.detailsView.element);
|
|
719
800
|
if (selectedNode && this.showDetailsForNode(selectedNode)) {
|
|
720
801
|
return;
|
|
721
802
|
}
|
|
722
|
-
|
|
723
|
-
UI.UIUtils.createTextChild(banner, i18nString(UIStrings.selectItemForDetails));
|
|
803
|
+
renderDetailsPlaceholder({showPlaceholder: true}, undefined, this.detailsView.element);
|
|
724
804
|
}
|
|
725
805
|
|
|
726
806
|
showDetailsForNode(_node: Trace.Extras.TraceTree.Node): boolean {
|
|
@@ -776,13 +856,14 @@ export class TimelineTreeView extends TimelineTreeViewBase implements UI.Searcha
|
|
|
776
856
|
|
|
777
857
|
onGridNodeOpened(): void {
|
|
778
858
|
const gridNode = this.dataGrid.selectedNode as TreeGridNode;
|
|
779
|
-
// Use tree's hover method in case of unique hover experiences (like
|
|
859
|
+
// Use tree's hover method in case of unique hover experiences (like
|
|
860
|
+
// ThirdPartyTree).
|
|
780
861
|
this.onHover(gridNode.profileNode);
|
|
781
862
|
this.updateDetailsForSelection();
|
|
782
863
|
}
|
|
783
864
|
|
|
784
|
-
private onContextMenu(
|
|
785
|
-
|
|
865
|
+
private onContextMenu(contextMenu: UI.ContextMenu.ContextMenu,
|
|
866
|
+
eventGridNode: DataGrid.DataGrid.DataGridNode<GridNode>): void {
|
|
786
867
|
const gridNode = (eventGridNode as GridNode);
|
|
787
868
|
if (gridNode.linkElement) {
|
|
788
869
|
contextMenu.appendApplicableItems(gridNode.linkElement);
|
|
@@ -861,17 +942,26 @@ export namespace TimelineTreeView {
|
|
|
861
942
|
}
|
|
862
943
|
|
|
863
944
|
export interface EventTypes {
|
|
864
|
-
[Events.TREE_ROW_HOVERED]: {
|
|
945
|
+
[Events.TREE_ROW_HOVERED]: {
|
|
946
|
+
node: Trace.Extras.TraceTree.Node|null,
|
|
947
|
+
events?: Trace.Types.Events.Event[],
|
|
948
|
+
};
|
|
865
949
|
[Events.BOTTOM_UP_BUTTON_CLICKED]: Trace.Extras.TraceTree.Node|null;
|
|
866
|
-
[Events.TREE_ROW_CLICKED]: {
|
|
950
|
+
[Events.TREE_ROW_CLICKED]: {
|
|
951
|
+
node: Trace.Extras.TraceTree.Node|null,
|
|
952
|
+
events?: Trace.Types.Events.Event[],
|
|
953
|
+
};
|
|
867
954
|
}
|
|
868
955
|
}
|
|
869
956
|
|
|
870
957
|
/**
|
|
871
|
-
* GridNodes are 1:1 with `TraceTree.Node`s but represent them within the
|
|
872
|
-
*
|
|
958
|
+
* GridNodes are 1:1 with `TraceTree.Node`s but represent them within the
|
|
959
|
+
* DataGrid. It handles the representation as a row. `TreeGridNode` extends this
|
|
960
|
+
* to maintain relationship to the tree, and handles populate().
|
|
873
961
|
*
|
|
874
|
-
* `TimelineStackView` (aka heaviest stack) uses GridNode directly (as there's
|
|
962
|
+
* `TimelineStackView` (aka heaviest stack) uses GridNode directly (as there's
|
|
963
|
+
* no hierarchy there), otherwise these TreeGridNode could probably be
|
|
964
|
+
* consolidated.
|
|
875
965
|
*/
|
|
876
966
|
export class GridNode extends DataGrid.SortableDataGrid.SortableDataGridNode<GridNode> {
|
|
877
967
|
protected populated: boolean;
|
|
@@ -882,9 +972,8 @@ export class GridNode extends DataGrid.SortableDataGrid.SortableDataGridNode<Gri
|
|
|
882
972
|
protected maxTotalTime: number;
|
|
883
973
|
linkElement: Element|null;
|
|
884
974
|
|
|
885
|
-
constructor(
|
|
886
|
-
|
|
887
|
-
treeView: TimelineTreeView) {
|
|
975
|
+
constructor(profileNode: Trace.Extras.TraceTree.Node, grandTotalTime: number, maxSelfTime: number,
|
|
976
|
+
maxTotalTime: number, treeView: TimelineTreeView) {
|
|
888
977
|
super(null, false);
|
|
889
978
|
this.populated = false;
|
|
890
979
|
this.profileNode = profileNode;
|
|
@@ -1026,7 +1115,8 @@ export class GridNode extends DataGrid.SortableDataGrid.SortableDataGridNode<Gri
|
|
|
1026
1115
|
return cell;
|
|
1027
1116
|
}
|
|
1028
1117
|
|
|
1029
|
-
// Generates bottom up tree hover button and appends it to the provided cell
|
|
1118
|
+
// Generates bottom up tree hover button and appends it to the provided cell
|
|
1119
|
+
// element.
|
|
1030
1120
|
private generateBottomUpButton(textDiv: HTMLElement): void {
|
|
1031
1121
|
const button = new Buttons.Button.Button();
|
|
1032
1122
|
button.data = {
|
|
@@ -1044,8 +1134,8 @@ export class GridNode extends DataGrid.SortableDataGrid.SortableDataGridNode<Gri
|
|
|
1044
1134
|
}
|
|
1045
1135
|
|
|
1046
1136
|
#bottomUpButtonClicked(): void {
|
|
1047
|
-
// We should also trigger an event to "unhover" the 3P tree row. Since this
|
|
1048
|
-
// triggered when clicking the bottom up button.
|
|
1137
|
+
// We should also trigger an event to "unhover" the 3P tree row. Since this
|
|
1138
|
+
// isn't triggered when clicking the bottom up button.
|
|
1049
1139
|
this.treeView.dispatchEventToListeners(TimelineTreeView.Events.TREE_ROW_HOVERED, {node: null});
|
|
1050
1140
|
this.treeView.dispatchEventToListeners(TimelineTreeView.Events.BOTTOM_UP_BUTTON_CLICKED, this.profileNode);
|
|
1051
1141
|
}
|
|
@@ -1055,9 +1145,8 @@ export class GridNode extends DataGrid.SortableDataGrid.SortableDataGridNode<Gri
|
|
|
1055
1145
|
* `TreeGridNode` lets a `GridNode` (row) populate based on its tree children.
|
|
1056
1146
|
*/
|
|
1057
1147
|
export class TreeGridNode extends GridNode {
|
|
1058
|
-
constructor(
|
|
1059
|
-
|
|
1060
|
-
treeView: TimelineTreeView) {
|
|
1148
|
+
constructor(profileNode: Trace.Extras.TraceTree.Node, grandTotalTime: number, maxSelfTime: number,
|
|
1149
|
+
maxTotalTime: number, treeView: TimelineTreeView) {
|
|
1061
1150
|
super(profileNode, grandTotalTime, maxSelfTime, maxTotalTime, treeView);
|
|
1062
1151
|
this.setHasChildren(this.profileNode.hasChildren());
|
|
1063
1152
|
treeNodeToGridNode.set(profileNode, this);
|
|
@@ -1091,18 +1180,21 @@ export class AggregatedTimelineTreeView extends TimelineTreeView {
|
|
|
1091
1180
|
|
|
1092
1181
|
constructor(element?: HTMLElement) {
|
|
1093
1182
|
super(element);
|
|
1094
|
-
this.groupBySetting = Common.Settings.Settings.instance().createSetting(
|
|
1095
|
-
|
|
1183
|
+
this.groupBySetting = Common.Settings.Settings.instance().createSetting('timeline-tree-group-by',
|
|
1184
|
+
AggregatedTimelineTreeView.GroupBy.None);
|
|
1096
1185
|
this.init();
|
|
1097
1186
|
this.stackView = new TimelineStackView(this);
|
|
1098
1187
|
this.stackView.addEventListener(TimelineStackView.Events.SELECTION_CHANGED, this.onStackViewSelectionChanged, this);
|
|
1099
1188
|
}
|
|
1100
1189
|
|
|
1101
1190
|
override refreshTree(forceRefresh = false): void {
|
|
1102
|
-
if (this.
|
|
1191
|
+
if (this.isShowing() || forceRefresh) {
|
|
1103
1192
|
this.#builtGroupBy = this.groupBySetting.get();
|
|
1104
1193
|
}
|
|
1105
1194
|
super.refreshTree(forceRefresh);
|
|
1195
|
+
if (this.element.parentElement || forceRefresh) {
|
|
1196
|
+
this.updateDetailsForSelection();
|
|
1197
|
+
}
|
|
1106
1198
|
}
|
|
1107
1199
|
|
|
1108
1200
|
override wasShown(): void {
|
|
@@ -1131,8 +1223,8 @@ export class AggregatedTimelineTreeView extends TimelineTreeView {
|
|
|
1131
1223
|
this.updateDetailsForSelection();
|
|
1132
1224
|
}
|
|
1133
1225
|
|
|
1134
|
-
private beautifyDomainName(this: AggregatedTimelineTreeView, name: string,
|
|
1135
|
-
|
|
1226
|
+
private beautifyDomainName(this: AggregatedTimelineTreeView, name: string,
|
|
1227
|
+
node: Trace.Extras.TraceTree.Node): string {
|
|
1136
1228
|
if (AggregatedTimelineTreeView.isExtensionInternalURL(name as Platform.DevToolsPath.UrlString)) {
|
|
1137
1229
|
name = i18nString(UIStrings.chromeExtensionsOverhead);
|
|
1138
1230
|
} else if (AggregatedTimelineTreeView.isV8NativeURL(name as Platform.DevToolsPath.UrlString)) {
|
|
@@ -1169,7 +1261,8 @@ export class AggregatedTimelineTreeView extends TimelineTreeView {
|
|
|
1169
1261
|
case AggregatedTimelineTreeView.GroupBy.Subdomain:
|
|
1170
1262
|
case AggregatedTimelineTreeView.GroupBy.ThirdParties: {
|
|
1171
1263
|
// This `undefined` is [unattributed]
|
|
1172
|
-
// TODO(paulirish): Improve attribution to reduce amount of items in
|
|
1264
|
+
// TODO(paulirish): Improve attribution to reduce amount of items in
|
|
1265
|
+
// [unattributed].
|
|
1173
1266
|
const domainName = id ? this.beautifyDomainName(id, node) : undefined;
|
|
1174
1267
|
return {name: domainName || unattributed, color};
|
|
1175
1268
|
}
|
|
@@ -1208,13 +1301,22 @@ export class AggregatedTimelineTreeView extends TimelineTreeView {
|
|
|
1208
1301
|
const groupBy = AggregatedTimelineTreeView.GroupBy;
|
|
1209
1302
|
const options = [
|
|
1210
1303
|
{label: i18nString(UIStrings.noGrouping), value: groupBy.None},
|
|
1211
|
-
{
|
|
1304
|
+
{
|
|
1305
|
+
label: i18nString(UIStrings.groupByActivity),
|
|
1306
|
+
value: groupBy.EventName,
|
|
1307
|
+
},
|
|
1212
1308
|
{label: i18nString(UIStrings.groupByCategory), value: groupBy.Category},
|
|
1213
1309
|
{label: i18nString(UIStrings.groupByDomain), value: groupBy.Domain},
|
|
1214
1310
|
{label: i18nString(UIStrings.groupByFrame), value: groupBy.Frame},
|
|
1215
|
-
{
|
|
1311
|
+
{
|
|
1312
|
+
label: i18nString(UIStrings.groupBySubdomain),
|
|
1313
|
+
value: groupBy.Subdomain,
|
|
1314
|
+
},
|
|
1216
1315
|
{label: i18nString(UIStrings.groupByUrl), value: groupBy.URL},
|
|
1217
|
-
{
|
|
1316
|
+
{
|
|
1317
|
+
label: i18nString(UIStrings.groupByThirdParties),
|
|
1318
|
+
value: groupBy.ThirdParties,
|
|
1319
|
+
},
|
|
1218
1320
|
];
|
|
1219
1321
|
toolbar.appendToolbarItem(
|
|
1220
1322
|
new UI.Toolbar.ToolbarSettingComboBox(options, this.groupBySetting, i18nString(UIStrings.groupBy)));
|
|
@@ -1290,9 +1392,11 @@ export class AggregatedTimelineTreeView extends TimelineTreeView {
|
|
|
1290
1392
|
}
|
|
1291
1393
|
}
|
|
1292
1394
|
|
|
1293
|
-
// This is our groupingFunction that returns the eventId in Domain, Subdomain,
|
|
1294
|
-
// The eventid == the identity of a node
|
|
1295
|
-
//
|
|
1395
|
+
// This is our groupingFunction that returns the eventId in Domain, Subdomain,
|
|
1396
|
+
// and ThirdParty groupBy scenarios. The eventid == the identity of a node
|
|
1397
|
+
// that we expect in a bottomUp tree (either without grouping or with the
|
|
1398
|
+
// groupBy grouping) A "top node" (in `ungroupedTopNodes`) is aggregated by
|
|
1399
|
+
// this. (But so are all the other nodes, except the `GroupNode`s)
|
|
1296
1400
|
private domainByEvent(groupBy: AggregatedTimelineTreeView.GroupBy, event: Trace.Types.Events.Event): string {
|
|
1297
1401
|
const parsedTrace = this.parsedTrace;
|
|
1298
1402
|
if (!parsedTrace) {
|
|
@@ -1300,8 +1404,9 @@ export class AggregatedTimelineTreeView extends TimelineTreeView {
|
|
|
1300
1404
|
}
|
|
1301
1405
|
const url = Trace.Handlers.Helpers.getNonResolvedURL(event, parsedTrace.data);
|
|
1302
1406
|
if (!url) {
|
|
1303
|
-
// We could have receiveDataEvents (that don't have a url), but that have
|
|
1304
|
-
// attributed to an entity, let's check for these. This is used for
|
|
1407
|
+
// We could have receiveDataEvents (that don't have a url), but that have
|
|
1408
|
+
// been attributed to an entity, let's check for these. This is used for
|
|
1409
|
+
// ThirdParty grouping.
|
|
1305
1410
|
const entity = this.entityMapper()?.entityForEvent(event);
|
|
1306
1411
|
if (groupBy === AggregatedTimelineTreeView.GroupBy.ThirdParties && entity) {
|
|
1307
1412
|
if (!entity) {
|
|
@@ -1393,7 +1498,8 @@ export class AggregatedTimelineTreeView extends TimelineTreeView {
|
|
|
1393
1498
|
}
|
|
1394
1499
|
export namespace AggregatedTimelineTreeView {
|
|
1395
1500
|
export enum GroupBy {
|
|
1396
|
-
/* eslint-disable @typescript-eslint/naming-convention -- Used by web_tests.
|
|
1501
|
+
/* eslint-disable @typescript-eslint/naming-convention -- Used by web_tests.
|
|
1502
|
+
*/
|
|
1397
1503
|
None = 'None',
|
|
1398
1504
|
EventName = 'EventName',
|
|
1399
1505
|
Category = 'Category',
|
|
@@ -1434,9 +1540,11 @@ export class BottomUpTimelineTreeView extends AggregatedTimelineTreeView {
|
|
|
1434
1540
|
endTime: this.endTime,
|
|
1435
1541
|
eventGroupIdCallback: this.groupingFunction(this.groupBySetting.get()),
|
|
1436
1542
|
// To include instant events. When this is set to true, instant events are
|
|
1437
|
-
// considered (to calculate transfer size). This then includes these
|
|
1543
|
+
// considered (to calculate transfer size). This then includes these
|
|
1544
|
+
// events in tree nodes.
|
|
1438
1545
|
calculateTransferSize: true,
|
|
1439
|
-
// We should forceGroupIdCallback if filtering by 3P for correct 3P
|
|
1546
|
+
// We should forceGroupIdCallback if filtering by 3P for correct 3P
|
|
1547
|
+
// grouping.
|
|
1440
1548
|
forceGroupIdCallback: this.groupBySetting.get() === AggregatedTimelineTreeView.GroupBy.ThirdParties,
|
|
1441
1549
|
});
|
|
1442
1550
|
}
|
|
@@ -1457,8 +1565,18 @@ export class TimelineStackView extends TimelineStackViewBase {
|
|
|
1457
1565
|
header.textContent = i18nString(UIStrings.heaviestStack);
|
|
1458
1566
|
this.treeView = treeView;
|
|
1459
1567
|
const columns: DataGrid.DataGrid.ColumnDescriptor[] = [
|
|
1460
|
-
{
|
|
1461
|
-
|
|
1568
|
+
{
|
|
1569
|
+
id: 'total',
|
|
1570
|
+
title: i18nString(UIStrings.totalTime),
|
|
1571
|
+
fixedWidth: true,
|
|
1572
|
+
width: '110px',
|
|
1573
|
+
sortable: false,
|
|
1574
|
+
},
|
|
1575
|
+
{
|
|
1576
|
+
id: 'activity',
|
|
1577
|
+
title: i18nString(UIStrings.activity),
|
|
1578
|
+
sortable: false,
|
|
1579
|
+
},
|
|
1462
1580
|
];
|
|
1463
1581
|
this.dataGrid = new DataGrid.ViewportDataGrid.ViewportDataGrid({
|
|
1464
1582
|
displayName: i18nString(UIStrings.timelineStack),
|