chrome-devtools-frontend 1.0.1726686 → 1.0.1730971

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (490) hide show
  1. package/.agents/rules/tests/test-strict-assertions-and-literal-expectations.md +1 -1
  2. package/.agents/rules/tests/test-view-and-presenter-isolation.md +1 -1
  3. package/.agents/rules/ui-and-widgets/ui-accessibility-and-semantic-html.md +1 -1
  4. package/.agents/rules/ui-and-widgets/ui-css-scoping-and-flex-layout.md +2 -2
  5. package/.agents/rules/ui-and-widgets/ui-declarative-child-widget-composition.md +5 -5
  6. package/.agents/rules/ui-and-widgets/ui-lit-declarative-templates-and-directives.md +2 -2
  7. package/.agents/rules/ui-and-widgets/ui-localization-and-uistrings-hygiene.md +2 -2
  8. package/.agents/rules/ui-and-widgets/ui-modern-component-and-encapsulation-standards.md +3 -3
  9. package/.agents/rules/ui-and-widgets/ui-pure-view-and-presenter-separation.md +2 -2
  10. package/.agents/rules/ui-and-widgets/ui-reactive-widget-update-lifecycle.md +2 -2
  11. package/.agents/rules/ui-and-widgets/ui-view-output-and-callback-contracts.md +2 -2
  12. package/.agents/rules/ui-and-widgets/ui-widget-dom-and-listener-lifecycle.md +2 -2
  13. package/.agents/skills/code-review/SKILL.md +63 -12
  14. package/.agents/skills/ui-eng-vision-local-lit-renderer/SKILL.md +38 -10
  15. package/.agents/skills/ui-eng-vision-widget-promoter/SKILL.md +1 -0
  16. package/.agents/skills/ui-widgets/SKILL.md +8 -2
  17. package/.agents/skills/write-ai-eval-test/SKILL.md +106 -0
  18. package/AUTHORS +2 -0
  19. package/DIR_METADATA +1 -2
  20. package/README.md +48 -26
  21. package/config/typescript/tsconfig.base.json +1 -0
  22. package/config/typescript/tsconfig.eslint.json +1 -0
  23. package/docs/contributing/changes.md +25 -0
  24. package/docs/ui_engineering.md +13 -4
  25. package/eslint.config.mjs +323 -41
  26. package/front_end/core/common/Color.ts +7 -7
  27. package/front_end/core/common/ParsedURL.ts +3 -3
  28. package/front_end/core/common/ResolverBase.ts +3 -3
  29. package/front_end/core/common/SegmentedRange.ts +3 -3
  30. package/front_end/core/common/SimpleHistoryManager.ts +14 -14
  31. package/front_end/core/common/Trie.ts +3 -3
  32. package/front_end/core/common/VersionController.ts +7 -7
  33. package/front_end/core/host/InspectorFrontendHost.ts +2 -2
  34. package/front_end/core/host/InspectorFrontendHostAPI.ts +9 -1
  35. package/front_end/core/host/InspectorFrontendHostStub.ts +1 -1
  36. package/front_end/core/host/UserMetrics.ts +4 -0
  37. package/front_end/core/host/UserMetricsEnums.ts +2 -1
  38. package/front_end/core/platform/StringUtilities.ts +54 -13
  39. package/front_end/core/platform/node/HostRuntime.ts +13 -7
  40. package/front_end/core/protocol_client/DevToolsCDPConnection.ts +4 -5
  41. package/front_end/core/root/Runtime.ts +5 -0
  42. package/front_end/core/sdk/AccessibilityModel.ts +5 -5
  43. package/front_end/core/sdk/AnimationModel.ts +17 -19
  44. package/front_end/core/sdk/CPUProfilerModel.ts +3 -3
  45. package/front_end/core/sdk/CPUThrottlingManager.ts +7 -0
  46. package/front_end/core/sdk/CSSMatchedStyles.ts +73 -13
  47. package/front_end/core/sdk/CSSMetadata.ts +7 -7
  48. package/front_end/core/sdk/CSSModel.ts +33 -33
  49. package/front_end/core/sdk/CSSProperty.ts +5 -5
  50. package/front_end/core/sdk/CSSRule.ts +6 -6
  51. package/front_end/core/sdk/CSSStyleSheetHeader.ts +4 -4
  52. package/front_end/core/sdk/Connections.ts +16 -16
  53. package/front_end/core/sdk/ConsoleModel.ts +44 -47
  54. package/front_end/core/sdk/CookieParser.ts +11 -11
  55. package/front_end/core/sdk/EmulationModel.ts +35 -36
  56. package/front_end/core/sdk/EventBreakpointsModel.ts +11 -11
  57. package/front_end/core/sdk/FrameManager.ts +16 -16
  58. package/front_end/core/sdk/IsolateManager.ts +2 -2
  59. package/front_end/core/sdk/IssuesModel.ts +2 -2
  60. package/front_end/core/sdk/OverlayModel.ts +19 -19
  61. package/front_end/core/sdk/PageResourceLoader.ts +14 -16
  62. package/front_end/core/sdk/RemoteObject.ts +9 -9
  63. package/front_end/core/sdk/Resource.ts +2 -2
  64. package/front_end/core/sdk/RuntimeModel.ts +7 -7
  65. package/front_end/core/sdk/Script.ts +6 -6
  66. package/front_end/core/sdk/ServiceWorkerManager.ts +36 -10
  67. package/front_end/core/sdk/SourceMap.ts +18 -20
  68. package/front_end/core/sdk/SourceMapManager.ts +2 -2
  69. package/front_end/core/sdk/TargetManager.ts +2 -2
  70. package/front_end/devtools_compatibility.js +7 -3
  71. package/front_end/entrypoints/inspector_main/InspectorMain.ts +2 -2
  72. package/front_end/entrypoints/node_app/app/NodeConnectionsPanel.ts +203 -115
  73. package/front_end/generated/InspectorBackendCommands.ts +1 -1
  74. package/front_end/generated/SupportedCSSProperties.ts +1 -3
  75. package/front_end/generated/protocol.ts +1 -0
  76. package/front_end/models/ai_assistance/AiAgent2.ts +36 -12
  77. package/front_end/models/ai_assistance/AiConversation.ts +8 -2
  78. package/front_end/models/ai_assistance/agents/AiAgent.ts +137 -62
  79. package/front_end/models/ai_assistance/agents/ExecuteJavascript.ts +2 -2
  80. package/front_end/models/ai_assistance/agents/StylingAgent.snapshot.txt +2 -2
  81. package/front_end/models/ai_assistance/data_formatters/LighthouseFormatter.snapshot.txt +149 -2
  82. package/front_end/models/ai_assistance/data_formatters/LighthouseFormatter.ts +269 -42
  83. package/front_end/models/ai_assistance/tools/ExecuteJavaScript.ts +3 -0
  84. package/front_end/models/ai_assistance/tools/GetLighthouseAudits.ts +9 -0
  85. package/front_end/models/ai_assistance/tools/ResolveDevtoolsNodePath.ts +13 -2
  86. package/front_end/models/ai_assistance/tools/RunLighthouse.ts +23 -7
  87. package/front_end/models/ai_assistance/tools/Tool.ts +7 -5
  88. package/front_end/models/bindings/CSSWorkspaceBinding.ts +22 -24
  89. package/front_end/models/bindings/DebuggerLanguagePlugins.ts +60 -60
  90. package/front_end/models/bindings/DebuggerWorkspaceBinding.ts +24 -24
  91. package/front_end/models/bindings/DefaultScriptMapping.ts +8 -8
  92. package/front_end/models/bindings/FileUtils.ts +13 -13
  93. package/front_end/models/bindings/PresentationConsoleMessageHelper.ts +3 -3
  94. package/front_end/models/bindings/ResourceScriptMapping.ts +23 -23
  95. package/front_end/models/comment_manager/CommentManager.ts +3 -3
  96. package/front_end/models/comment_manager/CommentThread.ts +50 -5
  97. package/front_end/models/cpu_profile/CPUProfileDataModel.ts +14 -14
  98. package/front_end/models/cpu_profile/ProfileTreeModel.ts +4 -4
  99. package/front_end/models/elements/StyleChanges.ts +38 -0
  100. package/front_end/models/emulation/EmulatedDevices.ts +12 -12
  101. package/front_end/models/har/HARFormat.ts +4 -4
  102. package/front_end/models/javascript_metadata/NativeFunctions.ts +5 -1
  103. package/front_end/models/lighthouse/LighthouseReporterTypes.ts +57 -3
  104. package/front_end/models/lighthouse/RunTypes.ts +9 -1
  105. package/front_end/models/logs/LogManager.ts +2 -2
  106. package/front_end/models/persistence/AutomaticFileSystemManager.ts +3 -0
  107. package/front_end/models/persistence/FileSystemWorkspaceBinding.ts +24 -24
  108. package/front_end/models/persistence/IsolatedFileSystemManager.ts +6 -0
  109. package/front_end/models/persistence/NetworkPersistenceManager.ts +8 -3
  110. package/front_end/models/trace/LanternComputationData.ts +37 -11
  111. package/front_end/models/trace/Processor.ts +2 -1
  112. package/front_end/models/trace/extras/TraceTree.ts +36 -10
  113. package/front_end/models/trace/handlers/InitiatorsHandler.ts +27 -34
  114. package/front_end/models/trace/handlers/LayoutShiftsHandler.ts +2 -6
  115. package/front_end/models/trace/handlers/SamplesHandler.ts +9 -6
  116. package/front_end/models/workspace/FileManager.ts +6 -0
  117. package/front_end/panels/accessibility/ARIAAttributesView.ts +4 -4
  118. package/front_end/panels/accessibility/AccessibilityAnnouncementRecordingView.ts +8 -1
  119. package/front_end/panels/accessibility/AccessibilityNodeView.ts +15 -17
  120. package/front_end/panels/accessibility/AccessibilitySubPane.ts +1 -1
  121. package/front_end/panels/ai_assistance/AiAssistancePanel.ts +5 -5
  122. package/front_end/panels/ai_assistance/ExternalHandler.ts +10 -1
  123. package/front_end/panels/ai_assistance/components/ChatMessage.ts +27 -22
  124. package/front_end/panels/ai_assistance/components/DisabledWidget.ts +19 -23
  125. package/front_end/panels/ai_assistance/components/ExploreWidget.ts +2 -2
  126. package/front_end/panels/ai_assistance/components/PermissionPrompt.ts +23 -9
  127. package/front_end/panels/ai_assistance/components/chatInput.css +1 -1
  128. package/front_end/panels/animation/AnimationTimeline.ts +37 -17
  129. package/front_end/panels/animation/animationTimeline.css +19 -3
  130. package/front_end/panels/application/AppManifestView.ts +1 -2
  131. package/front_end/panels/application/ApplicationPanelSidebar.ts +143 -128
  132. package/front_end/panels/application/DOMStorageItemsView.ts +14 -14
  133. package/front_end/panels/application/DeviceBoundSessionsView.ts +10 -13
  134. package/front_end/panels/application/ExtensionStorageItemsView.ts +3 -4
  135. package/front_end/panels/application/IndexedDBViews.ts +8 -4
  136. package/front_end/panels/application/KeyValueStorageItemsView.ts +4 -5
  137. package/front_end/panels/application/PrivateVerificationTokensView.ts +53 -0
  138. package/front_end/panels/application/ServiceWorkerCacheViews.ts +12 -8
  139. package/front_end/panels/application/ServiceWorkersView.ts +1 -2
  140. package/front_end/panels/application/StorageItemsToolbar.ts +3 -3
  141. package/front_end/panels/application/StorageView.ts +2 -2
  142. package/front_end/panels/application/WebMCPView.ts +91 -109
  143. package/front_end/panels/application/application.ts +2 -0
  144. package/front_end/panels/application/components/StorageMetadataView.ts +6 -6
  145. package/front_end/panels/application/preloading/PreloadingView.ts +70 -37
  146. package/front_end/panels/application/preloading/components/MismatchedPreloadingGrid.ts +2 -2
  147. package/front_end/panels/application/preloading/components/PreloadingDisabledInfobar.ts +3 -3
  148. package/front_end/panels/application/preloading/components/PreloadingGrid.ts +12 -0
  149. package/front_end/panels/application/preloading/components/RuleSetDetailsView.ts +10 -11
  150. package/front_end/panels/application/privateVerificationTokensView.css +20 -0
  151. package/front_end/panels/application/serviceWorkersView.css +2 -2
  152. package/front_end/panels/browser_debugger/DOMBreakpointsSidebarPane.ts +24 -24
  153. package/front_end/panels/changes/ChangesSidebar.ts +5 -5
  154. package/front_end/panels/changes/ChangesView.ts +10 -11
  155. package/front_end/panels/comments/CommentsPane.ts +292 -102
  156. package/front_end/panels/comments/commentsPane.css +93 -12
  157. package/front_end/panels/common/CommentThreadWidget.ts +69 -0
  158. package/front_end/panels/common/CommentsOverlayWidget.ts +108 -29
  159. package/front_end/panels/common/CommentsStatusBarPill.ts +17 -6
  160. package/front_end/panels/common/DOMLinkifier.ts +37 -12
  161. package/front_end/panels/common/ExtensionPanel.ts +13 -4
  162. package/front_end/panels/common/ExtensionServer.ts +27 -3
  163. package/front_end/panels/common/PersistenceUtils.ts +3 -3
  164. package/front_end/panels/common/commentThreadWidget.css +25 -1
  165. package/front_end/panels/common/common-meta.ts +10 -0
  166. package/front_end/panels/console/ConsolePinPane.ts +13 -15
  167. package/front_end/panels/console/ConsolePrompt.ts +173 -95
  168. package/front_end/panels/console/ConsoleSidebar.ts +2 -2
  169. package/front_end/panels/console/ConsoleView.ts +75 -79
  170. package/front_end/panels/console/ConsoleViewMessage.ts +52 -4
  171. package/front_end/panels/console/SymbolizedErrorWidget.ts +8 -4
  172. package/front_end/panels/console/consolePrompt.css +1 -1
  173. package/front_end/panels/console/consoleView.css +1 -1
  174. package/front_end/panels/console_counters/WarningErrorCounter.ts +3 -4
  175. package/front_end/panels/coverage/CoverageListView.ts +2 -2
  176. package/front_end/panels/coverage/CoverageView.ts +20 -5
  177. package/front_end/panels/css_overview/CSSOverviewCompletedView.ts +4 -3
  178. package/front_end/panels/css_overview/CSSOverviewPanel.ts +2 -2
  179. package/front_end/panels/css_overview/CSSOverviewProcessingView.ts +2 -2
  180. package/front_end/panels/css_overview/CSSOverviewSidebarPanel.ts +2 -2
  181. package/front_end/panels/css_overview/CSSOverviewStartView.ts +2 -2
  182. package/front_end/panels/css_overview/CSSOverviewUnusedDeclarations.ts +8 -8
  183. package/front_end/panels/developer_resources/DeveloperResourcesListView.ts +2 -3
  184. package/front_end/panels/developer_resources/DeveloperResourcesView.ts +4 -5
  185. package/front_end/panels/elements/AccessibilityTreeUtils.ts +6 -7
  186. package/front_end/panels/elements/CSSValueTraceView.ts +3 -3
  187. package/front_end/panels/elements/ClassesPaneWidget.ts +1 -2
  188. package/front_end/panels/elements/ComputedStyleWidget.ts +15 -14
  189. package/front_end/panels/elements/DOMTreeElementWidget.ts +5 -4
  190. package/front_end/panels/elements/DOMTreeWidget.ts +2 -1
  191. package/front_end/panels/elements/ElementStatePaneWidget.ts +2 -2
  192. package/front_end/panels/elements/ElementsPanel.ts +1 -0
  193. package/front_end/panels/elements/EventListenersWidget.ts +2 -2
  194. package/front_end/panels/elements/LayoutPane.ts +2 -2
  195. package/front_end/panels/elements/PlatformFontsWidget.ts +3 -3
  196. package/front_end/panels/elements/PropertiesWidget.ts +9 -10
  197. package/front_end/panels/elements/PropertyRenderer.ts +72 -11
  198. package/front_end/panels/elements/StandaloneStylesContainer.ts +5 -10
  199. package/front_end/panels/elements/StyleEditorWidget.ts +30 -16
  200. package/front_end/panels/elements/StylePropertiesSection.ts +93 -44
  201. package/front_end/panels/elements/StylePropertyTreeElement.ts +230 -302
  202. package/front_end/panels/elements/StylesContainer.ts +2 -3
  203. package/front_end/panels/elements/StylesSidebarPane.ts +4 -13
  204. package/front_end/panels/elements/components/AccessibilityTreeNode.ts +66 -37
  205. package/front_end/panels/elements/components/CSSHintDetailsView.ts +51 -41
  206. package/front_end/panels/elements/components/CSSPropertyDocsView.ts +75 -65
  207. package/front_end/panels/elements/components/CSSQuery.ts +112 -74
  208. package/front_end/panels/elements/components/CSSVariableValueView.ts +109 -68
  209. package/front_end/panels/elements/components/ComputedStyleProperty.ts +64 -45
  210. package/front_end/panels/elements/components/ElementsTreeExpandButton.ts +35 -28
  211. package/front_end/panels/elements/components/QueryContainer.ts +104 -74
  212. package/front_end/panels/elements/components/accessibilityTreeNode.css +22 -20
  213. package/front_end/panels/elements/components/computedStyleProperty.css +2 -0
  214. package/front_end/panels/elements/components/cssHintDetailsView.css +23 -21
  215. package/front_end/panels/elements/components/cssPropertyDocsView.css +38 -36
  216. package/front_end/panels/elements/components/cssVariableValueView.css +42 -40
  217. package/front_end/panels/elements/components/elementsTreeExpandButton.css +5 -2
  218. package/front_end/panels/elements/components/queryContainer.css +23 -21
  219. package/front_end/panels/elements/stylesSidebarPane.css +3 -3
  220. package/front_end/panels/emulation/DeviceModeToolbar.ts +2 -2
  221. package/front_end/panels/emulation/InspectedPagePlaceholder.ts +2 -2
  222. package/front_end/panels/emulation/MediaQueryInspector.ts +9 -10
  223. package/front_end/panels/emulation/mediaQueryInspector.css +1 -1
  224. package/front_end/panels/event_listeners/EventListenersView.ts +2 -2
  225. package/front_end/panels/issues/AffectedCookiesView.ts +144 -101
  226. package/front_end/panels/issues/AffectedDescendantsWithinSelectElementView.ts +83 -31
  227. package/front_end/panels/issues/AffectedDirectivesView.ts +218 -135
  228. package/front_end/panels/issues/AffectedDocumentsInQuirksModeView.ts +84 -34
  229. package/front_end/panels/issues/AffectedElementsView.ts +86 -23
  230. package/front_end/panels/issues/AffectedLazyLoadImagesView.ts +2 -2
  231. package/front_end/panels/issues/AffectedMetadataAllowedSitesView.ts +2 -2
  232. package/front_end/panels/issues/AffectedPartitioningBlobURLView.ts +36 -11
  233. package/front_end/panels/issues/AffectedSharedArrayBufferIssueDetailsView.ts +135 -58
  234. package/front_end/panels/issues/AffectedSourcesView.ts +49 -28
  235. package/front_end/panels/issues/AffectedTrackingSitesView.ts +3 -4
  236. package/front_end/panels/issues/CorsIssueDetailsView.ts +490 -269
  237. package/front_end/panels/issues/GenericIssueDetailsView.ts +2 -2
  238. package/front_end/panels/issues/IssueKindView.ts +63 -48
  239. package/front_end/panels/issues/IssueView.ts +14 -18
  240. package/front_end/panels/issues/components/ElementsPanelLink.ts +70 -34
  241. package/front_end/panels/issues/components/HideIssuesMenu.ts +56 -32
  242. package/front_end/panels/issues/components/elementsPanelLink.css +10 -6
  243. package/front_end/panels/issues/components/hideIssuesMenu.css +16 -14
  244. package/front_end/panels/issues/issues.ts +2 -0
  245. package/front_end/panels/issues/issuesTree.css +4 -4
  246. package/front_end/panels/lighthouse/LighthouseController.ts +6 -6
  247. package/front_end/panels/lighthouse/LighthouseStatusView.ts +12 -13
  248. package/front_end/panels/lighthouse/lighthouseStartView.css +1 -1
  249. package/front_end/panels/linear_memory_inspector/LinearMemoryInspectorPane.ts +159 -161
  250. package/front_end/panels/linear_memory_inspector/LinearMemoryInspectorView.ts +228 -0
  251. package/front_end/panels/linear_memory_inspector/components/LinearMemoryInspector.ts +32 -41
  252. package/front_end/panels/linear_memory_inspector/components/linearMemoryHighlightChipList.css +2 -2
  253. package/front_end/panels/linear_memory_inspector/linear_memory_inspector.ts +2 -0
  254. package/front_end/panels/media/EventDisplayTable.ts +2 -2
  255. package/front_end/panels/media/MainView.ts +132 -66
  256. package/front_end/panels/media/PlayerDetailView.ts +32 -14
  257. package/front_end/panels/media/PlayerListView.ts +83 -23
  258. package/front_end/panels/media/PlayerPropertiesView.ts +2 -2
  259. package/front_end/panels/media/TickingFlameChart.ts +153 -63
  260. package/front_end/panels/mobile_throttling/NetworkThrottlingSelector.ts +2 -2
  261. package/front_end/panels/mobile_throttling/ThrottlingSettingsTab.ts +615 -464
  262. package/front_end/panels/mobile_throttling/throttlingSettingsTab.css +43 -0
  263. package/front_end/panels/network/EventSourceMessagesView.ts +3 -3
  264. package/front_end/panels/network/NetworkConfigView.ts +6 -2
  265. package/front_end/panels/network/NetworkDataGridNode.ts +2 -1
  266. package/front_end/panels/network/NetworkItemView.ts +27 -26
  267. package/front_end/panels/network/NetworkManageCustomHeadersView.ts +236 -97
  268. package/front_end/panels/network/NetworkOverview.ts +8 -10
  269. package/front_end/panels/network/RequestConditionsDrawer.ts +8 -4
  270. package/front_end/panels/network/RequestDeviceBoundSessionsView.ts +2 -4
  271. package/front_end/panels/network/RequestHTMLView.ts +26 -7
  272. package/front_end/panels/network/RequestHeadersView.ts +2 -2
  273. package/front_end/panels/network/RequestInitiatorView.ts +21 -22
  274. package/front_end/panels/network/RequestPayloadView.ts +2 -16
  275. package/front_end/panels/network/RequestPreviewView.ts +5 -5
  276. package/front_end/panels/network/RequestTimingView.ts +6 -6
  277. package/front_end/panels/network/ResourceDirectSocketChunkView.ts +5 -6
  278. package/front_end/panels/network/ResourceWebSocketFrameView.ts +4 -3
  279. package/front_end/panels/network/ShowMoreDetailsWidget.ts +11 -12
  280. package/front_end/panels/network/SignedExchangeInfoView.ts +2 -2
  281. package/front_end/panels/network/networkLogView.css +2 -2
  282. package/front_end/panels/network/networkManageCustomHeadersView.css +27 -6
  283. package/front_end/panels/network/requestConditionsDrawer.css +1 -1
  284. package/front_end/panels/network/requestInitiatorView.css +5 -3
  285. package/front_end/panels/performance_monitor/PerformanceMonitor.ts +2 -2
  286. package/front_end/panels/profiler/HeapDetachedElementsView.ts +1 -2
  287. package/front_end/panels/profiler/HeapTimelineOverview.ts +77 -15
  288. package/front_end/panels/profiler/IsolateSelector.ts +258 -187
  289. package/front_end/panels/profiler/ProfileLauncherView.ts +7 -29
  290. package/front_end/panels/profiler/profileLauncherView.css +6 -1
  291. package/front_end/panels/protocol_monitor/JSONEditor.ts +4 -5
  292. package/front_end/panels/recorder/ControlButton.ts +1 -1
  293. package/front_end/panels/recorder/RecordingListView.ts +2 -4
  294. package/front_end/panels/recorder/RecordingView.ts +1 -2
  295. package/front_end/panels/recorder/SelectorPicker.ts +2 -4
  296. package/front_end/panels/recorder/StepView.ts +24 -10
  297. package/front_end/panels/recorder/TimelineSection.ts +1 -1
  298. package/front_end/panels/recorder/recordingView.css +1 -1
  299. package/front_end/panels/screencast/ScreencastApp.ts +1 -1
  300. package/front_end/panels/search/SearchResultsPane.ts +11 -12
  301. package/front_end/panels/search/SearchView.ts +8 -10
  302. package/front_end/panels/security/SecurityPanel.ts +1 -8
  303. package/front_end/panels/security/SecurityPanelSidebar.ts +2 -2
  304. package/front_end/panels/security/mainView.css +1 -1
  305. package/front_end/panels/sensors/LocationsSettingsTab.ts +1 -2
  306. package/front_end/panels/settings/AISettingsTab.ts +1 -1
  307. package/front_end/panels/settings/BackendLinkingSettingsTab.ts +34 -20
  308. package/front_end/panels/settings/EditFileSystemView.ts +2 -2
  309. package/front_end/panels/settings/FrameworkIgnoreListSettingsTab.ts +375 -197
  310. package/front_end/panels/settings/KeybindsSettingsTab.ts +570 -414
  311. package/front_end/panels/settings/SettingsScreen.ts +312 -114
  312. package/front_end/panels/settings/WorkspaceSettingsTab.ts +2 -2
  313. package/front_end/panels/settings/aiSettingsTab.css +1 -4
  314. package/front_end/panels/settings/emulation/DevicesSettingsTab.ts +924 -578
  315. package/front_end/panels/settings/emulation/components/UserAgentClientHintsForm.ts +9 -2
  316. package/front_end/panels/settings/emulation/devicesSettingsTab.css +39 -0
  317. package/front_end/panels/settings/frameworkIgnoreListSettingsTab.css +37 -8
  318. package/front_end/panels/settings/settingsScreen.css +0 -24
  319. package/front_end/panels/sources/BreakpointEditDialog.ts +9 -6
  320. package/front_end/panels/sources/BreakpointsView.ts +25 -4
  321. package/front_end/panels/sources/CallStackSidebarPane.ts +7 -1
  322. package/front_end/panels/sources/DebuggerPlugin.ts +1 -0
  323. package/front_end/panels/sources/GoToLineQuickOpen.ts +8 -8
  324. package/front_end/panels/sources/NavigatorView.ts +521 -439
  325. package/front_end/panels/sources/PersistenceActions.ts +11 -12
  326. package/front_end/panels/sources/ProfilePlugin.ts +28 -17
  327. package/front_end/panels/sources/ScopeChainSidebarPane.ts +3 -4
  328. package/front_end/panels/sources/SourcesNavigator.ts +9 -9
  329. package/front_end/panels/sources/SourcesPanel.ts +2 -2
  330. package/front_end/panels/sources/SourcesView.ts +3 -3
  331. package/front_end/panels/sources/ThreadsSidebarPane.ts +2 -2
  332. package/front_end/panels/sources/WatchExpressionsSidebarPane.ts +2 -2
  333. package/front_end/panels/sources/components/HeadersView.ts +1 -2
  334. package/front_end/panels/timeline/CompatibilityTracksAppender.ts +5 -6
  335. package/front_end/panels/timeline/EventsTimelineTreeView.ts +73 -34
  336. package/front_end/panels/timeline/IsolateSelector.ts +25 -37
  337. package/front_end/panels/timeline/StatusDialog.ts +5 -7
  338. package/front_end/panels/timeline/ThirdPartyTreeView.ts +10 -13
  339. package/front_end/panels/timeline/TimelineDetailsView.ts +40 -21
  340. package/front_end/panels/timeline/TimelineEventOverview.ts +130 -34
  341. package/front_end/panels/timeline/TimelineFlameChartNetworkDataProvider.ts +1 -1
  342. package/front_end/panels/timeline/TimelineMiniMap.ts +255 -103
  343. package/front_end/panels/timeline/TimelinePaintProfilerView.ts +19 -11
  344. package/front_end/panels/timeline/TimelinePanel.ts +1 -0
  345. package/front_end/panels/timeline/TimelineSelectorStatsView.ts +11 -12
  346. package/front_end/panels/timeline/TimelineTreeView.ts +240 -122
  347. package/front_end/panels/timeline/TimelineUIUtils.ts +12 -0
  348. package/front_end/panels/timeline/components/BreadcrumbsUI.ts +5 -4
  349. package/front_end/panels/timeline/components/DetailsView.ts +97 -65
  350. package/front_end/panels/timeline/components/LayoutShiftDetails.ts +2 -2
  351. package/front_end/panels/timeline/components/MetricCard.ts +2 -2
  352. package/front_end/panels/timeline/components/NetworkRequestDetails.ts +11 -12
  353. package/front_end/panels/timeline/components/NetworkTrackWidget.ts +57 -50
  354. package/front_end/panels/timeline/components/RelatedInsightChips.ts +2 -2
  355. package/front_end/panels/timeline/components/Sidebar.ts +161 -109
  356. package/front_end/panels/timeline/components/SidebarAnnotationsTab.ts +33 -12
  357. package/front_end/panels/timeline/components/SidebarInsightsTab.ts +3 -0
  358. package/front_end/panels/timeline/components/insights/LCPDiscovery.ts +11 -11
  359. package/front_end/panels/timeline/components/insights/SlowCSSSelector.ts +6 -7
  360. package/front_end/panels/timeline/components/networkTrackWidget.css +24 -22
  361. package/front_end/panels/timeline/components/sidebarInsightsTab.css +1 -1
  362. package/front_end/panels/timeline/overlays/components/TimespanBreakdownOverlay.ts +15 -10
  363. package/front_end/panels/timeline/overlays/components/entryLabelOverlay.css +1 -1
  364. package/front_end/panels/timeline/timelinePanel.css +5 -0
  365. package/front_end/panels/timeline/timelineStatusDialog.css +1 -1
  366. package/front_end/panels/web_audio/WebAudioView.ts +2 -2
  367. package/front_end/third_party/chromium/README.chromium +1 -1
  368. package/front_end/third_party/legacy-javascript/README.chromium +2 -2
  369. package/front_end/third_party/legacy-javascript/lib/legacy-javascript.js +2 -2
  370. package/front_end/third_party/legacy-javascript/package.json +1 -1
  371. package/front_end/third_party/lighthouse/README.chromium +2 -2
  372. package/front_end/third_party/lighthouse/lighthouse-dt-bundle.js +1983 -2022
  373. package/front_end/third_party/lighthouse/locales/ar-XB.json +157 -142
  374. package/front_end/third_party/lighthouse/locales/ar.json +157 -142
  375. package/front_end/third_party/lighthouse/locales/bg.json +154 -139
  376. package/front_end/third_party/lighthouse/locales/ca.json +157 -142
  377. package/front_end/third_party/lighthouse/locales/cs.json +148 -133
  378. package/front_end/third_party/lighthouse/locales/da.json +153 -138
  379. package/front_end/third_party/lighthouse/locales/de.json +152 -137
  380. package/front_end/third_party/lighthouse/locales/el.json +153 -138
  381. package/front_end/third_party/lighthouse/locales/en-GB.json +160 -145
  382. package/front_end/third_party/lighthouse/locales/en-US.json +239 -218
  383. package/front_end/third_party/lighthouse/locales/en-XL.json +239 -218
  384. package/front_end/third_party/lighthouse/locales/es-419.json +150 -135
  385. package/front_end/third_party/lighthouse/locales/es.json +149 -134
  386. package/front_end/third_party/lighthouse/locales/fi.json +151 -136
  387. package/front_end/third_party/lighthouse/locales/fil.json +154 -139
  388. package/front_end/third_party/lighthouse/locales/fr.json +150 -135
  389. package/front_end/third_party/lighthouse/locales/he.json +160 -145
  390. package/front_end/third_party/lighthouse/locales/hi.json +156 -141
  391. package/front_end/third_party/lighthouse/locales/hr.json +154 -139
  392. package/front_end/third_party/lighthouse/locales/hu.json +111 -96
  393. package/front_end/third_party/lighthouse/locales/id.json +153 -138
  394. package/front_end/third_party/lighthouse/locales/it.json +153 -138
  395. package/front_end/third_party/lighthouse/locales/ja.json +150 -135
  396. package/front_end/third_party/lighthouse/locales/ko.json +42 -27
  397. package/front_end/third_party/lighthouse/locales/lt.json +152 -137
  398. package/front_end/third_party/lighthouse/locales/lv.json +93 -78
  399. package/front_end/third_party/lighthouse/locales/nl.json +149 -134
  400. package/front_end/third_party/lighthouse/locales/no.json +152 -137
  401. package/front_end/third_party/lighthouse/locales/pl.json +153 -138
  402. package/front_end/third_party/lighthouse/locales/pt-PT.json +152 -137
  403. package/front_end/third_party/lighthouse/locales/pt.json +157 -142
  404. package/front_end/third_party/lighthouse/locales/ro.json +149 -134
  405. package/front_end/third_party/lighthouse/locales/ru.json +76 -61
  406. package/front_end/third_party/lighthouse/locales/sk.json +153 -138
  407. package/front_end/third_party/lighthouse/locales/sl.json +149 -134
  408. package/front_end/third_party/lighthouse/locales/sr-Latn.json +151 -136
  409. package/front_end/third_party/lighthouse/locales/sr.json +151 -136
  410. package/front_end/third_party/lighthouse/locales/sv.json +152 -137
  411. package/front_end/third_party/lighthouse/locales/ta.json +156 -141
  412. package/front_end/third_party/lighthouse/locales/te.json +157 -142
  413. package/front_end/third_party/lighthouse/locales/th.json +111 -96
  414. package/front_end/third_party/lighthouse/locales/tr.json +153 -138
  415. package/front_end/third_party/lighthouse/locales/uk.json +149 -134
  416. package/front_end/third_party/lighthouse/locales/vi.json +162 -147
  417. package/front_end/third_party/lighthouse/locales/zh-HK.json +150 -135
  418. package/front_end/third_party/lighthouse/locales/zh-TW.json +154 -139
  419. package/front_end/third_party/lighthouse/locales/zh.json +152 -137
  420. package/front_end/third_party/lighthouse/report/bundle.d.ts +9 -8
  421. package/front_end/third_party/lighthouse/report/bundle.js +10 -10
  422. package/front_end/third_party/lighthouse/report-assets/report-generator.mjs +2 -7
  423. package/front_end/tsconfig.compatibility.json +1 -0
  424. package/front_end/tsconfig.json +3 -2
  425. package/front_end/ui/components/dialogs/TypeToAllowDialog.ts +0 -2
  426. package/front_end/ui/components/dialogs/typeToAllowDialog.css +0 -4
  427. package/front_end/ui/components/icon_button/fileSourceIcon.css +1 -1
  428. package/front_end/ui/components/input/textInput.css +1 -1
  429. package/front_end/ui/components/lists/List.ts +26 -14
  430. package/front_end/ui/components/menus/menus.ts +0 -2
  431. package/front_end/ui/components/suggestion_input/SuggestionInput.ts +351 -138
  432. package/front_end/ui/components/survey_link/surveyLink.css +3 -3
  433. package/front_end/ui/components/switch/switch.css +6 -6
  434. package/front_end/ui/components/text_editor/AiCodeCompletionTeaser.ts +2 -3
  435. package/front_end/ui/components/text_editor/TextEditor.ts +1 -1
  436. package/front_end/ui/components/tooltips/Tooltip.ts +53 -4
  437. package/front_end/ui/components/tree_outline/treeOutline.css +7 -7
  438. package/front_end/ui/helpers/OpenInNewTab.ts +8 -3
  439. package/front_end/ui/legacy/EmptyWidget.ts +4 -4
  440. package/front_end/ui/legacy/ForwardedInputEventHandler.ts +2 -2
  441. package/front_end/ui/legacy/GlassPane.ts +1 -1
  442. package/front_end/ui/legacy/KeyboardShortcut.ts +7 -7
  443. package/front_end/ui/legacy/RemoteDebuggingTerminatedScreen.ts +2 -2
  444. package/front_end/ui/legacy/TabbedPane.ts +198 -66
  445. package/front_end/ui/legacy/TargetCrashedScreen.ts +2 -2
  446. package/front_end/ui/legacy/UIUtils.ts +71 -68
  447. package/front_end/ui/legacy/View.ts +7 -4
  448. package/front_end/ui/legacy/ViewManager.ts +49 -37
  449. package/front_end/ui/legacy/Widget.ts +32 -12
  450. package/front_end/ui/legacy/components/cookie_table/CookiesTable.ts +2 -3
  451. package/front_end/ui/legacy/components/inline_editor/AnimationTimingUI.ts +8 -8
  452. package/front_end/ui/legacy/components/inline_editor/BezierUI.ts +8 -9
  453. package/front_end/ui/legacy/components/inline_editor/LinkSwatch.ts +2 -2
  454. package/front_end/ui/legacy/components/inline_editor/cssAngleEditor.css +1 -1
  455. package/front_end/ui/legacy/components/inline_editor/cssAngleSwatch.css +1 -1
  456. package/front_end/ui/legacy/components/object_ui/ObjectPropertiesSection.ts +45 -11
  457. package/front_end/ui/legacy/components/object_ui/RemoteObjectPreviewFormatter.ts +10 -12
  458. package/front_end/ui/legacy/components/perf_ui/ChartViewport.ts +102 -29
  459. package/front_end/ui/legacy/components/perf_ui/FlameChart.ts +148 -122
  460. package/front_end/ui/legacy/components/perf_ui/TimelineOverviewPane.ts +20 -14
  461. package/front_end/ui/legacy/components/quick_open/filteredListWidget.css +1 -1
  462. package/front_end/ui/legacy/components/source_frame/FontView.ts +29 -5
  463. package/front_end/ui/legacy/components/source_frame/ImageView.ts +79 -12
  464. package/front_end/ui/legacy/components/source_frame/JSONView.ts +20 -2
  465. package/front_end/ui/legacy/components/source_frame/PreviewFactory.ts +2 -2
  466. package/front_end/ui/legacy/components/source_frame/StreamingContentHexView.ts +6 -10
  467. package/front_end/ui/legacy/components/source_frame/XMLView.ts +11 -11
  468. package/front_end/ui/legacy/components/source_frame/fontView.css +7 -0
  469. package/front_end/ui/legacy/components/source_frame/imageView.css +7 -0
  470. package/front_end/ui/legacy/components/utils/JSPresentationUtils.ts +14 -3
  471. package/front_end/ui/legacy/components/utils/Linkifier.ts +126 -2
  472. package/front_end/ui/legacy/emptyWidget.css +2 -1
  473. package/front_end/ui/legacy/inspectorCommon.css +3 -3
  474. package/front_end/ui/legacy/smallBubble.css +1 -1
  475. package/front_end/ui/legacy/tabbedPane.css +6 -0
  476. package/front_end/ui/lit/Directives.ts +35 -18
  477. package/front_end/ui/lit/lit.ts +0 -2
  478. package/front_end/ui/lit/render.ts +0 -7
  479. package/front_end/ui/visual_logging/KnownContextValues.ts +5 -0
  480. package/package.json +1 -1
  481. package/vpython.toml +8 -0
  482. package/vpython.toml.uv.lock +3 -0
  483. package/.agents/skills/review-models-core/SKILL.md +0 -73
  484. package/.agents/skills/review-tests/SKILL.md +0 -67
  485. package/.agents/skills/review-ui-widgets/SKILL.md +0 -115
  486. package/front_end/generated/ARIAProperties.ts +0 -2686
  487. package/front_end/ui/components/menus/README.md +0 -119
  488. package/front_end/ui/components/menus/SelectMenu.ts +0 -473
  489. package/front_end/ui/components/menus/selectMenu.css +0 -54
  490. package/front_end/ui/components/menus/selectMenuButton.css +0 -108
@@ -1,7 +1,6 @@
1
1
  // Copyright 2013 The Chromium Authors
2
2
  // Use of this source code is governed by a BSD-style license that can be
3
3
  // found in the LICENSE file.
4
- /* eslint-disable @devtools/no-imperative-dom-api */
5
4
 
6
5
  import '../../ui/kit/kit.js';
7
6
 
@@ -12,7 +11,6 @@ import type * as Platform from '../../core/platform/platform.js';
12
11
  import * as Root from '../../core/root/root.js';
13
12
  import * as Buttons from '../../ui/components/buttons/buttons.js';
14
13
  import * as UIHelpers from '../../ui/helpers/helpers.js';
15
- import type {Card} from '../../ui/kit/kit.js';
16
14
  import * as SettingsUI from '../../ui/legacy/components/settings_ui/settings_ui.js';
17
15
  import * as Components from '../../ui/legacy/components/utils/utils.js';
18
16
  import * as UI from '../../ui/legacy/legacy.js';
@@ -25,7 +23,8 @@ import * as PanelComponents from './components/components.js';
25
23
  import type {KeybindsSettingsTab} from './KeybindsSettingsTab.js';
26
24
  import settingsScreenStyles from './settingsScreen.css.js';
27
25
 
28
- const {html, render, Directives: {ref}} = Lit;
26
+ const {html, nothing, render, Directives: {ref, repeat}} = Lit;
27
+ const {widget, widgetRef} = UI.Widget;
29
28
 
30
29
  const UIStrings = {
31
30
  /**
@@ -83,53 +82,96 @@ const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
83
82
 
84
83
  let settingsScreenInstance: SettingsScreen|undefined;
85
84
 
86
- function createSettingsCard(heading: Common.UIString.LocalizedString, ...content: HTMLElement[]): Card {
87
- const card = document.createElement('devtools-card');
88
- card.heading = heading;
89
- card.append(...content);
90
- return card;
85
+ export interface SettingsScreenViewInput {
86
+ views: UI.View.View[];
87
+ selectedTabId: string;
88
+ focusTabHeader: boolean;
89
+ onTabInvoked: (eventData: {tabId: string, prevTabId?: string, isUserGesture?: boolean}) => void;
91
90
  }
92
91
 
93
- export class SettingsScreen extends UI.Widget.VBox implements UI.View.ViewLocationResolver {
94
- private readonly tabbedLocation: UI.View.TabbedViewLocation;
92
+ export type SettingsScreenView = (input: SettingsScreenViewInput, output: undefined, target: HTMLElement) => void;
93
+
94
+ export const SETTINGS_SCREEN_DEFAULT_VIEW: SettingsScreenView = (
95
+ input: SettingsScreenViewInput,
96
+ _output: undefined,
97
+ target: HTMLElement,
98
+ ): void => {
99
+ // clang-format off
100
+ render(
101
+ html`
102
+ <devtools-tabbed-pane
103
+ vertical
104
+ ?focus-header=${input.focusTabHeader}
105
+ selected-tab=${input.selectedTabId}
106
+ @tabinvoked=${(event: CustomEvent<{tabId: string, prevTabId?: string, isUserGesture?: boolean}>) =>
107
+ input.onTabInvoked(event.detail)}>
108
+ <div slot="left" class="settings-window-label-element">
109
+ <div class="settings-window-title" role="heading" aria-level="1">
110
+ ${i18nString(UIStrings.settings)}
111
+ </div>
112
+ </div>
113
+ ${repeat(input.views, view => view.viewId(), view => {
114
+ const iconName = view.iconName();
115
+ return html`
116
+ <devtools-widget
117
+ id=${view.viewId()}
118
+ label=${view.title()}
119
+ ${widget(UI.ViewManager.ContainerWidget, {view})}>
120
+ </devtools-widget>
121
+ ${iconName
122
+ ? html`<devtools-icon slot="icon-${view.viewId()}" name=${iconName}></devtools-icon>`
123
+ : nothing}
124
+ `;
125
+ })}
126
+ </devtools-tabbed-pane>
127
+ `,
128
+ target,
129
+ {container: {classes: ['settings-window-main', 'vbox']}});
130
+ // clang-format on
131
+ };
132
+
133
+ export class SettingsScreen extends UI.Widget.VBox implements UI.View.ViewLocationResolver, UI.View.ViewLocation {
95
134
  private keybindsTab?: KeybindsSettingsTab;
96
135
  private reportTabOnReveal: boolean;
136
+ readonly #view: SettingsScreenView;
137
+ readonly #views: UI.View.View[] = [];
138
+ readonly #onTabInvokedBound = this.tabInvoked.bind(this);
139
+ #selectedTabId = 'preferences';
140
+ #focusTabHeader = false;
97
141
 
98
- private constructor() {
142
+ constructor(view: SettingsScreenView = SETTINGS_SCREEN_DEFAULT_VIEW) {
99
143
  super({useShadowDom: true});
144
+ this.#view = view;
100
145
  this.registerRequiredCSS(settingsScreenStyles);
101
146
 
102
- this.contentElement.classList.add('settings-window-main');
103
- this.contentElement.classList.add('vbox');
104
-
105
- const settingsLabelElement = document.createElement('div');
106
- settingsLabelElement.classList.add('settings-window-label-element');
107
- const settingsTitleElement =
108
- UI.UIUtils.createShadowRootWithCoreStyles(settingsLabelElement, {cssFile: settingsScreenStyles})
109
- .createChild('div', 'settings-window-title');
110
-
111
- UI.ARIAUtils.markAsHeading(settingsTitleElement, 1);
112
- settingsTitleElement.textContent = i18nString(UIStrings.settings);
113
-
114
- this.tabbedLocation = UI.ViewManager.ViewManager.instance().createTabbedLocation(
115
- () => SettingsScreen.revealSettingsScreen(), 'settings-view');
116
- const tabbedPane = this.tabbedLocation.tabbedPane();
117
- tabbedPane.registerRequiredCSS(settingsScreenStyles);
118
- tabbedPane.headerElement().prepend(settingsLabelElement);
119
- tabbedPane.setShrinkableTabs(false);
120
- tabbedPane.makeVerticalTabLayout();
121
- const keyBindsView = UI.ViewManager.ViewManager.instance().view('keybinds');
147
+ this.appendApplicableItems(UI.ViewManager.ViewLocationValues.SETTINGS_VIEW);
148
+ const keyBindsView = this.#views.find(v => v.viewId() === 'keybinds');
122
149
  if (keyBindsView) {
123
150
  void keyBindsView.widget().then(widget => {
124
151
  this.keybindsTab = widget as KeybindsSettingsTab;
125
152
  });
126
153
  }
127
- tabbedPane.show(this.contentElement);
128
- tabbedPane.selectTab('preferences');
129
- tabbedPane.addEventListener(UI.TabbedPane.Events.TabInvoked, this.tabInvoked, this);
130
154
  this.reportTabOnReveal = false;
131
155
  }
132
156
 
157
+ override wasShown(): void {
158
+ super.wasShown();
159
+ this.performUpdate();
160
+ }
161
+
162
+ override performUpdate(): void {
163
+ this.#view(
164
+ {
165
+ views: this.#views,
166
+ selectedTabId: this.#selectedTabId,
167
+ focusTabHeader: this.#focusTabHeader,
168
+ onTabInvoked: this.#onTabInvokedBound,
169
+ },
170
+ undefined,
171
+ this.contentElement,
172
+ );
173
+ }
174
+
133
175
  static instance(opts: {forceNew: boolean|null} = {forceNew: null}): SettingsScreen {
134
176
  const {forceNew} = opts;
135
177
  if (!settingsScreenInstance || forceNew) {
@@ -171,30 +213,110 @@ export class SettingsScreen extends UI.Widget.VBox implements UI.View.ViewLocati
171
213
  const {name, focusTabHeader} = options;
172
214
  const settingsScreen = SettingsScreen.revealSettingsScreen();
173
215
 
174
- settingsScreen.selectTab(name || 'preferences');
175
- const tabbedPane = settingsScreen.tabbedLocation.tabbedPane();
176
- await tabbedPane.waitForTabElementUpdate();
177
- if (focusTabHeader) {
178
- tabbedPane.focusSelectedTabHeader();
216
+ await settingsScreen.selectTab(name || 'preferences', Boolean(focusTabHeader));
217
+ }
218
+
219
+ resolveLocation(_locationName: string): UI.View.ViewLocation|null {
220
+ return this;
221
+ }
222
+
223
+ appendApplicableItems(locationName: string): void {
224
+ for (const view of UI.ViewManager.ViewManager.instance().viewsForLocation(locationName)) {
225
+ if (!view.isTransient()) {
226
+ this.appendView(view);
227
+ }
228
+ }
229
+ }
230
+
231
+ appendView(view: UI.View.View, insertBefore?: UI.View.View|null): void {
232
+ if (this.#views.includes(view)) {
233
+ return;
234
+ }
235
+ const index = insertBefore ? this.#views.indexOf(insertBefore) : -1;
236
+ if (index !== -1) {
237
+ this.#views.splice(index, 0, view);
179
238
  } else {
180
- tabbedPane.focus();
239
+ this.#views.push(view);
181
240
  }
241
+ this.requestUpdate();
182
242
  }
183
243
 
184
- resolveLocation(_locationName: string): UI.View.ViewLocation|null {
185
- return this.tabbedLocation;
244
+ async showView(view: UI.View.View, insertBefore?: UI.View.View|null, userGesture?: boolean, omitFocus?: boolean,
245
+ shouldSelectTab = true): Promise<void> {
246
+ this.appendView(view, insertBefore);
247
+ if (shouldSelectTab) {
248
+ const prevTabId = this.#selectedTabId;
249
+ this.#selectedTabId = view.viewId();
250
+ this.#focusTabHeader = false;
251
+ if (userGesture && (this.reportTabOnReveal || prevTabId !== view.viewId())) {
252
+ this.reportTabOnReveal = false;
253
+ this.reportSettingsPanelShown(view.viewId());
254
+ }
255
+ }
256
+ this.performUpdate();
257
+ await view.widget();
258
+ if (!omitFocus) {
259
+ this.focus();
260
+ }
186
261
  }
187
262
 
188
- private selectTab(name: string): void {
189
- this.tabbedLocation.tabbedPane().selectTab(name, /* userGesture */ true);
263
+ removeView(view: UI.View.View): void {
264
+ const index = this.#views.indexOf(view);
265
+ if (index !== -1) {
266
+ this.#views.splice(index, 1);
267
+ if (this.#selectedTabId === view.viewId()) {
268
+ this.#selectedTabId = this.#views[0]?.viewId() ?? 'preferences';
269
+ }
270
+ this.requestUpdate();
271
+ }
272
+ }
273
+
274
+ isViewVisible(view: UI.View.View): boolean {
275
+ return this.isShowing() && this.#selectedTabId === view.viewId();
276
+ }
277
+
278
+ widget(): UI.Widget.AnyWidget {
279
+ return this;
280
+ }
281
+
282
+ reveal(): void {
283
+ SettingsScreen.revealSettingsScreen();
284
+ }
285
+
286
+ private async selectTab(name: string, focusTabHeader = false): Promise<void> {
287
+ const prevTabId = this.#selectedTabId;
288
+ this.#selectedTabId = name;
289
+ this.#focusTabHeader = focusTabHeader;
290
+ if (this.reportTabOnReveal || prevTabId !== name) {
291
+ this.reportTabOnReveal = false;
292
+ this.reportSettingsPanelShown(name);
293
+ }
294
+ this.performUpdate();
295
+ const view = this.#views.find(v => v.viewId() === name);
296
+ if (view) {
297
+ await view.widget();
298
+ }
299
+ this.focus();
300
+ if (this.#focusTabHeader) {
301
+ this.#focusTabHeader = false;
302
+ this.requestUpdate();
303
+ }
190
304
  }
191
305
 
192
- private tabInvoked(event: Common.EventTarget.EventTargetEvent<UI.TabbedPane.EventData>): void {
193
- const eventData = event.data;
306
+ private tabInvoked(eventData: {tabId: string, prevTabId?: string, isUserGesture?: boolean}): void {
307
+ if (this.#selectedTabId !== eventData.tabId) {
308
+ this.#selectedTabId = eventData.tabId;
309
+ this.requestUpdate();
310
+ }
194
311
  if (!eventData.isUserGesture) {
195
312
  return;
196
313
  }
197
314
 
315
+ if (this.#focusTabHeader) {
316
+ this.#focusTabHeader = false;
317
+ this.requestUpdate();
318
+ }
319
+
198
320
  const prevTabId = eventData.prevTabId;
199
321
  const tabId = eventData.tabId;
200
322
  if (!this.reportTabOnReveal && prevTabId && prevTabId === tabId) {
@@ -215,7 +337,7 @@ export class SettingsScreen extends UI.Widget.VBox implements UI.View.ViewLocati
215
337
  }
216
338
 
217
339
  private onEscapeKeyPressed(event: KeyboardEvent): void {
218
- if (this.tabbedLocation.tabbedPane().selectedTabId === 'keybinds' && this.keybindsTab) {
340
+ if (this.#selectedTabId === 'keybinds' && this.keybindsTab) {
219
341
  this.keybindsTab.onEscapeKeyPressed(event);
220
342
  }
221
343
  }
@@ -225,22 +347,110 @@ interface SettingsTab {
225
347
  highlightObject(object: Object): void;
226
348
  }
227
349
 
350
+ export interface GenericSettingsSection {
351
+ category: Common.Settings.SettingCategory;
352
+ heading: Common.UIString.LocalizedString;
353
+ settings: Array<Common.Settings.Setting<unknown>>;
354
+ }
355
+
356
+ export interface GenericSettingsTabViewInput {
357
+ sections: GenericSettingsSection[];
358
+ syncInfo: Host.InspectorFrontendHostAPI.SyncInformation;
359
+ onRestoreDefaults: () => void;
360
+ }
361
+
362
+ export interface GenericSettingsTabViewOutput {
363
+ highlightSetting?: (setting: Common.Settings.Setting<unknown>) => void;
364
+ }
365
+
366
+ export type GenericSettingsTabView =
367
+ (input: GenericSettingsTabViewInput, output: GenericSettingsTabViewOutput, target: HTMLElement) => void;
368
+
369
+ export const GENERIC_SETTINGS_TAB_DEFAULT_VIEW: GenericSettingsTabView = (
370
+ input: GenericSettingsTabViewInput,
371
+ output: GenericSettingsTabViewOutput,
372
+ target: HTMLElement,
373
+ ): void => {
374
+ const settingToControl = new Map<Common.Settings.Setting<unknown>, HTMLElement>();
375
+ let syncSection: PanelComponents.SyncSection.SyncSection|undefined;
376
+ output.highlightSetting = (setting: Common.Settings.Setting<unknown>): void => {
377
+ const element = settingToControl.get(setting);
378
+ if (element) {
379
+ PanelUtils.highlightElement(element);
380
+ } else if (setting.name === 'receive-gdp-badges') {
381
+ void syncSection?.highlightReceiveBadgesSetting();
382
+ }
383
+ };
384
+ // clang-format off
385
+ render(
386
+ html`
387
+ <div class="settings-card-container-wrapper">
388
+ <div class="settings-multicolumn-card-container">
389
+ ${input.sections.map(section => html`
390
+ <devtools-card heading=${section.heading}>
391
+ ${section.category === Common.Settings.SettingCategory.ACCOUNT
392
+ ? html`<devtools-widget
393
+ ${widget(PanelComponents.SyncSection.SyncSection, {syncInfo: input.syncInfo})}
394
+ ${widgetRef(PanelComponents.SyncSection.SyncSection, w => { syncSection = w; })}>
395
+ </devtools-widget>`
396
+ : html`
397
+ <div ${ref(el => {
398
+ if (!el) {
399
+ return;
400
+ }
401
+ let childIndex = 0;
402
+ for (const setting of section.settings) {
403
+ if (setting.type() !== Common.Settings.SettingType.BOOLEAN &&
404
+ setting.type() !== Common.Settings.SettingType.ENUM) {
405
+ continue;
406
+ }
407
+ const child = el.children[childIndex++];
408
+ if (child instanceof HTMLElement) {
409
+ settingToControl.set(setting, child);
410
+ }
411
+ }
412
+ })}>
413
+ ${section.settings.map(setting => SettingsUI.SettingsUI.renderControlForSetting(setting))}
414
+ ${section.category === Common.Settings.SettingCategory.EXTENSIONS
415
+ ? Components.Linkifier.LinkHandlerSettingUI.instance().settingElement()
416
+ : nothing}
417
+ </div>
418
+ `}
419
+ </devtools-card>
420
+ `)}
421
+ <devtools-button
422
+ .variant=${Buttons.Button.Variant.OUTLINED}
423
+ .jslogContext=${'settings.restore-defaults-and-reload'}
424
+ @click=${input.onRestoreDefaults}>
425
+ ${i18nString(UIStrings.restoreDefaultsAndReload)}
426
+ </devtools-button>
427
+ </div>
428
+ </div>
429
+ `,
430
+ target,
431
+ {
432
+ container: {
433
+ classes: ['settings-tab-container'],
434
+ attributes: {
435
+ id: 'preferences-tab-content',
436
+ jslog: `${VisualLogging.pane('preferences')}`,
437
+ },
438
+ },
439
+ });
440
+ // clang-format on
441
+ };
442
+
228
443
  export class GenericSettingsTab extends UI.Widget.VBox implements SettingsTab {
229
- private readonly syncSection = new PanelComponents.SyncSection.SyncSection();
230
- private readonly settingToControl = new Map<Common.Settings.Setting<unknown>, HTMLElement>();
231
- private readonly containerElement: HTMLElement;
444
+ readonly #sections: GenericSettingsSection[] = [];
445
+ readonly #view: GenericSettingsTabView;
446
+ readonly #viewOutput: GenericSettingsTabViewOutput = {};
447
+ #syncInfo: Host.InspectorFrontendHostAPI.SyncInformation = {isSyncActive: false};
232
448
  #updateSyncSectionTimerId = -1;
233
449
  #syncSectionUpdatePromise: Promise<void>|null = null;
234
450
 
235
- constructor() {
236
- super({jslog: `${VisualLogging.pane('preferences')}`});
237
- this.element.classList.add('settings-tab-container');
238
- this.element.id = 'preferences-tab-content';
239
- this.containerElement =
240
- this.contentElement.createChild('div', 'settings-card-container-wrapper').createChild('div');
241
-
242
- this.containerElement.classList.add('settings-multicolumn-card-container');
243
- this.syncSection.markAsRoot();
451
+ constructor(element?: HTMLElement, view: GenericSettingsTabView = GENERIC_SETTINGS_TAB_DEFAULT_VIEW) {
452
+ super(element);
453
+ this.#view = view;
244
454
 
245
455
  // AI, GRID, MOBILE, EMULATION, and RENDERING are intentionally excluded from this list.
246
456
  // AI settings are displayed in their own tab.
@@ -285,15 +495,24 @@ export class GenericSettingsTab extends UI.Widget.VBox implements SettingsTab {
285
495
  this.createSectionElement(sectionCategory, settingsForSection);
286
496
  }
287
497
 
288
- const restoreAndReloadButton =
289
- UI.UIUtils.createTextButton(i18nString(UIStrings.restoreDefaultsAndReload), restoreAndReload,
290
- {jslogContext: 'settings.restore-defaults-and-reload'});
291
- this.containerElement.appendChild(restoreAndReloadButton);
498
+ this.requestUpdate();
499
+ }
292
500
 
293
- function restoreAndReload(): void {
294
- Common.Settings.Settings.instance().clearAll();
295
- Components.Reload.reload();
296
- }
501
+ #restoreAndReload(): void {
502
+ Common.Settings.Settings.instance().clearAll();
503
+ Components.Reload.reload();
504
+ }
505
+
506
+ override performUpdate(): void {
507
+ this.#view(
508
+ {
509
+ sections: this.#sections,
510
+ syncInfo: this.#syncInfo,
511
+ onRestoreDefaults: this.#restoreAndReload.bind(this),
512
+ },
513
+ this.#viewOutput,
514
+ this.contentElement,
515
+ );
297
516
  }
298
517
 
299
518
  static isSettingVisible(setting: SettingUIRegistration.SettingUIRegistration.RegisteredSettingUI): boolean {
@@ -303,6 +522,7 @@ export class GenericSettingsTab extends UI.Widget.VBox implements SettingsTab {
303
522
  override wasShown(): void {
304
523
  UI.Context.Context.instance().setFlavor(GenericSettingsTab, this);
305
524
  super.wasShown();
525
+ this.performUpdate();
306
526
  this.updateSyncSection();
307
527
  }
308
528
 
@@ -325,64 +545,36 @@ export class GenericSettingsTab extends UI.Widget.VBox implements SettingsTab {
325
545
  new Promise<Host.InspectorFrontendHostAPI.SyncInformation>(
326
546
  resolve => Host.InspectorFrontendHost.InspectorFrontendHostInstance.getSyncInformation(resolve))
327
547
  .then(syncInfo => {
328
- this.syncSection.syncInfo = syncInfo;
548
+ this.#syncInfo = syncInfo;
549
+ this.requestUpdate();
329
550
  if (!syncInfo.isSyncActive || !syncInfo.arePreferencesSynced) {
330
551
  this.#updateSyncSectionTimerId = window.setTimeout(this.updateSyncSection.bind(this), 500);
331
552
  }
332
553
  });
333
554
  }
334
555
 
335
- private createExtensionSection(settings: SettingUIRegistration.SettingUIRegistration.RegisteredSettingUI[]): void {
336
- const sectionName = Common.Settings.SettingCategory.EXTENSIONS;
337
- const settingUI = Components.Linkifier.LinkHandlerSettingUI.instance();
338
- const element = settingUI.settingElement();
339
- this.createStandardSectionElement(sectionName, settings, element);
340
- }
341
-
342
556
  private createSectionElement(category: Common.Settings.SettingCategory,
343
557
  settings: SettingUIRegistration.SettingUIRegistration.RegisteredSettingUI[]): void {
344
558
  // Always create the EXTENSIONS section and append the link handling control.
345
- if (category === Common.Settings.SettingCategory.EXTENSIONS) {
346
- this.createExtensionSection(settings);
347
- } else if (category === Common.Settings.SettingCategory.ACCOUNT && settings.length > 0) {
348
- const syncCard = createSettingsCard(
349
- Common.SettingRegistration.getLocalizedSettingsCategory(Common.SettingRegistration.SettingCategory.ACCOUNT),
350
- this.syncSection.element);
351
- this.containerElement.appendChild(syncCard);
352
- } else if (settings.length > 0) {
353
- this.createStandardSectionElement(category, settings);
354
- }
355
- }
356
-
357
- private createStandardSectionElement(category: Common.Settings.SettingCategory,
358
- settings: SettingUIRegistration.SettingUIRegistration.RegisteredSettingUI[],
359
- content?: Element): void {
360
- const uiSectionName = Common.Settings.getLocalizedSettingsCategory(category);
361
- const sectionElement = document.createElement('div');
362
- for (const settingRegistration of settings) {
363
- const setting = Common.Settings.Settings.instance().resolve(settingRegistration.descriptor);
364
- const settingControl = SettingsUI.SettingsUI.createControlForSetting(setting);
365
- if (settingControl) {
366
- this.settingToControl.set(setting, settingControl);
367
- sectionElement.appendChild(settingControl);
368
- }
369
- }
370
- if (content) {
371
- sectionElement.appendChild(content);
559
+ if (category !== Common.Settings.SettingCategory.EXTENSIONS && settings.length === 0) {
560
+ return;
372
561
  }
373
- const card = createSettingsCard(uiSectionName, sectionElement);
374
- this.containerElement.appendChild(card);
562
+ this.#sections.push({
563
+ category,
564
+ heading: Common.Settings.getLocalizedSettingsCategory(category),
565
+ settings: settings.map(settingRegistration =>
566
+ Common.Settings.Settings.instance().resolve(settingRegistration.descriptor)),
567
+ });
375
568
  }
376
569
 
377
570
  highlightObject(setting: Object): void {
378
571
  if (setting instanceof Common.Settings.Setting) {
379
- const element = this.settingToControl.get(setting);
380
- if (element) {
381
- PanelUtils.highlightElement(element);
382
- } else if (setting.name === 'receive-gdp-badges') {
572
+ if (setting.name === 'receive-gdp-badges') {
383
573
  void this.#syncSectionUpdatePromise?.then(() => {
384
- void this.syncSection.highlightReceiveBadgesSetting();
574
+ this.#viewOutput.highlightSetting?.(setting);
385
575
  });
576
+ } else {
577
+ this.#viewOutput.highlightSetting?.(setting);
386
578
  }
387
579
  }
388
580
  }
@@ -432,7 +624,7 @@ export const EXPERIMENTS_SETTINGS_TAB_DEFAULT_VIEW: ExperimentsSettingsTabView =
432
624
  <span>${i18nString(UIStrings.theseExperimentsCouldBeUnstable)}</span>
433
625
  </div>
434
626
  <div class="settings-experiments-block">
435
- ${input.experiments.map(experiment => html`
627
+ ${repeat(input.experiments, experiment => experiment.name, experiment => html`
436
628
  <p class="settings-experiment" ${ref(el => {
437
629
  if (el) {
438
630
  output.setExperimentElement(experiment, el as HTMLElement);
@@ -483,7 +675,15 @@ export const EXPERIMENTS_SETTINGS_TAB_DEFAULT_VIEW: ExperimentsSettingsTabView =
483
675
  </div>
484
676
  </div>
485
677
  `,
486
- target);
678
+ target, {
679
+ container: {
680
+ classes: ['settings-tab-container'],
681
+ attributes: {
682
+ id: 'experiments-tab-content',
683
+ jslog: `${VisualLogging.pane('experiments')}`,
684
+ },
685
+ },
686
+ });
487
687
  // clang-format on
488
688
  };
489
689
 
@@ -498,9 +698,7 @@ export class ExperimentsSettingsTab extends UI.Widget.Widget implements Settings
498
698
  #filterText = '';
499
699
 
500
700
  constructor(element?: HTMLElement, view: ExperimentsSettingsTabView = EXPERIMENTS_SETTINGS_TAB_DEFAULT_VIEW) {
501
- super(element, {jslog: `${VisualLogging.pane('experiments')}`});
502
- this.element.classList.add('settings-tab-container');
503
- this.element.id = 'experiments-tab-content';
701
+ super(element);
504
702
  this.#view = view;
505
703
  }
506
704
 
@@ -49,7 +49,7 @@ export interface WorkspaceSettingsTabInput {
49
49
  onAddClicked: () => void;
50
50
  onRemoveClicked: (fileSystem: Persistence.IsolatedFileSystem.IsolatedFileSystem) => void;
51
51
  }
52
- export type View = (input: WorkspaceSettingsTabInput, output: object, target: HTMLElement) => void;
52
+ export type View = (input: WorkspaceSettingsTabInput, output: undefined, target: HTMLElement) => void;
53
53
  export const DEFAULT_VIEW: View = (input, _output, target) => {
54
54
  // clang-format off
55
55
  render(html`
@@ -148,7 +148,7 @@ export class WorkspaceSettingsTab extends UI.Widget.VBox {
148
148
  })
149
149
  .sort((fs1, fs2) => fs1.displayName.localeCompare(fs2.displayName)),
150
150
  };
151
- this.#view(input, {}, this.contentElement);
151
+ this.#view(input, undefined, this.contentElement);
152
152
  }
153
153
 
154
154
  static #getFilename(fileSystem: Persistence.PlatformFileSystem.PlatformFileSystem): string {
@@ -211,6 +211,7 @@
211
211
  background-color: var(--app-color-card-background);
212
212
  overflow: hidden;
213
213
  width: 100%;
214
+ padding-bottom: var(--sys-size-6);
214
215
  }
215
216
 
216
217
  .allowed-tools-description {
@@ -230,10 +231,6 @@
230
231
  min-height: var(--sys-size-12);
231
232
  font: var(--sys-typescale-body5-regular);
232
233
  color: var(--sys-color-on-surface);
233
-
234
- & ~ .allowed-tool-row {
235
- border-top: var(--sys-size-1) solid var(--sys-color-divider);
236
- }
237
234
  }
238
235
 
239
236
  .allowed-tool-name {