chrome-devtools-frontend 1.0.1014346 → 1.0.1015658

package/scripts/webidl-properties/config.js

@@ -35,245 +35,311 @@ export const GLOBAL_ATTRIBUTES = new Set([
  * The "applicable" members for certain "states" that WebIDL types can be in.
  * In other words, some members are "valid" only valid in certain situations:
  * for example, with the HTML input element, the set of valid members are
- * determined by the "type" attribute.
+ * determined by the "type" property.
  */
-export const VALID_MEMBERS = {
+export const APPLICABLE_MEMBERS = {
   // https://html.spec.whatwg.org/multipage/input.html#input-type-attr-summary
-  HTMLInputElement: {
-    '[type=hidden]': new Set([
-      'autocomplete',
-      'value',
-    ]),
-    '[type=text]': new Set([
-      'autocomplete',
-      'dirname',
-      'list',
-      'maxlength',
-      'minlength',
-      'pattern',
-      'placeholder',
-      'readonly',
-      'required',
-      'size',
-      'value',
-      'list',
-      'selectionstart',
-      'selectionend',
-      'selectiondirection',
-    ]),
-    '[type=search]': new Set([
-      'autocomplete',
-      'dirname',
-      'list',
-      'maxlength',
-      'minlength',
-      'pattern',
-      'placeholder',
-      'readonly',
-      'required',
-      'size',
-      'value',
-      'list',
-      'selectionstart',
-      'selectionend',
-      'selectiondirection',
-    ]),
-    '[type=url]': new Set([
-      'autocomplete',
-      'list',
-      'maxlength',
-      'minlength',
-      'pattern',
-      'placeholder',
-      'readonly',
-      'required',
-      'size',
-      'value',
-      'list',
-      'selectionstart',
-      'selectionend',
-      'selectiondirection',
-    ]),
-    '[type=tel]': new Set([
-      'autocomplete',
-      'list',
-      'maxlength',
-      'minlength',
-      'pattern',
-      'placeholder',
-      'readonly',
-      'required',
-      'size',
-      'value',
-      'list',
-      'selectionstart',
-      'selectionend',
-      'selectiondirection',
-    ]),
-    '[type=email]': new Set([
-      'autocomplete',
-      'list',
-      'maxlength',
-      'minlength',
-      'multiple',
-      'pattern',
-      'placeholder',
-      'readonly',
-      'required',
-      'size',
-      'value',
-      'list',
-    ]),
-    '[type=password]': new Set([
-      'autocomplete',
-      'maxlength',
-      'minlength',
-      'pattern',
-      'placeholder',
-      'readonly',
-      'required',
-      'size',
-      'value',
-      'selectionstart',
-      'selectionend',
-      'selectiondirection',
-    ]),
-    '[type=date]': new Set([
-      'autocomplete',
-      'list',
-      'max',
-      'min',
-      'readonly',
-      'required',
-      'step',
-      'value',
-      'valueasdate',
-      'valueasnumber',
-      'list',
-    ]),
-    '[type=month]': new Set([
-      'autocomplete',
-      'list',
-      'max',
-      'min',
-      'readonly',
-      'required',
-      'step',
-      'value',
-      'valueasdate',
-      'valueasnumber',
-      'list',
-    ]),
-    '[type=week]': new Set([
-      'autocomplete',
-      'list',
-      'max',
-      'min',
-      'readonly',
-      'required',
-      'step',
-      'value',
-      'valueasdate',
-      'valueasnumber',
-      'list',
-    ]),
-    '[type=time]': new Set([
-      'autocomplete',
-      'list',
-      'max',
-      'min',
-      'readonly',
-      'required',
-      'step',
-      'value',
-      'valueasdate',
-      'valueasnumber',
-      'list',
-    ]),
-    '[type=datetime-local]': new Set([
-      'autocomplete',
-      'list',
-      'max',
-      'min',
-      'readonly',
-      'required',
-      'step',
-      'value',
-      'valueasnumber',
-      'list',
-    ]),
-    '[type=number]': new Set([
-      'autocomplete',
-      'list',
-      'max',
-      'min',
-      'placeholder',
-      'readonly',
-      'required',
-      'step',
-      'value',
-      'valueasnumber',
-      'list',
-    ]),
-    '[type=range]': new Set([
-      'autocomplete',
-      'list',
-      'max',
-      'min',
-      'step',
-      'value',
-      'valueasnumber',
-      'list',
-    ]),
-    '[type=color]': new Set([
-      'autocomplete',
-      'list',
-      'value',
-    ]),
-    '[type=checkbox]': new Set([
-      'checked',
-      'required',
-      'checked',
-      'value',
-    ]),
-    '[type=radio]': new Set([
-      'checked',
-      'required',
-      'checked',
-      'value',
-    ]),
-    '[type=file]': new Set([
-      'accept',
-      'multiple',
-      'required',
-      'files',
-      'value',
-    ]),
-    '[type=submit]': new Set([
-      'formaction',
-      'formenctype',
-      'formmethod',
-      'formnovalidate',
-      'formtarget',
-      'value',
-    ]),
-    '[type=image]': new Set([
-      'alt',
-      'formaction',
-      'formenctype',
-      'formmethod',
-      'formnovalidate',
-      'formtarget',
-      'height',
-      'src',
-      'width',
-      'value',
-    ]),
-    '[type=reset]': new Set([
-      'value',
-    ]),
-    '[type=button]': new Set([
-      'value',
-    ]),
-  },
+  HTMLInputElement: [
+    {
+      rule: {when: 'type', is: 'hidden'},
+      members: new Set([
+        'autocomplete',
+        'value',
+      ])
+    },
+    {
+      rule: {when: 'type', is: 'text'},
+      members: new Set([
+        'autocomplete',
+        'dirname',
+        'list',
+        'maxlength',
+        'minlength',
+        'pattern',
+        'placeholder',
+        'readonly',
+        'required',
+        'size',
+        'value',
+        'list',
+        'selectionstart',
+        'selectionend',
+        'selectiondirection',
+      ])
+    },
+    {
+      rule: {when: 'type', is: 'search'},
+      members: new Set([
+        'autocomplete',
+        'dirname',
+        'list',
+        'maxlength',
+        'minlength',
+        'pattern',
+        'placeholder',
+        'readonly',
+        'required',
+        'size',
+        'value',
+        'list',
+        'selectionstart',
+        'selectionend',
+        'selectiondirection',
+      ])
+    },
+    {
+      rule: {when: 'type', is: 'url'},
+      members: new Set([
+        'autocomplete',
+        'list',
+        'maxlength',
+        'minlength',
+        'pattern',
+        'placeholder',
+        'readonly',
+        'required',
+        'size',
+        'value',
+        'list',
+        'selectionstart',
+        'selectionend',
+        'selectiondirection',
+      ])
+    },
+    {
+      rule: {when: 'type', is: 'tel'},
+      members: new Set([
+        'autocomplete',
+        'list',
+        'maxlength',
+        'minlength',
+        'pattern',
+        'placeholder',
+        'readonly',
+        'required',
+        'size',
+        'value',
+        'list',
+        'selectionstart',
+        'selectionend',
+        'selectiondirection',
+      ])
+    },
+    {
+      rule: {when: 'type', is: 'email'},
+      members: new Set([
+        'autocomplete',
+        'list',
+        'maxlength',
+        'minlength',
+        'multiple',
+        'pattern',
+        'placeholder',
+        'readonly',
+        'required',
+        'size',
+        'value',
+        'list',
+      ])
+    },
+    {
+      rule: {when: 'type', is: 'password'},
+      members: new Set([
+        'autocomplete',
+        'maxlength',
+        'minlength',
+        'pattern',
+        'placeholder',
+        'readonly',
+        'required',
+        'size',
+        'value',
+        'selectionstart',
+        'selectionend',
+        'selectiondirection',
+      ])
+    },
+    {
+      rule: {when: 'type', is: 'date'},
+      members: new Set([
+        'autocomplete',
+        'list',
+        'max',
+        'min',
+        'readonly',
+        'required',
+        'step',
+        'value',
+        'valueasdate',
+        'valueasnumber',
+        'list',
+      ])
+    },
+    {
+      rule: {when: 'type', is: 'month'},
+      members: new Set([
+        'autocomplete',
+        'list',
+        'max',
+        'min',
+        'readonly',
+        'required',
+        'step',
+        'value',
+        'valueasdate',
+        'valueasnumber',
+        'list',
+      ])
+    },
+    {
+      rule: {when: 'type', is: 'week'},
+      members: new Set([
+        'autocomplete',
+        'list',
+        'max',
+        'min',
+        'readonly',
+        'required',
+        'step',
+        'value',
+        'valueasdate',
+        'valueasnumber',
+        'list',
+      ])
+    },
+    {
+      rule: {when: 'type', is: 'time'},
+      members: new Set([
+        'autocomplete',
+        'list',
+        'max',
+        'min',
+        'readonly',
+        'required',
+        'step',
+        'value',
+        'valueasdate',
+        'valueasnumber',
+        'list',
+      ])
+    },
+    {
+      rule: {when: 'type', is: 'datetime-local'},
+      members: new Set([
+        'autocomplete',
+        'list',
+        'max',
+        'min',
+        'readonly',
+        'required',
+        'step',
+        'value',
+        'valueasnumber',
+        'list',
+      ])
+    },
+    {
+      rule: {when: 'type', is: 'number'},
+      members: new Set([
+        'autocomplete',
+        'list',
+        'max',
+        'min',
+        'placeholder',
+        'readonly',
+        'required',
+        'step',
+        'value',
+        'valueasnumber',
+        'list',
+      ])
+    },
+    {
+      rule: {when: 'type', is: 'range'},
+      members: new Set([
+        'autocomplete',
+        'list',
+        'max',
+        'min',
+        'step',
+        'value',
+        'valueasnumber',
+        'list',
+      ])
+    },
+    {
+      rule: {when: 'type', is: 'color'},
+      members: new Set([
+        'autocomplete',
+        'list',
+        'value',
+      ])
+    },
+    {
+      rule: {when: 'type', is: 'checkbox'},
+      members: new Set([
+        'checked',
+        'required',
+        'checked',
+        'value',
+      ])
+    },
+    {
+      rule: {when: 'type', is: 'radio'},
+      members: new Set([
+        'checked',
+        'required',
+        'checked',
+        'value',
+      ])
+    },
+    {
+      rule: {when: 'type', is: 'file'},
+      members: new Set([
+        'accept',
+        'multiple',
+        'required',
+        'files',
+        'value',
+      ])
+    },
+    {
+      rule: {when: 'type', is: 'submit'},
+      members: new Set([
+        'formaction',
+        'formenctype',
+        'formmethod',
+        'formnovalidate',
+        'formtarget',
+        'value',
+      ])
+    },
+    {
+      rule: {when: 'type', is: 'image'},
+      members: new Set([
+        'alt',
+        'formaction',
+        'formenctype',
+        'formmethod',
+        'formnovalidate',
+        'formtarget',
+        'height',
+        'src',
+        'width',
+        'value',
+      ])
+    },
+    {
+      rule: {when: 'type', is: 'reset'},
+      members: new Set([
+        'value',
+      ])
+    },
+    {
+      rule: {when: 'type', is: 'button'},
+      members: new Set([
+        'value',
+      ])
+    },
+  ],
 };

package/scripts/webidl-properties/get-props.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-import {GLOBAL_ATTRIBUTES, SPECS, VALID_MEMBERS} from './config.js';
+import {APPLICABLE_MEMBERS, GLOBAL_ATTRIBUTES, SPECS} from './config.js';
 import {merge} from './util.js';
 
 /**
@@ -40,7 +40,7 @@ function transform({name, idls}, output = {}) {
       case 'dictionary': {
         output[idl.name] = output[idl.name] ?? makeEntry();
         let props = idl.members?.filter(member => ACCEPTED_MEMBER_TYPES.has(member.type));
-        props = props?.map(member => [member.name, {global: GLOBAL_ATTRIBUTES.has(member.name), specs: [name]}, ]);
+        props = props?.map(member => [member.name, {specs: [name]}]);
         merge(output[idl.name], {
           inheritance: idl.inheritance,
           props: Object.fromEntries(props),
@@ -71,22 +71,33 @@ function transform({name, idls}, output = {}) {
 /**
  * Adds additional metadata to the DOM pinned properties dataset.
  *
- * Currently only adds information about which properties are valid based on
- * some state, such as for the HTMLInputElement. See `VALID_MEMBERS`.
+ * Currently:
+ * - Adds a field specifying whether a member is a global attribute or not.
+ * - Adds information about which properties are "applicable" members for
+ * certain "states" their parent WebIDL type can be in, such as for the
+ * HTMLInputElement where the set of valid members are determined by the "type"
+ * property. See `APPLICABLE_MEMBERS`.
  *
  * @param {*} output
  */
 export function addMetadata(output) {
   for (const [key, value] of Object.entries(output)) {
-    const rule = VALID_MEMBERS[key];
-    if (!rule) {
-      continue;
+    for (const [name, prop] of Object.entries(value.props)) {
+      prop.global = GLOBAL_ATTRIBUTES.has(name);
+
+      const rules = APPLICABLE_MEMBERS[key];
+      if (!rules) {
+        continue;
+      }
+
+      for (const {rule, members} of rules) {
+        if (members.has(name.toLowerCase())) {
+          merge(prop, {rules: [rule]});
+        }
+      }
+
+      value.rules = rules.map(({rule}) => rule);
     }
-    const states = Object.entries(rule).map(([selector, allowlist]) => {
-      const valid = Object.entries(value.props).filter(([prop]) => allowlist.has(prop.toLowerCase()));
-      return [selector, Object.fromEntries(valid)];
-    });
-    value.states = Object.fromEntries(states);
   }
   return output;
 }