mongoid 9.0.11 → 9.1.0

data/spec/mongoid/association/referenced/has_and_belongs_to_many_spec.rb

@@ -1,11 +1,9 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
-require "spec_helper"
-require_relative "./has_and_belongs_to_many_models"
+require 'spec_helper'
+require_relative 'has_and_belongs_to_many_models'
 
 describe Mongoid::Association::Referenced::HasAndBelongsToMany do
-
   before do
     class HasManyLeftObject; include Mongoid::Document; end
     class HasManyRightObject; include Mongoid::Document; end
@@ -29,14 +27,13 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany do
   end
 
   let(:options) do
-    { }
+    {}
   end
 
   describe '#relation_complements' do
-
     let(:expected_complements) do
       [
-          Mongoid::Association::Referenced::HasAndBelongsToMany,
+        Mongoid::Association::Referenced::HasAndBelongsToMany
       ]
     end
 
@@ -46,7 +43,6 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany do
   end
 
   describe '#setup!' do
-
     it 'sets up a getter for the relation' do
       expect(Mongoid::Association::Accessors).to receive(:define_getter!).with(association)
       association.setup!
@@ -63,12 +59,10 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany do
     end
 
     context 'autosave' do
-
       context 'when the :autosave option is true' do
-
         let(:options) do
           {
-              autosave: true
+            autosave: true
           }
         end
 
@@ -85,10 +79,9 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany do
       end
 
       context 'when the :autosave option is false' do
-
         let(:options) do
           {
-              autosave: false
+            autosave: false
           }
         end
 
@@ -99,7 +92,6 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany do
       end
 
       context 'when the :autosave option is not provided' do
-
         let(:association) do
           # Note that it is necessary to create the association directly, otherwise the
           # setup! method will be called by the :has_many macro
@@ -114,10 +106,9 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany do
     end
 
     context 'when the :validate option is true' do
-
       let(:options) do
         {
-            validate: true
+          validate: true
         }
       end
 
@@ -134,10 +125,9 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany do
     end
 
     context 'when the :validate option is false' do
-
       let(:options) do
         {
-            validate: false
+          validate: false
         }
       end
 
@@ -148,7 +138,6 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany do
     end
 
     context 'when the :validate option is not provided' do
-
       let(:association) do
         # Note that it is necessary to create the association directly, otherwise the
         # setup! method will be called by the :has_many macro
@@ -162,7 +151,6 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany do
     end
 
     context 'foreign key field' do
-
       before do
         association
       end
@@ -173,13 +161,11 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany do
     end
 
     context 'index' do
-
       before do
         association
       end
 
       context 'when index is true' do
-
         let(:options) do
           {
             index: true
@@ -187,13 +173,11 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany do
         end
 
         it 'sets up the index with the key' do
-          expect(has_many_left_class.index_specifications.first.fields).to match_array([association.key.to_sym])
+          expect(has_many_left_class.index_specifications.first.fields).to contain_exactly(association.key.to_sym)
         end
       end
 
       context 'when index is false' do
-
-
         it 'does not set up an index' do
           expect(has_many_left_class.index_specifications).to eq([])
         end
@@ -201,14 +185,11 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany do
     end
 
     context 'dependent' do
-
       context 'when the dependent option is provided' do
-
         context 'when the dependent option is :delete_all' do
-
           let(:options) do
             {
-                dependent: :delete_all
+              dependent: :delete_all
             }
           end
 
@@ -225,10 +206,9 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany do
         end
 
         context 'when the dependent option is :destroy' do
-
           let(:options) do
             {
-                dependent: :destroy
+              dependent: :destroy
             }
           end
 
@@ -245,10 +225,9 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany do
         end
 
         context 'when the dependent option is :nullify' do
-
           let(:options) do
             {
-                dependent: :nullify
+              dependent: :nullify
             }
           end
 
@@ -265,10 +244,9 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany do
         end
 
         context 'when the dependent option is :restrict_with_exception' do
-
           let(:options) do
             {
-                dependent: :restrict_with_exception
+              dependent: :restrict_with_exception
             }
           end
 
@@ -285,10 +263,9 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany do
         end
 
         context 'when the dependent option is :restrict_with_error' do
-
           let(:options) do
             {
-                dependent: :restrict_with_error
+              dependent: :restrict_with_error
             }
           end
 
@@ -306,7 +283,6 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany do
       end
 
       context 'when the dependent option is not provided' do
-
         it 'does not set up the dependency' do
           expect(Mongoid::Association::Depending).not_to receive(:define_dependency!)
           association.setup!
@@ -316,30 +292,25 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany do
   end
 
   describe '#type' do
-
     it 'returns nil' do
       expect(association.type).to be_nil
     end
   end
 
   describe '#inverse_type' do
-
     it 'returns nil' do
       expect(association.inverse_type).to be_nil
     end
   end
 
   describe '#inverse_type_setter' do
-
     it 'returns nil' do
       expect(association.inverse_type_setter).to be_nil
     end
   end
 
   describe '#foreign_key' do
-
     context 'when options has foreign_key specified' do
-
       let(:options) do
         { foreign_key: :other_object_id }
       end
@@ -350,7 +321,6 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany do
     end
 
     context 'when options does not have foreign_key specified' do
-
       it 'returns the default foreign key, the name of the inverse followed by "_ids"' do
         expect(association.foreign_key).to eq("#{name.to_s.singularize}_ids")
       end
@@ -358,19 +328,16 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany do
   end
 
   describe '#embedded?' do
-
     it 'returns false' do
       expect(association.embedded?).to be(false)
     end
   end
 
   describe '#primary_key' do
-
     context 'when the :primary_key option is specified' do
-
       let(:options) do
         {
-            primary_key: 'guid'
+          primary_key: 'guid'
         }
       end
 
@@ -380,7 +347,6 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany do
     end
 
     context 'when the :primary_key option is not specified' do
-
       it 'returns the primary_key default' do
         expect(association.primary_key).to eq(Mongoid::Association::Relatable::PRIMARY_KEY_DEFAULT)
       end
@@ -388,14 +354,11 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany do
   end
 
   describe '#indexed?' do
-
     context 'when :index is specified in the options' do
-
       context 'when :index is true' do
-
         let(:options) do
           {
-              index: true
+            index: true
           }
         end
 
@@ -405,10 +368,9 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany do
       end
 
       context 'when :index is false' do
-
         let(:options) do
           {
-              index: false
+            index: false
           }
         end
 
@@ -419,7 +381,6 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany do
     end
 
     context 'when :index is not specified in the options' do
-
       it 'returns nil' do
         expect(association.indexed?).to be(false)
       end
@@ -427,58 +388,49 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany do
   end
 
   describe '#relation' do
-
     it 'returns Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy' do
       expect(association.relation).to be(Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy)
     end
   end
 
   describe '#validation_default' do
-
     it 'returns true' do
       expect(association.validation_default).to be(true)
     end
   end
 
   describe '#name' do
-
     it 'returns the name of the relation' do
       expect(association.name).to be(name)
     end
   end
 
   describe '#options' do
-
     it 'returns the options' do
       expect(association.options).to be(options)
     end
   end
 
   describe '#merge!' do
-
   end
 
   describe '#store_as' do
-
     it 'returns nil' do
       expect(association.store_as).to be_nil
     end
   end
 
   describe '#touchable?' do
-
     it 'return false' do
       expect(association.send(:touchable?)).to be(false)
     end
   end
 
   describe '#order' do
-
     context 'when order is specified in the options' do
-
       let(:options) do
         {
-            order: :rating.desc
+          order: :rating.desc
         }
       end
 
@@ -488,7 +440,6 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany do
     end
 
     context 'when order is not specified in the options' do
-
       it 'returns nil' do
         expect(association.order).to be_nil
       end
@@ -496,9 +447,7 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany do
   end
 
   describe '#scope' do
-
     context 'when scope is specified in the options' do
-
       let(:options) do
         { scope: -> { unscoped.where(foo: :bar) } }
       end
@@ -509,7 +458,6 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany do
     end
 
     context 'when scope is not specified in the options' do
-
       it 'returns nil' do
         expect(association.scope).to be_nil
       end
@@ -517,117 +465,98 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany do
   end
 
   describe '#as' do
-
     it 'returns nil' do
       expect(association.as).to be_nil
     end
   end
 
   describe '#polymorphic?' do
-
     it 'returns false' do
       expect(association.polymorphic?).to be(false)
     end
   end
 
   describe '#type_setter' do
-
     it 'returns nil' do
       expect(association.type).to be_nil
     end
   end
 
   describe '#dependent' do
-
     it 'returns nil' do
       expect(association.dependent).to be_nil
     end
   end
 
   describe '#bindable?' do
-
     it 'returns false' do
       expect(association.bindable?(Person.new)).to be(false)
     end
   end
 
   describe '#inverses' do
-
     before do
       HasManyRightObject.has_and_belongs_to_many :has_many_left_objects
     end
 
     context 'when inverse_of is specified' do
-
       before do
         options.merge!(inverse_of: :inverse_name)
       end
 
       it 'returns the :inverse_of value' do
-        expect(association.inverses).to eq([:inverse_name])
+        expect(association.inverses).to eq([ :inverse_name ])
       end
     end
 
     context 'when inverse_of is not specified' do
-
       it 'uses the inverse class to find the inverse name' do
-        expect(association.inverses).to eq([:has_many_left_objects])
+        expect(association.inverses).to eq([ :has_many_left_objects ])
       end
     end
 
     context 'when :cyclic is specified' do
-
       it 'returns the cyclic inverse name' do
-
       end
     end
   end
 
   describe '##inverse' do
+    before do
+      HasManyRightObject.has_and_belongs_to_many :has_many_left_objects
+    end
 
+    context 'when inverse_of is specified' do
       before do
-        HasManyRightObject.has_and_belongs_to_many :has_many_left_objects
+        options.merge!(inverse_of: :inverse_name)
       end
 
-      context 'when inverse_of is specified' do
-
-        before do
-          options.merge!(inverse_of: :inverse_name)
-        end
-
-        it 'returns the :inverse_of value' do
-          expect(association.inverse).to eq(:inverse_name)
-        end
+      it 'returns the :inverse_of value' do
+        expect(association.inverse).to eq(:inverse_name)
       end
+    end
 
-      context 'when inverse_of is not specified' do
-
-        it 'uses the inverse class to find the inverse name' do
-          expect(association.inverse).to eq(:has_many_left_objects)
-        end
+    context 'when inverse_of is not specified' do
+      it 'uses the inverse class to find the inverse name' do
+        expect(association.inverse).to eq(:has_many_left_objects)
       end
+    end
 
-      context 'when :cyclic is specified' do
-
-        it 'returns the cyclic inverse name' do
-
-        end
+    context 'when :cyclic is specified' do
+      it 'returns the cyclic inverse name' do
       end
     end
+  end
 
   describe '#inverse_association' do
-
   end
 
   describe '#autosave' do
-
     context 'when the autosave option is specified' do
-
       context 'when the autosave option is true' do
-
         let(:options) do
           {
-              autosave: true
+            autosave: true
           }
         end
 
@@ -637,10 +566,9 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany do
       end
 
       context 'when the autosave option is false' do
-
         let(:options) do
           {
-              autosave: false
+            autosave: false
           }
         end
 
@@ -651,7 +579,6 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany do
     end
 
     context 'when the autosave option is not specified' do
-
       it 'returns false' do
         expect(association.autosave).to be(false)
       end
@@ -659,9 +586,7 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany do
   end
 
   describe '#relation_class_name' do
-
     context 'when the :class_name option is specified' do
-
       let(:options) do
         { class_name: 'OtherHasManyRightObject' }
       end
@@ -672,7 +597,6 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany do
     end
 
     context 'when the class_name option is not specified' do
-
       it 'uses the name of the relation to deduce the class name' do
         expect(association.relation_class_name).to eq('HasManyRightObject')
       end
@@ -680,9 +604,7 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany do
   end
 
   describe '#relation_class' do
-
     context 'when the :class_name option is specified' do
-
       let!(:_class) do
         class OtherHasManyRightObject; end
         OtherHasManyRightObject
@@ -698,7 +620,6 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany do
     end
 
     context 'when the class_name option is not specified' do
-
       it 'uses the name of the relation to deduce the class name' do
         expect(association.relation_class).to eq(HasManyRightObject)
       end
@@ -706,23 +627,19 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany do
   end
 
   describe '#inverse_class_name' do
-
     it 'returns the name of the owner class' do
       expect(association.inverse_class_name).to eq(HasManyLeftObject.name)
     end
   end
 
   describe '#inverse_class' do
-
     it 'returns the owner class' do
       expect(association.inverse_class).to be(HasManyLeftObject)
     end
   end
 
   describe '#inverse_of' do
-
     context 'when :inverse_of is specified in the options' do
-
       let(:options) do
         { inverse_of: :a_has_many_left_object }
       end
@@ -733,7 +650,6 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany do
     end
 
     context 'when :inverse_of is not specified in the options' do
-
       it 'returns nil' do
         expect(association.inverse_of).to be_nil
       end
@@ -748,18 +664,14 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany do
   # end
 
   describe '#setter' do
-
     it 'returns a string of the name followed by =' do
       expect(association.setter).to eq("#{name}=")
     end
   end
 
   describe '#validate?' do
-
     context 'when :validate is specified in the options' do
-
       context 'when validate is true' do
-
         let(:options) do
           { validate: true }
         end
@@ -770,7 +682,6 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany do
       end
 
       context 'when validate is false' do
-
         let(:options) do
           { validate: false }
         end
@@ -782,7 +693,6 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany do
     end
 
     context 'when :validate is not specified in the options' do
-
       it 'returns the validation_default' do
         expect(association.send(:validate?)).to eq(association.validation_default)
       end
@@ -790,14 +700,11 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany do
   end
 
   describe '#forced_nil_inverse?' do
-
     context 'when inverse_of is specified in the options' do
-
       context 'when :inverse_of is nil' do
-
         let(:options) do
           {
-              inverse_of: nil
+            inverse_of: nil
           }
         end
 
@@ -807,10 +714,9 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany do
       end
 
       context 'when :inverse_of is a symbol' do
-
         let(:options) do
           {
-              inverse_of: :inverse_name
+            inverse_of: :inverse_name
           }
         end
 
@@ -820,10 +726,9 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany do
       end
 
       context 'when :inverse_of is false' do
-
         let(:options) do
           {
-              inverse_of: false
+            inverse_of: false
           }
         end
 
@@ -834,7 +739,6 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany do
     end
 
     context 'when :inverse_of is not specified in the options' do
-
       it 'returns false' do
         expect(association.forced_nil_inverse?).to be(false)
       end
@@ -842,16 +746,13 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany do
   end
 
   describe '#stores_foreign_key?' do
-
     it 'returns false' do
       expect(association.stores_foreign_key?).to be(true)
     end
   end
 
   describe '#inverse_setter' do
-
     context 'when an inverse can be determined' do
-
       before do
         HasManyRightObject.has_and_belongs_to_many :has_many_left_objects
       end
@@ -862,7 +763,6 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany do
     end
 
     context 'when an inverse cannot be determined' do
-
       it 'returns nil' do
         expect(association.inverse_setter).to be_nil
       end
@@ -870,11 +770,10 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany do
   end
 
   describe '#extension' do
-
     context 'when a block is passed' do
-
       let(:association) do
-        has_many_left_class.has_and_belongs_to_many name, options do; end
+        has_many_left_class.has_and_belongs_to_many name, options do
+        end
       end
 
       it 'defines an extension module' do
@@ -883,12 +782,12 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany do
 
       it 'returns the extension' do
         expect(association.extension).to eq(
-          "#{has_many_left_class.name}::#{has_many_left_class.name}#{name.to_s.camelize}RelationExtension".constantize)
+          "#{has_many_left_class.name}::#{has_many_left_class.name}#{name.to_s.camelize}RelationExtension".constantize
+        )
       end
     end
 
     context 'when an :extension is not specified in the options' do
-
       it 'returns false' do
         expect(association.extension).to be_nil
       end
@@ -896,28 +795,23 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany do
   end
 
   describe '#foreign_key_setter' do
-
     it 'returns the foreign key followed by "="' do
       expect(association.foreign_key_setter).to eq("#{association.foreign_key}=")
     end
   end
 
   describe '#criteria' do
-
     it 'returns a criteria object' do
       expect(association.criteria(BSON::ObjectId.new, HasManyLeftObject)).to be_a(Mongoid::Criteria)
     end
   end
 
   describe '#destructive?' do
-
     context 'when the dependent option is provided' do
-
       context 'when the dependent option is :delete_all' do
-
         let(:options) do
           {
-              dependent: :delete_all
+            dependent: :delete_all
           }
         end
 
@@ -927,10 +821,9 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany do
       end
 
       context 'when the dependent option is :destroy' do
-
         let(:options) do
           {
-              dependent: :destroy
+            dependent: :destroy
           }
         end
 
@@ -940,10 +833,9 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany do
       end
 
       context 'when the dependent option is :nullify' do
-
         let(:options) do
           {
-              dependent: :nullify
+            dependent: :nullify
           }
         end
 
@@ -953,10 +845,9 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany do
       end
 
       context 'when the dependent option is :restrict_with_exception' do
-
         let(:options) do
           {
-              dependent: :restrict_with_exception
+            dependent: :restrict_with_exception
           }
         end
 
@@ -966,10 +857,9 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany do
       end
 
       context 'when the dependent option is :restrict_with_error' do
-
         let(:options) do
           {
-              dependent: :restrict_with_error
+            dependent: :restrict_with_error
           }
         end
 
@@ -980,7 +870,6 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany do
     end
 
     context 'when the dependent option is not provided' do
-
       it 'returns false' do
         expect(association.destructive?).to be(false)
       end
@@ -988,35 +877,30 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany do
   end
 
   describe '#nested_builder' do
-
     it 'returns an instance of Association::Nested::Many' do
       expect(association.nested_builder({}, {})).to be_a(Mongoid::Association::Nested::Many)
     end
   end
 
   describe '#cascading_callbacks?' do
-
     it 'returns false' do
       expect(association.cascading_callbacks?).to be(false)
     end
   end
 
   describe '#path' do
-
     it 'returns an instance of Mongoid::Atomic::Paths::Root' do
       expect(association.path(double)).to be_a(Mongoid::Atomic::Paths::Root)
     end
   end
 
   describe '#foreign_key_check' do
-
     it 'returns the foreign_key followed by "_previously_changed?"' do
       expect(association.foreign_key_check).to eq('has_many_right_object_ids_previously_changed?')
     end
   end
 
   describe '#create_relation' do
-
     let(:left_object) do
       HasManyLeftObject.new
     end
@@ -1037,7 +921,6 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany do
   end
 
   describe '#inverse_foreign_key' do
-
     it 'returns generated key' do
       expect(association.inverse_foreign_key).to eq('has_many_left_object_ids')
     end
@@ -1063,23 +946,25 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany do
       end
     end
 
-    context "when using a model that uses the class_name option" do
+    context 'when using a model that uses the class_name option' do
       let(:inverse_foreign_key) { HabtmmSchool.relations[:students].inverse_foreign_key }
-      it "gets the correct inverse foreign key" do
-        expect(inverse_foreign_key).to eq("school_ids")
+
+      it 'gets the correct inverse foreign key' do
+        expect(inverse_foreign_key).to eq('school_ids')
       end
     end
   end
 
   describe '#inverse_foreign_key_setter' do
-
     it 'returns generated method name' do
       expect(association.inverse_foreign_key_setter).to eq('has_many_left_object_ids=')
     end
   end
 
-  context "when adding an object to the association" do
+  context 'when adding an object to the association' do
     let!(:start_time) { Timecop.freeze(Time.at(Time.now.to_i)) }
+    let!(:school) { HabtmmSchool.create! }
+    let!(:student) { HabtmmStudent.create! }
 
     let(:update_time) do
       Timecop.freeze(Time.at(Time.now.to_i) + 2)
@@ -1089,16 +974,13 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany do
       Timecop.return
     end
 
-    let!(:school) { HabtmmSchool.create! }
-    let!(:student) { HabtmmStudent.create! }
-
     before do
       update_time
-      school.update(students: [student])
+      school.update(students: [ student ])
     end
 
-    it "updates the updated at" do
-      pending "MONGOID-4953"
+    it 'updates the updated at' do
+      pending 'MONGOID-4953'
       expect(school.updated_at).to eq(update_time)
     end
   end