mongoid 9.0.11 → 9.1.0

data/spec/mongoid/clients_spec.rb

@@ -1,55 +1,48 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
-require "spec_helper"
+require 'spec_helper'
 
 describe Mongoid::Clients do
-
-  describe "#collection" do
-
-    shared_examples_for "an overridden collection at the class level" do
-
-      it "returns the collection for the model" do
+  describe '#collection' do
+    shared_examples_for 'an overridden collection at the class level' do
+      it 'returns the collection for the model' do
         expect(instance_collection).to be_a(Mongo::Collection)
       end
 
-      it "sets the correct collection name" do
-        expect(instance_collection.name).to eq("artists")
+      it 'sets the correct collection name' do
+        expect(instance_collection.name).to eq('artists')
       end
 
-      context "when accessing from the class level" do
-
-        it "returns the collection for the model" do
+      context 'when accessing from the class level' do
+        it 'returns the collection for the model' do
           expect(class_collection).to be_a(Mongo::Collection)
         end
 
-        it "sets the correct collection name" do
-          expect(class_collection.name).to eq("artists")
+        it 'sets the correct collection name' do
+          expect(class_collection.name).to eq('artists')
         end
       end
     end
 
-    context "when overriding the persistence options" do
-
+    context 'when overriding the persistence options' do
       let(:instance_collection) do
-        Band.with(collection: "artists") do |klass|
+        Band.with(collection: 'artists') do |klass|
           klass.new.collection
         end
       end
 
       let(:class_collection) do
-        Band.with(collection: "artists") do |klass|
+        Band.with(collection: 'artists') do |klass|
           klass.collection
         end
       end
 
-      it_behaves_like "an overridden collection at the class level"
+      it_behaves_like 'an overridden collection at the class level'
     end
 
-    context "when overriding store_in and persistence options" do
-
+    context 'when overriding store_in and persistence options' do
       before do
-        Band.store_in collection: "foo"
+        Band.store_in collection: 'foo'
       end
 
       after do
@@ -57,43 +50,40 @@ describe Mongoid::Clients do
       end
 
       let(:instance_collection) do
-        Band.with(collection: "artists") do |klass|
+        Band.with(collection: 'artists') do |klass|
           klass.new.collection
         end
       end
 
       let(:class_collection) do
-        Band.with(collection: "artists") do |klass|
+        Band.with(collection: 'artists') do |klass|
           klass.collection
         end
       end
 
-      it_behaves_like "an overridden collection at the class level"
+      it_behaves_like 'an overridden collection at the class level'
     end
 
-    context "when overriding the default with store_in" do
-
+    context 'when overriding the default with store_in' do
       after do
         Band.reset_storage_options!
       end
 
-      context "when called multiple times with different options" do
-
+      context 'when called multiple times with different options' do
         before do
-          Band.store_in collection: "artists"
-          Band.store_in client: "another"
+          Band.store_in collection: 'artists'
+          Band.store_in client: 'another'
         end
 
-        it "should merge the options together" do
-          expect(Band.storage_options[:collection]).to eq("artists")
-          expect(Band.storage_options[:client]).to eq("another")
+        it 'merges the options together' do
+          expect(Band.storage_options[:collection]).to eq('artists')
+          expect(Band.storage_options[:client]).to eq('another')
         end
       end
 
-      context "when overriding with a proc" do
-
+      context 'when overriding with a proc' do
         before do
-          Band.store_in(collection: ->{ "artists" })
+          Band.store_in(collection: -> { 'artists' })
         end
 
         let(:instance_collection) do
@@ -104,13 +94,12 @@ describe Mongoid::Clients do
           Band.collection
         end
 
-        it_behaves_like "an overridden collection at the class level"
+        it_behaves_like 'an overridden collection at the class level'
       end
 
-      context "when overriding with a string" do
-
+      context 'when overriding with a string' do
         before do
-          Band.store_in(collection: "artists")
+          Band.store_in(collection: 'artists')
         end
 
         after do
@@ -125,11 +114,10 @@ describe Mongoid::Clients do
           Band.collection
         end
 
-        it_behaves_like "an overridden collection at the class level"
+        it_behaves_like 'an overridden collection at the class level'
       end
 
-      context "when overriding with a symbol" do
-
+      context 'when overriding with a symbol' do
         before do
           Band.store_in(collection: :artists)
         end
@@ -146,97 +134,90 @@ describe Mongoid::Clients do
           Band.collection
         end
 
-        it_behaves_like "an overridden collection at the class level"
+        it_behaves_like 'an overridden collection at the class level'
       end
     end
 
-    context "when not overriding the default" do
-
+    context 'when not overriding the default' do
       let(:band) do
         Band.new
       end
 
-      it "returns the collection for the model" do
+      it 'returns the collection for the model' do
         expect(band.collection).to be_a(Mongo::Collection)
       end
 
-      it "sets the correct collection name" do
-        expect(band.collection.name.to_s).to eq("bands")
+      it 'sets the correct collection name' do
+        expect(band.collection.name.to_s).to eq('bands')
       end
 
-      context "when accessing from the class level" do
-
-        it "returns the collection for the model" do
+      context 'when accessing from the class level' do
+        it 'returns the collection for the model' do
           expect(Band.collection).to be_a(Mongo::Collection)
         end
 
-        it "sets the correct collection name" do
-          expect(Band.collection.name.to_s).to eq("bands")
+        it 'sets the correct collection name' do
+          expect(Band.collection.name.to_s).to eq('bands')
         end
       end
     end
   end
 
-  describe "#collection_name" do
-
-    shared_examples_for "an overridden collection name at the class level" do
-
-      context "when accessing from the instance" do
-
-        it "returns the overridden value" do
+  describe '#collection_name' do
+    shared_examples_for 'an overridden collection name at the class level' do
+      context 'when accessing from the instance' do
+        it 'returns the overridden value' do
           expect(instance_collection_name).to eq(:artists)
         end
       end
 
-      context "when accessing from the class level" do
-
-        it "returns the overridden value" do
+      context 'when accessing from the class level' do
+        it 'returns the overridden value' do
           expect(class_collection_name).to eq(:artists)
         end
       end
     end
 
-    context "when overriding the persistence options" do
-
+    context 'when overriding the persistence options' do
       let(:instance_collection_name) do
-        Band.with(collection: "artists") do |klass|
+        Band.with(collection: 'artists') do |klass|
           klass.new.collection_name
         end
       end
 
       let(:class_collection_name) do
-        Band.with(collection: "artists") do |klass|
+        Band.with(collection: 'artists') do |klass|
           klass.collection_name
         end
       end
 
-      it_behaves_like "an overridden collection name at the class level"
+      it_behaves_like 'an overridden collection name at the class level'
 
       context 'when nesting #with calls' do
         let(:instance_collection_name) do
-          Band.with(collection: "ignore") do |klass|
-            Band.with(collection: "artists") do |klass|
+          Band.with(collection: 'ignore') do |_klass|
+            Band.with(collection: 'artists') do |klass|
               klass.new.collection_name
             end
           end
         end
 
         let(:class_collection_name) do
-          Band.with(collection: "ignore") do |klass|
-            Band.with(collection: "artists") do |klass|
+          Band.with(collection: 'ignore') do |_klass|
+            Band.with(collection: 'artists') do |klass|
               klass.collection_name
             end
           end
         end
 
-        it_behaves_like "an overridden collection name at the class level"
+        it_behaves_like 'an overridden collection name at the class level'
       end
 
       context 'when outer #with call specifies the collection' do
         use_spec_mongoid_config
 
         let(:instance_collection_name) do
-          Band.with(collection: "artists") do |klass|
+          Band.with(collection: 'artists') do |_klass|
             Band.with(client: :reports) do |klass|
               klass.new.collection_name
             end
@@ -244,22 +225,22 @@ describe Mongoid::Clients do
         end
 
         let(:class_collection_name) do
-          Band.with(collection: "artists") do |klass|
+          Band.with(collection: 'artists') do |_klass|
             Band.with(client: :reports) do |klass|
               klass.collection_name
             end
           end
         end
 
-        it_behaves_like "an overridden collection name at the class level"
+        it_behaves_like 'an overridden collection name at the class level'
       end
 
       context 'restores outer context in outer block' do
         use_spec_mongoid_config
 
         let(:instance_collection_name) do
-          Band.with(collection: "artists") do |klass|
-            Band.with(collection: "scratch") do |klass|
+          Band.with(collection: 'artists') do |klass|
+            Band.with(collection: 'scratch') do |klass|
               # nothing
             end
             klass.new.collection_name
@@ -267,45 +248,43 @@ describe Mongoid::Clients do
         end
 
         let(:class_collection_name) do
-          Band.with(collection: "artists") do |klass|
-            Band.with(collection: "scratch") do |klass|
+          Band.with(collection: 'artists') do |klass|
+            Band.with(collection: 'scratch') do |klass|
               # nothing
             end
             klass.collection_name
           end
         end
 
-        it_behaves_like "an overridden collection name at the class level"
+        it_behaves_like 'an overridden collection name at the class level'
       end
     end
 
-    context "when overriding store_in and persistence options" do
-
+    context 'when overriding store_in and persistence options' do
       let(:instance_collection_name) do
-        Band.with(collection: "artists") do |klass|
+        Band.with(collection: 'artists') do |klass|
           klass.new.collection_name
         end
       end
 
       let(:class_collection_name) do
-        Band.with(collection: "artists") do |klass|
+        Band.with(collection: 'artists') do |klass|
           klass.collection_name
         end
       end
 
       before do
-        Band.store_in collection: "foo"
+        Band.store_in collection: 'foo'
       end
 
       after do
         Band.reset_storage_options!
       end
 
-      it_behaves_like "an overridden collection name at the class level"
+      it_behaves_like 'an overridden collection name at the class level'
     end
 
-    context "when overriding the default with store_in" do
-
+    context 'when overriding the default with store_in' do
       let(:instance_collection_name) do
         Band.new.collection_name
       end
@@ -318,100 +297,88 @@ describe Mongoid::Clients do
         Band.reset_storage_options!
       end
 
-      context "when overriding with a proc" do
-
+      context 'when overriding with a proc' do
         before do
-          Band.store_in(collection: ->{ "artists" })
+          Band.store_in(collection: -> { 'artists' })
         end
 
-        it_behaves_like "an overridden collection name at the class level"
+        it_behaves_like 'an overridden collection name at the class level'
       end
 
-      context "when overriding with a string" do
-
+      context 'when overriding with a string' do
         before do
-          Band.store_in(collection: "artists")
+          Band.store_in(collection: 'artists')
         end
 
-        it_behaves_like "an overridden collection name at the class level"
+        it_behaves_like 'an overridden collection name at the class level'
       end
 
-      context "when overriding with a symbol" do
-
+      context 'when overriding with a symbol' do
         before do
           Band.store_in(collection: :artists)
         end
 
-        it_behaves_like "an overridden collection name at the class level"
+        it_behaves_like 'an overridden collection name at the class level'
       end
     end
 
-    context "when not overriding the default" do
-
+    context 'when not overriding the default' do
       let(:band) do
         Band.new
       end
 
-      it "returns the pluralized model name" do
+      it 'returns the pluralized model name' do
         expect(band.collection_name).to eq(:bands)
       end
 
-      context "when accessing from the class level" do
-
-        it "returns the pluralized model name" do
+      context 'when accessing from the class level' do
+        it 'returns the pluralized model name' do
           expect(Band.collection_name).to eq(:bands)
         end
       end
     end
 
-    context "when the model is a subclass" do
-
+    context 'when the model is a subclass' do
       let(:firefox) do
         Firefox.new
       end
 
-      it "returns the root class pluralized model name" do
+      it 'returns the root class pluralized model name' do
         expect(firefox.collection_name).to eq(:canvases)
       end
 
-      context "when accessing from the class level" do
-
-        it "returns the root class pluralized model name" do
+      context 'when accessing from the class level' do
+        it 'returns the root class pluralized model name' do
           expect(Firefox.collection_name).to eq(:canvases)
         end
       end
     end
   end
 
-  describe "#database_name" do
-
-    shared_examples_for "an overridden database name" do
-
+  describe '#database_name' do
+    shared_examples_for 'an overridden database name' do
       after do
         class_mongo_client.close
       end
 
-      context "when accessing from the instance" do
-
-        it "returns the overridden value" do
+      context 'when accessing from the instance' do
+        it 'returns the overridden value' do
           expect(instance_database.name.to_s).to eq(database_id_alt)
         end
       end
 
-      context "when accessing from the class level" do
-
-        it "returns the overridden value" do
+      context 'when accessing from the class level' do
+        it 'returns the overridden value' do
           expect(class_database.name.to_s).to eq(database_id_alt)
         end
 
-        it "client returns the overridden value" do
+        it 'client returns the overridden value' do
           expect(class_mongo_client.database.name).to eq(database_id_alt)
         end
       end
     end
 
-    context "when overriding the persistence options" do
-
+    context 'when overriding the persistence options' do
       let(:instance_database) do
         Band.with(database: database_id_alt) do |klass|
           klass.new.mongo_client.database
@@ -430,11 +397,10 @@ describe Mongoid::Clients do
         end
       end
 
-      it_behaves_like "an overridden database name"
+      it_behaves_like 'an overridden database name'
     end
 
-    context "when overriding with store_in" do
-
+    context 'when overriding with store_in' do
       let(:instance_database) do
         Band.new.mongo_client.database
       end
@@ -456,11 +422,10 @@ describe Mongoid::Clients do
         class_mongo_client.close
       end
 
-      it_behaves_like "an overridden database name"
+      it_behaves_like 'an overridden database name'
     end
 
-    context "when overriding store_in and persistence options" do
-
+    context 'when overriding store_in and persistence options' do
       let(:instance_database) do
         Band.with(database: database_id_alt) do |klass|
           klass.new.mongo_client.database
@@ -480,7 +445,7 @@ describe Mongoid::Clients do
       end
 
       before do
-        Band.store_in database: "foo"
+        Band.store_in database: 'foo'
       end
 
       after do
@@ -488,11 +453,10 @@ describe Mongoid::Clients do
         class_mongo_client.close
       end
 
-      it_behaves_like "an overridden database name"
+      it_behaves_like 'an overridden database name'
     end
 
-    context "when overriding using the client" do
-
+    context 'when overriding using the client' do
       let(:client_name) { :alternative }
 
       before do
@@ -503,8 +467,7 @@ describe Mongoid::Clients do
         Mongoid.clients.delete(client_name)
       end
 
-      context "when overriding the persistence options" do
-
+      context 'when overriding the persistence options' do
         let(:instance_database) do
           Band.with(client: :alternative) do |klass|
             klass.new.mongo_client.database
@@ -523,11 +486,10 @@ describe Mongoid::Clients do
           end
         end
 
-        it_behaves_like "an overridden database name"
+        it_behaves_like 'an overridden database name'
       end
 
-      context "when overriding with store_in" do
-
+      context 'when overriding with store_in' do
         let(:instance_database) do
           Band.new.mongo_client.database
         end
@@ -549,15 +511,14 @@ describe Mongoid::Clients do
           class_mongo_client.close
         end
 
-        it_behaves_like "an overridden database name"
+        it_behaves_like 'an overridden database name'
       end
     end
   end
 
-  describe "#mongo_client" do
-
+  describe '#mongo_client' do
     let(:file) do
-      File.join(File.dirname(__FILE__), "..", "config", "mongoid.yml")
+      File.join(File.dirname(__FILE__), '..', 'config', 'mongoid.yml')
     end
 
     before do
@@ -566,10 +527,15 @@ describe Mongoid::Clients do
       Mongoid.clients[:default][:database] = database_id
     end
 
-    context "when getting the default" do
-
+    context 'when getting the default' do
       let(:file) do
-        File.join(File.dirname(__FILE__), "..", "config", "mongoid.yml")
+        File.join(File.dirname(__FILE__), '..', 'config', 'mongoid.yml')
+      end
+      let!(:band) do
+        Band.new
+      end
+      let!(:mongo_client) do
+        band.mongo_client
       end
 
       before do
@@ -582,15 +548,7 @@ describe Mongoid::Clients do
         mongo_client.close
       end
 
-      let!(:band) do
-        Band.new
-      end
-
-      let!(:mongo_client) do
-        band.mongo_client
-      end
-
-      it "returns the default client" do
+      it 'returns the default client' do
         expect(mongo_client.options[:database].to_s).to eq(database_id)
       end
 
@@ -598,13 +556,12 @@ describe Mongoid::Clients do
         expect(mongo_client.options[:platform]).to eq(Mongoid::PLATFORM_DETAILS)
       end
 
-      it "sets the app_name to the config value" do
+      it 'sets the app_name to the config value' do
         expect(mongo_client.options[:app_name]).to eq('testing')
       end
     end
 
-    context "when no client exists with the key" do
-
+    context 'when no client exists with the key' do
       before(:all) do
         Band.store_in(client: :nonexistent)
       end
@@ -613,14 +570,14 @@ describe Mongoid::Clients do
         Band.new
       end
 
-      it "raises an error" do
-        expect {
+      it 'raises an error' do
+        expect do
           band.mongo_client
-        }.to raise_error(Mongoid::Errors::NoClientConfig)
+        end.to raise_error(Mongoid::Errors::NoClientConfig)
       end
     end
 
-    context "when getting a client by name" do
+    context 'when getting a client by name' do
       use_spec_mongoid_config
 
       before do
@@ -636,7 +593,7 @@ describe Mongoid::Clients do
         Band.new.mongo_client
       end
 
-      it "uses the reports client" do
+      it 'uses the reports client' do
         expect(mongo_client.options[:database].to_s).to eq('reports')
       end
 
@@ -644,13 +601,12 @@ describe Mongoid::Clients do
         expect(mongo_client.options[:platform]).to eq(Mongoid::PLATFORM_DETAILS)
       end
 
-      it "sets the app_name to the config value" do
+      it 'sets the app_name to the config value' do
         expect(mongo_client.options[:app_name]).to eq('testing')
       end
     end
 
     context 'when the app_name is not set in the config' do
-
       before do
         Mongoid::Config.reset
         Mongoid.configure do |config|
@@ -668,10 +624,9 @@ describe Mongoid::Clients do
     end
   end
 
-  describe ".mongo_client" do
-
+  describe '.mongo_client' do
     let(:file) do
-      File.join(File.dirname(__FILE__), "..", "config", "mongoid.yml")
+      File.join(File.dirname(__FILE__), '..', 'config', 'mongoid.yml')
     end
 
     before do
@@ -684,10 +639,12 @@ describe Mongoid::Clients do
       Band.reset_storage_options!
     end
 
-    context "when getting the default" do
-
+    context 'when getting the default' do
       let(:file) do
-        File.join(File.dirname(__FILE__), "..", "config", "mongoid.yml")
+        File.join(File.dirname(__FILE__), '..', 'config', 'mongoid.yml')
+      end
+      let!(:mongo_client) do
+        Band.mongo_client
       end
 
       before do
@@ -697,11 +654,7 @@ describe Mongoid::Clients do
         Mongoid.clients[:default][:database] = database_id
       end
 
-      let!(:mongo_client) do
-        Band.mongo_client
-      end
-
-      it "returns the default client" do
+      it 'returns the default client' do
         expect(mongo_client.options[:database].to_s).to eq(database_id)
       end
 
@@ -709,50 +662,44 @@ describe Mongoid::Clients do
         expect(mongo_client.options[:platform]).to eq(Mongoid::PLATFORM_DETAILS)
       end
 
-      it "sets the app_name to the config value" do
+      it 'sets the app_name to the config value' do
         expect(mongo_client.options[:app_name]).to eq('testing')
       end
     end
 
-    context "when no client exists with the key" do
-
+    context 'when no client exists with the key' do
       before(:all) do
         Band.store_in(client: :nonexistent)
       end
 
-      it "raises an error" do
-        expect {
+      it 'raises an error' do
+        expect do
           Band.mongo_client
-        }.to raise_error(Mongoid::Errors::NoClientConfig)
+        end.to raise_error(Mongoid::Errors::NoClientConfig)
       end
     end
   end
 
-  describe ".store_in" do
-
-    context "when provided a non hash" do
-
-      it "raises an error" do
-        expect {
+  describe '.store_in' do
+    context 'when provided a non hash' do
+      it 'raises an error' do
+        expect do
           Band.store_in :artists
-        }.to raise_error(Mongoid::Errors::InvalidStorageOptions)
+        end.to raise_error(Mongoid::Errors::InvalidStorageOptions)
       end
     end
 
-    context "when provided a hash" do
-
-      context "when the hash is not valid" do
-
-        it "raises an error" do
-          expect {
-            Band.store_in coll: "artists"
-          }.to raise_error(Mongoid::Errors::InvalidStorageOptions)
+    context 'when provided a hash' do
+      context 'when the hash is not valid' do
+        it 'raises an error' do
+          expect do
+            Band.store_in coll: 'artists'
+          end.to raise_error(Mongoid::Errors::InvalidStorageOptions)
         end
       end
     end
 
-    context "when it is called on a subclass" do
-
+    context 'when it is called on a subclass' do
       let(:client) { StoreParent.collection.client }
       let(:parent) { StoreParent.create! }
       let(:child1) { StoreChild1.create! }
@@ -776,10 +723,8 @@ describe Mongoid::Clients do
         Object.send(:remove_const, :StoreChild2)
       end
 
-      context "when it is not called on the parent" do
-
-        context "when it is called on all subclasses" do
-
+      context 'when it is not called on the parent' do
+        context 'when it is called on all subclasses' do
           before do
             StoreChild1.store_in collection: :store_ones
             StoreChild2.store_in collection: :store_twos
@@ -790,21 +735,20 @@ describe Mongoid::Clients do
           let(:db_child1) { client['store_ones'].find.first }
           let(:db_child2) { client['store_twos'].find.first }
 
-          it "stores the documents in the correct collections" do
-            expect(db_parent).to eq({ "_id" => parent.id, "_type" => "StoreParent" })
-            expect(db_child1).to eq({ "_id" => child1.id, "_type" => "StoreChild1" })
-            expect(db_child2).to eq({ "_id" => child2.id, "_type" => "StoreChild2" })
+          it 'stores the documents in the correct collections' do
+            expect(db_parent).to eq({ '_id' => parent.id, '_type' => 'StoreParent' })
+            expect(db_child1).to eq({ '_id' => child1.id, '_type' => 'StoreChild1' })
+            expect(db_child2).to eq({ '_id' => child2.id, '_type' => 'StoreChild2' })
           end
 
-          it "only queries from its own collections" do
+          it 'only queries from its own collections' do
             expect(StoreParent.count).to eq(1)
             expect(StoreChild1.count).to eq(1)
             expect(StoreChild2.count).to eq(1)
           end
         end
 
-        context "when it is called on one of the subclasses" do
-
+        context 'when it is called on one of the subclasses' do
           before do
             StoreChild1.store_in collection: :store_ones
             [ parent, child1, child2 ]
@@ -814,13 +758,13 @@ describe Mongoid::Clients do
           let(:db_child1) { client['store_ones'].find.first }
           let(:db_child2) { client['store_parents'].find.to_a.last }
 
-          it "stores the documents in the correct collections" do
-            expect(db_parent).to eq({ "_id" => parent.id, "_type" => "StoreParent" })
-            expect(db_child1).to eq({ "_id" => child1.id, "_type" => "StoreChild1" })
-            expect(db_child2).to eq({ "_id" => child2.id, "_type" => "StoreChild2" })
+          it 'stores the documents in the correct collections' do
+            expect(db_parent).to eq({ '_id' => parent.id, '_type' => 'StoreParent' })
+            expect(db_child1).to eq({ '_id' => child1.id, '_type' => 'StoreChild1' })
+            expect(db_child2).to eq({ '_id' => child2.id, '_type' => 'StoreChild2' })
           end
 
-          it "queries from its own collections" do
+          it 'queries from its own collections' do
             expect(StoreParent.count).to eq(2)
             expect(StoreChild1.count).to eq(1)
             expect(StoreChild2.count).to eq(1)
@@ -828,14 +772,12 @@ describe Mongoid::Clients do
         end
       end
 
-      context "when it is called on the parent" do
-
+      context 'when it is called on the parent' do
         before do
           StoreParent.store_in collection: :st_parents
         end
 
-        context "when it is called on all subclasses" do
-
+        context 'when it is called on all subclasses' do
           before do
             StoreChild1.store_in collection: :store_ones
             StoreChild2.store_in collection: :store_twos
@@ -846,15 +788,14 @@ describe Mongoid::Clients do
           let(:db_child1) { client['store_ones'].find.first }
           let(:db_child2) { client['store_twos'].find.first }
 
-          it "stores the documents in the correct collections" do
-            expect(db_parent).to eq({ "_id" => parent.id, "_type" => "StoreParent" })
-            expect(db_child1).to eq({ "_id" => child1.id, "_type" => "StoreChild1" })
-            expect(db_child2).to eq({ "_id" => child2.id, "_type" => "StoreChild2" })
+          it 'stores the documents in the correct collections' do
+            expect(db_parent).to eq({ '_id' => parent.id, '_type' => 'StoreParent' })
+            expect(db_child1).to eq({ '_id' => child1.id, '_type' => 'StoreChild1' })
+            expect(db_child2).to eq({ '_id' => child2.id, '_type' => 'StoreChild2' })
           end
         end
 
-        context "when it is called on one of the subclasses" do
-
+        context 'when it is called on one of the subclasses' do
           before do
             StoreChild1.store_in collection: :store_ones
             [ parent, child1, child2 ]
@@ -864,20 +805,18 @@ describe Mongoid::Clients do
           let(:db_child1) { client['store_ones'].find.first }
           let(:db_child2) { client['st_parents'].find.to_a.last }
 
-          it "stores the documents in the correct collections" do
-            expect(db_parent).to eq({ "_id" => parent.id, "_type" => "StoreParent" })
-            expect(db_child1).to eq({ "_id" => child1.id, "_type" => "StoreChild1" })
-            expect(db_child2).to eq({ "_id" => child2.id, "_type" => "StoreChild2" })
+          it 'stores the documents in the correct collections' do
+            expect(db_parent).to eq({ '_id' => parent.id, '_type' => 'StoreParent' })
+            expect(db_child1).to eq({ '_id' => child1.id, '_type' => 'StoreChild1' })
+            expect(db_child2).to eq({ '_id' => child2.id, '_type' => 'StoreChild2' })
           end
         end
       end
     end
   end
 
-  describe ".with" do
-
-    context "when changing write concern options" do
-
+  describe '.with' do
+    context 'when changing write concern options' do
       let(:client_one) do
         Band.with(write: { w: 2 }) do |klass|
           klass.mongo_client
@@ -888,143 +827,130 @@ describe Mongoid::Clients do
         Band.mongo_client
       end
 
-      it "does not carry over the options" do
-        expect(client_one.write_concern).to_not eq(client_two.write_concern)
+      it 'does not carry over the options' do
+        expect(client_one.write_concern).not_to eq(client_two.write_concern)
       end
     end
 
-    context "when sending operations to a different database" do
-
+    context 'when sending operations to a different database' do
       after do
         Band.with(database: database_id_alt) do |klass|
           klass.delete_all
         end
       end
 
-      describe ".create!" do
-
+      describe '.create!' do
         let!(:band) do
           Band.with(database: database_id_alt) do |klass|
             klass.create!
           end
         end
 
-        it "does not persist to the default database" do
-          expect {
-            Band.find(band.id)
-          }.to raise_error(Mongoid::Errors::DocumentNotFound, /Document\(s\) not found for class Band with id\(s\)/)
+        let(:count) do
+          Band.with(database: database_id_alt) do |klass|
+            klass.count
+          end
         end
-
         let(:from_db) do
           Band.with(database: database_id_alt) do |klass|
             klass.find(band.id)
           end
         end
 
-        it "persists to the specified database" do
-          expect(from_db).to eq(band)
+        it 'does not persist to the default database' do
+          expect do
+            Band.find(band.id)
+          end.to raise_error(Mongoid::Errors::DocumentNotFound, /Document\(s\) not found for class Band with id\(s\)/)
         end
 
-        let(:count) do
-          Band.with(database: database_id_alt) do |klass|
-            klass.count
-          end
+        it 'persists to the specified database' do
+          expect(from_db).to eq(band)
         end
 
-        it "persists the correct number of documents" do
+        it 'persists the correct number of documents' do
           expect(count).to eq(1)
         end
       end
     end
 
-    context "when sending operations to a different collection" do
-
-      describe ".create!" do
-
+    context 'when sending operations to a different collection' do
+      describe '.create!' do
         let!(:band) do
-          Band.with(collection: "artists") do |klass|
+          Band.with(collection: 'artists') do |klass|
             klass.create!
           end
         end
 
-        it "does not persist to the default database" do
-          expect {
-            Band.find(band.id)
-          }.to raise_error(Mongoid::Errors::DocumentNotFound, /Document\(s\) not found for class Band with id\(s\)/)
+        let(:count) do
+          Band.with(collection: 'artists') do |klass|
+            klass.count
+          end
         end
-
         let(:from_db) do
-          Band.with(collection: "artists") do |klass|
+          Band.with(collection: 'artists') do |klass|
             klass.find(band.id)
           end
         end
 
-        it "persists to the specified database" do
-          expect(from_db).to eq(band)
+        it 'does not persist to the default database' do
+          expect do
+            Band.find(band.id)
+          end.to raise_error(Mongoid::Errors::DocumentNotFound, /Document\(s\) not found for class Band with id\(s\)/)
         end
 
-        let(:count) do
-          Band.with(collection: "artists") do |klass|
-            klass.count
-          end
+        it 'persists to the specified database' do
+          expect(from_db).to eq(band)
         end
 
-        it "persists the correct number of documents" do
+        it 'persists the correct number of documents' do
           expect(count).to eq(1)
         end
       end
     end
 
-    context "when sending operations with safe mode" do
-
-      describe ".create" do
-
+    context 'when sending operations with safe mode' do
+      describe '.create' do
         before do
           Person.index({ ssn: 1 }, { unique: true })
           Person.create_indexes
-          Person.create(ssn: "432-97-1111")
+          Person.create(ssn: '432-97-1111')
         end
 
         after do
           Person.collection.drop
         end
 
-        context "when no error occurs" do
-
-          it "inserts the document" do
+        context 'when no error occurs' do
+          it 'inserts the document' do
             expect(Person.count).to eq(1)
           end
         end
 
-        context "when a mongodb error occurs" do
-
-          it "bubbles up to the caller" do
-            expect {
-              Person.create(ssn: "432-97-1111")
-            }.to raise_error(Mongo::Error::OperationFailure)
+        context 'when a mongodb error occurs' do
+          it 'bubbles up to the caller' do
+            expect do
+              Person.create(ssn: '432-97-1111')
+            end.to raise_error(Mongo::Error::OperationFailure)
           end
         end
       end
 
-      describe ".create!" do
-
+      describe '.create!' do
         before do
-          Person.create!(ssn: "432-97-1112")
+          Person.create!(ssn: '432-97-1112')
         end
 
         after do
           Person.collection.drop
         end
 
-        context "when no error occurs" do
-
-          it "inserts the document" do
+        context 'when no error occurs' do
+          it 'inserts the document' do
             expect(Person.count).to eq(1)
           end
         end
 
-        context "when a mongodb error occurs" do
-
+        context 'when a mongodb error occurs' do
           before do
             Person.index({ ssn: 1 }, { unique: true })
             Person.create_indexes
@@ -1034,33 +960,30 @@ describe Mongoid::Clients do
             Person.collection.drop
           end
 
-          it "bubbles up to the caller" do
-            expect {
-              Person.create!(ssn: "432-97-1112")
-            }.to raise_error(Mongo::Error::OperationFailure)
+          it 'bubbles up to the caller' do
+            expect do
+              Person.create!(ssn: '432-97-1112')
+            end.to raise_error(Mongo::Error::OperationFailure)
           end
         end
 
-        context "when a validation error occurs" do
-
-          it "raises the validation error" do
-            expect {
-              Account.create!(name: "this name is way too long")
-            }.to raise_error(Mongoid::Errors::Validations)
+        context 'when a validation error occurs' do
+          it 'raises the validation error' do
+            expect do
+              Account.create!(name: 'this name is way too long')
+            end.to raise_error(Mongoid::Errors::Validations)
           end
         end
       end
 
-      describe ".save" do
-
+      describe '.save' do
         before do
-          Person.create!(ssn: "432-97-1113")
+          Person.create!(ssn: '432-97-1113')
         end
 
-        context "when a mongodb error occurs" do
-
+        context 'when a mongodb error occurs' do
           let(:person) do
-            Person.new(ssn: "432-97-1113")
+            Person.new(ssn: '432-97-1113')
           end
 
           before do
@@ -1072,24 +995,22 @@ describe Mongoid::Clients do
             Person.collection.drop
           end
 
-          it "bubbles up to the caller" do
-            expect {
+          it 'bubbles up to the caller' do
+            expect do
               person.save
-            }.to raise_error(Mongo::Error::OperationFailure)
+            end.to raise_error(Mongo::Error::OperationFailure)
           end
         end
       end
 
-      describe ".save!" do
-
+      describe '.save!' do
         before do
-          Person.create!(ssn: "432-97-1114")
+          Person.create!(ssn: '432-97-1114')
         end
 
-        context "when a mongodb error occurs" do
-
+        context 'when a mongodb error occurs' do
           let(:person) do
-            Person.new(ssn: "432-97-1114")
+            Person.new(ssn: '432-97-1114')
           end
 
           before do
@@ -1101,23 +1022,22 @@ describe Mongoid::Clients do
             Person.collection.drop
           end
 
-          it "bubbles up to the caller" do
-            expect {
+          it 'bubbles up to the caller' do
+            expect do
               person.save!
-            }.to raise_error(Mongo::Error::OperationFailure)
+            end.to raise_error(Mongo::Error::OperationFailure)
           end
         end
 
-        context "when a validation error occurs" do
-
+        context 'when a validation error occurs' do
           let(:account) do
-            Account.new(name: "this name is way too long")
+            Account.new(name: 'this name is way too long')
           end
 
-          it "raises the validation error" do
-            expect {
+          it 'raises the validation error' do
+            expect do
               account.save!
-            }.to raise_error(Mongoid::Errors::Validations)
+            end.to raise_error(Mongoid::Errors::Validations)
           end
         end
       end
@@ -1126,7 +1046,7 @@ describe Mongoid::Clients do
     context 'when requesting named client' do
       let(:secondary_client) do
         double(Mongo::Client).tap do |client|
-          allow(client).to receive(:cluster).and_return(double("cluster"))
+          allow(client).to receive(:cluster).and_return(double('cluster'))
         end
       end
 
@@ -1157,7 +1077,7 @@ describe Mongoid::Clients do
       require_mri
 
       let(:first_band) do
-        Band.create!(name: "The Beatles")
+        Band.create!(name: 'The Beatles')
       end
 
       let(:second_band) do
@@ -1174,23 +1094,19 @@ describe Mongoid::Clients do
         end
         expect(Symbol.all_symbols.size).to be <= initial_symbols_count
       end
-
     end
-
   end
 
-  context "when overriding the default database" do
-
+  context 'when overriding the default database' do
     let(:file) do
-      File.join(File.dirname(__FILE__), "..", "config", "mongoid.yml")
+      File.join(File.dirname(__FILE__), '..', 'config', 'mongoid.yml')
     end
 
     before do
       Mongoid::Config.load!(file, :test)
     end
 
-    context "when the override is global" do
-
+    context 'when the override is global' do
       before do
         Mongoid.override_database(:mongoid_optional)
       end
@@ -1202,12 +1118,12 @@ describe Mongoid::Clients do
       end
 
       let!(:band) do
-        Band.create!(name: "Tool")
+        Band.create!(name: 'Tool')
       end
 
-      it "persists to the overridden database" do
+      it 'persists to the overridden database' do
         Band.mongo_client.with(database: :mongoid_optional) do |sess|
-          expect(sess[:bands].find(name: "Tool")).to_not be_nil
+          expect(sess[:bands].find(name: 'Tool')).not_to be_nil
         end
       end
 
@@ -1217,8 +1133,7 @@ describe Mongoid::Clients do
     end
   end
 
-  context "#disconnect" do
-
+  describe '#disconnect' do
     let(:clients) do
       Mongoid::Clients.clients.values
     end
@@ -1227,20 +1142,17 @@ describe Mongoid::Clients do
       Band.all.entries
     end
 
-    it "disconnects from all active clients" do
-      clients.each do |client|
-        expect(client).to receive(:close).and_call_original
-      end
+    it 'disconnects from all active clients' do
+      expect(clients).to all(receive(:close).and_call_original)
       Mongoid::Clients.disconnect
     end
 
-    it "returns true" do
+    it 'returns true' do
       expect(Mongoid::Clients.disconnect).to eq(true)
     end
   end
 
-  context "#reconnect" do
-
+  describe '#reconnect' do
     let(:clients) do
       Mongoid::Clients.clients.values
     end
@@ -1249,14 +1161,12 @@ describe Mongoid::Clients do
       Band.all.entries
     end
 
-    it "reconnects all active clients" do
-      clients.each do |client|
-        expect(client).to receive(:reconnect).and_call_original
-      end
+    it 'reconnects all active clients' do
+      expect(clients).to all(receive(:reconnect).and_call_original)
       Mongoid::Clients.reconnect
     end
 
-    it "returns true" do
+    it 'returns true' do
       expect(Mongoid::Clients.reconnect).to eq(true)
     end
   end