mongoid 9.0.11 → 9.1.0

data/spec/mongoid/shardable_models.rb

@@ -1,4 +1,3 @@
-# rubocop:todo all
 class SmMovie
   include Mongoid::Document
 
@@ -36,7 +35,7 @@ class SmProducer
   include Mongoid::Document
 
   index age: 1, gender: 1
-  shard_key({age: 1, gender: 'hashed'}, unique: true, numInitialChunks: 2)
+  shard_key({ age: 1, gender: 'hashed' }, unique: true, numInitialChunks: 2)
 end
 
 class SmDirector
@@ -63,14 +62,15 @@ end
 
 class SmReviewAuthor
   include Mongoid::Document
-  embedded_in :review, class_name: "SmReview", touch: false
+
+  embedded_in :review, class_name: 'SmReview', touch: false
   field :name, type: String
 end
 
 class SmReview
   include Mongoid::Document
 
-  embeds_one :author, class_name: "SmReviewAuthor"
+  embeds_one :author, class_name: 'SmReviewAuthor'
 
-  shard_key "author.name" => 1
+  shard_key 'author.name' => 1
 end

data/spec/mongoid/shardable_spec.rb

@@ -1,78 +1,74 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
-require "spec_helper"
-require_relative './shardable_models'
+require 'spec_helper'
+require_relative 'shardable_models'
 
 describe Mongoid::Shardable do
-
-  describe ".included" do
-
+  describe '.included' do
     let(:klass) do
       Class.new do
         include Mongoid::Shardable
       end
     end
 
-    it "adds an shard_key_fields accessor" do
+    it 'adds an shard_key_fields accessor' do
       expect(klass).to respond_to(:shard_key_fields)
     end
 
-    it "defaults shard_key_fields to an empty array" do
+    it 'defaults shard_key_fields to an empty array' do
       expect(klass.shard_key_fields).to be_empty
     end
   end
 
-  describe ".shard_key" do
-
+  describe '.shard_key' do
     context 'when full syntax is used' do
       context 'with symbol value' do
         it 'sets shard key fields to symbol value' do
-          expect(SmProducer.shard_key_fields).to be == %i(age gender)
+          expect(SmProducer.shard_key_fields).to eq %i[age gender]
         end
 
         it 'sets shard config' do
-          expect(SmProducer.shard_config).to be == {
-            key: {age: 1, gender: 'hashed'},
-            options: {
-              unique: true,
-              numInitialChunks: 2,
-            },
-          }
+          expect(SmProducer.shard_config).to eq({
+                                                  key: { age: 1, gender: 'hashed' },
+                                                  options: {
+                                                    unique: true,
+                                                    numInitialChunks: 2
+                                                  }
+                                                })
         end
 
         it 'keeps hashed as string' do
-          expect(SmProducer.shard_config[:key][:gender]).to be == 'hashed'
+          expect(SmProducer.shard_config[:key][:gender]).to eq 'hashed'
         end
       end
 
       context 'with string value' do
         it 'sets shard key fields to symbol value' do
-          expect(SmActor.shard_key_fields).to be == %i(age gender hello)
+          expect(SmActor.shard_key_fields).to eq %i[age gender hello]
         end
 
         it 'sets shard config' do
-          expect(SmActor.shard_config).to be == {
-            key: {age: 1, gender: 'hashed', hello: 'hashed'},
-            options: {},
-          }
+          expect(SmActor.shard_config).to eq({
+                                               key: { age: 1, gender: 'hashed', hello: 'hashed' },
+                                               options: {}
+                                             })
         end
 
         it 'sets hashed to string' do
-          expect(SmActor.shard_config[:key][:gender]).to be == 'hashed'
+          expect(SmActor.shard_config[:key][:gender]).to eq 'hashed'
         end
       end
 
       context 'when passed association name' do
         it 'uses foreign key as shard key in shard config' do
-          expect(SmDriver.shard_config).to be == {
-            key: {age: 1, agency_id: 'hashed'},
-            options: {},
-          }
+          expect(SmDriver.shard_config).to eq({
+                                                key: { age: 1, agency_id: 'hashed' },
+                                                options: {}
+                                              })
         end
 
         it 'uses foreign key as shard key in shard key fields' do
-          expect(SmDriver.shard_key_fields).to be == %i(age agency_id)
+          expect(SmDriver.shard_key_fields).to eq %i[age agency_id]
         end
       end
     end
@@ -80,26 +76,26 @@ describe Mongoid::Shardable do
     context 'when shorthand syntax is used' do
       context 'with symbol value' do
         it 'sets shard key fields to symbol value' do
-          expect(SmMovie.shard_key_fields).to be == %i(year)
+          expect(SmMovie.shard_key_fields).to eq %i[year]
         end
       end
 
       context 'with string value' do
         it 'sets shard key fields to symbol value' do
-          expect(SmTrailer.shard_key_fields).to be == %i(year)
+          expect(SmTrailer.shard_key_fields).to eq %i[year]
         end
       end
 
       context 'when passed association name' do
         it 'uses foreign key as shard key in shard config' do
-          expect(SmDirector.shard_config).to be == {
-            key: {agency_id: 1},
-            options: {},
-          }
+          expect(SmDirector.shard_config).to eq({
+                                                  key: { agency_id: 1 },
+                                                  options: {}
+                                                })
         end
 
         it 'uses foreign key as shard key in shard key fields' do
-          expect(SmDirector.shard_key_fields).to be == %i(agency_id)
+          expect(SmDirector.shard_key_fields).to eq %i[agency_id]
         end
       end
     end
@@ -107,7 +103,7 @@ describe Mongoid::Shardable do
 
   describe '#shard_key_selector' do
     subject { instance.shard_key_selector }
-    
+
     context 'when key is an immediate attribute' do
       let(:klass) { Band }
       let(:value) { 'a-brand-name' }
@@ -227,17 +223,18 @@ describe Mongoid::Shardable do
         end
       end
 
-      context "when record is not found" do
+      context 'when record is not found' do
         let!(:instance) { klass.create!(name: value) }
 
         before do
           instance.destroy
         end
 
-        it "raises a DocumentNotFound error with the shard key in the description on reload" do
+        it 'raises a DocumentNotFound error with the shard key in the description on reload' do
           expect do
             instance.reload
-          end.to raise_error(Mongoid::Errors::DocumentNotFound, /Document not found for class Band with id #{instance.id.to_s} and shard key name: a-brand-name./)
+          end.to raise_error(Mongoid::Errors::DocumentNotFound,
+                             /Document not found for class Band with id #{instance.id} and shard key name: a-brand-name./)
         end
       end
     end
@@ -278,17 +275,18 @@ describe Mongoid::Shardable do
           it { is_expected.to eq({ key => value }) }
         end
 
-        context "when record is not found" do
+        context 'when record is not found' do
           let!(:instance) { klass.create!(author: { name: value }) }
-  
+
           before do
             instance.destroy
           end
-  
-          it "raises a DocumentNotFound error with the shard key in the description on reload" do
+
+          it 'raises a DocumentNotFound error with the shard key in the description on reload' do
             expect do
               instance.reload
-            end.to raise_error(Mongoid::Errors::DocumentNotFound, /Document not found for class SmReview with id #{instance.id.to_s} and shard key author.name: Arthur Conan Doyle./)
+            end.to raise_error(Mongoid::Errors::DocumentNotFound,
+                               /Document not found for class SmReview with id #{instance.id} and shard key author.name: Arthur Conan Doyle./)
           end
         end
       end

data/spec/mongoid/stateful_spec.rb

@@ -1,58 +1,52 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
-require "spec_helper"
+require 'spec_helper'
 
 describe Mongoid::Stateful do
-
-  describe "#new_record?" do
-
-    context "when calling new on the document" do
-
+  describe '#new_record?' do
+    context 'when calling new on the document' do
       let(:person) do
-        Person.new("_id" => BSON::ObjectId.new)
+        Person.new('_id' => BSON::ObjectId.new)
       end
 
-      it "returns true" do
+      it 'returns true' do
         expect(person).to be_a_new_record
       end
     end
 
-    context "when the object has been saved" do
-
+    context 'when the object has been saved' do
       let(:person) do
-        Person.instantiate("_id" => BSON::ObjectId.new)
+        Person.instantiate('_id' => BSON::ObjectId.new)
       end
 
-      it "returns false" do
-        expect(person).to_not be_a_new_record
+      it 'returns false' do
+        expect(person).not_to be_a_new_record
       end
     end
 
-    context "when the object has not been saved" do
-
+    context 'when the object has not been saved' do
       let(:person) do
         Person.new
       end
 
-      it "returns true" do
+      it 'returns true' do
         expect(person).to be_a_new_record
       end
     end
   end
 
   describe '#previously_new_record?' do
-    it "returns correct values" do
+    it 'returns correct values' do
       person = Person.new
       expect(person).not_to be_a_previously_new_record
       person.save!
       expect(person).to be_a_previously_new_record
-      person.title = "Title"
+      person.title = 'Title'
       person.save!
       expect(person).not_to be_a_previously_new_record
     end
 
-    it "resets after reload" do
+    it 'resets after reload' do
       person = Person.create!
       expect(person).to be_a_previously_new_record
       person.reload
@@ -60,30 +54,29 @@ describe Mongoid::Stateful do
     end
   end
 
-  describe "#persisted?" do
-
+  describe '#persisted?' do
     let(:person) do
       Person.new
     end
 
-    it "delegates to new_record?" do
-      expect(person).to_not be_persisted
+    it 'delegates to new_record?' do
+      expect(person).not_to be_persisted
     end
 
-    context "when the object has been destroyed" do
+    context 'when the object has been destroyed' do
       before do
         person.save!
         person.destroy
       end
 
-      it "returns false" do
-        expect(person).to_not be_persisted
+      it 'returns false' do
+        expect(person).not_to be_persisted
       end
     end
   end
 
-  describe "#previously_persisted?" do
-    it "returns true after being destroyed" do
+  describe '#previously_persisted?' do
+    it 'returns true after being destroyed' do
       person = Person.create!
       expect(person).not_to be_previously_persisted
       person.destroy
@@ -91,92 +84,83 @@ describe Mongoid::Stateful do
     end
   end
 
-  describe "destroyed?" do
-
+  describe 'destroyed?' do
     let(:person) do
       Person.new
     end
 
-    context "when destroyed is true" do
-
+    context 'when destroyed is true' do
       before do
         person.destroyed = true
       end
 
-      it "returns true" do
+      it 'returns true' do
         expect(person).to be_destroyed
       end
     end
 
-    context "when destroyed is false" do
-
+    context 'when destroyed is false' do
       before do
         person.destroyed = false
       end
 
-      it "returns true" do
-        expect(person).to_not be_destroyed
+      it 'returns true' do
+        expect(person).not_to be_destroyed
       end
     end
 
-    context "when destroyed is nil" do
-
+    context 'when destroyed is nil' do
       before do
         person.destroyed = nil
       end
 
-      it "returns false" do
-        expect(person).to_not be_destroyed
+      it 'returns false' do
+        expect(person).not_to be_destroyed
       end
     end
   end
 
-  describe "#readonly?" do
-
+  describe '#readonly?' do
     let(:document) do
       Band.new
     end
 
-    context "when legacy_readonly is true" do
+    context 'when legacy_readonly is true' do
       config_override :legacy_readonly, true
 
-      context "when the selected fields are set" do
-
+      context 'when the selected fields are set' do
         before do
           document.__selected_fields = { test: 1 }
         end
 
-        it "returns true" do
+        it 'returns true' do
           expect(document).to be_readonly
         end
       end
 
-      context "when no readonly has been set" do
-
-        it "returns false" do
-          expect(document).to_not be_readonly
+      context 'when no readonly has been set' do
+        it 'returns false' do
+          expect(document).not_to be_readonly
         end
       end
 
-      context "when the readonly! method is called" do
-
+      context 'when the readonly! method is called' do
         let(:op) do
           document.readonly!
         end
 
-        it "returns false" do
+        it 'returns false' do
           op
-          expect(document).to_not be_readonly
+          expect(document).not_to be_readonly
         end
 
-        it "warns" do
+        it 'warns' do
           expect(Mongoid::Warnings).to receive(:warn_legacy_readonly)
           op
         end
       end
 
-      context "when overriding readonly?" do
-
+      context 'when overriding readonly?' do
         let(:doc) { ReadonlyModel.create! }
 
         before do
@@ -195,7 +179,7 @@ describe Mongoid::Stateful do
           Object.send(:remove_const, :ReadonlyModel)
         end
 
-        it "raises when readonly? is true" do
+        it 'raises when readonly? is true' do
           expect(doc.readonly?).to be false
           doc.locked = true
           expect(doc.readonly?).to be true
@@ -206,40 +190,36 @@ describe Mongoid::Stateful do
       end
     end
 
-    context "when legacy_readonly is false" do
+    context 'when legacy_readonly is false' do
       config_override :legacy_readonly, false
 
-      context "when the selected fields are set" do
-
+      context 'when the selected fields are set' do
         before do
           document.__selected_fields = { test: 1 }
         end
 
-        it "returns false" do
-          expect(document).to_not be_readonly
+        it 'returns false' do
+          expect(document).not_to be_readonly
         end
       end
 
-      context "when the readonly! method is called" do
-
+      context 'when the readonly! method is called' do
         before do
           document.readonly!
         end
 
-        it "returns true" do
+        it 'returns true' do
           expect(document).to be_readonly
         end
       end
 
-      context "when no readonly has been set" do
-
-        it "returns false" do
-          expect(document).to_not be_readonly
+      context 'when no readonly has been set' do
+        it 'returns false' do
+          expect(document).not_to be_readonly
         end
       end
 
-      context "when overriding readonly?" do
-
+      context 'when overriding readonly?' do
         let(:doc) { ReadonlyModel.new }
 
         before do
@@ -258,7 +238,7 @@ describe Mongoid::Stateful do
           Object.send(:remove_const, :ReadonlyModel)
         end
 
-        it "raises when readonly? is true" do
+        it 'raises when readonly? is true' do
           expect(doc.readonly?).to be false
           doc.locked = true
           expect(doc.readonly?).to be true