mongoid 9.0.11 → 9.1.0

data/spec/mongoid/criteria/queryable/extensions/time_with_zone_spec.rb

@@ -1,18 +1,14 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
-require "spec_helper"
+require 'spec_helper'
 
 describe ActiveSupport::TimeWithZone do
-
   let(:time_zone) do
-    ActiveSupport::TimeZone.new("Eastern Time (US & Canada)")
+    ActiveSupport::TimeZone.new('Eastern Time (US & Canada)')
   end
 
-  describe ".evolve" do
-
-    context "when provided a time" do
-
+  describe '.evolve' do
+    context 'when provided a time' do
       let(:date) do
         time_zone.local(2010, 1, 1, 12, 0, 0)
       end
@@ -25,19 +21,17 @@ describe ActiveSupport::TimeWithZone do
         Time.utc(2010, 1, 1, 17, 0, 0)
       end
 
-      it "returns the same time" do
+      it 'returns the same time' do
         expect(evolved).to eq(expected)
       end
 
-      it "returns the time in utc" do
+      it 'returns the time in utc' do
         expect(evolved.utc_offset).to eq(0)
       end
     end
 
-    context "when provided an array" do
-
-      context "when the array is composed of times" do
-
+    context 'when provided an array' do
+      context 'when the array is composed of times' do
         let(:date) do
           time_zone.local(2010, 1, 1, 12, 0, 0)
         end
@@ -50,38 +44,36 @@ describe ActiveSupport::TimeWithZone do
           Time.utc(2010, 1, 1, 17, 0, 0)
         end
 
-        it "returns the array with evolved times" do
+        it 'returns the array with evolved times' do
           expect(evolved).to eq([ expected ])
         end
 
-        it "returns utc times" do
+        it 'returns utc times' do
           expect(evolved.first.utc_offset).to eq(0)
         end
       end
 
-      context "when the array is composed of strings" do
-
+      context 'when the array is composed of strings' do
         let(:date) do
-          time_zone.parse("1st Jan 2010 12:00:00+01:00")
+          time_zone.parse('1st Jan 2010 12:00:00+01:00')
         end
 
         let(:evolved) do
           described_class.evolve([ date.to_s ])
         end
 
-        it "returns the strings as a times" do
+        it 'returns the strings as a times' do
           expect(evolved).to eq([ date.to_time ])
         end
 
-        it "returns the times in utc" do
+        it 'returns the times in utc' do
           expect(evolved.first.utc_offset).to eq(0)
         end
       end
 
-      context "when the array is composed of integers" do
-
+      context 'when the array is composed of integers' do
         let(:integer) do
-          1331890719
+          1_331_890_719
         end
 
         let(:evolved) do
@@ -92,19 +84,18 @@ describe ActiveSupport::TimeWithZone do
           Time.at(integer).utc
         end
 
-        it "returns the integers as times" do
+        it 'returns the integers as times' do
           expect(evolved).to eq([ expected ])
         end
 
-        it "returns the times in utc" do
+        it 'returns the times in utc' do
           expect(evolved.first.utc_offset).to eq(0)
         end
       end
 
-      context "when the array is composed of floats" do
-
+      context 'when the array is composed of floats' do
         let(:float) do
-          1331890719.413
+          1_331_890_719.413
         end
 
         let(:evolved) do
@@ -115,20 +106,18 @@ describe ActiveSupport::TimeWithZone do
           Time.at(float).utc
         end
 
-        it "returns the floats as times" do
+        it 'returns the floats as times' do
           expect(evolved).to eq([ expected ])
         end
 
-        it "returns the times in utc" do
+        it 'returns the times in utc' do
           expect(evolved.first.utc_offset).to eq(0)
         end
       end
     end
 
-    context "when provided a range" do
-
-      context "when the range are dates" do
-
+    context 'when provided a range' do
+      context 'when the range are dates' do
         let(:min) do
           time_zone.local(2010, 1, 1, 12, 0, 0)
         end
@@ -149,19 +138,18 @@ describe ActiveSupport::TimeWithZone do
           Time.utc(2010, 1, 3, 17, 0, 0)
         end
 
-        it "returns a selection of times" do
+        it 'returns a selection of times' do
           expect(evolved).to eq(
-            { "$gte" => expected_min, "$lte" => expected_max }
+            { '$gte' => expected_min, '$lte' => expected_max }
           )
         end
 
-        it "returns the times in utc" do
-          expect(evolved["$gte"].utc_offset).to eq(0)
+        it 'returns the times in utc' do
+          expect(evolved['$gte'].utc_offset).to eq(0)
         end
       end
 
-      context "when the range are strings" do
-
+      context 'when the range are strings' do
         let(:min) do
           time_zone.local(2010, 1, 1, 12, 0, 0)
         end
@@ -174,25 +162,24 @@ describe ActiveSupport::TimeWithZone do
           described_class.evolve(min.to_s..max.to_s)
         end
 
-        it "returns a selection of times" do
+        it 'returns a selection of times' do
           expect(evolved).to eq(
-            { "$gte" => min.to_time, "$lte" => max.to_time }
+            { '$gte' => min.to_time, '$lte' => max.to_time }
           )
         end
 
-        it "returns the times in utc" do
-          expect(evolved["$gte"].utc_offset).to eq(0)
+        it 'returns the times in utc' do
+          expect(evolved['$gte'].utc_offset).to eq(0)
         end
       end
 
-      context "when the range is floats" do
-
+      context 'when the range is floats' do
         let(:min) do
-          1331890719.1234
+          1_331_890_719.1234
         end
 
         let(:max) do
-          1332890719.7651
+          1_332_890_719.7651
         end
 
         let(:evolved) do
@@ -207,25 +194,24 @@ describe ActiveSupport::TimeWithZone do
           Time.at(max).utc
         end
 
-        it "returns a selection of times" do
+        it 'returns a selection of times' do
           expect(evolved).to eq(
-            { "$gte" => expected_min, "$lte" => expected_max }
+            { '$gte' => expected_min, '$lte' => expected_max }
           )
         end
 
-        it "returns the times in utc" do
-          expect(evolved["$gte"].utc_offset).to eq(0)
+        it 'returns the times in utc' do
+          expect(evolved['$gte'].utc_offset).to eq(0)
         end
       end
 
-      context "when the range is integers" do
-
+      context 'when the range is integers' do
         let(:min) do
-          1331890719
+          1_331_890_719
         end
 
         let(:max) do
-          1332890719
+          1_332_890_719
         end
 
         let(:evolved) do
@@ -240,41 +226,39 @@ describe ActiveSupport::TimeWithZone do
           Time.at(max).utc
         end
 
-        it "returns a selection of times" do
+        it 'returns a selection of times' do
           expect(evolved).to eq(
-            { "$gte" => expected_min, "$lte" => expected_max }
+            { '$gte' => expected_min, '$lte' => expected_max }
           )
         end
 
-        it "returns the times in utc" do
-          expect(evolved["$gte"].utc_offset).to eq(0)
+        it 'returns the times in utc' do
+          expect(evolved['$gte'].utc_offset).to eq(0)
         end
       end
     end
 
-    context "when provided a string" do
-
+    context 'when provided a string' do
       let(:date) do
-        time_zone.parse("1st Jan 2010 12:00:00+01:00")
+        time_zone.parse('1st Jan 2010 12:00:00+01:00')
       end
 
       let(:evolved) do
         described_class.evolve(date.to_s)
       end
 
-      it "returns the string as a time" do
+      it 'returns the string as a time' do
         expect(evolved).to eq(date.to_time)
       end
 
-      it "returns the time in utc" do
+      it 'returns the time in utc' do
         expect(evolved.utc_offset).to eq(0)
       end
     end
 
-    context "when provided a float" do
-
+    context 'when provided a float' do
       let(:float) do
-        1331890719.8170738
+        1_331_890_719.8170738
       end
 
       let(:evolved) do
@@ -285,19 +269,18 @@ describe ActiveSupport::TimeWithZone do
         Time.at(float)
       end
 
-      it "returns the float as a time" do
+      it 'returns the float as a time' do
         expect(evolved).to eq(expected)
       end
 
-      it "returns the time in utc" do
+      it 'returns the time in utc' do
         expect(evolved.utc_offset).to eq(0)
       end
     end
 
-    context "when provided an integer" do
-
+    context 'when provided an integer' do
       let(:integer) do
-        1331890719
+        1_331_890_719
       end
 
       let(:evolved) do
@@ -308,36 +291,33 @@ describe ActiveSupport::TimeWithZone do
         Time.at(integer)
       end
 
-      it "returns the integer as a time" do
+      it 'returns the integer as a time' do
         expect(evolved).to eq(expected)
       end
 
-      it "returns the time in utc" do
+      it 'returns the time in utc' do
         expect(evolved.utc_offset).to eq(0)
       end
     end
 
-    context "when provided an invalid string" do
-
+    context 'when provided an invalid string' do
       let(:evolved) do
-        described_class.evolve("bogus")
+        described_class.evolve('bogus')
       end
 
-      it "returns that string" do
-        expect(evolved).to eq("bogus")
+      it 'returns that string' do
+        expect(evolved).to eq('bogus')
       end
     end
 
-    context "when provided nil" do
-
-      it "returns nil" do
+    context 'when provided nil' do
+      it 'returns nil' do
         expect(described_class.evolve(nil)).to be_nil
       end
     end
   end
 
-  describe "#__evolve_date__" do
-
+  describe '#__evolve_date__' do
     let(:evolved) do
       time.__evolve_date__
     end
@@ -347,7 +327,7 @@ describe ActiveSupport::TimeWithZone do
         time_zone.local(2010, 1, 1, 0, 0, 1).freeze
       end
 
-      it "returns midnight utc" do
+      it 'returns midnight utc' do
         expect(evolved).to eq(Time.utc(2010, 1, 1, 0, 0, 0))
       end
     end
@@ -357,14 +337,13 @@ describe ActiveSupport::TimeWithZone do
         time_zone.local(2010, 1, 1, 23, 59, 59).freeze
       end
 
-      it "returns midnight utc" do
+      it 'returns midnight utc' do
         expect(evolved).to eq(Time.utc(2010, 1, 1, 0, 0, 0))
       end
     end
   end
 
-  describe "#__evolve_time__" do
-
+  describe '#__evolve_time__' do
     let(:date) do
       time_zone.local(2010, 1, 1, 12, 0, 0).freeze
     end
@@ -377,11 +356,11 @@ describe ActiveSupport::TimeWithZone do
       Time.utc(2010, 1, 1, 17, 0, 0)
     end
 
-    it "returns the same time" do
+    it 'returns the same time' do
       expect(evolved).to eq(expected)
     end
 
-    it "returns the time in utc" do
+    it 'returns the time in utc' do
       expect(evolved.utc_offset).to eq(0)
     end
   end

data/spec/mongoid/criteria/queryable/key_spec.rb

@@ -1,67 +1,63 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
-require "spec_helper"
+require 'spec_helper'
 
 describe Mongoid::Criteria::Queryable::Key do
-
-  describe "#initialize" do
-
+  describe '#initialize' do
     let(:key) do
-      described_class.new("field", :__union__, "$all")
+      described_class.new('field', :__union__, '$all')
     end
 
-    it "sets the name" do
-      expect(key.name).to eq("field")
+    it 'sets the name' do
+      expect(key.name).to eq('field')
     end
 
-    it "sets the operator" do
-      expect(key.operator).to eq("$all")
+    it 'sets the operator' do
+      expect(key.operator).to eq('$all')
     end
 
-    it "sets the strategy" do
+    it 'sets the strategy' do
       expect(key.strategy).to eq(:__union__)
     end
   end
 
-  describe "#__expr_part__" do
-
+  describe '#__expr_part__' do
     context 'operator only' do
       let(:key) do
-        described_class.new("field", :__union__, "$all")
+        described_class.new('field', :__union__, '$all')
       end
 
       let(:specified) do
         key.__expr_part__([ 1, 2 ])
       end
 
-      it "returns the name plus operator and value" do
-        expect(specified).to eq({ "field" => { "$all" => [ 1, 2 ] }})
+      it 'returns the name plus operator and value' do
+        expect(specified).to eq({ 'field' => { '$all' => [ 1, 2 ] } })
       end
     end
 
     context 'operator and expanded only' do
       let(:key) do
-        described_class.new("field", :__override__, "$geoIntersects", '$geometry')
+        described_class.new('field', :__override__, '$geoIntersects', '$geometry')
       end
 
       let(:specified) do
         key.__expr_part__([ 1, 10 ])
       end
 
-      it "returns the query expression" do
-        expect(specified).to eq({ "field" => {
-          '$geoIntersects' => {
-            '$geometry' => [1, 10],
-          },
-        }})
+      it 'returns the query expression' do
+        expect(specified).to eq({ 'field' => {
+                                  '$geoIntersects' => {
+                                    '$geometry' => [ 1, 10 ]
+                                  }
+                                } })
       end
     end
 
     context 'operator, expanded and block' do
       let(:key) do
-        described_class.new("field", :__override__, "$geoIntersects", '$geometry') do |value|
-          { "type" => 'Point', "coordinates" => value }
+        described_class.new('field', :__override__, '$geoIntersects', '$geometry') do |value|
+          { 'type' => 'Point', 'coordinates' => value }
         end
       end
 
@@ -69,28 +65,28 @@ describe Mongoid::Criteria::Queryable::Key do
         key.__expr_part__([ 1, 10 ])
       end
 
-      it "returns the query expression" do
-        expect(specified).to eq({ "field" => {
-          '$geoIntersects' => {
-            '$geometry' => {
-              'type' => 'Point', 'coordinates' => [1, 10],
-            },
-          },
-        }})
+      it 'returns the query expression' do
+        expect(specified).to eq({ 'field' => {
+                                  '$geoIntersects' => {
+                                    '$geometry' => {
+                                      'type' => 'Point', 'coordinates' => [ 1, 10 ]
+                                    }
+                                  }
+                                } })
       end
     end
   end
 
   describe '#hash' do
     let(:key) do
-      described_class.new("field", :__union__, "$all")
+      described_class.new('field', :__union__, '$all')
     end
 
     let(:other) do
-      described_class.new("field", :__union__, "$all")
+      described_class.new('field', :__union__, '$all')
     end
 
-    it "returns the same hash for keys with the same attributes" do
+    it 'returns the same hash for keys with the same attributes' do
       expect(key.hash).to eq(other.hash)
     end
   end