mongoid 9.0.11 → 9.1.0

data/spec/mongoid/persistence_context_spec.rb

@@ -1,10 +1,8 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
-require "spec_helper"
+require 'spec_helper'
 
 describe Mongoid::PersistenceContext do
-
   let(:persistence_context) do
     described_class.new(object, options)
   end
@@ -14,40 +12,36 @@ describe Mongoid::PersistenceContext do
   end
 
   describe '.set' do
-
     let(:options) do
       { collection: :other }
     end
 
     context 'when the persistence context is set on the thread' do
-
       let!(:persistence_context) do
         described_class.set(object, options)
       end
 
       it 'sets the persistence context for the object on the current thread' do
         expect(described_class.get(object)).to be(persistence_context)
-        expect(described_class.get(object)).not_to be(nil)
+        expect(described_class.get(object)).not_to be_nil
         expect(described_class.get(object).collection.name).to eq('other')
       end
 
       it 'only sets persistence context for the object on the current thread' do
-         Thread.new do
+        Thread.new do
           expect(described_class.get(object)).not_to be(persistence_context)
-          expect(described_class.get(object)).to be(nil)
+          expect(described_class.get(object)).to be_nil
         end.value
       end
     end
   end
 
   describe '.get' do
-
     let(:options) do
       { collection: :other }
     end
 
     context 'when there has been a persistence context set on the current thread' do
-
       let!(:persistence_context) do
         described_class.set(object, options)
       end
@@ -60,20 +54,18 @@ describe Mongoid::PersistenceContext do
       it 'does not get persistence context for the object from another thread' do
         Thread.new do
           expect(described_class.get(object)).not_to be(persistence_context)
-          expect(described_class.get(object)).to be(nil)
+          expect(described_class.get(object)).to be_nil
         end.value
       end
     end
   end
 
   describe '.clear' do
-
     let(:options) do
       { collection: :other }
     end
 
     context 'when the method throws an error' do
-
       let!(:persistence_context) do
         described_class.set(object, options).tap do |cxt|
           allow(cxt).to receive(:client).and_raise(Mongoid::Errors::NoClientConfig.new('default'))
@@ -81,32 +73,28 @@ describe Mongoid::PersistenceContext do
       end
 
       it 'clears the context anyway' do
-        begin; described_class.clear(object); rescue; end
-        expect(described_class.get(object)).to be(nil)
+        begin; described_class.clear(object); rescue StandardError; end
+        expect(described_class.get(object)).to be_nil
       end
     end
 
     context 'when there has been a persistence context set on the current thread' do
-
       let!(:persistence_context) do
         described_class.set(object, options)
       end
 
       context 'when no cluster is passed to the method' do
-
         before do
           described_class.clear(object)
         end
 
         it 'clears the persistence context for the object on the current thread' do
-          expect(described_class.get(object)).to be(nil)
+          expect(described_class.get(object)).to be_nil
         end
       end
 
       context 'when a cluster is passed to the method' do
-
         context 'when the cluster is the same as that of the persistence context on the current thread' do
-
           let(:client) do
             persistence_context.client
           end
@@ -122,7 +110,6 @@ describe Mongoid::PersistenceContext do
         end
 
         context 'when the cluster is not the same as that of the persistence context on the current thread' do
-
           let!(:client) do
             persistence_context.client
           end
@@ -137,7 +124,7 @@ describe Mongoid::PersistenceContext do
 
     context 'with reusable client' do
       let(:options) do
-        {client: :some_client}
+        { client: :some_client }
       end
 
       let(:cluster) do
@@ -163,22 +150,18 @@ describe Mongoid::PersistenceContext do
   end
 
   describe '#initialize' do
-
     let(:options) do
       { collection: 'other' }
     end
 
     context 'when an object is passed' do
-
       context 'when the object is a klass' do
-
         it 'sets the object on the persistence context' do
           expect(persistence_context.instance_variable_get(:@object)).to eq(object)
         end
       end
 
       context 'when the object is a model instance' do
-
         let(:object) do
           Band.new
         end
@@ -190,24 +173,19 @@ describe Mongoid::PersistenceContext do
     end
 
     context 'when options are passed' do
-
       let(:options) do
         { connect_timeout: 3 }
       end
 
       context 'when the options are valid client options' do
-
         it 'sets the options on the persistence context object' do
           expect(persistence_context.options).to eq(options)
         end
       end
 
       context 'when the options are not valid client options' do
-
         context 'when the options are valid extra options' do
-
           context 'collection' do
-
             let(:options) do
               { collection: 'other' }
             end
@@ -229,15 +207,14 @@ describe Mongoid::PersistenceContext do
         end
 
         context 'when the options are not valid extra options' do
-
           let(:options) do
             { invalid: 'option' }
           end
 
           it 'raises an InvalidPersistenceOption error' do
-            expect {
+            expect do
               persistence_context
-            }.to raise_error(Mongoid::Errors::InvalidPersistenceOption)
+            end.to raise_error(Mongoid::Errors::InvalidPersistenceOption)
           end
         end
       end
@@ -245,7 +222,6 @@ describe Mongoid::PersistenceContext do
   end
 
   describe '#collection' do
-
     let(:persistence_context) do
       described_class.new(object, options)
     end
@@ -255,7 +231,6 @@ describe Mongoid::PersistenceContext do
     end
 
     context 'when a parent object is passed' do
-
       it 'uses the collection of the parent object' do
         expect(persistence_context.collection(Person.new).name).to eq('people')
       end
@@ -270,9 +245,8 @@ describe Mongoid::PersistenceContext do
       end
 
       context 'when the parent object has a client set' do
-
         let(:file) do
-          File.join(File.dirname(__FILE__), "..", "config", "mongoid.yml")
+          File.join(File.dirname(__FILE__), '..', 'config', 'mongoid.yml')
         end
 
         before do
@@ -292,7 +266,6 @@ describe Mongoid::PersistenceContext do
     end
 
     context 'when a parent object is not passed' do
-
       it 'uses the collection of the object' do
         expect(persistence_context.collection.name).to eq('bands')
       end
@@ -309,7 +282,6 @@ describe Mongoid::PersistenceContext do
   end
 
   describe '#collection_name' do
-
     let(:persistence_context) do
       described_class.new(object, options)
     end
@@ -319,11 +291,9 @@ describe Mongoid::PersistenceContext do
     end
 
     context 'when storage options are set on the object' do
-
       context 'when there are no options passed to the Persistence Context' do
-
         let(:options) do
-          { }
+          {}
         end
 
         after do
@@ -331,7 +301,6 @@ describe Mongoid::PersistenceContext do
         end
 
         context 'when the storage options is static' do
-
           before do
             object.store_in collection: :schmands
           end
@@ -342,9 +311,8 @@ describe Mongoid::PersistenceContext do
         end
 
         context 'when the storage options is a block' do
-
           before do
-            object.store_in collection: ->{ :schmands }
+            object.store_in collection: -> { :schmands }
           end
 
           it 'uses the storage options' do
@@ -354,7 +322,6 @@ describe Mongoid::PersistenceContext do
       end
 
       context 'when there are options passed to the Persistence Context' do
-
         let(:options) do
           { collection: 'other' }
         end
@@ -364,7 +331,6 @@ describe Mongoid::PersistenceContext do
         end
 
         context 'when the storage options is static' do
-
           before do
             object.store_in collection: :schmands
           end
@@ -375,9 +341,8 @@ describe Mongoid::PersistenceContext do
         end
 
         context 'when the storage options is a block' do
-
           before do
-            object.store_in collection: ->{ :schmands }
+            object.store_in collection: -> { :schmands }
           end
 
           it 'uses the persistence context options' do
@@ -388,9 +353,7 @@ describe Mongoid::PersistenceContext do
     end
 
     context 'when storage options are not set on the object' do
-
       context 'when there are options passed to the Persistence Context' do
-
         let(:options) do
           { collection: 'other' }
         end
@@ -403,7 +366,6 @@ describe Mongoid::PersistenceContext do
   end
 
   describe '#database_name' do
-
     let(:persistence_context) do
       described_class.new(object, options)
     end
@@ -413,11 +375,9 @@ describe Mongoid::PersistenceContext do
     end
 
     context 'when storage options are set on the object' do
-
       context 'when there are no options passed to the Persistence Context' do
-
         let(:options) do
-          { }
+          {}
         end
 
         after do
@@ -437,7 +397,6 @@ describe Mongoid::PersistenceContext do
         end
 
         context 'when the storage options is static' do
-
           before do
             object.store_in database: :musique
           end
@@ -448,10 +407,10 @@ describe Mongoid::PersistenceContext do
         end
 
         context 'when the storage options is a block' do
-
           before do
-            object.store_in database: ->{ :musique }
+            object.store_in database: -> { :musique }
           end
+
           it 'uses the storage options' do
             expect(persistence_context.database_name).to eq(:musique)
           end
@@ -459,7 +418,6 @@ describe Mongoid::PersistenceContext do
       end
 
       context 'when there are options passed to the Persistence Context' do
-
         let(:options) do
           { database: 'musique' }
         end
@@ -473,7 +431,6 @@ describe Mongoid::PersistenceContext do
         end
 
         context 'when the storage options is static' do
-
           before do
             object.store_in database: :sounds
           end
@@ -488,9 +445,8 @@ describe Mongoid::PersistenceContext do
         end
 
         context 'when the storage options is a block' do
-
           before do
-            object.store_in database: ->{ :sounds }
+            object.store_in database: -> { :sounds }
           end
 
           after do
@@ -505,9 +461,7 @@ describe Mongoid::PersistenceContext do
     end
 
     context 'when storage options are not set on the object' do
-
       context 'when there are options passed to the Persistence Context' do
-
         let(:options) do
           { database: 'musique' }
         end
@@ -526,7 +480,6 @@ describe Mongoid::PersistenceContext do
       end
 
       context 'when there are no options passed to the Persistence Context' do
-
         context 'when there is a database override' do
           persistence_context_override :database, :other
 
@@ -538,7 +491,7 @@ describe Mongoid::PersistenceContext do
     end
 
     context 'when the database is specified as a proc' do
-      let(:options) { { database: ->{ 'other' } } }
+      let(:options) { { database: -> { 'other' } } }
 
       after { persistence_context.client.close }
 
@@ -553,13 +506,12 @@ describe Mongoid::PersistenceContext do
   end
 
   describe '#client' do
-
     let(:persistence_context) do
       described_class.new(object, options)
     end
 
     let(:options) do
-      { }
+      {}
     end
 
     before do
@@ -571,7 +523,6 @@ describe Mongoid::PersistenceContext do
     end
 
     context 'when the client is set in the options' do
-
       let(:options) do
         { client: :alternative }
       end
@@ -601,13 +552,11 @@ describe Mongoid::PersistenceContext do
       end
 
       context 'when there are storage options set' do
-
         after do
           object.reset_storage_options!
         end
 
         context 'when the storage options is static' do
-
           before do
             object.store_in client: :other
           end
@@ -618,9 +567,8 @@ describe Mongoid::PersistenceContext do
         end
 
         context 'when the storage options is a block' do
-
           before do
-            object.store_in client: ->{ :other }
+            object.store_in client: -> { :other }
           end
 
           it 'uses the persistence context options' do
@@ -634,7 +582,7 @@ describe Mongoid::PersistenceContext do
       let(:options) { {} }
 
       before do
-        Band.store_in client: ->{ :alternative }
+        Band.store_in client: -> { :alternative }
       end
 
       after do
@@ -648,9 +596,8 @@ describe Mongoid::PersistenceContext do
     end
 
     context 'when there is no client option set' do
-
       let(:options) do
-        { }
+        {}
       end
 
       context 'when there is a client override' do
@@ -662,13 +609,11 @@ describe Mongoid::PersistenceContext do
       end
 
       context 'when there are storage options set' do
-
         after do
           object.reset_storage_options!
         end
 
         context 'when the storage options is static' do
-
           before do
             object.store_in client: :alternative
           end
@@ -679,9 +624,8 @@ describe Mongoid::PersistenceContext do
         end
 
         context 'when the storage options is a block' do
-
           before do
-            object.store_in client: ->{ :alternative }
+            object.store_in client: -> { :alternative }
           end
 
           it 'uses the client storage option' do
@@ -700,7 +644,6 @@ describe Mongoid::PersistenceContext do
     end
 
     context 'when there are client options set' do
-
       let(:options) do
         { connect_timeout: 3 }
       end
@@ -711,7 +654,6 @@ describe Mongoid::PersistenceContext do
     end
 
     context 'when there is a database name set in the options' do
-
       let(:options) do
         { database: 'other' }
       end
@@ -722,7 +664,7 @@ describe Mongoid::PersistenceContext do
     end
   end
 
-  context "when using an alternate database to update a document" do
+  context 'when using an alternate database to update a document' do
     let(:user) do
       User.new(name: '1')
     end
@@ -734,14 +676,14 @@ describe Mongoid::PersistenceContext do
 
       expect do
         user.with(database: database_id_alt) do |u|
-          u.update(name:'2')
+          u.update(name: '2')
         end
-      end.to_not raise_error
+      end.not_to raise_error
     end
 
-    it "persists the update" do
-      User.with("database" => database_id_alt) do |klass|
-        expect(klass.find(user._id).name).to eq("2")
+    it 'persists the update' do
+      User.with('database' => database_id_alt) do |klass|
+        expect(klass.find(user._id).name).to eq('2')
       end
     end
   end