mongoid 9.0.11 → 9.1.0

data/spec/mongoid/fields/foreign_key_spec.rb

@@ -1,16 +1,13 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
-require "spec_helper"
+require 'spec_helper'
 
 describe Mongoid::Fields::ForeignKey do
-
-  describe "#add_atomic_changes" do
-
+  describe '#add_atomic_changes' do
     let(:field) do
       described_class.new(
         :vals,
-        association: Person.relations["preferences"],
+        association: Person.relations['preferences'],
         type: Array,
         default: [],
         identity: true
@@ -41,29 +38,27 @@ describe Mongoid::Fields::ForeignKey do
       person.preferences.concat([ preference_one, preference_three ])
     end
 
-    context "when adding and removing" do
-
+    context 'when adding and removing' do
       before do
         field.add_atomic_changes(
           person,
-          "preference_ids",
-          "preference_ids",
+          'preference_ids',
+          'preference_ids',
           mods,
           [ preference_three.id ],
           [ preference_two.id ]
         )
       end
 
-      it "adds the current to the modifications" do
-        expect(mods["preference_ids"]).to eq(
+      it 'adds the current to the modifications' do
+        expect(mods['preference_ids']).to eq(
           [ preference_one.id, preference_three.id ]
         )
       end
     end
   end
 
-  describe "#eval_default" do
-
+  describe '#eval_default' do
     let(:default) do
       [ BSON::ObjectId.new ]
     end
@@ -71,47 +66,44 @@ describe Mongoid::Fields::ForeignKey do
     let(:field) do
       described_class.new(
         :vals,
-        association: Person.relations["posts"],
+        association: Person.relations['posts'],
         type: Array,
         default: default,
         identity: true
       )
     end
 
-    it "dups the default value" do
-      expect(field.eval_default(Person.new)).to_not equal(default)
+    it 'dups the default value' do
+      expect(field.eval_default(Person.new)).not_to equal(default)
     end
 
-    it "returns the correct value" do
+    it 'returns the correct value' do
       expect(field.eval_default(Person.new)).to eq(default)
     end
   end
 
-  describe "#foreign_key?" do
-
+  describe '#foreign_key?' do
     let(:field) do
       described_class.new(
         :vals,
-        association: Person.relations["posts"],
+        association: Person.relations['posts'],
         type: Array,
         default: [],
         identity: true
       )
     end
 
-    it "returns true" do
+    it 'returns true' do
       expect(field).to be_foreign_key
     end
   end
 
-  describe "#evolve" do
-
+  describe '#evolve' do
     let(:association) do
       Person.reflect_on_association(:preferences)
     end
 
-    context "when provided a document" do
-
+    context 'when provided a document' do
       let(:field) do
         described_class.new(:person_id, type: Object, association: association)
       end
@@ -124,21 +116,18 @@ describe Mongoid::Fields::ForeignKey do
         field.evolve(game)
       end
 
-      it "returns the id for the document" do
+      it 'returns the id for the document' do
         expect(evolved).to eq(game.id)
       end
     end
 
-    context "when the type is an array" do
-
+    context 'when the type is an array' do
       let(:field) do
         described_class.new(:preference_ids, type: Array, default: [], association: association)
       end
 
-      context "when providing a single value" do
-
-        context "when the value is an id string" do
-
+      context 'when providing a single value' do
+        context 'when the value is an id string' do
           let(:id) do
             BSON::ObjectId.new
           end
@@ -147,40 +136,35 @@ describe Mongoid::Fields::ForeignKey do
             field.evolve(id.to_s)
           end
 
-          it "converts the value to an object id" do
+          it 'converts the value to an object id' do
             expect(evolved).to eq(id)
           end
         end
 
-        context "when the value is a normal string" do
-
+        context 'when the value is a normal string' do
           let(:evolved) do
-            field.evolve("testing")
+            field.evolve('testing')
           end
 
-          it "does not convert the value" do
-            expect(evolved).to eq("testing")
+          it 'does not convert the value' do
+            expect(evolved).to eq('testing')
           end
         end
 
-        context "when the value is an empty string" do
-
+        context 'when the value is an empty string' do
           let(:evolved) do
-            field.evolve("")
+            field.evolve('')
           end
 
-          it "does not convert the value" do
+          it 'does not convert the value' do
             expect(evolved).to be_empty
           end
         end
       end
 
-      context "when providing an array" do
-
-        context "when the values are id strings" do
-
-          context "when the relation stores ids as object ids" do
-
+      context 'when providing an array' do
+        context 'when the values are id strings' do
+          context 'when the relation stores ids as object ids' do
             let(:id_one) do
               BSON::ObjectId.new
             end
@@ -193,13 +177,12 @@ describe Mongoid::Fields::ForeignKey do
               field.evolve([ id_one.to_s, id_two.to_s ])
             end
 
-            it "converts the value to an object id" do
+            it 'converts the value to an object id' do
               expect(evolved).to eq([ id_one, id_two ])
             end
           end
 
-          context "when the relation stores ids as strings" do
-
+          context 'when the relation stores ids as strings' do
             let!(:association) do
               Agent.reflect_on_association(:accounts)
             end
@@ -220,49 +203,45 @@ describe Mongoid::Fields::ForeignKey do
               field.evolve([ id_one, id_two ])
             end
 
-            it "does not convert the values to object ids" do
+            it 'does not convert the values to object ids' do
               expect(evolved).to eq([ id_one, id_two ])
             end
           end
         end
 
-        context "when the values are normal strings" do
-
+        context 'when the values are normal strings' do
           let(:evolved) do
-            field.evolve([ "testing" ])
+            field.evolve([ 'testing' ])
           end
 
-          it "does not convert the value" do
-            expect(evolved).to eq([ "testing" ])
+          it 'does not convert the value' do
+            expect(evolved).to eq([ 'testing' ])
           end
         end
 
-        context "when the values are empty strings" do
-
+        context 'when the values are empty strings' do
           let(:evolved) do
-            field.evolve([ "" ])
+            field.evolve([ '' ])
           end
 
-          it "does not convert the value" do
-            expect(evolved).to eq([ "" ])
+          it 'does not convert the value' do
+            expect(evolved).to eq([ '' ])
           end
         end
 
-        context "when the values are nils" do
-
+        context 'when the values are nils' do
           let(:evolved) do
             field.evolve([ nil ])
           end
 
-          it "does not convert the value" do
+          it 'does not convert the value' do
             expect(evolved).to eq([ nil ])
           end
         end
       end
     end
 
-    context "when the type is an object" do
-
+    context 'when the type is an object' do
       let(:association) do
         Game.reflect_on_association(:person)
       end
@@ -271,12 +250,9 @@ describe Mongoid::Fields::ForeignKey do
         described_class.new(:person_id, type: Object, association: association)
       end
 
-      context "when providing a single value" do
-
-        context "when the relation stores object ids" do
-
-          context "when the value is an id string" do
-
+      context 'when providing a single value' do
+        context 'when the relation stores object ids' do
+          context 'when the value is an id string' do
             let(:id) do
               BSON::ObjectId.new
             end
@@ -285,36 +261,33 @@ describe Mongoid::Fields::ForeignKey do
               field.evolve(id.to_s)
             end
 
-            it "converts the value to an object id" do
+            it 'converts the value to an object id' do
               expect(evolved).to eq(id)
             end
           end
 
-          context "when the value is a normal string" do
-
+          context 'when the value is a normal string' do
             let(:evolved) do
-              field.evolve("testing")
+              field.evolve('testing')
             end
 
-            it "does not convert the value" do
-              expect(evolved).to eq("testing")
+            it 'does not convert the value' do
+              expect(evolved).to eq('testing')
             end
           end
 
-          context "when the value is an empty string" do
-
+          context 'when the value is an empty string' do
             let(:evolved) do
-              field.evolve("")
+              field.evolve('')
             end
 
-            it "does not convert the value" do
+            it 'does not convert the value' do
               expect(evolved).to be_empty
             end
           end
         end
 
-        context "when the relation stores string ids" do
-
+        context 'when the relation stores string ids' do
           let(:association) do
             Comment.reflect_on_association(:account)
           end
@@ -323,8 +296,7 @@ describe Mongoid::Fields::ForeignKey do
             described_class.new(:person_id, type: Object, association: association)
           end
 
-          context "when the value is an id string" do
-
+          context 'when the value is an id string' do
             let(:id) do
               BSON::ObjectId.new
             end
@@ -333,41 +305,36 @@ describe Mongoid::Fields::ForeignKey do
               field.evolve(id.to_s)
             end
 
-            it "does not convert the value to an object id" do
+            it 'does not convert the value to an object id' do
               expect(evolved).to eq(id.to_s)
             end
           end
 
-          context "when the value is a normal string" do
-
+          context 'when the value is a normal string' do
             let(:evolved) do
-              field.evolve("testing")
+              field.evolve('testing')
             end
 
-            it "does not convert the value" do
-              expect(evolved).to eq("testing")
+            it 'does not convert the value' do
+              expect(evolved).to eq('testing')
             end
           end
 
-          context "when the value is an empty string" do
-
+          context 'when the value is an empty string' do
             let(:evolved) do
-              field.evolve("")
+              field.evolve('')
             end
 
-            it "does not convert the value" do
+            it 'does not convert the value' do
               expect(evolved).to be_empty
             end
           end
         end
       end
 
-      context "when providing an array" do
-
-        context "when the values are id strings" do
-
-          context "when the relation stores ids as object ids" do
-
+      context 'when providing an array' do
+        context 'when the values are id strings' do
+          context 'when the relation stores ids as object ids' do
             let(:id_one) do
               BSON::ObjectId.new
             end
@@ -380,13 +347,12 @@ describe Mongoid::Fields::ForeignKey do
               field.evolve([ id_one.to_s, id_two.to_s ])
             end
 
-            it "converts the value to an object id" do
+            it 'converts the value to an object id' do
               expect(evolved).to eq([ id_one, id_two ])
             end
           end
 
-          context "when the relation stores ids as strings" do
-
+          context 'when the relation stores ids as strings' do
             let(:association) do
               Comment.reflect_on_association(:account)
             end
@@ -407,49 +373,45 @@ describe Mongoid::Fields::ForeignKey do
               field.evolve([ id_one, id_two ])
             end
 
-            it "does not convert the values to object ids" do
+            it 'does not convert the values to object ids' do
               expect(evolved).to eq([ id_one, id_two ])
             end
           end
         end
 
-        context "when the values are normal strings" do
-
+        context 'when the values are normal strings' do
           let(:evolved) do
-            field.evolve([ "testing" ])
+            field.evolve([ 'testing' ])
           end
 
-          it "does not convert the value" do
-            expect(evolved).to eq([ "testing" ])
+          it 'does not convert the value' do
+            expect(evolved).to eq([ 'testing' ])
           end
         end
 
-        context "when the values are empty strings" do
-
+        context 'when the values are empty strings' do
           let(:evolved) do
-            field.evolve([ "" ])
+            field.evolve([ '' ])
           end
 
-          it "does not convert the value" do
-            expect(evolved).to eq([ "" ])
+          it 'does not convert the value' do
+            expect(evolved).to eq([ '' ])
           end
         end
 
-        context "when the values are nils" do
-
+        context 'when the values are nils' do
           let(:evolved) do
             field.evolve([ nil ])
           end
 
-          it "does not convert the value" do
+          it 'does not convert the value' do
             expect(evolved).to eq([ nil ])
           end
         end
       end
     end
 
-    context "when the association is polymoprhic" do
-
+    context 'when the association is polymorphic' do
       let(:association) do
         Agent.reflect_on_association(:names)
       end
@@ -459,45 +421,44 @@ describe Mongoid::Fields::ForeignKey do
       end
 
       let(:value) do
-        BSON::ObjectId.new().to_s
+        BSON::ObjectId.new.to_s
       end
 
       let(:evolved) do
         field.evolve(value)
       end
 
-      it "does not change the foreign key" do
+      it 'does not change the foreign key' do
         expect(evolved).to eq(BSON::ObjectId.from_string(value))
       end
     end
   end
 
-  describe "#lazy?" do
-
-    context "when the key is resizable" do
-
+  describe '#lazy?' do
+    context 'when the key is resizable' do
       let(:field) do
         described_class.new(:test, type: Array, overwrite: true)
       end
 
-      it "returns true" do
+      it 'returns true' do
         expect(field).to be_lazy
       end
     end
 
-    context "when the key is not resizable" do
-
+    context 'when the key is not resizable' do
       let(:field) do
         described_class.new(:test, type: BSON::ObjectId, overwrite: true)
       end
 
-      it "returns false" do
-        expect(field).to_not be_lazy
+      it 'returns false' do
+        expect(field).not_to be_lazy
       end
     end
   end
 
   describe '#mongoize' do
+    subject(:mongoized) { field.mongoize(object) }
+
     let(:field) do
       described_class.new(
         :vals,
@@ -509,7 +470,6 @@ describe Mongoid::Fields::ForeignKey do
       )
     end
     let(:association) { Game.relations['person'] }
-    subject(:mongoized) { field.mongoize(object) }
 
     context 'type is Array' do
       let(:type) { Array }
@@ -518,12 +478,12 @@ describe Mongoid::Fields::ForeignKey do
         let(:object) { BSON::ObjectId.new }
 
         it 'returns the object id as an array' do
-          expect(mongoized).to eq([object])
+          expect(mongoized).to eq([ object ])
         end
       end
 
       context 'when the object is an Array of BSON::ObjectId' do
-        let(:object) { [BSON::ObjectId.new] }
+        let(:object) { [ BSON::ObjectId.new ] }
 
         it 'returns the object ids' do
           expect(mongoized).to eq(object)
@@ -534,7 +494,7 @@ describe Mongoid::Fields::ForeignKey do
         let(:object) { BSON::ObjectId.new.to_s }
 
         it 'returns the object id in an array' do
-          expect(mongoized).to eq([BSON::ObjectId.from_string(object)])
+          expect(mongoized).to eq([ BSON::ObjectId.from_string(object) ])
         end
       end
 
@@ -563,10 +523,10 @@ describe Mongoid::Fields::ForeignKey do
       end
 
       context 'when the object is Array of Strings which are legal object ids' do
-        let(:object) { [BSON::ObjectId.new.to_s] }
+        let(:object) { [ BSON::ObjectId.new.to_s ] }
 
         it 'returns the object id in an array' do
-          expect(mongoized).to eq([BSON::ObjectId.from_string(object.first)])
+          expect(mongoized).to eq([ BSON::ObjectId.from_string(object.first) ])
         end
       end
 
@@ -579,7 +539,7 @@ describe Mongoid::Fields::ForeignKey do
       end
 
       context 'when the object is Array of Strings which are blank' do
-        let(:object) { ['', ''] }
+        let(:object) { [ '', '' ] }
 
         it 'returns an empty Array' do
           expect(mongoized).to eq([])
@@ -587,7 +547,7 @@ describe Mongoid::Fields::ForeignKey do
       end
 
       context 'when the object is Array of nils' do
-        let(:object) { [nil, nil, nil] }
+        let(:object) { [ nil, nil, nil ] }
 
         it 'returns an empty Array' do
           expect(mongoized).to eq([])
@@ -624,7 +584,7 @@ describe Mongoid::Fields::ForeignKey do
             :_id,
             type: BSON::ObjectId,
             pre_processed: true,
-            default: ->{ BSON::ObjectId.new },
+            default: -> { BSON::ObjectId.new },
             overwrite: true
           )
         end
@@ -638,15 +598,15 @@ describe Mongoid::Fields::ForeignKey do
         end
 
         context 'when the object is a BSON::ObjectId' do
-          let(:object) { [BSON::ObjectId.new] }
+          let(:object) { [ BSON::ObjectId.new ] }
 
           it 'converts to String' do
-            expect(mongoized).to eq([object.first.to_s])
+            expect(mongoized).to eq([ object.first.to_s ])
           end
         end
 
         context 'when the object is an Integer' do
-          let(:object) { [1] }
+          let(:object) { [ 1 ] }
 
           it 'converts to String' do
             expect(mongoized).to eq(%w[1])
@@ -664,7 +624,7 @@ describe Mongoid::Fields::ForeignKey do
             :_id,
             type: BSON::ObjectId,
             pre_processed: true,
-            default: ->{ BSON::ObjectId.new },
+            default: -> { BSON::ObjectId.new },
             overwrite: true
           )
         end
@@ -673,15 +633,15 @@ describe Mongoid::Fields::ForeignKey do
           let(:object) { %w[1] }
 
           it 'converts to Integer' do
-            expect(mongoized).to eq([1])
+            expect(mongoized).to eq([ 1 ])
           end
         end
 
         context 'when the object is an Integer' do
-          let(:object) { [1] }
+          let(:object) { [ 1 ] }
 
           it 'returns Integer' do
-            expect(mongoized).to eq([1])
+            expect(mongoized).to eq([ 1 ])
           end
         end
       end
@@ -691,7 +651,7 @@ describe Mongoid::Fields::ForeignKey do
       let(:type) { Set }
 
       context 'when the object is an Array of BSON::ObjectId' do
-        let(:object) { [BSON::ObjectId.new] }
+        let(:object) { [ BSON::ObjectId.new ] }
 
         it 'returns the object ids' do
           expect(mongoized).to eq(object)
@@ -702,7 +662,7 @@ describe Mongoid::Fields::ForeignKey do
         let(:object) { Set[BSON::ObjectId.new] }
 
         it 'returns the object id in an array' do
-          expect(mongoized).to eq([object.first])
+          expect(mongoized).to eq([ object.first ])
         end
       end
     end
@@ -776,7 +736,7 @@ describe Mongoid::Fields::ForeignKey do
             :_id,
             type: BSON::ObjectId,
             pre_processed: true,
-            default: ->{ BSON::ObjectId.new },
+            default: -> { BSON::ObjectId.new },
             overwrite: true
           )
         end
@@ -816,7 +776,7 @@ describe Mongoid::Fields::ForeignKey do
             :_id,
             type: BSON::ObjectId,
             pre_processed: true,
-            default: ->{ BSON::ObjectId.new },
+            default: -> { BSON::ObjectId.new },
             overwrite: true
           )
         end
@@ -840,41 +800,36 @@ describe Mongoid::Fields::ForeignKey do
     end
   end
 
-  describe "#resizable" do
-
-    context "when the type is an array" do
-
+  describe '#resizable' do
+    context 'when the type is an array' do
       let(:field) do
         described_class.new(:vals, type: Array, default: [])
       end
 
-      it "returns true" do
+      it 'returns true' do
         expect(field).to be_resizable
       end
     end
 
-    context "when the type is an object" do
-
+    context 'when the type is an object' do
       let(:field) do
         described_class.new(:vals, type: Object, default: [])
       end
 
-      it "returns false" do
-        expect(field).to_not be_resizable
+      it 'returns false' do
+        expect(field).not_to be_resizable
       end
     end
   end
 
-  context "when the foreign key points is a many to many" do
-
-    context "when the related document stores non object ids" do
-
+  context 'when the foreign key points is a many to many' do
+    context 'when the related document stores non object ids' do
       let(:agent) do
         Agent.new(account_ids: [ true, false, 1, 2 ])
       end
 
-      it "casts the ids on the initial set" do
-        expect(agent.account_ids).to eq([ "true", "false", "1", "2" ])
+      it 'casts the ids on the initial set' do
+        expect(agent.account_ids).to eq(%w[true false 1 2])
       end
     end
   end