mongoid 9.0.11 → 9.1.0

data/spec/support/models/person.rb

@@ -1,9 +1,9 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 class Person
   include Mongoid::Document
   include Mongoid::Attributes::Dynamic
+
   attr_accessor :mode
 
   class_attribute :somebody_elses_important_class_options
@@ -13,7 +13,7 @@ class Person
   field :title
   field :terms, type: Mongoid::Boolean
   field :pets, type: Mongoid::Boolean, default: false
-  field :age, type: Integer, default: "100"
+  field :age, type: Integer, default: '100'
   field :dob, type: Date
   field :employer_id
   field :lunch_time, type: Time
@@ -21,8 +21,8 @@ class Person
   field :map, type: Hash
   field :map_with_default, type: Hash, default: {}
   field :score, type: Integer
-  field :blood_alcohol_content, type: Float, default: ->{ 0.0 }
-  field :last_drink_taken_at, type: Date, default: ->{ 1.day.ago.in_time_zone("Alaska") }
+  field :blood_alcohol_content, type: Float, default: -> { 0.0 }
+  field :last_drink_taken_at, type: Date, default: -> { 1.day.ago.in_time_zone('Alaska') }
   field :ssn
   field :owner_id, type: Integer
   field :security_code
@@ -52,13 +52,14 @@ class Person
   attr_reader :rescored
 
   embeds_many :favorites, order: :title.desc, inverse_of: :perp, validate: false
-  embeds_many :videos, order: [[ :title, :asc ]], validate: false
-  embeds_many :phone_numbers, class_name: "Phone", validate: false
+  embeds_many :videos, order: [ %i[title asc] ], validate: false
+  embeds_many :phone_numbers, class_name: 'Phone', validate: false
   embeds_many :phones, store_as: :mobile_phones, validate: false
   embeds_many :addresses, as: :addressable, validate: false do
     def extension
-      "Testing"
+      'Testing'
     end
+
     def find_by_street(street)
       where(street: street).first
     end
@@ -71,14 +72,15 @@ class Person
   embeds_many :messages, validate: false
 
   embeds_one :passport, autobuild: true, store_as: :pass, validate: false
-  embeds_one :purse, store_as: "Purse"
-  embeds_one :pet, class_name: "Animal", validate: false
+  embeds_one :purse, store_as: 'Purse'
+  embeds_one :pet, class_name: 'Animal', validate: false
   embeds_one :name, as: :namable, validate: false do
     def extension
-      "Testing"
+      'Testing'
     end
+
     def dawkins?
-      first_name == "Richard" && last_name == "Dawkins"
+      first_name == 'Richard' && last_name == 'Dawkins'
     end
   end
   embeds_one :quiz, validate: false
@@ -86,7 +88,7 @@ class Person
   # Must have dependent: :destroy
   has_one :game, dependent: :destroy, validate: false do
     def extension
-      "Testing"
+      'Testing'
     end
   end
 
@@ -95,7 +97,7 @@ class Person
     dependent: :delete_all,
     validate: false do
     def extension
-      "Testing"
+      'Testing'
     end
   end
   has_many :ordered_posts, order: :rating.desc, validate: false
@@ -119,7 +121,7 @@ class Person
     :administrated_events,
     class_name: 'Event',
     inverse_of: :administrators,
-    dependent:  :nullify,
+    dependent: :nullify,
     validate: false
 
   belongs_to :mother, class_name: 'Person'
@@ -135,9 +137,9 @@ class Person
   accepts_nested_attributes_for :quiz
   accepts_nested_attributes_for :services, allow_destroy: true
 
-  scope :minor, ->{ where(:age.lt => 18) }
-  scope :without_ssn, ->{ without(:ssn) }
-  scope :search, ->(query){ any_of({ title: query }) }
+  scope :minor, -> { where(:age.lt => 18) }
+  scope :without_ssn, -> { without(:ssn) }
+  scope :search, ->(query) { any_of({ title: query }) }
 
   def self.older_than(age:)
     where(:age.gt => age)
@@ -148,12 +150,12 @@ class Person
     self.score_without_rescoring = score
   end
 
-  alias_method :score_without_rescoring=, :score=
-  alias_method :score=, :score_with_rescoring=
+  alias score_without_rescoring= score=
+  alias score= score_with_rescoring=
 
   def update_addresses
     addresses.each do |address|
-      address.street = "Updated Address"
+      address.street = 'Updated Address'
     end
   end
 
@@ -171,18 +173,20 @@ class Person
 
   def overridden_setter=(value)
     @override_called = true
-    super(value)
+    super
   end
 
   class << self
     def accepted
       scoped.where(terms: true)
     end
+
     def knight
-      scoped.where(title: "Sir")
+      scoped.where(title: 'Sir')
     end
+
     def old
-      scoped.where(age: { "$gt" => 50 })
+      scoped.where(age: { '$gt' => 50 })
     end
   end
 
@@ -199,10 +203,10 @@ class Person
   end
 
   def preference_names=(names)
-    names.split(",").each do |name|
+    names.split(',').each do |name|
       preference = Preference.where(name: name).first
       if preference
-        self.preferences << preference
+        preferences << preference
       else
         preferences.build(name: name)
       end
@@ -210,7 +214,7 @@ class Person
   end
 
   def set_on_map_with_default=(value)
-    self.map_with_default["key"] = value
+    map_with_default['key'] = value
   end
 
   def set_personal_data(ssn:, age:)
@@ -226,8 +230,8 @@ class Person
   private
 
   def secret_name
-    "secret"
+    'secret'
   end
 end
 
-require "support/models/doctor"
+require 'support/models/doctor'

data/spec/support/models/pet.rb

@@ -1,8 +1,8 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 class Pet
   include Mongoid::Document
+
   field :name
   field :weight, type: Float, default: 0.0
   embeds_many :vet_visits

data/spec/support/models/pet_owner.rb

@@ -1,8 +1,8 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 class PetOwner
   include Mongoid::Document
+
   field :title
   embeds_one :pet, cascade_callbacks: true
   embeds_one :address, as: :addressable

data/spec/support/models/phone.rb

@@ -1,10 +1,9 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 class Phone
   include Mongoid::Document
 
-  field :_id, type: String, overwrite: true, default: ->{ number }
+  field :_id, type: String, overwrite: true, default: -> { number }
   field :number
   field :ext, as: :extension
   field :landline, type: Boolean

data/spec/support/models/piano.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 class Piano < Instrument
 end

data/spec/support/models/pizza.rb

@@ -1,8 +1,8 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 class Pizza
   include Mongoid::Document
+
   field :name, type: String
   has_one :topping, autosave: true
   validates_presence_of :topping

data/spec/support/models/player.rb

@@ -1,21 +1,21 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 class Player
   include Mongoid::Document
+
   field :active, type: Mongoid::Boolean
   field :frags, type: Integer
   field :deaths, type: Integer
   field :impressions, type: Integer, default: 0
   field :status
 
-  scope :active, ->{ where(active: true) } do
+  scope :active, -> { where(active: true) } do
     def extension
-      "extension"
+      'extension'
     end
   end
 
-  scope :inactive, ->{ where(active: false) }
+  scope :inactive, -> { where(active: false) }
   scope :frags_over, ->(count) { where(:frags.gt => count) }
   scope :deaths_under, ->(count) { where(:deaths.lt => count) }
   scope :deaths_over, ->(count) { where(:deaths.gt => count) }
@@ -34,7 +34,7 @@ class Player
 
   class << self
     def alive
-      where(status: "Alive")
+      where(status: 'Alive')
     end
   end
 end

data/spec/support/models/post.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 class Post
   include Mongoid::Document
@@ -8,14 +7,15 @@ class Post
   field :title, type: String
   field :content, type: String
   field :rating, type: Integer
-  field :person_title, type: String, default: ->{ person.title if ivar(:person) }
+  field :person_title, type: String, default: -> { person.title if ivar(:person) }
 
   attr_accessor :before_add_called, :after_add_called, :before_remove_called, :after_remove_called
 
   belongs_to :person, counter_cache: true
-  belongs_to :author, foreign_key: :author_id, class_name: "User"
+  belongs_to :author, foreign_key: :author_id, class_name: 'User'
   belongs_to :post_genre, foreign_key: :genre_id, counter_cache: true
-  has_and_belongs_to_many :tags, before_add: :before_add_tag, after_add: :after_add_tag, before_remove: :before_remove_tag, after_remove: :after_remove_tag
+  has_and_belongs_to_many :tags, before_add: :before_add_tag, after_add: :after_add_tag,
+                                 before_remove: :before_remove_tag, after_remove: :after_remove_tag
   has_many :videos, validate: false
   has_many :roles, validate: false
   has_many :alerts
@@ -23,31 +23,31 @@ class Post
   belongs_to :posteable, polymorphic: true
   accepts_nested_attributes_for :posteable, autosave: true
 
-  scope :recent, ->{ where(created_at: { "$lt" => Time.now, "$gt" => 30.days.ago }) }
-  scope :posting, ->{ where(:content.in => [ "Posting" ]) }
-  scope :open, ->{ where(title: "open") }
+  scope :recent, -> { where(created_at: { '$lt' => Time.now, '$gt' => 30.days.ago }) }
+  scope :posting, -> { where(:content.in => [ 'Posting' ]) }
+  scope :open, -> { where(title: 'open') }
 
   validates_format_of :title, without: /\$\$\$/
 
-  def before_add_tag(tag)
+  def before_add_tag(_tag)
     @before_add_called = true
   end
 
-  def after_add_tag(tag)
+  def after_add_tag(_tag)
     @after_add_called = true
   end
 
-  def before_remove_tag(tag)
+  def before_remove_tag(_tag)
     @before_remove_called = true
   end
 
-  def after_remove_tag(tag)
+  def after_remove_tag(_tag)
     @after_remove_called = true
   end
 
   class << self
     def old
-      where(created_at: { "$lt" => 30.days.ago })
+      where(created_at: { '$lt' => 30.days.ago })
     end
   end
 end

data/spec/support/models/post_genre.rb

@@ -1,8 +1,8 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 class PostGenre
   include Mongoid::Document
+
   field :posts_count, type: Integer, default: 0
 
   has_many :posts, inverse_of: :genre

data/spec/support/models/powerup.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 class Powerup
   include Mongoid::Document
@@ -14,7 +13,7 @@ class Powerup
 
   field :after_find_player
   field :after_initialize_player
-  field :after_default_player, default: ->{ self.player&._id }
+  field :after_default_player, default: -> { player&._id }
 
   after_find do |doc|
     doc.after_find_player = player&._id

data/spec/support/models/preference.rb

@@ -1,12 +1,12 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 class Preference
   include Mongoid::Document
+
   field :name, type: String
   field :value, type: String
   field :ranking, type: Integer
   has_and_belongs_to_many :people, validate: false
   validates_length_of :name, minimum: 2, allow_nil: true
-  scope :posting, ->{ where(:value.in => [ "Posting" ]) }
+  scope :posting, -> { where(:value.in => [ 'Posting' ]) }
 end

data/spec/support/models/princess.rb

@@ -1,8 +1,8 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 class Princess
   include Mongoid::Document
+
   field :primary_color
   field :name, type: String
   def color

data/spec/support/models/product.rb

@@ -1,10 +1,10 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 class Product
   include Mongoid::Document
+
   field :description, localize: true
-  field :name, localize: true, default: "no translation"
+  field :name, localize: true, default: 'no translation'
   field :price, type: Integer
   field :brand_name
   field :stores, type: Array
@@ -15,7 +15,7 @@ class Product
   alias_attribute :cost, :price
 
   validates :name, presence: true
-  validates :website, format: { with: URI.regexp, allow_blank: true }
+  validates :website, format: { with: URI::DEFAULT_PARSER.make_regexp, allow_blank: true }
 
   embeds_one :seo, as: :seo_tags, cascade_callbacks: true, autobuild: true
 

data/spec/support/models/profile.rb

@@ -1,8 +1,8 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 class Profile
   include Mongoid::Document
+
   field :name, type: String
 
   embeds_one :profile_image
@@ -12,6 +12,7 @@ end
 
 class ProfileImage
   include Mongoid::Document
+
   field :url, type: String
 
   embedded_in :profile

data/spec/support/models/pronunciation.rb

@@ -1,8 +1,8 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 class Pronunciation
   include Mongoid::Document
+
   field :sound, type: String
   embedded_in :word
 end

data/spec/support/models/pub.rb

@@ -1,9 +1,9 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 class Pub
   include Mongoid::Document
   include Mongoid::Attributes::Dynamic
+
   field :location, type: Array
-  index location: "2dsphere"
+  index location: '2dsphere'
 end

data/spec/support/models/publication/encyclopedia.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 module Publication
   class Encyclopedia

data/spec/support/models/publication/review.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 module Publication
   class Review

data/spec/support/models/publication.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 require 'support/models/publication/encyclopedia'
 require 'support/models/publication/review'

data/spec/support/models/purchase.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 class Purchase
   include Mongoid::Document
+
   embeds_many :line_items
 end

data/spec/support/models/purchased_item.rb

@@ -1,8 +1,8 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 class PurchasedItem
   include Mongoid::Document
+
   field :item_id, type: Mongoid::StringifiedSymbol
 
   validates_uniqueness_of :item_id

data/spec/support/models/question.rb

@@ -1,11 +1,11 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 class Question
   include Mongoid::Document
+
   field :content
   embedded_in :survey
   embeds_many :answers
 
-  accepts_nested_attributes_for :answers, reject_if: ->(a){ a[:content].blank? }, allow_destroy: true
+  accepts_nested_attributes_for :answers, reject_if: ->(a) { a[:content].blank? }, allow_destroy: true
 end

data/spec/support/models/quiz.rb

@@ -1,9 +1,9 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 class Quiz
   include Mongoid::Document
   include Mongoid::Timestamps::Created
+
   field :name, type: String
   field :topic, type: String
   embeds_many :pages

data/spec/support/models/rating.rb

@@ -1,8 +1,8 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 class Rating
   include Mongoid::Document
+
   field :value, type: Integer
   belongs_to :ratable, polymorphic: true
   has_many :comments

data/spec/support/models/record.rb

@@ -1,8 +1,8 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 class Record
   include Mongoid::Document
+
   field :name, type: String
   field :producers, type: Array
 
@@ -48,8 +48,7 @@ class Record
     band.name
   end
 
-  def dont_call_me_twice
-  end
+  def dont_call_me_twice; end
 
   validate { dont_call_me_twice }
 end

data/spec/support/models/registry.rb

@@ -1,8 +1,8 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 class Registry
   include Mongoid::Document
+
   field :data, type: BSON::Binary
   field :obj_id, type: BSON::ObjectId
 end

data/spec/support/models/role.rb

@@ -1,8 +1,8 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 class Role
   include Mongoid::Document
+
   field :name, type: String
   belongs_to :user
   belongs_to :post

data/spec/support/models/root_category.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 class RootCategory
   include Mongoid::Document
+
   embeds_many :categories
 end

data/spec/support/models/sandbox/app/models/app_models_message.rb

@@ -1,4 +1,3 @@
-# rubocop:todo all
 class AppModelsMessage
   include Mongoid::Document
 end

data/spec/support/models/sandbox/lib/models/lib_models_message.rb

@@ -1,4 +1,3 @@
-# rubocop:todo all
 class LibModelsMessage
   include Mongoid::Document
 end

data/spec/support/models/sandbox/sandbox_message.rb

@@ -1,4 +1,3 @@
-# rubocop:todo all
 class SandboxMessage
   include Mongoid::Document
 end

data/spec/support/models/sandbox/sandbox_user.rb

@@ -1,4 +1,3 @@
-# rubocop:todo all
 class SandboxUser
   include Mongoid::Document
 end

data/spec/support/models/sandbox/subdir/sandbox_comment.rb

@@ -1,4 +1,3 @@
-# rubocop:todo all
 class SandboxComment
   include Mongoid::Document
 end

data/spec/support/models/sandwich.rb

@@ -1,8 +1,8 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 class Sandwich
   include Mongoid::Document
+
   has_and_belongs_to_many :meats
 
   field :name, type: String

data/spec/support/models/scheduler.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 class Scheduler
   include Mongoid::Document

data/spec/support/models/school.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 class School
   include Mongoid::Document

data/spec/support/models/scribe.rb

@@ -1,8 +1,8 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 class Scribe
   include Mongoid::Document
+
   field :name, type: String
   embedded_in :owner
 end

data/spec/support/models/sealer.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 class Sealer
   include Mongoid::Document

data/spec/support/models/seat.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 class Seat
   include Mongoid::Document