mongoid 9.0.11 → 9.1.0

data/spec/mongoid/validatable_spec.rb

@@ -1,37 +1,32 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
-require "spec_helper"
+require 'spec_helper'
 
 describe Mongoid::Validatable do
-
   let(:account) do
-    Account.new(name: "Testing a really long name.")
+    Account.new(name: 'Testing a really long name.')
   end
 
-  describe "#read_attribute_for_validation" do
-
+  describe '#read_attribute_for_validation' do
     let(:person) do
-      Person.new(title: "Mr")
+      Person.new(title: 'Mr')
     end
 
     let!(:address) do
-      person.addresses.build(street: "Wienerstr")
+      person.addresses.build(street: 'Wienerstr')
     end
 
-    context "when reading a field" do
-
+    context 'when reading a field' do
       let(:value) do
         person.read_attribute_for_validation(:title)
       end
 
-      it "returns the value" do
-        expect(value).to eq("Mr")
+      it 'returns the value' do
+        expect(value).to eq('Mr')
       end
     end
 
-    context "when reading a relation" do
-
+    context 'when reading a relation' do
       let(:value) do
         person.read_attribute_for_validation(:addresses)
       end
@@ -44,13 +39,12 @@ describe Mongoid::Validatable do
         person.instance_variable_set(:@addresses, documents)
       end
 
-      it "returns the value" do
+      it 'returns the value' do
         expect(value).to eq([ address ])
       end
     end
 
-    context "when validating a non field" do
-
+    context 'when validating a non field' do
       let(:princess) do
         Princess.new
       end
@@ -59,90 +53,79 @@ describe Mongoid::Validatable do
         princess.read_attribute_for_validation(:color)
       end
 
-      it "does not error on the read" do
+      it 'does not error on the read' do
         expect(value).to be_empty
       end
     end
   end
 
-  describe "#valid?" do
-
-    context "when provided a context" do
-
-      it "uses the provided context" do
+  describe '#valid?' do
+    context 'when provided a context' do
+      it 'uses the provided context' do
         expect(account).to be_valid(:update)
       end
 
       context 'when multiple contexts are provided' do
-
         let(:princess) do
           Princess.new
         end
 
         let(:validation) do
-          princess.valid?([:create, :update])
+          princess.valid?(%i[create update])
         end
 
         it 'validates using each context' do
           expect(validation).to be(false)
-          expect(princess.errors.messages.keys).to eq([:color, :name])
+          expect(princess.errors.messages.keys).to eq(%i[color name])
         end
       end
     end
 
-    context "when not provided a context" do
-
-      context "when the document is new" do
-
-        it "defaults the context to :create" do
-          expect(account).to_not be_valid
+    context 'when not provided a context' do
+      context 'when the document is new' do
+        it 'defaults the context to :create' do
+          expect(account).not_to be_valid
         end
       end
 
-      context "when the document is persisted" do
-
+      context 'when the document is persisted' do
         before do
-          account.name = "Testing"
+          account.name = 'Testing'
           account.save!
-          account.name = "Testing a really long name."
+          account.name = 'Testing a really long name.'
         end
 
-        it "defaults the context to :update" do
+        it 'defaults the context to :update' do
           expect(account).to be_valid
         end
       end
     end
 
-    context "when the document is fresh from the database" do
-
+    context 'when the document is fresh from the database' do
       let!(:pizza) do
-        Pizza.new(name: "chicago")
+        Pizza.new(name: 'chicago')
+      end
+      let(:from_db) do
+        Pizza.first
       end
 
       before do
-        pizza.build_topping(name: "cheese")
+        pizza.build_topping(name: 'cheese')
         pizza.save!
       end
 
-      let(:from_db) do
-        Pizza.first
-      end
-
-      it "loads the required association from the db" do
+      it 'loads the required association from the db' do
         expect(from_db).to be_valid
       end
     end
 
-    context "when validating associated" do
-
-      context "when the child validates the parent" do
-
+    context 'when validating associated' do
+      context 'when the child validates the parent' do
         let(:movie) do
           Movie.new
         end
 
-        context "when the child is invalid" do
-
+        context 'when the child is invalid' do
           let(:rating) do
             Rating.new(value: 1000)
           end
@@ -151,30 +134,27 @@ describe Mongoid::Validatable do
             movie.ratings << rating
           end
 
-          context "when validating once" do
-
-            it "returns false" do
-              expect(movie).to_not be_valid
+          context 'when validating once' do
+            it 'returns false' do
+              expect(movie).not_to be_valid
             end
 
-            it "adds the errors to the document" do
+            it 'adds the errors to the document' do
               movie.valid?
-              expect(movie.errors[:ratings]).to eq([ "is invalid" ])
+              expect(movie.errors[:ratings]).to eq([ 'is invalid' ])
             end
           end
 
-          context "when validating multiple times" do
-
-            it "returns false every time" do
-              expect(movie).to_not be_valid
-              expect(movie).to_not be_valid
+          context 'when validating multiple times' do
+            it 'returns false every time' do
+              expect(movie).not_to be_valid
+              expect(movie).not_to be_valid
             end
           end
         end
       end
 
-      context "when the child does not validate the parent" do
-
+      context 'when the child does not validate the parent' do
         before(:all) do
           Person.validates_associated(:services)
         end
@@ -187,33 +167,30 @@ describe Mongoid::Validatable do
           Person.new
         end
 
-        context "when the child is invalid" do
-
+        context 'when the child is invalid' do
           let(:service) do
-            Service.new(sid: "invalid")
+            Service.new(sid: 'invalid')
           end
 
           before do
             person.services << service
           end
 
-          context "when validating once" do
-
-            it "returns false" do
-              expect(person).to_not be_valid
+          context 'when validating once' do
+            it 'returns false' do
+              expect(person).not_to be_valid
             end
 
-            it "adds the errors to the document" do
+            it 'adds the errors to the document' do
               person.valid?
-              expect(person.errors[:services]).to eq([ "is invalid" ])
+              expect(person.errors[:services]).to eq([ 'is invalid' ])
             end
           end
 
-          context "when validating multiple times" do
-
-            it "returns false every time" do
-              expect(person).to_not be_valid
-              expect(person).to_not be_valid
+          context 'when validating multiple times' do
+            it 'returns false every time' do
+              expect(person).not_to be_valid
+              expect(person).not_to be_valid
             end
           end
         end
@@ -221,34 +198,31 @@ describe Mongoid::Validatable do
     end
   end
 
-  describe ".validates_associated" do
-
+  describe '.validates_associated' do
     let(:klass) do
       Class.new do
         include Mongoid::Document
       end
     end
 
-    context "when adding via the traditional macro" do
-
+    context 'when adding via the traditional macro' do
       before do
         klass.validates_associated(:name)
       end
 
-      it "adds the validator" do
+      it 'adds the validator' do
         expect(klass.validators.first).to be_a(
           Mongoid::Validatable::AssociatedValidator
         )
       end
     end
 
-    context "when adding via the new syntax" do
-
+    context 'when adding via the new syntax' do
       before do
         klass.validates(:name, associated: true)
       end
 
-      it "adds the validator" do
+      it 'adds the validator' do
         expect(klass.validators.first).to be_a(
           Mongoid::Validatable::AssociatedValidator
         )
@@ -256,34 +230,31 @@ describe Mongoid::Validatable do
     end
   end
 
-  describe ".validates_uniqueness_of" do
-
+  describe '.validates_uniqueness_of' do
     let(:klass) do
       Class.new do
         include Mongoid::Document
       end
     end
 
-    context "when adding via the traditional macro" do
-
+    context 'when adding via the traditional macro' do
       before do
         klass.validates_uniqueness_of(:name)
       end
 
-      it "adds the validator" do
+      it 'adds the validator' do
         expect(klass.validators.first).to be_a(
           Mongoid::Validatable::UniquenessValidator
         )
       end
     end
 
-    context "when adding via the new syntax" do
-
+    context 'when adding via the new syntax' do
       before do
         klass.validates(:name, uniqueness: true)
       end
 
-      it "adds the validator" do
+      it 'adds the validator' do
         expect(klass.validators.first).to be_a(
           Mongoid::Validatable::UniquenessValidator
         )
@@ -291,34 +262,31 @@ describe Mongoid::Validatable do
     end
   end
 
-  describe ".validates_presence_of" do
-
+  describe '.validates_presence_of' do
     let(:klass) do
       Class.new do
         include Mongoid::Document
       end
     end
 
-    context "when adding via the traditional macro" do
-
+    context 'when adding via the traditional macro' do
       before do
         klass.validates_presence_of(:name)
       end
 
-      it "adds the validator" do
+      it 'adds the validator' do
         expect(klass.validators.first).to be_a(
           Mongoid::Validatable::PresenceValidator
         )
       end
     end
 
-    context "when adding via the new syntax" do
-
+    context 'when adding via the new syntax' do
       before do
         klass.validates(:name, presence: true)
       end
 
-      it "adds the validator" do
+      it 'adds the validator' do
         expect(klass.validators.first).to be_a(
           Mongoid::Validatable::PresenceValidator
         )

data/spec/mongoid/warnings_spec.rb

@@ -1,14 +1,10 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
-require "spec_helper"
+require 'spec_helper'
 
 describe Mongoid::Warnings do
-
-  describe ".warn_*" do
-
-    context "when calling a warn_* method" do
-
+  describe '.warn_*' do
+    context 'when calling a warn_* method' do
       let(:id) { :geo_haystack_deprecated }
       let(:message) do
         'The geoHaystack type is deprecated.'
@@ -21,12 +17,12 @@ describe Mongoid::Warnings do
         end
       end
 
-      it "logs the warning" do
+      it 'logs the warning' do
         expect_any_instance_of(Logger).to receive(:warn).once.with(message)
         Mongoid::Warnings.send("warn_#{id}")
       end
 
-      it "logs the warning only once" do
+      it 'logs the warning only once' do
         expect_any_instance_of(Logger).to receive(:warn).once.with(message)
         Mongoid::Warnings.send("warn_#{id}")
         Mongoid::Warnings.send("warn_#{id}")

data/spec/mongoid_spec.rb

@@ -1,72 +1,63 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
-require "spec_helper"
+require 'spec_helper'
 
 describe Mongoid do
-
-  describe ".configure" do
-
-    context "when no block supplied" do
-
-      it "returns the config singleton" do
+  describe '.configure' do
+    context 'when no block supplied' do
+      it 'returns the config singleton' do
         expect(Mongoid.configure).to eq(Mongoid::Config)
       end
     end
 
-    context "when a block is given" do
+    context 'when a block is given' do
       config_override :preload_models, false
 
-      context "with arity 0" do
-
+      context 'with arity 0' do
         before do
           Mongoid.configure do
             config.preload_models = true
           end
         end
 
-        it "sets the values on the config instance" do
+        it 'sets the values on the config instance' do
           expect(Mongoid.preload_models).to be true
         end
       end
 
-      context "with arity 1" do
-
+      context 'with arity 1' do
         before do
           Mongoid.configure do |config|
             config.preload_models = true
           end
         end
 
-        it "sets the values on the config instance" do
+        it 'sets the values on the config instance' do
           expect(Mongoid.preload_models).to be true
         end
       end
 
-      context "with arity 2" do
-
+      context 'with arity 2' do
         before do
           Mongoid.configure do |config, _other|
             config.preload_models = true
           end
         end
 
-        it "sets the values on the config instance" do
+        it 'sets the values on the config instance' do
           expect(Mongoid.preload_models).to be true
         end
       end
     end
   end
 
-  describe ".default_client" do
-
-    it "returns the default client" do
+  describe '.default_client' do
+    it 'returns the default client' do
       expect(Mongoid.default_client).to eq(Mongoid::Clients.default)
     end
   end
 
-  describe ".disconnect_clients" do
-
+  describe '.disconnect_clients' do
     let(:clients) do
       Mongoid::Clients.clients.values
     end
@@ -75,20 +66,17 @@ describe Mongoid do
       Band.all.entries
     end
 
-    it "disconnects from all active clients" do
-      clients.each do |client|
-        expect(client).to receive(:close).and_call_original
-      end
+    it 'disconnects from all active clients' do
+      expect(clients).to all(receive(:close).and_call_original)
       Mongoid.disconnect_clients
     end
 
-    it "returns true" do
+    it 'returns true' do
       expect(Mongoid.disconnect_clients).to eq(true)
     end
   end
 
-  describe ".reconnect_clients" do
-
+  describe '.reconnect_clients' do
     let(:clients) do
       Mongoid::Clients.clients.values
     end
@@ -97,28 +85,24 @@ describe Mongoid do
       Band.all.entries
     end
 
-    it "reconnects all active clients" do
-      clients.each do |client|
-        expect(client).to receive(:reconnect).and_call_original
-      end
+    it 'reconnects all active clients' do
+      expect(clients).to all(receive(:reconnect).and_call_original)
       Mongoid.reconnect_clients
     end
 
-    it "returns true" do
+    it 'returns true' do
       expect(Mongoid.reconnect_clients).to eq(true)
     end
   end
 
-  describe ".client" do
-
-    it "returns the named client" do
+  describe '.client' do
+    it 'returns the named client' do
       expect(Mongoid.client(:default)).to eq(Mongoid::Clients.default)
     end
   end
 
-  describe ".models" do
-
-    it "returns the list of known models" do
+  describe '.models' do
+    it 'returns the list of known models' do
       expect(Mongoid.models).to include(Band)
     end
   end