mongoid 9.0.11 → 9.1.0

data/spec/mongoid/association/polymorphic_spec.rb

@@ -1,113 +1,97 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
-require "spec_helper"
-
-describe "Polymorphic Associations" do
-
-  describe "#polymorph" do
+require 'spec_helper'
 
+describe 'Polymorphic Associations' do
+  describe '#polymorph' do
     let(:klass) do
       Class.new.tap { |c| c.send(:include, Mongoid::Document) }
     end
 
-    context "when the relation is polymorphic" do
-
-      context "when the relation stores a foreign key" do
-
+    context 'when the relation is polymorphic' do
+      context 'when the relation stores a foreign key' do
         let!(:association) do
           klass.belongs_to :ratable, polymorphic: true
         end
 
-        it "sets polymorphic to true" do
+        it 'sets polymorphic to true' do
           expect(klass).to be_polymorphic
         end
 
-        it "adds the foreign key type field" do
-          expect(klass.fields["ratable_type"]).to_not be_nil
+        it 'adds the foreign key type field' do
+          expect(klass.fields['ratable_type']).not_to be_nil
         end
       end
 
-      context "when the relation does not store a foreign key" do
-
+      context 'when the relation does not store a foreign key' do
         let!(:association) do
           klass.has_many :ratings, as: :ratable
         end
 
-        it "sets polymorphic to true" do
+        it 'sets polymorphic to true' do
           expect(klass).to be_polymorphic
         end
 
-        it "does not add the foreign key type field" do
-          expect(klass.fields["ratable_type"]).to be_nil
+        it 'does not add the foreign key type field' do
+          expect(klass.fields['ratable_type']).to be_nil
         end
 
-        it "does not add the foreign key inverse field field" do
-          expect(klass.fields["ratable_field"]).to be_nil
+        it 'does not add the foreign key inverse field field' do
+          expect(klass.fields['ratable_field']).to be_nil
         end
       end
     end
 
-    context "when the relation is not polymorphic" do
-
+    context 'when the relation is not polymorphic' do
       let!(:association) do
         klass.has_many :ratings
       end
 
-      it "sets polymorphic to false" do
-        expect(klass).to_not be_polymorphic
+      it 'sets polymorphic to false' do
+        expect(klass).not_to be_polymorphic
       end
 
-      it "does not add the foreign key type field" do
-        expect(klass.fields["ratable_type"]).to be_nil
+      it 'does not add the foreign key type field' do
+        expect(klass.fields['ratable_type']).to be_nil
       end
 
-      it "does not add the foreign key inverse field field" do
-        expect(klass.fields["ratable_field"]).to be_nil
+      it 'does not add the foreign key inverse field field' do
+        expect(klass.fields['ratable_field']).to be_nil
       end
     end
   end
 
-  describe ".polymorphic?" do
-
-    context "when the document is in a polymorphic relation" do
-
-      it "returns true" do
+  describe '.polymorphic?' do
+    context 'when the document is in a polymorphic relation' do
+      it 'returns true' do
         expect(Movie).to be_polymorphic
       end
     end
 
-    context "when the document is not in a polymorphic relation" do
-
-      it "returns false" do
-        expect(Survey).to_not be_polymorphic
+    context 'when the document is not in a polymorphic relation' do
+      it 'returns false' do
+        expect(Survey).not_to be_polymorphic
       end
     end
   end
 
-  describe "#polymorphic?" do
-
-    context "when the document is in a polymorphic relation" do
-
-      it "returns true" do
+  describe '#polymorphic?' do
+    context 'when the document is in a polymorphic relation' do
+      it 'returns true' do
         expect(Movie.new).to be_polymorphic
       end
     end
 
-    context "when the document is not in a polymorphic relation" do
-
-      it "returns false" do
-        expect(Survey.new).to_not be_polymorphic
+    context 'when the document is not in a polymorphic relation' do
+      it 'returns false' do
+        expect(Survey.new).not_to be_polymorphic
       end
     end
   end
 
   context 'when the relation is touchable' do
-
     context 'when the relation is embedded' do
-
       let(:define_classes) do
-
         class FirstOwner
           include Mongoid::Document
 
@@ -128,14 +112,12 @@ describe "Polymorphic Associations" do
       end
 
       it 'successfully defines the touch method' do
-       expect { define_classes }.not_to raise_error
+        expect { define_classes }.not_to raise_error
       end
     end
 
     context 'when the relation is not embedded' do
-
       let(:define_classes) do
-
         class FirstOwner
           include Mongoid::Document
 
@@ -156,7 +138,7 @@ describe "Polymorphic Associations" do
       end
 
       it 'successfully defines the touch method' do
-       expect { define_classes }.not_to raise_error
+        expect { define_classes }.not_to raise_error
       end
     end
   end

data/spec/mongoid/association/referenced/belongs_to/binding_spec.rb

@@ -1,10 +1,8 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
-require "spec_helper"
+require 'spec_helper'
 
 describe Mongoid::Association::Referenced::BelongsTo::Binding do
-
   let(:person) do
     Person.new
   end
@@ -18,45 +16,41 @@ describe Mongoid::Association::Referenced::BelongsTo::Binding do
   end
 
   let(:game_association) do
-    Game.relations["person"]
+    Game.relations['person']
   end
 
   let(:post_association) do
-    Post.relations["person"]
+    Post.relations['person']
   end
 
-  describe "#bind_one" do
-
-    context "when the child of an references one" do
-
+  describe '#bind_one' do
+    context 'when the child of an references one' do
       let(:binding) do
         described_class.new(game, person, game_association)
       end
 
-      context "when the document is bindable with default pk" do
-
+      context 'when the document is bindable with default pk' do
         before do
-          expect(person).to receive(:save).never
-          expect(game).to receive(:save).never
+          expect(person).not_to receive(:save)
+          expect(game).not_to receive(:save)
           binding.bind_one
         end
 
-        it "sets the inverse relation" do
+        it 'sets the inverse relation' do
           expect(person.game).to eq(game)
         end
 
-        it "sets the foreign key" do
+        it 'sets the foreign key' do
           expect(game.person_id).to eq(person.id)
         end
       end
 
-      context "when the document is bindable with username as pk" do
-
+      context 'when the document is bindable with username as pk' do
         before do
           Game.belongs_to :person, index: true, validate: true, primary_key: :username
 
-          expect(person).to receive(:save).never
-          expect(game).to receive(:save).never
+          expect(person).not_to receive(:save)
+          expect(game).not_to receive(:save)
           binding.bind_one
         end
 
@@ -64,147 +58,134 @@ describe Mongoid::Association::Referenced::BelongsTo::Binding do
           Game.belongs_to :person, index: true, validate: true
         end
 
-        it "sets the inverse relation" do
-          expect(person.game).to eq(game)
-        end
-
         let(:person) do
           Person.new(username: 'arthurnn')
         end
 
-        it "sets the fk with username field" do
+        it 'sets the inverse relation' do
+          expect(person.game).to eq(game)
+        end
+
+        it 'sets the fk with username field' do
           expect(game.person_id).to eq(person.username)
         end
       end
 
-      context "when the document is not bindable" do
-
+      context 'when the document is not bindable' do
         before do
           person.game = game
         end
 
-        it "does nothing" do
-          expect(game).to receive(:person=).with(person).never
+        it 'does nothing' do
+          expect(game).not_to receive(:person=).with(person)
           expect(game).to receive(:person=).with(nil).once
           binding.bind_one
         end
       end
     end
 
-    context "when the child of an references many" do
-
+    context 'when the child of an references many' do
       let(:binding) do
         described_class.new(post, person, post_association)
       end
 
-      context "when the document is bindable" do
-
+      context 'when the document is bindable' do
         before do
-          expect(person).to receive(:save).never
-          expect(post).to receive(:save).never
+          expect(person).not_to receive(:save)
+          expect(post).not_to receive(:save)
           binding.bind_one
         end
 
-        it "sets the inverse relation" do
+        it 'sets the inverse relation' do
           expect(person.posts).to include(post)
         end
 
-        it "sets the foreign key" do
+        it 'sets the foreign key' do
           expect(post.person_id).to eq(person.id)
         end
       end
 
-      context "when the document is not bindable" do
-
+      context 'when the document is not bindable' do
         before do
           person.posts = [ post ]
         end
 
-        it "does nothing" do
-          expect(post).to receive(:person=).never
+        it 'does nothing' do
+          expect(post).not_to receive(:person=)
           binding.bind_one
         end
       end
     end
   end
 
-  describe "#unbind_one" do
-
-    context "when the child of an references one" do
-
+  describe '#unbind_one' do
+    context 'when the child of an references one' do
       let(:binding) do
         described_class.new(game, person, game_association)
       end
 
-      context "when the document is unbindable" do
-
+      context 'when the document is unbindable' do
         before do
           binding.bind_one
-          expect(person).to receive(:delete).never
-          expect(game).to receive(:delete).never
+          expect(person).not_to receive(:delete)
+          expect(game).not_to receive(:delete)
           binding.unbind_one
         end
 
-        it "removes the inverse relation" do
+        it 'removes the inverse relation' do
           expect(person.game).to be_nil
         end
 
-        it "removed the foreign key" do
+        it 'removed the foreign key' do
           expect(game.person_id).to be_nil
         end
       end
 
-      context "when the document is not unbindable" do
-
-        it "does nothing" do
-          expect(game).to receive(:person=).never
+      context 'when the document is not unbindable' do
+        it 'does nothing' do
+          expect(game).not_to receive(:person=)
           binding.unbind_one
         end
       end
     end
 
-    context "when the child of an references many" do
-
+    context 'when the child of an references many' do
       let(:binding) do
         described_class.new(post, person, post_association)
       end
 
-      context "when the document is unbindable" do
-
+      context 'when the document is unbindable' do
         before do
           binding.bind_one
-          expect(person).to receive(:delete).never
-          expect(post).to receive(:delete).never
+          expect(person).not_to receive(:delete)
+          expect(post).not_to receive(:delete)
           binding.unbind_one
         end
 
-        it "removes the inverse relation" do
+        it 'removes the inverse relation' do
           expect(person.posts).to be_empty
         end
 
-        it "removes the foreign key" do
+        it 'removes the foreign key' do
           expect(post.person_id).to be_nil
         end
       end
 
-      context "when the document is not unbindable" do
-
-        it "does nothing" do
-          expect(post).to receive(:person=).never
+      context 'when the document is not unbindable' do
+        it 'does nothing' do
+          expect(post).not_to receive(:person=)
           binding.unbind_one
         end
       end
     end
   end
 
-  context "when binding frozen documents" do
-
+  context 'when binding frozen documents' do
     let(:person) do
       Person.new
     end
 
-    context "when the child is frozen" do
-
+    context 'when the child is frozen' do
       let(:game) do
         Game.new.freeze
       end
@@ -213,20 +194,18 @@ describe Mongoid::Association::Referenced::BelongsTo::Binding do
         game.person = person
       end
 
-      it "does not set the foreign key" do
+      it 'does not set the foreign key' do
         expect(game.person_id).to be_nil
       end
     end
   end
 
-  context "when unbinding frozen documents" do
-
+  context 'when unbinding frozen documents' do
     let(:person) do
       Person.new
     end
 
-    context "when the child is frozen" do
-
+    context 'when the child is frozen' do
       let(:game) do
         Game.new
       end
@@ -237,7 +216,7 @@ describe Mongoid::Association::Referenced::BelongsTo::Binding do
         game.person = nil
       end
 
-      it "does not unset the foreign key" do
+      it 'does not unset the foreign key' do
         expect(game.person_id).to eq(person.id)
       end
     end

data/spec/mongoid/association/referenced/belongs_to/buildable_spec.rb

@@ -1,16 +1,13 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
-require "spec_helper"
+require 'spec_helper'
 
 describe Mongoid::Association::Referenced::BelongsTo::Buildable do
-
   let(:base) do
     double
   end
 
-  describe "#build" do
-
+  describe '#build' do
     let(:document) do
       association.build(base, object)
     end
@@ -23,10 +20,8 @@ describe Mongoid::Association::Referenced::BelongsTo::Buildable do
       Mongoid::Association::Referenced::BelongsTo.new(Post, :person, options)
     end
 
-    context "when provided an id" do
-
-      context "when the object is an object id" do
-
+    context 'when provided an id' do
+      context 'when the object is an object id' do
         let!(:person) do
           Person.create!(_id: object, username: 'Bob')
         end
@@ -39,13 +34,12 @@ describe Mongoid::Association::Referenced::BelongsTo::Buildable do
           expect_any_instance_of(Mongoid::Criteria).to receive(:where).with(association.primary_key => object).and_call_original
         end
 
-        it "sets the document" do
+        it 'sets the document' do
           expect(document).to eq(person)
         end
       end
 
-      context "when scope is specified" do
-
+      context 'when scope is specified' do
         let!(:person) do
           Person.create(_id: object, username: 'Bob')
         end
@@ -60,27 +54,24 @@ describe Mongoid::Association::Referenced::BelongsTo::Buildable do
           }
         end
 
-        context "when document satisfies scope" do
-
-          it "sets the document" do
+        context 'when document satisfies scope' do
+          it 'sets the document' do
             expect(document).to eq(person)
           end
         end
 
-        context "when document does not satisfy scope" do
-
+        context 'when document does not satisfy scope' do
           let!(:person) do
             Person.create(_id: object, username: 'Bruce')
           end
 
-          it "returns nil" do
+          it 'returns nil' do
             expect(document).to eq(nil)
           end
         end
       end
 
       context 'when the id is nil' do
-
         let(:object) do
           nil
         end
@@ -94,8 +85,7 @@ describe Mongoid::Association::Referenced::BelongsTo::Buildable do
         end
       end
 
-      context "when the id does not correspond to a document in the database" do
-
+      context 'when the id does not correspond to a document in the database' do
         let!(:person) do
           Person.create!
         end
@@ -113,8 +103,7 @@ describe Mongoid::Association::Referenced::BelongsTo::Buildable do
         end
       end
 
-      context "when the object is an integer" do
-
+      context 'when the object is an integer' do
         let!(:person) do
           Person.create!(_id: object)
         end
@@ -127,14 +116,28 @@ describe Mongoid::Association::Referenced::BelongsTo::Buildable do
           expect_any_instance_of(Mongoid::Criteria).to receive(:where).with(association.primary_key => object).and_call_original
         end
 
-        it "sets the document" do
+        it 'sets the document' do
           expect(document).to eq(person)
         end
       end
     end
 
-    context "when provided a object" do
+    context 'when provided an array of hashes' do
+      let(:object) do
+        [
+          { '_id' => BSON::ObjectId.new, 'username' => 'user1' },
+          { '_id' => BSON::ObjectId.new, 'username' => 'user2' }
+        ]
+      end
 
+      it 'queries and returns the document' do
+        first_doc = document
+        expect(first_doc).to be_a(Person)
+        expect(first_doc.username).to eq('user1')
+      end
+    end
+
+    context 'when provided a object' do
       let!(:person) do
         Person.create!
       end
@@ -147,13 +150,12 @@ describe Mongoid::Association::Referenced::BelongsTo::Buildable do
         expect_any_instance_of(Mongoid::Criteria).not_to receive(:where)
       end
 
-      it "returns the object" do
+      it 'returns the object' do
         expect(document).to eq(object)
       end
     end
 
-    context "when the document is persisted" do
-
+    context 'when the document is persisted' do
       let!(:person) do
         Person.create!
       end
@@ -162,13 +164,12 @@ describe Mongoid::Association::Referenced::BelongsTo::Buildable do
         Game.new(person_id: person.id)
       end
 
-      it "returns the document" do
+      it 'returns the document' do
         expect(game.person).to eq(person)
       end
     end
 
     context 'setting an associated document to nil' do
-
       let(:person) do
         Person.create!
       end
@@ -193,7 +194,6 @@ describe Mongoid::Association::Referenced::BelongsTo::Buildable do
   end
 
   describe '#substitute' do
-
     let(:person) do
       Person.create!
     end
@@ -203,7 +203,6 @@ describe Mongoid::Association::Referenced::BelongsTo::Buildable do
     end
 
     context 'setting an associated document to nil' do
-
       before do
         game.person = nil
       end
@@ -218,7 +217,6 @@ describe Mongoid::Association::Referenced::BelongsTo::Buildable do
     end
 
     context 'setting an associated document to other doc' do
-
       let(:other_person) do
         Person.create!
       end
@@ -238,9 +236,7 @@ describe Mongoid::Association::Referenced::BelongsTo::Buildable do
   end
 
   context 'when the object is already associated with another object' do
-
-    context "when inverse is has_many" do
-
+    context 'when inverse is has_many' do
       let(:drug1) do
         Drug.create!
       end
@@ -261,18 +257,17 @@ describe Mongoid::Association::Referenced::BelongsTo::Buildable do
       it 'does not clear the object of its previous association' do
         expect(drug1.person).to eq(person)
         expect(drug2.person).to eq(person)
-        expect(person.drugs).to eq([drug1, drug2])
+        expect(person.drugs).to eq([ drug1, drug2 ])
       end
     end
 
-    context "when inverse is has_one" do
-
+    context 'when inverse is has_one' do
       let(:account1) do
-        Account.create!(name: "1")
+        Account.create!(name: '1')
       end
 
       let(:account2) do
-        Account.create!(name: "2")
+        Account.create!(name: '2')
       end
 
       let(:person) do