mongoid 9.0.11 → 9.1.0

data/spec/mongoid/extensions/hash_spec.rb

@@ -1,14 +1,10 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
-require "spec_helper"
+require 'spec_helper'
 
 describe Mongoid::Extensions::Hash do
-
-  describe "#__evolve_object_id__" do
-
-    context "when values have object id strings" do
-
+  describe '#__evolve_object_id__' do
+    context 'when values have object id strings' do
       let(:object_id) do
         BSON::ObjectId.new
       end
@@ -21,13 +17,12 @@ describe Mongoid::Extensions::Hash do
         hash.__evolve_object_id__
       end
 
-      it "converts each value in the hash" do
+      it 'converts each value in the hash' do
         expect(evolved[:field]).to eq(object_id)
       end
     end
 
-    context "when values have object ids" do
-
+    context 'when values have object ids' do
       let(:object_id) do
         BSON::ObjectId.new
       end
@@ -40,32 +35,30 @@ describe Mongoid::Extensions::Hash do
         hash.__evolve_object_id__
       end
 
-      it "converts each value in the hash" do
+      it 'converts each value in the hash' do
         expect(evolved[:field]).to eq(object_id)
       end
     end
 
-    context "when values have empty strings" do
-
+    context 'when values have empty strings' do
       let(:object_id) do
         BSON::ObjectId.new
       end
 
       let(:hash) do
-        { field: "" }
+        { field: '' }
       end
 
       let(:evolved) do
         hash.__evolve_object_id__
       end
 
-      it "retains the empty string values" do
+      it 'retains the empty string values' do
         expect(evolved[:field]).to be_empty
       end
     end
 
-    context "when values have nils" do
-
+    context 'when values have nils' do
       let(:object_id) do
         BSON::ObjectId.new
       end
@@ -78,16 +71,14 @@ describe Mongoid::Extensions::Hash do
         hash.__evolve_object_id__
       end
 
-      it "retains the nil values" do
+      it 'retains the nil values' do
         expect(evolved[:field]).to be_nil
       end
     end
   end
 
-  describe "#__mongoize_object_id__" do
-
-    context "when values have object id strings" do
-
+  describe '#__mongoize_object_id__' do
+    context 'when values have object id strings' do
       let(:object_id) do
         BSON::ObjectId.new
       end
@@ -100,13 +91,12 @@ describe Mongoid::Extensions::Hash do
         hash.__mongoize_object_id__
       end
 
-      it "converts each value in the hash" do
+      it 'converts each value in the hash' do
         expect(mongoized[:field]).to eq(object_id)
       end
     end
 
-    context "when values have object ids" do
-
+    context 'when values have object ids' do
       let(:object_id) do
         BSON::ObjectId.new
       end
@@ -119,32 +109,30 @@ describe Mongoid::Extensions::Hash do
         hash.__mongoize_object_id__
       end
 
-      it "converts each value in the hash" do
+      it 'converts each value in the hash' do
         expect(mongoized[:field]).to eq(object_id)
       end
     end
 
-    context "when values have empty strings" do
-
+    context 'when values have empty strings' do
       let(:object_id) do
         BSON::ObjectId.new
       end
 
       let(:hash) do
-        { field: "" }
+        { field: '' }
       end
 
       let(:mongoized) do
         hash.__mongoize_object_id__
       end
 
-      it "converts the empty strings to nil" do
+      it 'converts the empty strings to nil' do
         expect(mongoized[:field]).to be_nil
       end
     end
 
-    context "when values have nils" do
-
+    context 'when values have nils' do
       let(:object_id) do
         BSON::ObjectId.new
       end
@@ -157,47 +145,44 @@ describe Mongoid::Extensions::Hash do
         hash.__mongoize_object_id__
       end
 
-      it "retains the nil values" do
+      it 'retains the nil values' do
         expect(mongoized[:field]).to be_nil
       end
     end
   end
 
-  describe ".demongoize" do
-
+  describe '.demongoize' do
     let(:hash) do
       { field: 1 }
     end
 
-    it "returns the hash" do
+    it 'returns the hash' do
       expect(Hash.demongoize(hash)).to eq(hash)
     end
 
-    context "when object is nil" do
+    context 'when object is nil' do
       let(:demongoized) do
         Hash.demongoize(nil)
       end
 
-      it "returns nil" do
+      it 'returns nil' do
         expect(demongoized).to be_nil
       end
     end
 
-    context "when the object is uncastable" do
+    context 'when the object is uncastable' do
       let(:demongoized) do
         Hash.demongoize(1)
       end
 
-      it "returns the object" do
+      it 'returns the object' do
         expect(demongoized).to eq(1)
       end
     end
   end
 
-  describe ".mongoize" do
-
+  describe '.mongoize' do
     context "when object isn't nil" do
-
       let(:date) do
         Date.new(2012, 1, 1)
       end
@@ -210,56 +195,55 @@ describe Mongoid::Extensions::Hash do
         Hash.mongoize(hash)
       end
 
-      it "mongoizes each element in the hash" do
+      it 'mongoizes each element in the hash' do
         expect(mongoized[:date]).to be_a(Time)
       end
 
-      it "converts the elements properly" do
+      it 'converts the elements properly' do
         expect(mongoized[:date]).to eq(Time.utc(2012, 1, 1, 0, 0, 0))
       end
 
-      it "mongoizes to a BSON::Document" do
+      it 'mongoizes to a BSON::Document' do
         expect(mongoized).to be_a(BSON::Document)
       end
     end
 
-    context "when object is nil" do
+    context 'when object is nil' do
       let(:mongoized) do
         Hash.mongoize(nil)
       end
 
-      it "returns nil" do
+      it 'returns nil' do
         expect(mongoized).to be_nil
       end
     end
 
-    context "when the object is uncastable" do
+    context 'when the object is uncastable' do
       let(:mongoized) do
         Hash.mongoize(1)
       end
 
-      it "returns nil" do
+      it 'returns nil' do
         expect(mongoized).to be_nil
       end
     end
 
-    describe "when mongoizing a BSON::Document" do
+    describe 'when mongoizing a BSON::Document' do
       let(:mongoized) do
         Hash.mongoize(BSON::Document.new({ x: 1, y: 2 }))
       end
 
-      it "returns the same hash" do
-        expect(mongoized).to eq({ "x" => 1, "y" => 2 })
+      it 'returns the same hash' do
+        expect(mongoized).to eq({ 'x' => 1, 'y' => 2 })
       end
 
-      it "returns a BSON::Document" do
+      it 'returns a BSON::Document' do
         expect(mongoized).to be_a(BSON::Document)
       end
     end
   end
 
-  describe "#mongoize" do
-
+  describe '#mongoize' do
     let(:date) do
       Date.new(2012, 1, 1)
     end
@@ -272,25 +256,23 @@ describe Mongoid::Extensions::Hash do
       hash.mongoize
     end
 
-    it "mongoizes each element in the hash" do
+    it 'mongoizes each element in the hash' do
       expect(mongoized[:date]).to be_a(Time)
     end
 
-    it "converts the elements properly" do
+    it 'converts the elements properly' do
       expect(mongoized[:date]).to eq(Time.utc(2012, 1, 1, 0, 0, 0))
     end
   end
 
-  describe "#resizable?" do
-
-    it "returns true" do
+  describe '#resizable?' do
+    it 'returns true' do
       expect({}).to be_resizable
     end
   end
 
-  describe ".resizable?" do
-
-    it "returns true" do
+  describe '.resizable?' do
+    it 'returns true' do
       expect(Hash).to be_resizable
     end
   end

data/spec/mongoid/extensions/integer_spec.rb

@@ -1,18 +1,15 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
-require "spec_helper"
+require 'spec_helper'
 
 describe Mongoid::Extensions::Integer do
-
   let(:number) do
-    118347652312341
+    118_347_652_312_341
   end
 
-  describe "#__mongoize_time__" do
-
+  describe '#__mongoize_time__' do
     let(:integer) do
-      1335532685
+      1_335_532_685
     end
 
     let(:mongoized) do
@@ -21,98 +18,82 @@ describe Mongoid::Extensions::Integer do
 
     let(:expected_time) { Time.at(integer).in_time_zone }
 
-    context "when setting ActiveSupport time zone" do
+    context 'when setting ActiveSupport time zone' do
       include_context 'setting ActiveSupport time zone'
 
       it_behaves_like 'mongoizes to AS::TimeWithZone'
     end
   end
 
-  [ :mongoize, :demongoize ].each do |method|
-
+  %i[mongoize demongoize].each do |method|
     describe ".#{method}" do
-
-      context "when the value is a number" do
-
-        context "when the value is an integer" do
-
-          context "when the value is small" do
-
-            it "it returns the integer" do
+      context 'when the value is a number' do
+        context 'when the value is an integer' do
+          context 'when the value is small' do
+            it 'returns the integer' do
               expect(Integer.send(method, 3)).to eq(3)
             end
           end
 
-          context "when the value is large" do
-
-            it "returns the integer" do
-              expect(Integer.send(method, 1024**2).to_s).to eq("1048576")
+          context 'when the value is large' do
+            it 'returns the integer' do
+              expect(Integer.send(method, 1024**2).to_s).to eq('1048576')
             end
           end
         end
 
-        context "when the value is a decimal" do
-
-          it "casts to integer" do
+        context 'when the value is a decimal' do
+          it 'casts to integer' do
             expect(Integer.send(method, 2.5)).to eq(2)
           end
         end
 
-        context "when the value is floating point zero" do
-
-          it "returns the integer zero" do
+        context 'when the value is floating point zero' do
+          it 'returns the integer zero' do
             expect(Integer.send(method, 0.00000)).to eq(0)
           end
         end
 
-        context "when the value is a floating point integer" do
-
-          it "returns the integer number" do
+        context 'when the value is a floating point integer' do
+          it 'returns the integer number' do
             expect(Integer.send(method, 4.00000)).to eq(4)
           end
         end
 
-        context "when the value has leading zeros" do
-
-          it "returns the stripped integer" do
-            expect(Integer.send(method, "000011")).to eq(11)
+        context 'when the value has leading zeros' do
+          it 'returns the stripped integer' do
+            expect(Integer.send(method, '000011')).to eq(11)
           end
         end
       end
 
-      context "when the string is not a number" do
-
-        context "when the string is non numerical" do
-
-          it "returns nil" do
-            expect(Integer.send(method, "foo")).to be_nil
+      context 'when the string is not a number' do
+        context 'when the string is non numerical' do
+          it 'returns nil' do
+            expect(Integer.send(method, 'foo')).to be_nil
           end
         end
 
-        context "when the string starts with a number" do
-
-          it "returns nil" do
-            expect(Integer.send(method, "42bogus")).to be_nil
+        context 'when the string starts with a number' do
+          it 'returns nil' do
+            expect(Integer.send(method, '42bogus')).to be_nil
           end
         end
 
-        context "when the string is empty" do
-
-          it "returns nil" do
-            expect(Integer.send(method, "")).to be_nil
+        context 'when the string is empty' do
+          it 'returns nil' do
+            expect(Integer.send(method, '')).to be_nil
           end
         end
 
-        context "when the string is nil" do
-
-          it "returns nil" do
+        context 'when the string is nil' do
+          it 'returns nil' do
             expect(Integer.send(method, nil)).to be_nil
           end
         end
 
-        context "when giving an object that is castable to an Integer" do
-
-          it "returns the integer value" do
+        context 'when giving an object that is castable to an Integer' do
+          it 'returns the integer value' do
             expect(Integer.send(method, 2.hours)).to eq(7200)
           end
         end
@@ -120,16 +101,14 @@ describe Mongoid::Extensions::Integer do
     end
   end
 
-  describe "#mongoize" do
-
-    it "returns self" do
+  describe '#mongoize' do
+    it 'returns self' do
       expect(number.mongoize).to eq(number)
     end
   end
 
-  describe "#numeric?" do
-
-    it "returns true" do
+  describe '#numeric?' do
+    it 'returns true' do
       expect(number.numeric?).to eq(true)
     end
   end

data/spec/mongoid/extensions/module_spec.rb

@@ -1,44 +1,39 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
-require "spec_helper"
+require 'spec_helper'
 
 describe Mongoid::Extensions::Module do
-
-  describe "#re_define_method" do
-
-    context "when the method already exists" do
-
+  describe '#re_define_method' do
+    context 'when the method already exists' do
       class Smoochy
         def sing
-          "singing"
+          'singing'
         end
       end
 
       before do
-        Smoochy.re_define_method("sing") do
-          "singing again"
+        Smoochy.re_define_method('sing') do
+          'singing again'
         end
       end
 
-      it "redefines the existing method" do
-        expect(Smoochy.new.sing).to eq("singing again")
+      it 'redefines the existing method' do
+        expect(Smoochy.new.sing).to eq('singing again')
       end
     end
 
-    context "when the method does not exist" do
-
+    context 'when the method does not exist' do
       class Rhino
       end
 
       before do
-        Rhino.re_define_method("sing") do
-          "singing"
+        Rhino.re_define_method('sing') do
+          'singing'
         end
       end
 
-      it "redefines the existing method" do
-        expect(Rhino.new.sing).to eq("singing")
+      it 'redefines the existing method' do
+        expect(Rhino.new.sing).to eq('singing')
       end
     end
   end

data/spec/mongoid/extensions/nil_class_spec.rb

@@ -1,12 +1,9 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
-require "spec_helper"
+require 'spec_helper'
 
 describe Mongoid::Extensions::NilClass do
-
-  describe "#collectionize" do
-
+  describe '#collectionize' do
     it "returns ''" do
       expect(nil.collectionize).to be_empty
     end