mongoid 9.0.11 → 9.1.0

data/spec/integration/callbacks_spec.rb

@@ -1,12 +1,10 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 require 'spec_helper'
-require_relative './callbacks_models'
+require_relative 'callbacks_models'
 
 describe 'callbacks integration tests' do
   context 'when modifying attributes in a callback' do
-
     context 'when creating top-level document' do
       context 'top level document' do
         let(:instance) do
@@ -14,28 +12,28 @@ describe 'callbacks integration tests' do
         end
 
         it 'writes the attribute value into the model' do
-          instance.age.should == 100_000
+          instance.age.should eq 100_000
         end
 
         it 'persists the attribute value' do
-          Galaxy.find(instance.id).age.should == 100_000
+          Galaxy.find(instance.id).age.should eq 100_000
         end
       end
 
       context 'embedded document' do
         shared_examples 'persists the attribute value' do
           it 'writes the attribute value into the model' do
-            instance.stars.first.age.should == 42_000
+            instance.stars.first.age.should eq 42_000
           end
 
           it 'persists the attribute value' do
-            Galaxy.find(instance.id).stars.first.age.should == 42_000
+            Galaxy.find(instance.id).stars.first.age.should eq 42_000
           end
         end
 
         context 'set as a document instance' do
           let(:instance) do
-            Galaxy.create!(stars: [Star.new])
+            Galaxy.create!(stars: [ Star.new ])
           end
 
           include_examples 'persists the attribute value'
@@ -43,7 +41,7 @@ describe 'callbacks integration tests' do
 
         context 'set as attributes on parent' do
           let(:instance) do
-            Galaxy.create!(stars: [{}])
+            Galaxy.create!(stars: [ {} ])
           end
 
           include_examples 'persists the attribute value'
@@ -53,19 +51,19 @@ describe 'callbacks integration tests' do
       context 'nested embedded document' do
         shared_examples 'persists the attribute value' do
           it 'writes the attribute value into the model' do
-            instance.stars.first.planets.first.age.should == 2_000
+            instance.stars.first.planets.first.age.should eq 2_000
           end
 
           it 'persists the attribute value' do
-            Galaxy.find(instance.id).stars.first.planets.first.age.should == 2_000
+            Galaxy.find(instance.id).stars.first.planets.first.age.should eq 2_000
           end
         end
 
         context 'set as a document instance' do
           let(:instance) do
-            Galaxy.create!(stars: [Star.new(
-              planets: [Planet.new],
-            )])
+            Galaxy.create!(stars: [ Star.new(
+              planets: [ Planet.new ]
+            ) ])
           end
 
           include_examples 'persists the attribute value'
@@ -74,8 +72,8 @@ describe 'callbacks integration tests' do
         context 'set as attributes on parent' do
           let(:instance) do
             Galaxy.create!(stars: [
-              planets: [{}],
-            ])
+                             { planets: [ {} ] }
+                           ])
           end
 
           include_examples 'persists the attribute value'
@@ -91,17 +89,17 @@ describe 'callbacks integration tests' do
       context 'embedded document' do
         shared_examples 'persists the attribute value' do
           it 'writes the attribute value into the model' do
-            instance.stars.first.age.should == 42_000
+            instance.stars.first.age.should eq 42_000
           end
 
           it 'persists the attribute value' do
-            Galaxy.find(instance.id).stars.first.age.should == 42_000
+            Galaxy.find(instance.id).stars.first.age.should eq 42_000
           end
         end
 
         context 'set as a document instance' do
           before do
-            instance.stars = [Star.new]
+            instance.stars = [ Star.new ]
             instance.save!
           end
 
@@ -110,7 +108,7 @@ describe 'callbacks integration tests' do
 
         context 'set as attributes on parent' do
           before do
-            instance.stars = [{}]
+            instance.stars = [ {} ]
             instance.save!
           end
 
@@ -121,17 +119,17 @@ describe 'callbacks integration tests' do
       context 'nested embedded document' do
         shared_examples 'persists the attribute value' do
           it 'writes the attribute value into the model' do
-            instance.stars.first.planets.first.age.should == 2_000
+            instance.stars.first.planets.first.age.should eq 2_000
           end
 
           it 'persists the attribute value' do
-            Galaxy.find(instance.id).stars.first.planets.first.age.should == 2_000
+            Galaxy.find(instance.id).stars.first.planets.first.age.should eq 2_000
           end
         end
 
         context 'set as a document instance' do
           before do
-            instance.stars = [Star.new(planets: [Planet.new])]
+            instance.stars = [ Star.new(planets: [ Planet.new ]) ]
             instance.save!
           end
 
@@ -140,7 +138,7 @@ describe 'callbacks integration tests' do
 
         context 'set as attributes on parent' do
           before do
-            instance.stars = [planets: [{}]]
+            instance.stars = [ { planets: [ {} ] } ]
             instance.save!
           end
 
@@ -157,17 +155,17 @@ describe 'callbacks integration tests' do
       context 'embedded document' do
         shared_examples 'persists the attribute value' do
           it 'writes the attribute value into the model' do
-            instance.stars.first.age.should == 42_000
+            instance.stars.first.age.should eq 42_000
           end
 
           it 'persists the attribute value' do
-            Galaxy.find(instance.id).stars.first.age.should == 42_000
+            Galaxy.find(instance.id).stars.first.age.should eq 42_000
           end
         end
 
         context 'set as a document instance' do
           before do
-            instance.update_attributes!(stars: [Star.new])
+            instance.update_attributes!(stars: [ Star.new ])
           end
 
           include_examples 'persists the attribute value'
@@ -175,7 +173,7 @@ describe 'callbacks integration tests' do
 
         context 'set as attributes on parent' do
           before do
-            instance.update_attributes!(stars: [{}])
+            instance.update_attributes!(stars: [ {} ])
           end
 
           include_examples 'persists the attribute value'
@@ -185,17 +183,17 @@ describe 'callbacks integration tests' do
       context 'nested embedded document' do
         shared_examples 'persists the attribute value' do
           it 'writes the attribute value into the model' do
-            instance.stars.first.planets.first.age.should == 2_000
+            instance.stars.first.planets.first.age.should eq 2_000
           end
 
           it 'persists the attribute value' do
-            Galaxy.find(instance.id).stars.first.planets.first.age.should == 2_000
+            Galaxy.find(instance.id).stars.first.planets.first.age.should eq 2_000
           end
         end
 
         context 'set as a document instance' do
           before do
-            instance.update_attributes!(stars: [Star.new(planets: [Planet.new])])
+            instance.update_attributes!(stars: [ Star.new(planets: [ Planet.new ]) ])
           end
 
           include_examples 'persists the attribute value'
@@ -203,7 +201,7 @@ describe 'callbacks integration tests' do
 
         context 'set as attributes on parent' do
           before do
-            instance.update_attributes!(stars: [planets: [{}]])
+            instance.update_attributes!(stars: [ { planets: [ {} ] } ])
           end
 
           include_examples 'persists the attribute value'
@@ -219,11 +217,11 @@ describe 'callbacks integration tests' do
       context 'embedded document' do
         shared_examples 'persists the attribute value' do
           it 'writes the attribute value into the model' do
-            instance.president.age.should == 79
+            instance.president.age.should eq 79
           end
 
           it 'persists the attribute value' do
-            Country.find(instance.id).president.age.should == 79
+            Country.find(instance.id).president.age.should eq 79
           end
         end
 
@@ -237,7 +235,7 @@ describe 'callbacks integration tests' do
 
         context 'set as attributes on parent' do
           before do
-            instance.update_attributes!(president: { name: "Abraham Lincoln" })
+            instance.update_attributes!(president: { name: 'Abraham Lincoln' })
           end
 
           include_examples 'persists the attribute value'
@@ -247,11 +245,11 @@ describe 'callbacks integration tests' do
       context 'nested embedded document' do
         shared_examples 'persists the attribute value' do
           it 'writes the attribute value into the model' do
-            instance.president.first_spouse.age.should == 70
+            instance.president.first_spouse.age.should eq 70
           end
 
           it 'persists the attribute value' do
-            Country.find(instance.id).president.first_spouse.age.should == 70
+            Country.find(instance.id).president.first_spouse.age.should eq 70
           end
         end
 
@@ -265,7 +263,7 @@ describe 'callbacks integration tests' do
 
         context 'set as attributes on parent' do
           before do
-            instance.update_attributes!(president: { first_spouse: { name: "Mary Todd Lincoln" } })
+            instance.update_attributes!(president: { first_spouse: { name: 'Mary Todd Lincoln' } })
           end
 
           include_examples 'persists the attribute value'
@@ -281,7 +279,7 @@ describe 'callbacks integration tests' do
       obj.frequency = 2
       obj.save!
 
-      obj.previous.should == 2
+      obj.previous.should eq 2
     end
   end
 
@@ -296,6 +294,7 @@ describe 'callbacks integration tests' do
 
     class CBIntSpecProfile
       include Mongoid::Document
+
       field :name, type: String
       shard_key :name
 
@@ -316,7 +315,7 @@ describe 'callbacks integration tests' do
     end
   end
 
-  context "When touching an embedded document" do
+  context 'When touching an embedded document' do
     let(:planet) { Planet.new }
     let(:star) { Star.new }
     let(:galaxy) { Galaxy.create! }
@@ -326,7 +325,7 @@ describe 'callbacks integration tests' do
       galaxy.stars << star
     end
 
-    it "the parent document touch callback gets called before the child" do
+    it 'the parent document touch callback gets called before the child' do
       planet.touch
       expect(galaxy.was_touched).to be true
       expect(star.was_touched_after_parent).to be true
@@ -334,8 +333,7 @@ describe 'callbacks integration tests' do
     end
   end
 
-  context "when reloading has_and_belongs_to_many after_save and after_remove callbacks" do
-
+  context 'when reloading has_and_belongs_to_many after_save and after_remove callbacks' do
     let(:architect) { Architect.create }
 
     let(:b1) { Building.create }
@@ -344,7 +342,7 @@ describe 'callbacks integration tests' do
 
     let(:b3) { Building.create }
 
-    it "counts added/removed buildings correctly" do
+    it 'counts added/removed buildings correctly' do
       architect.buildings << b1
       expect(architect.after_add_num_buildings).to eq(1)
 
@@ -364,11 +362,11 @@ describe 'callbacks integration tests' do
 
   context '_previously was methods in after_save callback' do
     let(:title) do
-      "Title"
+      'Title'
     end
 
     let(:updated_title) do
-      "Updated title"
+      'Updated title'
     end
 
     let(:age) do
@@ -386,7 +384,7 @@ describe 'callbacks integration tests' do
 
         set_callback :save, :after do |doc|
           @after_save_vals ||= []
-          @after_save_vals << [doc.title_previously_was, doc.age_previously_was]
+          @after_save_vals << [ doc.title_previously_was, doc.age_previously_was ]
         end
       end
 
@@ -394,10 +392,10 @@ describe 'callbacks integration tests' do
       person.title = updated_title
       person.save!
       expect(person.after_save_vals).to eq([
-        # Field values are nil before create
-        [nil, nil],
-        [title, age]
-        ])
+                                             # Field values are nil before create
+                                             [ nil, nil ],
+                                             [ title, age ]
+                                           ])
     end
   end
 
@@ -416,9 +414,9 @@ describe 'callbacks integration tests' do
         end
       end
 
-      person = PreviouslyNewRecordPerson.create!(title: "title", age: 55)
+      person = PreviouslyNewRecordPerson.create!(title: 'title', age: 55)
       expect(person.previously_new_record_value).to be_truthy
-      person.title = "New title"
+      person.title = 'New title'
       person.save!
       expect(person.previously_new_record_value).to be_falsey
     end
@@ -439,11 +437,11 @@ describe 'callbacks integration tests' do
         end
       end
 
-      unsaved_person = PreviouslyPersistedPerson.new(title: "title", age: 55)
+      unsaved_person = PreviouslyPersistedPerson.new(title: 'title', age: 55)
       unsaved_person.destroy
       expect(unsaved_person.previously_persisted_value).to be_falsey
 
-      saved_person = PreviouslyPersistedPerson.create(title: "title", age: 55)
+      saved_person = PreviouslyPersistedPerson.create(title: 'title', age: 55)
       saved_person.destroy
       expect(saved_person.previously_persisted_value).to be_truthy
     end
@@ -456,19 +454,19 @@ describe 'callbacks integration tests' do
       field :name, type: String
       field :age, type: Integer
 
-      set_callback :save, :before do |doc|
-        [:name, :age].each do |attr|
-          saved_change_to_attribute_values_before[attr] += [saved_change_to_attribute(attr)]
-          attribute_before_last_save_values_before[attr] += [attribute_before_last_save(attr)]
-          will_save_change_to_attribute_values_before[attr] += [will_save_change_to_attribute?(attr)]
+      set_callback :save, :before do |_doc|
+        %i[name age].each do |attr|
+          saved_change_to_attribute_values_before[attr] += [ saved_change_to_attribute(attr) ]
+          attribute_before_last_save_values_before[attr] += [ attribute_before_last_save(attr) ]
+          will_save_change_to_attribute_values_before[attr] += [ will_save_change_to_attribute?(attr) ]
         end
       end
 
-      set_callback :save, :after do |doc|
-        [:name, :age].each do |attr|
-          saved_change_to_attribute_values_after[attr] += [saved_change_to_attribute(attr)]
-          saved_change_to_attribute_q_values_after[attr] += [saved_change_to_attribute?(attr)]
-          attribute_before_last_save_values_after[attr] += [attribute_before_last_save(attr)]
+      set_callback :save, :after do |_doc|
+        %i[name age].each do |attr|
+          saved_change_to_attribute_values_after[attr] += [ saved_change_to_attribute(attr) ]
+          saved_change_to_attribute_q_values_after[attr] += [ saved_change_to_attribute?(attr) ]
+          attribute_before_last_save_values_after[attr] += [ attribute_before_last_save(attr) ]
         end
       end
 
@@ -519,38 +517,38 @@ describe 'callbacks integration tests' do
 
       expect(subject.saved_change_to_attribute_values_before).to eq(
         {
-          :name => [nil, [nil, "Name 1"], nil],
-          :age => [nil, nil, [nil, 18]],
+          name: [ nil, [ nil, 'Name 1' ], nil ],
+          age: [ nil, nil, [ nil, 18 ] ]
         }
       )
       expect(subject.saved_change_to_attribute_values_after).to eq(
         {
-          :name => [[nil, "Name 1"], nil, ["Name 1", "Name 2"]],
-          :age => [nil, [nil, 18], nil],
+          name: [ [ nil, 'Name 1' ], nil, [ 'Name 1', 'Name 2' ] ],
+          age: [ nil, [ nil, 18 ], nil ]
         }
       )
       expect(subject.saved_change_to_attribute_q_values_after).to eq(
         {
-          :name => [true, false, true],
-          :age => [false, true, false],
+          name: [ true, false, true ],
+          age: [ false, true, false ]
         }
       )
       expect(subject.attribute_before_last_save_values_before).to eq(
         {
-          :name => [nil, nil, "Name 1"],
-          :age => [nil, nil, nil]
+          name: [ nil, nil, 'Name 1' ],
+          age: [ nil, nil, nil ]
         }
       )
       expect(subject.attribute_before_last_save_values_after).to eq(
         {
-          :name => [nil, "Name 1", "Name 1"],
-          :age => [nil, nil, 18]
+          name: [ nil, 'Name 1', 'Name 1' ],
+          age: [ nil, nil, 18 ]
         }
       )
       expect(subject.will_save_change_to_attribute_values_before).to eq(
         {
-          :name => [true, false, true],
-          :age => [false, true, false]
+          name: [ true, false, true ],
+          age: [ false, true, false ]
         }
       )
     end
@@ -560,19 +558,19 @@ describe 'callbacks integration tests' do
     config_override :prevent_multiple_calls_of_embedded_callbacks, true
     config_override :around_callbacks_for_embeds, true
 
-    let(:logger) { Array.new }
+    let(:logger) { [] }
 
     let(:root) do
       Root.new(
         embedded_once: [
           EmbeddedOnce.new(
-            embedded_twice: [EmbeddedTwice.new]
+            embedded_twice: [ EmbeddedTwice.new ]
           )
         ]
       )
     end
 
-    before(:each) do
+    before do
       root.logger = logger
       root.embedded_once.first.logger = logger
       root.embedded_once.first.embedded_twice.first.logger = logger

data/spec/integration/contextual/empty_spec.rb

@@ -1,37 +1,36 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 require 'spec_helper'
 
 describe 'Contextual classes when dealing with empty result set' do
   shared_examples 'behave as expected' do
-    context '#exists?' do
+    describe '#exists?' do
       it 'is false' do
         context.exists?.should be false
       end
     end
 
-    context '#count' do
+    describe '#count' do
       it 'is 0' do
-        context.count.should == 0
+        context.count.should eq 0
       end
     end
 
-    context '#length' do
+    describe '#length' do
       it 'is 0' do
-        context.length.should == 0
+        context.length.should eq 0
       end
     end
 
     # #estimated_count only exists for Mongo
 
-    context '#distinct' do
+    describe '#distinct' do
       it 'is empty array' do
-        context.distinct(:foo).should == []
+        context.distinct(:foo).should eq []
       end
     end
 
-    context '#each' do
+    describe '#each' do
       context 'with block' do
         it 'does not invoke the block' do
           called = false
@@ -48,12 +47,12 @@ describe 'Contextual classes when dealing with empty result set' do
         end
 
         it 'returns empty Enumerable' do
-          context.each.to_a.should == []
+          context.each.to_a.should eq []
         end
       end
     end
 
-    context '#map' do
+    describe '#map' do
       context 'with block' do
         it 'does not invoke the block' do
           called = false
@@ -68,32 +67,32 @@ describe 'Contextual classes when dealing with empty result set' do
         it 'returns empty array' do
           skip 'MONGOID-5148'
 
-          context.map(:field).should == []
+          context.map(:field).should eq []
         end
       end
     end
 
-    context '#first' do
+    describe '#first' do
       it 'is nil' do
-        context.first.should be nil
+        context.first.should be_nil
       end
     end
 
-    context '#find_first' do
+    describe '#find_first' do
       it 'is nil' do
-        context.find_first.should be nil
+        context.find_first.should be_nil
       end
     end
 
-    context '#one' do
+    describe '#one' do
       it 'is nil' do
-        context.one.should be nil
+        context.one.should be_nil
       end
     end
 
-    context '#last' do
+    describe '#last' do
       it 'is nil' do
-        context.last.should be nil
+        context.last.should be_nil
       end
     end
   end

data/spec/integration/criteria/alias_query_spec.rb

@@ -1,11 +1,13 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 require 'spec_helper'
 
 describe 'distinct on aliased fields' do
-
   let(:client) { Person.collection.client }
+  let(:event) do
+    subscriber.single_command_started_event('distinct')
+  end
+  let(:command) { event.command }
 
   let(:subscriber) do
     Mrss::EventSubscriber.new
@@ -19,12 +21,6 @@ describe 'distinct on aliased fields' do
     client.unsubscribe(Mongo::Monitoring::COMMAND, subscriber)
   end
 
-  let(:event) do
-    subscriber.single_command_started_event('distinct')
-  end
-
-  let(:command) { event.command }
-
   context 'top level field' do
     let(:query) do
       Person.distinct(:test)
@@ -33,7 +29,7 @@ describe 'distinct on aliased fields' do
     it 'expands the alias' do
       query
 
-      command['key'].should == 't'
+      command['key'].should eq 't'
     end
   end
 
@@ -45,14 +41,17 @@ describe 'distinct on aliased fields' do
     it 'expands the alias' do
       query
 
-      command['key'].should == 'phone_numbers.ext'
+      command['key'].should eq 'phone_numbers.ext'
     end
   end
 end
 
 describe 'pluck on aliased fields' do
-
   let(:client) { Person.collection.client }
+  let(:event) do
+    subscriber.single_command_started_event('find')
+  end
+  let(:command) { event.command }
 
   let(:subscriber) do
     Mrss::EventSubscriber.new
@@ -66,12 +65,6 @@ describe 'pluck on aliased fields' do
     client.unsubscribe(Mongo::Monitoring::COMMAND, subscriber)
   end
 
-  let(:event) do
-    subscriber.single_command_started_event('find')
-  end
-
-  let(:command) { event.command }
-
   context 'top level field' do
     let(:query) do
       Person.pluck(:test)
@@ -80,7 +73,7 @@ describe 'pluck on aliased fields' do
     it 'expands the alias' do
       query
 
-      command['projection'].should == {'t' => true}
+      command['projection'].should eq({ 't' => true })
     end
   end
 
@@ -92,7 +85,7 @@ describe 'pluck on aliased fields' do
     it 'expands the alias' do
       query
 
-      command['projection'].should == {'phone_numbers.ext' => true}
+      command['projection'].should eq({ 'phone_numbers.ext' => true })
     end
   end
 end

data/spec/integration/criteria/date_field_spec.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 require 'spec_helper'
 
@@ -12,7 +11,7 @@ describe 'Queries on Date fields' do
 
   shared_examples 'converts to beginning of day in UTC' do
     it 'converts to beginning of day in UTC' do
-      selector['founded'].should == Time.utc(arg.year, arg.month, arg.day)
+      selector['founded'].should eq Time.utc(arg.year, arg.month, arg.day)
     end
   end