mongoid 9.0.11 → 9.1.0

data/spec/mongoid/criteria/queryable/extensions/date_time_spec.rb

@@ -1,16 +1,12 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
-require "spec_helper"
+require 'spec_helper'
 
 describe DateTime do
-
-  describe "#__evolve_time" do
-
-    context "when the date time is not utc" do
-
+  describe '#__evolve_time' do
+    context 'when the date time is not utc' do
       let(:date) do
-        DateTime.new(2010, 1, 1, 12, 0, 0, "+01:00")
+        DateTime.new(2010, 1, 1, 12, 0, 0, '+01:00')
       end
 
       let(:evolved) do
@@ -21,17 +17,16 @@ describe DateTime do
         Time.utc(2010, 1, 1, 11, 0, 0)
       end
 
-      it "returns the time" do
+      it 'returns the time' do
         expect(evolved).to eq(expected)
       end
 
-      it "returns the time in utc" do
+      it 'returns the time in utc' do
         expect(evolved.utc_offset).to eq(0)
       end
     end
 
-    context "when the date time is already in utc" do
-
+    context 'when the date time is already in utc' do
       let(:date) do
         DateTime.new(2010, 1, 1, 12, 0, 0).utc
       end
@@ -44,18 +39,18 @@ describe DateTime do
         Time.utc(2010, 1, 1, 12, 0, 0)
       end
 
-      it "returns the time" do
+      it 'returns the time' do
         expect(evolved).to eq(expected)
       end
 
-      it "returns the time in utc" do
+      it 'returns the time in utc' do
         expect(evolved.utc_offset).to eq(0)
       end
     end
 
-    context "when the date time has millisecond precision" do
+    context 'when the date time has millisecond precision' do
       let(:date) do
-        DateTime.parse("2012-10-22T04:05:06.942")
+        DateTime.parse('2012-10-22T04:05:06.942')
       end
 
       let(:evolved) do
@@ -63,21 +58,19 @@ describe DateTime do
       end
 
       let(:expected) do
-        Time.utc(2012, 10, 22, 4, 5, 6, 942000)
+        Time.utc(2012, 10, 22, 4, 5, 6, 942_000)
       end
 
-      it "returns the time with millisecond precision" do
+      it 'returns the time with millisecond precision' do
         expect(evolved).to eq(expected)
       end
     end
   end
 
-  describe ".evolve" do
-
-    context "when provided a date time" do
-
+  describe '.evolve' do
+    context 'when provided a date time' do
       let(:date) do
-        DateTime.new(2010, 1, 1, 12, 0, 0, "+01:00")
+        DateTime.new(2010, 1, 1, 12, 0, 0, '+01:00')
       end
 
       let(:evolved) do
@@ -88,18 +81,18 @@ describe DateTime do
         Time.utc(2010, 1, 1, 11, 0, 0)
       end
 
-      it "returns the time" do
+      it 'returns the time' do
         expect(evolved).to eq(expected)
       end
 
-      it "returns the time in utc" do
+      it 'returns the time in utc' do
         expect(evolved.utc_offset).to eq(0)
       end
     end
 
-    context "when provided a date time with millisecond precision" do
+    context 'when provided a date time with millisecond precision' do
       let(:date) do
-        DateTime.parse("2012-10-22T04:05:06.942")
+        DateTime.parse('2012-10-22T04:05:06.942')
       end
 
       let(:evolved) do
@@ -107,20 +100,18 @@ describe DateTime do
       end
 
       let(:expected) do
-        Time.utc(2012, 10, 22, 4, 5, 6, 942000)
+        Time.utc(2012, 10, 22, 4, 5, 6, 942_000)
       end
 
-      it "returns the time with millisecond precision" do
+      it 'returns the time with millisecond precision' do
         expect(evolved).to eq(expected)
       end
     end
 
-    context "when provided an array" do
-
-      context "when the array is composed of date times" do
-
+    context 'when provided an array' do
+      context 'when the array is composed of date times' do
         let(:date) do
-          DateTime.new(2010, 1, 1, 12, 0, 0, "+01:00")
+          DateTime.new(2010, 1, 1, 12, 0, 0, '+01:00')
         end
 
         let(:evolved) do
@@ -131,19 +122,18 @@ describe DateTime do
           Time.utc(2010, 1, 1, 11, 0, 0)
         end
 
-        it "returns the array with evolved times" do
+        it 'returns the array with evolved times' do
           expect(evolved).to eq([ expected ])
         end
 
-        it "returns the times in utc" do
+        it 'returns the times in utc' do
           expect(evolved.first.utc_offset).to eq(0)
         end
       end
 
-      context "when the array is composed of strings" do
-
+      context 'when the array is composed of strings' do
         let(:date_str) do
-          "1st Jan 2010 12:00:00+01:00"
+          '1st Jan 2010 12:00:00+01:00'
         end
 
         let(:evolved) do
@@ -154,19 +144,18 @@ describe DateTime do
           Time.utc(2010, 1, 1, 11, 0, 0)
         end
 
-        it "returns the strings as a times" do
+        it 'returns the strings as a times' do
           expect(evolved).to eq([ expected ])
         end
 
-        it "returns the times in utc" do
+        it 'returns the times in utc' do
           expect(evolved.first.utc_offset).to eq(0)
         end
       end
 
-      context "when the array is composed of integers" do
-
+      context 'when the array is composed of integers' do
         let(:integer) do
-          1331890719
+          1_331_890_719
         end
 
         let(:evolved) do
@@ -177,19 +166,18 @@ describe DateTime do
           Time.at(integer).utc
         end
 
-        it "returns the integers as times" do
+        it 'returns the integers as times' do
           expect(evolved).to eq([ expected ])
         end
 
-        it "returns the times in utc" do
+        it 'returns the times in utc' do
           expect(evolved.first.utc_offset).to eq(0)
         end
       end
 
-      context "when the array is composed of floats" do
-
+      context 'when the array is composed of floats' do
         let(:float) do
-          1331890719.413
+          1_331_890_719.413
         end
 
         let(:evolved) do
@@ -200,26 +188,24 @@ describe DateTime do
           Time.at(float).utc
         end
 
-        it "returns the floats as times" do
+        it 'returns the floats as times' do
           expect(evolved).to eq([ expected ])
         end
 
-        it "returns the times in utc" do
+        it 'returns the times in utc' do
           expect(evolved.first.utc_offset).to eq(0)
         end
       end
     end
 
-    context "when provided a range" do
-
-      context "when the range are dates" do
-
+    context 'when provided a range' do
+      context 'when the range are dates' do
         let(:min) do
-          DateTime.new(2010, 1, 1, 12, 0, 0, "+01:00")
+          DateTime.new(2010, 1, 1, 12, 0, 0, '+01:00')
         end
 
         let(:max) do
-          DateTime.new(2010, 1, 3, 12, 0, 0, "+01:00")
+          DateTime.new(2010, 1, 3, 12, 0, 0, '+01:00')
         end
 
         let(:evolved) do
@@ -234,25 +220,24 @@ describe DateTime do
           Time.utc(2010, 1, 3, 11, 0, 0)
         end
 
-        it "returns a selection of times" do
+        it 'returns a selection of times' do
           expect(evolved).to eq(
-            { "$gte" => expected_min, "$lte" => expected_max }
+            { '$gte' => expected_min, '$lte' => expected_max }
           )
         end
 
-        it "returns the times in utc" do
-          expect(evolved["$gte"].utc_offset).to eq(0)
+        it 'returns the times in utc' do
+          expect(evolved['$gte'].utc_offset).to eq(0)
         end
       end
 
-      context "when the range are strings" do
-
+      context 'when the range are strings' do
         let(:min) do
-          "1st Jan 2010 12:00:00+01:00"
+          '1st Jan 2010 12:00:00+01:00'
         end
 
         let(:max) do
-          "3rd Jan 2010 12:00:00+01:00"
+          '3rd Jan 2010 12:00:00+01:00'
         end
 
         let(:expected_min) do
@@ -267,25 +252,24 @@ describe DateTime do
           described_class.evolve(min..max)
         end
 
-        it "returns a selection of times" do
+        it 'returns a selection of times' do
           expect(evolved).to eq(
-            { "$gte" => expected_min, "$lte" => expected_max }
+            { '$gte' => expected_min, '$lte' => expected_max }
           )
         end
 
-        it "returns the times in utc" do
-          expect(evolved["$gte"].utc_offset).to eq(0)
+        it 'returns the times in utc' do
+          expect(evolved['$gte'].utc_offset).to eq(0)
         end
       end
 
-      context "when the range is floats" do
-
+      context 'when the range is floats' do
         let(:min) do
-          1331890719.1234
+          1_331_890_719.1234
         end
 
         let(:max) do
-          1332890719.7651
+          1_332_890_719.7651
         end
 
         let(:evolved) do
@@ -300,25 +284,24 @@ describe DateTime do
           Time.at(max)
         end
 
-        it "returns a selection of times" do
+        it 'returns a selection of times' do
           expect(evolved).to eq(
-            { "$gte" => expected_min, "$lte" => expected_max }
+            { '$gte' => expected_min, '$lte' => expected_max }
           )
         end
 
-        it "returns the times in utc" do
-          expect(evolved["$gte"].utc_offset).to eq(0)
+        it 'returns the times in utc' do
+          expect(evolved['$gte'].utc_offset).to eq(0)
         end
       end
 
-      context "when the range is integers" do
-
+      context 'when the range is integers' do
         let(:min) do
-          1331890719
+          1_331_890_719
         end
 
         let(:max) do
-          1332890719
+          1_332_890_719
         end
 
         let(:evolved) do
@@ -333,22 +316,21 @@ describe DateTime do
           Time.at(max)
         end
 
-        it "returns a selection of times" do
+        it 'returns a selection of times' do
           expect(evolved).to eq(
-            { "$gte" => expected_min, "$lte" => expected_max }
+            { '$gte' => expected_min, '$lte' => expected_max }
           )
         end
 
-        it "returns the times in utc" do
-          expect(evolved["$gte"].utc_offset).to eq(0)
+        it 'returns the times in utc' do
+          expect(evolved['$gte'].utc_offset).to eq(0)
         end
       end
     end
 
-    context "when provided a string" do
-
+    context 'when provided a string' do
       let(:date_str) do
-        "1st Jan 2010 12:00:00+01:00"
+        '1st Jan 2010 12:00:00+01:00'
       end
 
       let(:evolved) do
@@ -359,19 +341,18 @@ describe DateTime do
         Time.utc(2010, 1, 1, 11, 0, 0)
       end
 
-      it "returns the string as a time" do
+      it 'returns the string as a time' do
         expect(evolved).to eq(expected)
       end
 
-      it "returns the time in utc" do
+      it 'returns the time in utc' do
         expect(evolved.utc_offset).to eq(0)
       end
     end
 
-    context "when provided a float" do
-
+    context 'when provided a float' do
       let(:float) do
-        1331890719.8170738
+        1_331_890_719.8170738
       end
 
       let(:evolved) do
@@ -382,19 +363,18 @@ describe DateTime do
         Time.at(float)
       end
 
-      it "returns the float as a time" do
+      it 'returns the float as a time' do
         expect(evolved).to eq(expected)
       end
 
-      it "returns the time in utc" do
+      it 'returns the time in utc' do
         expect(evolved.utc_offset).to eq(0)
       end
     end
 
-    context "when provided an integer" do
-
+    context 'when provided an integer' do
       let(:integer) do
-        1331890719
+        1_331_890_719
       end
 
       let(:evolved) do
@@ -405,29 +385,27 @@ describe DateTime do
         Time.at(integer)
       end
 
-      it "returns the integer as a time" do
+      it 'returns the integer as a time' do
         expect(evolved).to eq(expected)
       end
 
-      it "returns the time in utc" do
+      it 'returns the time in utc' do
         expect(evolved.utc_offset).to eq(0)
       end
     end
 
-    context "when provided an invalid string" do
-
+    context 'when provided an invalid string' do
       let(:evolved) do
-        described_class.evolve("bogus")
+        described_class.evolve('bogus')
       end
 
-      it "returns that string" do
-        expect(evolved).to eq("bogus")
+      it 'returns that string' do
+        expect(evolved).to eq('bogus')
       end
     end
 
-    context "when provided nil" do
-
-      it "returns nil" do
+    context 'when provided nil' do
+      it 'returns nil' do
         expect(described_class.evolve(nil)).to be_nil
       end
     end

data/spec/mongoid/criteria/queryable/extensions/float_spec.rb

@@ -1,67 +1,128 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
-require "spec_helper"
+require 'spec_helper'
 
 describe Float do
+  describe '.evolve' do
+    context 'when provided a string' do
+      context 'when the string is a number' do
+        context 'when the string is an integer' do
+          it 'returns a float' do
+            expect(described_class.evolve('1')).to eq(1.0)
+          end
+        end
 
-  describe ".evolve" do
+        context 'when the string is a float' do
+          it 'converts it to a float' do
+            expect(described_class.evolve('2.23')).to eq(2.23)
+          end
+        end
+      end
 
-    context "when provided a string" do
+      context 'when the string is not a number' do
+        it 'returns the string' do
+          expect(described_class.evolve('testing')).to eq('testing')
+        end
+      end
+    end
 
-      context "when the string is a number" do
+    context 'when provided an array of strings' do
+      it 'returns the array of floats' do
+        expect(described_class.evolve([ '2.23' ])).to eq([ 2.23 ])
+      end
+    end
 
-        context "when the string is an integer" do
+    context 'when provided a number' do
+      context 'when the number is an integer' do
+        it 'returns a float' do
+          expect(described_class.evolve(1)).to eq(1.0)
+        end
+      end
 
-          it "returns a float" do
-            expect(described_class.evolve("1")).to eq(1.0)
-          end
+      context 'when the number is a float' do
+        it 'returns the float' do
+          expect(described_class.evolve(2.23)).to eq(2.23)
         end
+      end
+    end
 
-        context "when the string is a float" do
+    context 'when provided nil' do
+      it 'returns nil' do
+        expect(described_class.evolve(nil)).to be_nil
+      end
+    end
+  end
 
-          it "converts it to a float" do
-            expect(described_class.evolve("2.23")).to eq(2.23)
-          end
-        end
+  describe '#__evolve_time__' do
+    context 'UTC time zone' do
+      let(:time) do
+        Time.parse('2022-01-01 16:15:01 UTC')
       end
 
-      context "when the string is not a number" do
+      let(:evolved) do
+        time.to_f.__evolve_time__
+      end
 
-        it "returns the string" do
-          expect(described_class.evolve("testing")).to eq("testing")
-        end
+      it 'evolves the correct time' do
+        expect(evolved).to eq(time)
       end
     end
 
-    context "when provided an array of strings" do
+    context 'other time zone' do
+      let(:time) do
+        Time.parse('2022-01-01 16:15:01 +0900')
+      end
+
+      let(:evolved) do
+        time.to_f.__evolve_time__
+      end
 
-      it "returns the array of floats" do
-        expect(described_class.evolve([ "2.23" ])).to eq([ 2.23 ])
+      it 'evolves the correct time' do
+        expect(evolved).to eq(time)
       end
     end
+  end
 
-    context "when provided a number" do
+  describe '#__evolve_date__' do
+    context 'exact match' do
+      let(:date) do
+        Date.parse('2022-01-01')
+      end
 
-      context "when the number is an integer" do
+      let(:evolved) do
+        Time.parse('2022-01-01 0:00 UTC').to_f.__evolve_date__
+      end
 
-        it "returns a float" do
-          expect(described_class.evolve(1)).to eq(1.0)
-        end
+      it 'evolves the correct time' do
+        expect(evolved).to eq(date)
       end
+    end
 
-      context "when the number is a float" do
+    context 'one second earlier' do
+      let(:date) do
+        Date.parse('2021-12-31')
+      end
 
-        it "returns the float" do
-          expect(described_class.evolve(2.23)).to eq(2.23)
-        end
+      let(:evolved) do
+        (Time.parse('2022-01-01 0:00 UTC').to_f - 1).__evolve_date__
+      end
+
+      it 'evolves the correct time' do
+        expect(evolved).to eq(date)
       end
     end
 
-    context "when provided nil" do
+    context 'one second later' do
+      let(:date) do
+        Date.parse('2022-01-01')
+      end
 
-      it "returns nil" do
-        expect(described_class.evolve(nil)).to be_nil
+      let(:evolved) do
+        (Time.parse('2022-01-01 0:00 UTC').to_f + 1).__evolve_date__
+      end
+
+      it 'evolves the correct time' do
+        expect(evolved).to eq(date)
       end
     end
   end