mongoid 9.0.11 → 9.1.0

data/spec/mongoid/association/builders_spec.rb

@@ -1,44 +1,36 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
-require "spec_helper"
+require 'spec_helper'
 
 describe Mongoid::Association::Builders do
-
   describe "#build_#\{name}" do
-
     let(:person) do
       Person.new
     end
 
-    context "when providing no attributes" do
-
-      context "when the relation is an embeds one" do
-
+    context 'when providing no attributes' do
+      context 'when the relation is an embeds one' do
         let(:name) do
           person.build_name
         end
 
-        it "does not set a binding attribute" do
+        it 'does not set a binding attribute' do
           expect(name[:binding]).to be_nil
         end
       end
 
-      context "when the relation is a references one" do
-
+      context 'when the relation is a references one' do
         let(:game) do
           person.build_game
         end
 
-        it "does not set a binding attribute" do
+        it 'does not set a binding attribute' do
           expect(game[:binding]).to be_nil
         end
       end
 
-      context "when the relation is a belongs to" do
-
-        context "when the inverse is a has many" do
-
+      context 'when the relation is a belongs to' do
+        context 'when the inverse is a has many' do
           let(:post) do
             Post.new
           end
@@ -47,21 +39,20 @@ describe Mongoid::Association::Builders do
             post.build_person
           end
 
-          it "builds the document" do
+          it 'builds the document' do
             expect(post.person).to eq(person)
           end
 
-          it "sets the inverse" do
+          it 'sets the inverse' do
             expect(person.posts).to eq([ post ])
           end
 
-          it "does not save the document" do
-            expect(person).to_not be_persisted
+          it 'does not save the document' do
+            expect(person).not_to be_persisted
           end
         end
 
-        context "when the inverse is a has one" do
-
+        context 'when the inverse is a has one' do
           let(:game) do
             Game.new
           end
@@ -70,16 +61,59 @@ describe Mongoid::Association::Builders do
             game.build_person
           end
 
-          it "builds the document" do
+          it 'builds the document' do
             expect(game.person).to eq(person)
           end
 
-          it "sets the inverse" do
+          it 'sets the inverse' do
             expect(person.game).to eq(game)
           end
 
-          it "does not save the document" do
-            expect(person).to_not be_persisted
+          it 'does not save the document' do
+            expect(person).not_to be_persisted
+          end
+        end
+      end
+    end
+
+    context 'when providing a type argument' do
+      context 'when the relation is an embeds_one' do
+        let(:canvas) { Canvas.new }
+
+        context 'when the type is a subclass of the association class' do
+          let(:writer) { canvas.build_writer({}, PdfWriter) }
+
+          it 'builds an instance of the specified type' do
+            expect(writer).to be_a(PdfWriter)
+          end
+
+          it 'assigns the built document to the association' do
+            writer # build the association
+            expect(canvas.writer).to eq(writer)
+          end
+
+          it 'does not persist the document' do
+            expect(writer).not_to be_persisted
+          end
+        end
+
+        context 'when no type is given' do
+          let(:writer) { canvas.build_writer(speed: 3) }
+
+          it 'builds an instance of the default association class' do
+            expect(writer).to be_a(Writer)
+          end
+
+          it 'applies the given attributes' do
+            expect(writer.speed).to eq(3)
+          end
+        end
+
+        context 'when nil is passed as the type' do
+          let(:writer) { canvas.build_writer({}, nil) }
+
+          it 'builds an instance of the default association class' do
+            expect(writer).to be_a(Writer)
           end
         end
       end
@@ -87,39 +121,33 @@ describe Mongoid::Association::Builders do
   end
 
   describe "#create_#\{name}" do
-
     let(:person) do
       Person.new
     end
 
-    context "when providing no attributes" do
-
-      context "when the relation is an embeds one" do
-
+    context 'when providing no attributes' do
+      context 'when the relation is an embeds one' do
         let(:name) do
           person.create_name
         end
 
-        it "does not set a binding attribute" do
+        it 'does not set a binding attribute' do
           expect(name[:binding]).to be_nil
         end
       end
 
-      context "when the relation is a references one" do
-
+      context 'when the relation is a references one' do
         let(:game) do
           person.create_game
         end
 
-        it "does not set a binding attribute" do
+        it 'does not set a binding attribute' do
           expect(game[:binding]).to be_nil
         end
       end
 
-      context "when the relation is a belongs to" do
-
-        context "when the inverse is a has many" do
-
+      context 'when the relation is a belongs to' do
+        context 'when the inverse is a has many' do
           let(:post) do
             Post.new
           end
@@ -128,25 +156,24 @@ describe Mongoid::Association::Builders do
             post.create_person
           end
 
-          it "builds the document" do
+          it 'builds the document' do
             expect(post.person).to eq(person)
           end
 
-          it "sets the inverse" do
+          it 'sets the inverse' do
             expect(person.posts).to eq([ post ])
           end
 
-          it "saves the document" do
+          it 'saves the document' do
             expect(person).to be_persisted
           end
 
-          it "saves the child" do
+          it 'saves the child' do
             expect(post).to be_persisted
           end
         end
 
-        context "when the inverse is a has one" do
-
+        context 'when the inverse is a has one' do
           let(:game) do
             Game.new
           end
@@ -155,78 +182,100 @@ describe Mongoid::Association::Builders do
             game.create_person
           end
 
-          it "builds the document" do
+          it 'builds the document' do
             expect(game.person).to eq(person)
           end
 
-          it "sets the inverse" do
+          it 'sets the inverse' do
             expect(person.game).to eq(game)
           end
 
-          it "saves the document" do
+          it 'saves the document' do
             expect(person).to be_persisted
           end
 
-          it "saves the child" do
+          it 'saves the child' do
             expect(game).to be_persisted
           end
         end
       end
     end
 
-    context "when the parent is persisted" do
+    context 'when providing a type argument' do
+      context 'when the relation is an embeds_one' do
+        let(:canvas) { Canvas.new }
+
+        context 'when the type is a subclass of the association class' do
+          let(:writer) { canvas.create_writer({}, PdfWriter) }
+
+          it 'builds an instance of the specified type' do
+            expect(writer).to be_a(PdfWriter)
+          end
+
+          it 'assigns the built document to the association' do
+            writer # create the association
+            expect(canvas.writer).to eq(writer)
+          end
+        end
+
+        context 'when no type is given' do
+          let(:writer) { canvas.create_writer(speed: 3) }
 
+          it 'builds an instance of the default association class' do
+            expect(writer).to be_a(Writer)
+          end
+        end
+      end
+    end
+
+    context 'when the parent is persisted' do
       let(:person) do
         Person.create!
       end
 
-      context "when the relation is a has one" do
-
+      context 'when the relation is a has one' do
         let!(:game_one) do
-          person.create_game(name: "Starcraft")
+          person.create_game(name: 'Starcraft')
         end
 
-        context "when a document already exists" do
-
-          context "when the relation belongs_to is already set" do
-
+        context 'when a document already exists' do
+          context 'when the relation belongs_to is already set' do
             let!(:game_one) do
-              game = person.create_game(name: "Starcraft")
+              game = person.create_game(name: 'Starcraft')
               game.person = person
             end
 
             let!(:game_two) do
-              person.create_game(name: "Skyrim")
+              person.create_game(name: 'Skyrim')
             end
 
-            it "replaces the existing document" do
+            it 'replaces the existing document' do
               expect(person.game).to eq(game_two)
             end
 
-            it "persists the change" do
+            it 'persists the change' do
               expect(person.game(true)).to eq(game_two)
             end
 
-            it "removes the old document from the database" do
+            it 'removes the old document from the database' do
               expect(Game.collection.find.count).to eq(1)
             end
           end
 
           context 'when the relation belongs_to is not already set' do
-
             let!(:game_two) do
-              person.create_game(name: "Skyrim")
+              person.create_game(name: 'Skyrim')
             end
 
-            it "replaces the existing document" do
+            it 'replaces the existing document' do
               expect(person.game).to eq(game_two)
             end
 
-            it "persists the change" do
+            it 'persists the change' do
               expect(person.game(true)).to eq(game_two)
             end
 
-            it "removes the old document from the database" do
+            it 'removes the old document from the database' do
               expect(Game.collection.find.count).to eq(1)
             end
           end
@@ -235,9 +284,9 @@ describe Mongoid::Association::Builders do
     end
   end
 
-  describe "#build" do
-
-    context "with criteria applied" do
+  describe '#build' do
+    context 'with criteria applied' do
+      subject { services.build }
 
       let(:person) do
         Person.new
@@ -247,10 +296,8 @@ describe Mongoid::Association::Builders do
         person.services.asc(:sid)
       end
 
-      subject { services.build }
-
-      it { should be_a_kind_of(Service) }
-      it { should_not be_persisted }
+      it { is_expected.to be_a(Service) }
+      it { is_expected.not_to be_persisted }
     end
   end
 end

data/spec/mongoid/association/constrainable_spec.rb

@@ -1,20 +1,16 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
-require "spec_helper"
+require 'spec_helper'
 
 describe Mongoid::Association::Constrainable do
-
-  describe "#convert_to_foreign_key" do
-
+  describe '#convert_to_foreign_key' do
     context "when the id's class stores object ids" do
-
       before(:all) do
         Person.field(
           :_id,
           type: BSON::ObjectId,
           pre_processed: true,
-          default: ->{ BSON::ObjectId.new },
+          default: -> { BSON::ObjectId.new },
           overwrite: true
         )
       end
@@ -23,42 +19,38 @@ describe Mongoid::Association::Constrainable do
         Post.belongs_to :person
       end
 
-      context "when provided an object id" do
-
+      context 'when provided an object id' do
         let(:object) do
           BSON::ObjectId.new
         end
 
-        it "returns the object id" do
+        it 'returns the object id' do
           expect(constrainable.convert_to_foreign_key(object)).to eq(object)
         end
       end
 
-      context "when provided a string" do
-
+      context 'when provided a string' do
         let(:object) do
           BSON::ObjectId.new
         end
 
-        it "returns an object id from the string" do
+        it 'returns an object id from the string' do
           expect(constrainable.convert_to_foreign_key(object.to_s)).to eq(object)
         end
       end
     end
 
     context "when the id's class does not store object ids" do
-
       let(:constrainable) do
         Alert.belongs_to :account
       end
 
-      it "returns the object" do
-        expect(constrainable.convert_to_foreign_key("testing")).to eq("testing")
+      it 'returns the object' do
+        expect(constrainable.convert_to_foreign_key('testing')).to eq('testing')
       end
     end
 
     context 'when the association is polymorphic' do
-
       let(:constrainable) do
         Post.relations['posteable']
       end
@@ -68,7 +60,6 @@ describe Mongoid::Association::Constrainable do
       end
 
       context 'when a BSON::ObjectId is passed' do
-
         let(:object) do
           BSON::ObjectId.new
         end
@@ -79,9 +70,7 @@ describe Mongoid::Association::Constrainable do
       end
 
       context 'when a string is passed' do
-
         context 'when the string represents an ObjectId' do
-
           let(:object) do
             BSON::ObjectId.new.to_s
           end
@@ -92,7 +81,6 @@ describe Mongoid::Association::Constrainable do
         end
 
         context 'when the string does not represent an ObjectId' do
-
           let(:object) do
             'some-other-string'
           end
@@ -104,7 +92,6 @@ describe Mongoid::Association::Constrainable do
       end
 
       context 'when a model object is passed' do
-
         let(:object) do
           Post.new
         end