mongoid 9.0.11 → 9.1.0

data/spec/mongoid/association/embedded/embedded_in_spec.rb

@@ -1,11 +1,9 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
-require "spec_helper"
-require_relative './embeds_one_models'
+require 'spec_helper'
+require_relative 'embeds_one_models'
 
 describe Mongoid::Association::Embedded::EmbeddedIn do
-
   before do
     class Container; include Mongoid::Document; end
     class EmbeddedObject; include Mongoid::Document; end
@@ -29,11 +27,10 @@ describe Mongoid::Association::Embedded::EmbeddedIn do
   end
 
   let(:options) do
-    { }
+    {}
   end
 
   describe '#VALID_OPTIONS' do
-
     it 'returns the SHARED options with the ASSOCIATION_OPTIONS' do
       expect(association.class::VALID_OPTIONS).to match_array(Mongoid::Association::Relatable::SHARED_OPTIONS +
                                                               association.class::ASSOCIATION_OPTIONS)
@@ -41,7 +38,6 @@ describe Mongoid::Association::Embedded::EmbeddedIn do
   end
 
   describe '#relation_complements' do
-
     let(:expected_complements) do
       [
         Mongoid::Association::Embedded::EmbedsMany,
@@ -55,7 +51,6 @@ describe Mongoid::Association::Embedded::EmbeddedIn do
   end
 
   describe '#setup_instance_methods!' do
-
     it 'sets up a getter for the relation' do
       expect(Mongoid::Association::Accessors).to receive(:define_getter!).with(association)
       association.send(:setup_instance_methods!)
@@ -73,9 +68,7 @@ describe Mongoid::Association::Embedded::EmbeddedIn do
   end
 
   describe '#inverse_type_setter' do
-
     context 'when polymorphic' do
-
       let(:options) do
         { polymorphic: true }
       end
@@ -86,7 +79,6 @@ describe Mongoid::Association::Embedded::EmbeddedIn do
     end
 
     context 'when not polymorphic' do
-
       it 'returns nil' do
         expect(association.inverse_type).to be_nil
       end
@@ -94,44 +86,37 @@ describe Mongoid::Association::Embedded::EmbeddedIn do
   end
 
   describe '#embedded?' do
-
     it 'returns true' do
       expect(association.embedded?).to be(true)
     end
   end
 
   describe '#relation' do
-
     it 'returns Mongoid::Association::Embedded::EmbeddedIn::Proxy' do
       expect(association.relation).to be(Mongoid::Association::Embedded::EmbeddedIn::Proxy)
     end
   end
 
   describe '#validation_default' do
-
     it 'returns false' do
       expect(association.validation_default).to be(false)
     end
   end
 
   describe '#name' do
-
     it 'returns the name of the relation' do
       expect(association.name).to be(name)
     end
   end
 
   describe '#options' do
-
     it 'returns the options' do
       expect(association.options).to be(options)
     end
   end
 
   describe '#cyclic?' do
-
     context 'when :cyclic is specified in the options' do
-
       let(:options) do
         { cyclic: true }
       end
@@ -142,7 +127,6 @@ describe Mongoid::Association::Embedded::EmbeddedIn do
     end
 
     context 'when :cyclic is not specified in the options' do
-
       it 'returns false' do
         expect(association.cyclic?).to be(false)
       end
@@ -150,12 +134,9 @@ describe Mongoid::Association::Embedded::EmbeddedIn do
   end
 
   describe '#merge!' do
-
   end
 
-
   describe '#touchable?' do
-
     context 'when :touch is in the options' do
       shared_examples_for ':touch is in the options' do
         it 'returns the value in the options' do
@@ -165,17 +146,18 @@ describe Mongoid::Association::Embedded::EmbeddedIn do
 
       context 'when the option is true' do
         let(:options) { { touch: true } }
+
         it_behaves_like ':touch is in the options'
       end
 
       context 'when the option is false' do
         let(:options) { { touch: false } }
+
         it_behaves_like ':touch is in the options'
       end
     end
 
     context 'when :touch is not in the options' do
-
       it 'return the default value' do
         expect(association.send(:touchable?)).to be(true)
       end
@@ -183,9 +165,7 @@ describe Mongoid::Association::Embedded::EmbeddedIn do
   end
 
   describe '#polymorphic?' do
-
     context 'when :polymorphic is specified in the options as true' do
-
       let(:options) do
         { polymorphic: true }
       end
@@ -196,7 +176,6 @@ describe Mongoid::Association::Embedded::EmbeddedIn do
     end
 
     context 'when :polymorphic is specified in the options as false' do
-
       let(:options) do
         { polymorphic: false }
       end
@@ -207,7 +186,6 @@ describe Mongoid::Association::Embedded::EmbeddedIn do
     end
 
     context 'when :polymorphic is not specified in the options' do
-
       it 'returns false' do
         expect(association.polymorphic?).to be(false)
       end
@@ -215,16 +193,13 @@ describe Mongoid::Association::Embedded::EmbeddedIn do
   end
 
   describe '#bindable?' do
-
     it 'returns false' do
       expect(association.bindable?(Person.new)).to be(false)
     end
   end
 
   describe '#inverses' do
-
     context 'when polymorphic' do
-
       let(:options) do
         {
           polymorphic: true
@@ -236,19 +211,16 @@ describe Mongoid::Association::Embedded::EmbeddedIn do
       end
 
       context 'when another object is passed to the method' do
-
         let(:instance_of_other_class) do
           Container.new
         end
 
         context 'when the relation class has only one relation whose class matches the owning class' do
-
           before do
             Container.embeds_many :embedded_objects, as: :containable
           end
 
           context 'when :inverse_of is specified' do
-
             before do
               options.merge!(inverse_of: :inverse_name)
             end
@@ -259,34 +231,30 @@ describe Mongoid::Association::Embedded::EmbeddedIn do
           end
 
           context 'when inverse_of is not specified' do
-
             it 'returns the list of relations whose :as attribute matches the name of this association' do
-              expect(association.inverses(instance_of_other_class)).to match_array([ :embedded_objects ])
+              expect(association.inverses(instance_of_other_class)).to contain_exactly(:embedded_objects)
             end
 
             context 'when the relation class has two associations with the same name' do
-
               before do
                 Container.embeds_many :embedded_objects, as: :containable
                 Container.embeds_many :other_embedded_objects, as: :containable
               end
 
               it 'returns only the relations whose :as attribute and class match' do
-                expect(association.inverses(instance_of_other_class)).to match_array([ :embedded_objects ])
+                expect(association.inverses(instance_of_other_class)).to contain_exactly(:embedded_objects)
               end
             end
           end
         end
 
         context 'when the relation class has more than one relation whose class matches the owning class' do
-
           before do
             Container.embeds_many :embedded_objects, as: :containable
             Container.embeds_one :other_embedded_object, as: :containable, class_name: 'EmbeddedObject'
           end
 
           context 'when :inverse_of is specified' do
-
             before do
               options.merge!(inverse_of: :inverse_name)
             end
@@ -297,19 +265,16 @@ describe Mongoid::Association::Embedded::EmbeddedIn do
           end
 
           context 'when inverse_of is not specified' do
-
             it 'returns the list of relations whose :as attribute matches the name of this association' do
-              expect(association.inverses(instance_of_other_class)).to match_array([ :embedded_objects,
-                                                                                     :other_embedded_object ])
+              expect(association.inverses(instance_of_other_class)).to match_array(%i[embedded_objects
+                                                                                      other_embedded_object])
             end
           end
         end
       end
 
       context 'when another object is not passed to the method' do
-
         context 'when inverse_of is specified' do
-
           before do
             options.merge!(inverse_of: :inverse_name)
           end
@@ -320,7 +285,6 @@ describe Mongoid::Association::Embedded::EmbeddedIn do
         end
 
         context 'when inverse_of is not specified' do
-
           it 'returns nil' do
             expect(association.inverses).to eq(nil)
           end
@@ -332,7 +296,7 @@ describe Mongoid::Association::Embedded::EmbeddedIn do
 
             it 'returns the inverse in an array' do
               inverses = association.inverses
-              expect(inverses).to eq([:parent])
+              expect(inverses).to eq([ :parent ])
             end
           end
 
@@ -345,7 +309,7 @@ describe Mongoid::Association::Embedded::EmbeddedIn do
               pending 'MONGOID-4751'
 
               inverses = association.inverses
-              expect(inverses).to eq([:child])
+              expect(inverses).to eq([ :child ])
             end
 
             context 'when other associations referencing unloaded classes exist' do
@@ -355,7 +319,7 @@ describe Mongoid::Association::Embedded::EmbeddedIn do
 
               it 'does not load other classes' do
                 inverses = association.inverses
-                expect(inverses).to eq([:child])
+                expect(inverses).to eq([ :child ])
                 expect(Object.const_defined?(:EoDnlMarker)).to be false
               end
             end
@@ -365,9 +329,7 @@ describe Mongoid::Association::Embedded::EmbeddedIn do
     end
 
     context 'when not polymorphic' do
-
       context 'when inverse_of is specified' do
-
         before do
           options.merge!(inverse_of: :inverse_name)
         end
@@ -378,7 +340,6 @@ describe Mongoid::Association::Embedded::EmbeddedIn do
       end
 
       context 'when inverse_of is not specified' do
-
         before do
           Container.embeds_many :embedded_objects
         end
@@ -389,28 +350,24 @@ describe Mongoid::Association::Embedded::EmbeddedIn do
       end
 
       context 'when :cyclic is specified' do
-
         it 'returns the cyclic inverse name' do
-
         end
       end
 
       context 'when the inverse class has more than one relation with objects of the owner class' do
-
         before do
           Container.embeds_many :embedded_objects
           Container.embeds_many :other_embedded_objects, class_name: 'EmbeddedObject'
         end
 
         it 'raises a Mongoid::Errors::AmbiguousRelationship exception' do
-          expect {
+          expect do
             association.inverses
-          }.to raise_exception(Mongoid::Errors::AmbiguousRelationship)
+          end.to raise_exception(Mongoid::Errors::AmbiguousRelationship)
         end
       end
 
       context 'when the inverse class only has one relation with objects of the owner class' do
-
         before do
           Container.embeds_many :embedded_objects
         end
@@ -423,9 +380,7 @@ describe Mongoid::Association::Embedded::EmbeddedIn do
   end
 
   describe '#inverse' do
-
     context 'when polymorphic' do
-
       let(:options) do
         {
           polymorphic: true
@@ -437,19 +392,16 @@ describe Mongoid::Association::Embedded::EmbeddedIn do
       end
 
       context 'when another object is passed to the method' do
-
         let(:instance_of_other_class) do
           Container.new
         end
 
         context 'when the relation class has only one relation whose class matches the owning class' do
-
           before do
             Container.embeds_many :embedded_objects, as: :containable
           end
 
           context 'when :inverse_of is specified' do
-
             before do
               options.merge!(inverse_of: :inverse_name)
             end
@@ -460,7 +412,6 @@ describe Mongoid::Association::Embedded::EmbeddedIn do
           end
 
           context 'when inverse_of is not specified' do
-
             it 'returns the list of relations whose :as attribute matches the name of this association' do
               expect(association.inverse(instance_of_other_class)).to eq(:embedded_objects)
             end
@@ -468,14 +419,12 @@ describe Mongoid::Association::Embedded::EmbeddedIn do
         end
 
         context 'when the relation class has more than one relation whose class matches the owning class' do
-
           before do
             Container.embeds_many :embedded_objects, as: :containable
             Container.embeds_one :other_embedded_object, as: :containable
           end
 
           context 'when :inverse_of is specified' do
-
             before do
               options.merge!(inverse_of: :inverse_name)
             end
@@ -486,7 +435,6 @@ describe Mongoid::Association::Embedded::EmbeddedIn do
           end
 
           context 'when inverse_of is not specified' do
-
             it 'returns the first candidate whose :as attribute matches the name of this association' do
               expect(association.inverse(instance_of_other_class)).to eq(:embedded_objects)
             end
@@ -495,9 +443,7 @@ describe Mongoid::Association::Embedded::EmbeddedIn do
       end
 
       context 'when another object is not passed to the method' do
-
         context 'when inverse_of is specified' do
-
           before do
             options.merge!(inverse_of: :inverse_name)
           end
@@ -508,7 +454,6 @@ describe Mongoid::Association::Embedded::EmbeddedIn do
         end
 
         context 'when inverse_of is not specified' do
-
           it 'returns nil' do
             expect(association.inverse).to eq(nil)
           end
@@ -517,9 +462,7 @@ describe Mongoid::Association::Embedded::EmbeddedIn do
     end
 
     context 'when not polymorphic' do
-
       context 'when inverse_of is specified' do
-
         before do
           options.merge!(inverse_of: :inverse_name)
         end
@@ -530,7 +473,6 @@ describe Mongoid::Association::Embedded::EmbeddedIn do
       end
 
       context 'when inverse_of is not specified' do
-
         before do
           Container.embeds_many :embedded_objects
         end
@@ -541,28 +483,24 @@ describe Mongoid::Association::Embedded::EmbeddedIn do
       end
 
       context 'when :cyclic is specified' do
-
         it 'returns the cyclic inverse name' do
-
         end
       end
 
       context 'when the inverse class has more than one relation with objects of the owner class' do
-
         before do
           Container.embeds_many :embedded_objects
           Container.embeds_many :other_embedded_objects, class_name: 'EmbeddedObject'
         end
 
         it 'raises a Mongoid::Errors::AmbiguousRelationship exception' do
-          expect {
+          expect do
             association.inverse
-          }.to raise_exception(Mongoid::Errors::AmbiguousRelationship)
+          end.to raise_exception(Mongoid::Errors::AmbiguousRelationship)
         end
       end
 
       context 'when the inverse class only has one relation with objects of the owner class' do
-
         before do
           Container.embeds_many :embedded_objects
         end
@@ -575,20 +513,16 @@ describe Mongoid::Association::Embedded::EmbeddedIn do
   end
 
   describe '#inverse_association' do
-
   end
 
   describe '#autosave' do
-
     it 'returns false' do
       expect(association.autosave).to be(false)
     end
   end
 
   describe '#relation_class_name' do
-
     context 'when the :class_name option is specified' do
-
       let(:options) do
         # `touch: true` is the default (see MONGOID-5016), which means by
         # default, callbacks are added to the referenced class. In this case,
@@ -613,7 +547,6 @@ describe Mongoid::Association::Embedded::EmbeddedIn do
     end
 
     context 'when the class_name option is not specified' do
-
       it 'uses the name of the relation to deduce the class name' do
         expect(association.relation_class_name).to eq('Container')
       end
@@ -632,9 +565,7 @@ describe Mongoid::Association::Embedded::EmbeddedIn do
   end
 
   describe '#klass' do
-
     context 'when the :class_name option is specified' do
-
       let!(:_class) do
         class OtherContainer; end
         OtherContainer
@@ -650,7 +581,6 @@ describe Mongoid::Association::Embedded::EmbeddedIn do
     end
 
     context 'when the class_name option is not specified' do
-
       it 'uses the name of the relation to deduce the class name' do
         expect(association.klass).to eq(Container)
       end
@@ -658,23 +588,19 @@ describe Mongoid::Association::Embedded::EmbeddedIn do
   end
 
   describe '#inverse_class_name' do
-
     it 'returns the name of the owner class' do
       expect(association.inverse_class_name).to eq(embedded_class.name)
     end
   end
 
   describe '#inverse_class' do
-
     it 'returns the owner class' do
       expect(association.inverse_class).to be(embedded_class)
     end
   end
 
   describe '#inverse_of' do
-
     context 'when :inverse_of is specified in the options' do
-
       let(:options) do
         { inverse_of: :a_container }
       end
@@ -685,7 +611,6 @@ describe Mongoid::Association::Embedded::EmbeddedIn do
     end
 
     context 'when :inverse_of is not specified in the options' do
-
       it 'returns nil' do
         expect(association.inverse_of).to be_nil
       end
@@ -693,25 +618,20 @@ describe Mongoid::Association::Embedded::EmbeddedIn do
   end
 
   describe '#key' do
-
     it 'returns the name of the relation as a string' do
       expect(association.key).to eq(name.to_s)
     end
   end
 
   describe '#setter' do
-
     it 'returns a string of the name followed by =' do
       expect(association.setter).to eq("#{name}=")
     end
   end
 
   describe '#validate?' do
-
     context 'when :validate is specified in the options' do
-
       context 'when validate is true' do
-
         let(:options) do
           { validate: true }
         end
@@ -722,7 +642,6 @@ describe Mongoid::Association::Embedded::EmbeddedIn do
       end
 
       context 'when validate is false' do
-
         let(:options) do
           { validate: false }
         end
@@ -734,7 +653,6 @@ describe Mongoid::Association::Embedded::EmbeddedIn do
     end
 
     context 'when :validate is not specified in the options' do
-
       it 'returns the validation_default' do
         expect(association.send(:validate?)).to eq(association.validation_default)
       end
@@ -742,11 +660,8 @@ describe Mongoid::Association::Embedded::EmbeddedIn do
   end
 
   describe '#autobuilding?' do
-
     context 'when :autobuild is specified in the options' do
-
       context 'when autobuild is true' do
-
         let(:options) do
           { autobuild: true }
         end
@@ -757,7 +672,6 @@ describe Mongoid::Association::Embedded::EmbeddedIn do
       end
 
       context 'when autobuild is false' do
-
         let(:options) do
           { autobuild: false }
         end
@@ -769,7 +683,6 @@ describe Mongoid::Association::Embedded::EmbeddedIn do
     end
 
     context 'when :validate is not specified in the options' do
-
       it 'returns false' do
         expect(association.autobuilding?).to be(false)
       end
@@ -777,23 +690,19 @@ describe Mongoid::Association::Embedded::EmbeddedIn do
   end
 
   describe '#forced_nil_inverse?' do
-
     it 'returns false' do
       expect(association.forced_nil_inverse?).to be(false)
     end
   end
 
   describe '#stores_foreign_key?' do
-
     it 'returns false' do
       expect(association.stores_foreign_key?).to be(false)
     end
   end
 
   describe '#inverse_setter' do
-
     context 'when an inverse can be determined' do
-
       before do
         Container.embeds_many :embedded_objects
       end
@@ -804,7 +713,6 @@ describe Mongoid::Association::Embedded::EmbeddedIn do
     end
 
     context 'when an inverse cannot be determined' do
-
       it 'returns nil' do
         expect(association.inverse_setter).to be_nil
       end
@@ -812,11 +720,10 @@ describe Mongoid::Association::Embedded::EmbeddedIn do
   end
 
   describe '#extension' do
-
     context 'when a block is passed' do
-
       let(:association) do
-        embedded_class.embedded_in name, options do; end
+        embedded_class.embedded_in name, options do
+        end
       end
 
       it 'defines an extension module' do
@@ -825,12 +732,12 @@ describe Mongoid::Association::Embedded::EmbeddedIn do
 
       it 'returns the extension' do
         expect(association.extension).to eq(
-          "#{embedded_class.name}::#{embedded_class.name}#{name.capitalize}RelationExtension".constantize)
+          "#{embedded_class.name}::#{embedded_class.name}#{name.capitalize}RelationExtension".constantize
+        )
       end
     end
 
     context 'when an :extension is not specified in the options' do
-
       it 'returns false' do
         expect(association.extension).to be_nil
       end
@@ -838,45 +745,39 @@ describe Mongoid::Association::Embedded::EmbeddedIn do
   end
 
   describe '#criteria' do
-
     it 'does not respond to the method' do
-      expect {
+      expect do
         association.criteria
-      }.to raise_exception(NoMethodError)
+      end.to raise_exception(NoMethodError)
     end
   end
 
   describe '#destructive?' do
-
     it 'returns false' do
       expect(association.destructive?).to be(false)
     end
   end
 
   describe '#nested_builder' do
-
     it 'returns an instance of Association::Nested::One' do
       expect(association.nested_builder({}, {})).to be_a(Mongoid::Association::Nested::One)
     end
   end
 
   describe '#cascading_callbacks?' do
-
     context 'when cascade_callbacks is specified in the options' do
-
       let(:options) do
-        {cascade_callbacks: true}
+        { cascade_callbacks: true }
       end
 
       it 'raises a Mongoid::Errors::InvalidRelationOption exception' do
-        expect {
+        expect do
           association.cascading_callbacks?
-        }.to raise_exception(Mongoid::Errors::InvalidRelationOption)
+        end.to raise_exception(Mongoid::Errors::InvalidRelationOption)
       end
     end
 
     context 'when cascade_callbacks is not specified in the options' do
-
       it 'returns false' do
         expect(association.cascading_callbacks?).to be(false)
       end
@@ -884,21 +785,18 @@ describe Mongoid::Association::Embedded::EmbeddedIn do
   end
 
   describe '#path' do
-
     it 'returns an instance of Mongoid::Atomic::Paths::Root' do
       expect(association.path({})).to be_a(Mongoid::Atomic::Paths::Root)
     end
   end
 
   describe '#foreign_key_check' do
-
     it 'returns nil' do
       expect(association.foreign_key_check).to be_nil
     end
   end
 
   describe '#create_relation' do
-
     let(:owner) do
       Container.new
     end