takomi 2.1.45 → 2.5.4

package/assets/.agent/skills/remotion-to-hyperframes/assets/test-corpus/tier-4-escape-hatch/cases/08-mixed.tsx

@@ -1,41 +1,41 @@
-// T4 case 08 — Multiple blockers + multiple warnings in one file.
-//
-// Should report:
-//   blockers: r2hf/use-state, r2hf/use-effect-deps, r2hf/third-party-react-ui
-//   warnings: r2hf/use-callback (also r2hf/delay-render via the import chain
-//             would only fire if delayRender is actually called)
-//
-// Tests that the linter aggregates findings correctly and does not stop at
-// the first blocker.
-
-import React, { useState, useEffect, useCallback } from "react";
-import { AbsoluteFill, useCurrentFrame } from "remotion";
-import { Card } from "@chakra-ui/react";
-
-interface Item {
-  id: string;
-  label: string;
-}
-
-export const MixedBlockers: React.FC = () => {
-  const frame = useCurrentFrame();
-  const [items, setItems] = useState<Item[]>([]);
-
-  useEffect(() => {
-    fetch("/api/items")
-      .then((r) => r.json())
-      .then(setItems);
-  }, [frame]);
-
-  const onClick = useCallback(() => {
-    setItems((prev) => [...prev, { id: String(prev.length), label: "new" }]);
-  }, []);
-
-  return (
-    <AbsoluteFill onClick={onClick}>
-      {items.map((item) => (
-        <Card key={item.id}>{item.label}</Card>
-      ))}
-    </AbsoluteFill>
-  );
-};
+// T4 case 08 — Multiple blockers + multiple warnings in one file.
+//
+// Should report:
+//   blockers: r2hf/use-state, r2hf/use-effect-deps, r2hf/third-party-react-ui
+//   warnings: r2hf/use-callback (also r2hf/delay-render via the import chain
+//             would only fire if delayRender is actually called)
+//
+// Tests that the linter aggregates findings correctly and does not stop at
+// the first blocker.
+
+import React, { useState, useEffect, useCallback } from "react";
+import { AbsoluteFill, useCurrentFrame } from "remotion";
+import { Card } from "@chakra-ui/react";
+
+interface Item {
+  id: string;
+  label: string;
+}
+
+export const MixedBlockers: React.FC = () => {
+  const frame = useCurrentFrame();
+  const [items, setItems] = useState<Item[]>([]);
+
+  useEffect(() => {
+    fetch("/api/items")
+      .then((r) => r.json())
+      .then(setItems);
+  }, [frame]);
+
+  const onClick = useCallback(() => {
+    setItems((prev) => [...prev, { id: String(prev.length), label: "new" }]);
+  }, []);
+
+  return (
+    <AbsoluteFill onClick={onClick}>
+      {items.map((item) => (
+        <Card key={item.id}>{item.label}</Card>
+      ))}
+    </AbsoluteFill>
+  );
+};

package/assets/.agent/skills/remotion-to-hyperframes/assets/test-corpus/tier-4-escape-hatch/expected.json

@@ -1,85 +1,85 @@
-{
-  "tier": 4,
-  "name": "escape-hatch",
-  "description": "Lint-only fixture set. Each case demonstrates a Remotion pattern the skill cannot or should not translate cleanly. The skill is graded on whether lint_source.py emits the right finding for each case — there are no renders to compare. T4 passes when every case triggers its expected rule and no others.",
-  "cases": [
-    {
-      "file": "01-use-state.tsx",
-      "expected": {
-        "blockers": [{ "rule": "r2hf/use-state", "min_count": 1 }],
-        "warnings": [],
-        "skill_action": "refuse_translation_recommend_interop"
-      }
-    },
-    {
-      "file": "02-use-effect-deps.tsx",
-      "expected": {
-        "blockers": [{ "rule": "r2hf/use-effect-deps", "min_count": 1 }],
-        "warnings": [],
-        "skill_action": "refuse_translation_recommend_interop"
-      }
-    },
-    {
-      "file": "03-async-metadata.tsx",
-      "expected": {
-        "blockers": [{ "rule": "r2hf/async-metadata", "min_count": 1 }],
-        "warnings": [],
-        "skill_action": "refuse_translation_recommend_interop"
-      }
-    },
-    {
-      "file": "04-third-party-react.tsx",
-      "expected": {
-        "blockers": [{ "rule": "r2hf/third-party-react-ui", "min_count": 1 }],
-        "warnings": [],
-        "skill_action": "refuse_translation_recommend_interop"
-      }
-    },
-    {
-      "file": "05-lambda-config.tsx",
-      "expected": {
-        "blockers": [],
-        "warnings": [{ "rule": "r2hf/lambda-import", "min_count": 1 }],
-        "skill_action": "drop_lambda_code_translate_remainder_if_clean"
-      }
-    },
-    {
-      "file": "06-warnings-only.tsx",
-      "expected": {
-        "blockers": [],
-        "warnings": [
-          { "rule": "r2hf/delay-render", "min_count": 1 },
-          { "rule": "r2hf/use-callback", "min_count": 1 },
-          { "rule": "r2hf/use-memo", "min_count": 1 }
-        ],
-        "skill_action": "translate_after_dropping_wrappers"
-      }
-    },
-    {
-      "file": "07-custom-hook.tsx",
-      "expected": {
-        "blockers": [],
-        "warnings": [{ "rule": "r2hf/custom-hook", "min_count": 1 }],
-        "skill_action": "inline_hook_body_if_pure"
-      }
-    },
-    {
-      "file": "08-mixed.tsx",
-      "expected": {
-        "blockers": [
-          { "rule": "r2hf/use-state", "min_count": 1 },
-          { "rule": "r2hf/use-effect-deps", "min_count": 1 },
-          { "rule": "r2hf/third-party-react-ui", "min_count": 1 }
-        ],
-        "warnings": [{ "rule": "r2hf/use-callback", "min_count": 1 }],
-        "skill_action": "refuse_translation_recommend_interop"
-      }
-    }
-  ],
-  "totals": {
-    "expected_blocker_cases": 5,
-    "expected_warning_only_cases": 3,
-    "expected_total_blocker_findings_min": 7,
-    "expected_total_warning_findings_min": 6
-  }
-}
+{
+  "tier": 4,
+  "name": "escape-hatch",
+  "description": "Lint-only fixture set. Each case demonstrates a Remotion pattern the skill cannot or should not translate cleanly. The skill is graded on whether lint_source.py emits the right finding for each case — there are no renders to compare. T4 passes when every case triggers its expected rule and no others.",
+  "cases": [
+    {
+      "file": "01-use-state.tsx",
+      "expected": {
+        "blockers": [{ "rule": "r2hf/use-state", "min_count": 1 }],
+        "warnings": [],
+        "skill_action": "refuse_translation_recommend_interop"
+      }
+    },
+    {
+      "file": "02-use-effect-deps.tsx",
+      "expected": {
+        "blockers": [{ "rule": "r2hf/use-effect-deps", "min_count": 1 }],
+        "warnings": [],
+        "skill_action": "refuse_translation_recommend_interop"
+      }
+    },
+    {
+      "file": "03-async-metadata.tsx",
+      "expected": {
+        "blockers": [{ "rule": "r2hf/async-metadata", "min_count": 1 }],
+        "warnings": [],
+        "skill_action": "refuse_translation_recommend_interop"
+      }
+    },
+    {
+      "file": "04-third-party-react.tsx",
+      "expected": {
+        "blockers": [{ "rule": "r2hf/third-party-react-ui", "min_count": 1 }],
+        "warnings": [],
+        "skill_action": "refuse_translation_recommend_interop"
+      }
+    },
+    {
+      "file": "05-lambda-config.tsx",
+      "expected": {
+        "blockers": [],
+        "warnings": [{ "rule": "r2hf/lambda-import", "min_count": 1 }],
+        "skill_action": "drop_lambda_code_translate_remainder_if_clean"
+      }
+    },
+    {
+      "file": "06-warnings-only.tsx",
+      "expected": {
+        "blockers": [],
+        "warnings": [
+          { "rule": "r2hf/delay-render", "min_count": 1 },
+          { "rule": "r2hf/use-callback", "min_count": 1 },
+          { "rule": "r2hf/use-memo", "min_count": 1 }
+        ],
+        "skill_action": "translate_after_dropping_wrappers"
+      }
+    },
+    {
+      "file": "07-custom-hook.tsx",
+      "expected": {
+        "blockers": [],
+        "warnings": [{ "rule": "r2hf/custom-hook", "min_count": 1 }],
+        "skill_action": "inline_hook_body_if_pure"
+      }
+    },
+    {
+      "file": "08-mixed.tsx",
+      "expected": {
+        "blockers": [
+          { "rule": "r2hf/use-state", "min_count": 1 },
+          { "rule": "r2hf/use-effect-deps", "min_count": 1 },
+          { "rule": "r2hf/third-party-react-ui", "min_count": 1 }
+        ],
+        "warnings": [{ "rule": "r2hf/use-callback", "min_count": 1 }],
+        "skill_action": "refuse_translation_recommend_interop"
+      }
+    }
+  ],
+  "totals": {
+    "expected_blocker_cases": 5,
+    "expected_warning_only_cases": 3,
+    "expected_total_blocker_findings_min": 7,
+    "expected_total_warning_findings_min": 6
+  }
+}

package/assets/.agent/skills/remotion-to-hyperframes/assets/test-corpus/tier-4-escape-hatch/validate.sh

@@ -1,110 +1,110 @@
-#!/usr/bin/env bash
-# validate.sh — assert lint_source.py output matches expected.json for every T4 case.
-#
-# T4 has no renders to diff. The skill is graded on whether it correctly
-# refuses to translate each case (or drops only the lambda config in case 5,
-# or warns appropriately in cases 6 and 7).
-#
-# Usage:
-#   ./validate.sh
-# Exit 0 on pass.
-
-set -euo pipefail
-
-THIS_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
-SCRIPTS_DIR="$(cd "$THIS_DIR/../../../scripts" && pwd)"
-EXPECTED="$THIS_DIR/expected.json"
-
-if [[ ! -f "$SCRIPTS_DIR/lint_source.py" ]]; then
-  echo "error: lint_source.py not found at $SCRIPTS_DIR/lint_source.py" >&2
-  exit 2
-fi
-if [[ ! -f "$EXPECTED" ]]; then
-  echo "error: expected.json not found at $EXPECTED" >&2
-  exit 2
-fi
-
-# Drive lint_file() in-process so the per-case overhead is one Python startup,
-# not N (8 cases × ~80 ms forking python3 was the dominant cost).
-SCRIPTS_DIR="$SCRIPTS_DIR" \
-THIS_DIR="$THIS_DIR" \
-EXPECTED="$EXPECTED" \
-python3 <<'PY'
-import json
-import os
-import sys
-from collections import Counter
-from pathlib import Path
-
-scripts_dir = Path(os.environ["SCRIPTS_DIR"])
-this_dir = Path(os.environ["THIS_DIR"])
-expected_path = Path(os.environ["EXPECTED"])
-cases_dir = this_dir / "cases"
-
-sys.path.insert(0, str(scripts_dir))
-from lint_source import BLOCKER, WARNING, lint_file  # noqa: E402
-
-expected = json.loads(expected_path.read_text())
-
-fails: list[str] = []
-passes: list[str] = []
-
-for case in expected["cases"]:
-    file_name = case["file"]
-    fixture = cases_dir / file_name
-    if not fixture.exists():
-        fails.append(f"{file_name}: fixture missing at {fixture}")
-        continue
-
-    findings = lint_file(fixture)
-    rule_counts: Counter[str] = Counter()
-    severity_by_rule: dict[str, str] = {}
-    for f in findings:
-        rule_counts[f.rule] += 1
-        severity_by_rule[f.rule] = f.severity
-
-    case_failed = False
-
-    def assert_rule(expected_entry, expected_severity_floor, kind):
-        global case_failed
-        rule = expected_entry["rule"]
-        min_count = expected_entry["min_count"]
-        actual = rule_counts[rule]
-        actual_severity = severity_by_rule.get(rule)
-        if actual < min_count:
-            fails.append(f"{file_name}: expected >={min_count} {kind} findings of rule {rule}, got {actual}")
-            case_failed = True
-        elif actual_severity not in expected_severity_floor:
-            fails.append(
-                f"{file_name}: rule {rule} found but severity={actual_severity!r} (expected {kind})"
-            )
-            case_failed = True
-
-    for entry in case["expected"]["blockers"]:
-        assert_rule(entry, {BLOCKER}, "blocker")
-    for entry in case["expected"]["warnings"]:
-        assert_rule(entry, {WARNING, BLOCKER}, "warning")
-
-    # Implied lint exit code: 1 when blockers are expected, 0 otherwise.
-    has_blockers = any(f.severity == BLOCKER for f in findings)
-    expected_has_blockers = bool(case["expected"]["blockers"])
-    if has_blockers != expected_has_blockers:
-        fails.append(
-            f"{file_name}: implied lint exit {1 if has_blockers else 0}, "
-            f"expected {1 if expected_has_blockers else 0} (blockers expected: {expected_has_blockers})"
-        )
-        case_failed = True
-
-    if not case_failed:
-        passes.append(file_name)
-
-print(f"Passed: {len(passes)}")
-for name in passes:
-    print(f"  ✓ {name}")
-if fails:
-    print(f"Failed: {len(fails)}")
-    for msg in fails:
-        print(f"  ✗ {msg}")
-    sys.exit(1)
-sys.exit(0)
-PY
+#!/usr/bin/env bash
+# validate.sh — assert lint_source.py output matches expected.json for every T4 case.
+#
+# T4 has no renders to diff. The skill is graded on whether it correctly
+# refuses to translate each case (or drops only the lambda config in case 5,
+# or warns appropriately in cases 6 and 7).
+#
+# Usage:
+#   ./validate.sh
+# Exit 0 on pass.
+
+set -euo pipefail
+
+THIS_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+SCRIPTS_DIR="$(cd "$THIS_DIR/../../../scripts" && pwd)"
+EXPECTED="$THIS_DIR/expected.json"
+
+if [[ ! -f "$SCRIPTS_DIR/lint_source.py" ]]; then
+  echo "error: lint_source.py not found at $SCRIPTS_DIR/lint_source.py" >&2
+  exit 2
+fi
+if [[ ! -f "$EXPECTED" ]]; then
+  echo "error: expected.json not found at $EXPECTED" >&2
+  exit 2
+fi
+
+# Drive lint_file() in-process so the per-case overhead is one Python startup,
+# not N (8 cases × ~80 ms forking python3 was the dominant cost).
+SCRIPTS_DIR="$SCRIPTS_DIR" \
+THIS_DIR="$THIS_DIR" \
+EXPECTED="$EXPECTED" \
+python3 <<'PY'
+import json
+import os
+import sys
+from collections import Counter
+from pathlib import Path
+
+scripts_dir = Path(os.environ["SCRIPTS_DIR"])
+this_dir = Path(os.environ["THIS_DIR"])
+expected_path = Path(os.environ["EXPECTED"])
+cases_dir = this_dir / "cases"
+
+sys.path.insert(0, str(scripts_dir))
+from lint_source import BLOCKER, WARNING, lint_file  # noqa: E402
+
+expected = json.loads(expected_path.read_text())
+
+fails: list[str] = []
+passes: list[str] = []
+
+for case in expected["cases"]:
+    file_name = case["file"]
+    fixture = cases_dir / file_name
+    if not fixture.exists():
+        fails.append(f"{file_name}: fixture missing at {fixture}")
+        continue
+
+    findings = lint_file(fixture)
+    rule_counts: Counter[str] = Counter()
+    severity_by_rule: dict[str, str] = {}
+    for f in findings:
+        rule_counts[f.rule] += 1
+        severity_by_rule[f.rule] = f.severity
+
+    case_failed = False
+
+    def assert_rule(expected_entry, expected_severity_floor, kind):
+        global case_failed
+        rule = expected_entry["rule"]
+        min_count = expected_entry["min_count"]
+        actual = rule_counts[rule]
+        actual_severity = severity_by_rule.get(rule)
+        if actual < min_count:
+            fails.append(f"{file_name}: expected >={min_count} {kind} findings of rule {rule}, got {actual}")
+            case_failed = True
+        elif actual_severity not in expected_severity_floor:
+            fails.append(
+                f"{file_name}: rule {rule} found but severity={actual_severity!r} (expected {kind})"
+            )
+            case_failed = True
+
+    for entry in case["expected"]["blockers"]:
+        assert_rule(entry, {BLOCKER}, "blocker")
+    for entry in case["expected"]["warnings"]:
+        assert_rule(entry, {WARNING, BLOCKER}, "warning")
+
+    # Implied lint exit code: 1 when blockers are expected, 0 otherwise.
+    has_blockers = any(f.severity == BLOCKER for f in findings)
+    expected_has_blockers = bool(case["expected"]["blockers"])
+    if has_blockers != expected_has_blockers:
+        fails.append(
+            f"{file_name}: implied lint exit {1 if has_blockers else 0}, "
+            f"expected {1 if expected_has_blockers else 0} (blockers expected: {expected_has_blockers})"
+        )
+        case_failed = True
+
+    if not case_failed:
+        passes.append(file_name)
+
+print(f"Passed: {len(passes)}")
+for name in passes:
+    print(f"  ✓ {name}")
+if fails:
+    print(f"Failed: {len(fails)}")
+    for msg in fails:
+        print(f"  ✗ {msg}")
+    sys.exit(1)
+sys.exit(0)
+PY