lighthouse 12.4.0 → 12.5.0-dev.20250325

package/core/audits/insights/use-cache-insight.js

@@ -0,0 +1,61 @@
+/**
+ * @license
+ * Copyright 2025 Google LLC
+ * SPDX-License-Identifier: Apache-2.0
+ */
+
+import {UIStrings} from '@paulirish/trace_engine/models/trace/insights/UseCache.js';
+
+import {Audit} from '../audit.js';
+import * as i18n from '../../lib/i18n/i18n.js';
+import {adaptInsightToAuditProduct} from './insight-audit.js';
+
+// eslint-disable-next-line max-len
+const str_ = i18n.createIcuMessageFn('node_modules/@paulirish/trace_engine/models/trace/insights/UseCache.js', UIStrings);
+
+class UseCacheInsight extends Audit {
+  /**
+   * @return {LH.Audit.Meta}
+   */
+  static get meta() {
+    return {
+      id: 'use-cache-insight',
+      title: str_(UIStrings.title),
+      failureTitle: str_(UIStrings.title),
+      description: str_(UIStrings.description),
+      guidanceLevel: 3,
+      requiredArtifacts: ['traces', 'SourceMaps'],
+      replacesAudits: ['uses-long-cache-ttl'],
+    };
+  }
+
+  /**
+   * @param {LH.Artifacts} artifacts
+   * @param {LH.Audit.Context} context
+   * @return {Promise<LH.Audit.Product>}
+   */
+  static async audit(artifacts, context) {
+    return adaptInsightToAuditProduct(artifacts, context, 'UseCache', (insight) => {
+      /** @type {LH.Audit.Details.Table['headings']} */
+      const headings = [
+        /* eslint-disable max-len */
+        {key: 'url', valueType: 'url', label: str_(UIStrings.requestColumn)},
+        {key: 'cacheLifetimeMs', valueType: 'ms', label: str_(UIStrings.cacheTTL), displayUnit: 'duration'},
+        {key: 'totalBytes', valueType: 'bytes', label: str_(i18n.UIStrings.columnTransferSize), displayUnit: 'kb', granularity: 1},
+        /* eslint-enable max-len */
+      ];
+      /** @type {LH.Audit.Details.Table['items']} */
+      const items = insight.requests.map(request => ({
+        url: request.request.args.data.url,
+        cacheLifetimeMs: request.ttl * 1000,
+        totalBytes: request.request.args.data.encodedDataLength,
+      }));
+      return Audit.makeTableDetails(headings, items, {
+        sortedBy: ['totalBytes'],
+        skipSumming: ['cacheLifetimeMs'],
+      });
+    });
+  }
+}
+
+export default UseCacheInsight;

package/core/audits/insights/viewport-insight.js

@@ -24,7 +24,7 @@ class ViewportInsight extends Audit {
       failureTitle: str_(UIStrings.title),
       description: str_(UIStrings.description),
       guidanceLevel: 3,
-      requiredArtifacts: ['traces', 'TraceElements'],
+      requiredArtifacts: ['traces', 'TraceElements', 'SourceMaps'],
       replacesAudits: ['viewport'],
     };
   }

package/core/audits/largest-contentful-paint-element.js

@@ -50,7 +50,8 @@ class LargestContentfulPaintElement extends Audit {
       guidanceLevel: 1,
       supportedModes: ['navigation'],
       requiredArtifacts:
-        ['traces', 'TraceElements', 'devtoolsLogs', 'GatherContext', 'settings', 'URL'],
+        ['traces', 'TraceElements', 'devtoolsLogs', 'GatherContext', 'settings', 'URL',
+          'SourceMaps'],
     };
   }
 
@@ -122,8 +123,11 @@ class LargestContentfulPaintElement extends Audit {
     const trace = artifacts.traces[Audit.DEFAULT_PASS];
     const devtoolsLog = artifacts.devtoolsLogs[Audit.DEFAULT_PASS];
     const gatherContext = artifacts.GatherContext;
-    const metricComputationData = {trace, devtoolsLog, gatherContext,
-      settings: context.settings, URL: artifacts.URL};
+    const metricComputationData = {
+      trace, devtoolsLog, gatherContext,
+      settings: context.settings, URL: artifacts.URL,
+      SourceMaps: artifacts.SourceMaps, simulator: null,
+    };
 
     const elementTable = this.makeElementTable(artifacts);
     if (!elementTable) {

package/core/audits/layout-shifts.js

@@ -47,7 +47,7 @@ class LayoutShifts extends Audit {
       description: str_(UIStrings.description),
       scoreDisplayMode: Audit.SCORING_MODES.METRIC_SAVINGS,
       guidanceLevel: 2,
-      requiredArtifacts: ['traces', 'TraceElements'],
+      requiredArtifacts: ['traces', 'TraceElements', 'SourceMaps'],
     };
   }
 
@@ -57,8 +57,11 @@ class LayoutShifts extends Audit {
    * @return {Promise<LH.Audit.Product>}
    */
   static async audit(artifacts, context) {
+    const settings = context.settings;
     const trace = artifacts.traces[Audit.DEFAULT_PASS];
-    const traceEngineResult = await TraceEngineResult.request({trace}, context);
+    const SourceMaps = artifacts.SourceMaps;
+    const traceEngineResult =
+      await TraceEngineResult.request({trace, settings, SourceMaps}, context);
     const clusters = traceEngineResult.data.LayoutShifts.clusters ?? [];
     const {cumulativeLayoutShift: clsSavings, impactByNodeId} =
       await CumulativeLayoutShiftComputed.request(trace, context);

package/core/audits/lcp-lazy-loaded.js

@@ -36,7 +36,7 @@ class LargestContentfulPaintLazyLoaded extends Audit {
       scoreDisplayMode: Audit.SCORING_MODES.METRIC_SAVINGS,
       guidanceLevel: 3,
       requiredArtifacts: ['TraceElements', 'ViewportDimensions', 'ImageElements',
-        'traces', 'devtoolsLogs', 'GatherContext', 'URL'],
+        'traces', 'devtoolsLogs', 'GatherContext', 'URL', 'SourceMaps'],
     };
   }
 

package/core/audits/long-tasks.js

@@ -68,7 +68,7 @@ class LongTasks extends Audit {
       scoreDisplayMode: Audit.SCORING_MODES.INFORMATIVE,
       title: str_(UIStrings.title),
       description: str_(UIStrings.description),
-      requiredArtifacts: ['traces', 'devtoolsLogs', 'URL', 'GatherContext'],
+      requiredArtifacts: ['traces', 'devtoolsLogs', 'URL', 'GatherContext', 'SourceMaps'],
       guidanceLevel: 1,
     };
   }
@@ -176,7 +176,7 @@ class LongTasks extends Audit {
    */
   static async audit(artifacts, context) {
     const settings = context.settings || {};
-    const URL = artifacts.URL;
+    const {URL, SourceMaps} = artifacts;
     const trace = artifacts.traces[Audit.DEFAULT_PASS];
     const tasks = await MainThreadTasks.request(trace, context);
     const devtoolsLog = artifacts.devtoolsLogs[LongTasks.DEFAULT_PASS];
@@ -192,9 +192,11 @@ class LongTasks extends Audit {
       taskTimingsByEvent = new Map();
 
       const simulatorOptions = {devtoolsLog, settings: context.settings};
-      const pageGraph = await PageDependencyGraph.request({trace, devtoolsLog, URL}, context);
+      const pageGraph =
+        // eslint-disable-next-line max-len
+        await PageDependencyGraph.request({settings, trace, devtoolsLog, URL, SourceMaps, fromTrace: false}, context);
       const simulator = await LoadSimulator.request(simulatorOptions, context);
-      const simulation = await simulator.simulate(pageGraph, {label: 'long-tasks-diagnostic'});
+      const simulation = simulator.simulate(pageGraph, {label: 'long-tasks-diagnostic'});
       for (const [node, timing] of simulation.nodeTimings.entries()) {
         if (node.type !== 'cpu') continue;
         taskTimingsByEvent.set(node.event, timing);

package/core/audits/mainthread-work-breakdown.js

@@ -46,7 +46,7 @@ class MainThreadWorkBreakdown extends Audit {
       description: str_(UIStrings.description),
       scoreDisplayMode: Audit.SCORING_MODES.METRIC_SAVINGS,
       guidanceLevel: 1,
-      requiredArtifacts: ['traces', 'devtoolsLogs', 'URL', 'GatherContext'],
+      requiredArtifacts: ['traces', 'devtoolsLogs', 'URL', 'GatherContext', 'SourceMaps'],
     };
   }
 

package/core/audits/metrics/first-contentful-paint.js

@@ -27,7 +27,7 @@ class FirstContentfulPaint extends Audit {
       description: str_(UIStrings.description),
       scoreDisplayMode: Audit.SCORING_MODES.NUMERIC,
       supportedModes: ['navigation'],
-      requiredArtifacts: ['traces', 'devtoolsLogs', 'GatherContext', 'URL'],
+      requiredArtifacts: ['traces', 'devtoolsLogs', 'GatherContext', 'URL', 'SourceMaps'],
     };
   }
 
@@ -65,7 +65,9 @@ class FirstContentfulPaint extends Audit {
     const devtoolsLog = artifacts.devtoolsLogs[Audit.DEFAULT_PASS];
     const gatherContext = artifacts.GatherContext;
     const metricComputationData = {trace, devtoolsLog, gatherContext,
-      settings: context.settings, URL: artifacts.URL};
+      settings: context.settings, URL: artifacts.URL,
+      SourceMaps: artifacts.SourceMaps, simulator: null,
+    };
     const metricResult = await ComputedFcp.request(metricComputationData, context);
     const options = context.options[context.settings.formFactor];
 

package/core/audits/metrics/interactive.js

@@ -33,7 +33,7 @@ class InteractiveMetric extends Audit {
       description: str_(UIStrings.description),
       scoreDisplayMode: Audit.SCORING_MODES.NUMERIC,
       supportedModes: ['navigation'],
-      requiredArtifacts: ['traces', 'devtoolsLogs', 'GatherContext', 'URL'],
+      requiredArtifacts: ['traces', 'devtoolsLogs', 'GatherContext', 'URL', 'SourceMaps'],
     };
   }
 
@@ -70,8 +70,11 @@ class InteractiveMetric extends Audit {
     const trace = artifacts.traces[Audit.DEFAULT_PASS];
     const devtoolsLog = artifacts.devtoolsLogs[Audit.DEFAULT_PASS];
     const gatherContext = artifacts.GatherContext;
-    const metricComputationData = {trace, devtoolsLog, gatherContext,
-      settings: context.settings, URL: artifacts.URL};
+    const metricComputationData = {
+      trace, devtoolsLog, gatherContext,
+      settings: context.settings, URL: artifacts.URL,
+      SourceMaps: artifacts.SourceMaps, simulator: null,
+    };
     const metricResult = await Interactive.request(metricComputationData, context);
     const timeInMs = metricResult.timing;
     const options = context.options[context.settings.formFactor];

package/core/audits/metrics/largest-contentful-paint.js

@@ -27,7 +27,8 @@ class LargestContentfulPaint extends Audit {
       description: str_(UIStrings.description),
       scoreDisplayMode: Audit.SCORING_MODES.NUMERIC,
       supportedModes: ['navigation'],
-      requiredArtifacts: ['HostUserAgent', 'traces', 'devtoolsLogs', 'GatherContext', 'URL'],
+      requiredArtifacts: ['HostUserAgent', 'traces', 'devtoolsLogs', 'GatherContext', 'URL',
+        'SourceMaps'],
     };
   }
 
@@ -72,8 +73,11 @@ class LargestContentfulPaint extends Audit {
     const trace = artifacts.traces[Audit.DEFAULT_PASS];
     const devtoolsLog = artifacts.devtoolsLogs[Audit.DEFAULT_PASS];
     const gatherContext = artifacts.GatherContext;
-    const metricComputationData = {trace, devtoolsLog, gatherContext,
-      settings: context.settings, URL: artifacts.URL};
+    const metricComputationData = {
+      trace, devtoolsLog, gatherContext,
+      settings: context.settings, URL: artifacts.URL,
+      SourceMaps: artifacts.SourceMaps, simulator: null,
+    };
 
     const metricResult = await ComputedLcp.request(metricComputationData, context);
     const options = context.options[context.settings.formFactor];

package/core/audits/metrics/max-potential-fid.js

@@ -43,7 +43,7 @@ class MaxPotentialFID extends Audit {
       description: str_(UIStrings.description),
       scoreDisplayMode: Audit.SCORING_MODES.NUMERIC,
       supportedModes: ['navigation'],
-      requiredArtifacts: ['traces', 'devtoolsLogs', 'GatherContext', 'URL'],
+      requiredArtifacts: ['traces', 'devtoolsLogs', 'GatherContext', 'URL', 'SourceMaps'],
     };
   }
 
@@ -120,8 +120,11 @@ class MaxPotentialFID extends Audit {
     const trace = artifacts.traces[Audit.DEFAULT_PASS];
     const devtoolsLog = artifacts.devtoolsLogs[Audit.DEFAULT_PASS];
     const gatherContext = artifacts.GatherContext;
-    const metricComputationData = {trace, devtoolsLog, gatherContext,
-      settings: context.settings, URL: artifacts.URL};
+    const metricComputationData = {
+      trace, devtoolsLog, gatherContext,
+      settings: context.settings, URL: artifacts.URL,
+      SourceMaps: artifacts.SourceMaps, simulator: null,
+    };
     const metricResult = await ComputedFid.request(metricComputationData, context);
 
     const processedTrace = await ProcessedTrace.request(trace, context);

package/core/audits/metrics/speed-index.js

@@ -27,7 +27,7 @@ class SpeedIndex extends Audit {
       description: str_(UIStrings.description),
       scoreDisplayMode: Audit.SCORING_MODES.NUMERIC,
       supportedModes: ['navigation'],
-      requiredArtifacts: ['traces', 'devtoolsLogs', 'GatherContext', 'URL'],
+      requiredArtifacts: ['traces', 'devtoolsLogs', 'GatherContext', 'URL', 'SourceMaps'],
     };
   }
 
@@ -66,8 +66,11 @@ class SpeedIndex extends Audit {
     const trace = artifacts.traces[Audit.DEFAULT_PASS];
     const devtoolsLog = artifacts.devtoolsLogs[Audit.DEFAULT_PASS];
     const gatherContext = artifacts.GatherContext;
-    const metricComputationData = {trace, devtoolsLog, gatherContext,
-      settings: context.settings, URL: artifacts.URL};
+    const metricComputationData = {
+      trace, devtoolsLog, gatherContext,
+      settings: context.settings, URL: artifacts.URL,
+      SourceMaps: artifacts.SourceMaps, simulator: null,
+    };
     const metricResult = await ComputedSi.request(metricComputationData, context);
     const options = context.options[context.settings.formFactor];
 

package/core/audits/metrics/total-blocking-time.js

@@ -27,7 +27,7 @@ class TotalBlockingTime extends Audit {
       title: str_(i18n.UIStrings.totalBlockingTimeMetric),
       description: str_(UIStrings.description),
       scoreDisplayMode: Audit.SCORING_MODES.NUMERIC,
-      requiredArtifacts: ['traces', 'devtoolsLogs', 'GatherContext', 'URL'],
+      requiredArtifacts: ['traces', 'devtoolsLogs', 'GatherContext', 'URL', 'SourceMaps'],
     };
   }
 
@@ -88,8 +88,11 @@ class TotalBlockingTime extends Audit {
     const trace = artifacts.traces[Audit.DEFAULT_PASS];
     const devtoolsLog = artifacts.devtoolsLogs[Audit.DEFAULT_PASS];
     const gatherContext = artifacts.GatherContext;
-    const metricComputationData = {trace, devtoolsLog, gatherContext,
-      settings: context.settings, URL: artifacts.URL};
+    const metricComputationData = {
+      trace, devtoolsLog, gatherContext,
+      settings: context.settings, URL: artifacts.URL,
+      SourceMaps: artifacts.SourceMaps, simulator: null,
+    };
     if (
       gatherContext.gatherMode === 'timespan' &&
       context.settings.throttlingMethod === 'simulate'

package/core/audits/metrics.js

@@ -26,7 +26,7 @@ class Metrics extends Audit {
       title: 'Metrics',
       description: 'Collects all available metrics.',
       supportedModes: ['navigation'],
-      requiredArtifacts: ['traces', 'devtoolsLogs', 'GatherContext', 'URL'],
+      requiredArtifacts: ['traces', 'devtoolsLogs', 'GatherContext', 'URL', 'SourceMaps'],
     };
   }
 
@@ -36,12 +36,13 @@ class Metrics extends Audit {
    * @return {Promise<LH.Audit.Product>}
    */
   static async audit(artifacts, context) {
+    const settings = context.settings;
     const gatherContext = artifacts.GatherContext;
     const trace = artifacts.traces[Audit.DEFAULT_PASS];
     const devtoolsLog = artifacts.devtoolsLogs[Audit.DEFAULT_PASS];
-    const URL = artifacts.URL;
+    const {URL, SourceMaps} = artifacts;
     const summary = await TimingSummary
-      .request({trace, devtoolsLog, gatherContext, settings: context.settings, URL}, context);
+      .request({trace, devtoolsLog, gatherContext, settings, URL, SourceMaps}, context);
     const metrics = summary.metrics;
     const debugInfo = summary.debugInfo;
 

package/core/audits/predictive-perf.js

@@ -33,7 +33,7 @@ class PredictivePerf extends Audit {
         'a cellular connection on a mobile device.',
       scoreDisplayMode: Audit.SCORING_MODES.NUMERIC,
       supportedModes: ['navigation'],
-      requiredArtifacts: ['traces', 'devtoolsLogs', 'GatherContext', 'URL'],
+      requiredArtifacts: ['traces', 'devtoolsLogs', 'GatherContext', 'URL', 'SourceMaps'],
     };
   }
 
@@ -46,10 +46,11 @@ class PredictivePerf extends Audit {
     const gatherContext = artifacts.GatherContext;
     const trace = artifacts.traces[Audit.DEFAULT_PASS];
     const devtoolsLog = artifacts.devtoolsLogs[Audit.DEFAULT_PASS];
-    const URL = artifacts.URL;
+    const {URL, SourceMaps} = artifacts;
     /** @type {LH.Config.Settings} */
     const settings = JSON.parse(JSON.stringify(defaultSettings)); // Use default settings.
-    const computationData = {trace, devtoolsLog, gatherContext, settings, URL};
+    const computationData =
+      {trace, devtoolsLog, gatherContext, settings, URL, SourceMaps, simulator: null};
     const fcp = await LanternFirstContentfulPaint.request(computationData, context);
     const tti = await LanternInteractive.request(computationData, context);
     const si = await LanternSpeedIndex.request(computationData, context);

package/core/audits/prioritize-lcp-image.js

@@ -38,7 +38,8 @@ class PrioritizeLcpImage extends Audit {
       description: str_(UIStrings.description),
       supportedModes: ['navigation'],
       guidanceLevel: 4,
-      requiredArtifacts: ['traces', 'devtoolsLogs', 'GatherContext', 'URL', 'TraceElements'],
+      requiredArtifacts: ['traces', 'devtoolsLogs', 'GatherContext', 'URL', 'TraceElements',
+        'SourceMaps'],
       scoreDisplayMode: Audit.SCORING_MODES.METRIC_SAVINGS,
     };
   }
@@ -237,9 +238,10 @@ class PrioritizeLcpImage extends Audit {
     const gatherContext = artifacts.GatherContext;
     const trace = artifacts.traces[PrioritizeLcpImage.DEFAULT_PASS];
     const devtoolsLog = artifacts.devtoolsLogs[PrioritizeLcpImage.DEFAULT_PASS];
-    const URL = artifacts.URL;
+    const {URL, SourceMaps} = artifacts;
     const settings = context.settings;
-    const metricData = {trace, devtoolsLog, gatherContext, settings, URL};
+    const metricData =
+      {trace, devtoolsLog, gatherContext, settings, URL, SourceMaps, simulator: null};
     const lcpElement = artifacts.TraceElements
       .find(element => element.traceEventType === 'largest-contentful-paint');
 

package/core/audits/redirects.js

@@ -31,7 +31,7 @@ class Redirects extends Audit {
       scoreDisplayMode: Audit.SCORING_MODES.METRIC_SAVINGS,
       supportedModes: ['navigation'],
       guidanceLevel: 2,
-      requiredArtifacts: ['URL', 'GatherContext', 'devtoolsLogs', 'traces'],
+      requiredArtifacts: ['URL', 'GatherContext', 'devtoolsLogs', 'traces', 'SourceMaps'],
     };
   }
 
@@ -87,12 +87,14 @@ class Redirects extends Audit {
     const trace = artifacts.traces[Audit.DEFAULT_PASS];
     const devtoolsLog = artifacts.devtoolsLogs[Audit.DEFAULT_PASS];
     const gatherContext = artifacts.GatherContext;
+    const {URL, SourceMaps} = artifacts;
 
     const processedTrace = await ProcessedTrace.request(trace, context);
     const networkRecords = await NetworkRecords.request(devtoolsLog, context);
     const documentRequests = Redirects.getDocumentRequestChain(networkRecords, processedTrace);
 
-    const metricComputationData = {trace, devtoolsLog, gatherContext, settings, URL: artifacts.URL};
+    const metricComputationData =
+      {trace, devtoolsLog, gatherContext, settings, URL, SourceMaps, simulator: null};
     const metricResult = await LanternInteractive.request(metricComputationData, context);
 
     /** @type {Map<string, LH.Gatherer.Simulation.NodeTiming>} */

package/core/audits/script-treemap-data.js

@@ -31,7 +31,7 @@ class ScriptTreemapDataAudit extends Audit {
       title: 'Script Treemap Data',
       description: 'Used for treemap app',
       requiredArtifacts:
-        ['traces', 'devtoolsLogs', 'SourceMaps', 'Scripts', 'JsUsage', 'URL'],
+        ['traces', 'devtoolsLogs', 'SourceMaps', 'Scripts', 'JsUsage', 'URL', 'SourceMaps'],
     };
   }
 
@@ -114,8 +114,12 @@ class ScriptTreemapDataAudit extends Audit {
      */
     function collapseAll(node) {
       while (node.children && node.children.length === 1) {
-        node.name += '/' + node.children[0].name;
-        node.children = node.children[0].children;
+        const child = node.children[0];
+        node.name += '/' + child.name;
+        if (child.duplicatedNormalizedModuleName) {
+          node.duplicatedNormalizedModuleName = child.duplicatedNormalizedModuleName;
+        }
+        node.children = child.children;
       }
 
       if (node.children) {
@@ -174,7 +178,7 @@ class ScriptTreemapDataAudit extends Audit {
       if (script.scriptLanguage !== 'JavaScript') continue;
 
       const name = script.url;
-      const bundle = bundles.find(bundle => script.scriptId === bundle.script.scriptId);
+      const bundle = bundles.find(bundle => script.scriptId === bundle.script.scriptId) ?? null;
       const scriptCoverage = /** @type {LH.Artifacts['JsUsage'][string] | undefined} */
         (artifacts.JsUsage[script.scriptId]);
       const unusedJavascriptSummary = scriptCoverage ?

package/core/audits/third-party-facades.js

@@ -87,7 +87,7 @@ class ThirdPartyFacades extends Audit {
       description: str_(UIStrings.description),
       supportedModes: ['navigation'],
       guidanceLevel: 3,
-      requiredArtifacts: ['traces', 'devtoolsLogs', 'URL', 'GatherContext'],
+      requiredArtifacts: ['traces', 'devtoolsLogs', 'URL', 'GatherContext', 'SourceMaps'],
       scoreDisplayMode: Audit.SCORING_MODES.METRIC_SAVINGS,
     };
   }

package/core/audits/third-party-summary.js

@@ -67,7 +67,7 @@ class ThirdPartySummary extends Audit {
       description: str_(UIStrings.description),
       guidanceLevel: 1,
       scoreDisplayMode: Audit.SCORING_MODES.METRIC_SAVINGS,
-      requiredArtifacts: ['traces', 'devtoolsLogs', 'URL', 'GatherContext'],
+      requiredArtifacts: ['traces', 'devtoolsLogs', 'URL', 'GatherContext', 'SourceMaps'],
     };
   }
 

package/core/audits/uses-rel-preconnect.js

@@ -62,7 +62,7 @@ class UsesRelPreconnectAudit extends Audit {
       description: str_(UIStrings.description),
       supportedModes: ['navigation'],
       guidanceLevel: 3,
-      requiredArtifacts: ['traces', 'devtoolsLogs', 'URL', 'LinkElements'],
+      requiredArtifacts: ['traces', 'devtoolsLogs', 'URL', 'LinkElements', 'SourceMaps'],
       scoreDisplayMode: Audit.SCORING_MODES.METRIC_SAVINGS,
     };
   }
@@ -124,6 +124,7 @@ class UsesRelPreconnectAudit extends Audit {
   static async audit(artifacts, context) {
     const trace = artifacts.traces[UsesRelPreconnectAudit.DEFAULT_PASS];
     const devtoolsLog = artifacts.devtoolsLogs[UsesRelPreconnectAudit.DEFAULT_PASS];
+    const {URL, SourceMaps} = artifacts;
     const settings = context.settings;
 
     let maxWastedLcp = 0;
@@ -134,15 +135,16 @@ class UsesRelPreconnectAudit extends Audit {
     const [networkRecords, mainResource, loadSimulator, processedNavigation, pageGraph] =
       await Promise.all([
         NetworkRecords.request(devtoolsLog, context),
-        MainResource.request({devtoolsLog, URL: artifacts.URL}, context),
+        MainResource.request({devtoolsLog, URL}, context),
         LoadSimulator.request({devtoolsLog, settings}, context),
         ProcessedNavigation.request(trace, context),
-        PageDependencyGraph.request({trace, devtoolsLog, URL: artifacts.URL}, context),
+        PageDependencyGraph.request(
+          {settings, trace, devtoolsLog, URL, SourceMaps, fromTrace: false}, context),
       ]);
 
     const {rtt, additionalRttByOrigin} = loadSimulator.getOptions();
     const lcpGraph =
-      await LanternLargestContentfulPaint.getPessimisticGraph(pageGraph, processedNavigation);
+      LanternLargestContentfulPaint.getPessimisticGraph(pageGraph, processedNavigation);
     /** @type {Set<string>} */
     const lcpGraphURLs = new Set();
     lcpGraph.traverse(node => {
@@ -150,7 +152,7 @@ class UsesRelPreconnectAudit extends Audit {
     });
 
     const fcpGraph =
-      await LanternFirstContentfulPaint.getPessimisticGraph(pageGraph, processedNavigation);
+      LanternFirstContentfulPaint.getPessimisticGraph(pageGraph, processedNavigation);
     const fcpGraphURLs = new Set();
     fcpGraph.traverse(node => {
       if (node.type === 'network') fcpGraphURLs.add(node.request.url);

package/core/audits/uses-rel-preload.js

@@ -44,7 +44,7 @@ class UsesRelPreloadAudit extends Audit {
       description: str_(UIStrings.description),
       supportedModes: ['navigation'],
       guidanceLevel: 3,
-      requiredArtifacts: ['devtoolsLogs', 'traces', 'URL'],
+      requiredArtifacts: ['devtoolsLogs', 'traces', 'URL', 'SourceMaps'],
       scoreDisplayMode: Audit.SCORING_MODES.METRIC_SAVINGS,
     };
   }
@@ -212,14 +212,16 @@ class UsesRelPreloadAudit extends Audit {
    * @return {Promise<LH.Audit.Product>}
    */
   static async audit(artifacts, context) {
+    const settings = context.settings;
     const trace = artifacts.traces[UsesRelPreloadAudit.DEFAULT_PASS];
     const devtoolsLog = artifacts.devtoolsLogs[UsesRelPreloadAudit.DEFAULT_PASS];
-    const URL = artifacts.URL;
+    const {URL, SourceMaps} = artifacts;
     const simulatorOptions = {devtoolsLog, settings: context.settings};
 
     const [mainResource, graph, simulator] = await Promise.all([
       MainResource.request({devtoolsLog, URL}, context),
-      PageDependencyGraph.request({trace, devtoolsLog, URL}, context),
+      PageDependencyGraph.request(
+        {settings, trace, devtoolsLog, URL, SourceMaps, fromTrace: false}, context),
       LoadSimulator.request(simulatorOptions, context),
     ]);
 

package/core/computed/computed-artifact.d.ts

@@ -4,7 +4,11 @@
  * @template {{name: string, compute_(dependencies: unknown, context: LH.Artifacts.ComputedContext): Promise<unknown>}} C
  * @template {Array<keyof LH.Util.FirstParamType<C['compute_']>>} K
  * @param {C} computableArtifact
- * @param {(K & ([keyof LH.Util.FirstParamType<C['compute_']>] extends [K[number]] ? unknown : never)) | null} keys List of properties of `dependencies` used by `compute_`; other properties are filtered out. Use `null` to allow all properties. Ensures that only required properties are used for caching result.
+ * @param {(K & ([keyof LH.Util.FirstParamType<C['compute_']>] extends [K[number]] ? unknown : never)) | null} keys
+ *        List of properties of `dependencies` used by `compute_`; other properties are filtered out.
+ *        Use `null` to allow all properties. Ensures that only required properties are used for caching result.
+ *        For optional properties of `dependencies`, undefined cannot be used and if found is treated as an error.
+ *        This is to guard against developer mistakes. For optional properties, make it nullable instead.
  */
 export function makeComputedArtifact<C extends {
     name: string;

package/core/computed/computed-artifact.js

@@ -7,6 +7,7 @@
 import log from 'lighthouse-logger';
 
 import {ArbitraryEqualityMap} from '../lib/arbitrary-equality-map.js';
+import {isUnderTest} from '../lib/lh-env.js';
 
 /**
  * Decorate computableArtifact with a caching `request()` method which will
@@ -14,7 +15,11 @@ import {ArbitraryEqualityMap} from '../lib/arbitrary-equality-map.js';
  * @template {{name: string, compute_(dependencies: unknown, context: LH.Artifacts.ComputedContext): Promise<unknown>}} C
  * @template {Array<keyof LH.Util.FirstParamType<C['compute_']>>} K
  * @param {C} computableArtifact
- * @param {(K & ([keyof LH.Util.FirstParamType<C['compute_']>] extends [K[number]] ? unknown : never)) | null} keys List of properties of `dependencies` used by `compute_`; other properties are filtered out. Use `null` to allow all properties. Ensures that only required properties are used for caching result.
+ * @param {(K & ([keyof LH.Util.FirstParamType<C['compute_']>] extends [K[number]] ? unknown : never)) | null} keys
+ *        List of properties of `dependencies` used by `compute_`; other properties are filtered out.
+ *        Use `null` to allow all properties. Ensures that only required properties are used for caching result.
+ *        For optional properties of `dependencies`, undefined cannot be used and if found is treated as an error.
+ *        This is to guard against developer mistakes. For optional properties, make it nullable instead.
  */
 function makeComputedArtifact(computableArtifact, keys) {
   // tsc (3.1) has more difficulty with template inter-references in jsdoc, so
@@ -27,13 +32,29 @@ function makeComputedArtifact(computableArtifact, keys) {
    * @return {ReturnType<C['compute_']>}
    */
   const request = (dependencies, context) => {
+    const computedName = computableArtifact.name;
+
+    // Guard against missing properties. Optional properties must be passed as null - if missing or
+    // undefined, throw an error.
+    for (const key of keys || []) {
+      if (dependencies && typeof dependencies === 'object' && dependencies[key] === undefined) {
+        // eslint-disable-next-line max-len
+        const err = new Error(`missing required key "${String(key)}" for computed artifact ${computableArtifact.name}`);
+        if (isUnderTest) {
+          throw err;
+        } else {
+          // For now, simply log in production.
+          log.error(`lh:computed:${computedName}`, err);
+        }
+      }
+    }
+
     const pickedDependencies = keys ?
       Object.fromEntries(keys.map(key => [key, dependencies[key]])) :
       dependencies;
 
     // NOTE: break immutability solely for this caching-controller function.
     const computedCache = /** @type {Map<string, ArbitraryEqualityMap>} */ (context.computedCache);
-    const computedName = computableArtifact.name;
 
     const cache = computedCache.get(computedName) || new ArbitraryEqualityMap();
     computedCache.set(computedName, cache);

package/core/computed/critical-request-chains.d.ts

@@ -2,8 +2,10 @@ export { CriticalRequestChainsComputed as CriticalRequestChains };
 declare const CriticalRequestChainsComputed: typeof CriticalRequestChains & {
     request: (dependencies: {
         URL: LH.Artifacts["URL"];
+        SourceMaps: LH.Artifacts["SourceMaps"];
         devtoolsLog: LH.DevtoolsLog;
         trace: LH.Trace;
+        settings: LH.Audit.Context["settings"];
     }, context: LH.Artifacts.ComputedContext) => ReturnType<typeof CriticalRequestChains.compute_>;
 };
 declare class CriticalRequestChains {
@@ -24,14 +26,16 @@ declare class CriticalRequestChains {
      */
     static extractChainsFromGraph(mainResource: LH.Artifacts.NetworkRequest, graph: LH.Gatherer.Simulation.GraphNode): LH.Artifacts.CriticalRequestNode;
     /**
-     * @param {{URL: LH.Artifacts['URL'], devtoolsLog: LH.DevtoolsLog, trace: LH.Trace}} data
+     * @param {{URL: LH.Artifacts['URL'], SourceMaps: LH.Artifacts['SourceMaps'], devtoolsLog: LH.DevtoolsLog, trace: LH.Trace, settings: LH.Audit.Context['settings']}} data
      * @param {LH.Artifacts.ComputedContext} context
      * @return {Promise<LH.Artifacts.CriticalRequestNode>}
      */
     static compute_(data: {
         URL: LH.Artifacts["URL"];
+        SourceMaps: LH.Artifacts["SourceMaps"];
         devtoolsLog: LH.DevtoolsLog;
         trace: LH.Trace;
+        settings: LH.Audit.Context["settings"];
     }, context: LH.Artifacts.ComputedContext): Promise<LH.Artifacts.CriticalRequestNode>;
 }
 import * as Lantern from '../lib/lantern/lantern.js';