code-ai-installer 3.0.0 → 4.0.1-a

package/domains/development/locales/en/.agents/skills/testing-strategy-js-reference/agents/kimi.yaml

@@ -0,0 +1,14 @@
+name: "testing-strategy-js-reference"
+display_name: "JS/TS Testing Strategy"
+description: "Canonical JS/TS testing code reference — detailed DO/DON'T examples across 7 topics — Unit tests (AAA, edge cases, hooks), React Testing Library, Integration (supertest), Mocks and factories, naming and file structure, Coverage config (Vitest), anti-patterns. Activate when looking up a specific test code pattern."how to properly test X\"."
+default_prompt: "Use $testing-strategy-js-reference when the task matches the \"JS/TS Testing Code Reference (DO/DON'T)\" skill."
+triggers:
+  - "testing-strategy-js-reference"
+  - "testing strategy js reference"
+  - "JS/TS Testing Strategy"
+  - "Testing strategy for JS/TS projects — unit (Vitest), integration (API/DB), e2e (Playwright)"
+capabilities:
+  - "testing"
+  - "reference"
+tools: []
+implicit_invocation: true

package/domains/development/locales/en/.agents/skills/testing-strategy-js-reference/agents/openai.yaml

@@ -0,0 +1,8 @@
+interface:
+  display_name: "JS/TS Testing Strategy"
+  short_description: "Canonical JS/TS testing code reference — detailed DO/DON'T examples across 7 topics — Unit tests (AAA, edge cases, hooks), React Testing Library, Integration (supertest), Mocks and factories, naming and file structure, Coverage config (Vitest), anti-patterns. Activate when looking up a specific test code pattern."
+  default_prompt: "Use $testing-strategy-js-reference when the task matches the \"JS/TS Testing Code Reference (DO/DON'T)\" skill."
+dependencies:
+  tools: []
+policy:
+  allow_implicit_invocation: true

package/domains/development/locales/en/.agents/skills/testing-strategy-js-reference/agents/qwen.json

@@ -0,0 +1,18 @@
+{
+  "name": "testing-strategy-js-reference",
+  "display_name": "JS/TS Testing Strategy",
+  "description": "Canonical JS/TS testing code reference — detailed DO/DON'T examples across 7 topics — Unit tests (AAA, edge cases, hooks), React Testing Library, Integration (supertest), Mocks and factories, naming and file structure, Coverage config (Vitest), anti-patterns. Activate when looking up a specific test code pattern."how to properly test X\".",
+  "default_prompt": "Use $testing-strategy-js-reference when the task matches the \"JS/TS Testing Code Reference (DO/DON'T)\" skill.",
+  "triggers": [
+    "testing-strategy-js-reference",
+    "testing strategy js reference",
+    "JS/TS Testing Strategy",
+    "Testing strategy for JS/TS projects — unit (Vitest), integration (API/DB), e2e (Playwright)"
+  ],
+  "capabilities": [
+    "testing",
+    "reference"
+  ],
+  "tools": [],
+  "implicit_invocation": true
+}

package/domains/development/locales/en/.agents/skills/testing-strategy-js-reference/agents/skill.yaml

@@ -0,0 +1,22 @@
+version: 1
+name: "testing-strategy-js-reference"
+display_name: "JS/TS Testing Strategy"
+description: "Canonical JS/TS testing code reference — detailed DO/DON'T examples across 7 topics — Unit tests (AAA, edge cases, hooks), React Testing Library, Integration (supertest), Mocks and factories, naming and file structure, Coverage config (Vitest), anti-patterns. Activate when looking up a specific test code pattern."how to properly test X\"."
+default_prompt: "Use $testing-strategy-js-reference when the task matches the \"JS/TS Testing Code Reference (DO/DON'T)\" skill."
+triggers:
+  - "testing-strategy-js-reference"
+  - "testing strategy js reference"
+  - "JS/TS Testing Strategy"
+  - "Testing strategy for JS/TS projects — unit (Vitest), integration (API/DB), e2e (Playwright)"
+capabilities:
+  - "testing"
+  - "reference"
+tools: []
+invocation:
+  explicit: true
+  implicit: true
+localization:
+  default_locale: "en"
+  available_locales:
+    - "ru"
+    - "en"

package/domains/development/locales/en/.agents/skills/tests-integrity-rules/SKILL.md

@@ -0,0 +1,256 @@
+---
+name: tests-integrity-rules
+description: "SFS-side declarative rules for writing tests without gaming patterns — 9 forbidden patterns with BAD/DO examples and exception conditions, commit annotations (TEST-CHANGED-WHY / DELETED-WHY / MOCK-INCREASE-WHY) for test changes, 3 minimum-viable property-based invariants, minimal pre-push lint snippet. Paired with $qa-test-integrity-audit which detects violations at TEST gate. Activate before writing new tests, before GREEN commit with test diff, before push."
+type: discretionary
+domain: development
+owners:
+  - senior_full_stack
+gates:
+  - DEV
+tech:
+  - eslint
+  - ruff
+  - fast-check
+  - hypothesis
+topic:
+  - general
+  - testing
+triggers:
+  - tests integrity rules
+  - forbidden test patterns
+  - TEST-CHANGED-WHY
+  - DELETED-WHY
+  - MOCK-INCREASE-WHY
+  - property-based invariants
+  - test writing rules
+  - forbidden test patterns
+related:
+  - testing-strategy-js
+  - testing-strategy-js-reference
+  - tdd-workflow
+  - tdd-workflow-reference
+  - qa-test-integrity-audit
+  - qa-property-based-testing
+  - qa-mutation-testing
+  - tests-quality-review
+  - test-integrity-hooks-setup
+budget_lines: 320
+schema_version: 1
+---
+
+
+# Skill: Tests Integrity Rules (SFS)
+
+SFS-side canonical rules for writing tests without gaming patterns. Paired with `$qa-test-integrity-audit` which detects violations at TEST gate. This skill — what to write; audit — what gets caught.
+
+**Sections:**
+1. [When to apply](#1-when)
+2. [9 forbidden patterns as rules](#2-forbidden)
+3. [Commit annotations for test changes](#3-commit)
+4. [Property-based invariants (minimum viable)](#4-property)
+5. [Minimal pre-push lint](#5-prepush)
+6. [Anti-patterns on the SFS side](#6-anti)
+7. [DoD](#7-dod)
+
+---
+
+## 1. When to apply
+
+- **Before writing new tests** — especially for tier 1-2 modules (auth/billing/payments/security/crypto). Read §2 forbidden patterns as a "what NOT to do" checklist.
+- **During GREEN commit** — §3 commit annotations: if you change a test, you need `TEST-CHANGED-WHY`. If you delete a test — `DELETED-WHY`. If you added >2 mocks in PR — `MOCK-INCREASE-WHY`.
+- **When writing property-based tests** — §4 gives 3 minimum-viable examples; full methodology → `$qa-property-based-testing`.
+- **Before push** — §5 for a fast local lint-hook run.
+
+---
+
+## 2. 9 forbidden patterns as rules
+
+Each rule is formulated as a **prohibition** + DO replacement + when an **exception** is allowed. Detection logic (AST queries, ESLint configs) — in `$qa-test-integrity-audit`.
+
+### Rule 1: No standalone `expect.anything()` / `expect.any(X)`
+- ❌ `expect(result).toEqual(expect.anything())`
+- ✅ `expect(result).toEqual({ status: "ok", id: expect.any(String) })`
+- **Exception:** `expect.any(Date)` for timestamps when time is not critical — add `// audit:any-date OK <reason>`.
+- Detect: `$qa-test-integrity-audit` pattern #1.
+
+### Rule 2: No `toBeDefined()` / `toBeTruthy()` without content
+- ❌ `assert user is not None` (and that's it)
+- ✅ `assert user is not None` + `assert user.email == "x@y"` + `assert user.role == "admin"`
+- **Exception:** existence test before a subsequent fetch — `// audit:existence-only`.
+- Detect: pattern #2.
+
+### Rule 3: Snapshot test must have a semantic assertion
+- ❌ `it("renders", () => expect(render(Foo)).toMatchSnapshot())`
+- ✅ Snapshot + minimum `toContain("Submit")` / `toHaveTextContent(...)` / `expect.objectContaining({...})`
+- **Exception:** pure visual regression test — `_snapshot.test.ts` suffix as a separate category.
+- Detect: pattern #3.
+
+### Rule 4: No `.skip` / `.only` in commit
+- ❌ `it.skip(...)`, `describe.only(...)`
+- ✅ Remove the block or file a TODO + linked issue
+- **Exception:** temporary quarantine flake — `// quarantine: <issue-link> deadline 2026-XX-XX`.
+- Detect: pattern #4. ESLint `vitest/no-disabled-tests` + `vitest/no-focused-tests` blocks pre-commit.
+
+### Rule 5: `try/catch` must not swallow an assertion
+- ❌ `try: assert user.balance > 0 except: pass`
+- ✅ `with pytest.raises(SomeError): ...` or `expect(() => ...).toThrow(...)`
+- Detect: pattern #5 (custom AST rule).
+
+### Rule 6: Deleted a test — `DELETED-WHY` required in commit
+```
+test: remove obsolete X test
+DELETED-WHY: replaced by Y integration test; behavior fully covered there.
+```
+- **Exception:** none — without `DELETED-WHY` the PR is blocked by gh check.
+- Detect: pattern #6 + diff parser.
+
+### Rule 7: Mock count +>2 — `MOCK-INCREASE-WHY` required
+```
+MOCK-INCREASE-WHY: external API X unavailable in CI without prod credentials;
+mocked at boundary per Boundary Mocking Rule ($testing-strategy-js §5).
+```
+- Detect: pattern #7 (diff analysis).
+
+### Rule 8: Every test must have `expect()` / `assert`
+- ❌ Test body without assertion (forever green)
+- ✅ Every `it` / `def test_` at least one `expect()` / `assert`
+- Detect: pattern #8. ESLint `vitest/expect-expect`.
+
+### Rule 9: Property test must not be a tautology
+- ❌ `fc.property(fc.integer(), x => x === x)` — always true, tests nothing
+- ✅ `fc.property(fc.integer(), x => Math.abs(x) >= 0)` — real invariant
+- Detect: pattern #9. See `$qa-property-based-testing §4` for the library of valid invariants.
+
+---
+
+## 3. Commit annotations for test changes
+
+Formalized templates for commit messages — feeds downstream checks ($qa-test-integrity-audit + DEMO envelope in $tester).
+
+### TEST-CHANGED-WHY (in GREEN commit)
+
+If you change an existing test in a GREEN commit:
+```
+feat: add validation for X
+TEST-CHANGED-WHY: existing test expected old error code 422, new code returns
+400 per RFC X — adjusted assertion. Behavior is more correct, not loosened.
+TEST-BEHAVIOR-PRESERVED: yes — new assertion is stricter (400 covers also Y case).
+```
+**Without `TEST-CHANGED-WHY`** in a GREEN commit with test diff — self-confirming pattern (AI-gaming). `$qa-test-integrity-audit` catches this.
+
+### DELETED-WHY (in commit removing a test)
+```
+test: remove redundant Y test
+DELETED-WHY: behavior fully covered by integration test in suite Z. Removing
+reduces maintenance and runtime by 1.2s.
+```
+
+### MOCK-INCREASE-WHY (in PR adding >2 mocks)
+```
+feat: add subscription tier handling
+MOCK-INCREASE-WHY: 3 new external SDKs (Stripe Customer, Stripe Subscription,
+SendGrid mail) mocked at boundary — production endpoints untouchable in CI
+without prod credentials. Each follows Boundary Mocking Rule ($testing-strategy-js §5).
+```
+
+### RED_COMMIT_HASH / GREEN_COMMIT_HASH (DEMO envelope for tier 1-2)
+
+See `$tdd-workflow §1 Commit discipline` — TDD phases are separate commits for tier 1-2, hashes go into DEMO envelope for TEST gate verification.
+
+---
+
+## 4. Property-based invariants (minimum viable)
+
+Full methodology (6 patterns + shrinking + counter-example) → `$qa-property-based-testing §4`. Here — 3 minimum-viable templates as an entry point.
+
+### Pattern A: Roundtrip (encode → decode = identity)
+```ts
+import fc from "fast-check";
+fc.assert(fc.property(fc.string(), (s) => {
+  expect(decode(encode(s))).toBe(s);
+}));
+```
+```python
+from hypothesis import given, strategies as st
+@given(st.text())
+def test_encode_decode_roundtrip(s):
+    assert decode(encode(s)) == s
+```
+
+### Pattern B: Idempotence (f(f(x)) = f(x))
+```ts
+fc.assert(fc.property(fc.string(), (s) => {
+  expect(normalize(normalize(s))).toBe(normalize(s));
+}));
+```
+
+### Pattern C: Postcondition invariant (length / sortedness)
+```ts
+fc.assert(fc.property(fc.array(fc.integer()), (arr) => {
+  const sorted = sort(arr);
+  expect(sorted.length).toBe(arr.length);
+  for (let i = 1; i < sorted.length; i++) {
+    expect(sorted[i] >= sorted[i-1]).toBe(true);
+  }
+}));
+```
+
+**When to write a property test:** validators, parsers, serializers, normalizers, dedupers, math/business rules. UI rendering — NOT applicable (see `$qa-property-based-testing §1` decision tree).
+
+---
+
+## 5. Minimal pre-push lint
+
+Fast local run BEFORE push (≤5 sec) for catching obvious violations on the dev workstation. Not production CI — full setup in `$test-integrity-hooks-setup`.
+
+```bash
+# package.json scripts (JS/TS)
+"lint:test-integrity:fast": "eslint 'src/**/*.{test,spec}.{ts,tsx}' --rule 'vitest/no-disabled-tests:error' --rule 'vitest/no-focused-tests:error' --rule 'vitest/expect-expect:error'"
+```
+
+```bash
+# Python
+ruff check tests/ --select PT,S101 --extend-select PT001,PT003,PT006
+```
+
+Run before push:
+```bash
+npm run lint:test-integrity:fast && git push
+```
+
+Production-grade hooks (pre-commit + gh check + report aggregation + exemption registry) — `$test-integrity-hooks-setup` (DEV-094 roadmap).
+
+---
+
+## 6. Anti-patterns on the SFS side
+
+- ❌ **`eslint-disable` without justification** — `// eslint-disable-next-line vitest/no-disabled-tests` without an explanation. Always: `// eslint-disable-next-line ... -- quarantine for issue #N, deadline 2026-XX-XX`.
+- ❌ **Tautological property** — `fc.property(_, x => x === x)`. A property must test a **real** invariant. See `$qa-property-based-testing §4`.
+- ❌ **`TEST-CHANGED-WHY: refactor only`** without an actual diff to back it — the test changed substantively, "refactor only" is false. Describe the real behavioral reason.
+- ❌ **Mock-count inflation via split commits** — added 2 mocks in commit A, another 2 in commit B to avoid triggering `MOCK-INCREASE-WHY` each time. PR aggregate audit catches this.
+
+---
+
+## 7. DoD
+
+- [ ] All tests in the PR pass §2 9 forbidden patterns (or have a justified exception comment)
+- [ ] If test files changed in GREEN commit — `TEST-CHANGED-WHY` + `TEST-BEHAVIOR-PRESERVED` in commit message
+- [ ] If a test deleted — `DELETED-WHY` in commit message
+- [ ] If mock count increased >2 — `MOCK-INCREASE-WHY` in commit message
+- [ ] Property-based tests added for validators/parsers/serializers/normalizers (§4 applies)
+- [ ] `npm run lint:test-integrity:fast` green locally before push
+- [ ] For tier 1-2 modules — `RED_COMMIT_HASH` + `GREEN_COMMIT_HASH` in DEMO envelope (see `$tdd-workflow §1`)
+
+---
+
+## See also
+
+- `$testing-strategy-js` — general test strategy (Boundary Mocking Rule §5, mock-vs-real decision tree)
+- `$testing-strategy-js-reference` — testing code reference
+- `$tdd-workflow` — TDD discipline + Commit discipline (RED/GREEN/REFACTOR commits for tier 1-2)
+- `$tdd-workflow-reference` — TDD code reference
+- `$qa-test-integrity-audit` — Tester-side detector (catches §2 rule violations)
+- `$qa-property-based-testing` — full set of 6 invariant patterns + shrinking + counter-example
+- `$qa-mutation-testing` — tier model (determines when rules are strict)
+- `$tests-quality-review` — Reviewer-side test review
+- `$test-integrity-hooks-setup` — production pre-commit + gh check + report aggregator (DEV-094 roadmap)

package/domains/development/locales/en/.agents/skills/tests-integrity-rules/agents/claude.json

@@ -0,0 +1,19 @@
+{
+  "name": "tests-integrity-rules",
+  "display_name": "Tests Integrity Rules (SFS)",
+  "description": "SFS-side declarative rules for writing tests without gaming patterns — 9 forbidden patterns with BAD/DO examples and exception conditions, commit annotations (TEST-CHANGED-WHY / DELETED-WHY / MOCK-INCREASE-WHY) for test changes, 3 minimum-viable property-based invariants, minimal pre-push lint snippet. Paired with $qa-test-integrity-audit which detects violations at TEST gate. Activate before writing new tests, before GREEN commit with test diff, before push.",
+  "default_prompt": "Use $tests-integrity-rules when the task relates to the skill \"Tests Integrity Rules (SFS)\".",
+  "triggers": [
+    "tests-integrity-rules",
+    "tests integrity rules",
+    "Tests Integrity Rules (SFS)"
+  ],
+  "capabilities": [
+    "testing",
+    "integrity",
+    "rules",
+    "sfs"
+  ],
+  "tools": [],
+  "implicit_invocation": true
+}

package/domains/development/locales/en/.agents/skills/tests-integrity-rules/agents/copilot.json

@@ -0,0 +1,19 @@
+{
+  "name": "tests-integrity-rules",
+  "display_name": "Tests Integrity Rules (SFS)",
+  "description": "SFS-side declarative rules for writing tests without gaming patterns — 9 forbidden patterns with BAD/DO examples and exception conditions, commit annotations (TEST-CHANGED-WHY / DELETED-WHY / MOCK-INCREASE-WHY) for test changes, 3 minimum-viable property-based invariants, minimal pre-push lint snippet. Paired with $qa-test-integrity-audit which detects violations at TEST gate. Activate before writing new tests, before GREEN commit with test diff, before push.",
+  "default_prompt": "Use $tests-integrity-rules when the task relates to the skill \"Tests Integrity Rules (SFS)\".",
+  "triggers": [
+    "tests-integrity-rules",
+    "tests integrity rules",
+    "Tests Integrity Rules (SFS)"
+  ],
+  "capabilities": [
+    "testing",
+    "integrity",
+    "rules",
+    "sfs"
+  ],
+  "tools": [],
+  "implicit_invocation": true
+}

package/domains/development/locales/en/.agents/skills/tests-integrity-rules/agents/gemini.json

@@ -0,0 +1,19 @@
+{
+  "name": "tests-integrity-rules",
+  "display_name": "Tests Integrity Rules (SFS)",
+  "description": "SFS-side declarative rules for writing tests without gaming patterns — 9 forbidden patterns with BAD/DO examples and exception conditions, commit annotations (TEST-CHANGED-WHY / DELETED-WHY / MOCK-INCREASE-WHY) for test changes, 3 minimum-viable property-based invariants, minimal pre-push lint snippet. Paired with $qa-test-integrity-audit which detects violations at TEST gate. Activate before writing new tests, before GREEN commit with test diff, before push.",
+  "default_prompt": "Use $tests-integrity-rules when the task relates to the skill \"Tests Integrity Rules (SFS)\".",
+  "triggers": [
+    "tests-integrity-rules",
+    "tests integrity rules",
+    "Tests Integrity Rules (SFS)"
+  ],
+  "capabilities": [
+    "testing",
+    "integrity",
+    "rules",
+    "sfs"
+  ],
+  "tools": [],
+  "implicit_invocation": true
+}

package/domains/development/locales/en/.agents/skills/tests-integrity-rules/agents/kimi.yaml

@@ -0,0 +1,15 @@
+name: "tests-integrity-rules"
+display_name: "Tests Integrity Rules (SFS)"
+description: "SFS-side declarative rules for writing tests without gaming patterns — 9 forbidden patterns with BAD/DO examples and exception conditions, commit annotations (TEST-CHANGED-WHY / DELETED-WHY / MOCK-INCREASE-WHY) for test changes, 3 minimum-viable property-based invariants, minimal pre-push lint snippet. Paired with $qa-test-integrity-audit which detects violations at TEST gate. Activate before writing new tests, before GREEN commit with test diff, before push."
+default_prompt: "Use $tests-integrity-rules when the task relates to the skill \"Tests Integrity Rules (SFS)\"."
+triggers:
+  - "tests-integrity-rules"
+  - "tests integrity rules"
+  - "Tests Integrity Rules (SFS)"
+capabilities:
+  - "testing"
+  - "integrity"
+  - "rules"
+  - "sfs"
+tools: []
+implicit_invocation: true

package/domains/development/locales/en/.agents/skills/tests-integrity-rules/agents/openai.yaml

@@ -0,0 +1,8 @@
+interface:
+  display_name: "Tests Integrity Rules (SFS)"
+  short_description: "SFS-side declarative rules for writing tests without gaming patterns — 9 forbidden patterns with BAD/DO examples and..."
+  default_prompt: "Use $tests-integrity-rules when the task relates to the skill \"Tests Integrity Rules (SFS)\"."
+dependencies:
+  tools: []
+policy:
+  allow_implicit_invocation: true

package/domains/development/locales/en/.agents/skills/tests-integrity-rules/agents/qwen.json

@@ -0,0 +1,19 @@
+{
+  "name": "tests-integrity-rules",
+  "display_name": "Tests Integrity Rules (SFS)",
+  "description": "SFS-side declarative rules for writing tests without gaming patterns — 9 forbidden patterns with BAD/DO examples and exception conditions, commit annotations (TEST-CHANGED-WHY / DELETED-WHY / MOCK-INCREASE-WHY) for test changes, 3 minimum-viable property-based invariants, minimal pre-push lint snippet. Paired with $qa-test-integrity-audit which detects violations at TEST gate. Activate before writing new tests, before GREEN commit with test diff, before push.",
+  "default_prompt": "Use $tests-integrity-rules when the task relates to the skill \"Tests Integrity Rules (SFS)\".",
+  "triggers": [
+    "tests-integrity-rules",
+    "tests integrity rules",
+    "Tests Integrity Rules (SFS)"
+  ],
+  "capabilities": [
+    "testing",
+    "integrity",
+    "rules",
+    "sfs"
+  ],
+  "tools": [],
+  "implicit_invocation": true
+}

package/domains/development/locales/en/.agents/skills/tests-integrity-rules/agents/skill.yaml

@@ -0,0 +1,23 @@
+version: 1
+name: "tests-integrity-rules"
+display_name: "Tests Integrity Rules (SFS)"
+description: "SFS-side declarative rules for writing tests without gaming patterns — 9 forbidden patterns with BAD/DO examples and exception conditions, commit annotations (TEST-CHANGED-WHY / DELETED-WHY / MOCK-INCREASE-WHY) for test changes, 3 minimum-viable property-based invariants, minimal pre-push lint snippet. Paired with $qa-test-integrity-audit which detects violations at TEST gate. Activate before writing new tests, before GREEN commit with test diff, before push."
+default_prompt: "Use $tests-integrity-rules when the task relates to the skill \"Tests Integrity Rules (SFS)\"."
+triggers:
+  - "tests-integrity-rules"
+  - "tests integrity rules"
+  - "Tests Integrity Rules (SFS)"
+capabilities:
+  - "testing"
+  - "integrity"
+  - "rules"
+  - "sfs"
+tools: []
+invocation:
+  explicit: true
+  implicit: true
+localization:
+  default_locale: "ru"
+  available_locales:
+    - "ru"
+    - "en"

package/domains/development/locales/en/.agents/skills/tests-quality-review/SKILL.md

@@ -1,8 +1,42 @@
 ---
 name: tests-quality-review
 description: Quality review of unit/integration tests — scenario coverage, boundaries, resilience, absence of flakes and test "magic". Prioritized checklist, good/bad test examples, output report template. Activate when reviewing existing tests, stabilizing flaky tests, or auditing test suite quality.
+type: triggered
+domain: development
+owners:
+  - reviewer
+  - senior_full_stack
+gates:
+  - REV
+  - DEV
+tech: []
+topic:
+  - general
+  - review
+  - security
+triggers:
+  - tests review
+  - test quality
+  - flaky tests
+  - test suite audit
+  - test magic
+  - stabilize test
+related:
+  - testing-strategy-js
+  - testing-strategy-js-reference
+  - tdd-workflow
+  - tests-integrity-rules
+  - code-review-checklist
+  - qa-e2e-playwright
+  - qa-mutation-testing
+  - qa-property-based-testing
+  - qa-test-integrity-audit
+  - dev-reference-snippets
+budget_lines: 400
+schema_version: 1
 ---
 
+
 # Skill: Tests Quality Review
 
 Structured quality review of tests: checklist, priorities, examples of bad → good, report template.
@@ -16,16 +50,17 @@ Structured quality review of tests: checklist, priorities, examples of bad → g
 
 ---
 
-## 1. When to activate
+## 1. When to activate <a id="1-when-to-activate"></a>
 
 - REV gate — review tests as part of code review
 - After TDD iteration — check the quality of newly written tests
 - When stabilizing a flaky CI — find and fix fragile tests
 - During a coverage audit — focus on *what* is covered, not just the percentage
+- When PR has test diff with new mocks or test modifications — mandatory run of §2 F + G
 
 ---
 
-## 2. Review Checklist
+## 2. Review Checklist <a id="2-review-checklist"></a>
 
 ### A. Scenario Coverage (P0)
 
@@ -74,9 +109,34 @@ Structured quality review of tests: checklist, priorities, examples of bad → g
 | E2 | Snapshot is **compact** (not 500 lines) — inline preferred | ✅/❌ |
 | E3 | Snapshot update is not "auto-accept" (diff is reviewed) | ✅/❌ |
 
+### F. AI-gaming detection (P1)
+
+REV-side **contextual judgment** for what static/dynamic scanners do not catch. Cross-check: what `$qa-test-integrity-audit` already caught automatically (9 patterns) — skip manual verification for those.
+
+| # | Check | Verdict |
+|---|---------|---------|
+| F1 | Mock does not reproduce the logic it is testing (mock-as-production-double) | ✅/❌ |
+| F2 | Mock-to-real ratio within range (compare with repo baseline; flag if >3× of average) | ✅/❌ |
+| F3 | Snapshot tests have a semantic assertion (not only `toMatchSnapshot()`) | ✅/❌ |
+| F4 | Property tests test real invariants (not a tautology like `x === x`) | ✅/❌ |
+| F5 | `eslint-disable` has justification comment + deadline (if quarantine) | ✅/❌ |
+
+### G. Test-modification audit (P0)
+
+PR diff verification for test files. SFS-side rules in `$tests-integrity-rules` (what SFS should have followed).
+
+| # | Check | Verdict |
+|---|---------|---------|
+| G1 | Every modified test file has `TEST-CHANGED-WHY` + `TEST-BEHAVIOR-PRESERVED` in commit message | ✅/❌ |
+| G2 | Rationale in `TEST-CHANGED-WHY` matches the actual diff (not "refactor only" when assertion changed) | ✅/❌ |
+| G3 | Changes made the test **stricter** or **weaker** (if weaker — justified in rationale) | ✅/❌ |
+| G4 | Deleted test has `DELETED-WHY` + verifiable reason (check the cited coverage source) | ✅/❌ |
+| G5 | +>2 mocks in PR — `MOCK-INCREASE-WHY` present + boundary mock rule respected (`$testing-strategy-js §5`) | ✅/❌ |
+| G6 | For tier 1-2 modules — `RED_COMMIT_HASH` + `GREEN_COMMIT_HASH` in DEMO envelope (see `$tdd-workflow §1`) | ✅/❌ |
+
 ---
 
-## 3. Examples: bad → good
+## 3. Examples: bad → good <a id="3-examples-bad--good"></a>
 
 ### A1. Behavior vs Implementation
 
@@ -195,7 +255,7 @@ it('should process order and save to DB', async () => {
 
 ---
 
-## 4. Flaky tests: diagnosis
+## 4. Flaky tests: diagnosis <a id="4-flaky-tests-diagnosis"></a>
 
 ### Common Causes
 
@@ -221,7 +281,7 @@ npx vitest run --repeat=10
 
 ---
 
-## 5. Output report template
+## 5. Output report template <a id="5-output-report-template"></a>
 
 ```markdown
 # Tests Quality Review Report
@@ -249,6 +309,21 @@ npx vitest run --repeat=10
 |---|----------------|---------|-------------|
 | 1 | E2 (snapshot size) | 200 line snapshot in ProductForm.test | Switch to inline snapshot or RTL assertion |
 
+### F — AI-gaming detections
+| # | Checklist item | Problem | Recommendation |
+|---|----------------|---------|-------------|
+| 1 | F1 (mock-as-production-double) | PaymentMock reproduces validator logic | Replace with real validator or raise test to integration level |
+
+### G — Test-modification audit findings
+| # | Checklist item | Problem | Recommendation |
+|---|----------------|---------|-------------|
+| 1 | G2 (rationale mismatch) | `TEST-CHANGED-WHY: refactor only` for diff with assertion 422 → 400 changed | Request precise rationale; if behavior changed — separate TDD cycle |
+
+### Mock-to-real ratio
+- **Repo baseline:** X mocks per test file (avg over last 50 PRs)
+- **This PR:** Y mocks per test file
+- **Verdict:** within / above (>3× of baseline → flag F2)
+
 ## Missing Test Cases
 - [ ] `fetchItems` — error path (network failure)
 - [ ] `updateRecord` — edge case (empty name)
@@ -259,21 +334,22 @@ npx vitest run --repeat=10
 |------|-------------------|-------------|
 | `pricing.test.js:42` | Depends on Date.now | vi.useFakeTimers |
 ```
-
----
-
 ## Verdict Criteria
 
 | Verdict | Conditions |
 |---------|---------|
-| **PASS ✅** | All P0 ✅, P1 ≤ 2 findings, no flaky |
-| **PASS with findings ⚠️** | All P0 ✅, but has P1 findings or missing cases | 
-| **FAIL ❌** | Any P0 ❌ (no error paths, tests dependent, flaky) |
+| **PASS ✅** | All P0 ✅, P1 ≤ 2 findings, no flaky, G findings = 0 |
+| **PASS with findings ⚠️** | All P0 ✅, but has P1 findings or missing cases or F findings |
+| **FAIL ❌** | Any P0 ❌ (no error paths, tests dependent, flaky) OR any G ❌ (commit annotations absent) |
+
+**Severity mapping:** G findings count as P0 (mandatory commit annotations feed downstream checks). F findings count as P1 (contextual gaming detections — review-required but not block).
 
 ---
 
 ## See also
 - `$testing-strategy-js` — strategy and patterns for writing tests
+- `$tdd-workflow` — TDD discipline + Commit discipline (RED/GREEN/REFACTOR commits for tier 1-2)
+- `$tests-integrity-rules` — SFS-side rules companion (what SFS should have followed before PR)
 - `$code-review-checklist` — general code review checklist
 - `$qa-e2e-playwright` — E2E via Playwright
 - `$dev-reference-snippets` — code examples

package/domains/development/locales/en/.agents/skills/tests-quality-review/agents/kimi.yaml

@@ -1,14 +1,14 @@
-name: "tests-quality-review"
-display_name: "Tests Quality Review"
-description: "Quality review of unit/integration tests — scenario coverage, boundaries, resilience, absence of flakes and test \"magic\". Prioritized checklist, good/bad test examples, output report template. Activate when reviewing existing tests, stabilizing flaky tests, or auditing test suite quality."
-default_prompt: "Use $tests-quality-review when the task matches the \"Tests Quality Review\" skill."
-triggers:
-  - "tests-quality-review"
-  - "tests quality review"
-  - "Quality review of unit/integration tests — scenario coverage, boundaries, resilience, absence of flakes and test \"magic\""
-capabilities:
-  - "tests"
-  - "quality"
-  - "review"
-tools: []
-implicit_invocation: true
+name: "tests-quality-review"
+display_name: "Tests Quality Review"
+description: "Quality review of unit/integration tests — scenario coverage, boundaries, resilience, absence of flakes and test \"magic\". Prioritized checklist, good/bad test examples, output report template. Activate when reviewing existing tests, stabilizing flaky tests, or auditing test suite quality."
+default_prompt: "Use $tests-quality-review when the task matches the \"Tests Quality Review\" skill."
+triggers:
+  - "tests-quality-review"
+  - "tests quality review"
+  - "Quality review of unit/integration tests — scenario coverage, boundaries, resilience, absence of flakes and test \"magic\""
+capabilities:
+  - "tests"
+  - "quality"
+  - "review"
+tools: []
+implicit_invocation: true