chrome-devtools-frontend 1.0.1040337 → 1.0.1070764

package/docs/l10n.md

@@ -0,0 +1,293 @@
+# Localization
+
+## How to add a localizable string
+
+When you introduce a new UI string or modify an existing one that will be displayed to the users, or remove a string that is localized, follow these steps so that it can be localized.
+
+**Table of Contents**
+- [Adding a string](#adding-a-string)
+- [Modifying a string](#modifying-a-string)
+- [Removing a string](#removing-a-string)
+
+### Adding a string
+Before proceeding, make sure you know the different [localization APIs](localization_apis_V2.md) and know which one you should use.
+
+Code example:
+  ```javascript
+  import * as i18n from '../i18n/i18n.js';
+
+  // at the top of example.js file, after import statements
+  const UIStrings = {
+    /**
+      * @description A string that is already added
+      */
+    alreadyAddedString: 'Someone already created a "UIStrings = {}" and added this string',
+    /**
+      * @description This is an example description for my new string
+      */
+    addThisString: 'The new string I want to add',
+    /**
+      * @description This is an example description for my new string with placeholder
+      * @example {example for placeholder} PH1
+      */
+    addAnotherString: 'Another new string I want to add, with {PH1}',
+  };
+  const str_ = i18n.i18n.registerUIStrings('example.js', UIStrings);
+  const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
+  ```
+
+  ```javascript
+  // in example.js file, where you want to call the string
+
+  const message1 = i18nString(UIStrings.addThisString);
+  console.log(message1); // The new string I want to add
+
+  const message2 = i18nString(UIStrings.addAnotherString, {PH1: 'a placeholder'});
+  console.log(message2); // Another new string I want to add, with a placeholder
+  ```
+1. If there is already `UIStrings = {}` declared in the file, add your string to it.
+  If there isn't `UIStrings = {}` in the file, create one and add your string, also register the new UIStrings into the `en-US.json` by adding:
+    1. `const str_ = i18n.i18n.registerUIStrings({the current fileName.js, relative to front_end}, UIStrings);`
+    1. `const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);`
+
+
+2. Add description and examples for placeholder(if any):
+    1. To specify the description, use `@description …`
+    `@description This is an example description for my new string`
+    2. To specify an example for placeholder, use `@example {…} …`
+    `@example {example for placeholder} PH1`
+
+3. Make sure your string is localizable:
+
+   1. Do not assume word order by using concatenation. Use the whole string.
+      ❌
+      ```javascript
+      'Add' + 'breakpoint'
+      ```
+      ✔️
+      ```javascript
+      'Add breakpoint'
+      ```
+      or
+      ❌
+      ```javascript
+      let description = 'first part'
+      if (condition)
+        description += ' second part'
+      ```
+      ✔️
+      ```javascript
+      let description
+      if (condition)
+        description = 'first part second part'
+      else
+        description = 'first part'
+      ```
+   2. Use placeholder over concatenation. This is so that the translators can adjust variable order based on what works in another language. For example:
+      ❌
+      ```javascript
+      'Check ' + title + ' for more information.'
+      ```
+      ✔️
+      ```javascript
+      'Check {PH1} for more information.', {PH1: title}
+      ```
+   3. If your string contains <b>leading or trailing white space</b>, it's usually an indication that it's half of a sentence. This decreases localizability as it's essentially concatenating. Modify it so that it doesn't contain leading or trailing white space anymore if you can.
+   4. <b>Backticks</b> are only used for the text that should not be localized. They cannot be escaped as part of the string. Check if there are something should not be localized (see [locked_terms](locked_terms_V2.md) for more details).
+
+      ❌ Not localized
+
+      - Numbers: 1, 1.23, 1.2e3, etc.
+      - Application data: error codes, enums, database names, rgba, urls, etc.
+
+      ✔️ Can be localized
+
+      - Words and sentences
+      - Punctuation
+      - Units of measurement: kb/s, mph, etc.
+4. The following commands would add the new strings to `en-US.json`:
+  - `git cl presubmit --upload`, or
+  - `node third_party/i18n/collect-strings.js` under the DevTools src folder
+5. Strings containing possible plurals have a special format in ICU. This is because plurals work quite differently in other languages, e.g. special forms for two or three items.
+
+    ❌
+    ```javascript
+    if (count === 1) {
+      str = '1 breakpoint';
+    } else {
+      str = '{n} breakpoints', {n: count};
+    }
+    ```
+
+    ✔️
+    ```javascript
+    '{n, plural, =1 {# breakpoint} other {# breakpoints}}', {n: count};
+    ```
+    - '#' is replaced with the value of `n`
+    - 'n' is a naming convention, but any name can be used
+    - Nesting placeholders inside of plurals is allowed
+    - Put the entire string within the plural switch, e.g. `{# breakpoints were found}`, not `{# breakpoints} were found`
+    - Always provide the `=1` and the `other` case, even if they are the same for English.
+
+### Modifying a string
+1. Update the string you want to modify in `UIStrings`
+2. Update the description and placeholders of the string if necessary
+
+### Removing a string
+1. Remove your string and the metadata from `UIStrings`
+
+
+## What are the l10n APIs?
+
+Access localized strings in the DevTools frontend using the following localization calls.
+
+### i18nString
+The basic API to make a string (with or without placeholder) localizable.
+The first argument is the string reference in `UIStrings`
+The second argument is an object for placeholders (if any)
+
+```javascript
+// at the top of example.js file, after import statements
+
+const UIStrings = {
+  /**
+    * @description This is an example description for my new string with placeholder
+    * @example {example for placeholder} PH1
+    * @example {example 2 for placeholder 2} PH2
+    */
+  addAnotherString: 'Another new string I want to add, with {PH1} and {PH2}',
+};
+
+message = i18nString(UIStrings.addAnotherString, {PH1: 'a placeholder', PH2: 'another placeholder'});
+```
+
+### i18nLazyString
+The `i18nString` function returns the translated string, with placeholders resolved. To do this, it needs access to the translated strings for the user's locale, which are not available until after DevTools has finished starting up.
+
+Calls to `i18nString` in the module scope will therefore fail when the module is imported.
+```javascript
+// Fails because i18nString runs at module-import time.
+Common.Settings.registerSettingExtension({
+  category: Common.Settings.SettingCategory.CONSOLE,
+  title: i18nString(UIStrings.groupSimilarMessagesInConsole),
+...
+
+function notTopLevel() {
+  console.log(extension.title);
+}
+```
+
+`i18nLazyString` fixes this problem by providing the same API, but returning a closure that returns a `LocalizedString`.
+It can be used in top-level calls; just make sure use-sites know it's a function now.
+
+```javascript
+// Works because i18nLazyString defers the loading of the translated string until later.
+Common.Settings.registerSettingExtension({
+  category: Common.Settings.SettingCategory.CONSOLE,
+  title: i18nLazyString(UIStrings.groupSimilarMessagesInConsole),
+...
+
+// Note we need to call title() now.
+function notTopLevel() {
+  console.log(extension.title());
+}
+```
+
+### i18n.i18n.getFormatLocalizedString
+This call returns a **span element**, not a string. It is used when you want to construct a DOM element with a localizable string, or localizable content that contains some other DOM element.
+
+```javascript
+// Create the string in UIString
+/**
+*@description Message in Coverage View of the Coverage tab
+*@example {reload button icon} PH1
+*@example {record button icon} PH2
+*/
+clickTheRecordButtonSToStart: 'Click the reload button {PH1} to reload or record button {PH2} start capturing coverage.',
+
+// Element with localizable content containing two DOM elements that are buttons
+const reloadButton = UI.createInlineButton(UI.Toolbar.createActionButtonForId('coverage.start-with-reload'));
+const recordButton = UI.createInlineButton(UI.Toolbar.createActionButton(this._toggleRecordAction));
+message = i18n.i18n.getFormatLocalizedString(str_, UIStrings.clickTheReloadButtonSToReloadAnd, {PH1: reloadButton, PH2:recordButton });
+```
+
+### i18n.i18n.lockedString
+This call is a named cast. Use it in places where a localized string is expected but the
+term you want to use does not require translation. Instead of locking the whole phrase or using
+a placeholder-only phrase, use `lockedString`.
+
+```javascript
+someFunctionRequiringALocalizedString(i18n.i18n.lockedString('HTTP'));
+```
+
+## How to write good descriptions
+
+Good descriptions can improve localizability by providing more context to the translators.
+There are some details that are very important to have in other languages!
+
+**Good description**:
+```javascript
+const UIStrings = {
+  /**
+   * @description Tooltip text that appears when hovering over the 'Focusable' attribute name under the Computed Properties section in the Accessibility pane of the Elements pane.
+   */
+  computedPropertyTooltip: 'If true, this element can receive focus.',
+};
+```
+**Bad description**:
+```javascript
+const UIStrings = {
+  /**
+   * @description Elements pane 'Focusable' tooltip.
+   */
+  computedPropertyTooltip: 'If true, this element can receive focus.',
+};
+```
+
+### What information should I provide in the message description?
+- The type of UI element where the text is displayed. Is it regular text, a label, button text, a tooltip, a link, or an accessible label? Button text is often imperative i.e. a command to do something, which is important to know in some languages.
+- _When_: What triggers the string and/or what is the result? What page or text comes before and after? e.g. "Status text while waiting for X", "Shown when the audit is finished and X error was encountered".
+- What do the placeholders stand for? Placeholder examples are sent to translators, but extra information in the description will help too. e.g. "Total time in ms that the profile took to complete", "The CSS property name that is being edited"
+- Is this a verb or a noun? Many words in English can be both, e.g. 'request', 'address', 'change', 'display', 'increase'. Particularly if the string is short, this can be hard to guess. If it's an adjective, what does it refer to? This is important for inflection in some languages, where the ending of the adjective must change for gender or case.
+- Explain or name any complex terms, e.g. "Trust Tokens are a web API - https://web.dev/trust-tokens/"
+- Where is the text located? e.g. A table header in the Sources panel, a context-menu item in the Network panel. Many strings in the code base have _only_ the location, which is not the most important context.
+
+
+## How to prevent a term being localized
+
+Any text within the backticks will not be translated.
+For example, if the 'robots.txt' in string 'Requesting for robots.txt ...' should not be translated:
+
+```javascript
+// in example.js file
+
+import * as i18n from '../i18n/i18n.js';
+const UIStrings = {
+  /**
+   * @description Example description. Note: "robots.txt" is a canonical filename and should not be translated.
+   */
+  requestMessage: 'Requesting for `robots.txt` ...',
+};
+const str_ = i18n.i18n.registerUIStrings('example.js', UIStrings);
+
+const message = i18nString(UIStrings.requestMessage);
+```
+The string will rendered with robots.txt not translated and without the backticks around it
+```javascript
+  'Requesting for robots.txt ...'
+```
+
+### Phrases that are fully locked
+Any text that is fully locked should not go into the UIStrings object. To make your intention clear
+or to make TypeScript happy, there are two methods `i18n.i18n.lockedString` and `i18n.i18n.lockedLazyString`
+that can be used instead of having fully locked phrases via `i18nString`.
+
+### What should not be localized?
+In general, branding related terms and code snippets are the ones to look for, and Sometimes some technical terms. Some examples:
+
+**Brandings:**
+Lighthouse, GitHub, DevTools, Chrome Data Saver, Safari, BlackBerry Z30, Kindle Fire HDX, Pixel 2, Microsoft Lumia 550
+**Code snippets:**
+localhost:9229, console.clear(), --memlog=all, url:a.com
+**Technical terms:**
+DOM, DIV, aria...

package/docs/navbar.md

@@ -0,0 +1,13 @@
+# Chromium DevTools Docs
+
+[logo]: https://github.com/ChromeDevTools/devtools-logo/raw/master/logos/png/devtools-circle-48.png
+[home]: /docs/README.md
+
+* [Home][home]
+* [Sitemap](/docs/README.md#document-index)
+* [Design Documents](https://drive.google.com/drive/folders/1JbUthATfybvMQR3yAHC4J0P7n6oftYNq)
+* [Contact](https://www.chromium.org/teams/devtools/)
+* [Bugs](https://www.chromium.org/for-testers/bug-reporting-guidelines/)
+* [Markdown Style Guide](https://github.com/google/styleguide/tree/gh-pages/docguide)
+* [Markdown Syntax](https://gerrit.googlesource.com/gitiles/+/HEAD/Documentation/markdown.md)
+* [Search](https://source.chromium.org/chromium/devtools/devtools-frontend/+/main:docs/)

package/docs/third_party_guidelines.md

@@ -0,0 +1,78 @@
+# Third-party Guidelines
+
+[TOC]
+
+When you want to integrate or use third-party content in DevTools, there are a
+couple of different ways to do so. Most of the time, we have to make a
+distinction between "third-party code we use as part of DevTools implementation"
+and "third-party code we use to build DevTools itself, but is not included in
+the product".
+
+## Third-party code included in DevTools bundle
+
+All third-party content that you want to ship as part of the DevTools bundle
+must be included in `front_end/third_party`. The typical way to update these
+packages is to download the relevant packages from [npm]. Since DevTools does
+not use a `package.json` to handle its dependencies (to make it possible to
+review third-party changes by legal), most packages bundles are fetched with
+`wget`.
+
+For all these packages, the [Chromium third-party guidelines] apply.
+
+Since DevTools ships as part of the Chrome binary, bundle size
+limitations apply. To make integration feasible, focus on small packages that
+(preferably) have no dependencies. This will make licensing checks feasible for
+Chromium reviewers and typically avoids inflating the bundle size.
+
+## Third-party tooling packages
+
+For all third-party packages that are used either as part of the DevTools build
+process or to augment engineers workflows (for example linters), we add them to
+`scripts/deps/manage_node_deps.py`. This Python script has been approved by
+Chromium licensing to be used, on the basis that it enforces all packages have a
+license that is compatible with a set of pre-defined licensees.
+
+If you want to use a new package as tooling process in engineer workflows, you
+can add the package to the `DEPS` in the script and run `npm run install-deps`
+to check in the new contents.
+
+Only add new license types to `LICENSES` after you received approval
+from `opensource-licensing@google.com`. Their response time is typically within
+24 hours, so this typically is not a big hurdle.
+
+To avoid excessive package updates, it is typically easiest to
+update all packages in `manage_node_deps.py` once a month. Since NPM packages
+can have a lot of (shared) transitive dependencies, updating the packages on a
+specific day increases the chances that shared dependencies are deduplicated and
+thus result in smaller repository sizes.
+
+> **WARNING:** Updating tools such as Rollup and TypeScript will cause all build cache
+> output to be purged, as they are part of all DevTools modules. Whenever you are
+> updating either of these tools, update these at the end of a working day to
+> avoid full rebuilds for other engineers.
+
+## Chromium third-party DEPS
+
+Some packages related to infrastructure are maintained by Chromium infra teams.
+These packages are typically uploaded to cloud storage buckets or are explicitly
+mirrored to a repository on https://chromium.googlesource.com. Examples include
+[GN][] (Chromium/DevTools build system) or [clang-format][] (multi-language
+formatter).
+
+The packages in `DEPS` are typically kept automatically up-to-date with
+autorollers. These autorollers will periodically update packages, which
+engineers can fetch with running `gclient sync`.
+
+These `DEPS` are checked out on all bots, which includes Chromium and
+DevTools-specific bots. To avoid excessive network bandwidth usage, by default
+do not check out packages if they are only used in specific situations.
+
+Only include packages that are maintained by Chromium
+infrastructure teams and are used to build DevTools in `DEPS`. For packages that
+are DevTools-specific, prefer adding them to `scripts/deps/manage_node_deps.py`
+instead.
+
+[npm]: https://www.npmjs.com/
+[Chromium third-party guidelines]: https://chromium.googlesource.com/chromium/src/+/HEAD/docs/adding_to_third_party.md
+[GN]: https://gn.googlesource.com/gn/+/master/docs/reference.md
+[clang-format]: https://clang.llvm.org/docs/ClangFormat.html

package/docs/workflows.md

@@ -26,6 +26,7 @@ To build, follow these steps:
 
 ```bash
 cd devtools-frontend
+gclient sync
 gn gen out/Default
 autoninja -C out/Default
 ```
@@ -275,7 +276,11 @@ Bug: 123456
 ```
 ## Managing dependencies
 
-- To sync dependencies from Chromium to DevTools frontend, use `scripts/deps/roll_deps.py && npm run generate-protocol-resources`.
+To sync dependencies from Chromium to DevTools frontend, use `scripts/deps/roll_deps.py && npm run generate-protocol-resources`.
+Note that this may:
+- Introduce unneeded whitespace/formatting changes. Presubmit scripts (e.g. invoked via `git cl upload`) will automatically fix these locally, so just apply the changes directly to your change (e.g. with `git commit --amend`) afterwards.
+- Introduce breaking changes to the devtools protocol, causing compilation failures. Unfortunately these need to be handled manually as there are some changes (e.g. removing an enum value) that cannot fail gracefully.
+
 
 The following scripts run as AutoRollers, but can be manually invoked if desired:
 

package/extension-api/ExtensionAPI.d.ts

@@ -187,6 +187,7 @@ export namespace Chrome {
       description?: string;
       objectId?: RemoteObjectId;
       linearMemoryAddress?: number;
+      linearMemorySize?: number;
       hasChildren: boolean;
     }
 

package/front_end/Images/src/edit-icon.svg

@@ -0,0 +1,3 @@
+<svg width="18" height="18" viewBox="0 0 18 18" fill="none" xmlns="http://www.w3.org/2000/svg">
+<path d="M2.25 15.7499V12.3938L12.1311 2.51272C12.4437 2.20012 12.8157 2.04382 13.2471 2.04382C13.6785 2.04382 14.0502 2.20012 14.3622 2.51272L15.4872 3.63772C15.7872 3.93772 15.9372 4.30942 15.9372 4.75282C15.9372 5.19682 15.7872 5.56882 15.4872 5.86882L5.6061 15.7499H2.25ZM13.2561 5.84992L14.3622 4.74382L13.2561 3.63772L12.15 4.74382L13.2561 5.84992Z" fill="black"/>
+</svg>

package/front_end/Images/src/frame-embedded-icon.svg

@@ -0,0 +1,61 @@
+<?xml version="1.0" encoding="UTF-8" standalone="no"?>
+<!-- Created with Inkscape (http://www.inkscape.org/) -->
+
+<svg
+   width="15"
+   height="13"
+   viewBox="0 0 3.9687502 3.4395833"
+   version="1.1"
+   id="svg234"
+   inkscape:version="1.1.2 (0a00cf5339, 2022-02-04)"
+   sodipodi:docname="frame-embedded-icon.svg"
+   xmlns:inkscape="http://www.inkscape.org/namespaces/inkscape"
+   xmlns:sodipodi="http://sodipodi.sourceforge.net/DTD/sodipodi-0.dtd"
+   xmlns="http://www.w3.org/2000/svg"
+   xmlns:svg="http://www.w3.org/2000/svg">
+  <sodipodi:namedview
+     id="namedview236"
+     pagecolor="#ffffff"
+     bordercolor="#666666"
+     borderopacity="1.0"
+     inkscape:pageshadow="2"
+     inkscape:pageopacity="0.0"
+     inkscape:pagecheckerboard="0"
+     inkscape:document-units="mm"
+     showgrid="false"
+     units="px"
+     inkscape:zoom="14.493388"
+     inkscape:cx="40.880712"
+     inkscape:cy="34.084509"
+     inkscape:window-width="2142"
+     inkscape:window-height="1445"
+     inkscape:window-x="0"
+     inkscape:window-y="0"
+     inkscape:window-maximized="1"
+     inkscape:current-layer="layer1" />
+  <defs
+     id="defs231" />
+  <g
+     inkscape:label="Layer 1"
+     inkscape:groupmode="layer"
+     id="layer1"
+     transform="translate(122.81654,83.789169)">
+    <g
+       id="g1853"
+       style="fill:#000000"
+       transform="matrix(0.26458333,0,0,0.26458333,-144.04935,-84.186044)">
+      <path
+         inkscape:connector-curvature="0"
+         fill-rule="evenodd"
+         clip-rule="evenodd"
+         d="m 85,6 h 7 v 5 h -7 z m 1,1 h 5 v 3 h -5 z"
+         id="path1838" />
+      <path
+         inkscape:connector-curvature="0"
+         fill-rule="evenodd"
+         clip-rule="evenodd"
+         d="M 82.5,2 C 81.67157,2 81,2.67157 81,3.5 v 9 c 0,0.8284 0.67157,1.5 1.5,1.5 H 93 c 0.8284,0 1.5,-0.6716 1.5,-1.5 v -9 C 94.5,2.67157 93.8284,2 93,2 Z m 0,10.5 V 5 H 93 v 7.5 z"
+         id="path1840" />
+    </g>
+  </g>
+</svg>

package/front_end/Images/src/frame-icon.svg

@@ -0,0 +1,54 @@
+<?xml version="1.0" encoding="UTF-8" standalone="no"?>
+<!-- Created with Inkscape (http://www.inkscape.org/) -->
+
+<svg
+   width="15"
+   height="13"
+   viewBox="0 0 3.9687499 3.4395834"
+   version="1.1"
+   id="svg358"
+   inkscape:version="1.1.2 (0a00cf5339, 2022-02-04)"
+   sodipodi:docname="frame-icon.svg"
+   xmlns:inkscape="http://www.inkscape.org/namespaces/inkscape"
+   xmlns:sodipodi="http://sodipodi.sourceforge.net/DTD/sodipodi-0.dtd"
+   xmlns="http://www.w3.org/2000/svg"
+   xmlns:svg="http://www.w3.org/2000/svg">
+  <sodipodi:namedview
+     id="namedview360"
+     pagecolor="#ffffff"
+     bordercolor="#666666"
+     borderopacity="1.0"
+     inkscape:pageshadow="2"
+     inkscape:pageopacity="0.0"
+     inkscape:pagecheckerboard="0"
+     inkscape:document-units="mm"
+     showgrid="false"
+     units="px"
+     inkscape:zoom="20.496745"
+     inkscape:cx="18.807864"
+     inkscape:cy="21.661976"
+     inkscape:window-width="2142"
+     inkscape:window-height="1445"
+     inkscape:window-x="0"
+     inkscape:window-y="0"
+     inkscape:window-maximized="1"
+     inkscape:current-layer="layer1" />
+  <defs
+     id="defs355" />
+  <g
+     inkscape:label="Layer 1"
+     inkscape:groupmode="layer"
+     id="layer1">
+    <g
+       transform="matrix(0.26458333,0,0,0.26458333,-0.06614581,-0.39687497)"
+       id="g1834"
+       style="fill:#000000">
+      <path
+         inkscape:connector-curvature="0"
+         fill-rule="evenodd"
+         clip-rule="evenodd"
+         d="M 1,3.5 C 1,2.67157 1.67157,2 2.5,2 H 13 c 0.8284,0 1.5,0.67157 1.5,1.5 v 9 C 14.5,13.3284 13.8284,14 13,14 H 2.5 C 1.67157,14 1,13.3284 1,12.5 Z M 2.5,5 v 7.5 H 13 V 5 Z"
+         id="path1822" />
+    </g>
+  </g>
+</svg>

package/front_end/Images/src/trash_bin_material_icon.svg

@@ -0,0 +1 @@
+<svg xmlns="http://www.w3.org/2000/svg" height="48" width="48"><path d="M12.8 42.7q-1.6 0-2.775-1.175Q8.85 40.35 8.85 38.75v-28H8.3q-.85 0-1.425-.575Q6.3 9.6 6.3 8.75q0-.85.575-1.425Q7.45 6.75 8.3 6.75h8.65q0-.85.575-1.425.575-.575 1.425-.575h10.1q.85 0 1.45.6t.6 1.4h8.6q.85 0 1.425.575.575.575.575 1.425 0 .85-.575 1.425-.575.575-1.425.575h-.55v28q0 1.6-1.175 2.775Q36.8 42.7 35.2 42.7Zm0-31.95v28h22.4v-28Zm5.2 22.2q0 .7.5 1.2t1.2.5q.75 0 1.25-.5t.5-1.2V16.5q0-.75-.525-1.275Q20.4 14.7 19.7 14.7q-.75 0-1.225.525Q18 15.75 18 16.5Zm8.55 0q0 .7.525 1.2t1.225.5q.75 0 1.25-.5t.5-1.2V16.5q0-.75-.525-1.275Q29 14.7 28.3 14.7q-.75 0-1.25.525t-.5 1.275ZM12.8 10.75v28-28Z"/></svg>

package/front_end/Images/src/triangle-expanded.svg

@@ -1 +1 @@
-<svg height="48" viewBox="0 0 48 48" width="48" xmlns="http://www.w3.org/2000/svg"><path d="M 10 10 h 28 l -14 20 L 10 10" /></svg>
+<svg height="48" viewBox="0 0 48 48" width="48" xmlns="http://www.w3.org/2000/svg"><path d="M 10 15 h 28 l -14 20 L 10 15" /></svg>

package/front_end/Tests.js

@@ -353,31 +353,6 @@
     this.takeControl();
   };
 
-  // Tests that pressing "Pause" will pause script execution if the script
-  // is already running.
-  TestSuite.prototype.testPauseWhenScriptIsRunning = function() {
-    this.showPanel('sources').then(function() {
-      this.evaluateInConsole_('setTimeout("handleClick()", 0)', didEvaluateInConsole.bind(this));
-    }.bind(this));
-
-    function didEvaluateInConsole(resultText) {
-      this.assertTrue(!isNaN(resultText), 'Failed to get timer id: ' + resultText);
-      // Wait for some time to make sure that inspected page is running the
-      // infinite loop.
-      setTimeout(testScriptPause.bind(this), 300);
-    }
-
-    function testScriptPause() {
-      // The script should be in infinite loop. Click "Pause" button to
-      // pause it and wait for the result.
-      UI.panels.sources.togglePause();
-
-      this._waitForScriptPause(this.releaseControl.bind(this));
-    }
-
-    this.takeControl();
-  };
-
   /**
    * Tests network size.
    */

package/front_end/core/common/ResourceType.ts

@@ -217,6 +217,9 @@ export class ResourceType {
   }
 
   static fromMimeTypeOverride(mimeType: string|null): ResourceType|null {
+    if (mimeType === 'application/manifest+json') {
+      return resourceTypes.Manifest;
+    }
     if (mimeType === 'application/wasm') {
       return resourceTypes.Wasm;
     }
@@ -413,6 +416,8 @@ export const resourceTypeByExtension = new Map([
   ['tif', resourceTypes.Image],
   ['tiff', resourceTypes.Image],
 
+  ['webmanifest', resourceTypes.Manifest],
+
   ['webp', resourceTypes.Media],
 
   ['otf', resourceTypes.Font],
@@ -435,6 +440,7 @@ export const mimeTypeByExtension = new Map([
   ['xml', 'application/xml'],
   ['xsl', 'application/xml'],
   ['wasm', 'application/wasm'],
+  ['webmanifest', 'application/manifest+json'],
 
   // HTML Embedded Scripts, ASP], JSP
   ['asp', 'application/x-aspx'],
@@ -474,7 +480,7 @@ export const mimeTypeByExtension = new Map([
   ['less', 'text/x-less'],
 
   // PHP
-  ['php', 'text/x-php'],
+  ['php', 'application/x-httpd-php'],
   ['phtml', 'application/x-httpd-php'],
 
   // Python

package/front_end/core/common/Revealer.ts

@@ -49,6 +49,9 @@ export let reveal = async function(revealable: Object|null, omitFocus?: boolean)
   const revealers =
       await Promise.all(getApplicableRegisteredRevealers(revealable).map(registration => registration.loadRevealer()));
 
+  if (!revealers.length) {
+    return Promise.reject(new Error('Can\'t reveal ' + revealable));
+  }
   return reveal(revealers);
   function reveal(revealers: Revealer[]): Promise<void> {
     const promises = [];

package/front_end/core/common/common.ts

@@ -24,6 +24,7 @@ import * as ResourceType from './ResourceType.js';
 import * as Revealer from './Revealer.js';
 import * as Runnable from './Runnable.js';
 import * as SegmentedRange from './SegmentedRange.js';
+import * as SettingRegistration from './SettingRegistration.js';
 import * as Settings from './Settings.js';
 import * as SimpleHistoryManager from './SimpleHistoryManager.js';
 import * as StringOutputStream from './StringOutputStream.js';
@@ -70,6 +71,7 @@ export {
   Runnable,
   SegmentedRange,
   Settings,
+  SettingRegistration,
   SimpleHistoryManager,
   StringOutputStream,
   TextDictionary,