telephony 1.0.3

data/spec/requests/providers/twilio/calls/dial_spec.rb

@@ -0,0 +1,132 @@
+require 'spec_helper'
+
+describe 'Dialing a whitelisted number' do
+  before do
+    @to = '8881234567'
+    @conversation = create :initiating_one_step_transferring_conversation
+    @call = @conversation.initiating_call
+    @child_call = @conversation.not_initiated_call
+
+    @existing_whitelist = Telephony.whitelist
+    Telephony.whitelist = [@to]
+  end
+
+  after do
+    Telephony.whitelist = @existing_whitelist
+  end
+
+  context 'when one-step transferring to an available agent' do
+    context "with a phone number" do
+      before do
+        agent = create :available_agent, phone_number: @to
+        @child_call.update_attributes agent: agent, number: @to
+
+        post "/zestphone/providers/twilio/calls/#{@call.id}/dial"
+      end
+
+      it 'returns TwiML for dialing to a specific number' do
+        xml = Nokogiri::XML response.body
+        dial = xml.at('/Response/Dial')
+        dial.attributes['method'].value.should == 'POST'
+        dial.attributes['action'].value.should == "/zestphone/providers/twilio/calls/#{@call.id}/child_detached"
+        dial.attributes['record'].value.should == 'true'
+        dial.attributes['timeout'].value.should == '15'
+        number = dial.at('Number')
+        number.attributes['url'].value.should == "/zestphone/providers/twilio/calls/#{@child_call.id}/child_answered"
+        number.text.should == @to
+      end
+    end
+
+    context "with a twilio client" do
+      before do
+        @agent = create :available_agent,
+          phone_type: Telephony::Agent::PhoneType::TWILIO_CLIENT
+        @child_call.update_attributes agent: @agent
+
+        post "/zestphone/providers/twilio/calls/#{@call.id}/dial"
+      end
+
+      it "returns TwiML for dialing to the agent's twilio client" do
+        xml = Nokogiri::XML response.body
+        dial = xml.at('/Response/Dial')
+        dial.attributes['method'].value.should == 'POST'
+        dial.attributes['action'].value.should == "/zestphone/providers/twilio/calls/#{@call.id}/child_detached"
+        dial.attributes['record'].value.should == 'true'
+        dial.attributes['timeout'].value.should == '15'
+        client = dial.at('Client')
+        client.attributes['url'].value.should == "/zestphone/providers/twilio/calls/#{@child_call.id}/child_answered"
+        client.text.should == "agent#{@agent.csr_id}"
+      end
+    end
+
+    context "with a sip" do
+      before do
+        @agent = create :available_agent,
+          phone_type: Telephony::Agent::PhoneType::SIP,
+          sip_number: 200,
+          call_center_name: 'other_location'
+        @child_call.update_attributes agent: @agent
+
+        post "/zestphone/providers/twilio/calls/#{@call.id}/dial"
+      end
+
+      it "returns TwiML for dialing to the agent's sip number" do
+        xml = Nokogiri::XML response.body
+        dial = xml.at('/Response/Dial')
+        dial.attributes['method'].value.should == 'POST'
+        dial.attributes['action'].value.should == "/zestphone/providers/twilio/calls/#{@call.id}/child_detached"
+        dial.attributes['record'].value.should == 'true'
+        dial.attributes['timeout'].value.should == '15'
+        client = dial.at('Sip')
+        client.attributes['url'].value.should == "/zestphone/providers/twilio/calls/#{@child_call.id}/child_answered"
+        client.text.should == "200@192.168.1.2"
+      end
+    end
+  end
+
+  context 'when leaving a voicemail for an unavailable agent' do
+    before do
+      @conversation.leave_voicemail!
+      @agent = create :not_available_agent, phone_number: @to
+      @child_call.update_attributes agent: @agent, number: @to
+
+      post "/zestphone/providers/twilio/calls/#{@call.id}/dial"
+    end
+
+    it 'returns TwiML for leaving a voicemail' do
+      xml = Nokogiri::XML response.body
+      say = xml.at '/Response/Say'
+      say.text.should =~ /at extension #{@agent.phone_ext}/i
+      say.text.should =~ /record your message/i
+      record = xml.at '/Response/Record'
+      record.attributes['action'].value.should == "/zestphone/providers/twilio/calls/#{@call.id}/voicemail?csr_id=#{@agent.csr_id}"
+    end
+  end
+end
+
+describe 'Dialing a non-whitelisted number' do
+  context "one step transferring to an agent" do
+    before do
+      @to = '8881234567'
+      @conversation = create :initiating_one_step_transferring_conversation
+      @call = @conversation.initiating_call
+      @child_call = @conversation.not_initiated_call
+      available_agent = create :available_agent, phone_number: @to
+      @child_call.update_attributes agent: available_agent
+      @existing_whitelist = Telephony.whitelist
+      Telephony.whitelist = []
+
+      post "/zestphone/providers/twilio/calls/#{@call.id}/dial"
+    end
+
+    after do
+      Telephony.whitelist = @existing_whitelist
+    end
+
+    it 'dials the number since we trust our agents' do
+      xml = Nokogiri::XML response.body
+      number = xml.at('/Response/Dial/Number')
+      number.text.should == @to
+    end
+  end
+end

data/spec/requests/providers/twilio/calls/done_spec.rb

@@ -0,0 +1,69 @@
+require 'spec_helper'
+
+describe 'When the callee does not answer' do
+  before do
+    agent = create :agent
+    @call = create :connecting_call, agent: agent
+
+    post "/zestphone/providers/twilio/calls/#{@call.id}/done",
+      { CallStatus: 'no-answer'}
+  end
+
+  it 'sets the call as terminated' do
+    @call.reload
+    @call.should be_terminated
+  end
+end
+
+describe 'When the call ends' do
+  before do
+    agent = create :agent
+    @call = create :call, agent: agent
+    @recording_url = 'recording_url'
+    @recording_duration = 0
+
+    post "/zestphone/providers/twilio/calls/#{@call.id}/done",
+      { CallStatus: 'completed',
+        RecordingUrl: @recording_url,
+        RecordingDuration: @recording_duration }
+
+    @call.reload
+  end
+
+  it 'saves the recording of the call' do
+    @call.recordings.last.url.should == @recording_url
+    @call.recordings.last.duration.should == @recording_duration
+  end
+
+  it 'terminates the call' do
+    @call.should be_terminated
+  end
+
+  it 'returns TwiML saying the caller on the other end has hung up' do
+    xml = Nokogiri::XML response.body
+    say = xml.at('/Response/Say')
+    say.text.should =~ /the caller on the other line has hung up/i
+  end
+end
+
+describe 'When the call has already not been answered' do
+  before do
+    agent = create :agent
+    @call = create :terminated_call, agent: agent
+    @recording_url = 'recording_url'
+    @recording_duration = 0
+    @call.should_not_receive(:no_answer!)
+
+    post "/zestphone/providers/twilio/calls/#{@call.id}/done",
+      { CallStatus: 'no-answer',
+        RecordingUrl: @recording_url,
+        RecordingDuration: @recording_duration }
+
+    @call.reload
+  end
+
+  it 'saves the recording of the call' do
+    @call.recordings.last.url.should == @recording_url
+    @call.recordings.last.duration.should == @recording_duration
+  end
+end

data/spec/requests/providers/twilio/calls/join_conference_spec.rb

@@ -0,0 +1,56 @@
+require 'spec_helper'
+
+describe 'Joining a conference' do
+
+  context "given an 'in_progress' conversation" do
+    before do
+      @conversation = create :in_progress_conversation_with_calls
+      @call = @conversation.active_agent_leg
+      @original_conversation_state = @call.conversation.state
+
+      post "/zestphone/providers/twilio/calls/#{@call.id}/join_conference"
+
+      @call.reload
+    end
+
+    it "updates the call's state to 'in_conference'" do
+      @call.should be_in_conference
+    end
+
+    it 'returns TwiML for joining a conference' do
+      @call.should join_conference
+    end
+
+    it 'does not change the conversation state' do
+      @call.conversation.state.should == @original_conversation_state
+    end
+  end
+
+  context "given an 'initiating_resume' conversation" do
+    before do
+      @conversation = create :initiating_resume_conversation
+      create :active_agent_leg, :state => 'in_conference', :conversation => @conversation
+      call = create :call, :state => 'in_progress_hold', :conversation => @conversation
+
+      post "/zestphone/providers/twilio/calls/#{call.id}/join_conference"
+    end
+
+    it "triggers 'complete_resume' event on the conversation" do
+      @conversation.reload.should be_in_progress
+    end
+  end
+
+  context "given an 'initiating_hold' conversation" do
+    before do
+      @conversation = create :initiating_hold_conversation
+      agent_call = create :active_agent_leg, :state => 'in_progress', :conversation => @conversation
+      create :call, :state => 'in_progress_hold', :conversation => @conversation
+
+      post "/zestphone/providers/twilio/calls/#{agent_call.id}/join_conference"
+    end
+
+    it "triggers 'complete_hold' event on the conversation" do
+      @conversation.reload.should be_in_progress_hold
+    end
+  end
+end

data/spec/requests/providers/twilio/calls/leave_queue_spec.rb

@@ -0,0 +1,44 @@
+require 'spec_helper'
+
+describe 'When the caller hangs up' do
+  before do
+    @call = create :call
+
+    post "/zestphone/providers/twilio/calls/#{@call.id}/leave_queue",
+      { QueueResult: "hangup" }
+  end
+
+  it 'sets the call as terminated' do
+    @call.reload
+    @call.should be_terminated
+  end
+end
+
+describe 'When Twilio fails to enqueue the caller call' do
+  before do
+    @call = create :call
+    Rails.logger.should_receive(:error)
+
+    post "/zestphone/providers/twilio/calls/#{@call.id}/leave_queue",
+      { QueueResult: "error" }
+  end
+
+  it 'sets the call as terminated and logs the error' do
+    @call.reload
+    @call.should be_terminated
+  end
+end
+
+describe 'When the caller is taken from the queue' do
+  before do
+    @call = create :call
+
+    post "/zestphone/providers/twilio/calls/#{@call.id}/leave_queue",
+      { QueueResult: "redirected" }
+  end
+
+  it 'does not change the call state' do
+    @call.should be_not_initiated
+  end
+end
+

data/spec/requests/providers/twilio/calls/parent_answered_spec.rb

@@ -0,0 +1,59 @@
+require 'spec_helper'
+
+describe 'Answering a call' do
+  before do
+    @existing_whitelist = Telephony.whitelist
+    phone_number = '562-555-5555'
+    Telephony.whitelist = [phone_number]
+
+    agent = create :agent
+    @call = create :connecting_call, agent: agent
+    @participant = create :call,
+      number: phone_number,
+      conversation: @call.conversation
+
+    post "/zestphone/providers/twilio/calls/#{@call.id}/connect"
+  end
+
+  after do
+    Telephony.whitelist = @existing_whitelist
+  end
+
+  it "updates the conversation's customer's state to 'connecting'" do
+    @participant.reload
+    @participant.state.should == 'connecting'
+  end
+
+  it 'returns TwiML for calling the callee' do
+    xml = Nokogiri::XML response.body
+    dial = xml.at('/Response/Dial')
+    dial.attributes['action'].value.should == "/zestphone/providers/twilio/calls/#{@call.id}/child_detached"
+    dial.attributes['record'].value.should == 'true'
+    number = dial.at('Number')
+    number.attributes['url'].value.should == "/zestphone/providers/twilio/calls/#{@participant.id}/child_answered"
+    number.text.should == @participant.number
+  end
+end
+
+describe 'Answering a call to a non-whitelisted number' do
+  before do
+    @existing_whitelist = Telephony.whitelist
+    Telephony.whitelist = []
+    agent = create :agent
+    @call = create :connecting_call, agent: agent
+    create :participant,
+      conversation: @call.conversation
+
+    post "/zestphone/providers/twilio/calls/#{@call.id}/connect"
+  end
+
+  after do
+    Telephony.whitelist = @existing_whitelist
+  end
+
+  it 'returns TwiML that includes a message about the callee not being whitelisted' do
+    xml = Nokogiri::XML response.body
+    say = xml.at('/Response/Say')
+    say.text.should =~ /The number you are trying to call is not whitelisted/i
+  end
+end

data/spec/requests/providers/twilio/inbound/connect_dequeued_call_spec.rb

@@ -0,0 +1,124 @@
+require 'spec_helper'
+
+describe 'Connecting a dequeued call' do
+  context 'given a non-whitelisted phone number' do
+    before do
+      Telephony::Call.any_instance.stub(:whitelisted_number?).and_return false
+      call = create :call
+      agent = create :agent
+      create :connecting_agent_leg, conversation: call.conversation, agent: agent
+
+      post "/zestphone/providers/twilio/inbound_calls/connect?csr_id=#{agent.csr_id}",
+        CallSid: call.sid
+    end
+
+    it 'returns TwiML saying the number is not whitelisted' do
+      xml = Nokogiri::XML response.body
+      say = xml.at '/Response/Say'
+      say.text.should =~ /the number you are trying to call is not whitelisted/i
+    end
+  end
+
+  context 'given a whitelisted phone number' do
+    before do
+      Telephony.stub(:whitelisted?).and_return true
+      @conversation = create :conversation
+      customer_leg = create :call, conversation: @conversation
+      @agent = create :agent, phone_number: '222-333-4444'
+      create :connecting_agent_leg, conversation: @conversation, agent: @agent
+
+      post "/zestphone/providers/twilio/inbound_calls/connect?csr_id=#{@agent.csr_id}",
+        CallSid: customer_leg.sid
+    end
+
+    it 'creates an agent leg for the conversation' do
+      @conversation.reload
+      @conversation.should have(2).calls
+      agent_leg = @conversation.calls.last
+      agent_leg.agent.should == @agent
+    end
+
+    it 'connects the agent leg' do
+      @conversation.reload
+      agent_leg = @conversation.calls.last
+      agent_leg.should be_connecting
+    end
+
+    it 'returns TwiML for dialing the phone number' do
+      @conversation.reload
+      customer = @conversation.customer
+      agent_leg = @conversation.active_agent_leg
+
+      xml = Nokogiri::XML response.body
+
+      dial = xml.at '/Response/Dial'
+      dial.attributes['record'].value.should == "true"
+      dial.attributes['action'].value.should == "/zestphone/providers/twilio/calls/#{customer.id}/child_detached"
+
+      number = dial.at 'Number'
+      number.text.should == @agent.phone_number
+      number.attributes['url'].value.should == "/zestphone/providers/twilio/calls/#{agent_leg.id}/child_answered"
+    end
+  end
+
+  context 'given a twilio client number' do
+    before do
+      @conversation = create :conversation, caller_id: 'caller_id'
+      customer_leg = create :call, conversation: @conversation
+      @agent = create :agent, phone_type: Telephony::Agent::PhoneType::TWILIO_CLIENT
+      create :connecting_agent_leg, conversation: @conversation, agent: @agent
+
+      post "/zestphone/providers/twilio/inbound_calls/connect?csr_id=#{@agent.csr_id}",
+        CallSid: customer_leg.sid
+    end
+
+    it "returns TwiML for dialing the agent's twilio client" do
+      @conversation.reload
+      customer = @conversation.customer
+      agent_leg = @conversation.active_agent_leg
+
+      xml = Nokogiri::XML response.body
+
+      dial = xml.at '/Response/Dial'
+      dial.attributes['record'].value.should == "true"
+      dial.attributes['callerId'].value.should == "caller_id"
+      dial.attributes['action'].value.should == "/zestphone/providers/twilio/calls/#{customer.id}/child_detached"
+
+      client = dial.at 'Client'
+      client.text.should == "agent#{@agent.csr_id}"
+      client.attributes['url'].value.should == "/zestphone/providers/twilio/calls/#{agent_leg.id}/child_answered"
+    end
+  end
+
+  context 'given a sip number' do
+    before do
+      @conversation = create :conversation, caller_id: 'caller_id'
+      customer_leg = create :call, conversation: @conversation
+      @agent = create :agent,
+        phone_type: Telephony::Agent::PhoneType::SIP,
+        sip_number: '200',
+        call_center_name: 'other_location'
+      create :connecting_agent_leg, conversation: @conversation, agent: @agent
+
+      post "/zestphone/providers/twilio/inbound_calls/connect?csr_id=#{@agent.csr_id}",
+        CallSid: customer_leg.sid
+    end
+
+    it "returns TwiML for dialing the agent's sip address" do
+      @conversation.reload
+      customer = @conversation.customer
+      agent_leg = @conversation.active_agent_leg
+
+      xml = Nokogiri::XML response.body
+
+      dial = xml.at '/Response/Dial'
+      dial.attributes['record'].value.should == "true"
+      dial.attributes['callerId'].value.should == "caller_id"
+      dial.attributes['action'].value.should == "/zestphone/providers/twilio/calls/#{customer.id}/child_detached"
+
+      client = dial.at 'Sip'
+      client.text.should == "200@192.168.1.2"
+      client.attributes['url'].value.should == "/zestphone/providers/twilio/calls/#{agent_leg.id}/child_answered"
+    end
+  end
+end