telephony 1.0.3

data/spec/observers/telephony/event_observer_spec.rb

@@ -0,0 +1,19 @@
+require 'spec_helper'
+
+module Telephony
+  describe EventObserver do
+    before do
+      ActiveRecord::Base.observers.enable 'Telephony::EventObserver'
+      EventObserver.instance
+    end
+
+    describe "#after_create" do
+      let(:event) { build(:event) }
+
+      it "asks its event to publish itself" do
+        event.should_receive(:publish)
+        event.save!
+      end
+    end
+  end
+end

data/spec/requests/create_conversation_spec.rb

@@ -0,0 +1,39 @@
+require 'spec_helper'
+
+describe 'Creating a conversation', :vcr do
+  before do
+    agent = create :agent, csr_type: 'B'
+    attributes = {
+      from:      '310-456-7890',
+      to:        '310-765-4321',
+      loan_id:   1,
+      from_id:   agent.csr_id,
+      from_type: 'csr'
+    }
+    @existing_whitelist = Telephony.whitelist
+    Telephony.whitelist = [attributes[:from], attributes[:to]]
+    @conversation_count = Telephony::Conversation.count
+
+    xhr :post,
+      '/zestphone/conversations',
+      attributes
+  end
+
+  after do
+    Telephony.whitelist = @existing_whitelist
+  end
+
+  it 'creates a new conversation' do
+    Telephony::Conversation.count.should == @conversation_count + 1
+  end
+
+  it 'creates a new call' do
+    Telephony::Call.count.should == 2
+  end
+
+  it 'returns the conversation as JSON' do
+    conversation = Telephony::Conversation.last
+    json = JSON response.body
+    json['id'].should == conversation.id
+  end
+end

data/spec/requests/dequeue_call_spec.rb

@@ -0,0 +1,42 @@
+require 'spec_helper'
+
+describe 'Dequeue an inbound call' do
+  context "given there's an inbound call on hold" do
+    before do
+      conversation = create :conversation
+      create :call, conversation: conversation
+      create :available_agent, csr_id: 1
+      Telephony::Call.any_instance.should_receive(:redirect_to_inbound_connect)
+      Telephony::InboundConversationQueue.stub(:oldest_queued_conversation).and_return(conversation)
+
+      fake_finder = 'fake_finder'
+      Telephony.stub(:pop_url_finder).and_return(fake_finder)
+      fake_finder.stub(:find).and_return('some_url')
+
+      delete "/zestphone/inbound/front?csr_id=1"
+    end
+
+    it 'returns the dequeued call as JSON' do
+      json = JSON response.body
+      json['pop_url'].should == 'some_url'
+    end
+  end
+
+  context "given there is NO inbound call on hold" do
+    before do
+      create :available_agent, csr_id: 1
+      delete "/zestphone/inbound/front?csr_id=1"
+    end
+
+    it 'returns 404 Not Found' do
+      response.should be_not_found
+    end
+
+    it 'returns an error message' do
+      json = JSON response.body
+      errors = json['errors']
+      errors.should have(1).error
+      errors.first.should =~ /queue is empty/i
+    end
+  end
+end

data/spec/requests/list_conversations_spec.rb

@@ -0,0 +1,33 @@
+require 'spec_helper'
+
+describe 'List all conversations' do
+  context 'when there are conversations in the system' do
+    before do
+      create_list :terminated_conversation, 3
+      create_list :connecting_conversation, 2
+      create_list :in_progress_conversation, 4
+    end
+
+    context 'and given no filtering parameters' do
+      before do
+        xhr :get, '/zestphone/conversations'
+      end
+
+      it 'returns all conversations and their details' do
+        json = JSON response.body
+        json.should have(9).items
+      end
+    end
+
+    context 'and given filter parameters' do
+      before do
+        xhr :get, '/zestphone/conversations', state: 'terminated'
+      end
+
+      it 'returns only conversations that match those filters' do
+        json = JSON response.body
+        json.should have(3).items
+      end
+    end
+  end
+end

data/spec/requests/presences_spec.rb

@@ -0,0 +1,51 @@
+require 'spec_helper'
+
+describe 'Reloading the widget during a call', :vcr do
+  include PusherSignatureHelper
+
+  describe '#create' do
+    context "during a call" do
+      context "after a failed transfer" do
+        before do
+          @conversation1 = create(:connecting_conversation).tap do |conversation|
+            create :active_agent_leg, conversation: conversation
+            create :connecting_call, conversation: conversation
+          end
+
+          @conversation2 = create(:in_progress_conversation).tap do |conversation|
+            create :active_agent_leg, conversation: conversation
+            create :customer_leg, conversation: conversation
+          end
+
+          @conversation1.calls.last.answer!
+          @conversation1.start!
+
+          @agent = @conversation1.calls.first.agent
+          @agent.available!
+          @agent.on_a_call!
+
+          @payload = {
+            "presence" => {
+              "time_ms" => 9223372036854775705,
+              "events" => [
+                           { "name" => "member_added",
+                             "channel" => "presence-#{@agent.csr_id}",
+                             "user_id" => "#{@agent.id}" }
+                          ]
+            }
+          }
+        end
+
+        it "pushes the event for the active call" do
+          Telephony::Events::Base.last.should be_a_kind_of(Telephony::Events::Start)
+
+          @conversation2.transfer!(@conversation1.calls.first.agent.csr_id, true)
+
+          Telephony::Events::Start.any_instance.should_receive(:republish_only_for)
+          
+          post '/zestphone/signals/agents/presences', @payload.to_query, get_pusher_params(@payload)
+        end
+      end
+    end
+  end
+end

data/spec/requests/providers/twilio/calls/child_answered_spec.rb

@@ -0,0 +1,24 @@
+require 'spec_helper'
+
+describe 'The receiver answering the call' do
+  before do
+    conversation = create :conversation, state: :connecting
+    agent = create :agent
+    @call = create :call, sid: nil, state: :connecting,
+      conversation: conversation, agent: agent
+    @sid = 'sid123'
+
+    post "/zestphone/providers/twilio/calls/#{@call.id}/child_answered",
+      { CallSid: @sid }
+
+    @call.reload
+  end
+
+  it "updates the call's sid" do
+    @call.sid.should == @sid
+  end
+
+  it 'returns an empty TwiML document (whisper tone)' do
+    response.body.should be_whisper_tone
+  end
+end

data/spec/requests/providers/twilio/calls/child_detached_spec.rb

@@ -0,0 +1,249 @@
+require 'spec_helper'
+
+describe 'Given a two step transfer' do
+  before do
+    @conversation = create :conversation, state: :two_step_transferring
+    @call = create :active_agent_leg, conversation: @conversation
+    participant = create :call, conversation: @conversation
+
+    post "/zestphone/providers/twilio/calls/#{@call.id}/child_detached",
+      DialCallSid: participant.sid,
+      DialCallStatus: 'completed'
+  end
+
+  it 'returns TwiML for redirecting the caller into the same conference' do
+    @call.should join_conference
+  end
+end
+
+describe 'When the child call is completed' do
+  context 'and there is a DialCallDuration (which is supposed to mean that the call is hung up)' do
+    before do
+      agent = create :agent
+      @call = create :call, agent: agent
+      @conversation = @call.conversation
+      @child_call = create :call, conversation: @conversation
+      @recording_url = 'recording_url'
+      @recording_duration = 0
+
+      post "/zestphone/providers/twilio/calls/#{@call.id}/child_detached",
+        DialCallSid: @child_call.sid,
+        DialCallDuration: '0',
+        DialCallStatus: 'completed',
+        RecordingUrl: @recording_url,
+        RecordingDuration: @recording_duration
+    end
+
+    it 'returns TwiML to hangup the caller' do
+      response.body.should be_hangup
+    end
+
+    it 'terminates the child call' do
+      @child_call.reload
+      @child_call.should be_terminated
+    end
+  end
+
+  context "and the conversation is initiating_hold" do
+    context "and the agent's call is the parent" do
+      before do
+        agent         = create :agent
+        @agent_leg    = create :holding_agent_call, agent: agent
+        @conversation = @agent_leg.conversation
+        @cust_leg     = create :call, conversation: @conversation
+
+        post "/zestphone/providers/twilio/calls/#{@agent_leg.id}/child_detached",
+          DialCallSid: @cust_leg.sid,
+          DialCallStatus: 'completed'
+      end
+
+      it "sets call's state to 'in_conference'" do
+        @agent_leg.reload.should be_in_conference
+      end
+
+      it "redirects the call to a conference" do
+        @agent_leg.should join_conference
+      end
+    end
+
+    context "and the customer's call is the parent" do
+      before do
+        @cust_leg     = create :holding_cust_call
+        @conversation = @cust_leg.conversation
+        agent         = create :agent
+        @agent_leg    = create :holding_agent_call, agent: agent, conversation: @conversation
+
+        post "/zestphone/providers/twilio/calls/#{@cust_leg.id}/child_detached",
+          DialCallSid: @agent_leg.sid,
+          DialCallStatus: 'completed'
+      end
+
+      it "sets call's state to 'in_progress_hold'" do
+        @cust_leg.reload.should be_in_progress_hold
+      end
+
+      it "redirects the call to the hold queue" do
+        @cust_leg.should complete_hold
+      end
+    end
+  end
+
+  context 'and there is not a DialCallDuration' do
+    before do
+      agent = create :agent
+      @call = create :call, agent: agent
+      @conversation = @call.conversation
+      @child_call = create :call, conversation: @conversation
+      @recording_url = 'recording_url'
+      @recording_duration = 0
+
+      post "/zestphone/providers/twilio/calls/#{@call.id}/child_detached",
+        DialCallSid: @child_call.sid,
+        DialCallStatus: 'completed',
+        RecordingUrl: @recording_url,
+        RecordingDuration: @recording_duration
+    end
+
+    it 'does not terminate the child call' do
+      @child_call.reload
+      @child_call.should_not be_terminated
+    end
+  end
+end
+
+describe 'When the child call is unanswered' do
+  before do
+    call = create :active_agent_leg
+    @connecting_call = create :connecting_call, conversation: call.conversation, sid: nil
+    @sid = '123'
+
+    post "/zestphone/providers/twilio/calls/#{call.id}/child_detached",
+      DialCallStatus: 'no-answer',
+      DialCallSid: @sid
+  end
+
+  it 'sets the sid of the child call' do
+    @connecting_call.reload.sid.should == @sid
+  end
+
+  it 'sets the participant call state to no_answer' do
+    @connecting_call.reload
+    @connecting_call.should be_terminated
+  end
+
+  it 'returns an empty TwiML response (whisper tone)' do
+    response.body.should be_hangup
+  end
+end
+
+describe 'When the child call fails' do
+  before do
+    call = create :active_agent_leg
+    @connecting_call = create :connecting_call, conversation: call.conversation, sid: nil
+    @sid = '123'
+
+    post "/zestphone/providers/twilio/calls/#{call.id}/child_detached",
+      DialCallStatus: 'failed',
+      DialCallSid: @sid
+  end
+
+  it 'sets the sid of the child call' do
+    @connecting_call.reload.sid.should == @sid
+  end
+
+  it 'sets the participant call state to call_failed' do
+    @connecting_call.reload
+    @connecting_call.should be_terminated
+  end
+
+  it 'returns an empty TwiML response (whisper tone)' do
+    response.body.should be_hangup
+  end
+end
+
+describe 'When the child call is busy' do
+  before do
+    call = create :active_agent_leg
+    @connecting_call = create :connecting_call, conversation: call.conversation, sid: nil
+    @sid = '123'
+
+    post "/zestphone/providers/twilio/calls/#{call.id}/child_detached",
+      DialCallStatus: 'busy',
+      DialCallSid: @sid
+  end
+
+  it 'sets the sid of the child call' do
+    @connecting_call.reload.sid.should == @sid
+  end
+
+  it 'sets the participant call state to busy' do
+    @connecting_call.reload
+    @connecting_call.should be_terminated
+  end
+
+  it 'returns an empty TwiML response (whisper tone)' do
+    response.body.should be_hangup
+  end
+end
+
+describe 'Given a one step transfer' do
+  context 'for a completed call' do
+    before do
+      agent = create :agent
+      @call = create :one_step_transfer_call, agent: agent
+      participant1 = create :in_progress_call, conversation: @call.conversation
+      create :connecting_call, conversation: @call.conversation
+
+      post "/zestphone/providers/twilio/calls/#{@call.id}/child_detached",
+        DialCallSid: participant1.sid,
+        DialCallStatus: 'completed'
+    end
+
+    it 'returns an empty TwiML response (whisper tone)' do
+      response.body.should be_hangup
+    end
+  end
+
+  context 'for an unanswered call' do
+    before do
+      @conversation = create :one_step_transferring_conversation
+      @agent = @conversation.active_agent_leg.agent
+
+      post "/zestphone/providers/twilio/calls/#{@conversation.customer.id}/child_detached",
+        DialCallStatus: 'no-answer'
+    end
+
+    it 'renders the voicemails/new twiml' do
+      xml = Nokogiri::XML response.body
+      say = xml.at '/Response/Say'
+      say.text.should =~ /at extension #{@agent.phone_ext}/i
+      say.text.should =~ /record your message/i
+      record = xml.at '/Response/Record'
+      record.attributes['action'].value.should == "/zestphone/providers/twilio/calls/#{@conversation.customer.id}/voicemail?csr_id=#{@agent.csr_id}"
+
+    end
+  end
+end
+
+describe 'Given a RONAed call' do
+  before do
+    conversation = create :rona_conversation
+    @customer_leg = conversation.customer
+    agent_leg = conversation.active_agent_leg
+
+    post "/zestphone/providers/twilio/calls/#{@customer_leg.id}/child_detached",
+      DialCallSid: agent_leg.sid,
+      DialCallStatus: 'no-answer'
+  end
+
+  it 'enqueues the call into the inbound queue' do
+    xml = Nokogiri::XML response.body
+    enqueue = xml.at '/Response/Enqueue'
+    enqueue.text.should == 'inbound'
+    enqueue.attributes['waitUrl'].value
+      .should =~ %r{/zestphone/providers/twilio/inbound_calls/wait_music$}
+    enqueue.attributes['waitUrlMethod'].value.should == 'GET'
+    enqueue.attributes['action'].value
+      .should == "/zestphone/providers/twilio/calls/#{@customer_leg.id}/leave_queue"
+  end
+end