blacklight-spotlight 0.4.1 → 0.5.0

data/app/views/spotlight/resources/csv/_form.html.erb

@@ -1,17 +0,0 @@
-<h3><%= t('spotlight.resources.csv.header') %></h3>
-<%= bootstrap_form_for [@resource.exhibit, @resource.becomes(Spotlight::Resources::Csv)], layout: :horizontal, label_col: 'col-md-3', control_col: 'col-sm-5 col-md-5', :html => {:multipart => true }  do |f| %>
-
-  <div class="form-group">
-  <%# bootstrap_form_for's file_field doesn't use any of the bootstrap 
-      goodness (bootstrap-ruby/rails-bootstrap-forms#49). Instead, we'll lie
-      about the field type and change the attribute ourselves. %>
-  <%= f.url_field :url, type: "file", help: link_to(t('.template'), [:template, @resource.exhibit, @resource.becomes(Spotlight::Resources::Csv)]) %>
-  <%= f.hidden_field :url_cache %>
-  </div>
-  <div class="form-actions col-md-7 col-sm-7">
-    <div class="primary-actions">
-      <%= cancel_link @resource, :back, class: 'btn btn-default' %>
-      <%= f.submit nil, class: 'btn btn-primary' %>
-    </div>
-  </div>
-<% end %>

data/app/views/spotlight/resources/csv/new.html.erb

@@ -1,3 +0,0 @@
-<%= curation_page_title %>
-
-<%= render 'form' %>

data/spec/controllers/spotlight/blacklight_configurations_controller_spec.rb

@@ -1,167 +0,0 @@
-require 'spec_helper'
-describe Spotlight::BlacklightConfigurationsController, :type => :controller do
-  routes { Spotlight::Engine.routes }
-  let(:exhibit) { FactoryGirl.create(:exhibit) }
-
-  describe "when the user is not authorized" do
-    before do
-      sign_in FactoryGirl.create(:exhibit_visitor)
-    end
-
-    it "should deny access" do
-      get :metadata_fields, exhibit_id: exhibit 
-      expect(response).to redirect_to main_app.root_path
-      expect(flash[:alert]).to be_present
-    end
-    
-    it "should deny access" do
-      get :edit_metadata_fields, exhibit_id: exhibit 
-      expect(response).to redirect_to main_app.root_path
-      expect(flash[:alert]).to be_present
-    end
-    
-    it "should deny access" do
-      get :edit_facet_fields, exhibit_id: exhibit 
-      expect(response).to redirect_to main_app.root_path
-      expect(flash[:alert]).to be_present
-    end
-  end
-
-  describe "when not logged in" do
-    describe "#update" do
-      it "should not be allowed" do
-        patch :update, exhibit_id: exhibit 
-        expect(response).to redirect_to main_app.new_user_session_path
-      end
-    end
-
-    describe "#edit_metadata_fields" do
-      it "should not be allowed" do
-        get :edit_metadata_fields, exhibit_id: exhibit
-        expect(response).to redirect_to main_app.new_user_session_path
-      end
-    end
-
-    describe "#edit_facet_fields" do
-      it "should not be allowed" do
-        get :edit_facet_fields, exhibit_id: exhibit
-        expect(response).to redirect_to main_app.new_user_session_path
-      end
-    end
-  end
-
-  describe "when signed in" do
-    let(:user) { FactoryGirl.create(:exhibit_admin, exhibit: exhibit) }
-    before {sign_in user }
-
-    describe "#edit_metadata_fields" do
-      it "should be successful" do
-        expect(controller).to receive(:add_breadcrumb).with("Home", exhibit)
-        expect(controller).to receive(:add_breadcrumb).with("Curation", exhibit_dashboard_path(exhibit))
-        expect(controller).to receive(:add_breadcrumb).with("Metadata", exhibit_edit_metadata_path(exhibit))
-        get :edit_metadata_fields, exhibit_id: exhibit
-        expect(response).to be_successful
-      end
-    end
-
-    describe "#edit_facet_fields" do
-      it "should be successful" do
-        expect(controller).to receive(:add_breadcrumb).with("Home", exhibit)
-        expect(controller).to receive(:add_breadcrumb).with("Curation", exhibit_dashboard_path(exhibit))
-        expect(controller).to receive(:add_breadcrumb).with("Search facets", exhibit_edit_facets_path(exhibit))
-        allow(controller).to receive_message_chain(:repository, :send_and_receive).and_return({})
-        get :edit_facet_fields, exhibit_id: exhibit
-        expect(response).to be_successful
-      end
-    end
-
-    describe "#edit_sort_fields" do
-      it "should be successful" do
-        expect(controller).to receive(:add_breadcrumb).with("Home", exhibit)
-        expect(controller).to receive(:add_breadcrumb).with("Curation", exhibit_dashboard_path(exhibit))
-        expect(controller).to receive(:add_breadcrumb).with("Sort fields", exhibit_edit_sort_fields_path(exhibit))
-        get :edit_sort_fields, exhibit_id: exhibit
-        expect(response).to be_successful
-      end
-    end
-
-    describe "#metadata_fields" do
-      it "should be successful" do
-        get :metadata_fields, exhibit_id: exhibit, format: 'json'
-        expect(response).to be_successful
-        expect(JSON.parse(response.body).keys).to eq exhibit.blacklight_config.index_fields.keys
-      end
-    end
-
-    describe "#available_search_views" do
-      it "should be successful" do
-        get :available_search_views, exhibit_id: exhibit, format: 'json'
-        expect(response).to be_successful
-        available = JSON.parse(response.body)
-        expect(available).to match_array ['list', 'gallery', 'slideshow']
-      end
-    end
-
-    describe "#alternate_count" do
-      before { controller.instance_variable_set(:@blacklight_configuration, exhibit.blacklight_configuration) }
-      subject { controller.alternate_count }
-      its(:count) { should eq 7 }
-      it "should have correct numbers" do
-        expect(subject['genre_ssim']).to eq 54
-      end
-    end
-
-    describe "#update" do
-
-      it "should update metadata fields" do
-        blacklight_config = Blacklight::Configuration.new
-        blacklight_config.add_index_field ['a', 'b', 'c', 'd', 'e', 'f']
-        allow(::CatalogController).to receive_messages(blacklight_config: blacklight_config)
-        patch :update, exhibit_id: exhibit, blacklight_configuration: {
-          index_fields: {
-            c: { enabled: true, show: true},
-            d: { enabled: true, show: true},
-            e: { enabled: true, list: true},
-            f: { enabled: true, list: true}
-          }
-        }
-
-        expect(flash[:notice]).to eq "The exhibit was successfully updated."
-        expect(response).to redirect_to exhibit_edit_metadata_path(exhibit)
-        assigns[:exhibit].tap do |saved|
-          expect(saved.blacklight_configuration.index_fields).to include 'c', 'd', 'e', 'f'
-        end
-      end
-
-      it "should update facet fields" do
-        patch :update, exhibit_id: exhibit, blacklight_configuration: { 
-          facet_fields: { 'genre_ssim' => { enabled: '1', label: "Label"} }  
-        }
-        expect(flash[:notice]).to eq "The exhibit was successfully updated."
-        expect(response).to redirect_to exhibit_edit_facets_path(exhibit)
-        assigns[:exhibit].tap do |saved|
-          expect(saved.blacklight_configuration.facet_fields.keys).to eq ['genre_ssim']
-        end
-      end
-
-      it "should update sort fields" do
-        patch :update, exhibit_id: exhibit, blacklight_configuration: { 
-          sort_fields: {"relevance"=>{"enabled" => "1", "label" => "Relevance"}, "title"=>{"enabled" => "1", "label" => "Title"}, "type"=>{"enabled" => "1", "label" => "Type"}, "date"=>{"enabled" => "0", "label" => "Date"}, "source"=>{"enabled" => "0", "label" => "Source"}, "identifier"=>{"enabled" => "0", "label" => "Identifier"}}
-        }
-        expect(flash[:notice]).to eq "The exhibit was successfully updated."
-        expect(response).to redirect_to exhibit_edit_sort_fields_path(exhibit)
-        assigns[:exhibit].tap do |saved|
-          expect(saved.blacklight_configuration.sort_fields).to eq(
-            {"relevance" => {"label"=>"Relevance", "enabled"=>true},
-             "title" => {"label" => "Title", "enabled"=>true},
-             "type" => {"label" => "Type", "enabled"=>true},
-             "date" => {"label" => "Date", "enabled"=>false},
-             "source" => {"label" => "Source", "enabled"=>false},
-             "identifier" => {"label" => "Identifier", "enabled"=>false}
-            }
-          )
-        end
-      end
-    end
-  end
-end

data/spec/features/edit_sort_fields_spec.rb

@@ -1,42 +0,0 @@
-require "spec_helper"
-
-describe "Sort Fields Administration", :type => :feature do
-  let(:exhibit) { FactoryGirl.create(:exhibit) }
-  let(:exhibit_curator) { FactoryGirl.create(:exhibit_curator, exhibit: exhibit) }
-  before { login_as exhibit_curator }
-
-  describe "edit" do
-    it "should display the sort fields edit screen" do
-      visit spotlight.exhibit_edit_sort_fields_path(exhibit)
-      expect(page).to have_css("h1 small", text: "Sort fields")
-    end
-
-    it "should update options" do
-      visit spotlight.exhibit_edit_sort_fields_path(exhibit)
-
-      # #field_labeled doesn't appear to work for disabled inputs
-      expect(page).to have_css("input[name='blacklight_configuration[sort_fields][relevance][enable]'][disabled='disabled']")
-      expect(page).to have_css("#nested-sort-fields .dd-item:nth-child(5) h3", text: "Identifier")
-
-      uncheck "blacklight_configuration_sort_fields_title_enabled"
-      uncheck "blacklight_configuration_sort_fields_identifier_enabled"
-
-      find("#blacklight_configuration_sort_fields_type_weight").set("100")
-
-      click_button "Save changes"
-      
-      within "#sidebar" do
-        click_link "Sort fields"
-      end
-
-      expect(page).to have_css("input[name='blacklight_configuration[sort_fields][relevance][enable]'][disabled='disabled']")
-      expect(find("#blacklight_configuration_sort_fields_type_enabled")).to be_checked
-      expect(find("#blacklight_configuration_sort_fields_date_enabled")).to be_checked
-      expect(find("#blacklight_configuration_sort_fields_title_enabled")).to_not be_checked
-      expect(find("#blacklight_configuration_sort_fields_identifier_enabled")).to_not be_checked
-
-      # Type is now sorted last
-      expect(page).to have_css("#nested-sort-fields .dd-item:nth-child(5) h3", text: "Type")
-    end
-  end
-end

data/spec/features/exhibits/edit_facet_fields_spec.rb

@@ -1,37 +0,0 @@
-require 'spec_helper'
-
-describe "Editing metadata fields", type: :feature do
-  let(:exhibit) { FactoryGirl.create(:exhibit) }
-  let(:admin) { FactoryGirl.create(:exhibit_admin, exhibit: exhibit) }
-  before { login_as(admin) }
-
-  it "should allow curators to select and unselect facets for display" do
-    visit spotlight.exhibit_edit_facets_path exhibit
-
-    expect(page).to have_content "Curation Search Facets"
-    expect(page).to have_button "Save"
-
-    uncheck "blacklight_configuration_facet_fields_language_ssim_show" # Language
-    uncheck "blacklight_configuration_facet_fields_genre_ssim_show" # Genre
-    check   "blacklight_configuration_facet_fields_subject_temporal_ssim_show" # Era
-
-    click_on "Save changes"
-
-    expect(exhibit.reload.blacklight_config.facet_fields.select { |k,v| v.show }.keys).to include("subject_temporal_ssim")
-    expect(exhibit.blacklight_config.facet_fields.select { |k,v| v.show }.keys).to_not include("language_ssim", "genre_ssim")
-  end
-
-  it "should display information about the facet" do
-    visit spotlight.exhibit_edit_facets_path exhibit
-    within  ".facet-config-genre_ssim" do
-      expect(page).to have_content /\d+ items/
-      expect(page).to have_content  /(\d+) unique values/
-    end
-  end
-
-  it "should have breadcrumbs" do
-    visit spotlight.exhibit_edit_facets_path exhibit
-
-    expect(page).to have_breadcrumbs "Home", "Curation", "Search facets"
-  end
-end

data/spec/features/javascript/facet_admin_spec.rb

@@ -1,36 +0,0 @@
-require "spec_helper"
-
-feature "Facets Administration", js:  true do
-  let(:exhibit) { FactoryGirl.create(:exhibit) }
-  let(:exhibit_curator) { FactoryGirl.create(:exhibit_curator, exhibit: exhibit) }
-  before { login_as exhibit_curator }
-  it "should allow us to update the label with edit-in-place" do
-
-    input_id = "blacklight_configuration_facet_fields_genre_ssim_label"
-    visit spotlight.exhibit_home_page_path(exhibit, exhibit.home_page)
-    click_link exhibit_curator.email
-
-    within '#user-util-collapse .dropdown' do
-      click_link 'Dashboard'
-    end
-
-    click_link "Search facets"
-
-    facet = find(".edit-in-place", text: "Genre")
-    expect(page).not_to have_content("Topic")
-    expect(page).to have_css("input##{input_id}", visible: false)
-
-    facet.click
-
-    expect(page).to have_css("input##{input_id}", visible: true)
-
-    fill_in(input_id, with: "Topic")
-
-    click_button "Save changes"
-
-    expect(page).to have_content("The exhibit was successfully updated.")
-
-    expect(page).not_to have_content("Genre")
-    expect(page).to have_content("Topic")
-  end
-end

data/spec/features/search_facets_admin_spec.rb

@@ -1,19 +0,0 @@
-require "spec_helper"
-
-describe "Search Facets Administration", :type => :feature do
-  let(:exhibit) { FactoryGirl.create(:exhibit) }
-  let(:exhibit_curator) { FactoryGirl.create(:exhibit_curator, exhibit: exhibit) }
-  before { login_as exhibit_curator }
-
-  describe "edit" do
-    it "should display the facet edit screen" do
-      visit spotlight.exhibit_edit_facets_path(exhibit)
-      expect(page).to have_css("h1 small", text: "Search Facets")
-      within("[data-id='genre_ssim']") do
-        expect(page).to have_content("Genre")
-        expect(page).to have_content(/\d+ items/)
-        expect(page).to have_content("10 unique values")
-      end
-    end
-  end
-end

data/spec/features/update_appearance_spec.rb

@@ -1,58 +0,0 @@
-require 'spec_helper'
-
-describe "Update the appearance", :type => :feature do
-  let(:exhibit) { FactoryGirl.create(:exhibit) }
-  let(:user) { FactoryGirl.create(:exhibit_admin, exhibit: exhibit) }
-
-  before { login_as user }
-  it "should update appearance options" do
-    visit spotlight.exhibit_dashboard_path(exhibit)
-    within "#sidebar" do
-      click_link "Appearance"
-    end
-
-    click_link "Exhibit style"
-    uncheck "Searchable (offer searchbox and facet sidebar)"
-
-    click_link "Search results"
-    uncheck "List"
-
-    choose "20"
-
-    click_button "Save changes"
-
-    expect(page).to have_content("The appearance was successfully updated.")
-
-    within "#sidebar" do
-      click_link "Appearance"
-    end
-
-    click_link "Exhibit style"
-    expect(field_labeled('Searchable (offer searchbox and facet sidebar)')).to_not be_checked
-
-    click_link "Search results"
-    expect(field_labeled('List')).to_not be_checked
-    expect(field_labeled('Gallery')).to be_checked
-
-    expect(field_labeled('20')).to be_checked
-    expect(field_labeled('10')).to_not be_checked
-  end
-
-  it "should hide search features when the exhibit is not searchable" do
-    visit spotlight.exhibit_dashboard_path(exhibit)
-    within "#sidebar" do
-      click_link "Appearance"
-    end
-
-    uncheck "Searchable (offer searchbox and facet sidebar)"
-
-    click_button "Save changes"
-
-    visit spotlight.exhibit_root_path(exhibit)
-
-    expect(page).to_not have_link "Saved Searches"
-    expect(page).to_not have_link "History"
-    expect(page).to_not have_content "Limit your search"
-    expect(page).to_not have_css ".search-query-form"
-  end
-end

data/spec/helpers/spotlight/blacklight_configurations_helper_spec.rb

@@ -1,12 +0,0 @@
-require 'spec_helper'
-
-describe Spotlight::BlacklightConfigurationsHelper, type: :helper do
-  describe "#translate_sort_fields" do
-    let(:sort_config) {
-      Blacklight::OpenStructWithHashAccess.new({sort: "score asc, sort_title_ssi desc"})
-    }
-    it 'should translate sort fields' do
-      expect(translate_sort_fields(sort_config)).to eq 'relevancy score ascending, title descending'
-    end
-  end
-end

data/spec/models/spotlight/appearance_spec.rb

@@ -1,33 +0,0 @@
-require 'spec_helper'
-
-describe Spotlight::Appearance, :type => :model do
-  let(:config) { FactoryGirl.create(:exhibit).blacklight_configuration }
-  subject { Spotlight::Appearance.new config }
-
-  describe '#searchable' do
-    it 'should be delegated to the exhibit' do
-      expect(config.exhibit).to receive(:searchable)
-      subject.searchable
-    end
-  end
-
-  describe '#exhibit_params' do
-    it 'should include the searchable parameter' do
-      expect(subject.send(:exhibit_params, searchable: true)).to eq({searchable: true})
-    end
-    it 'should include the main_navigations_attribute parameter when main_navigations is present' do
-      expect(subject.send(:exhibit_params, searchable: false, main_navigations: {a: :a})[:main_navigations_attributes]).to eq([:a])
-    end
-  end
-
-  describe "#view_type_options" do
-    subject { Spotlight::Appearance.new(config).view_type_options }
-    it "should include the available view types" do
-      expect(subject).to include :list, :gallery, :slideshow
-    end
-
-    it "should not include rss or atom" do
-      expect(subject).not_to include :rss, :atom
-    end
-  end
-end

data/spec/models/spotlight/resources/csv_spec.rb

@@ -1,101 +0,0 @@
-require 'spec_helper'
-
-describe Spotlight::Resources::Csv, :type => :model do
-  let(:exhibit) { FactoryGirl.create :exhibit }
-  before do
-    allow(Spotlight::SolrDocument).to receive_messages(visibility_field: 'public_bsi')
-  end
-
-  describe "#to_solr" do
-    let(:csv) do
-      [
-        { 'id' => 15, 'a' => 1, 'b' => 2, 'extra' => 'ignore'},
-        { 'id' => 16, 'a' => 2, 'b' => 3},
-      ]
-    end
-
-    let(:label_to_field) do
-      { 'id' => 'id', 'a' => 'solr_field_a', 'b' => 'custom_field_b' }
-    end
-
-    before do
-      allow(subject).to receive_messages(csv: csv, label_to_field: label_to_field, exhibit: exhibit, to_global_id: "xyz")
-    end
-
-    it "should map csv headers to solr fields" do
-      expect(subject.to_solr).to have(2).items
-      expect(subject.to_solr.first).to include 'id' => [15], 'solr_field_a' => [1], 'custom_field_b' => [2]
-      expect(subject.to_solr.first).to_not include 'extra'
-      expect(subject.to_solr.last).to include 'id' => [16], 'solr_field_a' => [2], 'custom_field_b' => [3]
-    end
-  end
-
-  describe "#label_to_field" do
-    let(:blacklight_config) do
-      Blacklight::Configuration.new do |config|
-        config.index.title_field = 'my_title_field'
-        config.add_index_field 'a', label: "Field A"
-        config.add_index_field 'b', label: "Field B"
-
-        config.add_facet_field 'c', label: "Field C"
-        config.add_facet_field 'd', label: "Field D"
-      end
-
-    end
-
-    before do
-      allow(subject).to receive_messages(exhibit: double(blacklight_config: blacklight_config))
-    end
-    it "should include an id and title" do
-      expect(subject.label_to_field).to include "id" => "id", "Title" => "my_title_field", "Public" => 'public_bsi'
-    end
-
-    it "should include the index fields" do
-      expect(subject.label_to_field).to include "Field A" => "a", "Field B" => "b"
-    end
-
-    it "should include the facet fields" do
-      expect(subject.label_to_field).to include "Field C" => "c", "Field D" => "d"
-    end
-  end
-
-  describe "#csv" do
-    it "should load the uploaded file as CSV" do
-      allow(subject).to receive_messages(url: double(path: "/abc"))
-      expect(File).to receive(:open).with("/abc", "r").and_return(StringIO.new "a,b\n1,2")
-      csv = subject.csv
-      expect(csv).to be_a_kind_of CSV
-      expect(csv).to have(1).row
-    end
-  end
-
-  describe "persisting exhibit-specific fields into sidecar rows" do
-
-    let!(:custom_field) { FactoryGirl.create :custom_field, exhibit: exhibit }
-
-    let!(:csv_data) do
-      t = Tempfile.new "csv_data"
-      t.puts "id,Public,a,b,#{custom_field.label}"
-      t.puts "1,true,z,y,x"
-      t.puts "2,false,x,v,w"
-      t.rewind
-      t
-    end
-
-    before do
-      allow(subject).to receive_messages(reindex: true)
-      subject.exhibit = exhibit
-      subject.url = csv_data
-    end
-
-    it "should create sidecar files for custom fields" do
-      expect { subject.save! }.to change { Spotlight::SolrDocumentSidecar.count }.by(2)
-      row = subject.exhibit.solr_document_sidecars.where(document_id: "1").first
-      expect(row.public).to be_truthy
-      expect(row.data[custom_field.field]).to eq "x"
-      row = subject.exhibit.solr_document_sidecars.where(document_id: "2").first
-      expect(row.public).to be_falsey
-      expect(row.data[custom_field.field]).to eq "w"
-    end
-  end
-end