blacklight-spotlight 0.4.1 → 0.5.0

data/spec/views/spotlight/pages/index.html.erb_spec.rb

@@ -1,28 +1,30 @@
 require 'spec_helper'
 
-describe "spotlight/pages/index.html.erb", :type => :view do
-  let(:pages) {[
+describe 'spotlight/pages/index.html.erb', type: :view do
+  let(:pages) do
+    [
       stub_model(Spotlight::FeaturePage,
-        title: "Title1",
-        content: "[]",
-        exhibit: exhibit
-      ),
+                 title: 'Title1',
+                 content: '[]',
+                 exhibit: exhibit
+                ),
       stub_model(Spotlight::FeaturePage,
-        title: "Title2",
-        content: "[]",
-        exhibit: exhibit
-      )
-    ]}
+                 title: 'Title2',
+                 content: '[]',
+                 exhibit: exhibit
+                )
+    ]
+  end
   let(:exhibit) { stub_model(Spotlight::Exhibit) }
   before do
     allow(view).to receive(:page_collection_name).and_return(:feature_pages)
-    allow(view).to receive(:update_all_exhibit_feature_pages_path).and_return("/exhibit/features/update_all")
+    allow(view).to receive(:update_all_exhibit_feature_pages_path).and_return('/exhibit/features/update_all')
     assign(:page, Spotlight::FeaturePage.new)
     assign(:exhibit, exhibit)
     allow(view).to receive(:current_exhibit).and_return(exhibit)
   end
 
-  it "renders a list of pages" do
+  it 'renders a list of pages' do
     assign(:pages, pages)
     allow(exhibit).to receive(:feature_pages).and_return pages
     render
@@ -30,12 +32,12 @@ describe "spotlight/pages/index.html.erb", :type => :view do
     expect(rendered).to have_selector '.panel-title', text: 'Title2'
   end
 
-  describe "Without pages" do
-    it "should not disable the update button" do
+  describe 'Without pages' do
+    it 'does not disable the update button' do
       assign(:pages, [])
       render
-      expect(rendered).not_to have_selector 'button[disabled]', text: "Save changes"
-      expect(rendered).to     have_selector 'button',           text: "Save changes"
+      expect(rendered).not_to have_selector 'button[disabled]', text: 'Save changes'
+      expect(rendered).to have_selector 'button', text: 'Save changes'
     end
   end
 end

data/spec/views/spotlight/pages/new.html.erb_spec.rb

@@ -1,20 +1,20 @@
 require 'spec_helper'
 
 module Spotlight
-  describe "spotlight/pages/new", :type => :view do
-    let(:exhibit) { stub_model(Exhibit) } 
+  describe 'spotlight/pages/new', type: :view do
+    let(:exhibit) { stub_model(Exhibit) }
     before do
       assign(:page, stub_model(FeaturePage, exhibit: exhibit).as_new_record)
       allow(view).to receive_messages(default_thumbnail_jcrop_options: {}, available_index_fields: [], available_view_fields: [])
     end
 
-    it "renders new page form" do
+    it 'renders new page form' do
       render
 
       # Run the generator again with the --webrat flag if you want to use webrat matchers
-      assert_select "form[action=?][method=?]", spotlight.exhibit_feature_pages_path(exhibit), "post" do
-        assert_select "input#feature_page_title[name=?]", "feature_page[title]"
-        assert_select "textarea#feature_page_content[name=?]", "feature_page[content]"
+      assert_select 'form[action=?][method=?]', spotlight.exhibit_feature_pages_path(exhibit), 'post' do
+        assert_select 'input#feature_page_title[name=?]', 'feature_page[title]'
+        assert_select 'textarea#feature_page_content[name=?]', 'feature_page[content]'
       end
     end
   end

data/spec/views/spotlight/pages/show.html.erb_spec.rb

@@ -1,65 +1,64 @@
 require 'spec_helper'
 
 module Spotlight
-  describe "spotlight/pages/show", :type => :view do
+  describe 'spotlight/pages/show', type: :view do
     let(:exhibit) { stub_model(Exhibit) }
-    let(:page) {
+    let(:page) do
       stub_model(FeaturePage,
-        :exhibit => exhibit,
-        :title => "Title",
-        :content => "[]"
-      )
-    }
+                 exhibit: exhibit,
+                 title: 'Title',
+                 content: '[]'
+                )
+    end
     before(:each) do
       allow(view).to receive(:current_exhibit).and_return(exhibit)
-      @page = assign(:page, page)
-      stub_template "spotlight/pages/_sidebar.html.erb" => "Sidebar"
-      
+      assign(:page, page)
+      stub_template 'spotlight/pages/_sidebar.html.erb' => 'Sidebar'
     end
 
-    it "should render the title as a heading" do
+    it 'renders the title as a heading' do
       render
-      expect(rendered).to have_css(".page-title", text: @page.title)
+      expect(rendered).to have_css('.page-title', text: page.title)
     end
-    it "should not render an empty heading" do
+    it 'does not render an empty heading' do
       allow(page).to receive_messages(title: nil)
       render
-      expect(rendered).to_not have_css(".page-title")
+      expect(rendered).to_not have_css('.page-title')
     end
-    
-    it "should inject the page title into the html title" do
+
+    it 'injects the page title into the html title' do
       expect(view).to receive(:set_html_page_title)
       render
     end
-    
-    it "should not include the page title" do
-      allow(page).to receive_messages(:should_display_title? => false)
+
+    it 'does not include the page title' do
+      allow(page).to receive_messages(should_display_title?: false)
       expect(view).to_not receive(:set_html_page_title)
       render
     end
 
-    it "renders attributes in <p>" do
+    it 'renders attributes in <p>' do
       render
       expect(rendered).to match(/Title/)
     end
 
-    it "should render the sidebar" do
+    it 'renders the sidebar' do
       page.display_sidebar = true
       render
-      expect(rendered).to match("Sidebar")
+      expect(rendered).to match('Sidebar')
     end
 
-    it "should not render the sidebar if the page has it disabled" do
+    it 'does not render the sidebar if the page has it disabled' do
       allow(page).to receive_messages(display_sidebar?: false)
       render
-      expect(rendered).to_not match("Sidebar")
+      expect(rendered).to_not match('Sidebar')
     end
 
-    it "should render an empty partial if the page has no content" do
-      allow(page).to receive_messages(has_content?: false)
-      stub_template "spotlight/pages/_empty.html.erb" => "Empty message"
+    it 'renders an empty partial if the page has no content' do
+      allow(page).to receive_messages(content?: false)
+      stub_template 'spotlight/pages/_empty.html.erb' => 'Empty message'
       render
-      expect(rendered).to have_content("Empty message")
+      expect(rendered).to have_content('Empty message')
     end
   end
 end

data/spec/views/spotlight/roles/index.html.erb_spec.rb

@@ -1,8 +1,8 @@
 require 'spec_helper'
 
 module Spotlight
-  describe "spotlight/roles/index", :type => :view do
-    let(:user) { stub_model(::User, email: 'jane@example.com') } 
+  describe 'spotlight/roles/index', type: :view do
+    let(:user) { stub_model(::User, email: 'jane@example.com') }
 
     let(:exhibit) { FactoryGirl.create(:exhibit) }
     let(:admin_role) { FactoryGirl.create(:role, role: 'admin', user: user, exhibit: exhibit) }
@@ -14,12 +14,12 @@ module Spotlight
       allow(exhibit).to receive(:roles).and_return roles
     end
 
-    it "renders the index page form" do
+    it 'renders the index page form' do
       render
 
-      assert_select "form[action=?][method=?]", spotlight.update_all_exhibit_roles_path(exhibit), "post" do
-        assert_select "tr[data-show-for=?]", admin_role.id
-        assert_select "tr[data-edit-for=?]", admin_role.id, 2
+      assert_select 'form[action=?][method=?]', spotlight.update_all_exhibit_roles_path(exhibit), 'post' do
+        assert_select 'tr[data-show-for=?]', admin_role.id
+        assert_select 'tr[data-edit-for=?]', admin_role.id, 2
         assert_select "input[type='submit'][data-behavior='destroy-user'][data-target=?]", admin_role.id
         assert_select "input[type='hidden'][data-destroy-for=?]", admin_role.id
         assert_select "a[data-behavior='cancel-edit']"

data/spec/views/spotlight/search_configurations/_search_fields.html.erb_spec.rb

@@ -0,0 +1,54 @@
+require 'spec_helper'
+
+module Spotlight
+  describe 'spotlight/search_configurations/_search_fields', type: :view do
+    let(:exhibit) { FactoryGirl.create(:exhibit) }
+    before do
+      assign(:exhibit, exhibit)
+      assign(:blacklight_configuration, exhibit.blacklight_configuration)
+      allow(view).to receive_messages(current_exhibit: exhibit)
+
+      exhibit.blacklight_config.add_search_field 'some_hidden_field', include_in_simple_select: false
+    end
+
+    let(:f) do
+      form_helper = nil
+      controller.view_context.bootstrap_form_for(exhibit.blacklight_configuration, url: '/update') do |f|
+        form_helper = f
+      end
+
+      form_helper
+    end
+
+    it 'has a fieldset with an appropriate legend' do
+      render partial: 'spotlight/search_configurations/search_fields', locals: { f: f }
+
+      expect(rendered).to have_selector 'fieldset legend', text: 'Field-based search'
+    end
+
+    it 'has a checkbox to enable or disable fielded search' do
+      render partial: 'spotlight/search_configurations/search_fields', locals: { f: f }
+
+      expect(rendered).to have_selector 'input[data-behavior="enable-feature"][data-target="#search_fields"]'
+    end
+
+    it 'has a read-only "all fields" search option' do
+      render partial: 'spotlight/search_configurations/search_fields', locals: { f: f }
+      expect(rendered).to have_selector "input[name='blacklight_configuration[search_fields][all_fields][enabled]'][data-readonly='true']"
+    end
+
+    it 'has search options for available search fields' do
+      render partial: 'spotlight/search_configurations/search_fields', locals: { f: f }
+
+      expect(rendered).to have_selector "input[name='blacklight_configuration[search_fields][title][enabled]']"
+      expect(rendered).to have_selector "input[name='blacklight_configuration[search_fields][author][enabled]']"
+    end
+
+    it 'excludes search options that do not show up in the search dropdown' do
+      render partial: 'spotlight/search_configurations/search_fields', locals: { f: f }
+
+      expect(rendered).not_to have_selector "input[name='blacklight_configuration[search_fields][autocomplete][enabled]']"
+      expect(rendered).not_to have_selector "input[name='blacklight_configuration[search_fields][some_hidden_field][enabled]']"
+    end
+  end
+end

data/spec/views/spotlight/search_configurations/_sort.html.erb_spec.rb

@@ -0,0 +1,28 @@
+require 'spec_helper'
+
+module Spotlight
+  describe 'spotlight/search_configurations/_sort', type: :view do
+    let(:exhibit) { FactoryGirl.create(:exhibit) }
+    before do
+      assign(:exhibit, exhibit)
+      assign(:blacklight_configuration, exhibit.blacklight_configuration)
+      allow(view).to receive_messages(
+        current_exhibit: exhibit,
+        translate_sort_fields: '')
+    end
+
+    let(:f) do
+      form_helper = nil
+      controller.view_context.bootstrap_form_for(exhibit.blacklight_configuration, url: '/update') do |f|
+        form_helper = f
+      end
+
+      form_helper
+    end
+
+    it 'has a disabled relevance sort option' do
+      render partial: 'spotlight/search_configurations/sort', locals: { f: f }
+      expect(rendered).to have_selector "input[name='blacklight_configuration[sort_fields][relevance][enable]'][disabled='disabled']"
+    end
+  end
+end

data/spec/views/spotlight/searches/_search.html.erb_spec.rb

@@ -1,13 +1,22 @@
 require 'spec_helper'
 
-describe "spotlight/searches/_search.html.erb", :type => :view do
-  
-  let(:search) { stub_model(Spotlight::Search, exhibit: FactoryGirl.create(:exhibit),
-        id: 99, title: "Title1", query_params: { f: { genre_ssim: ["xyz"]}}) }
+describe 'spotlight/searches/_search.html.erb', type: :view do
+  let(:search) do
+    FactoryGirl.build_stubbed(:search, exhibit: FactoryGirl.create(:exhibit),
+                                       id: 99,
+                                       title: 'Title1',
+                                       query_params: {
+                                         f: {
+                                           genre_ssim: ['xyz']
+                                         }
+                                       })
+  end
+
   before do
-    allow(view).to receive(:edit_search_path).and_return("/edit")
-    allow(view).to receive(:search_path).and_return("/search")
-    allow(search).to receive_message_chain(:thumbnail, :image, thumb: "/some/image")
+    allow(view).to receive(:edit_search_path).and_return('/edit')
+    allow(view).to receive(:search_path).and_return('/search')
+    allow(search).to receive_message_chain(:thumbnail, :image, thumb: '/some/image')
+    allow(search).to receive(:count).and_return(15)
     allow(search).to receive(:params).and_return({})
 
     form_for(search, url: '/update') do |f|
@@ -15,12 +24,13 @@ describe "spotlight/searches/_search.html.erb", :type => :view do
     end
   end
 
-  it "renders a list of pages" do
-    render :partial => "spotlight/searches/search", :locals => { f: @f}
+  it 'renders a list of pages' do
+    # rubocop:disable RSpec/InstanceVariable
+    render partial: 'spotlight/searches/search', locals: { f: @f }
+    # rubocop:enable RSpec/InstanceVariable
     expect(rendered).to have_selector "li[data-id='99']"
     expect(rendered).to have_selector '.panel-heading .main .title', text: 'Title1'
     expect(rendered).to have_selector 'img[src="/some/image"]'
     expect(rendered).to have_selector 'input[type=hidden][data-property=weight]'
   end
 end
-

data/spec/views/spotlight/searches/edit.html.erb_spec.rb

@@ -1,19 +1,20 @@
 require 'spec_helper'
 
-describe "spotlight/searches/edit.html.erb", :type => :view do
-  
+describe 'spotlight/searches/edit.html.erb', type: :view do
   let(:blacklight_config) do
     Blacklight::Configuration.new do |config|
       config.add_facet_field :some_field
     end
   end
   let(:exhibit) { FactoryGirl.create(:exhibit) }
-  let(:search) { stub_model(Spotlight::Search, exhibit: exhibit,
-        id: 99, title: "Title1", query_params: { f: { "some_field" => ["xyz"]}}) }
+  let(:search) do
+    stub_model(Spotlight::Search, exhibit: exhibit,
+                                  id: 99, title: 'Title1', query_params: { f: { 'some_field' => ['xyz'] } })
+  end
   before do
-    allow(view).to receive(:search_action_path).and_return("/search")
-    allow(view).to receive(:exhibit_search_path).and_return("/search")
-    allow(view).to receive(:exhibit_searches_path).and_return("/searches")
+    allow(view).to receive(:search_action_path).and_return('/search')
+    allow(view).to receive(:exhibit_search_path).and_return('/search')
+    allow(view).to receive(:exhibit_searches_path).and_return('/searches')
     allow(view).to receive(:blacklight_config).and_return(blacklight_config)
     assign(:exhibit, exhibit)
     assign(:search, search)
@@ -26,10 +27,10 @@ describe "spotlight/searches/edit.html.erb", :type => :view do
     expect(rendered).to have_selector 'form[data-autocomplete-exhibit-catalog-index-path]'
   end
 
-  it "renders active search constraints" do
+  it 'renders active search constraints' do
     render
     expect(rendered).to have_selector '.appliedFilter .constraint-value'
-    expect(rendered).to have_selector '.appliedFilter .constraint-value .filterName', text: "Some Field"
-    expect(rendered).to have_selector '.appliedFilter .constraint-value .filterValue', text: "xyz"
+    expect(rendered).to have_selector '.appliedFilter .constraint-value .filterName', text: 'Some Field'
+    expect(rendered).to have_selector '.appliedFilter .constraint-value .filterValue', text: 'xyz'
   end
-end
+end

data/spec/views/spotlight/searches/index.html.erb_spec.rb

@@ -1,28 +1,33 @@
 require 'spec_helper'
 
-describe "spotlight/searches/index.html.erb", :type => :view do
+describe 'spotlight/searches/index.html.erb', type: :view do
   let(:exhibit) { stub_model(Spotlight::Exhibit) }
 
   before do
-    allow(view).to receive_messages(update_all_exhibit_searches_path: "/")
+    allow(view).to receive_messages(update_all_exhibit_searches_path: '/')
     allow(view).to receive(:current_exhibit).and_return(exhibit)
     assign(:exhibit, exhibit)
   end
 
-  describe "Without searches" do
-    it "should disable the update button" do
+  describe 'Without searches' do
+    it 'disables the update button' do
       assign(:searches, [])
+      expect(exhibit).to receive(:searchable?).and_return(true)
       render
-      expect(rendered).to have_content "You can save search results"
+      expect(rendered).to have_content 'You can save search results'
     end
   end
 
   describe 'When the exhibit is not searchable' do
-    it 'should display a warning' do
+    it 'displays a warning' do
       assign(:searches, [])
       expect(exhibit).to receive(:searchable?).and_return(false)
       render
-      expect(rendered).to have_css('.alert-warning', text: "This exhibit is not currently searchable. To perform searches that can be saved as additional browse categories, an Administrator must temporarily turn on the Searchable option in the exhibit style section of the Administration > Appearance page.")
+      expect(rendered).to have_css '.alert-warning', text: %(\
+This exhibit is not currently searchable. To perform searches that can \
+be saved as additional browse categories, an Administrator must \
+temporarily turn on the Searchable option in the search configuration section \
+of the Administration > Appearance page.)
     end
   end
 end

data/spec/views/spotlight/sir_trevor/blocks/_iframe_block.html.erb_spec.rb

@@ -1,21 +1,20 @@
 require 'spec_helper'
 
-describe 'spotlight/sir_trevor/blocks/_iframe_block.html.erb', :type => :view do
-
-  let(:p) { "spotlight/sir_trevor/blocks/iframe_block.html.erb" }
+describe 'spotlight/sir_trevor/blocks/_iframe_block.html.erb', type: :view do
+  let(:p) { 'spotlight/sir_trevor/blocks/iframe_block.html.erb' }
   let(:block) do
     OpenStruct.new
   end
-  
-  it "should render iframes" do
+
+  it 'renders iframes' do
     block.code = "<iframe src='xyz'></iframe>"
     render partial: p, locals: { iframe_block: block }
     expect(rendered).to have_selector 'iframe[src="xyz"]'
   end
 
-  it "should strip extra markup from the code" do
-    block.code = "<a><b></b></a>"
+  it 'strips extra markup from the code' do
+    block.code = '<a><b></b></a>'
     render partial: p, locals: { iframe_block: block }
     expect(rendered).to be_blank
   end
-end
+end