blacklight-spotlight 0.4.1 → 0.5.0

data/spec/controllers/spotlight/feature_pages_controller_spec.rb

@@ -1,5 +1,5 @@
 require 'spec_helper'
-describe Spotlight::FeaturePagesController, :type => :controller do
+describe Spotlight::FeaturePagesController, type: :controller do
   routes { Spotlight::Engine.routes }
 
   it { is_expected.to be_a Spotlight::Catalog::AccessControlsEnforcement }
@@ -7,38 +7,38 @@ describe Spotlight::FeaturePagesController, :type => :controller do
   # This should return the minimal set of attributes required to create a valid
   # Page. As you add validations to Page, be sure to
   # adjust the attributes here as well.
-  let(:valid_attributes) { { "title" => "MyString" } }
-  describe "when signed in as a curator" do
+  let(:valid_attributes) { { 'title' => 'MyString' } }
+  describe 'when signed in as a curator' do
     let(:exhibit) { FactoryGirl.create(:exhibit) }
     let(:user) { FactoryGirl.create(:exhibit_curator, exhibit: exhibit) }
-    before {sign_in user }
+    before { sign_in user }
 
-    describe "GET index" do
+    describe 'GET index' do
       let!(:page) { FactoryGirl.create(:feature_page, exhibit: exhibit) }
-      it "assigns all feature pages as @pages" do
-        expect(controller).to receive(:add_breadcrumb).with("Home", exhibit_root_path(exhibit))
-        expect(controller).to receive(:add_breadcrumb).with("Curation", exhibit_dashboard_path(exhibit))
-        expect(controller).to receive(:add_breadcrumb).with("Feature pages", exhibit_feature_pages_path(exhibit))
+      it 'assigns all feature pages as @pages' do
+        expect(controller).to receive(:add_breadcrumb).with('Home', exhibit_root_path(exhibit))
+        expect(controller).to receive(:add_breadcrumb).with('Curation', exhibit_dashboard_path(exhibit))
+        expect(controller).to receive(:add_breadcrumb).with('Feature pages', exhibit_feature_pages_path(exhibit))
         get :index, exhibit_id: exhibit
         expect(assigns(:pages)).to include page
         expect(assigns(:exhibit)).to eq exhibit
       end
     end
 
-    describe "GET show" do
-      describe "on a top level page" do
+    describe 'GET show' do
+      describe 'on a top level page' do
         let(:page) { FactoryGirl.create(:feature_page, exhibit: exhibit) }
-        it "assigns the requested page as @page" do
-          expect(controller).to receive(:add_breadcrumb).with("Home", exhibit_root_path(exhibit))
+        it 'assigns the requested page as @page' do
+          expect(controller).to receive(:add_breadcrumb).with('Home', exhibit_root_path(exhibit))
           expect(controller).to receive(:add_breadcrumb).with(page.title, [exhibit, page])
           get :show, exhibit_id: page.exhibit.id, id: page
           expect(assigns(:page)).to eq(page)
         end
       end
-      describe "on a sub-page" do
+      describe 'on a sub-page' do
         let(:page) { FactoryGirl.create(:feature_subpage, exhibit: exhibit) }
-        it "assigns the requested page as @page" do
-          expect(controller).to receive(:add_breadcrumb).with("Home", exhibit_root_path(exhibit))
+        it 'assigns the requested page as @page' do
+          expect(controller).to receive(:add_breadcrumb).with('Home', exhibit_root_path(exhibit))
           expect(controller).to receive(:add_breadcrumb).with(page.parent_page.title, [exhibit, page.parent_page])
           expect(controller).to receive(:add_breadcrumb).with(page.title, [exhibit, page])
           get :show, exhibit_id: page.exhibit, id: page
@@ -47,66 +47,66 @@ describe Spotlight::FeaturePagesController, :type => :controller do
       end
     end
 
-    describe "GET new" do
-      it "assigns a new page as @page" do
+    describe 'GET new' do
+      it 'assigns a new page as @page' do
         get :new, exhibit_id: exhibit
         expect(assigns(:page)).to be_a_new(Spotlight::FeaturePage)
         expect(assigns(:page).exhibit).to eq exhibit
       end
     end
 
-    describe "GET edit" do
+    describe 'GET edit' do
       let(:page) { FactoryGirl.create(:feature_subpage, exhibit: exhibit) }
-      it "assigns the requested page as @page" do
-        expect(controller).to receive(:add_breadcrumb).with("Home", exhibit_root_path(exhibit))
-        expect(controller).to receive(:add_breadcrumb).with("Feature pages", exhibit_feature_pages_path(exhibit))
+      it 'assigns the requested page as @page' do
+        expect(controller).to receive(:add_breadcrumb).with('Home', exhibit_root_path(exhibit))
+        expect(controller).to receive(:add_breadcrumb).with('Feature pages', exhibit_feature_pages_path(exhibit))
         expect(controller).to receive(:add_breadcrumb).with(page.parent_page.title, [exhibit, page.parent_page])
         expect(controller).to receive(:add_breadcrumb).with(page.title, [:edit, exhibit, page])
-        get :edit, exhibit_id: page.exhibit.id,id: page.id
+        get :edit, exhibit_id: page.exhibit.id, id: page.id
         expect(assigns(:page)).to eq page
       end
     end
 
-    describe "POST create" do
-      describe "with valid params" do
-        it "creates a new Page" do
-          expect {
-            post :create, feature_page: {title: "MyString"} , exhibit_id: exhibit
-          }.to change(Spotlight::FeaturePage, :count).by(1)
+    describe 'POST create' do
+      describe 'with valid params' do
+        it 'creates a new Page' do
+          expect do
+            post :create, feature_page: { title: 'MyString' }, exhibit_id: exhibit
+          end.to change(Spotlight::FeaturePage, :count).by(1)
         end
 
-        it "assigns a newly created page as @page" do
-          post :create, feature_page: {title: "MyString"}, exhibit_id: exhibit
+        it 'assigns a newly created page as @page' do
+          post :create, feature_page: { title: 'MyString' }, exhibit_id: exhibit
           expect(assigns(:page)).to be_a(Spotlight::FeaturePage)
           expect(assigns(:page)).to be_persisted
         end
-        it "redirects to the feature page index" do
-          post :create, feature_page: {title: "MyString"}, exhibit_id: exhibit
+        it 'redirects to the feature page index' do
+          post :create, feature_page: { title: 'MyString' }, exhibit_id: exhibit
           expect(response).to redirect_to(exhibit_feature_pages_path(Spotlight::FeaturePage.last.exhibit))
         end
       end
 
-      describe "with invalid params" do
-        it "assigns a newly created but unsaved page as @page" do
+      describe 'with invalid params' do
+        it 'assigns a newly created but unsaved page as @page' do
           # Trigger the behavior that occurs when invalid params are submitted
           allow_any_instance_of(Spotlight::FeaturePage).to receive(:save).and_return(false)
-          post :create, feature_page: { "title" => "invalid value" }, exhibit_id: exhibit
+          post :create, feature_page: { 'title' => 'invalid value' }, exhibit_id: exhibit
           expect(assigns(:page)).to be_a_new(Spotlight::FeaturePage)
         end
 
         it "re-renders the 'new' template" do
           # Trigger the behavior that occurs when invalid params are submitted
           allow_any_instance_of(Spotlight::FeaturePage).to receive(:save).and_return(false)
-          post :create, feature_page: { "title" => "invalid value" }, exhibit_id: exhibit 
-          expect(response).to render_template("new")
+          post :create, feature_page: { 'title' => 'invalid value' }, exhibit_id: exhibit
+          expect(response).to render_template('new')
         end
       end
     end
 
-    describe "PUT update" do
+    describe 'PUT update' do
       let(:page) { FactoryGirl.create(:feature_page, exhibit: exhibit) }
-      describe "with valid params" do
-        it "updates the requested page" do
+      describe 'with valid params' do
+        it 'updates the requested page' do
           # Assuming there are no other pages in the database, this
           # specifies that the Page created on the previous line
           # receives the :update_attributes message with whatever params are
@@ -115,60 +115,60 @@ describe Spotlight::FeaturePagesController, :type => :controller do
           put :update, id: page, exhibit_id: page.exhibit.id, feature_page: valid_attributes
         end
 
-        it "assigns the requested page as @page" do
+        it 'assigns the requested page as @page' do
           put :update, id: page, exhibit_id: page.exhibit.id, feature_page: valid_attributes
           expect(assigns(:page)).to eq(page)
         end
 
-        it "redirects to the feature page" do
+        it 'redirects to the feature page' do
           put :update, id: page, exhibit_id: page.exhibit.id, feature_page: valid_attributes
           page.reload
           expect(response).to redirect_to(exhibit_feature_page_path(page.exhibit, page))
-          expect(flash[:notice]).to have_link "Undo changes"
+          expect(flash[:notice]).to have_link 'Undo changes'
         end
       end
 
-      describe "with invalid params" do
-        it "assigns the page as @page" do
+      describe 'with invalid params' do
+        it 'assigns the page as @page' do
           # Trigger the behavior that occurs when invalid params are submitted
           allow_any_instance_of(Spotlight::FeaturePage).to receive(:save).and_return(false)
-          put :update, id: page, exhibit_id: page.exhibit.id, feature_page: { "title" => "invalid value" }
+          put :update, id: page, exhibit_id: page.exhibit.id, feature_page: { 'title' => 'invalid value' }
           expect(assigns(:page)).to eq(page)
         end
 
         it "re-renders the 'edit' template" do
           # Trigger the behavior that occurs when invalid params are submitted
           allow_any_instance_of(Spotlight::FeaturePage).to receive(:save).and_return(false)
-          put :update, id: page, exhibit_id: page.exhibit.id, feature_page: { "title" => "invalid value" }
-          expect(response).to render_template("edit")
+          put :update, id: page, exhibit_id: page.exhibit.id, feature_page: { 'title' => 'invalid value' }
+          expect(response).to render_template('edit')
         end
       end
     end
 
-    describe "POST update_all" do
+    describe 'POST update_all' do
       let!(:page1) { FactoryGirl.create(:feature_page, exhibit: exhibit) }
       let!(:page2) { FactoryGirl.create(:feature_page, exhibit: page1.exhibit) }
       let!(:page3) { FactoryGirl.create(:feature_page, exhibit: page1.exhibit, parent_page_id: page1.id) }
-      before { request.env["HTTP_REFERER"] = "http://example.com" }
-      it "should update the parent/child relationship" do
-        post :update_all, exhibit_id: page1.exhibit, exhibit: {feature_pages_attributes: [{id: page2.id, parent_page_id: page1.id}]}
+      before { request.env['HTTP_REFERER'] = 'http://example.com' }
+      it 'updates the parent/child relationship' do
+        post :update_all, exhibit_id: page1.exhibit, exhibit: { feature_pages_attributes: [{ id: page2.id, parent_page_id: page1.id }] }
         expect(response).to redirect_to 'http://example.com'
-        expect(flash[:notice]).to eq "Feature pages were successfully updated."
+        expect(flash[:notice]).to eq 'Feature pages were successfully updated.'
         expect(page1.parent_page).to be_nil
         expect(page1.child_pages).to include page2
         expect(page3.parent_page).to eq page1 # should remain untouched since in wasn't present
       end
     end
 
-    describe "DELETE destroy" do
+    describe 'DELETE destroy' do
       let!(:page) { FactoryGirl.create(:feature_page, exhibit: exhibit) }
-      it "destroys the requested page" do
-        expect {
+      it 'destroys the requested page' do
+        expect do
           delete :destroy, id: page, exhibit_id: page.exhibit.id
-        }.to change(Spotlight::FeaturePage, :count).by(-1)
+        end.to change(Spotlight::FeaturePage, :count).by(-1)
       end
 
-      it "redirects to the pages list" do
+      it 'redirects to the pages list' do
         delete :destroy, id: page, exhibit_id: page.exhibit.id
         expect(response).to redirect_to(exhibit_feature_pages_path(page.exhibit))
       end

data/spec/controllers/spotlight/home_pages_controller_spec.rb

@@ -1,88 +1,88 @@
 require 'spec_helper'
 
-describe Spotlight::HomePagesController, :type => :controller do
+describe Spotlight::HomePagesController, type: :controller do
   routes { Spotlight::Engine.routes }
-  let(:valid_attributes) { { "title" => "MyString" } }
+  let(:valid_attributes) { { 'title' => 'MyString' } }
   let(:exhibit) { FactoryGirl.create(:exhibit) }
   let(:page) { exhibit.home_page }
 
   it { is_expected.to be_a Spotlight::Catalog::AccessControlsEnforcement }
 
-  describe "when signed in as a curator" do
+  describe 'when signed in as a curator' do
     let(:user) { FactoryGirl.create(:exhibit_curator) }
     before do
       FactoryGirl.create(:role, exhibit: exhibit, user: user)
       sign_in user
     end
 
-    describe "GET edit" do
+    describe 'GET edit' do
       describe "when the page title isn't set" do
         before do
           page.title = nil
         end
 
-        it "should show breadcrumbs" do
-          expect(controller).to receive(:add_breadcrumb).with("Home", exhibit_root_path(exhibit))
-          expect(controller).to receive(:add_breadcrumb).with("Feature pages", exhibit_feature_pages_path(exhibit))
-          expect(controller).to receive(:add_breadcrumb).with("Exhibit Home", [:edit, exhibit, page])
-          get :edit, id: page, exhibit_id: page.exhibit 
-          expect(response).to be_successful 
+        it 'shows breadcrumbs' do
+          expect(controller).to receive(:add_breadcrumb).with('Home', exhibit_root_path(exhibit))
+          expect(controller).to receive(:add_breadcrumb).with('Feature pages', exhibit_feature_pages_path(exhibit))
+          expect(controller).to receive(:add_breadcrumb).with('Exhibit Home', [:edit, exhibit, page])
+          get :edit, id: page, exhibit_id: page.exhibit
+          expect(response).to be_successful
         end
       end
-      it "should show breadcrumbs" do
-        expect(controller).to receive(:add_breadcrumb).with("Home", exhibit_root_path(exhibit))
-        expect(controller).to receive(:add_breadcrumb).with("Feature pages", exhibit_feature_pages_path(exhibit))
+      it 'shows breadcrumbs' do
+        expect(controller).to receive(:add_breadcrumb).with('Home', exhibit_root_path(exhibit))
+        expect(controller).to receive(:add_breadcrumb).with('Feature pages', exhibit_feature_pages_path(exhibit))
         expect(controller).to receive(:add_breadcrumb).with(page.title, [:edit, exhibit, page])
         get :edit, id: page, exhibit_id: page.exhibit
-        expect(response).to be_successful 
+        expect(response).to be_successful
       end
     end
-    describe "PUT update" do
-      it "redirects to the feature page index action" do
+    describe 'PUT update' do
+      it 'redirects to the feature page index action' do
         put :update, id: page, exhibit_id: page.exhibit.id, home_page: valid_attributes
         page.reload
         expect(response).to redirect_to(exhibit_home_page_path(page.exhibit, page))
-        expect(flash[:notice]).to have_link "Undo changes"
+        expect(flash[:notice]).to have_link 'Undo changes'
       end
     end
   end
 
-  describe "Rendering home page" do
-    it "should get search results for display facets" do
-      allow(controller).to receive_messages(get_search_results: [double, double])
+  describe 'Rendering home page' do
+    it 'gets search results for display facets' do
+      allow(controller).to receive_messages(search_results: [double, double])
       get :show, exhibit_id: exhibit
       expect(assigns[:response]).to_not be_blank
       expect(assigns[:document_list]).to_not be_blank
       expect(assigns[:page]).to eq exhibit.home_page
     end
-    it "should not render breadcrumbs" do
+    it 'does not render breadcrumbs' do
       expect(controller).not_to receive(:add_breadcrumb)
-      allow(controller).to receive_messages(get_search_results: [double, double])
+      allow(controller).to receive_messages(search_results: [double, double])
       get :show, exhibit_id: exhibit
       expect(response).to be_successful
     end
-    it "should not do the search when the sidebar is hidden" do
+    it 'does not do the search when the sidebar is hidden' do
       page.display_sidebar = false
       page.save
-      allow(controller).to receive_messages(get_search_results: [double, double])
+      allow(controller).to receive_messages(search_results: [double, double])
       get :show, exhibit_id: exhibit
       expect(assigns).not_to have_key :response
       expect(assigns).not_to have_key :document_list
     end
   end
 
-  describe "when the exhibit is not published" do
+  describe 'when the exhibit is not published' do
     before do
       exhibit.published = false
       exhibit.save!
     end
 
-    it "should redirect an anonymous user to the signin path" do
+    it 'redirects an anonymous user to the signin path' do
       get :show, exhibit_id: exhibit
       expect(response).to redirect_to(main_app.new_user_session_path)
     end
 
-    it "should redirect an unauthorized user to the signin path" do
+    it 'redirects an unauthorized user to the signin path' do
       user = FactoryGirl.create(:exhibit_curator)
       sign_in user
       expect do
@@ -90,7 +90,7 @@ describe Spotlight::HomePagesController, :type => :controller do
       end.to raise_error ActionController::RoutingError
     end
 
-    it "should redirect an authorized user to the signin path" do
+    it 'redirects an authorized user to the signin path' do
       user = FactoryGirl.create(:exhibit_curator)
       FactoryGirl.create(:role, exhibit: exhibit, user: user)
       sign_in user
@@ -98,5 +98,4 @@ describe Spotlight::HomePagesController, :type => :controller do
       expect(response).to be_successful
     end
   end
-
 end

data/spec/controllers/spotlight/metadata_configurations_controller_spec.rb

@@ -0,0 +1,84 @@
+require 'spec_helper'
+describe Spotlight::MetadataConfigurationsController, type: :controller do
+  routes { Spotlight::Engine.routes }
+  let(:exhibit) { FactoryGirl.create(:exhibit) }
+
+  describe 'when the user is not authorized' do
+    before do
+      sign_in FactoryGirl.create(:exhibit_visitor)
+    end
+
+    it 'denies access' do
+      get :show, exhibit_id: exhibit
+      expect(response).to redirect_to main_app.root_path
+      expect(flash[:alert]).to be_present
+    end
+
+    it 'denies access' do
+      get :edit, exhibit_id: exhibit
+      expect(response).to redirect_to main_app.root_path
+      expect(flash[:alert]).to be_present
+    end
+  end
+
+  describe 'when not logged in' do
+    describe '#update' do
+      it 'denies access' do
+        patch :update, exhibit_id: exhibit
+        expect(response).to redirect_to main_app.new_user_session_path
+      end
+    end
+
+    describe '#edit' do
+      it 'denies access' do
+        get :edit, exhibit_id: exhibit
+        expect(response).to redirect_to main_app.new_user_session_path
+      end
+    end
+  end
+
+  describe 'when signed in' do
+    let(:user) { FactoryGirl.create(:exhibit_admin, exhibit: exhibit) }
+    before { sign_in user }
+
+    describe '#edit' do
+      it 'is successful' do
+        expect(controller).to receive(:add_breadcrumb).with('Home', exhibit)
+        expect(controller).to receive(:add_breadcrumb).with('Curation', exhibit_dashboard_path(exhibit))
+        expect(controller).to receive(:add_breadcrumb).with('Metadata', edit_exhibit_metadata_configuration_path(exhibit))
+        get :edit, exhibit_id: exhibit
+        expect(response).to be_successful
+      end
+    end
+
+    describe '#show' do
+      it 'is successful' do
+        get :show, exhibit_id: exhibit, format: 'json'
+        expect(response).to be_successful
+        expect(JSON.parse(response.body).keys).to eq exhibit.blacklight_config.index_fields.keys
+      end
+    end
+
+    describe '#update' do
+      it 'updates metadata fields' do
+        blacklight_config = Blacklight::Configuration.new
+        blacklight_config.add_index_field %w(a b c d e f)
+        allow(::CatalogController).to receive_messages(blacklight_config: blacklight_config)
+        patch :update, exhibit_id: exhibit, blacklight_configuration: {
+          index_fields: {
+            c: { enabled: true, show: true },
+            d: { enabled: true, show: true },
+            e: { enabled: true, list: true },
+            f: { enabled: true, list: true }
+          }
+        }
+
+        expect(flash[:notice]).to eq 'The exhibit was successfully updated.'
+        expect(response).to redirect_to edit_exhibit_metadata_configuration_path(exhibit)
+        assigns[:exhibit].tap do |saved|
+          expect(saved.blacklight_configuration.index_fields).to include 'c', 'd', 'e', 'f'
+        end
+      end
+    end
+  end
+end

data/spec/controllers/spotlight/resources/upload_controller_spec.rb

@@ -1,30 +1,28 @@
 require 'spec_helper'
 
-describe Spotlight::Resources::UploadController, :type => :controller do
+describe Spotlight::Resources::UploadController, type: :controller do
   routes { Spotlight::Engine.routes }
   let(:exhibit) { FactoryGirl.create(:exhibit) }
 
-  describe "when not logged in" do
-
-    describe "POST create" do
-      it "should not be allowed" do
+  describe 'when not logged in' do
+    describe 'POST create' do
+      it 'does not be allowed' do
         post :create, exhibit_id: exhibit
         expect(response).to redirect_to main_app.new_user_session_path
       end
     end
   end
 
-
-  describe "when signed in as a curator" do
+  describe 'when signed in as a curator' do
     let(:user) { FactoryGirl.create(:exhibit_curator, exhibit: exhibit) }
-    before {sign_in user }
-    
-    describe "GET new" do
-      it "should be successful" do
-        expect(controller).to receive(:add_breadcrumb).with("Home", exhibit_path(exhibit))
-        expect(controller).to receive(:add_breadcrumb).with("Curation", exhibit_dashboard_path(exhibit))
-        expect(controller).to receive(:add_breadcrumb).with("Items", admin_exhibit_catalog_index_path(exhibit))
-        expect(controller).to receive(:add_breadcrumb).with("Add non-repository items", new_exhibit_resources_upload_path(exhibit))
+    before { sign_in user }
+
+    describe 'GET new' do
+      it 'is successful' do
+        expect(controller).to receive(:add_breadcrumb).with('Home', exhibit_path(exhibit))
+        expect(controller).to receive(:add_breadcrumb).with('Curation', exhibit_dashboard_path(exhibit))
+        expect(controller).to receive(:add_breadcrumb).with('Items', admin_exhibit_catalog_index_path(exhibit))
+        expect(controller).to receive(:add_breadcrumb).with('Add non-repository items', new_exhibit_resources_upload_path(exhibit))
         get :new, exhibit_id: exhibit
         expect(response).to be_successful
       end
@@ -32,32 +30,44 @@ describe Spotlight::Resources::UploadController, :type => :controller do
 
     describe 'POST csv_upload' do
       let(:csv) { fixture_file_upload(File.expand_path(File.join('..', 'fixtures', 'csv-upload-fixture.csv'), Rails.root), 'text/csv') }
-      let(:serialized_csv) {[
-        {"url"=>"http://lorempixel.com/800/500/", "full_title_tesim"=>"A random image", "spotlight_upload_description_tesim"=>"A random 800 by 500 image from lorempixel", "spotlight_upload_attribution_tesim"=>"lorempixel.com", "spotlight_upload_date_tesim"=>"2015"},
-        {"url"=>"http://lorempixel.com/900/600/", "full_title_tesim"=>"Another random image", "spotlight_upload_description_tesim"=>"A random 900 by 600 image from lorempixel", "spotlight_upload_attribution_tesim"=>"lorempixel.com", "spotlight_upload_date_tesim"=>"2014"}
-      ]}
+      let(:serialized_csv) do
+        [
+          {
+            'url' => 'http://lorempixel.com/800/500/',
+            'full_title_tesim' => 'A random image',
+            'spotlight_upload_description_tesim' => 'A random 800 by 500 image from lorempixel',
+            'spotlight_upload_attribution_tesim' => 'lorempixel.com',
+            'spotlight_upload_date_tesim' => '2015'
+          },
+          {
+            'url' => 'http://lorempixel.com/900/600/',
+            'full_title_tesim' => 'Another random image',
+            'spotlight_upload_description_tesim' => 'A random 900 by 600 image from lorempixel',
+            'spotlight_upload_attribution_tesim' => 'lorempixel.com',
+            'spotlight_upload_date_tesim' => '2014'
+          }
+        ]
+      end
       before do
-        request.env["HTTP_REFERER"] = 'http://test.host/'
+        request.env['HTTP_REFERER'] = 'http://test.host/'
       end
-      it 'should start an AddUploadsFromCSV job with the serialized CSV' do
+      it 'starts an AddUploadsFromCSV job with the serialized CSV' do
         expect(Spotlight::AddUploadsFromCSV).to receive(:perform_later).with(serialized_csv, exhibit, user).and_return(nil)
         post :csv_upload, exhibit_id: exhibit, resources_csv_upload: { url: csv }
       end
-      it 'should set the flash message' do
+      it 'sets the flash message' do
         expect(Spotlight::AddUploadsFromCSV).to receive(:perform_later).and_return(nil)
         post :csv_upload, exhibit_id: exhibit, resources_csv_upload: { url: csv }
         expect(flash[:notice]).to eq "'csv-upload-fixture.csv' has been uploaded.  An email will be sent to you once indexing is complete."
       end
-      it 'should redirect back' do
+      it 'redirects back' do
         expect(Spotlight::AddUploadsFromCSV).to receive(:perform_later).and_return(nil)
         post :csv_upload, exhibit_id: exhibit, resources_csv_upload: { url: csv }
         expect(response).to redirect_to :back
       end
-
     end
 
-    describe "POST create" do
-
+    describe 'POST create' do
       let(:blacklight_solr) { double }
 
       before do
@@ -65,23 +75,22 @@ describe Spotlight::Resources::UploadController, :type => :controller do
         allow_any_instance_of(Spotlight::Resource).to receive(:reindex)
         allow_any_instance_of(Spotlight::Resource).to receive(:blacklight_solr).and_return blacklight_solr
       end
-      it "create a Spotlight::Resources::Upload resource" do
+      it 'create a Spotlight::Resources::Upload resource' do
         expect(blacklight_solr).to receive(:commit)
-        post :create, exhibit_id: exhibit, resources_upload: { url: "url-data" }
+        post :create, exhibit_id: exhibit, resources_upload: { url: 'url-data' }
         expect(assigns[:resource]).to be_persisted
         expect(assigns[:resource]).to be_a(Spotlight::Resources::Upload)
       end
-      it 'should redirect to the item admin page' do
-        post :create, exhibit_id: exhibit, resources_upload: { url: "url-data" }
+      it 'redirects to the item admin page' do
+        post :create, exhibit_id: exhibit, resources_upload: { url: 'url-data' }
         expect(flash[:notice]).to eq 'Object uploaded successfully.'
         expect(response).to redirect_to admin_exhibit_catalog_index_path(exhibit, sort: :timestamp)
       end
-      it 'should redirect to the upload form when the add-and-continue parameter is present' do
-        post :create, exhibit_id: exhibit, "add-and-continue" => "true", resources_upload: { url: "url-data" }
+      it 'redirects to the upload form when the add-and-continue parameter is present' do
+        post :create, exhibit_id: exhibit, 'add-and-continue' => 'true', resources_upload: { url: 'url-data' }
         expect(flash[:notice]).to eq 'Object uploaded successfully.'
         expect(response).to redirect_to new_exhibit_resources_upload_path(exhibit)
       end
     end
   end
-
 end