blacklight-spotlight 0.4.1 → 0.5.0

data/spec/views/spotlight/catalog/edit.html.erb_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe "spotlight/catalog/edit.html.erb", :type => :view do
+describe 'spotlight/catalog/edit.html.erb', type: :view do
   let(:blacklight_config) { Blacklight::Configuration.new }
 
   let(:document) { stub_model(::SolrDocument) }
@@ -14,10 +14,7 @@ describe "spotlight/catalog/edit.html.erb", :type => :view do
     render
   end
 
-  it 'should render a document div' do
-    expect(rendered).to have_css "#document.document"
+  it 'renders a document div' do
+    expect(rendered).to have_css '#document.document'
   end
 end
-
-
-

data/spec/views/spotlight/catalog/new.html.erb_spec.rb

@@ -1,8 +1,8 @@
 require 'spec_helper'
 
-describe "spotlight/catalog/new.html.erb", :type => :view do
+describe 'spotlight/catalog/new.html.erb', type: :view do
   let(:blacklight_config) { Blacklight::Configuration.new }
-  let(:exhibit) { stub_model(Spotlight::Exhibit)}
+  let(:exhibit) { stub_model(Spotlight::Exhibit) }
 
   before do
     allow(view).to receive_messages(blacklight_config: blacklight_config)
@@ -11,16 +11,14 @@ describe "spotlight/catalog/new.html.erb", :type => :view do
     stub_template 'spotlight/shared/_curation_sidebar.html.erb' => ''
   end
 
-  it "should render the configured partials" do
-    allow(Spotlight::Engine.config).to receive(:new_resource_partials).and_return(['a', 'b', 'c'])
+  it 'renders the configured partials' do
+    allow(Spotlight::Engine.config).to receive(:new_resource_partials).and_return(%w(a b c))
     stub_template '_a.html.erb' => 'a_template'
     stub_template '_b.html.erb' => 'b_template'
     stub_template '_c.html.erb' => 'c_template'
     render
-    expect(rendered).to have_content "a_template"
-    expect(rendered).to have_content "b_template"
-    expect(rendered).to have_content "c_template"
+    expect(rendered).to have_content 'a_template'
+    expect(rendered).to have_content 'b_template'
+    expect(rendered).to have_content 'c_template'
   end
-
-  
-end
+end

data/spec/views/spotlight/contacts/edit.html.erb_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe "spotlight/contacts/edit.html.erb" do
+describe 'spotlight/contacts/edit.html.erb' do
   let(:exhibit) { FactoryGirl.create(:exhibit) }
 
   let(:contact) do
@@ -8,20 +8,20 @@ describe "spotlight/contacts/edit.html.erb" do
   end
 
   before do
-    allow(view).to receive(:exhibit_contacts_path).and_return("/exhibit/1/contacts")
-    allow(view).to receive(:exhibit_about_pages_path).and_return("/exhibit/admin/about")
+    allow(view).to receive(:exhibit_contacts_path).and_return('/exhibit/1/contacts')
+    allow(view).to receive(:exhibit_about_pages_path).and_return('/exhibit/admin/about')
     assign(:contact, contact)
     assign(:exhibit, exhibit)
     allow(view).to receive(:current_exhibit).and_return(exhibit)
   end
 
-  it "should have a photo field" do
+  it 'has a photo field' do
     render
-    expect(rendered).to have_content "Photo"
+    expect(rendered).to have_content 'Photo'
   end
 
-  it "should have a cropbox" do
+  it 'has a cropbox' do
     render
-    expect(rendered).to have_selector "#contact_avatar_cropbox"
+    expect(rendered).to have_selector '#contact_avatar_cropbox'
   end
-end
+end

data/spec/views/spotlight/dashboards/_analytics.html.erb_spec.rb

@@ -2,44 +2,44 @@ require 'spec_helper'
 
 describe 'spotlight/dashboards/_analytics.html.erb', type: :view do
   let(:current_exhibit) { FactoryGirl.create(:exhibit) }
-  let(:ga_data) { OpenStruct.new(pageviews: 1, users: 2, sessions: 3)}
-  let(:page_data) { [ OpenStruct.new(pageTitle: "title", pagePath: "/path", pageviews: '123') ]}
+  let(:ga_data) { OpenStruct.new(pageviews: 1, users: 2, sessions: 3) }
+  let(:page_data) { [OpenStruct.new(pageTitle: 'title', pagePath: '/path', pageviews: '123')] }
   before do
-    allow(view).to receive_messages(current_exhibit: current_exhibit, exhibit_root_path: "/some/path")
+    allow(view).to receive_messages(current_exhibit: current_exhibit, exhibit_root_path: '/some/path')
     allow(Spotlight::Analytics::Ga).to receive(:enabled?).and_return(true)
     allow(current_exhibit).to receive(:analytics).and_return(ga_data)
     allow(current_exhibit).to receive(:page_analytics).and_return(page_data)
   end
 
-  it "should use the exhibit_root_path for analytics" do
-    expect(current_exhibit).to receive(:analytics).with(1.month, "/some/path").and_return(ga_data)
-    expect(current_exhibit).to receive(:page_analytics).with(1.month, "/some/path").and_return(page_data)
+  it 'uses the exhibit_root_path for analytics' do
+    expect(current_exhibit).to receive(:analytics).with(1.month, '/some/path').and_return(ga_data)
+    expect(current_exhibit).to receive(:page_analytics).with(1.month, '/some/path').and_return(page_data)
     render
   end
-  
-  it "should have header" do
+
+  it 'has header' do
     render
-    expect(rendered).to have_content "User Activity Over the Past Month"
+    expect(rendered).to have_content 'User Activity Over the Past Month'
   end
 
-  it "should have metric labels" do
+  it 'has metric labels' do
     render
-    expect(rendered).to have_content "visitors"
-    expect(rendered).to have_content "unique visits"
-    expect(rendered).to have_content "page views"
+    expect(rendered).to have_content 'visitors'
+    expect(rendered).to have_content 'unique visits'
+    expect(rendered).to have_content 'page views'
   end
 
-  it "should have metric values" do
+  it 'has metric values' do
     render
-    expect(rendered).to have_selector ".value.pageviews", text: 1
-    expect(rendered).to have_selector ".value.users", text: 2
-    expect(rendered).to have_selector ".value.sessions", text: 3
+    expect(rendered).to have_selector '.value.pageviews', text: 1
+    expect(rendered).to have_selector '.value.users', text: 2
+    expect(rendered).to have_selector '.value.sessions', text: 3
   end
 
-  it "should have page-level data" do
+  it 'has page-level data' do
     render
-    expect(rendered).to have_content "Most popular pages"
-    expect(rendered).to have_link "title", href: "/path"
-    expect(rendered).to have_content "123"
+    expect(rendered).to have_content 'Most popular pages'
+    expect(rendered).to have_link 'title', href: '/path'
+    expect(rendered).to have_content '123'
   end
-end
+end

data/spec/views/spotlight/exhibits/edit.html.erb_spec.rb

@@ -1,8 +1,8 @@
 require 'spec_helper'
 
 module Spotlight
-  describe "spotlight/exhibits/edit", :type => :view do
-    let(:exhibit) { FactoryGirl.create(:exhibit) } 
+  describe 'spotlight/exhibits/edit', type: :view do
+    let(:exhibit) { FactoryGirl.create(:exhibit) }
     before do
       assign(:exhibit, exhibit)
       allow(view).to receive_messages(current_exhibit: exhibit)
@@ -11,15 +11,14 @@ module Spotlight
       allow(view).to receive_messages(get_exhibit_path: '/')
     end
 
-    it "renders the edit page form" do
+    it 'renders the edit page form' do
       render
 
       expect(rendered).to have_selector "form[action=\"#{spotlight.exhibit_path(exhibit)}\"]"
-      expect(rendered).to have_selector ".callout.callout-danger.row"
-      expect(rendered).to have_content "This action is irreversible"
-      expect(rendered).to have_link "Export data", href: spotlight.import_exhibit_path(exhibit)
-      expect(rendered).to have_button "Import data"
+      expect(rendered).to have_selector '.callout.callout-danger.row'
+      expect(rendered).to have_content 'This action is irreversible'
+      expect(rendered).to have_link 'Export data', href: spotlight.import_exhibit_path(exhibit)
+      expect(rendered).to have_button 'Import data'
     end
   end
 end
-

data/spec/views/spotlight/feature_pages/_empty.html.erb_spec.rb

@@ -1,24 +1,24 @@
 require 'spec_helper'
 
-describe "spotlight/feature_pages/_empty.html.erb", :type => :view do
+describe 'spotlight/feature_pages/_empty.html.erb', type: :view do
   let(:can?) { false }
   before do
     allow(view).to receive_messages(can?: can?)
     render
   end
   describe 'when a user cannot edit' do
-    it 'should not render an ordered list of steps' do
+    it 'does not render an ordered list of steps' do
       expect(rendered).to_not have_css('ol')
     end
   end
   describe 'when a user can edit' do
     let(:can?) { true }
-    
-    it 'should render a heading' do
+
+    it 'renders a heading' do
       expect(rendered).to have_css('h2', text: 'Building this feature page')
     end
 
-    it 'should render an ordered list of steps' do
+    it 'renders an ordered list of steps' do
       expect(rendered).to have_css('ol li', count: 6)
     end
   end

data/spec/views/spotlight/feature_pages/_sidebar.html.erb_spec.rb

@@ -1,46 +1,44 @@
 require 'spec_helper'
 
-describe "spotlight/feature_pages/_sidebar.html.erb", :type => :view do
+describe 'spotlight/feature_pages/_sidebar.html.erb', type: :view do
   let(:exhibit) { FactoryGirl.create(:exhibit) }
-  let!(:parent1) { FactoryGirl.create(:feature_page, exhibit: exhibit, title: "Parent Page") }
-  let!(:parent2) { FactoryGirl.create(:feature_page, exhibit: exhibit, title: "Two") }
-  let!(:child1) { FactoryGirl.create(:feature_page, exhibit: exhibit, parent_page: parent1, title: "Three", weight: 4) }
-  let!(:child2) { FactoryGirl.create(:feature_page, exhibit: exhibit, parent_page: parent2, title: "Four") }
-  let!(:child3) { FactoryGirl.create(:feature_page, exhibit: exhibit, parent_page: parent1, title: "Five", weight: 2) }
-  let!(:child4) { FactoryGirl.create(:feature_page, exhibit: exhibit, parent_page: parent1, title: "Six", published: false) }
-  let!(:child5) { FactoryGirl.create(:feature_page, exhibit: FactoryGirl.create(:exhibit), title: "Seven") }
-  
+  let!(:parent1) { FactoryGirl.create(:feature_page, exhibit: exhibit, title: 'Parent Page') }
+  let!(:parent2) { FactoryGirl.create(:feature_page, exhibit: exhibit, title: 'Two') }
+  let!(:child1) { FactoryGirl.create(:feature_page, exhibit: exhibit, parent_page: parent1, title: 'Three', weight: 4) }
+  let!(:child2) { FactoryGirl.create(:feature_page, exhibit: exhibit, parent_page: parent2, title: 'Four') }
+  let!(:child3) { FactoryGirl.create(:feature_page, exhibit: exhibit, parent_page: parent1, title: 'Five', weight: 2) }
+  let!(:child4) { FactoryGirl.create(:feature_page, exhibit: exhibit, parent_page: parent1, title: 'Six', published: false) }
+  let!(:child5) { FactoryGirl.create(:feature_page, exhibit: FactoryGirl.create(:exhibit), title: 'Seven') }
+
   before do
     allow(view).to receive_messages(current_exhibit: parent1.exhibit)
     allow(view).to receive_messages(feature_page_path: '/feature/9')
     assign(:exhibit, parent1.exhibit)
   end
 
-  it "renders a list of pages for a parent page" do
+  it 'renders a list of pages for a parent page' do
     assign(:page, parent1)
     allow(view).to receive(:current_page?).and_return(true, false)
     render
     # Checking that they are sorted accoding to weight
-    expect(rendered).to have_selector "li.active h4", text: "Parent Page"
-    expect(rendered).to have_selector "#sidebar ol.sidenav li:nth-child(1) a", text: "Five"
-    expect(rendered).to have_selector "#sidebar ol.sidenav li:nth-child(2) a", text: "Three"
-    expect(rendered).to have_selector "li h4 a", text: "Two" # a different parent page
-    expect(rendered).to have_link "Four" # different parent
-    expect(rendered).not_to have_link "Six" # not published 
-    expect(rendered).not_to have_link "Seven" # different exhibit 
+    expect(rendered).to have_selector 'li.active h4', text: 'Parent Page'
+    expect(rendered).to have_selector '#sidebar ol.sidenav li:nth-child(1) a', text: 'Five'
+    expect(rendered).to have_selector '#sidebar ol.sidenav li:nth-child(2) a', text: 'Three'
+    expect(rendered).to have_selector 'li h4 a', text: 'Two' # a different parent page
+    expect(rendered).to have_link 'Four' # different parent
+    expect(rendered).not_to have_link 'Six' # not published
+    expect(rendered).not_to have_link 'Seven' # different exhibit
   end
 
-  it "renders a list of pages from a child page" do
+  it 'renders a list of pages from a child page' do
     assign(:page, child1)
     render
     # Checking that they are sorted accoding to weight
-    expect(rendered).to have_selector "h4", text: "Parent Page"
-    expect(rendered).to have_selector "#sidebar ol.sidenav li:nth-child(1) a", text: "Five"
-    expect(rendered).to have_selector "#sidebar ol.sidenav li:nth-child(2) a", text: "Three"
-    expect(rendered).to have_content "Two" # not selected page
-    expect(rendered).to have_link "Four" # different parent
-    expect(rendered).not_to have_link "Six" # not published 
+    expect(rendered).to have_selector 'h4', text: 'Parent Page'
+    expect(rendered).to have_selector '#sidebar ol.sidenav li:nth-child(1) a', text: 'Five'
+    expect(rendered).to have_selector '#sidebar ol.sidenav li:nth-child(2) a', text: 'Three'
+    expect(rendered).to have_content 'Two' # not selected page
+    expect(rendered).to have_link 'Four' # different parent
+    expect(rendered).not_to have_link 'Six' # not published
   end
 end
-
-

data/spec/views/spotlight/home_pages/_empty.html.erb_spec.rb

@@ -1,21 +1,25 @@
 require 'spec_helper'
 
-describe "spotlight/home_pages/_empty.html.erb", :type => :view do
+describe 'spotlight/home_pages/_empty.html.erb', type: :view do
   describe 'resource providers' do
     before do
-      allow(view).to receive_messages(current_exhibit: FactoryGirl.create(:exhibit))
-      allow(view).to receive_messages(can?: true)
-      allow(view).to receive_messages(edit_exhibit_path: '/', edit_exhibit_appearance_path: '/', exhibit_roles_path: '/', admin_exhibit_catalog_index_path: '/', exhibit_edit_metadata_path: '/', exhibit_edit_facets_path: '/')
+      allow(view).to receive_messages(current_exhibit: FactoryGirl.create(:exhibit),
+                                      can?: true,
+                                      edit_exhibit_path: '/',
+                                      edit_exhibit_appearance_path: '/',
+                                      exhibit_roles_path: '/',
+                                      admin_exhibit_catalog_index_path: '/',
+                                      edit_exhibit_metadata_configuration_path: '/',
+                                      edit_exhibit_search_configuration_path: '/')
     end
-    it 'should have a list item with a link to add items when there are no resource providers configured' do
+    it 'has a list item with a link to add items when there are no resource providers configured' do
       render
-      expect(rendered).to have_css('li a', text: "Curation > Items")
+      expect(rendered).to have_css('li a', text: 'Curation > Items')
     end
-    it 'should not have a list item with a link to add items when there are resource providers configured' do
+    it 'does not have a list item with a link to add items when there are resource providers configured' do
       allow(Spotlight::Engine.config).to receive_messages(resource_providers: [true])
       render
-      expect(rendered).to_not have_css('li a', text: "Curation > Items")
+      expect(rendered).to_not have_css('li a', text: 'Curation > Items')
     end
-    
   end
 end

data/spec/views/spotlight/home_pages/_sidebar.html.erb_spec.rb

@@ -1,12 +1,12 @@
 require 'spec_helper'
 
-describe "spotlight/home_pages/_sidebar.html.erb", :type => :view do
+describe 'spotlight/home_pages/_sidebar.html.erb', type: :view do
   before do
-    stub_template 'catalog/_search_sidebar.html.erb' => "Sidebar"
+    stub_template 'catalog/_search_sidebar.html.erb' => 'Search Sidebar'
   end
 
-  it { render; expect(rendered).to match "Sidebar"  }
-
+  it 'has a search sidebar' do
+    render
+    expect(rendered).to match 'Search Sidebar'
+  end
 end
-
-

data/spec/views/spotlight/metadata_configurations/_metadata_field.html.erb_spec.rb

@@ -0,0 +1,26 @@
+require 'spec_helper'
+
+module Spotlight
+  describe 'spotlight/metadata_configurations/_metadata_field', type: :view do
+    let(:exhibit) { FactoryGirl.create(:exhibit) }
+    let(:p) { 'spotlight/metadata_configurations/metadata_field.html.erb' }
+    before do
+      assign(:exhibit, exhibit)
+      assign(:blacklight_configuration, exhibit.blacklight_configuration)
+      allow(view).to receive_messages(
+        current_exhibit: exhibit,
+        blacklight_config: exhibit.blacklight_configuration,
+        available_view_fields: { some_view_type: 1, another_view_type: 2 },
+        select_deselect_button: nil)
+    end
+
+    let(:facet_field) { Blacklight::Configuration::FacetField.new }
+    let(:builder) { ActionView::Helpers::FormBuilder.new 'z', nil, view, {} }
+
+    it 'uses the index_field_label helper to render the label' do
+      allow(view).to receive(:index_field_label).with(nil, 'some_key').and_return 'Some label'
+      render partial: p, locals: { key: 'some_key', config: facet_field, f: builder }
+      expect(rendered).to have_selector '.field-label', text: 'Some label'
+    end
+  end
+end

data/spec/views/spotlight/metadata_configurations/edit.html.erb_spec.rb

@@ -0,0 +1,22 @@
+require 'spec_helper'
+
+module Spotlight
+  describe 'spotlight/metadata_configurations/edit', type: :view do
+    let(:exhibit) { FactoryGirl.create(:exhibit) }
+    before do
+      assign(:exhibit, exhibit)
+      assign(:blacklight_configuration, exhibit.blacklight_configuration)
+      allow(view).to receive_messages(
+        current_exhibit: exhibit,
+        blacklight_config: exhibit.blacklight_configuration,
+        available_view_fields: { some_view_type: 1, another_view_type: 2 },
+        select_deselect_button: nil)
+    end
+
+    it 'has columns for the available view types' do
+      render
+      expect(rendered).to have_selector 'th', text: 'Some View Type'
+      expect(rendered).to have_selector 'th', text: 'Another View Type'
+    end
+  end
+end

data/spec/views/spotlight/pages/edit.html.erb_spec.rb

@@ -1,38 +1,38 @@
 require 'spec_helper'
 
 module Spotlight
-  describe "spotlight/pages/edit", :type => :view do
-    let(:exhibit) { stub_model(Exhibit) } 
+  describe 'spotlight/pages/edit', type: :view do
+    let(:exhibit) { stub_model(Exhibit) }
     let(:page) { stub_model(FeaturePage, exhibit: exhibit) }
     before do
       assign(:page, page)
       allow(view).to receive_messages(default_thumbnail_jcrop_options: {}, available_index_fields: [], available_view_fields: [])
     end
 
-    it "renders the edit page form" do
+    it 'renders the edit page form' do
       render
 
       # Run the generator again with the --webrat flag if you want to use webrat matchers
-      assert_select "form[action=?][method=?]", spotlight.exhibit_feature_page_path(page.exhibit, page), "post" do
-        assert_select "input#feature_page_title[name=?]", "feature_page[title]"
-        assert_select "textarea#feature_page_content[name=?]", "feature_page[content]"
+      assert_select 'form[action=?][method=?]', spotlight.exhibit_feature_page_path(page.exhibit, page), 'post' do
+        assert_select 'input#feature_page_title[name=?]', 'feature_page[title]'
+        assert_select 'textarea#feature_page_content[name=?]', 'feature_page[content]'
       end
     end
 
-    describe "locks" do
+    describe 'locks' do
       let(:lock) { Lock.create! on: page }
 
       before do
         page.lock = lock
       end
 
-      it "renders a lock" do
+      it 'renders a lock' do
         render
 
         expect(rendered).to have_css '.alert-lock'
       end
 
-      it "should not render an old lock" do
+      it 'does not render an old lock' do
         lock.created_at -= 1.day
 
         render
@@ -40,7 +40,7 @@ module Spotlight
         expect(rendered).not_to have_css '.alert-lock'
       end
 
-      it "should not render a lock held by the current session" do
+      it 'does not render a lock held by the current session' do
         lock.current_session!
 
         render
@@ -48,20 +48,20 @@ module Spotlight
         expect(rendered).not_to have_css '.alert-lock'
       end
 
-      it "should attach a data-lock attribute to the cancel button" do
+      it 'attaches a data-lock attribute to the cancel button' do
         lock.current_session!
 
         render
 
-        expect(rendered).to have_link "Cancel"
-        expect(rendered).to have_css "a[data-lock=\"#{url_for([spotlight, page.exhibit, lock])}\"]", text: "Cancel"
+        expect(rendered).to have_link 'Cancel'
+        expect(rendered).to have_css "a[data-lock=\"#{url_for([spotlight, page.exhibit, lock])}\"]", text: 'Cancel'
       end
 
-      it "should not have data-lock attribute if the lock doesn't belong to this session" do
+      it "does not have data-lock attribute if the lock doesn't belong to this session" do
         render
 
-        expect(rendered).to have_link "Cancel"
-        expect(rendered).not_to have_css "a[data-lock]", text: "Cancel"
+        expect(rendered).to have_link 'Cancel'
+        expect(rendered).not_to have_css 'a[data-lock]', text: 'Cancel'
       end
     end
   end